fix Klocwork warning of unintialized data members, unneeded assignment & unreachable...

[platform/core/uifw/dali-toolkit.git] / optional / dali-toolkit / public-api / shader-effects / distance-field-effect.h

diff --git a/optional/dali-toolkit/public-api/shader-effects/distance-field-effect.h b/optional/dali-toolkit/public-api/shader-effects/distance-field-effect.h
index ea034af..9adf92b 100644 (file)
--- a/optional/dali-toolkit/public-api/shader-effects/distance-field-effect.h
+++ b/optional/dali-toolkit/public-api/shader-effects/distance-field-effect.h
@@ -18,10 +18,10 @@
  *
  */
 
-// INTERNAL INCLUDES
-#include <dali/dali.h>
+// EXTERNAL INCLUDES
+#include <dali/public-api/shader-effects/shader-effect.h>
 
-namespace Dali DALI_IMPORT_API
+namespace Dali
 {
 
 namespace Toolkit
@@ -30,7 +30,7 @@ namespace Toolkit
 /**
  * DistanceFieldEffect is a custom shader effect to achieve distance field on Image actors
  */
-class DistanceFieldEffect : public ShaderEffect
+class DALI_IMPORT_API DistanceFieldEffect : public ShaderEffect
 {
 public:
 
@@ -41,9 +41,11 @@ public:
   DistanceFieldEffect();
 
   /**
-   * Virtual destructor.
+   * @brief Destructor
+   *
+   * This is non-virtual since derived Handle types must not contain data or virtual methods.
    */
-  virtual ~DistanceFieldEffect();
+  ~DistanceFieldEffect();
 
   /**
    * Create an initialized DistanceFieldEffect.
@@ -186,7 +188,7 @@ public:
   const std::string& GetGlowBoundaryPropertyName() const;
 
 private:
-  DistanceFieldEffect(ShaderEffect handle);
+  DALI_INTERNAL DistanceFieldEffect(ShaderEffect handle);
 
 };