btrfs-progs: dump-tree: fix crash on unrecognized tree id
[platform/upstream/btrfs-progs.git] / mkfs.c
diff --git a/mkfs.c b/mkfs.c
index ee5a30d..2b6fc64 100644 (file)
--- a/mkfs.c
+++ b/mkfs.c
@@ -79,7 +79,8 @@ static int create_metadata_block_groups(struct btrfs_root *root, int mixed,
                                     BTRFS_FIRST_CHUNK_TREE_OBJECTID,
                                     0, BTRFS_MKFS_SYSTEM_GROUP_SIZE);
        allocation->system += BTRFS_MKFS_SYSTEM_GROUP_SIZE;
-       BUG_ON(ret);
+       if (ret)
+               return ret;
 
        if (mixed) {
                ret = btrfs_alloc_chunk(trans, root->fs_info->extent_root,
@@ -90,13 +91,15 @@ static int create_metadata_block_groups(struct btrfs_root *root, int mixed,
                        error("no space to allocate data/metadata chunk");
                        goto err;
                }
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
                ret = btrfs_make_block_group(trans, root, 0,
                                             BTRFS_BLOCK_GROUP_METADATA |
                                             BTRFS_BLOCK_GROUP_DATA,
                                             BTRFS_FIRST_CHUNK_TREE_OBJECTID,
                                             chunk_start, chunk_size);
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
                allocation->mixed += chunk_size;
        } else {
                ret = btrfs_alloc_chunk(trans, root->fs_info->extent_root,
@@ -106,17 +109,19 @@ static int create_metadata_block_groups(struct btrfs_root *root, int mixed,
                        error("no space to allocate metadata chunk");
                        goto err;
                }
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
                ret = btrfs_make_block_group(trans, root, 0,
                                             BTRFS_BLOCK_GROUP_METADATA,
                                             BTRFS_FIRST_CHUNK_TREE_OBJECTID,
                                             chunk_start, chunk_size);
                allocation->metadata += chunk_size;
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
        }
 
        root->fs_info->system_allocs = 0;
-       btrfs_commit_transaction(trans, root);
+       ret = btrfs_commit_transaction(trans, root);
 
 err:
        return ret;
@@ -138,13 +143,15 @@ static int create_data_block_groups(struct btrfs_trans_handle *trans,
                        error("no space to allocate data chunk");
                        goto err;
                }
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
                ret = btrfs_make_block_group(trans, root, 0,
                                             BTRFS_BLOCK_GROUP_DATA,
                                             BTRFS_FIRST_CHUNK_TREE_OBJECTID,
                                             chunk_start, chunk_size);
                allocation->data += chunk_size;
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
        }
 
 err:
@@ -183,32 +190,50 @@ err:
        return ret;
 }
 
-static void __recow_root(struct btrfs_trans_handle *trans,
+static int __recow_root(struct btrfs_trans_handle *trans,
                         struct btrfs_root *root)
 {
-       int ret;
        struct extent_buffer *tmp;
+       int ret;
 
        if (trans->transid != btrfs_root_generation(&root->root_item)) {
                extent_buffer_get(root->node);
                ret = __btrfs_cow_block(trans, root, root->node,
                                        NULL, 0, &tmp, 0, 0);
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
                free_extent_buffer(tmp);
        }
+
+       return 0;
 }
 
-static void recow_roots(struct btrfs_trans_handle *trans,
+static int recow_roots(struct btrfs_trans_handle *trans,
                       struct btrfs_root *root)
 {
        struct btrfs_fs_info *info = root->fs_info;
+       int ret;
 
-       __recow_root(trans, info->fs_root);
-       __recow_root(trans, info->tree_root);
-       __recow_root(trans, info->extent_root);
-       __recow_root(trans, info->chunk_root);
-       __recow_root(trans, info->dev_root);
-       __recow_root(trans, info->csum_root);
+       ret = __recow_root(trans, info->fs_root);
+       if (ret)
+               return ret;
+       ret = __recow_root(trans, info->tree_root);
+       if (ret)
+               return ret;
+       ret = __recow_root(trans, info->extent_root);
+       if (ret)
+               return ret;
+       ret = __recow_root(trans, info->chunk_root);
+       if (ret)
+               return ret;
+       ret = __recow_root(trans, info->dev_root);
+       if (ret)
+               return ret;
+       ret = __recow_root(trans, info->csum_root);
+       if (ret)
+               return ret;
+
+       return 0;
 }
 
 static int create_one_raid_group(struct btrfs_trans_handle *trans,
@@ -226,23 +251,29 @@ static int create_one_raid_group(struct btrfs_trans_handle *trans,
                error("not enough free space to allocate chunk");
                exit(1);
        }
-       BUG_ON(ret);
+       if (ret)
+               return ret;
+
        ret = btrfs_make_block_group(trans, root->fs_info->extent_root, 0,
                                     type, BTRFS_FIRST_CHUNK_TREE_OBJECTID,
                                     chunk_start, chunk_size);
-       if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == BTRFS_BLOCK_GROUP_DATA)
+
+       type &= BTRFS_BLOCK_GROUP_TYPE_MASK;
+       if (type == BTRFS_BLOCK_GROUP_DATA) {
                allocation->data += chunk_size;
-       else if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == BTRFS_BLOCK_GROUP_METADATA)
+       } else if (type == BTRFS_BLOCK_GROUP_METADATA) {
                allocation->metadata += chunk_size;
-       else if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == BTRFS_BLOCK_GROUP_SYSTEM)
+       } else if (type == BTRFS_BLOCK_GROUP_SYSTEM) {
                allocation->system += chunk_size;
-       else if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) ==
-                       (BTRFS_BLOCK_GROUP_METADATA|BTRFS_BLOCK_GROUP_DATA))
+       } else if (type ==
+                       (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_DATA)) {
                allocation->mixed += chunk_size;
-       else
-               BUG_ON(1);
+       } else {
+               error("unrecognized profile type: 0x%llx",
+                               (unsigned long long)type);
+               ret = -EINVAL;
+       }
 
-       BUG_ON(ret);
        return ret;
 }
 
@@ -259,25 +290,28 @@ static int create_raid_groups(struct btrfs_trans_handle *trans,
                ret = create_one_raid_group(trans, root,
                                            BTRFS_BLOCK_GROUP_SYSTEM |
                                            metadata_profile, allocation);
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
 
                if (mixed)
                        meta_flags |= BTRFS_BLOCK_GROUP_DATA;
 
                ret = create_one_raid_group(trans, root, meta_flags |
                                            metadata_profile, allocation);
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
 
        }
        if (!mixed && data_profile) {
                ret = create_one_raid_group(trans, root,
                                            BTRFS_BLOCK_GROUP_DATA |
                                            data_profile, allocation);
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
        }
-       recow_roots(trans, root);
+       ret = recow_roots(trans, root);
 
-       return 0;
+       return ret;
 }
 
 static int create_data_reloc_tree(struct btrfs_trans_handle *trans,
@@ -290,7 +324,8 @@ static int create_data_reloc_tree(struct btrfs_trans_handle *trans,
        int ret;
 
        ret = btrfs_copy_root(trans, root, root->node, &tmp, objectid);
-       BUG_ON(ret);
+       if (ret)
+               return ret;
 
        memcpy(&root_item, &root->root_item, sizeof(root_item));
        btrfs_set_root_bytenr(&root_item, tmp->start);
@@ -303,40 +338,33 @@ static int create_data_reloc_tree(struct btrfs_trans_handle *trans,
        location.offset = 0;
        ret = btrfs_insert_root(trans, root->fs_info->tree_root,
                                &location, &root_item);
-       BUG_ON(ret);
-       return 0;
+
+       return ret;
 }
 
 static void print_usage(int ret)
 {
-       fprintf(stderr, "usage: mkfs.btrfs [options] dev [ dev ... ]\n");
-       fprintf(stderr, "options:\n");
-       fprintf(stderr, "\t-A|--alloc-start START  the offset to start the FS\n");
-       fprintf(stderr, "\t-b|--byte-count SIZE    total number of bytes in the FS\n");
-       fprintf(stderr, "\t-d|--data PROFILE       data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n");
-       fprintf(stderr, "\t-f|--force              force overwrite of existing filesystem\n");
-       fprintf(stderr, "\t-l|--leafsize SIZE      deprecated, alias for nodesize\n");
-       fprintf(stderr, "\t-L|--label LABEL        set a label\n");
-       fprintf(stderr, "\t-m|--metadata PROFILE   metadata profile, values like data profile\n");
-       fprintf(stderr, "\t-M|--mixed              mix metadata and data together\n");
-       fprintf(stderr, "\t-n|--nodesize SIZE      size of btree nodes\n");
-       fprintf(stderr, "\t-s|--sectorsize SIZE    min block allocation (may not mountable by current kernel)\n");
-       fprintf(stderr, "\t-r|--rootdir DIR        the source directory\n");
-       fprintf(stderr, "\t-K|--nodiscard          do not perform whole device TRIM\n");
-       fprintf(stderr, "\t-O|--features LIST      comma separated list of filesystem features, use '-O list-all' to list features\n");
-       fprintf(stderr, "\t-U|--uuid UUID          specify the filesystem UUID\n");
-       fprintf(stderr, "\t-q|--quiet              no messages except errors\n");
-       fprintf(stderr, "\t-V|--version            print the mkfs.btrfs version and exit\n");
+       printf("usage: mkfs.btrfs [options] dev [ dev ... ]\n");
+       printf("options:\n");
+       printf("\t-A|--alloc-start START  the offset to start the FS\n");
+       printf("\t-b|--byte-count SIZE    total number of bytes in the FS\n");
+       printf("\t-d|--data PROFILE       data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n");
+       printf("\t-f|--force              force overwrite of existing filesystem\n");
+       printf("\t-l|--leafsize SIZE      deprecated, alias for nodesize\n");
+       printf("\t-L|--label LABEL        set a label\n");
+       printf("\t-m|--metadata PROFILE   metadata profile, values like data profile\n");
+       printf("\t-M|--mixed              mix metadata and data together\n");
+       printf("\t-n|--nodesize SIZE      size of btree nodes\n");
+       printf("\t-s|--sectorsize SIZE    min block allocation (may not mountable by current kernel)\n");
+       printf("\t-r|--rootdir DIR        the source directory\n");
+       printf("\t-K|--nodiscard          do not perform whole device TRIM\n");
+       printf("\t-O|--features LIST      comma separated list of filesystem features, use '-O list-all' to list features\n");
+       printf("\t-U|--uuid UUID          specify the filesystem UUID\n");
+       printf("\t-q|--quiet              no messages except errors\n");
+       printf("\t-V|--version            print the mkfs.btrfs version and exit\n");
        exit(ret);
 }
 
-static void print_version(void) __attribute__((noreturn));
-static void print_version(void)
-{
-       fprintf(stderr, "mkfs.btrfs, part of %s\n", PACKAGE_STRING);
-       exit(0);
-}
-
 static u64 parse_profile(char *s)
 {
        if (strcasecmp(s, "raid0") == 0) {
@@ -387,7 +415,7 @@ static int add_directory_items(struct btrfs_trans_handle *trans,
 
        location.objectid = objectid;
        location.offset = 0;
-       btrfs_set_key_type(&location, BTRFS_INODE_ITEM_KEY);
+       location.type = BTRFS_INODE_ITEM_KEY;
 
        if (S_ISDIR(st->st_mode))
                filetype = BTRFS_FT_DIR;
@@ -511,7 +539,6 @@ static int add_inode_items(struct btrfs_trans_handle *trans,
                           int dir_index_cnt, struct btrfs_inode_item *inode_ret)
 {
        int ret;
-       struct btrfs_key inode_key;
        struct btrfs_inode_item btrfs_inode;
        u64 objectid;
        u64 inode_size = 0;
@@ -524,10 +551,6 @@ static int add_inode_items(struct btrfs_trans_handle *trans,
                btrfs_set_stack_inode_size(&btrfs_inode, inode_size);
        }
 
-       inode_key.objectid = objectid;
-       inode_key.offset = 0;
-       btrfs_set_key_type(&inode_key, BTRFS_INODE_ITEM_KEY);
-
        ret = btrfs_insert_inode(trans, root, objectid, &btrfs_inode);
 
        *inode_ret = btrfs_inode;
@@ -807,7 +830,7 @@ static int traverse_directory(struct btrfs_trans_handle *trans,
 
        root_dir_key.objectid = btrfs_root_dirid(&root->root_item);
        root_dir_key.offset = 0;
-       btrfs_set_key_type(&root_dir_key, BTRFS_INODE_ITEM_KEY);
+       root_dir_key.type = BTRFS_INODE_ITEM_KEY;
        ret = btrfs_lookup_inode(trans, root, &path, &root_dir_key, 1);
        if (ret) {
                error("failed to lookup root dir: %d", ret);
@@ -875,7 +898,13 @@ static int traverse_directory(struct btrfs_trans_handle *trans,
                                              parent_inum, dir_index_cnt,
                                              &cur_inode);
                        if (ret == -EEXIST) {
-                               BUG_ON(st.st_nlink <= 1);
+                               if (st.st_nlink <= 1) {
+                                       error(
+                       "item %s already exists but has wrong st_nlink %lu <= 1",
+                                               cur_file->d_name,
+                                               (unsigned long)st.st_nlink);
+                                       goto fail;
+                               }
                                continue;
                        }
                        if (ret) {
@@ -943,15 +972,6 @@ fail_no_dir:
        goto out;
 }
 
-static int open_target(char *output_name)
-{
-       int output_fd;
-       output_fd = open(output_name, O_CREAT | O_RDWR,
-                        S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH);
-
-       return output_fd;
-}
-
 static int create_chunks(struct btrfs_trans_handle *trans,
                         struct btrfs_root *root, u64 num_of_meta_chunks,
                         u64 size_of_data,
@@ -968,12 +988,14 @@ static int create_chunks(struct btrfs_trans_handle *trans,
        for (i = 0; i < num_of_meta_chunks; i++) {
                ret = btrfs_alloc_chunk(trans, root->fs_info->extent_root,
                                        &chunk_start, &chunk_size, meta_type);
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
                ret = btrfs_make_block_group(trans, root->fs_info->extent_root, 0,
                                             meta_type, BTRFS_FIRST_CHUNK_TREE_OBJECTID,
                                             chunk_start, chunk_size);
                allocation->metadata += chunk_size;
-               BUG_ON(ret);
+               if (ret)
+                       return ret;
                set_extent_dirty(&root->fs_info->free_space_cache,
                                 chunk_start, chunk_start + chunk_size - 1, 0);
        }
@@ -983,12 +1005,14 @@ static int create_chunks(struct btrfs_trans_handle *trans,
 
        ret = btrfs_alloc_data_chunk(trans, root->fs_info->extent_root,
                                     &chunk_start, size_of_data, data_type, 0);
-       BUG_ON(ret);
+       if (ret)
+               return ret;
        ret = btrfs_make_block_group(trans, root->fs_info->extent_root, 0,
                                     data_type, BTRFS_FIRST_CHUNK_TREE_OBJECTID,
                                     chunk_start, size_of_data);
        allocation->data += size_of_data;
-       BUG_ON(ret);
+       if (ret)
+               return ret;
        set_extent_dirty(&root->fs_info->free_space_cache,
                         chunk_start, chunk_start + size_of_data - 1, 0);
        return ret;
@@ -998,16 +1022,14 @@ static int make_image(char *source_dir, struct btrfs_root *root, int out_fd)
 {
        int ret;
        struct btrfs_trans_handle *trans;
-
        struct stat root_st;
-
        struct directory_name_entry dir_head;
-
        struct directory_name_entry *dir_entry = NULL;
 
        ret = lstat(source_dir, &root_st);
        if (ret) {
                error("unable to lstat %s: %s", source_dir, strerror(errno));
+               ret = -errno;
                goto out;
        }
 
@@ -1019,7 +1041,11 @@ static int make_image(char *source_dir, struct btrfs_root *root, int out_fd)
                error("unable to traverse directory %s: %d", source_dir, ret);
                goto fail;
        }
-       btrfs_commit_transaction(trans, root);
+       ret = btrfs_commit_transaction(trans, root);
+       if (ret) {
+               error("transaction commit failed: %d", ret);
+               goto out;
+       }
 
        if (verbose)
                printf("Making image is completed.\n");
@@ -1032,8 +1058,7 @@ fail:
                free(dir_entry);
        }
 out:
-       fprintf(stderr, "Making image is aborted.\n");
-       return -1;
+       return ret;
 }
 
 /*
@@ -1155,13 +1180,13 @@ static int is_ssd(const char *file)
                return 0;
        }
 
-       if (read(fd, &rotational, sizeof(char)) < sizeof(char)) {
+       if (read(fd, &rotational, 1) < 1) {
                close(fd);
                return 0;
        }
        close(fd);
 
-       return !atoi((const char *)&rotational);
+       return rotational == '0';
 }
 
 static int _cmp_device_by_id(void *priv, struct list_head *a,
@@ -1365,6 +1390,7 @@ int main(int argc, char **argv)
 {
        char *file;
        struct btrfs_root *root;
+       struct btrfs_fs_info *fs_info;
        struct btrfs_trans_handle *trans;
        char *label = NULL;
        u64 block_count = 0;
@@ -1480,7 +1506,9 @@ int main(int argc, char **argv)
                                zero_end = 0;
                                break;
                        case 'V':
-                               print_version();
+                               printf("mkfs.btrfs, part of %s\n",
+                                               PACKAGE_STRING);
+                               exit(0);
                                break;
                        case 'r':
                                source_dir = optarg;
@@ -1595,6 +1623,12 @@ int main(int argc, char **argv)
                                 features))
                exit(1);
 
+       if (sectorsize < sizeof(struct btrfs_super_block)) {
+               error("sectorsize smaller than superblock: %u < %zu",
+                               sectorsize, sizeof(struct btrfs_super_block));
+               exit(1);
+       }
+
        /* Check device/block_count after the nodesize is determined */
        if (block_count && block_count < btrfs_min_dev_size(nodesize)) {
                error("size %llu is too small to make a usable filesystem",
@@ -1656,7 +1690,8 @@ int main(int argc, char **argv)
                        exit(1);
                }
        } else {
-               fd = open_target(file);
+               fd = open(file, O_CREAT | O_RDWR,
+                               S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH);
                if (fd < 0) {
                        error("unable to open %s: %s", file, strerror(errno));
                        exit(1);
@@ -1694,7 +1729,7 @@ int main(int argc, char **argv)
        }
 
        mkfs_cfg.label = label;
-       mkfs_cfg.fs_uuid = fs_uuid;
+       memcpy(mkfs_cfg.fs_uuid, fs_uuid, sizeof(mkfs_cfg.fs_uuid));
        memcpy(mkfs_cfg.blocks, blocks, sizeof(blocks));
        mkfs_cfg.num_bytes = dev_block_count;
        mkfs_cfg.nodesize = nodesize;
@@ -1708,13 +1743,15 @@ int main(int argc, char **argv)
                exit(1);
        }
 
-       root = open_ctree(file, 0, OPEN_CTREE_WRITES | OPEN_CTREE_FS_PARTIAL);
-       if (!root) {
+       fs_info = open_ctree_fs_info(file, 0, 0, 0,
+                       OPEN_CTREE_WRITES | OPEN_CTREE_FS_PARTIAL);
+       if (!fs_info) {
                error("open ctree failed");
                close(fd);
                exit(1);
        }
-       root->fs_info->alloc_start = alloc_start;
+       root = fs_info->fs_root;
+       fs_info->alloc_start = alloc_start;
 
        ret = create_metadata_block_groups(root, mixed, &allocation);
        if (ret) {
@@ -1740,7 +1777,11 @@ int main(int argc, char **argv)
                exit(1);
        }
 
-       btrfs_commit_transaction(trans, root);
+       ret = btrfs_commit_transaction(trans, root);
+       if (ret) {
+               error("unable to commit transaction: %d", ret);
+               goto out;
+       }
 
        trans = btrfs_start_transaction(root, 1);
        if (!trans) {
@@ -1784,11 +1825,14 @@ int main(int argc, char **argv)
 
                ret = btrfs_add_to_fsid(trans, root, fd, file, dev_block_count,
                                        sectorsize, sectorsize, sectorsize);
-               BUG_ON(ret);
+               if (ret) {
+                       error("unable to add %s to filesystem: %d", file, ret);
+                       goto out;
+               }
                if (verbose >= 2) {
                        struct btrfs_device *device;
 
-                       device = container_of(root->fs_info->fs_devices->devices.next,
+                       device = container_of(fs_info->fs_devices->devices.next,
                                        struct btrfs_device, dev_list);
                        printf("adding device %s id %llu\n", file,
                                (unsigned long long)device->devid);
@@ -1799,26 +1843,46 @@ raid_groups:
        if (!source_dir_set) {
                ret = create_raid_groups(trans, root, data_profile,
                                 metadata_profile, mixed, &allocation);
-               BUG_ON(ret);
+               if (ret) {
+                       error("unable to create raid groups: %d", ret);
+                       goto out;
+               }
        }
 
        ret = create_data_reloc_tree(trans, root);
-       BUG_ON(ret);
+       if (ret) {
+               error("unable to create data reloc tree: %d", ret);
+               goto out;
+       }
 
-       btrfs_commit_transaction(trans, root);
+       ret = btrfs_commit_transaction(trans, root);
+       if (ret) {
+               error("unable to commit transaction: %d", ret);
+               goto out;
+       }
 
        if (source_dir_set) {
                trans = btrfs_start_transaction(root, 1);
                ret = create_chunks(trans, root,
                                    num_of_meta_chunks, size_of_data,
                                    &allocation);
-               BUG_ON(ret);
-               btrfs_commit_transaction(trans, root);
+               if (ret) {
+                       error("unable to create chunks: %d", ret);
+                       goto out;
+               }
+               ret = btrfs_commit_transaction(trans, root);
+               if (ret) {
+                       error("transaction commit failed: %d", ret);
+                       goto out;
+               }
 
                ret = make_image(source_dir, root, fd);
-               BUG_ON(ret);
+               if (ret) {
+                       error("error wihle filling filesystem: %d", ret);
+                       goto out;
+               }
        }
-       ret = cleanup_temp_chunks(root->fs_info, &allocation, data_profile,
+       ret = cleanup_temp_chunks(fs_info, &allocation, data_profile,
                                  metadata_profile, metadata_profile);
        if (ret < 0) {
                error("failed to cleanup temporary chunks: %d", ret);
@@ -1833,7 +1897,7 @@ raid_groups:
                printf("Node size:          %u\n", nodesize);
                printf("Sector size:        %u\n", sectorsize);
                printf("Filesystem size:    %s\n",
-                       pretty_size(btrfs_super_total_bytes(root->fs_info->super_copy)));
+                       pretty_size(btrfs_super_total_bytes(fs_info->super_copy)));
                printf("Block group profiles:\n");
                if (allocation.data)
                        printf("  Data:             %-8s %16s\n",
@@ -1862,20 +1926,22 @@ raid_groups:
         * The filesystem is now fully set up, commit the remaining changes and
         * fix the signature as the last step before closing the devices.
         */
-       root->fs_info->finalize_on_close = 1;
+       fs_info->finalize_on_close = 1;
 out:
        ret = close_ctree(root);
-       BUG_ON(ret);
 
-       optind = saved_optind;
-       dev_cnt = argc - optind;
-       while (dev_cnt-- > 0) {
-               file = argv[optind++];
-               if (is_block_device(file) == 1)
-                       btrfs_register_one_device(file);
+       if (!ret) {
+               optind = saved_optind;
+               dev_cnt = argc - optind;
+               while (dev_cnt-- > 0) {
+                       file = argv[optind++];
+                       if (is_block_device(file) == 1)
+                               btrfs_register_one_device(file);
+               }
        }
 
        btrfs_close_all_devices();
        free(label);
-       return 0;
+
+       return !!ret;
 }