+/* vi: set sw=4 ts=4: */
/*
* crond -d[#] -c <crondir> -f -b
*
* run as root, but NOT setuid root
*
* Copyright 1994 Matthew Dillon (dillon@apollo.west.oic.com)
- * May be distributed under the GNU General Public License
+ * (version 2.3.2)
+ * Vladimir Oleynik <dzo@simtreas.ru> (C) 2002
*
- * Vladimir Oleynik <dzo@simtreas.ru> (C) 2002 to be used in busybox
+ * Licensed under GPLv2 or later, see file LICENSE in this source tree.
*/
-#define VERSION "2.3.2"
-
-#undef FEATURE_DEBUG_OPT
-
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <string.h>
-#include <errno.h>
-#include <time.h>
-#include <dirent.h>
-#include <fcntl.h>
-#include <unistd.h>
+//usage:#define crond_trivial_usage
+//usage: "-fbS -l N " IF_FEATURE_CROND_D("-d N ") "-L LOGFILE -c DIR"
+//usage:#define crond_full_usage "\n\n"
+//usage: " -f Foreground"
+//usage: "\n -b Background (default)"
+//usage: "\n -S Log to syslog (default)"
+//usage: "\n -l Set log level. 0 is the most verbose, default 8"
+//usage: IF_FEATURE_CROND_D(
+//usage: "\n -d Set log level, log to stderr"
+//usage: )
+//usage: "\n -L Log to file"
+//usage: "\n -c Working dir"
+
+#include "libbb.h"
#include <syslog.h>
-#include <signal.h>
-#include <getopt.h>
-#include <sys/ioctl.h>
-#include <sys/wait.h>
-#include <sys/stat.h>
-#include <sys/resource.h>
-#include "busybox.h"
+/* glibc frees previous setenv'ed value when we do next setenv()
+ * of the same variable. uclibc does not do this! */
+#if (defined(__GLIBC__) && !defined(__UCLIBC__)) /* || OTHER_SAFE_LIBC... */
+# define SETENV_LEAKS 0
+#else
+# define SETENV_LEAKS 1
+#endif
-#define arysize(ary) (sizeof(ary)/sizeof((ary)[0]))
-#ifndef CRONTABS
-#define CRONTABS "/var/spool/cron/crontabs"
-#endif
-#ifndef TMPDIR
-#define TMPDIR "/var/spool/cron"
-#endif
+#define TMPDIR CONFIG_FEATURE_CROND_DIR
+#define CRONTABS CONFIG_FEATURE_CROND_DIR "/crontabs"
#ifndef SENDMAIL
-#define SENDMAIL "/usr/sbin/sendmail"
+# define SENDMAIL "sendmail"
#endif
#ifndef SENDMAIL_ARGS
-#define SENDMAIL_ARGS "-ti", "oem"
+# define SENDMAIL_ARGS "-ti"
#endif
#ifndef CRONUPDATE
-#define CRONUPDATE "cron.update"
+# define CRONUPDATE "cron.update"
#endif
#ifndef MAXLINES
-#define MAXLINES 256 /* max lines in non-root crontabs */
+# define MAXLINES 256 /* max lines in non-root crontabs */
#endif
-static const char def_sh[] = "/bin/sh";
-
typedef struct CronFile {
- struct CronFile *cf_Next;
- struct CronLine *cf_LineBase;
- char *cf_User; /* username */
- int cf_Ready; /* bool: one or more jobs ready */
- int cf_Running; /* bool: one or more jobs running */
- int cf_Deleted; /* marked for deletion, ignore */
+ struct CronFile *cf_next;
+ struct CronLine *cf_lines;
+ char *cf_username;
+ smallint cf_wants_starting; /* bool: one or more jobs ready */
+ smallint cf_has_running; /* bool: one or more jobs running */
+ smallint cf_deleted; /* marked for deletion (but still has running jobs) */
} CronFile;
typedef struct CronLine {
- struct CronLine *cl_Next;
- char *cl_Shell; /* shell command */
- pid_t cl_Pid; /* running pid, 0, or armed (-1) */
- int cl_MailFlag; /* running pid is for mail */
- int cl_MailPos; /* 'empty file' size */
- char cl_Mins[60]; /* 0-59 */
- char cl_Hrs[24]; /* 0-23 */
- char cl_Days[32]; /* 1-31 */
- char cl_Mons[12]; /* 0-11 */
- char cl_Dow[7]; /* 0-6, beginning sunday */
-} CronLine;
-
-#define RUN_RANOUT 1
-#define RUN_RUNNING 2
-#define RUN_FAILED 3
-
-#define DaemonUid 0
-
-#ifdef FEATURE_DEBUG_OPT
-static short DebugOpt;
+ struct CronLine *cl_next;
+ char *cl_cmd; /* shell command */
+ pid_t cl_pid; /* >0:running, <0:needs to be started in this minute, 0:dormant */
+#if ENABLE_FEATURE_CROND_CALL_SENDMAIL
+ int cl_empty_mail_size; /* size of mail header only, 0 if no mailfile */
+ char *cl_mailto; /* whom to mail results, may be NULL */
#endif
+ /* ordered by size, not in natural order. makes code smaller: */
+ char cl_Dow[7]; /* 0-6, beginning sunday */
+ char cl_Mons[12]; /* 0-11 */
+ char cl_Hrs[24]; /* 0-23 */
+ char cl_Days[32]; /* 1-31 */
+ char cl_Mins[60]; /* 0-59 */
+} CronLine;
-static short LogLevel = 8;
-static const char *LogFile;
-static const char *CDir = CRONTABS;
-static void startlogger(void);
+#define DAEMON_UID 0
-static void CheckUpdates(void);
-static void SynchronizeDir(void);
-static int TestJobs(time_t t1, time_t t2);
-static void RunJobs(void);
-static int CheckJobs(void);
-static void RunJob(const char *user, CronLine *line);
-#ifdef CONFIG_FEATURE_CROND_CALL_SENDMAIL
-static void EndJob(const char *user, CronLine *line);
+enum {
+ OPT_l = (1 << 0),
+ OPT_L = (1 << 1),
+ OPT_f = (1 << 2),
+ OPT_b = (1 << 3),
+ OPT_S = (1 << 4),
+ OPT_c = (1 << 5),
+ OPT_d = (1 << 6) * ENABLE_FEATURE_CROND_D,
+};
+#if ENABLE_FEATURE_CROND_D
+# define DebugOpt (option_mask32 & OPT_d)
#else
-#define EndJob(user, line) line->cl_Pid = 0
+# define DebugOpt 0
#endif
-static void DeleteFile(const char *userName);
-
-static CronFile *FileBase;
-
-static void
-log(const char *ctl, ...)
-{
- va_list va;
- int level = (int)(ctl[0] & 0xf);
- int type = level == 20 ?
- LOG_ERR : ((ctl[0] & 0100) ? LOG_WARNING : LOG_NOTICE);
-
-
- va_start(va, ctl);
- if (level >= LogLevel) {
-
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt) vfprintf(stderr, ctl, va);
- else
-#endif
- if (LogFile == 0) vsyslog(type, ctl, va);
- else {
- int logfd;
-
- if ((logfd = open(LogFile, O_WRONLY|O_CREAT|O_APPEND, 600)) >= 0) {
- vdprintf(logfd, ctl, va);
- close(logfd);
-#ifdef FEATURE_DEBUG_OPT
- } else {
- bb_perror_msg("Can't open log file");
+struct globals {
+ unsigned log_level; /* = 8; */
+ time_t crontab_dir_mtime;
+ const char *log_filename;
+ const char *crontab_dir_name; /* = CRONTABS; */
+ CronFile *cron_files;
+#if SETENV_LEAKS
+ char *env_var_user;
+ char *env_var_home;
#endif
+} FIX_ALIASING;
+#define G (*(struct globals*)&bb_common_bufsiz1)
+#define INIT_G() do { \
+ G.log_level = 8; \
+ G.crontab_dir_name = CRONTABS; \
+} while (0)
+
+
+/* 0 is the most verbose, default 8 */
+#define LVL5 "\x05"
+#define LVL7 "\x07"
+#define LVL8 "\x08"
+#define WARN9 "\x49"
+#define DIE9 "\xc9"
+/* level >= 20 is "error" */
+#define ERR20 "\x14"
+
+static void crondlog(const char *ctl, ...) __attribute__ ((format (printf, 1, 2)));
+static void crondlog(const char *ctl, ...)
+{
+ va_list va;
+ int level = (ctl[0] & 0x1f);
+
+ va_start(va, ctl);
+ if (level >= (int)G.log_level) {
+ /* Debug mode: all to (non-redirected) stderr, */
+ /* Syslog mode: all to syslog (logmode = LOGMODE_SYSLOG), */
+ if (!DebugOpt && G.log_filename) {
+ /* Otherwise (log to file): we reopen log file at every write: */
+ int logfd = open_or_warn(G.log_filename, O_WRONLY | O_CREAT | O_APPEND);
+ if (logfd >= 0)
+ xmove_fd(logfd, STDERR_FILENO);
+ }
+ /* When we log to syslog, level > 8 is logged at LOG_ERR
+ * syslog level, level <= 8 is logged at LOG_INFO. */
+ if (level > 8) {
+ bb_verror_msg(ctl + 1, va, /* strerr: */ NULL);
+ } else {
+ char *msg = NULL;
+ vasprintf(&msg, ctl + 1, va);
+ bb_info_msg("%s: %s", applet_name, msg);
+ free(msg);
}
- }
- }
- va_end(va);
- if(ctl[0] & 0200)
- exit(20);
+ }
+ va_end(va);
+ if (ctl[0] & 0x80)
+ exit(20);
}
-int
-crond_main(int ac, char **av)
-{
- unsigned long opt;
- char *lopt, *Lopt, *copt;
-#ifdef FEATURE_DEBUG_OPT
- char *dopt;
- bb_opt_complementaly = "f-b:b-f:S-L:L-S:d-l";
-#else
- bb_opt_complementaly = "f-b:b-f:S-L:L-S";
-#endif
-
- opterr = 0; /* disable getopt 'errors' message.*/
- opt = bb_getopt_ulflags(ac, av, "l:L:fbSc:"
-#ifdef FEATURE_DEBUG_OPT
- "d:"
-#endif
- , &lopt, &Lopt, &copt
-#ifdef FEATURE_DEBUG_OPT
- , &dopt
-#endif
- );
- if(opt & 1)
- LogLevel = atoi(lopt);
- if(opt & 2)
- if (*Lopt != 0) LogFile = Lopt;
- if(opt & 32) {
- if (*copt != 0) CDir = copt;
- }
-#ifdef FEATURE_DEBUG_OPT
- if(opt & 64) {
- DebugOpt = atoi(dopt);
- LogLevel = 0;
- }
-#endif
+static const char DowAry[] ALIGN1 =
+ "sun""mon""tue""wed""thu""fri""sat"
+ /* "Sun""Mon""Tue""Wed""Thu""Fri""Sat" */
+;
- /*
- * change directory
- */
-
- if (chdir(CDir) != 0)
- bb_perror_msg_and_die("%s", CDir);
-
- signal(SIGHUP,SIG_IGN); /* hmm.. but, if kill -HUP original
- * version - his died. ;(
- */
- /*
- * close stdin and stdout, stderr.
- * close unused descriptors - don't need.
- * optional detach from controlling terminal
- */
-
- if (!(opt & 4)) {
- if(daemon(1, 0) < 0) {
- bb_perror_msg_and_die("daemon");
-#if defined(__uClinux__)
- } else {
- /* reexec for vfork() do continue parent */
- vfork_daemon_rexec(ac, av, "-f");
- }
-#endif /* uClinux */
- }
+static const char MonAry[] ALIGN1 =
+ "jan""feb""mar""apr""may""jun""jul""aug""sep""oct""nov""dec"
+ /* "Jan""Feb""Mar""Apr""May""Jun""Jul""Aug""Sep""Oct""Nov""Dec" */
+;
- (void)startlogger(); /* need if syslog mode selected */
+static void ParseField(char *user, char *ary, int modvalue, int off,
+ const char *names, char *ptr)
+/* 'names' is a pointer to a set of 3-char abbreviations */
+{
+ char *base = ptr;
+ int n1 = -1;
+ int n2 = -1;
+
+ // this can't happen due to config_read()
+ /*if (base == NULL)
+ return;*/
+
+ while (1) {
+ int skip = 0;
+
+ /* Handle numeric digit or symbol or '*' */
+ if (*ptr == '*') {
+ n1 = 0; /* everything will be filled */
+ n2 = modvalue - 1;
+ skip = 1;
+ ++ptr;
+ } else if (isdigit(*ptr)) {
+ char *endp;
+ if (n1 < 0) {
+ n1 = strtol(ptr, &endp, 10) + off;
+ } else {
+ n2 = strtol(ptr, &endp, 10) + off;
+ }
+ ptr = endp; /* gcc likes temp var for &endp */
+ skip = 1;
+ } else if (names) {
+ int i;
+
+ for (i = 0; names[i]; i += 3) {
+ /* was using strncmp before... */
+ if (strncasecmp(ptr, &names[i], 3) == 0) {
+ ptr += 3;
+ if (n1 < 0) {
+ n1 = i / 3;
+ } else {
+ n2 = i / 3;
+ }
+ skip = 1;
+ break;
+ }
+ }
+ }
- /*
- * main loop - synchronize to 1 second after the minute, minimum sleep
- * of 1 second.
- */
+ /* handle optional range '-' */
+ if (skip == 0) {
+ goto err;
+ }
+ if (*ptr == '-' && n2 < 0) {
+ ++ptr;
+ continue;
+ }
- log("\011%s " VERSION " dillon, started, log level %d\n", bb_applet_name,
- LogLevel);
+ /*
+ * collapse single-value ranges, handle skipmark, and fill
+ * in the character array appropriately.
+ */
+ if (n2 < 0) {
+ n2 = n1;
+ }
+ if (*ptr == '/') {
+ char *endp;
+ skip = strtol(ptr + 1, &endp, 10);
+ ptr = endp; /* gcc likes temp var for &endp */
+ }
- SynchronizeDir();
+ /*
+ * fill array, using a failsafe is the easiest way to prevent
+ * an endless loop
+ */
+ {
+ int s0 = 1;
+ int failsafe = 1024;
+
+ --n1;
+ do {
+ n1 = (n1 + 1) % modvalue;
+
+ if (--s0 == 0) {
+ ary[n1 % modvalue] = 1;
+ s0 = skip;
+ }
+ if (--failsafe == 0) {
+ goto err;
+ }
+ } while (n1 != n2);
+ }
+ if (*ptr != ',') {
+ break;
+ }
+ ++ptr;
+ n1 = -1;
+ n2 = -1;
+ }
- {
- time_t t1 = time(NULL);
- time_t t2;
- long dt;
- short rescan = 60;
- short sleep_time = 60;
+ if (*ptr) {
+ err:
+ crondlog(WARN9 "user %s: parse error at %s", user, base);
+ return;
+ }
- for (;;) {
- sleep((sleep_time + 1) - (short)(time(NULL) % sleep_time));
-
- t2 = time(NULL);
- dt = t2 - t1;
-
- /*
- * The file 'cron.update' is checked to determine new cron
- * jobs. The directory is rescanned once an hour to deal
- * with any screwups.
- *
- * check for disparity. Disparities over an hour either way
- * result in resynchronization. A reverse-indexed disparity
- * less then an hour causes us to effectively sleep until we
- * match the original time (i.e. no re-execution of jobs that
- * have just been run). A forward-indexed disparity less then
- * an hour causes intermediate jobs to be run, but only once
- * in the worst case.
- *
- * when running jobs, the inequality used is greater but not
- * equal to t1, and less then or equal to t2.
- */
-
- if (--rescan == 0) {
- rescan = 60;
- SynchronizeDir();
- }
- CheckUpdates();
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt)
- log("\005Wakeup dt=%d\n", dt);
-#endif
- if (dt < -60*60 || dt > 60*60) {
- t1 = t2;
- log("\111time disparity of %d minutes detected\n", dt / 60);
- } else if (dt > 0) {
- TestJobs(t1, t2);
- RunJobs();
- sleep(5);
- if (CheckJobs() > 0)
- sleep_time = 10;
- else
- sleep_time = 60;
- t1 = t2;
- }
+ if (DebugOpt && (G.log_level <= 5)) { /* like LVL5 */
+ /* can't use crondlog, it inserts '\n' */
+ int i;
+ for (i = 0; i < modvalue; ++i)
+ fprintf(stderr, "%d", (unsigned char)ary[i]);
+ bb_putchar_stderr('\n');
}
- }
- /* not reached */
}
-
-#if defined(FEATURE_DEBUG_OPT) || defined(CONFIG_FEATURE_CROND_CALL_SENDMAIL)
-/*
- write to temp file..
-*/
-static void
-fdprintf(int fd, const char *ctl, ...)
+static void FixDayDow(CronLine *line)
{
- va_list va;
+ unsigned i;
+ int weekUsed = 0;
+ int daysUsed = 0;
- va_start(va, ctl);
- vdprintf(fd, ctl, va);
- va_end(va);
+ for (i = 0; i < ARRAY_SIZE(line->cl_Dow); ++i) {
+ if (line->cl_Dow[i] == 0) {
+ weekUsed = 1;
+ break;
+ }
+ }
+ for (i = 0; i < ARRAY_SIZE(line->cl_Days); ++i) {
+ if (line->cl_Days[i] == 0) {
+ daysUsed = 1;
+ break;
+ }
+ }
+ if (weekUsed != daysUsed) {
+ if (weekUsed)
+ memset(line->cl_Days, 0, sizeof(line->cl_Days));
+ else /* daysUsed */
+ memset(line->cl_Dow, 0, sizeof(line->cl_Dow));
+ }
}
-#endif
-
-static int
-ChangeUser(const char *user)
+/*
+ * delete_cronfile() - delete user database
+ *
+ * Note: multiple entries for same user may exist if we were unable to
+ * completely delete a database due to running processes.
+ */
+//FIXME: we will start a new job even if the old job is running
+//if crontab was reloaded: crond thinks that "new" job is different from "old"
+//even if they are in fact completely the same. Example
+//Crontab was:
+// 0-59 * * * * job1
+// 0-59 * * * * long_running_job2
+//User edits crontab to:
+// 0-59 * * * * job1_updated
+// 0-59 * * * * long_running_job2
+//Bug: crond can now start another long_running_job2 even if old one
+//is still running.
+//OTOH most other versions of cron do not wait for job termination anyway,
+//they end up with multiple copies of jobs if they don't terminate soon enough.
+static void delete_cronfile(const char *userName)
{
- struct passwd *pas;
-
- /*
- * Obtain password entry and change privilages
- */
-
- if ((pas = getpwnam(user)) == 0) {
- log("\011failed to get uid for %s", user);
- return(-1);
- }
- setenv("USER", pas->pw_name, 1);
- setenv("HOME", pas->pw_dir, 1);
- setenv("SHELL", def_sh, 1);
-
- /*
- * Change running state to the user in question
- */
-
- if (initgroups(user, pas->pw_gid) < 0) {
- log("\011initgroups failed: %s %m", user);
- return(-1);
- }
- /* drop all priviledges */
- if (setgid(pas->pw_gid) < 0) {
- log("\011setgid failed: %s %d", user, pas->pw_gid);
- return(-1);
- }
- if (setuid(pas->pw_uid) < 0) {
- log("\011setuid failed: %s %d", user, pas->pw_uid);
- return(-1);
- }
- if (chdir(pas->pw_dir) < 0) {
- log("\011chdir failed: %s: %m", pas->pw_dir);
- if (chdir(TMPDIR) < 0) {
- log("\011chdir failed: %s: %m", TMPDIR);
- return(-1);
- }
+ CronFile **pfile = &G.cron_files;
+ CronFile *file;
+
+ while ((file = *pfile) != NULL) {
+ if (strcmp(userName, file->cf_username) == 0) {
+ CronLine **pline = &file->cf_lines;
+ CronLine *line;
+
+ file->cf_has_running = 0;
+ file->cf_deleted = 1;
+
+ while ((line = *pline) != NULL) {
+ if (line->cl_pid > 0) {
+ file->cf_has_running = 1;
+ pline = &line->cl_next;
+ } else {
+ *pline = line->cl_next;
+ free(line->cl_cmd);
+ free(line);
+ }
+ }
+ if (file->cf_has_running == 0) {
+ *pfile = file->cf_next;
+ free(file->cf_username);
+ free(file);
+ continue;
+ }
+ }
+ pfile = &file->cf_next;
}
- return(pas->pw_uid);
}
-static void
-startlogger(void)
+static void load_crontab(const char *fileName)
{
- if (LogFile == 0)
- openlog(bb_applet_name, LOG_CONS|LOG_PID, LOG_CRON);
-#ifdef FEATURE_DEBUG_OPT
- else { /* test logfile */
- int logfd;
-
- if ((logfd = open(LogFile, O_WRONLY|O_CREAT|O_APPEND, 600)) >= 0)
- close(logfd);
- else
- bb_perror_msg("Failed to open log file '%s' reason", LogFile);
- }
+ struct parser_t *parser;
+ struct stat sbuf;
+ int maxLines;
+ char *tokens[6];
+#if ENABLE_FEATURE_CROND_CALL_SENDMAIL
+ char *mailTo = NULL;
#endif
-}
-
-
-static const char * const DowAry[] = {
- "sun",
- "mon",
- "tue",
- "wed",
- "thu",
- "fri",
- "sat",
-
- "Sun",
- "Mon",
- "Tue",
- "Wed",
- "Thu",
- "Fri",
- "Sat",
- NULL
-};
-
-static const char * const MonAry[] = {
- "jan",
- "feb",
- "mar",
- "apr",
- "may",
- "jun",
- "jul",
- "aug",
- "sep",
- "oct",
- "nov",
- "dec",
-
- "Jan",
- "Feb",
- "Mar",
- "Apr",
- "May",
- "Jun",
- "Jul",
- "Aug",
- "Sep",
- "Oct",
- "Nov",
- "Dec",
- NULL
-};
-
-static char *
-ParseField(char *user, char *ary, int modvalue, int off,
- const char * const *names, char *ptr)
-{
- char *base = ptr;
- int n1 = -1;
- int n2 = -1;
-
- if (base == NULL)
- return(NULL);
- while (*ptr != ' ' && *ptr != '\t' && *ptr != '\n') {
- int skip = 0;
-
- /*
- * Handle numeric digit or symbol or '*'
- */
+ delete_cronfile(fileName);
- if (*ptr == '*') {
- n1 = 0; /* everything will be filled */
- n2 = modvalue - 1;
- skip = 1;
- ++ptr;
- } else if (*ptr >= '0' && *ptr <= '9') {
- if (n1 < 0)
- n1 = strtol(ptr, &ptr, 10) + off;
- else
- n2 = strtol(ptr, &ptr, 10) + off;
- skip = 1;
- } else if (names) {
- int i;
-
- for (i = 0; names[i]; ++i) {
- if (strncmp(ptr, names[i], strlen(names[i])) == 0) {
- break;
- }
- }
- if (names[i]) {
- ptr += strlen(names[i]);
- if (n1 < 0)
- n1 = i;
- else
- n2 = i;
- skip = 1;
- }
+ if (!getpwnam(fileName)) {
+ crondlog(LVL7 "ignoring file '%s' (no such user)", fileName);
+ return;
}
- /*
- * handle optional range '-'
- */
+ parser = config_open(fileName);
+ if (!parser)
+ return;
- if (skip == 0) {
- log("\111failed user %s parsing %s\n", user, base);
- return(NULL);
- }
- if (*ptr == '-' && n2 < 0) {
- ++ptr;
- continue;
- }
+ maxLines = (strcmp(fileName, "root") == 0) ? 65535 : MAXLINES;
- /*
- * collapse single-value ranges, handle skipmark, and fill
- * in the character array appropriately.
- */
+ if (fstat(fileno(parser->fp), &sbuf) == 0 && sbuf.st_uid == DAEMON_UID) {
+ CronFile *file = xzalloc(sizeof(CronFile));
+ CronLine **pline;
+ int n;
- if (n2 < 0)
- n2 = n1;
+ file->cf_username = xstrdup(fileName);
+ pline = &file->cf_lines;
- if (*ptr == '/')
- skip = strtol(ptr + 1, &ptr, 10);
+ while (1) {
+ CronLine *line;
- /*
- * fill array, using a failsafe is the easiest way to prevent
- * an endless loop
- */
+ if (!--maxLines)
+ break;
+ n = config_read(parser, tokens, 6, 1, "# \t", PARSE_NORMAL | PARSE_KEEP_COPY);
+ if (!n)
+ break;
- {
- int s0 = 1;
- int failsafe = 1024;
+ if (DebugOpt)
+ crondlog(LVL5 "user:%s entry:%s", fileName, parser->data);
+
+ /* check if line is setting MAILTO= */
+ if (0 == strncmp(tokens[0], "MAILTO=", 7)) {
+#if ENABLE_FEATURE_CROND_CALL_SENDMAIL
+ free(mailTo);
+ mailTo = (tokens[0][7]) ? xstrdup(&tokens[0][7]) : NULL;
+#endif /* otherwise just ignore such lines */
+ continue;
+ }
+ /* check if a minimum of tokens is specified */
+ if (n < 6)
+ continue;
+ *pline = line = xzalloc(sizeof(*line));
+ /* parse date ranges */
+ ParseField(file->cf_username, line->cl_Mins, 60, 0, NULL, tokens[0]);
+ ParseField(file->cf_username, line->cl_Hrs, 24, 0, NULL, tokens[1]);
+ ParseField(file->cf_username, line->cl_Days, 32, 0, NULL, tokens[2]);
+ ParseField(file->cf_username, line->cl_Mons, 12, -1, MonAry, tokens[3]);
+ ParseField(file->cf_username, line->cl_Dow, 7, 0, DowAry, tokens[4]);
+ /*
+ * fix days and dow - if one is not "*" and the other
+ * is "*", the other is set to 0, and vise-versa
+ */
+ FixDayDow(line);
+#if ENABLE_FEATURE_CROND_CALL_SENDMAIL
+ /* copy mailto (can be NULL) */
+ line->cl_mailto = xstrdup(mailTo);
+#endif
+ /* copy command */
+ line->cl_cmd = xstrdup(tokens[5]);
+ if (DebugOpt) {
+ crondlog(LVL5 " command:%s", tokens[5]);
+ }
+ pline = &line->cl_next;
+//bb_error_msg("M[%s]F[%s][%s][%s][%s][%s][%s]", mailTo, tokens[0], tokens[1], tokens[2], tokens[3], tokens[4], tokens[5]);
+ }
+ *pline = NULL;
- --n1;
- do {
- n1 = (n1 + 1) % modvalue;
+ file->cf_next = G.cron_files;
+ G.cron_files = file;
- if (--s0 == 0) {
- ary[n1 % modvalue] = 1;
- s0 = skip;
+ if (maxLines == 0) {
+ crondlog(WARN9 "user %s: too many lines", fileName);
}
- } while (n1 != n2 && --failsafe);
-
- if (failsafe == 0) {
- log("\111failed user %s parsing %s\n", user, base);
- return(NULL);
- }
}
- if (*ptr != ',')
- break;
- ++ptr;
- n1 = -1;
- n2 = -1;
- }
-
- if (*ptr != ' ' && *ptr != '\t' && *ptr != '\n') {
- log("\111failed user %s parsing %s\n", user, base);
- return(NULL);
- }
-
- while (*ptr == ' ' || *ptr == '\t' || *ptr == '\n')
- ++ptr;
-
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt) {
- int i;
-
- for (i = 0; i < modvalue; ++i)
- log("\005%d", ary[i]);
- log("\005\n");
- }
-#endif
-
- return(ptr);
+ config_close(parser);
}
-static void
-FixDayDow(CronLine *line)
+static void process_cron_update_file(void)
{
- short i;
- short weekUsed = 0;
- short daysUsed = 0;
-
- for (i = 0; i < arysize(line->cl_Dow); ++i) {
- if (line->cl_Dow[i] == 0) {
- weekUsed = 1;
- break;
- }
- }
- for (i = 0; i < arysize(line->cl_Days); ++i) {
- if (line->cl_Days[i] == 0) {
- daysUsed = 1;
- break;
+ FILE *fi;
+ char buf[256];
+
+ fi = fopen_for_read(CRONUPDATE);
+ if (fi != NULL) {
+ unlink(CRONUPDATE);
+ while (fgets(buf, sizeof(buf), fi) != NULL) {
+ /* use first word only */
+ skip_non_whitespace(buf)[0] = '\0';
+ load_crontab(buf);
+ }
+ fclose(fi);
}
- }
- if (weekUsed && !daysUsed) {
- memset(line->cl_Days, 0, sizeof(line->cl_Days));
- }
- if (daysUsed && !weekUsed) {
- memset(line->cl_Dow, 0, sizeof(line->cl_Dow));
- }
}
-
-
-static void
-SynchronizeFile(const char *fileName)
+static void rescan_crontab_dir(void)
{
- int maxEntries = MAXLINES;
- int maxLines;
- char buf[1024];
-
- if (strcmp(fileName, "root") == 0)
- maxEntries = 65535;
- maxLines = maxEntries * 10;
-
- if (fileName) {
- FILE *fi;
-
- DeleteFile(fileName);
-
- if ((fi = fopen(fileName, "r")) != NULL) {
- struct stat sbuf;
-
- if (fstat(fileno(fi), &sbuf) == 0 && sbuf.st_uid == DaemonUid) {
- CronFile *file = calloc(1, sizeof(CronFile));
- CronLine **pline;
-
- file->cf_User = strdup(fileName);
- pline = &file->cf_LineBase;
-
- while (fgets(buf, sizeof(buf), fi) != NULL && --maxLines) {
- CronLine line;
- char *ptr;
+ CronFile *file;
- if (buf[0])
- buf[strlen(buf)-1] = 0;
+ /* Delete all files until we only have ones with running jobs (or none) */
+ again:
+ for (file = G.cron_files; file; file = file->cf_next) {
+ if (!file->cf_deleted) {
+ delete_cronfile(file->cf_username);
+ goto again;
+ }
+ }
- if (buf[0] == 0 || buf[0] == '#' || buf[0] == ' ' || buf[0] == '\t')
- continue;
+ /* Remove cron update file */
+ unlink(CRONUPDATE);
+ /* Re-chdir, in case directory was renamed & deleted */
+ if (chdir(G.crontab_dir_name) < 0) {
+ crondlog(DIE9 "chdir(%s)", G.crontab_dir_name);
+ }
- if (--maxEntries == 0)
- break;
+ /* Scan directory and add associated users */
+ {
+ DIR *dir = opendir(".");
+ struct dirent *den;
+
+ if (!dir)
+ crondlog(DIE9 "chdir(%s)", "."); /* exits */
+ while ((den = readdir(dir)) != NULL) {
+ if (strchr(den->d_name, '.') != NULL) {
+ continue;
+ }
+ load_crontab(den->d_name);
+ }
+ closedir(dir);
+ }
+}
- memset(&line, 0, sizeof(line));
+#if SETENV_LEAKS
+/* We set environment *before* vfork (because we want to use vfork),
+ * so we cannot use setenv() - repeated calls to setenv() may leak memory!
+ * Using putenv(), and freeing memory after unsetenv() won't leak */
+static void safe_setenv(char **pvar_val, const char *var, const char *val)
+{
+ char *var_val = *pvar_val;
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt)
- log("\111User %s Entry %s\n", fileName, buf);
+ if (var_val) {
+ bb_unsetenv_and_free(var_val);
+ }
+ *pvar_val = xasprintf("%s=%s", var, val);
+ putenv(*pvar_val);
+}
#endif
- /*
- * parse date ranges
- */
-
- ptr = ParseField(file->cf_User, line.cl_Mins, 60, 0, NULL, buf);
- ptr = ParseField(file->cf_User, line.cl_Hrs, 24, 0, NULL, ptr);
- ptr = ParseField(file->cf_User, line.cl_Days, 32, 0, NULL, ptr);
- ptr = ParseField(file->cf_User, line.cl_Mons, 12, -1, MonAry, ptr);
- ptr = ParseField(file->cf_User, line.cl_Dow, 7, 0, DowAry, ptr);
-
- /*
- * check failure
- */
+static void set_env_vars(struct passwd *pas)
+{
+#if SETENV_LEAKS
+ safe_setenv(&G.env_var_user, "USER", pas->pw_name);
+ safe_setenv(&G.env_var_home, "HOME", pas->pw_dir);
+ /* if we want to set user's shell instead: */
+ /*safe_setenv(G.env_var_shell, "SHELL", pas->pw_shell);*/
+#else
+ xsetenv("USER", pas->pw_name);
+ xsetenv("HOME", pas->pw_dir);
+#endif
+ /* currently, we use constant one: */
+ /*setenv("SHELL", DEFAULT_SHELL, 1); - done earlier */
+}
- if (ptr == NULL)
- continue;
+static void change_user(struct passwd *pas)
+{
+ /* careful: we're after vfork! */
+ change_identity(pas); /* - initgroups, setgid, setuid */
+ if (chdir(pas->pw_dir) < 0) {
+ crondlog(WARN9 "chdir(%s)", pas->pw_dir);
+ if (chdir(TMPDIR) < 0) {
+ crondlog(DIE9 "chdir(%s)", TMPDIR); /* exits */
+ }
+ }
+}
- /*
- * fix days and dow - if one is not * and the other
- * is *, the other is set to 0, and vise-versa
- */
+// TODO: sendmail should be _run-time_ option, not compile-time!
+#if ENABLE_FEATURE_CROND_CALL_SENDMAIL
+
+static pid_t
+fork_job(const char *user, int mailFd,
+ const char *prog,
+ const char *shell_cmd /* if NULL, we run sendmail */
+) {
+ struct passwd *pas;
+ pid_t pid;
+
+ /* prepare things before vfork */
+ pas = getpwnam(user);
+ if (!pas) {
+ crondlog(WARN9 "can't get uid for %s", user);
+ goto err;
+ }
+ set_env_vars(pas);
+
+ pid = vfork();
+ if (pid == 0) {
+ /* CHILD */
+ /* initgroups, setgid, setuid, and chdir to home or TMPDIR */
+ change_user(pas);
+ if (DebugOpt) {
+ crondlog(LVL5 "child running %s", prog);
+ }
+ if (mailFd >= 0) {
+ xmove_fd(mailFd, shell_cmd ? 1 : 0);
+ dup2(1, 2);
+ }
+ /* crond 3.0pl1-100 puts tasks in separate process groups */
+ bb_setpgrp();
+ execlp(prog, prog, (shell_cmd ? "-c" : SENDMAIL_ARGS), shell_cmd, (char *) NULL);
+ crondlog(ERR20 "can't execute '%s' for user %s", prog, user);
+ if (shell_cmd) {
+ fdprintf(1, "Exec failed: %s -c %s\n", prog, shell_cmd);
+ }
+ _exit(EXIT_SUCCESS);
+ }
- FixDayDow(&line);
+ if (pid < 0) {
+ /* FORK FAILED */
+ crondlog(ERR20 "can't vfork");
+ err:
+ pid = 0;
+ } /* else: PARENT, FORK SUCCESS */
- *pline = calloc(1, sizeof(CronLine));
- **pline = line;
+ /*
+ * Close the mail file descriptor.. we can't just leave it open in
+ * a structure, closing it later, because we might run out of descriptors
+ */
+ if (mailFd >= 0) {
+ close(mailFd);
+ }
+ return pid;
+}
- /*
- * copy command
- */
+static void start_one_job(const char *user, CronLine *line)
+{
+ char mailFile[128];
+ int mailFd = -1;
- (*pline)->cl_Shell = strdup(ptr);
+ line->cl_pid = 0;
+ line->cl_empty_mail_size = 0;
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt) {
- log("\111 Command %s\n", ptr);
- }
-#endif
+ if (line->cl_mailto) {
+ /* Open mail file (owner is root so nobody can screw with it) */
+ snprintf(mailFile, sizeof(mailFile), "%s/cron.%s.%d", TMPDIR, user, getpid());
+ mailFd = open(mailFile, O_CREAT | O_TRUNC | O_WRONLY | O_EXCL | O_APPEND, 0600);
- pline = &((*pline)->cl_Next);
+ if (mailFd >= 0) {
+ fdprintf(mailFd, "To: %s\nSubject: cron: %s\n\n", line->cl_mailto,
+ line->cl_cmd);
+ line->cl_empty_mail_size = lseek(mailFd, 0, SEEK_CUR);
+ } else {
+ crondlog(ERR20 "can't create mail file %s for user %s, "
+ "discarding output", mailFile, user);
}
- *pline = NULL;
-
- file->cf_Next = FileBase;
- FileBase = file;
-
- if (maxLines == 0 || maxEntries == 0)
- log("\111Maximum number of lines reached for user %s\n", fileName);
- }
- fclose(fi);
}
- }
-}
-
-static void
-CheckUpdates(void)
-{
- FILE *fi;
- char buf[256];
- if ((fi = fopen(CRONUPDATE, "r")) != NULL) {
- remove(CRONUPDATE);
- while (fgets(buf, sizeof(buf), fi) != NULL) {
- SynchronizeFile(strtok(buf, " \t\r\n"));
+ line->cl_pid = fork_job(user, mailFd, DEFAULT_SHELL, line->cl_cmd);
+ if (mailFd >= 0) {
+ if (line->cl_pid <= 0) {
+ unlink(mailFile);
+ } else {
+ /* rename mail-file based on pid of process */
+ char *mailFile2 = xasprintf("%s/cron.%s.%d", TMPDIR, user, (int)line->cl_pid);
+ rename(mailFile, mailFile2); // TODO: xrename?
+ free(mailFile2);
+ }
}
- fclose(fi);
- }
}
-static void
-SynchronizeDir(void)
+/*
+ * process_finished_job - called when job terminates and when mail terminates
+ */
+static void process_finished_job(const char *user, CronLine *line)
{
- /*
- * Attempt to delete the database.
- */
+ pid_t pid;
+ int mailFd;
+ char mailFile[128];
+ struct stat sbuf;
+
+ pid = line->cl_pid;
+ line->cl_pid = 0;
+ if (pid <= 0) {
+ /* No job */
+ return;
+ }
+ if (line->cl_empty_mail_size <= 0) {
+ /* End of job and no mail file, or end of sendmail job */
+ return;
+ }
- for (;;) {
- CronFile *file;
+ /*
+ * End of primary job - check for mail file.
+ * If size has changed and the file is still valid, we send it.
+ */
+ snprintf(mailFile, sizeof(mailFile), "%s/cron.%s.%d", TMPDIR, user, (int)pid);
+ mailFd = open(mailFile, O_RDONLY);
+ unlink(mailFile);
+ if (mailFd < 0) {
+ return;
+ }
- for (file = FileBase; file && file->cf_Deleted; file = file->cf_Next)
- ;
- if (file == NULL)
- break;
- DeleteFile(file->cf_User);
- }
-
- /*
- * Remove cron update file
- *
- * Re-chdir, in case directory was renamed & deleted, or otherwise
- * screwed up.
- *
- * scan directory and add associated users
- */
-
- remove(CRONUPDATE);
- if (chdir(CDir) < 0) {
- log("\311unable to find %s\n", CDir);
- }
- {
- DIR *dir;
- struct dirent *den;
-
- if ((dir = opendir("."))) {
- while ((den = readdir(dir))) {
- if (strchr(den->d_name, '.') != NULL)
- continue;
- if (getpwnam(den->d_name))
- SynchronizeFile(den->d_name);
- else
- log("\007ignoring %s\n", den->d_name);
- }
- closedir(dir);
- } else {
- log("\311Unable to open current dir!\n");
+ if (fstat(mailFd, &sbuf) < 0
+ || sbuf.st_uid != DAEMON_UID
+ || sbuf.st_nlink != 0
+ || sbuf.st_size == line->cl_empty_mail_size
+ || !S_ISREG(sbuf.st_mode)
+ ) {
+ close(mailFd);
+ return;
}
- }
+ line->cl_empty_mail_size = 0;
+ /* if (line->cl_mailto) - always true if cl_empty_mail_size was nonzero */
+ line->cl_pid = fork_job(user, mailFd, SENDMAIL, NULL);
}
+#else /* !ENABLE_FEATURE_CROND_CALL_SENDMAIL */
-/*
- * DeleteFile() - delete user database
- *
- * Note: multiple entries for same user may exist if we were unable to
- * completely delete a database due to running processes.
- */
-
-static void
-DeleteFile(const char *userName)
+static void start_one_job(const char *user, CronLine *line)
{
- CronFile **pfile = &FileBase;
- CronFile *file;
+ struct passwd *pas;
+ pid_t pid;
- while ((file = *pfile) != NULL) {
- if (strcmp(userName, file->cf_User) == 0) {
- CronLine **pline = &file->cf_LineBase;
- CronLine *line;
-
- file->cf_Running = 0;
- file->cf_Deleted = 1;
+ pas = getpwnam(user);
+ if (!pas) {
+ crondlog(WARN9 "can't get uid for %s", user);
+ goto err;
+ }
- while ((line = *pline) != NULL) {
- if (line->cl_Pid > 0) {
- file->cf_Running = 1;
- pline = &line->cl_Next;
- } else {
- *pline = line->cl_Next;
- free(line->cl_Shell);
- free(line);
+ /* Prepare things before vfork */
+ set_env_vars(pas);
+
+ /* Fork as the user in question and run program */
+ pid = vfork();
+ if (pid == 0) {
+ /* CHILD */
+ /* initgroups, setgid, setuid, and chdir to home or TMPDIR */
+ change_user(pas);
+ if (DebugOpt) {
+ crondlog(LVL5 "child running %s", DEFAULT_SHELL);
}
- }
- if (file->cf_Running == 0) {
- *pfile = file->cf_Next;
- free(file->cf_User);
- free(file);
- } else {
- pfile = &file->cf_Next;
- }
- } else {
- pfile = &file->cf_Next;
+ /* crond 3.0pl1-100 puts tasks in separate process groups */
+ bb_setpgrp();
+ execl(DEFAULT_SHELL, DEFAULT_SHELL, "-c", line->cl_cmd, (char *) NULL);
+ crondlog(ERR20 "can't execute '%s' for user %s", DEFAULT_SHELL, user);
+ _exit(EXIT_SUCCESS);
+ }
+ if (pid < 0) {
+ /* FORK FAILED */
+ crondlog(ERR20 "can't vfork");
+ err:
+ pid = 0;
}
- }
+ line->cl_pid = pid;
}
+#define process_finished_job(user, line) ((line)->cl_pid = 0)
+
+#endif /* !ENABLE_FEATURE_CROND_CALL_SENDMAIL */
+
/*
- * TestJobs()
- *
- * determine which jobs need to be run. Under normal conditions, the
+ * Determine which jobs need to be run. Under normal conditions, the
* period is about a minute (one scan). Worst case it will be one
* hour (60 scans).
*/
-
-static int
-TestJobs(time_t t1, time_t t2)
+static void flag_starting_jobs(time_t t1, time_t t2)
{
- short nJobs = 0;
- time_t t;
+ time_t t;
- /*
- * Find jobs > t1 and <= t2
- */
+ /* Find jobs > t1 and <= t2 */
- for (t = t1 - t1 % 60; t <= t2; t += 60) {
- if (t > t1) {
- struct tm *tp = localtime(&t);
- CronFile *file;
- CronLine *line;
+ for (t = t1 - t1 % 60; t <= t2; t += 60) {
+ struct tm *ptm;
+ CronFile *file;
+ CronLine *line;
- for (file = FileBase; file; file = file->cf_Next) {
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt)
- log("\005FILE %s:\n", file->cf_User);
-#endif
- if (file->cf_Deleted)
- continue;
- for (line = file->cf_LineBase; line; line = line->cl_Next) {
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt)
- log("\005 LINE %s\n", line->cl_Shell);
-#endif
- if (line->cl_Mins[tp->tm_min] &&
- line->cl_Hrs[tp->tm_hour] &&
- (line->cl_Days[tp->tm_mday] || line->cl_Dow[tp->tm_wday]) &&
- line->cl_Mons[tp->tm_mon]
- ) {
-#ifdef FEATURE_DEBUG_OPT
+ if (t <= t1)
+ continue;
+
+ ptm = localtime(&t);
+ for (file = G.cron_files; file; file = file->cf_next) {
if (DebugOpt)
- log("\005 JobToDo: %d %s\n", line->cl_Pid, line->cl_Shell);
-#endif
- if (line->cl_Pid > 0) {
- log("\010 process already running: %s %s\n",
- file->cf_User,
- line->cl_Shell
- );
- } else if (line->cl_Pid == 0) {
- line->cl_Pid = -1;
- file->cf_Ready = 1;
- ++nJobs;
+ crondlog(LVL5 "file %s:", file->cf_username);
+ if (file->cf_deleted)
+ continue;
+ for (line = file->cf_lines; line; line = line->cl_next) {
+ if (DebugOpt)
+ crondlog(LVL5 " line %s", line->cl_cmd);
+ if (line->cl_Mins[ptm->tm_min]
+ && line->cl_Hrs[ptm->tm_hour]
+ && (line->cl_Days[ptm->tm_mday] || line->cl_Dow[ptm->tm_wday])
+ && line->cl_Mons[ptm->tm_mon]
+ ) {
+ if (DebugOpt) {
+ crondlog(LVL5 " job: %d %s",
+ (int)line->cl_pid, line->cl_cmd);
+ }
+ if (line->cl_pid > 0) {
+ crondlog(LVL8 "user %s: process already running: %s",
+ file->cf_username, line->cl_cmd);
+ } else if (line->cl_pid == 0) {
+ line->cl_pid = -1;
+ file->cf_wants_starting = 1;
+ }
+ }
}
- }
}
- }
}
- }
- return(nJobs);
}
-static void
-RunJobs(void)
+static void start_jobs(void)
{
- CronFile *file;
- CronLine *line;
-
- for (file = FileBase; file; file = file->cf_Next) {
- if (file->cf_Ready) {
- file->cf_Ready = 0;
-
- for (line = file->cf_LineBase; line; line = line->cl_Next) {
- if (line->cl_Pid < 0) {
-
- RunJob(file->cf_User, line);
-
- log("\010USER %s pid %3d cmd %s\n",
- file->cf_User,
- line->cl_Pid,
- line->cl_Shell
- );
- if (line->cl_Pid < 0)
- file->cf_Ready = 1;
- else if (line->cl_Pid > 0)
- file->cf_Running = 1;
+ CronFile *file;
+ CronLine *line;
+
+ for (file = G.cron_files; file; file = file->cf_next) {
+ if (!file->cf_wants_starting)
+ continue;
+
+ file->cf_wants_starting = 0;
+ for (line = file->cf_lines; line; line = line->cl_next) {
+ pid_t pid;
+ if (line->cl_pid >= 0)
+ continue;
+
+ start_one_job(file->cf_username, line);
+ pid = line->cl_pid;
+ crondlog(LVL8 "USER %s pid %3d cmd %s",
+ file->cf_username, (int)pid, line->cl_cmd);
+ if (pid < 0) {
+ file->cf_wants_starting = 1;
+ }
+ if (pid > 0) {
+ file->cf_has_running = 1;
+ }
}
- }
}
- }
}
/*
- * CheckJobs() - check for job completion
- *
* Check for job completion, return number of jobs still running after
* all done.
*/
-
-static int
-CheckJobs(void)
-{
- CronFile *file;
- CronLine *line;
- int nStillRunning = 0;
-
- for (file = FileBase; file; file = file->cf_Next) {
- if (file->cf_Running) {
- file->cf_Running = 0;
-
- for (line = file->cf_LineBase; line; line = line->cl_Next) {
- if (line->cl_Pid > 0) {
- int status;
- int r = wait4(line->cl_Pid, &status, WNOHANG, NULL);
-
- if (r < 0 || r == line->cl_Pid) {
- EndJob(file->cf_User, line);
- if (line->cl_Pid)
- file->cf_Running = 1;
- } else if (r == 0) {
- file->cf_Running = 1;
- }
- }
- }
- }
- nStillRunning += file->cf_Running;
- }
- return(nStillRunning);
-}
-
-
-#ifdef CONFIG_FEATURE_CROND_CALL_SENDMAIL
-static void
-ForkJob(const char *user, CronLine *line, int mailFd,
- const char *prog, const char *cmd, const char *arg, const char *mailf)
+static int check_completions(void)
{
- /*
- * Fork as the user in question and run program
- */
- pid_t pid = fork();
-
- line->cl_Pid = pid;
- if (pid == 0) {
- /*
- * CHILD
- */
-
- /*
- * Change running state to the user in question
- */
-
- if (ChangeUser(user) < 0)
- exit(0);
+ CronFile *file;
+ CronLine *line;
+ int num_still_running = 0;
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt)
- log("\005Child Running %s\n", prog);
-#endif
+ for (file = G.cron_files; file; file = file->cf_next) {
+ if (!file->cf_has_running)
+ continue;
- if (mailFd >= 0) {
- dup2(mailFd, mailf != NULL);
- dup2((mailf ? mailFd : 1), 2);
- close(mailFd);
+ file->cf_has_running = 0;
+ for (line = file->cf_lines; line; line = line->cl_next) {
+ int r;
+
+ if (line->cl_pid <= 0)
+ continue;
+
+ r = waitpid(line->cl_pid, NULL, WNOHANG);
+ if (r < 0 || r == line->cl_pid) {
+ process_finished_job(file->cf_username, line);
+ if (line->cl_pid == 0) {
+ /* sendmail was not started for it */
+ continue;
+ }
+ /* else: sendmail was started, job is still running, fall thru */
+ }
+ /* else: r == 0: "process is still running" */
+ file->cf_has_running = 1;
+ }
+//FIXME: if !file->cf_has_running && file->deleted: delete it!
+//otherwise deleted entries will stay forever, right?
+ num_still_running += file->cf_has_running;
}
- execl(prog, prog, cmd, arg, NULL);
- log("\024unable to exec, user %s cmd %s %s %s\n", user,
- prog, cmd, arg);
- if(mailf)
- fdprintf(1, "Exec failed: %s -c %s\n", prog, arg);
- exit(0);
- } else if (pid < 0) {
- /*
- * FORK FAILED
- */
- log("\024couldn't fork, user %s\n", user);
- line->cl_Pid = 0;
- if(mailf)
- remove(mailf);
- } else if(mailf) {
- /*
- * PARENT, FORK SUCCESS
- *
- * rename mail-file based on pid of process
- */
- char mailFile2[128];
-
- snprintf(mailFile2, sizeof(mailFile2), TMPDIR "/cron.%s.%d",
- user, pid);
- rename(mailf, mailFile2);
- }
- /*
- * Close the mail file descriptor.. we can't just leave it open in
- * a structure, closing it later, because we might run out of descriptors
- */
-
- if (mailFd >= 0)
- close(mailFd);
-}
-
-static void
-RunJob(const char *user, CronLine *line)
-{
- char mailFile[128];
- int mailFd;
-
- line->cl_Pid = 0;
- line->cl_MailFlag = 0;
-
- /*
- * open mail file - owner root so nobody can screw with it.
- */
-
- snprintf(mailFile, sizeof(mailFile), TMPDIR "/cron.%s.%d",
- user, getpid());
- mailFd = open(mailFile, O_CREAT|O_TRUNC|O_WRONLY|O_EXCL|O_APPEND, 0600);
-
- if (mailFd >= 0) {
- line->cl_MailFlag = 1;
- fdprintf(mailFd, "To: %s\nSubject: cron: %s\n\n", user,
- line->cl_Shell);
- line->cl_MailPos = lseek(mailFd, 0, 1);
- } else {
- log("\024unable to create mail file user %s file %s, output to /dev/null\n",
- user, mailFile);
- }
-
- ForkJob(user, line, mailFd, def_sh, "-c", line->cl_Shell, mailFile);
-}
-
-/*
- * EndJob - called when job terminates and when mail terminates
- */
-
-static void
-EndJob(const char *user, CronLine *line)
-{
- int mailFd;
- char mailFile[128];
- struct stat sbuf;
-
- /*
- * No job
- */
-
- if (line->cl_Pid <= 0) {
- line->cl_Pid = 0;
- return;
- }
-
- /*
- * End of job and no mail file
- * End of sendmail job
- */
-
- snprintf(mailFile, sizeof(mailFile), TMPDIR "/cron.%s.%d",
- user, line->cl_Pid);
- line->cl_Pid = 0;
-
- if (line->cl_MailFlag != 1)
- return;
-
- line->cl_MailFlag = 0;
-
- /*
- * End of primary job - check for mail file. If size has increased and
- * the file is still valid, we sendmail it.
- */
-
- mailFd = open(mailFile, O_RDONLY);
- remove(mailFile);
- if (mailFd < 0) {
- return;
- }
-
- if (fstat(mailFd, &sbuf) < 0 ||
- sbuf.st_uid != DaemonUid ||
- sbuf.st_nlink != 0 ||
- sbuf.st_size == line->cl_MailPos ||
- !S_ISREG(sbuf.st_mode)
- ) {
- close(mailFd);
- return;
- }
- ForkJob(user, line, mailFd, SENDMAIL, SENDMAIL_ARGS, NULL);
+ return num_still_running;
}
-#else
-/* crond whithout sendmail */
-static void
-RunJob(const char *user, CronLine *line)
+int crond_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
+int crond_main(int argc UNUSED_PARAM, char **argv)
{
- /*
- * Fork as the user in question and run program
- */
- pid_t pid = fork();
+ time_t t2;
+ int rescan;
+ int sleep_time;
+ unsigned opts;
+
+ INIT_G();
+
+ /* "-b after -f is ignored", and so on for every pair a-b */
+ opt_complementary = "f-b:b-f:S-L:L-S" IF_FEATURE_CROND_D(":d-l")
+ /* -l and -d have numeric param */
+ ":l+" IF_FEATURE_CROND_D(":d+");
+ opts = getopt32(argv, "l:L:fbSc:" IF_FEATURE_CROND_D("d:"),
+ &G.log_level, &G.log_filename, &G.crontab_dir_name
+ IF_FEATURE_CROND_D(,&G.log_level));
+ /* both -d N and -l N set the same variable: G.log_level */
+
+ if (!(opts & OPT_f)) {
+ /* close stdin, stdout, stderr.
+ * close unused descriptors - don't need them. */
+ bb_daemonize_or_rexec(DAEMON_CLOSE_EXTRA_FDS, argv);
+ }
- if (pid == 0) {
- /*
- * CHILD
- */
+ if (!(opts & OPT_d) && G.log_filename == NULL) {
+ /* logging to syslog */
+ openlog(applet_name, LOG_CONS | LOG_PID, LOG_CRON);
+ logmode = LOGMODE_SYSLOG;
+ }
- /*
- * Change running state to the user in question
- */
+ xchdir(G.crontab_dir_name);
+ //signal(SIGHUP, SIG_IGN); /* ? original crond dies on HUP... */
+ xsetenv("SHELL", DEFAULT_SHELL); /* once, for all future children */
+ crondlog(LVL8 "crond (busybox "BB_VER") started, log level %d", G.log_level);
+ rescan_crontab_dir();
+ write_pidfile(CONFIG_PID_FILE_PATH "/crond.pid");
+
+ /* Main loop */
+ t2 = time(NULL);
+ rescan = 60;
+ sleep_time = 60;
+ for (;;) {
+ struct stat sbuf;
+ time_t t1;
+ long dt;
- if (ChangeUser(user) < 0)
- exit(0);
+ t1 = t2;
-#ifdef FEATURE_DEBUG_OPT
- if (DebugOpt)
- log("\005Child Running %s\n", def_sh);
-#endif
+ /* Synchronize to 1 minute, minimum 1 second */
+ sleep(sleep_time - (time(NULL) % sleep_time) + 1);
+
+ t2 = time(NULL);
+ dt = (long)t2 - (long)t1;
+
+ /*
+ * The file 'cron.update' is checked to determine new cron
+ * jobs. The directory is rescanned once an hour to deal
+ * with any screwups.
+ *
+ * Check for time jump. Disparities over an hour either way
+ * result in resynchronization. A negative disparity
+ * less than an hour causes us to effectively sleep until we
+ * match the original time (i.e. no re-execution of jobs that
+ * have just been run). A positive disparity less than
+ * an hour causes intermediate jobs to be run, but only once
+ * in the worst case.
+ *
+ * When running jobs, the inequality used is greater but not
+ * equal to t1, and less then or equal to t2.
+ */
+ if (stat(G.crontab_dir_name, &sbuf) != 0)
+ sbuf.st_mtime = 0; /* force update (once) if dir was deleted */
+ if (G.crontab_dir_mtime != sbuf.st_mtime) {
+ G.crontab_dir_mtime = sbuf.st_mtime;
+ rescan = 1;
+ }
+ if (--rescan == 0) {
+ rescan = 60;
+ rescan_crontab_dir();
+ }
+ process_cron_update_file();
+ if (DebugOpt)
+ crondlog(LVL5 "wakeup dt=%ld", dt);
+ if (dt < -60 * 60 || dt > 60 * 60) {
+ crondlog(WARN9 "time disparity of %ld minutes detected", dt / 60);
+ /* and we do not run any jobs in this case */
+ } else if (dt > 0) {
+ /* Usual case: time advances forward, as expected */
+ flag_starting_jobs(t1, t2);
+ start_jobs();
+ if (check_completions() > 0) {
+ /* some jobs are still running */
+ sleep_time = 10;
+ } else {
+ sleep_time = 60;
+ }
+ }
+ /* else: time jumped back, do not run any jobs */
+ } /* for (;;) */
- execl(def_sh, def_sh, "-c", line->cl_Shell, NULL);
- log("\024unable to exec, user %s cmd %s -c %s\n", user,
- def_sh, line->cl_Shell);
- exit(0);
- } else if (pid < 0) {
- /*
- * FORK FAILED
- */
- log("\024couldn't fork, user %s\n", user);
- pid = 0;
- }
- line->cl_Pid = pid;
+ return 0; /* not reached */
}
-#endif /* CONFIG_FEATURE_CROND_CALL_SENDMAIL */
projects / platform / upstream / busybox.git / blobdiff