Imported Upstream version 1.47.0
[platform/upstream/e2fsprogs.git] / misc / mke2fs.c
index 7ec8cc2..4a9c1b0 100644 (file)
  * enforced (but it's not much fun on a character device :-).
  */
 
-#define _XOPEN_SOURCE 600 /* for inclusion of PATH_MAX in Solaris */
+#define _XOPEN_SOURCE 600
 
 #include "config.h"
 #include <stdio.h>
 #include <string.h>
 #include <strings.h>
-#include <fcntl.h>
 #include <ctype.h>
 #include <time.h>
 #ifdef __linux__
 #include <sys/utsname.h>
+#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))
 #endif
 #ifdef HAVE_GETOPT_H
 #include <getopt.h>
@@ -43,25 +43,25 @@ extern int optind;
 #ifdef HAVE_ERRNO_H
 #include <errno.h>
 #endif
+#ifdef HAVE_SYS_IOCTL_H
 #include <sys/ioctl.h>
-#include <sys/types.h>
-#include <sys/stat.h>
+#endif
 #include <libgen.h>
 #include <limits.h>
 #include <blkid/blkid.h>
 
 #include "ext2fs/ext2_fs.h"
 #include "ext2fs/ext2fsP.h"
-#include "et/com_err.h"
 #include "uuid/uuid.h"
-#include "e2p/e2p.h"
-#include "ext2fs/ext2fs.h"
 #include "util.h"
-#include "profile.h"
-#include "prof_err.h"
+#include "support/nls-enable.h"
+#include "support/plausible.h"
+#include "support/profile.h"
+#include "support/prof_err.h"
 #include "../version.h"
-#include "nls-enable.h"
-#include "quota/mkquota.h"
+#include "support/quotaio.h"
+#include "mke2fs.h"
+#include "create_inode.h"
 
 #define STRIDE_LENGTH 8
 
@@ -77,50 +77,71 @@ extern int isatty(int);
 extern FILE *fpopen(const char *cmd, const char *mode);
 
 const char * program_name = "mke2fs";
-const char * device_name /* = NULL */;
+static const char * device_name /* = NULL */;
 
 /* Command line options */
-int    cflag;
+static int     cflag;
 int    verbose;
 int    quiet;
-int    super_only;
-int    discard = 1;    /* attempt to discard device before fs creation */
-int    direct_io;
-int    force;
-int    noaction;
+static int     super_only;
+static int     discard = 1;    /* attempt to discard device before fs creation */
+static int     direct_io;
+static int     force;
+static int     noaction;
+static int     num_backups = 2; /* number of backup bg's for sparse_super2 */
+static uid_t   root_uid;
+static gid_t   root_gid;
 int    journal_size;
 int    journal_flags;
-int    lazy_itable_init;
-char   *bad_blocks_filename;
-__u32  fs_stride;
-int    quotatype = -1;  /* Initialize both user and group quotas by default */
-
-struct ext2_super_block fs_param;
-char *fs_uuid = NULL;
-char *creator_os;
-char *volume_label;
-char *mount_dir;
+int    journal_fc_size;
+static e2_blkcnt_t     orphan_file_blocks;
+static int     lazy_itable_init;
+static int     assume_storage_prezeroed;
+static int     packed_meta_blocks;
+int            no_copy_xattrs;
+static char    *bad_blocks_filename = NULL;
+static __u32   fs_stride;
+/* Initialize usr/grp quotas by default */
+static unsigned int quotatype_bits = (QUOTA_USR_BIT | QUOTA_GRP_BIT);
+static __u64   offset;
+static blk64_t journal_location = ~0LL;
+static int     proceed_delay = -1;
+static blk64_t dev_size;
+
+static struct ext2_super_block fs_param;
+static __u32 zero_buf[4];
+static char *fs_uuid = NULL;
+static char *creator_os;
+static char *volume_label;
+static char *mount_dir;
 char *journal_device;
-int sync_kludge;       /* Set using the MKE2FS_SYNC env. option */
+static int sync_kludge;        /* Set using the MKE2FS_SYNC env. option */
 char **fs_types;
+const char *src_root_dir;  /* Copy files from the specified directory */
+static char *undo_file;
+
+static int android_sparse_file; /* -E android_sparse */
 
-profile_t      profile;
+static profile_t       profile;
 
-int sys_page_size = 4096;
-int linux_version_code = 0;
+static int sys_page_size = 4096;
+
+static int errors_behavior = 0;
 
 static void usage(void)
 {
        fprintf(stderr, _("Usage: %s [-c|-l filename] [-b block-size] "
        "[-C cluster-size]\n\t[-i bytes-per-inode] [-I inode-size] "
        "[-J journal-options]\n"
-       "\t[-G flex-group-size] [-N number-of-inodes]\n"
+       "\t[-G flex-group-size] [-N number-of-inodes] "
+       "[-d root-directory]\n"
        "\t[-m reserved-blocks-percentage] [-o creator-os]\n"
        "\t[-g blocks-per-group] [-L volume-label] "
        "[-M last-mounted-directory]\n\t[-O feature[,...]] "
        "[-r fs-revision] [-E extended-option[,...]]\n"
-       "\t[-t fs-type] [-T usage-type ] [-U UUID] "
-       "[-jnqvDFKSV] device [blocks-count]\n"),
+       "\t[-t fs-type] [-T usage-type ] [-U UUID] [-e errors_behavior]"
+       "[-z undo_file]\n"
+       "\t[-jnqvDFSV] device [blocks-count]\n"),
                program_name);
        exit(1);
 }
@@ -137,7 +158,7 @@ static int int_log2(unsigned long long arg)
        return l;
 }
 
-static int int_log10(unsigned long long arg)
+int int_log10(unsigned long long arg)
 {
        int     l;
 
@@ -146,6 +167,7 @@ static int int_log10(unsigned long long arg)
        return l;
 }
 
+#ifdef __linux__
 static int parse_version_number(const char *s)
 {
        int     major, minor, rev;
@@ -165,8 +187,33 @@ static int parse_version_number(const char *s)
        rev = strtol(cp, &endptr, 10);
        if (cp == endptr)
                return 0;
-       return ((((major * 256) + minor) * 256) + rev);
+       return KERNEL_VERSION(major, minor, rev);
+}
+
+static int is_before_linux_ver(unsigned int major, unsigned int minor,
+                              unsigned int rev)
+{
+       struct          utsname ut;
+       static int      linux_version_code = -1;
+
+       if (uname(&ut)) {
+               perror("uname");
+               exit(1);
+       }
+       if (linux_version_code < 0)
+               linux_version_code = parse_version_number(ut.release);
+       if (linux_version_code == 0)
+               return 0;
+
+       return linux_version_code < (int) KERNEL_VERSION(major, minor, rev);
+}
+#else
+static int is_before_linux_ver(unsigned int major, unsigned int minor,
+                              unsigned int rev)
+{
+       return 0;
 }
+#endif
 
 /*
  * Helper function for read_bb_file and test_disk
@@ -195,7 +242,7 @@ static void read_bb_file(ext2_filsys fs, badblocks_list *bb_list,
        retval = ext2fs_read_bb_FILE(fs, f, bb_list, invalid_block);
        fclose (f);
        if (retval) {
-               com_err("ext2fs_read_bb_FILE", retval,
+               com_err("ext2fs_read_bb_FILE", retval, "%s",
                        _("while reading in list of bad blocks from file"));
                exit(1);
        }
@@ -212,7 +259,8 @@ static void test_disk(ext2_filsys fs, badblocks_list *bb_list)
 
        sprintf(buf, "badblocks -b %d -X %s%s%s %llu", fs->blocksize,
                quiet ? "" : "-s ", (cflag > 1) ? "-w " : "",
-               fs->device_name, ext2fs_blocks_count(fs->super)-1);
+               fs->device_name,
+               (unsigned long long) ext2fs_blocks_count(fs->super)-1);
        if (verbose)
                printf(_("Running command: %s\n"), buf);
        f = popen(buf, "r");
@@ -224,7 +272,7 @@ static void test_disk(ext2_filsys fs, badblocks_list *bb_list)
        retval = ext2fs_read_bb_FILE(fs, f, bb_list, invalid_block);
        pclose(f);
        if (retval) {
-               com_err("ext2fs_read_bb_FILE", retval,
+               com_err("ext2fs_read_bb_FILE", retval, "%s",
                        _("while processing list of bad blocks from program"));
                exit(1);
        }
@@ -295,15 +343,75 @@ _("Warning: the backup superblock/group descriptors at block %u contain\n"
         */
        retval = ext2fs_badblocks_list_iterate_begin(bb_list, &bb_iter);
        if (retval) {
-               com_err("ext2fs_badblocks_list_iterate_begin", retval,
+               com_err("ext2fs_badblocks_list_iterate_begin", retval, "%s",
                        _("while marking bad blocks as used"));
                exit(1);
        }
        while (ext2fs_badblocks_list_iterate(bb_iter, &blk))
-               ext2fs_mark_block_bitmap2(fs->block_map, EXT2FS_B2C(fs, blk));
+               ext2fs_mark_block_bitmap2(fs->block_map, blk);
        ext2fs_badblocks_list_iterate_end(bb_iter);
 }
 
+static void write_reserved_inodes(ext2_filsys fs)
+{
+       errcode_t       retval;
+       ext2_ino_t      ino;
+       struct ext2_inode *inode;
+
+       retval = ext2fs_get_memzero(EXT2_INODE_SIZE(fs->super), &inode);
+       if (retval) {
+               com_err("inode_init", retval, _("while allocating memory"));
+               exit(1);
+       }
+
+       for (ino = 1; ino < EXT2_FIRST_INO(fs->super); ino++) {
+               retval = ext2fs_write_inode_full(fs, ino, inode,
+                                                EXT2_INODE_SIZE(fs->super));
+               if (retval) {
+                       com_err("ext2fs_write_inode_full", retval,
+                               _("while writing reserved inodes"));
+                       exit(1);
+               }
+       }
+
+       ext2fs_free_mem(&inode);
+}
+
+static errcode_t packed_allocate_tables(ext2_filsys fs)
+{
+       errcode_t       retval;
+       dgrp_t          i;
+       blk64_t         goal = 0;
+
+       for (i = 0; i < fs->group_desc_count; i++) {
+               retval = ext2fs_new_block2(fs, goal, NULL, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats2(fs, goal, +1);
+               ext2fs_block_bitmap_loc_set(fs, i, goal);
+       }
+       for (i = 0; i < fs->group_desc_count; i++) {
+               retval = ext2fs_new_block2(fs, goal, NULL, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats2(fs, goal, +1);
+               ext2fs_inode_bitmap_loc_set(fs, i, goal);
+       }
+       for (i = 0; i < fs->group_desc_count; i++) {
+               blk64_t end = ext2fs_blocks_count(fs->super) - 1;
+               retval = ext2fs_get_free_blocks2(fs, goal, end,
+                                                fs->inode_blocks_per_group,
+                                                fs->block_map, &goal);
+               if (retval)
+                       return retval;
+               ext2fs_block_alloc_stats_range(fs, goal,
+                                              fs->inode_blocks_per_group, +1);
+               ext2fs_inode_table_loc_set(fs, i, goal);
+               ext2fs_group_desc_csum_set(fs, i);
+       }
+       return 0;
+}
+
 static void write_inode_tables(ext2_filsys fs, int lazy_flag, int itable_zeroed)
 {
        errcode_t       retval;
@@ -332,54 +440,58 @@ static void write_inode_tables(ext2_filsys fs, int lazy_flag, int itable_zeroed)
                        ext2fs_bg_flags_set(fs, i, EXT2_BG_INODE_ZEROED);
                        ext2fs_group_desc_csum_set(fs, i);
                }
-               retval = ext2fs_zero_blocks2(fs, blk, num, &blk, &num);
-               if (retval) {
-                       fprintf(stderr, _("\nCould not write %d "
-                                 "blocks in inode table starting at %llu: %s\n"),
-                               num, blk, error_message(retval));
-                       exit(1);
+               if (!itable_zeroed) {
+                       retval = ext2fs_zero_blocks2(fs, blk, num, &blk, &num);
+                       if (retval) {
+                               fprintf(stderr, _("\nCould not write %d "
+                                         "blocks in inode table starting at %llu: %s\n"),
+                                       num, (unsigned long long) blk,
+                                       error_message(retval));
+                               exit(1);
+                       }
                }
                if (sync_kludge) {
                        if (sync_kludge == 1)
-                               sync();
+                               io_channel_flush(fs->io);
                        else if ((i % sync_kludge) == 0)
-                               sync();
+                               io_channel_flush(fs->io);
                }
        }
-       ext2fs_zero_blocks2(0, 0, 0, 0, 0);
        ext2fs_numeric_progress_close(fs, &progress,
                                      _("done                            \n"));
+
+       /* Reserved inodes must always have correct checksums */
+       if (ext2fs_has_feature_metadata_csum(fs->super))
+               write_reserved_inodes(fs);
 }
 
 static void create_root_dir(ext2_filsys fs)
 {
        errcode_t               retval;
        struct ext2_inode       inode;
-       __u32                   uid, gid;
 
        retval = ext2fs_mkdir(fs, EXT2_ROOT_INO, EXT2_ROOT_INO, 0);
        if (retval) {
-               com_err("ext2fs_mkdir", retval, _("while creating root dir"));
+               com_err("ext2fs_mkdir", retval, "%s",
+                       _("while creating root dir"));
                exit(1);
        }
-       if (geteuid()) {
+       if (root_uid != 0 || root_gid != 0) {
                retval = ext2fs_read_inode(fs, EXT2_ROOT_INO, &inode);
                if (retval) {
-                       com_err("ext2fs_read_inode", retval,
+                       com_err("ext2fs_read_inode", retval, "%s",
                                _("while reading root inode"));
                        exit(1);
                }
-               uid = getuid();
-               inode.i_uid = uid;
-               ext2fs_set_i_uid_high(inode, uid >> 16);
-               if (uid) {
-                       gid = getgid();
-                       inode.i_gid = gid;
-                       ext2fs_set_i_gid_high(inode, gid >> 16);
-               }
+
+               inode.i_uid = root_uid;
+               ext2fs_set_i_uid_high(inode, root_uid >> 16);
+               inode.i_gid = root_gid;
+               ext2fs_set_i_gid_high(inode, root_gid >> 16);
+
                retval = ext2fs_write_new_inode(fs, EXT2_ROOT_INO, &inode);
                if (retval) {
-                       com_err("ext2fs_write_inode", retval,
+                       com_err("ext2fs_write_inode", retval, "%s",
                                _("while setting root inode ownership"));
                        exit(1);
                }
@@ -397,14 +509,14 @@ static void create_lost_and_found(ext2_filsys fs)
        fs->umask = 077;
        retval = ext2fs_mkdir(fs, EXT2_ROOT_INO, 0, name);
        if (retval) {
-               com_err("ext2fs_mkdir", retval,
+               com_err("ext2fs_mkdir", retval, "%s",
                        _("while creating /lost+found"));
                exit(1);
        }
 
        retval = ext2fs_lookup(fs, EXT2_ROOT_INO, name, strlen(name), 0, &ino);
        if (retval) {
-               com_err("ext2_lookup", retval,
+               com_err("ext2_lookup", retval, "%s",
                        _("while looking up /lost+found"));
                exit(1);
        }
@@ -417,7 +529,7 @@ static void create_lost_and_found(ext2_filsys fs)
                        break;
                retval = ext2fs_expand_dir(fs, ino);
                if (retval) {
-                       com_err("ext2fs_expand_dir", retval,
+                       com_err("ext2fs_expand_dir", retval, "%s",
                                _("while expanding /lost+found"));
                        exit(1);
                }
@@ -432,7 +544,7 @@ static void create_bad_block_inode(ext2_filsys fs, badblocks_list bb_list)
        ext2fs_inode_alloc_stats2(fs, EXT2_BAD_INO, +1, 0);
        retval = ext2fs_update_bb_inode(fs, bb_list);
        if (retval) {
-               com_err("ext2fs_update_bb_inode", retval,
+               com_err("ext2fs_update_bb_inode", retval, "%s",
                        _("while setting bad block inode"));
                exit(1);
        }
@@ -458,7 +570,7 @@ static void zap_sector(ext2_filsys fs, int sect, int nsect)
        int retval;
        unsigned int *magic;
 
-       buf = malloc(512*nsect);
+       buf = calloc(512, nsect);
        if (!buf) {
                printf(_("Out of memory erasing sectors %d-%d\n"),
                       sect, sect + nsect - 1);
@@ -475,8 +587,10 @@ static void zap_sector(ext2_filsys fs, int sect, int nsect)
                else {
                        magic = (unsigned int *) (buf + BSD_LABEL_OFFSET);
                        if ((*magic == BSD_DISKMAGIC) ||
-                           (*magic == BSD_MAGICDISK))
+                           (*magic == BSD_MAGICDISK)) {
+                               free(buf);
                                return;
+                       }
                }
        }
 
@@ -497,11 +611,18 @@ static void create_journal_dev(ext2_filsys fs)
        char                    *buf;
        blk64_t                 blk, err_blk;
        int                     c, count, err_count;
+       struct ext2fs_journal_params    jparams;
+
+       retval = ext2fs_get_journal_params(&jparams, fs);
+       if (retval) {
+               com_err("create_journal_dev", retval, "%s",
+                       _("while splitting the journal size"));
+               exit(1);
+       }
 
-       retval = ext2fs_create_journal_superblock(fs,
-                                 ext2fs_blocks_count(fs->super), 0, &buf);
+       retval = ext2fs_create_journal_superblock2(fs, &jparams, 0, &buf);
        if (retval) {
-               com_err("create_journal_dev", retval,
+               com_err("create_journal_dev", retval, "%s",
                        _("while initializing journal superblock"));
                exit(1);
        }
@@ -524,22 +645,22 @@ static void create_journal_dev(ext2_filsys fs)
                        com_err("create_journal_dev", retval,
                                _("while zeroing journal device "
                                  "(block %llu, count %d)"),
-                               err_blk, err_count);
+                               (unsigned long long) err_blk, err_count);
                        exit(1);
                }
                blk += c;
                count -= c;
                ext2fs_numeric_progress_update(fs, &progress, blk);
        }
-       ext2fs_zero_blocks2(0, 0, 0, 0, 0);
 
        ext2fs_numeric_progress_close(fs, &progress, NULL);
 write_superblock:
        retval = io_channel_write_blk64(fs->io,
                                        fs->super->s_first_data_block+1,
                                        1, buf);
+       (void) ext2fs_free_mem(&buf);
        if (retval) {
-               com_err("create_journal_dev", retval,
+               com_err("create_journal_dev", retval, "%s",
                        _("while writing journal superblock"));
                exit(1);
        }
@@ -548,27 +669,33 @@ write_superblock:
 static void show_stats(ext2_filsys fs)
 {
        struct ext2_super_block *s = fs->super;
-       char                    buf[80];
         char                    *os;
        blk64_t                 group_block;
        dgrp_t                  i;
        int                     need, col_left;
 
+       if (!verbose) {
+               printf(_("Creating filesystem with %llu %dk blocks and "
+                        "%u inodes\n"),
+                      (unsigned long long) ext2fs_blocks_count(s),
+                      fs->blocksize >> 10, s->s_inodes_count);
+               goto skip_details;
+       }
+
        if (ext2fs_blocks_count(&fs_param) != ext2fs_blocks_count(s))
                fprintf(stderr, _("warning: %llu blocks unused.\n\n"),
-                      ext2fs_blocks_count(&fs_param) - ext2fs_blocks_count(s));
+                       (unsigned long long) (ext2fs_blocks_count(&fs_param) -
+                                             ext2fs_blocks_count(s)));
+
+       printf(_("Filesystem label=%.*s\n"), EXT2_LEN_STR(s->s_volume_name));
 
-       memset(buf, 0, sizeof(buf));
-       strncpy(buf, s->s_volume_name, sizeof(s->s_volume_name));
-       printf(_("Filesystem label=%s\n"), buf);
        os = e2p_os2string(fs->super->s_creator_os);
        if (os)
                printf(_("OS type: %s\n"), os);
        free(os);
        printf(_("Block size=%u (log=%u)\n"), fs->blocksize,
                s->s_log_block_size);
-       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
-                                      EXT4_FEATURE_RO_COMPAT_BIGALLOC))
+       if (ext2fs_has_feature_bigalloc(fs->super))
                printf(_("Cluster size=%u (log=%u)\n"),
                       fs->blocksize << fs->cluster_ratio_bits,
                       s->s_log_cluster_size);
@@ -578,11 +705,13 @@ static void show_stats(ext2_filsys fs)
        printf(_("Stride=%u blocks, Stripe width=%u blocks\n"),
               s->s_raid_stride, s->s_raid_stripe_width);
        printf(_("%u inodes, %llu blocks\n"), s->s_inodes_count,
-              ext2fs_blocks_count(s));
+              (unsigned long long) ext2fs_blocks_count(s));
        printf(_("%llu blocks (%2.2f%%) reserved for the super user\n"),
-               ext2fs_r_blocks_count(s),
+              (unsigned long long) ext2fs_r_blocks_count(s),
               100.0 *  ext2fs_r_blocks_count(s) / ext2fs_blocks_count(s));
        printf(_("First data block=%u\n"), s->s_first_data_block);
+       if (root_uid != 0 || root_gid != 0)
+               printf(_("Root directory owner=%u:%u\n"), root_uid, root_gid);
        if (s->s_reserved_gdt_blocks)
                printf(_("Maximum filesystem blocks=%lu\n"),
                       (s->s_reserved_gdt_blocks + fs->desc_blocks) *
@@ -591,8 +720,7 @@ static void show_stats(ext2_filsys fs)
                printf(_("%u block groups\n"), fs->group_desc_count);
        else
                printf(_("%u block group\n"), fs->group_desc_count);
-       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
-                                      EXT4_FEATURE_RO_COMPAT_BIGALLOC))
+       if (ext2fs_has_feature_bigalloc(fs->super))
                printf(_("%u blocks per group, %u clusters per group\n"),
                       s->s_blocks_per_group, s->s_clusters_per_group);
        else
@@ -600,12 +728,15 @@ static void show_stats(ext2_filsys fs)
                       s->s_blocks_per_group, s->s_clusters_per_group);
        printf(_("%u inodes per group\n"), s->s_inodes_per_group);
 
+skip_details:
        if (fs->group_desc_count == 1) {
                printf("\n");
                return;
        }
 
-       printf(_("Superblock backups stored on blocks: "));
+       if (!e2p_is_null_uuid(s->s_uuid))
+               printf(_("Filesystem UUID: %s\n"), e2p_uuid2str(s->s_uuid));
+       printf("%s", _("Superblock backups stored on blocks: "));
        group_block = s->s_first_data_block;
        col_left = 0;
        for (i = 1; i < fs->group_desc_count; i++) {
@@ -620,12 +751,29 @@ static void show_stats(ext2_filsys fs)
                        col_left = 72;
                }
                col_left -= need;
-               printf("%llu", group_block);
+               printf("%llu", (unsigned long long) group_block);
        }
        printf("\n\n");
 }
 
 /*
+ * Returns true if making a file system for the Hurd, else 0
+ */
+static int for_hurd(const char *os)
+{
+       if (!os) {
+#ifdef __GNU__
+               return 1;
+#else
+               return 0;
+#endif
+       }
+       if (isdigit(*os))
+               return (atoi(os) == EXT2_OS_HURD);
+       return (strcasecmp(os, "GNU") == 0 || strcasecmp(os, "hurd") == 0);
+}
+
+/*
  * Set the S_CREATOR_OS field.  Return true if OS is known,
  * otherwise, 0.
  */
@@ -654,11 +802,14 @@ static void parse_extended_opts(struct ext2_super_block *param,
        char    *buf, *token, *next, *p, *arg, *badopt = 0;
        int     len;
        int     r_usage = 0;
+       int     ret;
+       int     encoding = -1;
+       char    *encoding_flags = NULL;
 
        len = strlen(opts);
        buf = malloc(len+1);
        if (!buf) {
-               fprintf(stderr,
+               fprintf(stderr, "%s",
                        _("Couldn't allocate memory to parse options!\n"));
                exit(1);
        }
@@ -675,7 +826,63 @@ static void parse_extended_opts(struct ext2_super_block *param,
                        *arg = 0;
                        arg++;
                }
-               if (strcmp(token, "mmp_update_interval") == 0) {
+               if (strcmp(token, "desc-size") == 0 ||
+                   strcmp(token, "desc_size") == 0) {
+                       int desc_size;
+
+                       if (!ext2fs_has_feature_64bit(&fs_param)) {
+                               fprintf(stderr,
+                                       _("%s requires '-O 64bit'\n"), token);
+                               r_usage++;
+                               continue;
+                       }
+                       if (param->s_reserved_gdt_blocks != 0) {
+                               fprintf(stderr,
+                                       _("'%s' must be before 'resize=%u'\n"),
+                                       token, param->s_reserved_gdt_blocks);
+                               r_usage++;
+                               continue;
+                       }
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       desc_size = strtoul(arg, &p, 0);
+                       if (*p || (desc_size & (desc_size - 1))) {
+                               fprintf(stderr,
+                                       _("Invalid desc_size: '%s'\n"), arg);
+                               r_usage++;
+                               continue;
+                       }
+                       param->s_desc_size = desc_size;
+               } else if (strcmp(token, "hash_seed") == 0) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       if (uuid_parse(arg,
+                               (unsigned char *)param->s_hash_seed) != 0) {
+                               fprintf(stderr,
+                                       _("Invalid hash seed: %s\n"), arg);
+                               r_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "offset") == 0) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       offset = strtoull(arg, &p, 0);
+                       if (*p) {
+                               fprintf(stderr, _("Invalid offset: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "mmp_update_interval") == 0) {
                        if (!arg) {
                                r_usage++;
                                badopt = token;
@@ -689,6 +896,31 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                r_usage++;
                                continue;
                        }
+               } else if (strcmp(token, "no_copy_xattrs") == 0) {
+                       no_copy_xattrs = 1;
+                       continue;
+               } else if (strcmp(token, "num_backup_sb") == 0) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       num_backups = strtoul(arg, &p, 0);
+                       if (*p || num_backups > 2) {
+                               fprintf(stderr,
+                                       _("Invalid # of backup "
+                                         "superblocks: %s\n"),
+                                       arg);
+                               r_usage++;
+                               continue;
+                       }
+               } else if (strcmp(token, "packed_meta_blocks") == 0) {
+                       if (arg)
+                               packed_meta_blocks = strtoul(arg, &p, 0);
+                       else
+                               packed_meta_blocks = 1;
+                       if (packed_meta_blocks)
+                               journal_location = 0;
                } else if (strcmp(token, "stride") == 0) {
                        if (!arg) {
                                r_usage++;
@@ -742,7 +974,7 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                continue;
                        }
                        if (resize <= ext2fs_blocks_count(param)) {
-                               fprintf(stderr,
+                               fprintf(stderr, "%s",
                                        _("The resize maximum must be greater "
                                          "than the filesystem size.\n"));
                                r_usage++;
@@ -766,13 +998,12 @@ static void parse_extended_opts(struct ext2_super_block *param,
 
                        if (rsv_gdb > 0) {
                                if (param->s_rev_level == EXT2_GOOD_OLD_REV) {
-                                       fprintf(stderr,
+                                       fprintf(stderr, "%s",
        _("On-line resizing not supported with revision 0 filesystems\n"));
                                        free(buf);
                                        exit(1);
                                }
-                               param->s_feature_compat |=
-                                       EXT2_FEATURE_COMPAT_RESIZE_INODE;
+                               ext2fs_set_feature_resize_inode(param);
 
                                param->s_reserved_gdt_blocks = rsv_gdb;
                        }
@@ -783,29 +1014,99 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                lazy_itable_init = strtoul(arg, &p, 0);
                        else
                                lazy_itable_init = 1;
+               } else if (!strcmp(token, "assume_storage_prezeroed")) {
+                       if (arg)
+                               assume_storage_prezeroed = strtoul(arg, &p, 0);
+                       else
+                               assume_storage_prezeroed = 1;
                } else if (!strcmp(token, "lazy_journal_init")) {
                        if (arg)
                                journal_flags |= strtoul(arg, &p, 0) ?
                                                EXT2_MKJOURNAL_LAZYINIT : 0;
                        else
                                journal_flags |= EXT2_MKJOURNAL_LAZYINIT;
+               } else if (!strcmp(token, "root_owner")) {
+                       if (arg) {
+                               root_uid = strtoul(arg, &p, 0);
+                               if (*p != ':') {
+                                       fprintf(stderr,
+                                               _("Invalid root_owner: '%s'\n"),
+                                               arg);
+                                       r_usage++;
+                                       continue;
+                               }
+                               p++;
+                               root_gid = strtoul(p, &p, 0);
+                               if (*p) {
+                                       fprintf(stderr,
+                                               _("Invalid root_owner: '%s'\n"),
+                                               arg);
+                                       r_usage++;
+                                       continue;
+                               }
+                       } else {
+                               root_uid = getuid();
+                               root_gid = getgid();
+                       }
                } else if (!strcmp(token, "discard")) {
                        discard = 1;
                } else if (!strcmp(token, "nodiscard")) {
                        discard = 0;
                } else if (!strcmp(token, "quotatype")) {
+                       char *errtok = NULL;
+
                        if (!arg) {
                                r_usage++;
                                badopt = token;
                                continue;
                        }
-                       if (!strncmp(arg, "usr", 3)) {
-                               quotatype = 0;
-                       } else if (!strncmp(arg, "grp", 3)) {
-                               quotatype = 1;
-                       } else {
+                       quotatype_bits = 0;
+                       ret = parse_quota_types(arg, &quotatype_bits, &errtok);
+                       if (ret) {
+                               if (errtok) {
+                                       fprintf(stderr,
+                               "Failed to parse quota type at %s", errtok);
+                                       free(errtok);
+                               } else
+                                       com_err(program_name, ret,
+                                               "while parsing quota type");
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+               } else if (!strcmp(token, "android_sparse")) {
+                       android_sparse_file = 1;
+               } else if (!strcmp(token, "encoding")) {
+                       if (!arg) {
+                               r_usage++;
+                               continue;
+                       }
+
+                       encoding = e2p_str2encoding(arg);
+                       if (encoding < 0) {
+                               fprintf(stderr, _("Invalid encoding: %s"), arg);
+                               r_usage++;
+                               continue;
+                       }
+                       param->s_encoding = encoding;
+                       ext2fs_set_feature_casefold(param);
+               } else if (!strcmp(token, "encoding_flags")) {
+                       if (!arg) {
+                               r_usage++;
+                               continue;
+                       }
+                       encoding_flags = arg;
+               } else if (!strcmp(token, "orphan_file_size")) {
+                       if (!arg) {
+                               r_usage++;
+                               badopt = token;
+                               continue;
+                       }
+                       orphan_file_blocks = parse_num_blocks2(arg,
+                                               fs_param.s_log_block_size);
+                       if (orphan_file_blocks == 0) {
                                fprintf(stderr,
-                                       _("Invalid quotatype parameter: %s\n"),
+                                       _("Invalid size of orphan file %s\n"),
                                        arg);
                                r_usage++;
                                continue;
@@ -821,15 +1122,23 @@ static void parse_extended_opts(struct ext2_super_block *param,
                        "and may take an argument which\n"
                        "\tis set off by an equals ('=') sign.\n\n"
                        "Valid extended options are:\n"
+                       "\tmmp_update_interval=<interval>\n"
+                       "\tnum_backup_sb=<0|1|2>\n"
                        "\tstride=<RAID per-disk data chunk in blocks>\n"
                        "\tstripe-width=<RAID stride * data disks in blocks>\n"
+                       "\toffset=<offset to create the file system>\n"
                        "\tresize=<resize maximum size in blocks>\n"
+                       "\tpacked_meta_blocks=<0 to disable, 1 to enable>\n"
                        "\tlazy_itable_init=<0 to disable, 1 to enable>\n"
                        "\tlazy_journal_init=<0 to disable, 1 to enable>\n"
+                       "\troot_owner=<uid of root dir>:<gid of root dir>\n"
                        "\ttest_fs\n"
                        "\tdiscard\n"
                        "\tnodiscard\n"
-                       "\tquotatype=<usr OR grp>\n\n"),
+                       "\tencoding=<encoding>\n"
+                       "\tencoding_flags=<flags>\n"
+                       "\tquotatype=<quota type(s) to be enabled>\n"
+                       "\tassume_storage_prezeroed=<0 to disable, 1 to enable>\n\n"),
                        badopt ? badopt : "");
                free(buf);
                exit(1);
@@ -840,6 +1149,25 @@ static void parse_extended_opts(struct ext2_super_block *param,
                                  "multiple of stride %u.\n\n"),
                        param->s_raid_stripe_width, param->s_raid_stride);
 
+       if (ext2fs_has_feature_casefold(param)) {
+               param->s_encoding_flags =
+                       e2p_get_encoding_flags(param->s_encoding);
+
+               if (encoding_flags &&
+                   e2p_str2encoding_flags(param->s_encoding, encoding_flags,
+                                          &param->s_encoding_flags)) {
+                       fprintf(stderr, _("error: Invalid encoding flag: %s\n"),
+                               encoding_flags);
+                       free(buf);
+                       exit(1);
+               }
+       } else if (encoding_flags) {
+               fprintf(stderr, _("error: An encoding must be explicitly "
+                                 "specified when passing encoding-flags\n"));
+               free(buf);
+               exit(1);
+       }
+
        free(buf);
 }
 
@@ -848,15 +1176,25 @@ static __u32 ok_features[3] = {
        EXT3_FEATURE_COMPAT_HAS_JOURNAL |
                EXT2_FEATURE_COMPAT_RESIZE_INODE |
                EXT2_FEATURE_COMPAT_DIR_INDEX |
-               EXT2_FEATURE_COMPAT_EXT_ATTR,
+               EXT2_FEATURE_COMPAT_EXT_ATTR |
+               EXT4_FEATURE_COMPAT_SPARSE_SUPER2 |
+               EXT4_FEATURE_COMPAT_FAST_COMMIT |
+               EXT4_FEATURE_COMPAT_STABLE_INODES |
+               EXT4_FEATURE_COMPAT_ORPHAN_FILE,
        /* Incompat */
        EXT2_FEATURE_INCOMPAT_FILETYPE|
                EXT3_FEATURE_INCOMPAT_EXTENTS|
                EXT3_FEATURE_INCOMPAT_JOURNAL_DEV|
                EXT2_FEATURE_INCOMPAT_META_BG|
                EXT4_FEATURE_INCOMPAT_FLEX_BG|
+               EXT4_FEATURE_INCOMPAT_EA_INODE|
                EXT4_FEATURE_INCOMPAT_MMP |
-               EXT4_FEATURE_INCOMPAT_64BIT,
+               EXT4_FEATURE_INCOMPAT_64BIT|
+               EXT4_FEATURE_INCOMPAT_INLINE_DATA|
+               EXT4_FEATURE_INCOMPAT_ENCRYPT |
+               EXT4_FEATURE_INCOMPAT_CASEFOLD |
+               EXT4_FEATURE_INCOMPAT_CSUM_SEED |
+               EXT4_FEATURE_INCOMPAT_LARGEDIR,
        /* R/O compat */
        EXT2_FEATURE_RO_COMPAT_LARGE_FILE|
                EXT4_FEATURE_RO_COMPAT_HUGE_FILE|
@@ -865,10 +1203,10 @@ static __u32 ok_features[3] = {
                EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER|
                EXT4_FEATURE_RO_COMPAT_GDT_CSUM|
                EXT4_FEATURE_RO_COMPAT_BIGALLOC|
-#ifdef CONFIG_QUOTA
                EXT4_FEATURE_RO_COMPAT_QUOTA|
-#endif
-               0
+               EXT4_FEATURE_RO_COMPAT_METADATA_CSUM|
+               EXT4_FEATURE_RO_COMPAT_PROJECT|
+               EXT4_FEATURE_RO_COMPAT_VERITY
 };
 
 
@@ -915,7 +1253,7 @@ struct str_list {
 static errcode_t init_list(struct str_list *sl)
 {
        sl->num = 0;
-       sl->max = 0;
+       sl->max = 1;
        sl->list = malloc((sl->max+1) * sizeof(char *));
        if (!sl->list)
                return ENOMEM;
@@ -958,7 +1296,7 @@ static void print_str_list(char **list)
 /*
  * Return TRUE if the profile has the given subsection
  */
-static int profile_has_subsection(profile_t profile, const char *section,
+static int profile_has_subsection(profile_t prof, const char *section,
                                  const char *subsection)
 {
        void                    *state;
@@ -970,7 +1308,7 @@ static int profile_has_subsection(profile_t profile, const char *section,
        names[1] = subsection;
        names[2] = 0;
 
-       if (profile_iterator_create(profile, names,
+       if (profile_iterator_create(prof, names,
                                    PROFILE_ITER_LIST_SECTION |
                                    PROFILE_ITER_RELATIONS_ONLY, &state))
                return 0;
@@ -986,7 +1324,7 @@ static int profile_has_subsection(profile_t profile, const char *section,
 
 static char **parse_fs_type(const char *fs_type,
                            const char *usage_types,
-                           struct ext2_super_block *fs_param,
+                           struct ext2_super_block *sb,
                            blk64_t fs_blocks_count,
                            char *progname)
 {
@@ -997,15 +1335,11 @@ static char **parse_fs_type(const char *fs_type,
        const char      *size_type;
        struct str_list list;
        unsigned long long meg;
-       int             is_hurd = 0;
+       int             is_hurd = for_hurd(creator_os);
 
        if (init_list(&list))
                return 0;
 
-       if (creator_os && (!strcasecmp(creator_os, "GNU") ||
-                          !strcasecmp(creator_os, "hurd")))
-               is_hurd = 1;
-
        if (fs_type)
                ext_type = fs_type;
        else if (is_hurd)
@@ -1044,16 +1378,16 @@ static char **parse_fs_type(const char *fs_type,
                         "%s filesystem type.\n"), ext_type);
                if (!strcmp(ext_type, "ext3") || !strcmp(ext_type, "ext4") ||
                    !strcmp(ext_type, "ext4dev")) {
-                       printf(_("You probably need to install an updated "
-                                "mke2fs.conf file.\n\n"));
+                       printf("%s", _("You probably need to install an "
+                                      "updated mke2fs.conf file.\n\n"));
                }
                if (!force) {
-                       printf(_("Aborting...\n"));
+                       printf("%s", _("Aborting...\n"));
                        exit(1);
                }
        }
 
-       meg = (1024 * 1024) / EXT2_BLOCK_SIZE(fs_param);
+       meg = (1024 * 1024) / EXT2_BLOCK_SIZE(sb);
        if (fs_blocks_count < 3 * meg)
                size_type = "floppy";
        else if (fs_blocks_count < 512 * meg)
@@ -1070,6 +1404,7 @@ static char **parse_fs_type(const char *fs_type,
 
        parse_str = malloc(strlen(usage_types)+1);
        if (!parse_str) {
+               free(profile_type);
                free(list.list);
                return 0;
        }
@@ -1094,10 +1429,8 @@ static char **parse_fs_type(const char *fs_type,
                }
                if (t)
                        cp = t+1;
-               else {
-                       cp = "";
+               else
                        break;
-               }
        }
        free(parse_str);
        free(profile_type);
@@ -1106,15 +1439,15 @@ static char **parse_fs_type(const char *fs_type,
        return (list.list);
 }
 
-static char *get_string_from_profile(char **fs_types, const char *opt,
+char *get_string_from_profile(char **types, const char *opt,
                                     const char *def_val)
 {
        char *ret = 0;
        int i;
 
-       for (i=0; fs_types[i]; i++);
+       for (i=0; types[i]; i++);
        for (i-=1; i >=0 ; i--) {
-               profile_get_string(profile, "fs_types", fs_types[i],
+               profile_get_string(profile, "fs_types", types[i],
                                   opt, 0, &ret);
                if (ret)
                        return ret;
@@ -1123,36 +1456,48 @@ static char *get_string_from_profile(char **fs_types, const char *opt,
        return (ret);
 }
 
-static int get_int_from_profile(char **fs_types, const char *opt, int def_val)
+int get_int_from_profile(char **types, const char *opt, int def_val)
 {
        int ret;
        char **cpp;
 
        profile_get_integer(profile, "defaults", opt, 0, def_val, &ret);
-       for (cpp = fs_types; *cpp; cpp++)
+       for (cpp = types; *cpp; cpp++)
                profile_get_integer(profile, "fs_types", *cpp, opt, ret, &ret);
        return ret;
 }
 
-static double get_double_from_profile(char **fs_types, const char *opt,
+static unsigned int get_uint_from_profile(char **types, const char *opt,
+                                       unsigned int def_val)
+{
+       unsigned int ret;
+       char **cpp;
+
+       profile_get_uint(profile, "defaults", opt, 0, def_val, &ret);
+       for (cpp = types; *cpp; cpp++)
+               profile_get_uint(profile, "fs_types", *cpp, opt, ret, &ret);
+       return ret;
+}
+
+static double get_double_from_profile(char **types, const char *opt,
                                      double def_val)
 {
        double ret;
        char **cpp;
 
        profile_get_double(profile, "defaults", opt, 0, def_val, &ret);
-       for (cpp = fs_types; *cpp; cpp++)
+       for (cpp = types; *cpp; cpp++)
                profile_get_double(profile, "fs_types", *cpp, opt, ret, &ret);
        return ret;
 }
 
-static int get_bool_from_profile(char **fs_types, const char *opt, int def_val)
+int get_bool_from_profile(char **types, const char *opt, int def_val)
 {
        int ret;
        char **cpp;
 
        profile_get_boolean(profile, "defaults", opt, 0, def_val, &ret);
-       for (cpp = fs_types; *cpp; cpp++)
+       for (cpp = types; *cpp; cpp++)
                profile_get_boolean(profile, "fs_types", *cpp, opt, ret, &ret);
        return ret;
 }
@@ -1160,23 +1505,30 @@ static int get_bool_from_profile(char **fs_types, const char *opt, int def_val)
 extern const char *mke2fs_default_profile;
 static const char *default_files[] = { "<default>", 0 };
 
+struct device_param {
+       unsigned long min_io;           /* preferred minimum IO size */
+       unsigned long opt_io;           /* optimal IO size */
+       unsigned long alignment_offset; /* alignment offset wrt physical block size */
+       unsigned int dax:1;             /* supports dax? */
+};
+
 #ifdef HAVE_BLKID_PROBE_GET_TOPOLOGY
 /*
  * Sets the geometry of a device (stripe/stride), and returns the
  * device's alignment offset, if any, or a negative error.
  */
 static int get_device_geometry(const char *file,
-                              struct ext2_super_block *fs_param,
-                              int psector_size)
+                              unsigned int blocksize,
+                              unsigned int psector_size,
+                              struct device_param *dev_param)
 {
        int rc = -1;
-       int blocksize;
        blkid_probe pr;
        blkid_topology tp;
-       unsigned long min_io;
-       unsigned long opt_io;
        struct stat statbuf;
 
+       memset(dev_param, 0, sizeof(*dev_param));
+
        /* Nothing to do for a regular file */
        if (!stat(file, &statbuf) && S_ISREG(statbuf.st_mode))
                return 0;
@@ -1189,23 +1541,20 @@ static int get_device_geometry(const char *file,
        if (!tp)
                goto out;
 
-       min_io = blkid_topology_get_minimum_io_size(tp);
-       opt_io = blkid_topology_get_optimal_io_size(tp);
-       blocksize = EXT2_BLOCK_SIZE(fs_param);
-       if ((min_io == 0) && (psector_size > blocksize))
-               min_io = psector_size;
-       if ((opt_io == 0) && min_io)
-               opt_io = min_io;
-       if ((opt_io == 0) && (psector_size > blocksize))
-               opt_io = psector_size;
-
-       /* setting stripe/stride to blocksize is pointless */
-       if (min_io > blocksize)
-               fs_param->s_raid_stride = min_io / blocksize;
-       if (opt_io > blocksize)
-               fs_param->s_raid_stripe_width = opt_io / blocksize;
-
-       rc = blkid_topology_get_alignment_offset(tp);
+       dev_param->min_io = blkid_topology_get_minimum_io_size(tp);
+       dev_param->opt_io = blkid_topology_get_optimal_io_size(tp);
+       if ((dev_param->min_io == 0) && (psector_size > blocksize))
+               dev_param->min_io = psector_size;
+       if ((dev_param->opt_io == 0) && dev_param->min_io > 0)
+               dev_param->opt_io = dev_param->min_io;
+       if ((dev_param->opt_io == 0) && (psector_size > blocksize))
+               dev_param->opt_io = psector_size;
+
+       dev_param->alignment_offset = blkid_topology_get_alignment_offset(tp);
+#ifdef HAVE_BLKID_TOPOLOGY_GET_DAX
+       dev_param->dax = blkid_topology_get_dax(tp);
+#endif
+       rc = 0;
 out:
        blkid_free_probe(pr);
        return rc;
@@ -1214,39 +1563,57 @@ out:
 
 static void PRS(int argc, char *argv[])
 {
-       int             b, c;
+       int             b, c, flags;
        int             cluster_size = 0;
        char            *tmp, **cpp;
+       int             explicit_fssize = 0;
        int             blocksize = 0;
        int             inode_ratio = 0;
        int             inode_size = 0;
        unsigned long   flex_bg_size = 0;
        double          reserved_ratio = -1.0;
        int             lsector_size = 0, psector_size = 0;
-       int             show_version_only = 0;
+       int             show_version_only = 0, is_device = 0;
        unsigned long long num_inodes = 0; /* unsigned long long to catch too-large input */
+       int             default_orphan_file = 0;
+       int             default_csum_seed = 0;
        errcode_t       retval;
        char *          oldpath = getenv("PATH");
        char *          extended_opts = 0;
        char *          fs_type = 0;
        char *          usage_types = 0;
-       blk64_t         dev_size;
+       /*
+        * NOTE: A few words about fs_blocks_count and blocksize:
+        *
+        * Initially, blocksize is set to zero, which implies 1024.
+        * If -b is specified, blocksize is updated to the user's value.
+        *
+        * Next, the device size or the user's "blocks" command line argument
+        * is used to set fs_blocks_count; the units are blocksize.
+        *
+        * Later, if blocksize hasn't been set and the profile specifies a
+        * blocksize, then blocksize is updated and fs_blocks_count is scaled
+        * appropriately.  Note the change in units!
+        *
+        * Finally, we complain about fs_blocks_count > 2^32 on a non-64bit fs.
+        */
        blk64_t         fs_blocks_count = 0;
-#ifdef __linux__
-       struct          utsname ut;
-#endif
-       long            sysval;
        int             s_opt = -1, r_opt = -1;
        char            *fs_features = 0;
+       int             fs_features_size = 0;
        int             use_bsize;
        char            *newpath;
        int             pathlen = sizeof(PATH_SET) + 1;
+#ifdef HAVE_BLKID_PROBE_GET_TOPOLOGY
+       struct device_param dev_param;
+#endif
 
        if (oldpath)
                pathlen += strlen(oldpath);
        newpath = malloc(pathlen);
        if (!newpath) {
-               fprintf(stderr, _("Couldn't allocate memory for new PATH.\n"));
+               fprintf(stderr, "%s",
+                       _("Couldn't allocate memory for new PATH.\n"));
                exit(1);
        }
        strcpy(newpath, PATH_SET);
@@ -1258,19 +1625,18 @@ static void PRS(int argc, char *argv[])
        }
        putenv (newpath);
 
-       tmp = getenv("MKE2FS_SYNC");
-       if (tmp)
-               sync_kludge = atoi(tmp);
-
        /* Determine the system page size if possible */
 #ifdef HAVE_SYSCONF
 #if (!defined(_SC_PAGESIZE) && defined(_SC_PAGE_SIZE))
 #define _SC_PAGESIZE _SC_PAGE_SIZE
 #endif
 #ifdef _SC_PAGESIZE
-       sysval = sysconf(_SC_PAGESIZE);
-       if (sysval > 0)
-               sys_page_size = sysval;
+       {
+               long sysval = sysconf(_SC_PAGESIZE);
+
+               if (sysval > 0)
+                       sys_page_size = sysval;
+       }
 #endif /* _SC_PAGESIZE */
 #endif /* HAVE_SYSCONF */
 
@@ -1299,15 +1665,8 @@ profile_error:
        memset(&fs_param, 0, sizeof(struct ext2_super_block));
        fs_param.s_rev_level = 1;  /* Create revision 1 filesystems now */
 
-#ifdef __linux__
-       if (uname(&ut)) {
-               perror("uname");
-               exit(1);
-       }
-       linux_version_code = parse_version_number(ut.release);
-       if (linux_version_code && linux_version_code < (2*65536 + 2*256))
+       if (is_before_linux_ver(2, 2, 0))
                fs_param.s_rev_level = 0;
-#endif
 
        if (argc && *argv) {
                program_name = get_progname(*argv);
@@ -1319,13 +1678,13 @@ profile_error:
        }
 
        while ((c = getopt (argc, argv,
-                   "b:cg:i:jl:m:no:qr:s:t:vC:DE:FG:I:J:KL:M:N:O:R:ST:U:V")) != EOF) {
+                   "b:cd:e:g:i:jl:m:no:qr:s:t:vC:DE:FG:I:J:KL:M:N:O:R:ST:U:Vz:")) != EOF) {
                switch (c) {
                case 'b':
-                       blocksize = strtol(optarg, &tmp, 0);
+                       blocksize = parse_num_blocks2(optarg, -1);
                        b = (blocksize > 0) ? blocksize : -blocksize;
                        if (b < EXT2_MIN_BLOCK_SIZE ||
-                           b > EXT2_MAX_BLOCK_SIZE || *tmp) {
+                           b > EXT2_MAX_BLOCK_SIZE) {
                                com_err(program_name, 0,
                                        _("invalid block size - %s"), optarg);
                                exit(1);
@@ -1343,27 +1702,54 @@ profile_error:
                        cflag++;
                        break;
                case 'C':
-                       cluster_size = strtoul(optarg, &tmp, 0);
-                       if (cluster_size < EXT2_MIN_CLUSTER_SIZE ||
-                           cluster_size > EXT2_MAX_CLUSTER_SIZE || *tmp) {
+                       cluster_size = parse_num_blocks2(optarg, -1);
+                       if (cluster_size <= EXT2_MIN_CLUSTER_SIZE ||
+                           cluster_size > EXT2_MAX_CLUSTER_SIZE) {
                                com_err(program_name, 0,
                                        _("invalid cluster size - %s"),
                                        optarg);
                                exit(1);
                        }
                        break;
+               case 'd':
+                       src_root_dir = optarg;
+                       break;
                case 'D':
                        direct_io = 1;
                        break;
+               case 'R':
+                       com_err(program_name, 0, "%s",
+                               _("'-R' is deprecated, use '-E' instead"));
+                       /* fallthrough */
+               case 'E':
+                       extended_opts = optarg;
+                       break;
+               case 'e':
+                       if (strcmp(optarg, "continue") == 0)
+                               errors_behavior = EXT2_ERRORS_CONTINUE;
+                       else if (strcmp(optarg, "remount-ro") == 0)
+                               errors_behavior = EXT2_ERRORS_RO;
+                       else if (strcmp(optarg, "panic") == 0)
+                               errors_behavior = EXT2_ERRORS_PANIC;
+                       else {
+                               com_err(program_name, 0,
+                                       _("bad error behavior - %s"),
+                                       optarg);
+                               usage();
+                       }
+                       break;
+               case 'F':
+                       force++;
+                       break;
                case 'g':
                        fs_param.s_blocks_per_group = strtoul(optarg, &tmp, 0);
                        if (*tmp) {
-                               com_err(program_name, 0,
-                                       _("Illegal number for blocks per group"));
+                               com_err(program_name, 0, "%s",
+                               _("Illegal number for blocks per group"));
                                exit(1);
                        }
                        if ((fs_param.s_blocks_per_group % 8) != 0) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                _("blocks per group must be multiple of 8"));
                                exit(1);
                        }
@@ -1371,22 +1757,27 @@ profile_error:
                case 'G':
                        flex_bg_size = strtoul(optarg, &tmp, 0);
                        if (*tmp) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                        _("Illegal number for flex_bg size"));
                                exit(1);
                        }
                        if (flex_bg_size < 1 ||
                            (flex_bg_size & (flex_bg_size-1)) != 0) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                        _("flex_bg size must be a power of 2"));
                                exit(1);
                        }
+                       if (flex_bg_size > MAX_32_NUM) {
+                               com_err(program_name, 0,
+                               _("flex_bg size (%lu) must be less than"
+                               " or equal to 2^31"), flex_bg_size);
+                               exit(1);
+                       }
                        break;
                case 'i':
-                       inode_ratio = strtoul(optarg, &tmp, 0);
+                       inode_ratio = parse_num_blocks(optarg, -1);
                        if (inode_ratio < EXT2_MIN_BLOCK_SIZE ||
-                           inode_ratio > EXT2_MAX_BLOCK_SIZE * 1024 ||
-                           *tmp) {
+                           inode_ratio > EXT2_MAX_BLOCK_SIZE * 1024) {
                                com_err(program_name, 0,
                                        _("invalid inode ratio %s (min %d/max %d)"),
                                        optarg, EXT2_MIN_BLOCK_SIZE,
@@ -1394,29 +1785,49 @@ profile_error:
                                exit(1);
                        }
                        break;
+               case 'I':
+                       inode_size = strtoul(optarg, &tmp, 0);
+                       if (*tmp) {
+                               com_err(program_name, 0,
+                                       _("invalid inode size - %s"), optarg);
+                               exit(1);
+                       }
+                       break;
+               case 'j':
+                       if (!journal_size)
+                               journal_size = -1;
+                       if (!journal_fc_size)
+                               journal_fc_size = -1;
+                       break;
                case 'J':
                        parse_journal_opts(optarg);
                        break;
                case 'K':
-                       fprintf(stderr, _("Warning: -K option is deprecated and "
-                                         "should not be used anymore. Use "
-                                         "\'-E nodiscard\' extended option "
-                                         "instead!\n"));
+                       fprintf(stderr, "%s",
+                               _("Warning: -K option is deprecated and "
+                                 "should not be used anymore. Use "
+                                 "\'-E nodiscard\' extended option "
+                                 "instead!\n"));
                        discard = 0;
                        break;
-               case 'j':
-                       if (!journal_size)
-                               journal_size = -1;
-                       break;
                case 'l':
-                       bad_blocks_filename = malloc(strlen(optarg)+1);
+                       bad_blocks_filename = realloc(bad_blocks_filename,
+                                                     strlen(optarg) + 1);
                        if (!bad_blocks_filename) {
-                               com_err(program_name, ENOMEM,
+                               com_err(program_name, ENOMEM, "%s",
                                        _("in malloc for bad_blocks_filename"));
                                exit(1);
                        }
                        strcpy(bad_blocks_filename, optarg);
                        break;
+               case 'L':
+                       volume_label = optarg;
+                       if (strlen(volume_label) > EXT2_LABEL_LEN) {
+                               volume_label[EXT2_LABEL_LEN] = '\0';
+                               fprintf(stderr, _("Warning: label too long; will be truncated to '%s'\n\n"),
+                                       volume_label);
+                       }
+                       break;
                case 'm':
                        reserved_ratio = strtod(optarg, &tmp);
                        if ( *tmp || reserved_ratio > 50 ||
@@ -1427,13 +1838,40 @@ profile_error:
                                exit(1);
                        }
                        break;
+               case 'M':
+                       mount_dir = optarg;
+                       break;
                case 'n':
                        noaction++;
                        break;
+               case 'N':
+                       num_inodes = strtoul(optarg, &tmp, 0);
+                       if (*tmp) {
+                               com_err(program_name, 0,
+                                       _("bad num inodes - %s"), optarg);
+                                       exit(1);
+                       }
+                       break;
                case 'o':
                        creator_os = optarg;
                        break;
-               case 'q':
+               case 'O':
+                       retval = ext2fs_resize_mem(fs_features_size,
+                                  fs_features_size + 1 + strlen(optarg),
+                                                  &fs_features);
+                       if (retval) {
+                               com_err(program_name, retval,
+                                    _("while allocating fs_feature string"));
+                               exit(1);
+                       }
+                       if (fs_features_size)
+                               strcat(fs_features, ",");
+                       else
+                               fs_features[0] = 0;
+                       strcat(fs_features, optarg);
+                       fs_features_size += 1 + strlen(optarg);
+                       break;
+               case 'q':
                        quiet = 1;
                        break;
                case 'r':
@@ -1443,52 +1881,22 @@ profile_error:
                                        _("bad revision level - %s"), optarg);
                                exit(1);
                        }
+                       if (r_opt > EXT2_MAX_SUPP_REV) {
+                               com_err(program_name, EXT2_ET_REV_TOO_HIGH,
+                                       _("while trying to create revision %d"), r_opt);
+                               exit(1);
+                       }
                        fs_param.s_rev_level = r_opt;
                        break;
                case 's':       /* deprecated */
                        s_opt = atoi(optarg);
                        break;
-               case 'I':
-                       inode_size = strtoul(optarg, &tmp, 0);
-                       if (*tmp) {
-                               com_err(program_name, 0,
-                                       _("invalid inode size - %s"), optarg);
-                               exit(1);
-                       }
-                       break;
-               case 'v':
-                       verbose = 1;
-                       break;
-               case 'F':
-                       force++;
-                       break;
-               case 'L':
-                       volume_label = optarg;
-                       break;
-               case 'M':
-                       mount_dir = optarg;
-                       break;
-               case 'N':
-                       num_inodes = strtoul(optarg, &tmp, 0);
-                       if (*tmp) {
-                               com_err(program_name, 0,
-                                       _("bad num inodes - %s"), optarg);
-                                       exit(1);
-                       }
-                       break;
-               case 'O':
-                       fs_features = optarg;
-                       break;
-               case 'E':
-               case 'R':
-                       extended_opts = optarg;
-                       break;
                case 'S':
                        super_only = 1;
                        break;
                case 't':
                        if (fs_type) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                    _("The -t option may only be used once"));
                                exit(1);
                        }
@@ -1496,7 +1904,7 @@ profile_error:
                        break;
                case 'T':
                        if (usage_types) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                    _("The -T option may only be used once"));
                                exit(1);
                        }
@@ -1505,10 +1913,16 @@ profile_error:
                case 'U':
                        fs_uuid = optarg;
                        break;
+               case 'v':
+                       verbose = 1;
+                       break;
                case 'V':
                        /* Print version number and exit */
                        show_version_only++;
                        break;
+               case 'z':
+                       undo_file = optarg;
+                       break;
                default:
                        usage();
                }
@@ -1538,10 +1952,10 @@ profile_error:
 #ifdef CONFIG_TESTIO_DEBUG
                if (getenv("TEST_IO_FLAGS") || getenv("TEST_IO_BLOCK")) {
                        io_ptr = test_io_manager;
-                       test_io_backing_manager = unix_io_manager;
+                       test_io_backing_manager = default_io_manager;
                } else
 #endif
-                       io_ptr = unix_io_manager;
+                       io_ptr = default_io_manager;
                retval = ext2fs_open(journal_device,
                                     EXT2_FLAG_JOURNAL_DEV_OK, 0,
                                     0, io_ptr, &jfs);
@@ -1562,7 +1976,7 @@ profile_error:
                printf(_("Using journal device's blocksize: %d\n"), blocksize);
                fs_param.s_log_block_size =
                        int_log2(blocksize >> EXT2_MIN_BLOCK_LOG_SIZE);
-               ext2fs_close(jfs);
+               ext2fs_close_free(&jfs);
        }
 
        if (optind < argc) {
@@ -1578,8 +1992,18 @@ profile_error:
        if (optind < argc)
                usage();
 
-       if (!force)
-               check_plausibility(device_name);
+       profile_get_integer(profile, "options", "sync_kludge", 0, 0,
+                           &sync_kludge);
+       tmp = getenv("MKE2FS_SYNC");
+       if (tmp)
+               sync_kludge = atoi(tmp);
+
+       profile_get_integer(profile, "options", "proceed_delay", 0, 0,
+                           &proceed_delay);
+
+       if (fs_blocks_count)
+               explicit_fssize = 1;
+
        check_mount(device_name, force, _("filesystem"));
 
        /* Determine the size of the device (if possible) */
@@ -1590,22 +2014,41 @@ profile_error:
                retval = ext2fs_get_device_size2(device_name,
                                                 EXT2_BLOCK_SIZE(&fs_param),
                                                 &dev_size);
+       if (retval == ENOENT) {
+               int fd;
 
+               if (!explicit_fssize) {
+                       fprintf(stderr,
+                               _("The file %s does not exist and no "
+                                 "size was specified.\n"), device_name);
+                       exit(1);
+               }
+               fd = ext2fs_open_file(device_name,
+                                     O_CREAT | O_WRONLY, 0666);
+               if (fd < 0) {
+                       retval = errno;
+               } else {
+                       dev_size = 0;
+                       retval = 0;
+                       close(fd);
+                       printf(_("Creating regular file %s\n"), device_name);
+               }
+       }
        if (retval && (retval != EXT2_ET_UNIMPLEMENTED)) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while trying to determine filesystem size"));
                exit(1);
        }
        if (!fs_blocks_count) {
                if (retval == EXT2_ET_UNIMPLEMENTED) {
-                       com_err(program_name, 0,
+                       com_err(program_name, 0, "%s",
                                _("Couldn't determine device size; you "
                                "must specify\nthe size of the "
                                "filesystem\n"));
                        exit(1);
                } else {
                        if (dev_size == 0) {
-                               com_err(program_name, 0,
+                               com_err(program_name, 0, "%s",
                                _("Device size reported to be zero.  "
                                  "Invalid partition specified, or\n\t"
                                  "partition table wasn't reread "
@@ -1621,10 +2064,10 @@ profile_error:
                                fs_blocks_count &= ~((blk64_t) ((sys_page_size /
                                             EXT2_BLOCK_SIZE(&fs_param))-1));
                }
-       } else if (!force && (fs_blocks_count > dev_size)) {
-               com_err(program_name, 0,
+       } else if (!force && is_device && (fs_blocks_count > dev_size)) {
+               com_err(program_name, 0, "%s",
                        _("Filesystem larger than apparent device size."));
-               proceed_question();
+               proceed_question(proceed_delay);
        }
 
        if (!fs_type)
@@ -1633,6 +2076,9 @@ profile_error:
        if (!usage_types)
                profile_get_string(profile, "devices", device_name,
                                   "usage_types", 0, &usage_types);
+       if (!creator_os)
+               profile_get_string(profile, "defaults", "creator_os", 0,
+                                  0, &creator_os);
 
        /*
         * We have the file system (or device) size, so we can now
@@ -1643,7 +2089,7 @@ profile_error:
                                 fs_blocks_count ? fs_blocks_count : dev_size,
                                 argv[0]);
        if (!fs_types) {
-               fprintf(stderr, _("Failed to parse fs types list\n"));
+               fprintf(stderr, "%s", _("Failed to parse fs types list\n"));
                exit(1);
        }
 
@@ -1652,7 +2098,7 @@ profile_error:
        tmp = NULL;
        if (fs_param.s_rev_level != EXT2_GOOD_OLD_REV) {
                tmp = get_string_from_profile(fs_types, "base_features",
-                     "sparse_super,filetype,resize_inode,dir_index");
+                     "sparse_super,large_file,filetype,resize_inode,dir_index");
                edit_feature(tmp, &fs_param.s_feature_compat);
                free(tmp);
 
@@ -1675,39 +2121,163 @@ profile_error:
                tmp = get_string_from_profile(fs_types, "default_features",
                                              "");
        }
-       edit_feature(fs_features ? fs_features : tmp,
-                    &fs_param.s_feature_compat);
+       /* Mask off features which aren't supported by the Hurd */
+       if (for_hurd(creator_os)) {
+               ext2fs_clear_feature_filetype(&fs_param);
+               ext2fs_clear_feature_huge_file(&fs_param);
+               ext2fs_clear_feature_metadata_csum(&fs_param);
+               ext2fs_clear_feature_ea_inode(&fs_param);
+               ext2fs_clear_feature_casefold(&fs_param);
+       }
+       if (!fs_features && tmp)
+               edit_feature(tmp, &fs_param.s_feature_compat);
+       /*
+        * Now all the defaults are incorporated in fs_param. Check the state
+        * of orphan_file feature so that we know whether we should silently
+        * disabled in case journal gets disabled.
+        */
+       if (ext2fs_has_feature_orphan_file(&fs_param))
+               default_orphan_file = 1;
+       if (ext2fs_has_feature_csum_seed(&fs_param))
+               default_csum_seed = 1;
+       if (fs_features)
+               edit_feature(fs_features, &fs_param.s_feature_compat);
+       /* Silently disable orphan_file if user chose fs without journal */
+       if (default_orphan_file && !ext2fs_has_feature_journal(&fs_param))
+               ext2fs_clear_feature_orphan_file(&fs_param);
+       if (default_csum_seed && !ext2fs_has_feature_metadata_csum(&fs_param))
+               ext2fs_clear_feature_csum_seed(&fs_param);
        if (tmp)
                free(tmp);
+       (void) ext2fs_free_mem(&fs_features);
+       /*
+        * If the user specified features incompatible with the Hurd, complain
+        */
+       if (for_hurd(creator_os)) {
+               if (ext2fs_has_feature_filetype(&fs_param)) {
+                       fprintf(stderr, "%s", _("The HURD does not support the "
+                                               "filetype feature.\n"));
+                       exit(1);
+               }
+               if (ext2fs_has_feature_huge_file(&fs_param)) {
+                       fprintf(stderr, "%s", _("The HURD does not support the "
+                                               "huge_file feature.\n"));
+                       exit(1);
+               }
+               if (ext2fs_has_feature_metadata_csum(&fs_param)) {
+                       fprintf(stderr, "%s", _("The HURD does not support the "
+                                               "metadata_csum feature.\n"));
+                       exit(1);
+               }
+               if (ext2fs_has_feature_ea_inode(&fs_param)) {
+                       fprintf(stderr, "%s", _("The HURD does not support the "
+                                               "ea_inode feature.\n"));
+                       exit(1);
+               }
+       }
+
+       /* Get the hardware sector sizes, if available */
+       retval = ext2fs_get_device_sectsize(device_name, &lsector_size);
+       if (retval) {
+               com_err(program_name, retval, "%s",
+                       _("while trying to determine hardware sector size"));
+               exit(1);
+       }
+       retval = ext2fs_get_device_phys_sectsize(device_name, &psector_size);
+       if (retval) {
+               com_err(program_name, retval, "%s",
+                       _("while trying to determine physical sector size"));
+               exit(1);
+       }
+
+       tmp = getenv("MKE2FS_DEVICE_SECTSIZE");
+       if (tmp != NULL)
+               lsector_size = atoi(tmp);
+       tmp = getenv("MKE2FS_DEVICE_PHYS_SECTSIZE");
+       if (tmp != NULL)
+               psector_size = atoi(tmp);
+
+       /* Older kernels may not have physical/logical distinction */
+       if (!psector_size)
+               psector_size = lsector_size;
+
+       if (blocksize <= 0) {
+               use_bsize = get_int_from_profile(fs_types, "blocksize", 4096);
+
+               if (use_bsize == -1) {
+                       use_bsize = sys_page_size;
+                       if (is_before_linux_ver(2, 6, 0) && use_bsize > 4096)
+                               use_bsize = 4096;
+               }
+               if (lsector_size && use_bsize < lsector_size)
+                       use_bsize = lsector_size;
+               if ((blocksize < 0) && (use_bsize < (-blocksize)))
+                       use_bsize = -blocksize;
+               blocksize = use_bsize;
+               fs_blocks_count /= (blocksize / 1024);
+       } else {
+               if (blocksize < lsector_size) {                 /* Impossible */
+                       com_err(program_name, EINVAL, "%s",
+                               _("while setting blocksize; too small "
+                                 "for device\n"));
+                       exit(1);
+               } else if ((blocksize < psector_size) &&
+                          (psector_size <= sys_page_size)) {   /* Suboptimal */
+                       fprintf(stderr, _("Warning: specified blocksize %d is "
+                               "less than device physical sectorsize %d\n"),
+                               blocksize, psector_size);
+               }
+       }
+
+       fs_param.s_log_block_size =
+               int_log2(blocksize >> EXT2_MIN_BLOCK_LOG_SIZE);
 
        /*
         * We now need to do a sanity check of fs_blocks_count for
         * 32-bit vs 64-bit block number support.
         */
-       if ((fs_blocks_count > MAX_32_NUM) && (blocksize == 0)) {
-               fs_blocks_count /= 4; /* Try using a 4k blocksize */
-               blocksize = 4096;
-               fs_param.s_log_block_size = 2;
-       }
        if ((fs_blocks_count > MAX_32_NUM) &&
-           !(fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT) &&
+           ext2fs_has_feature_64bit(&fs_param))
+               ext2fs_clear_feature_resize_inode(&fs_param);
+       if ((fs_blocks_count > MAX_32_NUM) &&
+           !ext2fs_has_feature_64bit(&fs_param) &&
            get_bool_from_profile(fs_types, "auto_64-bit_support", 0)) {
-               fs_param.s_feature_incompat |= EXT4_FEATURE_INCOMPAT_64BIT;
-               fs_param.s_feature_compat &= ~EXT2_FEATURE_COMPAT_RESIZE_INODE;
+               ext2fs_set_feature_64bit(&fs_param);
+               ext2fs_clear_feature_resize_inode(&fs_param);
        }
        if ((fs_blocks_count > MAX_32_NUM) &&
-           !(fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT)) {
+           !ext2fs_has_feature_64bit(&fs_param)) {
                fprintf(stderr, _("%s: Size of device (0x%llx blocks) %s "
                                  "too big to be expressed\n\t"
                                  "in 32 bits using a blocksize of %d.\n"),
-                       program_name, fs_blocks_count, device_name,
-                       EXT2_BLOCK_SIZE(&fs_param));
+                       program_name, (unsigned long long) fs_blocks_count,
+                       device_name, EXT2_BLOCK_SIZE(&fs_param));
+               exit(1);
+       }
+       /*
+        * Guard against group descriptor count overflowing... Mostly to avoid
+        * strange results for absurdly large devices.  This is in log2:
+        * (blocksize) * (bits per byte) * (maximum number of block groups)
+        */
+       if (fs_blocks_count >
+           (1ULL << (EXT2_BLOCK_SIZE_BITS(&fs_param) + 3 + 32)) - 1) {
+               fprintf(stderr, _("%s: Size of device (0x%llx blocks) %s "
+                                 "too big to create\n\t"
+                                 "a filesystem using a blocksize of %d.\n"),
+                       program_name, (unsigned long long) fs_blocks_count,
+                       device_name, EXT2_BLOCK_SIZE(&fs_param));
                exit(1);
        }
 
        ext2fs_blocks_count_set(&fs_param, fs_blocks_count);
 
-       if (fs_param.s_feature_incompat & EXT3_FEATURE_INCOMPAT_JOURNAL_DEV) {
+       if (ext2fs_has_feature_journal_dev(&fs_param)) {
+               int i;
+
+               for (i=0; fs_types[i]; i++) {
+                       free(fs_types[i]);
+                       fs_types[i] = 0;
+               }
                fs_types[0] = strdup("journal");
                fs_types[1] = 0;
        }
@@ -1720,31 +2290,29 @@ profile_error:
        if (r_opt == EXT2_GOOD_OLD_REV &&
            (fs_param.s_feature_compat || fs_param.s_feature_incompat ||
             fs_param.s_feature_ro_compat)) {
-               fprintf(stderr, _("Filesystem features not supported "
-                                 "with revision 0 filesystems\n"));
+               fprintf(stderr, "%s", _("Filesystem features not supported "
+                                       "with revision 0 filesystems\n"));
                exit(1);
        }
 
        if (s_opt > 0) {
                if (r_opt == EXT2_GOOD_OLD_REV) {
-                       fprintf(stderr, _("Sparse superblocks not supported "
+                       fprintf(stderr, "%s",
+                               _("Sparse superblocks not supported "
                                  "with revision 0 filesystems\n"));
                        exit(1);
                }
-               fs_param.s_feature_ro_compat |=
-                       EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
+               ext2fs_set_feature_sparse_super(&fs_param);
        } else if (s_opt == 0)
-               fs_param.s_feature_ro_compat &=
-                       ~EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
+               ext2fs_clear_feature_sparse_super(&fs_param);
 
        if (journal_size != 0) {
                if (r_opt == EXT2_GOOD_OLD_REV) {
-                       fprintf(stderr, _("Journals not supported "
-                                 "with revision 0 filesystems\n"));
+                       fprintf(stderr, "%s", _("Journals not supported with "
+                                               "revision 0 filesystems\n"));
                        exit(1);
                }
-               fs_param.s_feature_compat |=
-                       EXT3_FEATURE_COMPAT_HAS_JOURNAL;
+               ext2fs_set_feature_journal(&fs_param);
        }
 
        /* Get reserved_ratio from profile if not specified on cmd line. */
@@ -1759,92 +2327,46 @@ profile_error:
                }
        }
 
-       if (fs_param.s_feature_incompat &
-           EXT3_FEATURE_INCOMPAT_JOURNAL_DEV) {
+       if (ext2fs_has_feature_journal_dev(&fs_param)) {
                reserved_ratio = 0;
                fs_param.s_feature_incompat = EXT3_FEATURE_INCOMPAT_JOURNAL_DEV;
                fs_param.s_feature_compat = 0;
-               fs_param.s_feature_ro_compat = 0;
+               fs_param.s_feature_ro_compat &=
+                                       EXT4_FEATURE_RO_COMPAT_METADATA_CSUM;
        }
 
-       if ((fs_param.s_feature_incompat & EXT2_FEATURE_INCOMPAT_META_BG) &&
-           (fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_RESIZE_INODE)) {
-               fprintf(stderr, _("The resize_inode and meta_bg features "
-                                 "are not compatible.\n"
-                                 "They can not be both enabled "
-                                 "simultaneously.\n"));
+       /* Check the user's mkfs options for 64bit */
+       if (ext2fs_has_feature_64bit(&fs_param) &&
+           !ext2fs_has_feature_extents(&fs_param)) {
+               printf("%s", _("Extents MUST be enabled for a 64-bit "
+                              "filesystem.  Pass -O extents to rectify.\n"));
                exit(1);
        }
 
        /* Set first meta blockgroup via an environment variable */
        /* (this is mostly for debugging purposes) */
-       if ((fs_param.s_feature_incompat & EXT2_FEATURE_INCOMPAT_META_BG) &&
-           ((tmp = getenv("MKE2FS_FIRST_META_BG"))))
+       if (ext2fs_has_feature_meta_bg(&fs_param) &&
+           (tmp = getenv("MKE2FS_FIRST_META_BG")))
                fs_param.s_first_meta_bg = atoi(tmp);
-
-       /* Get the hardware sector sizes, if available */
-       retval = ext2fs_get_device_sectsize(device_name, &lsector_size);
-       if (retval) {
-               com_err(program_name, retval,
-                       _("while trying to determine hardware sector size"));
-               exit(1);
-       }
-       retval = ext2fs_get_device_phys_sectsize(device_name, &psector_size);
-       if (retval) {
-               com_err(program_name, retval,
-                       _("while trying to determine physical sector size"));
-               exit(1);
-       }
-
-       if ((tmp = getenv("MKE2FS_DEVICE_SECTSIZE")) != NULL)
-               lsector_size = atoi(tmp);
-       if ((tmp = getenv("MKE2FS_DEVICE_PHYS_SECTSIZE")) != NULL)
-               psector_size = atoi(tmp);
-
-       /* Older kernels may not have physical/logical distinction */
-       if (!psector_size)
-               psector_size = lsector_size;
-
-       if (blocksize <= 0) {
-               use_bsize = get_int_from_profile(fs_types, "blocksize", 4096);
-
-               if (use_bsize == -1) {
-                       use_bsize = sys_page_size;
-                       if ((linux_version_code < (2*65536 + 6*256)) &&
-                           (use_bsize > 4096))
-                               use_bsize = 4096;
-               }
-               if (lsector_size && use_bsize < lsector_size)
-                       use_bsize = lsector_size;
-               if ((blocksize < 0) && (use_bsize < (-blocksize)))
-                       use_bsize = -blocksize;
-               blocksize = use_bsize;
-               ext2fs_blocks_count_set(&fs_param,
-                                       ext2fs_blocks_count(&fs_param) /
-                                       (blocksize / 1024));
-       } else {
-               if (blocksize < lsector_size) {                 /* Impossible */
-                       com_err(program_name, EINVAL,
-                               _("while setting blocksize; too small "
-                                 "for device\n"));
-                       exit(1);
-               } else if ((blocksize < psector_size) &&
-                          (psector_size <= sys_page_size)) {   /* Suboptimal */
-                       fprintf(stderr, _("Warning: specified blocksize %d is "
-                               "less than device physical sectorsize %d\n"),
-                               blocksize, psector_size);
-               }
-       }
-
-       fs_param.s_log_block_size =
-               int_log2(blocksize >> EXT2_MIN_BLOCK_LOG_SIZE);
-       if (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) {
+       if (ext2fs_has_feature_bigalloc(&fs_param)) {
                if (!cluster_size)
                        cluster_size = get_int_from_profile(fs_types,
                                                            "cluster_size",
                                                            blocksize*16);
                fs_param.s_log_cluster_size =
                        int_log2(cluster_size >> EXT2_MIN_CLUSTER_LOG_SIZE);
+               if (fs_param.s_log_cluster_size &&
+                   fs_param.s_log_cluster_size < fs_param.s_log_block_size) {
+                       com_err(program_name, 0, "%s",
+                               _("The cluster size may not be "
+                                 "smaller than the block size.\n"));
+                       exit(1);
+               }
+       } else if (cluster_size) {
+               com_err(program_name, 0, "%s",
+                       _("specifying a cluster size requires the "
+                         "bigalloc feature"));
+               exit(1);
        } else
                fs_param.s_log_cluster_size = fs_param.s_log_block_size;
 
@@ -1858,35 +2380,79 @@ profile_error:
        }
 
 #ifdef HAVE_BLKID_PROBE_GET_TOPOLOGY
-       retval = get_device_geometry(device_name, &fs_param, psector_size);
+       retval = get_device_geometry(device_name, blocksize,
+                                    psector_size, &dev_param);
        if (retval < 0) {
                fprintf(stderr,
                        _("warning: Unable to get device geometry for %s\n"),
                        device_name);
-       } else if (retval) {
-               printf(_("%s alignment is offset by %lu bytes.\n"),
-                      device_name, retval);
-               printf(_("This may result in very poor performance, "
-                         "(re)-partitioning suggested.\n"));
+       } else {
+               /* setting stripe/stride to blocksize is pointless */
+               if (dev_param.min_io > (unsigned) blocksize)
+                       fs_param.s_raid_stride = dev_param.min_io / blocksize;
+               if (dev_param.opt_io > (unsigned) blocksize) {
+                       fs_param.s_raid_stripe_width =
+                                               dev_param.opt_io / blocksize;
+               }
+
+               if (dev_param.alignment_offset) {
+                       printf(_("%s alignment is offset by %lu bytes.\n"),
+                              device_name, dev_param.alignment_offset);
+                       printf(_("This may result in very poor performance, "
+                                 "(re)-partitioning suggested.\n"));
+               }
+
+               if (dev_param.dax && blocksize != sys_page_size) {
+                       fprintf(stderr,
+                               _("%s is capable of DAX but current block size "
+                                 "%u is different from system page size %u so "
+                                 "filesystem will not support DAX.\n"),
+                               device_name, blocksize, sys_page_size);
+               }
        }
 #endif
 
+       num_backups = get_int_from_profile(fs_types, "num_backup_sb", 2);
+
        blocksize = EXT2_BLOCK_SIZE(&fs_param);
 
+       /*
+        * Initialize s_desc_size so that the parse_extended_opts()
+        * can correctly handle "-E resize=NNN" if the 64-bit option
+        * is set.
+        */
+       if (ext2fs_has_feature_64bit(&fs_param))
+               fs_param.s_desc_size = EXT2_MIN_DESC_SIZE_64BIT;
+
        /* This check should happen beyond the last assignment to blocksize */
        if (blocksize > sys_page_size) {
                if (!force) {
                        com_err(program_name, 0,
                                _("%d-byte blocks too big for system (max %d)"),
                                blocksize, sys_page_size);
-                       proceed_question();
+                       proceed_question(proceed_delay);
                }
                fprintf(stderr, _("Warning: %d-byte blocks too big for system "
                                  "(max %d), forced to continue\n"),
                        blocksize, sys_page_size);
        }
 
-       lazy_itable_init = 0;
+       /* Metadata checksumming wasn't totally stable before 3.18. */
+       if (is_before_linux_ver(3, 18, 0) &&
+           ext2fs_has_feature_metadata_csum(&fs_param))
+               fprintf(stderr, _("Suggestion: Use Linux kernel >= 3.18 for "
+                       "improved stability of the metadata and journal "
+                       "checksum features.\n"));
+
+       /*
+        * On newer kernels we do have lazy_itable_init support. So pick the
+        * right default in case ext4 module is not loaded.
+        */
+       if (is_before_linux_ver(2, 6, 37))
+               lazy_itable_init = 0;
+       else
+               lazy_itable_init = 1;
+
        if (access("/sys/fs/ext4/features/lazy_itable_init", R_OK) == 0)
                lazy_itable_init = 1;
 
@@ -1899,6 +2465,47 @@ profile_error:
                                               EXT2_MKJOURNAL_LAZYINIT : 0;
        journal_flags |= EXT2_MKJOURNAL_NO_MNT_CHECK;
 
+       if (!journal_location_string)
+               journal_location_string = get_string_from_profile(fs_types,
+                                               "journal_location", "");
+       if ((journal_location == ~0ULL) && journal_location_string &&
+           *journal_location_string)
+               journal_location = parse_num_blocks2(journal_location_string,
+                                               fs_param.s_log_block_size);
+       free(journal_location_string);
+
+       packed_meta_blocks = get_bool_from_profile(fs_types,
+                                                  "packed_meta_blocks", 0);
+       if (packed_meta_blocks)
+               journal_location = 0;
+
+       if (ext2fs_has_feature_casefold(&fs_param)) {
+               char *ef, *en = get_string_from_profile(fs_types,
+                                                       "encoding", "utf8");
+               int encoding = e2p_str2encoding(en);
+
+               if (encoding < 0) {
+                       com_err(program_name, 0,
+                               _("Unknown filename encoding from profile: %s"),
+                               en);
+                       exit(1);
+               }
+               free(en);
+               fs_param.s_encoding = encoding;
+               ef = get_string_from_profile(fs_types, "encoding_flags", NULL);
+               if (ef) {
+                       if (e2p_str2encoding_flags(encoding, ef,
+                                       &fs_param.s_encoding_flags) < 0) {
+                               com_err(program_name, 0,
+                       _("Unknown encoding flags from profile: %s"), ef);
+                               exit(1);
+                       }
+                       free(ef);
+               } else
+                       fs_param.s_encoding_flags =
+                               e2p_get_encoding_flags(encoding);
+       }
+
        /* Get options from profile */
        for (cpp = fs_types; *cpp; cpp++) {
                tmp = NULL;
@@ -1911,12 +2518,75 @@ profile_error:
        if (extended_opts)
                parse_extended_opts(&fs_param, extended_opts);
 
-       /* Since sparse_super is the default, we would only have a problem
+       if (explicit_fssize == 0 && offset > 0) {
+               fs_blocks_count -= offset / EXT2_BLOCK_SIZE(&fs_param);
+               ext2fs_blocks_count_set(&fs_param, fs_blocks_count);
+               fprintf(stderr,
+                       _("\nWarning: offset specified without an "
+                         "explicit file system size.\n"
+                         "Creating a file system with %llu blocks "
+                         "but this might\n"
+                         "not be what you want.\n\n"),
+                       (unsigned long long) fs_blocks_count);
+       }
+
+       if (quotatype_bits & QUOTA_PRJ_BIT)
+               ext2fs_set_feature_project(&fs_param);
+
+       if (ext2fs_has_feature_project(&fs_param)) {
+               quotatype_bits |= QUOTA_PRJ_BIT;
+               if (inode_size == EXT2_GOOD_OLD_INODE_SIZE) {
+                       com_err(program_name, 0,
+                               _("%d byte inodes are too small for "
+                                 "project quota"),
+                               inode_size);
+                       exit(1);
+               }
+               if (inode_size == 0) {
+                       inode_size = get_int_from_profile(fs_types,
+                                                         "inode_size", 0);
+                       if (inode_size <= EXT2_GOOD_OLD_INODE_SIZE*2)
+                               inode_size = EXT2_GOOD_OLD_INODE_SIZE*2;
+               }
+       }
+
+       /* Don't allow user to set both metadata_csum and uninit_bg bits. */
+       if (ext2fs_has_feature_metadata_csum(&fs_param) &&
+           ext2fs_has_feature_gdt_csum(&fs_param))
+               ext2fs_clear_feature_gdt_csum(&fs_param);
+
+       /* Can't support bigalloc feature without extents feature */
+       if (ext2fs_has_feature_bigalloc(&fs_param) &&
+           !ext2fs_has_feature_extents(&fs_param)) {
+               com_err(program_name, 0, "%s",
+                       _("Can't support bigalloc feature without "
+                         "extents feature"));
+               exit(1);
+       }
+
+       if (ext2fs_has_feature_meta_bg(&fs_param) &&
+           ext2fs_has_feature_resize_inode(&fs_param)) {
+               fprintf(stderr, "%s", _("The resize_inode and meta_bg "
+                                       "features are not compatible.\n"
+                                       "They can not be both enabled "
+                                       "simultaneously.\n"));
+               exit(1);
+       }
+
+       if (!quiet && ext2fs_has_feature_bigalloc(&fs_param) &&
+           EXT2_CLUSTER_SIZE(&fs_param) > 16 * EXT2_BLOCK_SIZE(&fs_param))
+               fprintf(stderr, "%s", _("\nWarning: bigalloc file systems "
+                               "with a cluster size greater than\n"
+                               "16 times the block size is considered "
+                               "experimental\n"));
+
+       /*
+        * Since sparse_super is the default, we would only have a problem
         * here if it was explicitly disabled.
         */
-       if ((fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_RESIZE_INODE) &&
-           !(fs_param.s_feature_ro_compat&EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER)) {
-               com_err(program_name, 0,
+       if (ext2fs_has_feature_resize_inode(&fs_param) &&
+           !ext2fs_has_feature_sparse_super(&fs_param)) {
+               com_err(program_name, 0, "%s",
                        _("reserved online resize blocks not supported "
                          "on non-sparse filesystem"));
                exit(1);
@@ -1925,22 +2595,29 @@ profile_error:
        if (fs_param.s_blocks_per_group) {
                if (fs_param.s_blocks_per_group < 256 ||
                    fs_param.s_blocks_per_group > 8 * (unsigned) blocksize) {
-                       com_err(program_name, 0,
+                       com_err(program_name, 0, "%s",
                                _("blocks per group count out of range"));
                        exit(1);
                }
        }
 
+       /*
+        * If the bigalloc feature is enabled, then the -g option will
+        * specify the number of clusters per group.
+        */
+       if (ext2fs_has_feature_bigalloc(&fs_param)) {
+               fs_param.s_clusters_per_group = fs_param.s_blocks_per_group;
+               fs_param.s_blocks_per_group = 0;
+       }
+
        if (inode_size == 0)
                inode_size = get_int_from_profile(fs_types, "inode_size", 0);
-       if (!flex_bg_size && (fs_param.s_feature_incompat &
-                             EXT4_FEATURE_INCOMPAT_FLEX_BG))
-               flex_bg_size = get_int_from_profile(fs_types,
-                                                   "flex_bg_size", 16);
+       if (!flex_bg_size && ext2fs_has_feature_flex_bg(&fs_param))
+               flex_bg_size = get_uint_from_profile(fs_types,
+                                                    "flex_bg_size", 16);
        if (flex_bg_size) {
-               if (!(fs_param.s_feature_incompat &
-                     EXT4_FEATURE_INCOMPAT_FLEX_BG)) {
-                       com_err(program_name, 0,
+               if (!ext2fs_has_feature_flex_bg(&fs_param)) {
+                       com_err(program_name, 0, "%s",
                                _("Flex_bg feature not enabled, so "
                                  "flex_bg size may not be specified"));
                        exit(1);
@@ -1961,25 +2638,49 @@ profile_error:
                fs_param.s_inode_size = inode_size;
        }
 
+       /*
+        * If inode size is 128 and inline data is enabled, we need
+        * to notify users that inline data will never be useful.
+        */
+       if (ext2fs_has_feature_inline_data(&fs_param) &&
+           fs_param.s_inode_size == EXT2_GOOD_OLD_INODE_SIZE) {
+               com_err(program_name, 0,
+                       _("%d byte inodes are too small for inline data; "
+                         "specify larger size"),
+                       fs_param.s_inode_size);
+               exit(1);
+       }
+
+       /*
+        * Warn the user that filesystems with 128-byte inodes will
+        * not work properly beyond 2038.  This can be suppressed via
+        * a boolean in the mke2fs.conf file, and we will disable this
+        * warning for file systems created for the GNU Hurd.
+        */
+       if (inode_size == EXT2_GOOD_OLD_INODE_SIZE &&
+           get_bool_from_profile(fs_types, "warn_y2038_dates", 1))
+               printf(
+_("128-byte inodes cannot handle dates beyond 2038 and are deprecated\n"));
+
        /* Make sure number of inodes specified will fit in 32 bits */
        if (num_inodes == 0) {
                unsigned long long n;
                n = ext2fs_blocks_count(&fs_param) * blocksize / inode_ratio;
                if (n > MAX_32_NUM) {
-                       if (fs_param.s_feature_incompat &
-                           EXT4_FEATURE_INCOMPAT_64BIT)
+                       if (ext2fs_has_feature_64bit(&fs_param))
                                num_inodes = MAX_32_NUM;
                        else {
                                com_err(program_name, 0,
                                        _("too many inodes (%llu), raise "
-                                         "inode ratio?"), n);
+                                         "inode ratio?"),
+                                       (unsigned long long) n);
                                exit(1);
                        }
                }
        } else if (num_inodes > MAX_32_NUM) {
                com_err(program_name, 0,
                        _("too many inodes (%llu), specify < 2^32 inodes"),
-                         num_inodes);
+                       (unsigned long long) num_inodes);
                exit(1);
        }
        /*
@@ -1988,7 +2689,7 @@ profile_error:
        fs_param.s_inodes_count = num_inodes ? num_inodes :
                (ext2fs_blocks_count(&fs_param) * blocksize) / inode_ratio;
 
-       if ((((long long)fs_param.s_inodes_count) *
+       if ((((unsigned long long)fs_param.s_inodes_count) *
             (inode_size ? inode_size : EXT2_GOOD_OLD_INODE_SIZE)) >=
            ((ext2fs_blocks_count(&fs_param)) *
             EXT2_BLOCK_SIZE(&fs_param))) {
@@ -2009,8 +2710,26 @@ profile_error:
        ext2fs_r_blocks_count_set(&fs_param, reserved_ratio *
                                  ext2fs_blocks_count(&fs_param) / 100.0);
 
+       if (ext2fs_has_feature_sparse_super2(&fs_param)) {
+               if (num_backups >= 1)
+                       fs_param.s_backup_bgs[0] = 1;
+               if (num_backups >= 2)
+                       fs_param.s_backup_bgs[1] = ~0;
+       }
+
        free(fs_type);
        free(usage_types);
+
+       /* The isatty() test is so we don't break existing scripts */
+       flags = CREATE_FILE;
+       if (isatty(0) && isatty(1) && !offset)
+               flags |= CHECK_FS_EXIST;
+       if (!quiet)
+               flags |= VERBOSE_CREATE;
+       if (!explicit_fssize)
+               flags |= NO_SIZE;
+       if (!check_plausibility(device_name, flags, &is_device) && !force)
+               proceed_question(proceed_delay);
 }
 
 static int should_do_undo(const char *name)
@@ -2019,11 +2738,11 @@ static int should_do_undo(const char *name)
        io_channel channel;
        __u16   s_magic;
        struct ext2_super_block super;
-       io_manager manager = unix_io_manager;
+       io_manager manager = default_io_manager;
        int csum_flag, force_undo;
 
-       csum_flag = EXT2_HAS_RO_COMPAT_FEATURE(&fs_param,
-                                              EXT4_FEATURE_RO_COMPAT_GDT_CSUM);
+       csum_flag = ext2fs_has_feature_metadata_csum(&fs_param) ||
+                   ext2fs_has_feature_gdt_csum(&fs_param);
        force_undo = get_int_from_profile(fs_types, "force_undo", 0);
        if (!force_undo && (!csum_flag || !lazy_itable_init))
                return 0;
@@ -2068,9 +2787,24 @@ static int mke2fs_setup_tdb(const char *name, io_manager *io_ptr)
 {
        errcode_t retval = ENOMEM;
        char *tdb_dir = NULL, *tdb_file = NULL;
-       char *device_name, *tmp_name;
+       char *dev_name, *tmp_name;
        int free_tdb_dir = 0;
 
+       /* (re)open a specific undo file */
+       if (undo_file && undo_file[0] != 0) {
+               retval = set_undo_io_backing_manager(*io_ptr);
+               if (retval)
+                       goto err;
+               *io_ptr = undo_io_manager;
+               retval = set_undo_io_backup_file(undo_file);
+               if (retval)
+                       goto err;
+               printf(_("Overwriting existing filesystem; this can be undone "
+                        "using the command:\n"
+                        "    e2undo %s %s\n\n"), undo_file, name);
+               return retval;
+       }
+
        /*
         * Configuration via a conf file would be
         * nice
@@ -2084,29 +2818,34 @@ static int mke2fs_setup_tdb(const char *name, io_manager *io_ptr)
        }
 
        if (!strcmp(tdb_dir, "none") || (tdb_dir[0] == 0) ||
-           access(tdb_dir, W_OK))
+           access(tdb_dir, W_OK)) {
+               if (free_tdb_dir)
+                       free(tdb_dir);
                return 0;
+       }
 
        tmp_name = strdup(name);
        if (!tmp_name)
                goto errout;
-       device_name = basename(tmp_name);
-       tdb_file = malloc(strlen(tdb_dir) + 8 + strlen(device_name) + 7 + 1);
+       dev_name = basename(tmp_name);
+       tdb_file = malloc(strlen(tdb_dir) + 8 + strlen(dev_name) + 7 + 1);
        if (!tdb_file) {
                free(tmp_name);
                goto errout;
        }
-       sprintf(tdb_file, "%s/mke2fs-%s.e2undo", tdb_dir, device_name);
+       sprintf(tdb_file, "%s/mke2fs-%s.e2undo", tdb_dir, dev_name);
        free(tmp_name);
 
-       if (!access(tdb_file, F_OK)) {
-               if (unlink(tdb_file) < 0) {
-                       retval = errno;
-                       goto errout;
-               }
+       if ((unlink(tdb_file) < 0) && (errno != ENOENT)) {
+               retval = errno;
+               com_err(program_name, retval,
+                       _("while trying to delete %s"), tdb_file);
+               goto errout;
        }
 
-       set_undo_io_backing_manager(*io_ptr);
+       retval = set_undo_io_backing_manager(*io_ptr);
+       if (retval)
+               goto errout;
        *io_ptr = undo_io_manager;
        retval = set_undo_io_backup_file(tdb_file);
        if (retval)
@@ -2124,7 +2863,8 @@ errout:
        if (free_tdb_dir)
                free(tdb_dir);
        free(tdb_file);
-       com_err(program_name, retval,
+err:
+       com_err(program_name, retval, "%s",
                _("while trying to setup undo file\n"));
        return retval;
 }
@@ -2134,7 +2874,7 @@ static int mke2fs_discard_device(ext2_filsys fs)
        struct ext2fs_numeric_progress_struct progress;
        blk64_t blocks = ext2fs_blocks_count(fs->super);
        blk64_t count = DISCARD_STEP_MB;
-       blk64_t cur;
+       blk64_t cur = 0;
        int retval = 0;
 
        /*
@@ -2142,10 +2882,9 @@ static int mke2fs_discard_device(ext2_filsys fs)
         * we do not print numeric progress resulting in failure
         * afterwards.
         */
-       retval = io_channel_discard(fs->io, 0, fs->blocksize);
+       retval = io_channel_discard(fs->io, 0, 1);
        if (retval)
                return retval;
-       cur = fs->blocksize;
 
        count *= (1024 * 1024);
        count /= fs->blocksize;
@@ -2179,58 +2918,118 @@ static int mke2fs_discard_device(ext2_filsys fs)
 
 static void fix_cluster_bg_counts(ext2_filsys fs)
 {
-       blk64_t cluster, num_clusters, tot_free;
-       int     grp_free, num_free, group, num;
-
-       num_clusters = EXT2FS_B2C(fs, ext2fs_blocks_count(fs->super));
-       tot_free = num_free = num = group = grp_free = 0;
-       for (cluster = EXT2FS_B2C(fs, fs->super->s_first_data_block);
-            cluster < num_clusters; cluster++) {
-               if (!ext2fs_test_block_bitmap2(fs->block_map,
-                                              EXT2FS_C2B(fs, cluster))) {
-                       grp_free++;
-                       tot_free++;
-               }
-               num++;
-               if ((num == fs->super->s_clusters_per_group) ||
-                   (cluster == num_clusters-1)) {
+       blk64_t         block, num_blocks, last_block, next;
+       blk64_t         tot_free = 0;
+       errcode_t       retval;
+       dgrp_t          group = 0;
+       int             grp_free = 0;
+
+       num_blocks = ext2fs_blocks_count(fs->super);
+       last_block = ext2fs_group_last_block2(fs, group);
+       block = fs->super->s_first_data_block;
+       while (block < num_blocks) {
+               retval = ext2fs_find_first_zero_block_bitmap2(fs->block_map,
+                                               block, last_block, &next);
+               if (retval == 0)
+                       block = next;
+               else {
+                       block = last_block + 1;
+                       goto next_bg;
+               }
+
+               retval = ext2fs_find_first_set_block_bitmap2(fs->block_map,
+                                               block, last_block, &next);
+               if (retval)
+                       next = last_block + 1;
+               grp_free += EXT2FS_NUM_B2C(fs, next - block);
+               tot_free += next - block;
+               block = next;
+
+               if (block > last_block) {
+               next_bg:
                        ext2fs_bg_free_blocks_count_set(fs, group, grp_free);
                        ext2fs_group_desc_csum_set(fs, group);
-                       num = 0;
                        grp_free = 0;
                        group++;
+                       last_block = ext2fs_group_last_block2(fs, group);
                }
        }
-       ext2fs_free_blocks_count_set(fs->super, EXT2FS_C2B(fs, tot_free));
+       ext2fs_free_blocks_count_set(fs->super, tot_free);
 }
 
 static int create_quota_inodes(ext2_filsys fs)
 {
        quota_ctx_t qctx;
+       errcode_t retval;
 
-       quota_init_context(&qctx, fs, -1);
+       retval = quota_init_context(&qctx, fs, quotatype_bits);
+       if (retval) {
+               com_err(program_name, retval,
+                       _("while initializing quota context"));
+               exit(1);
+       }
        quota_compute_usage(qctx);
-       quota_write_inode(qctx, quotatype);
+       retval = quota_write_inode(qctx, quotatype_bits);
+       if (retval) {
+               com_err(program_name, retval,
+                       _("while writing quota inodes"));
+               exit(1);
+       }
        quota_release_context(&qctx);
 
        return 0;
 }
 
+static errcode_t set_error_behavior(ext2_filsys fs)
+{
+       char    *arg = NULL;
+       short   errors = fs->super->s_errors;
+
+       arg = get_string_from_profile(fs_types, "errors", NULL);
+       if (arg == NULL)
+               goto try_user;
+
+       if (strcmp(arg, "continue") == 0)
+               errors = EXT2_ERRORS_CONTINUE;
+       else if (strcmp(arg, "remount-ro") == 0)
+               errors = EXT2_ERRORS_RO;
+       else if (strcmp(arg, "panic") == 0)
+               errors = EXT2_ERRORS_PANIC;
+       else {
+               com_err(program_name, 0,
+                       _("bad error behavior in profile - %s"),
+                       arg);
+               free(arg);
+               return EXT2_ET_INVALID_ARGUMENT;
+       }
+       free(arg);
+
+try_user:
+       if (errors_behavior)
+               errors = errors_behavior;
+
+       fs->super->s_errors = errors;
+       return 0;
+}
+
 int main (int argc, char *argv[])
 {
        errcode_t       retval = 0;
        ext2_filsys     fs;
        badblocks_list  bb_list = 0;
-       unsigned int    journal_blocks;
+       badblocks_iterate       bb_iter;
+       blk_t           blk;
+       struct ext2fs_journal_params    jparams = {0};
        unsigned int    i, checkinterval;
        int             max_mnt_count;
        int             val, hash_alg;
        int             flags;
        int             old_bitmaps;
        io_manager      io_ptr;
-       char            tdb_string[40];
+       char            opt_string[40];
        char            *hash_alg_str;
        int             itable_zeroed = 0;
+       blk64_t         overhead;
 
 #ifdef ENABLE_NLS
        setlocale(LC_MESSAGES, "");
@@ -2244,12 +3043,12 @@ int main (int argc, char *argv[])
 #ifdef CONFIG_TESTIO_DEBUG
        if (getenv("TEST_IO_FLAGS") || getenv("TEST_IO_BLOCK")) {
                io_ptr = test_io_manager;
-               test_io_backing_manager = unix_io_manager;
+               test_io_backing_manager = default_io_manager;
        } else
 #endif
-               io_ptr = unix_io_manager;
+               io_ptr = default_io_manager;
 
-       if (should_do_undo(device_name)) {
+       if (undo_file != NULL || should_do_undo(device_name)) {
                retval = mke2fs_setup_tdb(device_name, &io_ptr);
                if (retval)
                        exit(1);
@@ -2272,37 +3071,109 @@ int main (int argc, char *argv[])
         */
        if (!quiet)
                flags |= EXT2_FLAG_PRINT_PROGRESS;
-       retval = ext2fs_initialize(device_name, flags, &fs_param, io_ptr, &fs);
+       if (android_sparse_file) {
+               char *android_sparse_params = malloc(strlen(device_name) + 48);
+
+               if (!android_sparse_params) {
+                       com_err(program_name, ENOMEM, "%s",
+                               _("in malloc for android_sparse_params"));
+                       exit(1);
+               }
+               sprintf(android_sparse_params, "(%s):%u:%u",
+                        device_name, fs_param.s_blocks_count,
+                        1024 << fs_param.s_log_block_size);
+               retval = ext2fs_initialize(android_sparse_params, flags,
+                                          &fs_param, sparse_io_manager, &fs);
+               free(android_sparse_params);
+       } else
+               retval = ext2fs_initialize(device_name, flags, &fs_param,
+                                          io_ptr, &fs);
        if (retval) {
-               com_err(device_name, retval, _("while setting up superblock"));
+               com_err(device_name, retval, "%s",
+                       _("while setting up superblock"));
+               exit(1);
+       }
+       fs->progress_ops = &ext2fs_numeric_progress_ops;
+
+       /* Set the error behavior */
+       retval = set_error_behavior(fs);
+       if (retval)
+               usage();
+
+       /* Check the user's mkfs options for metadata checksumming */
+       if (!quiet &&
+           !ext2fs_has_feature_journal_dev(fs->super) &&
+           ext2fs_has_feature_metadata_csum(fs->super)) {
+               if (!ext2fs_has_feature_extents(fs->super))
+                       printf("%s",
+                              _("Extents are not enabled.  The file extent "
+                                "tree can be checksummed, whereas block maps "
+                                "cannot.  Not enabling extents reduces the "
+                                "coverage of metadata checksumming.  "
+                                "Pass -O extents to rectify.\n"));
+               if (!ext2fs_has_feature_64bit(fs->super))
+                       printf("%s",
+                              _("64-bit filesystem support is not enabled.  "
+                                "The larger fields afforded by this feature "
+                                "enable full-strength checksumming.  "
+                                "Pass -O 64bit to rectify.\n"));
+       }
+
+       if (ext2fs_has_feature_csum_seed(fs->super) &&
+           !ext2fs_has_feature_metadata_csum(fs->super)) {
+               printf("%s", _("The metadata_csum_seed feature "
+                              "requires the metadata_csum feature.\n"));
                exit(1);
        }
 
+       /* Calculate journal blocks */
+       if (!journal_device && ((journal_size) ||
+           ext2fs_has_feature_journal(&fs_param)))
+               figure_journal_size(&jparams, journal_size, journal_fc_size, fs);
+
+       sprintf(opt_string, "tdb_data_size=%d", fs->blocksize <= 4096 ?
+               32768 : fs->blocksize * 8);
+       io_channel_set_options(fs->io, opt_string);
+       if (offset) {
+               sprintf(opt_string, "offset=%llu", (unsigned long long) offset);
+               io_channel_set_options(fs->io, opt_string);
+       }
+
+       if (assume_storage_prezeroed) {
+               if (verbose)
+                       printf("%s",
+                              _("Assuming the storage device is prezeroed "
+                              "- skipping inode table and journal wipe\n"));
+
+               lazy_itable_init = 1;
+               itable_zeroed = 1;
+               zero_hugefile = 0;
+               journal_flags |= EXT2_MKJOURNAL_LAZYINIT;
+       }
+
        /* Can't undo discard ... */
-       if (!noaction && discard && (io_ptr != undo_io_manager)) {
+       if (!noaction && discard && dev_size && (io_ptr != undo_io_manager)) {
                retval = mke2fs_discard_device(fs);
                if (!retval && io_channel_discard_zeroes_data(fs->io)) {
                        if (verbose)
-                               printf(_("Discard succeeded and will return 0s "
-                                        " - skipping inode table wipe\n"));
+                               printf("%s",
+                                      _("Discard succeeded and will return "
+                                        "0s - skipping inode table wipe\n"));
                        lazy_itable_init = 1;
                        itable_zeroed = 1;
+                       zero_hugefile = 0;
                }
        }
 
-       sprintf(tdb_string, "tdb_data_size=%d", fs->blocksize <= 4096 ?
-               32768 : fs->blocksize * 8);
-       io_channel_set_options(fs->io, tdb_string);
-
        if (fs_param.s_flags & EXT2_FLAGS_TEST_FILESYS)
                fs->super->s_flags |= EXT2_FLAGS_TEST_FILESYS;
 
-       if ((fs_param.s_feature_incompat &
-            (EXT3_FEATURE_INCOMPAT_EXTENTS|EXT4_FEATURE_INCOMPAT_FLEX_BG)) ||
-           (fs_param.s_feature_ro_compat &
-            (EXT4_FEATURE_RO_COMPAT_HUGE_FILE|EXT4_FEATURE_RO_COMPAT_GDT_CSUM|
-             EXT4_FEATURE_RO_COMPAT_DIR_NLINK|
-             EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE)))
+       if (ext2fs_has_feature_flex_bg(&fs_param) ||
+           ext2fs_has_feature_huge_file(&fs_param) ||
+           ext2fs_has_feature_gdt_csum(&fs_param) ||
+           ext2fs_has_feature_dir_nlink(&fs_param) ||
+           ext2fs_has_feature_metadata_csum(&fs_param) ||
+           ext2fs_has_feature_extra_isize(&fs_param))
                fs->super->s_kbytes_written = 1;
 
        /*
@@ -2315,7 +3186,14 @@ int main (int argc, char *argv[])
         * Parse or generate a UUID for the filesystem
         */
        if (fs_uuid) {
-               if (uuid_parse(fs_uuid, fs->super->s_uuid) !=0) {
+               if ((strcasecmp(fs_uuid, "null") == 0) ||
+                   (strcasecmp(fs_uuid, "clear") == 0)) {
+                       uuid_clear(fs->super->s_uuid);
+               } else if (strcasecmp(fs_uuid, "time") == 0) {
+                       uuid_generate_time(fs->super->s_uuid);
+               } else if (strcasecmp(fs_uuid, "random") == 0) {
+                       uuid_generate(fs->super->s_uuid);
+               } else if (uuid_parse(fs_uuid, fs->super->s_uuid) != 0) {
                        com_err(device_name, 0, "could not parse UUID: %s\n",
                                fs_uuid);
                        exit(1);
@@ -2323,6 +3201,12 @@ int main (int argc, char *argv[])
        } else
                uuid_generate(fs->super->s_uuid);
 
+       if (ext2fs_has_feature_csum_seed(fs->super))
+               fs->super->s_checksum_seed = ext2fs_crc32c_le(~0,
+                               fs->super->s_uuid, sizeof(fs->super->s_uuid));
+
+       ext2fs_init_csum_seed(fs);
+
        /*
         * Initialize the directory index variables
         */
@@ -2332,7 +3216,13 @@ int main (int argc, char *argv[])
        free(hash_alg_str);
        fs->super->s_def_hash_version = (hash_alg >= 0) ? hash_alg :
                EXT2_HASH_HALF_MD4;
-       uuid_generate((unsigned char *) fs->super->s_hash_seed);
+
+       if (memcmp(fs_param.s_hash_seed, zero_buf,
+               sizeof(fs_param.s_hash_seed)) != 0) {
+               memcpy(fs->super->s_hash_seed, fs_param.s_hash_seed,
+                       sizeof(fs->super->s_hash_seed));
+       } else
+               uuid_generate((unsigned char *) fs->super->s_hash_seed);
 
        /*
         * Periodic checks can be enabled/disabled via config file.
@@ -2375,8 +3265,7 @@ int main (int argc, char *argv[])
         * support it.
         */
        if (fs->super->s_creator_os == EXT2_OS_HURD)
-               fs->super->s_feature_incompat &=
-                       ~EXT2_FEATURE_INCOMPAT_FILETYPE;
+               ext2fs_clear_feature_filetype(fs->super);
 
        /*
         * Set the volume label...
@@ -2384,7 +3273,7 @@ int main (int argc, char *argv[])
        if (volume_label) {
                memset(fs->super->s_volume_name, 0,
                       sizeof(fs->super->s_volume_name));
-               strncpy(fs->super->s_volume_name, volume_label,
+               strncpy((char *) fs->super->s_volume_name, volume_label,
                        sizeof(fs->super->s_volume_name));
        }
 
@@ -2394,58 +3283,117 @@ int main (int argc, char *argv[])
        if (mount_dir) {
                memset(fs->super->s_last_mounted, 0,
                       sizeof(fs->super->s_last_mounted));
-               strncpy(fs->super->s_last_mounted, mount_dir,
+               strncpy((char *) fs->super->s_last_mounted, mount_dir,
                        sizeof(fs->super->s_last_mounted));
        }
 
+       /* Set current default encryption algorithms for data and
+        * filename encryption */
+       if (ext2fs_has_feature_encrypt(fs->super)) {
+               fs->super->s_encrypt_algos[0] =
+                       EXT4_ENCRYPTION_MODE_AES_256_XTS;
+               fs->super->s_encrypt_algos[1] =
+                       EXT4_ENCRYPTION_MODE_AES_256_CTS;
+       }
+
+       if (ext2fs_has_feature_metadata_csum(fs->super))
+               fs->super->s_checksum_type = EXT2_CRC32C_CHKSUM;
+
        if (!quiet || noaction)
                show_stats(fs);
 
        if (noaction)
                exit(0);
 
-       if (fs->super->s_feature_incompat &
-           EXT3_FEATURE_INCOMPAT_JOURNAL_DEV) {
+       if (ext2fs_has_feature_journal_dev(fs->super)) {
                create_journal_dev(fs);
-               exit(ext2fs_close(fs) ? 1 : 0);
+               printf("\n");
+               exit(ext2fs_close_free(&fs) ? 1 : 0);
        }
 
        if (bad_blocks_filename)
                read_bb_file(fs, &bb_list, bad_blocks_filename);
        if (cflag)
                test_disk(fs, &bb_list);
-
        handle_bad_blocks(fs, bb_list);
+
        fs->stride = fs_stride = fs->super->s_raid_stride;
        if (!quiet)
-               printf(_("Allocating group tables: "));
-       retval = ext2fs_allocate_tables(fs);
+               printf("%s", _("Allocating group tables: "));
+       if (ext2fs_has_feature_flex_bg(fs->super) &&
+           packed_meta_blocks)
+               retval = packed_allocate_tables(fs);
+       else
+               retval = ext2fs_allocate_tables(fs);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("while trying to allocate filesystem tables"));
                exit(1);
        }
        if (!quiet)
-               printf(_("done                            \n"));
+               printf("%s", _("done                            \n"));
+
+       /*
+        * Unmark bad blocks to calculate overhead, because metadata
+        * blocks and bad blocks can land on the same allocation cluster.
+        */
+       if (bb_list) {
+               retval = ext2fs_badblocks_list_iterate_begin(bb_list,
+                                                            &bb_iter);
+               if (retval) {
+                       com_err("ext2fs_badblocks_list_iterate_begin", retval,
+                               "%s", _("while unmarking bad blocks"));
+                       exit(1);
+               }
+               while (ext2fs_badblocks_list_iterate(bb_iter, &blk))
+                       ext2fs_unmark_block_bitmap2(fs->block_map, blk);
+               ext2fs_badblocks_list_iterate_end(bb_iter);
+       }
 
        retval = ext2fs_convert_subcluster_bitmap(fs, &fs->block_map);
        if (retval) {
-               com_err(program_name, retval,
+               com_err(program_name, retval, "%s",
                        _("\n\twhile converting subcluster bitmap"));
                exit(1);
        }
 
+       retval = ext2fs_count_used_clusters(fs, fs->super->s_first_data_block,
+                                       ext2fs_blocks_count(fs->super) - 1,
+                                       &overhead);
+       if (retval) {
+               com_err(program_name, retval, "%s",
+                       _("while calculating overhead"));
+               exit(1);
+       }
+
+       if (bb_list) {
+               retval = ext2fs_badblocks_list_iterate_begin(bb_list,
+                                                            &bb_iter);
+               if (retval) {
+                       com_err("ext2fs_badblocks_list_iterate_begin", retval,
+                               "%s", _("while marking bad blocks as used"));
+                       exit(1);
+               }
+               while (ext2fs_badblocks_list_iterate(bb_iter, &blk))
+                       ext2fs_mark_block_bitmap2(fs->block_map, blk);
+               ext2fs_badblocks_list_iterate_end(bb_iter);
+       }
+
        if (super_only) {
+               check_plausibility(device_name, CHECK_FS_EXIST, NULL);
+               printf(_("%s may be further corrupted by superblock rewrite\n"),
+                      device_name);
+               if (!force)
+                       proceed_question(proceed_delay);
                fs->super->s_state |= EXT2_ERROR_FS;
                fs->flags &= ~(EXT2_FLAG_IB_DIRTY|EXT2_FLAG_BB_DIRTY);
-               /* 
+               /*
                 * The command "mke2fs -S" is used to recover
                 * corrupted file systems, so do not mark any of the
                 * inodes as unused; we want e2fsck to consider all
                 * inodes as potentially containing recoverable data.
                 */
-               if (fs->super->s_feature_ro_compat &
-                   EXT4_FEATURE_RO_COMPAT_GDT_CSUM) {
+               if (ext2fs_has_group_desc_csum(fs)) {
                        for (i = 0; i < fs->group_desc_count; i++)
                                ext2fs_bg_itable_unused_set(fs, i, 0);
                }
@@ -2475,18 +3423,18 @@ int main (int argc, char *argv[])
                if (retval) {
                        com_err(program_name, retval,
                                _("while zeroing block %llu at end of filesystem"),
-                               ret_blk);
+                               (unsigned long long) ret_blk);
                }
                write_inode_tables(fs, lazy_itable_init, itable_zeroed);
                create_root_dir(fs);
                create_lost_and_found(fs);
                reserve_inodes(fs);
                create_bad_block_inode(fs, bb_list);
-               if (fs->super->s_feature_compat &
-                   EXT2_FEATURE_COMPAT_RESIZE_INODE) {
+               if (ext2fs_has_feature_resize_inode(fs->super)) {
                        retval = ext2fs_create_resize_inode(fs);
                        if (retval) {
                                com_err("ext2fs_create_resize_inode", retval,
+                                       "%s",
                                _("while reserving blocks for online resize"));
                                exit(1);
                        }
@@ -2496,13 +3444,14 @@ int main (int argc, char *argv[])
        if (journal_device) {
                ext2_filsys     jfs;
 
-               if (!force)
-                       check_plausibility(journal_device);
+               if (!check_plausibility(journal_device, CHECK_BLOCK_DEV,
+                                       NULL) && !force)
+                       proceed_question(proceed_delay);
                check_mount(journal_device, force, _("journal"));
 
                retval = ext2fs_open(journal_device, EXT2_FLAG_RW|
                                     EXT2_FLAG_JOURNAL_DEV_OK, 0,
-                                    fs->blocksize, unix_io_manager, &jfs);
+                                    fs->blocksize, default_io_manager, &jfs);
                if (retval) {
                        com_err(program_name, retval,
                                _("while trying to open journal device %s\n"),
@@ -2522,47 +3471,49 @@ int main (int argc, char *argv[])
                        exit(1);
                }
                if (!quiet)
-                       printf(_("done\n"));
-               ext2fs_close(jfs);
+                       printf("%s", _("done\n"));
+               ext2fs_close_free(&jfs);
                free(journal_device);
        } else if ((journal_size) ||
-                  (fs_param.s_feature_compat &
-                   EXT3_FEATURE_COMPAT_HAS_JOURNAL)) {
-               journal_blocks = figure_journal_size(journal_size, fs);
-
+                  ext2fs_has_feature_journal(&fs_param)) {
+               overhead += EXT2FS_NUM_B2C(fs, jparams.num_journal_blocks + jparams.num_fc_blocks);
                if (super_only) {
-                       printf(_("Skipping journal creation in super-only mode\n"));
+                       printf("%s", _("Skipping journal creation in super-only mode\n"));
                        fs->super->s_journal_inum = EXT2_JOURNAL_INO;
                        goto no_journal;
                }
 
-               if (!journal_blocks) {
-                       fs->super->s_feature_compat &=
-                               ~EXT3_FEATURE_COMPAT_HAS_JOURNAL;
+               if (!jparams.num_journal_blocks) {
+                       ext2fs_clear_feature_journal(fs->super);
+                       ext2fs_clear_feature_orphan_file(fs->super);
+                       ext2fs_clear_feature_journal(&fs_param);
+                       ext2fs_clear_feature_orphan_file(&fs_param);
                        goto no_journal;
                }
                if (!quiet) {
                        printf(_("Creating journal (%u blocks): "),
-                              journal_blocks);
+                              jparams.num_journal_blocks + jparams.num_fc_blocks);
                        fflush(stdout);
                }
-               retval = ext2fs_add_journal_inode(fs, journal_blocks,
-                                                 journal_flags);
+               retval = ext2fs_add_journal_inode3(fs, &jparams,
+                                                  journal_location,
+                                                  journal_flags);
                if (retval) {
-                       com_err (program_name, retval,
-                                _("\n\twhile trying to create journal"));
+                       com_err(program_name, retval, "%s",
+                               _("\n\twhile trying to create journal"));
                        exit(1);
                }
                if (!quiet)
-                       printf(_("done\n"));
+                       printf("%s", _("done\n"));
        }
 no_journal:
        if (!super_only &&
-           fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_MMP) {
+           ext2fs_has_feature_mmp(fs->super)) {
                retval = ext2fs_mmp_init(fs);
                if (retval) {
-                       fprintf(stderr, _("\nError while enabling multiple "
-                                         "mount protection feature."));
+                       fprintf(stderr, "%s",
+                               _("\nError while enabling multiple "
+                                 "mount protection feature."));
                        exit(1);
                }
                if (!quiet)
@@ -2571,24 +3522,62 @@ no_journal:
                               fs->super->s_mmp_update_interval);
        }
 
-       if (EXT2_HAS_RO_COMPAT_FEATURE(&fs_param,
-                                      EXT4_FEATURE_RO_COMPAT_BIGALLOC))
+       overhead += fs->super->s_first_data_block;
+       if (!super_only)
+               fs->super->s_overhead_clusters = overhead;
+
+       if (ext2fs_has_feature_bigalloc(&fs_param))
                fix_cluster_bg_counts(fs);
-       if (EXT2_HAS_RO_COMPAT_FEATURE(&fs_param,
-                                      EXT4_FEATURE_RO_COMPAT_QUOTA))
+       if (ext2fs_has_feature_quota(&fs_param))
                create_quota_inodes(fs);
+       if (ext2fs_has_feature_orphan_file(&fs_param)) {
+               if (!ext2fs_has_feature_journal(&fs_param)) {
+                       com_err(program_name, 0, _("cannot set orphan_file "
+                               "feature without a journal."));
+                       exit(1);
+               }
+               if (!orphan_file_blocks) {
+                       orphan_file_blocks =
+                               ext2fs_default_orphan_file_blocks(fs);
+               }
+               retval = ext2fs_create_orphan_file(fs, orphan_file_blocks);
+               if (retval) {
+                       com_err(program_name, retval,
+                               _("while creating orphan file"));
+                       exit(1);
+               }
+       }
+
+       retval = mk_hugefiles(fs, device_name);
+       if (retval)
+               com_err(program_name, retval, "while creating huge files");
+       /* Copy files from the specified directory */
+       if (src_root_dir) {
+               if (!quiet)
+                       printf("%s", _("Copying files into the device: "));
+
+               retval = populate_fs(fs, EXT2_ROOT_INO, src_root_dir,
+                                    EXT2_ROOT_INO);
+               if (retval) {
+                       com_err(program_name, retval, "%s",
+                               _("while populating file system"));
+                       exit(1);
+               } else if (!quiet)
+                       printf("%s", _("done\n"));
+       }
 
        if (!quiet)
-               printf(_("Writing superblocks and "
+               printf("%s", _("Writing superblocks and "
                       "filesystem accounting information: "));
        checkinterval = fs->super->s_checkinterval;
        max_mnt_count = fs->super->s_max_mnt_count;
-       retval = ext2fs_close(fs);
+       retval = ext2fs_close_free(&fs);
        if (retval) {
-               fprintf(stderr,
-                       _("\nWarning, had trouble writing out superblocks."));
+               com_err(program_name, retval, "%s",
+                       _("while writing out and closing file system"));
+               retval = 1;
        } else if (!quiet) {
-               printf(_("done\n\n"));
+               printf("%s", _("done\n\n"));
                if (!getenv("MKE2FS_SKIP_CHECK_MSG"))
                        print_check_message(max_mnt_count, checkinterval);
        }