Sanity check for some options.
[platform/upstream/cryptsetup.git] / lib / setup.c
index bcd22df..024e2ba 100644 (file)
@@ -38,8 +38,10 @@ struct crypt_device {
        char *device;
        char *metadata_device;
 
-       char *backing_file;
-       int loop_fd;
+       /* loopback automatic detach helpers */
+       int loop_device_fd;
+       int loop_metadata_device_fd;
+
        struct volume_key *volume_key;
        uint64_t timeout;
        uint64_t iteration_time;
@@ -68,7 +70,7 @@ struct crypt_device {
        /* used in CRYPT_VERITY */
        struct crypt_params_verity verity_hdr;
        char *verity_root_hash;
-       uint64_t verity_root_hash_size;
+       unsigned int verity_root_hash_size;
        char *verity_uuid;
 
        /* callbacks definitions */
@@ -356,16 +358,23 @@ int crypt_confirm(struct crypt_device *cd, const char *msg)
 static int key_from_terminal(struct crypt_device *cd, char *msg, char **key,
                              size_t *key_len, int force_verify)
 {
-       char *prompt = NULL;
+       char *prompt = NULL, *device_name;
        int r;
 
        *key = NULL;
-       if(!msg && asprintf(&prompt, _("Enter passphrase for %s: "),
-                           cd->backing_file ?: crypt_get_device_name(cd)) < 0)
-               return -ENOMEM;
-
-       if (!msg)
+       if(!msg) {
+               if (crypt_loop_device(crypt_get_device_name(cd)))
+                       device_name = crypt_loop_backing_file(crypt_get_device_name(cd));
+               else
+                       device_name = strdup(crypt_get_device_name(cd));
+               if (!device_name)
+                       return -ENOMEM;
+               r = asprintf(&prompt, _("Enter passphrase for %s: "), device_name);
+               free(device_name);
+               if (r < 0)
+                       return -ENOMEM;
                msg = prompt;
+       }
 
        if (cd->password) {
                *key = crypt_safe_alloc(DEFAULT_PASSPHRASE_SIZE_MAX);
@@ -495,10 +504,48 @@ const char *crypt_get_dir(void)
        return dm_get_dir();
 }
 
+static int set_device_or_loop(const char *device_org, char **device, int *loop_fd)
+{
+       int r, readonly = 0;
+
+       if (!device_org)
+               return 0;
+
+       r = device_ready(NULL, device_org, O_RDONLY);
+       if (r == -ENOTBLK) {
+               *device = crypt_loop_get_device();
+               log_dbg("Not a block device, %s%s.", *device ?
+                       "using free loop device " : "no free loop device found",
+                       *device ?: "");
+               if (!*device) {
+                       log_err(NULL, _("Cannot find a free loopback device.\n"));
+                       return -ENOSYS;
+               }
+
+               /* Keep the loop open, dettached on last close. */
+               *loop_fd = crypt_loop_attach(*device, device_org, 0, 1, &readonly);
+               if (*loop_fd == -1) {
+                       log_err(NULL, _("Attaching loopback device failed "
+                               "(loop device with autoclear flag is required).\n"));
+                       return -EINVAL;
+               }
+
+               r = device_ready(NULL, *device, O_RDONLY);
+       }
+
+       if (r < 0)
+               return -ENOTBLK;
+
+       if (!*device && device_org && !(*device = strdup(device_org)))
+               return -ENOMEM;
+
+       return 0;
+}
+
 int crypt_init(struct crypt_device **cd, const char *device)
 {
        struct crypt_device *h = NULL;
-       int r, readonly = 0;
+       int r;
 
        if (!cd)
                return -EINVAL;
@@ -509,44 +556,12 @@ int crypt_init(struct crypt_device **cd, const char *device)
                return -ENOMEM;
 
        memset(h, 0, sizeof(*h));
-       h->loop_fd = -1;
-
-       if (device) {
-               r = device_ready(NULL, device, O_RDONLY);
-               if (r == -ENOTBLK) {
-                       h->device = crypt_loop_get_device();
-                       log_dbg("Not a block device, %s%s.",
-                               h->device ? "using free loop device " :
-                                        "no free loop device found",
-                               h->device ?: "");
-                       if (!h->device) {
-                               log_err(NULL, _("Cannot find a free loopback device.\n"));
-                               r = -ENOSYS;
-                               goto bad;
-                       }
-
-                       /* Keep the loop open, dettached on last close. */
-                       h->loop_fd = crypt_loop_attach(h->device, device, 0, 1, &readonly);
-                       if (h->loop_fd == -1) {
-                               log_err(NULL, _("Attaching loopback device failed "
-                                       "(loop device with autoclear flag is required).\n"));
-                               r = -EINVAL;
-                               goto bad;
-                       }
-
-                       h->backing_file = crypt_loop_backing_file(h->device);
-                       r = device_ready(NULL, h->device, O_RDONLY);
-               }
-               if (r < 0) {
-                       r = -ENOTBLK;
-                       goto bad;
-               }
-       }
+       h->loop_device_fd = -1;
+       h->loop_metadata_device_fd = -1;
 
-       if (!h->device && device && !(h->device = strdup(device))) {
-               r = -ENOMEM;
+       r = set_device_or_loop(device, &h->device, &h->loop_device_fd);
+       if (r < 0)
                goto bad;
-       }
 
        if (dm_init(h, 1) < 0) {
                r = -ENOSYS;
@@ -562,10 +577,9 @@ int crypt_init(struct crypt_device **cd, const char *device)
 bad:
 
        if (h) {
-               if (h->loop_fd != -1)
-                       close(h->loop_fd);
+               if (h->loop_device_fd != -1)
+                       close(h->loop_device_fd);
                free(h->device);
-               free(h->backing_file);
        }
        free(h);
        return r;
@@ -584,7 +598,7 @@ static int crypt_check_data_device_size(struct crypt_device *cd)
                return r;
 
        if (size < size_min) {
-               log_err(cd, _("LUKS header detected but device %s is too small.\n"),
+               log_err(cd, _("Header detected but device %s is too small.\n"),
                        crypt_get_device_name(cd));
                return -EINVAL;
        }
@@ -594,8 +608,8 @@ static int crypt_check_data_device_size(struct crypt_device *cd)
 
 int crypt_set_data_device(struct crypt_device *cd, const char *device)
 {
-       char *data_device;
-       int r;
+       char *data_device = NULL;
+       int r, loop_fd = -1;
 
        log_dbg("Setting ciphertext data device to %s.", device ?: "(none)");
 
@@ -608,19 +622,21 @@ int crypt_set_data_device(struct crypt_device *cd, const char *device)
        if (!cd->device || !device)
                return -EINVAL;
 
-       r = device_ready(NULL, device, O_RDONLY);
+       r = set_device_or_loop(device, &data_device, &loop_fd);
        if (r < 0)
                return r;
 
-       if (!(data_device = strdup(device)))
-               return -ENOMEM;
-
-       if (!cd->metadata_device)
+       if (!cd->metadata_device) {
                cd->metadata_device = cd->device;
-       else
+               cd->loop_metadata_device_fd = cd->loop_device_fd;
+       } else {
                free(cd->device);
+               if (cd->loop_device_fd != -1)
+                       close(cd->loop_device_fd);
+       }
 
        cd->device = data_device;
+       cd->loop_device_fd = loop_fd;
 
        return crypt_check_data_device_size(cd);
 }
@@ -673,7 +689,10 @@ static int _crypt_load_verity(struct crypt_device *cd, struct crypt_params_verit
            (r = crypt_set_data_device(cd, params->data_device)) < 0)
                return r;
 
+       /* Hash availability checked in sb load */
        cd->verity_root_hash_size = crypt_hash_size(cd->verity_hdr.hash_name);
+       if (cd->verity_root_hash_size > 4096)
+               return -EINVAL;
 
        if (!cd->type && !(cd->type = strdup(CRYPT_VERITY)))
                return -ENOMEM;
@@ -860,13 +879,6 @@ int crypt_init_by_name_and_header(struct crypt_device **cd,
 
        /* Try to initialise basic parameters from active device */
 
-       if (!(*cd)->backing_file && dmd.data_device &&
-           crypt_loop_device(dmd.data_device) &&
-           !((*cd)->backing_file = crypt_loop_backing_file(dmd.data_device))) {
-               r = -ENOMEM;
-               goto out;
-       }
-
        if (dmd.target == DM_CRYPT)
                r = _init_by_name_crypt(*cd, name);
        else if (dmd.target == DM_VERITY)
@@ -903,6 +915,9 @@ static int _crypt_format_plain(struct crypt_device *cd,
                return -EINVAL;
        }
 
+       if (!(cd->type = strdup(CRYPT_PLAIN)))
+               return -ENOMEM;
+
        cd->plain_key_size = volume_key_size;
        cd->volume_key = crypt_alloc_volume_key(volume_key_size, NULL);
        if (!cd->volume_key)
@@ -944,6 +959,9 @@ static int _crypt_format_luks1(struct crypt_device *cd,
                return -EINVAL;
        }
 
+       if (!(cd->type = strdup(CRYPT_LUKS1)))
+               return -ENOMEM;
+
        if (volume_key)
                cd->volume_key = crypt_alloc_volume_key(volume_key_size,
                                                      volume_key);
@@ -1008,6 +1026,9 @@ static int _crypt_format_loopaes(struct crypt_device *cd,
                return -EINVAL;
        }
 
+       if (!(cd->type = strdup(CRYPT_LOOPAES)))
+               return -ENOMEM;
+
        cd->loopaes_key_size = volume_key_size;
 
        cd->loopaes_cipher = strdup(cipher ?: DEFAULT_LOOPAES_CIPHER);
@@ -1028,7 +1049,7 @@ static int _crypt_format_verity(struct crypt_device *cd,
                                 const char *uuid,
                                 struct crypt_params_verity *params)
 {
-       int r = 0;
+       int r = 0, hash_size;
        uint64_t data_device_size;
 
        if (!mdata_device(cd)) {
@@ -1039,14 +1060,30 @@ static int _crypt_format_verity(struct crypt_device *cd,
        if (!params || !params->data_device)
                return -EINVAL;
 
-       /* set data device */
-       cd->type = CRYPT_VERITY;
+       if (params->hash_type > VERITY_MAX_HASH_TYPE) {
+               log_err(cd, _("Unsupported VERITY hash type %d.\n"), params->hash_type);
+               return -EINVAL;
+       }
+
+       if (VERITY_BLOCK_SIZE_OK(params->data_block_size) ||
+           VERITY_BLOCK_SIZE_OK(params->hash_block_size)) {
+               log_err(cd, _("Unsupported VERITY block size.\n"));
+               return -EINVAL;
+       }
+
+       if (params->hash_area_offset % 512) {
+               log_err(cd, _("Unsupported VERITY hash offset.\n"));
+               return -EINVAL;
+       }
+
+       if (!(cd->type = strdup(CRYPT_VERITY)))
+               return -ENOMEM;
+
        r = crypt_set_data_device(cd, params->data_device);
-       cd->type = NULL;
        if (r)
                return r;
        if (!params->data_size) {
-               r = device_size(params->data_device, &data_device_size);
+               r = device_size(cd->device, &data_device_size);
                if (r < 0)
                        return r;
 
@@ -1054,9 +1091,13 @@ static int _crypt_format_verity(struct crypt_device *cd,
        } else
                cd->verity_hdr.data_size = params->data_size;
 
-       cd->verity_root_hash_size = crypt_hash_size(params->hash_name);
-       if (!cd->verity_root_hash_size)
+       hash_size = crypt_hash_size(params->hash_name);
+       if (hash_size <= 0) {
+               log_err(cd, _("Hash algorithm %s not supported.\n"),
+                       params->hash_name);
                return -EINVAL;
+       }
+       cd->verity_root_hash_size = hash_size;
 
        cd->verity_root_hash = malloc(cd->verity_root_hash_size);
        if (!cd->verity_root_hash)
@@ -1141,15 +1182,13 @@ int crypt_format(struct crypt_device *cd,
        else if (isVERITY(type))
                r = _crypt_format_verity(cd, uuid, params);
        else {
-               /* FIXME: allow plugins here? */
                log_err(cd, _("Unknown crypt device type %s requested.\n"), type);
                r = -EINVAL;
        }
 
-       if (!r && !(cd->type = strdup(type)))
-               r = -ENOMEM;
-
        if (r < 0) {
+               free(cd->type);
+               cd->type = NULL;
                crypt_free_volume_key(cd->volume_key);
                cd->volume_key = NULL;
        }
@@ -1185,16 +1224,6 @@ int crypt_load(struct crypt_device *cd,
        } else
                return -EINVAL;
 
-       if (r < 0)
-               return r;
-
-       /* cd->type and header must be set in context */
-       r = crypt_check_data_device_size(cd);
-       if (r < 0) {
-               free(cd->type);
-               cd->type = NULL;
-       }
-
        return r;
 }
 
@@ -1344,15 +1373,16 @@ void crypt_free(struct crypt_device *cd)
        if (cd) {
                log_dbg("Releasing crypt device %s context.", mdata_device(cd));
 
-               if (cd->loop_fd != -1)
-                       close(cd->loop_fd);
+               if (cd->loop_device_fd != -1)
+                       close(cd->loop_device_fd);
+               if (cd->loop_metadata_device_fd != -1)
+                       close(cd->loop_metadata_device_fd);
 
                dm_exit();
                crypt_free_volume_key(cd->volume_key);
 
                free(cd->device);
                free(cd->metadata_device);
-               free(cd->backing_file);
                free(cd->type);
 
                /* used in plain device only */