close: add LWSS_WAITING_TO_SEND_CLOSE_NOTIFICATION allowed to send
[platform/upstream/libwebsockets.git] / lib / service.c
index dc61c1d..1420f58 100644 (file)
 static int
 lws_calllback_as_writeable(struct lws *wsi)
 {
+       struct lws_context_per_thread *pt = &wsi->context->pt[(int)wsi->tsi];
        int n;
 
+       lws_stats_atomic_bump(wsi->context, pt, LWSSTATS_C_WRITEABLE_CB, 1);
+#if defined(LWS_WITH_STATS)
+       {
+               uint64_t ul = time_in_microseconds() - wsi->active_writable_req_us;
+
+               lws_stats_atomic_bump(wsi->context, pt, LWSSTATS_MS_WRITABLE_DELAY, ul);
+               lws_stats_atomic_max(wsi->context, pt, LWSSTATS_MS_WORST_WRITABLE_DELAY, ul);
+               wsi->active_writable_req_us = 0;
+       }
+#endif
+
        switch (wsi->mode) {
+       case LWSCM_RAW:
+               n = LWS_CALLBACK_RAW_WRITEABLE;
+               break;
+       case LWSCM_RAW_FILEDESC:
+               n = LWS_CALLBACK_RAW_WRITEABLE_FILE;
+               break;
        case LWSCM_WS_CLIENT:
                n = LWS_CALLBACK_CLIENT_WRITEABLE;
                break;
@@ -40,13 +58,13 @@ lws_calllback_as_writeable(struct lws *wsi)
                n = LWS_CALLBACK_HTTP_WRITEABLE;
                break;
        }
-       lwsl_debug("%s: %p (user=%p)\n", __func__, wsi, wsi->user_space);
+
        return user_callback_handle_rxflow(wsi->protocol->callback,
                                           wsi, (enum lws_callback_reasons) n,
                                           wsi->user_space, NULL, 0);
 }
 
-int
+LWS_VISIBLE int
 lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
 {
        int write_type = LWS_WRITE_PONG;
@@ -56,7 +74,15 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
 #endif
        int ret, m, n;
 
-       //lwsl_err("%s: %p\n", __func__, wsi);
+//     lwsl_err("%s: %p\n", __func__, wsi);
+
+       wsi->leave_pollout_active = 0;
+       wsi->handling_pollout = 1;
+       /*
+        * if another thread wants POLLOUT on us, from here on while
+        * handling_pollout is set, he will only set leave_pollout_active.
+        * If we are going to disable POLLOUT, we will check that first.
+        */
 
        /*
         * user callback is lowest priority to get these notifications
@@ -71,13 +97,15 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                if (lws_issue_raw(wsi, wsi->trunc_alloc + wsi->trunc_offset,
                                  wsi->trunc_len) < 0) {
                        lwsl_info("%s signalling to close\n", __func__);
-                       return -1;
+                       goto bail_die;
                }
                /* leave POLLOUT active either way */
-               return 0;
+               goto bail_ok;
        } else
-               if (wsi->state == LWSS_FLUSHING_STORED_SEND_BEFORE_CLOSE)
-                       return -1; /* retry closing now */
+               if (wsi->state == LWSS_FLUSHING_STORED_SEND_BEFORE_CLOSE) {
+                       wsi->socket_is_permanently_unusable = 1;
+                       goto bail_die; /* retry closing now */
+               }
 
        if (wsi->mode == LWSCM_WSCL_ISSUE_HTTP_BODY)
                goto user_service;
@@ -99,17 +127,46 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                wsi->pps = LWS_PPS_NONE;
                lws_rx_flow_control(wsi, 1);
 
-               return 0; /* leave POLLOUT active */
+               goto bail_ok; /* leave POLLOUT active */
        }
 #endif
 
 #ifdef LWS_WITH_CGI
-       if (wsi->cgi)
+       if (wsi->cgi) {
+               /* also one shot */
+               if (pollfd)
+                       if (lws_change_pollfd(wsi, LWS_POLLOUT, 0)) {
+                               lwsl_info("failed at set pollfd\n");
+                               return 1;
+                       }
                goto user_service_go_again;
+       }
 #endif
 
        /* Priority 3: pending control packets (pong or close)
+        *
+        * 3a: close notification packet requested from close api
         */
+
+       if (wsi->state == LWSS_WAITING_TO_SEND_CLOSE_NOTIFICATION) {
+               lwsl_debug("sending close packet\n");
+               wsi->waiting_to_send_close_frame = 0;
+               n = lws_write(wsi, &wsi->u.ws.ping_payload_buf[LWS_PRE],
+                             wsi->u.ws.close_in_ping_buffer_len,
+                             LWS_WRITE_CLOSE);
+               if (n >= 0) {
+                       wsi->state = LWSS_AWAITING_CLOSE_ACK;
+                       lws_set_timeout(wsi, PENDING_TIMEOUT_CLOSE_ACK, 1);
+                       lwsl_debug("sent close indication, awaiting ack\n");
+
+                       goto bail_ok;
+               }
+
+               goto bail_die;
+       }
+
+       /* else, the send failed and we should just hang up */
+
        if ((wsi->state == LWSS_ESTABLISHED &&
             wsi->u.ws.ping_pending_flag) ||
            (wsi->state == LWSS_RETURNED_CLOSE_ALREADY &&
@@ -121,16 +178,16 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                n = lws_write(wsi, &wsi->u.ws.ping_payload_buf[LWS_PRE],
                              wsi->u.ws.ping_payload_len, write_type);
                if (n < 0)
-                       return -1;
+                       goto bail_die;
 
                /* well he is sent, mark him done */
                wsi->u.ws.ping_pending_flag = 0;
                if (wsi->u.ws.payload_is_close)
                        /* oh... a close frame was it... then we are done */
-                       return -1;
+                       goto bail_die;
 
                /* otherwise for PING, leave POLLOUT active either way */
-               return 0;
+               goto bail_ok;
        }
 
        if (wsi->state == LWSS_ESTABLISHED &&
@@ -142,7 +199,7 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                n = lws_write(wsi, &wsi->u.ws.ping_payload_buf[LWS_PRE],
                              0, LWS_WRITE_PING);
                if (n < 0)
-                       return -1;
+                       goto bail_die;
 
                /*
                 * we apparently were able to send the PING in a reasonable time
@@ -153,7 +210,7 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                lws_set_timeout(wsi, PENDING_TIMEOUT_WS_PONG_CHECK_GET_PONG,
                                wsi->context->timeout_secs);
 
-               return 0;
+               goto bail_ok;
        }
 
        /* Priority 4: if we are closing, not allowed to send more data frags
@@ -172,16 +229,16 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
        if (wsi->state == LWSS_ESTABLISHED && wsi->u.ws.tx_draining_ext) {
                lwsl_ext("SERVICING TX EXT DRAINING\n");
                if (lws_write(wsi, NULL, 0, LWS_WRITE_CONTINUATION) < 0)
-                       return -1;
+                       goto bail_die;
                /* leave POLLOUT active */
-               return 0;
+               goto bail_ok;
        }
 
        /* Priority 6: user can get the callback
         */
        m = lws_ext_cb_active(wsi, LWS_EXT_CB_IS_WRITEABLE, NULL, 0);
        if (m)
-               return -1;
+               goto bail_die;
 #ifndef LWS_NO_EXTENSIONS
        if (!wsi->extension_data_pending)
                goto user_service;
@@ -195,6 +252,8 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
         */
 
        ret = 1;
+       if (wsi->mode == LWSCM_RAW || wsi->mode == LWSCM_RAW_FILEDESC)
+               ret = 0;
        while (ret == 1) {
 
                /* default to nobody has more to spill */
@@ -210,7 +269,7 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                                               &eff_buf, 0);
                if (m < 0) {
                        lwsl_err("ext reports fatal error\n");
-                       return -1;
+                       goto bail_die;
                }
                if (m)
                        /*
@@ -226,15 +285,15 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                                          eff_buf.token_len);
                        if (n < 0) {
                                lwsl_info("closing from POLLOUT spill\n");
-                               return -1;
+                               goto bail_die;
                        }
                        /*
                         * Keep amount spilled small to minimize chance of this
                         */
                        if (n != eff_buf.token_len) {
-                               lwsl_err("Unable to spill ext %d vs %s\n",
+                               lwsl_err("Unable to spill ext %d vs %d\n",
                                                          eff_buf.token_len, n);
-                               return -1;
+                               goto bail_die;
                        }
                } else
                        continue;
@@ -262,7 +321,7 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
                 * when we come back here and there's nothing more to spill.
                 */
 
-               return 0;
+               goto bail_ok;
        }
 #ifndef LWS_NO_EXTENSIONS
        wsi->extension_data_pending = 0;
@@ -270,15 +329,37 @@ lws_handle_POLLOUT_event(struct lws *wsi, struct lws_pollfd *pollfd)
 user_service:
        /* one shot */
 
-       if (pollfd)
-               if (lws_change_pollfd(wsi, LWS_POLLOUT, 0)) {
-                       lwsl_info("failed at set pollfd\n");
-                       return 1;
-               }
+       if (wsi->parent_carries_io) {
+               wsi->handling_pollout = 0;
+               wsi->leave_pollout_active = 0;
+
+               return lws_calllback_as_writeable(wsi);
+       }
+
+       if (pollfd) {
+               int eff = wsi->leave_pollout_active;
+
+               if (!eff)
+                       if (lws_change_pollfd(wsi, LWS_POLLOUT, 0)) {
+                               lwsl_info("failed at set pollfd\n");
+                               goto bail_die;
+                       }
+
+               wsi->handling_pollout = 0;
+
+               /* cannot get leave_pollout_active set after the above */
+               if (!eff && wsi->leave_pollout_active)
+                       /* got set inbetween sampling eff and clearing
+                        * handling_pollout, force POLLOUT on */
+                       lws_calllback_as_writeable(wsi);
+
+               wsi->leave_pollout_active = 0;
+       }
 
        if (wsi->mode != LWSCM_WSCL_ISSUE_HTTP_BODY &&
            !wsi->hdr_parsing_completed)
-               return 0;
+               goto bail_ok;
+
 
 #ifdef LWS_WITH_CGI
 user_service_go_again:
@@ -306,7 +387,7 @@ user_service_go_again:
        wsi->u.http2.requested_POLLOUT = 0;
        if (!wsi->u.http2.initialized) {
                lwsl_info("pollout on uninitialized http2 conn\n");
-               return 0;
+               goto bail_ok;
        }
 
        lwsl_info("%s: doing children\n", __func__);
@@ -329,10 +410,30 @@ user_service_go_again:
 
        lwsl_info("%s: completed\n", __func__);
 
-       return 0;
+       goto bail_ok;
 notify:
 #endif
+       wsi->handling_pollout = 0;
+       wsi->leave_pollout_active = 0;
+
        return lws_calllback_as_writeable(wsi);
+
+       /*
+        * since these don't disable the POLLOUT, they are always doing the
+        * right thing for leave_pollout_active whether it was set or not.
+        */
+
+bail_ok:
+       wsi->handling_pollout = 0;
+       wsi->leave_pollout_active = 0;
+
+       return 0;
+
+bail_die:
+       wsi->handling_pollout = 0;
+       wsi->leave_pollout_active = 0;
+
+       return -1;
 }
 
 int
@@ -361,15 +462,17 @@ lws_service_timeout_check(struct lws *wsi, unsigned int sec)
         */
        if ((time_t)sec > wsi->pending_timeout_limit) {
 //#if LWS_POSIX
-               if (wsi->sock != LWS_SOCK_INVALID && wsi->position_in_fds_table >= 0)
+               if (wsi->desc.sockfd != LWS_SOCK_INVALID && wsi->position_in_fds_table >= 0)
                        n = pt->fds[wsi->position_in_fds_table].events;
 
+               lws_stats_atomic_bump(wsi->context, pt, LWSSTATS_C_TIMEOUTS, 1);
+
                /* no need to log normal idle keepalive timeout */
                if (wsi->pending_timeout != PENDING_TIMEOUT_HTTP_KEEPALIVE_IDLE)
-                       lwsl_notice("wsi %p: TIMEDOUT WAITING on %d (did hdr %d, ah %p, wl %d, pfd events %d)\n",
+                       lwsl_notice("wsi %p: TIMEDOUT WAITING on %d (did hdr %d, ah %p, wl %d, pfd events %d) %llu vs %llu\n",
                            (void *)wsi, wsi->pending_timeout,
                            wsi->hdr_parsing_completed, wsi->u.hdr.ah,
-                           pt->ah_wait_list_length, n);
+                           pt->ah_wait_list_length, n, (unsigned long long)sec, (unsigned long long)wsi->pending_timeout_limit);
 //#endif
                /*
                 * Since he failed a timeout, he already had a chance to do
@@ -481,9 +584,10 @@ lws_service_flag_pending(struct lws_context *context, int tsi)
        while (wsi) {
                pt->fds[wsi->position_in_fds_table].revents |=
                        pt->fds[wsi->position_in_fds_table].events & LWS_POLLIN;
-               if (pt->fds[wsi->position_in_fds_table].revents &
-                   LWS_POLLIN)
+               if (pt->fds[wsi->position_in_fds_table].revents & LWS_POLLIN) {
                        forced = 1;
+                       break;
+               }
                wsi = wsi->u.ws.rx_draining_ext_list;
        }
 
@@ -540,21 +644,25 @@ lws_http_client_read(struct lws *wsi, char **buf, int *len)
 {
        int rlen, n;
 
+       rlen = lws_ssl_capable_read(wsi, (unsigned char *)*buf, *len);
+       *len = 0;
 
+       /* allow the source to signal he has data again next time */
+       lws_change_pollfd(wsi, 0, LWS_POLLIN);
 
-       rlen = lws_ssl_capable_read(wsi, (unsigned char *)*buf, *len);
-       if (rlen < 0)
+       if (rlen == LWS_SSL_CAPABLE_ERROR) {
+               lwsl_notice("%s: SSL capable error\n", __func__);
                return -1;
+       }
 
-       *len = rlen;
        if (rlen == 0)
-               return 0;
+               return -1;
 
-//     lwsl_err("%s: read %d\n", __func__, rlen);
+       if (rlen < 0)
+               return 0;
 
-       /* allow the source to signal he has data again next time */
+       *len = rlen;
        wsi->client_rx_avail = 0;
-       lws_change_pollfd(wsi, 0, LWS_POLLIN);
 
        /*
         * server may insist on transfer-encoding: chunked,
@@ -569,14 +677,18 @@ spin_chunks:
                                break;
                        }
                        n = char_to_hex((*buf)[0]);
-                       if (n < 0)
+                       if (n < 0) {
+                               lwsl_debug("chunking failure\n");
                                return -1;
+                       }
                        wsi->chunk_remaining <<= 4;
                        wsi->chunk_remaining |= n;
                        break;
                case ELCP_CR:
-                       if ((*buf)[0] != '\x0a')
+                       if ((*buf)[0] != '\x0a') {
+                               lwsl_debug("chunking failure\n");
                                return -1;
+                       }
                        wsi->chunk_parser = ELCP_CONTENT;
                        lwsl_info("chunk %d\n", wsi->chunk_remaining);
                        if (wsi->chunk_remaining)
@@ -588,8 +700,11 @@ spin_chunks:
                        break;
 
                case ELCP_POST_CR:
-                       if ((*buf)[0] != '\x0d')
+                       if ((*buf)[0] != '\x0d') {
+                               lwsl_debug("chunking failure\n");
+
                                return -1;
+                       }
 
                        wsi->chunk_parser = ELCP_POST_LF;
                        break;
@@ -610,8 +725,8 @@ spin_chunks:
                return 0;
 
        if (wsi->u.http.content_remain &&
-           (int)wsi->u.http.content_remain < *len)
-               n = wsi->u.http.content_remain;
+           wsi->u.http.content_remain < *len)
+               n = (int)wsi->u.http.content_remain;
        else
                n = *len;
 
@@ -627,8 +742,11 @@ spin_chunks:
 #endif
                if (user_callback_handle_rxflow(wsi->protocol->callback,
                                wsi, LWS_CALLBACK_RECEIVE_CLIENT_HTTP_READ,
-                               wsi->user_space, *buf, n))
+                               wsi->user_space, *buf, n)) {
+                       lwsl_debug("%s: LWS_CALLBACK_RECEIVE_CLIENT_HTTP_READ returned -1\n", __func__);
+
                        return -1;
+               }
 
        if (wsi->chunked && wsi->chunk_remaining) {
                (*buf) += n;
@@ -639,30 +757,47 @@ spin_chunks:
        if (wsi->chunked && !wsi->chunk_remaining)
                wsi->chunk_parser = ELCP_POST_CR;
 
-       if (wsi->chunked && *len) {
+       if (wsi->chunked && *len)
                goto spin_chunks;
-       }
 
        if (wsi->chunked)
                return 0;
 
-       wsi->u.http.content_remain -= n;
+       /* if we know the content length, decrement the content remaining */
+       if (wsi->u.http.content_length > 0)
+               wsi->u.http.content_remain -= n;
+
        if (wsi->u.http.content_remain || !wsi->u.http.content_length)
                return 0;
 
 completed:
        if (user_callback_handle_rxflow(wsi->protocol->callback,
                        wsi, LWS_CALLBACK_COMPLETED_CLIENT_HTTP,
-                       wsi->user_space, NULL, 0))
+                       wsi->user_space, NULL, 0)) {
+               lwsl_debug("Completed call returned -1\n");
                return -1;
+       }
 
-       if (lws_http_transaction_completed_client(wsi))
+       if (lws_http_transaction_completed_client(wsi)) {
+               lwsl_notice("%s: transaction completed says -1\n", __func__);
                return -1;
+       }
 
        return 0;
 }
 #endif
 
+static int
+lws_is_ws_with_ext(struct lws *wsi)
+{
+#if defined(LWS_NO_EXTENSIONS)
+       return 0;
+#else
+       return wsi->state == LWSS_ESTABLISHED &&
+              !!wsi->count_act_ext;
+#endif
+}
+
 LWS_VISIBLE int
 lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int tsi)
 {
@@ -693,16 +828,27 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
        if (context->last_timeout_check_s != now) {
                context->last_timeout_check_s = now;
 
+#if defined(LWS_WITH_STATS)
+               if (!tsi && now - context->last_dump > 10) {
+                       lws_stats_log_dump(context);
+                       context->last_dump = now;
+               }
+#endif
+
                lws_plat_service_periodic(context);
 
-               /* retire unused deprecated context */
+               lws_check_deferred_free(context, 0);
 
+               /* retire unused deprecated context */
+#if !defined(LWS_PLAT_OPTEE) && !defined(LWS_WITH_ESP32)
+#if LWS_POSIX && !defined(_WIN32)
                if (context->deprecated && !context->count_wsi_allocated) {
                        lwsl_notice("%s: ending deprecated context\n", __func__);
                        kill(getpid(), SIGINT);
                        return 0;
                }
-
+#endif
+#endif
                /* global timeout check once per second */
 
                if (pollfd)
@@ -712,7 +858,7 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
                while (wsi) {
                        /* we have to take copies, because he may be deleted */
                        wsi1 = wsi->timeout_list;
-                       tmp_fd = wsi->sock;
+                       tmp_fd = wsi->desc.sockfd;
                        if (lws_service_timeout_check(wsi, (unsigned int)now)) {
                                /* he did time out... */
                                if (tmp_fd == our_fd)
@@ -745,9 +891,9 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
 
        if (context->ws_ping_pong_interval &&
            context->last_ws_ping_pong_check_s < now + 10) {
+               struct lws_vhost *vh = context->vhost_list;
                context->last_ws_ping_pong_check_s = now;
 
-               struct lws_vhost *vh = context->vhost_list;
                while (vh) {
                        for (n = 0; n < vh->count_protocols; n++) {
                                wsi = vh->same_vh_protocol_list[n];
@@ -812,7 +958,50 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
 
 #endif
 
-       lwsl_debug("fd=%d, revents=%d\n", pollfd->fd, pollfd->revents);
+//       lwsl_debug("fd=%d, revents=%d, mode=%d, state=%d\n", pollfd->fd, pollfd->revents, (int)wsi->mode, (int)wsi->state);
+       if (pollfd->revents & LWS_POLLHUP) {
+               lwsl_debug("pollhup\n");
+               wsi->socket_is_permanently_unusable = 1;
+               goto close_and_handled;
+       }
+
+
+#ifdef LWS_OPENSSL_SUPPORT
+       if ((wsi->state == LWSS_SHUTDOWN) && lws_is_ssl(wsi) && wsi->ssl)
+       {
+               n = SSL_shutdown(wsi->ssl);
+               lwsl_debug("SSL_shutdown=%d for fd %d\n", n, wsi->desc.sockfd);
+               if (n == 1)
+               {
+                       n = shutdown(wsi->desc.sockfd, SHUT_WR);
+                       goto close_and_handled;
+               }
+               else if (n == 0)
+               {
+                       lws_change_pollfd(wsi, LWS_POLLOUT, LWS_POLLIN);
+                       n = 0;
+                       goto handled;
+               }
+               else /* n < 0 */
+               {
+                       int shutdown_error = SSL_get_error(wsi->ssl, n);
+                       lwsl_debug("SSL_shutdown returned %d, SSL_get_error: %d\n", n, shutdown_error);
+                       if (shutdown_error == SSL_ERROR_WANT_READ) {
+                               lws_change_pollfd(wsi, LWS_POLLOUT, LWS_POLLIN);
+                               n = 0;
+                               goto handled;
+                       } else if (shutdown_error == SSL_ERROR_WANT_WRITE) {
+                               lws_change_pollfd(wsi, LWS_POLLOUT, LWS_POLLOUT);
+                               n = 0;
+                               goto handled;
+                       }
+
+                       // actual error occurred, just close the connection
+                       n = shutdown(wsi->desc.sockfd, SHUT_WR);
+                       goto close_and_handled;
+               }
+       }
+#endif
 
        /* okay, what we came here to do... */
 
@@ -822,6 +1011,7 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
        case LWSCM_HTTP_SERVING_ACCEPTED:
        case LWSCM_SERVER_LISTENER:
        case LWSCM_SSL_ACK_PENDING:
+       case LWSCM_SSL_ACK_PENDING_RAW:
                if (wsi->state == LWSS_CLIENT_HTTP_ESTABLISHED)
                        goto handled;
 
@@ -833,11 +1023,43 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
                        goto handled;
                }
 #endif
+               /* fallthru */
+       case LWSCM_RAW:
                n = lws_server_socket_service(context, wsi, pollfd);
                if (n) /* closed by above */
                        return 1;
                goto handled;
 
+       case LWSCM_RAW_FILEDESC:
+
+               if (pollfd->revents & LWS_POLLOUT) {
+                       n = lws_calllback_as_writeable(wsi);
+                       if (lws_change_pollfd(wsi, LWS_POLLOUT, 0)) {
+                               lwsl_info("failed at set pollfd\n");
+                               return 1;
+                       }
+                       if (n)
+                               goto close_and_handled;
+               }
+               n = LWS_CALLBACK_RAW_RX;
+               if (wsi->mode == LWSCM_RAW_FILEDESC)
+                       n = LWS_CALLBACK_RAW_RX_FILE;
+
+               if (pollfd->revents & LWS_POLLIN) {
+                       if (user_callback_handle_rxflow(
+                                       wsi->protocol->callback,
+                                       wsi, n,
+                                       wsi->user_space, NULL, 0)) {
+                               lwsl_debug("raw rx callback closed it\n");
+                               goto close_and_handled;
+                       }
+               }
+
+               if (pollfd->revents & LWS_POLLHUP)
+                       goto close_and_handled;
+               n = 0;
+               goto handled;
+
        case LWSCM_WS_SERVING:
        case LWSCM_WS_CLIENT:
        case LWSCM_HTTP2_SERVING:
@@ -845,12 +1067,16 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
 
                /* 1: something requested a callback when it was OK to write */
 
+               if (wsi->state == LWSS_WAITING_TO_SEND_CLOSE_NOTIFICATION)
+                       lwsl_notice("xxx\n");
+
                if ((pollfd->revents & LWS_POLLOUT) &&
-                   (wsi->state == LWSS_ESTABLISHED ||
+                   ((wsi->state == LWSS_ESTABLISHED ||
                     wsi->state == LWSS_HTTP2_ESTABLISHED ||
                     wsi->state == LWSS_HTTP2_ESTABLISHED_PRE_SETTINGS ||
                     wsi->state == LWSS_RETURNED_CLOSE_ALREADY ||
-                    wsi->state == LWSS_FLUSHING_STORED_SEND_BEFORE_CLOSE) &&
+                    wsi->state == LWSS_WAITING_TO_SEND_CLOSE_NOTIFICATION ||
+                    wsi->state == LWSS_FLUSHING_STORED_SEND_BEFORE_CLOSE)) &&
                    lws_handle_POLLOUT_event(wsi, pollfd)) {
                        if (wsi->state == LWSS_RETURNED_CLOSE_ALREADY)
                                wsi->state = LWSS_FLUSHING_STORED_SEND_BEFORE_CLOSE;
@@ -859,6 +1085,7 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
                }
 
                if (wsi->state == LWSS_RETURNED_CLOSE_ALREADY ||
+                   wsi->state == LWSS_WAITING_TO_SEND_CLOSE_NOTIFICATION ||
                    wsi->state == LWSS_AWAITING_CLOSE_ACK) {
                        /*
                         * we stopped caring about anything except control
@@ -937,9 +1164,6 @@ lws_service_fd_tsi(struct lws_context *context, struct lws_pollfd *pollfd, int t
                        break;
 
 read:
-               /* all the union members start with hdr, so even in ws mode
-                * we can deal with the ah via u.hdr
-                */
                if (wsi->u.hdr.ah) {
                        lwsl_info("%s: %p: inherited ah rx\n", __func__, wsi);
                        eff_buf.token_len = wsi->u.hdr.ah->rxlen -
@@ -948,9 +1172,24 @@ read:
                                        wsi->u.hdr.ah->rxpos;
                } else {
                        if (wsi->mode != LWSCM_HTTP_CLIENT_ACCEPTED) {
+                               /*
+                                * extension may not consume everything (eg, pmd may be constrained
+                                * as to what it can output...) has to go in per-wsi rx buf area.
+                                * Otherwise in large temp serv_buf area.
+                                */
+                               eff_buf.token = (char *)pt->serv_buf;
+                               if (lws_is_ws_with_ext(wsi)) {
+                                       eff_buf.token_len = wsi->u.ws.rx_ubuf_alloc;
+                               } else {
+                                       eff_buf.token_len = context->pt_serv_buf_size;
+                               }
+
+                               if ((unsigned int)eff_buf.token_len > context->pt_serv_buf_size)
+                                       eff_buf.token_len = context->pt_serv_buf_size;
+
                                eff_buf.token_len = lws_ssl_capable_read(wsi,
-                                       pt->serv_buf, pending ? pending :
-                                       context->pt_serv_buf_size);
+                                       (unsigned char *)eff_buf.token, pending ? pending :
+                                       eff_buf.token_len);
                                switch (eff_buf.token_len) {
                                case 0:
                                        lwsl_info("%s: zero length read\n", __func__);
@@ -963,8 +1202,7 @@ read:
                                        lwsl_info("Closing when error\n");
                                        goto close_and_handled;
                                }
-
-                               eff_buf.token = (char *)pt->serv_buf;
+                               // lwsl_notice("Actual RX %d\n", eff_buf.token_len);
                        }
                }
 
@@ -974,6 +1212,13 @@ drain:
                    !wsi->told_user_closed) {
 
                        /*
+                        * In SSL mode we get POLLIN notification about
+                        * encrypted data in.
+                        *
+                        * But that is not necessarily related to decrypted
+                        * data out becoming available; in may need to perform
+                        * other in or out before that happens.
+                        *
                         * simply mark ourselves as having readable data
                         * and turn off our POLLIN
                         */
@@ -986,8 +1231,13 @@ drain:
                        if (user_callback_handle_rxflow(
                                        wsi->protocol->callback,
                                        wsi, LWS_CALLBACK_RECEIVE_CLIENT_HTTP,
-                                       wsi->user_space, NULL, 0))
+                                       wsi->user_space, NULL, 0)) {
+                               lwsl_notice("LWS_CALLBACK_RECEIVE_CLIENT_HTTP closed it\n");
                                goto close_and_handled;
+                       }
+
+                       n = 0;
+                       goto handled;
                }
 #endif
                /*
@@ -1021,6 +1271,8 @@ drain:
                                 * around again it will pick up from where it
                                 * left off.
                                 */
+                               // lwsl_notice("doing lws_read from pt->serv_buf %p %p for len %d\n", pt->serv_buf, eff_buf.token, (int)eff_buf.token_len);
+
                                n = lws_read(wsi, (unsigned char *)eff_buf.token,
                                             eff_buf.token_len);
                                if (n < 0) {
@@ -1037,8 +1289,7 @@ drain:
                if (wsi->u.hdr.ah) {
                        lwsl_notice("%s: %p: detaching\n",
                                 __func__, wsi);
-                       /* show we used all the pending rx up */
-                       wsi->u.hdr.ah->rxpos = wsi->u.hdr.ah->rxlen;
+                       lws_header_table_force_to_detachable_state(wsi);
                        /* we can run the normal ah detach flow despite
                         * being in ws union mode, since all union members
                         * start with hdr */
@@ -1047,7 +1298,11 @@ drain:
 
                pending = lws_ssl_pending(wsi);
                if (pending) {
-                       pending = pending > context->pt_serv_buf_size ?
+                       if (lws_is_ws_with_ext(wsi))
+                               pending = pending > wsi->u.ws.rx_ubuf_alloc ?
+                                       wsi->u.ws.rx_ubuf_alloc : pending;
+                       else
+                               pending = pending > context->pt_serv_buf_size ?
                                        context->pt_serv_buf_size : pending;
                        goto read;
                }
@@ -1107,8 +1362,10 @@ drain:
                break;
 #else
                if ((pollfd->revents & LWS_POLLOUT) &&
-                   lws_handle_POLLOUT_event(wsi, pollfd))
+                   lws_handle_POLLOUT_event(wsi, pollfd)) {
+                       lwsl_debug("POLLOUT event closed it\n");
                        goto close_and_handled;
+               }
 
                n = lws_client_socket_service(context, wsi, pollfd);
                if (n)
@@ -1121,7 +1378,7 @@ drain:
        goto handled;
 
 close_and_handled:
-       lwsl_debug("Close and handled\n");
+       lwsl_debug("%p: Close and handled\n", wsi);
        lws_close_free_wsi(wsi, LWS_CLOSE_STATUS_NOSTATUS);
        /*
         * pollfd may point to something else after the close