change calling conventions of isl_basic_set_has_defining_{,in}equalit{y,ies}
[platform/upstream/isl.git] / isl_map.c
index 5abfe3b..1677c75 100644 (file)
--- a/isl_map.c
+++ b/isl_map.c
@@ -2,6 +2,7 @@
 #include <strings.h>
 #include "isl_ctx.h"
 #include "isl_blk.h"
+#include "isl_dim.h"
 #include "isl_equalities.h"
 #include "isl_list.h"
 #include "isl_lp.h"
 #include "isl_sample.h"
 #include "isl_vec.h"
 
+/* Maps dst positions to src positions */
+struct isl_dim_map {
+       unsigned len;
+       int pos[1];
+};
+
+static struct isl_dim_map *isl_dim_map_alloc(struct isl_ctx *ctx, unsigned len)
+{
+       int i;
+       struct isl_dim_map *dim_map;
+       dim_map = isl_alloc(ctx, struct isl_dim_map,
+                               sizeof(struct isl_dim_map) + len * sizeof(int));
+       if (!dim_map)
+               return NULL;
+       dim_map->len = 1 + len;
+       dim_map->pos[0] = 0;
+       for (i = 0; i < len; ++i)
+               dim_map->pos[1 + i] = -1;
+       return dim_map;
+}
+
+static unsigned n(struct isl_dim *dim, enum isl_dim_type type)
+{
+       switch (type) {
+       case isl_dim_param:     return dim->nparam;
+       case isl_dim_in:        return dim->n_in;
+       case isl_dim_out:       return dim->n_out;
+       }
+}
+
+static unsigned pos(struct isl_dim *dim, enum isl_dim_type type)
+{
+       switch (type) {
+       case isl_dim_param:     return 1;
+       case isl_dim_in:        return 1 + dim->nparam;
+       case isl_dim_out:       return 1 + dim->nparam + dim->n_in;
+       }
+}
+
+static void isl_dim_map_dim(struct isl_dim_map *dim_map, struct isl_dim *dim,
+               enum isl_dim_type type, unsigned dst_pos)
+{
+       int i;
+       unsigned src_pos;
+
+       if (!dim_map || !dim)
+               return;
+       
+       src_pos = pos(dim, type);
+       for (i = 0; i < n(dim, type); ++i)
+               dim_map->pos[1 + dst_pos + i] = src_pos + i;
+}
+
+static void isl_dim_map_div(struct isl_dim_map *dim_map,
+               struct isl_basic_map *bmap, unsigned dst_pos)
+{
+       int i;
+       unsigned src_pos;
+
+       if (!dim_map || !bmap)
+               return;
+       
+       src_pos = 1 + isl_dim_total(bmap->dim);
+       for (i = 0; i < bmap->n_div; ++i)
+               dim_map->pos[1 + dst_pos + i] = src_pos + i;
+}
+
+static void isl_dim_map_dump(struct isl_dim_map *dim_map)
+{
+       int i;
+
+       for (i = 0; i < dim_map->len; ++i)
+               fprintf(stderr, "%d -> %d; ", i, dim_map->pos[i]);
+       fprintf(stderr, "\n");
+}
+
+unsigned isl_basic_map_dim(const struct isl_basic_map *bmap,
+                               enum isl_dim_type type)
+{
+       struct isl_dim *dim = bmap->dim;
+       switch (type) {
+       case isl_dim_param:     return dim->nparam;
+       case isl_dim_in:        return dim->n_in;
+       case isl_dim_out:       return dim->n_out;
+       case isl_dim_div:       return bmap->n_div;
+       case isl_dim_all:       return isl_basic_map_total_dim(bmap);
+       }
+}
+
+unsigned isl_basic_set_dim(const struct isl_basic_set *bset,
+                               enum isl_dim_type type)
+{
+       return isl_basic_map_dim((const struct isl_basic_map*)bset, type);
+}
+
+unsigned isl_basic_set_n_dim(const struct isl_basic_set *bset)
+{
+       return bset->dim->n_out;
+}
+
+unsigned isl_basic_set_n_param(const struct isl_basic_set *bset)
+{
+       return bset->dim->nparam;
+}
+
+unsigned isl_basic_set_total_dim(const struct isl_basic_set *bset)
+{
+       return isl_dim_total(bset->dim) + bset->n_div;
+}
+
+unsigned isl_set_n_dim(const struct isl_set *set)
+{
+       return set->dim->n_out;
+}
+
+unsigned isl_set_n_param(const struct isl_set *set)
+{
+       return set->dim->nparam;
+}
+
+unsigned isl_basic_map_n_in(const struct isl_basic_map *bmap)
+{
+       return bmap->dim->n_in;
+}
+
+unsigned isl_basic_map_n_out(const struct isl_basic_map *bmap)
+{
+       return bmap->dim->n_out;
+}
+
+unsigned isl_basic_map_n_param(const struct isl_basic_map *bmap)
+{
+       return bmap->dim->nparam;
+}
+
+unsigned isl_basic_map_n_div(const struct isl_basic_map *bmap)
+{
+       return bmap->n_div;
+}
+
+unsigned isl_basic_map_total_dim(const struct isl_basic_map *bmap)
+{
+       return isl_dim_total(bmap->dim) + bmap->n_div;
+}
+
+unsigned isl_map_n_in(const struct isl_map *map)
+{
+       return map->dim->n_in;
+}
+
+unsigned isl_map_n_out(const struct isl_map *map)
+{
+       return map->dim->n_out;
+}
+
+unsigned isl_map_n_param(const struct isl_map *map)
+{
+       return map->dim->nparam;
+}
+
+int isl_map_compatible_domain(struct isl_map *map, struct isl_set *set)
+{
+       return map->dim->n_in == set->dim->n_out &&
+              map->dim->nparam == set->dim->nparam;
+}
+
+int isl_basic_map_compatible_domain(struct isl_basic_map *bmap,
+               struct isl_basic_set *bset)
+{
+       return bmap->dim->n_in == bset->dim->n_out &&
+              bmap->dim->nparam == bset->dim->nparam;
+}
+
+int isl_basic_map_compatible_range(struct isl_basic_map *bmap,
+               struct isl_basic_set *bset)
+{
+       return bmap->dim->n_out == bset->dim->n_out &&
+              bmap->dim->nparam == bset->dim->nparam;
+}
+
 static struct isl_basic_map *basic_map_init(struct isl_ctx *ctx,
-               struct isl_basic_map *bmap,
-               unsigned nparam, unsigned n_in, unsigned n_out, unsigned extra,
+               struct isl_basic_map *bmap, unsigned extra,
                unsigned n_eq, unsigned n_ineq)
 {
        int i;
-       size_t row_size = 1 + nparam + n_in + n_out + extra;
+       size_t row_size = 1 + isl_dim_total(bmap->dim) + extra;
 
        bmap->block = isl_blk_alloc(ctx, (n_eq + n_ineq) * row_size);
        if (isl_blk_is_error(bmap->block)) {
@@ -68,9 +248,6 @@ static struct isl_basic_map *basic_map_init(struct isl_ctx *ctx,
        bmap->flags = 0;
        bmap->c_size = n_eq + n_ineq;
        bmap->ineq = bmap->eq + n_eq;
-       bmap->nparam = nparam;
-       bmap->n_in = n_in;
-       bmap->n_out = n_out;
        bmap->extra = extra;
        bmap->n_eq = 0;
        bmap->n_ineq = 0;
@@ -78,6 +255,9 @@ static struct isl_basic_map *basic_map_init(struct isl_ctx *ctx,
        bmap->sample = NULL;
 
        return bmap;
+error:
+       isl_basic_map_free(bmap);
+       return NULL;
 }
 
 struct isl_basic_set *isl_basic_set_alloc(struct isl_ctx *ctx,
@@ -89,25 +269,55 @@ struct isl_basic_set *isl_basic_set_alloc(struct isl_ctx *ctx,
        return (struct isl_basic_set *)bmap;
 }
 
+struct isl_basic_set *isl_basic_set_alloc_dim(struct isl_dim *dim,
+               unsigned extra, unsigned n_eq, unsigned n_ineq)
+{
+       struct isl_basic_map *bmap;
+       if (!dim)
+               return NULL;
+       isl_assert(dim->ctx, dim->n_in == 0, return NULL);
+       bmap = isl_basic_map_alloc_dim(dim, extra, n_eq, n_ineq);
+       return (struct isl_basic_set *)bmap;
+}
+
+struct isl_basic_map *isl_basic_map_alloc_dim(struct isl_dim *dim,
+               unsigned extra, unsigned n_eq, unsigned n_ineq)
+{
+       struct isl_basic_map *bmap;
+
+       if (!dim)
+               return NULL;
+       bmap = isl_alloc_type(dim->ctx, struct isl_basic_map);
+       if (!bmap)
+               goto error;
+       bmap->dim = dim;
+
+       return basic_map_init(dim->ctx, bmap, extra, n_eq, n_ineq);
+error:
+       isl_dim_free(dim);
+       return NULL;
+}
+
 struct isl_basic_map *isl_basic_map_alloc(struct isl_ctx *ctx,
                unsigned nparam, unsigned in, unsigned out, unsigned extra,
                unsigned n_eq, unsigned n_ineq)
 {
        struct isl_basic_map *bmap;
+       struct isl_dim *dim;
 
-       bmap = isl_alloc_type(ctx, struct isl_basic_map);
-       if (!bmap)
+       dim = isl_dim_alloc(ctx, nparam, in, out);
+       if (!dim)
                return NULL;
 
-       return basic_map_init(ctx, bmap,
-                              nparam, in, out, extra, n_eq, n_ineq);
+       bmap = isl_basic_map_alloc_dim(dim, extra, n_eq, n_ineq);
+       return bmap;
 }
 
 static void dup_constraints(
                struct isl_basic_map *dst, struct isl_basic_map *src)
 {
        int i;
-       unsigned total = src->nparam + src->n_in + src->n_out + src->n_div;
+       unsigned total = isl_basic_map_total_dim(src);
 
        for (i = 0; i < src->n_eq; ++i) {
                int j = isl_basic_map_alloc_equality(dst);
@@ -132,8 +342,7 @@ struct isl_basic_map *isl_basic_map_dup(struct isl_basic_map *bmap)
 
        if (!bmap)
                return NULL;
-       dup = isl_basic_map_alloc(bmap->ctx, bmap->nparam,
-                       bmap->n_in, bmap->n_out,
+       dup = isl_basic_map_alloc_dim(isl_dim_copy(bmap->dim),
                        bmap->n_div, bmap->n_eq, bmap->n_ineq);
        if (!dup)
                return NULL;
@@ -207,6 +416,7 @@ void isl_basic_map_free(struct isl_basic_map *bmap)
        free(bmap->eq);
        isl_blk_free(bmap->ctx, bmap->block);
        isl_vec_free(bmap->ctx, bmap->sample);
+       isl_dim_free(bmap->dim);
        free(bmap);
 }
 
@@ -235,7 +445,7 @@ int isl_basic_map_alloc_equality(struct isl_basic_map *bmap)
                bmap->ineq++;
        } else
                isl_seq_clr(bmap->eq[bmap->n_eq] +
-                     1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div,
+                     1 + isl_basic_map_total_dim(bmap),
                      bmap->extra - bmap->n_div);
        return bmap->n_eq++;
 }
@@ -302,7 +512,7 @@ int isl_basic_map_alloc_inequality(struct isl_basic_map *bmap)
        F_CLR(bmap, ISL_BASIC_MAP_NO_REDUNDANT);
        F_CLR(bmap, ISL_BASIC_MAP_NORMALIZED);
        isl_seq_clr(bmap->ineq[bmap->n_ineq] +
-                     1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div,
+                     1 + isl_basic_map_total_dim(bmap),
                      bmap->extra - bmap->n_div);
        return bmap->n_ineq++;
 }
@@ -354,7 +564,7 @@ int isl_basic_map_alloc_div(struct isl_basic_map *bmap)
                return -1;
        isl_assert(bmap->ctx, bmap->n_div < bmap->extra, return -1);
        isl_seq_clr(bmap->div[bmap->n_div] +
-                     1 + 1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div,
+                     1 + 1 + isl_basic_map_total_dim(bmap),
                      bmap->extra - bmap->n_div);
        return bmap->n_div++;
 }
@@ -377,31 +587,37 @@ static void copy_constraint(struct isl_basic_map *dst_map, isl_int *dst,
                            struct isl_basic_map *src_map, isl_int *src,
                            unsigned in_off, unsigned out_off, unsigned div_off)
 {
+       unsigned src_nparam = isl_basic_map_n_param(src_map);
+       unsigned dst_nparam = isl_basic_map_n_param(dst_map);
+       unsigned src_in = isl_basic_map_n_in(src_map);
+       unsigned dst_in = isl_basic_map_n_in(dst_map);
+       unsigned src_out = isl_basic_map_n_out(src_map);
+       unsigned dst_out = isl_basic_map_n_out(dst_map);
        isl_int_set(dst[0], src[0]);
-       isl_seq_cpy(dst+1, src+1, isl_min(dst_map->nparam, src_map->nparam));
-       if (dst_map->nparam > src_map->nparam)
-               isl_seq_clr(dst+1+src_map->nparam,
-                               dst_map->nparam - src_map->nparam);
-       isl_seq_clr(dst+1+dst_map->nparam, in_off);
-       isl_seq_cpy(dst+1+dst_map->nparam+in_off,
-                   src+1+src_map->nparam,
-                   isl_min(dst_map->n_in-in_off, src_map->n_in));
-       if (dst_map->n_in-in_off > src_map->n_in)
-               isl_seq_clr(dst+1+dst_map->nparam+in_off+src_map->n_in,
-                               dst_map->n_in - in_off - src_map->n_in);
-       isl_seq_clr(dst+1+dst_map->nparam+dst_map->n_in, out_off);
-       isl_seq_cpy(dst+1+dst_map->nparam+dst_map->n_in+out_off,
-                   src+1+src_map->nparam+src_map->n_in,
-                   isl_min(dst_map->n_out-out_off, src_map->n_out));
-       if (dst_map->n_out-out_off > src_map->n_out)
-               isl_seq_clr(dst+1+dst_map->nparam+dst_map->n_in+out_off+src_map->n_out,
-                               dst_map->n_out - out_off - src_map->n_out);
-       isl_seq_clr(dst+1+dst_map->nparam+dst_map->n_in+dst_map->n_out, div_off);
-       isl_seq_cpy(dst+1+dst_map->nparam+dst_map->n_in+dst_map->n_out+div_off,
-                   src+1+src_map->nparam+src_map->n_in+src_map->n_out,
+       isl_seq_cpy(dst+1, src+1, isl_min(dst_nparam, src_nparam));
+       if (dst_nparam > src_nparam)
+               isl_seq_clr(dst+1+src_nparam,
+                               dst_nparam - src_nparam);
+       isl_seq_clr(dst+1+dst_nparam, in_off);
+       isl_seq_cpy(dst+1+dst_nparam+in_off,
+                   src+1+src_nparam,
+                   isl_min(dst_in-in_off, src_in));
+       if (dst_in-in_off > src_in)
+               isl_seq_clr(dst+1+dst_nparam+in_off+src_in,
+                               dst_in - in_off - src_in);
+       isl_seq_clr(dst+1+dst_nparam+dst_in, out_off);
+       isl_seq_cpy(dst+1+dst_nparam+dst_in+out_off,
+                   src+1+src_nparam+src_in,
+                   isl_min(dst_out-out_off, src_out));
+       if (dst_out-out_off > src_out)
+               isl_seq_clr(dst+1+dst_nparam+dst_in+out_off+src_out,
+                               dst_out - out_off - src_out);
+       isl_seq_clr(dst+1+dst_nparam+dst_in+dst_out, div_off);
+       isl_seq_cpy(dst+1+dst_nparam+dst_in+dst_out+div_off,
+                   src+1+src_nparam+src_in+src_out,
                    isl_min(dst_map->extra-div_off, src_map->n_div));
        if (dst_map->n_div-div_off > src_map->n_div)
-               isl_seq_clr(dst+1+dst_map->nparam+dst_map->n_in+dst_map->n_out+
+               isl_seq_clr(dst+1+dst_nparam+dst_in+dst_out+
                                div_off+src_map->n_div,
                                dst_map->n_div - div_off - src_map->n_div);
 }
@@ -459,6 +675,66 @@ error:
        return NULL;
 }
 
+static void copy_constraint_dim_map(isl_int *dst, isl_int *src,
+                                       struct isl_dim_map *dim_map)
+{
+       int i;
+
+       for (i = 0; i < dim_map->len; ++i) {
+               if (dim_map->pos[i] < 0)
+                       isl_int_set_si(dst[i], 0);
+               else
+                       isl_int_set(dst[i], src[dim_map->pos[i]]);
+       }
+}
+
+static void copy_div_dim_map(isl_int *dst, isl_int *src,
+                                       struct isl_dim_map *dim_map)
+{
+       isl_int_set(dst[0], src[0]);
+       copy_constraint_dim_map(dst+1, src+1, dim_map);
+}
+
+static struct isl_basic_map *add_constraints_dim_map(struct isl_basic_map *dst,
+               struct isl_basic_map *src, struct isl_dim_map *dim_map)
+{
+       int i;
+
+       if (!src || !dst || !dim_map)
+               goto error;
+
+       for (i = 0; i < src->n_eq; ++i) {
+               int i1 = isl_basic_map_alloc_equality(dst);
+               if (i1 < 0)
+                       goto error;
+               copy_constraint_dim_map(dst->eq[i1], src->eq[i], dim_map);
+       }
+
+       for (i = 0; i < src->n_ineq; ++i) {
+               int i1 = isl_basic_map_alloc_inequality(dst);
+               if (i1 < 0)
+                       goto error;
+               copy_constraint_dim_map(dst->ineq[i1], src->ineq[i], dim_map);
+       }
+
+       for (i = 0; i < src->n_div; ++i) {
+               int i1 = isl_basic_map_alloc_div(dst);
+               if (i1 < 0)
+                       goto error;
+               copy_div_dim_map(dst->div[i1], src->div[i], dim_map);
+       }
+
+       free(dim_map);
+       isl_basic_map_free(src);
+
+       return dst;
+error:
+       free(dim_map);
+       isl_basic_map_free(src);
+       isl_basic_map_free(dst);
+       return NULL;
+}
+
 static struct isl_basic_set *set_add_constraints(struct isl_basic_set *bset1,
                struct isl_basic_set *bset2, unsigned pos)
 {
@@ -467,36 +743,38 @@ static struct isl_basic_set *set_add_constraints(struct isl_basic_set *bset1,
                                (struct isl_basic_map *)bset2, 0, pos);
 }
 
-struct isl_basic_map *isl_basic_map_extend(struct isl_basic_map *base,
-               unsigned nparam, unsigned n_in, unsigned n_out, unsigned extra,
+struct isl_basic_map *isl_basic_map_extend_dim(struct isl_basic_map *base,
+               struct isl_dim *dim, unsigned extra,
                unsigned n_eq, unsigned n_ineq)
 {
        struct isl_basic_map *ext;
        unsigned flags;
        int dims_ok;
 
+       if (!dim)
+               goto error;
+
        base = isl_basic_map_cow(base);
        if (!base)
                goto error;
 
-       dims_ok = base && base->nparam == nparam &&
-                 base->n_in == n_in && base->n_out == n_out &&
+       dims_ok = isl_dim_equal(base->dim, dim) &&
                  base->extra >= base->n_div + extra;
 
-       if (dims_ok && n_eq == 0 && n_ineq == 0)
+       if (dims_ok && n_eq == 0 && n_ineq == 0) {
+               isl_dim_free(dim);
                return base;
+       }
 
-       isl_assert(base->ctx, base->nparam <= nparam, goto error);
-       isl_assert(base->ctx, base->n_in <= n_in, goto error);
-       isl_assert(base->ctx, base->n_out <= n_out, goto error);
+       isl_assert(base->ctx, base->dim->nparam <= dim->nparam, goto error);
+       isl_assert(base->ctx, base->dim->n_in <= dim->n_in, goto error);
+       isl_assert(base->ctx, base->dim->n_out <= dim->n_out, goto error);
        extra += base->extra;
        n_eq += base->n_eq;
        n_ineq += base->n_ineq;
 
-       ext = isl_basic_map_alloc(base->ctx, nparam, n_in, n_out,
-                                       extra, n_eq, n_ineq);
-       if (!base)
-               return ext;
+       ext = isl_basic_map_alloc_dim(dim, extra, n_eq, n_ineq);
+       dim = NULL;
        if (!ext)
                goto error;
 
@@ -510,10 +788,37 @@ struct isl_basic_map *isl_basic_map_extend(struct isl_basic_map *base,
        return ext;
 
 error:
+       isl_dim_free(dim);
        isl_basic_map_free(base);
        return NULL;
 }
 
+struct isl_basic_map *isl_basic_map_extend_constraints(
+               struct isl_basic_map *base, unsigned n_eq, unsigned n_ineq)
+{
+       if (!base)
+               return NULL;
+       return isl_basic_map_extend_dim(base, isl_dim_copy(base->dim),
+                                       0, n_eq, n_ineq);
+}
+
+struct isl_basic_map *isl_basic_map_extend(struct isl_basic_map *base,
+               unsigned nparam, unsigned n_in, unsigned n_out, unsigned extra,
+               unsigned n_eq, unsigned n_ineq)
+{
+       struct isl_basic_map *bmap;
+       struct isl_dim *dim;
+
+       if (!base)
+               return NULL;
+       dim = isl_dim_alloc(base->ctx, nparam, n_in, n_out);
+       if (!dim)
+               return NULL;
+
+       bmap = isl_basic_map_extend_dim(base, dim, extra, n_eq, n_ineq);
+       return bmap;
+}
+
 struct isl_basic_set *isl_basic_set_extend(struct isl_basic_set *base,
                unsigned nparam, unsigned dim, unsigned extra,
                unsigned n_eq, unsigned n_ineq)
@@ -523,6 +828,14 @@ struct isl_basic_set *isl_basic_set_extend(struct isl_basic_set *base,
                                        nparam, 0, dim, extra, n_eq, n_ineq);
 }
 
+struct isl_basic_set *isl_basic_set_extend_constraints(
+               struct isl_basic_set *base, unsigned n_eq, unsigned n_ineq)
+{
+       return (struct isl_basic_set *)
+               isl_basic_map_extend_constraints((struct isl_basic_map *)base,
+                                                   n_eq, n_ineq);
+}
+
 struct isl_basic_set *isl_basic_set_cow(struct isl_basic_set *bset)
 {
        return (struct isl_basic_set *)
@@ -577,34 +890,38 @@ struct isl_basic_set *isl_basic_set_swap_vars(
 {
        int i;
        struct isl_blk blk;
+       unsigned dim;
+       unsigned nparam;
 
        if (!bset)
                goto error;
 
-       isl_assert(bset->ctx, n <= bset->dim, goto error);
+       nparam = isl_basic_set_n_param(bset);
+       dim = isl_basic_set_n_dim(bset);
+       isl_assert(bset->ctx, n <= dim, goto error);
 
-       if (n == bset->dim)
+       if (n == dim)
                return bset;
 
        bset = isl_basic_set_cow(bset);
        if (!bset)
                return NULL;
 
-       blk = isl_blk_alloc(bset->ctx, bset->dim);
+       blk = isl_blk_alloc(bset->ctx, dim);
        if (isl_blk_is_error(blk))
                goto error;
 
        for (i = 0; i < bset->n_eq; ++i)
                swap_vars(blk,
-                         bset->eq[i]+1+bset->nparam, n, bset->dim - n);
+                         bset->eq[i]+1+nparam, n, dim - n);
 
        for (i = 0; i < bset->n_ineq; ++i)
                swap_vars(blk,
-                         bset->ineq[i]+1+bset->nparam, n, bset->dim - n);
+                         bset->ineq[i]+1+nparam, n, dim - n);
 
        for (i = 0; i < bset->n_div; ++i)
                swap_vars(blk,
-                         bset->div[i]+1+1+bset->nparam, n, bset->dim - n);
+                         bset->div[i]+1+1+nparam, n, dim - n);
 
        isl_blk_free(bset->ctx, blk);
 
@@ -640,6 +957,13 @@ static void constraint_drop_vars(isl_int *c, unsigned n, unsigned rem)
        isl_seq_clr(c + rem, n);
 }
 
+/* Drop n dimensions starting at first.
+ *
+ * In principle, this frees up some extra variables as the number
+ * of columns remains constant, but we would have to extend
+ * the div array too as the number of rows in this array is assumed
+ * to be equal to extra.
+ */
 struct isl_basic_set *isl_basic_set_drop_dims(
                struct isl_basic_set *bset, unsigned first, unsigned n)
 {
@@ -648,7 +972,7 @@ struct isl_basic_set *isl_basic_set_drop_dims(
        if (!bset)
                goto error;
 
-       isl_assert(bset->ctx, first + n <= bset->dim, goto error);
+       isl_assert(bset->ctx, first + n <= bset->dim->n_out, goto error);
 
        if (n == 0)
                return bset;
@@ -658,19 +982,20 @@ struct isl_basic_set *isl_basic_set_drop_dims(
                return NULL;
 
        for (i = 0; i < bset->n_eq; ++i)
-               constraint_drop_vars(bset->eq[i]+1+bset->nparam+first, n,
-                                    (bset->dim-first-n)+bset->extra);
+               constraint_drop_vars(bset->eq[i]+1+bset->dim->nparam+first, n,
+                                    (bset->dim->n_out-first-n)+bset->extra);
 
        for (i = 0; i < bset->n_ineq; ++i)
-               constraint_drop_vars(bset->ineq[i]+1+bset->nparam+first, n,
-                                    (bset->dim-first-n)+bset->extra);
+               constraint_drop_vars(bset->ineq[i]+1+bset->dim->nparam+first, n,
+                                    (bset->dim->n_out-first-n)+bset->extra);
 
        for (i = 0; i < bset->n_div; ++i)
-               constraint_drop_vars(bset->div[i]+1+1+bset->nparam+first, n,
-                                    (bset->dim-first-n)+bset->extra);
+               constraint_drop_vars(bset->div[i]+1+1+bset->dim->nparam+first, n,
+                                    (bset->dim->n_out-first-n)+bset->extra);
 
-       bset->dim -= n;
-       bset->extra += n;
+       bset->dim = isl_dim_drop_outputs(bset->dim, first, n);
+       if (!bset->dim)
+               goto error;
 
        F_CLR(bset, ISL_BASIC_SET_NORMALIZED);
        bset = isl_basic_set_simplify(bset);
@@ -688,20 +1013,22 @@ static struct isl_set *isl_set_drop_dims(
        if (!set)
                goto error;
 
-       isl_assert(set->ctx, first + n <= set->dim, goto error);
+       isl_assert(set->ctx, first + n <= set->dim->n_out, goto error);
 
        if (n == 0)
                return set;
        set = isl_set_cow(set);
        if (!set)
                goto error;
+       set->dim = isl_dim_drop_outputs(set->dim, first, n);
+       if (!set->dim)
+               goto error;
 
        for (i = 0; i < set->n; ++i) {
                set->p[i] = isl_basic_set_drop_dims(set->p[i], first, n);
                if (!set->p[i])
                        goto error;
        }
-       set->dim -= n;
 
        F_CLR(set, ISL_SET_NORMALIZED);
        return set;
@@ -710,15 +1037,28 @@ error:
        return NULL;
 }
 
+/* Drop n input dimensions starting at first.
+ *
+ * In principle, this frees up some extra variables as the number
+ * of columns remains constant, but we would have to extend
+ * the div array too as the number of rows in this array is assumed
+ * to be equal to extra.
+ */
 struct isl_basic_map *isl_basic_map_drop_inputs(
                struct isl_basic_map *bmap, unsigned first, unsigned n)
 {
        int i;
+       unsigned nparam;
+       unsigned n_in;
+       unsigned n_out;
 
        if (!bmap)
                goto error;
 
-       isl_assert(bmap->ctx, first + n <= bmap->n_in, goto error);
+       nparam = isl_basic_map_n_param(bmap);
+       n_in = isl_basic_map_n_in(bmap);
+       n_out = isl_basic_map_n_out(bmap);
+       isl_assert(bmap->ctx, first + n <= n_in, goto error);
 
        if (n == 0)
                return bmap;
@@ -728,19 +1068,20 @@ struct isl_basic_map *isl_basic_map_drop_inputs(
                return NULL;
 
        for (i = 0; i < bmap->n_eq; ++i)
-               constraint_drop_vars(bmap->eq[i]+1+bmap->nparam+first, n,
-                                (bmap->n_in-first-n)+bmap->n_out+bmap->extra);
+               constraint_drop_vars(bmap->eq[i]+1+nparam+first, n,
+                                (n_in-first-n)+n_out+bmap->extra);
 
        for (i = 0; i < bmap->n_ineq; ++i)
-               constraint_drop_vars(bmap->ineq[i]+1+bmap->nparam+first, n,
-                                (bmap->n_in-first-n)+bmap->n_out+bmap->extra);
+               constraint_drop_vars(bmap->ineq[i]+1+nparam+first, n,
+                                (n_in-first-n)+n_out+bmap->extra);
 
        for (i = 0; i < bmap->n_div; ++i)
-               constraint_drop_vars(bmap->div[i]+1+1+bmap->nparam+first, n,
-                                (bmap->n_in-first-n)+bmap->n_out+bmap->extra);
+               constraint_drop_vars(bmap->div[i]+1+1+nparam+first, n,
+                                (n_in-first-n)+n_out+bmap->extra);
 
-       bmap->n_in -= n;
-       bmap->extra += n;
+       bmap->dim = isl_dim_drop_inputs(bmap->dim, first, n);
+       if (!bmap->dim)
+               goto error;
 
        F_CLR(bmap, ISL_BASIC_MAP_NORMALIZED);
        bmap = isl_basic_map_simplify(bmap);
@@ -758,20 +1099,22 @@ static struct isl_map *isl_map_drop_inputs(
        if (!map)
                goto error;
 
-       isl_assert(map->ctx, first + n <= map->n_in, goto error);
+       isl_assert(map->ctx, first + n <= map->dim->n_in, goto error);
 
        if (n == 0)
                return map;
        map = isl_map_cow(map);
        if (!map)
                goto error;
+       map->dim = isl_dim_drop_inputs(map->dim, first, n);
+       if (!map->dim)
+               goto error;
 
        for (i = 0; i < map->n; ++i) {
                map->p[i] = isl_basic_map_drop_inputs(map->p[i], first, n);
                if (!map->p[i])
                        goto error;
        }
-       map->n_in -= n;
        F_CLR(map, ISL_MAP_NORMALIZED);
 
        return map;
@@ -792,7 +1135,7 @@ static struct isl_basic_map *isl_basic_map_drop_div(
        if (!bmap)
                goto error;
 
-       pos = 1 + bmap->nparam + bmap->n_in + bmap->n_out + div;
+       pos = 1 + isl_dim_total(bmap->dim) + div;
 
        isl_assert(bmap->ctx, div < bmap->n_div, goto error);
 
@@ -832,9 +1175,9 @@ error:
 static void eliminate_div(struct isl_basic_map *bmap, isl_int *eq, unsigned div)
 {
        int i;
-       unsigned pos = 1 + bmap->nparam + bmap->n_in + bmap->n_out + div;
+       unsigned pos = 1 + isl_dim_total(bmap->dim) + div;
        unsigned len;
-       len = 1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       len = 1 + isl_basic_map_total_dim(bmap);
 
        for (i = 0; i < bmap->n_eq; ++i)
                if (bmap->eq[i] != eq)
@@ -861,7 +1204,7 @@ struct isl_basic_map *isl_basic_map_set_to_empty(struct isl_basic_map *bmap)
        unsigned total;
        if (!bmap)
                goto error;
-       total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       total = isl_basic_map_total_dim(bmap);
        isl_basic_map_free_div(bmap, bmap->n_div);
        isl_basic_map_free_inequality(bmap, bmap->n_ineq);
        if (bmap->n_eq > 0)
@@ -910,7 +1253,7 @@ static void set_swap_inequality(struct isl_basic_set *bset, int a, int b)
 static void swap_div(struct isl_basic_map *bmap, int a, int b)
 {
        int i;
-       unsigned off = bmap->nparam + bmap->n_in + bmap->n_out;
+       unsigned off = isl_dim_total(bmap->dim);
        isl_int *t = bmap->div[a];
        bmap->div[a] = bmap->div[b];
        bmap->div[b] = t;
@@ -932,7 +1275,7 @@ static void eliminate_var_using_equality(struct isl_basic_map *bmap,
        unsigned total;
        int k;
 
-       total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       total = isl_basic_map_total_dim(bmap);
        for (k = 0; k < bmap->n_eq; ++k) {
                if (bmap->eq[k] == eq)
                        continue;
@@ -978,8 +1321,8 @@ struct isl_basic_map *isl_basic_map_gauss(
        if (!bmap)
                return NULL;
 
-       total_var = bmap->nparam + bmap->n_in + bmap->n_out;
-       total = total_var + bmap->n_div;
+       total = isl_basic_map_total_dim(bmap);
+       total_var = total - bmap->n_div;
 
        last_var = total - 1;
        for (done = 0; done < bmap->n_eq; ++done) {
@@ -1043,7 +1386,7 @@ static int hash_index(isl_int ***index, unsigned int size, int bits,
                        struct isl_basic_map *bmap, int k)
 {
        int h;
-       unsigned total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned total = isl_basic_map_total_dim(bmap);
        uint32_t hash = isl_seq_get_hash_bits(bmap->ineq[k]+1, total, bits);
        for (h = hash; index[h]; h = (h+1) % size)
                if (&bmap->ineq[k] != index[h] &&
@@ -1065,7 +1408,7 @@ static struct isl_basic_map *remove_duplicate_constraints(
        isl_int ***index;
        int k, l, h;
        int bits;
-       unsigned total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned total = isl_basic_map_total_dim(bmap);
        isl_int sum;
 
        if (bmap->n_ineq <= 1)
@@ -1126,7 +1469,7 @@ static void compute_elimination_index(struct isl_basic_map *bmap, int *elim)
        int d, i;
        unsigned total;
 
-       total = bmap->nparam + bmap->n_in + bmap->n_out;
+       total = isl_dim_total(bmap->dim);
        for (d = 0; d < total; ++d)
                elim[d] = -1;
        for (d = total - 1, i = 0; d >= 0 && i < bmap->n_eq; ++i) {
@@ -1151,7 +1494,7 @@ static int reduced_using_equalities(isl_int *dst, isl_int *src,
        int copied = 0;
        unsigned total;
 
-       total = bmap->nparam + bmap->n_in + bmap->n_out;
+       total = isl_dim_total(bmap->dim);
        for (d = total - 1; d >= 0; --d) {
                if (isl_int_is_zero(src[1+d]))
                        continue;
@@ -1188,15 +1531,14 @@ int isl_basic_map_fast_is_disjoint(struct isl_basic_map *bmap1,
 
        if (!bmap1 || !bmap2)
                return -1;
-       isl_assert(bmap1->ctx, bmap1->nparam == bmap2->nparam, return -1);
-       isl_assert(bmap1->ctx, bmap1->n_in == bmap2->n_in, return -1);
-       isl_assert(bmap1->ctx, bmap1->n_out == bmap2->n_out, return -1);
+       isl_assert(bmap1->ctx, isl_dim_equal(bmap1->dim, bmap2->dim),
+                       return -1);
        if (bmap1->n_div || bmap2->n_div)
                return 0;
        if (!bmap1->n_eq && !bmap2->n_eq)
                return 0;
 
-       total = bmap1->nparam + bmap1->n_in + bmap1->n_out;
+       total = isl_dim_total(bmap1->dim);
        if (total == 0)
                return 0;
        v = isl_vec_alloc(bmap1->ctx, 1 + total);
@@ -1286,7 +1628,7 @@ static struct isl_basic_map *remove_duplicate_divs(
        int k, l, h;
        int bits;
        struct isl_blk eq;
-       unsigned total_var = bmap->nparam + bmap->n_in + bmap->n_out;
+       unsigned total_var = isl_dim_total(bmap->dim);
        unsigned total = total_var + bmap->n_div;
        struct isl_ctx *ctx;
 
@@ -1353,7 +1695,7 @@ static struct isl_basic_map *eliminate_divs_eq(
        if (!bmap)
                return NULL;
 
-       off = 1 + bmap->nparam + bmap->n_in + bmap->n_out;
+       off = 1 + isl_dim_total(bmap->dim);
 
        for (d = bmap->n_div - 1; d >= 0 ; --d) {
                for (i = 0; i < bmap->n_eq; ++i) {
@@ -1376,7 +1718,7 @@ static struct isl_basic_map *normalize_constraints(struct isl_basic_map *bmap)
 {
        int i;
        isl_int gcd;
-       unsigned total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned total = isl_basic_map_total_dim(bmap);
 
        isl_int_init(gcd);
        for (i = bmap->n_eq - 1; i >= 0; --i) {
@@ -1423,11 +1765,32 @@ static struct isl_basic_map *normalize_constraints(struct isl_basic_map *bmap)
 }
 
 
+/* Remove any div that is defined in terms of the given variable.
+ */
+static struct isl_basic_map *remove_dependent_vars(struct isl_basic_map *bmap,
+                                                                       int pos)
+{
+       int i;
+       unsigned dim = isl_dim_total(bmap->dim);
+
+       for (i = 0; i < bmap->n_div; ++i) {
+               if (isl_int_is_zero(bmap->div[i][0]))
+                       continue;
+               if (isl_int_is_zero(bmap->div[i][1+1+pos]))
+                       continue;
+               bmap = isl_basic_map_eliminate_vars(bmap, dim + i, 1);
+               if (!bmap)
+                       return NULL;
+       }
+       return bmap;
+}
+
+
 /* Eliminate the specified variables from the constraints using
  * Fourier-Motzkin.  The variables themselves are not removed.
  */
 struct isl_basic_map *isl_basic_map_eliminate_vars(
-       struct isl_basic_map *bmap, int pos, unsigned n)
+       struct isl_basic_map *bmap, unsigned pos, unsigned n)
 {
        int d;
        int i, j, k;
@@ -1437,13 +1800,16 @@ struct isl_basic_map *isl_basic_map_eliminate_vars(
                return bmap;
        if (!bmap)
                return NULL;
-       total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       total = isl_basic_map_total_dim(bmap);
 
        bmap = isl_basic_map_cow(bmap);
-       for (d = pos + n - 1; d >= pos; --d) {
+       for (d = pos + n - 1; d >= 0 && d >= pos; --d) {
                int n_lower, n_upper;
+               bmap = remove_dependent_vars(bmap, d);
                if (!bmap)
                        return NULL;
+               if (d >= total - bmap->n_div)
+                       isl_seq_clr(bmap->div[d-(total-bmap->n_div)], 2+total);
                for (i = 0; i < bmap->n_eq; ++i) {
                        if (isl_int_is_zero(bmap->eq[i][1+d]))
                                continue;
@@ -1461,8 +1827,7 @@ struct isl_basic_map *isl_basic_map_eliminate_vars(
                        else if (isl_int_is_neg(bmap->ineq[i][1+d]))
                                n_upper++;
                }
-               bmap = isl_basic_map_extend(bmap,
-                               bmap->nparam, bmap->n_in, bmap->n_out, 0,
+               bmap = isl_basic_map_extend_constraints(bmap,
                                0, n_lower * n_upper);
                for (i = bmap->n_ineq - 1; i >= 0; --i) {
                        int last;
@@ -1520,6 +1885,7 @@ struct isl_set *isl_set_eliminate_dims(struct isl_set *set,
        unsigned first, unsigned n)
 {
        int i;
+       unsigned nparam;
 
        if (!set)
                return NULL;
@@ -1529,11 +1895,12 @@ struct isl_set *isl_set_eliminate_dims(struct isl_set *set,
        set = isl_set_cow(set);
        if (!set)
                return NULL;
-       isl_assert(set->ctx, first+n <= set->dim, goto error);
+       isl_assert(set->ctx, first+n <= isl_set_n_dim(set), goto error);
+       nparam = isl_set_n_param(set);
        
        for (i = 0; i < set->n; ++i) {
                set->p[i] = isl_basic_set_eliminate_vars(set->p[i],
-                                                       set->nparam + first, n);
+                                                           nparam + first, n);
                if (!set->p[i])
                        goto error;
        }
@@ -1554,7 +1921,7 @@ struct isl_set *isl_set_remove_dims(struct isl_set *set,
 
 struct isl_basic_set *isl_basic_set_remove_divs(struct isl_basic_set *bset)
 {
-       bset = isl_basic_set_eliminate_vars(bset, bset->nparam + bset->dim,
+       bset = isl_basic_set_eliminate_vars(bset, isl_dim_total(bset->dim),
                                                bset->n_div);
        if (!bset)
                return NULL;
@@ -1591,6 +1958,7 @@ struct isl_map *isl_map_remove_inputs(struct isl_map *map,
        unsigned first, unsigned n)
 {
        int i;
+       unsigned nparam;
 
        if (n == 0)
                return map;
@@ -1598,11 +1966,12 @@ struct isl_map *isl_map_remove_inputs(struct isl_map *map,
        map = isl_map_cow(map);
        if (!map)
                return NULL;
-       isl_assert(map->ctx, first+n <= map->n_in, goto error);
+       nparam = isl_map_n_param(map);
+       isl_assert(map->ctx, first+n <= isl_map_n_in(map), goto error);
        
        for (i = 0; i < map->n; ++i) {
                map->p[i] = isl_basic_map_eliminate_vars(map->p[i],
-                                                       map->nparam + first, n);
+                                                           nparam + first, n);
                if (!map->p[i])
                        goto error;
        }
@@ -1617,7 +1986,8 @@ error:
 struct isl_basic_set *isl_basic_set_remove_dims(struct isl_basic_set *bset,
        unsigned first, unsigned n)
 {
-       bset = isl_basic_set_eliminate_vars(bset, bset->nparam + first, n);
+       unsigned nparam = isl_basic_set_n_param(bset);
+       bset = isl_basic_set_eliminate_vars(bset, nparam + first, n);
        bset = isl_basic_set_drop_dims(bset, first, n);
        return bset;
 }
@@ -1636,7 +2006,7 @@ static struct isl_basic_map *eliminate_divs_ineq(
                return NULL;
 
        ctx = bmap->ctx;
-       off = 1 + bmap->nparam + bmap->n_in + bmap->n_out;
+       off = 1 + isl_dim_total(bmap->dim);
 
        for (d = bmap->n_div - 1; d >= 0 ; --d) {
                for (i = 0; i < bmap->n_eq; ++i)
@@ -1686,21 +2056,28 @@ struct isl_basic_set *isl_basic_set_simplify(struct isl_basic_set *bset)
 static void dump_term(struct isl_basic_map *bmap,
                        isl_int c, int pos, FILE *out)
 {
-       unsigned in = bmap->n_in;
-       unsigned dim = bmap->n_in + bmap->n_out;
+       const char *name;
+       unsigned in = isl_basic_map_n_in(bmap);
+       unsigned dim = in + isl_basic_map_n_out(bmap);
+       unsigned nparam = isl_basic_map_n_param(bmap);
        if (!pos)
                isl_int_print(out, c, 0);
        else {
                if (!isl_int_is_one(c))
                        isl_int_print(out, c, 0);
-               if (pos < 1 + bmap->nparam)
-                       fprintf(out, "p%d", pos - 1);
-               else if (pos < 1 + bmap->nparam + in)
-                       fprintf(out, "i%d", pos - 1 - bmap->nparam);
-               else if (pos < 1 + bmap->nparam + dim)
-                       fprintf(out, "o%d", pos - 1 - bmap->nparam - in);
+               if (pos < 1 + nparam) {
+                       name = isl_dim_get_name(bmap->dim,
+                                               isl_dim_param, pos - 1);
+                       if (name)
+                               fprintf(out, "%s", name);
+                       else
+                               fprintf(out, "p%d", pos - 1);
+               } else if (pos < 1 + nparam + in)
+                       fprintf(out, "i%d", pos - 1 - nparam);
+               else if (pos < 1 + nparam + dim)
+                       fprintf(out, "o%d", pos - 1 - nparam - in);
                else
-                       fprintf(out, "e%d", pos - 1 - bmap->nparam - dim);
+                       fprintf(out, "e%d", pos - 1 - nparam - dim);
        }
 }
 
@@ -1709,7 +2086,7 @@ static void dump_constraint_sign(struct isl_basic_map *bmap, isl_int *c,
 {
        int i;
        int first;
-       unsigned len = 1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned len = 1 + isl_basic_map_total_dim(bmap);
        isl_int v;
 
        isl_int_init(v);
@@ -1741,10 +2118,11 @@ static void dump_constraint(struct isl_basic_map *bmap, isl_int *c,
        fprintf(out, "\n");
 
        for (i = bmap->n_div; i < bmap->extra; ++i) {
-               if (isl_int_is_zero(c[1+bmap->nparam+bmap->n_in+bmap->n_out+i]))
+               if (isl_int_is_zero(c[1+isl_dim_total(bmap->dim)+i]))
                        continue;
                fprintf(out, "%*s", indent, "");
                fprintf(out, "ERROR: unused div coefficient not zero\n");
+               abort();
        }
 }
 
@@ -1762,7 +2140,7 @@ static void dump_affine(struct isl_basic_map *bmap, isl_int *exp, FILE *out)
 {
        int j;
        int first = 1;
-       unsigned total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned total = isl_basic_map_total_dim(bmap);
 
        for (j = 0; j < 1 + total; ++j) {
                if (isl_int_is_zero(exp[j]))
@@ -1800,8 +2178,8 @@ void isl_basic_set_dump(struct isl_basic_set *bset, FILE *out, int indent)
 
        fprintf(out, "%*s", indent, "");
        fprintf(out, "ref: %d, nparam: %d, dim: %d, extra: %d, flags: %x\n",
-                       bset->ref, bset->nparam, bset->dim, bset->extra,
-                       bset->flags);
+                       bset->ref, bset->dim->nparam, bset->dim->n_out,
+                       bset->extra, bset->flags);
        dump((struct isl_basic_map *)bset, out, indent);
 }
 
@@ -1813,17 +2191,20 @@ void isl_basic_map_dump(struct isl_basic_map *bmap, FILE *out, int indent)
        }
 
        fprintf(out, "%*s", indent, "");
-       fprintf(out, "ref: %d, nparam: %d, in: %d, out: %d, extra: %d, flags: %x\n",
+       fprintf(out, "ref: %d, nparam: %d, in: %d, out: %d, extra: %d, "
+                       "flags: %x, n_name: %d\n",
                bmap->ref,
-               bmap->nparam, bmap->n_in, bmap->n_out, bmap->extra, bmap->flags);
+               bmap->dim->nparam, bmap->dim->n_in, bmap->dim->n_out,
+               bmap->extra, bmap->flags, bmap->dim->n_name);
        dump(bmap, out, indent);
 }
 
 int isl_inequality_negate(struct isl_basic_map *bmap, unsigned pos)
 {
-       unsigned total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned total;
        if (!bmap)
                return -1;
+       total = isl_basic_map_total_dim(bmap);
        isl_assert(bmap->ctx, pos < bmap->n_ineq, return -1);
        isl_seq_neg(bmap->ineq[pos], bmap->ineq[pos], 1 + total);
        isl_int_sub_ui(bmap->ineq[pos][0], bmap->ineq[pos][0], 1);
@@ -1831,28 +2212,45 @@ int isl_inequality_negate(struct isl_basic_map *bmap, unsigned pos)
        return 0;
 }
 
-struct isl_set *isl_set_alloc(struct isl_ctx *ctx,
-               unsigned nparam, unsigned dim, int n, unsigned flags)
+struct isl_set *isl_set_alloc_dim(struct isl_dim *dim, int n, unsigned flags)
 {
        struct isl_set *set;
 
-       isl_assert(ctx, n >= 0, return NULL);
-       set = isl_alloc(ctx, struct isl_set,
+       if (!dim)
+               return NULL;
+       isl_assert(dim->ctx, dim->n_in == 0, return NULL);
+       isl_assert(dim->ctx, n >= 0, return NULL);
+       set = isl_alloc(dim->ctx, struct isl_set,
                        sizeof(struct isl_set) +
                        n * sizeof(struct isl_basic_set *));
        if (!set)
-               return NULL;
+               goto error;
 
-       set->ctx = ctx;
-       isl_ctx_ref(ctx);
+       set->ctx = dim->ctx;
+       isl_ctx_ref(set->ctx);
        set->ref = 1;
        set->size = n;
        set->n = 0;
-       set->nparam = nparam;
-       set->zero = 0;
        set->dim = dim;
        set->flags = flags;
        return set;
+error:
+       isl_dim_free(dim);
+       return NULL;
+}
+
+struct isl_set *isl_set_alloc(struct isl_ctx *ctx,
+               unsigned nparam, unsigned dim, int n, unsigned flags)
+{
+       struct isl_set *set;
+       struct isl_dim *dims;
+
+       dims = isl_dim_alloc(ctx, nparam, 0, dim);
+       if (!dims)
+               return NULL;
+
+       set = isl_set_alloc_dim(dims, n, flags);
+       return set;
 }
 
 struct isl_set *isl_set_dup(struct isl_set *set)
@@ -1863,7 +2261,7 @@ struct isl_set *isl_set_dup(struct isl_set *set)
        if (!set)
                return NULL;
 
-       dup = isl_set_alloc(set->ctx, set->nparam, set->dim, set->n, set->flags);
+       dup = isl_set_alloc_dim(isl_dim_copy(set->dim), set->n, set->flags);
        if (!dup)
                return NULL;
        for (i = 0; i < set->n; ++i)
@@ -1878,7 +2276,7 @@ struct isl_set *isl_set_from_basic_set(struct isl_basic_set *bset)
        if (!bset)
                return NULL;
 
-       set = isl_set_alloc(bset->ctx, bset->nparam, bset->dim, 1, ISL_MAP_DISJOINT);
+       set = isl_set_alloc_dim(isl_dim_copy(bset->dim), 1, ISL_MAP_DISJOINT);
        if (!set) {
                isl_basic_set_free(bset);
                return NULL;
@@ -1893,8 +2291,7 @@ struct isl_map *isl_map_from_basic_map(struct isl_basic_map *bmap)
        if (!bmap)
                return NULL;
 
-       map = isl_map_alloc(bmap->ctx, bmap->nparam, bmap->n_in, bmap->n_out, 1,
-                               ISL_MAP_DISJOINT);
+       map = isl_map_alloc_dim(isl_dim_copy(bmap->dim), 1, ISL_MAP_DISJOINT);
        if (!map) {
                isl_basic_map_free(bmap);
                return NULL;
@@ -1906,8 +2303,7 @@ struct isl_set *isl_set_add(struct isl_set *set, struct isl_basic_set *bset)
 {
        if (!bset || !set)
                goto error;
-       isl_assert(set->ctx, set->nparam == bset->nparam, goto error);
-       isl_assert(set->ctx, set->dim == bset->dim, goto error);
+       isl_assert(set->ctx, isl_dim_equal(set->dim, bset->dim), goto error);
        isl_assert(set->ctx, set->n < set->size, goto error);
        set->p[set->n] = bset;
        set->n++;
@@ -1933,6 +2329,7 @@ void isl_set_free(struct isl_set *set)
        isl_ctx_deref(set->ctx);
        for (i = 0; i < set->n; ++i)
                isl_basic_set_free(set->p[i]);
+       isl_dim_free(set->dim);
        free(set);
 }
 
@@ -1947,7 +2344,8 @@ void isl_set_dump(struct isl_set *set, FILE *out, int indent)
 
        fprintf(out, "%*s", indent, "");
        fprintf(out, "ref: %d, n: %d, nparam: %d, dim: %d, flags: %x\n",
-                       set->ref, set->n, set->nparam, set->dim, set->flags);
+                       set->ref, set->n, set->dim->nparam, set->dim->n_out,
+                       set->flags);
        for (i = 0; i < set->n; ++i) {
                fprintf(out, "%*s", indent, "");
                fprintf(out, "basic set %d:\n", i);
@@ -1965,9 +2363,10 @@ void isl_map_dump(struct isl_map *map, FILE *out, int indent)
        }
 
        fprintf(out, "%*s", indent, "");
-       fprintf(out, "ref: %d, n: %d, nparam: %d, in: %d, out: %d, flags: %x\n",
-                       map->ref, map->n, map->nparam, map->n_in, map->n_out,
-                       map->flags);
+       fprintf(out, "ref: %d, n: %d, nparam: %d, in: %d, out: %d, "
+                    "flags: %x, n_name: %d\n",
+                       map->ref, map->n, map->dim->nparam, map->dim->n_in,
+                       map->dim->n_out, map->flags, map->dim->n_name);
        for (i = 0; i < map->n; ++i) {
                fprintf(out, "%*s", indent, "");
                fprintf(out, "basic map %d:\n", i);
@@ -1979,20 +2378,20 @@ struct isl_basic_map *isl_basic_map_intersect_domain(
                struct isl_basic_map *bmap, struct isl_basic_set *bset)
 {
        struct isl_basic_map *bmap_domain;
+       struct isl_dim *dim;
 
        if (!bmap || !bset)
                goto error;
 
-       isl_assert(bset->ctx, bset->dim == bmap->n_in, goto error);
-       isl_assert(bset->ctx, bset->nparam == bmap->nparam, goto error);
+       isl_assert(set->ctx, isl_basic_map_compatible_domain(bmap, bset),
+                   goto error);
 
-       bmap = isl_basic_map_extend(bmap,
-                       bset->nparam, bmap->n_in, bmap->n_out,
+       bmap = isl_basic_map_extend_dim(bmap, isl_dim_copy(bmap->dim),
                        bset->n_div, bset->n_eq, bset->n_ineq);
        if (!bmap)
                goto error;
-       bmap_domain = isl_basic_map_from_basic_set(bset,
-                                               bset->dim, 0);
+       dim = isl_dim_reverse(isl_dim_copy(bset->dim));
+       bmap_domain = isl_basic_map_from_basic_set(bset, dim);
        bmap = add_constraints(bmap, bmap_domain, 0, 0);
 
        bmap = isl_basic_map_simplify(bmap);
@@ -2011,16 +2410,14 @@ struct isl_basic_map *isl_basic_map_intersect_range(
        if (!bmap || !bset)
                goto error;
 
-       isl_assert(bset->ctx, bset->dim == bmap->n_out, goto error);
-       isl_assert(bset->ctx, bset->nparam == bmap->nparam, goto error);
+       isl_assert(bset->ctx, isl_basic_map_compatible_range(bmap, bset),
+                  goto error);
 
-       bmap = isl_basic_map_extend(bmap,
-                       bset->nparam, bmap->n_in, bmap->n_out,
+       bmap = isl_basic_map_extend_dim(bmap, isl_dim_copy(bmap->dim),
                        bset->n_div, bset->n_eq, bset->n_ineq);
        if (!bmap)
                goto error;
-       bmap_range = isl_basic_map_from_basic_set(bset,
-                                               0, bset->dim);
+       bmap_range = isl_basic_map_from_basic_set(bset, isl_dim_copy(bset->dim));
        bmap = add_constraints(bmap, bmap_range, 0, 0);
 
        bmap = isl_basic_map_simplify(bmap);
@@ -2037,12 +2434,9 @@ struct isl_basic_map *isl_basic_map_intersect(
        if (!bmap1 || !bmap2)
                goto error;
 
-       isl_assert(bmap1->ctx, bmap1->nparam == bmap2->nparam, goto error);
-       isl_assert(bmap1->ctx, bmap1->n_in == bmap2->n_in, goto error);
-       isl_assert(bmap1->ctx, bmap1->n_out == bmap2->n_out, goto error);
+       isl_assert(map1->ctx, isl_dim_equal(bmap1->dim, bmap2->dim), goto error);
 
-       bmap1 = isl_basic_map_extend(bmap1,
-                       bmap1->nparam, bmap1->n_in, bmap1->n_out,
+       bmap1 = isl_basic_map_extend_dim(bmap1, isl_dim_copy(bmap1->dim),
                        bmap2->n_div, bmap2->n_eq, bmap2->n_ineq);
        if (!bmap1)
                goto error;
@@ -2078,7 +2472,7 @@ struct isl_map *isl_map_intersect(struct isl_map *map1, struct isl_map *map2)
            F_ISSET(map2, ISL_MAP_DISJOINT))
                FL_SET(flags, ISL_MAP_DISJOINT);
 
-       result = isl_map_alloc(map1->ctx, map1->nparam, map1->n_in, map1->n_out,
+       result = isl_map_alloc_dim(isl_dim_copy(map1->dim),
                                map1->n * map2->n, flags);
        if (!result)
                goto error;
@@ -2113,6 +2507,7 @@ struct isl_set *isl_set_intersect(struct isl_set *set1, struct isl_set *set2)
 
 struct isl_basic_map *isl_basic_map_reverse(struct isl_basic_map *bmap)
 {
+       struct isl_dim *dim;
        struct isl_basic_set *bset;
        unsigned in;
 
@@ -2121,10 +2516,11 @@ struct isl_basic_map *isl_basic_map_reverse(struct isl_basic_map *bmap)
        bmap = isl_basic_map_cow(bmap);
        if (!bmap)
                return NULL;
-       in = bmap->n_in;
+       dim = isl_dim_reverse(isl_dim_copy(bmap->dim));
+       in = isl_basic_map_n_in(bmap);
        bset = isl_basic_set_from_basic_map(bmap);
        bset = isl_basic_set_swap_vars(bset, in);
-       return isl_basic_map_from_basic_set(bset, bset->dim-in, in);
+       return isl_basic_map_from_basic_set(bset, dim);
 }
 
 /* Turn final n dimensions into existentially quantified variables.
@@ -2140,14 +2536,14 @@ struct isl_basic_set *isl_basic_set_project_out(
        if (!bset)
                return NULL;
 
-       isl_assert(bset->ctx, n <= bset->dim, goto error);
+       isl_assert(bset->ctx, n <= isl_basic_set_n_dim(bset), goto error);
 
        if (n == 0)
                return bset;
 
        bset = isl_basic_set_cow(bset);
 
-       row_size = 1 + bset->nparam + bset->dim + bset->extra;
+       row_size = 1 + isl_dim_total(bset->dim) + bset->extra;
        old = bset->block2.data;
        bset->block2 = isl_blk_extend(bset->ctx, bset->block2,
                                        (bset->extra + n) * (1 + row_size));
@@ -2167,7 +2563,10 @@ struct isl_basic_set *isl_basic_set_project_out(
        bset->div = new_div;
        bset->n_div += n;
        bset->extra += n;
-       bset->dim -= n;
+       bset->dim = isl_dim_drop_outputs(bset->dim,
+                                           isl_basic_set_n_dim(bset) - n, n);
+       if (!bset->dim)
+               goto error;
        bset = isl_basic_set_simplify(bset);
        return isl_basic_set_finalize(bset);
 error:
@@ -2175,35 +2574,62 @@ error:
        return NULL;
 }
 
+struct isl_basic_map *add_divs(struct isl_basic_map *bmap, unsigned n)
+{
+       int i, j;
+
+       for (i = 0; i < n; ++i) {
+               j = isl_basic_map_alloc_div(bmap);
+               if (j < 0)
+                       goto error;
+               isl_seq_clr(bmap->div[j], 1+1+isl_basic_map_total_dim(bmap));
+       }
+       return bmap;
+error:
+       isl_basic_map_free(bmap);
+       return NULL;
+}
+
 struct isl_basic_map *isl_basic_map_apply_range(
                struct isl_basic_map *bmap1, struct isl_basic_map *bmap2)
 {
-       struct isl_basic_set *bset;
-       unsigned n_in, n_out;
+       struct isl_dim *dim_result = NULL;
+       struct isl_basic_map *bmap;
+       unsigned n_in, n_out, n, nparam, total, pos;
+       struct isl_dim_map *dim_map1, *dim_map2;
 
        if (!bmap1 || !bmap2)
                goto error;
 
-       isl_assert(bmap->ctx, bmap1->n_out == bmap2->n_in, goto error);
-       isl_assert(bmap->ctx, bmap1->nparam == bmap2->nparam, goto error);
-
-       n_in = bmap1->n_in;
-       n_out = bmap2->n_out;
-
-       bmap2 = isl_basic_map_reverse(bmap2);
-       if (!bmap2)
-               goto error;
-       bmap1 = isl_basic_map_extend(bmap1, bmap1->nparam,
-                       bmap1->n_in + bmap2->n_in, bmap1->n_out,
-                       bmap2->extra, bmap2->n_eq, bmap2->n_ineq);
-       if (!bmap1)
-               goto error;
-       bmap1 = add_constraints(bmap1, bmap2, bmap1->n_in - bmap2->n_in, 0);
-       bmap1 = isl_basic_map_simplify(bmap1);
-       bset = isl_basic_set_from_basic_map(bmap1);
-       bset = isl_basic_set_project_out(bset,
-                                               bset->dim - (n_in + n_out), 0);
-       return isl_basic_map_from_basic_set(bset, n_in, n_out);
+       dim_result = isl_dim_join(isl_dim_copy(bmap1->dim),
+                                 isl_dim_copy(bmap2->dim));
+
+       n_in = isl_basic_map_n_in(bmap1);
+       n_out = isl_basic_map_n_out(bmap2);
+       n = isl_basic_map_n_out(bmap1);
+       nparam = isl_basic_map_n_param(bmap1);
+
+       total = nparam + n_in + n_out + bmap1->n_div + bmap2->n_div + n;
+       dim_map1 = isl_dim_map_alloc(bmap1->ctx, total);
+       dim_map2 = isl_dim_map_alloc(bmap1->ctx, total);
+       isl_dim_map_dim(dim_map1, bmap1->dim, isl_dim_param, pos = 0);
+       isl_dim_map_dim(dim_map2, bmap2->dim, isl_dim_param, pos = 0);
+       isl_dim_map_dim(dim_map1, bmap1->dim, isl_dim_in, pos += nparam);
+       isl_dim_map_dim(dim_map2, bmap2->dim, isl_dim_out, pos += n_in);
+       isl_dim_map_div(dim_map1, bmap1, pos += n_out);
+       isl_dim_map_div(dim_map2, bmap2, pos += bmap1->n_div);
+       isl_dim_map_dim(dim_map1, bmap1->dim, isl_dim_out, pos += bmap2->n_div);
+       isl_dim_map_dim(dim_map2, bmap2->dim, isl_dim_in, pos);
+
+       bmap = isl_basic_map_alloc_dim(dim_result,
+                       bmap1->n_div + bmap2->n_div + n,
+                       bmap1->n_eq + bmap2->n_eq,
+                       bmap1->n_ineq + bmap2->n_ineq);
+       bmap = add_constraints_dim_map(bmap, bmap1, dim_map1);
+       bmap = add_constraints_dim_map(bmap, bmap2, dim_map2);
+       bmap = add_divs(bmap, n);
+       bmap = isl_basic_map_simplify(bmap);
+       return isl_basic_map_finalize(bmap);
 error:
        isl_basic_map_free(bmap1);
        isl_basic_map_free(bmap2);
@@ -2216,7 +2642,8 @@ struct isl_basic_set *isl_basic_set_apply(
        if (!bset || !bmap)
                goto error;
 
-       isl_assert(bset->ctx, bset->dim == bmap->n_in, goto error);
+       isl_assert(set->ctx, isl_basic_map_compatible_domain(bmap, bset),
+                   goto error);
 
        return (struct isl_basic_set *)
                isl_basic_map_apply_range((struct isl_basic_map *)bset, bmap);
@@ -2232,8 +2659,11 @@ struct isl_basic_map *isl_basic_map_apply_domain(
        if (!bmap1 || !bmap2)
                goto error;
 
-       isl_assert(ctx, bmap1->n_in == bmap2->n_in, goto error);
-       isl_assert(ctx, bmap1->nparam == bmap2->nparam, goto error);
+       isl_assert(ctx,
+           isl_basic_map_n_in(bmap1) == isl_basic_map_n_in(bmap2), goto error);
+       isl_assert(ctx,
+           isl_basic_map_n_param(bmap1) == isl_basic_map_n_param(bmap2),
+           goto error);
 
        bmap1 = isl_basic_map_reverse(bmap1);
        bmap1 = isl_basic_map_apply_range(bmap1, bmap2);
@@ -2248,13 +2678,17 @@ static struct isl_basic_map *var_equal(struct isl_ctx *ctx,
                struct isl_basic_map *bmap, unsigned pos)
 {
        int i;
+       unsigned nparam;
+       unsigned n_in;
+
        i = isl_basic_map_alloc_equality(bmap);
        if (i < 0)
                goto error;
-       isl_seq_clr(bmap->eq[i],
-                   1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div);
-       isl_int_set_si(bmap->eq[i][1+bmap->nparam+pos], -1);
-       isl_int_set_si(bmap->eq[i][1+bmap->nparam+bmap->n_in+pos], 1);
+       nparam = isl_basic_map_n_param(bmap);
+       n_in = isl_basic_map_n_in(bmap);
+       isl_seq_clr(bmap->eq[i], 1 + isl_basic_map_total_dim(bmap));
+       isl_int_set_si(bmap->eq[i][1+nparam+pos], -1);
+       isl_int_set_si(bmap->eq[i][1+nparam+n_in+pos], 1);
        return isl_basic_map_finalize(bmap);
 error:
        isl_basic_map_free(bmap);
@@ -2265,14 +2699,18 @@ static struct isl_basic_map *var_more(struct isl_ctx *ctx,
                struct isl_basic_map *bmap, unsigned pos)
 {
        int i;
+       unsigned nparam;
+       unsigned n_in;
+
        i = isl_basic_map_alloc_inequality(bmap);
        if (i < 0)
                goto error;
-       isl_seq_clr(bmap->ineq[i],
-                   1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div);
+       nparam = isl_basic_map_n_param(bmap);
+       n_in = isl_basic_map_n_in(bmap);
+       isl_seq_clr(bmap->ineq[i], 1 + isl_basic_map_total_dim(bmap));
        isl_int_set_si(bmap->ineq[i][0], -1);
-       isl_int_set_si(bmap->ineq[i][1+bmap->nparam+pos], -1);
-       isl_int_set_si(bmap->ineq[i][1+bmap->nparam+bmap->n_in+pos], 1);
+       isl_int_set_si(bmap->ineq[i][1+nparam+pos], -1);
+       isl_int_set_si(bmap->ineq[i][1+nparam+n_in+pos], 1);
        return isl_basic_map_finalize(bmap);
 error:
        isl_basic_map_free(bmap);
@@ -2283,14 +2721,18 @@ static struct isl_basic_map *var_less(struct isl_ctx *ctx,
                struct isl_basic_map *bmap, unsigned pos)
 {
        int i;
+       unsigned nparam;
+       unsigned n_in;
+
        i = isl_basic_map_alloc_inequality(bmap);
        if (i < 0)
                goto error;
-       isl_seq_clr(bmap->ineq[i],
-                   1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div);
+       nparam = isl_basic_map_n_param(bmap);
+       n_in = isl_basic_map_n_in(bmap);
+       isl_seq_clr(bmap->ineq[i], 1 + isl_basic_map_total_dim(bmap));
        isl_int_set_si(bmap->ineq[i][0], -1);
-       isl_int_set_si(bmap->ineq[i][1+bmap->nparam+pos], 1);
-       isl_int_set_si(bmap->ineq[i][1+bmap->nparam+bmap->n_in+pos], -1);
+       isl_int_set_si(bmap->ineq[i][1+nparam+pos], 1);
+       isl_int_set_si(bmap->ineq[i][1+nparam+n_in+pos], -1);
        return isl_basic_map_finalize(bmap);
 error:
        isl_basic_map_free(bmap);
@@ -2341,21 +2783,22 @@ struct isl_basic_map *isl_basic_map_more_at(struct isl_ctx *ctx,
 }
 
 struct isl_basic_map *isl_basic_map_from_basic_set(
-               struct isl_basic_set *bset, unsigned n_in, unsigned n_out)
+               struct isl_basic_set *bset, struct isl_dim *dim)
 {
        struct isl_basic_map *bmap;
 
        bset = isl_basic_set_cow(bset);
-       if (!bset)
-               return NULL;
+       if (!bset || !dim)
+               goto error;
 
-       isl_assert(ctx, bset->dim == n_in + n_out, goto error);
+       isl_assert(bset->ctx, isl_dim_compatible(bset->dim, dim), goto error);
+       isl_dim_free(bset->dim);
        bmap = (struct isl_basic_map *) bset;
-       bmap->n_in = n_in;
-       bmap->n_out = n_out;
+       bmap->dim = dim;
        return isl_basic_map_finalize(bmap);
 error:
        isl_basic_set_free(bset);
+       isl_dim_free(dim);
        return NULL;
 }
 
@@ -2363,16 +2806,20 @@ struct isl_basic_set *isl_basic_set_from_basic_map(struct isl_basic_map *bmap)
 {
        if (!bmap)
                goto error;
-       if (bmap->n_in == 0)
+       if (bmap->dim->n_in == 0)
                return (struct isl_basic_set *)bmap;
        bmap = isl_basic_map_cow(bmap);
        if (!bmap)
                goto error;
-       bmap->n_out += bmap->n_in;
-       bmap->n_in = 0;
+       bmap->dim = isl_dim_cow(bmap->dim);
+       if (!bmap->dim)
+               goto error;
+       bmap->dim->n_out += bmap->dim->n_in;
+       bmap->dim->n_in = 0;
        bmap = isl_basic_map_finalize(bmap);
        return (struct isl_basic_set *)bmap;
 error:
+       isl_basic_map_free(bmap);
        return NULL;
 }
 
@@ -2388,8 +2835,8 @@ error:
 static int add_div_constraints(struct isl_basic_map *bmap, unsigned div)
 {
        int i, j;
-       unsigned div_pos = 1 + bmap->nparam + bmap->n_in + bmap->n_out + div;
-       unsigned total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned total = isl_basic_map_total_dim(bmap);
+       unsigned div_pos = 1 + total - bmap->n_div + div;
 
        i = isl_basic_map_alloc_inequality(bmap);
        if (i < 0)
@@ -2411,14 +2858,17 @@ struct isl_basic_set *isl_basic_map_underlying_set(
 {
        if (!bmap)
                goto error;
-       if (bmap->nparam == 0 && bmap->n_in == 0 && bmap->n_div == 0)
+       if (bmap->dim->nparam == 0 && bmap->dim->n_in == 0 && bmap->n_div == 0)
                return (struct isl_basic_set *)bmap;
        bmap = isl_basic_map_cow(bmap);
        if (!bmap)
                goto error;
-       bmap->n_out += bmap->nparam + bmap->n_in + bmap->n_div;
-       bmap->nparam = 0;
-       bmap->n_in = 0;
+       bmap->dim = isl_dim_cow(bmap->dim);
+       if (!bmap->dim)
+               goto error;
+       bmap->dim->n_out += bmap->dim->nparam + bmap->dim->n_in + bmap->n_div;
+       bmap->dim->nparam = 0;
+       bmap->dim->n_in = 0;
        bmap->extra -= bmap->n_div;
        bmap->n_div = 0;
        bmap = isl_basic_map_finalize(bmap);
@@ -2433,26 +2883,29 @@ struct isl_basic_map *isl_basic_map_overlying_set(
        struct isl_basic_map *bmap;
        struct isl_ctx *ctx;
        unsigned total;
-       int i, k;
+       int i;
 
        if (!bset || !like)
                goto error;
        ctx = bset->ctx;
-       isl_assert(ctx, bset->dim ==
-                       like->nparam + like->n_in + like->n_out + like->n_div,
+       isl_assert(ctx, bset->n_div == 0, goto error);
+       isl_assert(ctx, isl_basic_set_n_param(bset) == 0, goto error);
+       isl_assert(ctx, bset->dim->n_out == isl_basic_map_total_dim(like),
                        goto error);
-       if (like->nparam == 0 && like->n_in == 0 && like->n_div == 0) {
+       if (isl_dim_equal(bset->dim, like->dim) && like->n_div == 0) {
                isl_basic_map_free(like);
                return (struct isl_basic_map *)bset;
        }
        bset = isl_basic_set_cow(bset);
        if (!bset)
                goto error;
-       total = bset->dim + bset->extra;
+       total = bset->dim->n_out + bset->extra;
        bmap = (struct isl_basic_map *)bset;
-       bmap->nparam = like->nparam;
-       bmap->n_in = like->n_in;
-       bmap->n_out = like->n_out;
+       isl_dim_free(bmap->dim);
+       bmap->dim = isl_dim_copy(like->dim);
+       if (!bmap->dim)
+               goto error;
+       bmap->n_div = like->n_div;
        bmap->extra += like->n_div;
        if (bmap->extra) {
                unsigned ltotal;
@@ -2467,19 +2920,20 @@ struct isl_basic_map *isl_basic_map_overlying_set(
                                                bmap->extra);
                if (!bmap->div)
                        goto error;
-               bmap = isl_basic_map_extend(bmap, bmap->nparam,
-                       bmap->n_in, bmap->n_out, 0, 0, 2 * like->n_div);
+               for (i = 0; i < bmap->extra; ++i)
+                       bmap->div[i] = bmap->block2.data + i * (1 + 1 + total);
                for (i = 0; i < like->n_div; ++i) {
-                       k = isl_basic_map_alloc_div(bmap);
-                       if (k < 0)
-                               goto error;
-                       isl_seq_cpy(bmap->div[k], like->div[i], 1 + 1 + ltotal);
-                       isl_seq_clr(bmap->div[k]+1+1+ltotal, total - ltotal);
-                       if (add_div_constraints(bmap, k) < 0)
-                               goto error;
+                       isl_seq_cpy(bmap->div[i], like->div[i], 1 + 1 + ltotal);
+                       isl_seq_clr(bmap->div[i]+1+1+ltotal, total - ltotal);
                }
+               bmap = isl_basic_map_extend_constraints(bmap, 
+                                                       0, 2 * like->n_div);
+               for (i = 0; i < like->n_div; ++i)
+                       if (add_div_constraints(bmap, i) < 0)
+                               goto error;
        }
        isl_basic_map_free(like);
+       bmap = isl_basic_map_simplify(bmap);
        bmap = isl_basic_map_finalize(bmap);
        return bmap;
 error:
@@ -2502,9 +2956,9 @@ struct isl_set *isl_set_from_underlying_set(
 
        if (!set || !like)
                goto error;
-       isl_assert(set->ctx, set->dim == like->nparam + like->dim + like->n_div,
+       isl_assert(set->ctx, set->dim->n_out == isl_basic_set_total_dim(like),
                    goto error);
-       if (like->nparam == 0 && like->n_div == 0) {
+       if (isl_dim_equal(set->dim, like->dim) && like->n_div == 0) {
                isl_basic_set_free(like);
                return set;
        }
@@ -2517,8 +2971,10 @@ struct isl_set *isl_set_from_underlying_set(
                if (!set->p[i])
                        goto error;
        }
-       set->nparam = like->nparam;
-       set->dim = like->dim;
+       isl_dim_free(set->dim);
+       set->dim = isl_dim_copy(like->dim);
+       if (!set->dim)
+               goto error;
        isl_basic_set_free(like);
        return set;
 error:
@@ -2531,11 +2987,16 @@ struct isl_set *isl_map_underlying_set(struct isl_map *map)
 {
        int i;
 
-       map = isl_map_align_divs(map);
        map = isl_map_cow(map);
        if (!map)
                return NULL;
+       map->dim = isl_dim_cow(map->dim);
+       if (!map->dim)
+               goto error;
 
+       for (i = 1; i < map->n; ++i)
+               isl_assert(map->ctx, map->p[0]->n_div == map->p[i]->n_div,
+                               goto error);
        for (i = 0; i < map->n; ++i) {
                map->p[i] = (struct isl_basic_map *)
                                isl_basic_map_underlying_set(map->p[i]);
@@ -2543,11 +3004,11 @@ struct isl_set *isl_map_underlying_set(struct isl_map *map)
                        goto error;
        }
        if (map->n == 0)
-               map->n_out += map->nparam + map->n_in;
+               map->dim->n_out += map->dim->nparam + map->dim->n_in;
        else
-               map->n_out = map->p[0]->n_out;
-       map->nparam = 0;
-       map->n_in = 0;
+               map->dim->n_out = map->p[0]->dim->n_out;
+       map->dim->nparam = 0;
+       map->dim->n_in = 0;
        return (struct isl_set *)map;
 error:
        isl_map_free(map);
@@ -2565,7 +3026,7 @@ struct isl_basic_set *isl_basic_map_domain(struct isl_basic_map *bmap)
        unsigned n_out;
        if (!bmap)
                return NULL;
-       n_out = bmap->n_out;
+       n_out = isl_basic_map_n_out(bmap);
        domain = isl_basic_set_from_basic_map(bmap);
        return isl_basic_set_project_out(domain, n_out, 0);
 }
@@ -2587,7 +3048,11 @@ struct isl_set *isl_map_range(struct isl_map *map)
                goto error;
 
        set = (struct isl_set *) map;
-       set->zero = 0;
+       if (set->dim->n_in != 0) {
+               set->dim = isl_dim_drop_inputs(set->dim, 0, set->dim->n_in);
+               if (!set->dim)
+                       goto error;
+       }
        for (i = 0; i < map->n; ++i) {
                set->p[i] = isl_basic_map_range(map->p[i]);
                if (!set->p[i])
@@ -2601,29 +3066,27 @@ error:
        return NULL;
 }
 
-struct isl_map *isl_map_from_set(struct isl_set *set,
-               unsigned n_in, unsigned n_out)
+struct isl_map *isl_map_from_set(struct isl_set *set, struct isl_dim *dim)
 {
        int i;
        struct isl_map *map = NULL;
 
-       if (!set)
-               return NULL;
-       isl_assert(set->ctx, set->dim == n_in + n_out, goto error);
        set = isl_set_cow(set);
-       if (!set)
-               return NULL;
+       if (!set || !dim)
+               goto error;
+       isl_assert(set->ctx, isl_dim_compatible(set->dim, dim), goto error);
        map = (struct isl_map *)set;
        for (i = 0; i < set->n; ++i) {
                map->p[i] = isl_basic_map_from_basic_set(
-                               set->p[i], n_in, n_out);
+                               set->p[i], isl_dim_copy(dim));
                if (!map->p[i])
                        goto error;
        }
-       map->n_in = n_in;
-       map->n_out = n_out;
+       isl_dim_free(map->dim);
+       map->dim = dim;
        return map;
 error:
+       isl_dim_free(dim);
        isl_set_free(set);
        return NULL;
 }
@@ -2638,8 +3101,11 @@ struct isl_set *isl_set_from_map(struct isl_map *map)
        map = isl_map_cow(map);
        if (!map)
                return NULL;
-       map->n_out += map->n_in;
-       map->n_in = 0;
+       map->dim = isl_dim_cow(map->dim);
+       if (!map->dim)
+               goto error;
+       map->dim->n_out += map->dim->n_in;
+       map->dim->n_in = 0;
        set = (struct isl_set *)map;
        for (i = 0; i < map->n; ++i) {
                set->p[i] = isl_basic_set_from_basic_map(map->p[i]);
@@ -2652,28 +3118,45 @@ error:
        return NULL;
 }
 
-struct isl_map *isl_map_alloc(struct isl_ctx *ctx,
-               unsigned nparam, unsigned in, unsigned out, int n,
-               unsigned flags)
+struct isl_map *isl_map_alloc_dim(struct isl_dim *dim, int n, unsigned flags)
 {
        struct isl_map *map;
 
-       map = isl_alloc(ctx, struct isl_map,
+       if (!dim)
+               return NULL;
+       isl_assert(dim->ctx, n >= 0, return NULL);
+       map = isl_alloc(dim->ctx, struct isl_map,
                        sizeof(struct isl_map) +
                        n * sizeof(struct isl_basic_map *));
        if (!map)
-               return NULL;
+               goto error;
 
-       map->ctx = ctx;
-       isl_ctx_ref(ctx);
+       map->ctx = dim->ctx;
+       isl_ctx_ref(map->ctx);
        map->ref = 1;
        map->size = n;
        map->n = 0;
-       map->nparam = nparam;
-       map->n_in = in;
-       map->n_out = out;
+       map->dim = dim;
        map->flags = flags;
        return map;
+error:
+       isl_dim_free(dim);
+       return NULL;
+}
+
+struct isl_map *isl_map_alloc(struct isl_ctx *ctx,
+               unsigned nparam, unsigned in, unsigned out, int n,
+               unsigned flags)
+{
+       struct isl_map *map;
+       struct isl_dim *dims;
+
+       dims = isl_dim_alloc(ctx, nparam, in, out);
+       if (!dims)
+               return NULL;
+
+       map = isl_map_alloc_dim(dims, n, flags);
+       return map;
 }
 
 struct isl_basic_map *isl_basic_map_empty(struct isl_ctx *ctx,
@@ -2685,41 +3168,98 @@ struct isl_basic_map *isl_basic_map_empty(struct isl_ctx *ctx,
        return bmap;
 }
 
-struct isl_basic_set *isl_basic_set_empty(struct isl_ctx *ctx,
-               unsigned nparam, unsigned dim)
+struct isl_basic_set *isl_basic_set_empty(struct isl_dim *dim)
 {
        struct isl_basic_set *bset;
-       bset = isl_basic_set_alloc(ctx, nparam, dim, 0, 1, 0);
+       bset = isl_basic_set_alloc_dim(dim, 0, 1, 0);
        bset = isl_basic_set_set_to_empty(bset);
        return bset;
 }
 
-struct isl_basic_map *isl_basic_map_universe(struct isl_ctx *ctx,
-               unsigned nparam, unsigned in, unsigned out)
+struct isl_basic_map *isl_basic_map_empty_like(struct isl_basic_map *model)
 {
        struct isl_basic_map *bmap;
-       bmap = isl_basic_map_alloc(ctx, nparam, in, out, 0, 0, 0);
+       if (!model)
+               return NULL;
+       bmap = isl_basic_map_alloc_dim(isl_dim_copy(model->dim), 0, 1, 0);
+       bmap = isl_basic_map_set_to_empty(bmap);
        return bmap;
 }
 
-struct isl_basic_set *isl_basic_set_universe(struct isl_ctx *ctx,
-               unsigned nparam, unsigned dim)
+struct isl_basic_map *isl_basic_map_empty_like_map(struct isl_map *model)
+{
+       struct isl_basic_map *bmap;
+       if (!model)
+               return NULL;
+       bmap = isl_basic_map_alloc_dim(isl_dim_copy(model->dim), 0, 1, 0);
+       bmap = isl_basic_map_set_to_empty(bmap);
+       return bmap;
+}
+
+struct isl_basic_set *isl_basic_set_empty_like(struct isl_basic_set *model)
 {
        struct isl_basic_set *bset;
-       bset = isl_basic_set_alloc(ctx, nparam, dim, 0, 0, 0);
+       if (!model)
+               return NULL;
+       bset = isl_basic_set_alloc_dim(isl_dim_copy(model->dim), 0, 1, 0);
+       bset = isl_basic_set_set_to_empty(bset);
        return bset;
 }
 
+struct isl_basic_map *isl_basic_map_universe(struct isl_dim *dim)
+{
+       struct isl_basic_map *bmap;
+       bmap = isl_basic_map_alloc_dim(dim, 0, 0, 0);
+       return bmap;
+}
+
+struct isl_basic_set *isl_basic_set_universe(struct isl_dim *dim)
+{
+       struct isl_basic_set *bset;
+       bset = isl_basic_set_alloc_dim(dim, 0, 0, 0);
+       return bset;
+}
+
+struct isl_basic_set *isl_basic_set_universe_like(struct isl_basic_set *model)
+{
+       if (!model)
+               return NULL;
+       return isl_basic_set_alloc_dim(isl_dim_copy(model->dim), 0, 0, 0);
+}
+
 struct isl_map *isl_map_empty(struct isl_ctx *ctx,
                unsigned nparam, unsigned in, unsigned out)
 {
        return isl_map_alloc(ctx, nparam, in, out, 0, ISL_MAP_DISJOINT);
 }
 
-struct isl_set *isl_set_empty(struct isl_ctx *ctx,
-               unsigned nparam, unsigned dim)
+struct isl_map *isl_map_empty_like_basic_map(struct isl_basic_map *model)
 {
-       return isl_set_alloc(ctx, nparam, dim, 0, ISL_MAP_DISJOINT);
+       if (!model)
+               return NULL;
+       return isl_map_alloc_dim(isl_dim_copy(model->dim), 0, ISL_MAP_DISJOINT);
+}
+
+struct isl_set *isl_set_empty(struct isl_dim *dim)
+{
+       return isl_set_alloc_dim(dim, 0, ISL_MAP_DISJOINT);
+}
+
+struct isl_set *isl_set_empty_like(struct isl_set *model)
+{
+       if (!model)
+               return NULL;
+       return isl_set_empty(isl_dim_copy(model->dim));
+}
+
+struct isl_set *isl_set_universe(struct isl_dim *dim)
+{
+       struct isl_set *set;
+       if (!dim)
+               return NULL;
+       set = isl_set_alloc_dim(isl_dim_copy(dim), 1, ISL_MAP_DISJOINT);
+       set = isl_set_add(set, isl_basic_set_universe(dim));
+       return set;
 }
 
 struct isl_map *isl_map_dup(struct isl_map *map)
@@ -2729,8 +3269,7 @@ struct isl_map *isl_map_dup(struct isl_map *map)
 
        if (!map)
                return NULL;
-       dup = isl_map_alloc(map->ctx, map->nparam, map->n_in, map->n_out, map->n,
-                               map->flags);
+       dup = isl_map_alloc_dim(isl_dim_copy(map->dim), map->n, map->flags);
        for (i = 0; i < map->n; ++i)
                dup = isl_map_add(dup, isl_basic_map_copy(map->p[i]));
        return dup;
@@ -2740,9 +3279,7 @@ struct isl_map *isl_map_add(struct isl_map *map, struct isl_basic_map *bmap)
 {
        if (!bmap || !map)
                goto error;
-       isl_assert(map->ctx, map->nparam == bmap->nparam, goto error);
-       isl_assert(map->ctx, map->n_in == bmap->n_in, goto error);
-       isl_assert(map->ctx, map->n_out == bmap->n_out, goto error);
+       isl_assert(map->ctx, isl_dim_equal(map->dim, bmap->dim), goto error);
        isl_assert(map->ctx, map->n < map->size, goto error);
        map->p[map->n] = bmap;
        map->n++;
@@ -2769,6 +3306,7 @@ void isl_map_free(struct isl_map *map)
        isl_ctx_deref(map->ctx);
        for (i = 0; i < map->n; ++i)
                isl_basic_map_free(map->p[i]);
+       isl_dim_free(map->dim);
        free(map);
 }
 
@@ -2781,15 +3319,12 @@ struct isl_map *isl_map_extend(struct isl_map *base,
        if (!base)
                return NULL;
 
-       isl_assert(base->ctx, base->nparam <= nparam, goto error);
-       isl_assert(base->ctx, base->n_in <= n_in, goto error);
-       isl_assert(base->ctx, base->n_out <= n_out, goto error);
-       base->nparam = nparam;
-       base->n_in = n_in;
-       base->n_out = n_out;
+       base->dim = isl_dim_extend(base->dim, nparam, n_in, n_out);
+       if (!base->dim)
+               goto error;
        for (i = 0; i < base->n; ++i) {
-               base->p[i] = isl_basic_map_extend(base->p[i],
-                               nparam, n_in, n_out, 0, 0, 0);
+               base->p[i] = isl_basic_map_extend_dim(base->p[i],
+                               isl_dim_copy(base->dim), 0, 0, 0);
                if (!base->p[i])
                        goto error;
        }
@@ -2812,13 +3347,11 @@ static struct isl_basic_map *isl_basic_map_fix_var(struct isl_basic_map *bmap,
        int j;
 
        bmap = isl_basic_map_cow(bmap);
-       bmap = isl_basic_map_extend(bmap,
-                       bmap->nparam, bmap->n_in, bmap->n_out, 0, 1, 0);
+       bmap = isl_basic_map_extend_constraints(bmap, 1, 0);
        j = isl_basic_map_alloc_equality(bmap);
        if (j < 0)
                goto error;
-       isl_seq_clr(bmap->eq[j],
-                   1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div);
+       isl_seq_clr(bmap->eq[j], 1 + isl_basic_map_total_dim(bmap));
        isl_int_set_si(bmap->eq[j][1 + var], -1);
        isl_int_set_si(bmap->eq[j][0], value);
        bmap = isl_basic_map_simplify(bmap);
@@ -2833,8 +3366,9 @@ struct isl_basic_map *isl_basic_map_fix_input_si(struct isl_basic_map *bmap,
 {
        if (!bmap)
                return NULL;
-       isl_assert(bmap->ctx, input < bmap->n_in, goto error);
-       return isl_basic_map_fix_var(bmap, bmap->nparam + input, value);
+       isl_assert(bmap->ctx, input < isl_basic_map_n_in(bmap), goto error);
+       return isl_basic_map_fix_var(bmap, isl_basic_map_n_param(bmap) + input,
+                                       value);
 error:
        isl_basic_map_free(bmap);
        return NULL;
@@ -2845,10 +3379,10 @@ struct isl_basic_set *isl_basic_set_fix_dim_si(struct isl_basic_set *bset,
 {
        if (!bset)
                return NULL;
-       isl_assert(bset->ctx, dim < bset->dim, goto error);
+       isl_assert(bset->ctx, dim < isl_basic_set_n_dim(bset), goto error);
        return (struct isl_basic_set *)
                isl_basic_map_fix_var((struct isl_basic_map *)bset,
-                                               bset->nparam + dim, value);
+                                   isl_basic_set_n_param(bset) + dim, value);
 error:
        isl_basic_set_free(bset);
        return NULL;
@@ -2863,7 +3397,7 @@ struct isl_map *isl_map_fix_input_si(struct isl_map *map,
        if (!map)
                return NULL;
 
-       isl_assert(ctx, input < map->n_in, goto error);
+       isl_assert(ctx, input < isl_map_n_in(map), goto error);
        for (i = 0; i < map->n; ++i) {
                map->p[i] = isl_basic_map_fix_input_si(map->p[i], input, value);
                if (!map->p[i])
@@ -2884,7 +3418,7 @@ struct isl_set *isl_set_fix_dim_si(struct isl_set *set, unsigned dim, int value)
        if (!set)
                return NULL;
 
-       isl_assert(set->ctx, dim < set->dim, goto error);
+       isl_assert(set->ctx, dim < isl_set_n_dim(set), goto error);
        for (i = 0; i < set->n; ++i) {
                set->p[i] = isl_basic_set_fix_dim_si(set->p[i], dim, value);
                if (!set->p[i])
@@ -2900,14 +3434,15 @@ struct isl_basic_set *isl_basic_set_lower_bound_dim(struct isl_basic_set *bset,
        unsigned dim, isl_int value)
 {
        int j;
+       unsigned nparam;
 
        bset = isl_basic_set_cow(bset);
-       bset = isl_basic_set_extend(bset, bset->nparam, bset->dim, 0, 0, 1);
+       bset = isl_basic_set_extend_constraints(bset, 0, 1);
        j = isl_basic_set_alloc_inequality(bset);
        if (j < 0)
                goto error;
-       isl_seq_clr(bset->ineq[j], 1 + bset->nparam + bset->dim + bset->n_div);
-       isl_int_set_si(bset->ineq[j][1 + bset->nparam + dim], 1);
+       isl_seq_clr(bset->ineq[j], 1 + isl_basic_set_total_dim(bset));
+       isl_int_set_si(bset->ineq[j][1 + isl_basic_set_n_param(bset) + dim], 1);
        isl_int_neg(bset->ineq[j][0], value);
        bset = isl_basic_set_simplify(bset);
        return isl_basic_set_finalize(bset);
@@ -2925,7 +3460,7 @@ struct isl_set *isl_set_lower_bound_dim(struct isl_set *set, unsigned dim,
        if (!set)
                return NULL;
 
-       isl_assert(set->ctx, dim < set->dim, goto error);
+       isl_assert(set->ctx, dim < isl_set_n_dim(set), goto error);
        for (i = 0; i < set->n; ++i) {
                set->p[i] = isl_basic_set_lower_bound_dim(set->p[i], dim, value);
                if (!set->p[i])
@@ -2946,9 +3481,9 @@ struct isl_map *isl_map_reverse(struct isl_map *map)
        if (!map)
                return NULL;
 
-       t = map->n_in;
-       map->n_in = map->n_out;
-       map->n_out = t;
+       map->dim = isl_dim_reverse(map->dim);
+       if (!map->dim)
+               goto error;
        for (i = 0; i < map->n; ++i) {
                map->p[i] = isl_basic_map_reverse(map->p[i]);
                if (!map->p[i])
@@ -2980,13 +3515,15 @@ struct isl_set *isl_basic_set_lexmin(struct isl_basic_set *bset)
        struct isl_basic_map *bmap = NULL;
        struct isl_basic_set *dom = NULL;
        struct isl_map *min;
+       struct isl_dim *param_dim;
 
        if (!bset)
                goto error;
-       bmap = isl_basic_map_from_basic_set(bset, 0, bset->dim);
+       bmap = isl_basic_map_from_basic_set(bset, isl_dim_copy(bset->dim));
        if (!bmap)
                goto error;
-       dom = isl_basic_set_alloc(bmap->ctx, bmap->nparam, 0, 0, 0, 0);
+       param_dim = isl_dim_domain(isl_dim_copy(bmap->dim));
+       dom = isl_basic_set_universe(param_dim);
        if (!dom)
                goto error;
        min = isl_basic_map_lexmin(bmap, dom, NULL);
@@ -2998,11 +3535,22 @@ error:
 
 struct isl_map *isl_basic_map_compute_divs(struct isl_basic_map *bmap)
 {
+       int i;
+       unsigned off;
+
        if (!bmap)
                return NULL;
-       if (bmap->n_div == 0)
-               return isl_map_from_basic_map(bmap);
-       return isl_pip_basic_map_compute_divs(bmap);
+       off = isl_dim_total(bmap->dim);
+       for (i = 0; i < bmap->n_div; ++i) {
+               if (isl_int_is_zero(bmap->div[i][0]))
+                       return isl_pip_basic_map_compute_divs(bmap);
+               isl_assert(bmap->ctx, isl_int_is_zero(bmap->div[i][1+1+off+i]),
+                               goto error);
+       }
+       return isl_map_from_basic_map(bmap);
+error:
+       isl_basic_map_free(bmap);
+       return NULL;
 }
 
 struct isl_map *isl_map_compute_divs(struct isl_map *map)
@@ -3053,8 +3601,9 @@ struct isl_set *isl_map_domain(struct isl_map *map)
                return NULL;
 
        set = (struct isl_set *)map;
-       set->dim = map->n_in;
-       set->zero = 0;
+       set->dim = isl_dim_domain(set->dim);
+       if (!set->dim)
+               goto error;
        for (i = 0; i < map->n; ++i) {
                set->p[i] = isl_basic_map_domain(map->p[i]);
                if (!set->p[i])
@@ -3087,15 +3636,13 @@ struct isl_map *isl_map_union_disjoint(
                return map1;
        }
 
-       isl_assert(map1->ctx, map1->nparam == map2->nparam, goto error);
-       isl_assert(map1->ctx, map1->n_in == map2->n_in, goto error);
-       isl_assert(map1->ctx, map1->n_out == map2->n_out, goto error);
+       isl_assert(map1->ctx, isl_dim_equal(map1->dim, map2->dim), goto error);
 
        if (F_ISSET(map1, ISL_MAP_DISJOINT) &&
            F_ISSET(map2, ISL_MAP_DISJOINT))
                FL_SET(flags, ISL_MAP_DISJOINT);
 
-       map = isl_map_alloc(map1->ctx, map1->nparam, map1->n_in, map1->n_out,
+       map = isl_map_alloc_dim(isl_dim_copy(map1->dim),
                                map1->n + map2->n, flags);
        if (!map)
                goto error;
@@ -3159,8 +3706,8 @@ struct isl_map *isl_map_intersect_range(
            F_ISSET(set, ISL_MAP_DISJOINT))
                FL_SET(flags, ISL_MAP_DISJOINT);
 
-       result = isl_map_alloc(map->ctx, map->nparam, map->n_in, map->n_out,
-                               map->n * set->n, flags);
+       result = isl_map_alloc_dim(isl_dim_copy(map->dim),
+                                       map->n * set->n, flags);
        if (!result)
                goto error;
        for (i = 0; i < map->n; ++i)
@@ -3205,17 +3752,20 @@ error:
 struct isl_map *isl_map_apply_range(
                struct isl_map *map1, struct isl_map *map2)
 {
+       struct isl_dim *dim_result;
        struct isl_map *result;
        int i, j;
+       unsigned nparam;
+       unsigned n_in;
+       unsigned n_out;
 
        if (!map1 || !map2)
                goto error;
 
-       isl_assert(map1->ctx, map1->nparam == map2->nparam, goto error);
-       isl_assert(map1->ctx, map1->n_out == map2->n_in, goto error);
+       dim_result = isl_dim_join(isl_dim_copy(map1->dim),
+                                 isl_dim_copy(map2->dim));
 
-       result = isl_map_alloc(map1->ctx, map1->nparam, map1->n_in, map2->n_out,
-                               map1->n * map2->n, 0);
+       result = isl_map_alloc_dim(dim_result, map1->n * map2->n, 0);
        if (!result)
                goto error;
        for (i = 0; i < map1->n; ++i)
@@ -3245,26 +3795,26 @@ struct isl_basic_set *isl_basic_map_deltas(struct isl_basic_map *bmap)
 {
        struct isl_basic_set *bset;
        unsigned dim;
+       unsigned nparam;
        int i;
 
        if (!bmap)
                goto error;
-       isl_assert(bmap->ctx, bmap->n_in == bmap->n_out, goto error);
-       dim = bmap->n_in;
+       dim = isl_basic_map_n_in(bmap);
+       nparam = isl_basic_map_n_param(bmap);
+       isl_assert(bmap->ctx, dim == isl_basic_map_n_out(bmap), goto error);
        bset = isl_basic_set_from_basic_map(bmap);
-       bset = isl_basic_set_extend(bset, bset->nparam, 3*dim, 0,
-                                       dim, 0);
+       bset = isl_basic_set_extend(bset, nparam, 3*dim, 0, dim, 0);
        bset = isl_basic_set_swap_vars(bset, 2*dim);
        for (i = 0; i < dim; ++i) {
                int j = isl_basic_map_alloc_equality(
                                            (struct isl_basic_map *)bset);
                if (j < 0)
                        goto error;
-               isl_seq_clr(bset->eq[j],
-                           1 + bset->nparam + bset->dim + bset->n_div);
-               isl_int_set_si(bset->eq[j][1+bset->nparam+i], 1);
-               isl_int_set_si(bset->eq[j][1+bset->nparam+dim+i], 1);
-               isl_int_set_si(bset->eq[j][1+bset->nparam+2*dim+i], -1);
+               isl_seq_clr(bset->eq[j], 1 + isl_basic_set_total_dim(bset));
+               isl_int_set_si(bset->eq[j][1+nparam+i], 1);
+               isl_int_set_si(bset->eq[j][1+nparam+dim+i], 1);
+               isl_int_set_si(bset->eq[j][1+nparam+2*dim+i], -1);
        }
        return isl_basic_set_project_out(bset, 2*dim, 0);
 error:
@@ -3283,8 +3833,9 @@ struct isl_set *isl_map_deltas(struct isl_map *map)
        if (!map)
                return NULL;
 
-       isl_assert(map->ctx, map->n_in == map->n_out, goto error);
-       result = isl_set_alloc(map->ctx, map->nparam, map->n_in, map->n, map->flags);
+       isl_assert(map->ctx, isl_map_n_in(map) == isl_map_n_out(map), goto error);
+       result = isl_set_alloc(map->ctx, isl_map_n_param(map),
+                                       isl_map_n_in(map), map->n, map->flags);
        if (!result)
                goto error;
        for (i = 0; i < map->n; ++i)
@@ -3308,7 +3859,7 @@ error:
 static int div_is_redundant(struct isl_basic_map *bmap, int div)
 {
        int i;
-       unsigned pos = 1 + bmap->nparam + bmap->n_in + bmap->n_out + div;
+       unsigned pos = 1 + isl_dim_total(bmap->dim) + div;
 
        for (i = 0; i < bmap->n_eq; ++i)
                if (!isl_int_is_zero(bmap->eq[i][pos]))
@@ -3418,13 +3969,19 @@ error:
        return NULL;
 }
 
-struct isl_basic_map *isl_basic_map_identity(struct isl_ctx *ctx,
-               unsigned nparam, unsigned dim)
+static struct isl_basic_map *basic_map_identity(struct isl_dim *dims)
 {
        struct isl_basic_map *bmap;
+       unsigned nparam;
+       unsigned dim;
        int i;
 
-       bmap = isl_basic_map_alloc(ctx, nparam, dim, dim, 0, dim, 0);
+       if (!dims)
+               return NULL;
+
+       nparam = dims->nparam;
+       dim = dims->n_out;
+       bmap = isl_basic_map_alloc_dim(dims, 0, dim, 0);
        if (!bmap)
                goto error;
 
@@ -3432,8 +3989,7 @@ struct isl_basic_map *isl_basic_map_identity(struct isl_ctx *ctx,
                int j = isl_basic_map_alloc_equality(bmap);
                if (j < 0)
                        goto error;
-               isl_seq_clr(bmap->eq[j],
-                   1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div);
+               isl_seq_clr(bmap->eq[j], 1 + isl_basic_map_total_dim(bmap));
                isl_int_set_si(bmap->eq[j][1+nparam+i], 1);
                isl_int_set_si(bmap->eq[j][1+nparam+dim+i], -1);
        }
@@ -3443,19 +3999,44 @@ error:
        return NULL;
 }
 
-struct isl_map *isl_map_identity(struct isl_ctx *ctx,
-               unsigned nparam, unsigned dim)
+struct isl_basic_map *isl_basic_map_identity(struct isl_dim *set_dim)
 {
-       struct isl_map *map = isl_map_alloc(ctx, nparam, dim, dim, 1,
-                                               ISL_MAP_DISJOINT);
-       if (!map)
-               goto error;
-       map = isl_map_add(map,
-               isl_basic_map_identity(ctx, nparam, dim));
-       return map;
-error:
-       isl_map_free(map);
-       return NULL;
+       struct isl_dim *dim = isl_dim_map(set_dim);
+       if (!dim)
+               return NULL;
+       return basic_map_identity(dim);
+}
+
+struct isl_basic_map *isl_basic_map_identity_like(struct isl_basic_map *model)
+{
+       if (!model || !model->dim)
+               return NULL;
+       isl_assert(model->ctx,
+                       model->dim->n_in == model->dim->n_out, return NULL);
+       return basic_map_identity(isl_dim_copy(model->dim));
+}
+
+static struct isl_map *map_identity(struct isl_dim *dim)
+{
+       struct isl_map *map = isl_map_alloc_dim(dim, 1, ISL_MAP_DISJOINT);
+       return isl_map_add(map, basic_map_identity(isl_dim_copy(dim)));
+}
+
+struct isl_map *isl_map_identity(struct isl_dim *set_dim)
+{
+       struct isl_dim *dim = isl_dim_map(set_dim);
+       if (!dim)
+               return NULL;
+       return map_identity(dim);
+}
+
+struct isl_map *isl_map_identity_like(struct isl_basic_map *model)
+{
+       if (!model || !model->dim)
+               return NULL;
+       isl_assert(model->ctx,
+                       model->dim->n_in == model->dim->n_out, return NULL);
+       return map_identity(isl_dim_copy(model->dim));
 }
 
 int isl_set_is_equal(struct isl_set *set1, struct isl_set *set2)
@@ -3593,7 +4174,7 @@ static int basic_map_contains(struct isl_basic_map *bmap, struct isl_vec *vec)
        unsigned total;
        isl_int s;
 
-       total = 1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       total = 1 + isl_basic_map_total_dim(bmap);
        if (total != vec->size)
                return -1;
 
@@ -3648,7 +4229,7 @@ int isl_basic_map_is_empty(struct isl_basic_map *bmap)
                return empty;
        }
 
-       total = 1 + bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       total = 1 + isl_basic_map_total_dim(bmap);
        if (bmap->sample && bmap->sample->size == total) {
                int contains = basic_map_contains(bmap, bmap->sample);
                if (contains < 0)
@@ -3677,12 +4258,9 @@ struct isl_map *isl_basic_map_union(
        if (!bmap1 || !bmap2)
                return NULL;
 
-       isl_assert(bmap1->ctx, bmap1->nparam == bmap2->nparam, goto error);
-       isl_assert(bmap1->ctx, bmap1->n_in == bmap2->n_in, goto error);
-       isl_assert(bmap1->ctx, bmap1->n_out == bmap2->n_out, goto error);
+       isl_assert(map1->ctx, isl_dim_equal(bmap1->dim, bmap2->dim), goto error);
 
-       map = isl_map_alloc(bmap1->ctx, bmap1->nparam,
-                               bmap1->n_in, bmap1->n_out, 2, 0);
+       map = isl_map_alloc_dim(isl_dim_copy(bmap1->dim), 2, 0);
        if (!map)
                goto error;
        map = isl_map_add(map, bmap1);
@@ -3706,7 +4284,7 @@ struct isl_set *isl_basic_set_union(
 static struct isl_basic_map *order_divs(struct isl_basic_map *bmap)
 {
        int i;
-       unsigned off = bmap->nparam + bmap->n_in + bmap->n_out;
+       unsigned off = isl_dim_total(bmap->dim);
 
        for (i = 0; i < bmap->n_div; ++i) {
                int pos;
@@ -3720,17 +4298,24 @@ static struct isl_basic_map *order_divs(struct isl_basic_map *bmap)
        return bmap;
 }
 
+/* Look for a div in dst that corresponds to the div "div" in src.
+ * The divs before "div" in src and dst are assumed to be the same.
+ * 
+ * Returns -1 if no corresponding div was found and the position
+ * of the corresponding div in dst otherwise.
+ */
 static int find_div(struct isl_basic_map *dst,
                        struct isl_basic_map *src, unsigned div)
 {
        int i;
 
-       unsigned total = src->nparam + src->n_in + src->n_out + src->n_div;
+       unsigned total = isl_dim_total(src->dim);
 
-       for (i = 0; i < dst->n_div; ++i)
-               if (isl_seq_eq(dst->div[i], src->div[div], 1+1+total) &&
-                   isl_seq_first_non_zero(dst->div[i]+1+1+total,
-                                               dst->n_div - src->n_div) == -1)
+       isl_assert(dst->ctx, div <= dst->n_div, return -1);
+       for (i = div; i < dst->n_div; ++i)
+               if (isl_seq_eq(dst->div[i], src->div[div], 1+1+total+div) &&
+                   isl_seq_first_non_zero(dst->div[i]+1+1+total+div,
+                                               dst->n_div - div) == -1)
                        return i;
        return -1;
 }
@@ -3739,7 +4324,7 @@ struct isl_basic_map *isl_basic_map_align_divs(
                struct isl_basic_map *dst, struct isl_basic_map *src)
 {
        int i;
-       unsigned total = src->nparam + src->n_in + src->n_out + src->n_div;
+       unsigned total = isl_dim_total(src->dim);
 
        if (!dst || !src)
                goto error;
@@ -3747,9 +4332,12 @@ struct isl_basic_map *isl_basic_map_align_divs(
        if (src->n_div == 0)
                return dst;
 
+       for (i = 0; i < src->n_div; ++i)
+               isl_assert(src->ctx, !isl_int_is_zero(src->div[i][0]), goto error);
+
        src = order_divs(src);
-       dst = isl_basic_map_extend(dst, dst->nparam, dst->n_in,
-                       dst->n_out, src->n_div, 0, 2 * src->n_div);
+       dst = isl_basic_map_extend_dim(dst, isl_dim_copy(dst->dim),
+                       src->n_div, 0, 2 * src->n_div);
        if (!dst)
                return NULL;
        for (i = 0; i < src->n_div; ++i) {
@@ -3758,9 +4346,8 @@ struct isl_basic_map *isl_basic_map_align_divs(
                        j = isl_basic_map_alloc_div(dst);
                        if (j < 0)
                                goto error;
-                       isl_seq_cpy(dst->div[j], src->div[i], 1+1+total);
-                       isl_seq_clr(dst->div[j]+1+1+total,
-                                                   dst->n_div - src->n_div);
+                       isl_seq_cpy(dst->div[j], src->div[i], 1+1+total+i);
+                       isl_seq_clr(dst->div[j]+1+1+total+i, dst->n_div - i);
                        if (add_div_constraints(dst, j) < 0)
                                goto error;
                }
@@ -3811,8 +4398,7 @@ static struct isl_map *add_cut_constraint(struct isl_map *dst,
        copy = isl_basic_map_cow(copy);
        if (!copy)
                goto error;
-       copy = isl_basic_map_extend(copy,
-               copy->nparam, copy->n_in, copy->n_out, 0, 0, 1);
+       copy = isl_basic_map_extend_constraints(copy, 0, 1);
        k = isl_basic_map_alloc_inequality(copy);
        if (k < 0)
                goto error;
@@ -3820,7 +4406,7 @@ static struct isl_map *add_cut_constraint(struct isl_map *dst,
                isl_seq_neg(copy->ineq[k], c, len);
        else
                isl_seq_cpy(copy->ineq[k], c, len);
-       total = 1 + copy->nparam + copy->n_in + copy->n_out + copy->n_div;
+       total = 1 + isl_basic_map_total_dim(copy);
        isl_seq_clr(copy->ineq[k]+len, total - len);
        isl_inequality_negate(copy, k);
        copy = isl_basic_map_simplify(copy);
@@ -3845,7 +4431,7 @@ static struct isl_map *subtract(struct isl_map *map, struct isl_basic_map *bmap)
        unsigned flags = 0;
        struct isl_map *rest = NULL;
        unsigned max;
-       unsigned total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       unsigned total = isl_basic_map_total_dim(bmap);
 
        assert(bmap);
 
@@ -3856,8 +4442,7 @@ static struct isl_map *subtract(struct isl_map *map, struct isl_basic_map *bmap)
                FL_SET(flags, ISL_MAP_DISJOINT);
 
        max = map->n * (2 * bmap->n_eq + bmap->n_ineq);
-       rest = isl_map_alloc(map->ctx, map->nparam, map->n_in, map->n_out,
-                               max, flags);
+       rest = isl_map_alloc_dim(isl_dim_copy(map->dim), max, flags);
        if (!rest)
                goto error;
 
@@ -3882,9 +4467,8 @@ static struct isl_map *subtract(struct isl_map *map, struct isl_basic_map *bmap)
                        if (!rest)
                                goto error;
 
-                       map->p[j] = isl_basic_map_extend(map->p[j],
-                               map->p[j]->nparam, map->p[j]->n_in,
-                               map->p[j]->n_out, 0, 1, 0);
+                       map->p[j] = isl_basic_map_extend_constraints(map->p[j],
+                               1, 0);
                        if (!map->p[j])
                                goto error;
                        k = isl_basic_map_alloc_equality(map->p[j]);
@@ -3903,9 +4487,8 @@ static struct isl_map *subtract(struct isl_map *map, struct isl_basic_map *bmap)
                        if (!rest)
                                goto error;
 
-                       map->p[j] = isl_basic_map_extend(map->p[j],
-                               map->p[j]->nparam, map->p[j]->n_in,
-                               map->p[j]->n_out, 0, 0, 1);
+                       map->p[j] = isl_basic_map_extend_constraints(map->p[j],
+                               0, 1);
                        if (!map->p[j])
                                goto error;
                        k = isl_basic_map_alloc_inequality(map->p[j]);
@@ -3931,9 +4514,7 @@ struct isl_map *isl_map_subtract(struct isl_map *map1, struct isl_map *map2)
        if (!map1 || !map2)
                goto error;
 
-       isl_assert(map1->ctx, map1->nparam == map2->nparam, goto error);
-       isl_assert(map1->ctx, map1->n_in == map2->n_in, goto error);
-       isl_assert(map1->ctx, map1->n_out == map2->n_out, goto error);
+       isl_assert(map1->ctx, isl_dim_equal(map1->dim, map2->dim), goto error);
 
        if (isl_map_is_empty(map2)) {
                isl_map_free(map2);
@@ -3967,7 +4548,7 @@ struct isl_set *isl_set_apply(struct isl_set *set, struct isl_map *map)
 {
        if (!set || !map)
                goto error;
-       isl_assert(set->ctx, set->dim == map->n_in, goto error);
+       isl_assert(set->ctx, isl_map_compatible_domain(map, set), goto error);
        map = isl_map_intersect_domain(map, set);
        set = isl_map_range(map);
        return set;
@@ -4060,11 +4641,14 @@ error:
 int isl_basic_set_compare_at(struct isl_basic_set *bset1,
        struct isl_basic_set *bset2, int pos)
 {
+       struct isl_dim *dims;
        struct isl_basic_map *bmap1 = NULL;
        struct isl_basic_map *bmap2 = NULL;
        struct isl_ctx *ctx;
        struct isl_vec *obj;
        unsigned total;
+       unsigned nparam;
+       unsigned dim1, dim2;
        isl_int num, den;
        enum isl_lp_result res;
        int cmp;
@@ -4072,27 +4656,29 @@ int isl_basic_set_compare_at(struct isl_basic_set *bset1,
        if (!bset1 || !bset2)
                return -2;
 
-       bmap1 = isl_basic_map_from_basic_set(isl_basic_set_copy(bset1),
-                                               pos, bset1->dim - pos);
-       bmap2 = isl_basic_map_from_basic_set(isl_basic_set_copy(bset2),
-                                               pos, bset2->dim - pos);
+       nparam = isl_basic_set_n_param(bset1);
+       dim1 = isl_basic_set_n_dim(bset1);
+       dim2 = isl_basic_set_n_dim(bset2);
+       dims = isl_dim_alloc(bset1->ctx, nparam, pos, dim1 - pos);
+       bmap1 = isl_basic_map_from_basic_set(isl_basic_set_copy(bset1), dims);
+       dims = isl_dim_alloc(bset2->ctx, nparam, pos, dim2 - pos);
+       bmap2 = isl_basic_map_from_basic_set(isl_basic_set_copy(bset2), dims);
        if (!bmap1 || !bmap2)
                goto error;
-       bmap1 = isl_basic_map_extend(bmap1, bmap1->nparam,
-                       bmap1->n_in, bmap1->n_out + bmap2->n_out,
+       bmap1 = isl_basic_map_extend(bmap1, nparam,
+                       pos, (dim1 - pos) + (dim2 - pos),
                        bmap2->n_div, bmap2->n_eq, bmap2->n_ineq);
+       bmap1 = add_constraints(bmap1, bmap2, 0, dim1 - pos);
        if (!bmap1)
                goto error;
-       total = bmap1->nparam + bmap1->n_in + bmap1->n_out + bmap1->n_div;
+       total = isl_basic_map_total_dim(bmap1);
        ctx = bmap1->ctx;
        obj = isl_vec_alloc(ctx, total);
        isl_seq_clr(obj->block.data, total);
-       isl_int_set_si(obj->block.data[bmap1->nparam+bmap1->n_in], 1);
-       isl_int_set_si(obj->block.data[bmap1->nparam+bmap1->n_in+
-                                       bmap1->n_out-bmap2->n_out], -1);
+       isl_int_set_si(obj->block.data[nparam+pos], 1);
+       isl_int_set_si(obj->block.data[nparam+pos+(dim1-pos)], -1);
        if (!obj)
                goto error;
-       bmap1 = add_constraints(bmap1, bmap2, 0, bmap1->n_out - bmap2->n_out);
        isl_int_init(num);
        isl_int_init(den);
        res = isl_solve_lp(bmap1, 0, obj->block.data, ctx->one, &num, &den);
@@ -4125,7 +4711,7 @@ static int isl_basic_map_fast_has_fixed_var(struct isl_basic_map *bmap,
 
        if (!bmap)
                return -1;
-       total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       total = isl_basic_map_total_dim(bmap);
        for (i = 0, d = total-1; i < bmap->n_eq && d+1 > pos; ++i) {
                for (; d+1 > pos; --d)
                        if (!isl_int_is_zero(bmap->eq[i][1+d]))
@@ -4185,7 +4771,7 @@ static int isl_set_fast_has_fixed_var(struct isl_set *set, unsigned pos,
  */
 int isl_set_fast_dim_is_fixed(struct isl_set *set, unsigned dim, isl_int *val)
 {
-       return isl_set_fast_has_fixed_var(set, set->nparam + dim, val);
+       return isl_set_fast_has_fixed_var(set, isl_set_n_param(set) + dim, val);
 }
 
 /* Check if input variable in has fixed value and if so and if val is not NULL,
@@ -4193,7 +4779,7 @@ int isl_set_fast_dim_is_fixed(struct isl_set *set, unsigned dim, isl_int *val)
  */
 int isl_map_fast_input_is_fixed(struct isl_map *map, unsigned in, isl_int *val)
 {
-       return isl_map_fast_has_fixed_var(map, map->nparam + in, val);
+       return isl_map_fast_has_fixed_var(map, isl_map_n_param(map) + in, val);
 }
 
 /* Check if dimension dim has an (obvious) fixed lower bound and if so
@@ -4205,19 +4791,21 @@ int isl_basic_set_fast_dim_has_fixed_lower_bound(struct isl_basic_set *bset,
        int i, i_eq = -1, i_ineq = -1;
        isl_int *c;
        unsigned total;
+       unsigned nparam;
 
        if (!bset)
                return -1;
-       total = bset->nparam + bset->dim + bset->n_div;
+       total = isl_basic_set_total_dim(bset);
+       nparam = isl_basic_set_n_param(bset);
        for (i = 0; i < bset->n_eq; ++i) {
-               if (isl_int_is_zero(bset->eq[i][1+bset->nparam+dim]))
+               if (isl_int_is_zero(bset->eq[i][1+nparam+dim]))
                        continue;
                if (i_eq != -1)
                        return 0;
                i_eq = i;
        }
        for (i = 0; i < bset->n_ineq; ++i) {
-               if (!isl_int_is_pos(bset->ineq[i][1+bset->nparam+dim]))
+               if (!isl_int_is_pos(bset->ineq[i][1+nparam+dim]))
                        continue;
                if (i_eq != -1 || i_ineq != -1)
                        return 0;
@@ -4227,12 +4815,12 @@ int isl_basic_set_fast_dim_has_fixed_lower_bound(struct isl_basic_set *bset,
                return 0;
        c = i_eq != -1 ? bset->eq[i_eq] : bset->ineq[i_ineq];
        /* The coefficient should always be one due to normalization. */
-       if (!isl_int_is_one(c[1+bset->nparam+dim]))
+       if (!isl_int_is_one(c[1+nparam+dim]))
                return 0;
-       if (isl_seq_first_non_zero(c+1, bset->nparam+dim) != -1)
+       if (isl_seq_first_non_zero(c+1, nparam+dim) != -1)
                return 0;
-       if (isl_seq_first_non_zero(c+1+bset->nparam+dim+1,
-                                       total - bset->nparam - dim - 1) != -1)
+       if (isl_seq_first_non_zero(c+1+nparam+dim+1,
+                                       total - nparam - dim - 1) != -1)
                return 0;
        if (val)
                isl_int_neg(*val, c[0]);
@@ -4284,7 +4872,7 @@ static struct isl_basic_set *isl_basic_set_reduce_using_equalities(
        if (!bset)
                goto error;
 
-       elim = isl_alloc_array(ctx, int, bset->dim);
+       elim = isl_alloc_array(ctx, int, isl_basic_set_n_dim(bset));
        if (!elim)
                goto error;
        set_compute_elimination_index(context, elim);
@@ -4346,6 +4934,60 @@ error:
        return bset;
 }
 
+static struct isl_basic_set *uset_gist(struct isl_basic_set *bset,
+       struct isl_basic_set *context);
+
+static struct isl_basic_set *uset_gist_context_eq(struct isl_basic_set *bset,
+       struct isl_basic_set *context)
+{
+       struct isl_mat *T;
+       struct isl_mat *T2;
+       struct isl_ctx *ctx = context->ctx;
+       struct isl_basic_set *reduced_context;
+       reduced_context = isl_basic_set_remove_equalities(
+                               isl_basic_set_copy(context), &T, &T2);
+       if (!reduced_context)
+               goto error;
+       bset = isl_basic_set_preimage(ctx, bset, T);
+       bset = uset_gist(bset, reduced_context);
+       bset = isl_basic_set_preimage(ctx, bset, T2);
+       bset = isl_basic_set_reduce_using_equalities(bset, context);
+       return bset;
+error:
+       isl_basic_set_free(context);
+       isl_basic_set_free(bset);
+       return NULL;
+}
+
+static struct isl_basic_set *uset_gist_set_eq(struct isl_basic_set *bset,
+       struct isl_basic_set *context)
+{
+       struct isl_mat *T;
+       struct isl_mat *T2;
+       struct isl_ctx *ctx = context->ctx;
+       struct isl_basic_set *affine_hull = NULL;
+
+       affine_hull = isl_basic_set_copy(bset);
+       affine_hull = isl_basic_set_cow(affine_hull);
+       if (!affine_hull)
+               goto error;
+       isl_basic_set_free_inequality(affine_hull, affine_hull->n_ineq);
+
+       bset = isl_basic_set_remove_equalities(bset, &T, &T2);
+       if (!bset)
+               goto error;
+       context = isl_basic_set_preimage(ctx, context, T);
+       bset = uset_gist(bset, context);
+       bset = isl_basic_set_preimage(ctx, bset, T2);
+       bset = isl_basic_set_intersect(bset, affine_hull);
+       return bset;
+error:
+       isl_basic_set_free(affine_hull);
+       isl_basic_set_free(context);
+       isl_basic_set_free(bset);
+       return NULL;
+}
+
 /* Remove all information from bset that is redundant in the context
  * of context.  In particular, equalities that are linear combinations
  * of those in context are removed.  Then the inequalities that are
@@ -4363,26 +5005,15 @@ static struct isl_basic_set *uset_gist(struct isl_basic_set *bset,
        if (!bset || !context)
                goto error;
 
-       if (context->n_eq > 0) {
-               struct isl_mat *T;
-               struct isl_mat *T2;
-               struct isl_ctx *ctx = context->ctx;
-               struct isl_basic_set *reduced_context;
-               reduced_context = isl_basic_set_remove_equalities(
-                                       isl_basic_set_copy(context), &T, &T2);
-               if (!reduced_context)
-                       goto error;
-               bset = isl_basic_set_preimage(ctx, bset, T);
-               bset = uset_gist(bset, reduced_context);
-               bset = isl_basic_set_preimage(ctx, bset, T2);
-               bset = isl_basic_set_reduce_using_equalities(bset, context);
-               return bset;
-       }
+       if (context->n_eq > 0)
+               return uset_gist_context_eq(bset, context);
        if (!context->n_ineq)
                goto done;
+       if (bset->n_eq > 0)
+               return uset_gist_set_eq(bset, context);
        bset = remove_shifted_constraints(bset, context);
-       combined = isl_basic_set_extend(isl_basic_set_copy(bset),
-                       0, bset->dim, 0, context->n_eq, context->n_ineq);
+       combined = isl_basic_set_extend_constraints(isl_basic_set_copy(bset),
+                       context->n_eq, context->n_ineq);
        context = set_add_constraints(combined, context, 0);
        if (!context)
                goto error;
@@ -4440,6 +5071,9 @@ error:
        return NULL;
 }
 
+/*
+ * Assumes context has no implicit divs.
+ */
 struct isl_map *isl_map_gist(struct isl_map *map, struct isl_basic_map *context)
 {
        int i;
@@ -4447,9 +5081,8 @@ struct isl_map *isl_map_gist(struct isl_map *map, struct isl_basic_map *context)
        map = isl_map_cow(map);
        if (!map || !context)
                return NULL;
-       isl_assert(map->ctx, map->nparam == context->nparam, goto error);
-       isl_assert(map->ctx, map->n_in == context->n_in, goto error);
-       isl_assert(map->ctx, map->n_out == context->n_out, goto error);
+       isl_assert(map->ctx, isl_dim_equal(map->dim, context->dim), goto error);
+       map = isl_map_compute_divs(map);
        for (i = 0; i < map->n; ++i)
                context = isl_basic_map_align_divs(context, map->p[i]);
        for (i = 0; i < map->n; ++i) {
@@ -4502,7 +5135,7 @@ static struct isl_basic_map *isl_basic_map_sort_constraints(
 
        if (!bmap)
                return NULL;
-       total = bmap->nparam + bmap->n_in + bmap->n_out + bmap->n_div;
+       total = isl_basic_map_total_dim(bmap);
        c = isl_alloc_array(bmap->ctx, struct constraint, bmap->n_ineq);
        if (!c)
                goto error;
@@ -4546,12 +5179,12 @@ static int isl_basic_map_fast_cmp(const struct isl_basic_map *bmap1,
 
        if (bmap1 == bmap2)
                return 0;
-       if (bmap1->nparam != bmap2->nparam)
-               return bmap1->nparam - bmap2->nparam;
-       if (bmap1->n_in != bmap2->n_in)
-               return bmap1->n_in - bmap2->n_in;
-       if (bmap1->n_out != bmap2->n_out)
-               return bmap1->n_out - bmap2->n_out;
+       if (isl_basic_map_n_param(bmap1) != isl_basic_map_n_param(bmap2))
+               return isl_basic_map_n_param(bmap1) - isl_basic_map_n_param(bmap2);
+       if (isl_basic_map_n_in(bmap1) != isl_basic_map_n_in(bmap2))
+               return isl_basic_map_n_out(bmap1) - isl_basic_map_n_out(bmap2);
+       if (isl_basic_map_n_out(bmap1) != isl_basic_map_n_out(bmap2))
+               return isl_basic_map_n_out(bmap1) - isl_basic_map_n_out(bmap2);
        if (F_ISSET(bmap1, ISL_BASIC_MAP_EMPTY) &&
            F_ISSET(bmap2, ISL_BASIC_MAP_EMPTY))
                return 0;
@@ -4565,7 +5198,7 @@ static int isl_basic_map_fast_cmp(const struct isl_basic_map *bmap1,
                return bmap1->n_ineq - bmap2->n_ineq;
        if (bmap1->n_div != bmap2->n_div)
                return bmap1->n_div - bmap2->n_div;
-       total = bmap1->nparam + bmap1->n_in + bmap1->n_out + bmap1->n_div;
+       total = isl_basic_map_total_dim(bmap1);
        for (i = 0; i < bmap1->n_eq; ++i) {
                cmp = isl_seq_cmp(bmap1->eq[i], bmap2->eq[i], 1+total);
                if (cmp)
@@ -4653,11 +5286,7 @@ int isl_map_fast_is_equal(struct isl_map *map1, struct isl_map *map2)
 
        if (map1 == map2)
                return 1;
-       if (map1->nparam != map2->nparam)
-               return 0;
-       if (map1->n_in != map2->n_in)
-               return 0;
-       if (map1->n_out != map2->n_out)
+       if (!isl_dim_equal(map1->dim, map2->dim))
                return 0;
 
        map1 = isl_map_copy(map1);
@@ -4733,15 +5362,16 @@ struct isl_basic_set *isl_basic_set_product(struct isl_basic_set_list *list)
                goto error;
        isl_assert(list->ctx, list->n > 0, goto error);
        isl_assert(list->ctx, list->p[0], goto error);
-       nparam = list->p[0]->nparam;
-       dim = list->p[0]->dim;
+       nparam = isl_basic_set_n_param(list->p[0]);
+       dim = isl_basic_set_n_dim(list->p[0]);
        extra = list->p[0]->n_div;
        n_eq = list->p[0]->n_eq;
        n_ineq = list->p[0]->n_ineq;
        for (i = 1; i < list->n; ++i) {
                isl_assert(list->ctx, list->p[i], goto error);
-               isl_assert(list->ctx, nparam == list->p[i]->nparam, goto error);
-               dim += list->p[i]->dim;
+               isl_assert(list->ctx,
+                   nparam == isl_basic_set_n_param(list->p[i]), goto error);
+               dim += isl_basic_set_n_dim(list->p[i]);
                extra += list->p[i]->n_div;
                n_eq += list->p[i]->n_eq;
                n_ineq += list->p[i]->n_ineq;
@@ -4754,7 +5384,7 @@ struct isl_basic_set *isl_basic_set_product(struct isl_basic_set_list *list)
        for (i = 0; i < list->n; ++i) {
                set_add_constraints(product,
                                        isl_basic_set_copy(list->p[i]), dim);
-               dim += list->p[i]->dim;
+               dim += isl_basic_set_n_dim(list->p[i]);
        }
        isl_basic_set_list_free(list);
        return product;
@@ -4776,7 +5406,7 @@ uint32_t isl_basic_set_get_hash(struct isl_basic_set *bset)
        bset = isl_basic_set_normalize(bset);
        if (!bset)
                return 0;
-       total = bset->nparam + bset->dim + bset->n_div;
+       total = isl_basic_set_total_dim(bset);
        isl_hash_byte(hash, bset->n_eq & 0xFF);
        for (i = 0; i < bset->n_eq; ++i) {
                uint32_t c_hash;
@@ -4814,7 +5444,7 @@ uint32_t isl_set_get_hash(struct isl_set *set)
        if (!set)
                return 0;
 
-       isl_hash_init(hash);
+       hash = isl_hash_init();
        for (i = 0; i < set->n; ++i) {
                uint32_t bset_hash;
                bset_hash = isl_basic_set_get_hash(set->p[i]);
@@ -4833,11 +5463,13 @@ uint32_t isl_set_get_hash(struct isl_set *set)
 int isl_basic_set_dim_is_unique(struct isl_basic_set *bset, unsigned dim)
 {
        int i;
+       unsigned nparam;
 
        if (!bset)
                return -1;
+       nparam = isl_basic_set_n_param(bset);
        for (i = 0; i < bset->n_eq; ++i)
-               if (!isl_int_is_zero(bset->eq[i][1 + bset->nparam + dim]))
+               if (!isl_int_is_zero(bset->eq[i][1 + nparam + dim]))
                        return 1;
        return 0;
 }