add isl_map_set_rational
[platform/upstream/isl.git] / isl_convex_hull.c
index 17212c3..8d02b7c 100644 (file)
@@ -7,28 +7,18 @@
  * Computerwetenschappen, Celestijnenlaan 200A, B-3001 Leuven, Belgium
  */
 
-#include "isl_lp.h"
-#include "isl_map.h"
-#include "isl_map_private.h"
-#include "isl_mat.h"
-#include "isl_set.h"
-#include "isl_seq.h"
+#include <isl_ctx_private.h>
+#include <isl_map_private.h>
+#include <isl/lp.h>
+#include <isl/map.h>
+#include <isl_mat_private.h>
+#include <isl/set.h>
+#include <isl/seq.h>
 #include "isl_equalities.h"
 #include "isl_tab.h"
 
 static struct isl_basic_set *uset_convex_hull_wrap_bounded(struct isl_set *set);
 
-static void swap_ineq(struct isl_basic_map *bmap, unsigned i, unsigned j)
-{
-       isl_int *t;
-
-       if (i != j) {
-               t = bmap->ineq[i];
-               bmap->ineq[i] = bmap->ineq[j];
-               bmap->ineq[j] = t;
-       }
-}
-
 /* Return 1 if constraint c is redundant with respect to the constraints
  * in bmap.  If c is a lower [upper] bound in some variable and bmap
  * does not have a lower [upper] bound in that variable, then c cannot
@@ -79,7 +69,7 @@ int isl_basic_set_constraint_is_redundant(struct isl_basic_set **bset,
                        (struct isl_basic_map **)bset, c, opt_n, opt_d);
 }
 
-/* Compute the convex hull of a basic map, by removing the redundant
+/* Remove redundant
  * constraints.  If the minimal value along the normal of a constraint
  * is the same if the constraint is removed, then the constraint is redundant.
  *
@@ -87,7 +77,8 @@ int isl_basic_set_constraint_is_redundant(struct isl_basic_set **bset,
  * corresponding equality and the checked if the dimension was that
  * of a facet.
  */
-struct isl_basic_map *isl_basic_map_convex_hull(struct isl_basic_map *bmap)
+__isl_give isl_basic_map *isl_basic_map_remove_redundancies(
+       __isl_take isl_basic_map *bmap)
 {
        struct isl_tab *tab;
 
@@ -103,7 +94,8 @@ struct isl_basic_map *isl_basic_map_convex_hull(struct isl_basic_map *bmap)
                return bmap;
 
        tab = isl_tab_from_basic_map(bmap);
-       tab = isl_tab_detect_implicit_equalities(tab);
+       if (isl_tab_detect_implicit_equalities(tab) < 0)
+               goto error;
        if (isl_tab_detect_redundant(tab) < 0)
                goto error;
        bmap = isl_basic_map_update_from_tab(bmap, tab);
@@ -117,10 +109,24 @@ error:
        return NULL;
 }
 
-struct isl_basic_set *isl_basic_set_convex_hull(struct isl_basic_set *bset)
+__isl_give isl_basic_set *isl_basic_set_remove_redundancies(
+       __isl_take isl_basic_set *bset)
 {
        return (struct isl_basic_set *)
-               isl_basic_map_convex_hull((struct isl_basic_map *)bset);
+               isl_basic_map_remove_redundancies((struct isl_basic_map *)bset);
+}
+
+/* Remove redundant constraints in each of the basic maps.
+ */
+__isl_give isl_map *isl_map_remove_redundancies(__isl_take isl_map *map)
+{
+       return isl_map_inline_foreach_basic_map(map,
+                                           &isl_basic_map_remove_redundancies);
+}
+
+__isl_give isl_set *isl_set_remove_redundancies(__isl_take isl_set *set)
+{
+       return isl_map_remove_redundancies(set);
 }
 
 /* Check if the set set is bound in the direction of the affine
@@ -171,47 +177,62 @@ error:
        return -1;
 }
 
-struct isl_basic_set *isl_basic_set_set_rational(struct isl_basic_set *bset)
+__isl_give isl_basic_map *isl_basic_map_set_rational(
+       __isl_take isl_basic_set *bmap)
 {
-       if (!bset)
+       if (!bmap)
                return NULL;
 
-       if (ISL_F_ISSET(bset, ISL_BASIC_MAP_RATIONAL))
-               return bset;
+       if (ISL_F_ISSET(bmap, ISL_BASIC_MAP_RATIONAL))
+               return bmap;
 
-       bset = isl_basic_set_cow(bset);
-       if (!bset)
+       bmap = isl_basic_map_cow(bmap);
+       if (!bmap)
                return NULL;
 
-       ISL_F_SET(bset, ISL_BASIC_MAP_RATIONAL);
+       ISL_F_SET(bmap, ISL_BASIC_MAP_RATIONAL);
 
-       return isl_basic_set_finalize(bset);
+       return isl_basic_map_finalize(bmap);
 }
 
-static struct isl_set *isl_set_set_rational(struct isl_set *set)
+__isl_give isl_basic_set *isl_basic_set_set_rational(
+       __isl_take isl_basic_set *bset)
+{
+       return isl_basic_map_set_rational(bset);
+}
+
+__isl_give isl_map *isl_map_set_rational(__isl_take isl_map *map)
 {
        int i;
 
-       set = isl_set_cow(set);
-       if (!set)
+       map = isl_map_cow(map);
+       if (!map)
                return NULL;
-       for (i = 0; i < set->n; ++i) {
-               set->p[i] = isl_basic_set_set_rational(set->p[i]);
-               if (!set->p[i])
+       for (i = 0; i < map->n; ++i) {
+               map->p[i] = isl_basic_map_set_rational(map->p[i]);
+               if (!map->p[i])
                        goto error;
        }
-       return set;
+       return map;
 error:
-       isl_set_free(set);
+       isl_map_free(map);
        return NULL;
 }
 
+__isl_give isl_set *isl_set_set_rational(__isl_take isl_set *set)
+{
+       return isl_map_set_rational(set);
+}
+
 static struct isl_basic_set *isl_basic_set_add_equality(
        struct isl_basic_set *bset, isl_int *c)
 {
        int i;
        unsigned dim;
 
+       if (!bset)
+               return NULL;
+
        if (ISL_F_ISSET(bset, ISL_BASIC_SET_EMPTY))
                return bset;
 
@@ -284,6 +305,7 @@ static struct isl_basic_set *wrap_constraints(struct isl_set *set)
                n_ineq += set->p[i]->n_ineq;
        }
        lp = isl_basic_set_alloc(set->ctx, 0, dim * set->n, 0, n_eq, n_ineq);
+       lp = isl_basic_set_set_rational(lp);
        if (!lp)
                return NULL;
        lp_dim = isl_basic_set_n_dim(lp);
@@ -377,6 +399,7 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
        isl_int *facet, isl_int *ridge)
 {
        int i;
+       isl_ctx *ctx;
        struct isl_mat *T = NULL;
        struct isl_basic_set *lp = NULL;
        struct isl_vec *obj;
@@ -384,11 +407,14 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
        isl_int num, den;
        unsigned dim;
 
+       if (!set)
+               return NULL;
+       ctx = set->ctx;
        set = isl_set_copy(set);
        set = isl_set_set_rational(set);
 
        dim = 1 + isl_set_n_dim(set);
-       T = isl_mat_alloc(set->ctx, 3, dim);
+       T = isl_mat_alloc(ctx, 3, dim);
        if (!T)
                goto error;
        isl_int_set_si(T->row[0][0], 1);
@@ -401,7 +427,7 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
        if (!set)
                goto error;
        lp = wrap_constraints(set);
-       obj = isl_vec_alloc(set->ctx, 1 + dim*set->n);
+       obj = isl_vec_alloc(ctx, 1 + dim*set->n);
        if (!obj)
                goto error;
        isl_int_set_si(obj->block.data[0], 0);
@@ -413,17 +439,20 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
        isl_int_init(num);
        isl_int_init(den);
        res = isl_basic_set_solve_lp(lp, 0,
-                           obj->block.data, set->ctx->one, &num, &den, NULL);
+                           obj->block.data, ctx->one, &num, &den, NULL);
        if (res == isl_lp_ok) {
                isl_int_neg(num, num);
                isl_seq_combine(facet, num, facet, den, ridge, dim);
+               isl_seq_normalize(ctx, facet, dim);
        }
        isl_int_clear(num);
        isl_int_clear(den);
        isl_vec_free(obj);
        isl_basic_set_free(lp);
        isl_set_free(set);
-       isl_assert(set->ctx, res == isl_lp_ok || res == isl_lp_unbounded, 
+       if (res == isl_lp_error)
+               return NULL;
+       isl_assert(ctx, res == isl_lp_ok || res == isl_lp_unbounded, 
                   return NULL);
        return facet;
 error:
@@ -450,7 +479,6 @@ static __isl_give isl_mat *initial_facet_constraint(__isl_keep isl_set *set)
 {
        struct isl_set *slice = NULL;
        struct isl_basic_set *face = NULL;
-       struct isl_mat *m, *U, *Q;
        int i;
        unsigned dim = isl_set_n_dim(set);
        int is_bound;
@@ -464,7 +492,9 @@ static __isl_give isl_mat *initial_facet_constraint(__isl_keep isl_set *set)
        isl_seq_clr(bounds->row[0], dim);
        isl_int_set_si(bounds->row[0][1 + dim - 1], 1);
        is_bound = uset_is_bound(set, bounds->row[0], 1 + dim);
-       isl_assert(set->ctx, is_bound == 1, goto error);
+       if (is_bound < 0)
+               goto error;
+       isl_assert(set->ctx, is_bound, goto error);
        isl_seq_normalize(set->ctx, bounds->row[0], 1 + dim);
        bounds->n_row = 1;
 
@@ -559,7 +589,8 @@ static struct isl_basic_set *compute_facet(struct isl_set *set, isl_int *c)
        set = isl_set_preimage(set, U);
        facet = uset_convex_hull_wrap_bounded(set);
        facet = isl_basic_set_preimage(facet, Q);
-       isl_assert(ctx, facet->n_eq == 0, goto error);
+       if (facet)
+               isl_assert(ctx, facet->n_eq == 0, goto error);
        return facet;
 error:
        isl_basic_set_free(facet);
@@ -613,11 +644,13 @@ static struct isl_basic_set *extend(struct isl_basic_set *hull,
                hull_facet = isl_basic_set_add_equality(hull_facet, hull->ineq[i]);
                hull_facet = isl_basic_set_gauss(hull_facet, NULL);
                hull_facet = isl_basic_set_normalize_constraints(hull_facet);
-               if (!facet)
+               if (!facet || !hull_facet)
                        goto error;
                hull = isl_basic_set_cow(hull);
                hull = isl_basic_set_extend_dim(hull,
                        isl_dim_copy(hull->dim), 0, 0, facet->n_ineq);
+               if (!hull)
+                       goto error;
                for (j = 0; j < facet->n_ineq; ++j) {
                        for (f = 0; f < hull_facet->n_ineq; ++f)
                                if (isl_seq_eq(facet->ineq[j],
@@ -769,13 +802,6 @@ error:
        return NULL;
 }
 
-/* Project out final n dimensions using Fourier-Motzkin */
-static struct isl_set *set_project_out(struct isl_ctx *ctx,
-       struct isl_set *set, unsigned n)
-{
-       return isl_set_remove_dims(set, isl_set_n_dim(set) - n, n);
-}
-
 static struct isl_basic_set *convex_hull_0d(struct isl_set *set)
 {
        struct isl_basic_set *convex_hull;
@@ -852,8 +878,8 @@ static struct isl_basic_set *convex_hull_pair_elim(struct isl_basic_set *bset1,
                isl_int_set_si(hull->eq[k][2*(1+dim)+j], 1);
        }
        hull = isl_basic_set_set_rational(hull);
-       hull = isl_basic_set_remove_dims(hull, dim, 2*(1+dim));
-       hull = isl_basic_set_convex_hull(hull);
+       hull = isl_basic_set_remove_dims(hull, isl_dim_set, dim, 2*(1+dim));
+       hull = isl_basic_set_remove_redundancies(hull);
        isl_basic_set_free(bset1);
        isl_basic_set_free(bset2);
        return hull;
@@ -864,26 +890,52 @@ error:
        return NULL;
 }
 
-static int isl_basic_set_is_bounded(struct isl_basic_set *bset)
+/* Is the set bounded for each value of the parameters?
+ */
+int isl_basic_set_is_bounded(__isl_keep isl_basic_set *bset)
 {
        struct isl_tab *tab;
        int bounded;
 
        if (!bset)
                return -1;
-       if (isl_basic_set_fast_is_empty(bset))
+       if (isl_basic_set_plain_is_empty(bset))
                return 1;
 
-       tab = isl_tab_from_recession_cone(bset);
+       tab = isl_tab_from_recession_cone(bset, 1);
        bounded = isl_tab_cone_is_bounded(tab);
        isl_tab_free(tab);
        return bounded;
 }
 
+/* Is the image bounded for each value of the parameters and
+ * the domain variables?
+ */
+int isl_basic_map_image_is_bounded(__isl_keep isl_basic_map *bmap)
+{
+       unsigned nparam = isl_basic_map_dim(bmap, isl_dim_param);
+       unsigned n_in = isl_basic_map_dim(bmap, isl_dim_in);
+       int bounded;
+
+       bmap = isl_basic_map_copy(bmap);
+       bmap = isl_basic_map_cow(bmap);
+       bmap = isl_basic_map_move_dims(bmap, isl_dim_param, nparam,
+                                       isl_dim_in, 0, n_in);
+       bounded = isl_basic_set_is_bounded((isl_basic_set *)bmap);
+       isl_basic_map_free(bmap);
+
+       return bounded;
+}
+
+/* Is the set bounded for each value of the parameters?
+ */
 int isl_set_is_bounded(__isl_keep isl_set *set)
 {
        int i;
 
+       if (!set)
+               return -1;
+
        for (i = 0; i < set->n; ++i) {
                int bounded = isl_basic_set_is_bounded(set->p[i]);
                if (!bounded || bounded < 0)
@@ -987,7 +1039,7 @@ static struct isl_basic_set *modulo_lineality(struct isl_set *set,
        if (!set || !lin)
                goto error;
        lin_dim = total - lin->n_eq;
-       M = isl_mat_sub_alloc(set->ctx, lin->eq, 0, lin->n_eq, 1, total);
+       M = isl_mat_sub_alloc6(set->ctx, lin->eq, 0, lin->n_eq, 1, total);
        M = isl_mat_left_hermite(M, 0, &U, &Q);
        if (!M)
                goto error;
@@ -1000,7 +1052,7 @@ static struct isl_basic_set *modulo_lineality(struct isl_set *set,
        Q = isl_mat_lin_to_aff(Q);
 
        set = isl_set_preimage(set, U);
-       set = isl_set_remove_dims(set, total - lin_dim, lin_dim);
+       set = isl_set_remove_dims(set, isl_dim_set, total - lin_dim, lin_dim);
        hull = uset_convex_hull(set);
        hull = isl_basic_set_preimage(hull, Q);
 
@@ -1051,23 +1103,25 @@ static struct isl_basic_set *valid_direction_lp(
                if (k < 0)
                        goto error;
                n = 0;
-               isl_int_set_si(lp->eq[k][n++], 0);
+               isl_int_set_si(lp->eq[k][n], 0); n++;
                /* positivity constraint 1 >= 0 */
-               isl_int_set_si(lp->eq[k][n++], i == 0);
+               isl_int_set_si(lp->eq[k][n], i == 0); n++;
                for (j = 0; j < bset1->n_eq; ++j) {
-                       isl_int_set(lp->eq[k][n++], bset1->eq[j][i]);
-                       isl_int_neg(lp->eq[k][n++], bset1->eq[j][i]);
+                       isl_int_set(lp->eq[k][n], bset1->eq[j][i]); n++;
+                       isl_int_neg(lp->eq[k][n], bset1->eq[j][i]); n++;
+               }
+               for (j = 0; j < bset1->n_ineq; ++j) {
+                       isl_int_set(lp->eq[k][n], bset1->ineq[j][i]); n++;
                }
-               for (j = 0; j < bset1->n_ineq; ++j)
-                       isl_int_set(lp->eq[k][n++], bset1->ineq[j][i]);
                /* positivity constraint 1 >= 0 */
-               isl_int_set_si(lp->eq[k][n++], -(i == 0));
+               isl_int_set_si(lp->eq[k][n], -(i == 0)); n++;
                for (j = 0; j < bset2->n_eq; ++j) {
-                       isl_int_neg(lp->eq[k][n++], bset2->eq[j][i]);
-                       isl_int_set(lp->eq[k][n++], bset2->eq[j][i]);
+                       isl_int_neg(lp->eq[k][n], bset2->eq[j][i]); n++;
+                       isl_int_set(lp->eq[k][n], bset2->eq[j][i]); n++;
+               }
+               for (j = 0; j < bset2->n_ineq; ++j) {
+                       isl_int_neg(lp->eq[k][n], bset2->ineq[j][i]); n++;
                }
-               for (j = 0; j < bset2->n_ineq; ++j)
-                       isl_int_neg(lp->eq[k][n++], bset2->ineq[j][i]);
        }
        lp = isl_basic_set_gauss(lp, NULL);
        isl_basic_set_free(bset1);
@@ -1127,7 +1181,7 @@ static struct isl_vec *valid_direction(
        isl_seq_clr(dir->block.data + 1, dir->size - 1);
        n = 1;
        /* positivity constraint 1 >= 0 */
-       isl_int_set(dir->block.data[0], sample->block.data[n++]);
+       isl_int_set(dir->block.data[0], sample->block.data[n]); n++;
        for (i = 0; i < bset1->n_eq; ++i) {
                isl_int_sub(sample->block.data[n],
                            sample->block.data[n], sample->block.data[n+1]);
@@ -1307,6 +1361,9 @@ static struct isl_basic_set *convex_hull_pair(struct isl_basic_set *bset1,
        isl_basic_set *lin, *aff;
        int bounded1, bounded2;
 
+       if (bset1->ctx->opt->convex == ISL_CONVEX_HULL_FM)
+               return convex_hull_pair_elim(bset1, bset2);
+
        aff = isl_set_affine_hull(isl_basic_set_union(isl_basic_set_copy(bset1),
                                                    isl_basic_set_copy(bset2)));
        if (!aff)
@@ -1615,7 +1672,7 @@ static struct isl_basic_set *common_constraints(struct isl_basic_set *hull,
 
        total = isl_dim_total(set->dim);
        for (i = 0; i < set->p[best]->n_ineq; ++i) {
-               constraints[i].c = isl_mat_sub_alloc(hull->ctx,
+               constraints[i].c = isl_mat_sub_alloc6(hull->ctx,
                        set->p[best]->ineq + i, 0, 1, 0, 1 + total);
                if (!constraints[i].c)
                        goto error;
@@ -1762,7 +1819,8 @@ static struct isl_basic_set *uset_convex_hull(struct isl_set *set)
        if (isl_set_n_dim(set) == 1)
                return convex_hull_1d(set);
 
-       if (isl_set_is_bounded(set))
+       if (isl_set_is_bounded(set) &&
+           set->ctx->opt->convex == ISL_CONVEX_HULL_WRAP)
                return uset_convex_hull_wrap(set);
 
        lin = uset_combined_lineality_space(isl_set_copy(set));
@@ -1791,6 +1849,9 @@ static struct isl_basic_set *uset_convex_hull_wrap_bounded(struct isl_set *set)
 {
        struct isl_basic_set *convex_hull = NULL;
 
+       if (!set)
+               goto error;
+
        if (isl_set_n_dim(set) == 0) {
                convex_hull = isl_basic_set_universe(isl_dim_copy(set->dim));
                isl_set_free(set);
@@ -1799,9 +1860,6 @@ static struct isl_basic_set *uset_convex_hull_wrap_bounded(struct isl_set *set)
        }
 
        set = isl_set_set_rational(set);
-
-       if (!set)
-               goto error;
        set = isl_set_coalesce(set);
        if (!set)
                goto error;
@@ -1874,6 +1932,8 @@ struct isl_basic_map *isl_map_convex_hull(struct isl_map *map)
 
        map = isl_map_detect_equalities(map);
        map = isl_map_align_divs(map);
+       if (!map)
+               goto error;
        model = isl_basic_map_copy(map->p[0]);
        set = isl_map_underlying_set(map);
        if (!set)
@@ -1890,6 +1950,8 @@ struct isl_basic_map *isl_map_convex_hull(struct isl_map *map)
        }
 
        convex_hull = isl_basic_map_overlying_set(bset, model);
+       if (!convex_hull)
+               return NULL;
 
        ISL_F_SET(convex_hull, ISL_BASIC_MAP_NO_IMPLICIT);
        ISL_F_SET(convex_hull, ISL_BASIC_MAP_ALL_EQUALITIES);
@@ -1907,6 +1969,19 @@ struct isl_basic_set *isl_set_convex_hull(struct isl_set *set)
                isl_map_convex_hull((struct isl_map *)set);
 }
 
+__isl_give isl_basic_map *isl_map_polyhedral_hull(__isl_take isl_map *map)
+{
+       isl_basic_map *hull;
+
+       hull = isl_map_convex_hull(map);
+       return isl_basic_map_remove_divs(hull);
+}
+
+__isl_give isl_basic_set *isl_set_polyhedral_hull(__isl_take isl_set *set)
+{
+       return (isl_basic_set *)isl_map_polyhedral_hull((isl_map *)set);
+}
+
 struct sh_data_entry {
        struct isl_hash_table   *table;
        struct isl_tab          *tab;
@@ -2262,7 +2337,7 @@ struct isl_basic_map *isl_map_simple_hull(struct isl_map *map)
        hull = isl_basic_map_overlying_set(bset, model);
 
        hull = isl_basic_map_intersect(hull, affine_hull);
-       hull = isl_basic_map_convex_hull(hull);
+       hull = isl_basic_map_remove_redundancies(hull);
        ISL_F_SET(hull, ISL_BASIC_MAP_NO_IMPLICIT);
        ISL_F_SET(hull, ISL_BASIC_MAP_ALL_EQUALITIES);