stoken: Implement new auth form to gather soft token information
[platform/upstream/openconnect.git] / http.c
diff --git a/http.c b/http.c
index ad49e5c..38fc9a5 100644 (file)
--- a/http.c
+++ b/http.c
@@ -1,7 +1,7 @@
 /*
  * OpenConnect (SSL + DTLS) VPN client
  *
- * Copyright © 2008-2010 Intel Corporation.
+ * Copyright © 2008-2012 Intel Corporation.
  * Copyright © 2008 Nick Andrew <nick@nick-andrew.net>
  *
  * Author: David Woodhouse <dwmw2@infradead.org>
@@ -23,7 +23,6 @@
  *   Boston, MA 02110-1301 USA
  */
 
-#define _GNU_SOURCE
 #include <netdb.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <pwd.h>
 #include <sys/stat.h>
 #include <sys/types.h>
-
-#include <openssl/ssl.h>
-#include <openssl/err.h>
-#include <openssl/engine.h>
+#include <errno.h>
+#include <stdlib.h>
+#include <stdio.h>
 
 #include "openconnect-internal.h"
 
-static int proxy_write(int fd, unsigned char *buf, size_t len);
+static int proxy_write(struct openconnect_info *vpninfo, int fd,
+                      unsigned char *buf, size_t len);
+static int proxy_read(struct openconnect_info *vpninfo, int fd,
+                     unsigned char *buf, size_t len);
 
 #define MAX_BUF_LEN 131072
 /*
@@ -59,7 +60,8 @@ static int http_add_cookie(struct openconnect_info *vpninfo,
        if (*value) {
                new = malloc(sizeof(*new));
                if (!new) {
-                       vpn_progress(vpninfo, PRG_ERR, "No memory for allocating cookies\n");
+                       vpn_progress(vpninfo, PRG_ERR,
+                                    _("No memory for allocating cookies\n"));
                        return -ENOMEM;
                }
                new->next = NULL;
@@ -112,8 +114,9 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
        int i;
 
  cont:
-       if (openconnect_SSL_gets(vpninfo->https_ssl, buf, sizeof(buf)) < 0) {
-               vpn_progress(vpninfo, PRG_ERR, "Error fetching HTTPS response\n");
+       if (openconnect_SSL_gets(vpninfo, buf, sizeof(buf)) < 0) {
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Error fetching HTTPS response\n"));
                return -EINVAL;
        }
 
@@ -121,24 +124,27 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                closeconn = 1;
        
        if ((!closeconn && strncmp(buf, "HTTP/1.1 ", 9)) || !(*result = atoi(buf+9))) {
-               vpn_progress(vpninfo, PRG_ERR, "Failed to parse HTTP response '%s'\n", buf);
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to parse HTTP response '%s'\n"), buf);
                return -EINVAL;
        }
 
        vpn_progress(vpninfo, (*result==200)?PRG_TRACE:PRG_INFO,
-                         "Got HTTP response: %s\n", buf);
+                    _("Got HTTP response: %s\n"), buf);
 
        /* Eat headers... */
-       while ((i = openconnect_SSL_gets(vpninfo->https_ssl, buf, sizeof(buf)))) {
+       while ((i = openconnect_SSL_gets(vpninfo, buf, sizeof(buf)))) {
                char *colon;
 
                if (i < 0) {
-                       vpn_progress(vpninfo, PRG_ERR, "Error processing HTTP response\n");
+                       vpn_progress(vpninfo, PRG_ERR,
+                                    _("Error processing HTTP response\n"));
                        return -EINVAL;
                }
                colon = strchr(buf, ':');
                if (!colon) {
-                       vpn_progress(vpninfo, PRG_ERR, "Ignoring unknown HTTP response line '%s'\n", buf);
+                       vpn_progress(vpninfo, PRG_ERR,
+                                    _("Ignoring unknown HTTP response line '%s'\n"), buf);
                        continue;
                }
                *(colon++) = 0;
@@ -157,7 +163,8 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                                *semicolon = 0;
 
                        if (!equals) {
-                               vpn_progress(vpninfo, PRG_ERR, "Invalid cookie offered: %s\n", buf);
+                               vpn_progress(vpninfo, PRG_ERR,
+                                            _("Invalid cookie offered: %s\n"), buf);
                                return -EINVAL;
                        }
                        *(equals++) = 0;
@@ -166,10 +173,17 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                        /* Don't print the webvpn cookie unless it's empty; we don't
                           want people posting it in public with debugging output */
                        if (!strcmp(colon, "webvpn") && *equals)
-                               print_equals = "<elided>";
+                               print_equals = _("<elided>");
                        vpn_progress(vpninfo, PRG_TRACE, "%s: %s=%s%s%s\n",
-                                         buf, colon, print_equals, semicolon?";":"",
-                                         semicolon?(semicolon+1):"");
+                                    buf, colon, print_equals, semicolon?";":"",
+                                    semicolon?(semicolon+1):"");
+
+                       /* The server tends to ask for the username and password as
+                          usual, even if we've already failed because it didn't like
+                          our cert. Thankfully it does give us this hint... */
+                       if (!strcmp(colon, "ClientCertAuthFailed"))
+                               vpn_progress(vpninfo, PRG_ERR,
+                                            _("SSL certificate authentication failed\n"));
 
                        ret = http_add_cookie(vpninfo, colon, equals);
                        if (ret)
@@ -199,8 +213,9 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                if (!strcasecmp(buf, "Content-Length")) {
                        bodylen = atoi(colon);
                        if (bodylen < 0) {
-                               vpn_progress(vpninfo, PRG_ERR, "Response body has negative size (%d)\n",
-                                                 bodylen);
+                               vpn_progress(vpninfo, PRG_ERR,
+                                            _("Response body has negative size (%d)\n"),
+                                            bodylen);
                                return -EINVAL;
                        }
                }
@@ -208,7 +223,9 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                        if (!strcasecmp(colon, "chunked"))
                                bodylen = BODY_CHUNKED;
                        else {
-                               vpn_progress(vpninfo, PRG_ERR, "Unknown Transfer-Encoding: %s\n", colon);
+                               vpn_progress(vpninfo, PRG_ERR,
+                                            _("Unknown Transfer-Encoding: %s\n"),
+                                            colon);
                                return -EINVAL;
                        }
                }
@@ -221,10 +238,10 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                goto cont;
 
        /* Now the body, if there is one */
-       vpn_progress(vpninfo, PRG_TRACE, "HTTP body %s (%d)\n"
-                         bodylen==BODY_HTTP10?"http 1.0" :
-                         bodylen==BODY_CHUNKED?"chunked" : "length: ",
-                         bodylen);
+       vpn_progress(vpninfo, PRG_TRACE, _("HTTP body %s (%d)\n")
+                    bodylen==BODY_HTTP10?"http 1.0" :
+                    bodylen==BODY_CHUNKED?"chunked" : "length: ",
+                    bodylen);
 
        /* If we were given Content-Length, it's nice and easy... */
        if (bodylen > 0) {
@@ -232,9 +249,10 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                if (!body)
                        return -ENOMEM;
                while (done < bodylen) {
-                       i = SSL_read(vpninfo->https_ssl, body + done, bodylen - done);
+                       i = openconnect_SSL_read(vpninfo, body + done, bodylen - done);
                        if (i < 0) {
-                               vpn_progress(vpninfo, PRG_ERR, "Error reading HTTP response body\n");
+                               vpn_progress(vpninfo, PRG_ERR,
+                                            _("Error reading HTTP response body\n"));
                                 free(body);
                                return -EINVAL;
                        }
@@ -242,12 +260,13 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                }
        } else if (bodylen == BODY_CHUNKED) {
                /* ... else, chunked */
-               while ((i = openconnect_SSL_gets(vpninfo->https_ssl, buf, sizeof(buf)))) {
+               while ((i = openconnect_SSL_gets(vpninfo, buf, sizeof(buf)))) {
                        int chunklen, lastchunk = 0;
 
                        if (i < 0) {
-                               vpn_progress(vpninfo, PRG_ERR, "Error fetching chunk header\n");
-                               exit(1);
+                               vpn_progress(vpninfo, PRG_ERR,
+                                            _("Error fetching chunk header\n"));
+                               return i;
                        }
                        chunklen = strtol(buf, NULL, 16);
                        if (!chunklen) {
@@ -258,9 +277,10 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                        if (!body)
                                return -ENOMEM;
                        while (chunklen) {
-                               i = SSL_read(vpninfo->https_ssl, body + done, chunklen);
+                               i = openconnect_SSL_read(vpninfo, body + done, chunklen);
                                if (i < 0) {
-                                       vpn_progress(vpninfo, PRG_ERR, "Error reading HTTP response body\n");
+                                       vpn_progress(vpninfo, PRG_ERR,
+                                                    _("Error reading HTTP response body\n"));
                                         free(body);
                                        return -EINVAL;
                                }
@@ -268,12 +288,14 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                                done += i;
                        }
                skip:
-                       if ((i = openconnect_SSL_gets(vpninfo->https_ssl, buf, sizeof(buf)))) {
+                       if ((i = openconnect_SSL_gets(vpninfo, buf, sizeof(buf)))) {
                                if (i < 0) {
-                                       vpn_progress(vpninfo, PRG_ERR, "Error fetching HTTP response body\n");
+                                       vpn_progress(vpninfo, PRG_ERR,
+                                                    _("Error fetching HTTP response body\n"));
                                } else {
-                                       vpn_progress(vpninfo, PRG_ERR, "Error in chunked decoding. Expected '', got: '%s'",
-                                                         buf);
+                                       vpn_progress(vpninfo, PRG_ERR,
+                                                    _("Error in chunked decoding. Expected '', got: '%s'"),
+                                                    buf);
                                }
                                 free(body);
                                return -EINVAL;
@@ -284,7 +306,8 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                }
        } else if (bodylen == BODY_HTTP10) {
                if (!closeconn) {
-                       vpn_progress(vpninfo, PRG_ERR, "Cannot receive HTTP 1.0 body without closing connection\n");
+                       vpn_progress(vpninfo, PRG_ERR,
+                                    _("Cannot receive HTTP 1.0 body without closing connection\n"));
                        return -EINVAL;
                }
 
@@ -293,23 +316,26 @@ static int process_http_response(struct openconnect_info *vpninfo, int *result,
                        body = realloc(body, done + 16384);
                        if (!body)
                                return -ENOMEM;
-                       i = SSL_read(vpninfo->https_ssl, body + done, 16384);
-                       if (i <= 0) {
+                       i = openconnect_SSL_read(vpninfo, body + done, 16384);
+                       if (i > 0) {
+                               /* Got more data */
+                               done += i;
+                       } else if (i < 0) {
+                               /* Error */
+                               free(body);
+                               return i;
+                       } else {
+                               /* Connection closed. Reduce allocation to just what we need */
                                body = realloc(body, done + 1);
                                if (!body)
                                        return -ENOMEM;
                                break;
                         }
-                       done += i;
                }
        }
 
-       if (closeconn || vpninfo->no_http_keepalive) {
-               SSL_free(vpninfo->https_ssl);
-               vpninfo->https_ssl = NULL;
-               close(vpninfo->ssl_fd);
-               vpninfo->ssl_fd = -1;
-       }
+       if (closeconn || vpninfo->no_http_keepalive)
+               openconnect_close_https(vpninfo, 0);
 
        if (body)
                body[done] = 0;
@@ -324,11 +350,17 @@ static int fetch_config(struct openconnect_info *vpninfo, char *fu, char *bu,
        char buf[MAX_BUF_LEN];
        char *config_buf = NULL;
        int result, buflen;
-       unsigned char local_sha1_bin[SHA_DIGEST_LENGTH];
-       char local_sha1_ascii[(SHA_DIGEST_LENGTH * 2)+1];
-       EVP_MD_CTX c;
+       unsigned char local_sha1_bin[SHA1_SIZE];
+       char local_sha1_ascii[(SHA1_SIZE * 2)+1];
        int i;
 
+       if (openconnect_open_https(vpninfo)) {
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to open HTTPS connection to %s\n"),
+                            vpninfo->hostname);
+               return -EINVAL;
+       }
+
        sprintf(buf, "GET %s%s HTTP/1.1\r\n", fu, bu);
        sprintf(buf + strlen(buf), "Host: %s\r\n", vpninfo->hostname);
        sprintf(buf + strlen(buf),  "User-Agent: %s\r\n", vpninfo->useragent);
@@ -343,7 +375,11 @@ static int fetch_config(struct openconnect_info *vpninfo, char *fu, char *bu,
        }
        sprintf(buf + strlen(buf),  "X-Transcend-Version: 1\r\n\r\n");
 
-       SSL_write(vpninfo->https_ssl, buf, strlen(buf));
+       if (openconnect_SSL_write(vpninfo, buf, strlen(buf)) != strlen(buf)) {
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to send GET request for new config\n"));
+               return -EIO;
+       }
 
        buflen = process_http_response(vpninfo, &result, NULL, &config_buf);
        if (buflen < 0) {
@@ -356,15 +392,14 @@ static int fetch_config(struct openconnect_info *vpninfo, char *fu, char *bu,
                return -EINVAL;
        }
 
-       EVP_MD_CTX_init(&c);
-       EVP_Digest(config_buf, buflen, local_sha1_bin, NULL, EVP_sha1(), NULL);
-       EVP_MD_CTX_cleanup(&c);
+       openconnect_sha1(local_sha1_bin, config_buf, buflen);
 
-       for (i = 0; i < SHA_DIGEST_LENGTH; i++)
+       for (i = 0; i < SHA1_SIZE; i++)
                sprintf(&local_sha1_ascii[i*2], "%02x", local_sha1_bin[i]);
 
        if (strcasecmp(server_sha1, local_sha1_ascii)) {
-               vpn_progress(vpninfo, PRG_ERR, "Downloaded config file did not match intended SHA1\n");
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Downloaded config file did not match intended SHA1\n"));
                free(config_buf);
                return -EINVAL;
        }
@@ -381,68 +416,68 @@ static int run_csd_script(struct openconnect_info *vpninfo, char *buf, int bufle
 
        if (!vpninfo->uid_csd_given && !vpninfo->csd_wrapper) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Error: Server asked us to download and run a 'Cisco Secure Desktop' trojan.\n"
-                                 "This facility is disabled by default for security reasons, so you may wish to enable it.");
+                            _("Error: Server asked us to download and run a 'Cisco Secure Desktop' trojan.\n"
+                              "This facility is disabled by default for security reasons, so you may wish to enable it."));
                return -EPERM;
        }
 
 #ifndef __linux__
        vpn_progress(vpninfo, PRG_INFO,
-                         "Trying to run Linux CSD trojan script.");
+                    _("Trying to run Linux CSD trojan script."));
 #endif
 
        sprintf(fname, "/tmp/csdXXXXXX");
        fd = mkstemp(fname);
        if (fd < 0) {
                int err = -errno;
-               vpn_progress(vpninfo, PRG_ERR, "Failed to open temporary CSD script file: %s\n",
-                                 strerror(errno));
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to open temporary CSD script file: %s\n"),
+                            strerror(errno));
                return err;
        }
 
-       ret = proxy_write(fd, (void *)buf, buflen);
+       ret = proxy_write(vpninfo, fd, (void *)buf, buflen);
        if (ret) {
-               vpn_progress(vpninfo, PRG_ERR, "Failed to write temporary CSD script file: %s\n",
-                                 strerror(ret));
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to write temporary CSD script file: %s\n"),
+                            strerror(-ret));
                return ret;
        }
        fchmod(fd, 0755);
        close(fd);
 
        if (!fork()) {
-               X509 *scert = SSL_get_peer_certificate(vpninfo->https_ssl);
-               X509 *ccert = SSL_get_certificate(vpninfo->https_ssl);
-               char scertbuf[EVP_MAX_MD_SIZE * 2 + 1];
-               char ccertbuf[EVP_MAX_MD_SIZE * 2 + 1];
+               char scertbuf[MD5_SIZE * 2 + 1];
+               char ccertbuf[MD5_SIZE * 2 + 1];
                char *csd_argv[32];
                int i = 0;
 
-               if (vpninfo->uid_csd != getuid()) {
+               if (vpninfo->uid_csd_given && vpninfo->uid_csd != getuid()) {
                        struct passwd *pw;
 
                        if (setuid(vpninfo->uid_csd)) {
-                               fprintf(stderr, "Failed to set uid %d\n",
-                                       vpninfo->uid_csd);
+                               fprintf(stderr, _("Failed to set uid %ld\n"),
+                                       (long)vpninfo->uid_csd);
                                exit(1);
                        }
                        if (!(pw = getpwuid(vpninfo->uid_csd))) {
-                               fprintf(stderr, "Invalid user uid=%d\n",
-                                       vpninfo->uid_csd);
+                               fprintf(stderr, _("Invalid user uid=%ld\n"),
+                                       (long)vpninfo->uid_csd);
                                exit(1);
                        }
                        setenv("HOME", pw->pw_dir, 1);
                        if (chdir(pw->pw_dir)) {
-                               fprintf(stderr, "Failed to change to CSD home directory '%s': %s\n",
+                               fprintf(stderr, _("Failed to change to CSD home directory '%s': %s\n"),
                                        pw->pw_dir, strerror(errno));
                                exit(1);
                        }
                }
-               if (vpninfo->uid_csd == 0 && !vpninfo->csd_wrapper) {
-                       fprintf(stderr, "Warning: you are running insecure "
-                               "CSD code with root privileges\n"
-                               "\t Use command line option \"--csd-user\"\n");
+               if (getuid() == 0 && !vpninfo->csd_wrapper) {
+                       fprintf(stderr, _("Warning: you are running insecure "
+                                         "CSD code with root privileges\n"
+                                         "\t Use command line option \"--csd-user\"\n"));
                }
-               if (vpninfo->uid_csd_given == 2) {             
+               if (vpninfo->uid_csd_given == 2) {
                        /* The NM tool really needs not to get spurious output
                           on stdout, which the CSD trojan spews. */
                        dup2(2, 1);
@@ -459,32 +494,23 @@ static int run_csd_script(struct openconnect_info *vpninfo, char *buf, int bufle
                if (asprintf(&csd_argv[i++], "\"%s\"", vpninfo->authgroup?:"") == -1)
                        return -ENOMEM;
 
-               get_cert_md5_fingerprint(vpninfo, scert, scertbuf);
-               if (ccert)
-                       get_cert_md5_fingerprint(vpninfo, ccert, ccertbuf);
-               else
-                       ccertbuf[0] = 0;
-
+               openconnect_local_cert_md5(vpninfo, ccertbuf);
+               scertbuf[0] = 0;
+               get_cert_md5_fingerprint(vpninfo, vpninfo->peer_cert, scertbuf);
                csd_argv[i++]= (char *)"-certhash";
                if (asprintf(&csd_argv[i++], "\"%s:%s\"", scertbuf, ccertbuf) == -1)
                        return -ENOMEM;
+
                csd_argv[i++]= (char *)"-url";
                if (asprintf(&csd_argv[i++], "\"https://%s%s\"", vpninfo->hostname, vpninfo->csd_starturl) == -1)
                        return -ENOMEM;
-               /* WTF would it want to know this for? */
-               csd_argv[i++]= (char *)"-vpnclient";
-               csd_argv[i++]= (char *)"\"/opt/cisco/vpn/bin/vpnui";
-               csd_argv[i++]= (char *)"-connect";
-               if (asprintf(&csd_argv[i++], "https://%s/%s", vpninfo->hostname, vpninfo->csd_preurl) == -1)
-                       return -ENOMEM;
-               csd_argv[i++]= (char *)"-connectparam";
-               if (asprintf(&csd_argv[i++], "#csdtoken=%s\"", vpninfo->csd_token) == -1)
-                       return -ENOMEM;
+
                csd_argv[i++]= (char *)"-langselen";
                csd_argv[i++] = NULL;
 
                execv(csd_argv[0], csd_argv);
-               vpn_progress(vpninfo, PRG_ERR, "Failed to exec CSD script %s\n", csd_argv[0]);
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to exec CSD script %s\n"), csd_argv[0]);
                exit(1);
        }
 
@@ -500,27 +526,6 @@ static int run_csd_script(struct openconnect_info *vpninfo, char *buf, int bufle
        return 0;
 }
 
-#ifdef __sun__
-char *local_strcasestr(const char *haystack, const char *needle)
-{
-       int hlen = strlen(haystack);
-       int nlen = strlen(needle);
-       int i, j;
-
-       for (i = 0; i < hlen - nlen + 1; i++) {
-               for (j = 0; j < nlen; j++) {
-                       if (tolower(haystack[i + j]) != 
-                           tolower(needle[j]))
-                               break;
-               }
-               if (j == nlen)
-                       return (char *)haystack + i;
-       }
-       return NULL;
-}
-#define strcasestr local_strcasestr
-#endif
-
 int internal_parse_url(char *url, char **res_proto, char **res_host,
                       int *res_port, char **res_path, int default_port)
 {
@@ -577,6 +582,8 @@ int internal_parse_url(char *url, char **res_proto, char **res_host,
                *res_path = (path && *path) ? strdup(path) : NULL;
 
        /* Undo the damage we did to the original string */
+       if (port_str)
+               *(port_str) = ':';
        if (path)
                *(path - 1) = '/';
        if (proto)
@@ -586,8 +593,8 @@ int internal_parse_url(char *url, char **res_proto, char **res_host,
 
 /* Return value:
  *  < 0, on error
- *  = 0, no cookie (user cancel)
- *  = 1, obtained cookie
+ *  > 0, no cookie (user cancel)
+ *  = 0, obtained cookie
  */
 int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
 {
@@ -599,14 +606,21 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
        const char *request_body_type = NULL;
        const char *method = "GET";
 
+       if (vpninfo->use_stoken) {
+               result = prepare_stoken(vpninfo);
+               if (result)
+                       return result;
+       }
+
  retry:
        if (form_buf) {
                free(form_buf);
                form_buf = NULL;
        }
-       if (!vpninfo->https_ssl && openconnect_open_https(vpninfo)) {
-               vpn_progress(vpninfo, PRG_ERR, "Failed to open HTTPS connection to %s\n",
-                       vpninfo->hostname);
+       if (openconnect_open_https(vpninfo)) {
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to open HTTPS connection to %s\n"),
+                            vpninfo->hostname);
                return -EINVAL;
        }
 
@@ -643,19 +657,21 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
 
        if (vpninfo->port == 443)
                vpn_progress(vpninfo, PRG_INFO, "%s https://%s/%s\n",
-                                 method, vpninfo->hostname,
-                                 vpninfo->urlpath ?: "");
+                            method, vpninfo->hostname,
+                            vpninfo->urlpath ?: "");
        else
                vpn_progress(vpninfo, PRG_INFO, "%s https://%s:%d/%s\n",
-                                 method, vpninfo->hostname, vpninfo->port,
-                                 vpninfo->urlpath ?: "");
+                            method, vpninfo->hostname, vpninfo->port,
+                            vpninfo->urlpath ?: "");
 
-       SSL_write(vpninfo->https_ssl, buf, strlen(buf));
+       result = openconnect_SSL_write(vpninfo, buf, strlen(buf));
+       if (result < 0)
+               return result;
 
        buflen = process_http_response(vpninfo, &result, NULL, &form_buf);
        if (buflen < 0) {
                /* We'll already have complained about whatever offended us */
-               exit(1);
+               return buflen;
        }
 
        if (result != 200 && vpninfo->redirect_url) {
@@ -671,9 +687,11 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
 
                        ret = internal_parse_url(vpninfo->redirect_url, NULL, &host, &port, &vpninfo->urlpath, 0);
                        if (ret) {
-                               vpn_progress(vpninfo, PRG_ERR, "Failed to parse redirected URL '%s': %s\n",
-                                                 vpninfo->redirect_url, strerror(-ret));
+                               vpn_progress(vpninfo, PRG_ERR,
+                                            _("Failed to parse redirected URL '%s': %s\n"),
+                                            vpninfo->redirect_url, strerror(-ret));
                                free(vpninfo->redirect_url);
+                               vpninfo->redirect_url = NULL;
                                free(form_buf);
                                return ret;
                        }
@@ -686,12 +704,7 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
                                /* Kill the existing connection, and a new one will happen */
                                free(vpninfo->peer_addr);
                                vpninfo->peer_addr = NULL;
-                               if (vpninfo->https_ssl) {
-                                       SSL_free(vpninfo->https_ssl);
-                                       vpninfo->https_ssl = NULL;
-                                       close(vpninfo->ssl_fd);
-                                       vpninfo->ssl_fd = -1;
-                               }
+                               openconnect_close_https(vpninfo, 0);
 
                                for (opt = vpninfo->cookies; opt; opt = next) {
                                        next = opt->next;
@@ -708,6 +721,14 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
                        vpninfo->redirect_url = NULL;
 
                        goto retry;
+               } else if (strstr(vpninfo->redirect_url, "://")) {
+                       vpn_progress(vpninfo, PRG_ERR,
+                                    _("Cannot follow redirection to non-https URL '%s'\n"),
+                                    vpninfo->redirect_url);
+                       free(vpninfo->redirect_url);
+                       vpninfo->redirect_url = NULL;
+                       free(form_buf);
+                       return -EINVAL;
                } else if (vpninfo->redirect_url[0] == '/') {
                        /* Absolute redirect within same host */
                        free(vpninfo->urlpath);
@@ -731,8 +752,8 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
                                             oldurl, vpninfo->redirect_url) == -1) {
                                        int err = -errno;
                                        vpn_progress(vpninfo, PRG_ERR,
-                                                         "Allocating new path for relative redirect failed: %s\n",
-                                                         strerror(-err));
+                                                    _("Allocating new path for relative redirect failed: %s\n"),
+                                                    strerror(-err));
                                        return err;
                                }
                                free(oldurl);
@@ -744,8 +765,8 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
        }
        if (!form_buf || result != 200) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Unexpected %d result from server\n",
-                                 result);
+                            _("Unexpected %d result from server\n"),
+                            result);
                free(form_buf);
                return -EINVAL;
        }
@@ -763,12 +784,14 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
        if (strncmp(form_buf, "<?xml", 5)) {
                /* Not XML? Perhaps it's HTML with a refresh... */
                if (strcasestr(form_buf, "http-equiv=\"refresh\"")) {
-                       vpn_progress(vpninfo, PRG_INFO, "Refreshing %s after 1 second...\n",
-                                         vpninfo->urlpath);
+                       vpn_progress(vpninfo, PRG_INFO,
+                                    _("Refreshing %s after 1 second...\n"),
+                                    vpninfo->urlpath);
                        sleep(1);
                        goto retry;
                }
-               vpn_progress(vpninfo, PRG_ERR, "Unknown response from server\n");
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Unknown response from server\n"));
                free(form_buf);
                return -EINVAL;
        }
@@ -805,7 +828,7 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
                                        fu = tok + 3;
                                else if (!strncmp(tok, "fh:", 3)) {
                                        if (!strncasecmp(tok+3, vpninfo->xmlsha1,
-                                                        SHA_DIGEST_LENGTH * 2))
+                                                        SHA1_SIZE * 2))
                                                break;
                                        sha = tok + 3;
                                }
@@ -823,17 +846,18 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
        return 0;
 }
 
-char *openconnect_create_useragent(char *base)
+char *openconnect_create_useragent(const char *base)
 {
        char *uagent;
 
-       if (asprintf(&uagent, "%s %s", base, openconnect_version) < 0)
+       if (asprintf(&uagent, "%s %s", base, openconnect_version_str) < 0)
                return NULL;
 
        return uagent;
 }
 
-static int proxy_gets(int fd, char *buf, size_t len)
+static int proxy_gets(struct openconnect_info *vpninfo, int fd,
+                     char *buf, size_t len)
 {
        int i = 0;
        int ret;
@@ -841,7 +865,7 @@ static int proxy_gets(int fd, char *buf, size_t len)
        if (len < 2)
                return -EINVAL;
 
-       while ( (ret = read(fd, buf + i, 1)) == 1) {
+       while ( (ret = proxy_read(vpninfo, fd, (void *)(buf + i), 1)) == 0) {
                if (buf[i] == '\n') {
                        buf[i] = 0;
                        if (i && buf[i-1] == '\r') {
@@ -857,19 +881,39 @@ static int proxy_gets(int fd, char *buf, size_t len)
                        return i;
                }
        }
-       if (ret < 0)
-               ret = -errno;
-
        buf[i] = 0;
        return i ?: ret;
 }
 
-static int proxy_write(int fd, unsigned char *buf, size_t len)
+static int proxy_write(struct openconnect_info *vpninfo, int fd,
+                      unsigned char *buf, size_t len)
 {
        size_t count;
-       
+
        for (count = 0; count < len; ) {
-               int i = write(fd, buf + count, len - count);
+               fd_set rd_set, wr_set;
+               int maxfd = fd;
+               int i;
+
+               FD_ZERO(&wr_set);
+               FD_ZERO(&rd_set);
+               FD_SET(fd, &wr_set);
+               if (vpninfo->cancel_fd != -1) {
+                       FD_SET(vpninfo->cancel_fd, &rd_set);
+                       if (vpninfo->cancel_fd > fd)
+                               maxfd = vpninfo->cancel_fd;
+               }
+
+               select(maxfd + 1, &rd_set, &wr_set, NULL, NULL);
+               if (vpninfo->cancel_fd != -1 &&
+                   FD_ISSET(vpninfo->cancel_fd, &rd_set))
+                       return -EINTR;
+
+               /* Not that this should ever be able to happen... */
+               if (!FD_ISSET(fd, &wr_set))
+                       continue;
+
+               i = write(fd, buf + count, len - count);
                if (i < 0)
                        return -errno;
 
@@ -878,12 +922,34 @@ static int proxy_write(int fd, unsigned char *buf, size_t len)
        return 0;
 }
 
-static int proxy_read(int fd, unsigned char *buf, size_t len)
+static int proxy_read(struct openconnect_info *vpninfo, int fd,
+                     unsigned char *buf, size_t len)
 {
        size_t count;
 
        for (count = 0; count < len; ) {
-               int i = read(fd, buf + count, len - count);
+               fd_set rd_set;
+               int maxfd = fd;
+               int i;
+
+               FD_ZERO(&rd_set);
+               FD_SET(fd, &rd_set);
+               if (vpninfo->cancel_fd != -1) {
+                       FD_SET(vpninfo->cancel_fd, &rd_set);
+                       if (vpninfo->cancel_fd > fd)
+                               maxfd = vpninfo->cancel_fd;
+               }
+
+               select(maxfd + 1, &rd_set, NULL, NULL, NULL);
+               if (vpninfo->cancel_fd != -1 &&
+                   FD_ISSET(vpninfo->cancel_fd, &rd_set))
+                       return -EINTR;
+
+               /* Not that this should ever be able to happen... */
+               if (!FD_ISSET(fd, &rd_set))
+                       continue;
+
+               i = read(fd, buf + count, len - count);
                if (i < 0)
                        return -errno;
 
@@ -893,15 +959,15 @@ static int proxy_read(int fd, unsigned char *buf, size_t len)
 }
 
 static const char *socks_errors[] = {
-       "request granted",
-       "general failure",
-       "connection not allowed by ruleset",
-       "network unreachable",
-       "host unreachable",
-       "connection refused by destination host",
-       "TTL expired",
-       "command not supported / protocol error",
-       "address type not supported"
+       N_("request granted"),
+       N_("general failure"),
+       N_("connection not allowed by ruleset"),
+       N_("network unreachable"),
+       N_("host unreachable"),
+       N_("connection refused by destination host"),
+       N_("TTL expired"),
+       N_("command not supported / protocol error"),
+       N_("address type not supported")
 };
 
 static int process_socks_proxy(struct openconnect_info *vpninfo, int ssl_sock)
@@ -913,40 +979,41 @@ static int process_socks_proxy(struct openconnect_info *vpninfo, int ssl_sock)
        buf[1] = 1; /* # auth methods */
        buf[2] = 0; /* No auth supported */
 
-       if ((i = proxy_write(ssl_sock, buf, 3))) {
+       if ((i = proxy_write(vpninfo, ssl_sock, buf, 3))) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Error writing auth request to SOCKS proxy: %s\n",
-                                 strerror(-i));
+                            _("Error writing auth request to SOCKS proxy: %s\n"),
+                            strerror(-i));
                return i;
        }
        
-       if ((i = proxy_read(ssl_sock, buf, 2))) {
+       if ((i = proxy_read(vpninfo, ssl_sock, buf, 2))) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Error reading auth response from SOCKS proxy: %s\n",
-                                 strerror(-i));
+                            _("Error reading auth response from SOCKS proxy: %s\n"),
+                            strerror(-i));
                return i;
        }
        if (buf[0] != 5) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Unexpected auth response from SOCKS proxy: %02x %02x\n",
-                                 buf[0], buf[1]);
+                            _("Unexpected auth response from SOCKS proxy: %02x %02x\n"),
+                            buf[0], buf[1]);
                return -EIO;
        }
        if (buf[1]) {
        socks_err:
                if (buf[1] < sizeof(socks_errors) / sizeof(socks_errors[0]))
                        vpn_progress(vpninfo, PRG_ERR,
-                                         "SOCKS proxy error %02x: %s\n",
-                                         buf[1], socks_errors[buf[1]]);
+                                    _("SOCKS proxy error %02x: %s\n"),
+                                    buf[1], _(socks_errors[buf[1]]));
                else
                        vpn_progress(vpninfo, PRG_ERR,
-                                         "SOCKS proxy error %02x\n",
-                                         buf[1]);
+                                    _("SOCKS proxy error %02x\n"),
+                                    buf[1]);
                return -EIO;
        }
 
-       vpn_progress(vpninfo, PRG_INFO, "Requesting SOCKS proxy connection to %s:%d\n",
-                         vpninfo->hostname, vpninfo->port);
+       vpn_progress(vpninfo, PRG_INFO,
+                    _("Requesting SOCKS proxy connection to %s:%d\n"),
+                    vpninfo->hostname, vpninfo->port);
 
        buf[0] = 5; /* SOCKS version */
        buf[1] = 1; /* CONNECT */
@@ -958,24 +1025,24 @@ static int process_socks_proxy(struct openconnect_info *vpninfo, int ssl_sock)
        buf[i++] = vpninfo->port >> 8;
        buf[i++] = vpninfo->port & 0xff;
 
-       if ((i = proxy_write(ssl_sock, buf, i))) {
+       if ((i = proxy_write(vpninfo, ssl_sock, buf, i))) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Error writing connect request to SOCKS proxy: %s\n",
-                                 strerror(-i));
+                            _("Error writing connect request to SOCKS proxy: %s\n"),
+                            strerror(-i));
                return i;
        }
        /* Read 5 bytes -- up to and including the first byte of the returned
           address (which might be the length byte of a domain name) */
-       if ((i = proxy_read(ssl_sock, buf, 5))) {
+       if ((i = proxy_read(vpninfo, ssl_sock, buf, 5))) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Error reading connect response from SOCKS proxy: %s\n",
-                                 strerror(-i));
+                            _("Error reading connect response from SOCKS proxy: %s\n"),
+                            strerror(-i));
                return i;
        }
        if (buf[0] != 5) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Unexpected connect response from SOCKS proxy: %02x %02x...\n",
-                                 buf[0], buf[1]);
+                            _("Unexpected connect response from SOCKS proxy: %02x %02x...\n"),
+                            buf[0], buf[1]);
                return -EIO;
        }
        if (buf[1])
@@ -994,15 +1061,15 @@ static int process_socks_proxy(struct openconnect_info *vpninfo, int ssl_sock)
                break;
        default:
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Unexpected address type %02x in SOCKS connect response\n",
-                                 buf[3]);
+                            _("Unexpected address type %02x in SOCKS connect response\n"),
+                            buf[3]);
                return -EIO;
        }
 
-       if ((i = proxy_read(ssl_sock, buf, i))) {
+       if ((i = proxy_read(vpninfo, ssl_sock, buf, i))) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Error reading connect response from SOCKS proxy: %s\n",
-                                 strerror(-i));
+                            _("Error reading connect response from SOCKS proxy: %s\n"),
+                            strerror(-i));
                return i;
        }
        return 0;
@@ -1021,42 +1088,46 @@ static int process_http_proxy(struct openconnect_info *vpninfo, int ssl_sock)
        sprintf(buf + strlen(buf), "Accept-Encoding: identity\r\n");
        sprintf(buf + strlen(buf), "\r\n");
 
-       vpn_progress(vpninfo, PRG_INFO, "Requesting HTTP proxy connection to %s:%d\n",
-                         vpninfo->hostname, vpninfo->port);
+       vpn_progress(vpninfo, PRG_INFO,
+                    _("Requesting HTTP proxy connection to %s:%d\n"),
+                    vpninfo->hostname, vpninfo->port);
 
-       if (proxy_write(ssl_sock, (unsigned char *)buf, strlen(buf))) {
-               result = -errno;
-               vpn_progress(vpninfo, PRG_ERR, "Sending proxy request failed: %s\n",
-                                 strerror(errno));
+       result = proxy_write(vpninfo, ssl_sock, (unsigned char *)buf, strlen(buf));
+       if (result) {
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Sending proxy request failed: %s\n"),
+                            strerror(-result));
                return result;
        }
 
-       if (proxy_gets(ssl_sock, buf, sizeof(buf)) < 0) {
-               vpn_progress(vpninfo, PRG_ERR, "Error fetching proxy response\n");
+       if (proxy_gets(vpninfo, ssl_sock, buf, sizeof(buf)) < 0) {
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Error fetching proxy response\n"));
                return -EIO;
        }
 
        if (strncmp(buf, "HTTP/1.", 7) || (buf[7] != '0' && buf[7] != '1') ||
            buf[8] != ' ' || !(result = atoi(buf+9))) {
-               vpn_progress(vpninfo, PRG_ERR, "Failed to parse proxy response '%s'\n",
-                                 buf);
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Failed to parse proxy response '%s'\n"), buf);
                return -EINVAL;
        }
 
        if (result != 200) {
-               vpn_progress(vpninfo, PRG_ERR, "Proxy CONNECT request failed: %s\n",
-                                 buf);
+               vpn_progress(vpninfo, PRG_ERR,
+                            _("Proxy CONNECT request failed: %s\n"), buf);
                return -EIO;
        }
 
-       while ((buflen = proxy_gets(ssl_sock, buf, sizeof(buf)))) {
+       while ((buflen = proxy_gets(vpninfo, ssl_sock, buf, sizeof(buf)))) {
                if (buflen < 0) {
-                       vpn_progress(vpninfo, PRG_ERR, "Failed to read proxy response\n");
+                       vpn_progress(vpninfo, PRG_ERR,
+                                    _("Failed to read proxy response\n"));
                        return -EIO;
                }
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Unexpected continuation line after CONNECT response: '%s'\n",
-                                 buf);
+                            _("Unexpected continuation line after CONNECT response: '%s'\n"),
+                            buf);
        }
 
        return 0;
@@ -1071,8 +1142,8 @@ int process_proxy(struct openconnect_info *vpninfo, int ssl_sock)
            !strcmp(vpninfo->proxy_type, "socks5"))
                return process_socks_proxy(vpninfo, ssl_sock);
 
-       vpn_progress(vpninfo, PRG_ERR, "Unknown proxy type '%s'\n",
-                                 vpninfo->proxy_type);
+       vpn_progress(vpninfo, PRG_ERR, _("Unknown proxy type '%s'\n"),
+                    vpninfo->proxy_type);
        return -EIO;
 }
 
@@ -1099,7 +1170,7 @@ int openconnect_set_http_proxy(struct openconnect_info *vpninfo, char *proxy)
            strcmp(vpninfo->proxy_type, "socks") &&
            strcmp(vpninfo->proxy_type, "socks5")) {
                vpn_progress(vpninfo, PRG_ERR,
-                                 "Only http or socks(5) proxies supported\n");
+                            _("Only http or socks(5) proxies supported\n"));
                free(vpninfo->proxy_type);
                vpninfo->proxy_type = NULL;
                free(vpninfo->proxy);