hook gvariant vectors up to kdbus
[platform/upstream/glib.git] / gio / gthreadedresolver.c
index f979c1b..c02c593 100644 (file)
@@ -15,9 +15,7 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General
- * Public License along with this library; if not, write to the
- * Free Software Foundation, Inc., 59 Temple Place, Suite 330,
- * Boston, MA 02111-1307, USA.
+ * Public License along with this library; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "config.h"
 #include "gnetworkingprivate.h"
 
 #include "gcancellable.h"
+#include "ginetaddress.h"
+#include "ginetsocketaddress.h"
 #include "gtask.h"
 #include "gsocketaddress.h"
+#include "gsrvtarget.h"
 
 
 G_DEFINE_TYPE (GThreadedResolver, g_threaded_resolver, G_TYPE_RESOLVER)
@@ -42,6 +43,28 @@ g_threaded_resolver_init (GThreadedResolver *gtr)
 {
 }
 
+static GResolverError
+g_resolver_error_from_addrinfo_error (gint err)
+{
+  switch (err)
+    {
+    case EAI_FAIL:
+#if defined(EAI_NODATA) && (EAI_NODATA != EAI_NONAME)
+    case EAI_NODATA:
+#endif
+    case EAI_NONAME:
+      return G_RESOLVER_ERROR_NOT_FOUND;
+
+    case EAI_AGAIN:
+      return G_RESOLVER_ERROR_TEMPORARY_FAILURE;
+
+    default:
+      return G_RESOLVER_ERROR_INTERNAL;
+    }
+}
+
+static struct addrinfo addrinfo_hints;
+
 static void
 do_lookup_by_name (GTask         *task,
                    gpointer       source_object,
@@ -52,20 +75,60 @@ do_lookup_by_name (GTask         *task,
   struct addrinfo *res = NULL;
   GList *addresses;
   gint retval;
-  GError *error = NULL;
 
-  retval = getaddrinfo (hostname, NULL, &_g_resolver_addrinfo_hints, &res);
-  addresses = _g_resolver_addresses_from_addrinfo (hostname, res, retval, &error);
-  if (res)
-    freeaddrinfo (res);
+  retval = getaddrinfo (hostname, NULL, &addrinfo_hints, &res);
 
-  if (addresses)
+  if (retval == 0)
     {
-      g_task_return_pointer (task, addresses,
-                             (GDestroyNotify)g_resolver_free_addresses);
+      struct addrinfo *ai;
+      GSocketAddress *sockaddr;
+      GInetAddress *addr;
+
+      addresses = NULL;
+      for (ai = res; ai; ai = ai->ai_next)
+        {
+          sockaddr = g_socket_address_new_from_native (ai->ai_addr, ai->ai_addrlen);
+          if (!sockaddr)
+            continue;
+          if (!G_IS_INET_SOCKET_ADDRESS (sockaddr))
+            {
+              g_clear_object (&sockaddr);
+              continue;
+            }
+
+          addr = g_object_ref (g_inet_socket_address_get_address ((GInetSocketAddress *)sockaddr));
+          addresses = g_list_prepend (addresses, addr);
+          g_object_unref (sockaddr);
+        }
+
+      if (addresses != NULL)
+        {
+          addresses = g_list_reverse (addresses);
+          g_task_return_pointer (task, addresses,
+                                 (GDestroyNotify)g_resolver_free_addresses);
+        }
+      else
+        {
+          /* All addresses failed to be converted to GSocketAddresses. */
+          g_task_return_new_error (task,
+                                   G_RESOLVER_ERROR,
+                                   G_RESOLVER_ERROR_NOT_FOUND,
+                                   _("Error resolving '%s': %s"),
+                                   hostname,
+                                   _("No valid addresses were found"));
+        }
     }
   else
-    g_task_return_error (task, error);
+    {
+      g_task_return_new_error (task,
+                               G_RESOLVER_ERROR,
+                               g_resolver_error_from_addrinfo_error (retval),
+                               _("Error resolving '%s': %s"),
+                               hostname, gai_strerror (retval));
+    }
+
+  if (res)
+    freeaddrinfo (res);
 }
 
 static GList *
@@ -123,19 +186,33 @@ do_lookup_by_address (GTask         *task,
   GInetAddress *address = task_data;
   struct sockaddr_storage sockaddr;
   gsize sockaddr_size;
-  gchar namebuf[NI_MAXHOST], *name;
+  GSocketAddress *gsockaddr;
+  gchar name[NI_MAXHOST];
   gint retval;
-  GError *error = NULL;
 
-  _g_resolver_address_to_sockaddr (address, &sockaddr, &sockaddr_size);
-  retval = getnameinfo ((struct sockaddr *)&sockaddr, sockaddr_size,
-                        namebuf, sizeof (namebuf), NULL, 0, NI_NAMEREQD);
-  name = _g_resolver_name_from_nameinfo (address, namebuf, retval, &error);
+  gsockaddr = g_inet_socket_address_new (address, 0);
+  g_socket_address_to_native (gsockaddr, (struct sockaddr *)&sockaddr,
+                              sizeof (sockaddr), NULL);
+  sockaddr_size = g_socket_address_get_native_size (gsockaddr);
+  g_object_unref (gsockaddr);
 
-  if (name)
-    g_task_return_pointer (task, name, g_free);
+  retval = getnameinfo ((struct sockaddr *)&sockaddr, sockaddr_size,
+                        name, sizeof (name), NULL, 0, NI_NAMEREQD);
+  if (retval == 0)
+    g_task_return_pointer (task, g_strdup (name), g_free);
   else
-    g_task_return_error (task, error);
+    {
+      gchar *phys;
+
+      phys = g_inet_address_to_string (address);
+      g_task_return_new_error (task,
+                               G_RESOLVER_ERROR,
+                               g_resolver_error_from_addrinfo_error (retval),
+                               _("Error reverse-resolving '%s': %s"),
+                               phys ? phys : "(unknown)",
+                               gai_strerror (retval));
+      g_free (phys);
+    }
 }
 
 static gchar *
@@ -184,6 +261,526 @@ lookup_by_address_finish (GResolver     *resolver,
 }
 
 
+#if defined(G_OS_UNIX)
+
+#ifdef __BIONIC__
+/* Copy from bionic/libc/private/arpa_nameser_compat.h
+ * and bionic/libc/private/arpa_nameser.h */
+typedef struct {
+       unsigned        id :16;         /* query identification number */
+#if BYTE_ORDER == BIG_ENDIAN
+                       /* fields in third byte */
+       unsigned        qr: 1;          /* response flag */
+       unsigned        opcode: 4;      /* purpose of message */
+       unsigned        aa: 1;          /* authoritive answer */
+       unsigned        tc: 1;          /* truncated message */
+       unsigned        rd: 1;          /* recursion desired */
+                       /* fields in fourth byte */
+       unsigned        ra: 1;          /* recursion available */
+       unsigned        unused :1;      /* unused bits (MBZ as of 4.9.3a3) */
+       unsigned        ad: 1;          /* authentic data from named */
+       unsigned        cd: 1;          /* checking disabled by resolver */
+       unsigned        rcode :4;       /* response code */
+#endif
+#if BYTE_ORDER == LITTLE_ENDIAN || BYTE_ORDER == PDP_ENDIAN
+                       /* fields in third byte */
+       unsigned        rd :1;          /* recursion desired */
+       unsigned        tc :1;          /* truncated message */
+       unsigned        aa :1;          /* authoritive answer */
+       unsigned        opcode :4;      /* purpose of message */
+       unsigned        qr :1;          /* response flag */
+                       /* fields in fourth byte */
+       unsigned        rcode :4;       /* response code */
+       unsigned        cd: 1;          /* checking disabled by resolver */
+       unsigned        ad: 1;          /* authentic data from named */
+       unsigned        unused :1;      /* unused bits (MBZ as of 4.9.3a3) */
+       unsigned        ra :1;          /* recursion available */
+#endif
+                       /* remaining bytes */
+       unsigned        qdcount :16;    /* number of question entries */
+       unsigned        ancount :16;    /* number of answer entries */
+       unsigned        nscount :16;    /* number of authority entries */
+       unsigned        arcount :16;    /* number of resource entries */
+} HEADER;
+
+#define NS_INT32SZ     4       /* #/bytes of data in a uint32_t */
+#define NS_INT16SZ     2       /* #/bytes of data in a uint16_t */
+
+#define NS_GET16(s, cp) do { \
+       const u_char *t_cp = (const u_char *)(cp); \
+       (s) = ((uint16_t)t_cp[0] << 8) \
+           | ((uint16_t)t_cp[1]) \
+           ; \
+       (cp) += NS_INT16SZ; \
+} while (/*CONSTCOND*/0)
+
+#define NS_GET32(l, cp) do { \
+       const u_char *t_cp = (const u_char *)(cp); \
+       (l) = ((uint32_t)t_cp[0] << 24) \
+           | ((uint32_t)t_cp[1] << 16) \
+           | ((uint32_t)t_cp[2] << 8) \
+           | ((uint32_t)t_cp[3]) \
+           ; \
+       (cp) += NS_INT32SZ; \
+} while (/*CONSTCOND*/0)
+
+#define        GETSHORT                NS_GET16
+#define        GETLONG                 NS_GET32
+
+#define C_IN 1
+
+/* From bionic/libc/private/resolv_private.h */
+int dn_expand(const u_char *, const u_char *, const u_char *, char *, int);
+#define dn_skipname __dn_skipname
+int dn_skipname(const u_char *, const u_char *);
+
+/* From bionic/libc/private/arpa_nameser_compat.h */
+#define T_MX           ns_t_mx
+#define T_TXT          ns_t_txt
+#define T_SOA          ns_t_soa
+#define T_NS           ns_t_ns
+
+/* From bionic/libc/private/arpa_nameser.h */
+typedef enum __ns_type {
+       ns_t_invalid = 0,       /* Cookie. */
+       ns_t_a = 1,             /* Host address. */
+       ns_t_ns = 2,            /* Authoritative server. */
+       ns_t_md = 3,            /* Mail destination. */
+       ns_t_mf = 4,            /* Mail forwarder. */
+       ns_t_cname = 5,         /* Canonical name. */
+       ns_t_soa = 6,           /* Start of authority zone. */
+       ns_t_mb = 7,            /* Mailbox domain name. */
+       ns_t_mg = 8,            /* Mail group member. */
+       ns_t_mr = 9,            /* Mail rename name. */
+       ns_t_null = 10,         /* Null resource record. */
+       ns_t_wks = 11,          /* Well known service. */
+       ns_t_ptr = 12,          /* Domain name pointer. */
+       ns_t_hinfo = 13,        /* Host information. */
+       ns_t_minfo = 14,        /* Mailbox information. */
+       ns_t_mx = 15,           /* Mail routing information. */
+       ns_t_txt = 16,          /* Text strings. */
+       ns_t_rp = 17,           /* Responsible person. */
+       ns_t_afsdb = 18,        /* AFS cell database. */
+       ns_t_x25 = 19,          /* X_25 calling address. */
+       ns_t_isdn = 20,         /* ISDN calling address. */
+       ns_t_rt = 21,           /* Router. */
+       ns_t_nsap = 22,         /* NSAP address. */
+       ns_t_nsap_ptr = 23,     /* Reverse NSAP lookup (deprecated). */
+       ns_t_sig = 24,          /* Security signature. */
+       ns_t_key = 25,          /* Security key. */
+       ns_t_px = 26,           /* X.400 mail mapping. */
+       ns_t_gpos = 27,         /* Geographical position (withdrawn). */
+       ns_t_aaaa = 28,         /* Ip6 Address. */
+       ns_t_loc = 29,          /* Location Information. */
+       ns_t_nxt = 30,          /* Next domain (security). */
+       ns_t_eid = 31,          /* Endpoint identifier. */
+       ns_t_nimloc = 32,       /* Nimrod Locator. */
+       ns_t_srv = 33,          /* Server Selection. */
+       ns_t_atma = 34,         /* ATM Address */
+       ns_t_naptr = 35,        /* Naming Authority PoinTeR */
+       ns_t_kx = 36,           /* Key Exchange */
+       ns_t_cert = 37,         /* Certification record */
+       ns_t_a6 = 38,           /* IPv6 address (deprecates AAAA) */
+       ns_t_dname = 39,        /* Non-terminal DNAME (for IPv6) */
+       ns_t_sink = 40,         /* Kitchen sink (experimentatl) */
+       ns_t_opt = 41,          /* EDNS0 option (meta-RR) */
+       ns_t_apl = 42,          /* Address prefix list (RFC 3123) */
+       ns_t_tkey = 249,        /* Transaction key */
+       ns_t_tsig = 250,        /* Transaction signature. */
+       ns_t_ixfr = 251,        /* Incremental zone transfer. */
+       ns_t_axfr = 252,        /* Transfer zone of authority. */
+       ns_t_mailb = 253,       /* Transfer mailbox records. */
+       ns_t_maila = 254,       /* Transfer mail agent records. */
+       ns_t_any = 255,         /* Wildcard match. */
+       ns_t_zxfr = 256,        /* BIND-specific, nonstandard. */
+       ns_t_max = 65536
+} ns_type;
+
+#endif /* __BIONIC__ */
+
+static GVariant *
+parse_res_srv (guchar  *answer,
+               guchar  *end,
+               guchar **p)
+{
+  gchar namebuf[1024];
+  guint16 priority, weight, port;
+
+  GETSHORT (priority, *p);
+  GETSHORT (weight, *p);
+  GETSHORT (port, *p);
+  *p += dn_expand (answer, end, *p, namebuf, sizeof (namebuf));
+
+  return g_variant_new ("(qqqs)",
+                        priority,
+                        weight,
+                        port,
+                        namebuf);
+}
+
+static GVariant *
+parse_res_soa (guchar  *answer,
+               guchar  *end,
+               guchar **p)
+{
+  gchar mnamebuf[1024];
+  gchar rnamebuf[1024];
+  guint32 serial, refresh, retry, expire, ttl;
+
+  *p += dn_expand (answer, end, *p, mnamebuf, sizeof (mnamebuf));
+  *p += dn_expand (answer, end, *p, rnamebuf, sizeof (rnamebuf));
+
+  GETLONG (serial, *p);
+  GETLONG (refresh, *p);
+  GETLONG (retry, *p);
+  GETLONG (expire, *p);
+  GETLONG (ttl, *p);
+
+  return g_variant_new ("(ssuuuuu)",
+                        mnamebuf,
+                        rnamebuf,
+                        serial,
+                        refresh,
+                        retry,
+                        expire,
+                        ttl);
+}
+
+static GVariant *
+parse_res_ns (guchar  *answer,
+              guchar  *end,
+              guchar **p)
+{
+  gchar namebuf[1024];
+
+  *p += dn_expand (answer, end, *p, namebuf, sizeof (namebuf));
+
+  return g_variant_new ("(s)", namebuf);
+}
+
+static GVariant *
+parse_res_mx (guchar  *answer,
+              guchar  *end,
+              guchar **p)
+{
+  gchar namebuf[1024];
+  guint16 preference;
+
+  GETSHORT (preference, *p);
+
+  *p += dn_expand (answer, end, *p, namebuf, sizeof (namebuf));
+
+  return g_variant_new ("(qs)",
+                        preference,
+                        namebuf);
+}
+
+static GVariant *
+parse_res_txt (guchar  *answer,
+               guchar  *end,
+               guchar **p)
+{
+  GVariant *record;
+  GPtrArray *array;
+  guchar *at = *p;
+  gsize len;
+
+  array = g_ptr_array_new_with_free_func (g_free);
+  while (at < end)
+    {
+      len = *(at++);
+      if (len > at - end)
+        break;
+      g_ptr_array_add (array, g_strndup ((gchar *)at, len));
+      at += len;
+    }
+
+  *p = at;
+  record = g_variant_new ("(@as)",
+                          g_variant_new_strv ((const gchar **)array->pdata, array->len));
+  g_ptr_array_free (array, TRUE);
+  return record;
+}
+
+static gint
+g_resolver_record_type_to_rrtype (GResolverRecordType type)
+{
+  switch (type)
+  {
+    case G_RESOLVER_RECORD_SRV:
+      return T_SRV;
+    case G_RESOLVER_RECORD_TXT:
+      return T_TXT;
+    case G_RESOLVER_RECORD_SOA:
+      return T_SOA;
+    case G_RESOLVER_RECORD_NS:
+      return T_NS;
+    case G_RESOLVER_RECORD_MX:
+      return T_MX;
+  }
+  g_return_val_if_reached (-1);
+}
+
+static GList *
+g_resolver_records_from_res_query (const gchar      *rrname,
+                                   gint              rrtype,
+                                   guchar           *answer,
+                                   gint              len,
+                                   gint              herr,
+                                   GError          **error)
+{
+  gint count;
+  gchar namebuf[1024];
+  guchar *end, *p;
+  guint16 type, qclass, rdlength;
+  guint32 ttl;
+  HEADER *header;
+  GList *records;
+  GVariant *record;
+
+  if (len <= 0)
+    {
+      if (len == 0 || herr == HOST_NOT_FOUND || herr == NO_DATA)
+        {
+          g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_NOT_FOUND,
+                       _("No DNS record of the requested type for '%s'"), rrname);
+        }
+      else if (herr == TRY_AGAIN)
+        {
+          g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_TEMPORARY_FAILURE,
+                       _("Temporarily unable to resolve '%s'"), rrname);
+        }
+      else
+        {
+          g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_INTERNAL,
+                       _("Error resolving '%s'"), rrname);
+        }
+
+      return NULL;
+    }
+
+  records = NULL;
+
+  header = (HEADER *)answer;
+  p = answer + sizeof (HEADER);
+  end = answer + len;
+
+  /* Skip query */
+  count = ntohs (header->qdcount);
+  while (count-- && p < end)
+    {
+      p += dn_expand (answer, end, p, namebuf, sizeof (namebuf));
+      p += 4;
+
+      /* To silence gcc warnings */
+      namebuf[0] = namebuf[1];
+    }
+
+  /* Read answers */
+  count = ntohs (header->ancount);
+  while (count-- && p < end)
+    {
+      p += dn_expand (answer, end, p, namebuf, sizeof (namebuf));
+      GETSHORT (type, p);
+      GETSHORT (qclass, p);
+      GETLONG  (ttl, p);
+      ttl = ttl; /* To avoid -Wunused-but-set-variable */
+      GETSHORT (rdlength, p);
+
+      if (type != rrtype || qclass != C_IN)
+        {
+          p += rdlength;
+          continue;
+        }
+
+      switch (rrtype)
+        {
+        case T_SRV:
+          record = parse_res_srv (answer, end, &p);
+          break;
+        case T_MX:
+          record = parse_res_mx (answer, end, &p);
+          break;
+        case T_SOA:
+          record = parse_res_soa (answer, end, &p);
+          break;
+        case T_NS:
+          record = parse_res_ns (answer, end, &p);
+          break;
+        case T_TXT:
+          record = parse_res_txt (answer, p + rdlength, &p);
+          break;
+        default:
+          g_warn_if_reached ();
+          record = NULL;
+          break;
+        }
+
+      if (record != NULL)
+        records = g_list_prepend (records, record);
+    }
+
+  if (records == NULL)
+    {
+      g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_NOT_FOUND,
+                   _("No DNS record of the requested type for '%s'"), rrname);
+
+      return NULL;
+    }
+  else
+    return records;
+}
+
+#elif defined(G_OS_WIN32)
+
+static GVariant *
+parse_dns_srv (DNS_RECORD *rec)
+{
+  return g_variant_new ("(qqqs)",
+                        (guint16)rec->Data.SRV.wPriority,
+                        (guint16)rec->Data.SRV.wWeight,
+                        (guint16)rec->Data.SRV.wPort,
+                        rec->Data.SRV.pNameTarget);
+}
+
+static GVariant *
+parse_dns_soa (DNS_RECORD *rec)
+{
+  return g_variant_new ("(ssuuuuu)",
+                        rec->Data.SOA.pNamePrimaryServer,
+                        rec->Data.SOA.pNameAdministrator,
+                        (guint32)rec->Data.SOA.dwSerialNo,
+                        (guint32)rec->Data.SOA.dwRefresh,
+                        (guint32)rec->Data.SOA.dwRetry,
+                        (guint32)rec->Data.SOA.dwExpire,
+                        (guint32)rec->Data.SOA.dwDefaultTtl);
+}
+
+static GVariant *
+parse_dns_ns (DNS_RECORD *rec)
+{
+  return g_variant_new ("(s)", rec->Data.NS.pNameHost);
+}
+
+static GVariant *
+parse_dns_mx (DNS_RECORD *rec)
+{
+  return g_variant_new ("(qs)",
+                        (guint16)rec->Data.MX.wPreference,
+                        rec->Data.MX.pNameExchange);
+}
+
+static GVariant *
+parse_dns_txt (DNS_RECORD *rec)
+{
+  GVariant *record;
+  GPtrArray *array;
+  DWORD i;
+
+  array = g_ptr_array_new ();
+  for (i = 0; i < rec->Data.TXT.dwStringCount; i++)
+    g_ptr_array_add (array, rec->Data.TXT.pStringArray[i]);
+  record = g_variant_new ("(@as)",
+                          g_variant_new_strv ((const gchar **)array->pdata, array->len));
+  g_ptr_array_free (array, TRUE);
+  return record;
+}
+
+static WORD
+g_resolver_record_type_to_dnstype (GResolverRecordType type)
+{
+  switch (type)
+  {
+    case G_RESOLVER_RECORD_SRV:
+      return DNS_TYPE_SRV;
+    case G_RESOLVER_RECORD_TXT:
+      return DNS_TYPE_TEXT;
+    case G_RESOLVER_RECORD_SOA:
+      return DNS_TYPE_SOA;
+    case G_RESOLVER_RECORD_NS:
+      return DNS_TYPE_NS;
+    case G_RESOLVER_RECORD_MX:
+      return DNS_TYPE_MX;
+  }
+  g_return_val_if_reached (-1);
+}
+
+static GList *
+g_resolver_records_from_DnsQuery (const gchar  *rrname,
+                                  WORD          dnstype,
+                                  DNS_STATUS    status,
+                                  DNS_RECORD   *results,
+                                  GError      **error)
+{
+  DNS_RECORD *rec;
+  gpointer record;
+  GList *records;
+
+  if (status != ERROR_SUCCESS)
+    {
+      if (status == DNS_ERROR_RCODE_NAME_ERROR)
+        {
+          g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_NOT_FOUND,
+                       _("No DNS record of the requested type for '%s'"), rrname);
+        }
+      else if (status == DNS_ERROR_RCODE_SERVER_FAILURE)
+        {
+          g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_TEMPORARY_FAILURE,
+                       _("Temporarily unable to resolve '%s'"), rrname);
+        }
+      else
+        {
+          g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_INTERNAL,
+                       _("Error resolving '%s'"), rrname);
+        }
+
+      return NULL;
+    }
+
+  records = NULL;
+  for (rec = results; rec; rec = rec->pNext)
+    {
+      if (rec->wType != dnstype)
+        continue;
+      switch (dnstype)
+        {
+        case DNS_TYPE_SRV:
+          record = parse_dns_srv (rec);
+          break;
+        case DNS_TYPE_SOA:
+          record = parse_dns_soa (rec);
+          break;
+        case DNS_TYPE_NS:
+          record = parse_dns_ns (rec);
+          break;
+        case DNS_TYPE_MX:
+          record = parse_dns_mx (rec);
+          break;
+        case DNS_TYPE_TEXT:
+          record = parse_dns_txt (rec);
+          break;
+        default:
+          g_warn_if_reached ();
+          record = NULL;
+          break;
+        }
+      if (record != NULL)
+        records = g_list_prepend (records, g_variant_ref_sink (record));
+    }
+
+  if (records == NULL)
+    {
+      g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_NOT_FOUND,
+                   _("No DNS record of the requested type for '%s'"), rrname);
+
+      return NULL;
+    }
+  else
+    return records;
+}
+
+#endif
+
 typedef struct {
   char *rrname;
   GResolverRecordType record_type;
@@ -218,13 +815,14 @@ do_lookup_records (GTask         *task,
   LookupRecordsData *lrd = task_data;
   GList *records;
   GError *error = NULL;
+
 #if defined(G_OS_UNIX)
   gint len = 512;
   gint herr;
   GByteArray *answer;
   gint rrtype;
 
-  rrtype = _g_resolver_record_type_to_rrtype (lrd->record_type);
+  rrtype = g_resolver_record_type_to_rrtype (lrd->record_type);
   answer = g_byte_array_new ();
   for (;;)
     {
@@ -239,28 +837,28 @@ do_lookup_records (GTask         *task,
        * On overflow some res_query's return the length needed, others
        * return the full length entered. This code works in either case.
        */
-  }
+    }
 
   herr = h_errno;
-  records = _g_resolver_records_from_res_query (lrd->rrname, rrtype, answer->data, len, herr, &error);
+  records = g_resolver_records_from_res_query (lrd->rrname, rrtype, answer->data, len, herr, &error);
   g_byte_array_free (answer, TRUE);
 
-#elif defined(G_OS_WIN32)
+#else
+
   DNS_STATUS status;
   DNS_RECORD *results = NULL;
   WORD dnstype;
 
-  dnstype = _g_resolver_record_type_to_dnstype (lrd->record_type);
+  dnstype = g_resolver_record_type_to_dnstype (lrd->record_type);
   status = DnsQuery_A (lrd->rrname, dnstype, DNS_QUERY_STANDARD, NULL, &results, NULL);
-  records = _g_resolver_records_from_DnsQuery (lrd->rrname, dnstype, status, results, &error);
+  records = g_resolver_records_from_DnsQuery (lrd->rrname, dnstype, status, results, &error);
   if (results != NULL)
     DnsRecordListFree (results, DnsFreeRecordList);
+
 #endif
 
   if (records)
-    {
-      g_task_return_pointer (task, records, (GDestroyNotify) free_records);
-    }
+    g_task_return_pointer (task, records, (GDestroyNotify) free_records);
   else
     g_task_return_error (task, error);
 }
@@ -339,4 +937,15 @@ g_threaded_resolver_class_init (GThreadedResolverClass *threaded_class)
   resolver_class->lookup_records           = lookup_records;
   resolver_class->lookup_records_async     = lookup_records_async;
   resolver_class->lookup_records_finish    = lookup_records_finish;
+
+  /* Initialize addrinfo_hints */
+#ifdef AI_ADDRCONFIG
+  addrinfo_hints.ai_flags |= AI_ADDRCONFIG;
+#endif
+  /* These two don't actually matter, they just get copied into the
+   * returned addrinfo structures (and then we ignore them). But if
+   * we leave them unset, we'll get back duplicate answers.
+   */
+  addrinfo_hints.ai_socktype = SOCK_STREAM;
+  addrinfo_hints.ai_protocol = IPPROTO_TCP;
 }