hook gvariant vectors up to kdbus
[platform/upstream/glib.git] / gio / ginputstream.c
index 7ad7d6f..a1ba736 100644 (file)
@@ -13,9 +13,7 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General
- * Public License along with this library; if not, write to the
- * Free Software Foundation, Inc., 59 Temple Place, Suite 330,
- * Boston, MA 02111-1307, USA.
+ * Public License along with this library; if not, see <http://www.gnu.org/licenses/>.
  *
  * Author: Alexander Larsson <alexl@redhat.com>
  */
 #include "glibintl.h"
 
 #include "ginputstream.h"
+#include "gioprivate.h"
 #include "gseekable.h"
 #include "gcancellable.h"
 #include "gasyncresult.h"
-#include "gsimpleasyncresult.h"
 #include "gioerror.h"
 #include "gpollableinputstream.h"
 
  * All of these functions have async variants too.
  **/
 
-G_DEFINE_ABSTRACT_TYPE (GInputStream, g_input_stream, G_TYPE_OBJECT);
-
 struct _GInputStreamPrivate {
   guint closed : 1;
   guint pending : 1;
   GAsyncReadyCallback outstanding_callback;
 };
 
+G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE (GInputStream, g_input_stream, G_TYPE_OBJECT)
+
 static gssize   g_input_stream_real_skip         (GInputStream         *stream,
                                                  gsize                 count,
                                                  GCancellable         *cancellable,
@@ -88,12 +86,6 @@ static gboolean g_input_stream_real_close_finish (GInputStream         *stream,
                                                  GError              **error);
 
 static void
-g_input_stream_finalize (GObject *object)
-{
-  G_OBJECT_CLASS (g_input_stream_parent_class)->finalize (object);
-}
-
-static void
 g_input_stream_dispose (GObject *object)
 {
   GInputStream *stream;
@@ -112,9 +104,6 @@ g_input_stream_class_init (GInputStreamClass *klass)
 {
   GObjectClass *gobject_class = G_OBJECT_CLASS (klass);
   
-  g_type_class_add_private (klass, sizeof (GInputStreamPrivate));
-  
-  gobject_class->finalize = g_input_stream_finalize;
   gobject_class->dispose = g_input_stream_dispose;
   
   klass->skip = g_input_stream_real_skip;
@@ -129,15 +118,14 @@ g_input_stream_class_init (GInputStreamClass *klass)
 static void
 g_input_stream_init (GInputStream *stream)
 {
-  stream->priv = G_TYPE_INSTANCE_GET_PRIVATE (stream,
-                                             G_TYPE_INPUT_STREAM,
-                                             GInputStreamPrivate);
+  stream->priv = g_input_stream_get_instance_private (stream);
 }
 
 /**
  * g_input_stream_read:
  * @stream: a #GInputStream.
- * @buffer: a buffer to read data into (which should be at least count bytes long).
+ * @buffer: (array length=count) (element-type guint8): a buffer to
+ *     read data into (which should be at least count bytes long).
  * @count: the number of bytes that will be read from the stream
  * @cancellable: (allow-none): optional #GCancellable object, %NULL to ignore.
  * @error: location to store the error occurring, or %NULL to ignore
@@ -153,6 +141,9 @@ g_input_stream_init (GInputStream *stream)
  * can happen e.g. near the end of a file. Zero is returned on end of file
  * (or if @count is zero),  but never otherwise.
  *
+ * The returned @buffer is not a nul-terminated string, it can contain nul bytes
+ * at any position, and this function doesn't nul-terminate the @buffer.
+ *
  * If @cancellable is not %NULL, then the operation can be cancelled by
  * triggering the cancellable object from another thread. If the operation
  * was cancelled, the error %G_IO_ERROR_CANCELLED will be returned. If an
@@ -161,7 +152,7 @@ g_input_stream_init (GInputStream *stream)
  *
  * On error -1 is returned and @error is set accordingly.
  * 
- * Return value: Number of bytes read, or -1 on error, or 0 on end of file.
+ * Returns: Number of bytes read, or -1 on error, or 0 on end of file.
  **/
 gssize
 g_input_stream_read  (GInputStream  *stream,
@@ -214,7 +205,8 @@ g_input_stream_read  (GInputStream  *stream,
 /**
  * g_input_stream_read_all:
  * @stream: a #GInputStream.
- * @buffer: a buffer to read data into (which should be at least count bytes long).
+ * @buffer: (array length=count) (element-type guint8): a buffer to
+ *     read data into (which should be at least count bytes long).
  * @count: the number of bytes that will be read from the stream
  * @bytes_read: (out): location to store the number of bytes that was read from the stream
  * @cancellable: (allow-none): optional #GCancellable object, %NULL to ignore.
@@ -231,10 +223,16 @@ g_input_stream_read  (GInputStream  *stream,
  * read into @buffer.
  * 
  * If there is an error during the operation %FALSE is returned and @error
- * is set to indicate the error status, @bytes_read is updated to contain
- * the number of bytes read into @buffer before the error occurred.
+ * is set to indicate the error status.
  *
- * Return value: %TRUE on success, %FALSE if there was an error
+ * As a special exception to the normal conventions for functions that
+ * use #GError, if this function returns %FALSE (and sets @error) then
+ * @bytes_read will be set to the number of bytes that were successfully
+ * read before the error was encountered.  This functionality is only
+ * available from C.  If you need it from another language then you must
+ * write your own loop around g_input_stream_read().
+ *
+ * Returns: %TRUE on success, %FALSE if there was an error
  **/
 gboolean
 g_input_stream_read_all (GInputStream  *stream,
@@ -305,7 +303,9 @@ g_input_stream_read_all (GInputStream  *stream,
  *
  * On error %NULL is returned and @error is set accordingly.
  *
- * Return value: a new #GBytes, or %NULL on error
+ * Returns: a new #GBytes, or %NULL on error
+ *
+ * Since: 2.34
  **/
 GBytes *
 g_input_stream_read_bytes (GInputStream  *stream,
@@ -354,7 +354,7 @@ g_input_stream_read_bytes (GInputStream  *stream,
  * operation was partially finished when the operation was cancelled the
  * partial result will be returned, without an error.
  *
- * Return value: Number of bytes skipped, or -1 on error
+ * Returns: Number of bytes skipped, or -1 on error
  **/
 gssize
 g_input_stream_skip (GInputStream  *stream,
@@ -479,7 +479,7 @@ g_input_stream_real_skip (GInputStream  *stream,
  * Cancelling a close will still leave the stream closed, but some streams
  * can use a faster close that doesn't block to e.g. check errors. 
  *
- * Return value: %TRUE on success, %FALSE on failure
+ * Returns: %TRUE on success, %FALSE on failure
  **/
 gboolean
 g_input_stream_close (GInputStream  *stream,
@@ -547,9 +547,10 @@ async_ready_close_callback_wrapper (GObject      *source_object,
 /**
  * g_input_stream_read_async:
  * @stream: A #GInputStream.
- * @buffer: a buffer to read data into (which should be at least count bytes long).
+ * @buffer: (array length=count) (element-type guint8): a buffer to
+ *     read data into (which should be at least count bytes long).
  * @count: the number of bytes that will be read from the stream
- * @io_priority: the <link linkend="io-priority">I/O priority</link> 
+ * @io_priority: the [I/O priority][io-priority]
  * of the request. 
  * @cancellable: (allow-none): optional #GCancellable object, %NULL to ignore.
  * @callback: (scope async): callback to call when the request is satisfied
@@ -589,7 +590,6 @@ g_input_stream_read_async (GInputStream        *stream,
                           gpointer             user_data)
 {
   GInputStreamClass *class;
-  GSimpleAsyncResult *simple;
   GError *error = NULL;
 
   g_return_if_fail (G_IS_INPUT_STREAM (stream));
@@ -597,32 +597,30 @@ g_input_stream_read_async (GInputStream        *stream,
 
   if (count == 0)
     {
-      simple = g_simple_async_result_new (G_OBJECT (stream),
-                                         callback,
-                                         user_data,
-                                         g_input_stream_read_async);
-      g_simple_async_result_complete_in_idle (simple);
-      g_object_unref (simple);
+      GTask *task;
+
+      task = g_task_new (stream, cancellable, callback, user_data);
+      g_task_set_source_tag (task, g_input_stream_read_async);
+      g_task_return_int (task, 0);
+      g_object_unref (task);
       return;
     }
   
   if (((gssize) count) < 0)
     {
-      g_simple_async_report_error_in_idle (G_OBJECT (stream),
-                                          callback,
-                                          user_data,
-                                          G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
-                                          _("Too large count value passed to %s"),
-                                          G_STRFUNC);
+      g_task_report_new_error (stream, callback, user_data,
+                               g_input_stream_read_async,
+                               G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
+                               _("Too large count value passed to %s"),
+                               G_STRFUNC);
       return;
     }
 
   if (!g_input_stream_set_pending (stream, &error))
     {
-      g_simple_async_report_take_gerror_in_idle (G_OBJECT (stream),
-                                           callback,
-                                           user_data,
-                                           error);
+      g_task_report_error (stream, callback, user_data,
+                           g_input_stream_read_async,
+                           error);
       return;
     }
 
@@ -657,22 +655,198 @@ g_input_stream_read_finish (GInputStream  *stream,
   if (g_async_result_legacy_propagate_error (result, error))
     return -1;
   else if (g_async_result_is_tagged (result, g_input_stream_read_async))
-    {
-      /* Special case read of 0 bytes */
-      return 0;
-    }
+    return g_task_propagate_int (G_TASK (result), error);
 
   class = G_INPUT_STREAM_GET_CLASS (stream);
   return class->read_finish (stream, result, error);
 }
 
+typedef struct
+{
+  gchar *buffer;
+  gsize to_read;
+  gsize bytes_read;
+} AsyncReadAll;
+
+static void
+free_async_read_all (gpointer data)
+{
+  g_slice_free (AsyncReadAll, data);
+}
+
+static void
+read_all_callback (GObject      *stream,
+                   GAsyncResult *result,
+                   gpointer      user_data)
+{
+  GTask *task = user_data;
+  AsyncReadAll *data = g_task_get_task_data (task);
+  gboolean got_eof = FALSE;
+
+  if (result)
+    {
+      GError *error = NULL;
+      gssize nread;
+
+      nread = g_input_stream_read_finish (G_INPUT_STREAM (stream), result, &error);
+
+      if (nread == -1)
+        {
+          g_task_return_error (task, error);
+          g_object_unref (task);
+          return;
+        }
+
+      g_assert_cmpint (nread, <=, data->to_read);
+      data->to_read -= nread;
+      data->bytes_read += nread;
+      got_eof = (nread == 0);
+    }
+
+  if (got_eof || data->to_read == 0)
+    {
+      g_task_return_boolean (task, TRUE);
+      g_object_unref (task);
+    }
+
+  else
+    g_input_stream_read_async (G_INPUT_STREAM (stream),
+                               data->buffer + data->bytes_read,
+                               data->to_read,
+                               g_task_get_priority (task),
+                               g_task_get_cancellable (task),
+                               read_all_callback, task);
+}
+
+
+static void
+read_all_async_thread (GTask        *task,
+                       gpointer      source_object,
+                       gpointer      task_data,
+                       GCancellable *cancellable)
+{
+  GInputStream *stream = source_object;
+  AsyncReadAll *data = task_data;
+  GError *error = NULL;
+
+  if (g_input_stream_read_all (stream, data->buffer, data->to_read, &data->bytes_read,
+                               g_task_get_cancellable (task), &error))
+    g_task_return_boolean (task, TRUE);
+  else
+    g_task_return_error (task, error);
+}
+
+/**
+ * g_input_stream_read_all_async:
+ * @stream: A #GInputStream
+ * @buffer: (array length=count) (element-type guint8): a buffer to
+ *     read data into (which should be at least count bytes long)
+ * @count: the number of bytes that will be read from the stream
+ * @io_priority: the [I/O priority][io-priority] of the request
+ * @cancellable: (allow-none): optional #GCancellable object, %NULL to ignore
+ * @callback: (scope async): callback to call when the request is satisfied
+ * @user_data: (closure): the data to pass to callback function
+ *
+ * Request an asynchronous read of @count bytes from the stream into the
+ * buffer starting at @buffer.
+ *
+ * This is the asynchronous equivalent of g_input_stream_read_all().
+ *
+ * Call g_input_stream_read_all_finish() to collect the result.
+ *
+ * Any outstanding I/O request with higher priority (lower numerical
+ * value) will be executed before an outstanding request with lower
+ * priority. Default priority is %G_PRIORITY_DEFAULT.
+ *
+ * Since: 2.44
+ **/
+void
+g_input_stream_read_all_async (GInputStream        *stream,
+                               void                *buffer,
+                               gsize                count,
+                               int                  io_priority,
+                               GCancellable        *cancellable,
+                               GAsyncReadyCallback  callback,
+                               gpointer             user_data)
+{
+  AsyncReadAll *data;
+  GTask *task;
+
+  g_return_if_fail (G_IS_INPUT_STREAM (stream));
+  g_return_if_fail (buffer != NULL || count == 0);
+
+  task = g_task_new (stream, cancellable, callback, user_data);
+  data = g_slice_new0 (AsyncReadAll);
+  data->buffer = buffer;
+  data->to_read = count;
+
+  g_task_set_task_data (task, data, free_async_read_all);
+  g_task_set_priority (task, io_priority);
+
+  /* If async reads are going to be handled via the threadpool anyway
+   * then we may as well do it with a single dispatch instead of
+   * bouncing in and out.
+   */
+  if (g_input_stream_async_read_is_via_threads (stream))
+    {
+      g_task_run_in_thread (task, read_all_async_thread);
+      g_object_unref (task);
+    }
+  else
+    read_all_callback (G_OBJECT (stream), NULL, task);
+}
+
+/**
+ * g_input_stream_read_all_finish:
+ * @stream: a #GInputStream
+ * @result: a #GAsyncResult
+ * @bytes_read: (out): location to store the number of bytes that was read from the stream
+ * @error: a #GError location to store the error occurring, or %NULL to ignore
+ *
+ * Finishes an asynchronous stream read operation started with
+ * g_input_stream_read_all_async().
+ *
+ * As a special exception to the normal conventions for functions that
+ * use #GError, if this function returns %FALSE (and sets @error) then
+ * @bytes_read will be set to the number of bytes that were successfully
+ * read before the error was encountered.  This functionality is only
+ * available from C.  If you need it from another language then you must
+ * write your own loop around g_input_stream_read_async().
+ *
+ * Returns: %TRUE on success, %FALSE if there was an error
+ *
+ * Since: 2.44
+ **/
+gboolean
+g_input_stream_read_all_finish (GInputStream  *stream,
+                                GAsyncResult  *result,
+                                gsize         *bytes_read,
+                                GError       **error)
+{
+  GTask *task;
+
+  g_return_val_if_fail (G_IS_INPUT_STREAM (stream), FALSE);
+  g_return_val_if_fail (g_task_is_valid (result, stream), FALSE);
+
+  task = G_TASK (result);
+
+  if (bytes_read)
+    {
+      AsyncReadAll *data = g_task_get_task_data (task);
+
+      *bytes_read = data->bytes_read;
+    }
+
+  return g_task_propagate_boolean (task, error);
+}
+
 static void
 read_bytes_callback (GObject      *stream,
                     GAsyncResult *result,
                     gpointer      user_data)
 {
-  GSimpleAsyncResult *simple = user_data;
-  guchar *buf = g_simple_async_result_get_op_res_gpointer (simple);
+  GTask *task = user_data;
+  guchar *buf = g_task_get_task_data (task);
   GError *error = NULL;
   gssize nread;
   GBytes *bytes = NULL;
@@ -682,7 +856,7 @@ read_bytes_callback (GObject      *stream,
   if (nread == -1)
     {
       g_free (buf);
-      g_simple_async_result_take_error (simple, error);
+      g_task_return_error (task, error);
     }
   else if (nread == 0)
     {
@@ -693,20 +867,16 @@ read_bytes_callback (GObject      *stream,
     bytes = g_bytes_new_take (buf, nread);
 
   if (bytes)
-    {
-      g_simple_async_result_set_op_res_gpointer (simple, bytes,
-                                                (GDestroyNotify)g_bytes_unref);
-    }
-  g_simple_async_result_complete (simple);
-  g_object_unref (simple);
+    g_task_return_pointer (task, bytes, (GDestroyNotify)g_bytes_unref);
+
+  g_object_unref (task);
 }
 
 /**
  * g_input_stream_read_bytes_async:
  * @stream: A #GInputStream.
  * @count: the number of bytes that will be read from the stream
- * @io_priority: the <link linkend="io-priority">I/O priority</link>
- *   of the request.
+ * @io_priority: the [I/O priority][io-priority] of the request
  * @cancellable: (allow-none): optional #GCancellable object, %NULL to ignore.
  * @callback: (scope async): callback to call when the request is satisfied
  * @user_data: (closure): the data to pass to callback function
@@ -731,6 +901,8 @@ read_bytes_callback (GObject      *stream,
  * Any outstanding I/O request with higher priority (lower numerical
  * value) will be executed before an outstanding request with lower
  * priority. Default priority is %G_PRIORITY_DEFAULT.
+ *
+ * Since: 2.34
  **/
 void
 g_input_stream_read_bytes_async (GInputStream          *stream,
@@ -740,18 +912,16 @@ g_input_stream_read_bytes_async (GInputStream          *stream,
                                 GAsyncReadyCallback    callback,
                                 gpointer               user_data)
 {
-  GSimpleAsyncResult *simple;
+  GTask *task;
   guchar *buf;
 
-  simple = g_simple_async_result_new (G_OBJECT (stream),
-                                     callback, user_data,
-                                     g_input_stream_read_bytes_async);
+  task = g_task_new (stream, cancellable, callback, user_data);
   buf = g_malloc (count);
-  g_simple_async_result_set_op_res_gpointer (simple, buf, NULL);
+  g_task_set_task_data (task, buf, NULL);
 
   g_input_stream_read_async (stream, buf, count,
-                            io_priority, cancellable,
-                            read_bytes_callback, simple);
+                             io_priority, cancellable,
+                             read_bytes_callback, task);
 }
 
 /**
@@ -764,29 +934,25 @@ g_input_stream_read_bytes_async (GInputStream          *stream,
  * Finishes an asynchronous stream read-into-#GBytes operation.
  *
  * Returns: the newly-allocated #GBytes, or %NULL on error
+ *
+ * Since: 2.34
  **/
 GBytes *
 g_input_stream_read_bytes_finish (GInputStream  *stream,
                                  GAsyncResult  *result,
                                  GError       **error)
 {
-  GSimpleAsyncResult *simple;
-
   g_return_val_if_fail (G_IS_INPUT_STREAM (stream), NULL);
-  g_return_val_if_fail (g_simple_async_result_is_valid (result, G_OBJECT (stream), g_input_stream_read_bytes_async), NULL);
+  g_return_val_if_fail (g_task_is_valid (result, stream), NULL);
 
-  simple = G_SIMPLE_ASYNC_RESULT (result);
-  if (g_simple_async_result_propagate_error (simple, error))
-    return NULL;
-  return g_bytes_ref (g_simple_async_result_get_op_res_gpointer (simple));
+  return g_task_propagate_pointer (G_TASK (result), error);
 }
 
 /**
  * g_input_stream_skip_async:
  * @stream: A #GInputStream.
  * @count: the number of bytes that will be skipped from the stream
- * @io_priority: the <link linkend="io-priority">I/O priority</link>
- * of the request.
+ * @io_priority: the [I/O priority][io-priority] of the request
  * @cancellable: (allow-none): optional #GCancellable object, %NULL to ignore.
  * @callback: (scope async): callback to call when the request is satisfied
  * @user_data: (closure): the data to pass to callback function
@@ -824,40 +990,36 @@ g_input_stream_skip_async (GInputStream        *stream,
                           gpointer             user_data)
 {
   GInputStreamClass *class;
-  GSimpleAsyncResult *simple;
   GError *error = NULL;
 
   g_return_if_fail (G_IS_INPUT_STREAM (stream));
 
   if (count == 0)
     {
-      simple = g_simple_async_result_new (G_OBJECT (stream),
-                                         callback,
-                                         user_data,
-                                         g_input_stream_skip_async);
+      GTask *task;
 
-      g_simple_async_result_complete_in_idle (simple);
-      g_object_unref (simple);
+      task = g_task_new (stream, cancellable, callback, user_data);
+      g_task_set_source_tag (task, g_input_stream_skip_async);
+      g_task_return_int (task, 0);
+      g_object_unref (task);
       return;
     }
   
   if (((gssize) count) < 0)
     {
-      g_simple_async_report_error_in_idle (G_OBJECT (stream),
-                                          callback,
-                                          user_data,
-                                          G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
-                                          _("Too large count value passed to %s"),
-                                          G_STRFUNC);
+      g_task_report_new_error (stream, callback, user_data,
+                               g_input_stream_skip_async,
+                               G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
+                               _("Too large count value passed to %s"),
+                               G_STRFUNC);
       return;
     }
 
   if (!g_input_stream_set_pending (stream, &error))
     {
-      g_simple_async_report_take_gerror_in_idle (G_OBJECT (stream),
-                                           callback,
-                                           user_data,
-                                           error);
+      g_task_report_error (stream, callback, user_data,
+                           g_input_stream_skip_async,
+                           error);
       return;
     }
 
@@ -892,10 +1054,7 @@ g_input_stream_skip_finish (GInputStream  *stream,
   if (g_async_result_legacy_propagate_error (result, error))
     return -1;
   else if (g_async_result_is_tagged (result, g_input_stream_skip_async))
-    {
-      /* Special case skip of 0 bytes */
-      return 0;
-    }
+    return g_task_propagate_int (G_TASK (result), error);
 
   class = G_INPUT_STREAM_GET_CLASS (stream);
   return class->skip_finish (stream, result, error);
@@ -904,8 +1063,7 @@ g_input_stream_skip_finish (GInputStream  *stream,
 /**
  * g_input_stream_close_async:
  * @stream: A #GInputStream.
- * @io_priority: the <link linkend="io-priority">I/O priority</link> 
- * of the request. 
+ * @io_priority: the [I/O priority][io-priority] of the request
  * @cancellable: (allow-none): optional cancellable object
  * @callback: (scope async): callback to call when the request is satisfied
  * @user_data: (closure): the data to pass to callback function
@@ -929,29 +1087,26 @@ g_input_stream_close_async (GInputStream        *stream,
                            gpointer             user_data)
 {
   GInputStreamClass *class;
-  GSimpleAsyncResult *simple;
   GError *error = NULL;
 
   g_return_if_fail (G_IS_INPUT_STREAM (stream));
 
   if (stream->priv->closed)
     {
-      simple = g_simple_async_result_new (G_OBJECT (stream),
-                                         callback,
-                                         user_data,
-                                         g_input_stream_close_async);
+      GTask *task;
 
-      g_simple_async_result_complete_in_idle (simple);
-      g_object_unref (simple);
+      task = g_task_new (stream, cancellable, callback, user_data);
+      g_task_set_source_tag (task, g_input_stream_close_async);
+      g_task_return_boolean (task, TRUE);
+      g_object_unref (task);
       return;
     }
 
   if (!g_input_stream_set_pending (stream, &error))
     {
-      g_simple_async_report_take_gerror_in_idle (G_OBJECT (stream),
-                                           callback,
-                                           user_data,
-                                           error);
+      g_task_report_error (stream, callback, user_data,
+                           g_input_stream_close_async,
+                           error);
       return;
     }
   
@@ -986,10 +1141,7 @@ g_input_stream_close_finish (GInputStream  *stream,
   if (g_async_result_legacy_propagate_error (result, error))
     return FALSE;
   else if (g_async_result_is_tagged (result, g_input_stream_close_async))
-    {
-      /* Special case already closed */
-      return TRUE;
-    }
+    return g_task_propagate_boolean (G_TASK (result), error);
 
   class = G_INPUT_STREAM_GET_CLASS (stream);
   return class->close_finish (stream, result, error);
@@ -1037,7 +1189,7 @@ g_input_stream_has_pending (GInputStream *stream)
  * already set or @stream is closed, it will return %FALSE and set
  * @error.
  *
- * Return value: %TRUE if pending was previously unset and is now set.
+ * Returns: %TRUE if pending was previously unset and is now set.
  **/
 gboolean
 g_input_stream_set_pending (GInputStream *stream, GError **error)
@@ -1079,102 +1231,116 @@ g_input_stream_clear_pending (GInputStream *stream)
   stream->priv->pending = FALSE;
 }
 
+/**
+ * g_input_stream_async_read_is_via_threads:
+ * @stream: input stream
+ *
+ * Checks if an input stream's read_async function uses threads.
+ *
+ * Returns: %TRUE if @stream's read_async function uses threads.
+ **/
+gboolean
+g_input_stream_async_read_is_via_threads (GInputStream *stream)
+{
+  GInputStreamClass *class;
+
+  g_return_val_if_fail (G_IS_INPUT_STREAM (stream), FALSE);
+
+  class = G_INPUT_STREAM_GET_CLASS (stream);
+
+  return (class->read_async == g_input_stream_real_read_async &&
+      !(G_IS_POLLABLE_INPUT_STREAM (stream) &&
+        g_pollable_input_stream_can_poll (G_POLLABLE_INPUT_STREAM (stream))));
+}
+
 /********************************************
  *   Default implementation of async ops    *
  ********************************************/
 
 typedef struct {
-  void              *buffer;
-  gsize              count_requested;
-  gssize             count_read;
-
-  GCancellable      *cancellable;
-  gint               io_priority;
-  gboolean           need_idle;
+  void   *buffer;
+  gsize   count;
 } ReadData;
 
 static void
 free_read_data (ReadData *op)
 {
-  if (op->cancellable)
-    g_object_unref (op->cancellable);
   g_slice_free (ReadData, op);
 }
 
 static void
-read_async_thread (GSimpleAsyncResult *res,
-                  GObject            *object,
-                  GCancellable       *cancellable)
+read_async_thread (GTask        *task,
+                   gpointer      source_object,
+                   gpointer      task_data,
+                   GCancellable *cancellable)
 {
-  ReadData *op;
+  GInputStream *stream = source_object;
+  ReadData *op = task_data;
   GInputStreamClass *class;
   GError *error = NULL;
+  gssize nread;
  
-  op = g_simple_async_result_get_op_res_gpointer (res);
-
-  class = G_INPUT_STREAM_GET_CLASS (object);
+  class = G_INPUT_STREAM_GET_CLASS (stream);
 
-  op->count_read = class->read_fn (G_INPUT_STREAM (object),
-                                  op->buffer, op->count_requested,
-                                  cancellable, &error);
-  if (op->count_read == -1)
-    g_simple_async_result_take_error (res, error);
+  nread = class->read_fn (stream,
+                          op->buffer, op->count,
+                          g_task_get_cancellable (task),
+                          &error);
+  if (nread == -1)
+    g_task_return_error (task, error);
+  else
+    g_task_return_int (task, nread);
 }
 
 static void read_async_pollable (GPollableInputStream *stream,
-                                GSimpleAsyncResult   *result);
+                                 GTask                *task);
 
 static gboolean
 read_async_pollable_ready (GPollableInputStream *stream,
                           gpointer              user_data)
 {
-  GSimpleAsyncResult *result = user_data;
+  GTask *task = user_data;
 
-  read_async_pollable (stream, result);
+  read_async_pollable (stream, task);
   return FALSE;
 }
 
 static void
 read_async_pollable (GPollableInputStream *stream,
-                    GSimpleAsyncResult   *result)
+                     GTask                *task)
 {
+  ReadData *op = g_task_get_task_data (task);
   GError *error = NULL;
-  ReadData *op = g_simple_async_result_get_op_res_gpointer (result);
+  gssize nread;
 
-  if (g_cancellable_set_error_if_cancelled (op->cancellable, &error))
-    op->count_read = -1;
-  else
-    {
-      op->count_read = G_POLLABLE_INPUT_STREAM_GET_INTERFACE (stream)->
-       read_nonblocking (stream, op->buffer, op->count_requested, &error);
-    }
+  if (g_task_return_error_if_cancelled (task))
+    return;
+
+  nread = G_POLLABLE_INPUT_STREAM_GET_INTERFACE (stream)->
+    read_nonblocking (stream, op->buffer, op->count, &error);
 
   if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_WOULD_BLOCK))
     {
       GSource *source;
 
       g_error_free (error);
-      op->need_idle = FALSE;
-
-      source = g_pollable_input_stream_create_source (stream, op->cancellable);
-      g_source_set_callback (source,
-                            (GSourceFunc) read_async_pollable_ready,
-                            g_object_ref (result), g_object_unref);
-      g_source_set_priority (source, op->io_priority);
-      g_source_attach (source, g_main_context_get_thread_default ());
+
+      source = g_pollable_input_stream_create_source (stream,
+                                                      g_task_get_cancellable (task));
+      g_task_attach_source (task, source,
+                            (GSourceFunc) read_async_pollable_ready);
       g_source_unref (source);
       return;
     }
 
-  if (op->count_read == -1)
-    g_simple_async_result_take_error (result, error);
-
-  if (op->need_idle)
-    g_simple_async_result_complete_in_idle (result);
+  if (nread == -1)
+    g_task_return_error (task, error);
   else
-    g_simple_async_result_complete (result);
+    g_task_return_int (task, nread);
+  /* g_input_stream_real_read_async() unrefs task */
 }
 
+
 static void
 g_input_stream_real_read_async (GInputStream        *stream,
                                void                *buffer,
@@ -1184,24 +1350,21 @@ g_input_stream_real_read_async (GInputStream        *stream,
                                GAsyncReadyCallback  callback,
                                gpointer             user_data)
 {
-  GSimpleAsyncResult *res;
+  GTask *task;
   ReadData *op;
   
   op = g_slice_new0 (ReadData);
-  res = g_simple_async_result_new (G_OBJECT (stream), callback, user_data, g_input_stream_real_read_async);
-  g_simple_async_result_set_op_res_gpointer (res, op, (GDestroyNotify) free_read_data);
+  task = g_task_new (stream, cancellable, callback, user_data);
+  g_task_set_task_data (task, op, (GDestroyNotify) free_read_data);
+  g_task_set_priority (task, io_priority);
   op->buffer = buffer;
-  op->count_requested = count;
-  op->cancellable = cancellable ? g_object_ref (cancellable) : NULL;
-  op->io_priority = io_priority;
-  op->need_idle = TRUE;
-
-  if (G_IS_POLLABLE_INPUT_STREAM (stream) &&
-      g_pollable_input_stream_can_poll (G_POLLABLE_INPUT_STREAM (stream)))
-    read_async_pollable (G_POLLABLE_INPUT_STREAM (stream), res);
+  op->count = count;
+
+  if (!g_input_stream_async_read_is_via_threads (stream))
+    read_async_pollable (G_POLLABLE_INPUT_STREAM (stream), task);
   else
-    g_simple_async_result_run_in_thread (res, read_async_thread, io_priority, cancellable);
-  g_object_unref (res);
+    g_task_run_in_thread (task, read_async_thread);
+  g_object_unref (task);
 }
 
 static gssize
@@ -1209,52 +1372,38 @@ g_input_stream_real_read_finish (GInputStream  *stream,
                                 GAsyncResult  *result,
                                 GError       **error)
 {
-  GSimpleAsyncResult *simple = G_SIMPLE_ASYNC_RESULT (result);
-  ReadData *op;
-
-  g_warn_if_fail (g_simple_async_result_get_source_tag (simple) == 
-           g_input_stream_real_read_async);
-
-  if (g_simple_async_result_propagate_error (simple, error))
-    return -1;
-
-  op = g_simple_async_result_get_op_res_gpointer (simple);
+  g_return_val_if_fail (g_task_is_valid (result, stream), -1);
 
-  return op->count_read;
+  return g_task_propagate_int (G_TASK (result), error);
 }
 
-typedef struct {
-  gsize count_requested;
-  gssize count_skipped;
-} SkipData;
-
 
 static void
-skip_async_thread (GSimpleAsyncResult *res,
-                  GObject            *object,
-                  GCancellable       *cancellable)
+skip_async_thread (GTask        *task,
+                   gpointer      source_object,
+                   gpointer      task_data,
+                   GCancellable *cancellable)
 {
-  SkipData *op;
+  GInputStream *stream = source_object;
+  gsize count = GPOINTER_TO_SIZE (task_data);
   GInputStreamClass *class;
   GError *error = NULL;
-  
-  class = G_INPUT_STREAM_GET_CLASS (object);
-  op = g_simple_async_result_get_op_res_gpointer (res);
-  op->count_skipped = class->skip (G_INPUT_STREAM (object),
-                                  op->count_requested,
-                                  cancellable, &error);
-  if (op->count_skipped == -1)
-    g_simple_async_result_take_error (res, error);
+  gssize ret;
+
+  class = G_INPUT_STREAM_GET_CLASS (stream);
+  ret = class->skip (stream, count,
+                     g_task_get_cancellable (task),
+                     &error);
+  if (ret == -1)
+    g_task_return_error (task, error);
+  else
+    g_task_return_int (task, ret);
 }
 
 typedef struct {
   char buffer[8192];
   gsize count;
   gsize count_skipped;
-  int io_prio;
-  GCancellable *cancellable;
-  gpointer user_data;
-  GAsyncReadyCallback callback;
 } SkipFallbackAsyncData;
 
 static void
@@ -1263,9 +1412,8 @@ skip_callback_wrapper (GObject      *source_object,
                       gpointer      user_data)
 {
   GInputStreamClass *class;
-  SkipFallbackAsyncData *data = user_data;
-  SkipData *op;
-  GSimpleAsyncResult *simple;
+  GTask *task = user_data;
+  SkipFallbackAsyncData *data = g_task_get_task_data (task);
   GError *error = NULL;
   gssize ret;
 
@@ -1279,35 +1427,28 @@ skip_callback_wrapper (GObject      *source_object,
       if (data->count > 0)
        {
          class = G_INPUT_STREAM_GET_CLASS (source_object);
-         class->read_async (G_INPUT_STREAM (source_object), data->buffer, MIN (8192, data->count), data->io_prio, data->cancellable,
-                            skip_callback_wrapper, data);
+         class->read_async (G_INPUT_STREAM (source_object),
+                             data->buffer, MIN (8192, data->count),
+                             g_task_get_priority (task),
+                             g_task_get_cancellable (task),
+                             skip_callback_wrapper, task);
          return;
        }
     }
 
-  op = g_new0 (SkipData, 1);
-  op->count_skipped = data->count_skipped;
-  simple = g_simple_async_result_new (source_object,
-                                     data->callback, data->user_data,
-                                     g_input_stream_real_skip_async);
-
-  g_simple_async_result_set_op_res_gpointer (simple, op, g_free);
-
-  if (ret == -1)
+  if (ret == -1 &&
+      g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED) &&
+      data->count_skipped)
     {
-      if (data->count_skipped &&
-          g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED))
-       /* No error, return partial read */
-       g_error_free (error);
-      else
-       g_simple_async_result_take_error (simple, error);
+      /* No error, return partial read */
+      g_clear_error (&error);
     }
 
-  /* Complete immediately, not in idle, since we're already in a mainloop callout */
-  g_simple_async_result_complete (simple);
-  g_object_unref (simple);
-  
-  g_free (data);
+  if (error)
+    g_task_return_error (task, error);
+  else
+    g_task_return_int (task, data->count_skipped);
+  g_object_unref (task);
  }
 
 static void
@@ -1319,28 +1460,23 @@ g_input_stream_real_skip_async (GInputStream        *stream,
                                gpointer             user_data)
 {
   GInputStreamClass *class;
-  SkipData *op;
   SkipFallbackAsyncData *data;
-  GSimpleAsyncResult *res;
+  GTask *task;
 
   class = G_INPUT_STREAM_GET_CLASS (stream);
 
-  if (class->read_async == g_input_stream_real_read_async)
+  task = g_task_new (stream, cancellable, callback, user_data);
+  g_task_set_priority (task, io_priority);
+
+  if (g_input_stream_async_read_is_via_threads (stream))
     {
       /* Read is thread-using async fallback.
        * Make skip use threads too, so that we can use a possible sync skip
        * implementation. */
-      op = g_new0 (SkipData, 1);
-      
-      res = g_simple_async_result_new (G_OBJECT (stream), callback, user_data,
-                                      g_input_stream_real_skip_async);
-
-      g_simple_async_result_set_op_res_gpointer (res, op, g_free);
+      g_task_set_task_data (task, GSIZE_TO_POINTER (count), NULL);
 
-      op->count_requested = count;
-
-      g_simple_async_result_run_in_thread (res, skip_async_thread, io_priority, cancellable);
-      g_object_unref (res);
+      g_task_run_in_thread (task, skip_async_thread);
+      g_object_unref (task);
     }
   else
     {
@@ -1350,12 +1486,10 @@ g_input_stream_real_skip_async (GInputStream        *stream,
       data = g_new (SkipFallbackAsyncData, 1);
       data->count = count;
       data->count_skipped = 0;
-      data->io_prio = io_priority;
-      data->cancellable = cancellable;
-      data->callback = callback;
-      data->user_data = user_data;
+      g_task_set_task_data (task, data, g_free);
+      g_task_set_check_cancellable (task, FALSE);
       class->read_async (stream, data->buffer, MIN (8192, count), io_priority, cancellable,
-                        skip_callback_wrapper, data);
+                        skip_callback_wrapper, task);
     }
 
 }
@@ -1365,39 +1499,36 @@ g_input_stream_real_skip_finish (GInputStream  *stream,
                                 GAsyncResult  *result,
                                 GError       **error)
 {
-  GSimpleAsyncResult *simple = G_SIMPLE_ASYNC_RESULT (result);
-  SkipData *op;
-
-  g_warn_if_fail (g_simple_async_result_get_source_tag (simple) == g_input_stream_real_skip_async);
+  g_return_val_if_fail (g_task_is_valid (result, stream), -1);
 
-  if (g_simple_async_result_propagate_error (simple, error))
-    return -1;
-
-  op = g_simple_async_result_get_op_res_gpointer (simple);
-  return op->count_skipped;
+  return g_task_propagate_int (G_TASK (result), error);
 }
 
 static void
-close_async_thread (GSimpleAsyncResult *res,
-                   GObject            *object,
-                   GCancellable       *cancellable)
+close_async_thread (GTask        *task,
+                    gpointer      source_object,
+                    gpointer      task_data,
+                    GCancellable *cancellable)
 {
+  GInputStream *stream = source_object;
   GInputStreamClass *class;
   GError *error = NULL;
   gboolean result;
 
-  /* Auto handling of cancelation disabled, and ignore
-     cancellation, since we want to close things anyway, although
-     possibly in a quick-n-dirty way. At least we never want to leak
-     open handles */
-
-  class = G_INPUT_STREAM_GET_CLASS (object);
+  class = G_INPUT_STREAM_GET_CLASS (stream);
   if (class->close_fn)
     {
-      result = class->close_fn (G_INPUT_STREAM (object), cancellable, &error);
+      result = class->close_fn (stream,
+                                g_task_get_cancellable (task),
+                                &error);
       if (!result)
-        g_simple_async_result_take_error (res, error);
+        {
+          g_task_return_error (task, error);
+          return;
+        }
     }
+
+  g_task_return_boolean (task, TRUE);
 }
 
 static void
@@ -1407,20 +1538,14 @@ g_input_stream_real_close_async (GInputStream        *stream,
                                 GAsyncReadyCallback  callback,
                                 gpointer             user_data)
 {
-  GSimpleAsyncResult *res;
-  
-  res = g_simple_async_result_new (G_OBJECT (stream),
-                                  callback,
-                                  user_data,
-                                  g_input_stream_real_close_async);
+  GTask *task;
 
-  g_simple_async_result_set_handle_cancellation (res, FALSE);
+  task = g_task_new (stream, cancellable, callback, user_data);
+  g_task_set_check_cancellable (task, FALSE);
+  g_task_set_priority (task, io_priority);
   
-  g_simple_async_result_run_in_thread (res,
-                                      close_async_thread,
-                                      io_priority,
-                                      cancellable);
-  g_object_unref (res);
+  g_task_run_in_thread (task, close_async_thread);
+  g_object_unref (task);
 }
 
 static gboolean
@@ -1428,12 +1553,7 @@ g_input_stream_real_close_finish (GInputStream  *stream,
                                  GAsyncResult  *result,
                                  GError       **error)
 {
-  GSimpleAsyncResult *simple = G_SIMPLE_ASYNC_RESULT (result);
-
-  g_warn_if_fail (g_simple_async_result_get_source_tag (simple) == g_input_stream_real_close_async);
+  g_return_val_if_fail (g_task_is_valid (result, stream), FALSE);
 
-  if (g_simple_async_result_propagate_error (simple, error))
-    return FALSE;
-
-  return TRUE;
+  return g_task_propagate_boolean (G_TASK (result), error);
 }