Make sure compiled resources only have / as dirsep
[platform/upstream/glib.git] / gio / gdbusobjectproxy.c
index 263d06c..9788925 100644 (file)
@@ -13,9 +13,7 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General
- * Public License along with this library; if not, write to the
- * Free Software Foundation, Inc., 59 Temple Place, Suite 330,
- * Boston, MA 02111-1307, USA.
+ * Public License along with this library; if not, see <http://www.gnu.org/licenses/>.
  *
  * Author: David Zeuthen <davidz@redhat.com>
  */
  * @include: gio/gio.h
  *
  * A #GDBusObjectProxy is an object used to represent a remote object
- * with one or more D-Bus interfaces. You cannot instantiate a
- * #GDBusObjectProxy yourself - you need to use a
- * #GDBusObjectManagerClient to get one.
+ * with one or more D-Bus interfaces. Normally, you don't instantiate
+ * a #GDBusObjectProxy yourself - typically #GDBusObjectManagerClient
+ * is used to obtain it.
  *
  * Since: 2.30
  */
 
 struct _GDBusObjectProxyPrivate
 {
+  GMutex lock;
   GHashTable *map_name_to_iface;
   gchar *object_path;
   GDBusConnection *connection;
@@ -54,14 +53,15 @@ struct _GDBusObjectProxyPrivate
 enum
 {
   PROP_0,
-  PROP_OBJECT_PATH,
-  PROP_CONNECTION
+  PROP_G_OBJECT_PATH,
+  PROP_G_CONNECTION
 };
 
 static void dbus_object_interface_init (GDBusObjectIface *iface);
 
 G_DEFINE_TYPE_WITH_CODE (GDBusObjectProxy, g_dbus_object_proxy, G_TYPE_OBJECT,
-                         G_IMPLEMENT_INTERFACE (G_TYPE_DBUS_OBJECT, dbus_object_interface_init));
+                         G_ADD_PRIVATE (GDBusObjectProxy)
+                         G_IMPLEMENT_INTERFACE (G_TYPE_DBUS_OBJECT, dbus_object_interface_init))
 
 static void
 g_dbus_object_proxy_finalize (GObject *object)
@@ -70,6 +70,12 @@ g_dbus_object_proxy_finalize (GObject *object)
 
   g_hash_table_unref (proxy->priv->map_name_to_iface);
 
+  g_clear_object (&proxy->priv->connection);
+
+  g_free (proxy->priv->object_path);
+
+  g_mutex_clear (&proxy->priv->lock);
+
   if (G_OBJECT_CLASS (g_dbus_object_proxy_parent_class)->finalize != NULL)
     G_OBJECT_CLASS (g_dbus_object_proxy_parent_class)->finalize (object);
 }
@@ -84,16 +90,18 @@ g_dbus_object_proxy_get_property (GObject    *object,
 
   switch (prop_id)
     {
-    case PROP_OBJECT_PATH:
+    case PROP_G_OBJECT_PATH:
+      g_mutex_lock (&proxy->priv->lock);
       g_value_set_string (value, proxy->priv->object_path);
+      g_mutex_unlock (&proxy->priv->lock);
       break;
 
-    case PROP_CONNECTION:
+    case PROP_G_CONNECTION:
       g_value_set_object (value, g_dbus_object_proxy_get_connection (proxy));
       break;
 
     default:
-      G_OBJECT_WARN_INVALID_PROPERTY_ID (_object, prop_id, pspec);
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (proxy, prop_id, pspec);
       break;
     }
 }
@@ -104,10 +112,24 @@ g_dbus_object_proxy_set_property (GObject       *object,
                                   const GValue  *value,
                                   GParamSpec    *pspec)
 {
+  GDBusObjectProxy *proxy = G_DBUS_OBJECT_PROXY (object);
+
   switch (prop_id)
     {
+    case PROP_G_OBJECT_PATH:
+      g_mutex_lock (&proxy->priv->lock);
+      proxy->priv->object_path = g_value_dup_string (value);
+      g_mutex_unlock (&proxy->priv->lock);
+      break;
+
+    case PROP_G_CONNECTION:
+      g_mutex_lock (&proxy->priv->lock);
+      proxy->priv->connection = g_value_dup_object (value);
+      g_mutex_unlock (&proxy->priv->lock);
+      break;
+
     default:
-      G_OBJECT_WARN_INVALID_PROPERTY_ID (_object, prop_id, pspec);
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (proxy, prop_id, pspec);
       break;
     }
 }
@@ -122,46 +144,45 @@ g_dbus_object_proxy_class_init (GDBusObjectProxyClass *klass)
   gobject_class->get_property = g_dbus_object_proxy_get_property;
 
   /**
-   * GDBusObjectProxy:object-path:
+   * GDBusObjectProxy:g-object-path:
    *
    * The object path of the proxy.
    *
    * Since: 2.30
    */
   g_object_class_install_property (gobject_class,
-                                   PROP_OBJECT_PATH,
-                                   g_param_spec_string ("object-path",
+                                   PROP_G_OBJECT_PATH,
+                                   g_param_spec_string ("g-object-path",
                                                         "Object Path",
                                                         "The object path of the proxy",
                                                         NULL,
-                                                        G_PARAM_READABLE |
+                                                        G_PARAM_READWRITE |
+                                                        G_PARAM_CONSTRUCT_ONLY |
                                                         G_PARAM_STATIC_STRINGS));
 
   /**
-   * GDBusObjectProxy:connection:
+   * GDBusObjectProxy:g-connection:
    *
    * The connection of the proxy.
    *
    * Since: 2.30
    */
   g_object_class_install_property (gobject_class,
-                                   PROP_CONNECTION,
-                                   g_param_spec_string ("connection",
+                                   PROP_G_CONNECTION,
+                                   g_param_spec_object ("g-connection",
                                                         "Connection",
                                                         "The connection of the proxy",
-                                                        NULL,
-                                                        G_PARAM_READABLE |
+                                                        G_TYPE_DBUS_CONNECTION,
+                                                        G_PARAM_READWRITE |
+                                                        G_PARAM_CONSTRUCT_ONLY |
                                                         G_PARAM_STATIC_STRINGS));
-
-  g_type_class_add_private (klass, sizeof (GDBusObjectProxyPrivate));
 }
 
 static void
 g_dbus_object_proxy_init (GDBusObjectProxy *proxy)
 {
-  proxy->priv = G_TYPE_INSTANCE_GET_PRIVATE (proxy,
-                                             G_TYPE_DBUS_OBJECT_PROXY,
-                                             GDBusObjectProxyPrivate);
+  proxy->priv = g_dbus_object_proxy_get_instance_private (proxy);
+  g_mutex_init (&proxy->priv->lock);
   proxy->priv->map_name_to_iface = g_hash_table_new_full (g_str_hash,
                                                           g_str_equal,
                                                           g_free,
@@ -172,24 +193,33 @@ static const gchar *
 g_dbus_object_proxy_get_object_path (GDBusObject *object)
 {
   GDBusObjectProxy *proxy = G_DBUS_OBJECT_PROXY (object);
-  return proxy->priv->object_path;
+  const gchar *ret;
+  g_mutex_lock (&proxy->priv->lock);
+  ret = proxy->priv->object_path;
+  g_mutex_unlock (&proxy->priv->lock);
+  return ret;
 }
 
 /**
  * g_dbus_object_proxy_get_connection:
- * @proxy: A #GDBusObjectProxy.
+ * @proxy: a #GDBusObjectProxy
  *
  * Gets the connection that @proxy is for.
  *
- * Returns: A #GDBusConnection. Do not free, the object is owned by @proxy.
+ * Returns: (transfer none): A #GDBusConnection. Do not free, the
+ *   object is owned by @proxy.
  *
  * Since: 2.30
  */
 GDBusConnection *
 g_dbus_object_proxy_get_connection (GDBusObjectProxy *proxy)
 {
+  GDBusConnection *ret;
   g_return_val_if_fail (G_IS_DBUS_OBJECT_PROXY (proxy), NULL);
-  return proxy->priv->connection;
+  g_mutex_lock (&proxy->priv->lock);
+  ret = proxy->priv->connection;
+  g_mutex_unlock (&proxy->priv->lock);
+  return ret;
 }
 
 static GDBusInterface *
@@ -202,9 +232,12 @@ g_dbus_object_proxy_get_interface (GDBusObject *object,
   g_return_val_if_fail (G_IS_DBUS_OBJECT_PROXY (proxy), NULL);
   g_return_val_if_fail (g_dbus_is_interface_name (interface_name), NULL);
 
+  g_mutex_lock (&proxy->priv->lock);
   ret = g_hash_table_lookup (proxy->priv->map_name_to_iface, interface_name);
   if (ret != NULL)
     g_object_ref (ret);
+  g_mutex_unlock (&proxy->priv->lock);
+
   return (GDBusInterface *) ret; /* TODO: proper cast */
 }
 
@@ -213,35 +246,43 @@ g_dbus_object_proxy_get_interfaces (GDBusObject *object)
 {
   GDBusObjectProxy *proxy = G_DBUS_OBJECT_PROXY (object);
   GList *ret;
-  GHashTableIter iter;
-  GDBusProxy *interface_proxy;
 
   g_return_val_if_fail (G_IS_DBUS_OBJECT_PROXY (proxy), NULL);
 
   ret = NULL;
 
-  g_hash_table_iter_init (&iter, proxy->priv->map_name_to_iface);
-  while (g_hash_table_iter_next (&iter, NULL, (gpointer) &interface_proxy))
-    ret = g_list_prepend (ret, g_object_ref (interface_proxy));
+  g_mutex_lock (&proxy->priv->lock);
+  ret = g_hash_table_get_values (proxy->priv->map_name_to_iface);
+  g_list_foreach (ret, (GFunc) g_object_ref, NULL);
+  g_mutex_unlock (&proxy->priv->lock);
 
   return ret;
 }
 
 /* ---------------------------------------------------------------------------------------------------- */
 
+/**
+ * g_dbus_object_proxy_new:
+ * @connection: a #GDBusConnection
+ * @object_path: the object path
+ *
+ * Creates a new #GDBusObjectProxy for the given connection and
+ * object path.
+ *
+ * Returns: a new #GDBusObjectProxy
+ *
+ * Since: 2.30
+ */
 GDBusObjectProxy *
-_g_dbus_object_proxy_new (GDBusConnection *connection,
-                          const gchar *object_path)
+g_dbus_object_proxy_new (GDBusConnection *connection,
+                         const gchar     *object_path)
 {
-  GDBusObjectProxy *proxy;
-
   g_return_val_if_fail (G_IS_DBUS_CONNECTION (connection), NULL);
   g_return_val_if_fail (g_variant_is_object_path (object_path), NULL);
-
-  proxy = G_DBUS_OBJECT_PROXY (g_object_new (G_TYPE_DBUS_OBJECT_PROXY, NULL));
-  proxy->priv->object_path = g_strdup (object_path);
-  proxy->priv->connection = g_object_ref (connection);
-  return proxy;
+  return G_DBUS_OBJECT_PROXY (g_object_new (G_TYPE_DBUS_OBJECT_PROXY,
+                                            "g-object-path", object_path,
+                                            "g-connection", connection,
+                                            NULL));
 }
 
 void
@@ -249,16 +290,35 @@ _g_dbus_object_proxy_add_interface (GDBusObjectProxy *proxy,
                                     GDBusProxy       *interface_proxy)
 {
   const gchar *interface_name;
+  GDBusProxy *interface_proxy_to_remove;
 
   g_return_if_fail (G_IS_DBUS_OBJECT_PROXY (proxy));
   g_return_if_fail (G_IS_DBUS_PROXY (interface_proxy));
 
+  g_mutex_lock (&proxy->priv->lock);
+
   interface_name = g_dbus_proxy_get_interface_name (interface_proxy);
-  _g_dbus_object_proxy_remove_interface (proxy, interface_name);
+  interface_proxy_to_remove = g_hash_table_lookup (proxy->priv->map_name_to_iface, interface_name);
+  if (interface_proxy_to_remove != NULL)
+    {
+      g_object_ref (interface_proxy_to_remove);
+      g_warn_if_fail (g_hash_table_remove (proxy->priv->map_name_to_iface, interface_name));
+    }
   g_hash_table_insert (proxy->priv->map_name_to_iface,
                        g_strdup (interface_name),
                        g_object_ref (interface_proxy));
+  g_object_ref (interface_proxy);
+
+  g_mutex_unlock (&proxy->priv->lock);
+
+  if (interface_proxy_to_remove != NULL)
+    {
+      g_signal_emit_by_name (proxy, "interface-removed", interface_proxy_to_remove);
+      g_object_unref (interface_proxy_to_remove);
+    }
+
   g_signal_emit_by_name (proxy, "interface-added", interface_proxy);
+  g_object_unref (interface_proxy);
 }
 
 void
@@ -270,46 +330,21 @@ _g_dbus_object_proxy_remove_interface (GDBusObjectProxy *proxy,
   g_return_if_fail (G_IS_DBUS_OBJECT_PROXY (proxy));
   g_return_if_fail (g_dbus_is_interface_name (interface_name));
 
+  g_mutex_lock (&proxy->priv->lock);
+
   interface_proxy = g_hash_table_lookup (proxy->priv->map_name_to_iface, interface_name);
   if (interface_proxy != NULL)
     {
       g_object_ref (interface_proxy);
       g_warn_if_fail (g_hash_table_remove (proxy->priv->map_name_to_iface, interface_name));
+      g_mutex_unlock (&proxy->priv->lock);
       g_signal_emit_by_name (proxy, "interface-removed", interface_proxy);
       g_object_unref (interface_proxy);
     }
-}
-
-static gpointer
-g_dbus_object_proxy_lookup_with_typecheck (GDBusObject *object,
-                                           const gchar *interface_name,
-                                           GType        type)
-{
-  GDBusObjectProxy *proxy = G_DBUS_OBJECT_PROXY (object);
-  GDBusProxy *ret;
-
-  g_return_val_if_fail (G_IS_DBUS_OBJECT_PROXY (proxy), NULL);
-  g_return_val_if_fail (g_dbus_is_interface_name (interface_name), NULL);
-
-  ret = g_hash_table_lookup (proxy->priv->map_name_to_iface, interface_name);
-  if (ret != NULL)
+  else
     {
-      g_warn_if_fail (G_TYPE_CHECK_INSTANCE_TYPE (ret, type));
-      g_object_ref (ret);
+      g_mutex_unlock (&proxy->priv->lock);
     }
-  return ret;
-}
-
-static gpointer
-g_dbus_object_proxy_peek_with_typecheck (GDBusObject  *object,
-                                         const gchar  *interface_name,
-                                         GType         type)
-{
-  GDBusProxy *ret;
-  ret = g_dbus_object_proxy_lookup_with_typecheck (object, interface_name, type);
-  if (ret != NULL)
-    g_object_unref (ret);
-  return ret;
 }
 
 static void
@@ -318,6 +353,4 @@ dbus_object_interface_init (GDBusObjectIface *iface)
   iface->get_object_path       = g_dbus_object_proxy_get_object_path;
   iface->get_interfaces        = g_dbus_object_proxy_get_interfaces;
   iface->get_interface         = g_dbus_object_proxy_get_interface;
-  iface->peek_with_typecheck   = g_dbus_object_proxy_peek_with_typecheck;
-  iface->lookup_with_typecheck = g_dbus_object_proxy_lookup_with_typecheck;
 }