gdbus: Include changed properties only once per signal
[platform/upstream/connman.git] / gdbus / watch.c
index 9a716b0..9e4f994 100644 (file)
@@ -78,7 +78,7 @@ struct filter_data {
        gboolean registered;
 };
 
-static struct filter_data *filter_data_find(DBusConnection *connection,
+static struct filter_data *filter_data_find_match(DBusConnection *connection,
                                                        const char *name,
                                                        const char *owner,
                                                        const char *path,
@@ -95,28 +95,39 @@ static struct filter_data *filter_data_find(DBusConnection *connection,
                if (connection != data->connection)
                        continue;
 
-               if (name && data->name &&
-                               g_str_equal(name, data->name) == FALSE)
+               if (g_strcmp0(name, data->name) != 0)
                        continue;
 
-               if (owner && data->owner &&
-                               g_str_equal(owner, data->owner) == FALSE)
+               if (g_strcmp0(owner, data->owner) != 0)
                        continue;
 
-               if (path && data->path &&
-                               g_str_equal(path, data->path) == FALSE)
+               if (g_strcmp0(path, data->path) != 0)
                        continue;
 
-               if (interface && data->interface &&
-                               g_str_equal(interface, data->interface) == FALSE)
+               if (g_strcmp0(interface, data->interface) != 0)
                        continue;
 
-               if (member && data->member &&
-                               g_str_equal(member, data->member) == FALSE)
+               if (g_strcmp0(member, data->member) != 0)
                        continue;
 
-               if (argument && data->argument &&
-                               g_str_equal(argument, data->argument) == FALSE)
+               if (g_strcmp0(argument, data->argument) != 0)
+                       continue;
+
+               return data;
+       }
+
+       return NULL;
+}
+
+static struct filter_data *filter_data_find(DBusConnection *connection)
+{
+       GSList *current;
+
+       for (current = listeners;
+                       current != NULL; current = current->next) {
+               struct filter_data *data = current->data;
+
+               if (connection != data->connection)
                        continue;
 
                return data;
@@ -204,7 +215,7 @@ static struct filter_data *filter_data_get(DBusConnection *connection,
        struct filter_data *data;
        const char *name = NULL, *owner = NULL;
 
-       if (filter_data_find(connection, NULL, NULL, NULL, NULL, NULL, NULL) == NULL) {
+       if (filter_data_find(connection) == NULL) {
                if (!dbus_connection_add_filter(connection,
                                        message_filter, NULL, NULL)) {
                        error("dbus_connection_add_filter() failed");
@@ -221,16 +232,16 @@ static struct filter_data *filter_data_get(DBusConnection *connection,
                name = sender;
 
 proceed:
-       data = filter_data_find(connection, name, owner, path, interface,
-                                       member, argument);
+       data = filter_data_find_match(connection, name, owner, path,
+                                               interface, member, argument);
        if (data)
                return data;
 
        data = g_new0(struct filter_data, 1);
 
        data->connection = dbus_connection_ref(connection);
-       data->name = name ? g_strdup(name) : NULL;
-       data->owner = owner ? g_strdup(owner) : NULL;
+       data->name = g_strdup(name);
+       data->owner = g_strdup(owner);
        data->path = g_strdup(path);
        data->interface = g_strdup(interface);
        data->member = g_strdup(member);
@@ -376,15 +387,13 @@ static gboolean filter_data_remove_callback(struct filter_data *data,
 
        connection = dbus_connection_ref(data->connection);
        listeners = g_slist_remove(listeners, data);
-       filter_data_free(data);
 
        /* Remove filter if there are no listeners left for the connection */
-       data = filter_data_find(connection, NULL, NULL, NULL, NULL, NULL,
-                                       NULL);
-       if (data == NULL)
+       if (filter_data_find(connection) == NULL)
                dbus_connection_remove_filter(connection, message_filter,
                                                NULL);
 
+       filter_data_free(data);
        dbus_connection_unref(connection);
 
        return TRUE;
@@ -502,6 +511,7 @@ static DBusHandlerResult message_filter(DBusConnection *connection,
 {
        struct filter_data *data;
        const char *sender, *path, *iface, *member, *arg = NULL;
+       GSList *current, *delete_listener = NULL;
 
        /* Only filter signals */
        if (dbus_message_get_type(message) != DBUS_MESSAGE_TYPE_SIGNAL)
@@ -513,36 +523,66 @@ static DBusHandlerResult message_filter(DBusConnection *connection,
        member = dbus_message_get_member(message);
        dbus_message_get_args(message, NULL, DBUS_TYPE_STRING, &arg, DBUS_TYPE_INVALID);
 
-       /* Sender is always bus name */
-       data = filter_data_find(connection, NULL, sender, path, iface, member,
-                                       arg);
-       if (data == NULL) {
-               error("Got %s.%s signal which has no listeners", iface, member);
-               return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
-       }
+       /* Sender is always the owner */
+
+       for (current = listeners; current != NULL; current = current->next) {
+               data = current->data;
+
+               if (connection != data->connection)
+                       continue;
+
+               if (data->owner && g_str_equal(sender, data->owner) == FALSE)
+                       continue;
+
+               if (data->path && g_str_equal(path, data->path) == FALSE)
+                       continue;
+
+               if (data->interface && g_str_equal(iface,
+                                               data->interface) == FALSE)
+                       continue;
+
+               if (data->member && g_str_equal(member, data->member) == FALSE)
+                       continue;
+
+               if (data->argument && g_str_equal(arg,
+                                               data->argument) == FALSE)
+                       continue;
 
-       if (data->handle_func) {
-               data->lock = TRUE;
+               if (data->handle_func) {
+                       data->lock = TRUE;
 
-               data->handle_func(connection, message, data);
+                       data->handle_func(connection, message, data);
 
-               data->callbacks = data->processed;
-               data->processed = NULL;
-               data->lock = FALSE;
+                       data->callbacks = data->processed;
+                       data->processed = NULL;
+                       data->lock = FALSE;
+               }
+
+               if (!data->callbacks)
+                       delete_listener = g_slist_prepend(delete_listener,
+                                                               current);
        }
 
-       if (data->callbacks)
-               return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
+       for (current = delete_listener; current != NULL;
+                                       current = delete_listener->next) {
+               GSList *l = current->data;
 
-       remove_match(data);
+               data = l->data;
 
-       listeners = g_slist_remove(listeners, data);
-       filter_data_free(data);
+               /* Has any other callback added callbacks back to this data? */
+               if (data->callbacks != NULL)
+                       continue;
 
-       /* Remove filter if there no listener left for the connection */
-       data = filter_data_find(connection, NULL, NULL, NULL, NULL, NULL,
-                                       NULL);
-       if (data == NULL)
+               remove_match(data);
+               listeners = g_slist_delete_link(listeners, l);
+
+               filter_data_free(data);
+       }
+
+       g_slist_free(delete_listener);
+
+       /* Remove filter if there are no listeners left for the connection */
+       if (filter_data_find(connection) == NULL)
                dbus_connection_remove_filter(connection, message_filter,
                                                NULL);
 
@@ -712,6 +752,34 @@ guint g_dbus_add_signal_watch(DBusConnection *connection,
        return cb->id;
 }
 
+guint g_dbus_add_properties_watch(DBusConnection *connection,
+                               const char *sender, const char *path,
+                               const char *interface,
+                               GDBusSignalFunction function, void *user_data,
+                               GDBusDestroyFunction destroy)
+{
+       struct filter_data *data;
+       struct filter_callback *cb;
+
+       data = filter_data_get(connection, signal_filter, sender, path,
+                               DBUS_INTERFACE_PROPERTIES, "PropertiesChanged",
+                               interface);
+       if (data == NULL)
+               return 0;
+
+       cb = filter_data_add_callback(data, NULL, NULL, function, destroy,
+                                       user_data);
+       if (cb == NULL)
+               return 0;
+
+       if (data->name != NULL && data->name_watch == 0)
+               data->name_watch = g_dbus_add_service_watch(connection,
+                                                       data->name, NULL,
+                                                       NULL, NULL, NULL);
+
+       return cb->id;
+}
+
 gboolean g_dbus_remove_watch(DBusConnection *connection, guint id)
 {
        struct filter_data *data;
@@ -738,8 +806,7 @@ void g_dbus_remove_all_watches(DBusConnection *connection)
 {
        struct filter_data *data;
 
-       while ((data = filter_data_find(connection, NULL, NULL, NULL, NULL,
-                                       NULL, NULL))) {
+       while ((data = filter_data_find(connection))) {
                listeners = g_slist_remove(listeners, data);
                filter_data_call_and_free(data);
        }