daily update
[external/binutils.git] / gdb / dbxread.c
index 5b2c80a..447e64e 100644 (file)
@@ -1,13 +1,13 @@
 /* Read dbx symbol tables and convert to internal format, for GDB.
-   Copyright 1986, 1987, 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995,
-   1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004.
+   Copyright (C) 1986, 1987, 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995,
+   1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2008, 2009, 2010.
    Free Software Foundation, Inc.
 
    This file is part of GDB.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
 
    This program is distributed in the hope that it will be useful,
@@ -16,9 +16,7 @@
    GNU General Public License for more details.
 
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place - Suite 330,
-   Boston, MA 02111-1307, USA.  */
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 /* This module provides three functions: dbx_symfile_init,
    which initializes to read a symbol file; dbx_new_init, which 
@@ -56,6 +54,8 @@
 #include "demangle.h"
 #include "complaints.h"
 #include "cp-abi.h"
+#include "cp-support.h"
+#include "psympriv.h"
 
 #include "gdb_assert.h"
 #include "gdb_string.h"
@@ -177,7 +177,8 @@ static void
 repeated_header_complaint (const char *arg1, int arg2)
 {
   complaint (&symfile_complaints,
-            _("\"repeated\" header file %s not previously seen, at symtab pos %d"),
+            _("\"repeated\" header file %s not previously seen, at symtab \
+pos %d"),
             arg1, arg2);
 }
 
@@ -395,7 +396,7 @@ add_new_header_file (char *name, int instance)
 
   i = N_HEADER_FILES (current_objfile)++;
   hfile = HEADER_FILES (current_objfile) + i;
-  hfile->name = savestring (name, strlen (name));
+  hfile->name = xstrdup (name);
   hfile->instance = instance;
   hfile->length = 10;
   hfile->vector
@@ -514,19 +515,16 @@ record_minimal_symbol (char *name, CORE_ADDR address, int type,
     lowest_text_address = address;
 
   prim_record_minimal_symbol_and_info
-    (name, address, ms_type, NULL, section, bfd_section, objfile);
+    (name, address, ms_type, section, bfd_section, objfile);
 }
 \f
 /* Scan and build partial symbols for a symbol file.
    We have been initialized by a call to dbx_symfile_init, which 
    put all the relevant info into a "struct dbx_symfile_info",
-   hung off the objfile structure.
-
-   MAINLINE is true if we are reading the main symbol
-   table (as opposed to a shared lib or dynamically loaded file).  */
+   hung off the objfile structure.  */
 
 static void
-dbx_symfile_read (struct objfile *objfile, int mainline)
+dbx_symfile_read (struct objfile *objfile, int symfile_flags)
 {
   bfd *sym_bfd;
   int val;
@@ -556,10 +554,8 @@ dbx_symfile_read (struct objfile *objfile, int mainline)
   if (val < 0)
     perror_with_name (objfile->name);
 
-  /* If we are reinitializing, or if we have never loaded syms yet, init */
-  if (mainline
-      || (objfile->global_psymbols.size == 0
-         &&  objfile->static_psymbols.size == 0))
+  /* Size the symbol table.  */
+  if (objfile->global_psymbols.size == 0 && objfile->static_psymbols.size == 0)
     init_psymbol_list (objfile, DBX_SYMCOUNT (objfile));
 
   symbol_size = DBX_SYMBOL_SIZE (objfile);
@@ -627,7 +623,8 @@ dbx_symfile_init (struct objfile *objfile)
   /* Allocate struct to keep track of the symfile */
   objfile->deprecated_sym_stab_info = (struct dbx_symfile_info *)
     xmalloc (sizeof (struct dbx_symfile_info));
-  memset (objfile->deprecated_sym_stab_info, 0, sizeof (struct dbx_symfile_info));
+  memset (objfile->deprecated_sym_stab_info, 0,
+         sizeof (struct dbx_symfile_info));
 
   DBX_TEXT_SECTION (objfile) = bfd_get_section_by_name (sym_bfd, ".text");
   DBX_DATA_SECTION (objfile) = bfd_get_section_by_name (sym_bfd, ".data");
@@ -850,8 +847,9 @@ stabs_seek (int sym_offset)
 
 #define INTERNALIZE_SYMBOL(intern, extern, abfd)                       \
   {                                                                    \
-    (intern).n_type = bfd_h_get_8 (abfd, (extern)->e_type);            \
     (intern).n_strx = bfd_h_get_32 (abfd, (extern)->e_strx);           \
+    (intern).n_type = bfd_h_get_8 (abfd, (extern)->e_type);            \
+    (intern).n_other = 0;                                              \
     (intern).n_desc = bfd_h_get_16 (abfd, (extern)->e_desc);           \
     if (bfd_get_sign_extend_vma (abfd))                                        \
       (intern).n_value = bfd_h_get_signed_32 (abfd, (extern)->e_value);        \
@@ -959,20 +957,21 @@ make_cleanup_free_bincl_list (struct objfile *objfile)
    rather than abort the symbol reading or flood the user with messages.  */
 
 static char *
-set_namestring (struct objfile *objfile, struct internal_nlist nlist)
+set_namestring (struct objfile *objfile, const struct internal_nlist *nlist)
 {
   char *namestring;
 
-  if (((unsigned) nlist.n_strx + file_string_table_offset) >=
-      DBX_STRINGTAB_SIZE (objfile))
+  if (nlist->n_strx + file_string_table_offset
+      >= DBX_STRINGTAB_SIZE (objfile)
+      || nlist->n_strx + file_string_table_offset < nlist->n_strx)
     {
       complaint (&symfile_complaints, _("bad string table offset in symbol %d"),
                 symnum);
       namestring = "<bad string table offset>";
     } 
   else
-    namestring = nlist.n_strx + file_string_table_offset +
-      DBX_STRINGTAB (objfile);
+    namestring = (nlist->n_strx + file_string_table_offset
+                 + DBX_STRINGTAB (objfile));
   return namestring;
 }
 
@@ -1038,17 +1037,20 @@ read_dbx_dynamic_symtab (struct objfile *objfile)
 
          if (bfd_get_section_flags (abfd, sec) & SEC_CODE)
            {
-             sym_value += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
+             sym_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_TEXT (objfile));
              type = N_TEXT;
            }
          else if (bfd_get_section_flags (abfd, sec) & SEC_DATA)
            {
-             sym_value += ANOFFSET (objfile->section_offsets, SECT_OFF_DATA (objfile));
+             sym_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_DATA (objfile));
              type = N_DATA;
            }
          else if (bfd_get_section_flags (abfd, sec) & SEC_ALLOC)
            {
-             sym_value += ANOFFSET (objfile->section_offsets, SECT_OFF_BSS (objfile));
+             sym_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_BSS (objfile));
              type = N_BSS;
            }
          else
@@ -1089,7 +1091,8 @@ read_dbx_dynamic_symtab (struct objfile *objfile)
     {
       arelent *rel = *relptr;
       CORE_ADDR address =
-      rel->address + ANOFFSET (objfile->section_offsets, SECT_OFF_DATA (objfile));
+      rel->address + ANOFFSET (objfile->section_offsets,
+                              SECT_OFF_DATA (objfile));
 
       switch (bfd_get_arch (abfd))
        {
@@ -1118,7 +1121,6 @@ read_dbx_dynamic_symtab (struct objfile *objfile)
   do_cleanups (back_to);
 }
 
-#ifdef SOFUN_ADDRESS_MAYBE_MISSING
 static CORE_ADDR
 find_stab_function_addr (char *namestring, char *filename,
                         struct objfile *objfile)
@@ -1162,13 +1164,13 @@ find_stab_function_addr (char *namestring, char *filename,
 
   return msym == NULL ? 0 : SYMBOL_VALUE_ADDRESS (msym);
 }
-#endif /* SOFUN_ADDRESS_MAYBE_MISSING */
 
 static void
 function_outside_compilation_unit_complaint (const char *arg1)
 {
   complaint (&symfile_complaints,
-            _("function `%s' appears to be defined outside of all compilation units"),
+            _("function `%s' appears to be defined outside of all compilation \
+units"),
             arg1);
 }
 
@@ -1178,10 +1180,13 @@ function_outside_compilation_unit_complaint (const char *arg1)
 static void
 read_dbx_symtab (struct objfile *objfile)
 {
+  struct gdbarch *gdbarch = get_objfile_arch (objfile);
   struct external_nlist *bufp = 0;     /* =0 avoids gcc -Wall glitch */
   struct internal_nlist nlist;
   CORE_ADDR text_addr;
   int text_size;
+  char *sym_name;
+  int sym_len;
 
   char *namestring;
   int nsl;
@@ -1309,125 +1314,131 @@ read_dbx_symtab (struct objfile *objfile)
 
       switch (nlist.n_type)
        {
-         char *p;
          /*
           * Standard, external, non-debugger, symbols
           */
 
-         case N_TEXT | N_EXT:
-         case N_NBTEXT | N_EXT:
-         nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
+       case N_TEXT | N_EXT:
+       case N_NBTEXT | N_EXT:
+         nlist.n_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_TEXT (objfile));
          goto record_it;
 
-         case N_DATA | N_EXT:
-         case N_NBDATA | N_EXT:
-         nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_DATA (objfile));
+       case N_DATA | N_EXT:
+       case N_NBDATA | N_EXT:
+         nlist.n_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_DATA (objfile));
          goto record_it;
 
-         case N_BSS:
-         case N_BSS | N_EXT:
-         case N_NBBSS | N_EXT:
-         case N_SETV | N_EXT:          /* FIXME, is this in BSS? */
-         nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_BSS (objfile));
+       case N_BSS:
+       case N_BSS | N_EXT:
+       case N_NBBSS | N_EXT:
+       case N_SETV | N_EXT:            /* FIXME, is this in BSS? */
+         nlist.n_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_BSS (objfile));
          goto record_it;
 
-         case N_ABS | N_EXT:
+       case N_ABS | N_EXT:
          record_it:
-         namestring = set_namestring (objfile, nlist);
+         namestring = set_namestring (objfile, &nlist);
 
-         bss_ext_symbol:
+       bss_ext_symbol:
          record_minimal_symbol (namestring, nlist.n_value,
                                 nlist.n_type, objfile);        /* Always */
          continue;
 
          /* Standard, local, non-debugger, symbols */
 
-         case N_NBTEXT:
+       case N_NBTEXT:
 
          /* We need to be able to deal with both N_FN or N_TEXT,
             because we have no way of knowing whether the sys-supplied ld
             or GNU ld was used to make the executable.  Sequents throw
             in another wrinkle -- they renumbered N_FN.  */
 
-         case N_FN:
-         case N_FN_SEQ:
-         case N_TEXT:
-         nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
-         namestring = set_namestring (objfile, nlist);
+       case N_FN:
+       case N_FN_SEQ:
+       case N_TEXT:
+         nlist.n_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_TEXT (objfile));
+         namestring = set_namestring (objfile, &nlist);
 
          if ((namestring[0] == '-' && namestring[1] == 'l')
              || (namestring[(nsl = strlen (namestring)) - 1] == 'o'
                  && namestring[nsl - 2] == '.'))
-         {
-           if (past_first_source_file && pst
-               /* The gould NP1 uses low values for .o and -l symbols
-                  which are not the address.  */
-               && nlist.n_value >= pst->textlow)
-             {
-               end_psymtab (pst, psymtab_include_list, includes_used,
-                            symnum * symbol_size,
-                            nlist.n_value > pst->texthigh
-                            ? nlist.n_value : pst->texthigh,
-                            dependency_list, dependencies_used, textlow_not_set);
-               pst = (struct partial_symtab *) 0;
-               includes_used = 0;
-               dependencies_used = 0;
-             }
-           else
-             past_first_source_file = 1;
-           last_o_file_start = nlist.n_value;
-         }
+           {
+             if (past_first_source_file && pst
+                 /* The gould NP1 uses low values for .o and -l symbols
+                    which are not the address.  */
+                 && nlist.n_value >= pst->textlow)
+               {
+                 end_psymtab (pst, psymtab_include_list, includes_used,
+                              symnum * symbol_size,
+                              nlist.n_value > pst->texthigh
+                              ? nlist.n_value : pst->texthigh,
+                              dependency_list, dependencies_used,
+                              textlow_not_set);
+                 pst = (struct partial_symtab *) 0;
+                 includes_used = 0;
+                 dependencies_used = 0;
+                 has_line_numbers = 0;
+               }
+             else
+               past_first_source_file = 1;
+             last_o_file_start = nlist.n_value;
+           }
          else
-         goto record_it;
+           goto record_it;
          continue;
 
-         case N_DATA:
-         nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_DATA (objfile));
+       case N_DATA:
+         nlist.n_value += ANOFFSET (objfile->section_offsets,
+                                    SECT_OFF_DATA (objfile));
          goto record_it;
 
-         case N_UNDF | N_EXT:
+       case N_UNDF | N_EXT:
          if (nlist.n_value != 0)
-         {
-           /* This is a "Fortran COMMON" symbol.  See if the target
-              environment knows where it has been relocated to.  */
+           {
+             /* This is a "Fortran COMMON" symbol.  See if the target
+                environment knows where it has been relocated to.  */
 
-           CORE_ADDR reladdr;
+             CORE_ADDR reladdr;
 
-           namestring = set_namestring (objfile, nlist);
-           if (target_lookup_symbol (namestring, &reladdr))
-             {
-               continue;               /* Error in lookup; ignore symbol for now.  */
-             }
-           nlist.n_type ^= (N_BSS ^ N_UNDF);   /* Define it as a bss-symbol */
-           nlist.n_value = reladdr;
-           goto bss_ext_symbol;
-         }
+             namestring = set_namestring (objfile, &nlist);
+             if (target_lookup_symbol (namestring, &reladdr))
+               {
+                 continue;     /* Error in lookup; ignore symbol for now.  */
+               }
+             nlist.n_type ^= (N_BSS ^ N_UNDF); /* Define it as a bss-symbol */
+             nlist.n_value = reladdr;
+             goto bss_ext_symbol;
+           }
          continue;                     /* Just undefined, not COMMON */
 
-         case N_UNDF:
+       case N_UNDF:
          if (processing_acc_compilation && nlist.n_strx == 1)
-         {
-           /* Deal with relative offsets in the string table
-              used in ELF+STAB under Solaris.  If we want to use the
-              n_strx field, which contains the name of the file,
-              we must adjust file_string_table_offset *before* calling
-              set_namestring().  */
-           past_first_source_file = 1;
-           file_string_table_offset = next_file_string_table_offset;
-           next_file_string_table_offset =
-             file_string_table_offset + nlist.n_value;
-           if (next_file_string_table_offset < file_string_table_offset)
-             error (_("string table offset backs up at %d"), symnum);
-           /* FIXME -- replace error() with complaint.  */
-           continue;
-         }
+           {
+             /* Deal with relative offsets in the string table
+                used in ELF+STAB under Solaris.  If we want to use the
+                n_strx field, which contains the name of the file,
+                we must adjust file_string_table_offset *before* calling
+                set_namestring().  */
+             past_first_source_file = 1;
+             file_string_table_offset = next_file_string_table_offset;
+             next_file_string_table_offset =
+               file_string_table_offset + nlist.n_value;
+             if (next_file_string_table_offset < file_string_table_offset)
+               error (_("string table offset backs up at %d"), symnum);
+             /* FIXME -- replace error() with complaint.  */
+             continue;
+           }
          continue;
 
          /* Lots of symbol types we can just ignore.  */
 
-         case N_ABS:
-         case N_NBDATA:
-         case N_NBBSS:
+       case N_ABS:
+       case N_NBDATA:
+       case N_NBBSS:
          continue;
 
          /* Keep going . . . */
@@ -1435,24 +1446,24 @@ read_dbx_symtab (struct objfile *objfile)
          /*
           * Special symbol types for GNU
           */
-         case N_INDR:
-         case N_INDR | N_EXT:
-         case N_SETA:
-         case N_SETA | N_EXT:
-         case N_SETT:
-         case N_SETT | N_EXT:
-         case N_SETD:
-         case N_SETD | N_EXT:
-         case N_SETB:
-         case N_SETB | N_EXT:
-         case N_SETV:
+       case N_INDR:
+       case N_INDR | N_EXT:
+       case N_SETA:
+       case N_SETA | N_EXT:
+       case N_SETT:
+       case N_SETT | N_EXT:
+       case N_SETD:
+       case N_SETD | N_EXT:
+       case N_SETB:
+       case N_SETB | N_EXT:
+       case N_SETV:
          continue;
 
          /*
           * Debugger symbols
           */
 
-         case N_SO:
+       case N_SO:
          {
            CORE_ADDR valu;
            static int prev_so_symnum = -10;
@@ -1461,25 +1472,24 @@ read_dbx_symtab (struct objfile *objfile)
            static char *dirname_nso;
            int prev_textlow_not_set;
 
-           valu = nlist.n_value + ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
+           valu = nlist.n_value + ANOFFSET (objfile->section_offsets,
+                                            SECT_OFF_TEXT (objfile));
 
            prev_textlow_not_set = textlow_not_set;
 
-#ifdef SOFUN_ADDRESS_MAYBE_MISSING
            /* A zero value is probably an indication for the SunPRO 3.0
               compiler. end_psymtab explicitly tests for zero, so
               don't relocate it.  */
 
-           if (nlist.n_value == 0)
+           if (nlist.n_value == 0
+               && gdbarch_sofun_address_maybe_missing (gdbarch))
              {
                textlow_not_set = 1;
                valu = 0;
              }
            else
              textlow_not_set = 0;
-#else
-           textlow_not_set = 0;
-#endif
+
            past_first_source_file = 1;
 
            if (prev_so_symnum != symnum - 1)
@@ -1496,6 +1506,7 @@ read_dbx_symtab (struct objfile *objfile)
                    pst = (struct partial_symtab *) 0;
                    includes_used = 0;
                    dependencies_used = 0;
+                   has_line_numbers = 0;
                  }
              }
 
@@ -1503,7 +1514,7 @@ read_dbx_symtab (struct objfile *objfile)
 
            /* End the current partial symtab and start a new one */
 
-           namestring = set_namestring (objfile, nlist);
+           namestring = set_namestring (objfile, &nlist);
 
            /* Null name means end of .o file.  Don't start a new one. */
            if (*namestring == '\000')
@@ -1524,30 +1535,30 @@ read_dbx_symtab (struct objfile *objfile)
              }
 
            /* Some other compilers (C++ ones in particular) emit useless
-              SOs for non-existant .c files.  We ignore all subsequent SOs that
-              immediately follow the first.  */
+              SOs for non-existant .c files.  We ignore all subsequent SOs
+              that immediately follow the first.  */
 
            if (!pst)
              {
-             pst = start_psymtab (objfile,
-                                  namestring, valu,
-                                  first_so_symnum * symbol_size,
-                                  objfile->global_psymbols.next,
-                                  objfile->static_psymbols.next);
+               pst = start_psymtab (objfile,
+                                    namestring, valu,
+                                    first_so_symnum * symbol_size,
+                                    objfile->global_psymbols.next,
+                                    objfile->static_psymbols.next);
                pst->dirname = dirname_nso;
                dirname_nso = NULL;
              }
            continue;
          }
 
-         case N_BINCL:
+       case N_BINCL:
          {
            enum language tmp_language;
            /* Add this bincl to the bincl_list for future EXCLs.  No
               need to save the string; it'll be around until
               read_dbx_symtab function returns */
 
-           namestring = set_namestring (objfile, nlist);
+           namestring = set_namestring (objfile, &nlist);
            tmp_language = deduce_language_from_filename (namestring);
 
            /* Only change the psymtab's language if we've learned
@@ -1557,17 +1568,18 @@ read_dbx_symtab (struct objfile *objfile)
            if (tmp_language != language_unknown
                && (tmp_language != language_c
                    || psymtab_language != language_cplus))
-           psymtab_language = tmp_language;
+             psymtab_language = tmp_language;
 
            if (pst == NULL)
-           {
-             /* FIXME: we should not get here without a PST to work on.
-                Attempt to recover.  */
-             complaint (&symfile_complaints,
-                        _("N_BINCL %s not in entries for any file, at symtab pos %d"),
-                        namestring, symnum);
-             continue;
-           }
+             {
+               /* FIXME: we should not get here without a PST to work on.
+                  Attempt to recover.  */
+               complaint (&symfile_complaints,
+                          _("N_BINCL %s not in entries for any file, at symtab \
+pos %d"),
+                          namestring, symnum);
+               continue;
+             }
            add_bincl_to_list (pst, namestring, nlist.n_value);
 
            /* Mark down an include file in the current psymtab */
@@ -1575,12 +1587,12 @@ read_dbx_symtab (struct objfile *objfile)
            goto record_include_file;
          }
 
-         case N_SOL:
+       case N_SOL:
          {
            enum language tmp_language;
            /* Mark down an include file in the current psymtab */
 
-           namestring = set_namestring (objfile, nlist);
+           namestring = set_namestring (objfile, &nlist);
            tmp_language = deduce_language_from_filename (namestring);
 
            /* Only change the psymtab's language if we've learned
@@ -1590,7 +1602,7 @@ read_dbx_symtab (struct objfile *objfile)
            if (tmp_language != language_unknown
                && (tmp_language != language_c
                    || psymtab_language != language_cplus))
-           psymtab_language = tmp_language;
+             psymtab_language = tmp_language;
 
            /* In C++, one may expect the same filename to come round many
               times, when code is coming alternately from the main file
@@ -1603,7 +1615,7 @@ read_dbx_symtab (struct objfile *objfile)
               suppose the psymtab_include_list could be hashed or put
               in a binary tree, if profiling shows this is a major hog).  */
            if (pst && strcmp (namestring, pst->filename) == 0)
-           continue;
+             continue;
            {
              int i;
              for (i = 0; i < includes_used; i++)
@@ -1616,60 +1628,83 @@ read_dbx_symtab (struct objfile *objfile)
                continue;
            }
 
-           record_include_file:
+         record_include_file:
 
            psymtab_include_list[includes_used++] = namestring;
            if (includes_used >= includes_allocated)
-           {
-             char **orig = psymtab_include_list;
+             {
+               char **orig = psymtab_include_list;
 
-             psymtab_include_list = (char **)
-               alloca ((includes_allocated *= 2) *
-                       sizeof (char *));
-             memcpy (psymtab_include_list, orig,
-                     includes_used * sizeof (char *));
-           }
+               psymtab_include_list = (char **)
+                 alloca ((includes_allocated *= 2) * sizeof (char *));
+               memcpy (psymtab_include_list, orig,
+                       includes_used * sizeof (char *));
+             }
            continue;
          }
-         case N_LSYM:                  /* Typedef or automatic variable. */
-         case N_STSYM:         /* Data seg var -- static  */
-         case N_LCSYM:         /* BSS      "  */
-         case N_ROSYM:         /* Read-only data seg var -- static.  */
-         case N_NBSTS:         /* Gould nobase.  */
-         case N_NBLCS:         /* symbols.  */
-         case N_FUN:
-         case N_GSYM:                  /* Global (extern) variable; can be
-                                          data or bss (sigh FIXME).  */
+       case N_LSYM:            /* Typedef or automatic variable. */
+       case N_STSYM:           /* Data seg var -- static  */
+       case N_LCSYM:           /* BSS      "  */
+       case N_ROSYM:           /* Read-only data seg var -- static.  */
+       case N_NBSTS:           /* Gould nobase.  */
+       case N_NBLCS:           /* symbols.  */
+       case N_FUN:
+       case N_GSYM:            /* Global (extern) variable; can be
+                                  data or bss (sigh FIXME).  */
 
          /* Following may probably be ignored; I'll leave them here
             for now (until I do Pascal and Modula 2 extensions).  */
 
-         case N_PC:                    /* I may or may not need this; I
-                                          suspect not.  */
-         case N_M2C:                   /* I suspect that I can ignore this here. */
-         case N_SCOPE:         /* Same.   */
+       case N_PC:              /* I may or may not need this; I
+                                  suspect not.  */
+       case N_M2C:             /* I suspect that I can ignore this here. */
+       case N_SCOPE:           /* Same.   */
+       {
+         char *p;
 
-         namestring = set_namestring (objfile, nlist);
+         namestring = set_namestring (objfile, &nlist);
 
          /* See if this is an end of function stab.  */
          if (pst && nlist.n_type == N_FUN && *namestring == '\000')
-         {
-           CORE_ADDR valu;
-
-           /* It's value is the size (in bytes) of the function for
-              function relative stabs, or the address of the function's
-              end for old style stabs.  */
-           valu = nlist.n_value + last_function_start;
-           if (pst->texthigh == 0 || valu > pst->texthigh)
-             pst->texthigh = valu;
-           break;
-         }
+           {
+             CORE_ADDR valu;
+
+             /* It's value is the size (in bytes) of the function for
+                function relative stabs, or the address of the function's
+                end for old style stabs.  */
+             valu = nlist.n_value + last_function_start;
+             if (pst->texthigh == 0 || valu > pst->texthigh)
+               pst->texthigh = valu;
+             break;
+           }
 
          p = (char *) strchr (namestring, ':');
          if (!p)
-         continue;                     /* Not a debugging symbol.   */
+           continue;                   /* Not a debugging symbol.   */
 
+         sym_len = 0;
+         sym_name = NULL;      /* pacify "gcc -Werror" */
+         if (psymtab_language == language_cplus)
+           {
+             char *new_name, *name = xmalloc (p - namestring + 1);
+             memcpy (name, namestring, p - namestring);
+             name[p - namestring] = '\0';
+             new_name = cp_canonicalize_string (name);
+             if (new_name != NULL)
+               {
+                 sym_len = strlen (new_name);
+                 sym_name = obsavestring (new_name, sym_len,
+                                          &objfile->objfile_obstack);
+                 xfree (new_name);
+               }
+              xfree (name);
+           }
 
+         if (sym_len == 0)
+           {
+             sym_name = namestring;
+             sym_len = p - namestring;
+           }
 
          /* Main processing section for debugging symbols which
             the initial read through the symbol tables needs to worry
@@ -1679,320 +1714,334 @@ read_dbx_symtab (struct objfile *objfile)
             which indicates the debugging type symbol.  */
 
          switch (p[1])
-         {
-         case 'S':
-           nlist.n_value += ANOFFSET (objfile->section_offsets, data_sect_index);
-#ifdef STATIC_TRANSFORM_NAME
-           namestring = STATIC_TRANSFORM_NAME (namestring);
-#endif
-           add_psymbol_to_list (namestring, p - namestring,
-                                VAR_DOMAIN, LOC_STATIC,
-                                &objfile->static_psymbols,
-                                0, nlist.n_value,
-                                psymtab_language, objfile);
-           continue;
-         case 'G':
-           nlist.n_value += ANOFFSET (objfile->section_offsets, data_sect_index);
-           /* The addresses in these entries are reported to be
-              wrong.  See the code that reads 'G's for symtabs. */
-           add_psymbol_to_list (namestring, p - namestring,
-                                VAR_DOMAIN, LOC_STATIC,
-                                &objfile->global_psymbols,
-                                0, nlist.n_value,
-                                psymtab_language, objfile);
-           continue;
+           {
+           case 'S':
+             nlist.n_value += ANOFFSET (objfile->section_offsets,
+                                        data_sect_index);
+
+             if (gdbarch_static_transform_name_p (gdbarch))
+               namestring = gdbarch_static_transform_name (gdbarch,
+                                                           namestring);
+
+             add_psymbol_to_list (sym_name, sym_len, 1,
+                                  VAR_DOMAIN, LOC_STATIC,
+                                  &objfile->static_psymbols,
+                                  0, nlist.n_value,
+                                  psymtab_language, objfile);
+             continue;
 
-         case 'T':
-           /* When a 'T' entry is defining an anonymous enum, it
-              may have a name which is the empty string, or a
-              single space.  Since they're not really defining a
-              symbol, those shouldn't go in the partial symbol
-              table.  We do pick up the elements of such enums at
-              'check_enum:', below.  */
-           if (p >= namestring + 2
-               || (p == namestring + 1
-                   && namestring[0] != ' '))
-             {
-               add_psymbol_to_list (namestring, p - namestring,
-                                    STRUCT_DOMAIN, LOC_TYPEDEF,
-                                    &objfile->static_psymbols,
-                                    nlist.n_value, 0,
-                                    psymtab_language, objfile);
-               if (p[2] == 't')
-                 {
-                   /* Also a typedef with the same name.  */
-                   add_psymbol_to_list (namestring, p - namestring,
-                                        VAR_DOMAIN, LOC_TYPEDEF,
-                                        &objfile->static_psymbols,
-                                        nlist.n_value, 0,
-                                        psymtab_language, objfile);
-                   p += 1;
-                 }
-             }
-           goto check_enum;
-         case 't':
-           if (p != namestring)        /* a name is there, not just :T... */
-             {
-               add_psymbol_to_list (namestring, p - namestring,
-                                    VAR_DOMAIN, LOC_TYPEDEF,
-                                    &objfile->static_psymbols,
-                                    nlist.n_value, 0,
-                                    psymtab_language, objfile);
-             }
-         check_enum:
-           /* If this is an enumerated type, we need to
-              add all the enum constants to the partial symbol
-              table.  This does not cover enums without names, e.g.
-              "enum {a, b} c;" in C, but fortunately those are
-              rare.  There is no way for GDB to find those from the
-              enum type without spending too much time on it.  Thus
-              to solve this problem, the compiler needs to put out the
-              enum in a nameless type.  GCC2 does this.  */
-
-           /* We are looking for something of the form
-              <name> ":" ("t" | "T") [<number> "="] "e"
-              {<constant> ":" <value> ","} ";".  */
-
-           /* Skip over the colon and the 't' or 'T'.  */
-           p += 2;
-           /* This type may be given a number.  Also, numbers can come
-              in pairs like (0,26).  Skip over it.  */
-           while ((*p >= '0' && *p <= '9')
-                  || *p == '(' || *p == ',' || *p == ')'
-                  || *p == '=')
-             p++;
-
-           if (*p++ == 'e')
-             {
-               /* The aix4 compiler emits extra crud before the members.  */
-               if (*p == '-')
-                 {
-                   /* Skip over the type (?).  */
-                   while (*p != ':')
-                     p++;
+           case 'G':
+             nlist.n_value += ANOFFSET (objfile->section_offsets,
+                                        data_sect_index);
+             /* The addresses in these entries are reported to be
+                wrong.  See the code that reads 'G's for symtabs. */
+             add_psymbol_to_list (sym_name, sym_len, 1,
+                                  VAR_DOMAIN, LOC_STATIC,
+                                  &objfile->global_psymbols,
+                                  0, nlist.n_value,
+                                  psymtab_language, objfile);
+             continue;
 
-                   /* Skip over the colon.  */
-                   p++;
-                 }
+           case 'T':
+             /* When a 'T' entry is defining an anonymous enum, it
+                may have a name which is the empty string, or a
+                single space.  Since they're not really defining a
+                symbol, those shouldn't go in the partial symbol
+                table.  We do pick up the elements of such enums at
+                'check_enum:', below.  */
+             if (p >= namestring + 2
+                 || (p == namestring + 1
+                     && namestring[0] != ' '))
+               {
+                 add_psymbol_to_list (sym_name, sym_len, 1,
+                                      STRUCT_DOMAIN, LOC_TYPEDEF,
+                                      &objfile->static_psymbols,
+                                      nlist.n_value, 0,
+                                      psymtab_language, objfile);
+                 if (p[2] == 't')
+                   {
+                     /* Also a typedef with the same name.  */
+                     add_psymbol_to_list (sym_name, sym_len, 1,
+                                          VAR_DOMAIN, LOC_TYPEDEF,
+                                          &objfile->static_psymbols,
+                                          nlist.n_value, 0,
+                                          psymtab_language, objfile);
+                     p += 1;
+                   }
+               }
+             goto check_enum;
 
-               /* We have found an enumerated type.  */
-               /* According to comments in read_enum_type
-                  a comma could end it instead of a semicolon.
-                  I don't know where that happens.
-                  Accept either.  */
-               while (*p && *p != ';' && *p != ',')
-                 {
-                   char *q;
-
-                   /* Check for and handle cretinous dbx symbol name
-                      continuation!  */
-                   if (*p == '\\' || (*p == '?' && p[1] == '\0'))
-                     p = next_symbol_text (objfile);
-
-                   /* Point to the character after the name
-                      of the enum constant.  */
-                   for (q = p; *q && *q != ':'; q++)
-                     ;
-                   /* Note that the value doesn't matter for
-                      enum constants in psymtabs, just in symtabs.  */
-                   add_psymbol_to_list (p, q - p,
-                                        VAR_DOMAIN, LOC_CONST,
-                                        &objfile->static_psymbols, 0,
-                                        0, psymtab_language, objfile);
-                   /* Point past the name.  */
-                   p = q;
-                   /* Skip over the value.  */
-                   while (*p && *p != ',')
-                     p++;
-                   /* Advance past the comma.  */
-                   if (*p)
+           case 't':
+             if (p != namestring)      /* a name is there, not just :T... */
+               {
+                 add_psymbol_to_list (sym_name, sym_len, 1,
+                                      VAR_DOMAIN, LOC_TYPEDEF,
+                                      &objfile->static_psymbols,
+                                      nlist.n_value, 0,
+                                      psymtab_language, objfile);
+               }
+           check_enum:
+             /* If this is an enumerated type, we need to
+                add all the enum constants to the partial symbol
+                table.  This does not cover enums without names, e.g.
+                "enum {a, b} c;" in C, but fortunately those are
+                rare.  There is no way for GDB to find those from the
+                enum type without spending too much time on it.  Thus
+                to solve this problem, the compiler needs to put out the
+                enum in a nameless type.  GCC2 does this.  */
+
+             /* We are looking for something of the form
+                <name> ":" ("t" | "T") [<number> "="] "e"
+                {<constant> ":" <value> ","} ";".  */
+
+             /* Skip over the colon and the 't' or 'T'.  */
+             p += 2;
+             /* This type may be given a number.  Also, numbers can come
+                in pairs like (0,26).  Skip over it.  */
+             while ((*p >= '0' && *p <= '9')
+                    || *p == '(' || *p == ',' || *p == ')'
+                    || *p == '=')
+               p++;
+
+             if (*p++ == 'e')
+               {
+                 /* The aix4 compiler emits extra crud before the members.  */
+                 if (*p == '-')
+                   {
+                     /* Skip over the type (?).  */
+                     while (*p != ':')
+                       p++;
+
+                     /* Skip over the colon.  */
                      p++;
-                 }
-             }
-           continue;
-         case 'c':
-           /* Constant, e.g. from "const" in Pascal.  */
-           add_psymbol_to_list (namestring, p - namestring,
-                                VAR_DOMAIN, LOC_CONST,
-                                &objfile->static_psymbols, nlist.n_value,
-                                0, psymtab_language, objfile);
-           continue;
+                   }
 
-         case 'f':
-           if (! pst)
-             {
-               int name_len = p - namestring;
-               char *name = xmalloc (name_len + 1);
-               memcpy (name, namestring, name_len);
-               name[name_len] = '\0';
-               function_outside_compilation_unit_complaint (name);
-               xfree (name);
-             }
-           nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
-           /* Kludges for ELF/STABS with Sun ACC */
-           last_function_name = namestring;
-#ifdef SOFUN_ADDRESS_MAYBE_MISSING
-           /* Do not fix textlow==0 for .o or NLM files, as 0 is a legit
-              value for the bottom of the text seg in those cases. */
-           if (nlist.n_value == ANOFFSET (objfile->section_offsets, 
-                                          SECT_OFF_TEXT (objfile)))
-             {
-               CORE_ADDR minsym_valu = 
-                 find_stab_function_addr (namestring, pst->filename, objfile);
-               /* find_stab_function_addr will return 0 if the minimal
-                  symbol wasn't found.  (Unfortunately, this might also
-                  be a valid address.)  Anyway, if it *does* return 0,
-                  it is likely that the value was set correctly to begin
-                  with... */
-               if (minsym_valu != 0)
-                 nlist.n_value = minsym_valu;
-             }
-           if (pst && textlow_not_set)
-             {
-               pst->textlow = nlist.n_value;
-               textlow_not_set = 0;
-             }
-#endif
-           /* End kludge.  */
-
-           /* Keep track of the start of the last function so we
-              can handle end of function symbols.  */
-           last_function_start = nlist.n_value;
-
-           /* In reordered executables this function may lie outside
-              the bounds created by N_SO symbols.  If that's the case
-              use the address of this function as the low bound for
-              the partial symbol table.  */
-           if (pst
-               && (textlow_not_set
-                   || (nlist.n_value < pst->textlow
-                       && (nlist.n_value
-                           != ANOFFSET (objfile->section_offsets,
-                                        SECT_OFF_TEXT (objfile))))))
-             {
-               pst->textlow = nlist.n_value;
-               textlow_not_set = 0;
-             }
-           add_psymbol_to_list (namestring, p - namestring,
-                                VAR_DOMAIN, LOC_BLOCK,
-                                &objfile->static_psymbols,
-                                0, nlist.n_value,
-                                psymtab_language, objfile);
-           continue;
+                 /* We have found an enumerated type.  */
+                 /* According to comments in read_enum_type
+                    a comma could end it instead of a semicolon.
+                    I don't know where that happens.
+                    Accept either.  */
+                 while (*p && *p != ';' && *p != ',')
+                   {
+                     char *q;
+
+                     /* Check for and handle cretinous dbx symbol name
+                        continuation!  */
+                     if (*p == '\\' || (*p == '?' && p[1] == '\0'))
+                       p = next_symbol_text (objfile);
+
+                     /* Point to the character after the name
+                        of the enum constant.  */
+                     for (q = p; *q && *q != ':'; q++)
+                       ;
+                     /* Note that the value doesn't matter for
+                        enum constants in psymtabs, just in symtabs.  */
+                     add_psymbol_to_list (p, q - p, 1,
+                                          VAR_DOMAIN, LOC_CONST,
+                                          &objfile->static_psymbols, 0,
+                                          0, psymtab_language, objfile);
+                     /* Point past the name.  */
+                     p = q;
+                     /* Skip over the value.  */
+                     while (*p && *p != ',')
+                       p++;
+                     /* Advance past the comma.  */
+                     if (*p)
+                       p++;
+                   }
+               }
+             continue;
 
-           /* Global functions were ignored here, but now they
-              are put into the global psymtab like one would expect.
-              They're also in the minimal symbol table.  */
-         case 'F':
-           if (! pst)
-             {
-               int name_len = p - namestring;
-               char *name = xmalloc (name_len + 1);
-               memcpy (name, namestring, name_len);
-               name[name_len] = '\0';
-               function_outside_compilation_unit_complaint (name);
-               xfree (name);
-             }
-           nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
-           /* Kludges for ELF/STABS with Sun ACC */
-           last_function_name = namestring;
-#ifdef SOFUN_ADDRESS_MAYBE_MISSING
-           /* Do not fix textlow==0 for .o or NLM files, as 0 is a legit
-              value for the bottom of the text seg in those cases. */
-           if (nlist.n_value == ANOFFSET (objfile->section_offsets, 
-                                          SECT_OFF_TEXT (objfile)))
-             {
-               CORE_ADDR minsym_valu = 
-                 find_stab_function_addr (namestring, pst->filename, objfile);
-               /* find_stab_function_addr will return 0 if the minimal
-                  symbol wasn't found.  (Unfortunately, this might also
-                  be a valid address.)  Anyway, if it *does* return 0,
-                  it is likely that the value was set correctly to begin
-                  with... */
-               if (minsym_valu != 0)
-                 nlist.n_value = minsym_valu;
-             }
-           if (pst && textlow_not_set)
-             {
-               pst->textlow = nlist.n_value;
-               textlow_not_set = 0;
-             }
-#endif
-           /* End kludge.  */
-
-           /* Keep track of the start of the last function so we
-              can handle end of function symbols.  */
-           last_function_start = nlist.n_value;
-
-           /* In reordered executables this function may lie outside
-              the bounds created by N_SO symbols.  If that's the case
-              use the address of this function as the low bound for
-              the partial symbol table.  */
-           if (pst
-               && (textlow_not_set
-                   || (nlist.n_value < pst->textlow
-                       && (nlist.n_value
-                           != ANOFFSET (objfile->section_offsets,
-                                        SECT_OFF_TEXT (objfile))))))
-             {
-               pst->textlow = nlist.n_value;
-               textlow_not_set = 0;
-             }
-           add_psymbol_to_list (namestring, p - namestring,
-                                VAR_DOMAIN, LOC_BLOCK,
-                                &objfile->global_psymbols,
-                                0, nlist.n_value,
-                                psymtab_language, objfile);
-           continue;
+           case 'c':
+             /* Constant, e.g. from "const" in Pascal.  */
+             add_psymbol_to_list (sym_name, sym_len, 1,
+                                  VAR_DOMAIN, LOC_CONST,
+                                  &objfile->static_psymbols, nlist.n_value,
+                                  0, psymtab_language, objfile);
+             continue;
 
-           /* Two things show up here (hopefully); static symbols of
-              local scope (static used inside braces) or extensions
-              of structure symbols.  We can ignore both.  */
-         case 'V':
-         case '(':
-         case '0':
-         case '1':
-         case '2':
-         case '3':
-         case '4':
-         case '5':
-         case '6':
-         case '7':
-         case '8':
-         case '9':
-         case '-':
-         case '#':             /* for symbol identification (used in live ranges) */
-           continue;
+           case 'f':
+             if (! pst)
+               {
+                 int name_len = p - namestring;
+                 char *name = xmalloc (name_len + 1);
+                 memcpy (name, namestring, name_len);
+                 name[name_len] = '\0';
+                 function_outside_compilation_unit_complaint (name);
+                 xfree (name);
+               }
+             nlist.n_value += ANOFFSET (objfile->section_offsets, 
+                                        SECT_OFF_TEXT (objfile));
+             /* Kludges for ELF/STABS with Sun ACC */
+             last_function_name = namestring;
+             /* Do not fix textlow==0 for .o or NLM files, as 0 is a legit
+                value for the bottom of the text seg in those cases. */
+             if (nlist.n_value == ANOFFSET (objfile->section_offsets, 
+                                            SECT_OFF_TEXT (objfile))
+                 && gdbarch_sofun_address_maybe_missing (gdbarch))
+               {
+                 CORE_ADDR minsym_valu = 
+                   find_stab_function_addr (namestring, 
+                                            pst ? pst->filename : NULL, 
+                                            objfile);
+                 /* find_stab_function_addr will return 0 if the minimal
+                    symbol wasn't found.  (Unfortunately, this might also
+                    be a valid address.)  Anyway, if it *does* return 0,
+                    it is likely that the value was set correctly to begin
+                    with... */
+                 if (minsym_valu != 0)
+                   nlist.n_value = minsym_valu;
+               }
+             if (pst && textlow_not_set
+                 && gdbarch_sofun_address_maybe_missing (gdbarch))
+               {
+                 pst->textlow = nlist.n_value;
+                 textlow_not_set = 0;
+               }
+             /* End kludge.  */
+
+             /* Keep track of the start of the last function so we
+                can handle end of function symbols.  */
+             last_function_start = nlist.n_value;
+
+             /* In reordered executables this function may lie outside
+                the bounds created by N_SO symbols.  If that's the case
+                use the address of this function as the low bound for
+                the partial symbol table.  */
+             if (pst
+                 && (textlow_not_set
+                     || (nlist.n_value < pst->textlow
+                         && (nlist.n_value
+                             != ANOFFSET (objfile->section_offsets,
+                                          SECT_OFF_TEXT (objfile))))))
+               {
+                 pst->textlow = nlist.n_value;
+                 textlow_not_set = 0;
+               }
+             add_psymbol_to_list (sym_name, sym_len, 1,
+                                  VAR_DOMAIN, LOC_BLOCK,
+                                  &objfile->static_psymbols,
+                                  0, nlist.n_value,
+                                  psymtab_language, objfile);
+             continue;
 
-         case ':':
-           /* It is a C++ nested symbol.  We don't need to record it
-              (I don't think); if we try to look up foo::bar::baz,
-              then symbols for the symtab containing foo should get
-              read in, I think.  */
-           /* Someone says sun cc puts out symbols like
-              /foo/baz/maclib::/usr/local/bin/maclib,
-              which would get here with a symbol type of ':'.  */
-           continue;
+             /* Global functions were ignored here, but now they
+                are put into the global psymtab like one would expect.
+                They're also in the minimal symbol table.  */
+           case 'F':
+             if (! pst)
+               {
+                 int name_len = p - namestring;
+                 char *name = xmalloc (name_len + 1);
+                 memcpy (name, namestring, name_len);
+                 name[name_len] = '\0';
+                 function_outside_compilation_unit_complaint (name);
+                 xfree (name);
+               }
+             nlist.n_value += ANOFFSET (objfile->section_offsets, 
+                                        SECT_OFF_TEXT (objfile));
+             /* Kludges for ELF/STABS with Sun ACC */
+             last_function_name = namestring;
+             /* Do not fix textlow==0 for .o or NLM files, as 0 is a legit
+                value for the bottom of the text seg in those cases. */
+             if (nlist.n_value == ANOFFSET (objfile->section_offsets, 
+                                            SECT_OFF_TEXT (objfile))
+                 && gdbarch_sofun_address_maybe_missing (gdbarch))
+               {
+                 CORE_ADDR minsym_valu = 
+                   find_stab_function_addr (namestring, 
+                                            pst ? pst->filename : NULL, 
+                                            objfile);
+                 /* find_stab_function_addr will return 0 if the minimal
+                    symbol wasn't found.  (Unfortunately, this might also
+                    be a valid address.)  Anyway, if it *does* return 0,
+                    it is likely that the value was set correctly to begin
+                    with... */
+                 if (minsym_valu != 0)
+                   nlist.n_value = minsym_valu;
+               }
+             if (pst && textlow_not_set
+                 && gdbarch_sofun_address_maybe_missing (gdbarch))
+               {
+                 pst->textlow = nlist.n_value;
+                 textlow_not_set = 0;
+               }
+             /* End kludge.  */
+
+             /* Keep track of the start of the last function so we
+                can handle end of function symbols.  */
+             last_function_start = nlist.n_value;
+
+             /* In reordered executables this function may lie outside
+                the bounds created by N_SO symbols.  If that's the case
+                use the address of this function as the low bound for
+                the partial symbol table.  */
+             if (pst
+                 && (textlow_not_set
+                     || (nlist.n_value < pst->textlow
+                         && (nlist.n_value
+                             != ANOFFSET (objfile->section_offsets,
+                                          SECT_OFF_TEXT (objfile))))))
+               {
+                 pst->textlow = nlist.n_value;
+                 textlow_not_set = 0;
+               }
+             add_psymbol_to_list (sym_name, sym_len, 1,
+                                  VAR_DOMAIN, LOC_BLOCK,
+                                  &objfile->global_psymbols,
+                                  0, nlist.n_value,
+                                  psymtab_language, objfile);
+             continue;
 
-         default:
-           /* Unexpected symbol descriptor.  The second and subsequent stabs
-              of a continued stab can show up here.  The question is
-              whether they ever can mimic a normal stab--it would be
-              nice if not, since we certainly don't want to spend the
-              time searching to the end of every string looking for
-              a backslash.  */
-
-           complaint (&symfile_complaints, _("unknown symbol descriptor `%c'"),
-                      p[1]);
-
-           /* Ignore it; perhaps it is an extension that we don't
-              know about.  */
-           continue;
-         }
+             /* Two things show up here (hopefully); static symbols of
+                local scope (static used inside braces) or extensions
+                of structure symbols.  We can ignore both.  */
+           case 'V':
+           case '(':
+           case '0':
+           case '1':
+           case '2':
+           case '3':
+           case '4':
+           case '5':
+           case '6':
+           case '7':
+           case '8':
+           case '9':
+           case '-':
+           case '#':   /* for symbol identification (used in live ranges) */
+             continue;
 
-         case N_EXCL:
+           case ':':
+             /* It is a C++ nested symbol.  We don't need to record it
+                (I don't think); if we try to look up foo::bar::baz,
+                then symbols for the symtab containing foo should get
+                read in, I think.  */
+             /* Someone says sun cc puts out symbols like
+                /foo/baz/maclib::/usr/local/bin/maclib,
+                which would get here with a symbol type of ':'.  */
+             continue;
 
-         namestring = set_namestring (objfile, nlist);
+           default:
+             /* Unexpected symbol descriptor.  The second and subsequent stabs
+                of a continued stab can show up here.  The question is
+                whether they ever can mimic a normal stab--it would be
+                nice if not, since we certainly don't want to spend the
+                time searching to the end of every string looking for
+                a backslash.  */
+
+             complaint (&symfile_complaints, _("unknown symbol descriptor `%c'"),
+                        p[1]);
+
+             /* Ignore it; perhaps it is an extension that we don't
+                know about.  */
+             continue;
+           }
+       }
+
+       case N_EXCL:
+
+         namestring = set_namestring (objfile, &nlist);
 
          /* Find the corresponding bincl and mark that psymtab on the
             psymtab dependency list */
@@ -2033,8 +2082,10 @@ read_dbx_symtab (struct objfile *objfile)
                            (dependencies_used
                             * sizeof (struct partial_symtab *)));
 #ifdef DEBUG_INFO
-                   fprintf_unfiltered (gdb_stderr, "Had to reallocate dependency list.\n");
-                   fprintf_unfiltered (gdb_stderr, "New dependencies allocated: %d\n",
+                   fprintf_unfiltered (gdb_stderr,
+                                       "Had to reallocate dependency list.\n");
+                   fprintf_unfiltered (gdb_stderr,
+                                       "New dependencies allocated: %d\n",
                                        dependencies_allocated);
 #endif
                  }
@@ -2042,60 +2093,59 @@ read_dbx_symtab (struct objfile *objfile)
          }
          continue;
 
-         case N_ENDM:
-#ifdef SOFUN_ADDRESS_MAYBE_MISSING
+       case N_ENDM:
          /* Solaris 2 end of module, finish current partial symbol table.
             end_psymtab will set pst->texthigh to the proper value, which
             is necessary if a module compiled without debugging info
             follows this module.  */
-         if (pst)
-         {
-           end_psymtab (pst, psymtab_include_list, includes_used,
-                        symnum * symbol_size,
-                        (CORE_ADDR) 0,
-                        dependency_list, dependencies_used, textlow_not_set);
-           pst = (struct partial_symtab *) 0;
-           includes_used = 0;
-           dependencies_used = 0;
-         }
-#endif
+         if (pst && gdbarch_sofun_address_maybe_missing (gdbarch))
+           {
+             end_psymtab (pst, psymtab_include_list, includes_used,
+                          symnum * symbol_size,
+                          (CORE_ADDR) 0,
+                          dependency_list, dependencies_used, textlow_not_set);
+             pst = (struct partial_symtab *) 0;
+             includes_used = 0;
+             dependencies_used = 0;
+             has_line_numbers = 0;
+           }
          continue;
 
-         case N_RBRAC:
+       case N_RBRAC:
 #ifdef HANDLE_RBRAC
          HANDLE_RBRAC (nlist.n_value);
          continue;
 #endif
-         case N_EINCL:
-         case N_DSLINE:
-         case N_BSLINE:
-         case N_SSYM:                  /* Claim: Structure or union element.
-                                          Hopefully, I can ignore this.  */
-         case N_ENTRY:         /* Alternate entry point; can ignore. */
-         case N_MAIN:                  /* Can definitely ignore this.   */
-         case N_CATCH:         /* These are GNU C++ extensions */
-         case N_EHDECL:                /* that can safely be ignored here. */
-         case N_LENG:
-         case N_BCOMM:
-         case N_ECOMM:
-         case N_ECOML:
-         case N_FNAME:
-         case N_SLINE:
-         case N_RSYM:
-         case N_PSYM:
-         case N_LBRAC:
-         case N_NSYMS:         /* Ultrix 4.0: symbol count */
-         case N_DEFD:                  /* GNU Modula-2 */
-         case N_ALIAS:         /* SunPro F77: alias name, ignore for now.  */
-
-         case N_OBJ:                   /* useless types from Solaris */
-         case N_OPT:
-         case N_PATCH:
+       case N_EINCL:
+       case N_DSLINE:
+       case N_BSLINE:
+       case N_SSYM:            /* Claim: Structure or union element.
+                                  Hopefully, I can ignore this.  */
+       case N_ENTRY:           /* Alternate entry point; can ignore. */
+       case N_MAIN:            /* Can definitely ignore this.   */
+       case N_CATCH:           /* These are GNU C++ extensions */
+       case N_EHDECL:          /* that can safely be ignored here. */
+       case N_LENG:
+       case N_BCOMM:
+       case N_ECOMM:
+       case N_ECOML:
+       case N_FNAME:
+       case N_SLINE:
+       case N_RSYM:
+       case N_PSYM:
+       case N_LBRAC:
+       case N_NSYMS:           /* Ultrix 4.0: symbol count */
+       case N_DEFD:            /* GNU Modula-2 */
+       case N_ALIAS:           /* SunPro F77: alias name, ignore for now.  */
+
+       case N_OBJ:             /* useless types from Solaris */
+       case N_OPT:
+       case N_PATCH:
          /* These symbols aren't interesting; don't worry about them */
 
          continue;
 
-         default:
+       default:
          /* If we haven't found it yet, ignore it.  It's probably some
             new type we don't know about yet.  */
          unknown_symtype_complaint (hex_string (nlist.n_type));
@@ -2109,7 +2159,8 @@ read_dbx_symtab (struct objfile *objfile)
       /* Don't set pst->texthigh lower than it already is.  */
       CORE_ADDR text_end =
        (lowest_text_address == (CORE_ADDR) -1
-        ? (text_addr + ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)))
+        ? (text_addr + ANOFFSET (objfile->section_offsets,
+                                 SECT_OFF_TEXT (objfile)))
         : lowest_text_address)
        + text_size;
 
@@ -2129,7 +2180,6 @@ read_dbx_symtab (struct objfile *objfile)
    is the address relative to which its symbols are (incremental) or 0
    (normal). */
 
-
 static struct partial_symtab *
 start_psymtab (struct objfile *objfile, char *filename, CORE_ADDR textlow,
               int ldsymoff, struct partial_symbol **global_syms,
@@ -2139,8 +2189,8 @@ start_psymtab (struct objfile *objfile, char *filename, CORE_ADDR textlow,
   start_psymtab_common (objfile, objfile->section_offsets,
                        filename, textlow, global_syms, static_syms);
 
-  result->read_symtab_private = (char *)
-    obstack_alloc (&objfile->objfile_obstack, sizeof (struct symloc));
+  result->read_symtab_private = obstack_alloc (&objfile->objfile_obstack,
+                                              sizeof (struct symloc));
   LDSYMOFF (result) = ldsymoff;
   result->read_symtab = dbx_psymtab_to_symtab;
   SYMBOL_SIZE (result) = symbol_size;
@@ -2148,11 +2198,13 @@ start_psymtab (struct objfile *objfile, char *filename, CORE_ADDR textlow,
   STRING_OFFSET (result) = string_table_offset;
   FILE_STRING_OFFSET (result) = file_string_table_offset;
 
+#ifdef HAVE_ELF
   /* If we're handling an ELF file, drag some section-relocation info
      for this source file out of the ELF symbol table, to compensate for
      Sun brain death.  This replaces the section_offsets in this psymtab,
      if successful.  */
   elfstab_offset_sections (objfile, result);
+#endif
 
   /* Deduce the source language from the filename for this psymtab. */
   psymtab_language = deduce_language_from_filename (filename);
@@ -2173,12 +2225,12 @@ end_psymtab (struct partial_symtab *pst, char **include_list, int num_includes,
 {
   int i;
   struct objfile *objfile = pst->objfile;
+  struct gdbarch *gdbarch = get_objfile_arch (objfile);
 
   if (capping_symbol_offset != -1)
     LDSYMLEN (pst) = capping_symbol_offset - LDSYMOFF (pst);
   pst->texthigh = capping_text;
 
-#ifdef SOFUN_ADDRESS_MAYBE_MISSING
   /* Under Solaris, the N_SO symbols always have a value of 0,
      instead of the usual address of the .o file.  Therefore,
      we have to do some tricks to fill in texthigh and textlow.
@@ -2194,7 +2246,8 @@ end_psymtab (struct partial_symtab *pst, char **include_list, int num_includes,
      a reliable texthigh by taking the address plus size of the
      last function in the file.  */
 
-  if (pst->texthigh == 0 && last_function_name)
+  if (pst->texthigh == 0 && last_function_name
+      && gdbarch_sofun_address_maybe_missing (gdbarch))
     {
       char *p;
       int n;
@@ -2225,8 +2278,10 @@ end_psymtab (struct partial_symtab *pst, char **include_list, int num_includes,
       last_function_name = NULL;
     }
 
+  if (!gdbarch_sofun_address_maybe_missing (gdbarch))
+    ;
   /* this test will be true if the last .o file is only data */
-  if (textlow_not_set)
+  else if (textlow_not_set)
     pst->textlow = pst->texthigh;
   else
     {
@@ -2251,19 +2306,20 @@ end_psymtab (struct partial_symtab *pst, char **include_list, int num_includes,
     }
 
   /* End of kludge for patching Solaris textlow and texthigh.  */
-#endif /* SOFUN_ADDRESS_MAYBE_MISSING.  */
 
   pst->n_global_syms =
-    objfile->global_psymbols.next - (objfile->global_psymbols.list + pst->globals_offset);
+    objfile->global_psymbols.next - (objfile->global_psymbols.list
+                                    + pst->globals_offset);
   pst->n_static_syms =
-    objfile->static_psymbols.next - (objfile->static_psymbols.list + pst->statics_offset);
+    objfile->static_psymbols.next - (objfile->static_psymbols.list
+                                    + pst->statics_offset);
 
   pst->number_of_dependencies = number_dependencies;
   if (number_dependencies)
     {
       pst->dependencies = (struct partial_symtab **)
        obstack_alloc (&objfile->objfile_obstack,
-                   number_dependencies * sizeof (struct partial_symtab *));
+                      number_dependencies * sizeof (struct partial_symtab *));
       memcpy (pst->dependencies, dependency_list,
              number_dependencies * sizeof (struct partial_symtab *));
     }
@@ -2278,8 +2334,7 @@ end_psymtab (struct partial_symtab *pst, char **include_list, int num_includes,
       /* Copy the sesction_offsets array from the main psymtab. */
       subpst->section_offsets = pst->section_offsets;
       subpst->read_symtab_private =
-       (char *) obstack_alloc (&objfile->objfile_obstack,
-                               sizeof (struct symloc));
+       obstack_alloc (&objfile->objfile_obstack, sizeof (struct symloc));
       LDSYMOFF (subpst) =
        LDSYMLEN (subpst) =
        subpst->textlow =
@@ -2305,11 +2360,6 @@ end_psymtab (struct partial_symtab *pst, char **include_list, int num_includes,
 
   sort_pst_symbols (pst);
 
-  /* If there is already a psymtab or symtab for a file of this name, remove it.
-     (If there is a symtab, more drastic things also happen.)
-     This happens in VxWorks.  */
-  free_named_symtabs (pst->filename);
-
   if (num_includes == 0
       && number_dependencies == 0
       && pst->n_global_syms == 0
@@ -2343,7 +2393,8 @@ dbx_psymtab_to_symtab_1 (struct partial_symtab *pst)
 
   if (pst->readin)
     {
-      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  Shouldn't happen.\n",
+      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  \
+Shouldn't happen.\n",
                          pst->filename);
       return;
     }
@@ -2399,7 +2450,8 @@ dbx_psymtab_to_symtab (struct partial_symtab *pst)
 
   if (pst->readin)
     {
-      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  Shouldn't happen.\n",
+      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  \
+Shouldn't happen.\n",
                          pst->filename);
       return;
     }
@@ -2421,11 +2473,12 @@ dbx_psymtab_to_symtab (struct partial_symtab *pst)
       if (DBX_STAB_SECTION (pst->objfile))
        {
          stabs_data
-           = symfile_relocate_debug_section (pst->objfile->obfd,
+           = symfile_relocate_debug_section (pst->objfile,
                                              DBX_STAB_SECTION (pst->objfile),
                                              NULL);
          if (stabs_data)
-           back_to = make_cleanup (free_current_contents, (void *) &stabs_data);
+           back_to = make_cleanup (free_current_contents,
+                                   (void *) &stabs_data);
        }
 
       dbx_psymtab_to_symtab_1 (pst);
@@ -2498,7 +2551,7 @@ read_ofile_symtab (struct partial_symtab *pst)
       INTERNALIZE_SYMBOL (nlist, bufp, abfd);
       OBJSTAT (objfile, n_stabs++);
 
-      namestring = set_namestring (objfile, nlist);
+      namestring = set_namestring (objfile, &nlist);
 
       processing_gcc_compilation = 0;
       if (nlist.n_type == N_TEXT)
@@ -2560,10 +2613,23 @@ read_ofile_symtab (struct partial_symtab *pst)
 
       type = bfd_h_get_8 (abfd, bufp->e_type);
 
-      namestring = set_namestring (objfile, nlist);
+      namestring = set_namestring (objfile, &nlist);
 
       if (type & N_STAB)
        {
+         if (sizeof (nlist.n_value) > 4
+             /* We are a 64-bit debugger debugging a 32-bit program.  */
+             && (type == N_LSYM || type == N_PSYM))
+             /* We have to be careful with the n_value in the case of N_LSYM
+                and N_PSYM entries, because they are signed offsets from frame
+                pointer, but we actually read them as unsigned 32-bit values.
+                This is not a problem for 32-bit debuggers, for which negative
+                values end up being interpreted correctly (as negative
+                offsets) due to integer overflow.
+                But we need to sign-extend the value for 64-bit debuggers,
+                or we'll end up interpreting negative values as very large
+                positive offsets.  */
+           nlist.n_value = (nlist.n_value ^ 0x80000000) - 0x80000000;
          process_one_symbol (type, nlist.n_desc, nlist.n_value,
                              namestring, section_offsets, objfile);
        }
@@ -2608,8 +2674,6 @@ read_ofile_symtab (struct partial_symtab *pst)
        }
     }
 
-  current_objfile = NULL;
-
   /* In a Solaris elf file, this variable, which comes from the
      value of the N_SO symbol, will still be 0.  Luckily, text_offset,
      which comes from pst->textlow is correct. */
@@ -2622,9 +2686,12 @@ read_ofile_symtab (struct partial_symtab *pst)
   if (last_source_start_addr > text_offset)
     last_source_start_addr = text_offset;
 
-  pst->symtab = end_symtab (text_offset + text_size, objfile, SECT_OFF_TEXT (objfile));
+  pst->symtab = end_symtab (text_offset + text_size, objfile,
+                           SECT_OFF_TEXT (objfile));
 
   end_stabs ();
+
+  current_objfile = NULL;
 }
 \f
 
@@ -2648,6 +2715,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, char *name,
                    struct section_offsets *section_offsets,
                    struct objfile *objfile)
 {
+  struct gdbarch *gdbarch = get_objfile_arch (objfile);
   struct context_stack *new;
   /* This remembers the address of the start of a function.  It is
      used because in Solaris 2, N_LBRAC, N_RBRAC, and N_SLINE entries
@@ -2704,6 +2772,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, char *name,
        {
          /* This N_FUN marks the end of a function.  This closes off
             the current block.  */
+         struct block *block;
 
          if (context_stack_depth <= 0)
            {
@@ -2716,15 +2785,24 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, char *name,
             which may have an N_FUN stabs at the end of the function,
             but no N_SLINE stabs.  */
          if (sline_found_in_function)
-           record_line (current_subfile, 0, last_function_start + valu);
+           {
+             CORE_ADDR addr = last_function_start + valu;
+             record_line (current_subfile, 0,
+                          gdbarch_addr_bits_remove (gdbarch, addr));
+           }
 
          within_function = 0;
          new = pop_context ();
 
          /* Make a block for the local symbols within.  */
-         finish_block (new->name, &local_symbols, new->old_blocks,
-                       new->start_addr, new->start_addr + valu,
-                       objfile);
+         block = finish_block (new->name, &local_symbols, new->old_blocks,
+                               new->start_addr, new->start_addr + valu,
+                               objfile);
+
+         /* For C++, set the block's scope.  */
+         if (SYMBOL_LANGUAGE (new->name) == language_cplus)
+           cp_set_block_scope (new->name, block, &objfile->objfile_obstack,
+                               "", 0);
 
          /* May be switching to an assembler file which may not be using
             block relative stabs, so reset the offset.  */
@@ -2738,7 +2816,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, char *name,
 
       /* Relocate for dynamic loading.  */
       valu += ANOFFSET (section_offsets, SECT_OFF_TEXT (objfile));
-      valu = SMASH_TEXT_ADDRESS (valu);
+      valu = gdbarch_smash_text_address (gdbarch, valu);
       last_function_start = valu;
 
       goto define_a_symbol;
@@ -2788,38 +2866,19 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, char *name,
       if (desc != new->depth)
        lbrac_mismatch_complaint (symnum);
 
-      /* Some compilers put the variable decls inside of an
-         LBRAC/RBRAC block.  This macro should be nonzero if this is
-         true.  DESC is N_DESC from the N_RBRAC symbol.  GCC_P is true
-         if we've detected the GCC_COMPILED_SYMBOL or the
-         GCC2_COMPILED_SYMBOL.  */
-#if !defined (VARIABLES_INSIDE_BLOCK)
-#define VARIABLES_INSIDE_BLOCK(desc, gcc_p) 0
-#endif
-
-      /* Can only use new->locals as local symbols here if we're in
-         GCC or on a machine that puts them before the lbrack.  */
-      if (!VARIABLES_INSIDE_BLOCK (desc, processing_gcc_compilation))
+      if (local_symbols != NULL)
        {
-         if (local_symbols != NULL)
-           {
-             /* GCC development snapshots from March to December of
-                2000 would output N_LSYM entries after N_LBRAC
-                entries.  As a consequence, these symbols are simply
-                discarded.  Complain if this is the case.  Note that
-                there are some compilers which legitimately put local
-                symbols within an LBRAC/RBRAC block; this complaint
-                might also help sort out problems in which
-                VARIABLES_INSIDE_BLOCK is incorrectly defined.  */
-             complaint (&symfile_complaints, _("\
+         /* GCC development snapshots from March to December of
+            2000 would output N_LSYM entries after N_LBRAC
+            entries.  As a consequence, these symbols are simply
+            discarded.  Complain if this is the case.  */
+         complaint (&symfile_complaints, _("\
 misplaced N_LBRAC entry; discarding local symbols which have \
 no enclosing block"));
-           }
-         local_symbols = new->locals;
        }
+      local_symbols = new->locals;
 
-      if (context_stack_depth
-         > !VARIABLES_INSIDE_BLOCK (desc, processing_gcc_compilation))
+      if (context_stack_depth > 1)
        {
          /* This is not the outermost LBRAC...RBRAC pair in the
             function, its local symbols preceded it, and are the ones
@@ -2852,9 +2911,6 @@ no enclosing block"));
          within_function = 0;
        }
 
-      if (VARIABLES_INSIDE_BLOCK (desc, processing_gcc_compilation))
-       /* Now pop locals of block just finished.  */
-       local_symbols = new->locals;
       break;
 
     case N_FN:
@@ -2949,14 +3005,15 @@ no enclosing block"));
 
       if (within_function && sline_found_in_function == 0)
        {
-         if (processing_gcc_compilation == 2)
-           record_line (current_subfile, desc, last_function_start);
-         else
-           record_line (current_subfile, desc, valu);
+         CORE_ADDR addr = processing_gcc_compilation == 2 ?
+                          last_function_start : valu;
+         record_line (current_subfile, desc,
+                      gdbarch_addr_bits_remove (gdbarch, addr));
          sline_found_in_function = 1;
        }
       else
-       record_line (current_subfile, desc, valu);
+       record_line (current_subfile, desc,
+                    gdbarch_addr_bits_remove (gdbarch, valu));
       break;
 
     case N_BCOMM:
@@ -3095,12 +3152,12 @@ no enclosing block"));
            case 'F':
              function_stab_type = type;
 
-#ifdef SOFUN_ADDRESS_MAYBE_MISSING
              /* Deal with the SunPRO 3.0 compiler which omits the
                 address from N_FUN symbols.  */
              if (type == N_FUN
                  && valu == ANOFFSET (section_offsets,
-                                      SECT_OFF_TEXT (objfile)))
+                                      SECT_OFF_TEXT (objfile))
+                 && gdbarch_sofun_address_maybe_missing (gdbarch))
                {
                  CORE_ADDR minsym_valu = 
                    find_stab_function_addr (name, last_source_file, objfile);
@@ -3114,7 +3171,6 @@ no enclosing block"));
                  if (minsym_valu != 0)
                    valu = minsym_valu;
                }
-#endif
 
              if (block_address_function_relative)
                /* For Solaris 2 compilers, the block addresses and
@@ -3130,16 +3186,26 @@ no enclosing block"));
              if (context_stack_depth > 1)
                {
                  complaint (&symfile_complaints,
-                            _("unmatched N_LBRAC before symtab pos %d"), symnum);
+                            _("unmatched N_LBRAC before symtab pos %d"),
+                            symnum);
                  break;
                }
 
              if (context_stack_depth > 0)
                {
+                 struct block *block;
+
                  new = pop_context ();
                  /* Make a block for the local symbols within.  */
-                 finish_block (new->name, &local_symbols, new->old_blocks,
-                               new->start_addr, valu, objfile);
+                 block = finish_block (new->name, &local_symbols,
+                                       new->old_blocks, new->start_addr,
+                                       valu, objfile);
+
+                 /* For C++, set the block's scope.  */
+                 if (SYMBOL_LANGUAGE (new->name) == language_cplus)
+                   cp_set_block_scope (new->name, block,
+                                       &objfile->objfile_obstack,
+                                       "", 0);
                }
 
              new = push_context (0, valu);
@@ -3244,8 +3310,6 @@ no enclosing block"));
    OBJFILE is the object file we are reading symbols from.
    ADDR is the address relative to which the symbols are (e.g.
    the base address of the text segment).
-   MAINLINE is true if we are reading the main symbol
-   table (as opposed to a shared lib or dynamically loaded file).
    TEXTADDR is the address of the text section.
    TEXTSIZE is the size of the text section.
    STABSECTS is the list of .stab sections in OBJFILE.
@@ -3256,7 +3320,7 @@ no enclosing block"));
    adjusted for coff details. */
 
 void
-coffstab_build_psymtabs (struct objfile *objfile, int mainline,
+coffstab_build_psymtabs (struct objfile *objfile,
                         CORE_ADDR textaddr, unsigned int textsize,
                         struct stab_section_list *stabsects,
                         file_ptr stabstroffset, unsigned int stabstrsize)
@@ -3339,8 +3403,6 @@ coffstab_build_psymtabs (struct objfile *objfile, int mainline,
    OBJFILE is the object file we are reading symbols from.
    ADDR is the address relative to which the symbols are (e.g.
    the base address of the text segment).
-   MAINLINE is true if we are reading the main symbol
-   table (as opposed to a shared lib or dynamically loaded file).
    STABSECT is the BFD section information for the .stab section.
    STABSTROFFSET and STABSTRSIZE define the location in OBJFILE where the
    .stabstr section exists.
@@ -3349,8 +3411,7 @@ coffstab_build_psymtabs (struct objfile *objfile, int mainline,
    adjusted for elf details. */
 
 void
-elfstab_build_psymtabs (struct objfile *objfile, int mainline,
-                       asection *stabsect,
+elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect,
                        file_ptr stabstroffset, unsigned int stabstrsize)
 {
   int val;
@@ -3399,7 +3460,7 @@ elfstab_build_psymtabs (struct objfile *objfile, int mainline,
 
   symbuf_read = 0;
   symbuf_left = bfd_section_size (objfile->obfd, stabsect);
-  stabs_data = symfile_relocate_debug_section (objfile->obfd, stabsect, NULL);
+  stabs_data = symfile_relocate_debug_section (objfile, stabsect, NULL);
   if (stabs_data)
     back_to = make_cleanup (free_current_contents, (void *) &stabs_data);
 
@@ -3425,15 +3486,13 @@ elfstab_build_psymtabs (struct objfile *objfile, int mainline,
    OBJFILE is the object file we are reading symbols from.
    ADDR is the address relative to which the symbols are (e.g. the base address
    of the text segment).
-   MAINLINE is true if we are reading the main symbol table (as opposed to a
-   shared lib or dynamically loaded file).
    STAB_NAME is the name of the section that contains the stabs.
    STABSTR_NAME is the name of the section that contains the stab strings.
 
    This routine is mostly copied from dbx_symfile_init and dbx_symfile_read. */
 
 void
-stabsect_build_psymtabs (struct objfile *objfile, int mainline, char *stab_name,
+stabsect_build_psymtabs (struct objfile *objfile, char *stab_name,
                         char *stabstr_name, char *text_name)
 {
   int val;
@@ -3450,12 +3509,14 @@ stabsect_build_psymtabs (struct objfile *objfile, int mainline, char *stab_name,
     return;
 
   if (!stabstrsect)
-    error (_("stabsect_build_psymtabs:  Found stabs (%s), but not string section (%s)"),
+    error (_("stabsect_build_psymtabs:  Found stabs (%s), but not string \
+section (%s)"),
           stab_name, stabstr_name);
 
   objfile->deprecated_sym_stab_info = (struct dbx_symfile_info *)
     xmalloc (sizeof (struct dbx_symfile_info));
-  memset (objfile->deprecated_sym_stab_info, 0, sizeof (struct dbx_symfile_info));
+  memset (objfile->deprecated_sym_stab_info, 0,
+         sizeof (struct dbx_symfile_info));
 
   text_sect = bfd_get_section_by_name (sym_bfd, text_name);
   if (!text_sect)
@@ -3470,7 +3531,8 @@ stabsect_build_psymtabs (struct objfile *objfile, int mainline, char *stab_name,
   DBX_SYMTAB_OFFSET (objfile) = stabsect->filepos;     /* XXX - FIXME: POKING INSIDE BFD DATA STRUCTURES */
 
   if (DBX_STRINGTAB_SIZE (objfile) > bfd_get_size (sym_bfd))
-    error (_("ridiculous string table size: %d bytes"), DBX_STRINGTAB_SIZE (objfile));
+    error (_("ridiculous string table size: %d bytes"),
+          DBX_STRINGTAB_SIZE (objfile));
   DBX_STRINGTAB (objfile) = (char *)
     obstack_alloc (&objfile->objfile_obstack, DBX_STRINGTAB_SIZE (objfile) + 1);
   OBJSTAT (objfile, sz_strtab += DBX_STRINGTAB_SIZE (objfile) + 1);
@@ -3479,9 +3541,9 @@ stabsect_build_psymtabs (struct objfile *objfile, int mainline, char *stab_name,
 
   val = bfd_get_section_contents (sym_bfd,     /* bfd */
                                  stabstrsect,  /* bfd section */
-                                 DBX_STRINGTAB (objfile),      /* input buffer */
+                                 DBX_STRINGTAB (objfile), /* input buffer */
                                  0,    /* offset into section */
-                                 DBX_STRINGTAB_SIZE (objfile));        /* amount to read */
+                                 DBX_STRINGTAB_SIZE (objfile)); /* amount to read */
 
   if (!val)
     perror_with_name (name);
@@ -3500,11 +3562,17 @@ stabsect_build_psymtabs (struct objfile *objfile, int mainline, char *stab_name,
 static struct sym_fns aout_sym_fns =
 {
   bfd_target_aout_flavour,
-  dbx_new_init,                        /* sym_new_init: init anything gbl to entire symtab */
-  dbx_symfile_init,            /* sym_init: read initial info, setup for sym_read() */
+  dbx_new_init,                /* sym_new_init: init anything gbl to entire symtab */
+  dbx_symfile_init,    /* sym_init: read initial info, setup for sym_read() */
   dbx_symfile_read,            /* sym_read: read a symbol file into symtab */
   dbx_symfile_finish,          /* sym_finish: finished with file, cleanup */
-  default_symfile_offsets,     /* sym_offsets: parse user's offsets to internal form */
+  default_symfile_offsets, /* sym_offsets: parse user's offsets to
+                             internal form */
+  default_symfile_segments,    /* sym_segments: Get segment information from
+                                  a file.  */
+  NULL,                         /* sym_read_linetable */
+  default_symfile_relocate,    /* sym_relocate: Relocate a debug section.  */
+  &psym_functions,
   NULL                         /* next: pointer to next struct sym_fns */
 };