+2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
+
+ * unittests/help-doc-selftests.c: New file.
+ * Makefile.in: Add the new file.
+
+2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
+
+ * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
+ * cli/cli-decode.c (print_doc_line): Likewise. It now prints
+ the full first line, except when FOR_VALUE_PREFIX. In this case,
+ the trailing '.' is not output, and the first character is uppercased.
+ (print_help_for_command): Update call to print_doc_line.
+ (print_doc_of_command): Likewise.
+ * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
+ * cli/cli-option.c (append_indented_doc): Do not append newline.
+ (build_help_option): Append newline after first appended_indented_doc
+ only if a second call is done.
+ (build_help): Append 2 new lines before each option, except the first
+ one.
+ * compile/compile.c (_initialize_compile): Add new lines after
+ %OPTIONS%, when not at the end of the help.
+ Change help doc or code
+ producing the help doc to respect the invariants.
+ * maint-test-options.c (_initialize_maint_test_options): Likewise.
+ Also removed the new line after 'Options:', as all other commands
+ do not put an empty line between 'Options:' and the first option.
+ * printcmd.c (_initialize_printcmd): Likewise.
+ * stack.c (_initialize_stack): Likewise.
+ * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
+ incorrectly telling COMMAND is optional.
+ * ada-lang.c (_initialize_ada_language): Change help doc or code
+ producing the help doc to respect the invariants.
+ * ada-tasks.c (_initialize_ada_tasks): Likewise.
+ * breakpoint.c (_initialize_breakpoint): Likewise.
+ * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
+ * cli/cli-logging.c (_initialize_cli_logging): Likewise.
+ * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
+ * cli/cli-style.c (cli_style_option::add_setshow_commands,
+ _initialize_cli_style): Likewise.
+ * corelow.c (core_target_info): Likewise.
+ * dwarf-index-cache.c (_initialize_index_cache): Likewise.
+ * dwarf2read.c (_initialize_dwarf2_read): Likewise.
+ * filesystem.c (_initialize_filesystem): Likewise.
+ * frame.c (_initialize_frame): Likewise.
+ * gnu-nat.c (add_task_commands): Likewise.
+ * infcall.c (_initialize_infcall): Likewise.
+ * infcmd.c (_initialize_infcmd): Likewise.
+ * interps.c (_initialize_interpreter): Likewise.
+ * language.c (_initialize_language): Likewise.
+ * linux-fork.c (_initialize_linux_fork): Likewise.
+ * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
+ * maint.c (_initialize_maint_cmds): Likewise.
+ * memattr.c (_initialize_mem): Likewise.
+ * printcmd.c (_initialize_printcmd): Likewise.
+ * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
+ _RegEx): Likewise.
+ * ravenscar-thread.c (_initialize_ravenscar): Likewise.
+ * record-btrace.c (_initialize_record_btrace): Likewise.
+ * record-full.c (_initialize_record_full): Likewise.
+ * record.c (_initialize_record): Likewise.
+ * regcache-dump.c (_initialize_regcache_dump): Likewise.
+ * regcache.c (_initialize_regcache): Likewise.
+ * remote.c (add_packet_config_cmd, init_remote_threadtests,
+ _initialize_remote): Likewise.
+ * ser-tcp.c (_initialize_ser_tcp): Likewise.
+ * serial.c (_initialize_serial): Likewise.
+ * skip.c (_initialize_step_skip): Likewise.
+ * source.c (_initialize_source): Likewise.
+ * stack.c (_initialize_stack): Likewise.
+ * symfile.c (_initialize_symfile): Likewise.
+ * symtab.c (_initialize_symtab): Likewise.
+ * target-descriptions.c (_initialize_target_descriptions): Likewise.
+ * top.c (init_main): Likewise.
+ * tracefile-tfile.c (tfile_target_info): Likewise.
+ * tracepoint.c (_initialize_tracepoint): Likewise.
+ * tui/tui-win.c (_initialize_tui_win): Likewise.
+ * utils.c (add_internal_problem_command): Likewise.
+ * valprint.c (value_print_option_defs): Likewise.
+
+2019-08-06 Frank Ch. Eigler <fche@redhat.com>
+
+ PR build/24886
+ * configure.ac: Drop enable-libmcheck support.
+ * configure, config.in: Rebuild.
+ * libmcheck.m4: Remove.
+ * acinclude.m4: Don't include it.
+ * Makefile.in: Don't distribute it.
+ * top.c (print_gdb_configuration): Don't mention it.
+
+2019-08-06 Tom Tromey <tom@tromey.com>
+
+ * utils.c (set_output_style): Sometimes pass stream to
+ emit_style_escape.
+ * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
+ * record-btrace.c (btrace_insn_history): Update.
+ * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
+ method.
+ * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
+ Update initializers.
+ <m_uiout>: New field.
+ <m_di>: Move lower.
+ * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
+ Remove "uiout" parameter.
+ (dump_insns): Update.
+ * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
+ * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
+
+2019-08-06 Christian Biesinger <cbiesinger@google.com>
+
+ * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
+ (error_in_psymtab_expansion): Likewise.
+ (lookup_symbol_via_quick_fns): Likewise.
+ (basic_lookup_transparent_type_quick): Likewise.
+ (basic_lookup_transparent_type_1): Likewise.
+
+2019-08-06 Tom Tromey <tromey@adacore.com>
+
+ * source.c (last_source_error): Now bool.
+ (print_source_lines_base): Make "noprint" bool. Only open
+ source file when last_source_visited changes.
+
+2019-08-06 Tom Tromey <tromey@adacore.com>
+
+ * annotate.c (annotate_source_line): Use g_source_cache.
+ * source-cache.c (source_cache::get_plain_source_lines): Change
+ parameters. Populate m_offset_cache.
+ (source_cache::ensure): New method.
+ (source_cache::get_line_charpos): New method.
+ (extract_lines): Move lower. Change parameters.
+ (source_cache::get_source_lines): Move lower.
+ * source-cache.h (class source_cache): Update comment.
+ <get_line_charpos>: New method.
+ <get_source_lines>: Update comment.
+ <clear>: Clear m_offset_cache.
+ <get_plain_source_lines>: Change parameters.
+ <ensure>: New method
+ <m_offset_cache>: New member.
+ * source.c (forget_cached_source_info_for_objfile): Update.
+ (info_source_command): Use g_source_cache.
+ (find_source_lines, open_source_file_with_line_charpos): Remove.
+ (print_source_lines_base, search_command_helper): Use g_source_cache.
+ * source.h (open_source_file_with_line_charpos): Don't declare.
+ * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
+ * tui/tui-source.c (tui_source_window::do_scroll_vertical):
+ Use g_source_cache.
+
+2019-08-06 Tom Tromey <tromey@adacore.com>
+
+ * source-cache.c (source_cache::get_plain_source_lines):
+ Remove "first_line" and "last_line" parameters.
+ (source_cache::get_source_lines): Cache plain text.
+ * source-cache.h (class source_cache)
+ <get_plain_source_lines>: Update.
+
+2019-08-06 Tom Tromey <tromey@adacore.com>
+
+ * source-cache.c (extract_lines): No longer a method.
+ Changed type of parameter. Include final newline.
+ (selftests::extract_lines_test): New function.
+ (_initialize_source_cache): Likewise.
+ * source-cache.h (class source_cache)
+ <extract_lines>: Don't declare.
+
+2019-08-06 Tom Tromey <tromey@adacore.com>
+
+ * breakpoint.c (init_breakpoint_sal): Update.
+ (breakpoint): Update.
+ * breakpoint.h (struct breakpoint) <filter>: Now a
+ unique_xmalloc_ptr.
+
+2019-08-05 Christian Biesinger <cbiesinger@google.com>
+
+ * NEWS: Mention dictionary access on blocks.
+ * python/py-block.c (blpy_getitem): New function.
+ (block_object_as_mapping): New struct.
+ (block_object_type): Use new struct for tp_as_mapping field.
+
+2019-08-05 Christian Biesinger <cbiesinger@google.com>
+
+ * objfiles.h (objfile): Add a comment describing partial symbols.
+
+2019-08-05 Tom Tromey <tromey@adacore.com>
+
+ * compile/compile.c (_initialize_compile): Use _(), not N_().
+ * thread.c (_initialize_thread): Use _(), not N_().
+ * stack.c (_initialize_stack): Use _(), not N_().
+ * printcmd.c (_initialize_printcmd): Use _(), not N_().
+
+2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * dwarf2read.c (struct dw2_symtab_iterator):
+ <want_specific_block>: Remove.
+ <block_index>: Change type to gdb::optional.
+ (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
+ change type of BLOCK_INDEX parameter to gdb::optional.
+ (dw2_symtab_iter_next): Re-write in function of gdb::optional.
+ (dw2_lookup_symbol): Don't pass argument for
+ WANT_SPECIFIC_BLOCK.
+ (dw2_expand_symtabs_for_function): Don't pass argument for
+ WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
+ (class dw2_debug_names_iterator)
+ <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
+ parameter, change BLOCK_INDEX type to gdb::optional.
+ <m_want_specific_block>: Remove.
+ <m_block_index>: Change type to gdb::optional.
+ (dw2_debug_names_iterator::next): Change type of IS_STATIC to
+ gdb::optional. Re-write in function of gdb::optional.
+ (dw2_debug_names_lookup_symbol): Don't pass argument for
+ WANT_SPECIFIC_BLOCK.
+ (dw2_debug_names_expand_symtabs_for_function): Don't pass
+ argument for WANT_SPECIFIC_BLOCK, pass empty optional for
+ BLOCK_INDEX.
+
+2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
+
+ * NEWS: Mention changes to "info sources" command.
+
+2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
+
+ * symtab.c (filename_partial_match_opts): New struct type.
+ (struct output_source_filename_data): New members
+ regexp, c_regexp, partial_match.
+ (output_source_filename): Use new members to decide to print file.
+ (info_sources_option_defs): New variable.
+ (make_info_sources_options_def_group, print_info_sources_header,
+ info_sources_command_completer):
+ New functions.
+ (info_sources_command): Read new optional arguments.
+ (_initialize_symtab): Update info sources help.
+
+2019-08-02 Alexandre Oliva <oliva@adacore.com>
+
+ * ada-lang.c (exception_support_info_v0): Renamed from...
+ (default_exception_support_info): ... this. Create new
+ definition for v1.
+ (ada_has_this_exception_support): Look up catch_handlers_sym.
+ (ada_exception_support_info_sniffer): Try v0 after default.
+
+2019-08-01 Tom Tromey <tromey@adacore.com>
+
+ * ia64-libunwind-tdep.h (struct libunwind_descr): Include
+ gdbarch.h.
+
+2019-08-01 Christian Biesinger <cbiesinger@google.com>
+
+ * s12z-tdep.c: Fix include path for s12z-opc.h.
+
+2019-08-01 Alan Hayward <alan.hayward@arm.com>
+
+ * NEWS: Require GNU make 3.82.
+
+2019-07-16 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
+ declare.
+
+2019-07-30 Tom Tromey <tromey@adacore.com>
+
+ * block.c (contained_in): Remove BLOCK_FUNCTION check.
+
+2019-07-30 Kevin Buettner <kevinb@redhat.com>
+
+ * printcmd.c (print_address_symbolic): Print negative offsets.
+ (build_address_symbolic): Force signed arithmetic when computing
+ offset.
+
+2019-07-30 Christian Biesinger <cbiesinger@google.com>
+
+ PR/24474: Add a function to lookup static variables.
+ * NEWS: Mention this new function.
+ * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
+ * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
+ * python/python.c (python_GdbMethods): Add new function.
+
+2019-07-29 Christian Biesinger <cbiesinger@google.com>
+
+ * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
+ * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
+ (objfpy_lookup_static_symbol): New function.
+ (objfile_object_methods): Add new functions.
+
+2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
+
+ * NEWS: Mention 'set|show print frame-info'. Mention new
+ 'presence' value for 'frame-arguments'. Mention new '-frame-info'
+ backtrace argument. Mention that python frame filtering code
+ is now consistent with what 'backtrace' command prints.
+
+2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
+
+ * frame.h (enum print_what): New value 'SHORT_LOCATION', update
+ comments.
+ (print_frame_info_auto, print_frame_info_source_line,
+ print_frame_info_location, print_frame_info_source_and_location,
+ print_frame_info_location_and_address, print_frame_info_short_location):
+ New declarations.
+ (struct frame_print_options): New member print_frame_info.
+ * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
+ * stack.h (get_user_print_what_frame_info): New declaration.
+ (frame_show_address): New declaration.
+ * stack.c (print_frame_arguments_choices): New value 'presence'.
+ (print_frame_info_auto, print_frame_info_source_line,
+ print_frame_info_location, print_frame_info_source_and_location,
+ print_frame_info_location_and_address, print_frame_info_short_location,
+ print_frame_info_choices, print_frame_info_print_what): New definitions.
+ (print_frame_args): Only print dots for args if print frame-arguments
+ is 'presence'.
+ (frame_print_option_defs): New element for "frame-info".
+ (get_user_print_what_frame_info): New function.
+ (frame_show_address): Make non static. Move comment to stack.h.
+ (print_frame_info_to_print_what): New function.
+ (print_frame_info): Update comment. Use fp_opts.print_frame_info
+ to decide what to print.
+ (backtrace_command_1): Handle the new print_frame_arguments_presence
+ value.
+ (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
+ * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
+ (py_print_frame): In non-mi mode, use LOCATION as default for
+ print_what, similarly to frame information printed directly by
+ backtrace command. Handle frame-info user option in non MI mode.
+
+2019-07-27 Kevin Buettner <kevinb@redhat.com>
+
+ * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
+ Add case for debugging 32-bit target on 64-bit host. Revise
+ comment.
+
+2019-07-27 Kevin Buettner <kevinb@redhat.com>
+
+ * infrun.c (fill_in_stop_func): Use find_pc_partial_function
+ instead of find_function_entry_range_from_pc.
+
+2019-07-27 Kevin Buettner <kevinb@redhat.com>
+
+ * stack.c (find_frame_funname): Remove code which preferred
+ minsym over symtab sym in "certain pathological cases".
+
+ * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
+ parameter. Change type of "do_demangle" to bool.
+ * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
+ Pass suitable "prefer_sym_over_minsym" flag to
+ build_address_symbolic(). Don't output "+" for negative offsets.
+ * printcmd.c (print_address_symbolic): Update invocation of
+ build_address_symbolic to include a "prefer_sym_over_minsym"
+ flag.
+ (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
+ Restrict cases in which use of minimal symbol is preferred to that
+ of a found symbol. Update comments.
+
+ * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
+ for entry pc when entry pc is out of range for that FDE.
+
+2019-07-26 Brian Callahan <bcallah@openbsd.org>
+
+ PR gdb/24839:
+ * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
+ type.
+
+2019-07-25 Christian Biesinger <cbiesinger@google.com>
+
+ * python/py-objfile.c (add_separate_debug_file): Fix comment about
+ this function's Python signature.
+
+
+2019-07-24 Christian Biesinger <cbiesinger@google.com>
+
+ * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
+ * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
+ * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
+ * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
+ * symtab.h (lookup_global_symbol_from_objfile): Likewise.
+
+
+2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
+
+ * h8300-tdep.c (h8300_register_name_common): New.
+ h8300_register_name): Use h8300_register_name_common.
+ (h8300s_register_name): Likewise.
+ (h8300sx_register_name): Likewise.
+ (h8300h_register_nam): New.
+ (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
+
+
+2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
+
+ * arm-tdep.c (arm_skip_cmse_entry): New function.
+ (arm_is_sgstubs_section): New function.
+ (arm_skip_stub): Add call to arm_skip_cmse_entry function.
+
+2019-07-22 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
+ Don't self-assign.
+
+2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
+ type_print.
+
+2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * symtab.c (search_symbols): Adjust msymbol matching type arrays
+ so that GDB doesn't match any msymbols when searching in the
+ TYPES_DOMAIN.
+ (print_symbol_info): Print using typedef_print or type_print based
+ on the type of the symbol. Add updated FIXME comment moved from...
+ (_initialize_symtab): ... move and update FIXME comment to above.
+
+2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * NEWS: Mention adding -q option to "info types".
+ * symtab.c (struct info_types_options): New struct.
+ (info_types_options_defs): New variable.
+ (make_info_types_options_def_group): New function.
+ (info_types_command): Use gdb::option framework to parse options.
+ (info_types_command_completer): New function.
+ (_initialize_symtab): Extend the help text on "info types" and
+ register command completer.
+
+2019-07-21 Christian Biesinger <cbiesinger@google.com>
+
+ * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
+ (lookup_symbol_in_objfile): Change int to block_enum and add a
+ gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
+
+2019-07-20 Christian Biesinger <cbiesinger@google.com>
+
+ * MAINTAINERS (Write After Approval): Add self.
+
+2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
+ instruction to the dummy code region.
+
+2019-07-19 Tom Tromey <tromey@adacore.com>
+
+ * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
+ (ARGSUSED, PARAMS, __func__): Remove rules.
+
+2019-07-19 Alan Hayward <alan.hayward@arm.com>
+
+ * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
+ * features/arm/arm-with-iwmmxt.c: Remove.
+ * features/arm/arm-with-iwmmxt.xml: Remove.
+ * features/arm/arm-with-m-fpa-layout.c: Remove.
+ * features/arm/arm-with-m-fpa-layout.xml: Remove.
+ * features/arm/arm-with-m-vfp-d16.c: Remove.
+ * features/arm/arm-with-m-vfp-d16.xml: Remove.
+ * features/arm/arm-with-m.c: Remove.
+ * features/arm/arm-with-m.xml: Remove.
+ * features/arm/arm-with-neon.c: Remove.
+ * features/arm/arm-with-neon.xml: Remove.
+ * features/arm/arm-with-vfpv2.c: Remove.
+ * features/arm/arm-with-vfpv2.xml: Remove.
+ * features/arm/arm-with-vfpv3.c: Remove.
+ * features/arm/arm-with-vfpv3.xml: Remove.
+
+2019-07-19 Alan Hayward <alan.hayward@arm.com>
+
+ * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
+
+2019-07-19 Alan Hayward <alan.hayward@arm.com>
+
+ * arch/aarch32.c (aarch32_create_target_description): Create
+ target descriptions using features.
+ * arch/arm.c (arm_create_target_description)
+ (arm_create_mprofile_target_description): Likewise.
+ * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
+
+2019-07-19 Alan Hayward <alan.hayward@arm.com>
+
+ * Makefile.in: Add new files.
+ * aarch32-tdep.c: New file.
+ * aarch32-tdep.h: New file.
+ * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
+ Call aarch32_read_description.
+ * arch/aarch32.c: New file.
+ * arch/aarch32.h: New file.
+ * arch/arm.c (arm_create_target_description)
+ (arm_create_mprofile_target_description): New function.
+ * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
+ (arm_create_target_description)
+ (arm_create_mprofile_target_description): New declaration.
+ * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
+ read_description functions.
+ * arm-linux-nat.c (arm_linux_nat_target::read_description):
+ Likewise.
+ * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
+ * arm-tdep.c (tdesc_arm_list): New variable.
+ (arm_register_g_packet_guesses): Call create description functions.
+ (arm_read_description) (arm_read_mprofile_description): New
+ function.
+ * arm-tdep.h (arm_read_description)
+ (arm_read_mprofile_description): Add declaration.
+ * configure.tgt: Add new files.
+
+2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
+
+ * top.c (new_ui_command): Open specified terminal just once.
+
+2019-07-18 Tom Tromey <tromey@adacore.com>
+
+ * symtab.c (main_name): Constify return type.
+ * symfile.c (set_initial_language): Update.
+ * symtab.h (main_name): Constify return type.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.c (tui_update_source_window)
+ (tui_update_source_window_as_is)
+ (tui_update_source_windows_with_line): Remove return.
+ * tui/tui-disasm.c (tui_show_disassem)
+ (tui_show_disassem_and_update_source): Remove return.
+ * tui/tui.c (tui_reset): Remove return.
+ * tui/tui-wingeneral.c
+ (tui_check_and_display_highlight_if_needed): Remove return.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (struct tui_exec_info_window)
+ (struct tui_source_window_base): Move from tui-data.h.
+ * tui/tui-winsource.c: Move many method definitions from
+ elsewhere. Remove "structuring" comments.
+ * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
+ (tui_source_window_base::refresh_window): Move to
+ tui-winsource.c.
+ * tui/tui-win.c (tui_source_window_base::refresh_all)
+ (tui_source_window_base::update_tab_width)
+ (tui_source_window_base::set_new_height)
+ (tui_source_window_base::do_make_visible_with_new_height): Move to
+ tui-winsource.c.
+ * tui/tui-source.h: Update.
+ * tui/tui-source.c (tui_source_window_base::reset): Move to
+ tui-winsource.c.
+ * tui/tui-disasm.h: Update.
+ * tui/tui-data.h (struct tui_exec_info_window): Move to
+ tui-winsource.h.
+ (struct tui_source_window_base): Likewise.
+ * tui/tui-data.c (tui_source_window_base::clear_detail)
+ (tui_source_window_base, ~tui_source_window_base): Move to
+ tui-winsource.c.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-win.c (tui_resize_all)
+ (tui_source_window_base::update_tab_width)
+ (tui_adjust_win_heights): Update.
+ (tui_win_info::make_invisible_and_set_new_height): Rename from
+ make_invisible_and_set_new_height.
+ * tui/tui-data.h (struct tui_win_info)
+ <make_invisible_and_set_new_height>: New method.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.c: Update.
+ * tui/tui-source.h (struct tui_source_window): Move from
+ tui-data.h.
+ * tui/tui-layout.c: Update.
+ * tui/tui-disasm.c: Update.
+ * tui/tui-data.h (struct tui_source_window): Move to
+ tui-source.h.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-disasm.h (struct tui_disasm_window): Move from
+ tui-data.h.
+ * tui/tui-data.h (struct tui_disasm_window): Move to
+ tui-disasm.h.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-regs.h (struct tui_data_item_window): Move from
+ tui-data.h.
+ * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
+ * tui/tui-data.h (struct tui_data_item_window): Move to
+ tui-regs.h.
+ * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.c: Update.
+ * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
+ (tui_cmd_window::max_height): Move to tui-command.c.
+ * tui/tui-layout.c: Update.
+ * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
+ * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
+ tui-command.c.
+ * tui/tui-command.h (struct tui_cmd_window): Move from
+ tui-data.h.
+ * tui/tui-command.c: Remove "structuring" comments.
+ (tui_cmd_window::clear_detail)
+ (tui_cmd_window::do_make_visible_with_new_height)
+ (tui_cmd_window::max_height): Move from elsewhere.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
+ Now static.
+ * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
+ * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.c: Update.
+ * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
+ tui-regs.c.
+ * tui/tui-windata.h: Remove file.
+ * tui/tui-windata.c: Remove file.
+ * tui/tui-win.c (tui_data_window::set_new_height)
+ (tui_data_window::do_make_visible_with_new_height): Move to
+ tui-regs.c.
+ * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
+ * tui/tui-regs.c: Remove "structuring" comments.
+ (tui_data_window::first_data_item_displayed)
+ (tui_data_window::delete_data_content_windows)
+ (tui_data_window::erase_data_content)
+ (tui_data_window::display_all_data)
+ (tui_data_window::refresh_all)
+ (tui_data_window::do_scroll_vertical)
+ (tui_data_window::clear_detail, tui_data_window::set_new_height)
+ (tui_data_window::do_make_visible_with_new_height)
+ (tui_data_window::refresh_window): Move from elsewhere.
+ (_initialize_tui_regs): Move to end of file.
+ * tui/tui-layout.c: Update.
+ * tui/tui-hooks.c: Update.
+ * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
+ * tui/tui-data.c (tui_data_window::clear_detail): Move to
+ tui-regs.c.
+ * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
+ seen.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-win.c (tui_source_window_base::set_new_height)
+ (tui_source_window_base::do_make_visible_with_new_height): Use
+ m_has_locator field directly.
+ * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
+ method.
+ (struct tui_source_window_base) <has_locator>: Likewise.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
+ Don't declare.
+ * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
+ Remove.
+ * tui/tui-win.c (tui_source_window_base::set_new_height)
+ (tui_source_window_base::set_new_height)
+ (make_invisible_and_set_new_height)
+ (tui_source_window_base::do_make_visible_with_new_height)
+ (tui_source_window_base::do_make_visible_with_new_height):
+ Update.
+ * tui/tui-layout.c (show_source_disasm_command, show_data)
+ (show_source_or_disasm_and_command): Update.
+ * tui/tui-layout.c (show_layout): Update.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (make_data_window): Remove.
+ (show_data): Unify creation and re-initialization cases.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (make_source_window, make_disasm_window):
+ Remove.
+ (show_data): Unify creation and re-initialization cases.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (make_command_window): Remove.
+ (show_source_disasm_command, show_source_or_disasm_and_command):
+ Unify creation and re-initialization cases.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
+ creation and re-initialization cases.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-regs.c (tui_get_register): Return void.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
+ Simplify.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (show_source_disasm_command): Simplify window
+ resetting.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.h (tui_set_layout_by_name): Don't declare.
+ * tui/tui-regs.c (tui_reg_layout): New function.
+ (tui_show_registers, tui_reg_command): Use it.
+ * tui/tui-layout.c (LAYOUT_USAGE): Remove.
+ (tui_layout_command): Rename from tui_set_layout_by_name. Change
+ parameters.
+ (tui_layout_command): Remove.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.h (tui/tui-layout): Return void.
+ * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (show_source_disasm_command, show_data):
+ Update.
+ (reset_locator): Remove.
+ (show_source_or_disasm_and_command): Update.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-source.c (tui_source_window_base::reset): Remove
+ win_type parameter.
+ * tui/tui-layout.c (make_command_window, make_source_window)
+ (make_disasm_window, make_data_window)
+ (show_source_disasm_command, show_data, tui_gen_win_info::reset)
+ (reset_locator, show_source_or_disasm_and_command): Update.
+ * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
+ win_type parameter.
+ (struct tui_source_window_base) <reset>: Likewise.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (show_source_disasm_command): Use
+ reset_locator.
+ (reset_locator): New function.
+ (init_and_make_win): Remove.
+ (show_source_or_disasm_and_command): Use reset_locator.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.c (tui_set_exec_info_content): Remove
+ condition.
+ * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
+ Remove condition.
+ * tui/tui-source.c (tui_source_window_base::reset): New method.
+ * tui/tui-layout.c (make_command_window): Don't call
+ init_and_make_win.
+ (make_source_window, make_disasm_window): Don't call
+ make_source_or_disasm_window.
+ (make_data_window): Don't call init_and_make_win. Change calling
+ convention.
+ (show_source_disasm_command, show_data): Simplify.
+ (make_source_or_disasm_window): Remove.
+ (show_source_or_disasm_and_command): Simplify.
+ * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
+ (struct tui_source_window_base) <reset>: Likewise.
+ <execution_info>: Remove initializer.
+ * tui/tui-data.c (tui_source_window_base): Initialize
+ execution_info.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (tui_set_layout): Remove regs_populate
+ variable.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.c (tui_rl_other_window): Update.
+ * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
+ superclass method first. Always iterate over regs_content.
+ (tui_unhighlight_win, tui_highlight_win): Use refresh_window
+ method.
+ * tui/tui-win.c (tui_set_focus_command): Update.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-win.c (tui_set_focus_command): Rename from
+ tui_set_focus. Call tui_enable.
+ (tui_set_focus_command): Remove.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
+ refresh_window.
+ * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
+ touchwin.
+ (tui_data_window::refresh_window): Call refresh_window on data
+ items. Always call superclass refresh_window.
+ (tui_win_info::refresh): Remove.
+ (tui_source_window_base::refresh_window): Update.
+ (tui_refresh_all): Update.
+ * tui/tui-layout.c (show_source_disasm_command): Remove call to
+ refresh_window.
+ (show_source_or_disasm_and_command): Likewise.
+ * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
+ (struct tui_source_window_base) <refresh>: Likewise.
+
2019-07-17 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.c (tui_clear_source_content)