Simplify show_source_or_disasm_and_command
[external/binutils.git] / gdb / ChangeLog
index ee17d50..6d50df1 100644 (file)
@@ -1,5 +1,141 @@
 2019-07-17  Tom Tromey  <tom@tromey.com>
 
+       * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
+       creation and re-initialization cases.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.c (tui_get_register): Return void.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
+       Simplify.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_disasm_command): Simplify window
+       resetting.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui.h (tui_set_layout_by_name): Don't declare.
+       * tui/tui-regs.c (tui_reg_layout): New function.
+       (tui_show_registers, tui_reg_command): Use it.
+       * tui/tui-layout.c (LAYOUT_USAGE): Remove.
+       (tui_layout_command): Rename from tui_set_layout_by_name.  Change
+       parameters.
+       (tui_layout_command): Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.h (tui/tui-layout): Return void.
+       * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_disasm_command, show_data):
+       Update.
+       (reset_locator): Remove.
+       (show_source_or_disasm_and_command): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-source.c (tui_source_window_base::reset): Remove
+       win_type parameter.
+       * tui/tui-layout.c (make_command_window, make_source_window)
+       (make_disasm_window, make_data_window)
+       (show_source_disasm_command, show_data, tui_gen_win_info::reset)
+       (reset_locator, show_source_or_disasm_and_command): Update.
+       * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
+       win_type parameter.
+       (struct tui_source_window_base) <reset>: Likewise.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_disasm_command): Use
+       reset_locator.
+       (reset_locator): New function.
+       (init_and_make_win): Remove.
+       (show_source_or_disasm_and_command): Use reset_locator.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_set_exec_info_content): Remove
+       condition.
+       * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
+       Remove condition.
+       * tui/tui-source.c (tui_source_window_base::reset): New method.
+       * tui/tui-layout.c (make_command_window): Don't call
+       init_and_make_win.
+       (make_source_window, make_disasm_window): Don't call
+       make_source_or_disasm_window.
+       (make_data_window): Don't call init_and_make_win.  Change calling
+       convention.
+       (show_source_disasm_command, show_data): Simplify.
+       (make_source_or_disasm_window): Remove.
+       (show_source_or_disasm_and_command): Simplify.
+       * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
+       (struct tui_source_window_base) <reset>: Likewise.
+       <execution_info>: Remove initializer.
+       * tui/tui-data.c (tui_source_window_base): Initialize
+       execution_info.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (tui_set_layout): Remove regs_populate
+       variable.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui.c (tui_rl_other_window): Update.
+       * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
+       superclass method first.  Always iterate over regs_content.
+       (tui_unhighlight_win, tui_highlight_win): Use refresh_window
+       method.
+       * tui/tui-win.c (tui_set_focus_command): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-win.c (tui_set_focus_command): Rename from
+       tui_set_focus.  Call tui_enable.
+       (tui_set_focus_command): Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
+       refresh_window.
+       * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
+       touchwin.
+       (tui_data_window::refresh_window): Call refresh_window on data
+       items.  Always call superclass refresh_window.
+       (tui_win_info::refresh): Remove.
+       (tui_source_window_base::refresh_window): Update.
+       (tui_refresh_all): Update.
+       * tui/tui-layout.c (show_source_disasm_command): Remove call to
+       refresh_window.
+       (show_source_or_disasm_and_command): Likewise.
+       * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
+       (struct tui_source_window_base) <refresh>: Likewise.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_clear_source_content)
+       (tui_show_source_content): Update.
+       * tui/tui-source.c (tui_source_window::showing_source_p): Check
+       whether content is empty.
+       * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
+       Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_erase_source_content): Clear the
+       window's contents.
+       * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
+       * tui/tui-source.c (tui_set_source_content_nil): Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
        * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
        (struct tui_data_item_window): Update.