Simplify show_source_or_disasm_and_command
[external/binutils.git] / gdb / ChangeLog
index 112b460..6d50df1 100644 (file)
@@ -1,3 +1,865 @@
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
+       creation and re-initialization cases.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.c (tui_get_register): Return void.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
+       Simplify.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_disasm_command): Simplify window
+       resetting.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui.h (tui_set_layout_by_name): Don't declare.
+       * tui/tui-regs.c (tui_reg_layout): New function.
+       (tui_show_registers, tui_reg_command): Use it.
+       * tui/tui-layout.c (LAYOUT_USAGE): Remove.
+       (tui_layout_command): Rename from tui_set_layout_by_name.  Change
+       parameters.
+       (tui_layout_command): Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.h (tui/tui-layout): Return void.
+       * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_disasm_command, show_data):
+       Update.
+       (reset_locator): Remove.
+       (show_source_or_disasm_and_command): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-source.c (tui_source_window_base::reset): Remove
+       win_type parameter.
+       * tui/tui-layout.c (make_command_window, make_source_window)
+       (make_disasm_window, make_data_window)
+       (show_source_disasm_command, show_data, tui_gen_win_info::reset)
+       (reset_locator, show_source_or_disasm_and_command): Update.
+       * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
+       win_type parameter.
+       (struct tui_source_window_base) <reset>: Likewise.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_disasm_command): Use
+       reset_locator.
+       (reset_locator): New function.
+       (init_and_make_win): Remove.
+       (show_source_or_disasm_and_command): Use reset_locator.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_set_exec_info_content): Remove
+       condition.
+       * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
+       Remove condition.
+       * tui/tui-source.c (tui_source_window_base::reset): New method.
+       * tui/tui-layout.c (make_command_window): Don't call
+       init_and_make_win.
+       (make_source_window, make_disasm_window): Don't call
+       make_source_or_disasm_window.
+       (make_data_window): Don't call init_and_make_win.  Change calling
+       convention.
+       (show_source_disasm_command, show_data): Simplify.
+       (make_source_or_disasm_window): Remove.
+       (show_source_or_disasm_and_command): Simplify.
+       * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
+       (struct tui_source_window_base) <reset>: Likewise.
+       <execution_info>: Remove initializer.
+       * tui/tui-data.c (tui_source_window_base): Initialize
+       execution_info.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (tui_set_layout): Remove regs_populate
+       variable.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui.c (tui_rl_other_window): Update.
+       * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
+       superclass method first.  Always iterate over regs_content.
+       (tui_unhighlight_win, tui_highlight_win): Use refresh_window
+       method.
+       * tui/tui-win.c (tui_set_focus_command): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-win.c (tui_set_focus_command): Rename from
+       tui_set_focus.  Call tui_enable.
+       (tui_set_focus_command): Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
+       refresh_window.
+       * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
+       touchwin.
+       (tui_data_window::refresh_window): Call refresh_window on data
+       items.  Always call superclass refresh_window.
+       (tui_win_info::refresh): Remove.
+       (tui_source_window_base::refresh_window): Update.
+       (tui_refresh_all): Update.
+       * tui/tui-layout.c (show_source_disasm_command): Remove call to
+       refresh_window.
+       (show_source_or_disasm_and_command): Likewise.
+       * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
+       (struct tui_source_window_base) <refresh>: Likewise.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_clear_source_content)
+       (tui_show_source_content): Update.
+       * tui/tui-source.c (tui_source_window::showing_source_p): Check
+       whether content is empty.
+       * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
+       Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_erase_source_content): Clear the
+       window's contents.
+       * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
+       * tui/tui-source.c (tui_set_source_content_nil): Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
+       (struct tui_data_item_window): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
+       (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
+       defines.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.h (tui_erase_source_content)
+       (tui_clear_source_content): Remove "display_prompt" parameter.
+       * tui/tui-winsource.c (tui_update_source_window_as_is)
+       (tui_update_source_windows_with_addr): Update.
+       (tui_clear_source_content): Remove "display_prompt" parameter.
+       (tui_erase_source_content): Likewise.  Simplify.
+       (tui_show_source_content): Update.
+       * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
+       * tui/tui-stack.c (tui_show_frame_info): Update.
+       * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
+       Remove defines.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
+       * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
+       parameter.
+       * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
+       parameter.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_clear_source_content)
+       (tui_show_source_content, tui_show_exec_info_content)
+       (tui_clear_exec_info_content): Update.
+       * tui/tui-stack.c (tui_show_locator_content): Update.
+       (tui_show_frame_info): Update.
+       * tui/tui-source.h (tui_source_window): Don't declare.
+       * tui/tui-source.c (tui_source_window::showing_source_p): Rename
+       from tui_source_is_displayed.
+       * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
+       Remove field.
+       (struct tui_source_window_base) <content_in_use>: New field.  Now
+       bool.
+       (struct tui_source_window) <showing_source_p>: New method.
+       (TUI_SRC_WIN): Change cast.
+       * tui/tui-data.c (tui_initialize_static_data): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_update_breakpoint_info): Use
+       location_matches_p.
+       * tui/tui-source.c (tui_source_window::location_matches_p): New
+       method.
+       * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
+       method.
+       * tui/tui-data.h (struct tui_source_window_base)
+       <location_matches_p>: New method.
+       (struct tui_source_window, struct tui_disasm_window)
+       <location_matches_p>: Likewise.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-win.c (tui_set_win_height_command): Rename from
+       tui_set_win_height.
+       (tui_set_win_height_command): Remove.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-source.c (tui_source_window): New constructor.  Add
+       observer.
+       (~tui_source_window): New destructor.
+       (tui_source_window::style_changed): New method.
+       * tui/tui-hooks.c (tui_redisplay_source): Remove.
+       (tui_attach_detach_observers): Update.
+       * tui/tui-data.h (struct tui_source_window): Make constructor not
+       inline.  Add destructor.
+       (struct tui_source_window) <style_changed>: New method.
+       <m_observable>: New member.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
+       * tui/tui-win.c (tui_resize_all): Fix typo.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-wingeneral.h (tui_refresh_all): Update.
+       * tui/tui-wingeneral.c (make_all_visible): Use foreach.
+       (tui_refresh_all): Remove "list" parameter.  Use foreach.
+       * tui/tui-win.c (window_name_completer): Use foreach.
+       (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
+       (update_tab_width): Likewise.
+       * tui/tui-layout.c (show_layout): Update.
+       * tui/tui-data.h (class tui_window_iterator): New.
+       (struct all_tui_windows): New.
+       * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
+       parameter.  Don't reference globals.
+       (tui_reg_command): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.c (tui_show_registers): Simplify.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.c (tui_show_registers): Update.
+       (tui_show_register_group): Add win_info parameter.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
+       Rename from tui_display_reg_element_at_line.
+       (tui_data_window::display_registers_from_line): Update.
+       * tui/tui-data.h (struct tui_data_window)
+       <display_reg_element_at_line>: New method.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.h (tui_display_registers_from)
+       (tui_display_registers_from_line): Don't declare.
+       * tui/tui-windata.c (tui_data_window::display_all_data)
+       (tui_data_window::refresh_all)
+       (tui_data_window::do_scroll_vertical): Update.
+       * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
+       from tui_display_registers_from.
+       (tui_display_reg_element_at_line): Update.
+       (tui_data_window::display_registers_from_line): Rename from
+       tui_display_registers_from_line.
+       * tui/tui-data.h (struct tui_data_window) <display_registers_from,
+       display_registers_from_line>: New methods.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-windata.h (tui_erase_data_content): Don't declare.
+       * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
+       from tui_erase_data_content.
+       (tui_data_window::display_all_data)
+       (tui_data_window::refresh_all)
+       (tui_data_window::do_scroll_vertical): Update.
+       * tui/tui-regs.c (tui_show_registers): Update.
+       * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
+       New method.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-windata.h (tui_delete_data_content_windows): Don't
+       declare.
+       * tui/tui-windata.c
+       (tui_data_window::delete_data_content_windows): Rename from
+       tui_delete_data_content_windows.
+       (tui_data_window::display_all_data)
+       (tui_data_window::do_scroll_vertical): Update.
+       * tui/tui-data.h (struct tui_data_window)
+       <delete_data_content_windows>: New method.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
+       * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-windata.h (tui_display_all_data): Don't declare.
+       * tui/tui-windata.c (tui_data_window::display_all_data): Rename
+       from tui_display_all_data.
+       * tui/tui-win.c
+       (tui_data_window::do_make_visible_with_new_height): Update.
+       * tui/tui-regs.c (tui_show_registers): Update.
+       * tui/tui-layout.c (tui_set_layout): Update.
+       * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
+       method.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-windata.h (tui_display_data_from): Don't declare.
+       * tui/tui-windata.c (tui_display_data_from): Remove.
+       (tui_data_window::refresh_all): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
+       * tui/tui-windata.c (tui_display_data_from_line): Remove.
+       (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
+       tui_display_registers_from_line.
+       * tui/tui-regs.h (tui_display_registers_from_line): Update.
+       * tui/tui-regs.c (tui_display_registers_from_line): Remove
+       "force_display" parameter.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
+       declare.
+       * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
+       Rename from tui_first_reg_element_no_inline.
+       (tui_display_reg_element_at_line)
+       (tui_display_registers_from_line): Update.
+       * tui/tui-data.h (struct tui_data_window)
+       <first_reg_element_no_inline>: New method.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-windata.c (tui_display_data_from)
+       (tui_data_window::do_scroll_vertical): Update.
+       * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
+       * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
+       Rename from tui_line_from_reg_element_no.
+       (tui_display_registers_from_line): Update.
+       * tui/tui-data.h (struct tui_data_window)
+       <line_from_reg_element_no>: New method.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
+       * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
+       tui_last_regs_line_no.
+       (tui_display_reg_element_at_line)
+       (tui_display_registers_from_line): Update.
+       * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
+       method.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       PR tui/24722:
+       * tui/tui-winsource.h (tui_update_all_breakpoint_info)
+       (tui_update_breakpoint_info): Add "being_deleted" parameter.
+       * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
+       (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
+       (tui_update_breakpoint_info): Likewise.
+       * tui/tui-hooks.c (tui_event_create_breakpoint)
+       (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
+       Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_update_source_window_as_is)
+       (tui_update_source_windows_with_addr): Update.
+       * tui/tui-source.h (tui_set_source_content)
+       (tui_show_symtab_source): Add "win_info" parameter.
+       * tui/tui-source.c (tui_set_source_content): Add "win_info"
+       parameter.
+       (tui_show_symtab_source): Likewise.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-wingeneral.c
+       (tui_check_and_display_highlight_if_needed): Check can_highlight.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
+       (struct tui_cmd_window) <can_scroll>: New method.
+       * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
+       method.
+
+2019-07-17  Tom Tromey  <tromey@adacore.com>
+
+       * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
+       do_field_signed>: Rename.  Change type of "value".
+       * ui-out.c (ui_out::field_signed): Rename from field_int.
+       Change type of "value".
+       (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
+       type of "value".
+       * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
+       do_field_int.  Change type of "value".
+       * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
+       do_field_int.  Change type of "value".
+       * tracepoint.c (trace_status_mi, tfind_1)
+       (print_one_static_tracepoint_marker): Update.
+       * thread.c (print_thread_info_1, print_selected_thread_frame):
+       Update.
+       * stack.c (print_frame, print_frame_info): Update.
+       * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
+       Update.
+       * source.c (print_source_lines_base): Update.
+       * skip.c (info_skip_command): Update.
+       * record-btrace.c (btrace_ui_out_decode_error)
+       (btrace_call_history_src_line): Update.
+       * python/py-framefilter.c (py_print_single_arg, py_print_frame):
+       Update.
+       * progspace.c (print_program_space): Update.
+       * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
+       * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
+       do_field_int.  Change type of "value".
+       * mi/mi-out.c (mi_ui_out::do_table_begin)
+       (mi_ui_out::do_table_header): Update.
+       (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
+       type of "value".
+       * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
+       (mi_cmd_data_list_changed_registers, output_register)
+       (mi_cmd_data_read_memory, mi_load_progress)
+       (mi_cmd_trace_frame_collected): Update.
+       * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
+       Update.
+       * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
+       (mi_cmd_var_delete, mi_cmd_var_info_num_children)
+       (mi_cmd_var_list_children, varobj_update_one): Update.
+       * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
+       (mi_cmd_stack_list_args, list_arg_or_local): Update.
+       * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
+       * inferior.c (print_inferior): Update.
+       * gdb_bfd.c (print_one_bfd): Update.
+       * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
+       Update.
+       * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
+       * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
+       do_field_int.  Change type of "value".
+       * cli-out.c (cli_ui_out::do_field_signed): Rename from
+       do_field_int.  Change type of "value".
+       * breakpoint.c (watchpoint_check, print_breakpoint_location)
+       (print_one_breakpoint_location, print_it_catch_fork)
+       (print_one_catch_fork, print_it_catch_vfork)
+       (print_one_catch_vfork, print_it_catch_solib)
+       (print_it_catch_exec, print_it_ranged_breakpoint)
+       (print_mention_watchpoint, print_mention_masked_watchpoint)
+       (bkpt_print_it, update_static_tracepoint): Update.
+       * break-catch-throw.c (print_it_exception_catchpoint): Update.
+       * break-catch-syscall.c (print_it_catch_syscall): Update.
+       * ada-tasks.c (print_ada_task_info): Update.
+       * ada-lang.c (print_it_exception, print_mention_exception):
+       Update.
+
+2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       PR breakpoints/24541
+       * gdbarch.c: Regenerate.
+       * gdbarch.h: Regenerate.
+       * gdbarch.sh: Adjust return type and parameter types for
+       'stap_adjust_register'.
+       (i386_stap_adjust_register): Adjust signature and return new
+       register name.
+       * stap-probe.c (stap_parse_register_operand): Adjust use of
+       'gdbarch_stap_adjust_register'.
+
+2019-07-17  Tom Tromey  <tromey@adacore.com>
+
+       * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
+       declare VEC.
+       (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
+       std::vector.
+       (struct s390_process_info): Add initializers.
+       (s390_add_process): Use new.
+       (s390_linux_nat_target::low_forget_process): Use delete.
+       (s390_linux_nat_target::low_new_fork)
+       (s390_linux_nat_target::stopped_by_watchpoint)
+       (s390_linux_nat_target::low_prepare_to_resume)
+       (s390_linux_nat_target::insert_watchpoint)
+       (s390_linux_nat_target::insert_hw_breakpoint)
+       (s390_linux_nat_target::remove_watchpoint)
+       (s390_linux_nat_target::remove_hw_breakpoint): Update.
+
+2019-07-16  John Baldwin  <jhb@FreeBSD.org>
+
+       * aarch64-fbsd-nat.c: Include regcache.h.
+       (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
+       argument.
+       (aarch64_fbsd_nat_target::fetch_registers)
+       (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
+       variable.
+       * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
+
+2019-07-16  John Baldwin  <jhb@FreeBSD.org>
+
+       * fbsd-nat.c: Include gdbarch.h.
+
+2019-07-15  Tom Tromey  <tromey@adacore.com>
+
+       * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
+
+2019-07-15  Tom Tromey  <tromey@adacore.com>
+
+       * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
+       * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
+       * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
+       * cli-out.c (cli_ui_out::do_field_int): New method.
+       * ui-out.c (ui_out::field_unsigned): New method.
+       * symfile.c (generic_load): Use field_unsigned.
+       (print_transfer_performance): Likewise.
+       * record-btrace.c (ui_out_field_uint): Remove.
+       (btrace_call_history_insn_range, btrace_call_history): Use
+       field_unsigned.
+       * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
+       field_unsigned.
+       * ui-out.h (class ui_out) <field_unsigned>: New method.
+       <do_field_unsigned>: Likewise.
+
+2019-07-15  Tom Tromey  <tromey@adacore.com>
+
+       * mi/mi-main.c (list_available_thread_groups): Use field_string.
+       * mi/mi-interp.c (mi_memory_changed): Use field_string.
+       * target.c (flash_erase_command): Use field_string.
+       * infrun.c (print_signal_received_reason): Use field_string.
+       * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
+       * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
+       field_string.
+       * ada-tasks.c (print_ada_task_info): Use field_string.
+
+2019-07-15  Tom Tromey  <tromey@adacore.com>
+
+       * target.c (flash_erase_command): Use field_core_addr.
+       * symfile.c (generic_load): Use field_core_addr.
+       * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
+       Use field_core_addr.
+       * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
+       field_core_addr.
+
+2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
+       value if its desired type is smaller than a CORE_ADDR and signed.
+
+2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
+       of changes to field names, and use new is_reference field to
+       decide if a property is a reference or not.
+       * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
+       field.
+       (struct dwarf2_property_baton): Update header comment, rename
+       'referenced_type' to 'property_type' and update comments.
+       * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
+       default property type, store in property baton, update to take
+       accound of renamed field.
+       (read_func_scope): Update call to attr_to_dynamic_prop.
+       (read_array_type): Likewise.
+       (dwarf2_per_cu_addr_sized_int_type): New function.
+       (read_subrange_index_type): Move type finding code to
+       dwarf2_per_cu_addr_sized_int_type.
+       (read_subrange_type): Update calls to attr_to_dynamic_prop.
+       (dwarf2_per_cu_addr_type): New function.
+       (set_die_type): Update calls to attr_to_dynamic_prop.
+
+2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * dwarf2read.c (read_subrange_index_type): New function.
+       (read_subrange_type): Move code into new function and call it.
+       * gdbtypes.c (create_range_type): Add some asserts.
+
+2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
+       update return statements.
+       * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
+       declaration, and update comment to match.
+       * gdbtypes.c (resolve_dynamic_array): Update call to
+       dwarf2_evaluate_property to match new return type.
+
+2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * valarith.c (value_subscripted_rvalue): Change lowerbound
+       parameter type from int to LONGEST.
+       * value.h (value_subscripted_rvalue): Likewise in declaration.
+
+2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * cli/cli-utils.c (info_print_command_completer): New function.
+       * cli/cli-utils.h: Add 'completer.h' include, and forward
+       declaration for 'struct cmd_list_element'.
+       (info_print_command_completer): Declare.
+       * stack.c (_initialize_stack): Add completer for 'info locals' and
+       'info args'.
+       * symtab.c (_initialize_symtab): Add completer for 'info
+       variables' and 'info functions'.
+       * NEWS: Mention completion for additional info commands.
+
+2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * cli/cli-utils.c (extract_info_print_args): Delete.
+       (extract_arg_maybe_quoted): Delete.
+       (info_print_options_defs): New variable.
+       (make_info_print_options_def_group): New function.
+       (extract_info_print_options): Define new function.
+       * cli/cli-utils.h (extract_info_print_args): Delete.
+       (struct info_print_options): New structure.
+       (extract_info_print_options): Declare new function.
+       * stack.c (info_locals_command): Update to use new
+       extract_info_print_options, also add a header comment.
+       (info_args_command): Likewise.
+       * symtab.c (info_variables_command): Likewise.
+       (info_functions_command): Likewise.
+
+2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
+       to extract string arguments.
+       * common/common-utils.c (extract_string_maybe_quoted): New function.
+       * common/common-utils.h (extract_string_maybe_quoted): Declare.
+
+2019-07-11  Tom Tromey  <tromey@adacore.com>
+
+       * main.c (get_init_files): Use GDBINIT, not gdbinit.
+       * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
+       * top.h (gdbinit): Don't declare.
+       * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
+       into...
+       (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
+       * top.c (gdb_init): Don't call init_cli_cmds.
+       (gdbinit): Remove.
+       * cli/cli-cmds.h (init_cli_cmds): Don't declare.
+
+2019-07-11  Tom Tromey  <tromey@adacore.com>
+
+       * python/py-inferior.c (add_thread_object): Don't use thread_obj
+       after it has been moved.
+
+2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * valops.c (value_must_coerce_to_target): Change return type to
+       bool.
+       * value.h (value_must_coerce_to_target): Likewise.
+
+2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
+
+       * breakpoint.c (is_hardware_watchpoint): Remove
+       forward-declaration.
+       (is_masked_watchpoint): Change return type to bool.
+       (is_tracepoint): Likewise.
+       (is_breakpoint): Likewise.
+       (is_hardware_watchpoint): Likewise.
+       (is_watchpoint): Likewise.
+       (is_no_memory_software_watchpoint): Likewise.
+       (is_catchpoint): Likewise.
+       (breakpoint_1): Make FILTER parameter's return type bool.
+       is_masked_watchpoint): Change return type to bool.
+       (save_breakpoints): Make FILTER parameter's return type bool.
+       * breakpoint.h (is_breakpoint): Change return type to bool.
+       (is_watchpoint): Likewise.
+       (is_catchpoint): Likewise.
+       (is_tracepoint): Likewise.
+
+2019-07-10  Tom Tromey  <tom@tromey.com>
+
+       * defs.h: Don't include gdbarch.h.
+       * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
+       alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
+       ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
+       cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
+       cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
+       compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
+       cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
+       dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
+       dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
+       dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
+       frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
+       go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
+       i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
+       linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
+       mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
+       objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
+       parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
+       record-btrace.c, record.h, regcache-dump.c, regcache.h,
+       riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
+       sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
+       sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
+       sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
+       target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
+       tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
+       utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
+       xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
+       * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * ada-lang.h (is_ada_exception_catchpoint): Declare.
+       * breakpoint.c (init_ada_exception_breakpoint): Register as
+       bp_catchpoint.
+       (print_one_breakpoint_location, print_one_breakpoint): Use
+       is_ada_exception_catchpoint.
+       * ada-lang.c (class ada_catchpoint_location): Pass
+       bp_loc_software_breakpoint to bp_location constructor.
+       (is_ada_exception_catchpoint): New function.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
+       VEC.
+       (struct arm_exidx_entry): New method operator<.
+       (struct arm_exidx_data) <section_maps>: Change type.
+       (arm_exidx_data_free): Remove.
+       (arm_exidx_data_key): Change type.  Move lower.
+       (arm_exidx_new_objfile): Update.
+       (arm_compare_exidx_entries): Remove.
+       (arm_find_exidx_entry, _initialize_arm_tdep)
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * solib-spu.c (ocl_program_data_key): Change type.
+       (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
+       Update.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
+       (struct solib_aix_inferior_data) <library_list>: Change type.
+       (solib_aix_inferior_data_handle): Change type.
+       (get_solib_aix_inferior_data): Update.
+       (solib_aix_free_library_list): Remove.
+       (library_list_start_library): Update.
+       (solib_aix_parse_libraries, solib_aix_get_library_list): Change
+       return type.
+       (solib_aix_get_library_list)
+       (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
+       (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * solib-dsbt.c (struct dsbt_info): Add initializers.
+       (solib_dsbt_pspace_data): Change type.
+       (dsbt_pspace_data_cleanup): Remove.
+       (get_dsbt_info, _initialize_dsbt_solib): Update.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * spu-tdep.c (spu_overlay_data): Change type.
+       (spu_get_overlay_table, spu_overlay_new_objfile)
+       (_initialize_spu_tdep): Update.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
+       destructor.
+       (dbx_objfile_data_key): Change type and declare later.
+       (DBX_SYMFILE_INFO): Rewrite.
+       * dbxread.c (dbx_objfile_data_key): Change type.
+       (dbx_symfile_init): Update.
+       (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
+       (coffstab_build_psymtabs, elfstab_build_psymtabs)
+       (stabsect_build_psymtabs, _initialize_dbxread): Update.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * jit.c (jit_program_space_key): Change type.  Move lower.
+       (get_jit_program_space_data): Update.
+       (jit_program_space_data_cleanup): Remove.
+       (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
+       Update.
+       (struct jit_program_space_data): Add initializers.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * solib-darwin.c (struct darwin_info): Add initializers.
+       (solib_darwin_pspace_data): Change type.
+       (darwin_pspace_data_cleanup): Remove.
+       (get_darwin_info, _initialize_darwin_solib): Update.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * remote-sim.c (struct sim_inferior_data): Add initializers,
+       constructor, and destructor.
+       (sim_inferior_data_key): Change type.  Move lower.
+       (check_for_duplicate_sim_descriptor): Update.
+       (get_sim_inferior_data): Use new.  Update.
+       (~sim_inferior_data_cleanup): Rename from
+       sim_inferior_data_cleanup.  Simplify.
+       (gdbsim_close_inferior, simulator_command)
+       (sim_command_completer, _initialize_remote_sim): Update.
+       (next_pid, INITIAL_PID): Move earlier.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * python/python-internal.h (create_thread_object): Return
+       gdbpy_ref.
+       * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
+       * python/py-inferior.c (struct threadlist_entry): Add
+       constructor.
+       <thread_obj>: Now a gdbpy_ref.
+       (thread_to_thread_object): Update.
+       (add_thread_object): Use new.
+       (delete_thread_object): Use delete.
+       (infpy_threads): Update.
+       (py_free_inferior): Update.  Construct "inf_obj" after acquiring
+       GIL.
+
+2019-07-10  Tom Tromey  <tromey@adacore.com>
+
+       * valops.c (value_cast): Specialize error message for Ada.
+
+2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * breakpoint.c (breakpoint_1): Update doc and parameter names.
+
+2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
+       bpstat_should_step): Return bool, adjust comments.
+       * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
+       bpstat_should_step): Likewise.
+
+2019-07-10  Alan Hayward  <alan.hayward@arm.com>
+
+       * features/Makefile: Use feature target descriptions for Arm.
+       * features/arm/arm-core.c: Generate new file.
+       * features/arm/arm-fpa.c: Likewise.
+       * features/arm/arm-m-profile-with-fpa.xml: Likewise.
+       * features/arm/arm-m-profile.c: Likewise.
+       * features/arm/arm-vfpv2.c: Likewise.
+       * features/arm/arm-vfpv3.c: Likewise.
+       * features/arm/xscale-iwmmxt.c: Likewise.
+       * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
+
+2019-07-10  Alan Hayward  <alan.hayward@arm.com>
+
+       * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
+       ptrace earlier.
+
+2019-07-10  Alan Hayward  <alan.hayward@arm.com>
+
+       * features/aarch64-pauth.c: Regenerate.
+
+2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
+       bool.
+       (bpstat_what): Use false instead of 0.
+
 2019-07-09  Pedro Alves  <palves@redhat.com>
 
        * break-catch-throw.c (is_exception_catchpoint): New.