grep: make "-f -" work (+ testsuite)
[platform/upstream/busybox.git] / findutils / grep.c
index e543ee0..fc78938 100644 (file)
@@ -7,7 +7,7 @@
  *
  * Licensed under the GPL v2 or later, see the file LICENSE in this tarball.
  */
-/* BB_AUDIT SUSv3 defects - unsupported option -x */
+/* BB_AUDIT SUSv3 defects - unsupported option -x "match whole line only". */
 /* BB_AUDIT GNU defects - always acts as -a.  */
 /* http://www.opengroup.org/onlinepubs/007904975/utilities/grep.html */
 /*
@@ -35,7 +35,7 @@
 enum {
        OPTBIT_l, /* list matched file names only */
        OPTBIT_n, /* print line# */
-       OPTBIT_q, /* quiet - exit(0) of first match */
+       OPTBIT_q, /* quiet - exit(EXIT_SUCCESS) of first match */
        OPTBIT_v, /* invert the match, to select non-matching lines */
        OPTBIT_s, /* suppress errors about file open errors */
        OPTBIT_c, /* count matches per file (suppresses normal output) */
@@ -85,33 +85,53 @@ enum {
 #define FGREP_FLAG                  (option_mask32 & OPT_F)
 #define PRINT_FILES_WITHOUT_MATCHES (option_mask32 & OPT_L)
 
-typedef unsigned char byte_t;
-
-static int max_matches;
-static int reflags;
-static byte_t invert_search;
-static byte_t print_filename;
-static byte_t open_errors;
-
+struct globals {
+       int max_matches;
+       int reflags;
+       smalluint invert_search;
+       smalluint print_filename;
+       smalluint open_errors;
 #if ENABLE_FEATURE_GREP_CONTEXT
-static byte_t did_print_line;
-static int lines_before;
-static int lines_after;
-static char **before_buf;
-static int last_line_printed;
-#endif /* ENABLE_FEATURE_GREP_CONTEXT */
-/* globals used internally */
-static llist_t *pattern_head;   /* growable list of patterns to match */
-static const char *cur_file;    /* the current file we are reading */
+       smalluint did_print_line;
+       int lines_before;
+       int lines_after;
+       char **before_buf;
+       int last_line_printed;
+#endif
+       /* globals used internally */
+       llist_t *pattern_head;   /* growable list of patterns to match */
+       const char *cur_file;    /* the current file we are reading */
+};
+#define G (*(struct globals*)&bb_common_bufsiz1)
+#define INIT_G() \
+       do { \
+               struct G_sizecheck { \
+                       char G_sizecheck[sizeof(G) > COMMON_BUFSIZE ? -1 : 1]; \
+               }; \
+       } while (0)
+#define max_matches       (G.max_matches         )
+#define reflags           (G.reflags             )
+#define invert_search     (G.invert_search       )
+#define print_filename    (G.print_filename      )
+#define open_errors       (G.open_errors         )
+#define did_print_line    (G.did_print_line      )
+#define lines_before      (G.lines_before        )
+#define lines_after       (G.lines_after         )
+#define before_buf        (G.before_buf          )
+#define last_line_printed (G.last_line_printed   )
+#define pattern_head      (G.pattern_head        )
+#define cur_file          (G.cur_file            )
+
 
 typedef struct grep_list_data_t {
        char *pattern;
        regex_t preg;
-#define PATTERN_MEM_A 1
+#define ALLOCATED 1
 #define COMPILED 2
        int flg_mem_alocated_compiled;
 } grep_list_data_t;
 
+
 static void print_line(const char *line, int linenum, char decoration)
 {
 #if ENABLE_FEATURE_GREP_CONTEXT
@@ -140,7 +160,7 @@ static void print_line(const char *line, int linenum, char decoration)
 static int grep_file(FILE *file)
 {
        char *line;
-       byte_t ret;
+       smalluint found;
        int linenum = 0;
        int nmatches = 0;
        regmatch_t regmatch;
@@ -152,23 +172,17 @@ static int grep_file(FILE *file)
        enum { print_n_lines_after = 0 };
 #endif /* ENABLE_FEATURE_GREP_CONTEXT */
 
-       while ((line = xmalloc_getline(file)) != NULL) {
+       while ((line = xmalloc_fgetline(file)) != NULL) {
                llist_t *pattern_ptr = pattern_head;
-               grep_list_data_t * gl;
+               grep_list_data_t *gl = gl; /* for gcc */
 
                linenum++;
-               ret = 0;
+               found = 0;
                while (pattern_ptr) {
                        gl = (grep_list_data_t *)pattern_ptr->data;
                        if (FGREP_FLAG) {
-                               ret = strstr(line, gl->pattern) != NULL;
+                               found |= (strstr(line, gl->pattern) != NULL);
                        } else {
-                               /*
-                                * test for a postitive-assertion match (regexec returns success (0)
-                                * and the user did not specify invert search), or a negative-assertion
-                                * match (regexec returns failure (REG_NOMATCH) and the user specified
-                                * invert search)
-                                */
                                if (!(gl->flg_mem_alocated_compiled & COMPILED)) {
                                        gl->flg_mem_alocated_compiled |= COMPILED;
                                        xregcomp(&(gl->preg), gl->pattern, reflags);
@@ -177,7 +191,7 @@ static int grep_file(FILE *file)
                                regmatch.rm_eo = 0;
                                if (regexec(&(gl->preg), line, 1, &regmatch, 0) == 0) {
                                        if (!(option_mask32 & OPT_w))
-                                               ret = 1;
+                                               found = 1;
                                        else {
                                                char c = ' ';
                                                if (regmatch.rm_so)
@@ -185,15 +199,20 @@ static int grep_file(FILE *file)
                                                if (!isalnum(c) && c != '_') {
                                                        c = line[regmatch.rm_eo];
                                                        if (!c || (!isalnum(c) && c != '_'))
-                                                               ret = 1;
+                                                               found = 1;
                                                }
                                        }
                                }
                        }
+                       /* If it's non-inverted search, we can stop
+                        * at first match */
+                       if (found && !invert_search)
+                               goto do_found;
                        pattern_ptr = pattern_ptr->link;
                } /* while (pattern_ptr) */
 
-               if (ret ^ invert_search) {
+               if (found ^ invert_search) {
+ do_found:
                        /* keep track of matches */
                        nmatches++;
 
@@ -205,12 +224,12 @@ static int grep_file(FILE *file)
                                         * "exit immediately with zero status
                                         * if any match is found,
                                         * even if errors were detected" */
-                                       exit(0);
+                                       exit(EXIT_SUCCESS);
                                }
                                /* if we're just printing filenames, we stop after the first match */
                                if (PRINT_FILES_WITH_MATCHES) {
                                        puts(cur_file);
-                                       /* fall thru to "return 1" */
+                                       /* fall through to "return 1" */
                                }
                                /* OPT_L aka PRINT_FILES_WITHOUT_MATCHES: return early */
                                return 1; /* one match */
@@ -255,8 +274,15 @@ static int grep_file(FILE *file)
                                print_n_lines_after = lines_after;
 #endif
                                if (option_mask32 & OPT_o) {
-                                       line[regmatch.rm_eo] = '\0';
-                                       print_line(line + regmatch.rm_so, linenum, ':');
+                                       if (FGREP_FLAG) {
+                                               /* -Fo just prints the pattern
+                                                * (unless -v: -Fov doesnt print anything at all) */
+                                               if (found)
+                                                       print_line(gl->pattern, linenum, ':');
+                                       } else {
+                                               line[regmatch.rm_eo] = '\0';
+                                               print_line(line + regmatch.rm_so, linenum, ':');
+                                       }
                                } else {
                                        print_line(line, linenum, ':');
                                }
@@ -273,7 +299,7 @@ static int grep_file(FILE *file)
                                free(before_buf[curpos]);
                                before_buf[curpos] = line;
                                curpos = (curpos + 1) % lines_before;
-                               /* avoid free(line) - we took line */
+                               /* avoid free(line) - we took the line */
                                line = NULL;
                        }
                }
@@ -310,18 +336,18 @@ static int grep_file(FILE *file)
 
 #if ENABLE_FEATURE_CLEAN_UP
 #define new_grep_list_data(p, m) add_grep_list_data(p, m)
-static char * add_grep_list_data(char *pattern, int flg_used_mem)
+static char *add_grep_list_data(char *pattern, int flg_used_mem)
 #else
 #define new_grep_list_data(p, m) add_grep_list_data(p)
-static char * add_grep_list_data(char *pattern)
+static char *add_grep_list_data(char *pattern)
 #endif
 {
-       grep_list_data_t *gl = xmalloc(sizeof(grep_list_data_t));
+       grep_list_data_t *gl = xzalloc(sizeof(*gl));
        gl->pattern = pattern;
 #if ENABLE_FEATURE_CLEAN_UP
        gl->flg_mem_alocated_compiled = flg_used_mem;
 #else
-       gl->flg_mem_alocated_compiled = 0;
+       /*gl->flg_mem_alocated_compiled = 0;*/
 #endif
        return (char *)gl;
 }
@@ -337,20 +363,23 @@ static void load_regexes_from_file(llist_t *fopt)
 
                fopt = cur->link;
                free(cur);
-               f = xfopen(ffile, "r");
-               while ((line = xmalloc_getline(f)) != NULL) {
+               f = xfopen_stdin(ffile);
+               while ((line = xmalloc_fgetline(f)) != NULL) {
                        llist_add_to(&pattern_head,
-                               new_grep_list_data(line, PATTERN_MEM_A));
+                               new_grep_list_data(line, ALLOCATED));
                }
        }
 }
 
-static int file_action_grep(const char *filename, struct stat *statbuf, void* matched, int depth)
+static int file_action_grep(const char *filename,
+                       struct stat *statbuf ATTRIBUTE_UNUSED,
+                       void* matched,
+                       int depth ATTRIBUTE_UNUSED)
 {
        FILE *file = fopen(filename, "r");
        if (file == NULL) {
                if (!SUPPRESS_ERR_MSGS)
-                       bb_perror_msg("%s", cur_file);
+                       bb_simple_perror_msg(filename);
                open_errors = 1;
                return 0;
        }
@@ -374,40 +403,33 @@ static int grep_dir(const char *dir)
        return matched;
 }
 
-int grep_main(int argc, char **argv);
+int grep_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int grep_main(int argc, char **argv)
 {
        FILE *file;
        int matched;
-       char *mopt;
        llist_t *fopt = NULL;
 
        /* do normal option parsing */
 #if ENABLE_FEATURE_GREP_CONTEXT
-       char *slines_after;
-       char *slines_before;
-       char *Copt;
+       int Copt;
 
-       opt_complementary = "H-h:e::f::C-AB";
-       getopt32(argc, argv,
+       /* -H unsets -h; -C unsets -A,-B; -e,-f are lists;
+        * -m,-A,-B,-C have numeric param */
+       opt_complementary = "H-h:C-AB:e::f::m+:A+:B+:C+";
+       getopt32(argv,
                OPTSTR_GREP,
-               &pattern_head, &fopt, &mopt,
-               &slines_after, &slines_before, &Copt);
+               &pattern_head, &fopt, &max_matches,
+               &lines_after, &lines_before, &Copt);
 
        if (option_mask32 & OPT_C) {
                /* -C unsets prev -A and -B, but following -A or -B
                   may override it */
                if (!(option_mask32 & OPT_A)) /* not overridden */
-                       slines_after = Copt;
+                       lines_after = Copt;
                if (!(option_mask32 & OPT_B)) /* not overridden */
-                       slines_before = Copt;
-               option_mask32 |= OPT_A|OPT_B; /* for parser */
-       }
-       if (option_mask32 & OPT_A) {
-               lines_after = xatoi_u(slines_after);
-       }
-       if (option_mask32 & OPT_B) {
-               lines_before = xatoi_u(slines_before);
+                       lines_before = Copt;
+               //option_mask32 |= OPT_A|OPT_B; /* for parser */
        }
        /* sanity checks */
        if (option_mask32 & (OPT_c|OPT_q|OPT_l|OPT_L)) {
@@ -418,13 +440,11 @@ int grep_main(int argc, char **argv)
                before_buf = xzalloc(lines_before * sizeof(char *));
 #else
        /* with auto sanity checks */
-       opt_complementary = "H-h:e::f::c-n:q-n:l-n";
-       getopt32(argc, argv, OPTSTR_GREP,
-               &pattern_head, &fopt, &mopt);
+       /* -H unsets -h; -c,-q or -l unset -n; -e,-f are lists; -m N */
+       opt_complementary = "H-h:c-n:q-n:l-n:e::f::m+";
+       getopt32(argv, OPTSTR_GREP,
+               &pattern_head, &fopt, &max_matches);
 #endif
-       if (option_mask32 & OPT_m) {
-               max_matches = xatoi_u(mopt);
-       }
        invert_search = ((option_mask32 & OPT_v) != 0); /* 0 | 1 */
 
        if (pattern_head != NULL) {
@@ -443,9 +463,11 @@ int grep_main(int argc, char **argv)
        if (!(option_mask32 & (OPT_o | OPT_w)))
                reflags = REG_NOSUB;
 
-       if (ENABLE_FEATURE_GREP_EGREP_ALIAS &&
-                       (applet_name[0] == 'e' || (option_mask32 & OPT_E)))
+       if (ENABLE_FEATURE_GREP_EGREP_ALIAS
+        && (applet_name[0] == 'e' || (option_mask32 & OPT_E))
+       ) {
                reflags |= REG_EXTENDED;
+       }
 
        if (option_mask32 & OPT_i)
                reflags |= REG_ICASE;
@@ -453,8 +475,8 @@ int grep_main(int argc, char **argv)
        argv += optind;
        argc -= optind;
 
-       /* if we didn't get a pattern from -e and no command file was specified,
-        * argv[optind] should be the pattern. no pattern, no worky */
+       /* if we didn't get a pattern from -e and no command file was specified,
+        * first parameter should be the pattern. no pattern, no worky */
        if (pattern_head == NULL) {
                char *pattern;
                if (*argv == NULL)
@@ -464,7 +486,7 @@ int grep_main(int argc, char **argv)
                argc--;
        }
 
-       /* argv[(optind)..(argc-1)] should be names of file to grep through. If
+       /* argv[0..(argc-1)] should be names of file to grep through. If
         * there is more than one file to grep, we will print the filenames. */
        if (argc > 1)
                print_filename = 1;
@@ -476,13 +498,11 @@ int grep_main(int argc, char **argv)
 
        /* If no files were specified, or '-' was specified, take input from
         * stdin. Otherwise, we grep through all the files specified. */
-       if (argc == 0)
-               argc++;
        matched = 0;
-       while (argc--) {
+       do {
                cur_file = *argv++;
                file = stdin;
-               if (!cur_file || (*cur_file == '-' && !cur_file[1])) {
+               if (!cur_file || LONE_DASH(cur_file)) {
                        cur_file = "(standard input)";
                } else {
                        if (option_mask32 & OPT_r) {
@@ -498,7 +518,7 @@ int grep_main(int argc, char **argv)
                        file = fopen(cur_file, "r");
                        if (file == NULL) {
                                if (!SUPPRESS_ERR_MSGS)
-                                       bb_perror_msg("%s", cur_file);
+                                       bb_simple_perror_msg(cur_file);
                                open_errors = 1;
                                continue;
                        }
@@ -506,19 +526,18 @@ int grep_main(int argc, char **argv)
                matched += grep_file(file);
                fclose_if_not_stdin(file);
  grep_done: ;
-       }
+       } while (--argc > 0);
 
        /* destroy all the elments in the pattern list */
        if (ENABLE_FEATURE_CLEAN_UP) {
                while (pattern_head) {
                        llist_t *pattern_head_ptr = pattern_head;
-                       grep_list_data_t *gl =
-                               (grep_list_data_t *)pattern_head_ptr->data;
+                       grep_list_data_t *gl = (grep_list_data_t *)pattern_head_ptr->data;
 
                        pattern_head = pattern_head->link;
-                       if ((gl->flg_mem_alocated_compiled & PATTERN_MEM_A))
+                       if (gl->flg_mem_alocated_compiled & ALLOCATED)
                                free(gl->pattern);
-                       if ((gl->flg_mem_alocated_compiled & COMPILED))
+                       if (gl->flg_mem_alocated_compiled & COMPILED)
                                regfree(&(gl->preg));
                        free(gl);
                        free(pattern_head_ptr);
@@ -527,5 +546,5 @@ int grep_main(int argc, char **argv)
        /* 0 = success, 1 = failed, 2 = error */
        if (open_errors)
                return 2;
-       return !matched; /* invert return value 0 = success, 1 = failed */
+       return !matched; /* invert return value: 0 = success, 1 = failed */
 }