sysfs: kill unnecessary attribute->owner
[platform/adaptation/renesas_rcar/renesas_kernel.git] / drivers / video / backlight / lcd.c
index bc8ab00..648b53c 100644 (file)
 #include <linux/err.h>
 #include <linux/fb.h>
 
+#if defined(CONFIG_FB) || (defined(CONFIG_FB_MODULE) && \
+                          defined(CONFIG_LCD_CLASS_DEVICE_MODULE))
+/* This callback gets called when something important happens inside a
+ * framebuffer driver. We're looking if that important event is blanking,
+ * and if it is, we're switching lcd power as well ...
+ */
+static int fb_notifier_callback(struct notifier_block *self,
+                                unsigned long event, void *data)
+{
+       struct lcd_device *ld;
+       struct fb_event *evdata = data;
+
+       /* If we aren't interested in this event, skip it immediately ... */
+       if (event != FB_EVENT_BLANK)
+               return 0;
+
+       ld = container_of(self, struct lcd_device, fb_notif);
+       mutex_lock(&ld->ops_lock);
+       if (ld->ops)
+               if (!ld->ops->check_fb || ld->ops->check_fb(evdata->info))
+                       ld->ops->set_power(ld, *(int *)evdata->data);
+       mutex_unlock(&ld->ops_lock);
+       return 0;
+}
+
+static int lcd_register_fb(struct lcd_device *ld)
+{
+       memset(&ld->fb_notif, 0, sizeof(&ld->fb_notif));
+       ld->fb_notif.notifier_call = fb_notifier_callback;
+       return fb_register_client(&ld->fb_notif);
+}
+
+static void lcd_unregister_fb(struct lcd_device *ld)
+{
+       fb_unregister_client(&ld->fb_notif);
+}
+#else
+static int lcd_register_fb(struct lcd_device *ld)
+{
+       return 0;
+}
+
+static inline void lcd_unregister_fb(struct lcd_device *ld)
+{
+}
+#endif /* CONFIG_FB */
+
 static ssize_t lcd_show_power(struct class_device *cdev, char *buf)
 {
        int rc;
        struct lcd_device *ld = to_lcd_device(cdev);
 
-       down(&ld->sem);
-       if (likely(ld->props && ld->props->get_power))
-               rc = sprintf(buf, "%d\n", ld->props->get_power(ld));
+       mutex_lock(&ld->ops_lock);
+       if (ld->ops && ld->ops->get_power)
+               rc = sprintf(buf, "%d\n", ld->ops->get_power(ld));
        else
                rc = -ENXIO;
-       up(&ld->sem);
+       mutex_unlock(&ld->ops_lock);
 
        return rc;
 }
@@ -42,13 +89,13 @@ static ssize_t lcd_store_power(struct class_device *cdev, const char *buf, size_
        if (size != count)
                return -EINVAL;
 
-       down(&ld->sem);
-       if (likely(ld->props && ld->props->set_power)) {
+       mutex_lock(&ld->ops_lock);
+       if (ld->ops && ld->ops->set_power) {
                pr_debug("lcd: set power to %d\n", power);
-               ld->props->set_power(ld, power);
+               ld->ops->set_power(ld, power);
                rc = count;
        }
-       up(&ld->sem);
+       mutex_unlock(&ld->ops_lock);
 
        return rc;
 }
@@ -58,10 +105,10 @@ static ssize_t lcd_show_contrast(struct class_device *cdev, char *buf)
        int rc = -ENXIO;
        struct lcd_device *ld = to_lcd_device(cdev);
 
-       down(&ld->sem);
-       if (likely(ld->props && ld->props->get_contrast))
-               rc = sprintf(buf, "%d\n", ld->props->get_contrast(ld));
-       up(&ld->sem);
+       mutex_lock(&ld->ops_lock);
+       if (ld->ops && ld->ops->get_contrast)
+               rc = sprintf(buf, "%d\n", ld->ops->get_contrast(ld));
+       mutex_unlock(&ld->ops_lock);
 
        return rc;
 }
@@ -79,28 +126,22 @@ static ssize_t lcd_store_contrast(struct class_device *cdev, const char *buf, si
        if (size != count)
                return -EINVAL;
 
-       down(&ld->sem);
-       if (likely(ld->props && ld->props->set_contrast)) {
+       mutex_lock(&ld->ops_lock);
+       if (ld->ops && ld->ops->set_contrast) {
                pr_debug("lcd: set contrast to %d\n", contrast);
-               ld->props->set_contrast(ld, contrast);
+               ld->ops->set_contrast(ld, contrast);
                rc = count;
        }
-       up(&ld->sem);
+       mutex_unlock(&ld->ops_lock);
 
        return rc;
 }
 
 static ssize_t lcd_show_max_contrast(struct class_device *cdev, char *buf)
 {
-       int rc = -ENXIO;
        struct lcd_device *ld = to_lcd_device(cdev);
 
-       down(&ld->sem);
-       if (likely(ld->props))
-               rc = sprintf(buf, "%d\n", ld->props->max_contrast);
-       up(&ld->sem);
-
-       return rc;
+       return sprintf(buf, "%d\n", ld->props.max_contrast);
 }
 
 static void lcd_class_release(struct class_device *dev)
@@ -116,87 +157,63 @@ static struct class lcd_class = {
 
 #define DECLARE_ATTR(_name,_mode,_show,_store)                 \
 {                                                              \
-       .attr   = { .name = __stringify(_name), .mode = _mode, .owner = THIS_MODULE },  \
+       .attr   = { .name = __stringify(_name), .mode = _mode }, \
        .show   = _show,                                        \
        .store  = _store,                                       \
 }
 
-static struct class_device_attribute lcd_class_device_attributes[] = {
+static const struct class_device_attribute lcd_class_device_attributes[] = {
        DECLARE_ATTR(power, 0644, lcd_show_power, lcd_store_power),
        DECLARE_ATTR(contrast, 0644, lcd_show_contrast, lcd_store_contrast),
        DECLARE_ATTR(max_contrast, 0444, lcd_show_max_contrast, NULL),
 };
 
-/* This callback gets called when something important happens inside a
- * framebuffer driver. We're looking if that important event is blanking,
- * and if it is, we're switching lcd power as well ...
- */
-static int fb_notifier_callback(struct notifier_block *self,
-                                unsigned long event, void *data)
-{
-       struct lcd_device *ld;
-       struct fb_event *evdata =(struct fb_event *)data;
-
-       /* If we aren't interested in this event, skip it immediately ... */
-       if (event != FB_EVENT_BLANK)
-               return 0;
-
-       ld = container_of(self, struct lcd_device, fb_notif);
-       down(&ld->sem);
-       if (ld->props)
-               if (!ld->props->check_fb || ld->props->check_fb(evdata->info))
-                       ld->props->set_power(ld, *(int *)evdata->data);
-       up(&ld->sem);
-       return 0;
-}
-
 /**
  * lcd_device_register - register a new object of lcd_device class.
  * @name: the name of the new object(must be the same as the name of the
  *   respective framebuffer device).
  * @devdata: an optional pointer to be stored in the class_device. The
  *   methods may retrieve it by using class_get_devdata(ld->class_dev).
- * @lp: the lcd properties structure.
+ * @ops: the lcd operations structure.
  *
  * Creates and registers a new lcd class_device. Returns either an ERR_PTR()
  * or a pointer to the newly allocated device.
  */
 struct lcd_device *lcd_device_register(const char *name, void *devdata,
-                                      struct lcd_properties *lp)
+                                      struct lcd_ops *ops)
 {
        int i, rc;
        struct lcd_device *new_ld;
 
        pr_debug("lcd_device_register: name=%s\n", name);
 
-       new_ld = kmalloc(sizeof(struct lcd_device), GFP_KERNEL);
-       if (unlikely(!new_ld))
+       new_ld = kzalloc(sizeof(struct lcd_device), GFP_KERNEL);
+       if (!new_ld)
                return ERR_PTR(-ENOMEM);
 
-       init_MUTEX(&new_ld->sem);
-       new_ld->props = lp;
-       memset(&new_ld->class_dev, 0, sizeof(new_ld->class_dev));
+       mutex_init(&new_ld->ops_lock);
+       mutex_init(&new_ld->update_lock);
+       new_ld->ops = ops;
        new_ld->class_dev.class = &lcd_class;
        strlcpy(new_ld->class_dev.class_id, name, KOBJ_NAME_LEN);
        class_set_devdata(&new_ld->class_dev, devdata);
 
        rc = class_device_register(&new_ld->class_dev);
-       if (unlikely(rc)) {
-error:         kfree(new_ld);
+       if (rc) {
+               kfree(new_ld);
                return ERR_PTR(rc);
        }
 
-       memset(&new_ld->fb_notif, 0, sizeof(new_ld->fb_notif));
-       new_ld->fb_notif.notifier_call = fb_notifier_callback;
-
-       rc = fb_register_client(&new_ld->fb_notif);
-       if (unlikely(rc))
-               goto error;
+       rc = lcd_register_fb(new_ld);
+       if (rc) {
+               class_device_unregister(&new_ld->class_dev);
+               return ERR_PTR(rc);
+       }
 
        for (i = 0; i < ARRAY_SIZE(lcd_class_device_attributes); i++) {
                rc = class_device_create_file(&new_ld->class_dev,
                                              &lcd_class_device_attributes[i]);
-               if (unlikely(rc)) {
+               if (rc) {
                        while (--i >= 0)
                                class_device_remove_file(&new_ld->class_dev,
                                                         &lcd_class_device_attributes[i]);
@@ -229,12 +246,10 @@ void lcd_device_unregister(struct lcd_device *ld)
                class_device_remove_file(&ld->class_dev,
                                         &lcd_class_device_attributes[i]);
 
-       down(&ld->sem);
-       ld->props = NULL;
-       up(&ld->sem);
-
-       fb_unregister_client(&ld->fb_notif);
-
+       mutex_lock(&ld->ops_lock);
+       ld->ops = NULL;
+       mutex_unlock(&ld->ops_lock);
+       lcd_unregister_fb(ld);
        class_device_unregister(&ld->class_dev);
 }
 EXPORT_SYMBOL(lcd_device_unregister);