global: Move remaining CONFIG_SYS_* to CFG_SYS_*
[platform/kernel/u-boot.git] / drivers / spi / cadence_qspi_apb.c
index 55a7501..d1f8913 100644 (file)
  */
 
 #include <common.h>
+#include <log.h>
 #include <asm/io.h>
+#include <dma.h>
+#include <linux/bitops.h>
+#include <linux/delay.h>
 #include <linux/errno.h>
 #include <wait_bit.h>
 #include <spi.h>
+#include <spi-mem.h>
 #include <malloc.h>
 #include "cadence_qspi.h"
 
-#define CQSPI_REG_POLL_US                      1 /* 1us */
-#define CQSPI_REG_RETRY                                10000
-#define CQSPI_POLL_IDLE_RETRY                  3
-
-/* Transfer mode */
-#define CQSPI_INST_TYPE_SINGLE                 0
-#define CQSPI_INST_TYPE_DUAL                   1
-#define CQSPI_INST_TYPE_QUAD                   2
-
-#define CQSPI_STIG_DATA_LEN_MAX                        8
-
-#define CQSPI_DUMMY_CLKS_PER_BYTE              8
-#define CQSPI_DUMMY_BYTES_MAX                  4
-
-/****************************************************************************
- * Controller's configuration and status register (offset from QSPI_BASE)
- ****************************************************************************/
-#define        CQSPI_REG_CONFIG                        0x00
-#define        CQSPI_REG_CONFIG_ENABLE                 BIT(0)
-#define        CQSPI_REG_CONFIG_CLK_POL                BIT(1)
-#define        CQSPI_REG_CONFIG_CLK_PHA                BIT(2)
-#define        CQSPI_REG_CONFIG_DIRECT                 BIT(7)
-#define        CQSPI_REG_CONFIG_DECODE                 BIT(9)
-#define        CQSPI_REG_CONFIG_XIP_IMM                BIT(18)
-#define        CQSPI_REG_CONFIG_CHIPSELECT_LSB         10
-#define        CQSPI_REG_CONFIG_BAUD_LSB               19
-#define        CQSPI_REG_CONFIG_IDLE_LSB               31
-#define        CQSPI_REG_CONFIG_CHIPSELECT_MASK        0xF
-#define        CQSPI_REG_CONFIG_BAUD_MASK              0xF
-
-#define        CQSPI_REG_RD_INSTR                      0x04
-#define        CQSPI_REG_RD_INSTR_OPCODE_LSB           0
-#define        CQSPI_REG_RD_INSTR_TYPE_INSTR_LSB       8
-#define        CQSPI_REG_RD_INSTR_TYPE_ADDR_LSB        12
-#define        CQSPI_REG_RD_INSTR_TYPE_DATA_LSB        16
-#define        CQSPI_REG_RD_INSTR_MODE_EN_LSB          20
-#define        CQSPI_REG_RD_INSTR_DUMMY_LSB            24
-#define        CQSPI_REG_RD_INSTR_TYPE_INSTR_MASK      0x3
-#define        CQSPI_REG_RD_INSTR_TYPE_ADDR_MASK       0x3
-#define        CQSPI_REG_RD_INSTR_TYPE_DATA_MASK       0x3
-#define        CQSPI_REG_RD_INSTR_DUMMY_MASK           0x1F
-
-#define        CQSPI_REG_WR_INSTR                      0x08
-#define        CQSPI_REG_WR_INSTR_OPCODE_LSB           0
-#define        CQSPI_REG_WR_INSTR_TYPE_DATA_LSB        16
-
-#define        CQSPI_REG_DELAY                         0x0C
-#define        CQSPI_REG_DELAY_TSLCH_LSB               0
-#define        CQSPI_REG_DELAY_TCHSH_LSB               8
-#define        CQSPI_REG_DELAY_TSD2D_LSB               16
-#define        CQSPI_REG_DELAY_TSHSL_LSB               24
-#define        CQSPI_REG_DELAY_TSLCH_MASK              0xFF
-#define        CQSPI_REG_DELAY_TCHSH_MASK              0xFF
-#define        CQSPI_REG_DELAY_TSD2D_MASK              0xFF
-#define        CQSPI_REG_DELAY_TSHSL_MASK              0xFF
-
-#define        CQSPI_REG_RD_DATA_CAPTURE               0x10
-#define        CQSPI_REG_RD_DATA_CAPTURE_BYPASS        BIT(0)
-#define        CQSPI_REG_RD_DATA_CAPTURE_DELAY_LSB     1
-#define        CQSPI_REG_RD_DATA_CAPTURE_DELAY_MASK    0xF
-
-#define        CQSPI_REG_SIZE                          0x14
-#define        CQSPI_REG_SIZE_ADDRESS_LSB              0
-#define        CQSPI_REG_SIZE_PAGE_LSB                 4
-#define        CQSPI_REG_SIZE_BLOCK_LSB                16
-#define        CQSPI_REG_SIZE_ADDRESS_MASK             0xF
-#define        CQSPI_REG_SIZE_PAGE_MASK                0xFFF
-#define        CQSPI_REG_SIZE_BLOCK_MASK               0x3F
-
-#define        CQSPI_REG_SRAMPARTITION                 0x18
-#define        CQSPI_REG_INDIRECTTRIGGER               0x1C
-
-#define        CQSPI_REG_REMAP                         0x24
-#define        CQSPI_REG_MODE_BIT                      0x28
-
-#define        CQSPI_REG_SDRAMLEVEL                    0x2C
-#define        CQSPI_REG_SDRAMLEVEL_RD_LSB             0
-#define        CQSPI_REG_SDRAMLEVEL_WR_LSB             16
-#define        CQSPI_REG_SDRAMLEVEL_RD_MASK            0xFFFF
-#define        CQSPI_REG_SDRAMLEVEL_WR_MASK            0xFFFF
-
-#define        CQSPI_REG_IRQSTATUS                     0x40
-#define        CQSPI_REG_IRQMASK                       0x44
-
-#define        CQSPI_REG_INDIRECTRD                    0x60
-#define        CQSPI_REG_INDIRECTRD_START              BIT(0)
-#define        CQSPI_REG_INDIRECTRD_CANCEL             BIT(1)
-#define        CQSPI_REG_INDIRECTRD_INPROGRESS         BIT(2)
-#define        CQSPI_REG_INDIRECTRD_DONE               BIT(5)
-
-#define        CQSPI_REG_INDIRECTRDWATERMARK           0x64
-#define        CQSPI_REG_INDIRECTRDSTARTADDR           0x68
-#define        CQSPI_REG_INDIRECTRDBYTES               0x6C
-
-#define        CQSPI_REG_CMDCTRL                       0x90
-#define        CQSPI_REG_CMDCTRL_EXECUTE               BIT(0)
-#define        CQSPI_REG_CMDCTRL_INPROGRESS            BIT(1)
-#define        CQSPI_REG_CMDCTRL_DUMMY_LSB             7
-#define        CQSPI_REG_CMDCTRL_WR_BYTES_LSB          12
-#define        CQSPI_REG_CMDCTRL_WR_EN_LSB             15
-#define        CQSPI_REG_CMDCTRL_ADD_BYTES_LSB         16
-#define        CQSPI_REG_CMDCTRL_ADDR_EN_LSB           19
-#define        CQSPI_REG_CMDCTRL_RD_BYTES_LSB          20
-#define        CQSPI_REG_CMDCTRL_RD_EN_LSB             23
-#define        CQSPI_REG_CMDCTRL_OPCODE_LSB            24
-#define        CQSPI_REG_CMDCTRL_DUMMY_MASK            0x1F
-#define        CQSPI_REG_CMDCTRL_WR_BYTES_MASK         0x7
-#define        CQSPI_REG_CMDCTRL_ADD_BYTES_MASK        0x3
-#define        CQSPI_REG_CMDCTRL_RD_BYTES_MASK         0x7
-#define        CQSPI_REG_CMDCTRL_OPCODE_MASK           0xFF
-
-#define        CQSPI_REG_INDIRECTWR                    0x70
-#define        CQSPI_REG_INDIRECTWR_START              BIT(0)
-#define        CQSPI_REG_INDIRECTWR_CANCEL             BIT(1)
-#define        CQSPI_REG_INDIRECTWR_INPROGRESS         BIT(2)
-#define        CQSPI_REG_INDIRECTWR_DONE               BIT(5)
-
-#define        CQSPI_REG_INDIRECTWRWATERMARK           0x74
-#define        CQSPI_REG_INDIRECTWRSTARTADDR           0x78
-#define        CQSPI_REG_INDIRECTWRBYTES               0x7C
-
-#define        CQSPI_REG_CMDADDRESS                    0x94
-#define        CQSPI_REG_CMDREADDATALOWER              0xA0
-#define        CQSPI_REG_CMDREADDATAUPPER              0xA4
-#define        CQSPI_REG_CMDWRITEDATALOWER             0xA8
-#define        CQSPI_REG_CMDWRITEDATAUPPER             0xAC
-
-#define CQSPI_REG_IS_IDLE(base)                                        \
-       ((readl(base + CQSPI_REG_CONFIG) >>             \
-               CQSPI_REG_CONFIG_IDLE_LSB) & 0x1)
-
-#define CQSPI_GET_RD_SRAM_LEVEL(reg_base)                      \
-       (((readl(reg_base + CQSPI_REG_SDRAMLEVEL)) >>   \
-       CQSPI_REG_SDRAMLEVEL_RD_LSB) & CQSPI_REG_SDRAMLEVEL_RD_MASK)
-
-#define CQSPI_GET_WR_SRAM_LEVEL(reg_base)                      \
-       (((readl(reg_base + CQSPI_REG_SDRAMLEVEL)) >>   \
-       CQSPI_REG_SDRAMLEVEL_WR_LSB) & CQSPI_REG_SDRAMLEVEL_WR_MASK)
-
-static unsigned int cadence_qspi_apb_cmd2addr(const unsigned char *addr_buf,
-       unsigned int addr_width)
+__weak void cadence_qspi_apb_enable_linear_mode(bool enable)
 {
-       unsigned int addr;
-
-       addr = (addr_buf[0] << 16) | (addr_buf[1] << 8) | addr_buf[2];
-
-       if (addr_width == 4)
-               addr = (addr << 8) | addr_buf[3];
-
-       return addr;
+       return;
 }
 
 void cadence_qspi_apb_controller_enable(void *reg_base)
@@ -201,6 +59,87 @@ void cadence_qspi_apb_controller_disable(void *reg_base)
        writel(reg, reg_base + CQSPI_REG_CONFIG);
 }
 
+void cadence_qspi_apb_dac_mode_enable(void *reg_base)
+{
+       unsigned int reg;
+
+       reg = readl(reg_base + CQSPI_REG_CONFIG);
+       reg |= CQSPI_REG_CONFIG_DIRECT;
+       writel(reg, reg_base + CQSPI_REG_CONFIG);
+}
+
+static unsigned int cadence_qspi_calc_dummy(const struct spi_mem_op *op,
+                                           bool dtr)
+{
+       unsigned int dummy_clk;
+
+       if (!op->dummy.nbytes || !op->dummy.buswidth)
+               return 0;
+
+       dummy_clk = op->dummy.nbytes * (8 / op->dummy.buswidth);
+       if (dtr)
+               dummy_clk /= 2;
+
+       return dummy_clk;
+}
+
+static u32 cadence_qspi_calc_rdreg(struct cadence_spi_priv *priv)
+{
+       u32 rdreg = 0;
+
+       rdreg |= priv->inst_width << CQSPI_REG_RD_INSTR_TYPE_INSTR_LSB;
+       rdreg |= priv->addr_width << CQSPI_REG_RD_INSTR_TYPE_ADDR_LSB;
+       rdreg |= priv->data_width << CQSPI_REG_RD_INSTR_TYPE_DATA_LSB;
+
+       return rdreg;
+}
+
+static int cadence_qspi_buswidth_to_inst_type(u8 buswidth)
+{
+       switch (buswidth) {
+       case 0:
+       case 1:
+               return CQSPI_INST_TYPE_SINGLE;
+
+       case 2:
+               return CQSPI_INST_TYPE_DUAL;
+
+       case 4:
+               return CQSPI_INST_TYPE_QUAD;
+
+       case 8:
+               return CQSPI_INST_TYPE_OCTAL;
+
+       default:
+               return -ENOTSUPP;
+       }
+}
+
+static int cadence_qspi_set_protocol(struct cadence_spi_priv *priv,
+                                    const struct spi_mem_op *op)
+{
+       int ret;
+
+       priv->dtr = op->data.dtr && op->cmd.dtr && op->addr.dtr;
+
+       ret = cadence_qspi_buswidth_to_inst_type(op->cmd.buswidth);
+       if (ret < 0)
+               return ret;
+       priv->inst_width = ret;
+
+       ret = cadence_qspi_buswidth_to_inst_type(op->addr.buswidth);
+       if (ret < 0)
+               return ret;
+       priv->addr_width = ret;
+
+       ret = cadence_qspi_buswidth_to_inst_type(op->data.buswidth);
+       if (ret < 0)
+               return ret;
+       priv->data_width = ret;
+
+       return 0;
+}
+
 /* Return 1 if idle, otherwise return 0 (busy). */
 static unsigned int cadence_qspi_wait_idle(void *reg_base)
 {
@@ -375,35 +314,34 @@ void cadence_qspi_apb_delay(void *reg_base,
        cadence_qspi_apb_controller_enable(reg_base);
 }
 
-void cadence_qspi_apb_controller_init(struct cadence_spi_platdata *plat)
+void cadence_qspi_apb_controller_init(struct cadence_spi_priv *priv)
 {
        unsigned reg;
 
-       cadence_qspi_apb_controller_disable(plat->regbase);
+       cadence_qspi_apb_controller_disable(priv->regbase);
 
        /* Configure the device size and address bytes */
-       reg = readl(plat->regbase + CQSPI_REG_SIZE);
+       reg = readl(priv->regbase + CQSPI_REG_SIZE);
        /* Clear the previous value */
        reg &= ~(CQSPI_REG_SIZE_PAGE_MASK << CQSPI_REG_SIZE_PAGE_LSB);
        reg &= ~(CQSPI_REG_SIZE_BLOCK_MASK << CQSPI_REG_SIZE_BLOCK_LSB);
-       reg |= (plat->page_size << CQSPI_REG_SIZE_PAGE_LSB);
-       reg |= (plat->block_size << CQSPI_REG_SIZE_BLOCK_LSB);
-       writel(reg, plat->regbase + CQSPI_REG_SIZE);
+       reg |= (priv->page_size << CQSPI_REG_SIZE_PAGE_LSB);
+       reg |= (priv->block_size << CQSPI_REG_SIZE_BLOCK_LSB);
+       writel(reg, priv->regbase + CQSPI_REG_SIZE);
 
        /* Configure the remap address register, no remap */
-       writel(0, plat->regbase + CQSPI_REG_REMAP);
+       writel(0, priv->regbase + CQSPI_REG_REMAP);
 
        /* Indirect mode configurations */
-       writel(plat->fifo_depth / 2, plat->regbase + CQSPI_REG_SRAMPARTITION);
+       writel(priv->fifo_depth / 2, priv->regbase + CQSPI_REG_SRAMPARTITION);
 
        /* Disable all interrupts */
-       writel(0, plat->regbase + CQSPI_REG_IRQMASK);
+       writel(0, priv->regbase + CQSPI_REG_IRQMASK);
 
-       cadence_qspi_apb_controller_enable(plat->regbase);
+       cadence_qspi_apb_controller_enable(priv->regbase);
 }
 
-static int cadence_qspi_apb_exec_flash_cmd(void *reg_base,
-       unsigned int reg)
+int cadence_qspi_apb_exec_flash_cmd(void *reg_base, unsigned int reg)
 {
        unsigned int retry = CQSPI_REG_RETRY;
 
@@ -432,22 +370,109 @@ static int cadence_qspi_apb_exec_flash_cmd(void *reg_base,
        return 0;
 }
 
+static int cadence_qspi_setup_opcode_ext(struct cadence_spi_priv *priv,
+                                        const struct spi_mem_op *op,
+                                        unsigned int shift)
+{
+       unsigned int reg;
+       u8 ext;
+
+       if (op->cmd.nbytes != 2)
+               return -EINVAL;
+
+       /* Opcode extension is the LSB. */
+       ext = op->cmd.opcode & 0xff;
+
+       reg = readl(priv->regbase + CQSPI_REG_OP_EXT_LOWER);
+       reg &= ~(0xff << shift);
+       reg |= ext << shift;
+       writel(reg, priv->regbase + CQSPI_REG_OP_EXT_LOWER);
+
+       return 0;
+}
+
+static int cadence_qspi_enable_dtr(struct cadence_spi_priv *priv,
+                                  const struct spi_mem_op *op,
+                                  unsigned int shift,
+                                  bool enable)
+{
+       unsigned int reg;
+       int ret;
+
+       reg = readl(priv->regbase + CQSPI_REG_CONFIG);
+
+       if (enable) {
+               reg |= CQSPI_REG_CONFIG_DTR_PROTO;
+               reg |= CQSPI_REG_CONFIG_DUAL_OPCODE;
+
+               /* Set up command opcode extension. */
+               ret = cadence_qspi_setup_opcode_ext(priv, op, shift);
+               if (ret)
+                       return ret;
+       } else {
+               reg &= ~CQSPI_REG_CONFIG_DTR_PROTO;
+               reg &= ~CQSPI_REG_CONFIG_DUAL_OPCODE;
+       }
+
+       writel(reg, priv->regbase + CQSPI_REG_CONFIG);
+
+       return 0;
+}
+
+int cadence_qspi_apb_command_read_setup(struct cadence_spi_priv *priv,
+                                       const struct spi_mem_op *op)
+{
+       int ret;
+       unsigned int reg;
+
+       ret = cadence_qspi_set_protocol(priv, op);
+       if (ret)
+               return ret;
+
+       ret = cadence_qspi_enable_dtr(priv, op, CQSPI_REG_OP_EXT_STIG_LSB,
+                                     priv->dtr);
+       if (ret)
+               return ret;
+
+       reg = cadence_qspi_calc_rdreg(priv);
+       writel(reg, priv->regbase + CQSPI_REG_RD_INSTR);
+
+       return 0;
+}
+
 /* For command RDID, RDSR. */
-int cadence_qspi_apb_command_read(void *reg_base,
-       unsigned int cmdlen, const u8 *cmdbuf, unsigned int rxlen,
-       u8 *rxbuf)
+int cadence_qspi_apb_command_read(struct cadence_spi_priv *priv,
+                                 const struct spi_mem_op *op)
 {
+       void *reg_base = priv->regbase;
        unsigned int reg;
        unsigned int read_len;
        int status;
+       unsigned int rxlen = op->data.nbytes;
+       void *rxbuf = op->data.buf.in;
+       unsigned int dummy_clk;
+       u8 opcode;
 
-       if (!cmdlen || rxlen > CQSPI_STIG_DATA_LEN_MAX || rxbuf == NULL) {
-               printf("QSPI: Invalid input arguments cmdlen %d rxlen %d\n",
-                      cmdlen, rxlen);
+       if (rxlen > CQSPI_STIG_DATA_LEN_MAX || !rxbuf) {
+               printf("QSPI: Invalid input arguments rxlen %u\n", rxlen);
                return -EINVAL;
        }
 
-       reg = cmdbuf[0] << CQSPI_REG_CMDCTRL_OPCODE_LSB;
+       if (priv->dtr)
+               opcode = op->cmd.opcode >> 8;
+       else
+               opcode = op->cmd.opcode;
+
+       reg = opcode << CQSPI_REG_CMDCTRL_OPCODE_LSB;
+
+       /* Set up dummy cycles. */
+       dummy_clk = cadence_qspi_calc_dummy(op, priv->dtr);
+       if (dummy_clk > CQSPI_DUMMY_CLKS_MAX)
+               return -ENOTSUPP;
+
+       if (dummy_clk)
+               reg |= (dummy_clk & CQSPI_REG_CMDCTRL_DUMMY_MASK)
+                    << CQSPI_REG_CMDCTRL_DUMMY_LSB;
 
        reg |= (0x1 << CQSPI_REG_CMDCTRL_RD_EN_LSB);
 
@@ -474,35 +499,60 @@ int cadence_qspi_apb_command_read(void *reg_base,
        return 0;
 }
 
+int cadence_qspi_apb_command_write_setup(struct cadence_spi_priv *priv,
+                                        const struct spi_mem_op *op)
+{
+       int ret;
+       unsigned int reg;
+
+       ret = cadence_qspi_set_protocol(priv, op);
+       if (ret)
+               return ret;
+
+       ret = cadence_qspi_enable_dtr(priv, op, CQSPI_REG_OP_EXT_STIG_LSB,
+                                     priv->dtr);
+       if (ret)
+               return ret;
+
+       reg = cadence_qspi_calc_rdreg(priv);
+       writel(reg, priv->regbase + CQSPI_REG_RD_INSTR);
+
+       return 0;
+}
+
 /* For commands: WRSR, WREN, WRDI, CHIP_ERASE, BE, etc. */
-int cadence_qspi_apb_command_write(void *reg_base, unsigned int cmdlen,
-       const u8 *cmdbuf, unsigned int txlen,  const u8 *txbuf)
+int cadence_qspi_apb_command_write(struct cadence_spi_priv *priv,
+                                  const struct spi_mem_op *op)
 {
        unsigned int reg = 0;
-       unsigned int addr_value;
        unsigned int wr_data;
        unsigned int wr_len;
+       unsigned int txlen = op->data.nbytes;
+       const void *txbuf = op->data.buf.out;
+       void *reg_base = priv->regbase;
+       u32 addr;
+       u8 opcode;
+
+       /* Reorder address to SPI bus order if only transferring address */
+       if (!txlen) {
+               addr = cpu_to_be32(op->addr.val);
+               if (op->addr.nbytes == 3)
+                       addr >>= 8;
+               txbuf = &addr;
+               txlen = op->addr.nbytes;
+       }
 
-       if (!cmdlen || cmdlen > 5 || txlen > 8 || cmdbuf == NULL) {
-               printf("QSPI: Invalid input arguments cmdlen %d txlen %d\n",
-                      cmdlen, txlen);
+       if (txlen > CQSPI_STIG_DATA_LEN_MAX) {
+               printf("QSPI: Invalid input arguments txlen %u\n", txlen);
                return -EINVAL;
        }
 
-       reg |= cmdbuf[0] << CQSPI_REG_CMDCTRL_OPCODE_LSB;
+       if (priv->dtr)
+               opcode = op->cmd.opcode >> 8;
+       else
+               opcode = op->cmd.opcode;
 
-       if (cmdlen == 4 || cmdlen == 5) {
-               /* Command with address */
-               reg |= (0x1 << CQSPI_REG_CMDCTRL_ADDR_EN_LSB);
-               /* Number of bytes to write. */
-               reg |= ((cmdlen - 2) & CQSPI_REG_CMDCTRL_ADD_BYTES_MASK)
-                       << CQSPI_REG_CMDCTRL_ADD_BYTES_LSB;
-               /* Get address */
-               addr_value = cadence_qspi_apb_cmd2addr(&cmdbuf[1],
-                       cmdlen >= 5 ? 4 : 3);
-
-               writel(addr_value, reg_base + CQSPI_REG_CMDADDRESS);
-       }
+       reg |= opcode << CQSPI_REG_CMDCTRL_OPCODE_LSB;
 
        if (txlen) {
                /* writing data = yes */
@@ -529,92 +579,76 @@ int cadence_qspi_apb_command_write(void *reg_base, unsigned int cmdlen,
 }
 
 /* Opcode + Address (3/4 bytes) + dummy bytes (0-4 bytes) */
-int cadence_qspi_apb_indirect_read_setup(struct cadence_spi_platdata *plat,
-       unsigned int cmdlen, unsigned int rx_width, const u8 *cmdbuf)
+int cadence_qspi_apb_read_setup(struct cadence_spi_priv *priv,
+                               const struct spi_mem_op *op)
 {
        unsigned int reg;
        unsigned int rd_reg;
-       unsigned int addr_value;
        unsigned int dummy_clk;
-       unsigned int dummy_bytes;
-       unsigned int addr_bytes;
+       unsigned int dummy_bytes = op->dummy.nbytes;
+       int ret;
+       u8 opcode;
 
-       /*
-        * Identify addr_byte. All NOR flash device drivers are using fast read
-        * which always expecting 1 dummy byte, 1 cmd byte and 3/4 addr byte.
-        * With that, the length is in value of 5 or 6. Only FRAM chip from
-        * ramtron using normal read (which won't need dummy byte).
-        * Unlikely NOR flash using normal read due to performance issue.
-        */
-       if (cmdlen >= 5)
-               /* to cater fast read where cmd + addr + dummy */
-               addr_bytes = cmdlen - 2;
-       else
-               /* for normal read (only ramtron as of now) */
-               addr_bytes = cmdlen - 1;
+       ret = cadence_qspi_set_protocol(priv, op);
+       if (ret)
+               return ret;
+
+       ret = cadence_qspi_enable_dtr(priv, op, CQSPI_REG_OP_EXT_READ_LSB,
+                                     priv->dtr);
+       if (ret)
+               return ret;
 
        /* Setup the indirect trigger address */
-       writel(plat->trigger_address,
-              plat->regbase + CQSPI_REG_INDIRECTTRIGGER);
+       writel(priv->trigger_address,
+              priv->regbase + CQSPI_REG_INDIRECTTRIGGER);
 
        /* Configure the opcode */
-       rd_reg = cmdbuf[0] << CQSPI_REG_RD_INSTR_OPCODE_LSB;
+       if (priv->dtr)
+               opcode = op->cmd.opcode >> 8;
+       else
+               opcode = op->cmd.opcode;
 
-       if (rx_width & SPI_RX_QUAD)
-               /* Instruction and address at DQ0, data at DQ0-3. */
-               rd_reg |= CQSPI_INST_TYPE_QUAD << CQSPI_REG_RD_INSTR_TYPE_DATA_LSB;
+       rd_reg = opcode << CQSPI_REG_RD_INSTR_OPCODE_LSB;
+       rd_reg |= cadence_qspi_calc_rdreg(priv);
 
-       /* Get address */
-       addr_value = cadence_qspi_apb_cmd2addr(&cmdbuf[1], addr_bytes);
-       writel(addr_value, plat->regbase + CQSPI_REG_INDIRECTRDSTARTADDR);
+       writel(op->addr.val, priv->regbase + CQSPI_REG_INDIRECTRDSTARTADDR);
 
-       /* The remaining lenght is dummy bytes. */
-       dummy_bytes = cmdlen - addr_bytes - 1;
        if (dummy_bytes) {
-               if (dummy_bytes > CQSPI_DUMMY_BYTES_MAX)
-                       dummy_bytes = CQSPI_DUMMY_BYTES_MAX;
-
-               rd_reg |= (1 << CQSPI_REG_RD_INSTR_MODE_EN_LSB);
-#if defined(CONFIG_SPL_SPI_XIP) && defined(CONFIG_SPL_BUILD)
-               writel(0x0, plat->regbase + CQSPI_REG_MODE_BIT);
-#else
-               writel(0xFF, plat->regbase + CQSPI_REG_MODE_BIT);
-#endif
-
                /* Convert to clock cycles. */
-               dummy_clk = dummy_bytes * CQSPI_DUMMY_CLKS_PER_BYTE;
-               /* Need to minus the mode byte (8 clocks). */
-               dummy_clk -= CQSPI_DUMMY_CLKS_PER_BYTE;
+               dummy_clk = cadence_qspi_calc_dummy(op, priv->dtr);
+
+               if (dummy_clk > CQSPI_DUMMY_CLKS_MAX)
+                       return -ENOTSUPP;
 
                if (dummy_clk)
                        rd_reg |= (dummy_clk & CQSPI_REG_RD_INSTR_DUMMY_MASK)
                                << CQSPI_REG_RD_INSTR_DUMMY_LSB;
        }
 
-       writel(rd_reg, plat->regbase + CQSPI_REG_RD_INSTR);
+       writel(rd_reg, priv->regbase + CQSPI_REG_RD_INSTR);
 
        /* set device size */
-       reg = readl(plat->regbase + CQSPI_REG_SIZE);
+       reg = readl(priv->regbase + CQSPI_REG_SIZE);
        reg &= ~CQSPI_REG_SIZE_ADDRESS_MASK;
-       reg |= (addr_bytes - 1);
-       writel(reg, plat->regbase + CQSPI_REG_SIZE);
+       reg |= (op->addr.nbytes - 1);
+       writel(reg, priv->regbase + CQSPI_REG_SIZE);
        return 0;
 }
 
-static u32 cadence_qspi_get_rd_sram_level(struct cadence_spi_platdata *plat)
+static u32 cadence_qspi_get_rd_sram_level(struct cadence_spi_priv *priv)
 {
-       u32 reg = readl(plat->regbase + CQSPI_REG_SDRAMLEVEL);
+       u32 reg = readl(priv->regbase + CQSPI_REG_SDRAMLEVEL);
        reg >>= CQSPI_REG_SDRAMLEVEL_RD_LSB;
        return reg & CQSPI_REG_SDRAMLEVEL_RD_MASK;
 }
 
-static int cadence_qspi_wait_for_data(struct cadence_spi_platdata *plat)
+static int cadence_qspi_wait_for_data(struct cadence_spi_priv *priv)
 {
        unsigned int timeout = 10000;
        u32 reg;
 
        while (timeout--) {
-               reg = cadence_qspi_get_rd_sram_level(plat);
+               reg = cadence_qspi_get_rd_sram_level(priv);
                if (reg)
                        return reg;
                udelay(1);
@@ -623,21 +657,22 @@ static int cadence_qspi_wait_for_data(struct cadence_spi_platdata *plat)
        return -ETIMEDOUT;
 }
 
-int cadence_qspi_apb_indirect_read_execute(struct cadence_spi_platdata *plat,
-       unsigned int n_rx, u8 *rxbuf)
+static int
+cadence_qspi_apb_indirect_read_execute(struct cadence_spi_priv *priv,
+                                      unsigned int n_rx, u8 *rxbuf)
 {
        unsigned int remaining = n_rx;
        unsigned int bytes_to_read = 0;
        int ret;
 
-       writel(n_rx, plat->regbase + CQSPI_REG_INDIRECTRDBYTES);
+       writel(n_rx, priv->regbase + CQSPI_REG_INDIRECTRDBYTES);
 
        /* Start the indirect read transfer */
        writel(CQSPI_REG_INDIRECTRD_START,
-              plat->regbase + CQSPI_REG_INDIRECTRD);
+              priv->regbase + CQSPI_REG_INDIRECTRD);
 
        while (remaining > 0) {
-               ret = cadence_qspi_wait_for_data(plat);
+               ret = cadence_qspi_wait_for_data(priv);
                if (ret < 0) {
                        printf("Indirect write timed out (%i)\n", ret);
                        goto failrd;
@@ -646,7 +681,7 @@ int cadence_qspi_apb_indirect_read_execute(struct cadence_spi_platdata *plat,
                bytes_to_read = ret;
 
                while (bytes_to_read != 0) {
-                       bytes_to_read *= plat->fifo_width;
+                       bytes_to_read *= priv->fifo_width;
                        bytes_to_read = bytes_to_read > remaining ?
                                        remaining : bytes_to_read;
                        /*
@@ -654,18 +689,18 @@ int cadence_qspi_apb_indirect_read_execute(struct cadence_spi_platdata *plat,
                         * data abort.
                         */
                        if (((uintptr_t)rxbuf % 4) || (bytes_to_read % 4))
-                               readsb(plat->ahbbase, rxbuf, bytes_to_read);
+                               readsb(priv->ahbbase, rxbuf, bytes_to_read);
                        else
-                               readsl(plat->ahbbase, rxbuf,
+                               readsl(priv->ahbbase, rxbuf,
                                       bytes_to_read >> 2);
                        rxbuf += bytes_to_read;
                        remaining -= bytes_to_read;
-                       bytes_to_read = cadence_qspi_get_rd_sram_level(plat);
+                       bytes_to_read = cadence_qspi_get_rd_sram_level(priv);
                }
        }
 
        /* Check indirect done status */
-       ret = wait_for_bit_le32(plat->regbase + CQSPI_REG_INDIRECTRD,
+       ret = wait_for_bit_le32(priv->regbase + CQSPI_REG_INDIRECTRD,
                                CQSPI_REG_INDIRECTRD_DONE, 1, 10, 0);
        if (ret) {
                printf("Indirect read completion error (%i)\n", ret);
@@ -674,56 +709,110 @@ int cadence_qspi_apb_indirect_read_execute(struct cadence_spi_platdata *plat,
 
        /* Clear indirect completion status */
        writel(CQSPI_REG_INDIRECTRD_DONE,
-              plat->regbase + CQSPI_REG_INDIRECTRD);
+              priv->regbase + CQSPI_REG_INDIRECTRD);
+
+       /* Check indirect done status */
+       ret = wait_for_bit_le32(priv->regbase + CQSPI_REG_INDIRECTRD,
+                               CQSPI_REG_INDIRECTRD_DONE, 0, 10, 0);
+       if (ret) {
+               printf("Indirect read clear completion error (%i)\n", ret);
+               goto failrd;
+       }
 
        return 0;
 
 failrd:
        /* Cancel the indirect read */
        writel(CQSPI_REG_INDIRECTRD_CANCEL,
-              plat->regbase + CQSPI_REG_INDIRECTRD);
+              priv->regbase + CQSPI_REG_INDIRECTRD);
        return ret;
 }
 
+int cadence_qspi_apb_read_execute(struct cadence_spi_priv *priv,
+                                 const struct spi_mem_op *op)
+{
+       u64 from = op->addr.val;
+       void *buf = op->data.buf.in;
+       size_t len = op->data.nbytes;
+
+       cadence_qspi_apb_enable_linear_mode(true);
+
+       if (priv->use_dac_mode && (from + len < priv->ahbsize)) {
+               if (len < 256 ||
+                   dma_memcpy(buf, priv->ahbbase + from, len) < 0) {
+                       memcpy_fromio(buf, priv->ahbbase + from, len);
+               }
+               if (!cadence_qspi_wait_idle(priv->regbase))
+                       return -EIO;
+               return 0;
+       }
+
+       return cadence_qspi_apb_indirect_read_execute(priv, len, buf);
+}
+
 /* Opcode + Address (3/4 bytes) */
-int cadence_qspi_apb_indirect_write_setup(struct cadence_spi_platdata *plat,
-       unsigned int cmdlen, unsigned int tx_width, const u8 *cmdbuf)
+int cadence_qspi_apb_write_setup(struct cadence_spi_priv *priv,
+                                const struct spi_mem_op *op)
 {
        unsigned int reg;
-       unsigned int addr_bytes = cmdlen > 4 ? 4 : 3;
+       int ret;
+       u8 opcode;
+
+       ret = cadence_qspi_set_protocol(priv, op);
+       if (ret)
+               return ret;
+
+       ret = cadence_qspi_enable_dtr(priv, op, CQSPI_REG_OP_EXT_WRITE_LSB,
+                                     priv->dtr);
+       if (ret)
+               return ret;
 
-       if (cmdlen < 4 || cmdbuf == NULL) {
-               printf("QSPI: Invalid input argument, len %d cmdbuf %p\n",
-                      cmdlen, cmdbuf);
-               return -EINVAL;
-       }
        /* Setup the indirect trigger address */
-       writel(plat->trigger_address,
-              plat->regbase + CQSPI_REG_INDIRECTTRIGGER);
+       writel(priv->trigger_address,
+              priv->regbase + CQSPI_REG_INDIRECTTRIGGER);
 
        /* Configure the opcode */
-       reg = cmdbuf[0] << CQSPI_REG_WR_INSTR_OPCODE_LSB;
+       if (priv->dtr)
+               opcode = op->cmd.opcode >> 8;
+       else
+               opcode = op->cmd.opcode;
 
-       if (tx_width & SPI_TX_QUAD)
-               reg |= CQSPI_INST_TYPE_QUAD << CQSPI_REG_WR_INSTR_TYPE_DATA_LSB;
+       reg = opcode << CQSPI_REG_WR_INSTR_OPCODE_LSB;
+       reg |= priv->data_width << CQSPI_REG_WR_INSTR_TYPE_DATA_LSB;
+       reg |= priv->addr_width << CQSPI_REG_WR_INSTR_TYPE_ADDR_LSB;
+       writel(reg, priv->regbase + CQSPI_REG_WR_INSTR);
 
-       writel(reg, plat->regbase + CQSPI_REG_WR_INSTR);
+       reg = cadence_qspi_calc_rdreg(priv);
+       writel(reg, priv->regbase + CQSPI_REG_RD_INSTR);
 
-       /* Setup write address. */
-       reg = cadence_qspi_apb_cmd2addr(&cmdbuf[1], addr_bytes);
-       writel(reg, plat->regbase + CQSPI_REG_INDIRECTWRSTARTADDR);
+       writel(op->addr.val, priv->regbase + CQSPI_REG_INDIRECTWRSTARTADDR);
+
+       if (priv->dtr) {
+               /*
+                * Some flashes like the cypress Semper flash expect a 4-byte
+                * dummy address with the Read SR command in DTR mode, but this
+                * controller does not support sending address with the Read SR
+                * command. So, disable write completion polling on the
+                * controller's side. spi-nor will take care of polling the
+                * status register.
+                */
+               reg = readl(priv->regbase + CQSPI_REG_WR_COMPLETION_CTRL);
+               reg |= CQSPI_REG_WR_DISABLE_AUTO_POLL;
+               writel(reg, priv->regbase + CQSPI_REG_WR_COMPLETION_CTRL);
+       }
 
-       reg = readl(plat->regbase + CQSPI_REG_SIZE);
+       reg = readl(priv->regbase + CQSPI_REG_SIZE);
        reg &= ~CQSPI_REG_SIZE_ADDRESS_MASK;
-       reg |= (addr_bytes - 1);
-       writel(reg, plat->regbase + CQSPI_REG_SIZE);
+       reg |= (op->addr.nbytes - 1);
+       writel(reg, priv->regbase + CQSPI_REG_SIZE);
        return 0;
 }
 
-int cadence_qspi_apb_indirect_write_execute(struct cadence_spi_platdata *plat,
-       unsigned int n_tx, const u8 *txbuf)
+static int
+cadence_qspi_apb_indirect_write_execute(struct cadence_spi_priv *priv,
+                                       unsigned int n_tx, const u8 *txbuf)
 {
-       unsigned int page_size = plat->page_size;
+       unsigned int page_size = priv->page_size;
        unsigned int remaining = n_tx;
        const u8 *bb_txbuf = txbuf;
        void *bounce_buf = NULL;
@@ -743,21 +832,27 @@ int cadence_qspi_apb_indirect_write_execute(struct cadence_spi_platdata *plat,
        }
 
        /* Configure the indirect read transfer bytes */
-       writel(n_tx, plat->regbase + CQSPI_REG_INDIRECTWRBYTES);
+       writel(n_tx, priv->regbase + CQSPI_REG_INDIRECTWRBYTES);
 
        /* Start the indirect write transfer */
        writel(CQSPI_REG_INDIRECTWR_START,
-              plat->regbase + CQSPI_REG_INDIRECTWR);
+              priv->regbase + CQSPI_REG_INDIRECTWR);
+
+       /*
+        * Some delay is required for the above bit to be internally
+        * synchronized by the QSPI module.
+        */
+       ndelay(priv->wr_delay);
 
        while (remaining > 0) {
                write_bytes = remaining > page_size ? page_size : remaining;
-               writesl(plat->ahbbase, bb_txbuf, write_bytes >> 2);
+               writesl(priv->ahbbase, bb_txbuf, write_bytes >> 2);
                if (write_bytes % 4)
-                       writesb(plat->ahbbase,
+                       writesb(priv->ahbbase,
                                bb_txbuf + rounddown(write_bytes, 4),
                                write_bytes % 4);
 
-               ret = wait_for_bit_le32(plat->regbase + CQSPI_REG_SDRAMLEVEL,
+               ret = wait_for_bit_le32(priv->regbase + CQSPI_REG_SDRAMLEVEL,
                                        CQSPI_REG_SDRAMLEVEL_WR_MASK <<
                                        CQSPI_REG_SDRAMLEVEL_WR_LSB, 0, 10, 0);
                if (ret) {
@@ -770,7 +865,7 @@ int cadence_qspi_apb_indirect_write_execute(struct cadence_spi_platdata *plat,
        }
 
        /* Check indirect done status */
-       ret = wait_for_bit_le32(plat->regbase + CQSPI_REG_INDIRECTWR,
+       ret = wait_for_bit_le32(priv->regbase + CQSPI_REG_INDIRECTWR,
                                CQSPI_REG_INDIRECTWR_DONE, 1, 10, 0);
        if (ret) {
                printf("Indirect write completion error (%i)\n", ret);
@@ -779,7 +874,16 @@ int cadence_qspi_apb_indirect_write_execute(struct cadence_spi_platdata *plat,
 
        /* Clear indirect completion status */
        writel(CQSPI_REG_INDIRECTWR_DONE,
-              plat->regbase + CQSPI_REG_INDIRECTWR);
+              priv->regbase + CQSPI_REG_INDIRECTWR);
+
+       /* Check indirect done status */
+       ret = wait_for_bit_le32(priv->regbase + CQSPI_REG_INDIRECTWR,
+                               CQSPI_REG_INDIRECTWR_DONE, 0, 10, 0);
+       if (ret) {
+               printf("Indirect write clear completion error (%i)\n", ret);
+               goto failwr;
+       }
+
        if (bounce_buf)
                free(bounce_buf);
        return 0;
@@ -787,12 +891,38 @@ int cadence_qspi_apb_indirect_write_execute(struct cadence_spi_platdata *plat,
 failwr:
        /* Cancel the indirect write */
        writel(CQSPI_REG_INDIRECTWR_CANCEL,
-              plat->regbase + CQSPI_REG_INDIRECTWR);
+              priv->regbase + CQSPI_REG_INDIRECTWR);
        if (bounce_buf)
                free(bounce_buf);
        return ret;
 }
 
+int cadence_qspi_apb_write_execute(struct cadence_spi_priv *priv,
+                                  const struct spi_mem_op *op)
+{
+       u32 to = op->addr.val;
+       const void *buf = op->data.buf.out;
+       size_t len = op->data.nbytes;
+
+       /*
+        * Some flashes like the Cypress Semper flash expect a dummy 4-byte
+        * address (all 0s) with the read status register command in DTR mode.
+        * But this controller does not support sending dummy address bytes to
+        * the flash when it is polling the write completion register in DTR
+        * mode. So, we can not use direct mode when in DTR mode for writing
+        * data.
+        */
+       cadence_qspi_apb_enable_linear_mode(true);
+       if (!priv->dtr && priv->use_dac_mode && (to + len < priv->ahbsize)) {
+               memcpy_toio(priv->ahbbase + to, buf, len);
+               if (!cadence_qspi_wait_idle(priv->regbase))
+                       return -EIO;
+               return 0;
+       }
+
+       return cadence_qspi_apb_indirect_write_execute(priv, len, buf);
+}
+
 void cadence_qspi_apb_enter_xip(void *reg_base, char xip_dummy)
 {
        unsigned int reg;