rapidio: fix possible UAF when kfifo_alloc() fails

[platform/kernel/linux-starfive.git] / drivers / rapidio / devices / rio_mport_cdev.c

diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 3cc8399..fecf523 100644 (file)
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -1904,10 +1904,6 @@ static int mport_cdev_open(struct inode *inode, struct file *filp)
 
        priv->md = chdev;
 
-       mutex_lock(&chdev->file_mutex);
-       list_add_tail(&priv->list, &chdev->file_list);
-       mutex_unlock(&chdev->file_mutex);
-
        INIT_LIST_HEAD(&priv->db_filters);
        INIT_LIST_HEAD(&priv->pw_filters);
        spin_lock_init(&priv->fifo_lock);
@@ -1926,6 +1922,9 @@ static int mport_cdev_open(struct inode *inode, struct file *filp)
        spin_lock_init(&priv->req_lock);
        mutex_init(&priv->dma_lock);
 #endif
+       mutex_lock(&chdev->file_mutex);
+       list_add_tail(&priv->list, &chdev->file_list);
+       mutex_unlock(&chdev->file_mutex);
 
        filp->private_data = priv;
        goto out;