cfi_flash: Remove braces for single-statement blocks
[platform/kernel/u-boot.git] / drivers / mtd / cfi_flash.c
index e8f1739..e246905 100644 (file)
@@ -231,13 +231,13 @@ static void flash_make_cmd(flash_info_t *info, u32 cmd, void *cmdbuf)
        uchar *cp = (uchar *) cmdbuf;
 
        for (i = info->portwidth; i > 0; i--) {
-               cword_offset = (info->portwidth-i)%info->chipwidth;
+               cword_offset = (info->portwidth - i) % info->chipwidth;
 #if defined(__LITTLE_ENDIAN) || defined(CONFIG_SYS_WRITE_SWAPPED_DATA)
                cp_offset = info->portwidth - i;
-               val = *((uchar*)&cmd_le + cword_offset);
+               val = *((uchar *)&cmd_le + cword_offset);
 #else
                cp_offset = i - 1;
-               val = *((uchar*)&cmd + sizeof(u32) - cword_offset - 1);
+               val = *((uchar *)&cmd + sizeof(u32) - cword_offset - 1);
 #endif
                cp[cp_offset] = (cword_offset >= sizeof(u32)) ? 0x00 : val;
        }
@@ -252,7 +252,7 @@ static void print_longlong(char *str, unsigned long long data)
        int i;
        char *cp;
 
-       cp = (char *) &data;
+       cp = (char *)&data;
        for (i = 0; i < 8; i++)
                sprintf(&str[i * 2], "%2.2x", *cp++);
 }
@@ -269,6 +269,7 @@ static void flash_printqry(struct cfi_qry *qry)
                debug(" ");
                for (y = 0; y < 16; y++) {
                        unsigned char c = p[x + y];
+
                        if (c >= 0x20 && c <= 0x7e)
                                debug("%c", c);
                        else
@@ -279,7 +280,6 @@ static void flash_printqry(struct cfi_qry *qry)
 }
 #endif
 
-
 /*-----------------------------------------------------------------------
  * read a character at a port width address
  */
@@ -311,7 +311,6 @@ static inline ushort flash_read_word(flash_info_t *info, uint offset)
        return retval;
 }
 
-
 /*-----------------------------------------------------------------------
  * read a long word by picking the least significant byte of each maximum
  * port size word. Swap for ppc format.
@@ -330,9 +329,8 @@ static ulong flash_read_long (flash_info_t *info, flash_sect_t sect,
 #ifdef DEBUG
        debug("long addr is at %p info->portwidth = %d\n", addr,
               info->portwidth);
-       for (x = 0; x < 4 * info->portwidth; x++) {
+       for (x = 0; x < 4 * info->portwidth; x++)
                debug("addr[%x] = 0x%x\n", x, flash_read8(addr + x));
-       }
 #endif
 #if defined(__LITTLE_ENDIAN) || defined(CONFIG_SYS_WRITE_SWAPPED_DATA)
        retval = ((flash_read8(addr) << 16) |
@@ -356,7 +354,6 @@ static ulong flash_read_long (flash_info_t *info, flash_sect_t sect,
 static void flash_write_cmd(flash_info_t *info, flash_sect_t sect,
                            uint offset, u32 cmd)
 {
-
        void *addr;
        cfiword_t cword;
 
@@ -512,7 +509,7 @@ static int flash_toggle(flash_info_t *info, flash_sect_t sect,
                break;
        case FLASH_CFI_64BIT:
                retval = ((flash_read32(addr) != flash_read32(addr)) ||
-                          (flash_read32(addr+4) != flash_read32(addr+4)));
+                          (flash_read32(addr + 4) != flash_read32(addr + 4)));
                break;
        default:
                retval = 0;
@@ -1048,7 +1045,6 @@ out_unmap:
 }
 #endif /* CONFIG_SYS_FLASH_USE_BUFFER_WRITE */
 
-
 /*-----------------------------------------------------------------------
  */
 int flash_erase(flash_info_t *info, int s_first, int s_last)
@@ -1068,11 +1064,9 @@ int flash_erase(flash_info_t *info, int s_first, int s_last)
        }
 
        prot = 0;
-       for (sect = s_first; sect <= s_last; ++sect) {
-               if (info->protect[sect]) {
+       for (sect = s_first; sect <= s_last; ++sect)
+               if (info->protect[sect])
                        prot++;
-               }
-       }
        if (prot) {
                printf("- Warning: %d protected sectors will not be erased!\n",
                        prot);
@@ -1080,7 +1074,6 @@ int flash_erase(flash_info_t *info, int s_first, int s_last)
                putc('\n');
        }
 
-
        for (sect = s_first; sect <= s_last; sect++) {
                if (ctrlc()) {
                        printf("\n");
@@ -1154,6 +1147,7 @@ int flash_erase(flash_info_t *info, int s_first, int s_last)
                        if (use_flash_status_poll(info)) {
                                cfiword_t cword;
                                void *dest;
+
                                cword.w64 = 0xffffffffffffffffULL;
                                dest = flash_map(info, sect, 0);
                                st = flash_status_poll(info, &cword, dest,
@@ -1212,7 +1206,7 @@ void flash_print_info(flash_info_t *info)
        printf("%s flash (%d x %d)",
                info->name,
                (info->portwidth << 3), (info->chipwidth << 3));
-       if (info->size < 1024*1024)
+       if (info->size < 1024 * 1024)
                printf("  Size: %ld kB in %d Sectors\n",
                        info->size >> 10, info->sector_count);
        else
@@ -1220,29 +1214,29 @@ void flash_print_info(flash_info_t *info)
                        info->size >> 20, info->sector_count);
        printf("  ");
        switch (info->vendor) {
-               case CFI_CMDSET_INTEL_PROG_REGIONS:
-                       printf("Intel Prog Regions");
-                       break;
-               case CFI_CMDSET_INTEL_STANDARD:
-                       printf("Intel Standard");
-                       break;
-               case CFI_CMDSET_INTEL_EXTENDED:
-                       printf("Intel Extended");
-                       break;
-               case CFI_CMDSET_AMD_STANDARD:
-                       printf("AMD Standard");
-                       break;
-               case CFI_CMDSET_AMD_EXTENDED:
-                       printf("AMD Extended");
-                       break;
+       case CFI_CMDSET_INTEL_PROG_REGIONS:
+               printf("Intel Prog Regions");
+               break;
+       case CFI_CMDSET_INTEL_STANDARD:
+               printf("Intel Standard");
+               break;
+       case CFI_CMDSET_INTEL_EXTENDED:
+               printf("Intel Extended");
+               break;
+       case CFI_CMDSET_AMD_STANDARD:
+               printf("AMD Standard");
+               break;
+       case CFI_CMDSET_AMD_EXTENDED:
+               printf("AMD Extended");
+               break;
 #ifdef CONFIG_FLASH_CFI_LEGACY
-               case CFI_CMDSET_AMD_LEGACY:
-                       printf("AMD Legacy");
-                       break;
+       case CFI_CMDSET_AMD_LEGACY:
+               printf("AMD Legacy");
+               break;
 #endif
-               default:
-                       printf("Unknown (%d)", info->vendor);
-                       break;
+       default:
+               printf("Unknown (%d)", info->vendor);
+               break;
        }
        printf(" command set, Manufacturer ID: 0x%02X, Device ID: 0x",
                info->manufacturer_id);
@@ -1399,9 +1393,8 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt)
 #else
        while (cnt >= info->portwidth) {
                cword.w32 = 0;
-               for (i = 0; i < info->portwidth; i++) {
+               for (i = 0; i < info->portwidth; i++)
                        flash_add_byte(info, &cword, *src++);
-               }
                if ((rc = flash_write_cfiword(info, wp, cword)) != 0)
                        return rc;
                wp += info->portwidth;
@@ -1413,9 +1406,8 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt)
        }
 #endif /* CONFIG_SYS_FLASH_USE_BUFFER_WRITE */
 
-       if (cnt == 0) {
+       if (cnt == 0)
                return (0);
-       }
 
        /*
         * handle unaligned tail bytes
@@ -1480,94 +1472,93 @@ int flash_real_protect(flash_info_t *info, long sector, int prot)
        int retcode = 0;
 
        switch (info->vendor) {
-               case CFI_CMDSET_INTEL_PROG_REGIONS:
-               case CFI_CMDSET_INTEL_STANDARD:
-               case CFI_CMDSET_INTEL_EXTENDED:
-                       if (!cfi_protect_bugfix(info, sector, prot)) {
+       case CFI_CMDSET_INTEL_PROG_REGIONS:
+       case CFI_CMDSET_INTEL_STANDARD:
+       case CFI_CMDSET_INTEL_EXTENDED:
+               if (!cfi_protect_bugfix(info, sector, prot)) {
+                       flash_write_cmd(info, sector, 0,
+                                FLASH_CMD_CLEAR_STATUS);
+                       flash_write_cmd(info, sector, 0,
+                               FLASH_CMD_PROTECT);
+                       if (prot)
                                flash_write_cmd(info, sector, 0,
-                                        FLASH_CMD_CLEAR_STATUS);
+                                       FLASH_CMD_PROTECT_SET);
+                       else
                                flash_write_cmd(info, sector, 0,
-                                       FLASH_CMD_PROTECT);
-                               if (prot)
-                                       flash_write_cmd(info, sector, 0,
-                                               FLASH_CMD_PROTECT_SET);
-                               else
-                                       flash_write_cmd(info, sector, 0,
-                                               FLASH_CMD_PROTECT_CLEAR);
-
+                                       FLASH_CMD_PROTECT_CLEAR);
+               }
+               break;
+       case CFI_CMDSET_AMD_EXTENDED:
+       case CFI_CMDSET_AMD_STANDARD:
+               /* U-Boot only checks the first byte */
+               if (manufact_match(info, ATM_MANUFACT)) {
+                       if (prot) {
+                               flash_unlock_seq(info, 0);
+                               flash_write_cmd(info, 0,
+                                               info->addr_unlock1,
+                                               ATM_CMD_SOFTLOCK_START);
+                               flash_unlock_seq(info, 0);
+                               flash_write_cmd(info, sector, 0,
+                                               ATM_CMD_LOCK_SECT);
+                       } else {
+                               flash_write_cmd(info, 0,
+                                               info->addr_unlock1,
+                                               AMD_CMD_UNLOCK_START);
+                               if (info->device_id == ATM_ID_BV6416)
+                                       flash_write_cmd(info, sector,
+                                               0, ATM_CMD_UNLOCK_SECT);
                        }
-                       break;
-               case CFI_CMDSET_AMD_EXTENDED:
-               case CFI_CMDSET_AMD_STANDARD:
-                       /* U-Boot only checks the first byte */
-                       if (manufact_match(info, ATM_MANUFACT)) {
-                               if (prot) {
-                                       flash_unlock_seq(info, 0);
-                                       flash_write_cmd(info, 0,
-                                                       info->addr_unlock1,
-                                                       ATM_CMD_SOFTLOCK_START);
-                                       flash_unlock_seq(info, 0);
+               }
+               if (info->legacy_unlock) {
+                       int flag = disable_interrupts();
+                       int lock_flag;
+
+                       flash_unlock_seq(info, 0);
+                       flash_write_cmd(info, 0, info->addr_unlock1,
+                                       AMD_CMD_SET_PPB_ENTRY);
+                       lock_flag = flash_isset(info, sector, 0, 0x01);
+                       if (prot) {
+                               if (lock_flag) {
                                        flash_write_cmd(info, sector, 0,
-                                                       ATM_CMD_LOCK_SECT);
-                               } else {
-                                       flash_write_cmd(info, 0,
-                                                       info->addr_unlock1,
-                                                       AMD_CMD_UNLOCK_START);
-                                       if (info->device_id == ATM_ID_BV6416)
-                                               flash_write_cmd(info, sector,
-                                                       0, ATM_CMD_UNLOCK_SECT);
+                                               AMD_CMD_PPB_LOCK_BC1);
+                                       flash_write_cmd(info, sector, 0,
+                                               AMD_CMD_PPB_LOCK_BC2);
                                }
-                       }
-                       if (info->legacy_unlock) {
-                               int flag = disable_interrupts();
-                               int lock_flag;
-
-                               flash_unlock_seq(info, 0);
-                               flash_write_cmd(info, 0, info->addr_unlock1,
-                                               AMD_CMD_SET_PPB_ENTRY);
-                               lock_flag = flash_isset(info, sector, 0, 0x01);
-                               if (prot) {
-                                       if (lock_flag) {
-                                               flash_write_cmd(info, sector, 0,
-                                                       AMD_CMD_PPB_LOCK_BC1);
-                                               flash_write_cmd(info, sector, 0,
-                                                       AMD_CMD_PPB_LOCK_BC2);
-                                       }
-                                       debug("sector %ld %slocked\n", sector,
-                                               lock_flag ? "" : "already ");
-                               } else {
-                                       if (!lock_flag) {
-                                               debug("unlock %ld\n", sector);
-                                               flash_write_cmd(info, 0, 0,
-                                                       AMD_CMD_PPB_UNLOCK_BC1);
-                                               flash_write_cmd(info, 0, 0,
-                                                       AMD_CMD_PPB_UNLOCK_BC2);
-                                       }
-                                       debug("sector %ld %sunlocked\n", sector,
-                                               !lock_flag ? "" : "already ");
+                               debug("sector %ld %slocked\n", sector,
+                                       lock_flag ? "" : "already ");
+                       } else {
+                               if (!lock_flag) {
+                                       debug("unlock %ld\n", sector);
+                                       flash_write_cmd(info, 0, 0,
+                                               AMD_CMD_PPB_UNLOCK_BC1);
+                                       flash_write_cmd(info, 0, 0,
+                                               AMD_CMD_PPB_UNLOCK_BC2);
                                }
-                               if (flag)
-                                       enable_interrupts();
-
-                               if (flash_status_check(info, sector,
-                                               info->erase_blk_tout,
-                                               prot ? "protect" : "unprotect"))
-                                       printf("status check error\n");
-
-                               flash_write_cmd(info, 0, 0,
-                                               AMD_CMD_SET_PPB_EXIT_BC1);
-                               flash_write_cmd(info, 0, 0,
-                                               AMD_CMD_SET_PPB_EXIT_BC2);
+                               debug("sector %ld %sunlocked\n", sector,
+                                       !lock_flag ? "" : "already ");
                        }
-                       break;
+                       if (flag)
+                               enable_interrupts();
+
+                       if (flash_status_check(info, sector,
+                                       info->erase_blk_tout,
+                                       prot ? "protect" : "unprotect"))
+                               printf("status check error\n");
+
+                       flash_write_cmd(info, 0, 0,
+                                       AMD_CMD_SET_PPB_EXIT_BC1);
+                       flash_write_cmd(info, 0, 0,
+                                       AMD_CMD_SET_PPB_EXIT_BC2);
+               }
+               break;
 #ifdef CONFIG_FLASH_CFI_LEGACY
-               case CFI_CMDSET_AMD_LEGACY:
-                       flash_write_cmd(info, sector, 0, FLASH_CMD_CLEAR_STATUS);
-                       flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT);
-                       if (prot)
-                               flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_SET);
-                       else
-                               flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
+       case CFI_CMDSET_AMD_LEGACY:
+               flash_write_cmd(info, sector, 0, FLASH_CMD_CLEAR_STATUS);
+               flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT);
+               if (prot)
+                       flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_SET);
+               else
+                       flash_write_cmd(info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
 #endif
        };
 
@@ -1579,7 +1570,6 @@ int flash_real_protect(flash_info_t *info, long sector, int prot)
        if ((retcode =
             flash_full_status_check(info, sector, info->erase_blk_tout,
                                      prot ? "protect" : "unprotect")) == 0) {
-
                info->protect[sector] = prot;
 
                /*
@@ -1887,8 +1877,9 @@ static void __flash_cmd_reset(flash_info_t *info)
        udelay(1);
        flash_write_cmd(info, 0, 0, FLASH_CMD_RESET);
 }
+
 void flash_cmd_reset(flash_info_t *info)
-       __attribute__((weak,alias("__flash_cmd_reset")));
+       __attribute__((weak, alias("__flash_cmd_reset")));
 
 static int __flash_detect_cfi(flash_info_t *info, struct cfi_qry *qry)
 {
@@ -2035,7 +2026,7 @@ static void flash_fixup_sst(flash_info_t *info, struct cfi_qry *qry)
        if (info->device_id == 0x5D23 || /* SST39VF3201B */
            info->device_id == 0x5C23) { /* SST39VF3202B */
                /* set sector granularity to 4KB */
-               info->cmd_erase_sector=0x50;
+               info->cmd_erase_sector = 0x50;
        }
 }
 
@@ -2093,9 +2084,9 @@ ulong flash_get_size(phys_addr_t base, int banknum)
                num_erase_regions = qry.num_erase_regions;
 
                if (info->ext_addr) {
-                       info->cfi_version = (ushort) flash_read_uchar(info,
+                       info->cfi_version = (ushort)flash_read_uchar(info,
                                                info->ext_addr + 3) << 8;
-                       info->cfi_version |= (ushort) flash_read_uchar(info,
+                       info->cfi_version |= (ushort)flash_read_uchar(info,
                                                info->ext_addr + 4);
                }
 
@@ -2370,6 +2361,7 @@ unsigned long flash_init(void)
 #ifdef CONFIG_SYS_FLASH_PROTECTION
        /* read environment from EEPROM */
        char s[64];
+
        env_get_f("unlock", s, sizeof(s));
 #endif
 
@@ -2392,7 +2384,7 @@ unsigned long flash_init(void)
 #ifndef CONFIG_SYS_FLASH_QUIET_TEST
                        printf("## Unknown flash on Bank %d "
                                "- Size = 0x%08lx = %ld MB\n",
-                               i+1, flash_info[i].size,
+                               i + 1, flash_info[i].size,
                                flash_info[i].size >> 20);
 #endif /* CONFIG_SYS_FLASH_QUIET_TEST */
                }