mlxsw: spectrum_acl_tcam: Fix NULL pointer dereference in error path

[platform/kernel/linux-starfive.git] / drivers / mcb / mcb-parse.c

diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
index 2aef990..1ae37e6 100644 (file)
--- a/drivers/mcb/mcb-parse.c
+++ b/drivers/mcb/mcb-parse.c
@@ -99,8 +99,6 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
        mdev->mem.end = mdev->mem.start + size - 1;
        mdev->mem.flags = IORESOURCE_MEM;
 
-       mdev->is_added = false;
-
        ret = mcb_device_register(bus, mdev);
        if (ret < 0)
                goto err;
@@ -108,7 +106,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
        return 0;
 
 err:
-       put_device(&mdev->dev);
+       mcb_free_dev(mdev);
 
        return ret;
 }