iio: humidity: hts221: move BDU configuration in probe routine
[platform/kernel/linux-rpi.git] / drivers / iio / humidity / hts221_core.c
index 3f3ef4a..47a29b2 100644 (file)
@@ -13,6 +13,7 @@
 #include <linux/device.h>
 #include <linux/iio/sysfs.h>
 #include <linux/delay.h>
+#include <linux/pm.h>
 #include <asm/unaligned.h>
 
 #include "hts221.h"
 #define HTS221_HUMIDITY_AVG_MASK       0x07
 #define HTS221_TEMP_AVG_MASK           0x38
 
-#define HTS221_ODR_MASK                        0x87
+#define HTS221_ODR_MASK                        0x03
 #define HTS221_BDU_MASK                        BIT(2)
+#define HTS221_ENABLE_MASK             BIT(7)
 
 #define HTS221_DRDY_MASK               BIT(2)
 
-#define HTS221_ENABLE_SENSOR           BIT(7)
-
-#define HTS221_HUMIDITY_AVG_4          0x00 /* 0.4 %RH */
-#define HTS221_HUMIDITY_AVG_8          0x01 /* 0.3 %RH */
-#define HTS221_HUMIDITY_AVG_16         0x02 /* 0.2 %RH */
-#define HTS221_HUMIDITY_AVG_32         0x03 /* 0.15 %RH */
-#define HTS221_HUMIDITY_AVG_64         0x04 /* 0.1 %RH */
-#define HTS221_HUMIDITY_AVG_128                0x05 /* 0.07 %RH */
-#define HTS221_HUMIDITY_AVG_256                0x06 /* 0.05 %RH */
-#define HTS221_HUMIDITY_AVG_512                0x07 /* 0.03 %RH */
-
-#define HTS221_TEMP_AVG_2              0x00 /* 0.08 degC */
-#define HTS221_TEMP_AVG_4              0x08 /* 0.05 degC */
-#define HTS221_TEMP_AVG_8              0x10 /* 0.04 degC */
-#define HTS221_TEMP_AVG_16             0x18 /* 0.03 degC */
-#define HTS221_TEMP_AVG_32             0x20 /* 0.02 degC */
-#define HTS221_TEMP_AVG_64             0x28 /* 0.015 degC */
-#define HTS221_TEMP_AVG_128            0x30 /* 0.01 degC */
-#define HTS221_TEMP_AVG_256            0x38 /* 0.007 degC */
 
 /* calibration registers */
 #define HTS221_REG_0RH_CAL_X_H         0x36
@@ -72,10 +55,11 @@ struct hts221_odr {
        u8 val;
 };
 
+#define HTS221_AVG_DEPTH               8
 struct hts221_avg {
        u8 addr;
        u8 mask;
-       struct hts221_avg_avl avg_avl[HTS221_AVG_DEPTH];
+       u16 avg_avl[HTS221_AVG_DEPTH];
 };
 
 static const struct hts221_odr hts221_odr_table[] = {
@@ -89,28 +73,28 @@ static const struct hts221_avg hts221_avg_list[] = {
                .addr = HTS221_REG_AVG_ADDR,
                .mask = HTS221_HUMIDITY_AVG_MASK,
                .avg_avl = {
-                       { 4, HTS221_HUMIDITY_AVG_4 },
-                       { 8, HTS221_HUMIDITY_AVG_8 },
-                       { 16, HTS221_HUMIDITY_AVG_16 },
-                       { 32, HTS221_HUMIDITY_AVG_32 },
-                       { 64, HTS221_HUMIDITY_AVG_64 },
-                       { 128, HTS221_HUMIDITY_AVG_128 },
-                       { 256, HTS221_HUMIDITY_AVG_256 },
-                       { 512, HTS221_HUMIDITY_AVG_512 },
+                       4, /* 0.4 %RH */
+                       8, /* 0.3 %RH */
+                       16, /* 0.2 %RH */
+                       32, /* 0.15 %RH */
+                       64, /* 0.1 %RH */
+                       128, /* 0.07 %RH */
+                       256, /* 0.05 %RH */
+                       512, /* 0.03 %RH */
                },
        },
        {
                .addr = HTS221_REG_AVG_ADDR,
                .mask = HTS221_TEMP_AVG_MASK,
                .avg_avl = {
-                       { 2, HTS221_TEMP_AVG_2 },
-                       { 4, HTS221_TEMP_AVG_4 },
-                       { 8, HTS221_TEMP_AVG_8 },
-                       { 16, HTS221_TEMP_AVG_16 },
-                       { 32, HTS221_TEMP_AVG_32 },
-                       { 64, HTS221_TEMP_AVG_64 },
-                       { 128, HTS221_TEMP_AVG_128 },
-                       { 256, HTS221_TEMP_AVG_256 },
+                       2, /* 0.08 degC */
+                       4, /* 0.05 degC */
+                       8, /* 0.04 degC */
+                       16, /* 0.03 degC */
+                       32, /* 0.02 degC */
+                       64, /* 0.015 degC */
+                       128, /* 0.01 degC */
+                       256, /* 0.007 degC */
                },
        },
 };
@@ -165,7 +149,7 @@ static int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask,
                goto unlock;
        }
 
-       data = (data & ~mask) | (val & mask);
+       data = (data & ~mask) | ((val << __ffs(mask)) & mask);
 
        err = hw->tf->write(hw->dev, addr, sizeof(data), &data);
        if (err < 0)
@@ -200,11 +184,10 @@ static int hts221_check_whoami(struct hts221_hw *hw)
 
 int hts221_config_drdy(struct hts221_hw *hw, bool enable)
 {
-       u8 val = enable ? BIT(2) : 0;
        int err;
 
        err = hts221_write_with_mask(hw, HTS221_REG_CNTRL3_ADDR,
-                                    HTS221_DRDY_MASK, val);
+                                    HTS221_DRDY_MASK, enable);
 
        return err < 0 ? err : 0;
 }
@@ -212,7 +195,6 @@ int hts221_config_drdy(struct hts221_hw *hw, bool enable)
 static int hts221_update_odr(struct hts221_hw *hw, u8 odr)
 {
        int i, err;
-       u8 val;
 
        for (i = 0; i < ARRAY_SIZE(hts221_odr_table); i++)
                if (hts221_odr_table[i].hz == odr)
@@ -221,9 +203,13 @@ static int hts221_update_odr(struct hts221_hw *hw, u8 odr)
        if (i == ARRAY_SIZE(hts221_odr_table))
                return -EINVAL;
 
-       val = HTS221_ENABLE_SENSOR | HTS221_BDU_MASK | hts221_odr_table[i].val;
        err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR,
-                                    HTS221_ODR_MASK, val);
+                                    HTS221_ODR_MASK, hts221_odr_table[i].val);
+       if (err < 0)
+               return err;
+
+       err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR,
+                                    HTS221_ENABLE_MASK, 1);
        if (err < 0)
                return err;
 
@@ -240,14 +226,13 @@ static int hts221_update_avg(struct hts221_hw *hw,
        const struct hts221_avg *avg = &hts221_avg_list[type];
 
        for (i = 0; i < HTS221_AVG_DEPTH; i++)
-               if (avg->avg_avl[i].avg == val)
+               if (avg->avg_avl[i] == val)
                        break;
 
        if (i == HTS221_AVG_DEPTH)
                return -EINVAL;
 
-       err = hts221_write_with_mask(hw, avg->addr, avg->mask,
-                                    avg->avg_avl[i].val);
+       err = hts221_write_with_mask(hw, avg->addr, avg->mask, i);
        if (err < 0)
                return err;
 
@@ -282,7 +267,7 @@ hts221_sysfs_rh_oversampling_avail(struct device *dev,
 
        for (i = 0; i < ARRAY_SIZE(avg->avg_avl); i++)
                len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
-                                avg->avg_avl[i].avg);
+                                avg->avg_avl[i]);
        buf[len - 1] = '\n';
 
        return len;
@@ -299,7 +284,7 @@ hts221_sysfs_temp_oversampling_avail(struct device *dev,
 
        for (i = 0; i < ARRAY_SIZE(avg->avg_avl); i++)
                len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
-                                avg->avg_avl[i].avg);
+                                avg->avg_avl[i]);
        buf[len - 1] = '\n';
 
        return len;
@@ -307,15 +292,30 @@ hts221_sysfs_temp_oversampling_avail(struct device *dev,
 
 int hts221_power_on(struct hts221_hw *hw)
 {
-       return hts221_update_odr(hw, hw->odr);
+       int err;
+
+       err = hts221_update_odr(hw, hw->odr);
+       if (err < 0)
+               return err;
+
+       hw->enabled = true;
+
+       return 0;
 }
 
 int hts221_power_off(struct hts221_hw *hw)
 {
-       u8 data[] = {0x00, 0x00};
+       __le16 data = 0;
+       int err;
+
+       err = hw->tf->write(hw->dev, HTS221_REG_CNTRL1_ADDR, sizeof(data),
+                           (u8 *)&data);
+       if (err < 0)
+               return err;
+
+       hw->enabled = false;
 
-       return hw->tf->write(hw->dev, HTS221_REG_CNTRL1_ADDR, sizeof(data),
-                            data);
+       return 0;
 }
 
 static int hts221_parse_temp_caldata(struct hts221_hw *hw)
@@ -518,13 +518,13 @@ static int hts221_read_raw(struct iio_dev *iio_dev,
                case IIO_HUMIDITYRELATIVE:
                        avg = &hts221_avg_list[HTS221_SENSOR_H];
                        idx = hw->sensors[HTS221_SENSOR_H].cur_avg_idx;
-                       *val = avg->avg_avl[idx].avg;
+                       *val = avg->avg_avl[idx];
                        ret = IIO_VAL_INT;
                        break;
                case IIO_TEMP:
                        avg = &hts221_avg_list[HTS221_SENSOR_T];
                        idx = hw->sensors[HTS221_SENSOR_T].cur_avg_idx;
-                       *val = avg->avg_avl[idx].avg;
+                       *val = avg->avg_avl[idx];
                        ret = IIO_VAL_INT;
                        break;
                default:
@@ -638,6 +638,12 @@ int hts221_probe(struct iio_dev *iio_dev)
        iio_dev->name = HTS221_DEV_NAME;
        iio_dev->info = &hts221_info;
 
+       /* enable Block Data Update */
+       err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR,
+                                    HTS221_BDU_MASK, 1);
+       if (err < 0)
+               return err;
+
        /* configure humidity sensor */
        err = hts221_parse_rh_caldata(hw);
        if (err < 0) {
@@ -645,7 +651,7 @@ int hts221_probe(struct iio_dev *iio_dev)
                return err;
        }
 
-       data = hts221_avg_list[HTS221_SENSOR_H].avg_avl[3].avg;
+       data = hts221_avg_list[HTS221_SENSOR_H].avg_avl[3];
        err = hts221_update_avg(hw, HTS221_SENSOR_H, data);
        if (err < 0) {
                dev_err(hw->dev, "failed to set rh oversampling ratio\n");
@@ -660,7 +666,7 @@ int hts221_probe(struct iio_dev *iio_dev)
                return err;
        }
 
-       data = hts221_avg_list[HTS221_SENSOR_T].avg_avl[3].avg;
+       data = hts221_avg_list[HTS221_SENSOR_T].avg_avl[3];
        err = hts221_update_avg(hw, HTS221_SENSOR_T, data);
        if (err < 0) {
                dev_err(hw->dev,
@@ -682,6 +688,36 @@ int hts221_probe(struct iio_dev *iio_dev)
 }
 EXPORT_SYMBOL(hts221_probe);
 
+static int __maybe_unused hts221_suspend(struct device *dev)
+{
+       struct iio_dev *iio_dev = dev_get_drvdata(dev);
+       struct hts221_hw *hw = iio_priv(iio_dev);
+       __le16 data = 0;
+       int err;
+
+       err = hw->tf->write(hw->dev, HTS221_REG_CNTRL1_ADDR, sizeof(data),
+                           (u8 *)&data);
+
+       return err < 0 ? err : 0;
+}
+
+static int __maybe_unused hts221_resume(struct device *dev)
+{
+       struct iio_dev *iio_dev = dev_get_drvdata(dev);
+       struct hts221_hw *hw = iio_priv(iio_dev);
+       int err = 0;
+
+       if (hw->enabled)
+               err = hts221_update_odr(hw, hw->odr);
+
+       return err;
+}
+
+const struct dev_pm_ops hts221_pm_ops = {
+       SET_SYSTEM_SLEEP_PM_OPS(hts221_suspend, hts221_resume)
+};
+EXPORT_SYMBOL(hts221_pm_ops);
+
 MODULE_AUTHOR("Lorenzo Bianconi <lorenzo.bianconi@st.com>");
 MODULE_DESCRIPTION("STMicroelectronics hts221 sensor driver");
 MODULE_LICENSE("GPL v2");