Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc
[platform/adaptation/renesas_rcar/renesas_kernel.git] / drivers / firmware / efi / efi-pstore.c
index 452800e..73de5a9 100644 (file)
@@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct efivar_entry *entry, void *data)
                           &entry->var.DataSize, entry->var.Data);
        size = entry->var.DataSize;
 
-       *cb_data->buf = kmalloc(size, GFP_KERNEL);
+       *cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL);
        if (*cb_data->buf == NULL)
                return -ENOMEM;
-       memcpy(*cb_data->buf, entry->var.Data, size);
        return size;
 }
 
@@ -236,7 +235,11 @@ static __init int efivars_pstore_init(void)
        efi_pstore_info.bufsize = 1024;
        spin_lock_init(&efi_pstore_info.buf_lock);
 
-       pstore_register(&efi_pstore_info);
+       if (pstore_register(&efi_pstore_info)) {
+               kfree(efi_pstore_info.buf);
+               efi_pstore_info.buf = NULL;
+               efi_pstore_info.bufsize = 0;
+       }
 
        return 0;
 }