/*
- * Copyright (c) 2022 Samsung Electronics Co., Ltd.
+ * Copyright (c) 2023 Samsung Electronics Co., Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
// INTERNAL INCLUDES
#include <dali/devel-api/threading/thread-pool.h>
#include <dali/integration-api/core.h>
+#include <dali/internal/common/ordered-set.h>
#include <dali/internal/event/common/scene-impl.h>
#include <dali/internal/update/nodes/scene-graph-layer.h>
#include <dali/internal/update/render-tasks/scene-graph-camera.h>
+#include <dali/internal/common/owner-key-container.h>
+
#include <dali/internal/render/common/render-algorithms.h>
#include <dali/internal/render/common/render-debug.h>
#include <dali/internal/render/common/render-instruction.h>
}
return newScissorArea;
}
-
-/**
- * @brief The number of dirty rects per renderer in itemDirtyRects list.
- * If this value is 3, keep only last 3 dirty rects for the same node and renderer.
- */
-constexpr int MAX_DIRTY_RECT_PER_RENDERER = 3;
} // namespace
+
/**
* Structure to contain internal data
*/
Integration::StencilBufferAvailable stencilBufferAvailableParam,
Integration::PartialUpdateAvailable partialUpdateAvailableParam)
: graphicsController(graphicsController),
- renderQueue(),
renderAlgorithms(graphicsController),
- frameCount(0u),
- renderBufferIndex(SceneGraphBuffers::INITIAL_UPDATE_BUFFER_INDEX),
- rendererContainer(),
- samplerContainer(),
- textureContainer(),
- frameBufferContainer(),
- lastFrameWasRendered(false),
programController(graphicsController),
shaderCache(graphicsController),
depthBufferAvailable(depthBufferAvailableParam),
}
// the order is important for destruction,
- Graphics::Controller& graphicsController;
- RenderQueue renderQueue; ///< A message queue for receiving messages from the update-thread.
-
- std::vector<SceneGraph::Scene*> sceneContainer; ///< List of pointers to the scene graph objects of the scenes
-
- Render::RenderAlgorithms renderAlgorithms; ///< The RenderAlgorithms object is used to action the renders required by a RenderInstruction
-
- uint32_t frameCount; ///< The current frame count
- BufferIndex renderBufferIndex; ///< The index of the buffer to read from; this is opposite of the "update" buffer
-
- OwnerContainer<Render::Renderer*> rendererContainer; ///< List of owned renderers
- OwnerContainer<Render::Sampler*> samplerContainer; ///< List of owned samplers
- OwnerContainer<Render::Texture*> textureContainer; ///< List of owned textures
- OwnerContainer<Render::FrameBuffer*> frameBufferContainer; ///< List of owned framebuffers
- OwnerContainer<Render::VertexBuffer*> vertexBufferContainer; ///< List of owned vertex buffers
- OwnerContainer<Render::Geometry*> geometryContainer; ///< List of owned Geometries
+ Graphics::Controller& graphicsController;
+ RenderQueue renderQueue; ///< A message queue for receiving messages from the update-thread.
+ std::vector<SceneGraph::Scene*> sceneContainer; ///< List of pointers to the scene graph objects of the scenes
+ Render::RenderAlgorithms renderAlgorithms; ///< The RenderAlgorithms object is used to action the renders required by a RenderInstruction
- bool lastFrameWasRendered; ///< Keeps track of the last frame being rendered due to having render instructions
+ OrderedSet<Render::Sampler> samplerContainer; ///< List of owned samplers
+ OrderedSet<Render::FrameBuffer> frameBufferContainer; ///< List of owned framebuffers
+ OrderedSet<Render::VertexBuffer> vertexBufferContainer; ///< List of owned vertex buffers
+ OrderedSet<Render::Geometry> geometryContainer; ///< List of owned Geometries
+ OwnerKeyContainer<Render::Renderer> rendererContainer; ///< List of owned renderers
+ OwnerKeyContainer<Render::Texture> textureContainer; ///< List of owned textures
- OwnerContainer<Render::RenderTracker*> mRenderTrackers; ///< List of render trackers
+ OrderedSet<Render::RenderTracker> mRenderTrackers; ///< List of owned render trackers
ProgramController programController; ///< Owner of the programs
Render::ShaderCache shaderCache; ///< The cache for the graphics shaders
std::unique_ptr<Dali::ThreadPool> threadPool; ///< The thread pool
Vector<Graphics::Texture*> boundTextures; ///< The textures bound for rendering
Vector<Graphics::Texture*> textureDependencyList; ///< The dependency list of bound textures
+
+ uint32_t frameCount{0u}; ///< The current frame count
+ BufferIndex renderBufferIndex{SceneGraphBuffers::INITIAL_UPDATE_BUFFER_INDEX}; ///< The index of the buffer to read from; this is opposite of the "update" buffer
+
+ bool lastFrameWasRendered{false}; ///< Keeps track of the last frame being rendered due to having render instructions
+ bool commandBufferSubmitted{false};
};
RenderManager* RenderManager::New(Graphics::Controller& graphicsController,
{
}
-void RenderManager::AddRenderer(OwnerPointer<Render::Renderer>& renderer)
+void RenderManager::AddRenderer(const Render::RendererKey& renderer)
{
// Initialize the renderer as we are now in render thread
renderer->Initialize(mImpl->graphicsController, mImpl->programController, mImpl->shaderCache, *(mImpl->uniformBufferManager.get()), *(mImpl->pipelineCache.get()));
- mImpl->rendererContainer.PushBack(renderer.Release());
+ mImpl->rendererContainer.PushBack(renderer);
}
-void RenderManager::RemoveRenderer(Render::Renderer* renderer)
+void RenderManager::RemoveRenderer(const Render::RendererKey& renderer)
{
- mImpl->rendererContainer.EraseObject(renderer);
+ mImpl->rendererContainer.EraseKey(renderer);
}
void RenderManager::AddSampler(OwnerPointer<Render::Sampler>& sampler)
mImpl->samplerContainer.EraseObject(sampler);
}
-void RenderManager::AddTexture(OwnerPointer<Render::Texture>& texture)
+void RenderManager::AddTexture(const Render::TextureKey& textureKey)
{
- texture->Initialize(mImpl->graphicsController);
- mImpl->textureContainer.PushBack(texture.Release());
+ DALI_ASSERT_DEBUG(textureKey && "Trying to add empty texture key");
+
+ textureKey->Initialize(mImpl->graphicsController);
+ mImpl->textureContainer.PushBack(textureKey);
}
-void RenderManager::RemoveTexture(Render::Texture* texture)
+void RenderManager::RemoveTexture(const Render::TextureKey& textureKey)
{
- DALI_ASSERT_DEBUG(NULL != texture);
+ DALI_ASSERT_DEBUG(textureKey && "Trying to remove empty texture key");
- // Find the texture, use std::find so we can do the erase safely
- auto iter = std::find(mImpl->textureContainer.begin(), mImpl->textureContainer.end(), texture);
+ // Find the texture, use std::find so we can do the erase by iterator safely
+ auto iter = std::find(mImpl->textureContainer.Begin(), mImpl->textureContainer.End(), textureKey);
- if(iter != mImpl->textureContainer.end())
+ if(iter != mImpl->textureContainer.End())
{
- texture->Destroy();
+ textureKey->Destroy();
mImpl->textureContainer.Erase(iter); // Texture found; now destroy it
}
}
-void RenderManager::UploadTexture(Render::Texture* texture, PixelDataPtr pixelData, const Texture::UploadParams& params)
+void RenderManager::UploadTexture(const Render::TextureKey& textureKey, PixelDataPtr pixelData, const Texture::UploadParams& params)
{
- texture->Upload(pixelData, params);
+ DALI_ASSERT_DEBUG(textureKey && "Trying to upload to empty texture key");
+ textureKey->Upload(pixelData, params);
}
-void RenderManager::GenerateMipmaps(Render::Texture* texture)
+void RenderManager::GenerateMipmaps(const Render::TextureKey& textureKey)
{
- texture->GenerateMipmaps();
+ DALI_ASSERT_DEBUG(textureKey && "Trying to generate mipmaps on empty texture key");
+ textureKey->GenerateMipmaps();
}
void RenderManager::SetFilterMode(Render::Sampler* sampler, uint32_t minFilterMode, uint32_t magFilterMode)
{
DALI_ASSERT_DEBUG(nullptr != frameBuffer);
- // Find the framebuffer, use std:find so we can safely do the erase
- auto iter = std::find(mImpl->frameBufferContainer.begin(), mImpl->frameBufferContainer.end(), frameBuffer);
+ // Find the framebuffer, use OrderedSet.Find so we can safely do the erase
+ auto iter = mImpl->frameBufferContainer.Find(frameBuffer);
- if(iter != mImpl->frameBufferContainer.end())
+ if(iter != mImpl->frameBufferContainer.End())
{
frameBuffer->Destroy();
mImpl->frameBufferContainer.Erase(iter); // frameBuffer found; now destroy it
frameBuffer->AttachDepthStencilTexture(texture, mipmapLevel);
}
+void RenderManager::SetMultiSamplingLevelToFrameBuffer(Render::FrameBuffer* frameBuffer, uint8_t multiSamplingLevel)
+{
+ frameBuffer->SetMultiSamplingLevel(multiSamplingLevel);
+}
+
void RenderManager::AddVertexBuffer(OwnerPointer<Render::VertexBuffer>& vertexBuffer)
{
mImpl->vertexBufferContainer.PushBack(vertexBuffer.Release());
vertexBuffer->SetData(data.Release(), size);
}
-void RenderManager::SetIndexBuffer(Render::Geometry* geometry, Dali::Vector<uint16_t>& indices)
+void RenderManager::SetIndexBuffer(Render::Geometry* geometry, Render::Geometry::Uint16ContainerType& indices)
+{
+ geometry->SetIndexBuffer(indices);
+}
+
+void RenderManager::SetIndexBuffer(Render::Geometry* geometry, Render::Geometry::Uint32ContainerType& indices)
{
geometry->SetIndexBuffer(indices);
}
void RenderManager::RemoveGeometry(Render::Geometry* geometry)
{
- auto iter = std::find(mImpl->geometryContainer.begin(), mImpl->geometryContainer.end(), geometry);
-
- if(iter != mImpl->geometryContainer.end())
- {
- mImpl->geometryContainer.Erase(iter);
- }
+ mImpl->geometryContainer.EraseObject(geometry);
}
void RenderManager::AttachVertexBuffer(Render::Geometry* geometry, Render::VertexBuffer* vertexBuffer)
{
- DALI_ASSERT_DEBUG(nullptr != geometry);
-
- // Find the geometry
- for(auto&& iter : mImpl->geometryContainer)
- {
- if(iter == geometry)
- {
- iter->AddVertexBuffer(vertexBuffer);
- break;
- }
- }
+ geometry->AddVertexBuffer(vertexBuffer);
}
void RenderManager::RemoveVertexBuffer(Render::Geometry* geometry, Render::VertexBuffer* vertexBuffer)
{
- DALI_ASSERT_DEBUG(nullptr != geometry);
-
- // Find the geometry
- for(auto&& iter : mImpl->geometryContainer)
- {
- if(iter == geometry)
- {
- iter->RemoveVertexBuffer(vertexBuffer);
- break;
- }
- }
+ geometry->RemoveVertexBuffer(vertexBuffer);
}
void RenderManager::SetGeometryType(Render::Geometry* geometry, uint32_t geometryType)
geom->Upload(mImpl->graphicsController);
}
}
+
+ // Clean latest used pipeline
+ mImpl->pipelineCache->CleanLatestUsedCache();
+
+ mImpl->commandBufferSubmitted = false;
}
void RenderManager::PreRender(Integration::Scene& scene, std::vector<Rect<int>>& damagedRects)
Internal::Scene& sceneInternal = GetImplementation(scene);
SceneGraph::Scene* sceneObject = sceneInternal.GetSceneObject();
- if(sceneObject->IsRenderingSkipped())
+ if(!sceneObject || sceneObject->IsRenderingSkipped())
{
// We don't need to calculate dirty rects
return;
// Clean collected dirty/damaged rects on exit if 3d layer or 3d node or other conditions.
DamagedRectsCleaner damagedRectCleaner(damagedRects, surfaceRect);
+ bool cleanDamagedRect = false;
- // Mark previous dirty rects in the sorted array. The array is already sorted by node and renderer, frame number.
- // so you don't need to sort: std::stable_sort(itemsDirtyRects.begin(), itemsDirtyRects.end());
- std::vector<DirtyRect>& itemsDirtyRects = sceneObject->GetItemsDirtyRects();
- for(DirtyRect& dirtyRect : itemsDirtyRects)
+ // Mark previous dirty rects in the std::unordered_map.
+ Scene::ItemsDirtyRectsContainer& itemsDirtyRects = sceneObject->GetItemsDirtyRects();
+ for(auto& dirtyRectPair : itemsDirtyRects)
{
- dirtyRect.visited = false;
+ dirtyRectPair.second.visited = false;
}
uint32_t instructionCount = sceneObject->GetRenderInstructions().Count(mImpl->renderBufferIndex);
if(instruction.mFrameBuffer)
{
- return; // TODO: reset, we don't deal with render tasks with framebuffers (for now)
+ cleanDamagedRect = true;
+ continue; // TODO: reset, we don't deal with render tasks with framebuffers (for now)
}
const Camera* camera = instruction.GetCamera();
- if(camera->mType == Camera::DEFAULT_TYPE && camera->mTargetPosition == Camera::DEFAULT_TARGET_POSITION)
+ if(camera && camera->mType == Camera::DEFAULT_TYPE && camera->mTargetPosition == Camera::DEFAULT_TARGET_POSITION)
{
- const Node* node = instruction.GetCamera()->GetNode();
- if(node)
+ Vector3 position;
+ Vector3 scale;
+ Quaternion orientation;
+ camera->GetWorldMatrix(mImpl->renderBufferIndex).GetTransformComponents(position, orientation, scale);
+
+ Vector3 orientationAxis;
+ Radian orientationAngle;
+ orientation.ToAxisAngle(orientationAxis, orientationAngle);
+
+ if(position.x > Math::MACHINE_EPSILON_10000 ||
+ position.y > Math::MACHINE_EPSILON_10000 ||
+ orientationAxis != Vector3(0.0f, 1.0f, 0.0f) ||
+ orientationAngle != ANGLE_180 ||
+ scale != Vector3(1.0f, 1.0f, 1.0f))
{
- Vector3 position;
- Vector3 scale;
- Quaternion orientation;
- node->GetWorldMatrix(mImpl->renderBufferIndex).GetTransformComponents(position, orientation, scale);
-
- Vector3 orientationAxis;
- Radian orientationAngle;
- orientation.ToAxisAngle(orientationAxis, orientationAngle);
-
- if(position.x > Math::MACHINE_EPSILON_10000 ||
- position.y > Math::MACHINE_EPSILON_10000 ||
- orientationAxis != Vector3(0.0f, 1.0f, 0.0f) ||
- orientationAngle != ANGLE_180 ||
- scale != Vector3(1.0f, 1.0f, 1.0f))
- {
- return;
- }
+ cleanDamagedRect = true;
+ continue;
}
}
else
{
- return;
+ cleanDamagedRect = true;
+ continue;
}
Rect<int32_t> viewportRect;
viewportRect.Set(instruction.mViewport.x, y, instruction.mViewport.width, instruction.mViewport.height);
if(viewportRect.IsEmpty() || !viewportRect.IsValid())
{
- return; // just skip funny use cases for now, empty viewport means it is set somewhere else
+ cleanDamagedRect = true;
+ continue; // just skip funny use cases for now, empty viewport means it is set somewhere else
}
}
else
for(uint32_t listIndex = 0u; listIndex < listCount; ++listIndex)
{
RenderItem& item = renderList->GetItem(listIndex);
- // If the item does 3D transformation, do early exit and clean the damaged rect array
+ // If the item does 3D transformation, make full update
if(item.mUpdateArea == Vector4::ZERO)
{
- return;
+ cleanDamagedRect = true;
+
+ // Save the full rect in the damaged list. We need it when this item is removed
+ DirtyRectKey dirtyRectKey(item.mNode, item.mRenderer);
+ auto dirtyRectPos = itemsDirtyRects.find(dirtyRectKey);
+ if(dirtyRectPos != itemsDirtyRects.end())
+ {
+ // Replace the rect
+ dirtyRectPos->second.visited = true;
+ dirtyRectPos->second.rect = surfaceRect;
+ }
+ else
+ {
+ // Else, just insert the new dirtyrect
+ itemsDirtyRects.insert({dirtyRectKey, surfaceRect});
+ }
+ continue;
}
- Rect<int> rect;
- DirtyRect dirtyRect(item.mNode, item.mRenderer, mImpl->frameCount, rect);
+ Rect<int> rect;
+ DirtyRectKey dirtyRectKey(item.mNode, item.mRenderer);
// If the item refers to updated node or renderer.
if(item.mIsUpdated ||
(item.mNode &&
- (item.mNode->Updated() || (item.mRenderer && item.mRenderer->Updated(mImpl->renderBufferIndex, item.mNode)))))
+ (item.mNode->Updated() || (item.mRenderer && item.mRenderer->Updated(mImpl->renderBufferIndex)))))
{
item.mIsUpdated = false;
- rect = RenderItem::CalculateViewportSpaceAABB(item.mModelViewMatrix, Vector3(item.mUpdateArea.x, item.mUpdateArea.y, 0.0f), Vector3(item.mUpdateArea.z, item.mUpdateArea.w, 0.0f), viewportRect.width, viewportRect.height);
+ Vector4 updateArea = item.mRenderer ? item.mRenderer->GetVisualTransformedUpdateArea(mImpl->renderBufferIndex, item.mUpdateArea) : item.mUpdateArea;
+
+ rect = RenderItem::CalculateViewportSpaceAABB(item.mModelViewMatrix, Vector3(updateArea.x, updateArea.y, 0.0f), Vector3(updateArea.z, updateArea.w, 0.0f), viewportRect.width, viewportRect.height);
if(rect.IsValid() && rect.Intersect(viewportRect) && !rect.IsEmpty())
{
const int left = rect.x;
rect.height = ((bottom + 16) / 16) * 16 - rect.y;
// Found valid dirty rect.
- // 1. Mark the related dirty rects as visited so they will not be removed below.
- // 2. Keep only last "MAX_DIRTY_RECT_PER_RENDERER" dirty rects for the same node and renderer (Tizen uses 3 back buffers, Ubuntu 1).
- // 3-1. If itemDirtyRect hold MAX_DIRTY_RECT_PER_RENDERER rects, remove oldest one and insert it in the sorted array of the dirty rects.
- // 3-2. Else, Insert it in the sorted array of the dirty rects.
- dirtyRect.rect = rect;
- auto dirtyRectPos = std::lower_bound(itemsDirtyRects.begin(), itemsDirtyRects.end(), dirtyRect);
-
- auto originDirtyRectPos = dirtyRectPos;
- bool hasMaxDirtyRect = false;
- while(dirtyRectPos != itemsDirtyRects.end())
+ auto dirtyRectPos = itemsDirtyRects.find(dirtyRectKey);
+ if(dirtyRectPos != itemsDirtyRects.end())
{
- if(dirtyRectPos->node != item.mNode || dirtyRectPos->renderer != item.mRenderer)
- {
- break;
- }
+ Rect<int> currentRect = rect;
- dirtyRectPos->visited = true;
- rect.Merge(dirtyRectPos->rect);
+ // Same item, merge it with the previous rect
+ rect.Merge(dirtyRectPos->second.rect);
- ++dirtyRectPos;
-
- if((dirtyRectPos - originDirtyRectPos) == MAX_DIRTY_RECT_PER_RENDERER) // no more than MAX_DIRTY_RECT_PER_RENDERER previous rects
- {
- hasMaxDirtyRect = true;
- break;
- }
- }
-
- if(hasMaxDirtyRect)
- {
- // If we have already MAX_DIRTY_RECT_PER_RENDERER for the same item, just copy it.
- // Remove the oldest rect (at pos + MAX_DIRTY_RECT_PER_RENDERER - 1)
- // and move other rects one step.
- // and insert new dirtyRect at originDirtyRectPos.
- auto pos = originDirtyRectPos - itemsDirtyRects.begin();
- for(auto i = MAX_DIRTY_RECT_PER_RENDERER - 1; i > 0; i--)
- {
- itemsDirtyRects[pos + i] = itemsDirtyRects[pos + i - 1];
- }
- itemsDirtyRects[pos] = dirtyRect;
+ // Replace the rect as current
+ dirtyRectPos->second.visited = true;
+ dirtyRectPos->second.rect = currentRect;
}
else
{
- // Else, just insert the new dirtyrect in the correct position
- itemsDirtyRects.insert(originDirtyRectPos, dirtyRect);
+ // Else, just insert the new dirtyrect
+ itemsDirtyRects.insert({dirtyRectKey, rect});
}
damagedRects.push_back(rect);
{
// 1. The item is not dirty, the node and renderer referenced by the item are still exist.
// 2. Mark the related dirty rects as visited so they will not be removed below.
- auto dirtyRectPos = std::lower_bound(itemsDirtyRects.begin(), itemsDirtyRects.end(), dirtyRect);
- while(dirtyRectPos != itemsDirtyRects.end())
+ auto dirtyRectPos = itemsDirtyRects.find(dirtyRectKey);
+ if(dirtyRectPos != itemsDirtyRects.end())
{
- if(dirtyRectPos->node != item.mNode || dirtyRectPos->renderer != item.mRenderer)
- {
- break;
- }
-
- dirtyRectPos->visited = true;
- dirtyRectPos++;
+ dirtyRectPos->second.visited = true;
+ }
+ else
+ {
+ // The item is not in the list for some reason. Add it!
+ itemsDirtyRects.insert({dirtyRectKey, surfaceRect});
+ cleanDamagedRect = true; // And make full update at this frame
}
}
}
}
// Check removed nodes or removed renderers dirty rects
- auto i = itemsDirtyRects.begin();
- auto j = itemsDirtyRects.begin();
- while(i != itemsDirtyRects.end())
+ // Note, std::unordered_map end iterator is validate if we call erase.
+ for(auto iter = itemsDirtyRects.cbegin(), iterEnd = itemsDirtyRects.cend(); iter != iterEnd;)
{
- if(i->visited)
+ if(!iter->second.visited)
{
- *j++ = *i;
+ damagedRects.push_back(iter->second.rect);
+ iter = itemsDirtyRects.erase(iter);
}
else
{
- Rect<int>& dirtRect = i->rect;
- damagedRects.push_back(dirtRect);
+ ++iter;
}
- i++;
}
- itemsDirtyRects.resize(j - itemsDirtyRects.begin());
- damagedRectCleaner.SetCleanOnReturn(false);
-
- // Reset updated flag from the root
- Layer* root = sceneObject->GetRoot();
- if(root)
+ if(!cleanDamagedRect)
{
- root->SetUpdatedTree(false);
+ damagedRectCleaner.SetCleanOnReturn(false);
}
}
void RenderManager::RenderScene(Integration::RenderStatus& status, Integration::Scene& scene, bool renderToFbo)
{
- SceneGraph::Scene* sceneObject = GetImplementation(scene).GetSceneObject();
- Rect<int> clippingRect = sceneObject->GetSurfaceRect();
+ SceneGraph::Scene* sceneObject = GetImplementation(scene).GetSceneObject();
+ if(!sceneObject)
+ {
+ return;
+ }
+ Rect<int> clippingRect = sceneObject->GetSurfaceRect();
RenderScene(status, scene, renderToFbo, clippingRect);
}
Internal::Scene& sceneInternal = GetImplementation(scene);
SceneGraph::Scene* sceneObject = sceneInternal.GetSceneObject();
+ if(!sceneObject)
+ {
+ return;
+ }
uint32_t count = sceneObject->GetRenderInstructions().Count(mImpl->renderBufferIndex);
Rect<int32_t> viewportRect;
- int32_t surfaceOrientation = sceneObject->GetSurfaceOrientation();
+ int32_t surfaceOrientation = sceneObject->GetSurfaceOrientation() + sceneObject->GetScreenOrientation();
+ if(surfaceOrientation >= 360)
+ {
+ surfaceOrientation -= 360;
+ }
// @todo Should these be part of scene?
Integration::DepthBufferAvailable depthBufferAvailable = mImpl->depthBufferAvailable;
// Scissor's value should be set based on the default system coordinates.
// When the surface is rotated, the input values already were set with the rotated angle.
// So, re-calculation is needed.
- scissorArea = RecalculateScissorArea(scissorArea, surfaceOrientation, viewportRect);
+ scissorArea = RecalculateScissorArea(scissorArea, surfaceOrientation, surfaceRect);
// Begin render pass
mainCommandBuffer->BeginRenderPass(
mImpl->boundTextures,
viewportRect,
clippingRect,
- surfaceOrientation);
+ surfaceOrientation,
+ Uint16Pair(surfaceRect.width, surfaceRect.height));
Graphics::SyncObject* syncObject{nullptr};
// If the render instruction has an associated render tracker (owned separately)
mImpl->uniformBufferManager->UnlockUniformBuffer(mImpl->renderBufferIndex);
mImpl->renderAlgorithms.SubmitCommandBuffer();
+ mImpl->commandBufferSubmitted = true;
std::sort(targetstoPresent.begin(), targetstoPresent.end());
void RenderManager::PostRender()
{
+ if(!mImpl->commandBufferSubmitted)
+ {
+ // Rendering is skipped but there may be pending tasks. Flush them.
+ Graphics::SubmitInfo submitInfo;
+ submitInfo.cmdBuffer.clear(); // Only flush
+ submitInfo.flags = 0 | Graphics::SubmitFlagBits::FLUSH;
+ mImpl->graphicsController.SubmitCommandBuffers(submitInfo);
+
+ mImpl->commandBufferSubmitted = true;
+ }
+
// Notify RenderGeometries that rendering has finished
for(auto&& iter : mImpl->geometryContainer)
{
iter->OnRenderFinished();
}
+ // Notify RenderTexture that rendering has finished
+ for(auto&& iter : mImpl->textureContainer)
+ {
+ iter->OnRenderFinished();
+ }
+
mImpl->UpdateTrackers();
uint32_t count = 0u;