[dali_2.3.28] Merge branch 'devel/master'

[platform/core/uifw/dali-adaptor.git] / dali / internal / accessibility / bridge / bridge-component.cpp

diff --git a/dali/internal/accessibility/bridge/bridge-component.cpp b/dali/internal/accessibility/bridge/bridge-component.cpp
index 1e65ddc..ef0ff0f 100644 (file)
--- a/dali/internal/accessibility/bridge/bridge-component.cpp
+++ b/dali/internal/accessibility/bridge/bridge-component.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019 Samsung Electronics Co., Ltd.
+ * Copyright (c) 2021 Samsung Electronics Co., Ltd.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,9 +18,6 @@
 // CLASS HEADER
 #include <dali/internal/accessibility/bridge/bridge-component.h>
 
-// EXTERNAL INCLUDES
-#include <iostream>
-
 #define DBUS_INTERFACE_PROPERTIES "org.freedesktop.DBus.Properties"
 
 using namespace Dali::Accessibility;
@@ -31,75 +28,92 @@ BridgeComponent::BridgeComponent()
 
 void BridgeComponent::RegisterInterfaces()
 {
-  DBus::DBusInterfaceDescription desc{AtspiDbusInterfaceComponent};
-  AddFunctionToInterface( desc, "Contains", &BridgeComponent::Contains );
-  AddFunctionToInterface( desc, "GetAccessibleAtPoint", &BridgeComponent::GetAccessibleAtPoint );
-  AddFunctionToInterface( desc, "GetExtents", &BridgeComponent::GetExtents );
-  AddFunctionToInterface( desc, "GetPosition", &BridgeComponent::GetPosition );
-  AddFunctionToInterface( desc, "GetSize", &BridgeComponent::GetSize );
-  AddFunctionToInterface( desc, "GetLayer", &BridgeComponent::GetLayer );
-  AddFunctionToInterface( desc, "GetAlpha", &BridgeComponent::GetAlpha );
-  AddFunctionToInterface( desc, "GetMDIZOrder", &BridgeComponent::GetMdiZOrder );
-  AddFunctionToInterface( desc, "GrabHighlight", &BridgeComponent::GrabHighlight );
-  AddFunctionToInterface( desc, "GrabFocus", &BridgeComponent::GrabFocus );
-  AddFunctionToInterface( desc, "ClearHighlight", &BridgeComponent::ClearHighlight );
-  dbusServer.addInterface( "/", desc, true );
+  // The second arguments below are the names (or signatures) of DBus methods.
+  // Screen Reader will call the methods with the exact names as specified in the AT-SPI Component interface:
+  // https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/master/xml/Component.xml
+
+  DBus::DBusInterfaceDescription desc{Accessible::GetInterfaceName(AtspiInterface::COMPONENT)};
+  AddFunctionToInterface(desc, "Contains", &BridgeComponent::IsAccessibleContainingPoint);
+  AddFunctionToInterface(desc, "GetAccessibleAtPoint", &BridgeComponent::GetAccessibleAtPoint);
+  AddFunctionToInterface(desc, "GetExtents", &BridgeComponent::GetExtents);
+  AddFunctionToInterface(desc, "GetPosition", &BridgeComponent::GetPosition);
+  AddFunctionToInterface(desc, "GetSize", &BridgeComponent::GetSize);
+  AddFunctionToInterface(desc, "GetLayer", &BridgeComponent::GetLayer);
+  AddFunctionToInterface(desc, "GetAlpha", &BridgeComponent::GetAlpha);
+  AddFunctionToInterface(desc, "GetMDIZOrder", &BridgeComponent::GetMdiZOrder);
+  AddFunctionToInterface(desc, "GrabHighlight", &BridgeComponent::GrabHighlight);
+  AddFunctionToInterface(desc, "GrabFocus", &BridgeComponent::GrabFocus);
+  AddFunctionToInterface(desc, "ClearHighlight", &BridgeComponent::ClearHighlight);
+  mDbusServer.addInterface("/", desc, true);
 }
 
 Component* BridgeComponent::FindSelf() const
 {
-  auto s = BridgeBase::FindSelf();
-  assert( s );
-  auto s2 = dynamic_cast< Component* >( s );
-  if( !s2 )
-    throw std::domain_error{"object " + s->GetAddress().ToString() + " doesn't have Component interface"};
-  return s2;
+  return FindCurrentObjectWithInterface<Dali::Accessibility::AtspiInterface::COMPONENT>();
 }
 
-DBus::ValueOrError< bool > BridgeComponent::Contains( int32_t x, int32_t y, uint32_t coordType )
+DBus::ValueOrError<bool> BridgeComponent::IsAccessibleContainingPoint(int32_t x, int32_t y, uint32_t coordType)
 {
-  return FindSelf()->Contains( {x, y}, static_cast< CoordType >( coordType ) );
+  return FindSelf()->IsAccessibleContainingPoint({x, y}, static_cast<CoordinateType>(coordType));
 }
-DBus::ValueOrError< Accessible* > BridgeComponent::GetAccessibleAtPoint( int32_t x, int32_t y, uint32_t coordType )
+
+DBus::ValueOrError<Accessible*> BridgeComponent::GetAccessibleAtPoint(int32_t x, int32_t y, uint32_t coordType)
 {
-  return FindSelf()->GetAccessibleAtPoint( {x, y}, static_cast< CoordType >( coordType ) );
+  return FindSelf()->GetAccessibleAtPoint({x, y}, static_cast<CoordinateType>(coordType));
 }
-DBus::ValueOrError< std::tuple< int32_t, int32_t, int32_t, int32_t > > BridgeComponent::GetExtents( uint32_t coordType )
+
+DBus::ValueOrError<std::tuple<int32_t, int32_t, int32_t, int32_t> > BridgeComponent::GetExtents(uint32_t coordType)
 {
-  auto p = FindSelf()->GetExtents( static_cast< CoordType >( coordType ) );
-  return std::tuple< int32_t, int32_t, int32_t, int32_t >{p.x, p.y, p.width, p.height};
+  auto rect = FindSelf()->GetExtents(static_cast<CoordinateType>(coordType));
+
+  rect.x += mData->mExtentsOffset.first;
+  rect.y += mData->mExtentsOffset.second;
+
+  return std::tuple<int32_t, int32_t, int32_t, int32_t>{rect.x, rect.y, rect.width, rect.height};
 }
-DBus::ValueOrError< int32_t, int32_t > BridgeComponent::GetPosition( uint32_t coordType )
+
+DBus::ValueOrError<int32_t, int32_t> BridgeComponent::GetPosition(uint32_t coordType)
 {
-  auto p = FindSelf()->GetExtents( static_cast< CoordType >( coordType ) );
-  return { static_cast<int32_t>(p.x), static_cast<int32_t>(p.y) };
+  auto rect = FindSelf()->GetExtents(static_cast<CoordinateType>(coordType));
+
+  rect.x += mData->mExtentsOffset.first;
+  rect.y += mData->mExtentsOffset.second;
+
+  return {static_cast<int32_t>(rect.x), static_cast<int32_t>(rect.y)};
 }
-DBus::ValueOrError< int32_t, int32_t > BridgeComponent::GetSize( uint32_t coordType )
+
+DBus::ValueOrError<int32_t, int32_t> BridgeComponent::GetSize(uint32_t coordType)
 {
-  auto p = FindSelf()->GetExtents( static_cast< CoordType >( coordType ) );
-  return { static_cast<int32_t>(p.width), static_cast<int32_t>(p.height) };
+  auto rect = FindSelf()->GetExtents(static_cast<CoordinateType>(coordType));
+  return {static_cast<int32_t>(rect.width), static_cast<int32_t>(rect.height)};
 }
-DBus::ValueOrError< ComponentLayer > BridgeComponent::GetLayer()
+
+DBus::ValueOrError<ComponentLayer> BridgeComponent::GetLayer()
 {
   return FindSelf()->GetLayer();
 }
-DBus::ValueOrError< double > BridgeComponent::GetAlpha()
+
+DBus::ValueOrError<double> BridgeComponent::GetAlpha()
 {
   return FindSelf()->GetAlpha();
 }
-DBus::ValueOrError< bool > BridgeComponent::GrabFocus()
+
+DBus::ValueOrError<bool> BridgeComponent::GrabFocus()
 {
   return FindSelf()->GrabFocus();
 }
-DBus::ValueOrError< bool > BridgeComponent::GrabHighlight()
+
+DBus::ValueOrError<bool> BridgeComponent::GrabHighlight()
 {
   return FindSelf()->GrabHighlight();
 }
-DBus::ValueOrError< bool > BridgeComponent::ClearHighlight()
+
+DBus::ValueOrError<bool> BridgeComponent::ClearHighlight()
 {
   return FindSelf()->ClearHighlight();
 }
-DBus::ValueOrError< int16_t > BridgeComponent::GetMdiZOrder()
+
+DBus::ValueOrError<int16_t> BridgeComponent::GetMdiZOrder()
 {
   return FindSelf()->GetMdiZOrder();
 }