btrfs-progs: tests: refactor post-convert check helpers
[platform/upstream/btrfs-progs.git] / cmds-subvolume.c
index 9d9b0af..4cd2e0e 100644 (file)
@@ -127,9 +127,8 @@ static int cmd_subvol_create(int argc, char **argv)
        struct btrfs_qgroup_inherit *inherit = NULL;
        DIR     *dirstream = NULL;
 
-       optind = 1;
        while (1) {
-               int c = getopt(argc, argv, "c:i:v");
+               int c = getopt(argc, argv, "c:i:");
                if (c < 0)
                        break;
 
@@ -224,33 +223,6 @@ out:
        return retval;
 }
 
-/*
- * Test if path is a subvolume
- * Returns:
- *   0 - path exists but it is not a subvolume
- *   1 - path exists and it is  a subvolume
- * < 0 - error
- */
-int test_issubvolume(const char *path)
-{
-       struct stat     st;
-       struct statfs stfs;
-       int             res;
-
-       res = stat(path, &st);
-       if (res < 0)
-               return -errno;
-
-       if (st.st_ino != BTRFS_FIRST_FREE_OBJECTID || !S_ISDIR(st.st_mode))
-               return 0;
-
-       res = statfs(path, &stfs);
-       if (res < 0)
-               return -errno;
-
-       return (int)stfs.f_type == BTRFS_SUPER_MAGIC;
-}
-
 static int wait_for_commit(int fd)
 {
        int ret;
@@ -273,6 +245,7 @@ static const char * const cmd_subvol_delete_usage[] = {
        "",
        "-c|--commit-after      wait for transaction commit at the end of the operation",
        "-C|--commit-each       wait for transaction commit after deleting each subvolume",
+       "-v|--verbose           verbose output of operations",
        NULL
 };
 
@@ -290,16 +263,16 @@ static int cmd_subvol_delete(int argc, char **argv)
        int verbose = 0;
        int commit_mode = 0;
 
-       optind = 1;
        while (1) {
                int c;
                static const struct option long_options[] = {
                        {"commit-after", no_argument, NULL, 'c'},  /* commit mode 1 */
                        {"commit-each", no_argument, NULL, 'C'},  /* commit mode 2 */
+                       {"verbose", no_argument, NULL, 'v'},
                        {NULL, 0, NULL, 0}
                };
 
-               c = getopt_long(argc, argv, "cC", long_options, NULL);
+               c = getopt_long(argc, argv, "cCv", long_options, NULL);
                if (c < 0)
                        break;
 
@@ -458,15 +431,14 @@ static int cmd_subvol_list(int argc, char **argv)
        u64 top_id;
        int ret = -1, uerr = 0;
        char *subvol;
-       int is_tab_result = 0;
        int is_list_all = 0;
        int is_only_in_path = 0;
        DIR *dirstream = NULL;
+       enum btrfs_list_layout layout = BTRFS_LIST_LAYOUT_DEFAULT;
 
        filter_set = btrfs_list_alloc_filter_set();
        comparer_set = btrfs_list_alloc_comparer_set();
 
-       optind = 1;
        while(1) {
                int c;
                static const struct option long_options[] = {
@@ -501,7 +473,7 @@ static int cmd_subvol_list(int argc, char **argv)
                        is_only_in_path = 1;
                        break;
                case 't':
-                       is_tab_result = 1;
+                       layout = BTRFS_LIST_LAYOUT_TABLE;
                        break;
                case 's':
                        btrfs_list_setup_filter(&filter_set,
@@ -558,10 +530,6 @@ static int cmd_subvol_list(int argc, char **argv)
                }
        }
 
-       if (flags)
-               btrfs_list_setup_filter(&filter_set, BTRFS_LIST_FILTER_FLAGS,
-                                       flags);
-
        if (check_argc_exact(argc - optind, 1)) {
                uerr = 1;
                goto out;
@@ -575,11 +543,13 @@ static int cmd_subvol_list(int argc, char **argv)
                goto out;
        }
 
+       if (flags)
+               btrfs_list_setup_filter(&filter_set, BTRFS_LIST_FILTER_FLAGS,
+                                       flags);
+
        ret = btrfs_list_get_path_rootid(fd, &top_id);
-       if (ret) {
-               error("can't get rootid for '%s'", subvol);
+       if (ret)
                goto out;
-       }
 
        if (is_list_all)
                btrfs_list_setup_filter(&filter_set,
@@ -596,21 +566,15 @@ static int cmd_subvol_list(int argc, char **argv)
        btrfs_list_setup_print_column(BTRFS_LIST_TOP_LEVEL);
        btrfs_list_setup_print_column(BTRFS_LIST_PATH);
 
-       if (is_tab_result)
-               ret = btrfs_list_subvols_print(fd, filter_set, comparer_set,
-                               BTRFS_LIST_LAYOUT_TABLE,
-                               !is_list_all && !is_only_in_path, NULL);
-       else
-               ret = btrfs_list_subvols_print(fd, filter_set, comparer_set,
-                               BTRFS_LIST_LAYOUT_DEFAULT,
-                               !is_list_all && !is_only_in_path, NULL);
+       ret = btrfs_list_subvols_print(fd, filter_set, comparer_set,
+                       layout, !is_list_all && !is_only_in_path, NULL);
 
 out:
        close_file_or_dir(fd, dirstream);
        if (filter_set)
-               btrfs_list_free_filter_set(filter_set);
+               free(filter_set);
        if (comparer_set)
-               btrfs_list_free_comparer_set(comparer_set);
+               free(comparer_set);
        if (uerr)
                usage(cmd_subvol_list_usage);
        return !!ret;
@@ -643,7 +607,6 @@ static int cmd_subvol_snapshot(int argc, char **argv)
        struct btrfs_qgroup_inherit *inherit = NULL;
        DIR *dirstream1 = NULL, *dirstream2 = NULL;
 
-       optind = 1;
        memset(&args, 0, sizeof(args));
        while (1) {
                int c = getopt(argc, argv, "c:i:r");
@@ -788,7 +751,9 @@ static int cmd_subvol_get_default(int argc, char **argv)
        u64 default_id;
        DIR *dirstream = NULL;
 
-       if (check_argc_exact(argc, 2))
+       clean_args_no_options(argc, argv, cmd_subvol_get_default_usage);
+
+       if (check_argc_exact(argc - optind, 1))
                usage(cmd_subvol_get_default_usage);
 
        subvol = argv[1];
@@ -830,7 +795,7 @@ static int cmd_subvol_get_default(int argc, char **argv)
                BTRFS_LIST_LAYOUT_DEFAULT, 1, NULL);
 
        if (filter_set)
-               btrfs_list_free_filter_set(filter_set);
+               free(filter_set);
 out:
        close_file_or_dir(fd, dirstream);
        return !!ret;
@@ -850,11 +815,13 @@ static int cmd_subvol_set_default(int argc, char **argv)
        char    *subvolid;
        DIR     *dirstream = NULL;
 
-       if (check_argc_exact(argc, 3))
+       clean_args_no_options(argc, argv, cmd_subvol_set_default_usage);
+
+       if (check_argc_exact(argc - optind, 2))
                usage(cmd_subvol_set_default_usage);
 
-       subvolid = argv[1];
-       path = argv[2];
+       subvolid = argv[optind];
+       path = argv[optind + 1];
 
        objectid = arg_strtou64(subvolid);
 
@@ -887,11 +854,13 @@ static int cmd_subvol_find_new(int argc, char **argv)
        u64 last_gen;
        DIR *dirstream = NULL;
 
-       if (check_argc_exact(argc, 3))
+       clean_args_no_options(argc, argv, cmd_subvol_find_new_usage);
+
+       if (check_argc_exact(argc - optind, 2))
                usage(cmd_subvol_find_new_usage);
 
-       subvol = argv[1];
-       last_gen = arg_strtou64(argv[2]);
+       subvol = argv[optind];
+       last_gen = arg_strtou64(argv[optind + 1]);
 
        ret = test_issubvolume(subvol);
        if (ret < 0) {
@@ -929,21 +898,21 @@ static const char * const cmd_subvol_show_usage[] = {
 static int cmd_subvol_show(int argc, char **argv)
 {
        struct root_info get_ri;
-       struct btrfs_list_filter_set *filter_set;
+       struct btrfs_list_filter_set *filter_set = NULL;
        char tstr[256];
        char uuidparse[BTRFS_UUID_UNPARSED_SIZE];
-       char *fullpath = NULL, *svpath = NULL, *mnt = NULL;
+       char *fullpath = NULL;
        char raw_prefix[] = "\t\t\t\t";
-       u64 sv_id;
-       int fd = -1, mntfd = -1;
+       int fd = -1;
        int ret = 1;
-       DIR *dirstream1 = NULL, *dirstream2 = NULL;
+       DIR *dirstream1 = NULL;
 
        clean_args_no_options(argc, argv, cmd_subvol_show_usage);
 
        if (check_argc_exact(argc - optind, 1))
                usage(cmd_subvol_show_usage);
 
+       memset(&get_ri, 0, sizeof(get_ri));
        fullpath = realpath(argv[optind], NULL);
        if (!fullpath) {
                error("cannot find real path for '%s': %s",
@@ -951,57 +920,16 @@ static int cmd_subvol_show(int argc, char **argv)
                goto out;
        }
 
-       ret = test_issubvolume(fullpath);
-       if (ret < 0) {
-               error("cannot access subvolume %s: %s", fullpath,
-                       strerror(-ret));
-               goto out;
-       }
-       if (!ret) {
-               error("not a subvolume: %s", fullpath);
-               ret = 1;
-               goto out;
-       }
-
-       ret = find_mount_root(fullpath, &mnt);
-       if (ret < 0) {
-               error("find_mount_root failed on '%s': %s",
-                       fullpath, strerror(-ret));
-               goto out;
-       }
-       if (ret > 0) {
-               error("%s doesn't belong to btrfs mount point", fullpath);
-               goto out;
-       }
-       ret = 1;
-       svpath = get_subvol_name(mnt, fullpath);
-
-       fd = btrfs_open_dir(fullpath, &dirstream1, 1);
-       if (fd < 0)
-               goto out;
-
-       ret = btrfs_list_get_path_rootid(fd, &sv_id);
-       if (ret) {
-               error("can't get rootid for '%s'", fullpath);
-               goto out;
-       }
-
-       mntfd = btrfs_open_dir(mnt, &dirstream2, 1);
-       if (mntfd < 0)
-               goto out;
-
-       if (sv_id == BTRFS_FS_TREE_OBJECTID) {
-               printf("%s is toplevel subvolume\n", fullpath);
-               goto out;
-       }
-
-       memset(&get_ri, 0, sizeof(get_ri));
-       get_ri.root_id = sv_id;
-
-       ret = btrfs_get_subvol(mntfd, &get_ri);
+       ret = get_subvol_info(fullpath, &get_ri);
        if (ret) {
-               error("can't find '%s'", svpath);
-               goto out;
+               if (ret < 0) {
+                       error("Failed to get subvol info %s: %s\n",
+                                       fullpath, strerror(-ret));
+               } else {
+                       error("Failed to get subvol info %s: %d\n",
+                                       fullpath, ret);
+               }
+               return ret;
        }
 
        /* print the info */
@@ -1052,19 +980,23 @@ static int cmd_subvol_show(int argc, char **argv)
        btrfs_list_setup_filter(&filter_set, BTRFS_LIST_FILTER_BY_PARENT,
                                (u64)(unsigned long)get_ri.uuid);
        btrfs_list_setup_print_column(BTRFS_LIST_PATH);
+
+       fd = open_file_or_dir(fullpath, &dirstream1);
+       if (fd < 0) {
+               fprintf(stderr, "ERROR: can't access '%s'\n", fullpath);
+               goto out;
+       }
        btrfs_list_subvols_print(fd, filter_set, NULL, BTRFS_LIST_LAYOUT_RAW,
                        1, raw_prefix);
 
+out:
        /* clean up */
        free(get_ri.path);
        free(get_ri.name);
        free(get_ri.full_path);
-       btrfs_list_free_filter_set(filter_set);
+       free(filter_set);
 
-out:
        close_file_or_dir(fd, dirstream1);
-       close_file_or_dir(mntfd, dirstream2);
-       free(mnt);
        free(fullpath);
        return !!ret;
 }
@@ -1193,24 +1125,26 @@ static int enumerate_dead_subvols(int fd, u64 **ids)
                        sh = (struct btrfs_ioctl_search_header*)(args.buf + off);
                        off += sizeof(*sh);
 
-                       if (sh->type == BTRFS_ORPHAN_ITEM_KEY) {
+                       if (btrfs_search_header_type(sh)
+                           == BTRFS_ORPHAN_ITEM_KEY) {
                                if (idx >= count) {
                                        u64 *newids;
 
                                        count += SUBVOL_ID_BATCH;
-                                       newids = (u64*)realloc(*ids, count);
+                                       newids = (u64*)realloc(*ids,
+                                                       count * sizeof(u64));
                                        if (!newids)
                                                return -ENOMEM;
                                        *ids = newids;
                                }
-                               (*ids)[idx] = sh->offset;
+                               (*ids)[idx] = btrfs_search_header_offset(sh);
                                idx++;
                        }
-                       off += sh->len;
+                       off += btrfs_search_header_len(sh);
 
-                       sk->min_objectid = sh->objectid;
-                       sk->min_type = sh->type;
-                       sk->min_offset = sh->offset;
+                       sk->min_objectid = btrfs_search_header_objectid(sh);
+                       sk->min_type = btrfs_search_header_type(sh);
+                       sk->min_offset = btrfs_search_header_offset(sh);
                }
                if (sk->min_offset < (u64)-1)
                        sk->min_offset++;
@@ -1235,7 +1169,6 @@ static int cmd_subvol_sync(int argc, char **argv)
        int id_count;
        int sleep_interval = 1;
 
-       optind = 1;
        while (1) {
                int c = getopt(argc, argv, "s:");
 
@@ -1244,10 +1177,9 @@ static int cmd_subvol_sync(int argc, char **argv)
 
                switch (c) {
                case 's':
-                       sleep_interval = atoi(argv[optind]);
+                       sleep_interval = atoi(optarg);
                        if (sleep_interval < 1) {
-                               error("invalid sleep interval %s",
-                                       argv[optind]);
+                               error("invalid sleep interval %s", optarg);
                                ret = 1;
                                goto out;
                        }