btrfs-progs: check: introduce function to check dir_item
[platform/upstream/btrfs-progs.git] / cmds-check.c
index cf58f95..dd8926d 100644 (file)
@@ -41,6 +41,7 @@
 #include "rbtree-utils.h"
 #include "backref.h"
 #include "ulist.h"
+#include "hash.h"
 
 enum task_position {
        TASK_EXTENTS,
@@ -3826,6 +3827,572 @@ out:
        return err;
 }
 
+#define ROOT_DIR_ERROR         (1<<1)  /* bad ROOT_DIR */
+#define DIR_ITEM_MISSING       (1<<2)  /* DIR_ITEM not found */
+#define DIR_ITEM_MISMATCH      (1<<3)  /* DIR_ITEM found but not match */
+#define INODE_REF_MISSING      (1<<4)  /* INODE_REF/INODE_EXTREF not found */
+#define INODE_ITEM_MISSING     (1<<5)  /* INODE_ITEM not found */
+#define INODE_ITEM_MISMATCH    (1<<6)  /* INODE_ITEM found but not match */
+
+/*
+ * Find DIR_ITEM/DIR_INDEX for the given key and check it with the specified
+ * INODE_REF/INODE_EXTREF match.
+ *
+ * @root:      the root of the fs/file tree
+ * @ref_key:   the key of the INODE_REF/INODE_EXTREF
+ * @key:       the key of the DIR_ITEM/DIR_INDEX
+ * @index:     the index in the INODE_REF/INODE_EXTREF, be used to
+ *             distinguish root_dir between normal dir/file
+ * @name:      the name in the INODE_REF/INODE_EXTREF
+ * @namelen:   the length of name in the INODE_REF/INODE_EXTREF
+ * @mode:      the st_mode of INODE_ITEM
+ *
+ * Return 0 if no error occurred.
+ * Return ROOT_DIR_ERROR if found DIR_ITEM/DIR_INDEX for root_dir.
+ * Return DIR_ITEM_MISSING if couldn't find DIR_ITEM/DIR_INDEX for normal
+ * dir/file.
+ * Return DIR_ITEM_MISMATCH if INODE_REF/INODE_EXTREF and DIR_ITEM/DIR_INDEX
+ * not match for normal dir/file.
+ */
+static int find_dir_item(struct btrfs_root *root, struct btrfs_key *ref_key,
+                        struct btrfs_key *key, u64 index, char *name,
+                        u32 namelen, u32 mode)
+{
+       struct btrfs_path path;
+       struct extent_buffer *node;
+       struct btrfs_dir_item *di;
+       struct btrfs_key location;
+       char namebuf[BTRFS_NAME_LEN] = {0};
+       u32 total;
+       u32 cur = 0;
+       u32 len;
+       u32 name_len;
+       u32 data_len;
+       u8 filetype;
+       int slot;
+       int ret;
+
+       btrfs_init_path(&path);
+       ret = btrfs_search_slot(NULL, root, key, &path, 0, 0);
+       if (ret < 0) {
+               ret = DIR_ITEM_MISSING;
+               goto out;
+       }
+
+       /* Process root dir and goto out*/
+       if (index == 0) {
+               if (ret == 0) {
+                       ret = ROOT_DIR_ERROR;
+                       error(
+                       "root %llu INODE %s[%llu %llu] ROOT_DIR shouldn't have %s",
+                               root->objectid,
+                               ref_key->type == BTRFS_INODE_REF_KEY ?
+                                       "REF" : "EXTREF",
+                               ref_key->objectid, ref_key->offset,
+                               key->type == BTRFS_DIR_ITEM_KEY ?
+                                       "DIR_ITEM" : "DIR_INDEX");
+               } else {
+                       ret = 0;
+               }
+
+               goto out;
+       }
+
+       /* Process normal file/dir */
+       if (ret > 0) {
+               ret = DIR_ITEM_MISSING;
+               error(
+               "root %llu INODE %s[%llu %llu] doesn't have related %s[%llu %llu] namelen %u filename %s filetype %d",
+                       root->objectid,
+                       ref_key->type == BTRFS_INODE_REF_KEY ? "REF" : "EXTREF",
+                       ref_key->objectid, ref_key->offset,
+                       key->type == BTRFS_DIR_ITEM_KEY ?
+                               "DIR_ITEM" : "DIR_INDEX",
+                       key->objectid, key->offset, namelen, name,
+                       imode_to_type(mode));
+               goto out;
+       }
+
+       /* Check whether inode_id/filetype/name match */
+       node = path.nodes[0];
+       slot = path.slots[0];
+       di = btrfs_item_ptr(node, slot, struct btrfs_dir_item);
+       total = btrfs_item_size_nr(node, slot);
+       while (cur < total) {
+               ret = DIR_ITEM_MISMATCH;
+               name_len = btrfs_dir_name_len(node, di);
+               data_len = btrfs_dir_data_len(node, di);
+
+               btrfs_dir_item_key_to_cpu(node, di, &location);
+               if (location.objectid != ref_key->objectid ||
+                   location.type !=  BTRFS_INODE_ITEM_KEY ||
+                   location.offset != 0)
+                       goto next;
+
+               filetype = btrfs_dir_type(node, di);
+               if (imode_to_type(mode) != filetype)
+                       goto next;
+
+               if (name_len <= BTRFS_NAME_LEN) {
+                       len = name_len;
+               } else {
+                       len = BTRFS_NAME_LEN;
+                       warning("root %llu %s[%llu %llu] name too long %u, trimmed",
+                       root->objectid,
+                       key->type == BTRFS_DIR_ITEM_KEY ?
+                       "DIR_ITEM" : "DIR_INDEX",
+                       key->objectid, key->offset, name_len);
+               }
+               read_extent_buffer(node, namebuf, (unsigned long)(di + 1), len);
+               if (len != namelen || strncmp(namebuf, name, len))
+                       goto next;
+
+               ret = 0;
+               goto out;
+next:
+               len = sizeof(*di) + name_len + data_len;
+               di = (struct btrfs_dir_item *)((char *)di + len);
+               cur += len;
+       }
+       if (ret == DIR_ITEM_MISMATCH)
+               error(
+               "root %llu INODE %s[%llu %llu] and %s[%llu %llu] mismatch namelen %u filename %s filetype %d",
+                       root->objectid,
+                       ref_key->type == BTRFS_INODE_REF_KEY ? "REF" : "EXTREF",
+                       ref_key->objectid, ref_key->offset,
+                       key->type == BTRFS_DIR_ITEM_KEY ?
+                               "DIR_ITEM" : "DIR_INDEX",
+                       key->objectid, key->offset, namelen, name,
+                       imode_to_type(mode));
+out:
+       btrfs_release_path(&path);
+       return ret;
+}
+
+/*
+ * Traverse the given INODE_REF and call find_dir_item() to find related
+ * DIR_ITEM/DIR_INDEX.
+ *
+ * @root:      the root of the fs/file tree
+ * @ref_key:   the key of the INODE_REF
+ * @refs:      the count of INODE_REF
+ * @mode:      the st_mode of INODE_ITEM
+ *
+ * Return 0 if no error occurred.
+ */
+static int check_inode_ref(struct btrfs_root *root, struct btrfs_key *ref_key,
+                          struct extent_buffer *node, int slot, u64 *refs,
+                          int mode)
+{
+       struct btrfs_key key;
+       struct btrfs_inode_ref *ref;
+       char namebuf[BTRFS_NAME_LEN] = {0};
+       u32 total;
+       u32 cur = 0;
+       u32 len;
+       u32 name_len;
+       u64 index;
+       int ret, err = 0;
+
+       ref = btrfs_item_ptr(node, slot, struct btrfs_inode_ref);
+       total = btrfs_item_size_nr(node, slot);
+
+next:
+       /* Update inode ref count */
+       (*refs)++;
+
+       index = btrfs_inode_ref_index(node, ref);
+       name_len = btrfs_inode_ref_name_len(node, ref);
+       if (name_len <= BTRFS_NAME_LEN) {
+               len = name_len;
+       } else {
+               len = BTRFS_NAME_LEN;
+               warning("root %llu INODE_REF[%llu %llu] name too long",
+                       root->objectid, ref_key->objectid, ref_key->offset);
+       }
+
+       read_extent_buffer(node, namebuf, (unsigned long)(ref + 1), len);
+
+       /* Check root dir ref name */
+       if (index == 0 && strncmp(namebuf, "..", name_len)) {
+               error("root %llu INODE_REF[%llu %llu] ROOT_DIR name shouldn't be %s",
+                     root->objectid, ref_key->objectid, ref_key->offset,
+                     namebuf);
+               err |= ROOT_DIR_ERROR;
+       }
+
+       /* Find related DIR_INDEX */
+       key.objectid = ref_key->offset;
+       key.type = BTRFS_DIR_INDEX_KEY;
+       key.offset = index;
+       ret = find_dir_item(root, ref_key, &key, index, namebuf, len, mode);
+       err |= ret;
+
+       /* Find related dir_item */
+       key.objectid = ref_key->offset;
+       key.type = BTRFS_DIR_ITEM_KEY;
+       key.offset = btrfs_name_hash(namebuf, len);
+       ret = find_dir_item(root, ref_key, &key, index, namebuf, len, mode);
+       err |= ret;
+
+       len = sizeof(*ref) + name_len;
+       ref = (struct btrfs_inode_ref *)((char *)ref + len);
+       cur += len;
+       if (cur < total)
+               goto next;
+
+       return err;
+}
+
+/*
+ * Traverse the given INODE_EXTREF and call find_dir_item() to find related
+ * DIR_ITEM/DIR_INDEX.
+ *
+ * @root:      the root of the fs/file tree
+ * @ref_key:   the key of the INODE_EXTREF
+ * @refs:      the count of INODE_EXTREF
+ * @mode:      the st_mode of INODE_ITEM
+ *
+ * Return 0 if no error occurred.
+ */
+static int check_inode_extref(struct btrfs_root *root,
+                             struct btrfs_key *ref_key,
+                             struct extent_buffer *node, int slot, u64 *refs,
+                             int mode)
+{
+       struct btrfs_key key;
+       struct btrfs_inode_extref *extref;
+       char namebuf[BTRFS_NAME_LEN] = {0};
+       u32 total;
+       u32 cur = 0;
+       u32 len;
+       u32 name_len;
+       u64 index;
+       u64 parent;
+       int ret;
+       int err = 0;
+
+       extref = btrfs_item_ptr(node, slot, struct btrfs_inode_extref);
+       total = btrfs_item_size_nr(node, slot);
+
+next:
+       /* update inode ref count */
+       (*refs)++;
+       name_len = btrfs_inode_extref_name_len(node, extref);
+       index = btrfs_inode_extref_index(node, extref);
+       parent = btrfs_inode_extref_parent(node, extref);
+       if (name_len <= BTRFS_NAME_LEN) {
+               len = name_len;
+       } else {
+               len = BTRFS_NAME_LEN;
+               warning("root %llu INODE_EXTREF[%llu %llu] name too long",
+                       root->objectid, ref_key->objectid, ref_key->offset);
+       }
+       read_extent_buffer(node, namebuf, (unsigned long)(extref + 1), len);
+
+       /* Check root dir ref name */
+       if (index == 0 && strncmp(namebuf, "..", name_len)) {
+               error("root %llu INODE_EXTREF[%llu %llu] ROOT_DIR name shouldn't be %s",
+                     root->objectid, ref_key->objectid, ref_key->offset,
+                     namebuf);
+               err |= ROOT_DIR_ERROR;
+       }
+
+       /* find related dir_index */
+       key.objectid = parent;
+       key.type = BTRFS_DIR_INDEX_KEY;
+       key.offset = index;
+       ret = find_dir_item(root, ref_key, &key, index, namebuf, len, mode);
+       err |= ret;
+
+       /* find related dir_item */
+       key.objectid = parent;
+       key.type = BTRFS_DIR_ITEM_KEY;
+       key.offset = btrfs_name_hash(namebuf, len);
+       ret = find_dir_item(root, ref_key, &key, index, namebuf, len, mode);
+       err |= ret;
+
+       len = sizeof(*extref) + name_len;
+       extref = (struct btrfs_inode_extref *)((char *)extref + len);
+       cur += len;
+
+       if (cur < total)
+               goto next;
+
+       return err;
+}
+
+/*
+ * Find INODE_REF/INODE_EXTREF for the given key and check it with the specified
+ * DIR_ITEM/DIR_INDEX match.
+ *
+ * @root:      the root of the fs/file tree
+ * @key:       the key of the INODE_REF/INODE_EXTREF
+ * @name:      the name in the INODE_REF/INODE_EXTREF
+ * @namelen:   the length of name in the INODE_REF/INODE_EXTREF
+ * @index:     the index in the INODE_REF/INODE_EXTREF, for DIR_ITEM set index
+ * to (u64)-1
+ * @ext_ref:   the EXTENDED_IREF feature
+ *
+ * Return 0 if no error occurred.
+ * Return >0 for error bitmap
+ */
+static int find_inode_ref(struct btrfs_root *root, struct btrfs_key *key,
+                         char *name, int namelen, u64 index,
+                         unsigned int ext_ref)
+{
+       struct btrfs_path path;
+       struct btrfs_inode_ref *ref;
+       struct btrfs_inode_extref *extref;
+       struct extent_buffer *node;
+       char ref_namebuf[BTRFS_NAME_LEN] = {0};
+       u32 total;
+       u32 cur = 0;
+       u32 len;
+       u32 ref_namelen;
+       u64 ref_index;
+       u64 parent;
+       u64 dir_id;
+       int slot;
+       int ret;
+
+       btrfs_init_path(&path);
+       ret = btrfs_search_slot(NULL, root, key, &path, 0, 0);
+       if (ret) {
+               ret = INODE_REF_MISSING;
+               goto extref;
+       }
+
+       node = path.nodes[0];
+       slot = path.slots[0];
+
+       ref = btrfs_item_ptr(node, slot, struct btrfs_inode_ref);
+       total = btrfs_item_size_nr(node, slot);
+
+       /* Iterate all entry of INODE_REF */
+       while (cur < total) {
+               ret = INODE_REF_MISSING;
+
+               ref_namelen = btrfs_inode_ref_name_len(node, ref);
+               ref_index = btrfs_inode_ref_index(node, ref);
+               if (index != (u64)-1 && index != ref_index)
+                       goto next_ref;
+
+               if (ref_namelen <= BTRFS_NAME_LEN) {
+                       len = ref_namelen;
+               } else {
+                       len = BTRFS_NAME_LEN;
+                       warning("root %llu INODE %s[%llu %llu] name too long",
+                               root->objectid,
+                               key->type == BTRFS_INODE_REF_KEY ?
+                                       "REF" : "EXTREF",
+                               key->objectid, key->offset);
+               }
+               read_extent_buffer(node, ref_namebuf, (unsigned long)(ref + 1),
+                                  len);
+
+               if (len != namelen || strncmp(ref_namebuf, name, len))
+                       goto next_ref;
+
+               ret = 0;
+               goto out;
+next_ref:
+               len = sizeof(*ref) + ref_namelen;
+               ref = (struct btrfs_inode_ref *)((char *)ref + len);
+               cur += len;
+       }
+
+extref:
+       /* Skip if not support EXTENDED_IREF feature */
+       if (!ext_ref)
+               goto out;
+
+       btrfs_release_path(&path);
+       btrfs_init_path(&path);
+
+       dir_id = key->offset;
+       key->type = BTRFS_INODE_EXTREF_KEY;
+       key->offset = btrfs_extref_hash(dir_id, name, namelen);
+
+       ret = btrfs_search_slot(NULL, root, key, &path, 0, 0);
+       if (ret) {
+               ret = INODE_REF_MISSING;
+               goto out;
+       }
+
+       node = path.nodes[0];
+       slot = path.slots[0];
+
+       extref = btrfs_item_ptr(node, slot, struct btrfs_inode_extref);
+       cur = 0;
+       total = btrfs_item_size_nr(node, slot);
+
+       /* Iterate all entry of INODE_EXTREF */
+       while (cur < total) {
+               ret = INODE_REF_MISSING;
+
+               ref_namelen = btrfs_inode_extref_name_len(node, extref);
+               ref_index = btrfs_inode_extref_index(node, extref);
+               parent = btrfs_inode_extref_parent(node, extref);
+               if (index != (u64)-1 && index != ref_index)
+                       goto next_extref;
+
+               if (parent != dir_id)
+                       goto next_extref;
+
+               if (ref_namelen <= BTRFS_NAME_LEN) {
+                       len = ref_namelen;
+               } else {
+                       len = BTRFS_NAME_LEN;
+                       warning("Warning: root %llu INODE %s[%llu %llu] name too long\n",
+                               root->objectid,
+                               key->type == BTRFS_INODE_REF_KEY ?
+                                       "REF" : "EXTREF",
+                               key->objectid, key->offset);
+               }
+               read_extent_buffer(node, ref_namebuf,
+                                  (unsigned long)(extref + 1), len);
+
+               if (len != namelen || strncmp(ref_namebuf, name, len))
+                       goto next_extref;
+
+               ret = 0;
+               goto out;
+
+next_extref:
+               len = sizeof(*extref) + ref_namelen;
+               extref = (struct btrfs_inode_extref *)((char *)extref + len);
+               cur += len;
+
+       }
+out:
+       btrfs_release_path(&path);
+       return ret;
+}
+
+/*
+ * Traverse the given DIR_ITEM/DIR_INDEX and check related INODE_ITEM and
+ * call find_inode_ref() to check related INODE_REF/INODE_EXTREF.
+ *
+ * @root:      the root of the fs/file tree
+ * @key:       the key of the INODE_REF/INODE_EXTREF
+ * @size:      the st_size of the INODE_ITEM
+ * @ext_ref:   the EXTENDED_IREF feature
+ *
+ * Return 0 if no error occurred.
+ */
+static int check_dir_item(struct btrfs_root *root, struct btrfs_key *key,
+                         struct extent_buffer *node, int slot, u64 *size,
+                         unsigned int ext_ref)
+{
+       struct btrfs_dir_item *di;
+       struct btrfs_inode_item *ii;
+       struct btrfs_path path;
+       struct btrfs_key location;
+       char namebuf[BTRFS_NAME_LEN] = {0};
+       u32 total;
+       u32 cur = 0;
+       u32 len;
+       u32 name_len;
+       u32 data_len;
+       u8 filetype;
+       u32 mode;
+       u64 index;
+       int ret;
+       int err = 0;
+
+       /*
+        * For DIR_ITEM set index to (u64)-1, so that find_inode_ref
+        * ignore index check.
+        */
+       index = (key->type == BTRFS_DIR_INDEX_KEY) ? key->offset : (u64)-1;
+
+       di = btrfs_item_ptr(node, slot, struct btrfs_dir_item);
+       total = btrfs_item_size_nr(node, slot);
+
+       while (cur < total) {
+               data_len = btrfs_dir_data_len(node, di);
+               if (data_len)
+                       error("root %llu %s[%llu %llu] data_len shouldn't be %u",
+                             root->objectid, key->type == BTRFS_DIR_ITEM_KEY ?
+                             "DIR_ITEM" : "DIR_INDEX",
+                             key->objectid, key->offset, data_len);
+
+               name_len = btrfs_dir_name_len(node, di);
+               if (name_len <= BTRFS_NAME_LEN) {
+                       len = name_len;
+               } else {
+                       len = BTRFS_NAME_LEN;
+                       warning("root %llu %s[%llu %llu] name too long",
+                               root->objectid,
+                               key->type == BTRFS_DIR_ITEM_KEY ?
+                               "DIR_ITEM" : "DIR_INDEX",
+                               key->objectid, key->offset);
+               }
+               (*size) += name_len;
+
+               read_extent_buffer(node, namebuf, (unsigned long)(di + 1), len);
+               filetype = btrfs_dir_type(node, di);
+
+               btrfs_init_path(&path);
+               btrfs_dir_item_key_to_cpu(node, di, &location);
+
+               /* Ignore related ROOT_ITEM check */
+               if (location.type == BTRFS_ROOT_ITEM_KEY)
+                       goto next;
+
+               /* Check relative INODE_ITEM(existence/filetype) */
+               ret = btrfs_search_slot(NULL, root, &location, &path, 0, 0);
+               if (ret) {
+                       err |= INODE_ITEM_MISSING;
+                       error("root %llu %s[%llu %llu] couldn't find relative INODE_ITEM[%llu] namelen %u filename %s filetype %x",
+                             root->objectid, key->type == BTRFS_DIR_ITEM_KEY ?
+                             "DIR_ITEM" : "DIR_INDEX", key->objectid,
+                             key->offset, location.objectid, name_len,
+                             namebuf, filetype);
+                       goto next;
+               }
+
+               ii = btrfs_item_ptr(path.nodes[0], path.slots[0],
+                                   struct btrfs_inode_item);
+               mode = btrfs_inode_mode(path.nodes[0], ii);
+
+               if (imode_to_type(mode) != filetype) {
+                       err |= INODE_ITEM_MISMATCH;
+                       error("root %llu %s[%llu %llu] relative INODE_ITEM filetype mismatch namelen %u filename %s filetype %d",
+                             root->objectid, key->type == BTRFS_DIR_ITEM_KEY ?
+                             "DIR_ITEM" : "DIR_INDEX", key->objectid,
+                             key->offset, name_len, namebuf, filetype);
+               }
+
+               /* Check relative INODE_REF/INODE_EXTREF */
+               location.type = BTRFS_INODE_REF_KEY;
+               location.offset = key->objectid;
+               ret = find_inode_ref(root, &location, namebuf, len,
+                                      index, ext_ref);
+               err |= ret;
+               if (ret & INODE_REF_MISSING)
+                       error("root %llu %s[%llu %llu] relative INODE_REF missing namelen %u filename %s filetype %d",
+                             root->objectid, key->type == BTRFS_DIR_ITEM_KEY ?
+                             "DIR_ITEM" : "DIR_INDEX", key->objectid,
+                             key->offset, name_len, namebuf, filetype);
+
+next:
+               btrfs_release_path(&path);
+               len = sizeof(*di) + name_len + data_len;
+               di = (struct btrfs_dir_item *)((char *)di + len);
+               cur += len;
+
+               if (key->type == BTRFS_DIR_INDEX_KEY && cur < total) {
+                       error("root %llu DIR_INDEX[%llu %llu] should contain only one entry",
+                             root->objectid, key->objectid, key->offset);
+                       break;
+               }
+       }
+
+       return err;
+}
+
 static int all_backpointers_checked(struct extent_record *rec, int print_errs)
 {
        struct list_head *cur = rec->backrefs.next;
@@ -6670,7 +7237,6 @@ static int record_extent(struct btrfs_trans_handle *trans,
        struct extent_buffer *leaf;
        struct btrfs_key ins_key;
        struct btrfs_extent_item *ei;
-       struct tree_backref *tback;
        struct data_backref *dback;
        struct btrfs_tree_block_info *bi;
 
@@ -6706,7 +7272,6 @@ static int record_extent(struct btrfs_trans_handle *trans,
                } else {
                        struct btrfs_disk_key copy_key;;
 
-                       tback = to_tree_backref(back);
                        bi = (struct btrfs_tree_block_info *)(ei + 1);
                        memset_extent_buffer(leaf, 0, (unsigned long)bi,
                                             sizeof(*bi));
@@ -6772,6 +7337,7 @@ static int record_extent(struct btrfs_trans_handle *trans,
                                dback->found_ref);
        } else {
                u64 parent;
+               struct tree_backref *tback;
 
                tback = to_tree_backref(back);
                if (back->full_backref)
@@ -6809,11 +7375,6 @@ static struct extent_entry *find_most_right_entry(struct list_head *entries)
        struct extent_entry *entry, *best = NULL, *prev = NULL;
 
        list_for_each_entry(entry, entries, list) {
-               if (!prev) {
-                       prev = entry;
-                       continue;
-               }
-
                /*
                 * If there are as many broken entries as entries then we know
                 * not to trust this particular entry.
@@ -6822,6 +7383,16 @@ static struct extent_entry *find_most_right_entry(struct list_head *entries)
                        continue;
 
                /*
+                * Special case, when there are only two entries and 'best' is
+                * the first one
+                */
+               if (!prev) {
+                       best = entry;
+                       prev = entry;
+                       continue;
+               }
+
+               /*
                 * If our current entry == best then we can't be sure our best
                 * is really the best, so we need to keep searching.
                 */
@@ -11020,7 +11591,7 @@ static int maybe_repair_root_item(struct btrfs_fs_info *info,
  */
 static int repair_root_items(struct btrfs_fs_info *info)
 {
-       struct btrfs_path *path = NULL;
+       struct btrfs_path path;
        struct btrfs_key key;
        struct extent_buffer *leaf;
        struct btrfs_trans_handle *trans = NULL;
@@ -11028,16 +11599,12 @@ static int repair_root_items(struct btrfs_fs_info *info)
        int bad_roots = 0;
        int need_trans = 0;
 
+       btrfs_init_path(&path);
+
        ret = build_roots_info_cache(info);
        if (ret)
                goto out;
 
-       path = btrfs_alloc_path();
-       if (!path) {
-               ret = -ENOMEM;
-               goto out;
-       }
-
        key.objectid = BTRFS_FIRST_FREE_OBJECTID;
        key.type = BTRFS_ROOT_ITEM_KEY;
        key.offset = 0;
@@ -11056,19 +11623,19 @@ again:
                }
        }
 
-       ret = btrfs_search_slot(trans, info->tree_root, &key, path,
+       ret = btrfs_search_slot(trans, info->tree_root, &key, &path,
                                0, trans ? 1 : 0);
        if (ret < 0)
                goto out;
-       leaf = path->nodes[0];
+       leaf = path.nodes[0];
 
        while (1) {
                struct btrfs_key found_key;
 
-               if (path->slots[0] >= btrfs_header_nritems(leaf)) {
-                       int no_more_keys = find_next_key(path, &key);
+               if (path.slots[0] >= btrfs_header_nritems(leaf)) {
+                       int no_more_keys = find_next_key(&path, &key);
 
-                       btrfs_release_path(path);
+                       btrfs_release_path(&path);
                        if (trans) {
                                ret = btrfs_commit_transaction(trans,
                                                               info->tree_root);
@@ -11082,14 +11649,14 @@ again:
                        goto again;
                }
 
-               btrfs_item_key_to_cpu(leaf, &found_key, path->slots[0]);
+               btrfs_item_key_to_cpu(leaf, &found_key, path.slots[0]);
 
                if (found_key.type != BTRFS_ROOT_ITEM_KEY)
                        goto next;
                if (found_key.objectid == BTRFS_TREE_RELOC_OBJECTID)
                        goto next;
 
-               ret = maybe_repair_root_item(info, path, &found_key,
+               ret = maybe_repair_root_item(info, &path, &found_key,
                                             trans ? 0 : 1);
                if (ret < 0)
                        goto out;
@@ -11097,18 +11664,18 @@ again:
                        if (!trans && repair) {
                                need_trans = 1;
                                key = found_key;
-                               btrfs_release_path(path);
+                               btrfs_release_path(&path);
                                goto again;
                        }
                        bad_roots++;
                }
 next:
-               path->slots[0]++;
+               path.slots[0]++;
        }
        ret = 0;
 out:
        free_roots_info_cache();
-       btrfs_free_path(path);
+       btrfs_release_path(&path);
        if (trans)
                btrfs_commit_transaction(trans, info->tree_root);
        if (ret < 0)
@@ -11175,7 +11742,6 @@ const char * const cmd_check_usage[] = {
        "--chunk-root <bytenr>       use the given bytenr for the chunk tree root",
        "-p|--progress               indicate progress",
        "--clear-space-cache v1|v2   clear space cache for v1 or v2",
-       "                            NOTE: v1 support implemented",
        NULL
 };
 
@@ -11297,13 +11863,16 @@ int cmd_check(int argc, char **argv)
                                }
                                break;
                        case GETOPT_VAL_CLEAR_SPACE_CACHE:
-                               if (strcmp(optarg, "v1") != 0) {
+                               if (strcmp(optarg, "v1") == 0) {
+                                       clear_space_cache = 1;
+                               } else if (strcmp(optarg, "v2") == 0) {
+                                       clear_space_cache = 2;
+                                       ctree_flags |= OPEN_CTREE_INVALIDATE_FST;
+                               } else {
                                        error(
-                       "only v1 support implmented, unrecognized value %s",
-                       optarg);
+               "invalid argument to --clear-space-cache, must be v1 or v2");
                                        exit(1);
                                }
-                               clear_space_cache = 1;
                                ctree_flags |= OPEN_CTREE_WRITES;
                                break;
                }
@@ -11357,11 +11926,11 @@ int cmd_check(int argc, char **argv)
 
        global_info = info;
        root = info->fs_root;
-       if (clear_space_cache) {
+       if (clear_space_cache == 1) {
                if (btrfs_fs_compat_ro(info,
                                BTRFS_FEATURE_COMPAT_RO_FREE_SPACE_TREE)) {
                        error(
-                       "free space cache v2 detected, clearing not implemented");
+               "free space cache v2 detected, use --clear-space-cache v2");
                        ret = 1;
                        goto close_out;
                }
@@ -11374,6 +11943,22 @@ int cmd_check(int argc, char **argv)
                        printf("Free space cache cleared\n");
                }
                goto close_out;
+       } else if (clear_space_cache == 2) {
+               if (!btrfs_fs_compat_ro(info,
+                                       BTRFS_FEATURE_COMPAT_RO_FREE_SPACE_TREE)) {
+                       printf("no free space cache v2 to clear\n");
+                       ret = 0;
+                       goto close_out;
+               }
+               printf("Clear free space cache v2\n");
+               ret = btrfs_clear_free_space_tree(info);
+               if (ret) {
+                       error("failed to clear free space cache v2: %d", ret);
+                       ret = 1;
+               } else {
+                       printf("free space cache v2 cleared\n");
+               }
+               goto close_out;
        }
 
        /*
@@ -11472,13 +12057,14 @@ int cmd_check(int argc, char **argv)
        }
 
        if (!ctx.progress_enabled)
-               printf("checking extents");
+               fprintf(stderr, "checking extents\n");
        if (check_mode == CHECK_MODE_LOWMEM)
                ret = check_chunks_and_extents_v2(root);
        else
                ret = check_chunks_and_extents(root);
        if (ret)
-               printf("Errors found in extent allocation tree or chunk allocation");
+               error(
+               "errors found in extent allocation tree or chunk allocation");
 
        ret = repair_root_items(info);
        if (ret < 0)