Remove net-config dependency
[platform/upstream/connman.git] / client / commands.c
old mode 100644 (file)
new mode 100755 (executable)
index ce82791..dab6209
 #include "dbus_helpers.h"
 #include "input.h"
 #include "services.h"
+#if defined TIZEN_EXT_INS
+#include "ins.h"
+#endif
+#include "tethering.h"
 #include "peers.h"
 #include "commands.h"
 #include "agent.h"
@@ -144,7 +148,7 @@ static int parse_args(char *arg, struct connman_option *options)
        return '?';
 }
 
-static int enable_return(DBusMessageIter *iter, const char *error,
+static int enable_return(DBusMessageIter *iter, int errnum, const char *error,
                void *user_data)
 {
        char *tech = user_data;
@@ -156,10 +160,19 @@ static int enable_return(DBusMessageIter *iter, const char *error,
        else
                str = tech;
 
-       if (!error)
+       switch (errnum) {
+       case 0:
                fprintf(stdout, "Enabled %s\n", str);
-       else
+               break;
+       case -ENODEV:
+               fprintf(stderr, "%s is not available\n", str);
+               break;
+       case -EALREADY:
+               fprintf(stderr, "%s is already enabled\n", str);
+               break;
+       default:
                fprintf(stderr, "Error %s: %s\n", str, error);
+       }
 
        g_free(user_data);
 
@@ -193,7 +206,7 @@ static int cmd_enable(char *args[], int num, struct connman_option *options)
                                "Powered", DBUS_TYPE_BOOLEAN, &b);
 }
 
-static int disable_return(DBusMessageIter *iter, const char *error,
+static int disable_return(DBusMessageIter *iter, int errnum, const char *error,
                void *user_data)
 {
        char *tech = user_data;
@@ -205,10 +218,19 @@ static int disable_return(DBusMessageIter *iter, const char *error,
        else
                str = tech;
 
-       if (!error)
-               fprintf(stdout, "Disabled %s\n", str);
-       else
+       switch (errnum) {
+       case 0:
+               fprintf(stdout, "Disable %s\n", str);
+               break;
+       case -ENODEV:
+               fprintf(stderr, "%s is not available\n", str);
+               break;
+       case -EALREADY:
+               fprintf(stderr, "%s is already disabled\n", str);
+               break;
+       default:
                fprintf(stderr, "Error %s: %s\n", str, error);
+       }
 
        g_free(user_data);
 
@@ -242,13 +264,13 @@ static int cmd_disable(char *args[], int num, struct connman_option *options)
                                "Powered", DBUS_TYPE_BOOLEAN, &b);
 }
 
-static int state_print(DBusMessageIter *iter, const char *error,
+static int state_print(DBusMessageIter *iter, int errnum, const char *error,
                void *user_data)
 {
        DBusMessageIter entry;
 
        if (error) {
-               fprintf(stderr, "Error: %s", error);
+               fprintf(stderr, "Error: %s\n", error);
                return 0;
        }
 
@@ -269,13 +291,13 @@ static int cmd_state(char *args[], int num, struct connman_option *options)
                        state_print, NULL, NULL, NULL);
 }
 
-static int clock_print(DBusMessageIter *iter, const char *error,
+static int clock_print(DBusMessageIter *iter, int errnum, const char *error,
                void *user_data)
 {
        DBusMessageIter entry;
 
        if (error) {
-               fprintf(stderr, "Error: %s", error);
+               fprintf(stderr, "Error: %s\n", error);
                return 0;
        }
 
@@ -296,7 +318,7 @@ static int cmd_clock(char *args[], int num, struct connman_option *options)
                        clock_print, NULL, NULL, NULL);
 }
 
-static int services_list(DBusMessageIter *iter, const char *error,
+static int services_list(DBusMessageIter *iter, int errnum, const char *error,
                void *user_data)
 {
        if (!error) {
@@ -309,7 +331,26 @@ static int services_list(DBusMessageIter *iter, const char *error,
        return 0;
 }
 
-static int peers_list(DBusMessageIter *iter,
+#if defined TIZEN_EXT_INS
+static int ins_list(DBusMessageIter *iter, const char *error,
+               void *user_data)
+{
+       char *filter = user_data;
+
+       if (!error) {
+               __connmanctl_ins_list(iter, filter);
+               fprintf(stdout, "\n");
+       } else {
+               fprintf(stderr, "Error: %s\n", error);
+       }
+
+       g_free(filter);
+
+       return 0;
+}
+#endif
+
+static int peers_list(DBusMessageIter *iter, int errnum,
                                        const char *error, void *user_data)
 {
        if (!error) {
@@ -321,7 +362,19 @@ static int peers_list(DBusMessageIter *iter,
        return 0;
 }
 
-static int object_properties(DBusMessageIter *iter,
+static int tethering_clients_list(DBusMessageIter *iter, int errnum,
+                                       const char *error, void *user_data)
+{
+       if (!error) {
+               __connmanctl_tethering_clients_list(iter);
+               fprintf(stdout, "\n");
+       } else
+               fprintf(stderr, "Error: %s\n", error);
+
+       return 0;
+}
+
+static int object_properties(DBusMessageIter *iter, int errnum,
                                        const char *error, void *user_data)
 {
        char *path = user_data;
@@ -392,6 +445,24 @@ static int cmd_services(char *args[], int num, struct connman_option *options)
                        object_properties, path, NULL, NULL);
 }
 
+#if defined TIZEN_EXT_INS
+static int cmd_ins(char *args[], int num, struct connman_option *options)
+{
+       char *filter = NULL;
+
+       if (num > 2)
+               return -E2BIG;
+
+       if (num == 2)
+               filter = g_strdup(args[1]);
+
+       return __connmanctl_dbus_method_call(connection,
+                               CONNMAN_SERVICE, CONNMAN_PATH,
+                               "net.connman.Manager", "GetINS",
+                               ins_list, filter, NULL, NULL);
+}
+#endif
+
 static int cmd_peers(char *args[], int num, struct connman_option *options)
 {
        char *peer_name = NULL;
@@ -419,7 +490,7 @@ static int cmd_peers(char *args[], int num, struct connman_option *options)
                                object_properties, path, NULL, NULL);
 }
 
-static int technology_print(DBusMessageIter *iter, const char *error,
+static int technology_print(DBusMessageIter *iter, int errnum, const char *error,
                void *user_data)
 {
        DBusMessageIter array;
@@ -466,8 +537,8 @@ struct tether_enable {
        dbus_bool_t enable;
 };
 
-static int tether_set_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int tether_set_return(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        struct tether_enable *tether = user_data;
        char *str;
@@ -543,8 +614,8 @@ static int tether_update(struct tether_properties *tether)
        return -EINPROGRESS;
 }
 
-static int tether_set_ssid_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int tether_set_ssid_return(DBusMessageIter *iter, int errnum,
+                               const char *error, void *user_data)
 {
        struct tether_properties *tether = user_data;
 
@@ -559,8 +630,8 @@ static int tether_set_ssid_return(DBusMessageIter *iter, const char *error,
        return tether_update(tether);
 }
 
-static int tether_set_passphrase_return(DBusMessageIter *iter,
-               const char *error, void *user_data)
+static int tether_set_passphrase_return(DBusMessageIter *iter, int errnum,
+                                       const char *error, void *user_data)
 {
        struct tether_properties *tether = user_data;
 
@@ -1214,7 +1285,18 @@ static int cmd_tether(char *args[], int num, struct connman_option *options)
        return tether_set(args[1], set_tethering);
 }
 
-static int scan_return(DBusMessageIter *iter, const char *error,
+static int cmd_tethering_clients(char *args[], int num, struct connman_option *options)
+{
+       if (num > 1)
+               return -E2BIG;
+
+       return __connmanctl_dbus_method_call(connection,
+                               CONNMAN_SERVICE, CONNMAN_PATH,
+                               "net.connman.Manager", "GetTetheringClients",
+                               tethering_clients_list, NULL, NULL, NULL);
+}
+
+static int scan_return(DBusMessageIter *iter, int ernnum, const char *error,
                void *user_data)
 {
        char *path = user_data;
@@ -1250,8 +1332,8 @@ static int cmd_scan(char *args[], int num, struct connman_option *options)
                        scan_return, path, NULL, NULL);
 }
 
-static int connect_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int connect_return(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        char *path = user_data;
 
@@ -1291,8 +1373,8 @@ static int cmd_connect(char *args[], int num, struct connman_option *options)
                        iface, "Connect", connect_return, path, NULL, NULL);
 }
 
-static int disconnect_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int disconnect_return(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        char *path = user_data;
 
@@ -1338,8 +1420,8 @@ struct move_service {
        char *target;
 };
 
-static int move_before_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int move_before_return(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        struct move_service *services = user_data;
        char *service;
@@ -1367,8 +1449,6 @@ static void move_before_append_args(DBusMessageIter *iter, void *user_data)
 
        dbus_message_iter_append_basic(iter,
                                DBUS_TYPE_OBJECT_PATH, &path);
-
-       return;
 }
 
 static int cmd_service_move_before(char *args[], int num,
@@ -1398,8 +1478,8 @@ static int cmd_service_move_before(char *args[], int num,
                                        services->target);
 }
 
-static int move_after_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int move_after_return(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        struct move_service *services = user_data;
        char *service;
@@ -1427,8 +1507,6 @@ static void move_after_append_args(DBusMessageIter *iter, void *user_data)
 
        dbus_message_iter_append_basic(iter,
                                DBUS_TYPE_OBJECT_PATH, &path);
-
-       return;
 }
 
 static int cmd_service_move_after(char *args[], int num,
@@ -1458,8 +1536,8 @@ static int cmd_service_move_after(char *args[], int num,
                                        services->target);
 }
 
-static int config_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int config_return(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        char *service_name = user_data;
 
@@ -1476,6 +1554,13 @@ struct config_append {
        int values;
 };
 
+struct session_options {
+       char **args;
+       int num;
+       char *notify_path;
+       struct connman_option *options;
+};
+
 static void config_append_ipv4(DBusMessageIter *iter,
                void *user_data)
 {
@@ -1777,6 +1862,30 @@ static int cmd_config(char *args[], int num, struct connman_option *options)
                                        config_return, g_strdup(service_name),
                                        NULL, NULL);
                        break;
+
+               case 'm':
+                       switch (parse_boolean(*opt_start)) {
+                       case 1:
+                               val = TRUE;
+                               break;
+                       case 0:
+                               val = FALSE;
+                               break;
+                       default:
+                               res = -EINVAL;
+                               break;
+                       }
+                       if (res == 0) {
+                               res = __connmanctl_dbus_set_property(connection,
+                                               path, "net.connman.Service",
+                                               config_return,
+                                               g_strdup(service_name),
+                                               "mDNS.Configuration",
+                                               DBUS_TYPE_BOOLEAN, &val);
+                       }
+                       index++;
+                       break;
+
                default:
                        res = -EINVAL;
                        break;
@@ -2084,8 +2193,8 @@ static int cmd_agent(char *args[], int num, struct connman_option *options)
        return 0;
 }
 
-static int vpnconnections_properties(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int vpnconnections_properties(DBusMessageIter *iter, int errnum,
+                               const char *error, void *user_data)
 {
        char *path = user_data;
        char *str;
@@ -2114,8 +2223,8 @@ static int vpnconnections_properties(DBusMessageIter *iter, const char *error,
        return 0;
 }
 
-static int vpnconnections_list(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int vpnconnections_list(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        if (!error)
                __connmanctl_vpnconnections_list(iter);
@@ -2306,11 +2415,11 @@ static void session_notify_remove(void)
        session_notify_path = NULL;
 }
 
-static int session_connect_cb(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int session_connect_cb(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        if (error) {
-               fprintf(stderr, "Error: %s", error);
+               fprintf(stderr, "Error: %s\n", error);
                return 0;
        }
 
@@ -2325,11 +2434,11 @@ static int session_connect(void)
                        session_connect_cb, NULL, NULL, NULL);
 }
 
-static int session_disconnect_cb(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int session_disconnect_cb(DBusMessageIter *iter, int errnum,
+                               const char *error, void *user_data)
 {
        if (error)
-               fprintf(stderr, "Error: %s", error);
+               fprintf(stderr, "Error: %s\n", error);
 
        return 0;
 }
@@ -2341,8 +2450,8 @@ static int session_disconnect(void)
                        session_disconnect_cb, NULL, NULL, NULL);
 }
 
-static int session_create_cb(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int session_create_cb(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        gboolean connect = GPOINTER_TO_INT(user_data);
        char *str;
@@ -2371,28 +2480,140 @@ static int session_create_cb(DBusMessageIter *iter, const char *error,
        return -EINPROGRESS;
 }
 
+static void session_config_append_array(DBusMessageIter *iter,
+               void *user_data)
+{
+       struct config_append *append = user_data;
+       char **opts = append->opts;
+       int i = 1;
+
+       if (!opts)
+               return;
+
+       while (opts[i] && strncmp(opts[i], "--", 2) != 0) {
+               dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING,
+                                              &opts[i]);
+               i++;
+       }
+
+       append->values = i;
+}
+
+static void session_create_append_dict(DBusMessageIter *iter, void *user_data)
+{
+       struct session_options *args_struct = user_data;
+       int index = 0, res = 0;
+       struct config_append append;
+       char c;
+       char *ifname;
+       dbus_bool_t source_ip_rule;
+
+       while (index < args_struct->num && args_struct->args[index]) {
+               append.opts = &args_struct->args[index];
+               append.values = 0;
+
+               c = parse_args(args_struct->args[index], args_struct->options);
+
+               switch (c) {
+               case 'b':
+                       __connmanctl_dbus_append_dict_string_array(iter, "AllowedBearers",
+                                                                  session_config_append_array,
+                                                                  &append);
+                       break;
+               case 't':
+                       if (! args_struct->args[index + 1]) {
+                               res = -EINVAL;
+                               break;
+                       }
+                       __connmanctl_dbus_append_dict_entry(iter, "ConnectionType",
+                                                           DBUS_TYPE_STRING,
+                                                           &args_struct->args[index + 1]);
+                       append.values = 2;
+                       break;
+               case 'i':
+                       if (index + 1 <  args_struct->num)
+                               ifname =  args_struct->args[index + 1];
+                       else
+                               ifname = "";
+                        __connmanctl_dbus_append_dict_entry(iter, "AllowedInterface",
+                                                            DBUS_TYPE_STRING,
+                                                            &ifname);
+                       append.values = 2;
+                       break;
+               case 's':
+                       if (! args_struct->args[index + 1]) {
+                               res = -EINVAL;
+                               break;
+                       }
+                       switch (parse_boolean( args_struct->args[index + 1])) {
+                       case 1:
+                               source_ip_rule = TRUE;
+                               break;
+                       case 0:
+                               source_ip_rule = FALSE;
+                               break;
+                       default:
+                               res = -EINVAL;
+                               break;
+                       }
+                       __connmanctl_dbus_append_dict_entry(iter, "SourceIPRule",
+                                                           DBUS_TYPE_BOOLEAN,
+                                                           &source_ip_rule);
+                       append.values = 2;
+                       break;
+               case 'c':
+                       if (!args_struct->args[index + 1]) {
+                               res = -EINVAL;
+                               break;
+                       }
+                       __connmanctl_dbus_append_dict_entry(iter, "ContextIdentifier",
+                                                           DBUS_TYPE_STRING,
+                                                           &args_struct->args[index + 1]);
+                       append.values = 2;
+                       break;
+               default:
+                       res = -EINVAL;
+               }
+
+               if (res < 0 && res != -EINPROGRESS) {
+                       printf("Error '%s': %s\n",  args_struct->args[index],
+                                       strerror(-res));
+                       return;
+               }
+
+               index += append.values;
+       }
+}
+
 static void session_create_append(DBusMessageIter *iter, void *user_data)
 {
-       const char *notify_path = user_data;
+       struct session_options *args_struct = user_data;
 
-       __connmanctl_dbus_append_dict(iter, NULL, NULL);
+       __connmanctl_dbus_append_dict(iter, session_create_append_dict,
+                                     args_struct);
 
        dbus_message_iter_append_basic(iter, DBUS_TYPE_OBJECT_PATH,
-                       &notify_path);
+                                      &args_struct->notify_path);
 }
 
-static int session_create(gboolean connect)
+static int session_create(gboolean connect, char *args[], int num,
+                         struct connman_option *options)
 {
        int res;
        char *notify_path;
+       struct session_options args_struct;
+       args_struct.args = args;
+       args_struct.num = num;
+       args_struct.options = options;
 
        notify_path = g_strdup_printf("/net/connman/connmanctl%d", getpid());
        session_notify_add(notify_path);
+       args_struct.notify_path = notify_path;
 
        res = __connmanctl_dbus_method_call(connection, "net.connman", "/",
                        "net.connman.Manager", "CreateSession",
                        session_create_cb, GINT_TO_POINTER(connect),
-                       session_create_append, notify_path);
+                       session_create_append, &args_struct);
 
        g_free(notify_path);
 
@@ -2402,8 +2623,8 @@ static int session_create(gboolean connect)
        return res;
 }
 
-static int session_destroy_cb(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int session_destroy_cb(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        if (error) {
                fprintf(stderr, "Error destroying session: %s", error);
@@ -2434,8 +2655,8 @@ static int session_destroy(void)
                        session_destroy_append, session_path);
 }
 
-static int session_config_return(DBusMessageIter *iter, const char *error,
-               void *user_data)
+static int session_config_return(DBusMessageIter *iter, int errnum,
+                               const char *error, void *user_data)
 {
        char *property_name = user_data;
 
@@ -2446,25 +2667,6 @@ static int session_config_return(DBusMessageIter *iter, const char *error,
        return 0;
 }
 
-static void session_config_append_array(DBusMessageIter *iter,
-               void *user_data)
-{
-       struct config_append *append = user_data;
-       char **opts = append->opts;
-       int i = 1;
-
-       if (!opts)
-               return;
-
-       while (opts[i] && strncmp(opts[i], "--", 2) != 0) {
-               dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING,
-                               &opts[i]);
-               i++;
-       }
-
-       append->values = i;
-}
-
 static int session_config(char *args[], int num,
                struct connman_option *options)
 {
@@ -2534,6 +2736,18 @@ static int session_config(char *args[], int num,
                                        DBUS_TYPE_BOOLEAN, &source_ip_rule);
                        append.values = 2;
                        break;
+               case 'c':
+                               if (!args[index + 1]) {
+                                       res = -EINVAL;
+                                       break;
+                               }
+
+                               res = __connmanctl_dbus_session_change(connection,
+                                               session_path, session_config_return,
+                                               "ctxid", "ctxid", DBUS_TYPE_STRING,
+                                               &args[index + 1]);
+                               append.values = 2;
+                               break;
 
                default:
                        res = -EINVAL;
@@ -2569,12 +2783,13 @@ static int cmd_session(char *args[], int num, struct connman_option *options)
        case 1:
                if (session_path)
                        return -EALREADY;
-               return session_create(FALSE);
+               return session_create(FALSE, &args[2], num - 2, options);
 
        default:
                if (!strcmp(command, "connect")) {
                        if (!session_path)
-                               return session_create(TRUE);
+                               return session_create(TRUE, &args[2], num - 2,
+                                                     options);
 
                        return session_connect();
 
@@ -2793,10 +3008,20 @@ static struct connman_option service_options[] = {
        { NULL, }
 };
 
+#if defined TIZEN_EXT_INS
+static struct connman_option ins_options[] = {
+       {"all",         'a', ""},
+       {"filter-ssid", 's', "ssid"},
+       {"filter-name", 'n', "[<service_name>]"},
+       { NULL, }
+};
+#endif
+
 static struct connman_option config_options[] = {
        {"nameservers", 'n', "<dns1> [<dns2>] [<dns3>]"},
        {"timeservers", 't', "<ntp1> [<ntp2>] [...]"},
        {"domains", 'd', "<domain1> [<domain2>] [...]"},
+       {"mdns", 'm', "yes|no"},
        {"ipv6", 'v', "off|auto [enable|disable|preferred]|\n"
                      "\t\t\tmanual <address> <prefixlength> <gateway>"},
        {"proxy", 'x', "direct|auto <URL>|manual <URL1> [<URL2>] [...]\n"
@@ -2823,6 +3048,7 @@ static struct connman_option session_options[] = {
        {"type", 't', "local|internet|any"},
        {"ifname", 'i', "[<interface_name>]"},
        {"srciprule", 's', "yes|no"},
+       {"ctxid", 'c', "<context_identifier>"},
        { NULL, }
 };
 
@@ -2917,8 +3143,8 @@ static char *lookup_mesh(const char *text, int state)
 }
 #endif
 
-static int peer_service_cb(DBusMessageIter *iter, const char *error,
-                                                       void *user_data)
+static int peer_service_cb(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        bool registration = GPOINTER_TO_INT(user_data);
 
@@ -3237,8 +3463,14 @@ static const struct {
                                          NULL,            cmd_tether,
          "Enable, disable tethering, set SSID and passphrase for wifi",
          lookup_tether },
+       { "tethering_clients", NULL,      NULL,            cmd_tethering_clients,
+         "Display tethering clients", NULL },
        { "services",     "[<service>]",  service_options, cmd_services,
          "Display services", lookup_service_arg },
+#if defined TIZEN_EXT_INS
+       { "ins",                  NULL,      ins_options, cmd_ins,
+         "Display intelligent network selection", NULL },
+#endif
        { "peers",        "[peer]",       NULL,            cmd_peers,
          "Display peers", lookup_peer_arg },
        { "scan",         "<technology>", NULL,            cmd_scan,
@@ -3453,8 +3685,8 @@ static void update_services(DBusMessageIter *iter)
        }
 }
 
-static int populate_service_hash(DBusMessageIter *iter, const char *error,
-                               void *user_data)
+static int populate_service_hash(DBusMessageIter *iter, int errnum,
+                               const char *error, void *user_data)
 {
        if (error) {
                fprintf(stderr, "Error getting services: %s", error);
@@ -3511,8 +3743,8 @@ static void add_vpnconnections(DBusMessageIter *iter)
        }
 }
 
-static int populate_vpnconnection_hash(DBusMessageIter *iter, const char *error,
-                               void *user_data)
+static int populate_vpnconnection_hash(DBusMessageIter *iter, int errnum,
+                               const char *error, void *user_data)
 {
        DBusMessageIter array;
 
@@ -3585,8 +3817,8 @@ static void update_peers(DBusMessageIter *iter)
        }
 }
 
-static int populate_peer_hash(DBusMessageIter *iter,
-                                       const char *error, void *user_data)
+static int populate_peer_hash(DBusMessageIter *iter, int errnum,
+                       const char *error, void *user_data)
 {
        if (error) {
                fprintf(stderr, "Error getting peers: %s", error);
@@ -3650,11 +3882,11 @@ static void update_technologies(DBusMessageIter *iter)
        }
 }
 
-static int populate_technology_hash(DBusMessageIter *iter, const char *error,
-                               void *user_data)
+static int populate_technology_hash(DBusMessageIter *iter, int errnum,
+                               const char *error, void *user_data)
 {
        if (error) {
-               fprintf(stderr, "Error getting technologies: %s", error);
+               fprintf(stderr, "Error getting technologies: %s\n", error);
                return 0;
        }