btrfs-progs: unify getopt table terminators
[platform/upstream/btrfs-progs.git] / btrfs-convert.c
index 9a7da57..bbd19bb 100644 (file)
@@ -31,7 +31,7 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <uuid/uuid.h>
-#include <linux/fs.h>
+#include <linux/limits.h>
 
 #include "ctree.h"
 #include "disk-io.h"
 #include "transaction.h"
 #include "crc32c.h"
 #include "utils.h"
+#include "task-utils.h"
 #include <ext2fs/ext2_fs.h>
 #include <ext2fs/ext2fs.h>
 #include <ext2fs/ext2_ext_attr.h>
 
 #define INO_OFFSET (BTRFS_FIRST_FREE_OBJECTID - EXT2_ROOT_INO)
-#define STRIPE_LEN (64 * 1024)
 #define EXT2_IMAGE_SUBVOL_OBJECTID BTRFS_FIRST_FREE_OBJECTID
 
+struct task_ctx {
+       uint32_t max_copy_inodes;
+       uint32_t cur_copy_inodes;
+       struct task_info *info;
+};
+
+static void *print_copied_inodes(void *p)
+{
+       struct task_ctx *priv = p;
+       const char work_indicator[] = { '.', 'o', 'O', 'o' };
+       uint32_t count = 0;
+
+       task_period_start(priv->info, 1000 /* 1s */);
+       while (1) {
+               count++;
+               printf("copy inodes [%c] [%10d/%10d]\r",
+                      work_indicator[count % 4], priv->cur_copy_inodes,
+                      priv->max_copy_inodes);
+               fflush(stdout);
+               task_period_wait(priv->info);
+       }
+
+       return NULL;
+}
+
+static int after_copied_inodes(void *p)
+{
+       struct task_ctx *priv = p;
+
+       printf("\n");
+       task_period_stop(priv->info);
+
+       return 0;
+}
+
 /*
  * Open Ext2fs in readonly mode, read block allocation bitmap and
  * inode bitmap into memory.
@@ -135,11 +170,11 @@ static int cache_free_extents(struct btrfs_root *root, ext2_filsys ext2_fs)
 
        for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; i++) {
                bytenr = btrfs_sb_offset(i);
-               bytenr &= ~((u64)STRIPE_LEN - 1);
+               bytenr &= ~((u64)BTRFS_STRIPE_LEN - 1);
                if (bytenr >= blocksize * ext2_fs->super->s_blocks_count)
                        break;
                clear_extent_dirty(&root->fs_info->free_space_cache, bytenr,
-                                  bytenr + STRIPE_LEN - 1, 0);
+                                  bytenr + BTRFS_STRIPE_LEN - 1, 0);
        }
 
        clear_extent_dirty(&root->fs_info->free_space_cache,
@@ -208,9 +243,9 @@ static int intersect_with_sb(u64 bytenr, u64 num_bytes)
 
        for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; i++) {
                offset = btrfs_sb_offset(i);
-               offset &= ~((u64)STRIPE_LEN - 1);
+               offset &= ~((u64)BTRFS_STRIPE_LEN - 1);
 
-               if (bytenr < offset + STRIPE_LEN &&
+               if (bytenr < offset + BTRFS_STRIPE_LEN &&
                    bytenr + num_bytes > offset)
                        return 1;
        }
@@ -223,7 +258,7 @@ static int custom_free_extent(struct btrfs_root *root, u64 bytenr,
        return intersect_with_sb(bytenr, num_bytes);
 }
 
-struct btrfs_extent_ops extent_ops = {
+static struct btrfs_extent_ops extent_ops = {
        .alloc_extent = custom_alloc_extent,
        .free_extent = custom_free_extent,
 };
@@ -352,124 +387,33 @@ fail:
                ret = -1;
        return ret;
 }
-/*
- * Record a file extent. Do all the required works, such as inserting
- * file extent item, inserting extent item and backref item into extent
- * tree and updating block accounting.
- */
-static int record_file_extent(struct btrfs_trans_handle *trans,
-                             struct btrfs_root *root, u64 objectid,
-                             struct btrfs_inode_item *inode,
-                             u64 file_pos, u64 disk_bytenr,
-                             u64 num_bytes, int checksum)
+
+static int csum_disk_extent(struct btrfs_trans_handle *trans,
+                           struct btrfs_root *root,
+                           u64 disk_bytenr, u64 num_bytes)
 {
-       int ret;
-       struct btrfs_fs_info *info = root->fs_info;
-       struct btrfs_root *extent_root = info->extent_root;
-       struct extent_buffer *leaf;
-       struct btrfs_file_extent_item *fi;
-       struct btrfs_key ins_key;
-       struct btrfs_path path;
-       struct btrfs_extent_item *ei;
        u32 blocksize = root->sectorsize;
-       u64 nbytes;
-
-       if (disk_bytenr == 0) {
-               ret = btrfs_insert_file_extent(trans, root, objectid,
-                                               file_pos, disk_bytenr,
-                                               num_bytes, num_bytes);
-               return ret;
-       }
-
-       btrfs_init_path(&path);
-
-       if (checksum) {
-               u64 offset;
-               char *buffer;
+       u64 offset;
+       char *buffer;
+       int ret = 0;
 
-               ret = -ENOMEM;
-               buffer = malloc(blocksize);
-               if (!buffer)
-                       goto fail;
-               for (offset = 0; offset < num_bytes; offset += blocksize) {
-                       ret = read_disk_extent(root, disk_bytenr + offset,
-                                               blocksize, buffer);
-                       if (ret)
-                               break;
-                       ret = btrfs_csum_file_block(trans,
-                                                   root->fs_info->csum_root,
-                                                   disk_bytenr + num_bytes,
-                                                   disk_bytenr + offset,
-                                                   buffer, blocksize);
-                       if (ret)
-                               break;
-               }
-               free(buffer);
+       buffer = malloc(blocksize);
+       if (!buffer)
+               return -ENOMEM;
+       for (offset = 0; offset < num_bytes; offset += blocksize) {
+               ret = read_disk_extent(root, disk_bytenr + offset,
+                                       blocksize, buffer);
                if (ret)
-                       goto fail;
-       }
-
-       ins_key.objectid = objectid;
-       ins_key.offset = file_pos;
-       btrfs_set_key_type(&ins_key, BTRFS_EXTENT_DATA_KEY);
-       ret = btrfs_insert_empty_item(trans, root, &path, &ins_key,
-                                     sizeof(*fi));
-       if (ret)
-               goto fail;
-       leaf = path.nodes[0];
-       fi = btrfs_item_ptr(leaf, path.slots[0],
-                           struct btrfs_file_extent_item);
-       btrfs_set_file_extent_generation(leaf, fi, trans->transid);
-       btrfs_set_file_extent_type(leaf, fi, BTRFS_FILE_EXTENT_REG);
-       btrfs_set_file_extent_disk_bytenr(leaf, fi, disk_bytenr);
-       btrfs_set_file_extent_disk_num_bytes(leaf, fi, num_bytes);
-       btrfs_set_file_extent_offset(leaf, fi, 0);
-       btrfs_set_file_extent_num_bytes(leaf, fi, num_bytes);
-       btrfs_set_file_extent_ram_bytes(leaf, fi, num_bytes);
-       btrfs_set_file_extent_compression(leaf, fi, 0);
-       btrfs_set_file_extent_encryption(leaf, fi, 0);
-       btrfs_set_file_extent_other_encoding(leaf, fi, 0);
-       btrfs_mark_buffer_dirty(leaf);
-
-       nbytes = btrfs_stack_inode_nbytes(inode) + num_bytes;
-       btrfs_set_stack_inode_nbytes(inode, nbytes);
-
-       btrfs_release_path(&path);
-
-       ins_key.objectid = disk_bytenr;
-       ins_key.offset = num_bytes;
-       ins_key.type = BTRFS_EXTENT_ITEM_KEY;
-
-       ret = btrfs_insert_empty_item(trans, extent_root, &path,
-                                     &ins_key, sizeof(*ei));
-       if (ret == 0) {
-               leaf = path.nodes[0];
-               ei = btrfs_item_ptr(leaf, path.slots[0],
-                                   struct btrfs_extent_item);
-
-               btrfs_set_extent_refs(leaf, ei, 0);
-               btrfs_set_extent_generation(leaf, ei, 0);
-               btrfs_set_extent_flags(leaf, ei, BTRFS_EXTENT_FLAG_DATA);
-
-               btrfs_mark_buffer_dirty(leaf);
-
-               ret = btrfs_update_block_group(trans, root, disk_bytenr,
-                                              num_bytes, 1, 0);
+                       break;
+               ret = btrfs_csum_file_block(trans,
+                                           root->fs_info->csum_root,
+                                           disk_bytenr + num_bytes,
+                                           disk_bytenr + offset,
+                                           buffer, blocksize);
                if (ret)
-                       goto fail;
-       } else if (ret != -EEXIST) {
-               goto fail;
+                       break;
        }
-       btrfs_extent_post_op(trans, extent_root);
-
-       ret = btrfs_inc_extent_ref(trans, root, disk_bytenr, num_bytes, 0,
-                                  root->root_key.objectid,
-                                  objectid, file_pos);
-       if (ret)
-               goto fail;
-       ret = 0;
-fail:
-       btrfs_release_path(&path);
+       free(buffer);
        return ret;
 }
 
@@ -479,11 +423,17 @@ static int record_file_blocks(struct btrfs_trans_handle *trans,
                              u64 file_block, u64 disk_block,
                              u64 num_blocks, int checksum)
 {
+       int ret;
        u64 file_pos = file_block * root->sectorsize;
        u64 disk_bytenr = disk_block * root->sectorsize;
        u64 num_bytes = num_blocks * root->sectorsize;
-       return record_file_extent(trans, root, objectid, inode, file_pos,
-                                 disk_bytenr, num_bytes, checksum);
+       ret = btrfs_record_file_extent(trans, root, objectid, inode, file_pos,
+                                       disk_bytenr, num_bytes);
+
+       if (ret || !checksum || disk_bytenr == 0)
+               return ret;
+
+       return csum_disk_extent(trans, root, disk_bytenr, num_bytes);
 }
 
 struct blk_iterate_data {
@@ -536,8 +486,8 @@ static int block_iterate_proc(ext2_filsys ext2_fs,
                }
 
                if (sb_region) {
-                       bytenr += STRIPE_LEN - 1;
-                       bytenr &= ~((u64)STRIPE_LEN - 1);
+                       bytenr += BTRFS_STRIPE_LEN - 1;
+                       bytenr &= ~((u64)BTRFS_STRIPE_LEN - 1);
                } else {
                        cache = btrfs_lookup_block_group(root->fs_info, bytenr);
                        BUG_ON(!cache);
@@ -633,8 +583,7 @@ static int create_file_extents(struct btrfs_trans_handle *trans,
                                         data.first_block, data.checksum);
        }
 fail:
-       if (buffer)
-               free(buffer);
+       free(buffer);
        return ret;
 error:
        fprintf(stderr, "ext2fs_block_iterate2: %s\n", error_message(err));
@@ -871,8 +820,7 @@ static int copy_single_xattr(struct btrfs_trans_handle *trans,
        ret = btrfs_insert_xattr_item(trans, root, namebuf, name_len,
                                      data, datalen, objectid);
 out:
-       if (databuf)
-               free(databuf);
+       free(databuf);
        return ret;
 }
 
@@ -978,8 +926,7 @@ static int copy_extended_attrs(struct btrfs_trans_handle *trans,
                entry = EXT2_EXT_ATTR_NEXT(entry);
        }
 out:
-       if (buffer != NULL)
-               free(buffer);
+       free(buffer);
        if ((void *)ext2_inode != inode_buf)
                free(ext2_inode);
        return ret;
@@ -1126,7 +1073,7 @@ fail:
  * scan ext2's inode bitmap and copy all used inodes.
  */
 static int copy_inodes(struct btrfs_root *root, ext2_filsys ext2_fs,
-                      int datacsum, int packing, int noxattr)
+                      int datacsum, int packing, int noxattr, struct task_ctx *p)
 {
        int ret;
        errcode_t err;
@@ -1158,6 +1105,7 @@ static int copy_inodes(struct btrfs_root *root, ext2_filsys ext2_fs,
                                        objectid, ext2_fs, ext2_ino,
                                        &ext2_inode, datacsum, packing,
                                        noxattr);
+               p->cur_copy_inodes++;
                if (ret)
                        return ret;
                if (trans->blocks_used >= 4096) {
@@ -1294,9 +1242,9 @@ static int create_ext2_image(struct btrfs_root *root, ext2_filsys ext2_fs,
                                       sectorsize);
                if (ret)
                        goto fail;
-               ret = record_file_extent(trans, root, objectid,
-                                        &btrfs_inode, last_byte,
-                                        key.objectid, sectorsize, 0);
+               ret = btrfs_record_file_extent(trans, root, objectid,
+                                              &btrfs_inode, last_byte,
+                                              key.objectid, sectorsize);
                if (ret)
                        goto fail;
        }
@@ -1355,8 +1303,9 @@ next:
                        if (ret)
                                goto fail;
                }
-               ret = record_file_extent(trans, root, objectid, &btrfs_inode,
-                                        bytenr, bytenr, num_bytes, 0);
+               ret = btrfs_record_file_extent(trans, root, objectid,
+                                              &btrfs_inode, bytenr, bytenr,
+                                              num_bytes);
                if (ret)
                        goto fail;
                last_byte = bytenr + num_bytes;
@@ -1429,10 +1378,15 @@ static struct btrfs_root * link_subvol(struct btrfs_root *root,
        struct btrfs_key key;
        u64 dirid = btrfs_root_dirid(&root->root_item);
        u64 index = 2;
-       char buf[64];
+       char buf[BTRFS_NAME_LEN + 1]; /* for snprintf null */
+       int len;
        int i;
        int ret;
 
+       len = strlen(base);
+       if (len < 1 || len > BTRFS_NAME_LEN)
+               return NULL;
+
        path = btrfs_alloc_path();
        BUG_ON(!path);
 
@@ -1468,18 +1422,22 @@ static struct btrfs_root * link_subvol(struct btrfs_root *root,
        key.offset = (u64)-1;
        key.type = BTRFS_ROOT_ITEM_KEY;
 
-       strcpy(buf, base);
+       memcpy(buf, base, len);
        for (i = 0; i < 1024; i++) {
-               ret = btrfs_insert_dir_item(trans, root, buf, strlen(buf),
+               ret = btrfs_insert_dir_item(trans, root, buf, len,
                                            dirid, &key, BTRFS_FT_DIR, index);
                if (ret != -EEXIST)
                        break;
-               sprintf(buf, "%s%d", base, i);
+               len = snprintf(buf, ARRAY_SIZE(buf), "%s%d", base, i);
+               if (len < 1 || len > BTRFS_NAME_LEN) {
+                       ret = -EINVAL;
+                       break;
+               }
        }
        if (ret)
                goto fail;
 
-       btrfs_set_inode_size(leaf, inode_item, strlen(buf) * 2 +
+       btrfs_set_inode_size(leaf, inode_item, len * 2 +
                             btrfs_inode_size(leaf, inode_item));
        btrfs_mark_buffer_dirty(leaf);
        btrfs_release_path(path);
@@ -1488,13 +1446,13 @@ static struct btrfs_root * link_subvol(struct btrfs_root *root,
        ret = btrfs_add_root_ref(trans, tree_root, root_objectid,
                                 BTRFS_ROOT_BACKREF_KEY,
                                 root->root_key.objectid,
-                                dirid, index, buf, strlen(buf));
+                                dirid, index, buf, len);
        BUG_ON(ret);
 
        /* now add the forward ref */
        ret = btrfs_add_root_ref(trans, tree_root, root->root_key.objectid,
                                 BTRFS_ROOT_REF_KEY, root_objectid,
-                                dirid, index, buf, strlen(buf));
+                                dirid, index, buf, len);
 
        ret = btrfs_commit_transaction(trans, root);
        BUG_ON(ret);
@@ -1599,7 +1557,7 @@ static int create_chunk_mapping(struct btrfs_trans_handle *trans,
                btrfs_set_stack_chunk_length(&chunk, cache->key.offset);
                btrfs_set_stack_chunk_owner(&chunk,
                                            extent_root->root_key.objectid);
-               btrfs_set_stack_chunk_stripe_len(&chunk, STRIPE_LEN);
+               btrfs_set_stack_chunk_stripe_len(&chunk, BTRFS_STRIPE_LEN);
                btrfs_set_stack_chunk_type(&chunk, cache->flags);
                btrfs_set_stack_chunk_io_align(&chunk, device->io_align);
                btrfs_set_stack_chunk_io_width(&chunk, device->io_width);
@@ -1710,6 +1668,7 @@ static int init_btrfs(struct btrfs_root *root)
        ret = create_subvol(trans, root, BTRFS_DATA_RELOC_TREE_OBJECTID);
        BUG_ON(ret);
 
+       extent_buffer_get(fs_info->csum_root->node);
        ret = __btrfs_cow_block(trans, fs_info->csum_root,
                                fs_info->csum_root->node, NULL, 0, &tmp, 0, 0);
        BUG_ON(ret);
@@ -1722,7 +1681,7 @@ err:
 }
 
 /*
- * Migrate super block to it's default position and zero 0 ~ 16k
+ * Migrate super block to its default position and zero 0 ~ 16k
  */
 static int migrate_super_block(int fd, u64 old_bytenr, u32 sectorsize)
 {
@@ -1792,7 +1751,7 @@ static int prepare_system_chunk_sb(struct btrfs_super_block *super)
 
        btrfs_set_stack_chunk_length(chunk, btrfs_super_total_bytes(super));
        btrfs_set_stack_chunk_owner(chunk, BTRFS_EXTENT_TREE_OBJECTID);
-       btrfs_set_stack_chunk_stripe_len(chunk, 64 * 1024);
+       btrfs_set_stack_chunk_stripe_len(chunk, BTRFS_STRIPE_LEN);
        btrfs_set_stack_chunk_type(chunk, BTRFS_BLOCK_GROUP_SYSTEM);
        btrfs_set_stack_chunk_io_align(chunk, sectorsize);
        btrfs_set_stack_chunk_io_width(chunk, sectorsize);
@@ -2174,10 +2133,10 @@ static int cleanup_sys_chunk(struct btrfs_root *fs_root,
        }
        for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; i++) {
                offset = btrfs_sb_offset(i);
-               offset &= ~((u64)STRIPE_LEN - 1);
+               offset &= ~((u64)BTRFS_STRIPE_LEN - 1);
 
                ret = relocate_extents_range(fs_root, ext2_root,
-                                            offset, offset + STRIPE_LEN);
+                                            offset, offset + BTRFS_STRIPE_LEN);
                if (ret)
                        goto fail;
        }
@@ -2275,8 +2234,8 @@ err:
        return ret;
 }
 
-static int do_convert(const char *devname, int datacsum, int packing,
-               int noxattr)
+static int do_convert(const char *devname, int datacsum, int packing, int noxattr,
+              int copylabel, const char *fslabel, int progress)
 {
        int i, ret;
        int fd = -1;
@@ -2287,6 +2246,7 @@ static int do_convert(const char *devname, int datacsum, int packing,
        ext2_filsys ext2_fs;
        struct btrfs_root *root;
        struct btrfs_root *ext2_root;
+       struct task_ctx ctx;
 
        ret = open_ext2fs(devname, &ext2_fs);
        if (ret) {
@@ -2319,8 +2279,8 @@ static int do_convert(const char *devname, int datacsum, int packing,
                goto fail;
        }
        ret = make_btrfs(fd, devname, ext2_fs->super->s_volume_name,
-                        blocks, total_bytes, blocksize, blocksize,
-                        blocksize, blocksize);
+                        NULL, blocks, total_bytes, blocksize, blocksize,
+                        blocksize, blocksize, 0);
        if (ret) {
                fprintf(stderr, "unable to create initial ctree: %s\n",
                        strerror(-ret));
@@ -2332,7 +2292,7 @@ static int do_convert(const char *devname, int datacsum, int packing,
                fprintf(stderr, "unable to update system chunk\n");
                goto fail;
        }
-       root = open_ctree_fd(fd, devname, super_bytenr, O_RDWR);
+       root = open_ctree_fd(fd, devname, super_bytenr, OPEN_CTREE_WRITES);
        if (!root) {
                fprintf(stderr, "unable to open ctree\n");
                goto fail;
@@ -2354,11 +2314,23 @@ static int do_convert(const char *devname, int datacsum, int packing,
                goto fail;
        }
        printf("creating btrfs metadata.\n");
-       ret = copy_inodes(root, ext2_fs, datacsum, packing, noxattr);
+       ctx.max_copy_inodes = (ext2_fs->super->s_inodes_count
+                       - ext2_fs->super->s_free_inodes_count);
+       ctx.cur_copy_inodes = 0;
+
+       if (progress) {
+               ctx.info = task_init(print_copied_inodes, after_copied_inodes, &ctx);
+               task_start(ctx.info);
+       }
+       ret = copy_inodes(root, ext2_fs, datacsum, packing, noxattr, &ctx);
        if (ret) {
                fprintf(stderr, "error during copy_inodes %d\n", ret);
                goto fail;
        }
+       if (progress) {
+               task_stop(ctx.info);
+               task_deinit(ctx.info);
+       }
        printf("creating ext2fs image file.\n");
        ext2_root = link_subvol(root, "ext2_saved", EXT2_IMAGE_SUBVOL_OBJECTID);
        if (!ext2_root) {
@@ -2370,6 +2342,17 @@ static int do_convert(const char *devname, int datacsum, int packing,
                fprintf(stderr, "error during create_ext2_image %d\n", ret);
                goto fail;
        }
+       memset(root->fs_info->super_copy->label, 0, BTRFS_LABEL_SIZE);
+       if (copylabel == 1) {
+               strncpy(root->fs_info->super_copy->label,
+                               ext2_fs->super->s_volume_name, 16);
+               fprintf(stderr, "copy label '%s'\n",
+                               root->fs_info->super_copy->label);
+       } else if (copylabel == -1) {
+               strncpy(root->fs_info->super_copy->label, fslabel, BTRFS_LABEL_SIZE);
+               fprintf(stderr, "set label to '%s'\n", fslabel);
+       }
+
        printf("cleaning up system chunk.\n");
        ret = cleanup_sys_chunk(root, ext2_root);
        if (ret) {
@@ -2393,7 +2376,7 @@ static int do_convert(const char *devname, int datacsum, int packing,
                goto fail;
        }
 
-       root = open_ctree_fd(fd, devname, 0, O_RDWR);
+       root = open_ctree_fd(fd, devname, 0, OPEN_CTREE_WRITES);
        if (!root) {
                fprintf(stderr, "unable to open ctree\n");
                goto fail;
@@ -2436,8 +2419,17 @@ static int may_rollback(struct btrfs_root *root)
        while (1) {
                ret = btrfs_map_block(&info->mapping_tree, WRITE, bytenr,
                                      &length, &multi, 0, NULL);
-               if (ret)
+               if (ret) {
+                       if (ret == -ENOENT) {
+                               /* removed block group at the tail */
+                               if (length == (u64)-1)
+                                       break;
+
+                               /* removed block group in the middle */
+                               goto next;
+                       }
                        goto fail;
+               }
 
                num_stripes = multi->num_stripes;
                physical = multi->stripes[0].physical;
@@ -2445,7 +2437,7 @@ static int may_rollback(struct btrfs_root *root)
 
                if (num_stripes != 1 || physical != bytenr)
                        goto fail;
-
+next:
                bytenr += length;
                if (bytenr >= total_bytes)
                        break;
@@ -2455,7 +2447,7 @@ fail:
        return -1;
 }
 
-static int do_rollback(const char *devname, int force)
+static int do_rollback(const char *devname)
 {
        int fd = -1;
        int ret;
@@ -2494,7 +2486,7 @@ static int do_rollback(const char *devname, int force)
                fprintf(stderr, "unable to open %s\n", devname);
                goto fail;
        }
-       root = open_ctree_fd(fd, devname, 0, O_RDWR);
+       root = open_ctree_fd(fd, devname, 0, OPEN_CTREE_WRITES);
        if (!root) {
                fprintf(stderr, "unable to open ctree\n");
                goto fail;
@@ -2520,7 +2512,7 @@ static int do_rollback(const char *devname, int force)
        ext2_root = btrfs_read_fs_root(root->fs_info, &key);
        if (!ext2_root || IS_ERR(ext2_root)) {
                fprintf(stderr, "unable to open subvol %llu\n",
-                       key.objectid);
+                       (unsigned long long)key.objectid);
                goto fail;
        }
 
@@ -2683,6 +2675,12 @@ next_extent:
                if (bytenr >= total_bytes)
                        break;
                ret = pwrite(fd, buf, sectorsize, bytenr);
+               if (ret != sectorsize) {
+                       fprintf(stderr,
+                               "error during zeroing supreblock %d: %d\n",
+                               i, ret);
+                       goto fail;
+               }
        }
 
        sb_bytenr = (u64)-1;
@@ -2764,11 +2762,14 @@ fail:
 
 static void print_usage(void)
 {
-       printf("usage: btrfs-convert [-d] [-i] [-n] [-r] device\n");
-       printf("\t-d disable data checksum\n");
-       printf("\t-i ignore xattrs and ACLs\n");
-       printf("\t-n disable packing of small files\n");
-       printf("\t-r roll back to ext2fs\n");
+       printf("usage: btrfs-convert [-d] [-i] [-n] [-r] [-l label] [-L] device\n");
+       printf("\t-d           disable data checksum\n");
+       printf("\t-i           ignore xattrs and ACLs\n");
+       printf("\t-n           disable packing of small files\n");
+       printf("\t-r           roll back to ext2fs\n");
+       printf("\t-l LABEL     set filesystem label\n");
+       printf("\t-L           use label from converted fs\n");
+       printf("\t-p           show converting progress\n");
 }
 
 int main(int argc, char *argv[])
@@ -2778,9 +2779,14 @@ int main(int argc, char *argv[])
        int noxattr = 0;
        int datacsum = 1;
        int rollback = 0;
+       int copylabel = 0;
+       int usage_error = 0;
+       int progress = 0;
        char *file;
+       char *fslabel = NULL;
+
        while(1) {
-               int c = getopt(argc, argv, "dinr");
+               int c = getopt(argc, argv, "dinrl:Lp");
                if (c < 0)
                        break;
                switch(c) {
@@ -2796,27 +2802,60 @@ int main(int argc, char *argv[])
                        case 'r':
                                rollback = 1;
                                break;
+                       case 'l':
+                               copylabel = -1;
+                               fslabel = strdup(optarg);
+                               if (strlen(fslabel) > BTRFS_LABEL_SIZE) {
+                                       fprintf(stderr,
+                                               "warning: label too long, trimmed to %d bytes\n",
+                                               BTRFS_LABEL_SIZE);
+                                       fslabel[BTRFS_LABEL_SIZE] = 0;
+                               }
+                               break;
+                       case 'L':
+                               copylabel = 1;
+                               break;
+                       case 'p':
+                               progress = 1;
+                               break;
                        default:
                                print_usage();
                                return 1;
                }
        }
        argc = argc - optind;
-       if (argc != 1) {
+       set_argv0(argv);
+       if (check_argc_exact(argc, 1)) {
+               print_usage();
+               return 1;
+       }
+
+       if (rollback && (!datacsum || noxattr || !packing)) {
+               fprintf(stderr,
+                       "Usage error: -d, -i, -n options do not apply to rollback\n");
+               usage_error++;
+       }
+
+       if (usage_error) {
                print_usage();
                return 1;
        }
 
        file = argv[optind];
-       if (check_mounted(file)) {
+       ret = check_mounted(file);
+       if (ret < 0) {
+               fprintf(stderr, "Could not check mount status: %s\n",
+                       strerror(-ret));
+               return 1;
+       } else if (ret) {
                fprintf(stderr, "%s is mounted\n", file);
                return 1;
        }
 
        if (rollback) {
-               ret = do_rollback(file, 0);
+               ret = do_rollback(file);
        } else {
-               ret = do_convert(file, datacsum, packing, noxattr);
+               ret = do_convert(file, datacsum, packing, noxattr, copylabel, fslabel, progress);
        }
        if (ret)
                return 1;