Fix the coverity issues

[platform/core/connectivity/bluetooth-frwk.git] / bt-oal / oal-gatt.c

diff --git a/bt-oal/oal-gatt.c b/bt-oal/oal-gatt.c
index e3a6547..ab6cc88 100644 (file)
--- a/bt-oal/oal-gatt.c
+++ b/bt-oal/oal-gatt.c
@@ -421,50 +421,6 @@ oal_status_t gatts_stop_advertising(int instance_id)
        return OAL_STATUS_SUCCESS;
 }
 
-#if 0
-/* Below API's need to be removed as they are hardcoded API's.
-   If at all, product specific API's are required to set specific data, then new naming should
-   be adopted for these API's */
-oal_status_t gatts_set_advertising_params(int instance_id, float min_intv, float max_intv)
-{
-       int ret = OAL_STATUS_SUCCESS;
-
-       API_TRACE("Set advertising params min_int:%f, max_int:%f", min_intv, max_intv);
-       CHECK_OAL_GATT_ENABLED();
-       CHECK_SERVER_INSTANCE(instance_id);
-       CHECK_SERVER_REGISTRATION(instance_id);
-
-       /* Historically used for Legacy Advertising */
-       return OAL_STATUS_NOT_SUPPORT;
-}
-
-oal_status_t gatts_set_advertising_data(int instance_id, uint16_t manufac_len, char* manufac_data)
-{
-       int ret = OAL_STATUS_SUCCESS;
-
-       API_TRACE("Set advertising data");
-       CHECK_OAL_GATT_ENABLED();
-       CHECK_SERVER_INSTANCE(instance_id);
-       CHECK_SERVER_REGISTRATION(instance_id);
-
-       /* Historically used for Legacy Advertising */
-       return OAL_STATUS_NOT_SUPPORT;
-}
-
-oal_status_t gatts_set_scan_response(int instance_id, uint16_t manufac_len, char* manufac_data)
-{
-       int ret = OAL_STATUS_SUCCESS;
-
-       API_TRACE("Set Scan Response data");
-       CHECK_OAL_GATT_ENABLED();
-       CHECK_SERVER_INSTANCE(instance_id);
-       CHECK_SERVER_REGISTRATION(instance_id);
-
-       /* Historically used for Legacy Advertising */
-       return OAL_STATUS_NOT_SUPPORT;
-}
-#endif
-
 oal_status_t gatts_multi_adv_enable(int instance_id)
 {
        int ret = OAL_STATUS_SUCCESS;
@@ -607,6 +563,9 @@ oal_status_t gatts_multi_adv_set_inst_data(int instance_id,
        adv_setup.set_scan_rsp = adv_param_setup->set_scan_rsp;
        adv_setup.include_name = adv_param_setup->include_name;
        adv_setup.include_txpower = adv_param_setup->include_txpower;
+#ifdef TIZEN_BT_HAL
+       adv_setup.include_appearance = adv_param_setup->include_appearance;
+#endif
        adv_setup.appearance = adv_param_setup->appearance;
        adv_setup.manufacturer_data = adv_param_setup->manufacturer_data;
        adv_setup.manufacturer_data_len = adv_param_setup->manufacturer_data_len;
@@ -1756,7 +1715,7 @@ oal_status_t gattc_stop_le_discovery(int client_id)
 
        int ret = OAL_STATUS_SUCCESS;
 
-       API_TRACE("Scan is stopped");
+       API_TRACE("BTGATT CLIENT SCAN STOP");
        CHECK_OAL_GATT_ENABLED();
        CHECK_CLIENT_REGISTRATION(client_id);
        ret = gatt_api->client->scan(client_id, 0);
@@ -1771,7 +1730,7 @@ oal_status_t gattc_set_le_scan_param(int scan_type, int itv, int win)
 {
        int ret;
 
-       API_TRACE("Scan is stopped");
+       API_TRACE("GATT client set le scan param");
        CHECK_OAL_GATT_ENABLED();
 
 #ifdef TIZEN_BT_HAL
@@ -2429,6 +2388,30 @@ oal_status_t gattc_register_scan_filter(oal_ble_scan_filter_t* filter_data)
        return OAL_STATUS_SUCCESS;
 }
 
+oal_status_t gattc_get_att_mtu(int conn_id, int *mtu)
+{
+       int ret = OAL_STATUS_SUCCESS;
+       API_TRACE("Get ATT MTU, conn_id: %d", conn_id);
+       CHECK_OAL_GATT_ENABLED();
+       CHECK_CLIENT_CONNECTION(conn_id);
+       OAL_CHECK_PARAMETER(mtu, return);
+
+       /* To prevent crash in case other libraries not support this api */
+       if (gatt_api->client->get_att_mtu == NULL) {
+               BT_WARN("get_att_mtu is NULL");
+               return OAL_STATUS_NOT_SUPPORT;
+       }
+
+       ret = gatt_api->client->get_att_mtu(conn_id, mtu);
+       if (ret != BT_STATUS_SUCCESS) {
+               BT_ERR("GATT MTU Size failed, status: %s", status2string(ret));
+               return convert_to_oal_status(ret);
+       }
+
+       BT_INFO("Current ATT MTU Size: %d", *mtu);
+       return OAL_STATUS_SUCCESS;
+}
+
 oal_status_t gattc_configure_mtu(int conn_id, int mtu)
 {
        int ret;