board: stm32mp1: enable simple framebuffer node for splashscreen
[platform/kernel/u-boot.git] / board / st / stm32mp1 / stm32mp1.c
index 1d274c3..45f2ca8 100644 (file)
@@ -2,6 +2,9 @@
 /*
  * Copyright (C) 2018, STMicroelectronics - All Rights Reserved
  */
+
+#define LOG_CATEGORY LOGC_BOARD
+
 #include <common.h>
 #include <adc.h>
 #include <bootm.h>
@@ -10,6 +13,7 @@
 #include <dm.h>
 #include <env.h>
 #include <env_internal.h>
+#include <fdt_simplefb.h>
 #include <fdt_support.h>
 #include <g_dnl.h>
 #include <generic-phy.h>
 #include <syscon.h>
 #include <usb.h>
 #include <watchdog.h>
+#include <asm/global_data.h>
 #include <asm/io.h>
 #include <asm/gpio.h>
 #include <asm/arch/stm32.h>
 #include <asm/arch/sys_proto.h>
+#include <dm/ofnode.h>
 #include <jffs2/load_kernel.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
@@ -101,33 +107,36 @@ int checkboard(void)
        const char *fdt_compat;
        int fdt_compat_len;
 
-       if (IS_ENABLED(CONFIG_TFABOOT))
-               mode = "trusted";
-       else
+       if (IS_ENABLED(CONFIG_TFABOOT)) {
+               if (IS_ENABLED(CONFIG_STM32MP15x_STM32IMAGE))
+                       mode = "trusted - stm32image";
+               else
+                       mode = "trusted";
+       } else {
                mode = "basic";
+       }
 
-       printf("Board: stm32mp1 in %s mode", mode);
        fdt_compat = fdt_getprop(gd->fdt_blob, 0, "compatible",
                                 &fdt_compat_len);
-       if (fdt_compat && fdt_compat_len)
-               printf(" (%s)", fdt_compat);
-       puts("\n");
+
+       log_info("Board: stm32mp1 in %s mode (%s)\n", mode,
+                fdt_compat && fdt_compat_len ? fdt_compat : "");
 
        /* display the STMicroelectronics board identification */
        if (CONFIG_IS_ENABLED(CMD_STBOARD)) {
                ret = uclass_get_device_by_driver(UCLASS_MISC,
-                                                 DM_GET_DRIVER(stm32mp_bsec),
+                                                 DM_DRIVER_GET(stm32mp_bsec),
                                                  &dev);
                if (!ret)
                        ret = misc_read(dev, STM32_BSEC_SHADOW(BSEC_OTP_BOARD),
                                        &otp, sizeof(otp));
                if (ret > 0 && otp)
-                       printf("Board: MB%04x Var%d.%d Rev.%c-%02d\n",
-                              otp >> 16,
-                              (otp >> 12) & 0xF,
-                              (otp >> 4) & 0xF,
-                              ((otp >> 8) & 0xF) - 1 + 'A',
-                              otp & 0xF);
+                       log_info("Board: MB%04x Var%d.%d Rev.%c-%02d\n",
+                                otp >> 16,
+                                (otp >> 12) & 0xF,
+                                (otp >> 4) & 0xF,
+                                ((otp >> 8) & 0xF) - 1 + 'A',
+                                otp & 0xF);
        }
 
        return 0;
@@ -135,82 +144,88 @@ int checkboard(void)
 
 static void board_key_check(void)
 {
-#if defined(CONFIG_FASTBOOT) || defined(CONFIG_CMD_STM32PROG)
        ofnode node;
        struct gpio_desc gpio;
        enum forced_boot_mode boot_mode = BOOT_NORMAL;
 
+       if (!IS_ENABLED(CONFIG_FASTBOOT) && !IS_ENABLED(CONFIG_CMD_STM32PROG))
+               return;
+
        node = ofnode_path("/config");
        if (!ofnode_valid(node)) {
-               debug("%s: no /config node?\n", __func__);
+               log_debug("no /config node?\n");
                return;
        }
-#ifdef CONFIG_FASTBOOT
-       if (gpio_request_by_name_nodev(node, "st,fastboot-gpios", 0,
-                                      &gpio, GPIOD_IS_IN)) {
-               debug("%s: could not find a /config/st,fastboot-gpios\n",
-                     __func__);
-       } else {
-               if (dm_gpio_get_value(&gpio)) {
-                       puts("Fastboot key pressed, ");
-                       boot_mode = BOOT_FASTBOOT;
-               }
+       if (IS_ENABLED(CONFIG_FASTBOOT)) {
+               if (gpio_request_by_name_nodev(node, "st,fastboot-gpios", 0,
+                                              &gpio, GPIOD_IS_IN)) {
+                       log_debug("could not find a /config/st,fastboot-gpios\n");
+               } else {
+                       udelay(20);
+                       if (dm_gpio_get_value(&gpio)) {
+                               log_notice("Fastboot key pressed, ");
+                               boot_mode = BOOT_FASTBOOT;
+                       }
 
-               dm_gpio_free(NULL, &gpio);
+                       dm_gpio_free(NULL, &gpio);
+               }
        }
-#endif
-#ifdef CONFIG_CMD_STM32PROG
-       if (gpio_request_by_name_nodev(node, "st,stm32prog-gpios", 0,
-                                      &gpio, GPIOD_IS_IN)) {
-               debug("%s: could not find a /config/st,stm32prog-gpios\n",
-                     __func__);
-       } else {
-               if (dm_gpio_get_value(&gpio)) {
-                       puts("STM32Programmer key pressed, ");
-                       boot_mode = BOOT_STM32PROG;
+       if (IS_ENABLED(CONFIG_CMD_STM32PROG)) {
+               if (gpio_request_by_name_nodev(node, "st,stm32prog-gpios", 0,
+                                              &gpio, GPIOD_IS_IN)) {
+                       log_debug("could not find a /config/st,stm32prog-gpios\n");
+               } else {
+                       udelay(20);
+                       if (dm_gpio_get_value(&gpio)) {
+                               log_notice("STM32Programmer key pressed, ");
+                               boot_mode = BOOT_STM32PROG;
+                       }
+                       dm_gpio_free(NULL, &gpio);
                }
-               dm_gpio_free(NULL, &gpio);
        }
-#endif
-
        if (boot_mode != BOOT_NORMAL) {
-               puts("entering download mode...\n");
+               log_notice("entering download mode...\n");
                clrsetbits_le32(TAMP_BOOT_CONTEXT,
                                TAMP_BOOT_FORCED_MASK,
                                boot_mode);
        }
-#endif
 }
 
-#if defined(CONFIG_USB_GADGET) && defined(CONFIG_USB_GADGET_DWC2_OTG)
-#include <usb/dwc2_udc.h>
 int g_dnl_board_usb_cable_connected(void)
 {
        struct udevice *dwc2_udc_otg;
        int ret;
 
+       if (!IS_ENABLED(CONFIG_USB_GADGET_DWC2_OTG))
+               return -ENODEV;
+
        /* if typec stusb160x is present, means DK1 or DK2 board */
        ret = stusb160x_cable_connected();
        if (ret >= 0)
                return ret;
 
        ret = uclass_get_device_by_driver(UCLASS_USB_GADGET_GENERIC,
-                                         DM_GET_DRIVER(dwc2_udc_otg),
+                                         DM_DRIVER_GET(dwc2_udc_otg),
                                          &dwc2_udc_otg);
-       if (!ret)
-               debug("dwc2_udc_otg init failed\n");
+       if (ret) {
+               log_debug("dwc2_udc_otg init failed\n");
+               return ret;
+       }
 
        return dwc2_udc_B_session_valid(dwc2_udc_otg);
 }
 
+#ifdef CONFIG_USB_GADGET_DOWNLOAD
 #define STM32MP1_G_DNL_DFU_PRODUCT_NUM 0xdf11
 #define STM32MP1_G_DNL_FASTBOOT_PRODUCT_NUM 0x0afb
 
 int g_dnl_bind_fixup(struct usb_device_descriptor *dev, const char *name)
 {
-       if (!strcmp(name, "usb_dnl_dfu"))
+       if (IS_ENABLED(CONFIG_DFU_OVER_USB) &&
+           !strcmp(name, "usb_dnl_dfu"))
                put_unaligned(STM32MP1_G_DNL_DFU_PRODUCT_NUM, &dev->idProduct);
-       else if (!strcmp(name, "usb_dnl_fastboot"))
+       else if (IS_ENABLED(CONFIG_FASTBOOT) &&
+                !strcmp(name, "usb_dnl_fastboot"))
                put_unaligned(STM32MP1_G_DNL_FASTBOOT_PRODUCT_NUM,
                              &dev->idProduct);
        else
@@ -218,23 +233,21 @@ int g_dnl_bind_fixup(struct usb_device_descriptor *dev, const char *name)
 
        return 0;
 }
-
-#endif /* CONFIG_USB_GADGET */
+#endif /* CONFIG_USB_GADGET_DOWNLOAD */
 
 static int get_led(struct udevice **dev, char *led_string)
 {
-       char *led_name;
+       const char *led_name;
        int ret;
 
-       led_name = fdtdec_get_config_string(gd->fdt_blob, led_string);
+       led_name = ofnode_conf_read_str(led_string);
        if (!led_name) {
-               pr_debug("%s: could not find %s config string\n",
-                        __func__, led_string);
+               log_debug("could not find %s config string\n", led_string);
                return -ENOENT;
        }
        ret = led_get_by_label(led_name, dev);
        if (ret) {
-               debug("%s: get=%d\n", __func__, ret);
+               log_debug("get=%d\n", ret);
                return ret;
        }
 
@@ -285,46 +298,19 @@ static void __maybe_unused led_error_blink(u32 nb_blink)
                hang();
 }
 
-#ifdef CONFIG_ADC
-static int board_check_usb_power(void)
+static int adc_measurement(ofnode node, int adc_count, int *min_uV, int *max_uV)
 {
        struct ofnode_phandle_args adc_args;
        struct udevice *adc;
-       ofnode node;
        unsigned int raw;
-       int max_uV = 0;
-       int min_uV = USB_START_HIGH_THRESHOLD_UV;
-       int ret, uV, adc_count;
-       u32 nb_blink;
-       u8 i;
-       node = ofnode_path("/config");
-       if (!ofnode_valid(node)) {
-               debug("%s: no /config node?\n", __func__);
-               return -ENOENT;
-       }
-
-       /*
-        * Retrieve the ADC channels devices and get measurement
-        * for each of them
-        */
-       adc_count = ofnode_count_phandle_with_args(node, "st,adc_usb_pd",
-                                                  "#io-channel-cells");
-       if (adc_count < 0) {
-               if (adc_count == -ENOENT)
-                       return 0;
-
-               pr_err("%s: can't find adc channel (%d)\n", __func__,
-                      adc_count);
-
-               return adc_count;
-       }
+       int ret, uV;
+       int i;
 
        for (i = 0; i < adc_count; i++) {
                if (ofnode_parse_phandle_with_args(node, "st,adc_usb_pd",
                                                   "#io-channel-cells", 0, i,
                                                   &adc_args)) {
-                       pr_debug("%s: can't find /config/st,adc_usb_pd\n",
-                                __func__);
+                       log_debug("can't find /config/st,adc_usb_pd\n");
                        return 0;
                }
 
@@ -332,44 +318,90 @@ static int board_check_usb_power(void)
                                                  &adc);
 
                if (ret) {
-                       pr_err("%s: Can't get adc device(%d)\n", __func__,
-                              ret);
+                       log_err("Can't get adc device(%d)\n", ret);
                        return ret;
                }
 
                ret = adc_channel_single_shot(adc->name, adc_args.args[0],
                                              &raw);
                if (ret) {
-                       pr_err("%s: single shot failed for %s[%d]!\n",
-                              __func__, adc->name, adc_args.args[0]);
+                       log_err("single shot failed for %s[%d]!\n",
+                               adc->name, adc_args.args[0]);
                        return ret;
                }
                /* Convert to uV */
                if (!adc_raw_to_uV(adc, raw, &uV)) {
-                       if (uV > max_uV)
-                               max_uV = uV;
-                       if (uV < min_uV)
-                               min_uV = uV;
-                       pr_debug("%s: %s[%02d] = %u, %d uV\n", __func__,
-                                adc->name, adc_args.args[0], raw, uV);
+                       if (uV > *max_uV)
+                               *max_uV = uV;
+                       if (uV < *min_uV)
+                               *min_uV = uV;
+                       log_debug("%s[%02d] = %u, %d uV\n",
+                                 adc->name, adc_args.args[0], raw, uV);
                } else {
-                       pr_err("%s: Can't get uV value for %s[%d]\n",
-                              __func__, adc->name, adc_args.args[0]);
+                       log_err("Can't get uV value for %s[%d]\n",
+                               adc->name, adc_args.args[0]);
                }
        }
 
+       return 0;
+}
+
+static int board_check_usb_power(void)
+{
+       ofnode node;
+       int max_uV = 0;
+       int min_uV = USB_START_HIGH_THRESHOLD_UV;
+       int adc_count, ret;
+       u32 nb_blink;
+       u8 i;
+
+       if (!IS_ENABLED(CONFIG_ADC))
+               return -ENODEV;
+
+       node = ofnode_path("/config");
+       if (!ofnode_valid(node)) {
+               log_debug("no /config node?\n");
+               return -ENOENT;
+       }
+
        /*
-        * If highest value is inside 1.23 Volts and 2.10 Volts, that means
-        * board is plugged on an USB-C 3A power supply and boot process can
-        * continue.
+        * Retrieve the ADC channels devices and get measurement
+        * for each of them
         */
-       if (max_uV > USB_START_LOW_THRESHOLD_UV &&
-           max_uV <= USB_START_HIGH_THRESHOLD_UV &&
-           min_uV <= USB_LOW_THRESHOLD_UV)
-               return 0;
+       adc_count = ofnode_count_phandle_with_args(node, "st,adc_usb_pd",
+                                                  "#io-channel-cells", 0);
+       if (adc_count < 0) {
+               if (adc_count == -ENOENT)
+                       return 0;
+
+               log_err("Can't find adc channel (%d)\n", adc_count);
+
+               return adc_count;
+       }
+
+       /* perform maximum of 2 ADC measurements to detect power supply current */
+       for (i = 0; i < 2; i++) {
+               ret = adc_measurement(node, adc_count, &min_uV, &max_uV);
+               if (ret)
+                       return ret;
+
+               /*
+                * If highest value is inside 1.23 Volts and 2.10 Volts, that means
+                * board is plugged on an USB-C 3A power supply and boot process can
+                * continue.
+                */
+               if (max_uV > USB_START_LOW_THRESHOLD_UV &&
+                   max_uV <= USB_START_HIGH_THRESHOLD_UV &&
+                   min_uV <= USB_LOW_THRESHOLD_UV)
+                       return 0;
 
-       pr_err("****************************************************\n");
+               if (i == 0) {
+                       log_err("Previous ADC measurements was not the one expected, retry in 20ms\n");
+                       mdelay(20);  /* equal to max tPDDebounce duration (min 10ms - max 20ms) */
+               }
+       }
 
+       log_notice("****************************************************\n");
        /*
         * If highest and lowest value are either both below
         * USB_LOW_THRESHOLD_UV or both above USB_LOW_THRESHOLD_UV, that
@@ -380,8 +412,8 @@ static int board_check_usb_power(void)
             min_uV > USB_LOW_THRESHOLD_UV) ||
             (max_uV <= USB_LOW_THRESHOLD_UV &&
             min_uV <= USB_LOW_THRESHOLD_UV)) {
-               pr_err("* ERROR USB TYPE-C connection in unattached mode   *\n");
-               pr_err("* Check that USB TYPE-C cable is correctly plugged *\n");
+               log_notice("* ERROR USB TYPE-C connection in unattached mode   *\n");
+               log_notice("* Check that USB TYPE-C cable is correctly plugged *\n");
                /* with 125ms interval, led will blink for 17.02 years ....*/
                nb_blink = U32_MAX;
        }
@@ -389,14 +421,14 @@ static int board_check_usb_power(void)
        if (max_uV > USB_LOW_THRESHOLD_UV &&
            max_uV <= USB_WARNING_LOW_THRESHOLD_UV &&
            min_uV <= USB_LOW_THRESHOLD_UV) {
-               pr_err("*        WARNING 500mA power supply detected       *\n");
+               log_notice("*        WARNING 500mA power supply detected       *\n");
                nb_blink = 2;
        }
 
        if (max_uV > USB_WARNING_LOW_THRESHOLD_UV &&
            max_uV <= USB_START_LOW_THRESHOLD_UV &&
            min_uV <= USB_LOW_THRESHOLD_UV) {
-               pr_err("*       WARNING 1.5A power supply detected        *\n");
+               log_notice("*       WARNING 1.5A power supply detected        *\n");
                nb_blink = 3;
        }
 
@@ -405,32 +437,28 @@ static int board_check_usb_power(void)
         * supplies more than 3 Amp, this is not compliant with TypeC specification
         */
        if (max_uV > USB_START_HIGH_THRESHOLD_UV) {
-               pr_err("*      USB TYPE-C charger not compliant with       *\n");
-               pr_err("*                   specification                  *\n");
-               pr_err("****************************************************\n\n");
+               log_notice("*      USB TYPE-C charger not compliant with       *\n");
+               log_notice("*                   specification                  *\n");
+               log_notice("****************************************************\n\n");
                /* with 125ms interval, led will blink for 17.02 years ....*/
                nb_blink = U32_MAX;
        } else {
-               pr_err("*     Current too low, use a 3A power supply!      *\n");
-               pr_err("****************************************************\n\n");
+               log_notice("*     Current too low, use a 3A power supply!      *\n");
+               log_notice("****************************************************\n\n");
        }
 
        led_error_blink(nb_blink);
 
        return 0;
 }
-#endif /* CONFIG_ADC */
 
 static void sysconf_init(void)
 {
-#ifndef CONFIG_TFABOOT
        u8 *syscfg;
-#ifdef CONFIG_DM_REGULATOR
        struct udevice *pwr_dev;
        struct udevice *pwr_reg;
        struct udevice *dev;
        u32 otp = 0;
-#endif
        int ret;
        u32 bootr, val;
 
@@ -448,7 +476,6 @@ static void sysconf_init(void)
        bootr |= (bootr & SYSCFG_BOOTR_BOOT_MASK) << SYSCFG_BOOTR_BOOTPD_SHIFT;
        writel(bootr, syscfg + SYSCFG_BOOTR);
 
-#ifdef CONFIG_DM_REGULATOR
        /* High Speed Low Voltage Pad mode Enable for SPI, SDMMC, ETH, QSPI
         * and TRACE. Needed above ~50MHz and conditioned by AFMUX selection.
         * The customer will have to disable this for low frequencies
@@ -463,14 +490,14 @@ static void sysconf_init(void)
         *      but this value need to be consistent with board design
         */
        ret = uclass_get_device_by_driver(UCLASS_PMIC,
-                                         DM_GET_DRIVER(stm32mp_pwr_pmic),
+                                         DM_DRIVER_GET(stm32mp_pwr_pmic),
                                          &pwr_dev);
-       if (!ret) {
+       if (!ret && IS_ENABLED(CONFIG_DM_REGULATOR)) {
                ret = uclass_get_device_by_driver(UCLASS_MISC,
-                                                 DM_GET_DRIVER(stm32mp_bsec),
+                                                 DM_DRIVER_GET(stm32mp_bsec),
                                                  &dev);
                if (ret) {
-                       pr_err("Can't find stm32mp_bsec driver\n");
+                       log_err("Can't find stm32mp_bsec driver\n");
                        return;
                }
 
@@ -493,16 +520,15 @@ static void sysconf_init(void)
                                       syscfg + SYSCFG_IOCTRLSETR);
 
                                if (!otp)
-                                       pr_err("product_below_2v5=0: HSLVEN protected by HW\n");
+                                       log_err("product_below_2v5=0: HSLVEN protected by HW\n");
                        } else {
                                if (otp)
-                                       pr_err("product_below_2v5=1: HSLVEN update is destructive, no update as VDD>2.7V\n");
+                                       log_err("product_below_2v5=1: HSLVEN update is destructive, no update as VDD>2.7V\n");
                        }
                } else {
-                       debug("VDD unknown");
+                       log_debug("VDD unknown");
                }
        }
-#endif
 
        /* activate automatic I/O compensation
         * warning: need to ensure CSI enabled and ready in clock driver
@@ -514,15 +540,13 @@ static void sysconf_init(void)
                                 val & SYSCFG_CMPCR_READY,
                                 1000000);
        if (ret) {
-               pr_err("SYSCFG: I/O compensation failed, timeout.\n");
+               log_err("SYSCFG: I/O compensation failed, timeout.\n");
                led_error_blink(10);
        }
 
        clrbits_le32(syscfg + SYSCFG_CMPCR, SYSCFG_CMPCR_SW_CTRL);
-#endif
 }
 
-#ifdef CONFIG_DM_REGULATOR
 /* Fix to make I2C1 usable on DK2 for touchscreen usage in kernel */
 static int dk2_i2c1_fix(void)
 {
@@ -530,41 +554,42 @@ static int dk2_i2c1_fix(void)
        struct gpio_desc hdmi, audio;
        int ret = 0;
 
+       if (!IS_ENABLED(CONFIG_DM_REGULATOR))
+               return -ENODEV;
+
        node = ofnode_path("/soc/i2c@40012000/hdmi-transmitter@39");
        if (!ofnode_valid(node)) {
-               pr_debug("%s: no hdmi-transmitter@39 ?\n", __func__);
+               log_debug("no hdmi-transmitter@39 ?\n");
                return -ENOENT;
        }
 
        if (gpio_request_by_name_nodev(node, "reset-gpios", 0,
                                       &hdmi, GPIOD_IS_OUT)) {
-               pr_debug("%s: could not find reset-gpios\n",
-                        __func__);
+               log_debug("could not find reset-gpios\n");
                return -ENOENT;
        }
 
        node = ofnode_path("/soc/i2c@40012000/cs42l51@4a");
        if (!ofnode_valid(node)) {
-               pr_debug("%s: no cs42l51@4a ?\n", __func__);
+               log_debug("no cs42l51@4a ?\n");
                return -ENOENT;
        }
 
        if (gpio_request_by_name_nodev(node, "reset-gpios", 0,
                                       &audio, GPIOD_IS_OUT)) {
-               pr_debug("%s: could not find reset-gpios\n",
-                        __func__);
+               log_debug("could not find reset-gpios\n");
                return -ENOENT;
        }
 
        /* before power up, insure that HDMI and AUDIO IC is under reset */
        ret = dm_gpio_set_value(&hdmi, 1);
        if (ret) {
-               pr_err("%s: can't set_value for hdmi_nrst gpio", __func__);
+               log_err("can't set_value for hdmi_nrst gpio");
                goto error;
        }
        ret = dm_gpio_set_value(&audio, 1);
        if (ret) {
-               pr_err("%s: can't set_value for audio_nrst gpio", __func__);
+               log_err("can't set_value for audio_nrst gpio");
                goto error;
        }
 
@@ -587,7 +612,6 @@ static bool board_is_dk2(void)
 
        return false;
 }
-#endif
 
 static bool board_is_ev1(void)
 {
@@ -618,31 +642,29 @@ static void board_ev1_init(void)
        struct udevice *dev;
 
        /* configure IRQ line on EV1 for touchscreen before LCD reset */
-       uclass_get_device_by_driver(UCLASS_NOP, DM_GET_DRIVER(goodix), &dev);
+       uclass_get_device_by_driver(UCLASS_NOP, DM_DRIVER_GET(goodix), &dev);
 }
 
 /* board dependent setup after realloc */
 int board_init(void)
 {
-       /* address of boot parameters */
-       gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
-
-       if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
-               gpio_hog_probe_all();
-
        board_key_check();
 
        if (board_is_ev1())
                board_ev1_init();
 
-#ifdef CONFIG_DM_REGULATOR
        if (board_is_dk2())
                dk2_i2c1_fix();
 
-       regulators_enable_boot_on(_DEBUG);
-#endif
+       if (IS_ENABLED(CONFIG_DM_REGULATOR))
+               regulators_enable_boot_on(_DEBUG);
 
-       sysconf_init();
+       /*
+        * sysconf initialisation done only when U-Boot is running in secure
+        * done in TF-A for TFABOOT.
+        */
+       if (IS_ENABLED(CONFIG_ARMV7_NONSEC))
+               sysconf_init();
 
        if (CONFIG_IS_ENABLED(LED))
                led_default_state();
@@ -654,52 +676,50 @@ int board_init(void)
 
 int board_late_init(void)
 {
-#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
        const void *fdt_compat;
        int fdt_compat_len;
        int ret;
        u32 otp;
        struct udevice *dev;
        char buf[10];
+       char dtb_name[256];
+       int buf_len;
+
+       if (IS_ENABLED(CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG)) {
+               fdt_compat = fdt_getprop(gd->fdt_blob, 0, "compatible",
+                                        &fdt_compat_len);
+               if (fdt_compat && fdt_compat_len) {
+                       if (strncmp(fdt_compat, "st,", 3) != 0) {
+                               env_set("board_name", fdt_compat);
+                       } else {
+                               env_set("board_name", fdt_compat + 3);
 
-       fdt_compat = fdt_getprop(gd->fdt_blob, 0, "compatible",
-                                &fdt_compat_len);
-       if (fdt_compat && fdt_compat_len) {
-               if (strncmp(fdt_compat, "st,", 3) != 0) {
-                       env_set("board_name", fdt_compat);
-               } else {
-                       char dtb_name[256];
-                       int buf_len = sizeof(dtb_name);
+                               buf_len = sizeof(dtb_name);
+                               strncpy(dtb_name, fdt_compat + 3, buf_len);
+                               buf_len -= strlen(fdt_compat + 3);
+                               strncat(dtb_name, ".dtb", buf_len);
+                               env_set("fdtfile", dtb_name);
+                       }
+               }
+               ret = uclass_get_device_by_driver(UCLASS_MISC,
+                                                 DM_DRIVER_GET(stm32mp_bsec),
+                                                 &dev);
 
-                       env_set("board_name", fdt_compat + 3);
+               if (!ret)
+                       ret = misc_read(dev, STM32_BSEC_SHADOW(BSEC_OTP_BOARD),
+                                       &otp, sizeof(otp));
+               if (ret > 0 && otp) {
+                       snprintf(buf, sizeof(buf), "0x%04x", otp >> 16);
+                       env_set("board_id", buf);
 
-                       strncpy(dtb_name, fdt_compat + 3, buf_len);
-                       buf_len -= strlen(fdt_compat + 3);
-                       strncat(dtb_name, ".dtb", buf_len);
-                       env_set("fdtfile", dtb_name);
+                       snprintf(buf, sizeof(buf), "0x%04x",
+                                ((otp >> 8) & 0xF) - 1 + 0xA);
+                       env_set("board_rev", buf);
                }
        }
-       ret = uclass_get_device_by_driver(UCLASS_MISC,
-                                         DM_GET_DRIVER(stm32mp_bsec),
-                                         &dev);
 
-       if (!ret)
-               ret = misc_read(dev, STM32_BSEC_SHADOW(BSEC_OTP_BOARD),
-                               &otp, sizeof(otp));
-       if (ret > 0 && otp) {
-               snprintf(buf, sizeof(buf), "0x%04x", otp >> 16);
-               env_set("board_id", buf);
-
-               snprintf(buf, sizeof(buf), "0x%04x",
-                        ((otp >> 8) & 0xF) - 1 + 0xA);
-               env_set("board_rev", buf);
-       }
-#endif
-
-#ifdef CONFIG_ADC
        /* for DK1/DK2 boards */
        board_check_usb_power();
-#endif /* CONFIG_ADC */
 
        return 0;
 }
@@ -719,11 +739,11 @@ int board_interface_eth_init(struct udevice *dev,
        bool eth_ref_clk_sel_reg = false;
 
        /* Gigabit Ethernet 125MHz clock selection. */
-       eth_clk_sel_reg = dev_read_bool(dev, "st,eth_clk_sel");
+       eth_clk_sel_reg = dev_read_bool(dev, "st,eth-clk-sel");
 
        /* Ethernet 50Mhz RMII clock selection */
        eth_ref_clk_sel_reg =
-               dev_read_bool(dev, "st,eth_ref_clk_sel");
+               dev_read_bool(dev, "st,eth-ref-clk-sel");
 
        syscfg = (u8 *)syscon_get_first_range(STM32MP_SYSCON_SYSCFG);
 
@@ -734,7 +754,7 @@ int board_interface_eth_init(struct udevice *dev,
        case PHY_INTERFACE_MODE_MII:
                value = SYSCFG_PMCSETR_ETH_SEL_GMII_MII |
                        SYSCFG_PMCSETR_ETH_REF_CLK_SEL;
-               debug("%s: PHY_INTERFACE_MODE_MII\n", __func__);
+               log_debug("PHY_INTERFACE_MODE_MII\n");
                break;
        case PHY_INTERFACE_MODE_GMII:
                if (eth_clk_sel_reg)
@@ -742,7 +762,7 @@ int board_interface_eth_init(struct udevice *dev,
                                SYSCFG_PMCSETR_ETH_CLK_SEL;
                else
                        value = SYSCFG_PMCSETR_ETH_SEL_GMII_MII;
-               debug("%s: PHY_INTERFACE_MODE_GMII\n", __func__);
+               log_debug("PHY_INTERFACE_MODE_GMII\n");
                break;
        case PHY_INTERFACE_MODE_RMII:
                if (eth_ref_clk_sel_reg)
@@ -750,7 +770,7 @@ int board_interface_eth_init(struct udevice *dev,
                                SYSCFG_PMCSETR_ETH_REF_CLK_SEL;
                else
                        value = SYSCFG_PMCSETR_ETH_SEL_RMII;
-               debug("%s: PHY_INTERFACE_MODE_RMII\n", __func__);
+               log_debug("PHY_INTERFACE_MODE_RMII\n");
                break;
        case PHY_INTERFACE_MODE_RGMII:
        case PHY_INTERFACE_MODE_RGMII_ID:
@@ -761,11 +781,11 @@ int board_interface_eth_init(struct udevice *dev,
                                SYSCFG_PMCSETR_ETH_CLK_SEL;
                else
                        value = SYSCFG_PMCSETR_ETH_SEL_RGMII;
-               debug("%s: PHY_INTERFACE_MODE_RGMII\n", __func__);
+               log_debug("PHY_INTERFACE_MODE_RGMII\n");
                break;
        default:
-               debug("%s: Do not manage %d interface\n",
-                     __func__, interface_type);
+               log_debug("Do not manage %d interface\n",
+                         interface_type);
                /* Do not manage others interfaces */
                return -EINVAL;
        }
@@ -787,31 +807,33 @@ enum env_location env_get_location(enum env_operation op, int prio)
                return ENVL_UNKNOWN;
 
        switch (bootmode & TAMP_BOOT_DEVICE_MASK) {
-#if CONFIG_IS_ENABLED(ENV_IS_IN_MMC)
        case BOOT_FLASH_SD:
        case BOOT_FLASH_EMMC:
-               return ENVL_MMC;
-#endif
-#if CONFIG_IS_ENABLED(ENV_IS_IN_EXT4)
-       case BOOT_FLASH_SD:
-       case BOOT_FLASH_EMMC:
-               return ENVL_EXT4;
-#endif
-#if CONFIG_IS_ENABLED(ENV_IS_IN_UBI)
+               if (CONFIG_IS_ENABLED(ENV_IS_IN_MMC))
+                       return ENVL_MMC;
+               else if (CONFIG_IS_ENABLED(ENV_IS_IN_EXT4))
+                       return ENVL_EXT4;
+               else
+                       return ENVL_NOWHERE;
+
        case BOOT_FLASH_NAND:
        case BOOT_FLASH_SPINAND:
-               return ENVL_UBI;
-#endif
-#if CONFIG_IS_ENABLED(ENV_IS_IN_SPI_FLASH)
+               if (CONFIG_IS_ENABLED(ENV_IS_IN_UBI))
+                       return ENVL_UBI;
+               else
+                       return ENVL_NOWHERE;
+
        case BOOT_FLASH_NOR:
-               return ENVL_SPI_FLASH;
-#endif
+               if (CONFIG_IS_ENABLED(ENV_IS_IN_SPI_FLASH))
+                       return ENVL_SPI_FLASH;
+               else
+                       return ENVL_NOWHERE;
+
        default:
                return ENVL_NOWHERE;
        }
 }
 
-#if defined(CONFIG_ENV_IS_IN_EXT4)
 const char *env_ext4_get_intf(void)
 {
        u32 bootmode = get_bootmode();
@@ -825,35 +847,76 @@ const char *env_ext4_get_intf(void)
        }
 }
 
+int mmc_get_boot(void)
+{
+       struct udevice *dev;
+       u32 boot_mode = get_bootmode();
+       unsigned int instance = (boot_mode & TAMP_BOOT_INSTANCE_MASK) - 1;
+       char cmd[20];
+       const u32 sdmmc_addr[] = {
+               STM32_SDMMC1_BASE,
+               STM32_SDMMC2_BASE,
+               STM32_SDMMC3_BASE
+       };
+
+       if (instance > ARRAY_SIZE(sdmmc_addr))
+               return 0;
+
+       /* search associated sdmmc node in devicetree */
+       snprintf(cmd, sizeof(cmd), "mmc@%x", sdmmc_addr[instance]);
+       if (uclass_get_device_by_name(UCLASS_MMC, cmd, &dev)) {
+               log_err("mmc%d = %s not found in device tree!\n", instance, cmd);
+               return 0;
+       }
+
+       return dev_seq(dev);
+};
+
 const char *env_ext4_get_dev_part(void)
 {
+       static char *const env_dev_part =
+#ifdef CONFIG_ENV_EXT4_DEVICE_AND_PART
+               CONFIG_ENV_EXT4_DEVICE_AND_PART;
+#else
+               "";
+#endif
        static char *const dev_part[] = {"0:auto", "1:auto", "2:auto"};
-       u32 bootmode = get_bootmode();
 
-       return dev_part[(bootmode & TAMP_BOOT_INSTANCE_MASK) - 1];
+       if (strlen(env_dev_part) > 0)
+               return env_dev_part;
+
+       return dev_part[mmc_get_boot()];
 }
-#endif
 
-#if defined(CONFIG_ENV_IS_IN_MMC)
 int mmc_get_env_dev(void)
 {
-       u32 bootmode = get_bootmode();
+       if (CONFIG_SYS_MMC_ENV_DEV >= 0)
+               return CONFIG_SYS_MMC_ENV_DEV;
 
-       return (bootmode & TAMP_BOOT_INSTANCE_MASK) - 1;
+       /* use boot instance to select the correct mmc device identifier */
+       return mmc_get_boot();
 }
-#endif
 
 #if defined(CONFIG_OF_BOARD_SETUP)
 int ft_board_setup(void *blob, struct bd_info *bd)
 {
-#ifdef CONFIG_FDT_FIXUP_PARTITIONS
-       struct node_info nodes[] = {
+       static const struct node_info nodes[] = {
                { "st,stm32f469-qspi",          MTD_DEV_TYPE_NOR,  },
                { "st,stm32f469-qspi",          MTD_DEV_TYPE_SPINAND},
                { "st,stm32mp15-fmc2",          MTD_DEV_TYPE_NAND, },
+               { "st,stm32mp1-fmc2-nfc",       MTD_DEV_TYPE_NAND, },
        };
-       fdt_fixup_mtdparts(blob, nodes, ARRAY_SIZE(nodes));
-#endif
+       char *boot_device;
+
+       /* Check the boot-source and don't update MTD for serial or usb boot */
+       boot_device = env_get("boot_device");
+       if (!boot_device ||
+           (strcmp(boot_device, "serial") && strcmp(boot_device, "usb")))
+               if (IS_ENABLED(CONFIG_FDT_FIXUP_PARTITIONS))
+                       fdt_fixup_mtdparts(blob, nodes, ARRAY_SIZE(nodes));
+
+       if (CONFIG_IS_ENABLED(FDT_SIMPLEFB))
+               fdt_simplefb_enable_and_mem_rsv(blob);
 
        return 0;
 }
@@ -865,14 +928,14 @@ static void board_copro_image_process(ulong fw_image, size_t fw_size)
 
        if (!rproc_is_initialized())
                if (rproc_init()) {
-                       printf("Remote Processor %d initialization failed\n",
-                              id);
+                       log_err("Remote Processor %d initialization failed\n",
+                               id);
                        return;
                }
 
        ret = rproc_load(id, fw_image, fw_size);
-       printf("Load Remote Processor %d with data@addr=0x%08lx %u bytes:%s\n",
-              id, fw_image, fw_size, ret ? " Failed!" : " Success!");
+       log_err("Load Remote Processor %d with data@addr=0x%08lx %u bytes:%s\n",
+               id, fw_image, fw_size, ret ? " Failed!" : " Success!");
 
        if (!ret)
                rproc_start(id);