Fix emulator build error

[platform/framework/web/chromium-efl.git] / base / version_unittest.cc

diff --git a/base/version_unittest.cc b/base/version_unittest.cc
index 285ca9c..b320edd 100644 (file)
--- a/base/version_unittest.cc
+++ b/base/version_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -8,7 +8,6 @@
 #include <stdint.h>
 #include <utility>
 
-#include "base/macros.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
@@ -75,12 +74,12 @@ TEST(VersionTest, GetVersionFromString) {
     {"15.5.28.130162", 4, 15, true},
   };
 
-  for (size_t i = 0; i < arraysize(cases); ++i) {
-    base::Version version(cases[i].input);
-    EXPECT_EQ(cases[i].success, version.IsValid());
-    if (cases[i].success) {
-      EXPECT_EQ(cases[i].parts, version.components().size());
-      EXPECT_EQ(cases[i].firstpart, version.components()[0]);
+  for (const auto& i : cases) {
+    base::Version version(i.input);
+    EXPECT_EQ(i.success, version.IsValid());
+    if (i.success) {
+      EXPECT_EQ(i.parts, version.components().size());
+      EXPECT_EQ(i.firstpart, version.components()[0]);
     }
   }
 }
@@ -105,44 +104,43 @@ TEST(VersionTest, Compare) {
       {"11.0.10", "15.5.28.130162", -1},
       {"15.5.28.130162", "15.5.28.130162", 0},
   };
-  for (size_t i = 0; i < arraysize(cases); ++i) {
-    base::Version lhs(cases[i].lhs);
-    base::Version rhs(cases[i].rhs);
-    EXPECT_EQ(lhs.CompareTo(rhs), cases[i].expected) <<
-        cases[i].lhs << " ? " << cases[i].rhs;
+  for (const auto& i : cases) {
+    base::Version lhs(i.lhs);
+    base::Version rhs(i.rhs);
+    EXPECT_EQ(lhs.CompareTo(rhs), i.expected) << i.lhs << " ? " << i.rhs;
     // CompareToWildcardString() should have same behavior as CompareTo() when
     // no wildcards are present.
-    EXPECT_EQ(lhs.CompareToWildcardString(cases[i].rhs), cases[i].expected)
-        << cases[i].lhs << " ? " << cases[i].rhs;
-    EXPECT_EQ(rhs.CompareToWildcardString(cases[i].lhs), -cases[i].expected)
-        << cases[i].lhs << " ? " << cases[i].rhs;
+    EXPECT_EQ(lhs.CompareToWildcardString(i.rhs), i.expected)
+        << i.lhs << " ? " << i.rhs;
+    EXPECT_EQ(rhs.CompareToWildcardString(i.lhs), -i.expected)
+        << i.lhs << " ? " << i.rhs;
 
     // Test comparison operators
-    switch (cases[i].expected) {
-    case -1:
-      EXPECT_LT(lhs, rhs);
-      EXPECT_LE(lhs, rhs);
-      EXPECT_NE(lhs, rhs);
-      EXPECT_FALSE(lhs == rhs);
-      EXPECT_FALSE(lhs >= rhs);
-      EXPECT_FALSE(lhs > rhs);
-      break;
-    case 0:
-      EXPECT_FALSE(lhs < rhs);
-      EXPECT_LE(lhs, rhs);
-      EXPECT_FALSE(lhs != rhs);
-      EXPECT_EQ(lhs, rhs);
-      EXPECT_GE(lhs, rhs);
-      EXPECT_FALSE(lhs > rhs);
-      break;
-    case 1:
-      EXPECT_FALSE(lhs < rhs);
-      EXPECT_FALSE(lhs <= rhs);
-      EXPECT_NE(lhs, rhs);
-      EXPECT_FALSE(lhs == rhs);
-      EXPECT_GE(lhs, rhs);
-      EXPECT_GT(lhs, rhs);
-      break;
+    switch (i.expected) {
+      case -1:
+        EXPECT_LT(lhs, rhs);
+        EXPECT_LE(lhs, rhs);
+        EXPECT_NE(lhs, rhs);
+        EXPECT_FALSE(lhs == rhs);
+        EXPECT_FALSE(lhs >= rhs);
+        EXPECT_FALSE(lhs > rhs);
+        break;
+      case 0:
+        EXPECT_FALSE(lhs < rhs);
+        EXPECT_LE(lhs, rhs);
+        EXPECT_FALSE(lhs != rhs);
+        EXPECT_EQ(lhs, rhs);
+        EXPECT_GE(lhs, rhs);
+        EXPECT_FALSE(lhs > rhs);
+        break;
+      case 1:
+        EXPECT_FALSE(lhs < rhs);
+        EXPECT_FALSE(lhs <= rhs);
+        EXPECT_NE(lhs, rhs);
+        EXPECT_FALSE(lhs == rhs);
+        EXPECT_GE(lhs, rhs);
+        EXPECT_GT(lhs, rhs);
+        break;
     }
   }
 }
@@ -167,10 +165,10 @@ TEST(VersionTest, CompareToWildcardString) {
     {"1.3.9", "1.3.*", 0},
     {"1.2.0.0.0.0", "1.2.*", 0},
   };
-  for (size_t i = 0; i < arraysize(cases); ++i) {
-    const base::Version version(cases[i].lhs);
-    const int result = version.CompareToWildcardString(cases[i].rhs);
-    EXPECT_EQ(result, cases[i].expected) << cases[i].lhs << "?" << cases[i].rhs;
+  for (const auto& i : cases) {
+    const base::Version version(i.lhs);
+    const int result = version.CompareToWildcardString(i.rhs);
+    EXPECT_EQ(result, i.expected) << i.lhs << "?" << i.rhs;
   }
 }
 
@@ -191,9 +189,54 @@ TEST(VersionTest, IsValidWildcardString) {
     {"*", false},
     {"*.2", false},
   };
-  for (size_t i = 0; i < arraysize(cases); ++i) {
-    EXPECT_EQ(base::Version::IsValidWildcardString(cases[i].version),
-        cases[i].expected) << cases[i].version << "?" << cases[i].expected;
+  for (const auto& i : cases) {
+    EXPECT_EQ(base::Version::IsValidWildcardString(i.version), i.expected)
+        << i.version << "?" << i.expected;
+  }
+}
+
+TEST(VersionTest, LeadingZeros) {
+  {
+    // Leading zeros in the first component are not allowed.
+    base::Version v("01.1");
+    EXPECT_FALSE(v.IsValid());
+  }
+
+  {
+    // Leading zeros in subsequent components are allowed (and this behavior is
+    // now important for compatibility with existing modules, like extensions),
+    // but are ignored because the value is parsed as an integer...
+    base::Version v1("1.01");
+    EXPECT_TRUE(v1.IsValid());
+    // ...and as a result, v1.01 == v1.1.
+    EXPECT_EQ("1.1", v1.GetString());
+    base::Version v2("1.1");
+    EXPECT_EQ(v1, v2);
+  }
+
+  // Similarly, since leading zeros are ignored, v1.02 > v1.1 (because
+  // v1.02 is translated to 1.2).
+  EXPECT_GT(base::Version("1.02"), base::Version("1.1"));
+}
+
+TEST(VersionTest, GetString) {
+  static const struct version_compare {
+    const char* version;
+    bool valid;
+    const char* string;
+  } cases[] = {
+      {"", false, "invalid"},
+      {"1", true, "1"},
+      {"1.0", true, "1.0"},
+      {"0.0.1.0", true, "0.0.1.0"},
+      {"1.2.3.4.5.6", true, "1.2.3.4.5.6"},
+      {"1.*.3", false, "invalid"},
+  };
+
+  for (const auto& i : cases) {
+    base::Version v(i.version);
+    EXPECT_EQ(v.IsValid(), i.valid);
+    EXPECT_EQ(v.GetString(), i.string);
   }
 }