Changelog
-Version 7.40.0 (7 Jan 2015)
+Version 7.50.2 (7 Sep 2016)
-Daniel Stenberg (7 Jan 2015)
-- RELEASE-NOTES: version 7.40.0
+Daniel Stenberg (7 Sep 2016)
+- RELEASE-NOTES: curl 7.50.2 release
-- darwinssl: fix session ID keys to only reuse identical sessions
+- THANKS: updated for 7.50.2
+
+Jay Satiro (6 Sep 2016)
+- [Gaurav Malhotra brought this change]
+
+ openssl: fix CURLINFO_SSL_VERIFYRESULT
- ...to avoid a session ID getting cached without certificate checking and
- then after a subsequent _enabling_ of the check libcurl could still
- re-use the session done without cert checks.
+ CURLINFO_SSL_VERIFYRESULT does not get the certificate verification
+ result when SSL_connect fails because of a certificate verification
+ error.
- Bug: http://curl.haxx.se/docs/adv_20150108A.html
- Reported-by: Marc Hesse
-
-- tests: make sure CRLFs can't be used in URLs passed to proxy
+ This fix saves the result of SSL_get_verify_result so that it is
+ returned by CURLINFO_SSL_VERIFYRESULT.
- Bug: http://curl.haxx.se/docs/adv_20150108B.html
+ Closes https://github.com/curl/curl/pull/995
+
+Daniel Stenberg (6 Sep 2016)
+- [Daniel Gustafsson brought this change]
-- url-parsing: reject CRLFs within URLs
+ darwinssl: test for errSecSuccess in PKCS12 import rather than noErr (#993)
- Bug: http://curl.haxx.se/docs/adv_20150108B.html
- Reported-by: Andrey Labunets
+ While noErr and errSecSuccess are defined as the same value, the API
+ documentation states that SecPKCS12Import() returns errSecSuccess if
+ there were no errors in importing. Ensure that a future change of the
+ defined value doesn't break (however unlikely) and be consistent with
+ the API docs.
-Steve Holme (7 Jan 2015)
-- ldap: Convert attribute output to UTF-8 when Unicode
+- [Daniel Gustafsson brought this change]
-- ldap: Convert DN output to UTF-8 when Unicode
+ docs: Fix link to CONTRIBUTE in Github contribution guidelines (#994)
-Daniel Stenberg (7 Jan 2015)
-- hostip: remove 'stale' argument from Curl_fetch_addr proto
-
- Also, remove the log output of the resolved name is NOT in the cache in
- the spirit of only telling when something is actually happening.
+- [Marcel Raad brought this change]
-Steve Holme (7 Jan 2015)
-- ldap/imap: Fixed spelling mistake in comments and variable names
+ openssl: Fix compilation with OPENSSL_API_COMPAT=0x10100000L
- Reported-by: Michael Osipov
-
-Daniel Stenberg (7 Jan 2015)
-- RELEASE-NOTES: updated with ./contributors.sh output
-
-Dan Fandrich (5 Jan 2015)
-- curl_multibyte.h: Eliminated some trailing whitespace
+ With OPENSSL_API_COMPAT=0x10100000L (OpenSSL 1.1 API), the cleanup
+ functions are unavailable (they're no-ops anyway in OpenSSL 1.1). The
+ replacements for SSL_load_error_strings, SSLeay_add_ssl_algorithms, and
+ OpenSSL_add_all_algorithms are called automatically [1][2]. SSLeay() is
+ now called OpenSSL_version_num().
+
+ [1]: https://www.openssl.org/docs/man1.1.0/ssl/OPENSSL_init_ssl.html
+ [2]: https://www.openssl.org/docs/man1.1.0/crypto/OPENSSL_init_crypto.html
+
+ Closes #992
-Steve Holme (4 Jan 2015)
-- RELEASE-NOTES: Synced with ea93252ef1
+- RELEASE-NOTES: synced with 3d4c0c8b9bc1d
-- ldap: Fixed Unicode usage for all Win32 builds
+- http2: return EOF when done uploading without known size
- Otherwise, the fixes in the previous commits would only be applicable
- to IDN and SSPI based builds and not others such as OpenSSL with LDAP
- enabled.
+ Fixes #982
-- ldap: Fixed memory leak from commit efb64fdf80
+- http2: skip the content-length parsing, detect unknown size
-- ldap: Fix memory leak from commit 3a805c5cc1
+- http2: minor white space edit
-- ldap: Fixed attribute variable warnings when Unicode is enabled
-
- Use 'TCHAR *' for local attribute variable rather than 'char *'.
+- http2: use named define instead of magic constant in read callback
-- ldap: Fixed DN variable warnings when Unicode is enabled
-
- Use 'TCHAR *' for local DN variable rather than 'char *'.
+- [Craig Davison brought this change]
-- ldap: Remove the unescape_elements() function
+ configure: make the cpp -P detection not clobber CPPFLAGS
- Due to the recent modifications this function is no longer used.
-
-- ldap.c: Fixed compilation warning
+ CPPPFLAGS is now CPPPFLAG. Fixes CURL_CHECK_DEF.
- ldap.c:98: warning: extra tokens at end of #endif directive
+ Fixes #958
-- ldap: Fixed support for Unicode filter in Win32 search call
+- [Olivier Brunel brought this change]
-- ldap.c: Fixed compilation warning
+ speed caps: not based on average speeds anymore
- ldap.c:802: warning: comparison between signed and unsigned integer
- expressions
-
-- ldap: Fixed support for Unicode attributes in Win32 search call
-
-- ldap: Fixed memory leak from commit efb64fdf80
+ Speed limits (from CURLOPT_MAX_RECV_SPEED_LARGE &
+ CURLOPT_MAX_SEND_SPEED_LARGE) were applied simply by comparing limits
+ with the cumulative average speed of the entire transfer; While this
+ might work at times with good/constant connections, in other cases it
+ can result to the limits simply being "ignored" for more than "short
+ bursts" (as told in man page).
- The unescapped DN was not freed after a successful character conversion.
-
-- ldap.c: Fixed compilation error
+ Consider a download that goes on much slower than the limit for some
+ time (because bandwidth is used elsewhere, server is slow, whatever the
+ reason), then once things get better, curl would simply ignore the limit
+ up until the average speed (since the beginning of the transfer) reached
+ the limit. This could prove the limit useless to effectively avoid
+ using the entire bandwidth (at least for quite some time).
- ldap.c:738: error: macro "LDAP_TRACE" passed 2 arguments, but takes
- just 1
-
-- ldap.c: Fixed compilation warning
+ So instead, we now use a "moving starting point" as reference, and every
+ time at least as much as the limit as been transferred, we can reset
+ this starting point to the current position. This gets a good limiting
+ effect that applies to the "current speed" with instant reactivity (in
+ case of sudden speed burst).
- ldap.c:89: warning: extra tokens at end of #endif directive
-
-- ldap: Fixed support for Unicode DN in Win32 search call
+ Closes #971
-- ldap: Fixed Unicode user and password in Win32 bind calls
+- HISTORY.md: the multi socket was put in the wrong year!
-- ldap: Fixed Unicode host name in Win32 initialisation calls
+- [Mark Hamilton brought this change]
-- ldap: Use host.dispname for infof() connection failure messages
-
- As host.name may be encoded use dispname for infof() failure messages.
+ tool_helpers.c: fix comment typo (#989)
-- ldap: Prefer 'CURLcode result' for curl result codes
+- [Mark Hamilton brought this change]
-- ldap: Pass write length in all Curl_client_write() calls
-
- As we get the length for the DN and attribute variables, and we know
- the length for the line terminator, pass the length values rather than
- zero as this will save Curl_client_write() from having to perform an
- additional strlen() call.
+ libtest/test.h: fix typo (#988)
-- ldap: Fixed attribute memory leaks on failed client write
-
- Fixed memory leaks from commit 086ad79970 as was noted in the commit
- comments.
+- CURLMOPT_PIPELINING.3: language
-- ldap: Fixed DN memory leaks on failed client write
+- CURLMOPT_PIPELINING.3: extended and clarified
- Fixed memory leaks from commit 086ad79970 as was noted in the commit
- comments.
+ Especially in regards to the multiplexing part.
-- curl_ntlm_core.c: Fixed compilation warning from commit 1cb17b2a5d
+Steve Holme (31 Aug 2016)
+- curl_sspi.c: Updated function description comments
- curl_ntlm_core.c:146: warning: passing 'DES_cblock' (aka 'unsigned char
- [8]') to parameter of type 'char *' converts
- between pointers to integer types with different
- sign
+ * Added description to Curl_sspi_free_identity()
+ * Added parameter and return explanations to Curl_sspi_global_init()
+ * Added parameter explaination to Curl_sspi_global_cleanup()
-- ntlm: Use extend_key_56_to_64() for all cryptography engines
+- README: Corrected the supported Visual Studio versions
- Rather than duplicate the code in setup_des_key() for OpenSSL and in
- extend_key_56_to_64() for non-OpenSSL based crypto engines, as it is
- the same, use extend_key_56_to_64() for all engines.
+ Missed from commit 8356022d17.
-- RELEASE-NOTES: Synced with 34f0bd110f
+- KNOWN_BUGS: Move the Visual Studio project shortcomings from local README
-- curl_ntlm_core.c: Fixed compilation warning
+- KNOWN_BUGS: Expand 6.4 to include Kerberos V5
- curl_ntlm_core.c:458: warning: 'ascii_uppercase_to_unicode_le' defined
- but not used
+ ...and discuss a possible solution.
-- endian: Fixed bit-shift in 64-bit integer read functions
+Daniel Stenberg (30 Aug 2016)
+- connect: fix #ifdefs for debug versions of conn/streamclose() macros
- From commit 43792592ca and 4bb5a351b2.
+ CURLDEBUG is for the memory debugging
- Reported-by: Michael Osipov
-
-- smb: Use endian functions for reading NBT and message size values
+ DEBUGBUILD is for the extra debug stuff
+
+ Pointed-out-by: Steve Holme
-- endian: Added big endian read functions
+- KNOWN_BUGS: mention some cmake "support gaps"
-- endian: Added 64-bit integer read function
+Nick Zitzmann (28 Aug 2016)
+- darwinssl: add documentation stating that the --cainfo option is intended for backward compatibility only
+
+ In other news, I changed one other reference to "Mac OS X" in the documentation (that I previously wrote) to say "macOS" instead.
-- COPYING: Bumped copyright year to 2015
+Daniel Stenberg (28 Aug 2016)
+- http2: return CURLE_HTTP2_STREAM for unexpected stream close
+
+ Follow-up to c3e906e9cd0f, seems like a more appropriate error code
+
+ Suggested-by: Jay Satiro
-- version: Bump copyright year to 2015
+- [Tatsuhiro Tsujikawa brought this change]
-- smb.c: Fixed compilation warnings
+ http2: handle closed streams when uploading
- smb.c:780: warning: passing 'char *' to parameter of type 'unsigned
- char *' converts between pointers to integer types with
- different sign
- smb.c:781: warning: passing 'char *' to parameter of type 'unsigned
- char *' converts between pointers to integer types with
- different sign
- smb.c:804: warning: passing 'char *' to parameter of type 'unsigned
- char *' converts between pointers to integer types with
- different sign
-
-- smb: Use endian functions for reading length and offset values
+ Fixes #986
-- endian: Added 16-bit integer write function
+- http2: make sure stream errors don't needlessly close the connection
+
+ With HTTP/2 each transfer is made in an indivial logical stream over the
+ connection, making most previous errors that caused the connection to get
+ forced-closed now instead just kill the stream and not the connection.
+
+ Fixes #941
-- endian: Fixed Linux compilation issues
+- Curl_verify_windows_version: minor edit to avoid compiler warnings
- Having files named endian.[c|h] seemed to cause issues under Linux so
- renamed them both to have the curl_ prefix in the filenames.
+ ... instead of if() before the switch(), add a default to the switch so
+ that the compilers don't warn on "warning: enumeration value
+ 'PLATFORM_DONT_CARE' not handled in switch" anymore.
-- [Julien Nabet brought this change]
+Steve Holme (27 Aug 2016)
+- RELEASE-NOTES: Added missing fix from commit 15592143f
- lib1900.c: Fixed cppcheck error
+Jay Satiro (26 Aug 2016)
+- schannel: Disable ALPN for Wine since it is causing problems
+
+ - Disable ALPN on Wine.
+
+ - Don't pass input secbuffer when ALPN is disabled.
- lib1900.c:182: (style) Array index 'handlenum' is used before limits
- check
+ When ALPN support was added a change was made to pass an input secbuffer
+ to initialize the context. When ALPN is enabled the buffer contains the
+ ALPN information, and when it's disabled the buffer is empty. In either
+ case this input buffer caused problems with Wine and connections would
+ not complete.
- Bug: https://github.com/bagder/curl/pull/133
+ Bug: https://github.com/curl/curl/issues/983
+ Reported-by: Christian Fillion
-- endian: Added standard function descriptions
+Kamil Dudka (26 Aug 2016)
+- [Peter Wang brought this change]
-- endian: Renamed functions for curl API naming convention
+ nss: work around race condition in PK11_FindSlotByName()
+
+ Serialise the call to PK11_FindSlotByName() to avoid spurious errors in
+ a multi-threaded environment. The underlying cause is a race condition
+ in nssSlot_IsTokenPresent().
+
+ Bug: https://bugzilla.mozilla.org/1297397
+
+ Closes #985
-- endian: Moved write functions to new module
+- nss: refuse previously loaded certificate from file
+
+ ... when we are not asked to use a certificate from file
-- endian: Moved read functions to new module
+Daniel Stenberg (26 Aug 2016)
+- ftp_done: remove dead code
-- endian: Introduced endian module
-
- To allow the little endian functions, currently used in two of the NTLM
- source files, to be used by other modules such as the SMB module.
+- TLS: random file/egd doesn't have to match for conn reuse
-- sepheaders.c: Applied curl oding standards
+- test161: add comment for the exit code
-- [Julien Nabet brought this change]
+Dan Fandrich (26 Aug 2016)
+- test219: Add http as a required feature
- sepheaders.c: Fixed resource leak on failure
+Daniel Stenberg (25 Aug 2016)
+- [Michael Kaufmann brought this change]
-- vtls: Use '(void) arg' for unused parameters
+ HTTP: stop parsing headers when switching to unknown protocols
- Prefer void for unused parameters, rather than assigning an argument to
- itself as a) unintelligent compilers won't optimize it out, b) it can't
- be used for const parameters, c) it will cause compilation warnings for
- clang with -Wself-assign and d) is inconsistent with other areas of the
- curl source code.
-
-- smb.c: Fixed compilation warning
+ - unknown protocols probably won't send more headers (e.g. WebSocket)
+ - improved comments and moved them to the correct case statements
- smb.c:586: warning: conversion to 'short unsigned int' from 'int' may
- alter its value
-
-- [Bill Nagel brought this change]
+ Closes #899
- smb: Use the connection's upload buffer
+- openssl: make build with 1.1.0 again
- Use the connection's upload buffer instead of allocating our own send
- buffer.
+ synced with OpenSSL git master commit cc06906707
-- RELEASE-NOTES: Synced with 1933f9d33c
+- INTERNALS: fix title
-- schannel: Moved the ISC return flag definitions to the SSPI module
+- configure: detect zlib with our pkg-config macros
+
+ ... instead of relying on the pkg-config autoconf macros to be present.
- Moved our Initialize Security Context return attribute definitions to
- the SSPI module, as a) these can be used by other SSPI based providers
- and b) the ISC required attributes are defined there.
+ Fixes #972 (again...)
-- [Bill Nagel brought this change]
+Jay Satiro (25 Aug 2016)
+- http2: Remove incorrect comments
+
+ .. also remove same from scp
- smb: Close the connection after a failed client write
+Daniel Stenberg (23 Aug 2016)
+- [Ales Novak brought this change]
-- darwinssl: Fixed compilation warning
+ ftp: fix wrong poll on the secondary socket
- vtls.c:683:43: warning: unused parameter 'data'
-
-- sockfilt.c: Fixed compilation warnings
+ When we're uploading using FTP and the server issues a tiny pause
+ between opening the connection to the client's secondary socket, the
+ client's initial poll() times out, which leads to second poll() which
+ does not wait for POLLIN on the secondary socket. So that poll() also
+ has to time out, creating a long (200ms) pause.
- sockfilt.c:288: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
- sockfilt.c:291: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
- sockfilt.c:323: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
- sockfilt.c:326: warning: conversion to 'DWORD' from 'size_t' may alter
- its value
-
-- test1509: Fixed compilation warning
+ This patch adds the correct flag to the secondary socket, making the
+ second poll() correctly wait for the connection there too.
- lib1509.c:93:18: warning: conversion to 'long int' from 'size_t' may
- alter its value
-
-- test556: Fixed compilation warning
+ Signed-off-by: Ales Novak <alnovak@suse.cz>
- lib556.c:90: warning: conversion to 'unsigned int' from 'size_t' may
- alter its value
+ Closes #978
-- sasl_gssapi: Fixed use of dummy username with real username
+- RELEASE-NOTES: synced with 95ded2c56
-- vtls: Fixed compilation warning and an ignored return code
+- configure: make it work without PKG_CHECK_MODULES
- curl_schannel.h:123: warning: right-hand operand of comma expression
- has no effect
+ With commit c2f9b78 we added a new dependency on pkg-config for
+ developers which may be unwanted. This change make the configure script
+ still work as before if pkg-config isn't installed, it'll just use the
+ old zlib detection logic without pkg-config.
- Some instances of the curlssl_close_all() function were declared with a
- void return type whilst others as int. The schannel version returned
- CURLE_NOT_BUILT_IN and others simply returned zero, but in all cases the
- return code was ignored by the calling function Curl_ssl_close_all().
+ Reported-by: Marc Hörsken
- For the time being and to keep the internal API consistent, changed all
- declarations to use a void return type.
-
- To reduce code we might want to consider removing the unimplemented
- versions and use a void #define like schannel does.
-
-Daniel Stenberg (28 Dec 2014)
-- TODO: 2.3 Better support for same name resolves
+ Fixes #972
-Steve Holme (28 Dec 2014)
-- test1520: Fixed initial teething problems
+Marc Hoersken (21 Aug 2016)
+- Revert "KNOWN_BUGS: SOCKS proxy not working via IPv6"
- * Missing initialisation of upload status caused a seg fault
- * Missing data termination caused corrupt data to be uploaded
- * Data verification should be performed in <upload> element
- * Added missing recipient list cleanup
+ This reverts commit 9cb1059f92286a6eb5d28c477fdd3f26aed1d554.
+
+ As discussed in #835 SOCKS5 supports IPv6 proxies and destinations.
-- test1520: Fixed compilation errors
+Daniel Stenberg (21 Aug 2016)
+- [Marco Deckel brought this change]
-- tests: Added test for bug #1456
+ win: Basic support for Universal Windows Platform apps
+
+ Closes #820
-- checksrc.bat: Fixed a problem opening files with spaces in the filename
+Steve Holme (21 Aug 2016)
+- sasl: Don't use GSSAPI authentication when domain name not specified
+
+ Only choose the GSSAPI authentication mechanism when the user name
+ contains a Windows domain name or the user is a valid UPN.
+
+ Fixes #718
-- openldap: Prefer use of 'CURLcode result'
+- vauth: Added check for supported SSPI based authentication mechanisms
+
+ Completing commit 00417fd66c and 2708d4259b.
-- openldap: Use 'LDAPMessage *msg' for messages
+- http.c: Remove duplicate (authp->avail & CURLAUTH_DIGEST) check
- This frees up the 'result' variable for CURLcode based result codes.
+ From commit 2708d4259b.
-- nss: Don't ignore Curl_extract_certinfo() OOM failure
+Marc Hoersken (20 Aug 2016)
+- socks.c: display the hostname returned by the SOCKS5 proxy server
+
+ Instead of displaying the requested hostname the one returned
+ by the SOCKS5 proxy server is used in case of connection error.
+ The requested hostname is displayed earlier in the connection sequence.
+
+ The upper-value of the port is moved to a temporary variable and
+ replaced with a 0-byte to make sure the hostname is 0-terminated.
-- nss: Don't ignore Curl_ssl_init_certinfo() OOM failure
+Steve Holme (20 Aug 2016)
+- urldata.h: Corrected comment for httpcode which is also populated by SMTP
+
+ As of 7.25.0 and commit 5430007222.
-- nss: Use 'CURLcode result' for curl result codes
+Marc Hoersken (20 Aug 2016)
+- socks.c: use Curl_printable_address in SOCKS5 connection sequence
- ...and don't use CURLE_OK in failure/success comparisons.
+ Replace custom string formatting with Curl_printable_address.
+ Add additional debug and error output in case of failures.
-- getinfo: Code style policing
+- socks.c: align SOCKS4 connection sequence with SOCKS5
+
+ Calling sscanf is not required since the raw IPv4 address is
+ available and the protocol can be detected using ai_family.
-- getinfo: Use 'CURLcode result' for curl result codes
+Steve Holme (20 Aug 2016)
+- http.c: Corrected indentation change from commit 2708d4259b
+
+ Made by Visual Studio's auto-correct feature and missed by me in my own
+ code reviews!
-- darwinssl: Use 'CURLcode result' for curl result codes
+- http: Added calls to Curl_auth_is_<mechansism>_supported()
+
+ Hooked up the HTTP authentication layer to query the new 'is mechanism
+ supported' functions when deciding what mechanism to use.
+
+ As per commit 00417fd66c existing functionality is maintained for now.
-- polarssl: Use 'CURLcode result' for curl result codes
+Marc Hoersken (20 Aug 2016)
+- socks.c: improve verbose output of SOCKS5 connection sequence
-- docs: Updated following the addition of SASL GSSAPI via GSS-API libraries
-
- As this feature has been implemented for 7.40.0.
+- configure.ac: add missing quotes to PKG_CHECK_MODULES
-- asiohiper.cpp: No need to initialise members of ConnInfo
+Steve Holme (20 Aug 2016)
+- sasl: Added calls to Curl_auth_is_<mechansism>_supported()
- ...as calloc() automatically clears the area of memory with zeros.
-
-- asiohiper.cpp: Updated for curl coding standards
+ Hooked up the SASL authentication layer to query the new 'is mechanism
+ supported' functions when deciding what mechanism to use.
- ...with the exception of the start of block statement curly brackets.
+ For now existing functionality is maintained.
-- code/docs: Use correct case for IPv4 and IPv6
-
- For consistency, as we seem to have a bit of a mixed bag, changed all
- instances of ipv4 and ipv6 in comments and documentations to use the
- correct case.
+Daniel Stenberg (19 Aug 2016)
+- [Miroslav Franc brought this change]
-- runtests: Fixed detection of Unix Sockets feature
-
- ...following change in curl --version output.
+ spnego_sspi: fix memory leak in case *outlen is zero (#970)
-- code/docs: Use Unix rather than UNIX to avoid use of the trademark
-
- Use Unix when generically writing about Unix based systems as UNIX is
- the trademark and should only be used in a particular product's name.
+- CURLMOPT_MAX_TOTAL_CONNECTIONS.3: mention it can also multiplex
-- ip2ip.c: Fixed compilation warning when IPv6 Scope ID not supported
+Steve Holme (18 Aug 2016)
+- vauth: Introduced Curl_auth_is_<mechansism>_supported() functions
- if2ip.c:119: warning: unused parameter 'remote_scope_id'
+ As Windows SSPI authentication calls fail when a particular mechanism
+ isn't available, introduced these functions for DIGEST, NTLM, Kerberos 5
+ and Negotiate to allow both HTTP and SASL authentication the opportunity
+ to query support for a supported mechanism before selecting it.
- ...and some minor code style policing in the same function.
+ For now each function returns TRUE to maintain compatability with the
+ existing code when called.
+
+Daniel Stenberg (18 Aug 2016)
+- test1144: verify HEAD with body-only response
-- vtls: Don't set cert info count until memory allocation is successful
+Steve Holme (17 Aug 2016)
+- RELEASE-PROCEDURE: Added some more future release dates
- Otherwise Curl_ssl_init_certinfo() can fail and set the num_of_certs
- member variable to the requested count, which could then be used
- incorrectly as libcurl closes down.
+ ...and removed some old ones
-- vtls: Use CURLcode for Curl_ssl_init_certinfo() return type
+Daniel Stenberg (17 Aug 2016)
+- [David Woodhouse brought this change]
+
+ curl: allow "pkcs11:" prefix for client certificates
- The return type for this function was 0 on success and 1 on error. This
- was then examined by the calling functions and, in most cases, used to
- return CURLE_OUT_OF_MEMORY.
+ RFC7512 provides a standard method to reference certificates in PKCS#11
+ tokens, by means of a URI starting 'pkcs11:'.
- Instead use CURLcode for the return type and return the out of memory
- error directly, propagating it up the call stack.
-
-- configure: Use camel case for UNIX sockets feature output
+ We're working on fixing various applications so that whenever they would
+ have been able to use certificates from a file, users can simply insert
+ a PKCS#11 URI instead and expect it to work. This expectation is now a
+ part of the Fedora packaging guidelines, for example.
- To match the curl --version output.
-
-Marc Hoersken (26 Dec 2014)
-- sockfilt.c: Reduce the number of individual memory allocations
+ This doesn't work with cURL because of the way that the colon is used
+ to separate the certificate argument from the passphrase. So instead of
- Merge multiple internal arrays into one, even if some variables
- will not not be used. They are all created with the number of
- file descriptors as their size.
+ curl -E 'pkcs11:manufacturer=piv_II;id=%01' …
- Also fix possible thread handle leak in CloseHandle-loop.
-
-- sockfilt.c: Replace 100ms sleep with thread throttle
+ I instead need to invoke cURL with the colon escaped, like this:
- Improves performance of test cases 574 and 575 by 50%.
+ curl -E 'pkcs11\:manufacturer=piv_II;id=%01' …
- A value of zero causes the thread to relinquish the remainder
- of its time slice to any other thread of equal priority that is
- ready to run. If there are no other threads of equal priority
- ready to run, the function returns immediately, and the thread
- continues execution.
+ This is suboptimal because we want *consistency* — the URI should be
+ usable in place of a filename anywhere, without having strange
+ differences for different applications.
- http://msdn.microsoft.com/library/windows/desktop/ms686307.aspx
-
-Steve Holme (25 Dec 2014)
-- tool_help: Use camel case for UNIX sockets feature output
+ This patch therefore disables the processing in parse_cert_parameter()
+ when the string starts with 'pkcs11:'. It means you can't pass a
+ passphrase with an unescaped PKCS#11 URI, but there's no need to do so
+ because RFC7512 allows a PIN to be given as a 'pin-value' attribute in
+ the URI itself.
- In line with the other features listed in the --version output,
- capitalise the UNIX socket feature.
-
-- vtls: Use bool for Curl_ssl_getsessionid() return type
+ Also, if users are already using RFC7512 URIs with the colon escaped as
+ in the above example — even providing a passphrase for cURL to handling
+ instead of using a pin-value attribute, that will continue to work
+ because their string will start 'pkcs11\:' and won't match the check.
- The return type of this function is a boolean value, and even uses a
- bool internally, so use bool in the function declaration as well as
- the variables that store the return value, to avoid any confusion.
-
-- schannel: Minor code style policing for casts
+ What *does* break with this patch is the extremely unlikely case that a
+ user has a file which is in the local directory and literally named
+ just "pkcs11", and they have a passphrase on it. If that ever happened,
+ the user would need to refer to it as './pkcs11:<passphrase>' instead.
-- schannel: Prefer 'CURLcode result' for curl result codes
+- nss: make the global variables static
-- cyassl: Prefer 'CURLcode result' for curl result codes
-
-- tool_xattr: Use 'CURLcode result' for curl result codes
-
-- curl_ntlm_core.c: Fixed compilation warnings
+- openssl: use regular malloc instead of OPENSSL_malloc
- curl_ntlm_core.c:301: warning: pointer targets in passing argument 2 of
- 'CryptImportKey' differ in signedness
- curl_ntlm_core.c:310: warning: passing argument 6 of 'CryptEncrypt' from
- incompatible pointer type
- curl_ntlm_core.c:540: warning: passing argument 4 of 'CryptGetHashParam'
- from incompatible pointer type
-
-- RELEASE-NOTES: Synced with 8830df8b66
-
-- gtls: Use preferred 'CURLcode result'
+ This allows for better memmory debugging and torture tests.
-- openldap: Use standard naming for setup connection function
+- proxy: fix tests as follow-up to 93b0d907d5
- Renamed ldap_setup() to ldap_setup_connection() to follow more widely
- used function naming.
+ This fixes tests that were added after 113f04e664b as the tests would
+ fail otherwise.
+
+ We bring back "Proxy-Connection: Keep-Alive" now unconditionally to fix
+ regressions with old and stupid proxies, but we could possibly switch to
+ using it only for CONNECT or only for NTLM in a future if we want to
+ gradually reduce it.
+
+ Fixes #954
+
+ Reported-by: János Fekete
-- rtmp: Use standard naming for setup connection function
+- Revert "Proxy-Connection: stop sending this header by default"
- Renamed rtmp_setup() to rtmp_setup_connection() to follow more widely
- used function naming.
+ This reverts commit 113f04e664b16b944e64498a73a4dab990fe9a68.
-- smb: Use standard naming for setup connection function
+- CURLOPT_PROXY.3: unsupported schemes cause errors now
- Renamed smb_setup() to smb_setup_connection() to follow more widely
- used function naming.
+ Follow-up to a96319ebb9 (document the new behavior)
-- config-win32.h: Fixed line length > 79 columns
+- tests/README: mention nghttpx for HTTP/2 tests
-- openssl: Prefer we don't use NULL in comparisons
+- README.md: add our CII Best Practices badge
-- build: Removed WIN32 definition from the Visual Studio projects
+- proxy: polished the error message for unsupported schemes
- As this pre-processor definition is defined in curl_setup.h there is no
- need to include it in the Visual Studio project files.
+ Follow up to a96319ebb93
+
+- test219: verify unsupported scheme for proxies get rejected
-- build: Removed WIN64 definition from the libcurl Visual Studio projects
+- proxy: reject attempts to use unsupported proxy schemes
- Removed the WIN64 pre-processor definition from the libcurl project
- files as:
+ I discovered some people have been using "https://example.com" style
+ strings as proxy and it "works" (curl doesn't complain) because curl
+ ignores unknown schemes and then assumes plain HTTP instead.
- * WIN64 is not used in our source code
- * The curl projects files don't define it
- * It isn't required by or used in the platform SDK
- * For backwards compatability curl_setup.h defines WIN32
- * The compiler automatically defines _WIN64 for x64 builds
+ I think this misleads users into believing curl uses HTTPS to proxies
+ when it doesn't. Now curl rejects proxy strings using unsupported
+ schemes instead of just ignoring and defaulting to HTTP.
+
+- RELEASE-NOTES: synced with b7ee5316c2fd5b
+
+Marc Hoersken (14 Aug 2016)
+- socks.c: Correctly calculate position of port in response packet
- Historically Visual Studio projects have defined WIN32, in addition to
- the compiler defined _WIN32 definition, and I had incorrectly changed
- that to WIN64 for the x64 libcurl builds but not in the curl projects.
+ Third commit to fix issue #944 regarding SOCKS5 error handling.
+
+ Reported-by: David Kalnischkies
+
+- socks.c: Do not modify and invalidate calculated response length
- As such, it is questionable whether this should be defined or not. For
- more information see the following cache of a discussion that took
- place on the microsoft.public.vc.mfc newsgroup:
+ Second commit to fix issue #944 regarding SOCKS5 error handling.
- http://www.tech-archive.net/Archive/VC/microsoft.public.vc.mfc/2008-06/msg00074.html
+ Reported-by: David Kalnischkies
-- openssl.c Fix for compilation errors with older versions of OpenSSL
+- socks.c: Move error output after reading the whole response packet
- openssl.c:1408: error: 'TLS1_1_VERSION' undeclared
- openssl.c:1411: error: 'TLS1_2_VERSION' undeclared
+ First commit to fix issue #944 regarding SOCKS5 error handling.
+
+ Reported-by: David Kalnischkies
-Daniel Stenberg (22 Dec 2014)
-- [John Malmberg brought this change]
+Daniel Stenberg (13 Aug 2016)
+- [Ronnie Mose brought this change]
- Fix comment edit in vms/backup_gnv_curl_src.com
+ MANUAL: Remove invalid link to LDAP documentation (#962)
- packages/vms/backup_gnv_curl_src.com: Originally copied from Bash port.
+ The server developer.netscape.com does not resolve into any
+ ip address and can be removed.
-- curl: show size of inhibited data when using -v
+Jay Satiro (13 Aug 2016)
+- openssl: accept subjectAltName iPAddress if no dNSName match
- To offer some more info and yet it doesn't use more lines.
-
-- openssl: fix SSL/TLS versions in verbose output
-
-- openssl: make it compile against openssl 1.1.0-DEV master branch
+ Undo change introduced in d4643d6 which caused iPAddress match to be
+ ignored if dNSName was present but did not match.
+
+ Also, if iPAddress is present but does not match, and dNSName is not
+ present, fail as no-match. Prior to this change in such a case the CN
+ would be checked for a match.
+
+ Bug: https://github.com/curl/curl/issues/959
+ Reported-by: wmsch@users.noreply.github.com
-Marc Hoersken (22 Dec 2014)
-- sshserver.pl: clarify and streamline variable names
+Daniel Stenberg (12 Aug 2016)
+- [Dambaev Alexander brought this change]
-Daniel Stenberg (21 Dec 2014)
-- openssl: warn for SRP set if SSLv3 is used, not for TLS version
+ configure.ac: add zlib search with pkg-config
- ... as it requires TLS and it was was left to warn on the default from
- when default was SSL...
+ Closes #956
-- smb: use memcpy() instead of strncpy()
+- rtsp: ignore whitespace in session id
- ... as it never copies the trailing zero anyway and always just the four
- bytes so let's not mislead anyone into thinking it is actually treated
- as a string.
+ Follow-up to e577c43bb to fix test case 569 brekage: stop the parser at
+ whitespace as well.
- Coverity CID: 1260214
-
-- [John E. Malmberg brought this change]
+ Help-by: Erik Janssen
- VMS: Updates for 0740-0D1220
+- HTTP: retry failed HEAD requests too
- lib/setup-vms.h : VAX HP OpenSSL port is ancient, needs help.
- More defines to set symbols to uppercase.
+ Mark's new document about HTTP Retries
+ (https://mnot.github.io/I-D/httpbis-retry/) made me check our code and I
+ spotted that we don't retry failed HEAD requests which seems totally
+ inconsistent and I can't see any reason for that separate treatment.
- src/tool_main.c : Fix parameter to vms_special_exit() call.
+ So, no separate treatment for HEAD starting now. A HTTP request sent
+ over a reused connection that gets cut off before a single byte is
+ received will be retried on a fresh connection.
- packages/vms/ :
- backup_gnv_curl_src.com : Fix the error message to have the correct package.
+ Made-aware-by: Mark Nottingham
+
+- mk-ca-bundle.1: document -m, added in 1.26
+
+- RELEASE-NOTES: synced with e577c43bb5
+
+- [Erik Janssen brought this change]
+
+ rtsp: accept any RTSP session id
- build_curl-config_script.com : Rewrite to be more accurate.
+ Makes libcurl work in communication with gstreamer-based RTSP
+ servers. The original code validates the session id to be in accordance
+ with the RFC. I think it is better not to do that:
- build_libcurl_pc.com : Use tool_version.h now.
+ - For curl the actual content is a don't care.
- build_vms.com : Fix to handle lib/vtls directory.
+ - The clarity of the RFC is debatable, is $ allowed or only as \$, that
+ is imho not clear
- curl_gnv_build_steps.txt : Updated build procedure documentation.
+ - Gstreamer seems to url-encode the session id but % is not allowed by
+ the RFC
- generate_config_vms_h_curl.com :
- * VAX does not support 64 bit ints, so no NTLM support for now.
- * VAX HP SSL port is ancient, needs some help.
- * Disable NGHTTP2 for now, not ported to VMS.
- * Disable UNIX_SOCKETS, not available on VMS yet.
- * HP GSSAPI port does not have gss_nt_service_name.
+ - less code
- gnv_link_curl.com : Update for new curl structure.
+ With this patch curl will correctly handle real-life lines like:
+ Session: biTN4Kc.8%2B1w-AF.; timeout=60
- pcsi_product_gnv_curl.com : Set up to optionally do a complete build.
+ Bug: https://curl.haxx.se/mail/lib-2016-08/0076.html
-Marc Hoersken (21 Dec 2014)
-- sockfilt.c: use non-Ex functions that are available before WinXP
+- symbols-in-versions: add CURL_STRICTER
- It was initially reported by Guenter that GetFileSizeEx
- requires (_WIN32_WINNT >= 0x0500) to be true.
+ Added in 5fce88aa8c12564
-- tests: use Cygwin-style paths in SSH, SSHD and SFTP config files
-
- Second patch to enable Windows support using Cygwin-based OpenSSH.
-
- Tested with CopSSH 5.0.0 free edition using an msys shell on Windows 7.
+- [Simon Warta brought this change]
-- tests: support spaces in paths to SSH, SSHD and SFTP binaries
+ winbuild: Allow changing C compiler via environment variable CC (#952)
- First patch to enable Windows support using Cygwin-based OpenSSH.
-
-Steve Holme (20 Dec 2014)
-- non-ascii: Reduce variable usage
+ This makes it possible to use specific compilers or a cache.
- Removed 'next' variable in Curl_convert_form(). Rather than setting it
- from 'form->next' and using that to set 'form' after the conversion
- just use 'form = form->next' instead.
+ Sample use for clcache:
+ set CC=clcache.bat
+ nmake /f Makefile.vc DEBUG=no MODE=static VC=14 GEN_PDB=no
-- non-ascii: Prefer while loop rather than a do loop
-
- This also removes the need to check that the 'form' argument is valid.
+- LICENSE-MIXING.md: switched to markdown
-- non-ascii: Reduce variable scope
-
- As 'result' isn't used out side the conversion callback code and
- previously caused variable shadowing in the libiconv based code.
+- docs-make: have markdown files use .md
-- non-ascii: We prefer 'CURLcode result'
-
- This also fixes a variable shadowing issue when HAVE_ICONV is defined
- as rc was declared for the result code of libiconv based functions.
+- curl.h: make CURL_NO_OLDIES define CURL_STRICTER
-Marc Hoersken (19 Dec 2014)
-- secureserver.pl: clean up formatting of config and fix verbose output
-
- Verbose output was not matching the actual configuration file,
- because FIPS and Windows conditions were ignored.
+- HISTORY.md: use markdown extension
-- secureserver.pl: update Windows detection and fix path conversion
+- SSLCERTS.md: renamed to markdown extension
-- secureserver.pl: make OpenSSL CApath and cert absolute path values
-
- Recent stunnel versions (5.08) seem to have trouble with relative
- paths on Windows. This turns the relative paths into absolute ones.
+- INTERNALS.md: use markdown extension for markdown content
-Patrick Monnerat (18 Dec 2014)
-- if2ip: dummy scope parameter for Curl_if2ip() call in SIOCGIFADDR-enabled code.
+- CONTRIBUTE.md: markdown extension
-- [Kyle J. McKay brought this change]
+- CONTRIBUTE: changed to markdown
- parseurlandfillconn(): fix improper non-numeric scope_id stripping.
- Fixes SF bug 1149: http://sourceforge.net/p/curl/bugs/1449/
+- CONTRIBUTE: refreshed
-- IPV6: address scope != scope id
- There was a confusion between these: this commit tries to disambiguate them.
- - Scope can be computed from the address itself.
- - Scope id is scope dependent: it is currently defined as 1-based local
- interface index for link-local scoped addresses, and as a site index(?) for
- (obsolete) site-local addresses. Linux only supports it for link-local
- addresses.
- The URL parser properly parses a scope id as an interface index, but stores it
- in a field named "scope": confusion. The field has been renamed into "scope_id".
- Curl_if2ip() used the scope id as it was a scope. This caused failures
- to bind to an interface.
- Scope is now computed from the addresses and Curl_if2ip() matches them.
- If redundantly specified in the URL, scope id is check for mismatch with
- the interface index.
-
- This commit should fix SF bug #1451.
+- TODO: added an SSH section and two SFTP things to do
-- connect: singleipconnect(): properly try other address families after failure
+- TODO: remove the 1.22 duplicated item
-Daniel Stenberg (16 Dec 2014)
-- SFTP: work-around servers that return zero size on STAT
-
- Bug: http://curl.haxx.se/mail/lib-2014-12/0103.html
- Pathed-by: Marc Renault
+- TODO: move "CURLOPT_MAIL_CLIENT" to SMTP section
-- glob_next_url: make the loop count upwards
-
- As the former contruct apparently caused a compiler warning, mentioned
- in d8efde07e556c.
+- TODO: API for URL parsing/splitting
-- tool_operate: we prefer 'CURLcode result'
+- TODO: move QUIC to the HTTP section
-- tool_urlglob: unify return codes to use CURLcode
-
- There was a mix of GlobCode, CURLcode and ints and they were mostly
- passing around CURLcode errors. This change makes the functions use only
- CURLcode and removes the GlobCode type completely.
+- [Simon Warta brought this change]
-- tool_urlglob.c: partly reverse dc19789444
+ winbuild: Free name $(CC) in Makefile (#950)
- The loop in glob_next_url() needs to be done backwards to maintain the
- logic. dc19789444 caused test 1235 to fail.
+ In the old line number 290, CC and CURL_CC had the same value. After
+ that, /DCURL_STATICLIB was added to CC but not CURL_CC (intended?).
+
+ This gets rid of the CC variable entirely. It is a first step to make it
+ possible to manualyl set a CC variable in order to be able to change the
+ compiler.
-- KNOWN_BUGS: the SFTP code doesn't support CURLINFO_FILETIME
+- TODO: Use huge HTTP/2 windows
-- [Jay Satiro brought this change]
+- [Simon Warta brought this change]
- opts: Warn CURLOPT_TIMEOUT overrides when set after CURLOPT_TIMEOUT_MS
+ winbuild: Avoid setting redundant CFLAGS to compile commands (#949)
- Change CURLOPT_TIMEOUT doc to warn that if CURLOPT_TIMEOUT and
- CURLOPT_TIMEOUT_MS are both set whichever one is set last is the one
- that will be used.
+ $(CURL_CC) is always used with $(CURL_CFLAGS) appended, so before this,
+ all arguments in CURL_CFLAGS have been added twice.
+
+Jay Satiro (8 Aug 2016)
+- cmake: Enable win32 threaded resolver by default
+
+ - Turn on USE_THREADS_WIN32 in Windows if ares isn't on
- Prior to this change that behavior was only noted in the
- CURLOPT_TIMEOUT_MS doc.
+ This change is similar to what we already do in the autotools build.
-Nick Zitzmann (15 Dec 2014)
-- darwinssl: fix incorrect usage of aprintf()
+- cmake: Enable win32 large file support by default
- Commit b13923f changed an snprintf() to use aprintf(), but the API usage
- wasn't correct, and was causing a crash to occur. This fixes it.
+ All compilers used by cmake in Windows should support large files.
+
+ - Add test SIZEOF_OFF_T
+ - Remove outdated test SIZEOF_CURL_OFF_T
+ - Turn on USE_WIN32_LARGE_FILES in Windows
+ - Check for 'Largefile' during the features output
-Steve Holme (14 Dec 2014)
-- copyright: Updated the copyright year following recent updates
+Daniel Stenberg (7 Aug 2016)
+- TODO: added several ideas, removed SPDY
-Daniel Stenberg (14 Dec 2014)
-- tool_urlglob.c: reverse two loops
+- http2: always wait for readable socket
+
+ Since the server can at any time send a HTTP/2 frame to us, we need to
+ wait for the socket to be readable during all transfers so that we can
+ act on incoming frames even when uploading etc.
- By counting from 0 and up instead of backwards like before, we remove
- the need for the "funny" check of the unsigned variable when decreased
- passed zero. Easier to read and less risk for compiler warnings.
+ Reminded-by: Tatsuhiro Tsujikawa
-Marc Hoersken (14 Dec 2014)
-- tool_urlglob.c: Added braces to clarify the conditions
+- RELEASE-NOTES: synced with 7b4bf37a44791
-- tool_urlglob.c: Silence warning C6293: Ill-defined for-loop
-
- The >= 0 is actually not required, since i underflows and
- the for-loop is stopped using the < condition, but this
- makes the VS2012 compiler and code analysis happy.
+- [Thomas Glanzmann brought this change]
-- tool_binmode.c: Explicitly ignore the return code of setmode
+ mbedtls: set debug threshold to 4 (verbose) when MBEDTLS_DEBUG is defined
- Fixes code analysis warning C6031:
- return value ignored: <function> could return unexpected value
+ In order to make MBEDTLS_DEBUG work, the debug threshold must be unequal
+ to 0. This patch also adds a comment how mbedtls must be compiled in
+ order to make debugging work, and explains the possible debug levels.
-- lib: Fixed multiple code analysis warnings if SAL are available
+- CURLOPT_TCP_NODELAY: now enabled by default
- warning C28252: Inconsistent annotation for function:
- parameter has another annotation on this instance
-
-Steve Holme (14 Dec 2014)
-- smb.c: Fixed code analysis warning
+ After a few wasted hours hunting down the reason for slowness during a
+ TLS handshake that turned out to be because of TCP_NODELAY not being
+ set, I think we have enough motivation to toggle the default for this
+ option. We now enable TCP_NODELAY by default and allow applications to
+ switch it off.
- smb.c:320: warning C6297: Arithmetic overflow: 32-bit value is shifted,
- then cast to 64-bit value. Result may not be an expected
- value
+ This also makes --tcp-nodelay unnecessary, but --no-tcp-nodelay can be
+ used to disable it.
+
+ Thanks-to: Tim Rühsen
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0143.html
-Marc Hoersken (14 Dec 2014)
-- tool_util.c: Use GetTickCount64 if it is available
+- [Serj Kalichev brought this change]
-Steve Holme (14 Dec 2014)
-- smb: Use HAVE_PROCESS_H for process.h inclusion
+ TFTP: Fix upload problem with piped input
+
+ When input stream for curl is stdin and input stream is not a file but
+ generated by a script then curl can truncate data transfer to arbitrary
+ size since a partial packet is treated as end of transfer by TFTP.
- Rather than testing against _WIN32 use the preferred HAVE_PROCESS_H
- pre-processor define when including process.h.
+ Fixes #857
-Daniel Stenberg (14 Dec 2014)
-- darwinssl: aprintf() to allocate the session key
+- mk-ca-bundle.pl: -m keeps ca cert meta data in output
- ... to avoid using a fixed memory size that risks being too large or too
- small.
+ Makes the script pass on comments holding meta data to the output
+ file. Like fingerprinters, issuer, date ranges etc.
+
+ Closes #937
-Marc Hoersken (14 Dec 2014)
-- curl_schannel: Improvements to memory re-allocation strategy
+- multi: make Curl_expire() work with 0 ms timeouts
- - do not grow memory by doubling its size
- - do not leak previously allocated memory if reallocation fails
- - replace while-loop with a single check to make sure
- that the requested amount of data fits into the buffer
+ Previously, passing a timeout of zero to Curl_expire() was a magic code
+ for clearing all timeouts for the handle. That is now instead made with
+ the new Curl_expire_clear() function and thus a 0 timeout is fine to set
+ and will trigger a timeout ASAP.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1450
- Reported-by: Warren Menzer
+ This will help removing short delays, in particular notable when doing
+ HTTP/2.
-Steve Holme (14 Dec 2014)
-- asyn-ares: We prefer use of 'CURLcode result'
+- transfer: return without select when the read loop reached maxcount
+
+ Regression added in 790d6de48515. The was then added to avoid one
+ particular transfer to starve out others. But when aborting due to
+ reading the maxcount, the connection must be marked to be read from
+ again without first doing a select as for some protocols (like SFTP/SCP)
+ the data may already have been read off the socket.
+
+ Reported-by: Dan Donahue
+ Bug: https://curl.haxx.se/mail/lib-2016-07/0057.html
-Marc Hoersken (14 Dec 2014)
-- curl_schannel.c: Data may be available before connection shutdown
+Steve Holme (3 Aug 2016)
+- [Bill Nagel brought this change]
-Steve Holme (14 Dec 2014)
-- http2: Use 'CURLcode result' for curl result codes
+ mbedtls: Added support for NTLM
-- asyn-thread: We prefer 'CURLcode result'
+Daniel Stenberg (3 Aug 2016)
+- [Sergei Nikulov brought this change]
-- smb: Fixed unnecessary initialisation of struct member variables
+ travis: removed option to rebuild autotool from source
- There is no need to set the 'state' and 'result' member variables to
- SMB_REQUESTING (0) and CURLE_OK (0) after the allocation via calloc()
- as calloc() initialises the contents to zero.
+ Fixes #943
-- ntlm: Fixed return code for bad type-2 Target Info
-
- Use CURLE_BAD_CONTENT_ENCODING for bad type-2 Target Info security
- buffers just like we do for bad decodes.
+- bump: start working toward 7.50.2
-- ntlm: Remove unnecessary casts in readshort_le()
-
- I don't think both of my fix ups from yesterday were needed to fix the
- compilation warning, so remove the one that I think is unnecessary and
- let the next Android autobuild prove/disprove it.
+Version 7.50.1 (3 Aug 2016)
-- curl_ntlm_msgs.c: Another attempt to fix compilation warning
-
- curl_ntlm_msgs.c:170: warning: conversion to 'short unsigned int' from
- 'int' may alter its value
+Daniel Stenberg (3 Aug 2016)
+- THANKS: 7 new contributors from the 7.50.1 release
-Guenter Knauf (13 Dec 2014)
-- synctime.c: added own user-agent string.
+- RELEASE-NOTES: 7.50.1
-Steve Holme (13 Dec 2014)
-- smb.c: Fixed line longer than 79 columns
+- TLS: only reuse connections with the same client cert
+
+ CVE-2016-5420
+ Bug: https://curl.haxx.se/docs/adv_20160803B.html
-- curl_ntlm_msgs.c: Fixed compilation warning from commit 783b5c3b11
+- TLS: switch off SSL session id when client cert is used
- curl_ntlm_msgs.c:169: warning: conversion to 'short unsigned int' from
- 'int' may alter its value
+ CVE-2016-5419
+ Bug: https://curl.haxx.se/docs/adv_20160803A.html
+ Reported-by: Bru Rom
+ Contributions-by: Eric Rescorla and Ray Satiro
-Guenter Knauf (13 Dec 2014)
-- mk-ca-bundle.pl: restored forced run again.
+- curl_multi_cleanup: clear connection pointer for easy handles
+
+ CVE-2016-5421
+ Bug: https://curl.haxx.se/docs/adv_20160803C.html
+ Reported-by: Marcelo Echeverria and Fernando Muñoz
-- synctime.c: removed another timeserver URL.
+- KNOWN_BUGS: SOCKS proxy not working via IPv6
- worldtimeserver.com seems also no longer available.
+ Closes #835
-- synctime.c: fixed timeserver URLs.
+- KNOWN_BUGS: CURLOPT_SEEKFUNCTION not called with CURLFORM_STREAM
- For getting the date header its not necessary to access special
- pages or even CGI scripts - all pages including the main index
- reply with the date header, therefore shortened URLs to domain.
- Removed worldtime.com; added pool.ntp.org.
+ Closes #768
-Steve Holme (13 Dec 2014)
-- ftp.c: Fixed compilation warning when no verbose string support
+- KNOWN_BUGS: transfer-encoding: chunked in HTTP/2
- ftp.c:819: warning: unused parameter 'lineno'
+ Closes #662
-- smb: Added state change functions to assist with debugging
+- TODO: Provide cmake config-file
- For debugging purposes, and as per other protocols within curl, added
- state change functions rather than changing the states directly.
+ Closes #885
+
+Patrick Monnerat (2 Aug 2016)
+- os400: define BUILDING_LIBCURL in make script.
-- ntlm: Use short integer when decoding 16-bit values
+Daniel Stenberg (1 Aug 2016)
+- RELEASE-NOTES: synced with aa9f536a18b
-- RELEASE-NOTES: Synced with 6291a16b20
+Jay Satiro (1 Aug 2016)
+- [Thomas Glanzmann brought this change]
-- smtp.c: Fixed compilation warnings
+ mbedtls: Fix debug function name
- smtp.c:2357 warning: adding 'size_t' (aka 'unsigned long') to a string
- does not append to the string
- smtp.c:2375 warning: adding 'size_t' (aka 'unsigned long') to a string
- does not append to the string
- smtp.c:2386 warning: adding 'size_t' (aka 'unsigned long') to a string
- does not append to the string
+ This patch is necessary so that curl compiles if MBEDTLS_DEBUG is
+ defined.
- Used array index notation instead.
+ Bug: https://curl.haxx.se/mail/lib-2016-08/0001.html
-- smb: Disable SMB when 64-bit integers are not supported
-
- This fixes compilation issues with compilers that don't support 64-bit
- integers through long long or __int64.
+Daniel Stenberg (1 Aug 2016)
+- [Sergei Nikulov brought this change]
-- ntlm: Disable NTLM v2 when 64-bit integers are not supported
+ travis: fix OSX build by re-installing libtool
- This fixes compilation issues with compilers that don't support 64-bit
- integers through long long or __int64 which was introduced in commit
- 07b66cbfa4.
-
-- ntlm: Allow NTLM2Session messages when USE_NTRESPONSES manually defined
+ Apparently due to a broken homebrew install
- Previously USE_NTLM2SESSION would only be defined automatically when
- USE_NTRESPONSES wasn't already defined. Separated the two definitions
- so that the user can manually set USE_NTRESPONSES themselves but
- USE_NTLM2SESSION is defined automatically if they don't define it.
+ fixes #934
+ Closes #939
-- smtp.c: Fixed line longer than 79 columns
+- [Martin Vejnár brought this change]
-- config-win32.h: Don't enable Windows Crypt API if using OpenSSL
+ win32: fix a potential memory leak in Curl_load_library
- As the OpenSSL and NSS Crypto engines are prefered by the core NTLM
- routines, to the Windows Crypt API, don't define USE_WIN32_CRYPT
- automatically when either OpenSSL or NSS are in use - doing so would
- disable NTLM2Session responses in NTLM type-3 messages.
-
-- smtp: Fixed inappropriate free of the scratch buffer
-
- If the scratch buffer was allocated in a previous call to
- Curl_smtp_escape_eob(), a new buffer not allocated in the subsequent
- call and no action taken by that call, then an attempt would be made to
- try and free the buffer which, by now, would be part of the data->state
- structure.
+ If a call to GetSystemDirectory fails, the `path` pointer that was
+ previously allocated would be leaked. This makes sure that `path` is
+ always freed.
- This bug was introduced in commit 4bd860a001.
+ Closes #938
-- smtp: Fixed dot stuffing when EOL characters were at end of input buffers
+- include: revert 9adf3c4 and make public types void * again
- Fixed a problem with the CRLF. detection when multiple buffers were
- used to upload an email to libcurl and the line ending character(s)
- appeared at the end of each buffer. This meant any lines which started
- with . would not be escaped into .. and could be interpreted as the end
- of transmission string instead.
+ Many applications assume the actual contents of the public types and use
+ that do for example forward declarations (saving them from including our
+ public header) which then breaks when we switch from void * to a struct
+ *.
- This only affected libcurl based applications that used a read function
- and wasn't reproducible with the curl command-line tool.
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1456
- Assisted-by: Patrick Monnerat
-
-Daniel Stenberg (11 Dec 2014)
-- telnet: fix "cast increases required alignment of target type"
-
-- ntlm_wb_response: fix "statement not reached"
+ I'm not convinced we were wrong, but since this practise seems
+ widespread enough I'm willing to (partly) step down.
- ... and I could use a break instead of a goto to end the loop.
+ Now libcurl uses the struct itself when it is built and it allows
+ applications to use the struct type if CURL_STRICTER is defined at the
+ time of the #include.
- Bug: http://curl.haxx.se/mail/lib-2014-12/0089.html
- Reported-by: Tor Arntsen
+ Reported-by: Peter Frühberger
+ Fixes #926
-Steve Holme (10 Dec 2014)
-- RELEASE-NOTES: Synced with 1cc5194337
-
- Added some bug fixes that I had missed in previous synchronisations.
+Jay Satiro (28 Jul 2016)
+- [Yonggang Luo brought this change]
-Daniel Stenberg (10 Dec 2014)
-- Curl_unix2addr: avoid using the variable name 'sun'
+ cmake: Fix for schannel support
- I suspect this causes compile failures on Solaris:
+ The check_library_exists_concat do not check crypt32 library properly.
+ So include it directly.
- Bug: http://curl.haxx.se/mail/lib-2014-12/0081.html
-
-Steve Holme (10 Dec 2014)
-- url.c: Fixed compilation warning when USE_NTLM is not defined
+ Bug: https://github.com/curl/curl/pull/917
+ Reported-by: Yonggang Luo
- url.c:3078: warning: variable 'credentialsMatch' set but not used
+ Bug: https://github.com/curl/curl/issues/935
+ Reported-by: Alain Danteny
-- parsedate.c: Fixed compilation warning
+- Revert "travis: Install libtool for OS X builds"
- parsedate.c:548: warning: 'parsed' may be used uninitialized in this
- function
+ Didn't work.
- As curl_getdate() returns -1 when parsedate() fails we can initialise
- parsed to -1.
+ This reverts commit 50723585ed380744358de054e2a55dccee65dfd7.
-Daniel Stenberg (10 Dec 2014)
-- TODO: Cache negative name resolves
+- travis: Install libtool for OS X builds
- Worth exploring
+ CI is failing due to missing libtoolize, so I'm trying this.
-- ldap: check Curl_client_write() return codes
-
- There might be one or two memory leaks left in the error paths.
+Daniel Stenberg (26 Jul 2016)
+- [Viktor Szakats brought this change]
-- ldap: rename variables to comply to curl standards
+ TODO: minor typo in last commit
+
+ merged #931
-Dan Fandrich (10 Dec 2014)
-- sws.c: Fixed 'rc' may be used uninitialized warning
+- TODO: Timeout idle connections from the pool
-- cookies: Improved OOM handling in cookies
-
- This fixes the test 506 torture test. The internal cookie API really
- ought to be improved to separate cookie parsing errors (which may be
- ignored) with OOM errors (which should be fatal).
+Patrick Monnerat (25 Jul 2016)
+- os400: minimum supported OS version: V6R1M0.
+ Do not log compilation informational messages.
-Guenter Knauf (9 Dec 2014)
-- synctime.c: fixed user-agent setting.
+Jay Satiro (24 Jul 2016)
+- tests: Fix for http/2 feature
- Some websites meanwhile refuse to reply to requests from ancient
- browsers like IE6, therefore I've comment out this setting, but
- also fixed the string to now fake IE8 if someone enables it.
+ Bug: https://curl.haxx.se/mail/lib-2016-07/0070.html
+ Reported-by: Paul Howarth
-Daniel Stenberg (9 Dec 2014)
-- smb: fix unused return code warning
+Steve Holme (23 Jul 2016)
+- README: Mention wolfSSL in the 'Dependencies' section
-Patrick Monnerat (9 Dec 2014)
-- Curl_client_write() & al.: chop long data, convert data only once.
+- vauth.h: No need to query HAVE_GSSAPI || USE_WINDOWS_SSPI for SPNEGO
+
+ As SPNEGO is only defined when these pre-processor variables are defined
+ there is no need to query them explicitly.
-Guenter Knauf (9 Dec 2014)
-- VC build: added sspi define for winssl-zlib builds.
+- spnego: Corrected miss-placed * in Curl_auth_spnego_cleanup() declaration
+
+ Typo introduced in commit ad5e9bfd5d.
-Daniel Stenberg (9 Dec 2014)
-- schannel_recv: return the correct code
+Daniel Stenberg (22 Jul 2016)
+- SECURITY: mention how to get windows-specific CVEs
- Bug: http://curl.haxx.se/bug/view.cgi?id=1462
- Reported-by: Tae Hyoung Ahn
+ ... and make the distros link a proper link
-- http2: avoid logging neg "failure" if h2 was not requested
+Dan Fandrich (21 Jul 2016)
+- test558: fix test by stripping file paths from FD lines
-- openldap: do not ignore Curl_client_write() return codes
+Kamil Dudka (21 Jul 2016)
+- tests: distribute the http2-server.pl script, too
-- compile: warn on unused return code from Curl_client_write()
+- docs: distribute the CURLINFO_HTTP_VERSION(3) man page, too
-Patrick Monnerat (8 Dec 2014)
-- SMB: Fix a data size mismatch that broke SMB on big-endian platforms
+Daniel Stenberg (21 Jul 2016)
+- bump: start working on 7.50.1
-Steve Holme (7 Dec 2014)
-- smb: Fixed Windows autoconf builds following commit eb88d778e7
-
- As Windows based autoconf builds don't yet define USE_WIN32_CRYPTO
- either explicitly through --enable-win32-cypto or automatically on
- _WIN32 based platforms, subsequent builds broke with the following
- error message:
-
- "Can't compile NTLM support without a crypto library."
+Version 7.50.0 (21 Jul 2016)
-- RELEASE-NOTES: Synced with 526603ff05
+Daniel Stenberg (21 Jul 2016)
+- RELEASE-NOTES: version 7.50.0 ready
-- [Bill Nagel brought this change]
+- THANKS: 13 new contributors from the 7.50.0 release
- smb: Build with SSPI enabled
+Jay Satiro (21 Jul 2016)
+- winbuild: fix embedded manifest option
- Build SMB/CIFS protocol support when SSPI is enabled.
-
-- [Bill Nagel brought this change]
-
- ntlm: Use Windows Crypt API
+ Embedded manifest option didn't work due to typo.
- Allow the use of the Windows Crypt API for NTLMv1 functions.
+ Reported-by: Stefan Kanthak
-Dan Fandrich (7 Dec 2014)
-- cookie.c: Refactored cleanup code to simplify
+- vauth: Fix memleak by freeing credentials if out of memory
- Also, fixed the outdated comments on the cookie API.
+ This is a follow up to the parent commit dcdd4be which fixes one leak
+ but creates another by failing to free the credentials handle if out of
+ memory. Also there's a second location a few lines down where we fail to
+ do same. This commit fixes both of those issues.
-- get_url_file_name: Fixed crash on OOM on debug build
-
- This caused a null-pointer dereference which caused a few dozen
- torture tests to fail.
+Daniel Stenberg (20 Jul 2016)
+- [Saurav Babu brought this change]
-Steve Holme (6 Dec 2014)
-- sws.c: Fixed compilation warning
+ vauth: Fixed memory leak due to function returning without free
- sws.c:2191 warning: 'rc' may be used uninitialized in this function
+ This patch allocates memory to "output_token" only when it is required
+ so that memory is not leaked if function returns.
-- ftp.c: Fixed compilation warnings when proxy support disabled
+- test558: updated after ipv6-check move
- ftp.c:1827 warning: unused parameter 'newhost'
- ftp.c:1827 warning: unused parameter 'newport'
+ Follow-up commit to c50980807c5 to make this test pass.
-- smb: Fixed a problem with large file transfers
+Jay Satiro (20 Jul 2016)
+- connect: disable TFO on Linux when using SSL
- Fixed an issue with the message size calculation where the raw bytes
- from the buffer were interpreted as signed values rather than unsigned
- values.
+ - Linux TFO + TLS is not implemented yet.
- Reported-by: Gisle Vanem
- Assisted-by: Bill Nagel
+ Bug: https://github.com/curl/curl/issues/907
-- smb: Moved the URL decoding into a separate function
+Daniel Stenberg (19 Jul 2016)
+- ROADMAP: QUIC and TLS 1.3
-- smb: Fixed URL encoded URLs not working
+- RELEASE-NOTES: synced with c50980807c5
-- Makefile.inc: Added our standard header and updated file formatting
+Jay Satiro (18 Jul 2016)
+- [Brian Prodoehl brought this change]
-- Makefile.inc: Updated file formatting
+ curl_global_init: Check if IPv6 works
- Aligned continuation character and used space as the separator
- character as per other makefile files.
-
-- curl_md4.h: Updated copyright year following recent edit
+ - Curl_ipv6works() is not thread-safe until after the first call, so
+ call it once during global init to avoid a possible race condition.
- ...and minor layout adjustment.
-
-Patrick Monnerat (5 Dec 2014)
-- SMB: Fix big endian problems. Make it OS/400 aware.
+ Bug: https://github.com/curl/curl/issues/915
+ PR: https://github.com/curl/curl/pull/918
-- OS400: enable NTLM authentication
+- [Timothy Polich brought this change]
-Steve Holme (5 Dec 2014)
-- multi.c: Fixed compilation warning
+ CURLMOPT_SOCKETFUNCTION.3: fix typo
- multi.c:2695: warning: declaration of `exp' shadows a global declaration
-
-Guenter Knauf (5 Dec 2014)
-- build: updated dependencies in makefiles.
-
-Steve Holme (5 Dec 2014)
-- sasl: Corrected formatting of function descriptions
+ Closes https://github.com/curl/curl/pull/914
-- sasl_gssapi: Added missing function description
+- [Miroslav Franc brought this change]
-- RELEASE-NOTES: Provided better descriptions
+ library: Fix memory leaks found during static analysis
- As it is often difficult to choose the best description for a single
- feature when it spans many commits, updated the descriptions for the
- recent SMB/CIFS protocol and GSS-API additions.
+ Closes https://github.com/curl/curl/pull/913
-- sasl_sspi: Corrected some typos
+- [Viktor Szakats brought this change]
-- sasl_sspi: Don't use hard coded sizes in Kerberos V5 security data
+ cookie.c: Fix misleading indentation
- Don't use a hard coded size of 4 for the security layer and buffer size
- in Curl_sasl_create_gssapi_security_message(), instead, use sizeof() as
- we have done in the sasl_gssapi module.
+ Closes https://github.com/curl/curl/pull/911
-- sasl_sspi: Free the Kerberos V5 challenge as soon as we're done with it
+- FAQ: Update FTP directory listing section for MLSD command
- Reduced the amount of free's required for the decoded challenge message
- in Curl_sasl_create_gssapi_security_message() as a result of coding it
- differently in the sasl_gssapi module.
-
-- gssapi: Corrected typo in comments
-
-- sasl_gssapi: Added body to Curl_sasl_create_gssapi_security_message()
-
-Daniel Stenberg (4 Dec 2014)
-- [Stefan Bühler brought this change]
-
- http_perhapsrewind: don't abort CONNECT requests
+ Explain how some FTP servers support the machine readable listing
+ format MLSD from RFC 3659 and compare it to LIST.
- ...they never have a body
+ Ref: https://github.com/curl/curl/issues/906
-- [Stefan Bühler brought this change]
+Daniel Stenberg (1 Jul 2016)
+- [Sergei Nikulov brought this change]
- HTTP: Free (proxy)userpwd for NTLM/Negotiate after sending a request
+ Appveyor: Updates for options - CURL_STATICLIB/BUILD_TESTING
- Sending NTLM/Negotiate header again after successful authentication
- breaks the connection with certain Proxies and request types (POST to MS
- Forefront).
+ Closes #892
-- [Stefan Bühler brought this change]
+- TODO: 17.4 also brings more HTTP/2 support
- HTTP: don't abort connections with pending Negotiate authentication
+- TODO: try next proxy if one doesn't work
- ... similarly to how NTLM works as Negotiate is in fact often NTLM with
- another name.
-
-- [Stefan Bühler brought this change]
-
- fix gdb libtool invocation path
-
-Steve Holme (4 Dec 2014)
-- sasl_gssapi: Fixed missing include from commit d3cca934ee
-
-Daniel Stenberg (4 Dec 2014)
-- [Jay Satiro brought this change]
+ Closes #896
- examples: remove sony.com from 10-at-a-time
+- conn: don't free easy handle data in handler->disconnect
- Prior to this change the 10-at-a-time example showed CURLE_RECV_ERROR
- for the sony website because it ends the connection when the request is
- missing a user agent.
+ Reported-by: Gou Lingfeng
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0139.html
-Steve Holme (4 Dec 2014)
-- sasl_gssapi: Fixed missing decoding debug failure message
+- test1244: test different proxy ports same URL
-- sasl_gssapi: Fixed honouring of no mutual authentication
+- curl_global_init.3: improved formatting of the flags
-- sasl_sspi: Added more Kerberos V5 decoding debug failure messages
+- curl_global_init.3: expand on the SSL and WIN32 bits purpose
+
+ Reported-by: Richard Gray
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0136.html
-Daniel Stenberg (4 Dec 2014)
-- [Anthon Pang brought this change]
+- [Michael Kaufmann brought this change]
- docs: Fix FAILONERROR typos
+ cleanup: minor code cleanup in Curl_http_readwrite_headers()
- It returns error for >= 400 HTTP responses.
+ - the expression of an 'if' was always true
+ - a 'while' contained a condition that was always true
+ - use 'if(k->exp100 > EXP100_SEND_DATA)' instead of 'if(k->exp100)'
+ - fixed a typo
- Bug: https://github.com/bagder/curl/pull/129
+ Closes #889
-- [Peter Wu brought this change]
-
- tool: fix CURLOPT_UNIX_SOCKET_PATH in --libcurl output
+- SFTP: set a generic error when no SFTP one exists...
- Mark CURLOPT_UNIX_SOCKET_PATH as string to ensure that it ends up as
- option in the file generated by --libcurl.
+ ... as otherwise we could get a 0 which would count as no error and we'd
+ wrongly continue and could end up segfaulting.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0052.html
+ Reported-by: 暖和的和暖
+
+- ROADMAP: http2 tests are merged, mention http2 perf
-- [Peter Wu brought this change]
+- docs/README.md: to render nicer pages on github
+
+ ... as previously the README.cmake would be picked and put at the bottom
+ of the docs page there and it wasn't very representative!
- opts: fix CURLOPT_UNIX_SOCKET_PATH formatting
+- README.md: change host name for the svg logo
- Add .nf and .fi such that the code gets wrapped in a pre on the web.
- Fixed grammar, fixed formatting of the "See also" items.
+ rawgit.com asks to use the domain cdn.rawgit.com for production
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ See #900
-Patrick Monnerat (4 Dec 2014)
-- OS400: enable Unix sockets.
+- [Viktor Szakats brought this change]
-Daniel Stenberg (3 Dec 2014)
-- RELEASE-NOTES: synced with b216427e73b5e9
+ README.md: use the SVG logo
-- opts: added CURLOPT_UNIX_SOCKET_PATH to Makefile.am
+- README.md: logo on top!
-- updateconninfo: clear destination struct before getsockname()
+- KNOWN_BUGS: 3.4 POP3 expects "CRLF.CRLF" eob for some
- Otherwise we may read uninitialized bytes later in the unix-domain
- sockets case.
+ Closes #740
-- curl.1: added --unix-socket
+- RELEASE-NOTES: synced with d61c80515aa8
-- [Peter Wu brought this change]
+- [Michael Osipov brought this change]
- tool: add --unix-socket option
+ acinclude.m4: improve autodetection of CA bundle on FreeBSD
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
-
-- [Peter Wu brought this change]
-
- libcurl: add UNIX domain sockets support
+ The FreeBSD Port security/ca_root_nss installs the Mozilla NSS CA bundle
+ to /usr/local/share/certs/ca-root-nss.crt. Use this bundle in the
+ discovery process.
- The ability to do HTTP requests over a UNIX domain socket has been
- requested before, in Apr 2008 [0][1] and Sep 2010 [2]. While a
- discussion happened, no patch seems to get through. I decided to give it
- a go since I need to test a nginx HTTP server which listens on a UNIX
- domain socket.
+ This change also removes the former FreeBSD path that has been obsolete
+ for 8 years since this FreeBSD ports commit:
+ https://svnweb.freebsd.org/ports/head/security/?view=revision&revision=215953
- One patch [3] seems to make it possible to use the
- CURLOPT_OPENSOCKETFUNCTION function to gain a UNIX domain socket.
- Another person wrote a Go program which can do HTTP over a UNIX socket
- for Docker[4] which uses a special URL scheme (though the name contains
- cURL, it has no relation to the cURL library).
+ Closes #894
+
+- configure: don't specify .lib for libs on windows
- This patch considers support for UNIX domain sockets at the same level
- as HTTP proxies / IPv6, it acts as an intermediate socket provider and
- not as a separate protocol. Since this feature affects network
- operations, a new feature flag was added ("unix-sockets") with a
- corresponding CURL_VERSION_UNIX_SOCKETS macro.
+ Another follow up for crypt32.lib linking with winssl
+
+- configure: fix winssl LIBS change typo
- A new CURLOPT_UNIX_SOCKET_PATH option is added and documented. This
- option enables UNIX domain sockets support for all requests on the
- handle (replacing IP sockets and skipping proxies).
+ follow-up from 120bf29e
+
+- TODO: "TCP Fast Open" is done, add monitor pool connections
+
+- configure: add crypt32.lib for winssl builds
- A new configure option (--enable-unix-sockets) and CMake option
- (ENABLE_UNIX_SOCKETS) can disable this optional feature. Note that I
- deliberately did not mark this feature as advanced, this is a
- feature/component that should easily be available.
+ Necessary since 6cabd78531f
+
+- Makefile.vc: link with crypt32.lib for winssl builds
- [0]: http://curl.haxx.se/mail/lib-2008-04/0279.html
- [1]: http://daniel.haxx.se/blog/2008/04/14/http-over-unix-domain-sockets/
- [2]: http://sourceforge.net/p/curl/feature-requests/53/
- [3]: http://curl.haxx.se/mail/lib-2008-04/0361.html
- [4]: https://github.com/Soulou/curl-unix-socket
+ Necessary since 6cabd78531f
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Fixes #853
-- [Peter Wu brought this change]
+- [Joel Depooter brought this change]
- tests: add two HTTP over UNIX socket tests
+ VC: Add crypt32.lib to Visual Sudio project template files
- test1435: a simple test that checks whether a HTTP request can be
- performed over the UNIX socket. The hostname/port are interpreted
- by sws and should be ignored by cURL.
+ Closes #854
+
+- vc: fix the build for schannel certinfo support
- test1436: test for the ability to do two requests to the same host,
- interleaved with one to a different hostname.
+ Broken since 6cabd785, which adds use of the Curl_extract_certinfo
+ function from the x509asn1.c file.
+
+- typedefs: use the full structs in internal code...
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ ... and save the typedef'ed names for headers and external APIs.
-- [Peter Wu brought this change]
+- internals: rename the SessionHandle struct to Curl_easy
- tests: add HTTP UNIX socket server testing support
+- headers: forward declare CURL, CURLM and CURLSH as structs
- The variable `$ipvnum` can now contain "unix" besides the integers 4
- and 6 since the variable. Functions which receive this parameter
- have their `$port` parameter renamed to `$port_or_path` to support a
- path to the UNIX domain socket (as a "port" is only meaningful for TCP).
+ Instead of typedef'ing to void, typedef to their corresponding actual
+ struct names to allow compilers to type-check.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
-
-- [Peter Wu brought this change]
+ Assisted-by: Reinhard Max
- sws: try to remove socket and retry bind
+Jay Satiro (22 Jun 2016)
+- vtls: Only call add/getsession if session id is enabled
- If sws is killed it might leave a stale socket file on the filesystem
- which would cause an EADDRINUSE error. After this patch, it is checked
- whether the socket is really stale and if so, the socket file gets
- removed and another bind is executed.
+ Prior to this change we called Curl_ssl_getsessionid and
+ Curl_ssl_addsessionid regardless of whether session ID reusing was
+ enabled. According to comments that is in case session ID reuse was
+ disabled but then later enabled.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ The old way was not intuitive and probably not something users expected.
+ When a user disables session ID caching I'd guess they don't expect the
+ session ID to be cached anyway in case the caching is later enabled.
-- [Peter Wu brought this change]
+Daniel Stenberg (22 Jun 2016)
+- curl.1: the used progress meter suffix is k in lower case
+
+ Closes #883
+
+- [Sergei Nikulov brought this change]
- sws: add UNIX domain socket support
+ cmake: now using BUILD_TESTING=ON/OFF
- This extends sws with a --unix-socket option which causes the port to
- be ignored (as the server now listens on the path specified by
- --unix-socket). This feature will be available in the following patch
- that enables checking for UNIX domain socket support.
+ CMake build now using BUILD_TESTING=ON/OFF (default is OFF) to build
+ tests and enabling CTest integration. Options BUILD_CURL_TESTS and
+ BUILD_DASHBOARD_REPORTS was removed.
- Proxy support (CONNECT) is not considered nor tested. It does not make
- sense anyway, first connecting through a TCP proxy, then let that TCP
- proxy connect to a UNIX socket.
+ Closes #882
+
+ Reviewed-by: Brad King
+
+- [Michael Kaufmann brought this change]
+
+ cleanup: fix method names in code comments
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Closes #887
-- [Peter Wu brought this change]
+Kamil Dudka (21 Jun 2016)
+- curl-compilers.m4: improve detection of GCC's -fvisibility= flag
+
+ Some builds of GCC produce output on both stdout and stderr when --help
+ --verbose is used. The 2>&1 redirection caused them to be arbitrarily
+ interleaved with each other because of stream buffering. Consequently,
+ grep failed to match the fvisibility= string in the mixed output, even
+ though the string was present in GCC's standard output.
+
+ This led to silently disabling symbol hiding in some builds of curl.
- sws: restrict TCP_NODELAY to IP sockets
+Daniel Stenberg (19 Jun 2016)
+- tests: fix the HTTP/2 tests
- TCP_NODELAY does not make sense for Unix sockets, so enable it only if
- the socket is using IP.
+ The HTTP/2 tests brought with commit bf05606ef1f were using the internal
+ name 'http2' for the HTTP/2 server, while in fact that name was already
+ used for the second instance of the HTTP server. This made tests using
+ the second instance (like test 2050) fail after a HTTP/2 test had run.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ The server is now known as HTTP/2 internally and within the <server>
+ section in test cases. 1700, 1701 and 1702 were updated accordingly.
-Dan Fandrich (3 Dec 2014)
-- [Dave Reisner brought this change]
+- openssl: use more 'const' to fix build warnings with 1.1.0 branch
- curl.1: fix trivial typo
+- curl.1: missed 'T' in the progress unit suffixes
-Steve Holme (3 Dec 2014)
-- sasl_gssapi: Added body to Curl_sasl_create_gssapi_user_message()
+- curl.1: mention the unix for the progress meter
-- sasl_gssapi: Added body to Curl_sasl_gssapi_cleanup()
+Patrick Monnerat (16 Jun 2016)
+- os400: add new definitions to ILE/RPG binding.
-- sasl_gssapi: Added Curl_sasl_build_gssapi_spn() function
+Daniel Stenberg (16 Jun 2016)
+- openssl: fix cert check with non-DNS name fields present
- Added helper function for returning a GSS-API compatible SPN.
-
-Daniel Stenberg (3 Dec 2014)
-- NSS: enable the CAPATH option
+ Regression introduced in 5f5b62635 (released in 7.48.0)
- Bug: http://curl.haxx.se/bug/view.cgi?id=1457
- Patch-by: Tomasz Kojm
+ Reported-by: Fabian Ruff
+ Fixes #875
-Steve Holme (3 Dec 2014)
-- sasl_gssapi: Enable USE_KERBEROS5 for GSS-API based builds
+Dan Fandrich (16 Jun 2016)
+- axtls: Use Curl_wait_ms instead of the less-portable usleep
-- sasl_gssapi: Added GSS-API based Kerberos V5 variables
+- axtls: Fixed compile after compile 31c521b0
-- sws.c: Fixed compilation warning when IPv6 is disabled
-
- sws.c:69: warning: comma at end of enumerator list
+- tests: Added HTTP proxy keywords to tests 1141 & 1142
-- sasl_gssapi: Made log_gss_error() a common GSS-API function
-
- Made log_gss_error() a common function so that it can be used in both
- the http_negotiate code as well as the curl_sasl_gssapi code.
+Jay Satiro (15 Jun 2016)
+- [Sergei Nikulov brought this change]
-- sasl_gssapi: Introduced GSS-API based SASL module
+ cmake: Fix build with winldap
- Added the initial version of curl_sasl_gssapi.c and updated the project
- files in preparation for adding GSS-API based Kerberos V5 support.
+ Bug: https://github.com/curl/curl/pull/874
+ Reported-by: Sergei Nikulov
-- smb: Don't try to connect with empty credentials
+- CURLOPT_POSTFIELDS.3: Clarify what happens when set empty
- On some platforms curl would crash if no credentials were used. As such
- added detection of such a use case to prevent this from happening.
+ When CURLOPT_POSTFIELDS is set to an empty string libcurl will send a
+ zero-byte POST. Prior to this change it was documented as sending data
+ from the read callback.
- Reported-by: Gisle Vanem
-
-- smb.c: Coding policing of pointer usage
+ This also changes the wording of what happens when empty or NULL so that
+ it's hopefully easier to understand for people whose primary language
+ isn't English.
+
+ Bug: https://github.com/curl/curl/issues/862
+ Reported-by: Askar Safin
-- configure: Fixed inclusion of SMB when no crypto engines available
+- [Michael Wallner brought this change]
-Guenter Knauf (1 Dec 2014)
-- build: in Makefile.m32 simplified autodetection.
+ curl_multi_socket_action.3: Fix rewording
+
+ - Remove some erroneous text.
+
+ Closes https://github.com/curl/curl/pull/865
-Daniel Stenberg (30 Nov 2014)
-- [Peter Wu brought this change]
+- [Luo Jinghua brought this change]
- sws: move away from IPv4/IPv4-only assumption
+ resolve: enable protocol family logic for synthesized IPv6
- Instead of depending the socket domain type on use_ipv6, specify the
- domain type (AF_INET / AF_INET6) as variable. An enum is used here with
- switch to avoid compiler warnings in connect_to, complaining that rc
- is possibly undefined (which is not possible as socket_domain is
- always set).
+ - Enable protocol family logic for IPv6 resolves even when support
+ for synthesized addresses is enabled.
- Besides abstracting the socket type, make the debugging messages be
- independent on IP (introduce location_str which points to "port XXXXX").
- Rename "ipv_inuse" to "socket_type" and tighten the scope (main).
+ This is a follow up to the parent commit that added support for
+ synthesized IPv6 addresses from IPv4 on iOS/OS X. The protocol family
+ logic needed for IPv6 was inadvertently excluded if support for
+ synthesized addresses was enabled.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Bug: https://github.com/curl/curl/issues/863
+ Ref: https://github.com/curl/curl/pull/866
+ Ref: https://github.com/curl/curl/pull/867
-- [Peter Wu brought this change]
+Daniel Stenberg (7 Jun 2016)
+- [Luo Jinghua brought this change]
- lib/connect: restrict IP/TCP options to said sockets
+ resolve: add support for IPv6 DNS64/NAT64 Networks on OS X + iOS
- This patch prepares for adding UNIX domain sockets support.
+ Use getaddrinfo() to resolve the IPv4 address literal on iOS/Mac OS X.
+ If the current network interface doesn’t support IPv4, but supports
+ IPv6, NAT64, and DNS64.
- TCP_NODELAY and TCP_KEEPALIVE are specific to TCP/IP sockets, so do not
- apply these to other socket types. bindlocal only works for IP sockets
- (independent of TCP/UDP), so filter that out too for other types.
-
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Closes #866
+ Fixes #863
-- smb.c: use size_t as input argument types for msg sizes
+- tests: two more HTTP/2 tests
- This fixes warnings about conversions to int
-
-Steve Holme (30 Nov 2014)
-- version: The next release will become 7.40.0
+ 1701 and 1702
-- [Bill Nagel brought this change]
+- runtests: don't display logs when http2 server fails to start
- docs: Updated for the SMB protocol
+- runtests: make stripfile work on stdout as well
- This patch updates the documentation for the SMB/CIFS protocol.
+ ... and have test 1700 use that to strip out the nghttpx server: headers
-- curl tool: Exclude SMB from the protocol redirect
+- http2-tests: test1700 is the first real HTTP/2 test
+
+ It requires that 'nghttpx' is in the PATH, and it will run the tests
+ using nghttpx as a front-end proxy in front of the standard HTTP/1 test
+ server. This uses HTTP/2 over plain TCP.
- As local files could be accessed through \\localhost\c$.
+ If you like me have nghttpx installed in a custom path, you can run test 1700
+ like this:
+
+ $ PATH=$PATH:$HOME/build-nghttp2/bin/ ./runtests.pl 1700
-- [Bill Nagel brought this change]
+- RELEASE-NOTES: synced with 34855feeb4c299
- curl tool: Enable support for the SMB protocol
+Steve Holme (6 Jun 2016)
+- schannel: Disable ALPN on Windows < 8.1
- This patch enables SMB/CIFS support in the curl command-line tool.
-
-- smb.c: Fixed compilation warnings
+ Calling QueryContextAttributes with SECPKG_ATTR_APPLICATION_PROTOCOL
+ fails on Windows < 8.1 so we need to disable ALPN on these OS versions.
- smb.c:398: warning: comparison of integers of different signs:
- 'ssize_t' (aka 'long') and 'unsigned long'
- smb.c:443: warning: comparison of integers of different signs:
- 'ssize_t' (aka 'long') and 'unsigned long'
-
-- libcurl: Exclude SMB from the protocol redirect
+ Inspiration provide by: Daniel Seither
- As local files could be accessed through \\localhost\c$.
-
-- [Bill Nagel brought this change]
+ Closes #848
+ Fixes #840
- libcurl: Enable support for the SMB protocol
+Jay Satiro (5 Jun 2016)
+- checksrc: Add LoadLibrary to the banned functions list
- This patch enables SMB/CIFS support in libcurl.
+ LoadLibrary was supplanted by Curl_load_library for security
+ reasons in 6df916d.
-- smb.c: Fixed compilation warnings
+- http: Fix HTTP/2 connection reuse
- smb.c:322: warning: conversion to 'short unsigned int' from 'unsigned
- int' may alter its value
- smb.c:323: warning: conversion to 'short unsigned int' from 'unsigned
- int' may alter its value
- smb.c:482: warning: conversion to 'short unsigned int' from 'int' may
- alter its value
- smb.c:521: warning: conversion to 'unsigned int' from 'curl_off_t' may
- alter its value
- smb.c:549: warning: conversion to 'unsigned int' from 'curl_off_t' may
- alter its value
- smb.c:550: warning: conversion to 'short unsigned int' from 'int' may
- alter its value
-
-- smb.c: Renamed SMB command message variables to avoid compiler warnings
-
- smb.c:489: warning: declaration of 'close' shadows a global declaration
- smb.c:511: warning: declaration of 'read' shadows a global declaration
- smb.c:528: warning: declaration of 'write' shadows a global declaration
-
-- smb.c: Fixed compilation warnings
+ - Change the parser to not require a minor version for HTTP/2.
- smb.c:212: warning: unused parameter 'done'
- smb.c:380: warning: ISO C does not allow extra ';' outside of a function
- smb.c:812: warning: unused parameter 'premature'
- smb.c:822: warning: unused parameter 'dead'
-
-- smb.c: Fixed compilation warnings
+ HTTP/2 connection reuse broke when we changed from HTTP/2.0 to HTTP/2
+ in 8243a95 because the parser still expected a minor version.
- smb.c:311: warning: conversion from 'unsigned __int64' to 'u_short',
- possible loss of data
- smb.c:425: warning: conversion from '__int64' to 'unsigned short',
- possible loss of data
- smb.c:452: warning: conversion from '__int64' to 'unsigned short',
- possible loss of data
+ Bug: https://github.com/curl/curl/issues/855
+ Reported-by: Andrew Robbins, Frank Gevaerts
-- smb.c: Fixed compilation warnings
+Steve Holme (4 Jun 2016)
+- connect.c: Fixed compilation warning from commit 332e8d6164
- smb.c:162: error: comma at end of enumerator list
- smb.c:469: warning: conversion from 'size_t' to 'unsigned short',
- possible loss of data
- smb.c:517: warning: conversion from 'curl_off_t' to 'unsigned int',
- possible loss of data
- smb.c:545: warning: conversion from 'curl_off_t' to 'unsigned int',
- possible loss of data
-
-- [Bill Nagel brought this change]
+ connect.c:952:5: warning: suggest explicit braces to avoid ambiguous 'else'
- smb: Added initial SMB functionality
+- win32: Used centralised verify windows version function
- Initial implementation of the SMB/CIFS protocol.
-
-- [Bill Nagel brought this change]
+ Closes #845
- smb: Added SMB handler interfaces
-
- Added the SMB and SMBS handler interface structures and associated
- functions required for SMB/CIFS operation.
+- win32: Added verify windows version functionality
-- transfer: Code style policing
-
- Prefer ! rather than NULL in if statements, added comments and updated
- function spacing, argument spacing and line spacing to be more readble.
+- win32: Introduced centralised verify windows version function
-- transfer: Fixed existing scratch buffer being checked for NULL twice
+Kamil Dudka (3 Jun 2016)
+- tool_urlglob: fix off-by-one error in glob_parse()
- If the scratch buffer already existed when the CRLF conversion was
- performed then the buffer pointer would be checked twice for NULL. This
- second check is only necessary if the call to malloc() was performed by
- the first check.
-
-- smtp: Fixed dot stuffing being performed when no new data read
+ ... causing SIGSEGV while parsing URL with too many globs.
+ Minimal example:
- Whilst I had moved the dot stuffing code from being performed before
- CRLF conversion takes place to after it, in commit 4bd860a001, I had
- moved it outside the 'when something read' block of code when meant
- it could perform the dot stuffing twice on partial send if nread
- happened to contain the right values. It also meant the function could
- potentially read past the end of buffer. This was highlighted by the
- following warning:
+ $ curl $(for i in $(seq 101); do printf '{a}'; done)
- warning: `nread' might be used uninitialized in this function
+ Reported-by: Romain Coltel
+ Bug: https://bugzilla.redhat.com/1340757
-Daniel Stenberg (29 Nov 2014)
-- smb.h: fixed picky compiler warning
-
- smb.h:30:16: error: comma at end of enumerator list [-Werror=pedantic]
+Daniel Stenberg (1 Jun 2016)
+- [Benjamin Kircher brought this change]
-Steve Holme (29 Nov 2014)
-- tests: Disable test 1013 until SMB is fully added
+ libcurl-multi.3: fix small typo
+
+ Closes #850
-- [Bill Nagel brought this change]
+- [Viktor Szakats brought this change]
- smb: Added SMB protocol and port definitions
+ makefile.m32: add crypt32 for winssl builds
+
+ Dependency added by 6cabd78
- Added the necessary protocol and port definitions in order to support
- SMB/CIFS.
+ Closes #849
-- [Bill Nagel brought this change]
+- [Ivan Avdeev brought this change]
- smb: Added internal SMB definitions and structures
+ vtls: fix ssl session cache race condition
+
+ Sessionid cache management is inseparable from managing individual
+ session lifetimes. E.g. for reference-counted sessions (like those in
+ SChannel and OpenSSL engines) every session addition and removal
+ should be accompanied with refcount increment and decrement
+ respectively. Failing to do so synchronously leads to a race condition
+ that causes symptoms like use-after-free and memory corruption.
+ This commit:
+ - makes existing session cache locking explicit, thus allowing
+ individual engines to manage lock's scope.
+ - fixes OpenSSL and SChannel engines by putting refcount management
+ inside this lock's scope in relevant places.
+ - adds these explicit locking calls to other engines that use
+ sessionid cache to accommodate for this change. Note, however,
+ that it is unknown whether any of these engines could also have
+ this race.
- Added the internal definitions and structures necessary for SMB/CIFS
- support.
+ Bug: https://github.com/curl/curl/issues/815
+ Fixes #815
+ Closes #847
-- [Bill Nagel brought this change]
+- [Andrew Kurushin brought this change]
- smb: Added SMB connection structure
+ schannel: add CURLOPT_CERTINFO support
- Added the connection structure that will be required in urldata.h for
- SMB/CIFS based connections.
+ Closes #822
-- [Bill Nagel brought this change]
+- RELEASE-NOTES: synced with 142ee9fa15002315
- smb: Added initial source files for SMB
+- openssl: rename the private SSL_strerror
- Added the initial source files and updated the relevant project files in
- order to support SMB/CIFS.
+ ... to make it not look like an OpenSSL function
-- [Bill Nagel brought this change]
+- [Michael Kaufmann brought this change]
- smb: Added configuration options for SMB
+ openssl: Use correct buffer sizes for error messages
- Added --enable-smb and --disable-smb configuration options for the
- upcoming SMB/CIFS protocol support.
+ Closes #844
-Daniel Stenberg (28 Nov 2014)
-- [Peter Wu brought this change]
+- curl: fix -q [regression]
+
+ This broke in 7.49.0 with commit e200034425a7625
+
+ Fixes #842
- runtests.pl: fix startup of IPv6 servers
+- URL parser: allow URLs to use one, two or three slashes
+
+ Mostly in order to support broken web sites that redirect to broken URLs
+ that are accepted by browsers.
- Commit curl-7_23_1-143-g8218064 changed the parameter of
- responsive_http_server to accept types other than IPv6 (converting
- from a boolean to a string), but only considered the lower-case "ipv6"
- and not the "IPv6" variant. This caused all servers to start in IPv4
- mode instead.
+ Browsers are typically even more leniant than this as the WHATWG URL
+ spec they should allow an _infinite_ amount. I tested 8000 slashes with
+ Firefox and it just worked.
- This patch converts the remaining cases to "ipv6". While not strictly
- necessary for the run*server variants, these got also converted for
- consistency and to prevent future errors.
+ Added test case 1141, 1142 and 1143 to verify the new parser.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Closes #791
-- [Peter Wu brought this change]
+- [Renaud Lehoux brought this change]
- runtests.pl: fix warning message, remove duplicate value
+ cmake: Added missing mbedTLS support
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Closes #837
-Steve Holme (27 Nov 2014)
-- http.c: Fixed compilation warnings from features being disabled
-
- warning: unused variable 'data'
- warning: variable 'addcookies' set but not used
+- [Renaud Lehoux brought this change]
+
+ mbedtls: removed unused variables
- ...and some very minor coding style policing.
+ Closes #838
-- RELEASE-NOTES: Synced with c5399c827d
+- [Frank Gevaerts brought this change]
-- tests: Added SMTP with --crlf test case
+ http: add CURLINFO_HTTP_VERSION and %{http_version}
+
+ Adds access to the effectively used http version to both libcurl and
+ curl.
+
+ Closes #799
-- docs: Updated for commit 4bd860a001 and SMTP Unix line ending conversion
+- bump: start the journey toward 7.50.0
-- smtp: Fixed const'ness of nread parameter in Curl_smtp_escape_eob()
-
- ...and some comment typos!
+- [Marcel Raad brought this change]
-- smtp: Added support for the conversion of Unix newlines during mail send
+ openssl: fix build with OPENSSL_NO_COMP
- Added support for the automatic conversion of Unix newlines to CRLF
- during mail uploads.
+ With OPENSSL_NO_COMP defined, there is no function
+ SSL_COMP_free_compression_methods
- Feature: http://curl.haxx.se/bug/view.cgi?id=1456
+ Closes #836
-- CURLOPT_CRLF.3: Fixed inclusion of SMTP in listed protocols
+- [Gisle Vanem brought this change]
-Daniel Stenberg (25 Nov 2014)
-- curl*3: added small examples
+ memdebug: fix MSVC crash with -DMEMDEBUG_LOG_SYNC
- and some minor edits
+ Fixes #828
-- libcurl.3: fix formatting
+- [Jonathan brought this change]
+
+ README.md: polish
- refer to functions with the man page section properly
+ Closes #834
-- man pages: SEE ALSO curl_multi_wait
+- RELEASE-NOTES: fix vuln link
-- curl_multi_wait.3: clarify numfds being used if not NULL
+Version 7.49.1 (30 May 2016)
-- multi-single.c: switch to use curl_multi_wait
-
- Makes the example much easier and straight-forward!
+Daniel Stenberg (30 May 2016)
+- RELEASE-NOTES: 7.49.1
-- testcurl: bump the version of this script!
+- [Steve Holme brought this change]
-- testcurl: skip reading the setup file if given enough cmdline info
+ loadlibrary: Only load system DLLs from the system directory
- This makes it much easier to run multiple tests in the same directory,
- just altering the command lines used.
-
-- select.c: fix compilation for VxWorks
+ Inspiration provided by: Daniel Stenberg and Ray Satiro
+
+ Bug: https://curl.haxx.se/docs/adv_20160530.html
- Reported-by: Brian
- Bug: http://curl.haxx.se/bug/view.cgi?id=1455
+ Ref: Windows DLL hijacking with curl, CVE-2016-4802
-Patrick Monnerat (24 Nov 2014)
-- [moparisthebest brought this change]
+- ssh: fix version number check typo
- SSL: Add PEM format support for public key pinning
+Jay Satiro (29 May 2016)
+- curl_share_setopt.3: Add min ver needed for ssl session lock
+
+ Bug: https://github.com/curl/curl/issues/826
+ Reported-by: Michael Wallner
-Kamil Dudka (24 Nov 2014)
-- Revert "repository: ignore patch files generated by git"
+Daniel Stenberg (29 May 2016)
+- ssh: fix build for libssh2 before 1.2.6
- This reverts commit 217024a687ce86eb6d2317822ed81c7e5abc4b61.
+ The statvfs functionality was added to libssh2 in that version, so we
+ switch off that functionality when built with older libraries.
- Bug: https://github.com/bagder/curl/commit/217024a6#commitcomment-8693738
+ Fixes #831
-Steve Holme (23 Nov 2014)
-- multi.c: Fixed compilation warnings when no verbose string support
+- mbedtls: fix includes so snprintf() works
- warning: variable 'connection_id' set but not used
- warning: unused parameter 'lineno'
+ Regression from the previous *printf() rearrangements, this file missed to
+ include the correct header to make sure snprintf() works universally.
+
+ Reported-by: Moti Avrahami
+ Bug: https://curl.haxx.se/mail/lib-2016-05/0196.html
-- RELEASE-NOTES: Synced with 1450712e76
+Steve Holme (23 May 2016)
+- checksrc.pl: Added variants of strcat() & strncat() to banned function list
+
+ Added support for checking the tchar, unicode and mbcs variants of
+ strcat() and strncat() in the banned function list.
-- sasl: Tidied up some parameter comments
+Daniel Stenberg (23 May 2016)
+- smtp: minor ident (white space) fixes
-- sasl: Reduced the need for two sets of NTLM functions
-
-- ntlm: Moved NSS initialisation to base decode function
-
-- http_ntlm: Fixed additional NSS initialisation call when decoding type-2
+- THANKS: updated after script fixes
- After commit 48d19acb7c the HTTP code would call Curl_nss_force_init()
- twice when decoding a NTLM type-2 message, once directly and the other
- through the call to Curl_sasl_decode_ntlm_type2_message().
+ Now giving credit properly to github user names, fixed some UTF-8 issues
+ and added names discovered when contrithanks was improved.
-- ntlm: Fixed static'ness of local decode function
+- THANKS-filter: more name cleanups
-- ntlm: Corrected some parameter names and comments
+- contrithanks.sh: exclude existing names case insensitively
-- runtests.pl: Re-aligned feature support comments
+- contrithanks.sh: use same grep pattern and -a flag as contributors.sh
-- runtests.pl: Use Kerberos and SPNEGO as proxies for the crypto feature
-
- In addition to NTLM, use Kerberos and SPNEGO as proxies to the crypto
- feature.
-
- ...and converted tab characters, from commit 4b4e8a5853, to spaces.
+- contributors.sh: better grep pattern, use grep -a
-- runtests.pl: Added support for SPNEGO
+- THANKS-filter: fix more names
-- runtests.pl: Added Kerberos detection
+- contrithanks.sh: do the same github fix as contributors.sh
+
+ from 1577bfa35ba
-- runtests.pl: Added GSS-API detection
+Jay Satiro (23 May 2016)
+- contributors: Show GitHub username if real name unknown
+
+ Prior to this change if a GitHub contributor's real name was unknown
+ they would be omitted from the list.
+
+ Bug: https://github.com/curl/curl/issues/824
-- FILEFORMAT: Added SSPI, GSS-API and Kerberos to the features list
+Daniel Stenberg (21 May 2016)
+- RELEASE-NOTES: synced with 3caaeffbe8ded4
-- FILEFORMAT: Added test requires feature not present information
+Jay Satiro (20 May 2016)
+- openssl: cleanup must free compression methods
+
+ - Free compression methods if OpenSSL 1.0.2 to avoid a memory leak.
- Such as !SSPI as we do for the NTLM and Digest tests.
+ Bug: https://github.com/curl/curl/issues/817
+ Reported-by: jveazey@users.noreply.github.com
-Daniel Stenberg (20 Nov 2014)
-- http.c: log if it notices HTTP 1.1 after a upgrade to http2
+Daniel Stenberg (20 May 2016)
+- [Gisle Vanem brought this change]
-- test1801: first real http2 test case
+ curl_multibyte: fix compiler error
+
+ While compiling lib/curl_multibyte.c with '-DUSE_WIN32_IDN' etc. I was
+ getting:
+
+ f:\mingw32\src\inet\curl\lib\memdebug.h(38): error C2054: expected '('
+ to follow 'CURL_EXTERN'
+
+ f:\mingw32\src\inet\curl\lib\memdebug.h(38): error C2085:
+ 'curl_domalloc': not in formal parameter list
-- sws: initial tiny steps toward http2 support
+- THANKS-filter: make Jan-E get proper credit
-- FILEFORMAT: mention the new upgrade support
+- [Jan-E brought this change]
-- test1800: first plain-text http2 test case
+ winbuild/Makefile.vc: Fix check on SSL, MBEDTLS, WINSSL exclusivity
- Verifies the upgrade request, but gets a plain 1.1 response
+ Closes #818
-- [Tatsuhiro Tsujikawa brought this change]
+- [Alexander Traud brought this change]
- http: Disable pipelining for HTTP/2 and upgraded connections
+ libcurl.m4: Avoid obsolete warning
- This commit disables pipelining for HTTP/2 or upgraded connections. For
- HTTP/2, we do not support multiplexing. In general, requests cannot be
- pipelined in an upgraded connection, since it is now different protocol.
-
-- [Brad Harder brought this change]
-
- CURLOPT_POSTFIELDS.3: mention the COPYPOSTFIELDS option
-
-Steve Holme (19 Nov 2014)
-- multi-uv.c: Updated for curl coding standards
+ Closes #821
-- conncache: Fixed specifiers in infof() for long and size_t variables
+Jay Satiro (20 May 2016)
+- [Michael Kaufmann brought this change]
-- [Peter Wu brought this change]
-
- cmake: add Kerberos to the supported features
+ CURLOPT_CONNECT_TO.3: user must not free the list prematurely
- Updated following commit eda919f and a4b7f71.
+ The connect-to list isn't copied so as long as the handle may be used
+ for a transfer the list must be valid.
- Acked-by: Brad King <brad.king@kitware.com>
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Bug: https://github.com/curl/curl/pull/819
+ Reported-by: Michael Kaufmann
-- [Peter Wu brought this change]
+Daniel Stenberg (19 May 2016)
+- RELEASE-NOTES: synced with 48114a8634242c
- cmake: fix NTLM detection when CURL_DISABLE_HTTP defined
+- openssl: ERR_remove_thread_state() is deprecated in latest 1.1.0
- Updated following changes in commit f0d860d.
+ See OpenSSL commit 21e001747d4a
+
+- http2: use HTTP/2 in the HTTP/1.1-alike header
- Acked-by: Brad King <brad.king@kitware.com>
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ ... when generating them, not "2.0" as the protocol is called just
+ HTTP/2 and nothing else.
-Daniel Stenberg (19 Nov 2014)
-- RELEASE-NOTES: synced with cb13fad733e
+Jay Satiro (19 May 2016)
+- dist: include curl_multi_socket_all.3
+
+ Closes https://github.com/curl/curl/pull/816
-- [Jay Satiro brought this change]
+Steve Holme (18 May 2016)
+- bump: Start work on 7.49.1
- examples: Wait recommended 100ms when no file descriptors are ready
+Daniel Stenberg (18 May 2016)
+- curlbuild.h.dist: check __LP64__ as well to fix MIPS build
- Prior to this change when no file descriptors were ready on platforms
- other than Windows the multi examples would sleep whatever was in
- timeout, which may or may not have been less than the minimum
- recommended value [1] of 100ms.
+ The preprocessor check that sets up the 32bit defines for non-configure
+ builds didn't work properly for MIPS systems as __mips__ is defined for
+ both 32bit and 64bit. Now __LP64__ is also checked and indicates 64bit.
- [1]: http://curl.haxx.se/libcurl/c/curl_multi_fdset.html
+ Reported-by: Tomas Jakobsson
+ Fixes #813
-- [Waldek Kozba brought this change]
-
- multi-uv.c: close the file handle after download
+- [Marcel Raad brought this change]
-- [Jon Spencer brought this change]
+ schannel: fix compile break with MSVC XP toolset
+
+ For the Windows XP toolset of Visual C++ 2013/2015, the old Windows SDK
+ 7.1 is used. In this case, _USING_V110_SDK71_ is defined.
+
+ Closes #812
- multi: inform about closed sockets before they are closed
+- dist: include CHECKSRC.md
- When the connection code decides to close a socket it informs the multi
- system via the Curl_multi_closed function. The multi system may, in
- turn, invoke the CURLMOPT_SOCKETFUNCTION function with
- CURL_POLL_REMOVE. This happens after the socket has already been
- closed. Reorder the code so that CURL_POLL_REMOVE is called before the
- socket is closed.
+ Reported-by: Paul Howarth
+ Bug: https://curl.haxx.se/mail/lib-2016-05/0116.html
-Guenter Knauf (19 Nov 2014)
-- build: in Makefile.m32 moved target autodetection.
+- test/Makefile.am: include manpage-scan.pl and nroff-scan.pl in dist
- Moved target autodetection block after defining CC macro.
+ Reported-by: Ray Satiro
+ Bug: https://curl.haxx.se/mail/lib-2016-05/0113.html
-- build: in Makefile.m32 simplify platform flags.
+Version 7.49.0 (17 May 2016)
-- build: in Makefile.m32 try to detect 64bit target.
+Daniel Stenberg (17 May 2016)
+- THANKS: 24 new names from 7.49.0 release notes
-Daniel Stenberg (19 Nov 2014)
-- [Brad King brought this change]
+- RELEASE-NOTES: 7.49.0
- CMake: Simplify if() conditions on check result variables
+- mbedtls/polarssl: set "hostname" unconditionally
- Remove use of an old hack that takes advantage of the auto-dereference
- behavior of the if() command to detect if a variable is defined. The
- hack has the form:
+ ...as otherwise the TLS libs will skip the CN/SAN check and just allow
+ connection to any server. curl previously skipped this function when SNI
+ wasn't used or when connecting to an IP address specified host.
- if("${VAR} MATCHES "^${VAR}$")
+ CVE-2016-3739
- where "${VAR}" is a macro argument reference. Use if(DEFINED) instead.
- This also avoids warnings for CMake Policy CMP0054 in CMake 3.1.
+ Bug: https://curl.haxx.se/docs/adv_20160518A.html
+ Reported-by: Moti Avrahami
-- TODO-RELEASE: removed
-
-- [Carlo Wood brought this change]
+- [Frank Gevaerts brought this change]
- debug: added new connection cache output, plus fixups
-
- Debug output 'typo' fix.
-
- Don't print an extra "0x" in
- * Pipe broke: handle 0x0x2546d88, url = /
+ CURLOPT_RESOLVE.3: fix typo
- Add debug output.
- Print the number of connections in the connection cache when
- adding one, and not only when one is removed.
-
- Fix typos in comments.
+ Closes #811
+
+- docs: CURLOPT_RESOLVE overrides CURLOPT_IPRESOLVE
-- multi: move the ending condition into the loop as well
+- KNOWN_BUGS: GnuTLS backend skips really long certificate fields
- ... as it was before I changed the loop in commit e04ccbd50. It caused
- test 2030 and 2032 to fail.
+ Closes #762
-Steve Holme (18 Nov 2014)
-- multi: Prefer we don't use CURLE_OK and NULL in comparisons
+- CURLOPT_HTTPPOST.3: the data needs to be around while in use
-Daniel Stenberg (18 Nov 2014)
-- multi_runsingle: use 'result' for local CURLcode storage
+- openssl: get_cert_chain: fix NULL dereference
- ... and assign data->result only at the end. Makes the code more compact
- (easier to read) and more similar to other code.
+ CID 1361815: Explicit null dereferenced (FORWARD_NULL)
-- multi_runsingle: rename result to rc
+- openssl: get_cert_chain: avoid NULL dereference
- save 'result' for CURLcode types
+ CID 1361811: Explicit null dereferenced (FORWARD_NULL)
-- multi: make multi_runsingle loop internally
+- dprintf_formatf: fix (false?) Coverity warning
- simplifies the use of this function at little cost.
-
-- [Carlo Wood brought this change]
-
- multi: when leaving for timeout, close accordingly
+ CID 1024412: Memory - illegal accesses (OVERRUN). Claimed to happen when
+ we run over 'workend' but the condition says <= workend and for all I
+ can see it should be safe. Compensating for the warning by adding a byte
+ margin in the buffer.
- Fixes the problem when a transfer in a pipeline times out.
+ Also, removed the extra brace level indentation in the code and made it
+ so that 'workend' is only assigned once within the function.
-Guenter Knauf (18 Nov 2014)
-- build: in Makefile.m32 add -m32 flag for 32bit.
+- RELEASE-NOTES: synced with 2dcb5adc72d6
-- mk-ca-bundle.vbs: update copyright year.
+- THANKS-filter: fixed Jonathan Cardoso
-- build: in Makefile.m32 pass -F flag to windres.
-
-Steve Holme (17 Nov 2014)
-- config-win32: Fixed build targets for the VS2012+ Windows XP toolset
+Jay Satiro (15 May 2016)
+- ftp: fix incorrect out-of-memory code in Curl_pretransfer
- Even though commit 23e70e1cc6 mentioned the v110_xp toolset, I had
- forgotten to include the relevant pre-processor definitions.
-
-- sasl_sspi: Removed note about the NTLM functions being a wrapper
-
-- connect.c: Fixed compilation warning when no verbose string support
+ - Return value type must match function type.
- warning: unused parameter 'reason'
-
-- easy.c: Fixed compilation warning when no verbose string support
+ s/CURLM_OUT_OF_MEMORY/CURLE_OUT_OF_MEMORY/
- warning: unused parameter 'easy'
+ Caught by Travis CI
-- win32: Updated some legacy APIs to use the newer extended versions
+Daniel Stenberg (15 May 2016)
+- ftp wildcard: segfault due to init only in multi_perform
- Updated the usage of some legacy APIs, that are preventing curl from
- compiling for Windows Store and Windows Phone build targets.
+ The proper FTP wildcard init is now more properly done in Curl_pretransfer()
+ and the corresponding cleanup in Curl_close().
- Suggested-by: Stefan Neis
- Feature: http://sourceforge.net/p/curl/feature-requests/82/
-
-- config-win32: Introduce build targets for VS2012+
+ The previous place of init/cleanup code made the internal pointer to be NULL
+ when this feature was used with the multi_socket() API, as it was made within
+ the curl_multi_perform() function.
- Visual Studio 2012 introduced support for Windows Store apps as well as
- supporting Windows Phone 8. Introduced build targets that allow more
- modern APIs to be used as certain legacy ones are not available on these
- new platforms.
-
-- sasl_sspi: Fixed compilation warnings when no verbose string support
+ Reported-by: Jonathan Cardoso Machado
+ Fixes #800
-- sasl_sspi: Added base64 decoding debug failure messages
+Jay Satiro (13 May 2016)
+- libcurl-tlibcurl-thread: Update OpenSSL links
- Just like in the NTLM code, added infof() failure messages for
- DIGEST-MD5 and GSSAPI authentication when base64 decoding fails.
-
-- ntlm: Moved the SSPI based Type-3 message generation into the SASL module
-
-- ntlm: Moved the SSPI based Type-2 message decoding into the SASL module
+ Because the old OpenSSL link now redirects to their master documentation
+ (currently 1.1.0), which does not document the required actions for
+ OpenSSL <= 1.0.2.
-- ntlm: Moved the SSPI based Type-1 message generation into the SASL module
+Daniel Stenberg (13 May 2016)
+- [Viktor Szakats brought this change]
-- [Michael Osipov brought this change]
+ darwinssl.c: fix OS X codename typo in comment
- kerberos: Use symbol qualified with _KERBEROS5
+- RELEASE-NOTES: synced with 68701e51c1f7
- For consistency renamed USE_KRB5 to USE_KERBEROS5.
+ Added 8 bug fixes and 5 more contrbutors
-Daniel Stenberg (15 Nov 2014)
- [Jay Satiro brought this change]
- examples: Don't call select() to sleep on windows
+ mprintf: Fix processing of width and prec args
- Windows does not support using select() for sleeping without a dummy
- socket. Instead use Windows' Sleep() and sleep for 100ms which is the
- minimum suggested value in the curl_multi_fdset() doc.
+ Prior to this change a width arg could be erroneously output, and also
+ width and precision args could not be used together without crashing.
- Prior to this change the multi examples would exit prematurely since
- select() would error instead of sleeping when called without an fd.
+ "%0*d%s", 2, 9, "foo"
- Reported-by: Johan Lantz
- Bug: http://curl.haxx.se/mail/lib-2014-11/0221.html
-
-- [Tatsuhiro Tsujikawa brought this change]
-
- http2: Don't send Upgrade headers when we already do HTTP/2
-
-Steve Holme (15 Nov 2014)
-- sasl: Corrected Curl_sasl_build_spn() function description
+ Before: "092"
+ After: "09foo"
- There was a mismatch in function parameter names.
-
-- tool: Removed krb4 from the supported features
+ "%*.*s", 5, 2, "foo"
- Although libcurl would never return CURL_VERSION_KERBEROS4 after 7.33,
- so would not be output with --version, removed krb4 from the supported
- features output.
-
-- [Michael Osipov brought this change]
-
- tool: Use Kerberos for supported features
-
-- urldata: Don't define sec_complete when no GSS-API support present
+ Before: crash
+ After: " fo"
- This variable is only used with HAVE_GSSAPI is defined by the FTP code
- so let's place the definition with the other GSS-API based variables.
-
-- [Michael Osipov brought this change]
+ Test 557 is updated to verify this and more
- docs: Use consistent naming for Kerberos
+- [Michael Kaufmann brought this change]
-- TODO: Lets support QOP options in GSSAPI authentication
-
-- sasl_sspi: Corrected a couple of comment typos
-
-- sasl: Moved Curl_sasl_gssapi_cleanup() definition into header file
+ ConnectionExists: follow-up fix for proxy re-use
- Rather than define the function as extern in the source files that use
- it, moved the function declaration into the SASL header file just like
- the Digest and NTLM clean-up functions.
+ Follow-up commit to 5823179
- Additionally, added a function description comment block.
-
-- sasl_sspi: Added missing RFC reference for HTTP Digest authentication
-
-- ntlm: Clean-up and standardisation of base64 decoding
+ Closes #648
-- ntlm: We prefer 'CURLcode result'
+- [Per Malmberg brought this change]
-Daniel Stenberg (13 Nov 2014)
-- [Brad King brought this change]
-
- CMake: Restore order-dependent library checks
-
- Revert commit 2257deb502 (Cmake: Avoid cycle directory dependencies,
- 2014-08-22) and add a comment explaining the purpose of the original
- code.
+ darwinssl: fix certificate verification disable on OS X 10.8
- The check_library_exists_concat macro is intended to be called multiple
- times on a sequence of possibly dependent libraries. Later libraries
- may depend on earlier libraries when they are static. They cannot be
- safely linked in reverse order on some platforms.
+ The new way of disabling certificate verification doesn't work on
+ Mountain Lion (OS X 10.8) so we need to use the old way in that version
+ too. I've tested this solution on versions 10.7.5, 10.8, 10.9, 10.10.2
+ and 10.11.
- Signed-off-by: Brad King <brad.king@kitware.com>
+ Closes #802
-- [Brad King brought this change]
+- [Cory Benfield brought this change]
- CMake: Restore order-dependent header checks
-
- Revert commit 1269df2e3b (Cmake: Don't check for all headers each
- time, 2014-08-15) and add a comment explaining the purpose of the
- original code.
+ http2: Add space between colon and header value
- The check_include_file_concat macro is intended to be called multiple
- times on a sequence of possibly dependent headers. Later headers
- may depend on earlier headers to provide declarations. They cannot
- be safely included independently on some platforms.
-
- For example, many POSIX APIs document including sys/types.h before some
- other headers. Also on some OS X versions sys/socket.h must be included
- before net/if.h or the check for the latter will fail.
-
- Signed-off-by: Brad King <brad.king@kitware.com>
-
-- [Peter Wu brought this change]
-
- test22: expand a backtick command
+ curl's representation of HTTP/2 responses involves transforming the
+ response to a format that is similar to HTTP/1.1. Prior to this change,
+ curl would do this by separating header names and values with only a
+ colon, without introducing a space after the colon.
- This is the only user of the backtick operator in the command. As the
- commands will soon not be executed by a shell anymore (but by perl),
- replace the command with its output.
+ While this is technically a valid way to represent a HTTP/1.1 header
+ block, it is much more common to see a space following the colon. This
+ change introduces that space, to ensure that incautious tools are safely
+ able to parse the header block.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
-
-- RELEASE-NOTES: synced with 2ee3c63b13
-
-- http2: fix switched macro when http2 is not enabled
-
-- [Tatsuhiro Tsujikawa brought this change]
-
- http2: Deal with HTTP/2 data inside response header buffer
+ This also ensures that the difference between the HTTP/1.1 and HTTP/2
+ response layout is as minimal as possible.
- Previously if HTTP/2 traffic is appended to HTTP Upgrade response header
- (thus they are in the same buffer), the trailing HTTP/2 traffic is not
- processed and lost. The appended data is most likely SETTINGS frame.
- If it is lost, nghttp2 library complains server does not obey the HTTP/2
- protocol and issues GOAWAY frame and curl eventually drops connection.
- This commit fixes this problem and now trailing data is processed.
-
-Steve Holme (11 Nov 2014)
-- configure: Fixed inclusion of krb5 when CURL_DISABLE_CRYPTO_AUTH is defined
+ Bug: https://github.com/curl/curl/issues/797
- Commit fe0f8967bf fixed a problem with krb5 not being defined as a
- supported feature when HAVE_GSSAPI is defined, however, it should
- only be included if CURL_DISABLE_CRYPTO_AUTH is not set, like when
- SPNEGO is listed as a feature.
+ Closes #798
+ Fixes #797
-Daniel Stenberg (10 Nov 2014)
-- multi: removed Curl_multi_set_easy_connection
+Kamil Dudka (12 May 2016)
+- openssl: fix compile-time warning in Curl_ossl_check_cxn()
- It isn't used anywhere!
+ ... introduced in curl-7_48_0-293-g2968c83:
- Reported-by: Carlo Wood
+ Error: COMPILER_WARNING:
+ lib/vtls/openssl.c: scope_hint: In function ‘Curl_ossl_check_cxn’
+ lib/vtls/openssl.c:767:15: warning: conversion to ‘int’ from ‘ssize_t’
+ may alter its value [-Wconversion]
-- [Peter Wu brought this change]
-
- symbol-scan.pl: do not require autotools
+Jay Satiro (11 May 2016)
+- openssl: stricter connection check function
- Makes test1119 pass when building with cmake.
+ - In the case of recv error, limit returning 'connection still in place'
+ to EINPROGRESS, EAGAIN and EWOULDBLOCK.
- configurehelp.pm is generated by configure (autotools). As cmake does
- not provide a separate variable for the C preprocessor, default to cpp.
- Before commit ef24ecde68a5f577a7f0f423a767620f09a0ab16 ("symbol-scan:
- use configure script knowledge about how to run the C preprocessor"),
- this tool would also use 'cpp'.
+ This is an improvement on the parent commit which changed the openssl
+ connection check to use recv MSG_PEEK instead of SSL_peek.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Ref: https://github.com/curl/curl/commit/856baf5#comments
-- [Peter Wu brought this change]
+Daniel Stenberg (11 May 2016)
+- [Anders Bakken brought this change]
- cmake: add ENABLE_THREADED_RESOLVER, rename ARES
+ TLS: SSL_peek is not a const operation
- Fix detection of the AsynchDNS feature which not just depends on
- pthreads support, but also on whether USE_POSIX_THREADS is set or not.
- Caught by test 1014.
+ Calling SSL_peek can cause bytes to be read from the raw socket which in
+ turn can upset the select machinery that determines whether there's data
+ available on the socket.
- This patch adds a new ENABLE_THREADED_RESOLVER option (corresponding to
- --enable-threaded-resolver of autotools) which also needs a check for
- HAVE_PTHREAD_H.
+ Since Curl_ossl_check_cxn only tries to determine whether the socket is
+ alive and doesn't actually need to see the bytes SSL_peek seems like
+ the wrong function to call.
- For symmetry with autotools, CURL_USE_ARES is renamed to ENABLE_ARES
- (--enable-ares). Checks that test for the availability actually use
- USE_ARES instead as that is the result of whether a-res is available or
- not (in practice this does not matter as CARES is marked as required
- package, but nevertheless it is better to write the intent).
+ We're able to occasionally reproduce a connect timeout due to this
+ bug. What happens is that Curl doesn't know to call SSL_connect again
+ after the peek happens since data is buffered in the SSL buffer and thus
+ select won't fire for this socket.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Closes #795
-- [Peter Wu brought this change]
+Jay Satiro (9 May 2016)
+- [Daniel Stenberg brought this change]
- cmake: build libhostname for test suite
-
- Used by some test cases via LD_PRELOAD in order to fake the host name.
+ TLS: move the ALPN/NPN enable bits to the connection
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
-
-- [Peter Wu brought this change]
-
- cmake: fix HAVE_GETHOSTNAME definition
+ Only protocols that actually have a protocol registered for ALPN and NPN
+ should try to get that negotiated in the TLS handshake. That is only
+ HTTPS (well, http/1.1 and http/2) right now. Previously ALPN and NPN
+ would wrongly be used in all handshakes if libcurl was built with it
+ enabled.
- Otherwise Curl_gethostname always fails. Windows has gethostname
- since Vista according to
- http://msdn.microsoft.com/en-us/library/ms738527%28VS.85%29.aspx, but
- accordings to byte_bucket's VC 2005 documentation, it is available even
- in Windows 95. (possibly after installing a Platform SDK, the
- Windows Server 2003 SP1 Platform SDK should be sufficient).
+ Reported-by: Jay Satiro
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Fixes #789
-- [Peter Wu brought this change]
+Daniel Stenberg (8 May 2016)
+- libcurl-thread.3: openssl 1.1.0 is safe, and so is boringssl
- tests: fix libhostname visibility
-
- I noticed that a patched cmake build would pass tests with a fake local
- hostname, but the autotools build skips them:
+- [Antonio Larrosa brought this change]
+
+ connect: fix invalid "Network is unreachable" errors
- got unexpected host name back, LD_PRELOAD failed
+ Sometimes, in systems with both ipv4 and ipv6 addresses but where the
+ network doesn't support ipv6, Curl_is_connected returns an error
+ (intermittently) even if the ipv4 socket connects successfully.
- It turns out that -fvisibility=hidden hides the symbol, and since the
- tests are not part of libcurl, it fails too. Just remove the LIBCURL
- guard.
+ This happens because there's a for-loop that iterates on the sockets but
+ the error variable is not resetted when the ipv4 is checked and is ok.
- Broken since cURL 7.30 (commit 83a42ee20ea7fc25abb61c0b7ef56ebe712d7093,
- "curl.h: stricter CURL_EXTERN linkage decorations logic").
+ This patch fixes this problem by setting error to 0 when checking the
+ second socket and not having a result yet.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Fixes #794
-- [Peter Wu brought this change]
+Jay Satiro (5 May 2016)
+- FAQ: refer to thread safety guidelines
- tests: fix memleak in server/resolve.c
+Daniel Stenberg (3 May 2016)
+- connections: non-HTTP proxies on different ports aren't reused either
- This makes LeakSanitizer happy.
+ Reported-by: Oleg Pudeyev and fuchaoqun
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Fixes #648
-- configure: assume krb5 when gss-api works
+- http: make sure a blank header overrides accept_decoding
- To please test 1014 while we work out if this is truly the a correct
- assumption.
+ Reported-by: rcanavan
+ Assisted-by: Isaac Boukris
+ Closes #785
-Steve Holme (9 Nov 2014)
-- vtls.h: Fixed compiler warning when compiled without SSL
-
- vtls.c:185:46: warning: unused parameter 'data'
+- CHECKSRC.md: clarified, explained the whitelist file
-- RELEASE-NOTES: Synced with 2fbf23875f
+- nroff-scan.pl: verify that references are made with \fI
-- ntlm: Added separate SSPI based functions
-
- In preparation for moving the NTLM message code into the SASL module,
- and separating the native code from the SSPI code, added functions that
- simply call the functions in curl_ntlm_msg.c.
+- docs: unified man page references to use \fI
-- http_ntlm: Use the SASL functions instead
+- TODO: 17.14 --fail without --location should treat 3xx as a failure
- In preparation for moving the NTLM message code into the SASL module
- use the SASL functions in the HTTP code instead.
+ Closes #727
-Daniel Stenberg (9 Nov 2014)
-- libssh2: detect features based on version, not configure checks
-
- ... so that non-configure builds get the correct functions too based on
- the libssh2 version used.
+- RELEASE-NOTES: synced with 7987f5cb14d
-- [Nobuhiro Ban brought this change]
+- [Isaac Boukris brought this change]
- SSH: use the port number as well for known_known checks
+ CURLOPT_ACCEPT_ENCODING.3: Follow-up clarification
- ... if the libssh2 version is new enough.
+ Mention possible content-length mismatch with sum of bytes reported
+ by write callbacks when auto decoding is enabled.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1448
+ See #785
-Steve Holme (9 Nov 2014)
-- INSTALL: Updated pre-processor references to the old VC6 project files
-
- Reworked the two sections that discuss modifying the Visual Studio pre-
- processor settings, and vc6libcurl.dsw/vc6libcurl.dsp, to remove the
- project files references as they have been superseded by a more thorough
- set of project files for VC6 through VC12, but to also give the correct
- reference to this setting in later versions of Visual Studio.
+- test1140: run nroff-scan to verify man pages
-- INSTALL: Added email protocols to the "Disabling in Win32 builds" section
+- nroff-scan.pl: verify the .BR references as well
-- configure: Fixed NTLM missing from features when CURL_DISABLE_HTTP defined
+- CURLOPT_CONV_TO_NETWORK_FUNCTION.3: fix bad man page reference
-- build: Fixed no NTLM support for email when CURL_DISABLE_HTTP is defined
-
- USE_NTLM would only be defined if: HTTP support was enabled, NTLM and
- cryptography weren't disabled, and either a supporting cryptography
- library or Windows SSPI was being compiled against.
+- CURLOPT_BUFFERSIZE.3: fix reference to CURLOPT_MAX_RECV_SPEED_LARGE
+
+- curl_easy_pause.3: fix man page reference
+
+Jay Satiro (1 May 2016)
+- tool_cb_hdr: Fix --remote-header-name with schemeless URL
- This means it was not possible to build libcurl without HTTP support
- and use NTLM for other protocols such as IMAP, POP3 and SMTP. Rather
- than introduce a new SASL pre-processor definition, removed the HTTP
- prerequisite just like USE_SPNEGO and USE_KRB5.
+ - Move the existing scheme check from tool_operate.
- Note: Winbind support still needs to be dependent on CURL_DISABLE_HTTP
- as it is only available to HTTP at present.
+ In the case of --remote-header-name we want to parse Content-disposition
+ for a filename, but only if the scheme is http or https. A recent
+ adjustment 0dc4d8e was made to account for schemeless URLs however it's
+ not 100% accurate. To remedy that I've moved the scheme check to the
+ header callback, since at that point the library has already determined
+ the scheme.
- This bug dates back to August 2011 when I started to add support for
- NTLM to SMTP.
+ Bug: https://github.com/curl/curl/issues/760
+ Reported-by: Kai Noda
-- ntlm: Removed an unnecessary free of native Target Info
+Daniel Stenberg (1 May 2016)
+- tls: make setting pinnedkey option fail if not supported
- Due to commit 40ee1ba0dc the free in Curl_ntlm_decode_type2_target() is
- longer required.
+ to make it obvious to users trying to use the feature with TLS backends
+ not supporting it.
+
+ Discussed in #781
+ Reported-by: Travis Burtrum
-- ntlm: Moved the native Target Info clean-up from HTTP specific function
+- nroff-scan.pl: verifies nroff pages
+
+ ... not used by any test yet but can be used stand-alone.
-- ntlm: Moved SSPI clean-up code into SASL module
+- opts: fix broken/bad references
-- Makefile.dist: Added support for WinIDN
+- [Michael Kaufmann brought this change]
-- Makefile.vc6: Added support for WinIDN
+ docs: fix bugs in CURLOPT_HTTP_VERSION.3 and CURLOPT_PIPEWAIT.3
+
+ Closes #786
-- Makefile.dist: Added some missing SSPI configurations
+- CURLOPT_ACCEPT_ENCODING.3: clarified
+
+ As discussed in #785
-- Makefile.dist: Separated the groups of SSL configurations from each other
+- curl.1: --mail-rcpt can be used multiple times
+
+ Reported-by: mgendre
+ Closes #784
-- Makefile.dist: Grouped the x64 configurations next to their x86 counterparts
+- [Karlson2k brought this change]
-- curl.h: Tidy up of CURL_VERSION_* flags
+ tests: Use 'pathhelp' for paths conversions in secureserver.pl
- As the list has gotten a little messy and hard to read, especially with
- the introduction of deprecated items, aligned the values and comments
- into clean columns and reworked some of the comments in the process.
-
-- curl_tool: Added krb5 to the supported features
+ Closes #675
-- configure: Added krb5 to the supported features
+- [Karlson2k brought this change]
-- version info: Added Kerberos V5 to the supported features
+ tests: Use 'pathhelp' for paths conversions in sshserver.pl
-Guenter Knauf (7 Nov 2014)
-- mk-ca-bundle.vbs: switch to new certdata.txt url.
+- [Karlson2k brought this change]
-Steve Holme (7 Nov 2014)
-- RELEASE-NOTES: Synced with dcad09e125
+ tests: Use 'pathhelp' for current path in runtests.pl
-- http_digest: Fixed some memory leaks introduced in commit 6f8d8131b1
-
- Fixed a couple of memory leaks as a result of moving code that used to
- populate allocuserpwd and relied on it's clean up.
+- [Karlson2k brought this change]
-- docs: Updated following the addition of SSPI based HTTP digest auth
+ tests: pathhelp.pm to process paths on Msys/Cygwin
-- sasl_sspi: Tidy up of the existing digest code
+- lib: include curl_printf.h as one of the last headers
- Following the addition of SSPI support for HTTP digest, synchronised
- elements of the email digest code with that of the new HTTP code.
-
-- http_digest: Post SSPI support tidy up
+ curl_printf.h defines printf to curl_mprintf, etc. This can cause
+ problems with external headers which may use
+ __attribute__((format(printf, ...))) markers etc.
- Post tidy up to ensure commonality of code style and variable names.
-
-Dan Fandrich (6 Nov 2014)
-- test552: Don't run HTTP digest tests for SSPI based builds
+ To avoid that they cause problems with system includes, we include
+ curl_printf.h after any system headers. That makes the three last
+ headers to always be, and we keep them in this order:
- Technical difficulties prevented this from going into the
- previous commit.
-
-Steve Holme (6 Nov 2014)
-- tests: Don't run HTTP digest tests for SSPI based builds
+ curl_printf.h
+ curl_memory.h
+ memdebug.h
- Added !SSPI to the features list of the HTTP digest tests, as SSPI
- based builds now use the Windows SSPI messaging API rather than the
- internal functions, and we can't control the random numbers that get
- used as part of the digest.
-
-Daniel Stenberg (6 Nov 2014)
-- curl.1: show zone index use in a URL
-
-Steve Holme (6 Nov 2014)
-- http_digest: Fixed auth retry loop when SSPI based authentication fails
-
-- http_digest: Reworked the SSPI based input token storage
+ None of them include system headers, they all do funny #defines.
- Reworked the input token (challenge message) storage as what is passed
- to the buf and desc in the response generation are typically blobs of
- data rather than strings, so this is more in keeping with other areas
- of the SSPI code, such as the NTLM message functions.
-
-- sasl_sspi: Fixed compilation warning from commit 2d2a62e3d9
+ Reported-by: David Benjamin
- Added void reference to unused 'data' parameter back to fix compilation
- warning.
+ Fixes #743
-- sspi: Align definition values to even columns as we use 2 char spacing
-
-- sspi: Fixed missing definition of ISC_REQ_USE_HTTP_STYLE
+- memdebug.h: remove inclusion of other headers
- Some versions of Microsoft's sspi.h don't define this.
-
-- sasl: Removed non-SSPI Digest functions and defines from SSPI based builds
+ Mostly because they're not needed, because memdebug.h is always included
+ last of all headers so the others already included the correct ones.
- Introduced in commit 7e6d51a73c these functions and definitions are only
- required by the internal challenge-response functions now.
+ But also, starting now we don't want this to accidentally include any
+ system headers, as the header included _before_ this header may add
+ defines and other fun stuff that we won't want used in system includes.
-- sasl_sspi: Added HTTP digest response generation code
-
-- http_digest: Added SSPI based challenge decoding code
-
-- http_digest: Added SSPI based clean-up code
+- [Jay Satiro brought this change]
-- http_digest: Added SSPI based authentication functions
+ curl -J: make it work even without http:// scheme on URL
+
+ It does open up a miniscule risk that one of the other protocols that
+ libcurl could use would send back a Content-Disposition header and then
+ curl would act on it even if not HTTP.
- This temporarily breaks HTTP digest authentication in SSPI based builds,
- causing CURLE_NOT_BUILT_IN to be returned. A follow up commit will
- resume normal operation.
+ A future mitigation for this risk would be to allow the callback to ask
+ libcurl which protocol is being used.
+
+ Verified with test 1312
+
+ Closes #760
-- http_digest: Added required SSPI based variables to digest structure
+- manpage-scan.pl: also verify the command line option docs
+
+ This script now also scans src/tool_getparam.c, docs/curl.1 and
+ src/tool_help.c and will warn if any of them lists a command line option
+ not mentioned in one of the other places.
-Daniel Stenberg (6 Nov 2014)
-- [Frank Gevaerts brought this change]
+- curl: show the long option version of -q in the -h list
- contributors.sh: --releasenotes reads in names from RELEASE-NOTES
+- curl: remove "--socks" as "--socks5" turned 8
- This is very handy when updating the RELEASE-NOTES as then we sometimes
- have names added manually in the existing list and we use this script to
- update the set.
+ In commit 2e42b0a2524 (Jan 2008) we made the option "--socks" deprecated
+ and it has not been documented since. The more explicit socks options
+ (like --socks4 or --socks5) should be used.
-- RELEASE-NOTES: synced with 68542e72a9
+- curl.1: document the deprecated --ftp-ssl option
-- curl_easy_setopt.3: add CURLOPT_PINNEDPUBLICKEY
+- curl: remove --http-request
- Reported-by: Christian Hägele
- Bug: http://curl.haxx.se/mail/lib-2014-11/0078.html
+ It was mentioned as deprecated already in commit ae1912cb0d4 from
+ 1999. It has not been documented in this millennium.
-Steve Holme (5 Nov 2014)
-- build: Fixed Visual Studio project file generation of strdup.[c|h]
-
- As the curl command-line tool now includes it's own version of strdup(),
- for platforms that don't have it, fixed up the git respository Visual
- Studio project file generator to not include the version from lib in the
- tool project files, rather than having both lib\strdup.[c|h] and
- src\tool_strdup.[c|h] present.
+- curl: mention --ntlm-wb in -h list
-Daniel Stenberg (5 Nov 2014)
-- tool_strdup.c: include the tool strdup.h
-
- ... not the lib/ one that the tool no longer uses!
+- curl: -h output lacked --proxy-header
-- THANKS-filter: added another Michał Górny version we've used
+- curl.1: document --ntlm-wb
-- contributors.sh: split lists using " and "
-
- ... and require the space after the filtering to make the filter able to
- remove names.
+- curl.1: document the long format of -q: --disable
-Steve Holme (5 Nov 2014)
-- http_digest: Fixed memory leaks from commit 6f8d8131b1
+- curl.1: mention the deprecated --krb4 option
-- sasl: Fixed compilation warning from commit 25264131e2
-
- Added forward declaration of digestdata to overcome the following
- compilation warning:
+- curl.1: document --ftp-ssl-reqd
- warning: 'struct digestdata' declared inside parameter list
-
- Additionally made the ntlmdata forward declaration dependent on
- USE_NTLM similar to how digestdata and kerberosdata are.
+ Even if deprecated, document it so that people will find it as old
+ scripts may still use it.
-- sasl: Fixed HTTP digest challenges with spaces between auth parameters
+- curl: use --telnet-option as documented
- Broken as part of the rework, in commit 7e6d51a73c, to assist with the
- addition of HTTP digest via Windows SSPI.
+ The code said "telnet-options" but no documentation ever said so. It
+ worked fine since the code is fine with a unique match of the first
+ part.
-- http_digest: Fixed compilation errors from commit 6f8d8131b1
+- getparam: remove support for --ftpport
- error: invalid operands to binary
- warning: pointer targets in assignment differ in signedness
+ It has been deprecated and undocumented since commit ad5ead8bed7 (Dec
+ 2003). --ftp-port is the proper long option name.
-- http_digest: Moved response generation into SASL module
+- curl: make --disable work as long form of -q
+
+ To make the aliases list reflect reality.
-- http_digest: Moved challenge decoding into SASL module
+- aliases: remove trailing space from capath string
-- http_digest: Moved clean-up function into SASL module
+- cmdline parse: only single letter options have single-letter strings
+
+ ... moved around options so that parsing the code to find all
+ single-letter options easier.
-- http_digest: Moved algorithm definitions to SASL module
+Jay Satiro (28 Apr 2016)
+- CURLINFO_TLS_SSL_PTR.3: Clarify SSL pointer availability
+
+ Bug: https://curl.haxx.se/mail/lib-2016-04/0126.html
+ Reported-by: Bru Rom
-- [Gisle Vanem brought this change]
+Daniel Stenberg (28 Apr 2016)
+- curl_easy_getinfo.3: remove superfluous blank lines
- ssh: Fixed build on platforms where R_OK is not defined
+- test1139: verifies libcurl option man page presence
- Bug: http://curl.haxx.se/mail/lib-2014-11/0035.html
- Reported-by: Jan Ehrhardt
-
-- strdup: Removed irrelevant comment
+ - checks that each option has its own man page present
- ...as Curl_memdup() duplicates an area of fix size memory, that may be
- binary, and not a null terminated string.
+ - checks that each option is mentioned in its corresponding index man
+ page
-- url.c: Fixed compilation warning
+- curl_easy_getinfo.3: added missing mention of CURLINFO_TLS_SESSION
- conversion from 'curl_off_t' to 'size_t', possible loss of data
+ ... although it is deprecated.
-- http_digest: Use CURLcode instead of CURLdigest
+Jay Satiro (28 Apr 2016)
+- mbedtls: Fix session resume
- To provide consistent behaviour between the various HTTP authentication
- functions use CURLcode based error codes for Curl_input_digest()
- especially as the calling code doesn't use the specific error code just
- that it failed.
-
-Daniel Stenberg (5 Nov 2014)
-- contributors.sh: filter common alternative name spellings
+ This also fixes PolarSSL session resume.
- docs/THANKS-filter is a new filter file for converting contributor names
- we get or have recorded in alternative formats to the one we already use
- in THANKS. To help us show individual contributors using a single
- presentation of their names.
+ Prior to this change the TLS session information wasn't properly
+ saved and restored for PolarSSL and mbedTLS.
+
+ Bug: https://curl.haxx.se/mail/lib-2016-01/0070.html
+ Reported-by: Thomas Glanzmann
+
+ Bug: https://curl.haxx.se/mail/lib-2016-04/0095.html
+ Reported-by: Moti Avrahami
-- THANKS: added missing contributor from 2012
+Daniel Stenberg (27 Apr 2016)
+- RELEASE-NOTES: synced with f4298fcc6d2
-- [Frank Gevaerts brought this change]
+- [Michael Kaufmann brought this change]
- Remove duplicate names.
+ opts: Fix some syntax errors in example code fragments
- The removed names also appear as:
- Andrés García, François Charlier, Gökhan Şengün, Michał Górny, Sébastien
- Willemijns, Christopher Conroy, John E. Malmberg, Luca Altea, Peter Su,
- S. Moonesamy, Samuel Listopad, Yasuharu Yamada, Karl Moerder
+ Fixes #779
-Steve Holme (5 Nov 2014)
-- sspi: Define authentication package name constants
+- openssl: avoid BN_print a NULL bignum
- These were previously hard coded, and whilst defined in security.h,
- they may or may not be present in old header files given that these
- defines were never used in the original code.
+ OpenSSL 1.1.0-pre seems to return NULL(?) for a whole lot of those
+ numbers so make sure the function handles this.
- Not only that, but there appears to be some ambiguity between the ANSI
- and UNICODE NTLM definition name in security.h.
+ Reported-by: Linus Nordberg
-Patrick Monnerat (5 Nov 2014)
-- Adjust OS400-specific support to last release
+- [Marcel Raad brought this change]
-Daniel Stenberg (5 Nov 2014)
-- THANKS: added two missing names and removed a duplicate
+ CONNECT_ONLY: don't close connection on GSS 401/407 reponses
- ./contributors.sh found these extra ones that somehow had fallen
- through the cracks and never gotten added here.
+ Previously, connections were closed immediately before the user had a
+ chance to extract the socket when the proxy required Negotiate
+ authentication.
- Reported-by: Frank Gevaerts
-
-- bump: towards next release
+ This regression was brought in with the security fix in commit
+ 79b9d5f1a42578f
+
+ Closes #655
-- THANKS: added names from 7.39.0 release notes
+- CURLINFO_TLS_SESSION.3: clarify TLS library support before 7.48.0
-Version 7.39.0 (5 Nov 2014)
+- mbedtls.c: silly spellfix of a comment
-Daniel Stenberg (5 Nov 2014)
-- RELEASE-NOTES: 7.39.0 release (commit b3875606925)
+- KNOWN_BUGS: 1.10 Strips trailing dot from host name
+
+ Closes #716
-- curl_easy_duphandle: CURLOPT_COPYPOSTFIELDS read out of bounds
+- test1322: verify stripping of trailing dot from host name
- When duplicating a handle, the data to post was duplicated using
- strdup() when it could be binary and contain zeroes and it was not even
- zero terminated! This caused read out of bounds crashes/segfaults.
+ While being debated (in #716) and a violation of RFC 7230 section 5.4,
+ this test verifies that the existing functionality works as intended. It
+ strips the dot from the host name and uses the host without dot
+ throughout the internals.
+
+- multi: accidentally used resolved host name instead of proxy
- Since the lib/strdup.c file no longer is easily shared with the curl
- tool with this change, it now uses its own version instead.
+ Regression introduced in 09b5a998
- Bug: http://curl.haxx.se/docs/adv_20141105.html
- CVE: CVE-2014-3707
- Reported-By: Symeon Paraschoudis
+ Bug: https://curl.haxx.se/mail/lib-2016-04/0084.html
+ Reported-by: BoBo
-- lib544.c: use duphandle for test 545
-
- To verify that curl_easy_duphandle() works fine on a handle that has
- gotten data stored with *_COPYPOSTFIELDS.
+- symbols-in-versions: added new CURLSSLBACKEND_ symbols
-- tests: add new feature 'SSLpinning'
+- test148: fixed after the --ftp-create-dirs retry change
- ... and make test 2034 and 2035 require it, and have it set when built
- with OpenSSL or GnuTLS.
+ follow-up commit to 3c1e84f569 as it made curl try a little harder
-- buildconf: update copyright year
+- curl.h: clarify curl_sslbackend for openssl clones and renames
-Steve Holme (4 Nov 2014)
-- INSTALL: Consistent spacing in section headings, paragraphs and examples
+- [Karlson2k brought this change]
-Daniel Stenberg (4 Nov 2014)
-- buildconf: stop checking for libtool
+ url.c: fixed DEBUGASSERT() for WinSock workaround
- As we only use libtoolize, only check for that!
-
-Steve Holme (4 Nov 2014)
-- INSTALL: Corrected MIT Kerberos and Heimdal package names
+ If buffer is allocated, but nothing is received during prereceive
+ stage, than number of processed bytes must be zero.
+
+ Closes #778
-- README: Corrected inconsistent use of --help
+- KNOWN_BUGS: --interface for ipv6 binds to unusable IP address
+
+ Closes #686 for now.
-- INSTALL: Use GSS-API rather than GSSAPI
+- TODO: 1.17 Add support for IRIs
- As implementations are refereed to GSS-API libraries as per the RFC and
- GSSAPI typically refers to the SASL authentication mechanism.
+ Adding support for IRIs is a mouthful, but is probably interesting at
+ least for areas and countries where the use of such "URLs" are growing
+ popularity.
- ...and minor rewording on the same paragraph.
+ Closes #776
-- README: Added note about using Visual Studio projects out of git repository
+- THANKS-filter: Travis Burtrum
-Daniel Stenberg (4 Nov 2014)
-- [K. R. Walker brought this change]
+- lib1517: checksrc compliance
- cmake: fix ZLIB_INCLUDE_DIRS use
-
- CMake 2.8's FindZLIB.cmake documents ZLIB_INCLUDE_DIRS, see
- http://www.cmake.org/cmake/help/v2.8.0/cmake.html#module:FindZLIB
-
- Bug: https://github.com/bagder/curl/pull/123
+- [moparisthebest brought this change]
-- [Jay Satiro brought this change]
+ PolarSSL: Implement public key pinning
- SSL: PolarSSL default min SSL version TLS 1.0
-
- - Prior to this change no SSL minimum version was set by default at
- runtime for PolarSSL. Therefore in most cases PolarSSL would probably
- have defaulted to a minimum version of SSLv3 which is no longer secure.
+Patrick Monnerat (22 Apr 2016)
+- os400: upgrade ILE/RPG binding
-- opts-Makefile: put more man pages into dist and make hmtl+pdf
+- curl.h: CURLOPT_CONNECT_TO sets a struct slist *, not a string
-- curl_multi_setopt.3: refer to stand-alone pages
+Daniel Stenberg (22 Apr 2016)
+- contributors.sh: make --releasenotes implied
- ... instead of duplicating info.
+ It got too annoying to type =)
-- opts: more multi options as stand-alone man pages
+- RELEASE-NOTES: synced with 3c1e84f5693d8093
-- Makefile.am: two cmake files are gone
+- curl: make --ftp-create-dirs retry on failure
+
+ The underlying libcurl option used for this feature is
+ CURLOPT_FTP_CREATE_MISSING_DIRS which has the ability to retry the dir
+ creation, but it was never set to do that by the command line tool.
+
+ Now it does.
- 8cb010144 removed the CurlCheckCSourceCompiles.cmake and
- CurlCheckCSourceRuns.cmake files
+ Bug: https://curl.haxx.se/mail/archive-2016-04/0021.html
+ Reported-by: John Wanghui
+ Help-by: Leif W
-- opts: made stand-alone man-pages for several multi options
+- [Henrik Gaßmann brought this change]
-- [Carlo Wood brought this change]
+ winbuild: add mbedtls support
+
+ Add WITH_MBEDTLS option. Make WITH_SSL, WITH_MBEDTLS and ENABLE_WINSSL
+ options mutual exclusive.
+
+ Closes #606
- Curl_single_getsock: fix hold/pause sock handling
+- KNOWN_BUGS: fixed "5.6 Improper use of Autoconf cache variables"
- The previous condition that checked if the socket was marked as readable
- when also adding a writable one, was incorrect and didn't take the pause
- bits properly into account.
+ As of commit d9f3b365a3
-- [Peter Wu brought this change]
+- [Irfan Adilovic brought this change]
- cmake: fix struct sockaddr_storage check
+ configure: ac_cv_ -> curl_cv_ for write-only vars
- CHECK_TYPE_SIZE_PREINCLUDE is an internal, undocumented variable which
- was removed in cmake 2.8.1. According to the MSDN docs[1], inclusion
- of winsock2.h is sufficient. WIN32_LEAN_AND_MEAN does not really seem
- to affect the tests, so remove it too[2].
+ These configure vars are modified in a curl-specific way but never
+ evaluated or loaded from cache, even though they are designated as
+ _cv_. We could either implement proper AC_CACHE_CHECKs for them, or
+ remove them completely.
- For the non-windows case, remove inet headers as POSIX only requires
- sys/socket.h.
+ Fixes #603 as ac_cv_func_gethostbyname is no longer clobbered, and
+ AC_CHECK_FUNC(gethostbyname...) will no longer spuriously succeed after
+ the first configure run with caching.
- [1]: http://msdn.microsoft.com/en-us/library/windows/desktop/ms740504%28v=vs.85%29.aspx
- [2]: http://stackoverflow.com/questions/11040133/what-does-defining-win32-lean-and-mean-exclude-exactly
+ `ac_cv_func_strcasecmp` is curious, see #770.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ `eval "ac_cv_func_$func=yes"` can still cause problems as it works in
+ tandem with AC_CHECK_FUNCS and then potentially modifies its result. It
+ would be best to rewrite this test to use a new CURL_CHECK_FUNCS macro,
+ which works the same as AC_CHECK_FUNCS but relies on caching the values
+ of curl_cv_func_* variables, without modifiying ac_cv_func_*.
-- [Peter Wu brought this change]
+- [Irfan Adilovic brought this change]
- cmake: clean OtherTests, fixing -Werror
+ configure: ac_cv_ -> curl_cv_ for r/w vars
- There were several -Wunused warnings and one duplicate macro definition.
- The EXTRA_DEFINES variable of the CurlCheckCSources macro was being
- abused ("__unused1\n#undef inline\n#define __unused2", seriously?) to
- insert extra C code. Avoid this broken abstraction and use cmake's
- check_c_source_compiles directly (works fine with CMake 2.8, maybe
- even cmake 2.6).
+ These configure vars are modified in a curl-specific way and modified by
+ the configure process, but are never loaded from cache, even though they
+ are designated as _cv_. We should implement proper AC_CACHE_CHECKs for
+ them eventually.
+
+- [Irfan Adilovic brought this change]
+
+ configure: ac_cv_func_clock_gettime -> curl_...
- After cleaning up all related variables (EXTRA_DEFINES,
- HEADER_INCLUDES, auxiliary headers_hack), also remove a duplicate
- add_headers_include macro and remove duplicate header additions before
- the struct timeval check.
+ This variable must not be cached in its current form, as any cached
+ information will prevent the next configure run from determining the
+ correct LIBS needed for the function. Thus, rename prefix `ac_cv_` to
+ just `curl_`.
+
+- [Irfan Adilovic brought this change]
+
+ configure: ac_cv_ -> curl_cv_ for all cached vars
- Oh, and now the code is converted to use CheckCSourceRuns and
- CheckCSourceCompiles, the two curl-specific helpers can be removed.
- Unfortunately, the cmake output is now slightly more verbose. Before:
+ This was automated by:
- Performing Test int send(int, const void *, size_t, int) (curl_cv_func_send_test)
- Performing Test int send(int, const void *, size_t, int) (curl_cv_func_send_test) - Failed
+ sed -b -i -f <(ack -A1 AC_CACHE_CHECK | \
+ ack -o 'ac_cv_.*?\b' | \
+ sort -u | xargs -n1 bash -c \
+ 'echo "s/$0/curl_cv_${0#ac_cv_}/g"') \
+ $(git ls-files)
- Since check_c_source_compiles prints the varname, now you see:
+ This only changed the prefix for 16 variables actually checked with
+ AC_CACHE_CHECK.
+
+- openssl: builds with OpenSSL 1.1.0-pre5
- Performing Test curl_cv_func_send_test
- Performing Test curl_cv_func_send_test - Failed
- Tested: int send(int, const void *, size_t, int)
+ The RSA, DSA and DH structs are now opaque and require use of new APIs
- Compared cmake output with each other using vimdiff, no functional
- differences were found. Tested with GCC 4.9.1 and Clang 3.5.0.
+ Fixes #763
+
+Steve Holme (20 Apr 2016)
+- url.c: Prefer we don't use explicit NULLs in conditions
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Fixed commit fa5fa65a30 to not use NULLs in if condition.
-- [Peter Wu brought this change]
+Daniel Stenberg (20 Apr 2016)
+- [Isaac Boukris brought this change]
- cmake: fix gethostby{addr,name}_r in CurlTests
+ NTLM: check for NULL pointer before deferencing
- This patch cleans up the automatically-generated (?) code and fixes one
- case that will always fail due to syntax error.
+ At ConnectionExists, both check->proxyuser and check->proxypasswd
+ could be NULL, so make sure to check first.
- HAVE_GETHOSTBYADDR_R_5_REENTRANT always failed because of a trailing
- character ("int length;q"). Several parameter type and unused variable
- warnings popped up. This causes a detection failure with -Werror.
-
- Observe that the REENTRANT cases are exactly the same as their
- non-REENTRANT cases except for a `_REENTRANT` macro definition.
- Merge all these pieces and build one big main function with different
- cases, but reusing variables where logical.
+ Fixes #765
+
+- [Karlson2k brought this change]
+
+ tests: added test1517
- For the cases where the parameters where NULL, I looked at
- lib/hostip4.c to get an idea of the parameters types.
+ ... for checking ability to receive full HTTP response when POST request
+ is used with slow read callback function.
- void-cast variables such as 'rc' to avoid -Wuninitialized errors.
+ This test checks for bug #657 and verifies the work-around from
+ 72d5e144fbc6.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Closes #720
-- [Peter Wu brought this change]
+- [Karlson2k brought this change]
- cmake: drop _BSD_SOURCE macro usage
+ sendf.c: added ability to call recv() before send() as workaround
- autotools does not use features.h nor _BSD_SOURCE. As this macro
- triggers warnings since glibc 2.20, remove it. It should not have
- functional differences.
+ WinSock destroys recv() buffer if send() is failed. As result - server
+ response may be lost if server sent it while curl is still sending
+ request. This behavior noticeable on HTTP server short replies if
+ libcurl use several send() for request (usually for POST request).
+ To workaround this problem, libcurl use recv() before every send() and
+ keeps received data in intermediate buffer for further processing.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Fixes: #657
+ Closes: #668
-Steve Holme (2 Nov 2014)
-- RELEASE-NOTES: Synced with d71ea7c01e
+Kamil Dudka (19 Apr 2016)
+- connect: make sure that rc is initialized in singleipconnect()
- Additionally, updated "GSSAPI" to "GSS-API" for a Cmake related change
- as GSSAPI can be confused with the authentication mechanism rather than
- a GSS-API implementation library such as MIT or Heimdal.
-
-- build: Added WinIDN build configuration options
+ This commit fixes a Clang warning introduced in curl-7_48_0-190-g8f72b13:
- Added support for WinIDN build configurations to the VC6 project files.
+ Error: CLANG_WARNING:
+ lib/connect.c:1120:11: warning: The right operand of '==' is a garbage value
+ 1118| }
+ 1119|
+ 1120|-> if(-1 == rc)
+ 1121| error = SOCKERRNO;
+ 1122| }
-- build: Added WinIDN build configuration options
+Daniel Stenberg (19 Apr 2016)
+- make/checksrc: use $srcdir, not $top_srcdir
+
+- src/checksrc.whitelist: removed
+
+- tool_operate: switch to inline checksrc ignore
+
+- lib/checksrc.whitelist: not needed anymore
- Added support for WinIDN build configurations to the VC7 and VC7.1
- project files.
+ ... as checksrc now skips comments
-- build: Fixed the pre-processor separator in Visual Studio project files
+- vtls.h: remove a space before semicolon
- A left over from the VC6 project files, so mainly cosmetic in Visual
- Studio .NET as it can handle both comma and semi-colon characters for
- separating multiple pre-processor definitions.
+ ... that the new checksrc detected
+
+- darwinssl: removed commented out code
+
+- http_chunks: removed checksrc disable
- However, the IDE uses semi-colons if the value is edited, and as such,
- this may cause problems in future for anyone updating the files or
- merging patches.
+ ... since checksrc now skips comments
+
+- imap: inlined checksrc disable instead of whitelist edit
+
+- checksrc: taught to skip comments
- Used the Visual Studio IDE to correct the separator character.
+ ... but output non-stripped version of the line, even if that then can
+ make the script identify the wrong position in the line at
+ times. Showing the line stripped (ie without comments) is just too
+ surprising.
-- build: Added optional specific version generation of VC project files
+- opts/Makefile.am: list all docs file one by one
- ..when working from the git repository. This is particularly useful
- for single development environments where the project files for all
- supported versions of Visual Studio may not be required.
+ ... to make it easier to add lines in patches that won't just break all
+ other patches trying to add lines too.
-- [Jay Satiro brought this change]
+- curl_easy_setopt.3: mention CURLOPT_TCP_FASTOPEN
- build-openssl.bat: Fix x64 release build
+- RELEASE-NOTES: synced with 03de4e4b219
- Prior to this change if x64 release was specified a failed attempt was
- made to build x86 release instead.
+ (since we just merged two major features)
-- CURLOPT_XOAUTH2_BEARER.3: Corrected the OAuth version number
+- [Alessandro Ghedini brought this change]
-- CURLOPT_SASL_IR.3: Added supported mechanism information
+ connect: implement TCP Fast Open for Linux
- ...and removed duplication of what protocols are supported from the
- description text.
+ Closes #660
-- opts: Use common wording for MAIL related names
+- [Alessandro Ghedini brought this change]
-- opts: Use common wording for TLS user/password option names
-
- ...and revised the proxy wording a little as well.
+ tool: add --tcp-fastopen option
-- CURLOPT_MAXCONNECTS.3: Reworked the description to be less confusing
-
- ...and corrected a related typo in curl_easy_setopt.3.
+- [Alessandro Ghedini brought this change]
-Guenter Knauf (2 Nov 2014)
-- RELEASE-NOTES: removed obsolete entry; fixed entry.
+ connect: implement TCP Fast Open for OS X
-Steve Holme (2 Nov 2014)
-- RELEASE-NOTES: Synced with e7da67f5d3
+- [Alessandro Ghedini brought this change]
-- docs: Added mention of Kerberos for CURL_VERSION_SSPI
-
- As this has been present for SOCKSv5 proxy since v7.19.4 and for IMAP,
- POP3 and SMTP authentication since v7.38.0.
+ url: add CURLOPT_TCP_FASTOPEN option
-- CURL_VERSION_KERBEROS4: Mark as deprecated
-
- Support for Kerberos V4 was removed in v7.33.0.
+- checksrc: pass on -D so the whitelists are found correctly
-- sasl: Fixed Kerberos V5 inclusion when CURL_DISABLE_CRYPTO_AUTH is used
+- configure: remove check for libresolve
- Typically the USE_WINDOWS_SSPI definition would not be used when the
- CURL_DISABLE_CRYPTO_AUTH define is, however, it is still a valid build
- configuration and, as such, the SASL Kerberos V5 (GSSAPI) authentication
- data structures and functions would incorrectly be used when they
- shouldn't be.
+ 'strncasecmp' was once provided by libresolv (no trailing e) for SunOS,
+ but this check is broken and most likely adds nothing useful. Removing
+ now.
- Introduced a new USE_KRB5 definition that takes into account the use of
- CURL_DISABLE_CRYPTO_AUTH like USE_SPNEGO and USE_NTLM do.
-
-- openssl: Use 'CURLcode result'
+ Reported-by: Irfan Adilovic
- More CURLcode fixes.
+ Discussed in #770
-Daniel Stenberg (1 Nov 2014)
-- resume: consider a resume from [content-length] to be OK
-
- Basically since servers often then don't respond well to this and
- instead send the full contents and then libcurl would instead error out
- with the assumption that the server doesn't support resume. As the data
- is then already transfered, this is now considered fine.
+- scripts/make: use $(EXEEXT) for executables
- Test case 1434 added to verify this. Test case 1042 slightly modified.
+ Reported-by: bodop
- Reported-by: hugo
- Bug: http://curl.haxx.se/bug/view.cgi?id=1443
+ Fixes #771
-Steve Holme (1 Nov 2014)
-- openssl: Use 'CURLcode result'
-
- More standardisation of CURLcode usage and coding style.
+- includes: avoid duplicate memory callback typdefs even harder
-- openssl: Use 'CURLcode result'
+- checksrc/makefile.am: use $top_srcdir to find source files
- ...and some minor code style changes.
+ ... to properly support out of source tree builds.
-- ftplistparser: We prefer 'CURLcode result'
+- RELEASE-NOTES: synced with 26ec93dd6aeba8dfb5
-- opts: Use common wording for user/password option names
+- opts: fix option references missing (section)
-- CURLOPT_CONNECT_ONLY.3: Removed "This option is implemented for..." text
-
- As this is covered by the PROTOCOLS section and saves having to update
- two parts of the document with the same information in future.
+- [Michael Kaufmann brought this change]
-- CURLOPT_GSSAPI_DELEGATION.3: Use GSS-API rather than GSSAPI
+ news: CURLOPT_CONNECT_TO and --connect-to
- As implementations are refereed to GSS-API libraries as per the RFC and
- GSSAPI typically refers to an authentication mechanism.
+ Makes curl connect to the given host+port instead of the host+port found
+ in the URL.
-- CURLOPT_CONNECT_ONLY.3: Fixed incomplete protocol list
+- makefile.vc6: use d suffix on debug object
- Added missing IMAP to the protocol list.
-
-- code cleanup: Use 'CURLcode result'
-
-- curl_easy_setopt.3: Fixed lots of typos
-
-- curl_easy_setopt.3: Moved CURLOPT_DIRLISTONLY into PROTOCOL OPTIONS
+ To allow both release and debug builds in parallel.
- ...as this option affects more that just FTP.
-
-Guenter Knauf (30 Oct 2014)
-- build: added Watcom support to build with WinSSL.
-
-Daniel Stenberg (30 Oct 2014)
-- CURLOPT_PINNEDPUBLICKEY.3: added details
-
-Steve Holme (30 Oct 2014)
-- CURLOPT_CUSTOMREQUEST.3: Fixed incomplete protocol list
+ Reported-by: Rod Widdowson
- Whilst the description included information about SMTP, the protocol
- list only showed "TTP, FTP, IMAP, POP3".
+ Fixes #769
-- CURLOPT_DIRLISTONLY.3: Added information about the usage in POP3
+Jay Satiro (12 Apr 2016)
+- http2: Use size_t type for data drain count
+
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-Daniel Stenberg (29 Oct 2014)
-- openssl: enable NPN separately from ALPN
+- http2: Improve header parsing
- ... and allow building with nghttp2 but completely without NPN and ALPN,
- as nghttp2 can still be used for plain-text HTTP.
+ - Error if a header line is larger than supported.
- Reported-by: Lucas Pardue
-
-- configure.ac: remove checks for OpenSSL NPN/ALPN funcs again
+ - Warn if cumulative header line length may be larger than supported.
- ... since the conditional in the code are now based on OpenSSL versions
- instead to better support non-configure builds.
+ - Allow spaces when parsing the path component.
+
+ - Make sure each header line ends in \r\n. This fixes an out of bounds.
+
+ - Disallow header continuation lines until we decide what to do.
+
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- opts: added some "SEE ALSO" references
+- http2: Add Curl_http2_strerror for HTTP/2 error codes
+
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-Steve Holme (29 Oct 2014)
-- RELEASE-NOTES: Synced with 32913182dc
+- [Tatsuhiro Tsujikawa brought this change]
-- vtls.c: Fixed compilation warning
+ http2: Don't increment drain when one header field is received
- conversion from 'size_t' to 'unsigned int', possible loss of data
-
-- sspi: Return CURLE_LOGIN_DENIED on AcquireCredentialsHandle() failure
+ Sicne we write header field in temporary location, not in the memory
+ that upper layer provides, incrementing drain should not happen.
- Return a more appropriate error, rather than CURLE_OUT_OF_MEMORY when
- acquiring the credentials handle fails. This is then consistent with
- the code prior to commit f7e24683c4 when log-in credentials were empty.
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
+
+- [Tatsuhiro Tsujikawa brought this change]
-- sasl_sspi: Allow DIGEST-MD5 to use current windows credentials
+ http2: Ensure that http2_handle_stream_close is called
- Fixed the ability to use the current log-in credentials with DIGEST-MD5.
- I had previously disabled this functionality in commit 607883f13c as I
- couldn't get this to work under Windows 8, however, from testing HTTP
- Digest authentication through Windows SSPI and then further testing of
- this code I have found it works in Windows 7.
+ This commit ensures that streams which was closed in on_stream_close
+ callback gets passed to http2_handle_stream_close. Previously, this
+ might not happen. To achieve this, we increment drain property to
+ forcibly call recv function for that stream.
- Some further investigation is required to see what the differences are
- between Windows 7 and 8, but for now enable this functionality as the
- code will return an error when AcquireCredentialsHandle() fails.
-
-Kamil Dudka (29 Oct 2014)
-- transfer: drop the code handling the ssl_connect_retry flag
+ To more accurately check that we have no pending event before shutting
+ down HTTP/2 session, we sum up drain property into
+ http_conn.drain_total. We only shutdown session if that value is 0.
- Its last use has been removed by the previous commit.
-
-- nss: drop the code for libcurl-level downgrade to SSLv3
+ With this commit, when stream was closed before reading response
+ header fields, error code CURLE_HTTP2_STREAM is returned even if
+ HTTP/2 level error is NO_ERROR. This signals the upper layer that
+ stream was closed by error just like TCP connection close in HTTP/1.
- This code was already deactivated by commit
- ec783dc142129d3860e542b443caaa78a6172d56.
-
-- openssl: fix a line length warning
-
-Guenter Knauf (29 Oct 2014)
-- Added NetWare support to build with nghttp2.
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- Fixed error message since we require ALPN support.
+- [Tatsuhiro Tsujikawa brought this change]
-- Check for ALPN via OpenSSL version number.
+ http2: Process paused data first before tear down http2 session
- This check works also with to non-configure platforms.
-
-Steve Holme (28 Oct 2014)
-- sasl_sspi: Fixed typo in comment
+ This commit ensures that data from network are processed before HTTP/2
+ session is terminated. This is achieved by pausing nghttp2 whenever
+ different stream than current easy handle receives data.
+
+ This commit also fixes the bug that sometimes processing hangs when
+ multiple HTTP/2 streams are multiplexed.
+
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- code cleanup: We prefer 'CURLcode result'
+- [Tatsuhiro Tsujikawa brought this change]
-Daniel Stenberg (28 Oct 2014)
-- TODO: consider supporting STAT
+ http2: Check session closure early in http2_recv
+
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- mk-ca-bundle: spell fix "version"
+- [Tatsuhiro Tsujikawa brought this change]
-- HTTP: return larger than 3 digit response codes too
+ http2: Add handling stream level error
- HTTP 1.1 is clearly specified to only allow three digit response codes,
- and libcurl used sscanf("%3d") for that purpose. This made libcurl
- support smaller numbers but not larger. It does now, but we will not
- make any specific promises nor document this further since it is going
- outside of what HTTP is.
+ Previously, when a stream was closed with other than NGHTTP2_NO_ERROR
+ by RST_STREAM, underlying TCP connection was dropped. This is
+ undesirable since there may be other streams multiplexed and they are
+ very much fine. This change introduce new error code
+ CURLE_HTTP2_STREAM, which indicates stream error that only affects the
+ relevant stream, and connection should be kept open. The existing
+ CURLE_HTTP2 means connection error in general.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1441
- Reported-by: Balaji
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- src/: remove version.h.dist from gitignore
+Daniel Stenberg (11 Apr 2016)
+- http2: drain the socket better...
- It has not been used since commit f7bfdbab in 2011
-
-Steve Holme (26 Oct 2014)
-- ntlm: We prefer 'CURLcode result'
+ ... but ignore EAGAIN if the stream has ended so that we don't end up in
+ a loop. This is a follow-up to c8ab613 in order to avoid the problem
+ d261652 was made to fix.
- Continuing commit 0eb3d15ccb more return code variable name changes.
-
-Guenter Knauf (26 Oct 2014)
-- Cosmetics: lowercase non-special subroutine names.
+ Reported-by: Jay Satiro
+ Clues-provided-by: Tatsuhiro Tsujikawa
+
+ Discussed in #750
-Steve Holme (26 Oct 2014)
-- RELEASE-NOTES: Synced with 07ac29a058
+- KNOWN_BUGS: added info for "Hangs with PolarSSL"
-- http_negotiate: We prefer 'CURLcode result'
+- KNOWN_BUGS: 1.9 HTTP/2 frames while in the connection pool kill reuse
- Continuing commit 0eb3d15ccb more return code variable name changes.
+ Closes #750
-- http_negotiate: Fixed missing check for USE_SPNEGO
+- build: include scripts/ in the dist
-- sspi: Synchronization of cleanup code between auth mechanisms
-
-- sspi: Renamed max token length variables
+Steve Holme (9 Apr 2016)
+- CURLOPT_SOCKS5_GSSAPI_SERVICE: Merged with CURLOPT_PROXY_SERVICE_NAME
- Code cleanup to try and synchronise code between the different SSPI
- based authentication mechanisms.
-
-- sspi: Renamed expiry time stamp variables
+ As these two options provide identical functionality, the former for
+ SOCK5 proxies and the latter for HTTP proxies, merged the two options
+ together.
- Code cleanup to try and synchronise code between the different SSPI
- based authentication mechanisms.
+ As such CURLOPT_SOCKS5_GSSAPI_SERVICE is marked as deprecated as of
+ 7.49.0.
-- sspi: Only call CompleteAuthToken() when complete is needed
+- urldata: Use bool for socks5_gssapi_nec as it is a flag
- Don't call CompleteAuthToken() after InitializeSecurityContext() has
- returned SEC_I_CONTINUE_NEEDED as this return code only indicates the
- function should be called again after receiving a response back from
- the server.
-
- This only affected the Digest and NTLM authentication code.
+ This value is set to TRUE or FALSE so should be a bool and not a long.
+
+- url: Ternary operator code style changes
-Dan Fandrich (26 Oct 2014)
-- Added the "flaky" keyword to a number of tests
+- CODE_STYLE: Added ternary operator example to 'Space around operators'
- Each shows evidence of flakiness on at least one platform on
- the autobuilds. Users can use this keyword to skip these tests
- if desired.
+ Following conversation on the libcurl mailing list.
-Steve Holme (26 Oct 2014)
-- ntlm: Return all errors from Curl_ntlm_core_mk_nt_hash()
+- sasl: Fixed compilation errors from commit 9d89a0387
- For consistency with other areas of the NTLM code propagate all errors
- from Curl_ntlm_core_mk_nt_hash() up the call stack rather than just
- CURLE_OUT_OF_MEMORY.
+ ...when GSS-API or Windows SSPI are not used.
-- ntlm: Return CURLcode from Curl_ntlm_core_mk_lm_hash()
+- url: Corrected comments following 9d89a0387
-- ntlm: Use 'CURLcode result'
-
- Continuing commit 0eb3d15ccb more return code variable name changes.
+- docs: Added clarification following commit 9d89a0387
+
+- Makefile: Fixed echo of checksrc check
-- ntlm: Only define ntlm data structure when USE_NTLM is defined
+- checksrc: Fix issue with the autobuilds not picking up the whitelist
-- ntlm: Changed handles to be dynamic like other SSPI handles
+- checksrc: Added missing vauth and vtls directories
+
+- ftp/imap/pop3/smtp: Allow the service name to be overridden
- Code cleanup to try and synchronise code between the different SSPI
- based authentication mechanisms.
+ Allow the service name to be overridden for DIGIST-MD5 and Kerberos 5
+ authentication in FTP, IMAP, POP3 and SMTP.
-- ntlm: Renamed handle variables to match other SSPI structures
+- http_negotiate: Calculate service name and proxy service name locally
- Code cleanup to try and synchronise code between the different SSPI
- based authentication mechanisms.
+ Calculate the service name and proxy service names locally, rather than
+ in url.c which will allow for us to support overriding the service name
+ for other protocols such as FTP, IMAP, POP3 and SMTP.
+
+- ROADMAP: Updated following the move of the authentication code
-- ntlm: Renamed SSPI based input token variables
+Patrick Monnerat (8 Apr 2016)
+- KNOWN_BUGS: openldap hangs. TODO: binary SASL.
+
+Daniel Stenberg (8 Apr 2016)
+- KNOWN_BUGS: 5.6 Improper use of Autoconf cache variables
- Code cleanup to try and synchronise code between the different SSPI
- based authentication mechanisms.
+ Closes #603
-- ntlm: We prefer 'CURLcode result'
+- KNOWN_BUGS: 11.2 error buffer not set...
- Continuing commit 0eb3d15ccb more return code variable name changes.
+ Closes #544
-- build: Added WinIDN build configuration options
+- KNOWN_BUGS: 11.1 Curl leaks .onion hostnames in DNS
- Added support for WinIDN build configurations to the VC8 and VC9
- project files.
+ Closes #543
-Nick Zitzmann (24 Oct 2014)
-- darwinssl: detect possible future removal of SSLv3 from the framework
+- KNOWN_BUGS: 1.8 DNS timing is wrong for HTTP redirects
- If Apple ever drops SSLv3 support from the Security framework, we'll fail with an error if the user insists on using SSLv3.
+ Closes #522
-Patrick Monnerat (24 Oct 2014)
-- gskit.c: remove SSLv3 from SSL default.
+- TODO: HTTP/2 "prior knowledge" is implemented!
-- gskit.c: use 'CURLcode result'
+- [Damien Vielpeau brought this change]
-Daniel Stenberg (24 Oct 2014)
-- [Jay Satiro brought this change]
+ mbedtls: fix MBEDTLS_DEBUG builds
- SSL: Remove SSLv3 from SSL default due to POODLE attack
+- mbedtls: implement and provide *_data_pending()
- - Remove SSLv3 from SSL default in darwinssl, schannel, cyassl, nss,
- openssl effectively making the default TLS 1.x. axTLS is not affected
- since it supports only TLS, and gnutls is not affected since it already
- defaults to TLS 1.x.
+ ... as otherwise we might get stuck thinking there's no more data to
+ handle.
- - Update CURLOPT_SSLVERSION doc
-
-- pipelining: only output "is not blacklisted" in debug builds
-
-- *.3: add/extend "SEE ALSO" sections
+ Reported-by: Damien Vielpeau
+
+ Fixes #737
-- curl_easy_pause.3: minor wording edit
+- mbedtls: follow-up for the previous commit
-- curl_getdate.3: provide a "SEE ALSO" section
+- mbedtls.c: name space pollution fix, Use 'Curl_'
-- curl_global_init.3: minor formatting fix, add version info
+- mbedtls.c: changed private prefix to mbed_
+
+ mbedtls_ is the prefix used by the mbedTLS library itself so we should
+ avoid using that for our private functions.
-- url.c: use 'CURLcode result'
+- mbedtls.h: fix compiler warnings
-- code cleanup: we prefer 'CURLcode result'
-
- ... for the local variable name in functions holding the return
- code. Using the same name universally makes code easier to read and
- follow.
-
- Also, unify code for checking for CURLcode errors with:
-
- if(result) or if(!result)
+- Revert "winbuild: trying to set some files eol=crlf for git"
- instead of
+ This reverts commit 9c08b4f1e7eced5a4d3782a3e0daa484c9d77d21.
- if(result == CURLE_OK), if(CURLE_OK == result) or if(result != CURLE_OK)
-
-- Curl_add_timecondition: skip superfluous varible assignment
+ Didn't help. Caused problems.
- Detected by cppcheck.
+ Fixes #756
-- Curl_pp_flushsend: skip superfluous assignment
+- curl.1: use example.com more
- Detected by cppcheck.
+ Make (most) example snippets use the example.com domain instead of the
+ random ones picked and used before. Some of those were probably
+ legitimate sites and some not. example.com is designed for this purpose.
-- Curl_pp_readresp: remove superfluous assignment
-
- Variable already assigned a few lines up.
-
- Detected by cppcheck.
+- [Michael Kaufmann brought this change]
-- Curl_proxyCONNECT: remove superfluous statement
+ HTTP2: Add a space character after the status code
- The variable is already assigned, skip the duplicate assignment.
+ The space character after the status code is mandatory, even if the
+ reason phrase is empty (see RFC 7230 section 3.1.2)
- Pointed out by cppcheck.
-
-Guenter Knauf (24 Oct 2014)
-- Added MinGW support to build with nghttp2.
+ Closes #755
-- Added VC ssh2 target to main Makefile.
+- [Viktor Szakats brought this change]
-- Some cosmetics and simplifies.
-
-- Remove dependency on openssl and cut.
+ URLs: change http to https in many places
- Prefer usage of Perl modules for sha1 calculation since there
- might be systems where openssl is not installed or not in path.
- If openssl is used for sha1 calculation then dont rely on cut
- since it is usually not available on other systems than Linux.
-
-Daniel Stenberg (23 Oct 2014)
-- RELEASE-NOTES: synced with e116d0a62
+ Closes #754
-- CURLOPT_RESOLVE.3: add an example
-
-- gnutls: removed dead code
+- winbuild: trying to set some files eol=crlf for git
- Bug: http://curl.haxx.se/bug/view.cgi?id=1437
- Reported-by: Julien
+ Thinking it might help to apply patches etc with git.
+
+- [Theodore Dubois brought this change]
-- Curl_rand: Uninitialized variable: r
+ curl.1: change example for -F
- This is not actually used uninitialized but we silence warnings.
+ It's a bad idea to send your passwords anywhere, especially over HTTP.
+ Modified example to send a picture instead.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1437
- Reported-by: Julien
+ Fixes #752
-- opts: provide more and updated examples
-
-- CURLOPT_RANGE.3: works for SFTP as well
+- KNOWN_BUGS: reorganized and cleaned up
- ... and added a small example
-
-- curl.1: edited for clarity
-
-- CURLOPT_SSLVERSION.3: provide an example
-
-- docs/libcurl/ABI: more markdown friendly
+ Now sorted into categories and organized in the same style we do the
+ TODO document. It will make each issue linked properly on the
+ https://curl.haxx.se/docs/knownbugs.html web page.
+
+ The sections should make it easier to find issues and issues related to
+ areas of the reader's specific interest.
-- docs: edited lots of libcurl docs for clarity
+Jay Satiro (6 Apr 2016)
+- KNOWN_BUGS: #95 curl in Windows can't handle Unicode arguments
-- opts: added examples
+Steve Holme (6 Apr 2016)
+- KNOWN_BUGS: Use https://curl.haxx.se URL for github based issues
-- HISTORY: two glimpses in 2014
+- CHECKSRC.md: Corrected some typos
-Kamil Dudka (20 Oct 2014)
-- nss: reset SSL handshake state machine
+- RELEASE-NOTES: Corrected last updated
- ... when the handshake succeeds
+ Included a summary of the checksrc.bat updates and combined two krb5
+ changes as they should have been implemented at the same time.
+
+- vauth: Corrected a number of typos in comments
- This fixes a connection failure when FTPS handle is reused.
+ Reported-by: Michael Osipov
-Daniel Stenberg (20 Oct 2014)
-- [Peter Wu brought this change]
+Jay Satiro (5 Apr 2016)
+- KNOWN_BUGS: #94 IMAP custom requests use the LIST handler
+
+ Bug: https://github.com/curl/curl/issues/536
+ Reported-by: eXeC64@users.noreply.github.com
- cmake: generate pkg-config and curl-config
+Daniel Stenberg (5 Apr 2016)
+- KNOWN_BUGS: remove 68, 70 and 72.
- Initial work to generate a pkg-config and curl-config script. Static
- linking (`curl-config --static-libs` and `pkg-config --shared --libs
- libcurl`) is broken and therefore disabled.
+ Due to their age (we don't fully know if they actually remain) and lack
+ of detail - very few people will bother to find out what they're about
+ or work on them. If people truly still suffer from any of these, I
+ assume they will be reported again and then we'll deal with them.
- CONFIGURE_OPTIONS does not make sense for CMake, use an empty string
- for now.
+ 72. "Pausing pipeline problems."
+ https://curl.haxx.se/mail/lib-2009-07/0214.html
- At least `curl-config --features` and `curl-config --protocols` work
- which is needed by runtests.pl.
+ 70. Problem re-using easy handle after call to curl_multi_remove_handle
+ https://curl.haxx.se/mail/lib-2009-07/0249.html
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ 68. "More questions about ares behavior".
+ https://curl.haxx.se/mail/lib-2009-08/0012.html
-- [Peter Wu brought this change]
+- KNOWN_BUGS: remove 92 and 88, fixed
- cmake: use LIBCURL_VERSION from curlver.h
+- http2: fix connection reuse when PING comes after last DATA
- This matches the behavior from autotools. The auxiliary major, minor
- and patch components are not needed anymore and therefore removed.
+ It turns out the google GFE HTTP/2 servers send a PING frame immediately
+ after a stream ends and its last DATA has been received by curl. So if
+ we don't drain that from the socket, it makes the socket readable in
+ subsequent checks and libcurl then (wrongly) assumes the connection is
+ dead when trying to reuse the connection.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ Reported-by: Joonas Kuorilehto
+
+ Discussed in #750
-- [Peter Wu brought this change]
+- multi: remove trailing space in debug output
- cmake: add SUPPORT_FEATURES and SUPPORT_PROTOCOLS
-
- For compatibility with autoconf, it will be used later for curl-config
- and pkg-config. Not all features and or protocols can be enabled as
- these are missing additional checks (see new TODOs).
-
- SUPPORT_PROTOCOLS is partially scripted (grep for SUPPORT_PROTOCOLS=)
- and manually verified/modified. SUPPORT_FEATURES is manually added.
+- RELEASE-NOTES: synced with 86e97b642fb
+
+- CHECKSRC.md: mention cmdline options, fix the bullet list
+
+- docs/CHECKSRC.md: initial version
+
+Steve Holme (3 Apr 2016)
+- checksrc.bat: Added support for the examples
+
+Daniel Stenberg (3 Apr 2016)
+- lib/src: fix the checksrc invoke
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ ... now works correctly when invoke from the root makefile
-- cmake: add CMake/Macros.cmake to the release tarball
+- nw: please the stricter checksrc
-- test545: make it not use a trailing zero
+Steve Holme (3 Apr 2016)
+- checksrc.bat: Re-enabled the tests directory by default
- CURLOPT_COPYPOSTFIELDS with a given CURLOPT_POSTFIELDSIZE does not
- require a trailing zero of the data and by making sure this test doesn't
- use one we know it works (combined with valgrind).
+ Following the recent changes to the source in the tests directory,
+ re-enabled tests for the default scan.
-Steve Holme (16 Oct 2014)
-- ntlm: Fixed empty type-2 decoded message info text
+- checksrc.bat: Added tests/server directory support
- Updated the info text when the base-64 decode of the type-2 message
- returns a null buffer to be more specific.
+ In addition to commit 83b174b3f0 and following the recent changes.
-- ntlm: Fixed empty/bad base-64 decoded buffer return codes
+- tests: Fixed header files to comply with our code style
-- ntlm: Avoid unnecessary buffer allocation for SSPI based type-2 token
+Daniel Stenberg (3 Apr 2016)
+- make checksrc: run it in docs/examples too by default
-Daniel Stenberg (16 Oct 2014)
-- httpcustomheader.c: make use of more CURLOPT_HTTPHEADER features
+- docs/examples: remove spurious white spaces all over
- ... and only do a single request for clarity.
+ ... to please the new, slightly picker, checksrc.pl
-Steve Holme (15 Oct 2014)
-- sasl_sspi: Fixed some typos
+- tests: fix make checksrc in servers/
-- sasl_sspi: Fixed Kerberos response buffer not being allocated when using SSO
+- tests: 'make checksrc' now checks server/ too
-Daniel Stenberg (15 Oct 2014)
-- [Bruno Thomsen brought this change]
+- root/make: have checksrc run in include/curl too
- mk-ca-bundle: added SHA-384 signature algorithm
-
- Certificates based on SHA-1 are being phased out[1].
- So we should expect a rise in certificates based on SHA-2.
- Adding SHA-384 as a valid signature algorithm.
-
- [1] https://blog.mozilla.org/security/2014/09/23/phasing-out-certificates-with-sha-1-based-signature-algorithms/
-
- Signed-off-by: Bruno Thomsen <bth@kamstrup.dk>
+- tests/server: comply with our code style
-Patrick Monnerat (14 Oct 2014)
-- OS400: fix bugs in curl_*escape_ccsid() and reduce variables scope
+- code: style updates
-- Implement pinned public key in GSKit backend
+- checksrc: check for more malplaced spaces
-Daniel Stenberg (14 Oct 2014)
-- CURLOPT_TLSAUTH_*.3: fix reference typos
+- unit: make unit test source code checksrc compliant
-- cleanups: reduce variable scope
-
- cppcheck pointed these out.
+- checksrc: run checksrc in tests when 'make checksrc' in root
-- singleipconnect: remove dead assignment never used
-
- cppcheck pointed this out.
+- checksrc: remove debug crap
-- pinning: minor code style policing
+- lib557: allow too long lines
-Patrick Monnerat (13 Oct 2014)
-- Factorize pinned public key code into generic file handling and backend specific
+- checksrc: allow ignore of specific warnings within a file (section)
-- vtls: remove QsoSSL
+- checksrc: add warning names, explain on help output
-- gskit: supply dummy randomization function
+Steve Holme (3 Apr 2016)
+- checksrc.bat: Disable tests by default until warnings are fixed
-- vtls/*: deprecate have_curlssl_md5sum and set-up default md5sum implementation
+- checksrc.bat: Added support for the tests directory
-Daniel Stenberg (13 Oct 2014)
-- [Peter Wu brought this change]
+- vauth: Removed the need for a separate GSS-API based SPN function
- tests: move TESTCASES to Makefile.inc, add show for cmake
+- curl_sasl: Fixed potential null pointer utilisation
- This change allows runtests.pl to be run from the CMake builddir:
+ Although this should never happen due to the relationship between the
+ 'mech' and 'resp' variables, and the way they are allocated together,
+ it does cause problems for code analysis tools:
- export srcdir=/tmp/curl/tests;
- perl -I$srcdir $srcdir/runtests.pl -l
+ V595 The 'mech' pointer was utilized before it was verified against
+ nullptr. Check lines: 376, 381. curl_sasl.c 376
- In order to make this possible, all test cases have been moved from
- Makefile.am to Makefile.inc.
-
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
-
-- [Peter Wu brought this change]
+ Bug: https://github.com/curl/curl/issues/745
+ Reported-by: Alexis La Goutte
- cmake: enable IPv6 by default if available
+- spnego: Small code tidy up
- ENABLE_IPV6 depends on HAVE_GETADDRINFO or you will get a
- Curl_getaddrinfo_ex error. Enable IPv6 by default, disabling it if
- struct sockaddr_in6 is not found in netinet/in.h.
+ * Prefer dereference of string pointer rather than strlen()
+ * Free challenge pointer in one place
+ * Additional comments
+
+- krb5: Small code tidy up
- Note that HAVE_GETADDRINFO_THREADSAFE is still not set as it needs more
- platform checks even though POSIX requires a thread-safe getaddrinfo.
+ * Prefer dereference of string pointer rather than strlen()
+ * Free challenge pointer in one place
+ * Additional comments
+
+- krb5_gssapi: Only process challenge when present
- Verified on Arch Linux x86_64 with glibc 2.20-2 and Linux 3.16-rc7.
+ This wouldn't cause a problem because of the way the function is called,
+ but prior to this change, we were processing the challenge message when
+ the credentials were NULL rather than when the challenge message was
+ populated.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ This also brings this part of the Kerberos 5 code in line with the
+ Negotiate code.
-- [Peter Wu brought this change]
+- krb5: Fixed missing client response when mutual authentication enabled
+
+ Although mutual authentication is currently turned off and can only be
+ enabled by changing libcurl source code, authentication using Kerberos
+ 5 has been broken since commit 79543caf90 in this use case.
- cmake: build tool_hugehelp (ENABLE_MANUAL)
+- krb5_sspi: Only process challenge when present
- Rather than always outputting an empty manual page for the '-M' option,
- generate a full manual page as done by autotools. For simplicity in
- CMake, always generate the gzipped page as it will not be used anyway
- when zlib is not available.
+ This wouldn't cause a problem because of the way the function is called,
+ but prior to this change, we were processing the challenge message when
+ the credentials were NULL rather than when the challenge message was
+ populated.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ This also brings this part of the Kerberos 5 code in line with the
+ Negotiate code.
-- [Peter Wu brought this change]
+- krb5_sspi: Only generate the output token when its not allocated
+
+ Prior to this change, we were generating the output token when the
+ credentials were NULL rather than when the output token was NULL.
+
+ This also brings this part of the Kerberos 5 code in line with the
+ Negotiate code.
- tests/http_pipe.py: Python 3 support
+- krb5: Only generate a SPN when its not known
- The 2to3 tool converted socketserver (which I manually fixed up with an
- import fallback) and the print(e) line. The xrange option was converted
- to range, but it seems better to use the '*' operator here for
- simplicity.
+ Prior to this change, we were generating the SPN in the SSPI code when
+ the credentials were NULL and in the GSS-API code when the context was
+ empty. It is better to decouple the SPN generation from these checks
+ and only generate it when the SPN itself is NULL.
- Signed-off-by: Peter Wu <peter@lekensteyn.nl>
+ This also brings this part of the Kerberos 5 code in line with the
+ Negotiate code.
-- SECURITY: slightly nicer markdown format
+Daniel Stenberg (3 Apr 2016)
+- tests/libtest: follow our code style guidelines better
+
+ ... checksrc of all test code is pending.
-- RELEASE-PROCEDURE: better markdown, more content
+- checksrc.whitelist: remove fopen() uses
-- RELEASE-NOTES: synced with 6637b237e6eb
+- formdata: use appropriate fopen() macros
+
+- checksrc: improve the fopen() parser somewhat
- ... and bumped the planned release version.
+ The quote scanner was too fragile, now look for a comma instead to find
+ the mode argument.
-- vtls: have vtls.h include the backend header files
+- unit1604: fix snprintf
+
+ follow-up to 0326b06
- It turned out some features were not enabled in the build since for
- example url.c #ifdefs on features that are defined on a per-backend
- basis but vtls.h didn't include the backend headers.
+ sizeof(pointer) is no good for the buffer size!
- CURLOPT_CERTINFO was one such feature that was accidentally disabled.
+ Reported-by: Viktor Szakats
-- test2036: verify -O with no slash at all in the URL
+Steve Holme (3 Apr 2016)
+- unittests: Fixed compilation warnings
- Similar to test 76 but that test's URL has a slash just no file name
- part.
+ warning: implicit declaration of function 'sprintf_was_used'
+ [-Wimplicit-function-declaration]
+
+ Follow up to the modications made to tests/libtest in commit 55452ebdff
+ as we prefer not to use sprintf() now.
-- get_url_file_name: make no slash equal empty string
+Daniel Stenberg (2 Apr 2016)
+- curl.1: -w filename_effective was introduced in 7.26.0
+
+ We never made a 7.25.1 release
+
+- 7.49.0: next release version
-- get_url_file_name: never return a NULL string *and* OK
+- http2: make use of the nghttp2 error callback
- Change 987a4a73 assumes that as it simplifies life in the calling
- function.
+ It offers extra info from nghttp2 in certain error cases. Like for
+ example when trying prior-knowledge http2 on a server that doesn't speak
+ http2 at all. The error message is passed on as a verbose message to
+ libcurl.
+
+ Discussed in #722
- Reported-by: Fabian Keil
+ The error callback was added in nghttp2 1.9.0
-- [Jakub Zakrzewski brought this change]
+Steve Holme (2 Apr 2016)
+- spnego: Renamed the context's SPN variable
+
+ To be consistent with the Kerberos 5 context and other authentication
+ code.
+
+- krb5_gssapi: Renamed the status variables
+
+ For consistency with the spnego code.
- Cmake: Build with GSSAPI (MIT or Heimdal)
+- krb5: Moved host from Curl_auth_create_gssapi_user_message() to be argument
- It tries hard to recognise SDK's on different platforms. On windows MIT
- Kerberos installs SDK with other things and puts path into registry.
- Heimdal have separate zip archive. On linux pkg-config is tried, then
- krb5-config script and finally old-style libs and headers detection.
+ For consistency with the spnego and oauth2 code moved the setting of
+ the host name outside of the Curl_auth_create_gssapi_user_messag()
+ function.
- Command line args:
- * CMAKE_USE_GSSAPI - enables GSSAPI detection
- * GSS_ROOT_DIR - if set, should point to the root of GSSAPI installation
- (the one with include and lib directories)
+ This will allow us to more easily override it in the future.
-- [Jakub Zakrzewski brought this change]
+- test1119: Fixed missing CURL_DID_MEMORY_FUNC_TYPEDEFS symbol
- Cmake: Got rid of setup_curl_dependencies
+- RELEASE-NOTES: Removed "http_negotiate: Corrected host and proxy host name"
- There is no need for such function. Include_directories propagate by
- themselves and having a function with one simple link statement makes
- little sense.
+ As this was introduced in the recent vauth changes and not a prior
+ release.
-- [Jakub Zakrzewski brought this change]
+Daniel Stenberg (1 Apr 2016)
+- RELEASE-NOTES: synced with 0aa8da10bbdafa
- Cmake: Avoid cycle directory dependencies.
+Steve Holme (1 Apr 2016)
+- http_negotiate: Corrected host and proxy host name being wrong way round
- Because we prepended libraries to list, CMake had troubles resolving
- link directory order as it detected some cycles. Appending to list ensures
- that dependencies will preceed dependees.
-
-- [Jakub Zakrzewski brought this change]
+ I had accidentally used the proxy server name for the host and the host
+ server name for the proxy in commit ad5e9bfd5d and 6d6f9ca1d9. Whilst
+ Windows SSPI was quite happy with this, GSS-API wasn't.
+
+ Thanks-to: Michael Osipov
- Cmake: Fix library list provided to cURL tests.
+- build: Changed the Visual Studio projects warning level from 3 to 4
- The list must be set after those nice CMake tests as we mess with
- CMAKE_REQUIRED_LIBRARIES there.
+ After squashing most of our compiler warnings, up'ed the default
+ warning level from 3 to 4 in order to increase the likelyhood of
+ catching future warnings.
-- [Jakub Zakrzewski brought this change]
+Daniel Stenberg (1 Apr 2016)
+- [ehlertjd@gmail.com brought this change]
- Cmake: Check for OpenSSL before OpenLDAP.
+ IMAP: check pointer before dereferencing it
- OpenLDAP might have been build with OpenSSL. Checking for OpenLDAP first
- may result in undefined symbols. Of course, the found OpenSSL libraries
- must also be linked whenever OpenLDAP is.
-
-- curl_multi_fdset.3: improved the formatting slightly
+ may be null in the CURLOPT_CONNECT_ONLY case
+
+ Fixes #747
-- curl_multi_fdset: explain the fd_set arguments
+Steve Holme (1 Apr 2016)
+- .gitignore: Added new VC14 SQLite based program database files
-Kamil Dudka (8 Oct 2014)
-- nss: do not fail if a CRL is already cached
+- curl_memory.h: Fixed typo in comment
- This fixes a copy-paste mistake from commit 2968f957.
+ From commit 7218b52c49.
-Patrick Monnerat (8 Oct 2014)
-- OS400: upgrade interface for pinned public key (no implementation yet)
+- spnego: Corrected some typos in comments
+
+ Corrected typos from commit ad5e9bfd5d and 6d6f9ca1d9.
-Daniel Stenberg (8 Oct 2014)
-- FormAdd: precaution against memdup() of NULL pointer
+- memdebug: Ensure curl/curl.h is included before curl_memory.h
- Coverity CID 252518. This function is in general far too complicated for
- its own good and really should be broken down into several smaller
- funcitons instead - but I'm adding this protection here now since it
- seems there's a risk the code flow can end up here and dereference a
- NULL pointer.
+ Follow up to commit 7db9782dd6.
-- operate: avoid NULL dereference
+Daniel Stenberg (1 Apr 2016)
+- upload: missing rewind call could make libcurl hang
+
+ When an upload is done, there are two places where that can be detected
+ and only one of them would rewind the input stream - which sometimes is
+ necessary for example when doing NTLM HTTP POSTs and more.
+
+ This could then end up libcurl hanging.
- Coverity CID 1241948. dumpeasysrc() would get called with
- config->current set to NULL which could be dereferenced by a warnf()
- call.
+ Figured-out-by: Isaac Boukris
+ Reported-by: Anatol Belski
+
+ Fixes #741
-- do_sec_send: remove dead code
+- curl.h: define CURL_DID_MEMORY_FUNC_TYPEDEFS
+
+ So that we only do the extra typedefs in curl_memory.h when we really
+ need to and avoid double typedefs.
- Coverity CID 1241951. The condition 'len >= 0' would always be true at
- that point and thus not necessary to check for.
+ follow-up commit to 7218b52c49aeb1
+
+ Thanks-to: Steve Holme
-- krb5_encode: remove unused argument
+- curl/mprintf.h: remove support for _MPRINTF_REPLACE
+
+ The define is not in our name space and is therefore not protected by
+ our API promises.
- Coverity CID 1241957. Removed the unused argument. As this struct and
- pointer now are used only for krb5, there's no need to keep unused
- function arguments around.
+ It was only really used by libcurl internals but was mostly erased from
+ there already in 8aabbf5 (March 2015). This is supposedly the final
+ death blow to that define from everywhere.
+
+ As a side-effect, making sure _MPRINTF_REPLACE is gone and not used, I
+ made the lib tests in tests/libtest/ use curl_printf.h for its redefine
+ magic and then subsequently the use of sprintf() got banned in the tests
+ as well (as it is in libcurl internals) and I then replaced them all
+ with snprintf().
+
+ In the unlikely event that any users is actually using this define and
+ gets sad by this change, it is very easily copied to the user's own
+ code.
-- operate_do: skip superfluous check for NULL pointer
+- curl_memory.h: avoid the curl/curl.h include
- Coverity CID 1243583. get_url_file_name() cannot fail and return a NULL
- file name pointer so skip the check for that - it tricks coverity into
- believing it can happen and it then warns later on when we use 'outfile'
- without checking for NULL.
+ Discussed in #743
-- curl_easy_getinfo.3: spell-fix
+Steve Holme (1 Apr 2016)
+- url: Corrected get protocol family for FTP and LDAP
- Reported-By: Luan Cestari
+ Fixed copy/paste error from commit a5aec58726.
-- [moparisthebest brought this change]
+Jay Satiro (31 Mar 2016)
+- strerror: don't bit shift a signed integer
+
+ Bug: https://github.com/curl/curl/issues/744
+ Reported-by: Alexis La Goutte
- GnuTLS: Implement public key pinning
+Daniel Stenberg (31 Mar 2016)
+- http2: more documentation for prior knowledge
-- [moparisthebest brought this change]
+- [Diego Bes brought this change]
- SSL: implement public key pinning
+ http2: support "prior knowledge", no upgrade from HTTP/1.1
- Option --pinnedpubkey takes a path to a public key in DER format and
- only connect if it matches (currently only implemented with OpenSSL).
+ Supports HTTP/2 over clear TCP
- Provides CURLOPT_PINNEDPUBLICKEY for curl_easy_setopt().
+ - Optimize switching to HTTP/2 by removing calls to init and setup
+ before switching. Switching will eventually call setup and setup calls
+ init.
- Extract a public RSA key from a website like so:
- openssl s_client -connect google.com:443 2>&1 < /dev/null | \
- sed -n '/-----BEGIN/,/-----END/p' | openssl x509 -noout -pubkey \
- | openssl rsa -pubin -outform DER > google.com.der
-
-- multi_runsingle: fix possible memory leak
+ - Supports new version to “force” the use of HTTP/2 over clean TCP
- Coverity CID 1202837. 'newurl' can in fact be allocated even when
- Curl_retry_request() returns failure so free it if need be.
+ - Add common line parameter “--http2-prior-knowledge” to the Curl
+ command line tool.
-- ares::Curl_resolver_cancel: skip checking for NULL conn
+- imap: remove duplicated function
- Coverity CID 1243581. 'conn' will never be NULL here, and if it would be
- the subsequent statement would dereference it!
+ The list and search response functions were identical! Merged into one
+ now. Detected by PVS Studio.
+
+ Reported-by: Alexis La Goutte
-- parseconfig: skip a NULL check
+- SOCKS5_gssapi_negotiate: don't assume little-endian ints
+
+ The code copied one byte from a 32bit integer, which works fine as long
+ as the byte order is the same. Not a fine assumption. Reported by PVS
+ Studio.
- Coverity CID 1154198. This NULL check implies that the pointer _can_ be
- NULL at this point, which it can't. Thus it is dead code. It tricks
- static analyzers to warn about dereferencing the pointer since the code
- seems to imply it can be NULL.
+ Reported-by: Alexis La Goutte
-- [Waldek Kozba brought this change]
+- http: remove ((expression)) double parentheses
- multi-uv.c: call curl_multi_info_read() better
+- Curl_add_buffer_send: avoid possible NULL dereference
- Improves it for low-latency cases (like the communication with
- localhost)
-
-- tool_go_sleep: use (void) to spell out we ignore the return value
+ ... as we check for a NULL pointer below, we move the derefence to after
+ the check. Detected by PVS Studio.
- Coverity CID 1222080.
+ Reported-by: Alexis La Goutte
-- ssh_statemach_act: split out assignment from check
+- file: remove duplicate checks of the same variable
- just a minor code style thing to make the code clearer
-
-Marc Hoersken (4 Oct 2014)
-- curl_schannel.c: Fixed possible memory or handle leak
+ ... as it doesn't change in between. Deteced by PVS Studio.
- First try to fix possible memory leaks, in this case:
- Only connssl->ctxt xor onnssl->cred being initialized.
+ Reported-by: Alexis La Goutte
-Daniel Stenberg (4 Oct 2014)
-- getparameter: remove dead code
-
- Coverity CID 1061126. 'parse' will always be non-NULL here.
+Steve Holme (30 Mar 2016)
+- [Marcel Raad brought this change]
-- getparameter: comment a switch FALLTHROUGH
+ openssl: Fix compilation warnings
- Coverity CID 1061118. Point out that it is on purpose.
-
-- choose_mech: fix return code
+ When compiling with OpenSSL 1.1.0 (so that the HAVE_X509_GET0_SIGNATURE
+ && HAVE_X509_GET0_EXTENSIONS pre-processor block is active), Visual C++
+ 14 complains:
- Coverity CID 1241950. The pointer is never NULL but it might point to
- NULL.
+ warning C4701: potentially uninitialized local variable 'palg' used
+ warning C4701: potentially uninitialized local variable 'psig' used
-- Curl_sec_read_msg: spell out that we ignore return code
+Daniel Stenberg (30 Mar 2016)
+- multi: turn Curl_done into file local multi_done
- Coverity CID 1241947. Since if sscanf() fails, the previously set value
- remains set.
+ ... as it now is used by multi.c only.
-- nonblock: call with (void) to show we ignore the return code
+- multi: multi_reconnect_request is the former Curl_reconnect_request
- Coverity pointed out several of these.
+ now a file local function in multi.c
-- parse_proxy: remove dead code.
+- multi: move Curl_do and Curl_do_done to multi.c and make static
- Coverity CID 982331.
-
-- Curl_debug: document switch fallthroughs
+ ... called multi_do and multi_do_done as they're file local now.
-- curl_multi_remove_handle: remove dead code
+Jay Satiro (29 Mar 2016)
+- wolfssl: Use ECC supported curves extension
- Coverify CID 1157776. Removed a superfluous if() that always evaluated
- true (and an else clause that never ran), and then re-indented the
- function accordingly.
+ https://github.com/wolfSSL/wolfssl/issues/366
-- Curl_pipeline_server_blacklisted: handle a NULL server name
+- build-wolfssl: Allow a broader range of ciphers (Visual Studio)
- Coverity CID 1215284. The server name is extracted with
- Curl_copy_header_value() and passed in to this function, and
- copy_header_value can actually can fail and return NULL.
-
-- ssh: comment "fallthrough" in switch statement
+ This is an update to the build-time options used to build wolfSSL in
+ Visual Studio for greater compatibility, and make it behave similar to
+ the way OpenSSL 1.0.2 behaves. Starting in wolfSSL v3.6.6 static ciphers
+ and SSLv3 are disabled by default at build time, but we can use both.
+
+ - Enable static cipher suites TLS_ECDH_ and TLS_RSA_.
+
+ - Enable SSLv3 hello. Though in libcurl we disable it by default at
+ runtime, we make it available so the user can manually select it if
+ necessary.
-- [Jeremy Lin brought this change]
+Daniel Stenberg (29 Mar 2016)
+- [Isaac Boukris brought this change]
- ssh: improve key file search
+ GSS: make Curl_gss_log_error more verbose
+
+ Also display the GSS_C_GSS_CODE (major code) when specified instead of
+ only GSS_C_MECH_CODE (minor code).
- For private keys, use the first match from: user-specified key file
- (if provided), ~/.ssh/id_rsa, ~/.ssh/id_dsa, ./id_rsa, ./id_dsa
+ In addition, the old code was printing a colon twice after the prefix
+ and also miscalculated the length of the buffer in between calls to
+ gss_display_status (the length of ": " was missing).
- Note that the previous code only looked for id_dsa files. id_rsa is
- now generally preferred, as it supports larger key sizes.
+ Also, gss_buffer is not guaranteed to be NULL terminated and thus need
+ to restrict reading by its length.
- For public keys, use the user-specified key file, if provided.
- Otherwise, try to extract the public key from the private key file.
- This means that passing --pubkey is typically no longer required,
- and makes the key-handling behavior more like OpenSSH.
+ Closes #738
-- CURLOPT_HTTPHEADER.3: libcurl doesn't copy the whole list
+- build: use roffit 0.11 feature
+
+ ... load file specified as argument.
-- detect_proxy: fix possible single-byte memory leak
+- http2: set correct scheme in handler structs [regression]
+
+ Since commit a5aec58 the handler schemes need to match for the
+ connections to be reused and for HTTP/2 multiplexing to work, reusing
+ connections is very important!
- Coverity CID 1202836. If the proxy environment variable returned an empty
- string, it would be leaked. While an empty string is not really a proxy, other
- logic in this function already allows a blank string to be returned so allow
- that here to avoid the leak.
+ Closes #736
+
+- hostip.c: minor white space edit for style
-- multi_runsingle: fix memory leak
+- [Viktor Szakats brought this change]
+
+ TODO: use secure protocol in recently added URL
- Coverity CID 1202837. There's a potential risk that 'newurl' gets
- overwritten when it was already pointing to allocated memory.
+ Closes #733
+
+- HTTP2.md: mention libressl and boringssl too
+
+- docs/HTTP-COOKIES: converted to markdown
+
+- HTTP2: s/polarssl/mbedtls
-- pop3_perform_authentication: fix memory leak
+Jay Satiro (28 Mar 2016)
+- wolfssl: Add ALPN support
+
+- tool_operate: remove mixed declaration
- Coverity CID 1215287. There's a potential risk for a memory leak in
- here, and moving the free call to be unconditional seems like a cheap
- price to remove the risk.
+ This is a follow up to the previous commit.
-- imap_perform_authentication: fix memory leak
+Daniel Stenberg (28 Mar 2016)
+- curl: warn for --capath use if not supported by libcurl
- Coverity CID 1215296. There's a potential risk for a memory leak in
- here, and moving the free call to be unconditional seems like a cheap
- price to remove the risk.
+ Closes #492
+
+- TODO: 2.5 Edge-triggered sockets should work
-- wait_or_timeout: return failure when Curl_poll() fails
+- Makefile.am: skip the scripts dir
+
+ Skipping the scripts dir is primarily done for 'make install' so that it
+ does not attempt to install the zsh completion script as we've not yet
+ found a proper way to do/run that at install time.
+
+ By leaving the script dir's Makefile in place, a user can still opt to
+ run make install manually in there.
- Coverity detected this. CID 1241954. When Curl_poll() returns a negative value
- 'mcode' was uninitialized. Pretty harmless since this is debug code only and
- would at worst cause an error to _not_ be returned...
+ Closes #620
-- curl.1: mention quoting in the URL section
+- CURLMOPT_SOCKETFUNCTION.3: describe the 'what' argument
+
+- curl_multi_socket_action.3: mark the options properly
- and separate the example URLs with newlines
+ ... to make them appear as links on the html version.
-Steve Holme (30 Sep 2014)
-- [Bill Nagel brought this change]
+Steve Holme (27 Mar 2016)
+- RELEASE-NOTES: Synced with f0bdd72c10
- smtp: Fixed intermittent "SSL3_WRITE_PENDING: bad write retry" error
+- http_ntlm: Renamed from curl_ntlm.[c|h]
- This patch fixes the "SSL3_WRITE_PENDING: bad write retry" error that
- sometimes occurs when sending an email over SMTPS with OpenSSL. OpenSSL
- appears to require the same pointer on a write that follows a retry
- (CURLE_AGAIN) as discussed here:
+ Renamed the header and source files for this module as they are HTTP
+ specific and as such, they should use the naming convention as other
+ HTTP authentication source files do - this revert commit 260ee6b7bf.
- http://stackoverflow.com/questions/2997218/why-am-i-getting-error1409f07fssl-routinesssl3-write-pending-bad-write-retr
+ Note: We could also rename curl_ntlm_wb.[c|h], however, the Winbind
+ code needs separating from the HTTP protocol and migrating into the
+ vauth directory, thus adding support for Winbind to the SASL based
+ protocols such as IMAP, POP3 and SMTP.
-Daniel Stenberg (30 Sep 2014)
-- RELEASE-NOTES: synced with 53cbea22310f15
+Daniel Stenberg (27 Mar 2016)
+- [marquis-de-muesli brought this change]
-- file: reject paths using embedded %00
+ docs: curlinfo_filetime sftp support, new curlopt_quote "statvfs"
- Mostly because we use C strings and they end at a binary zero so we know
- we can't open a file name using an embedded binary zero.
-
- Reported-by: research@g0blin.co.uk
+ Closes #677
-Dan Fandrich (26 Sep 2014)
-- test506: Fixed a couple of memory leaks in test
+- [marquis-de-muesli brought this change]
-Daniel Stenberg (25 Sep 2014)
-- [Yousuke Kimoto brought this change]
+ SSH: new CURLOPT_QUOTE command "statvfs"
+
+ usage: "statvfs path"
+ returns remote file system statistics
- CURLOPT_COOKIELIST: Added "RELOAD" command
+- [marquis-de-muesli brought this change]
-- [Michael Wallner brought this change]
+ SSH: support CURLINFO_FILETIME
+
+- [Karlson2k brought this change]
- CURLOPT_POSTREDIR.3: Added availability for CURL_REDIR_POST_303
+ sshserver.pl: use quotes for given options
+
+ Fixed failed redirection of stderr with some options. At least on Msys2,
+ perl fails to redirect stderr if $value contains newline or other weird
+ characters.
-- threaded-resolver: revert Curl_expire_latest() switch
+Jay Satiro (26 Mar 2016)
+- url: don't use bad offset in tld_check_name to show error
- The switch to using Curl_expire_latest() in commit cacdc27f52b was a
- mistake and was against the advice even mentioned in that commit. The
- comparison in asyn-thread.c:Curl_resolver_is_resolved() makes
- Curl_expire() the suitable function to use.
+ libidn's tld_check_lz returns an error offset of the first character
+ that it failed to process, however that offset is not a byte offset and
+ may not even be in the locale encoding therefore we can't use it to show
+ the user the character that failed to process.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1426
- Reported-By: graysky
+ Bug: https://github.com/curl/curl/issues/731
+ Reported-by: Karlson2k
-- libcurl docs: improvements all over
+Steve Holme (26 Mar 2016)
+- http_negotiate: Combine GSS-API and SSPI source files
+
+ As the GSS-API and SSPI based source files are no longer library/API
+ specific, following the extraction of that authentication code to the
+ vauth directory, combine these files rather than maintain two separate
+ versions.
-Steve Holme (19 Sep 2014)
-- build: Added WinIDN build configuration options
+- vauth: Moved the Negotiate authentication code to the new vauth directory
- Added initial support for WinIDN build configurations to the VC10+
- project files.
+ Part 2 of 2 - Moved the GSS-API based Negotiate authentication code.
-Daniel Stenberg (19 Sep 2014)
-- tutorial: signals aren't used for the threaded resolver
+- vauth: Moved the Negotiate authentication code to the new vauth directory
+
+ Part 1 of 2 - Moved the SSPI based Negotiate authentication code.
-- FAQ: update the pronunciation section
+- warnless.h: Removed spurious character from commit 696bc6b9c9
- As we weren't using the correct phonetic description and doing it correctly
- involves funny letters that I'm sure will cause problems for people in a text
- document so I instead rephrased it and link to a WAV file with a person
- actually saying 'curl'.
+ Not picked up by checksrc or Visual Studio but my own code review, this
+ would haven broken Intel based Unix builds - Perhaps I should learn to
+ type on my laptop's keyboard before committing!
+
+- schannel: Fixed compilation warning from commit f8d88a4913
- Reported-By: Dimitar Boevski
+ warning C4244: '=': conversion from 'int' to 'unsigned short', possible
+ loss of data
-- CURLOPT_COOKIE*: added more cross-references
+- warnless?: Added some integer based conversion functions
-- BINDINGS: add node-libcurl
-
- Reported-By: Jonathan Cardoso Machado
- URL: http://curl.haxx.se/mail/lib-2014-09/0102.html
+Daniel Stenberg (25 Mar 2016)
+- [Dusty Mabe brought this change]
-- README.http2: updated to reflect current status
+ docs/TODO: Add feature request for metalink in HTTP headers
+
+ Closes #729
+ Closes #728
-- formdata: removed unnecessary USE_SSLEAY use
+Steve Holme (25 Mar 2016)
+- build: Corrected typos from commit 70e56939aa
-- curlssl: make tls backend symbols use curlssl in the name
+- vauth: Refactored function names after move to new vauth directory
+
+ Renamed all the SASL functions that moved to the new vauth directory to
+ include the correct module name.
-- url: let the backend decide CURLOPT_SSL_CTX_ support
+- vauth: Updated the copyright year after recent changes
- ... to further remove specific TLS backend knowledge from url.c
+ As most of this work was performed in 2015 but not pushed until 2016
+ updated the copyright year to reflect the public facing changes.
-- vtls: have the backend tell if it supports CERTINFO
+- vauth: Moved the OAuth 2.0 authentication code to the new vauth directory
-- [Catalin Patulea brought this change]
+- vauth: Moved the NTLM authentication code to the new vauth directory
- configure: allow --with-ca-path with PolarSSL too
-
- Missed this in af45542c.
-
- Signed-off-by: Catalin Patulea <cat@vv.carleton.ca>
+- vauth: Moved the Kerberos V5 authentication code to the new vauth directory
-- CURLOPT_CAPATH: return failure if set without backend support
+- digest.c: Fixed checksrc warnings
-- [Tatsuhiro Tsujikawa brought this change]
+- vauth: Moved the DIGEST authentication code to the new vauth directory
- http2: Fix busy loop when EOF is encountered
-
- Previously we did not handle EOF from underlying transport socket and
- wrongly just returned error code CURL_AGAIN from http2_recv, which
- caused busy loop since socket has been closed. This patch adds the
- code to handle EOF situation and tells the upper layer that we got
- EOF.
+- vauth: Moved the CRAM-MD5 authentication code to the new vauth directory
-Steve Holme (13 Sep 2014)
-- build: Added batch wrapper to checksrc.pl
+- vauth: Moved the ClearText authentication code to the new vauth directory
-- RELEASE-NOTES: Synced with bd3df5ec6d
+- vauth: Moved Curl_sasl_build_spn() to create the initial vauth source files
-- [Marcel Raad brought this change]
+- checksrc.bat: Added support for checking the new vauth directory
- sasl_sspi: Fixed Unicode build
+- build: Updated all makefiles and project files for the new vauth directory
- Bug: http://curl.haxx.se/bug/view.cgi?id=1422
- Verified-by: Steve Holme
+ Updated the makefiles and Visual Studio project files to support moving
+ the authentication code to the new lib/vauth directory that was started
+ in commit 0d04e859e1.
+
+Daniel Stenberg (24 Mar 2016)
+- [JDepooter brought this change]
-Daniel Stenberg (12 Sep 2014)
-- libcurl-tutorial.3: fix GnuTLS link to thread-safety guidelines
+ schannel: Add ALPN support
- The former link was turned into a 404 at some point.
+ Add ALPN support for schannel. This allows cURL to negotiate
+ HTTP/2.0 connections when built with schannel.
- Reported-By: Askar Safin
+ Closes #724
-- contributors.sh: split list of names at comma
-
- ... to support a list of names provided in a commit message.
+Steve Holme (24 Mar 2016)
+- http: Minor update based on CODE_STYLE guidelines
-Steve Holme (12 Sep 2014)
-- [Ulrich Telle brought this change]
+Daniel Stenberg (23 Mar 2016)
+- multi: fix "Operation timed out after" timer
+
+ Use the local, reasonably updated, 'now' value when creating the message
+ string to output for the timeout condition.
+
+ Fixes #619
- ntlm: Fixed HTTP proxy authentication when using Windows SSPI
+- openssl: boringssl provides the same numbering as openssl
- Removed ISC_REQ_* flags from calls to InitializeSecurityContext to fix
- bug in NTLM handshake for HTTP proxy authentication.
+ ... so we don't need extra boringssl precautions for for
+ HAVE_ERR_REMOVE_THREAD_STATE_NOARG.
- NTLM handshake for HTTP proxy authentication failed with error
- SEC_E_INVALID_TOKEN from InitializeSecurityContext for certain proxy
- servers on generating the NTLM Type-3 message.
+ Pointed-out-by: David Benjamin
+
+- openssl: fix ERR_remove_thread_state() for boringssl/libressl
- The flag ISC_REQ_CONFIDENTIALITY seems to cause the problem according
- to the observations and suggestions made in a bug report for the
- QT project (https://bugreports.qt-project.org/browse/QTBUG-17322).
+ The removed arg is only done in OpenSSL
- Removing all the flags solved the problem.
+ Bug: https://twitter.com/xtraemeat/status/712564874098917376
+
+- bump: work on 7.48.1
+
+- RELEASE-PROCEDURE: mention the github release tag edit
- Bug: http://curl.haxx.se/mail/lib-2014-08/0273.html
- Reported-by: Ulrich Telle
- Assisted-by: Steve Holme, Daniel Stenberg
+ ... and update the coming release dates a bit
-Daniel Stenberg (12 Sep 2014)
-- [Ray Satiro brought this change]
+Steve Holme (23 Mar 2016)
+- checksrc.bat: Updated the help to be consistent with generate.bat
+
+ Follow up to commit a8c7f0fcbf prior to release.
+
+Version 7.48.0 (23 Mar 2016)
+
+Daniel Stenberg (23 Mar 2016)
+- RELEASE-NOTES: curl 7.48.0
+
+- THANKS: 15 new contributors from 7.48.0 release
- newlines: fix mixed newlines to LF-only
+Jay Satiro (23 Mar 2016)
+- CURLINFO_TLS_SSL_PTR.3: Warn about limitations
- I use the curl repo mainly on Windows with the typical Windows git
- checkout which converts the LF line endings in the curl repo to CRLF
- automatically on checkout. The automatic conversion is not done on files
- in the repo with mixed line endings. I recently noticed some weird
- output with projects/build-openssl.bat that I traced back to mixed line
- endings, so I scanned the repo and there are files (excluding the
- test data) that have mixed line endings.
+ Bug: https://github.com/curl/curl/issues/685
+
+Daniel Stenberg (22 Mar 2016)
+- Revert "sshserver: remove use of AuthorizedKeysFile2"
+
+ It seems we may have some autobuild problems after this commit went
+ in. Trying to see if a revert helps to get them back.
- I used this command below to do the scan. Unfortunately it's not as easy
- as git grep, at least not on Windows. This gets the names of all the
- files in the repo's HEAD, gets each of those files raw from HEAD, checks
- for mixed line endings of both LF and CRLF, and prints the name if
- mixed. I excluded path tests/data/test* because those can have mixed
- line endings if I understand correctly.
+ This reverts commit 2716350d1f3edc8e929f6ceeee05051090f6d642.
+
+- maketgz: add -j to make dist
- for f in `git ls-tree --name-only --full-tree -r HEAD`;
- do if [ -n "${f##tests/data/test*}" ];
- then git show "HEAD:$f" | \
- perl -0777 -ne 'exit 1 if /([^\r]\n.*\r\n)|(\r\n.*[^\r]\n)/';
- if [ $? -ne 0 ];
- then echo "$f";
- fi;
- fi;
- done
+ ... makes it a lot faster
-- [Viktor Szakáts brought this change]
+- libcurl-thread.3: minor nroff format fix
- mk-ca-bundle.pl: converted tabs to spaces, deleted trailing spaces
+- CURLINFO_TLS_SSL_PTR.3: minor nroff format fix
-- ROADMAP: markdown eats underscores
+- CODE_STYLE: indend example code
- It interprets them as italic indictors unless we backtick the word.
-
-- ROADMAP: tiny formatting edit for nicer web output
+ ... to make it look nicer in markdown outputa
-Steve Holme (10 Sep 2014)
-- ROADMAP.md: Updated GSSAPI authentication following 7.38.0 additions
+Jay Satiro (22 Mar 2016)
+- build-wolfssl: Update VS properties for wolfSSL v3.9.0
+
+ - Do not use wolfSSL's sample user-setting files.
+
+ wolfSSL starting in v3.9.0 has added their own sample user settings that
+ are applied by default, but we don't use them because we have our own
+ settings.
+
+ - Do not use wolfSSL's Visual Studio Unicode character setting.
+
+ wolfSSL Visual Studio projects use the Unicode character set however our
+ settings and options imitate mingw build which does not use the Unicode
+ character set. This does not appear to have any effect at the moment but
+ better safe than sorry.
+
+
+ These changes are backwards compatible with earlier versions.
-- INTERNALS: Added email and updated Kerberos details
+Steve Holme (22 Mar 2016)
+- hostip6: Fixed compilation warnings when verbose strings disabled
+
+ warning C4189: 'data': local variable is initialized but not referenced
+
+ ...and some minor formatting/spacing changes.
-- FEATURES: Updated Kerberos details
+Daniel Stenberg (21 Mar 2016)
+- sshserver: remove use of AuthorizedKeysFile2
- Added support for Kerberos 5 to the email protocols following the recent
- additions in 7.38.0.
+ Support for the (undocumented) AuthorizedKeysFile2 was removed in
+ OpenSSH 5.9, released in September 2011
- Removed Kerberos 4 as this has been gone for a while now.
+ Closes #715
-Daniel Stenberg (10 Sep 2014)
-- [Paul Howarth brought this change]
+Steve Holme (20 Mar 2016)
+- connect/ntlm/http: Fixed compilation warnings when verbose strings disabled
+
+ warning C4189: 'data': local variable is initialized but not referenced
- openssl: build fix for versions < 0.9.8e
+- openssl: Fixed compilation warning when /Wall enabled
- Bug: http://curl.haxx.se/mail/lib-2014-09/0064.html
+ warning C4706: assignment within conditional expression
-- mk-ca-bundle.pl: first, try downloading HTTPS with curl
+- CODE_STYLE: Use boolean conditions
- As a sort of step forward, this script will now first try to get the
- data from the HTTPS URL using curl, and only if that fails it will
- switch back to the HTTP transfer using perl's native LWP functionality.
- To reduce the risk of this script being tricked.
+ Rather than use TRUE, FALSE, NULL, 0 or != 0 in if/while conditions.
- Using HTTPS to get a cert bundle introduces a chicken-and-egg problem so
- we can't really ever completely disable HTTP, but chances are that most
- users already have a ca cert bundle that trusts the mozilla.org site
- that this script downloads from.
+ Additionally, corrected some example code to adhere to the recommended
+ coding style.
+
+- inet_pton.c: Fixed compilation warnings
- A future version of this script will probably switch to require a
- dedicated "insecure" command line option to allow downloading over HTTP
- (or unverified HTTPS).
+ warning: conversion to 'unsigned char' from 'int' may alter its value
+
+Daniel Stenberg (19 Mar 2016)
+- RELEASE-NOTES: synced with 80851028efc2fa9
-- LICENSE-MIXING: removed krb4 info
+- mbedtls: fix compiler warning
- krb4 has been dropped since a while now
+ vtls/mbedtls.h:67:36: warning: implicit declaration of function
+ ‘mbedtls_sha256’ [-Wimplicit-function-declaration]
-- bump: on the 7.38.1-DEV train now!
+Steve Holme (19 Mar 2016)
+- easy: Minor coding standard and style updates
+
+ Following commit c5744340db. Additionally removes the need for a second
+ 'result code' variable as well.
-- SSLCERTS: minor updates
+Jay Satiro (19 Mar 2016)
+- easy: Remove poll failure check in easy_transfer
+
+ .. because curl_multi_wait can no longer signal poll failure.
- Edited format to look better on the web, added a "it is about trust"
- section.
+ follow-up to 77e1726
+
+ Bug: https://github.com/curl/curl/issues/707
-Version 7.38.0 (10 Sep 2014)
+Steve Holme (19 Mar 2016)
+- build: Added missing Visual Studio filter files for VC10 onwards
+
+ As these files don't need to contain references to the source files,
+ although typically do, added basic files which only include three
+ filters and don't require the project file generator to be modified.
+
+ These files allow the source code to be viewed in the Solution Explorer
+ in versions of Visual Studio from 2010 onwards in the same manner as
+ previous versions did rather than one large view of files.
-Daniel Stenberg (10 Sep 2014)
-- dist: two cmake files are no more
+- ftp/imap/pop3/smtp: Fixed compilation warning when /Wall enabled
- CMake/FindOpenSSL.cmake and FindZLIB.cmake are gone since 14aa8f0c117b
+ warning C4706: assignment within conditional expression
-- RELEASE-NOTES: final update for 7.38.0
+- config-w32.h: Fixed compilation warning when /Wall enabled
+
+ warning C4668: 'USE_IPV6' is not defined as a preprocessor macro,
+ replacing with '0' for '#if/#elif'
-- cookies: reject incoming cookies set for TLDs
+- imap.c: Fixed compilation warning with /Wall enabled
- Test 61 was modified to verify this.
+ warning C4701: potentially uninitialized local variable 'size' used
- CVE-2014-3620
+ Technically this can't happen, as the usage of 'size' is protected by
+ 'if(parsed)' and 'parsed' is only set after 'size' has been parsed.
- Reported-by: Tim Ruehsen
- URL: http://curl.haxx.se/docs/adv_20140910B.html
+ Anyway, lets keep the compiler happy.
+
+- KNOWN_BUGS: #93 Issue with CURLFORM_CONTENTLEN in arrays on 32-bit platforms
-- [Tim Ruehsen brought this change]
+Daniel Stenberg (18 Mar 2016)
+- bump: the coming release is 7.48.0
- cookies: only use full host matches for hosts used as IP address
+- configure: use cpp -P when needed
- By not detecting and rejecting domain names for partial literal IP
- addresses properly when parsing received HTTP cookies, libcurl can be
- fooled to both send cookies to wrong sites and to allow arbitrary sites
- to set cookies for others.
+ Since gcc 5, the processor output can get split up on multiple lines
+ that made the configure script fail to figure out values from
+ definitions. The fix is to use cpp -P, and this fix now first checks if
+ cpp -P is necessary and then if cpp -P works before it uses that to
+ extract defined values.
- CVE-2014-3613
+ Fixes #719
+
+Steve Holme (18 Mar 2016)
+- formdata.c: Fixed compilation warning
+
+ formdata.c:390: warning: cast from pointer to integer of different size
+
+ Introduced in commit ca5f9341ef this happens because a char*, which is
+ 32-bits wide in 32-bit land, is being cast to a curl_off_t which is
+ 64-bits wide where 64-bit integers are supported by the compiler.
+
+ This doesn't happen in 64-bit land as a pointer is the same size as a
+ curl_off_t.
- Bug: http://curl.haxx.se/docs/adv_20140910A.html
+ This fix doesn't address the fact that a 64-bit value cannot be used
+ for CURLFORM_CONTENTLEN when set in a form array and compiled on a
+ 32-bit platforms, it does at least suppress the compilation warning.
-- HISTORY: fix the 1998 title position
+Daniel Stenberg (18 Mar 2016)
+- FAQ: 2.5 Install libcurl for both 32bit and 64bit?
-- HISTORY: extended and now markdown
+- [Gisle Vanem brought this change]
-- SSLCERTS: converted to markdown
+ openssl: adapt to API breakage in ERR_remove_thread_state()
- Only minor edits to make it generate nice HTML output using markdown, as
- this document serves both in source release tarballs as on the web site.
+ The OpenSSL API change that broke this is "Convert ERR_STATE to new
+ multi-threading API": openssl commit 8509dcc.
- URL: http://curl.haxx.se/docs/sslcerts.html
+ Closes #713
-- ftp-wildcard.c: spell fix
+- version: init moved to private name space, added protos
- Reported-By: Frank Gevaerts
+ follow-up to 80015cdd52145
-- RELEASE-NOTES: synced with 921a0c22a6f
+- openssl: verbose: show matching SAN pattern
+
+ ... to allow users to see which specfic wildcard that matched when such
+ is used.
+
+ Also minor logic cleanup to simplify the code, and I removed all tabs
+ from verbose strings.
-- THANKS: synced with RELEASE-NOTES for 921a0c22a6f
+Jay Satiro (16 Mar 2016)
+- version: thread safety
-- polarassl: avoid memset() when clearing the first byte is enough
+Steve Holme (16 Mar 2016)
+- transfer: Removed redundant HTTP authentication include files
+
+ It would also seem that share.h is not required here either as there
+ are no references to the Curl_share structure or functions.
-- [Catalin Patulea brought this change]
+- easy: Removed redundant HTTP authentication include files
- polarssl: support CURLOPT_CAPATH / --capath
+Jay Satiro (15 Mar 2016)
+- CURLOPT_SSLENGINE.3: Only for OpenSSL built with engine support
- Signed-off-by: Catalin Patulea <cat@vv.carleton.ca>
+ Bug: https://curl.haxx.se/mail/lib-2016-03/0150.html
+ Reported-by: Oliver Graute
-- SECURITY: eh, make more sense!
+Steve Holme (15 Mar 2016)
+- curl_sasl: Minor code indent fixes
-- SECURITY: how to join the curl-security list
+Daniel Stenberg (14 Mar 2016)
+- runtests: mention when run event-based
-- RELEASE-NOTES: fix the required nghttp2 version typo
+- easy: add check to malloc() when running event-based
+
+ ... to allow torture tests then too.
-- [Brandon Casey brought this change]
+- memdebug: skip logging the limit countdown, fflush when reached
- Ensure progress.size_dl/progress.size_ul are always >= 0
-
- Historically the default "unknown" value for progress.size_dl and
- progress.size_ul has been zero, since these values are initialized
- implicitly by the calloc that allocates the curl handle that these
- variables are a part of. Users of curl that install progress
- callbacks may expect these values to always be >= 0.
+- CODE_STYLE: Space around operators
- Currently it is possible for progress.size_dl and progress.size_ul
- to by set to a value of -1, if Curl_pgrsSetDownloadSize() or
- Curl_pgrsSetUploadSize() are passed a "size" of -1 (which a few
- places currently do, and a following patch will add more). So
- lets update Curl_pgrsSetDownloadSize() and Curl_pgrsSetUploadSize()
- so they make sure that these variables always contain a value that
- is >= 0.
+ As just discussed on the mailing list, also document how we prefer
+ spacing in expressions.
+
+- curl: glob_range: no need to check unsigned variable for negative
- Updates test579 and test599.
+ cppcheck warned:
- Signed-off-by: Brandon Casey <drafnel@gmail.com>
+ [src/tool_urlglob.c:283]: (style) Checking if unsigned variable 'step_n'
+ is less than zero.
-Steve Holme (7 Sep 2014)
-- tests: Added test1420 to the makefile
+- CODE_STYLE: add example for indent style as well
-- test1420: Removed unnecessary CURLOPT setting
+- CODE_STYLE: mention braces for functions too
-- tests: Added more "Clear Text" authentication keywords
+- docs/Makefile.am: include CODE_STYLE in tarball too
-- tests: Updated "based on" text due to email test renumbering
+- CONTRIBUTE: moved out code style to a separate document
-- tests: For consistency added --libcurl to test name
+- CODE_STYLE: initial version
+
+ Ripped out from CONTRIBUTE into its own document, but also extended from
+ there.
-- tests: Added --libcurl for IMAP test case
+- curl_sasl.c: minor code indent fixes
-- multi.c: Avoid invalid memory read after free() from commit 3c8c873252
+- multi: simplified singlesocket
- As the current element in the list is free()d by Curl_llist_remove(),
- when the associated connection is pending, reworked the loop to avoid
- accessing the next element through e->next afterward.
+ Since sh_getentry() now checks for invalid sockets itself and by
+ narrowing the scope of the remove_sock_from_hash variable.
-- multi.c: Fixed compilation warning from commit 3c8c873252
+- multi: introduce sh_getentry() for looking up sockets in the sockhash
- warning: implicit conversion from enumeration type 'CURLMcode' to
- different enumeration type 'CURLcode'
+ Simplify the code by using a single entry that looks for a socket in the
+ socket hash. As indicated in #712, the code looked for CURL_SOCKET_BAD
+ at some point and that is ineffective/wrong and this makes it easier to
+ avoid that.
-- url.c: Use CURLAUTH_NONE constant rather than 0
+- [Jaime Fullaondo brought this change]
+
+ multi hash: ensure modulo performed on curl_socket_t
- Small follow up to commit 898808fa8c to use auth constants rather than
- hard code value when clearing picked authentication mechanism.
+ Closes #712
+
+Steve Holme (13 Mar 2016)
+- base64: Minor coding standard and style updates
+
+- base64: Use 'CURLcode result' for curl result codes
-- RELEASE-NOTES: Synced with fd1ce3856a
+- negotiate: Use 'CURLcode result' for curl result codes
-Nick Zitzmann (4 Sep 2014)
-- [Vilmos Nebehaj brought this change]
+Daniel Stenberg (13 Mar 2016)
+- [Maksim Kuzevanov brought this change]
- darwinssl: Use CopyCertSubject() to check CA cert.
+ multi_runsingle: avoid loop in CURLM_STATE_WAITPROXYCONNECT
- SecCertificateCopyPublicKey() is not available on iPhone. Use
- CopyCertSubject() instead to see if the certificate returned by
- SecCertificateCreateWithData() is valid.
+ Closes #703
+
+- TODO: Use the RFC6265 test suite
+
+Steve Holme (13 Mar 2016)
+- checksrc.bat: Added the ability to scan src and lib source independently
+
+- digest: Use boolean based success code for Curl_sasl_digest_get_pair()
- Reported-by: Toby Peterson
+ Rather than use a 0 and 1 integer base result code use a TRUE / FALSE
+ based success code.
+
+- digest: Corrected some typos in comments
-Steve Holme (4 Sep 2014)
-- RELEASE-NOTES: Clarify email Kerberos support is currently via Windows SSPI
+- krb5: Corrected some typos in function descriptions
-Daniel Stenberg (4 Sep 2014)
-- MAIL-ETIQUETTE: "1.8 I posted, now what?"
+- ntlm: Corrected some typos in function descriptions
-- CURLOPT_CA*: better refering between *CAINFO and *CAPATH
+- url: Corrected indentation when calling idna_to_ascii_lz()
+
+- idn_win32: Use boolean based success codes
- ... and a minor wording edit
+ Rather than use 0 and 1 integer base result codes use a FALSE / TRUE
+ based success code.
+
+Daniel Stenberg (10 Mar 2016)
+- idn_win32.c: warning: Trailing whitespace
-- THANKS: added Dennis Clarke
+Steve Holme (10 Mar 2016)
+- idn_win32.c: Fixed compilation warning from commit 9e7fcd4291
- Dennis Clarke from Blastwave.org for ensuring that nightly builds run
- smooth on Solaris!
+ warning C4267: 'function': conversion from 'size_t' to 'int',
+ possible loss of data
+
+Daniel Stenberg (10 Mar 2016)
+- THANKS-filter: unify Michael König
+
+- RELEASE-NOTES: synced with 863c5766dd
-- curl_multi_cleanup: remove superfluous NULL assigns
+- ftp: remove a check for NULL(!)
- ... as the struct is free()d in the end anyway. It was first pointed out
- to me that one of the ->msglist assignments were supposed to have been
- ->pending but was a copy and paste mistake when I realized none of the
- clearing of pointers had to be there.
+ ... as it implies we need to check for that on all the other variable
+ references as well (as Coverity otherwise warns us for missing NULL
+ checks), and we're alredy making sure that the pointer is never NULL.
-- multi: convert CURLM_STATE_CONNECT_PEND handling to a list
+- cookies: first n/v pair in Set-Cookie: is the cookie, then parameters
- ... instead of scanning through all handles, stash only the actual
- handles that are in that state in the new ->pending list and scan that
- list only. It should be mostly empty or very short. And only used for
- pipelining.
+ RFC 6265 section 4.1.1 spells out that the first name/value pair in the
+ header is the actual cookie name and content, while the following are
+ the parameters.
- This avoids a rather hefty slow-down especially notable if you add many
- handles to the same multi handle. Regression introduced in commit
- 0f147887 (version 7.30.0).
+ libcurl previously had a more liberal approach which causes significant
+ problems when introducing new cookie parameters, like the suggested new
+ cookie priority draft.
- Bug: http://curl.haxx.se/mail/lib-2014-07/0206.html
- Reported-by: David Meyer
+ The previous logic read all n/v pairs from left-to-right and the first
+ name used that wassn't a known parameter name would be used as the
+ cookie name, thus accepting "Set-Cookie: Max-Age=2; person=daniel" to be
+ a cookie named 'person' while an RFC 6265 compliant parser should
+ consider that to be a cookie named 'Max-Age' with an (unknown) parameter
+ 'person'.
+
+ Fixes #709
-- RELEASE-NOTES: synced with e608324f9f9
+- krb5: improved type handling to avoid clang compiler warnings
-- [Andre Heinecke brought this change]
+- url.c: fix clang warning: no newline at end of file
- polarssl: implement CURLOPT_SSLVERSION
+- curl_multi_wait: never return -1 in 'numfds'
- Forwards the setting as minimum ssl version (if set) to polarssl. If
- the server does not support the requested version the SSL Handshake will
- fail.
+ Such a return value isn't documented but could still happen, and the
+ curl tool code checks for it. It would happen when the underlying
+ Curl_poll() function returns an error. Starting now we mask that error
+ as a user of curl_multi_wait() would have no way to handle it anyway.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1419
+ Reported-by: Jay Satiro
+ Closes #707
+
+- HTTP2.md: add CURL_HTTP_VERSION_2TLS and updated alt-svc link
-nickzman (1 Sep 2014)
-- Merge pull request #115 from ldx/darwinsslfixpr
+- curl_multi_wait.3: add example
+
+Steve Holme (8 Mar 2016)
+- imap/pop3/smtp: Fixed connections upgraded with TLS are not reused
+
+ Regression since commit 710f14edba.
+
+ Bug: https://github.com/curl/curl/issues/422
+ Reported-by: Justin Ehlert
+
+Jay Satiro (8 Mar 2016)
+- opt-docs: fix heading macros
+
+ ..SH should be .SH
- darwinssl: now accepts cacert bundles in PEM format in addition to single certs
+ Bug: https://github.com/curl/curl/issues/705
+ Reported-by: Eric S. Raymond
-Vilmos Nebehaj (1 Sep 2014)
-- Check CA certificate in curl_darwinssl.c.
+Kamil Dudka (8 Mar 2016)
+- [Tim Rühsen brought this change]
+
+ cookie: do not refuse cookies for localhost
- SecCertificateCreateWithData() returns a non-NULL SecCertificateRef even
- if the buffer holds an invalid or corrupt certificate. Call
- SecCertificateCopyPublicKey() to make sure cacert is a valid
- certificate.
+ Closes #658
-Daniel Stenberg (31 Aug 2014)
-- low-speed-limit: avoid timeout flood
+Daniel Stenberg (8 Mar 2016)
+- ftp_done: clear tunnel_state when secondary socket closes
- Introducing Curl_expire_latest(). To be used when we the code flow only
- wants to get called at a later time that is "no later than X" so that
- something can be checked (and another timeout be added).
+ Introducing a function for closing the secondary connection to make this
+ bug less likely to happen again.
- The low-speed logic for example could easily be made to set very many
- expire timeouts if it would be called faster or sooner than what it had
- set its own timer and this goes for a few other timers too that aren't
- explictiy checked for timer expiration in the code.
+ Reported-by: daboul
+ Closes #701
+
+- [Gisle Vanem brought this change]
+
+ openssl: use the correct OpenSSL/BoringSSL/LibreSSL in messages
+
+- HTTP2.md: HTTP/2 by default for curl's HTTPS connections
+
+- [Anders Bakken brought this change]
+
+ pipeline: Sanity check pipeline pointer before accessing it.
- If there's no condition the code that says if(time-passed >= TIME), then
- Curl_expire_latest() is preferred to Curl_expire().
+ I got a crash with this stack:
- If there exists such a condition, it is on the other hand important that
- Curl_expire() is used and not the other.
+ curl/lib/url.c:2873 (Curl_removeHandleFromPipeline)
+ curl/lib/url.c:2919 (Curl_getoff_all_pipelines)
+ curl/lib/multi.c:561 (curl_multi_remove_handle)
+ curl/lib/url.c:415 (Curl_close)
+ curl/lib/easy.c:859 (curl_easy_cleanup)
- Bug: http://curl.haxx.se/mail/lib-2014-06/0235.html
- Reported-by: Florian Weimer
+ Closes #704
-- [Michael Wallner brought this change]
+- HTTP2.md: mention the disable ALPN and NPN options
- resolve: cache lookup for async resolvers
+- TODO: 17.12 keep running, read instructions from pipe/socket
- While waiting for a host resolve, check if the host cache may have
- gotten the name already (by someone else), for when the same name is
- resolved by several simultanoues requests.
+ And delete trailing whitespace
+ And rename section 17 to "command line tool" from "client"
- The resolver thread occasionally gets stuck in getaddrinfo() when the
- DNS or anything else is crappy or slow, so when a host is found in the
- DNS cache, leave the thread alone and let itself cleanup the mess.
+ Closes #702
-Vilmos Nebehaj (30 Aug 2014)
-- Fix CA certificate bundle handling in darwinssl.
+- README.md: linkified
- If the --cacert option is used with a CA certificate bundle that
- contains multiple CA certificates, iterate through it, adding each
- certificate as a trusted root CA.
+ It also makes it less readable as plain text, so let's keep this
+ primarily for github use.
+
+ Removed the top ascii art logo, as it looks weird when markdownified.
+
+- README.md: markdown version of README
+
+ Attempt to make it look more appealing on github
+
+Jay Satiro (6 Mar 2016)
+- mprintf: update trio project link
+
+Daniel Stenberg (6 Mar 2016)
+- CURLOPT_ACCEPTTIMEOUT_MS.3: added example
+
+- CURLOPT_ACCEPT_ENCODING.3: added example
+
+- CURLOPT_APPEND.3: added example
-Daniel Stenberg (29 Aug 2014)
-- [Askar Safin brought this change]
+- CURLOPT_NOPROGRESS.3: added example, conform to stardard style
- getinfo-times: Typo fixed
+Steve Holme (6 Mar 2016)
+- build-openssl/checksrc.bat: Fixed prepend vs append of Perl path
+
+ Fixed inconsistency from commit 1eae114065 and 0ad6c72227 of the order
+ in which Perl was added to the PATH.
-- [Askar Safin brought this change]
+Daniel Stenberg (6 Mar 2016)
+- opts: added two examples
- libcurl.3: Typo fixed
+- CURLOPT_SSL_CTX_FUNCTION.3: use .NF for example
-- curl_formadd.3: setting CURLFORM_CONTENTSLENGTH 0 zero means strlen
+- CURLOPT_SSL_CTX_FUNCTION.3: added example
+
+ and removed erroneous reference to test case lib509
-- curl.1: add an example for -H
+- curlx.c: use more curl style code
-- FAQ: mention -w in the 4.20 answer as well
+- test46: change cookie expiry date
+
+ Since two of the cookies would now otherwise expire and cause the test
+ to fail after commit 20de9b4f09
+
+ Discussed in #697
-- FAQ: 4.20 curl doesn't return error for HTTP non-200 responses
+Jay Satiro (5 Mar 2016)
+- [Viktor Szakats brought this change]
-- CURLOPT_NOBODY.3: clarify this option is for downloads
+ makefile.m32: add missing libs for static -winssl-ssh2 builds
- When enabling CURLOPT_NOBODY, libcurl effectively switches off upload
- mode and will do a download (without a body). This is now better
- explained in this man page.
+ Bug: https://github.com/curl/curl/pull/693
+
+- mbedtls: fix user-specified SSL protocol version
- Bug: http://curl.haxx.se/mail/lib-2014-08/0236.html
- Reported-by: John Coffey
+ Prior to this change when a single protocol CURL_SSLVERSION_ was
+ specified by the user that version was set only as the minimum version
+ but not as the maximum version as well.
-- INTERNALS: nghttp2 must be 0.6.0 or later
+Steve Holme (5 Mar 2016)
+- .gitignore: Added *.VC.opendb and *.vcxproj.user files for VC14
-- [Tatsuhiro Tsujikawa brought this change]
+- build-openssl.bat: Fixed cannot find perl if installed but not in path
- Compile with latest nghttp2
+- checksrc.bat: Fixed cannot find perl if installed but not in path
-Dan Fandrich (26 Aug 2014)
-- THANKS: removed a few more duplicates
+Jay Satiro (5 Mar 2016)
+- [Viktor Szakats brought this change]
-Daniel Stenberg (26 Aug 2014)
-- RELEASE-NOTES: synced with 007242257683a
+ makefile.m32: fix to allow -ssh2-winssl combination
- ... and bumped the contributor amount after recount
+ In makefile.m32, option -ssh2 (libssh2) automatically implied -ssl
+ (OpenSSL) option, with no way to override it with -winssl. Since both
+ libssh2 and curl support using Windows's built-in SSL backend, modify
+ the logic to allow that combination.
-- THANKS: added 52 missing contributors
+- cookie: Don't expire session cookies in remove_expired
- I re-ran contributors.sh on all changes since 7.10 and I found these
- contributors who are mentioned in the commits but never were added to
- THANKS before!
+ Prior to this change cookies with an expiry date that failed parsing
+ and were converted to session cookies could be purged in remove_expired.
- I also removed a couple of duplicates (mostly due to different
- spellings).
+ Bug: https://github.com/curl/curl/issues/697
+ Reported-by: Seth Mos
-- contributors: grep and sort case insensitively
-
-- [Michael Osipov brought this change]
+Daniel Stenberg (3 Mar 2016)
+- cookie: remove redundant check
+
+ ... as it was already checked previously within the function.
+
+ Reported-by: Dmitry-Me
+ Closes #695
- configure.ac: Add support for recent GSS-API implementations for HP-UX
-
- By default, configure script assumes that libcurl will use the
- HP-supplied GSS-API implementation which does not have krb5-config.
- If a dev needs a more recent version which has that config script,
- the change will allow to pass an appropriate GSSAPI_ROOT.
+Jay Satiro (1 Mar 2016)
+- [Anders Bakken brought this change]
-- CONNECT: close proxy connections that fail to CONNECT
+ url: if Curl_done is premature then pipeline not in use
- This is usually due to failed auth. There's no point in us keeping such
- a connection alive since it shouldn't be re-used anyway.
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1381
- Reported-by: Marcel Raad
-
-- RELEASE-NOTES: added two missing HTTP/2 bug fixes
+ Prevent a crash if 2 (or more) requests are made to the same host and
+ pipelining is enabled and the connection does not complete.
- And renamed all http2 references to HTTP/2 in this file
+ Bug: https://github.com/curl/curl/pull/690
-- RELEASE-NOTES: synced with f646e9075f47
+- [Viktor Szakats brought this change]
-- [Jakub Zakrzewski brought this change]
+ makefile.m32: allow to pass .dll/.exe-specific LDFLAGS
+
+ using envvars `CURL_LDFLAG_EXTRAS_DLL` and
+ `CURL_LDFLAG_EXTRAS_EXE` respectively. This
+ is useful f.e. to pass ASLR-related extra
+ options, that are required to make this
+ feature work when using the mingw toolchain.
+
+ Ref: https://github.com/curl/curl/pull/670#issuecomment-190863985
+
+ Closes https://github.com/curl/curl/pull/689
- Cmake: Possibility to use OpenLDAP, OpenSSL, LibSSH2 on windows
+Daniel Stenberg (29 Feb 2016)
+- formpost: fix memory leaks in AddFormData error branches
- At this point I can build libcurl on windows. It provides at least the same
- list of protocols as for linux build and works with our software.
+ Reported-by: Dmitry-Me
+ Fixes #688
-- [Jakub Zakrzewski brought this change]
+Jay Satiro (28 Feb 2016)
+- getinfo: Fix syntax error when mbedTLS
+
+ The assignment of the mbedTLS TLS session info in the parent commit was
+ incorrect. Change the assignment to a pointer to the session structure.
- Cmake: Removed repeated content from ending blocks
+- getinfo: Add support for mbedTLS TLS session info
- They are unnecesary in modern CMake and removing them improves readability.
+ .. and preprocessor check TLS session info is defined for all backends.
-- [Jakub Zakrzewski brought this change]
+Daniel Stenberg (26 Feb 2016)
+- ROADMAP: clarify on the TLS proxy, mention HTTP cookies to work on
- Cmake: Removed some useless empty SET statements.
+- file: try reading from files with no size
- Undefined variables resolve to empty strings and we do not ever test if
- the variable is defined thus those SETs are superfluous.
+ Some systems have special files that report as 0 bytes big, but still
+ contain data that can be read (for example /proc/cpuinfo on
+ Linux). Starting now, a zero byte size is considered "unknown" size and
+ will be read as far as possible anyway.
+
+ Reported-by: Jesse Tan
+
+ Closes #681
-- [Jakub Zakrzewski brought this change]
+Jay Satiro (25 Feb 2016)
+- configure: warn on invalid ca bundle or path
+
+ - Warn if --with-ca-bundle file does not exist.
+
+ - Warn if --with-ca-path directory does not contain certificates.
+
+ - Improve help messages for both.
+
+ Example configure output:
+
+ ca cert bundle: /some/file (warning: certs not found)
+ ca cert path: /some/dir (warning: certs not found)
+
+ Bug: https://github.com/curl/curl/issues/404
+ Reported-by: Jeffrey Walton
- Cmake: Removed useless comments from CMakeLists.txt
+Daniel Stenberg (24 Feb 2016)
+- Curl_read: check for activated HTTP/1 pipelining, not only requested
- They look like some relics after changes.
+ ... as when pipelining is used, we read things into a unified buffer and
+ we don't do that with HTTP/2. This could then easily make programs that
+ set CURLMOPT_PIPELINING = CURLPIPE_HTTP1|CURLPIPE_MULTIPLEX to get data
+ intermixed or plain broken between HTTP/2 streams.
+
+ Reported-by: Anders Bakken
-- [Jakub Zakrzewski brought this change]
+Patrick Monnerat (24 Feb 2016)
+- os400: Fix ILE/RPG definition of CURLOPT_TFTP_NO_OPTIONS
- Cmake: Don't check for all headers each time
+Jay Satiro (23 Feb 2016)
+- getinfo: CURLINFO_TLS_SSL_PTR supersedes CURLINFO_TLS_SESSION
+
+ The two options are almost the same, except in the case of OpenSSL:
+
+ CURLINFO_TLS_SESSION OpenSSL session internals is SSL_CTX *.
+
+ CURLINFO_TLS_SSL_PTR OpenSSL session internals is SSL *.
- One header at a time is the right way. Apart from that the output on
- windows goes from:
- ...
- -- Looking for include files I:/src/libssh2-1.4.3/include/libssh2.h, ws2tcpip.h
- -- Looking for include files I:/src/libssh2-1.4.3/include/libssh2.h, ws2tcpip.h
- - found
- -- Looking for 3 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., wins
- ock2.h
- -- Looking for 3 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., wins
- ock2.h - found
- -- Looking for 4 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., stdi
- o.h
- -- Looking for 4 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., stdi
- o.h - found
- -- Looking for 5 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., wind
- ows.h
- -- Looking for 5 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., wind
- ows.h - found
- -- Looking for 6 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., wins
- ock.h
- -- Looking for 6 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., wins
- ock.h - found
- -- Looking for 7 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., sys/
- filio.h
- -- Looking for 7 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., sys/
- filio.h - not found
- -- Looking for 7 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., sys/
- ioctl.h
- -- Looking for 7 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., sys/
- ioctl.h - not found
- -- Looking for 7 include files I:/src/libssh2-1.4.3/include/libssh2.h, ..., sys/
- resource.h
- ...
+ For backwards compatibility we couldn't modify CURLINFO_TLS_SESSION to
+ return an SSL pointer for OpenSSL.
- To much nicer:
- ...
- -- Looking for ws2tcpip.h
- -- Looking for ws2tcpip.h - found
- -- Looking for winsock2.h
- -- Looking for winsock2.h - found
- -- Looking for stdio.h
- -- Looking for stdio.h - found
- -- Looking for windows.h
- -- Looking for windows.h - found
- -- Looking for winsock.h
- -- Looking for winsock.h - found
- -- Looking for sys/filio.h
- -- Looking for sys/filio.h - not found
- -- Looking for sys/ioctl.h
- -- Looking for sys/ioctl.h - not found
- -- Looking for sys/resource.h
+ Also, add support for the 'internals' member to point to SSL object for
+ the other backends axTLS, PolarSSL, Secure Channel, Secure Transport and
+ wolfSSL.
+
+ Bug: https://github.com/curl/curl/issues/234
+ Reported-by: dkjjr89@users.noreply.github.com
+
+ Bug: https://curl.haxx.se/mail/lib-2015-09/0127.html
+ Reported-by: Michael König
-- [Jakub Zakrzewski brought this change]
+Daniel Stenberg (23 Feb 2016)
+- multi_remove_handle: keep the timeout list until after disconnect
+
+ The internal Curl_done() function uses Curl_expire() at times and that
+ uses the timeout list. Better clean up the list once we're done using
+ it. This caused a segfault.
+
+ Reported-by: 蔡文凱
+ Bug: https://curl.haxx.se/mail/lib-2016-02/0097.html
- Cmake: Append OpenSSL include directory to search path
+Kamil Dudka (23 Feb 2016)
+- tests/sshserver.pl: use RSA instead of DSA for host auth
+
+ DSA is no longer supported by OpenSSH 7.0, which causes all SCP/SFTP
+ test cases to be skipped. Using RSA for host authentication works with
+ both old and new versions of OpenSSH.
- At this point I can build libcurl with OpenSSL, OpenLDAP and LibSSH2.
- Supported protocols are at least:
- HTTP, HTTPS, FTP, SFTP, TFTP, LDAP, LDAPS, POP3, SMTP
- (those are the ones we have regression tests for
- in our product's testsuite)
+ Reported-by: Karlson2k
+
+ Closes #676
-- [Jakub Zakrzewski brought this change]
+Jay Satiro (23 Feb 2016)
+- TFTP: add option to suppress TFTP option requests (Part 2)
+
+ - Add tests.
+
+ - Add an example to CURLOPT_TFTP_NO_OPTIONS.3.
+
+ - Add --tftp-no-options to expose CURLOPT_TFTP_NO_OPTIONS.
+
+ Bug: https://github.com/curl/curl/issues/481
- Cmake: Search for liblber, LDAP SSL headers, swith for using OpenLDAP code.
+- [Michael Koenig brought this change]
-- [Jakub Zakrzewski brought this change]
+ TFTP: add option to suppress TFTP option requests (Part 1)
+
+ Some TFTP server implementations ignore the "TFTP Option extension"
+ (RFC 1782-1784, 2347-2349), or implement it in a flawed way, causing
+ problems with libcurl. Another switch for curl_easy_setopt
+ "CURLOPT_TFTP_NO_OPTIONS" is introduced which prevents libcurl from
+ sending TFTP option requests to a server, avoiding many problems caused
+ by faulty implementations.
+
+ Bug: https://github.com/curl/curl/issues/481
- Cmake: LibSSH2 detection and use.
+Daniel Stenberg (22 Feb 2016)
+- [Karlson2k brought this change]
-- [Jakub Zakrzewski brought this change]
+ runtests: Fixed usage of %PWD on MinGW64
+
+ Closes #672
- Cmake: Moved macros out of the main CMakeLists.txt
+Jay Satiro (20 Feb 2016)
+- CURLOPT_DEBUGFUNCTION.3: Fix example
-- [Jakub Zakrzewski brought this change]
+- [Viktor Szakats brought this change]
- Cmake: Added missing protocol-disable switches
+ src/Makefile.m32: add CURL_{LD,C}FLAGS_EXTRAS support
- They already have their defines in config.h. This makes it possible to
- disable the protocols from command line during configure step.
+ Sync with lib/Makefile.m32 which already uses those variables.
+
+ Bug: https://github.com/curl/curl/pull/670
-- [Jakub Zakrzewski brought this change]
+Dan Fandrich (20 Feb 2016)
+- Enabled test 1437 after the bug fix in commit 3fa220a6
- Cmake: Made boolean defines be defined to "1" instead of "ON"
-
- It's by convention, for compatibility and because the comments say so.
- Just mabe someone have written a test like "#if HAVE_XX==1"
+Jay Satiro (19 Feb 2016)
+- [Emil Lerner brought this change]
-- [Jakub Zakrzewski brought this change]
+ curl_sasl: Fix memory leak in digest parser
+
+ If any parameter in a HTTP DIGEST challenge message is present multiple
+ times, memory allocated for all but the last entry should be freed.
+
+ Bug: https://github.com/curl/curl/pull/667
- Cmake: Require at least CMake 2.8.
+Dan Fandrich (19 Feb 2016)
+- Added test 1437 to verify a memory leak
- CMake 2.6 is already a bit old. Many bugs have been fixed since
- its release. We use 2.8 in our company and we have no intention
- of polluting our environment with old software, so 2.6 would
- not be tested. This shouldn't be a problem since all one need
- to build CMake from source is C and C++ compiler.
+ Reported-by: neex@users.noreply.github.com
-- disconnect: don't touch easy-related state on disconnects
+Jay Satiro (18 Feb 2016)
+- CURLOPT_COOKIEFILE.3: HTTP headers must be Set-Cookie style
- This was done to make sure NTLM state that is bound to a connection
- doesn't survive and gets used for the subsequent request - but
- disconnects can also be done to for example make room in the connection
- cache and thus that connection is not strictly related to the easy
- handle's current operation.
+ Bug: https://github.com/curl/curl/issues/666
+ Reported-by: baumanj@users.noreply.github.com
+
+- curl.1: HTTP headers for --cookie must be Set-Cookie style
- The http authentication state is still kept in the easy handle since all
- http auth _except_ NTLM is connection independent and thus survive over
- multiple connections.
+ Bug: https://github.com/curl/curl/issues/666
+ Reported-by: baumanj@users.noreply.github.com
+
+Daniel Stenberg (18 Feb 2016)
+- curl.1: add a missing dash
+
+- CONTRIBUTING.md: fix links
+
+- ISSUE_TEMPLATE: github issue template
- Bug: http://curl.haxx.se/mail/lib-2014-08/0148.html
- Reported-by: Paras S
+ First version, try this out!
-- curl.1: clarify --limit-rate's effect on both directions
+- CONTRIBUTING.md: move into .github
- Bug: http://curl.haxx.se/bug/view.cgi?id=1414
- Reported-by: teo8976
+ To hide github specific files somewhat from the rest.
+
+- opts: add references
-- curl.1: mention the --post30x options within the --location desc
+- examples/make: add 'checksrc' target
-Dan Fandrich (22 Aug 2014)
-- sasl: Fixed a memory leak on OOM
+- 10-at-a-time: typecast the argument passed to sleep()
-Daniel Stenberg (22 Aug 2014)
-- [Frank Meier brought this change]
+- externalsocket.c: fix compiler warning for fwrite return type
+
+- anyauthput.c: fix compiler warnings
+
+- simplessl.c: warning: while with space
+
+- curlx.c: i2s_ASN1_IA5STRING() clashes with an openssl function
+
+ Reported-By: Gisle Vanem
- NTLM: ignore CURLOPT_FORBID_REUSE during NTLM HTTP auth
+- http2: don't decompress gzip decoding automatically
- Problem: if CURLOPT_FORBID_REUSE is set, requests using NTLM failed
- since NTLM requires multiple requests that re-use the same connection
- for the authentication to work
+ At one point during the development of HTTP/2, the commit 133cdd29ea0
+ introduced automatic decompression of Content-Encoding as that was what
+ the spec said then. Now however, HTTP/2 should work the same way as
+ HTTP/1 in this regard.
- Solution: Ignore the forbid reuse flag in case the NTLM authentication
- handshake is in progress, according to the NTLM state flag.
+ Reported-by: Kazuho Oku
- Fixed known bug #77.
+ Closes #661
-Steve Holme (22 Aug 2014)
-- openssl.c: Fixed longer than 79 columns
+Jay Satiro (16 Feb 2016)
+- [Tatsuhiro Tsujikawa brought this change]
-- openssl.c: Fixed compilation warning
+ http: Don't break the header into chunks if HTTP/2
+
+ nghttp2 callback deals with TLS layer and therefore the header does not
+ need to be broken into chunks.
- warning: declaration of 'minor' shadows a global declaration
+ Bug: https://github.com/curl/curl/issues/659
+ Reported-by: Kazuho Oku
+
+Daniel Stenberg (16 Feb 2016)
+- [Viktor Szakats brought this change]
+
+ openssl: use macro to guard the opaque EVP_PKEY branch
-Daniel Stenberg (21 Aug 2014)
-- [Haris Okanovic brought this change]
+- [Viktor Szakats brought this change]
- win32: Fixed WinSock 2 #if
+ openssl: avoid direct PKEY access with OpenSSL 1.1.0
- A conditionally compiled block in connect.c references WinSock 2
- symbols, but used `#ifdef HAVE_WINSOCK_H` instead of `#ifdef
- HAVE_WINSOCK2_H`.
+ by using API instead of accessing an internal structure.
+ This is required starting OpenSSL 1.1.0-pre3.
- Bug: http://curl.haxx.se/mail/lib-2014-08/0155.html
+ Closes #650
-- Curl_disconnect: don't free the URL
+- RELEASE-NOTES: synced with ede0bfc079da
+
+- [Clint Clayton brought this change]
+
+ CURLOPT_CONNECTTIMEOUT_MS.3: Fix example to use milliseconds option
- The URL is not a property of the connection so it should not be freed in
- the connection disconnect but in the Curl_close() that frees the easy
- handle.
+ Change the example in the docs for CURLOPT_CONNECTTIMEOUT_MS to use
+ CURLOPT_CONNECTTIMEOUT_MS instead of CURLOPT_CONNECTTIMEOUT.
- Bug: http://curl.haxx.se/mail/lib-2014-08/0148.html
- Reported-by: Paras S
+ Closes #653
-- help output: minor whitespace edits
+- opt-docs: add more references
+
+- [David Byron brought this change]
+
+ SCP: use libssh2_scp_recv2 to support > 2GB files on windows
- Should've been amended in the previous commit but wasn't due to a
- mistake.
+ libssh2_scp_recv2 is introduced in libssh2 1.7.0 - to be released "any
+ day now.
+
+ Closes #451
-- [Zearin brought this change]
+Jay Satiro (13 Feb 2016)
+- [Shine Fan brought this change]
- help output: use ≥2 spaces between option and description
+ gtls: fix for builds lacking encrypted key file support
- ... and some other cleanups
+ Bug: https://github.com/curl/curl/pull/651
+
+Dan Fandrich (13 Feb 2016)
+- test1604: Add to Makefile.inc so it gets run
-- FAQ: some actually sometimes get paid...
+Jay Satiro (12 Feb 2016)
+- generate.bat: Fix comment bug by removing old comments
+
+ Remove NOTES section, it's no longer needed since we aren't setting the
+ errorlevel and more importantly the recently updated URL in the comments
+ is causing some unusual behavior that breaks the script.
+
+ Closes https://github.com/curl/curl/issues/649
-Steve Holme (17 Aug 2014)
-- sasl_sspi: Fixed a memory leak with the GSSAPI base-64 decoded challenge
+Kamil Dudka (12 Feb 2016)
+- curl.1: --disable-{eprt,epsv} are ignored for IPv6 hosts
+
+ The behavior has been clarified in CURLOPT_FTP_USE_{EPRT,EPSV}.3 man
+ pages since curl-7_12_3~131. This patch makes it clear in the curl.1
+ man page, too.
+
+ Bug: https://bugzilla.redhat.com/1305970
-- sasl_sspi: Renamed GSSAPI mutual authentication parameter
+Daniel Stenberg (12 Feb 2016)
+- dist: ship buildconf.bat too
- ...From "mutual" to "mutual_auth" which better describes what it is.
+ As the winbuild/* stuff uses it!
-- sasl_sspi: Corrected some of the GSSAPI security message error codes
+- curlx_tvdiff: handle 32bit time_t overflows
- Corrected a number of the error codes that can be returned from the
- Curl_sasl_create_gssapi_security_message() function when things go
- wrong.
+ On 32bit systems, make sure we don't overflow and return funky values
+ for very large time differences.
- It makes more sense to return CURLE_BAD_CONTENT_ENCODING when the
- inbound security challenge can't be decoded correctly or doesn't
- contain the KERB_WRAP_NO_ENCRYPT flag and CURLE_OUT_OF_MEMORY when
- EncryptMessage() fails. Unfortunately the previous error code of
- CURLE_RECV_ERROR was a copy and paste mistakes on my part and should
- have been correct in commit 4b491c675f :(
+ Reported-by: Anders Bakken
+
+ Closes #646
+
+- examples: fix some compiler warnings
-- docs: Escaped single backslash
+- simplessl.c: fix my breakage
-- TODO: Updated following GSSAPI (Kerberos V5) additions
+- examples: adhere to curl code style
- Updated "FTP 4.6 GSSAPI via Windows SSPI" and "SASL 14.1 Other
- authentication mechanisms" following recent additions.
+ All plain C examples now (mostly) adhere to the curl code style. While
+ they are only examples, they had diverted so much and contained all
+ sorts of different mixed code styles by now. Having them use a unified
+ style helps users and readability. Also, as they get copy-and-pasted
+ widely by users, making sure they're clean and nice is a good idea.
- Added SASL 14.2 GSSAPI via GSS-API libraries.
+ 573 checksrc warnings were addressed.
-- CURLOPT_USERNAME.3: Added Kerberos V5 and NTLM domain information
+- examples/cookie_interface.c: add cleanup call
- This repeats what has already been documented in both the curl manpage
- and CURLOPT_USERPWD documentation but is provided here for completeness
- as someone may not especially read the latter when using libcurl.
+ cleaning up handles is a good idea as we leak memory otherwise
+
+ Also, line wrapped before 80 columns.
-- CURLOPT_USERPWD.3: Updated following Kerberos V5 SSPI changes
+Kamil Dudka (10 Feb 2016)
+- nss: search slash in forward direction in dup_nickname()
- Added information about Kerberos V5 requiring the domain part in the
- user name.
+ It is wasteful to search it backwards if we look for _any_ slash.
+
+- nss: do not count enabled cipher-suites
- Mentioned that the user name can be specified in UPN format, and not
- just in Down-Level Logon Name format, following the information
- added in commit 7679cb3fa8 reworking the exisitng information in the
- process.
+ We only care if at least one cipher-suite is enabled, so it does
+ not make any sense to iterate till the end and count all enabled
+ cipher-suites.
-- docs: Added Kerberos V5 and NTLM domain information to --user
+Daniel Stenberg (10 Feb 2016)
+- contributors.sh: make 79 the max column width (from 80)
-- docs: Added Kerberos V5 to the --user SSPI current credentials usage
+- RELEASE-NOTES: synced with c276aefee3995
-- sasl_sspi: Tell the server we don't support a GSSAPI receive buffer
+- mbedtls.c: re-indent to better match curl standards
-- smtp: Added support for GSSAPI (Kerberos V5) authentication via Windows SSPI
+- [Rafael Antonio brought this change]
-- pop3: Added support for GSSAPI (Kerberos V5) authentication via Windows SSPI
+ mbedtls: fix memory leak when destroying SSL connection data
+
+ Closes #626
+
+- mbedtls: fix ALPN usage segfault
+
+ Since we didn't keep the input argument around after having called
+ mbedtls, it could end up accessing the wrong memory when figuring out
+ the ALPN protocols.
+
+ Closes #642
-- imap: Added support for GSSAPI (Kerberos V5) authentication via Windows SSPI
+Jay Satiro (9 Feb 2016)
+- [Timotej Lazar brought this change]
-- email: Added mutual authentication flag
+ opts: update references to renamed options
-Daniel Stenberg (15 Aug 2014)
-- RELEASE-NOTES: synced with 0187c9e11d079
+- KNOWN_BUGS: Update #92 - Windows device prefix
-- http: fix the Content-Range: parser
-
- ... to handle "*/[total]". Also, removed the strange hack that made
- CURLOPT_FAILONERROR on a 416 response after a *RESUME_FROM return
- CURLE_OK.
+- tool_doswin: Support for literal path prefix \\?\
- Reported-by: Dimitrios Siganos
- Bug: http://curl.haxx.se/mail/lib-2014-06/0221.html
+ For example something like --output \\?\C:\foo
-Steve Holme (14 Aug 2014)
-- email: Introduced the GSSAPI states
+Daniel Stenberg (9 Feb 2016)
+- configure: state "BoringSSL" in summary when that was detected
-- curl_sasl_sspi.c: Fixed more compilation warnings from commit 4b491c675f
+- [David Benjamin brought this change]
+
+ openssl: remove most BoringSSL #ifdefs.
- warning: unused variable 'resp'
+ As of https://boringssl-review.googlesource.com/#/c/6980/, almost all of
+ BoringSSL #ifdefs in cURL should be unnecessary:
- warning: no previous prototype for 'Curl_sasl_gssapi_cleanup'
-
-- SHA-1: 61c93383b7f6cf79d12ff99e9dced1d1cc2a7064
+ - BoringSSL provides no-op stubs for compatibility which replaces most
+ #ifdefs.
- * curl_sasl_sspi.c: Fixed compilation warning from commit 4b491c675f
+ - DES_set_odd_parity has been in BoringSSL for nearly a year now. Remove
+ the compatibility codepath.
- warning: declaration of 'result' shadows a previous local
-
-- curl_sasl.h: Fixed compilation error from commit 4b491c675f
+ - With a small tweak to an extend_key_56_to_64 call, the NTLM code
+ builds fine.
- warning: 'struct kerberos5data' declared inside parameter list
+ - Switch OCSP-related #ifdefs to the more generally useful
+ OPENSSL_NO_OCSP.
- Due to missing forward declaration.
-
-- urldata.h: Fixed compilation warnings from commit 3ec253532e
+ The only #ifdefs which remain are Curl_ossl_version and the #undefs to
+ work around OpenSSL and wincrypt.h name conflicts. (BoringSSL leaves
+ that to the consumer. The in-header workaround makes things sensitive to
+ include order.)
- warning: extra tokens at end of #endif directive
+ This change errs on the side of removing conditionals despite many of
+ the restored codepaths being no-ops. (BoringSSL generally adds no-op
+ compatibility stubs when possible. OPENSSL_VERSION_NUMBER #ifdefs are
+ bad enough!)
+
+ Closes #640
-- sasl_sspi: Added GSSAPI message functions
+Jay Satiro (8 Feb 2016)
+- KNOWN_BUGS: Windows device prefix is required for devices
-- urldata: Introduced a GSSAPI (Kerberos V5) data structure
+- tool_urlglob: Allow reserved dos device names (Windows)
+
+ Allow --output to reserved dos device names without the device prefix
+ for backwards compatibility.
- Added a kerberos5data structure which is similar in nature to the
- ntlmdata and negotiatedata structures.
+ Example: --output NUL can be used instead of --output \\.\NUL
+
+ Bug: https://github.com/curl/curl/commit/4520534#commitcomment-15954863
+ Reported-by: Gisle Vanem
-- sspi: Moved KERB_WRAP_NO_ENCRYPT from socks_sspi module
+Daniel Stenberg (8 Feb 2016)
+- cookies: allow spaces in cookie names, cut of trailing spaces
+
+ It turns out Firefox and Chrome both allow spaces in cookie names and
+ there are sites out there using that.
+
+ Turned out the code meant to strip off trailing space from cookie names
+ didn't work. Fixed now.
- In preparation for the upcoming SSPI implementation of GSSAPI
- authentication, moved the definition of KERB_WRAP_NO_ENCRYPT from
- socks_sspi.c to curl_sspi.h allowing it to be shared amongst other
- SSPI based code.
+ Test case 8 modified to verify both these changes.
+
+ Closes #639
+
+Patrick Monnerat (8 Feb 2016)
+- Merge branch 'master' of github.com:curl/curl
+
+- os400: sync ILE/RPG definitions with latest public header files.
-Daniel Stenberg (13 Aug 2014)
-- mk-ca-bundle.pl: add missing $
+Daniel Stenberg (8 Feb 2016)
+- [Ludwig Nussel brought this change]
-- mk-ca-bundle.pl: switched to using hg.mozilla.org
+ SSLCERTS: update wrt SSL CA certificate store
+
+- [Ludwig Nussel brought this change]
+
+ configure: --with-ca-fallback: use built-in TLS CA fallback
- ... as mxr.mozilla.org is due to be retired.
+ When trying to verify a peer without having any root CA certificates
+ set, this makes libcurl use the TLS library's built in default as
+ fallback.
+
+ Closes #569
+
+- Proxy-Connection: stop sending this header by default
- The new host doesn't support If-Modified-Since nor ETags, meaning that
- the script will now defer to download and do a post-transfer checksum
- check to see if a new output is to be generated. The new output format
- will hold the SHA1 checksum of the source file for that purpose.
+ RFC 7230 says we should stop. Firefox already stopped.
- We call this version 1.22
+ Bug: https://github.com/curl/curl/issues/633
+ Reported-By: Brad Fitzpatrick
- Reported-by: Ed Morley
- Bug: http://curl.haxx.se/bug/view.cgi?id=1409
+ Closes #633
-- [Jose Alf brought this change]
+- bump: work toward the next release
- openssl: fix version report for the 0.9.8 branch
+- THANKS: 2 contributors from the 7.47.1 release
+
+- RELEASE-PROCEDURE: remove the github upload part
- Fixed libcurl to correctly output the newer versions of OpenSSL 0.9.8,
- starting from openssl-0.9.8za.
+ ... as we're HTTPS on the main site now, there's no point in that
+ extra step
-- [Frank Meier brought this change]
+Version 7.47.1 (8 Feb 2016)
- create_conn: prune dead connections
-
- Bringing back the old functionality that was mistakenly removed when the
- connection cache was remade. When creating a new connection, all the
- existing ones are checked and those that are known to be dead get
- disconnected for real and removed from the connection cache. It helps
- the cache from holding on to very many stale connections and aids in
- keeping down the number of system sockets in wait states.
+Daniel Stenberg (8 Feb 2016)
+- RELEASE-NOTES: curl 7.47.1 time!
+
+Jay Satiro (8 Feb 2016)
+- tool_operhlp: Check for backslashes in get_url_file_name
- Help-by: Jonatan Vela <jonatan.vela@ergon.ch>
+ Extract the filename from the last slash or backslash. Prior to this
+ change backslashes could be part of the filename.
- Bug: http://curl.haxx.se/mail/lib-2014-06/0189.html
-
-Kamil Dudka (11 Aug 2014)
-- docs/SSLCERTS: update the section about NSS database
+ This change needed for the curl tool built for Cygwin. Refer to the
+ CYGWIN addendum in advisory 20160127B.
- Bug: http://curl.haxx.se/mail/lib-2014-07/0335.html
- Reported-by: David Shaw
+ Bug: https://curl.haxx.se/docs/adv_20160127B.html
-Daniel Stenberg (11 Aug 2014)
-- [Peter Wang brought this change]
+Daniel Stenberg (7 Feb 2016)
+- RELEASE-NOTES: synced with d6a8869ea34
- Curl_poll + Curl_wait_ms: fix timeout return value
+Jay Satiro (6 Feb 2016)
+- openssl: Fix signed/unsigned mismatch warning in X509V3_ext
- Curl_poll and Curl_wait_ms require the fix applied to Curl_socket_check
- in commits b61e8b8 and c771968:
+ sk_X509_EXTENSION_num may return an unsigned integer, however the value
+ will fit in an int.
- When poll or select are interrupted and coincides with the timeout
- elapsing, the functions return -1 indicating an error instead of 0 for
- the timeout.
+ Bug: https://github.com/curl/curl/commit/dd1b44c#commitcomment-15913896
+ Reported-by: Gisle Vanem
-Steve Holme (10 Aug 2014)
-- config-tpf.h: Fixed up line lengths > 79 characters
+Daniel Stenberg (7 Feb 2016)
+- TODO: 17.11 -w output to stderr
-- config-symbian.h: Fixed up line lengths > 79 characters
+Jay Satiro (6 Feb 2016)
+- [Michael Kaufmann brought this change]
-- tool_hugehelp.c.cvs: Added copyright
+ idn_win32: Better error checking
+
+ .. also fix a conversion bug in the unused function
+ curl_win32_ascii_to_idn().
+
+ And remove wprintfs on error (Jay).
- Added copyright due to warning from checksrc.pl.
+ Bug: https://github.com/curl/curl/pull/637
-- RELEASE-NOTES: Synced with cd6ecf6a89
+- [Gisle Vanem brought this change]
-- sasl_sspi: Fixed hard coded buffer for response generation
+ examples/asiohiper: Avoid function name collision on Windows
+
+ closesocket => close_socket
+ Winsock already has the former.
- Given the SSPI package info query indicates a token size of 4096 bytes,
- updated to use a dynamic buffer for the response message generation
- rather than a fixed buffer of 1024 bytes.
+ Bug: https://curl.haxx.se/mail/lib-2016-02/0016.html
-- sasl_sspi: Fixed missing free of challenge buffer on SPN failure
+- [Gisle Vanem brought this change]
-- http_negotiate_sspi: Tidy up to remove the get_gss_name() function
+ examples/htmltitle: Use _stricmp on Windows
- Due to the reduction of code in commit 3b924b29 of get_gss_name() the
- function isn't necessary anymore.
+ Bug: https://curl.haxx.se/mail/lib-2016-02/0017.html
-- http_negotiate_sspi: Use a dynamic buffer for SPN generation
+Daniel Stenberg (6 Feb 2016)
+- COPYING: clarify that Daniel is not the sole author
- Updated to use a dynamic buffer for the SPN generation via the recently
- introduced Curl_sasl_build_spn() function rather than a fixed buffer of
- 1024 characters, which should have been more than enough, but by using
- the new function removes the need for another variable sname to do the
- wide character conversion in Unicode builds.
+ ... done on request and as it is a fair point.
+
+Jay Satiro (5 Feb 2016)
+- unit1604: Fix unit setup return code
-- sasl: Tidy up to rename SPN variable from URI
+- tool_doswin: Use type SANITIZEcode in sanitize_file_name
-- sasl: Use a dynamic buffer for SPN generation
+- tool_doswin: Improve sanitization processing
- Updated Curl_sasl_create_digest_md5_message() to use a dynamic buffer
- for the SPN generation via the recently introduced Curl_sasl_build_spn()
- function rather than a fixed buffer of 128 characters.
+ - Add unit test 1604 to test the sanitize_file_name function.
+
+ - Use -DCURL_STATICLIB when building libcurltool for unit testing.
+
+ - Better detection of reserved DOS device names.
+
+ - New flags to modify sanitize behavior:
+
+ SANITIZE_ALLOW_COLONS: Allow colons
+ SANITIZE_ALLOW_PATH: Allow path separators and colons
+ SANITIZE_ALLOW_RESERVED: Allow reserved device names
+ SANITIZE_ALLOW_TRUNCATE: Allow truncating a long filename
+
+ - Restore sanitization of banned characters from user-specified outfile.
+
+ Prior to this commit sanitization of a user-specified outfile was
+ temporarily disabled in 2b6dadc because there was no way to allow path
+ separators and colons through while replacing other banned characters.
+ Now in such a case we call the sanitize function with
+ SANITIZE_ALLOW_PATH which allows path separators and colons to pass
+ through.
+
+
+ Closes https://github.com/curl/curl/issues/624
+ Reported-by: Octavio Schroeder
-- sasl_sspi: Fixed SPN not being converted to wchar under Unicode builds
+- [Viktor Szakats brought this change]
+
+ URLs: change more http to https
+
+- sasl_sspi: Fix memory leak in domain populate
- Curl_sasl_create_digest_md5_message() would simply cast the SPN variable
- to a TCHAR when calling InitializeSecurityContext(). This meant that,
- under Unicode builds, it would not be valid wide character string.
+ Free an existing domain before replacing it.
- Updated to use the recently introduced Curl_sasl_build_spn() function
- which performs the correct conversion for us.
+ Bug: https://github.com/curl/curl/issues/635
+ Reported-by: silveja1@users.noreply.github.com
-- sasl: Introduced Curl_sasl_build_spn() for building a SPN
+Daniel Stenberg (4 Feb 2016)
+- [Viktor Szakats brought this change]
+
+ URLs: follow GitHub project rename (also Travis CI)
- Various parts of the libcurl source code build a SPN for inclusion in
- authentication data. This information is either used by our own native
- generation routines or passed to authentication functions in third-party
- libraries such as SSPI. However, some of these instances use fixed
- buffers rather than dynamically allocated ones and not all of those that
- should, convert to wide character strings in Unicode builds.
+ Closes #632
+
+- CHANGES.o: fix references to curl.haxx.nu
- Implemented a common function that generates a SPN and performs the
- wide character conversion where necessary.
+ I removed the scheme prefix from the URLs references this host name, as
+ we don't own/run that anymore but the name is kept for historic reasons.
+
+- HISTORY: add some info about when we used which host names
+
+Jay Satiro (2 Feb 2016)
+- [Viktor Szakats brought this change]
+
+ URLs: change more http to https
-- sasl_sspi: Fixed memory leak with not releasing Package Info struct
+Dan Fandrich (3 Feb 2016)
+- URLs: Change more haxx.se URLs from http: to https:
+
+Daniel Stenberg (3 Feb 2016)
+- RELEASE-NOTES: synced with 4af40b364
+
+- URLs: change all http:// URLs to https://
+
+- configure: update the copyright year range in output
+
+- dotdot: allow an empty input string too
- Curl_sasl_create_digest_md5_message() wouldn't free the Package Info
- structure after QuerySecurityPackageInfo() had allocated it.
+ It isn't used by the code in current conditions but for safety it seems
+ sensible to at least not crash on such input.
+
+ Extended unit test 1395 to verify this too as well as a plain "/" input.
-- [Michael Osipov brought this change]
+- HTTPS: update a bunch of URLs from HTTP to HTTPS
- docs: Update SPNEGO and GSS-API related doc sections
+- [Sergei Nikulov brought this change]
+
+ AppVeyor: updated to handle OpenSSL/WinSSL builds
- Reflect recent changes in SPNEGO and GSS-API code in the docs.
- Update them with appropriate namings and remove visible spots for
- GSS-Negotiate.
+ Closes #621
-- sspi: Minor code tidy up to standardise coding style
+Jay Satiro (1 Feb 2016)
+- tool_operate: Don't sanitize --output path (Windows)
- Following the recent changes and in attempt to align the SSPI based
- authentication code performed the following:
+ Due to path separators being incorrectly sanitized in --output
+ pathnames, eg -o c:\foo => c__foo
- * Use NULL and SECBUFFVERSION rather than hard coded constants.
- * Avoid comparison of zero in if statements.
- * Standardised the buf and desc setup code.
-
-- schannel: Fixed compilation warning in vtls.c
+ This is a partial revert of 3017d8a until I write a proper fix. The
+ remote-name will continue to be sanitized, but if the user specified an
+ --output with string replacement (#1, #2, etc) that data is unsanitized
+ until I finish a fix.
- vtls.c:688:43: warning: unused parameter 'data'
+ Bug: https://github.com/bagder/curl/issues/624
+ Reported-by: Octavio Schroeder
-- tool_getparam.c: Fixed compilation warning
+- curl.1: Explain remote-name behavior if file already exists
- warning: `orig_opt' might be used uninitialized in this function
+ .. also warn about letting the server pick the filename.
-- RELEASE-NOTES: Synced with 159c3aafd8
+- [Gisle Vanem brought this change]
+
+ urldata: Error on missing SSL backend-specific connect info
-Daniel Stenberg (8 Aug 2014)
-- curl_ntlm_msgs: make < 80 columns wide
+Daniel Stenberg (28 Jan 2016)
+- bump: towards the next (7.47.1 ?)
-Steve Holme (8 Aug 2014)
-- ntlm: Fixed hard coded buffer for SSPI based auth packet generation
+- [Sergei Nikulov brought this change]
+
+ cmake: fixed when OpenSSL enabled on Windows and schannel detected
- Given the SSPI package info query indicates a token size of 2888 bytes,
- and as with the Winbind code and commit 9008f3d56, use a dynamic buffer
- for the Type-1 and Type-3 message generation rather than a fixed buffer
- of 1024 bytes.
+ Closes #617
+
+Jay Satiro (28 Jan 2016)
+- [Sergei Nikulov brought this change]
-- ntlm: Added support for SSPI package info query
+ urldata: moved common variable out of ifdef
- Just as with the SSPI implementations of Digest and Negotiate added a
- package info query so that libcurl can a) return a more appropriate
- error code when the NTLM package is not supported and b) it can be of
- use later to allocate a dynamic buffer for the Type-1 and Type-3
- output tokens rather than use a fixed buffer of 1024 bytes.
+ Closes https://github.com/bagder/curl/pull/618
-Daniel Stenberg (7 Aug 2014)
-- http2: added some more logging for debugging stream problems
+- [Viktor Szakats brought this change]
-- [Tatsuhiro Tsujikawa brought this change]
+ tool_doswin: silence unused function warning
+
+ tool_doswin.c:185:14: warning: 'msdosify' defined but not used
+ [-Wunused-function]
+
+ Closes https://github.com/bagder/curl/pull/616
- HTTP/2: Reset promised stream, not its associated stream.
+Daniel Stenberg (27 Jan 2016)
+- getredirect.c: fix variable name
+
+ Reported-by: Bernard Spil
-- [Tatsuhiro Tsujikawa brought this change]
+Version 7.47.0 (27 Jan 2016)
- HTTP/2: Move :authority before non-pseudo header fields
+Daniel Stenberg (27 Jan 2016)
+- examples/Makefile.inc: specify programs without .c!
-- http2: show the received header for better debugging
+- THANKS: 6 new contributors from 7.47.0 release notes
-- openssl: replace call to OPENSSL_config
+- [Isaac Boukris brought this change]
+
+ NTLM: Fix ConnectionExists to compare Proxy credentials
+
+ Proxy NTLM authentication should compare credentials when
+ re-using a connection similar to host authentication, as it
+ authenticate the connection.
- OPENSSL_config() is "strongly recommended" to use but unfortunately that
- function makes an exit() call on wrongly formatted config files which
- makes it hard to use in some situations. OPENSSL_config() itself calls
- CONF_modules_load_file() and we use that instead and we ignore its
- return code!
+ Example:
+ curl -v -x http://proxy:port http://host/ -U good_user:good_pwd
+ --proxy-ntlm --next -x http://proxy:port http://host/
+ [-U fake_user:fake_pwd --proxy-ntlm]
- Reported-by: Jan Ehrhardt
- Bug: http://curl.haxx.se/bug/view.cgi?id=1401
+ CVE-2016-0755
+
+ Bug: http://curl.haxx.se/docs/adv_20160127A.html
-Dan Fandrich (7 Aug 2014)
-- [Fabian Keil brought this change]
+- [Ray Satiro brought this change]
- runtests.pl: Pad test case numbers with up to three zeroes
+ curl: avoid local drive traversal when saving file (Windows)
- Test case numbers with four digits have been available for a
- while now.
-
-Steve Holme (7 Aug 2014)
-- docs: Added Negotiate to the SSPI current credentials usage description
+ curl does not sanitize colons in a remote file name that is used as the
+ local file name. This may lead to a vulnerability on systems where the
+ colon is a special path character. Currently Windows/DOS is the only OS
+ where this vulnerability applies.
+
+ CVE-2016-0754
+
+ Bug: http://curl.haxx.se/docs/adv_20160127B.html
-- TODO: HTTP Digest via Windows SSPI
+- RELEASE-NOTES: 7.47.0
-- TODO: FTP GSSAPI via Windows SSPI
+- FAQ: language fix in 4.19
-- http_negotiate_sspi: Fixed specific username and password not working
-
- Bug: http://curl.haxx.se/mail/lib-2014-06/0224.html
- Reported-by: Leonardo Rosati
+- [paulehoffman brought this change]
-- http_negotiate_sspi: Fixed endless unauthorized loop in commit 6bc76194e8
+ FAQ: Update to point to GitHub
- If the server rejects our authentication attempt and curl hasn't
- called CompleteAuthToken() then the status variable will be
- SEC_I_CONTINUE_NEEDED and not SEC_E_OK.
+ Current FAQ didn't make it clear where the main repo is.
- As such the existing detection mechanism for determining whether or not
- the authentication process has finished is not sufficient.
+ Closes #612
+
+- maketgz: generate date stamp with LC_TIME=C
- However, the WWW-Authenticate: Negotiate header line will not contain
- any data when the server has exhausted the negotiation, so we can use
- that coupled with the already allocated context pointer.
+ bug: http://curl.haxx.se/mail/lib-2016-01/0123.html
-Daniel Stenberg (5 Aug 2014)
-- RELEASE-NOTES: synced with 5b37db44a3eb
+- curl_multi_socket_action.3: line wrap
-Dan Fandrich (5 Aug 2014)
-- parsedate.c: fix the return code for an overflow edge condition
+- RELEASE-NOTES: synced with d58ba66eeceb
-Daniel Stenberg (5 Aug 2014)
-- [Toby Peterson brought this change]
+Steve Holme (21 Jan 2016)
+- TODO: "Create remote directories" for SMB
- darwinssl: don't use strtok()
+Jay Satiro (18 Jan 2016)
+- mbedtls: Fix pinned key return value on fail
+
+ - Switch from verifying a pinned public key in a callback during the
+ certificate verification to inline after the certificate verification.
+
+ The callback method had three problems:
+
+ 1. If a pinned public key didn't match, CURLE_SSL_PINNEDPUBKEYNOTMATCH
+ was not returned.
+
+ 2. If peer certificate verification was disabled the pinned key
+ verification did not take place as it should.
- The GetDarwinVersionNumber() function uses strtok, which is not
- thread-safe.
+ 3. (related to #2) If there was no certificate of depth 0 the callback
+ would not have checked the pinned public key.
+
+ Though all those problems could have been fixed it would have made the
+ code more complex. Instead we now verify inline after the certificate
+ verification in mbedtls_connect_step2.
+
+ Ref: http://curl.haxx.se/mail/lib-2016-01/0047.html
+ Ref: https://github.com/bagder/curl/pull/601
-- Curl_ossl_version: adapted to detect BoringSSL
+- tests: Add a test for pinnedpubkey fail even when insecure
- This seems to be the way it should work. Right now we can't build with
- BoringSSL and try this out properly due to a minor API breakage.
+ Because disabling the peer verification (--insecure) must not disable
+ the public key pinning check (--pinnedpubkey).
+
+- [Daniel Schauenberg brought this change]
+
+ CURLINFO_RESPONSE_CODE.3: add example
-- Curl_ossl_version: detect and show libressl
+Kamil Dudka (15 Jan 2016)
+- ssh: make CURLOPT_SSH_PUBLIC_KEYFILE treat "" as NULL
- LibreSSL is otherwise OpenSSL API compliant (so far)
+ The CURLOPT_SSH_PUBLIC_KEYFILE option has been documented to handle
+ empty strings specially since curl-7_25_0-31-g05a443a but the behavior
+ was unintentionally removed in curl-7_38_0-47-gfa7d04f.
+
+ This commit restores the original behavior and clarifies it in the
+ documentation that NULL and "" have both the same meaning when passed
+ to CURLOPT_SSH_PUBLIC_KEYFILE.
+
+ Bug: http://curl.haxx.se/mail/lib-2016-01/0072.html
-- [Tatsuhiro Tsujikawa brought this change]
+Daniel Stenberg (14 Jan 2016)
+- RELEASE-NOTES: synced with 35083ca60ed035a
- HTTP/2: Fix infinite loop in readwrite_data()
+- openssl: improved error detection/reporting
- To prevent infinite loop in readwrite_data() function when stream is
- reset before any response body comes, reset closed flag to false once
- it is evaluated to true.
+ ... by extracting the LIB + REASON from the OpenSSL error code. OpenSSL
+ 1.1.0+ returned a new func number of another cerfificate fail so this
+ required a fix and this is the better way to catch this error anyway.
-Dan Fandrich (3 Aug 2014)
-- gtls: only define Curl_gtls_seed if Nettle is not being used
+- openssl: for 1.1.0+ they now provide a SSLeay() macro of their own
-- ssl: provide Curl_ssl_backend even if no SSL library is available
+- CURLOPT_RESOLVE.3: minor language polish
-Daniel Stenberg (2 Aug 2014)
-- [Tatsuhiro Tsujikawa brought this change]
+- configure: assume IPv6 works when cross-compiled
+
+ The configure test uses AC_TRY_RUN to figure out if an ipv6 socket
+ works, and testing like that doesn't work for cross-compiles. These days
+ IPv6 support is widespread so a blind guess is probably more likely to
+ be 'yes' than 'no' now.
+
+ Further: anyone who cross-compiles can use configure's --disable-ipv6 to
+ explicitly disable IPv6 and that also works for cross-compiles.
+
+ Made happen after discussions in issue #594
- HTTP2: Support expect: 100-continue
+- TODO: "Try to URL encode given URL"
- "Expect: 100-continue", which was once deprecated in HTTP/2, is now
- resurrected in HTTP/2 draft 14. This change adds its support to
- HTTP/2 code. This change also includes stricter header field
- checking.
+ Closes #514
-- CURLOPT_SSL_VERIFYPEER.3. add a warning about disabling it
+- ConnectionExists: only do pipelining/multiplexing when asked
+
+ When an HTTP/2 upgrade request fails (no protocol switch), it would
+ previously detect that as still possible to pipeline on (which is
+ acorrect) and do that when PIPEWAIT was enabled even if pipelining was
+ not explictily enabled.
+
+ It should only pipelined if explicitly asked to.
+
+ Closes #584
-- FEATURES: minor update
+- [Mohammad AlSaleh brought this change]
-- openssl: make ossl_send return CURLE_OK better
+ lib: Prefix URLs with lower-case protocol names/schemes
- Previously it only returned a CURLcode for errors, which is when it
- returns a different size than what was passed in to it.
+ Before this patch, if a URL does not start with the protocol
+ name/scheme, effective URLs would be prefixed with upper-case protocol
+ names/schemes. This behavior might not be expected by library users or
+ end users.
- The http2 code only checked the curlcode and thus failed.
-
-- RELEASE-NOTES: synced with 7bb4c8cadb5d0
+ For example, if `CURLOPT_DEFAULT_PROTOCOL` is set to "https". And the
+ URL is "hostname/path". The effective URL would be
+ "HTTPS://hostname/path" instead of "https://hostname/path".
+
+ After this patch, effective URLs would be prefixed with a lower-case
+ protocol name/scheme.
+
+ Closes #597
+
+ Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
-- [Michael Wallner brought this change]
+- [Alessandro Ghedini brought this change]
- CURLOPT_HEADEROPT.3: typo: do -> to
+ scripts: don't generate and install zsh completion when cross-compiling
-- [Marcel Raad brought this change]
+- [Alessandro Ghedini brought this change]
- schannel: use CryptGenRandom for random numbers
+ scripts: fix zsh completion generation
- This function is available for every Windows version since Windows 95/NT.
+ The script should use the just-built curl, not the system one. This fixes
+ zsh completion generation when no system curl is installed.
+
+- [Alessandro Ghedini brought this change]
+
+ zsh.pl: fail if no curl is found
- reference:
- http://msdn.microsoft.com/en-us/library/windows/desktop/aa379942.aspx
+ Instead of generation a broken completion file.
-- curl_version_info.3: 'ssl_version_num' is always 0
+- [Michael Kaufmann brought this change]
+
+ IDN host names: Remove the port number before converting to ACE
- ... and has been so since 2005
+ Closes #596
-- ssl: generalize how the ssl backend identifier is set
+Jay Satiro (10 Jan 2016)
+- runtests: Add mbedTLS to the SSL backends
- Each backend now defines CURL_SSL_BACKEND accordingly. Added the *AXTLS
- one which was missing previously.
+ .. and enable SSLpinning tests for mbedTLS, BoringSSL and LibreSSL.
-Dan Fandrich (31 Jul 2014)
-- axtls: define curlssl_random using axTLS's PRNG
+Daniel Stenberg (10 Jan 2016)
+- [Thomas Glanzmann brought this change]
-- cyassl: fix the test for ASN_NO_SIGNER_E
-
- It's an enum so a macro test won't work. The CyaSSL changelog doesn't
- say exactly when this error code was introduced, but it's likely
- to be 2.7.0.
+ mbedtls: implement CURLOPT_PINNEDPUBLICKEY
-- cyassl: use RNG_GenerateBlock to generate a good random number
+Jay Satiro (9 Jan 2016)
+- [Tatsuhiro Tsujikawa brought this change]
-- opts: fixed some typos
+ url: Fix compile error with --enable-werror
-- smtp: fixed a segfault during test 1320 torture test
-
- Under these circumstances, the connection hasn't been fully established
- and smtp_connect hasn't been called, yet smtp_done still calls the state
- machine which dereferences the NULL conn pointer in struct pingpong.
+- [Tatsuhiro Tsujikawa brought this change]
-Daniel Stenberg (30 Jul 2014)
-- vtls: repair build without TLS support
+ http2: Ensure that http2_handle_stream_close is called
- ... by defining Curl_ssl_random() properly
+ Previously, when HTTP/2 is enabled and used, and stream has content
+ length known, Curl_read was not called when there was no bytes left to
+ read. Because of this, we could not make sure that
+ http2_handle_stream_close was called for every stream. Since we use
+ http2_handle_stream_close to emit trailer fields, they were
+ effectively ignored. This commit changes the code so that Curl_read is
+ called even if no bytes left to read, to ensure that
+ http2_handle_stream_close is called for every stream.
+
+ Discussed in https://github.com/bagder/curl/pull/564
-- polarssl: provide a (weak) random function
+Daniel Stenberg (8 Jan 2016)
+- http2: handle the received SETTINGS frame
+
+ This regression landed in 5778e6f5 and made libcurl not act on received
+ settings and instead stayed with its internal defaults.
- This now provides a weak random function since PolarSSL doesn't have a
- quick and easy way to provide a good one. It does however provide the
- framework to make one so it _can_ and _should_ be done...
+ Bug: http://curl.haxx.se/mail/lib-2016-01/0031.html
+ Reported-by: Bankde
-- [Michael Wallner brought this change]
+- Revert "multiplex: allow only once HTTP/2 is actually used"
+
+ This reverts commit 46cb70e9fa81c9a56de484cdd7c5d9d0d9fbec36.
+
+ Bug: http://curl.haxx.se/mail/lib-2016-01/0031.html
- curl_tlsinfo -> curl_tlssessioninfo
+Jay Satiro (8 Jan 2016)
+- [Tatsuhiro Tsujikawa brought this change]
-- cyassl: use the default (weeker) random
+ http2: Fix PUSH_PROMISE headers being treated as trailers
- I couldn't find any dedicated function in its API to get a "good" random
- with.
+ Discussed in https://github.com/bagder/curl/pull/564
-- cyassl: made it compile with version 2.0.6 again
+Daniel Stenberg (8 Jan 2016)
+- [Michael Kaufmann brought this change]
+
+ connection reuse: IDN host names fixed
+
+ Use the ACE form of IDN hostnames as key in the connection cache. Add
+ new tests.
- ASN_NO_SIGNER_E didn't exist back then!
+ Closes #592
-- vtls: make the random function mandatory in the TLS backend
+- tests: mark IPv6 FTP and FTPS tests with the FTP keyword
+
+Jay Satiro (7 Jan 2016)
+- mbedtls: Fix ALPN support
+
+ - Fix ALPN reply detection.
- To force each backend implementation to really attempt to provide proper
- random. If a proper random function is missing, then we can explicitly
- make use of the default one we use when TLS support is missing.
+ - Wrap nghttp2 code in ifdef USE_NGHTTP2.
- This commit makes sure it works for darwinssl, gnutls, nss and openssl.
+
+ Prior to this change ALPN and HTTP/2 did not work properly in mbedTLS.
-- libcurl.m4: include the standard source header
+- http2: Fix client write for trailers on stream close
+
+ Check that the trailer buffer exists before attempting a client write
+ for trailers on stream close.
- ... with permission from David Shaw
+ Refer to comments in https://github.com/bagder/curl/pull/564
-Kamil Dudka (28 Jul 2014)
-- nss: do not check the version of NSS at run time
+Daniel Stenberg (7 Jan 2016)
+- COPYING: update general copyright year range
+
+- ConnectionExists: add missing newline in infof() call
- The minimal required version of NSS is 3.14.x so it does not make sense
- to check for NSS 3.12.0+ at run time.
+ Mistake from commit a464f33843ee1
-Daniel Stenberg (28 Jul 2014)
-- [Anthon Pang brought this change]
+- multiplex: allow only once HTTP/2 is actually used
+
+ To make sure curl doesn't allow multiplexing before a connection is
+ upgraded to HTTP/2 (like when Upgrade: h2c fails), we must make sure the
+ connection uses HTTP/2 as well and not only check what's wanted.
+
+ Closes #584
+
+ Patch-by: c0ff
- curl.h: bring back CURLE_OBSOLETE16
+Jay Satiro (4 Jan 2016)
+- curl_global_init.3: Add Windows-specific info for init via DLL
- Removing defines, even obsolete ones that haven't been used for a very
- long time, still break a lot of applications.
+ - Add to both curl_global_init.3 and libcurl.3 the caveat for Windows
+ that initializing libcurl via a DLL's DllMain or static initializer
+ could cause a deadlock.
- Bug: https://github.com/bagder/curl/pull/106
+ Bug: https://github.com/bagder/curl/issues/586
+ Reported-by: marc-groundctl@users.noreply.github.com
+
+Daniel Stenberg (4 Jan 2016)
+- FAQ: clarify who to mail about ECCN clarifications
+
+- progressfunc.c: spellfix description
+
+- docs/examples/multi-app.c: fix bad desc formatting
-Dan Fandrich (26 Jul 2014)
-- [Fabian Keil brought this change]
+- examples: added descriptions
- tests: Fix a couple of incomplete response lines
+- example/simple.c: add description
-- [Fabian Keil brought this change]
+- getredirect.c: a new example
- runtests.pl: Remove filteroff() which hasn't been used since 2001
+Marc Hoersken (27 Dec 2015)
+- RELEASE-NOTES: add 5e0e81a9c4e35f04ca
-- [Fabian Keil brought this change]
+Daniel Stenberg (26 Dec 2015)
+- RELEASE-NOTES: synced with 2aec4359db1088b10d
- runtests.pl: Don't expect $TESTDIR/DISABLED to exist
+Marc Hoersken (26 Dec 2015)
+- test 1515: add data check
+
+- test 1515: add MSYS support by passing a relative path
- If a non-standard $TESTDIR is used the file may not be necessary.
+ MSYS would otherwise turn a /-style path into a C:\-style path.
+
+- test 539: use datacheck mode text for ASCII-mode LISTings
- Previously a "missing" file resulted in the warning:
- readline() on closed filehandle D at ./runtests.pl line 4940.
+ While still using datacheck mode binary for the inline reply data.
-- [Fabian Keil brought this change]
+- runtests.pl: check up to 5 data parts with different text modes
+
+ Move the text-mode conversion for reply/replycheck from the verify
+ section into the load section and add support for 4 more check parts.
- getpart.pm: Fix a comment typo
+Daniel Stenberg (24 Dec 2015)
+- CURLOPT_RANGE: for HTTP servers, range support is optional
-Daniel Stenberg (25 Jul 2014)
-- c-ares: fix build without IPv6 support
-
- Bug: http://curl.haxx.se/mail/lib-2014-07/0337.html
- Reported-by: Spork Schivago
+Marc Hoersken (24 Dec 2015)
+- tests 1048 and 1050: use datacheck mode text for ASCII-mode LISTings
-- Curl_base64url_encode: unit-tested in 1302
+- tests 706 and 707: use datacheck mode text for ASCII-mode LISTings
-- base64: added Curl_base64url_encode()
+- tests 400,403,406: use datacheck mode text for ASCII-mode LISTings
+
+- sockfilt.c: fix calculation of sleep timeout on Windows
- This is now used by the http2 code. It has two different symbols at the
- end of the base64 table to make the output "url safe".
+ Not converting to double caused small timeouts to be skipped.
+
+- tests first.c: fix calculation of sleep timeout on Windows
- Bug: https://github.com/tatsuhiro-t/nghttp2/issues/62
+ Not converting to double caused small timeouts to be skipped.
-- [Marcel Raad brought this change]
+- test 573: add more debug output
- SSPI Negotiate: Fix 3 memory leaks
+- ftplistparser.c: fix handling of file LISTings using Windows EOL
+
+ Previously file.txt[CR][LF] would have been returned as file.tx
+ (without the last t) if filetype is symlink. Now the t is
+ included and the internal item_length includes the zero byte.
- Curl_base64_decode allocates the output string by itself and two other
- strings were not freed either.
+ Spotted using test 576 on Windows.
-- symbols: CURL_VERSION_GSSNEGOTIATE is deprecated
+- test 16: fix on Linux (and Windows) by using plain ASCII characters
+
+ Follow up on b064ff0c351bb287557228575ef4c1d079b866fb, thanks Daniel.
+
+- tftpd server: add Windows support by writing files in binary mode
-- test1013.pl: GSS-Negotiate doesn't exist as a feature anymore
+- tests 252-255: use datacheck mode text for ASCII-mode LISTings
-- [Sergey Nikulov brought this change]
+- test 16: fix on Windows by converting data file from ANSI to UTF-8
- libtest: fixed duplicated line in Makefile
+Daniel Stenberg (23 Dec 2015)
+- Makefile.inc: s/curl_SOURCES/CURL_FILES
+
+ This allows the root Makefile.am to include the Makefile.inc without
+ causing automake to warn on it (variables named *_SOURCES are
+ magic). curl_SOURCES is then instead assigned properly in
+ src/Makefile.am only.
- Bug: https://github.com/bagder/curl/pull/105
+ Closes #577
-Patrick Monnerat (23 Jul 2014)
-- GSSAPI: remove useless *_MECHANISM defines.
+- [Anders Bakken brought this change]
-Daniel Stenberg (23 Jul 2014)
-- findprotocol: show unsupported protocol within quotes
+ ConnectionExists: with *PIPEWAIT, wait for connections
- ... to aid when for example prefixed with a space or other weird
- character.
-
-Patrick Monnerat (23 Jul 2014)
-- GSSAPI: private export mechanisms OIDs. OS400: Make RPG binding up to date.
+ Try harder to prevent libcurl from opening up an additional socket when
+ CURLOPT_PIPEWAIT is set. Accomplished by letting ongoing TCP and TLS
+ handshakes complete first before the decision is made.
+
+ Closes #575
-Daniel Stenberg (23 Jul 2014)
-- [Marcel Raad brought this change]
+- [Anders Bakken brought this change]
- conncache: fix compiler warning
-
- warning C4267: '=' : conversion from 'size_t' to 'long', possible loss
- of data
+ Add .dir-locals and set c-basic-offset to 2.
- The member connection_id of struct connectdata is a long (always a
- 32-bit signed integer on Visual C++) and the member next_connection_id
- of struct conncache is a size_t, so one of them should be changed to
- match the other.
+ This makes it easier for emacs users to automatically get the right
+ 2-space indentation when they edit curl source files.
- This patch the size_t in struct conncache to long (the less invasive
- change as that variable is only ever used in a single code line).
+ c++-mode is in there as well because Emacs can't easily know if
+ something is a C or C++ header.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1399
+ Closes #574
-- RELEASE-NOTES: synced with 81cd24adb8b
+- [Johannes Schindelin brought this change]
-- http2: more and better error checking
+ configure: detect IPv6 support on Windows
- 1 - fixes the warnings when built without http2 support
+ This patch was "nicked" from the MINGW-packages project by Daniel.
- 2 - adds CURLE_HTTP2, a new error code for errors detected by nghttp2
- basically when they are about http2 specific things.
+ https://github.com/Alexpux/MINGW-packages/commit/9253d0bf58a1486e91f7efb5316e7fdb48fa4007
+ Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-Dan Fandrich (23 Jul 2014)
-- cyassl.c: return the correct error code on no CA cert
+- configure: allow static builds on mingw
- CyaSSL 3.0.0 returns a unique error code if no CA cert is available,
- so translate that into CURLE_SSL_CACERT_BADFILE when peer verification
- is requested.
+ This patch is adopted from the MINGW-packages project. It makes it
+ possible to build curl both shared and static again.
+
+ URL: https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-curl
-Daniel Stenberg (23 Jul 2014)
-- symbols-in-versions: new SPNEGO/GSS-API symbols in 7.38.0
+Marc Hoersken (17 Dec 2015)
+- test 1326: fix file check since curl is outputting binary data
-- test1013.pl: remove SPNEGO/GSS-API tweaks
+- test 1326: fix getting stuck on Windows due to incomplete request
- No longer necessary after Michael Osipov's rework
+ The request needs to be read and send in binary mode in order to use
+ CRLF instead of LF. Adding --upload-file - causes curl to read stdin
+ in binary mode.
-- http_negotiate: remove unused variable
+Daniel Stenberg (17 Dec 2015)
+- RELEASE-NOTES: command line option recount
-- [Michael Osipov brought this change]
+Dan Fandrich (16 Dec 2015)
+- scripts/Makefile: build zsh script even in an out-of-tree build
- docs: Improve inline GSS-API naming in code documentation
+Marc Hoersken (16 Dec 2015)
+- sockfilt.c: added some debug output to select_ws
-- [Michael Osipov brought this change]
+- sockfilt.c: keep lines shorter than 80 chars
- curl.h/features: Deprecate GSS-Negotiate macros due to bad naming
+- sockfilt.c: do not wait on unreliable file or pipe handle
- - Replace CURLAUTH_GSSNEGOTIATE with CURLAUTH_NEGOTIATE
- - CURL_VERSION_GSSNEGOTIATE is deprecated which
- is served by CURL_VERSION_SSPI, CURL_VERSION_GSSAPI and
- CURUL_VERSION_SPNEGO now.
- - Remove display of feature 'GSS-Negotiate'
+ The previous implementation caused issues on modern MSYS2 runtimes.
-- [Michael Osipov brought this change]
+Daniel Stenberg (16 Dec 2015)
+- cyassl: deal with lack of *get_peer_certificate
+
+ The function is only present in wolfssl/cyassl if it was built with
+ --enable-opensslextra. With these checks added, pinning support is disabled
+ unless the TLS lib has that function available.
+
+ Also fix the mistake in configure that checks for the wrong lib name.
+
+ Closes #566
- configure/features: Add feature and version info for GSS-API and SPNEGO
+- wolfssl: handle builds without SSLv3 support
-- [Michael Osipov brought this change]
+- [Tatsuhiro Tsujikawa brought this change]
- HTTP: Remove checkprefix("GSS-Negotiate")
+ http2: Support trailer fields
+
+ This commit adds trailer support in HTTP/2. In HTTP/1.1, chunked
+ encoding must be used to send trialer fields. HTTP/2 deprecated any
+ trandfer-encoding, including chunked. But trailer fields are now
+ always available.
+
+ Since trailer fields are relatively rare these days (gRPC uses them
+ extensively though), allocating buffer for trailer fields is done when
+ we detect that HEADERS frame containing trailer fields is started. We
+ use Curl_add_buffer_* functions to buffer all trailers, just like we
+ do for regular header fields. And then deliver them when stream is
+ closed. We have to be careful here so that all data are delivered to
+ upper layer before sending trailers to the application.
- That auth mech has never existed neither on MS nor on Unix side.
- There is only Negotiate over SPNEGO.
+ We can deliver trailer field one by one using NGHTTP2_ERR_PAUSE
+ mechanism, but current method is far more simple.
+
+ Another possibility is use chunked encoding internally for HTTP/2
+ traffic. I have not tested it, but it could add another overhead.
+
+ Closes #564
-- [Michael Osipov brought this change]
+- RELEASE-NOTES: synced with 6c2c019654e658a
- curl_gssapi: Add macros for common mechs and pass them appropriately
+Jay Satiro (15 Dec 2015)
+- x509asn1: Fix host altname verification
- Macros defined: KRB5_MECHANISM and SPNEGO_MECHANISM called from
- HTTP, FTP and SOCKS on Unix
-
-- CONNECT: Revert Curl_proxyCONNECT back to 7.29.0 design
+ - In Curl_verifyhost check all altnames in the certificate.
- This reverts commit cb3e6dfa3511 and instead fixes the problem
- differently.
+ Prior to this change only the first altname was checked. Only the GSKit
+ SSL backend was affected by this bug.
- The reverted commit addressed a test failure in test 1021 by simplifying
- and generalizing the code flow in a way that damaged the
- performance. Now we modify the flow so that Curl_proxyCONNECT() again
- does as much as possible in one go, yet still do test 1021 with and
- without valgrind. It failed due to mistakes in the multi state machine.
+ Bug: http://curl.haxx.se/mail/lib-2015-12/0062.html
+ Reported-by: John Kohl
+
+Daniel Stenberg (15 Dec 2015)
+- curl --expect100-timeout: added
- Bug: http://curl.haxx.se/bug/view.cgi?id=1397
- Reported-by: Paul Saab
+ This is the new command line option to set the value for the existing
+ libcurl option CURLOPT_EXPECT_100_TIMEOUT_MS
-- [Marcel Raad brought this change]
+- cyassl: fix compiler warning on type conversion
- url.c: use the preferred symbol name: *READDATA
-
- with CURL_NO_OLDIES defined, it doesn't compile because this deprecated
- symbol (*INFILE) is used
+- curlver: the pending release will become 7.47.0
+
+- [Anders Bakken brought this change]
+
+ setstropt: const-correctness
- Bug: http://curl.haxx.se/bug/view.cgi?id=1398
+ Closes #565
-Dan Fandrich (19 Jul 2014)
-- [Alessandro Ghedini brought this change]
+- ROADMAP: implemented HTTP2 for HTTPS-only
- CURLOPT_CHUNK_BGN_FUNCTION: fix typo
+- HTTP2.md: spell fix and remove TODO now implemented
-Kamil Dudka (18 Jul 2014)
-- [Alessandro Ghedini brought this change]
+- libressl: the latest openssl x509 funcs are not in libressl
- build: link curl to NSS libraries when NSS support is enabled
+- curl: use 2TLS by default
- This fixes a build failure on Debian caused by commit
- 24c3cdce88f39731506c287cb276e8bf4a1ce393.
+ Make this the default for the curl tool (if built with HTTP/2 powers
+ enabled) unless a specific HTTP version is requested on the command
+ line.
- Bug: http://curl.haxx.se/mail/lib-2014-07/0209.html
+ This should allow more users to get HTTP/2 powers without having to
+ change anything.
-Steve Holme (17 Jul 2014)
-- build: Removed unnecessary XML Documentation file directive from VC8 to VC12
+- http: add libcurl option to allow HTTP/2 for HTTPS only
- The curl tool project files for VC8 to VC12 would set this setting to
- $(IntDir) which is the Visual Studio default value. To avoid confusion
- when viewing settings from within Visual Studio and for consistency
- with the libcurl project files removed this setting.
+ ... and stick to 1.1 for HTTP. This is in line with what browsers do and
+ should have very little risk.
+
+- openssl: adapt to openssl >= 1.1.0 X509 opaque structs
- Conflicts:
- projects/Windows/VC10/src/curlsrc.tmpl
- projects/Windows/VC11/src/curlsrc.tmpl
- projects/Windows/VC12/src/curlsrc.tmpl
- projects/Windows/VC8/src/curlsrc.tmpl
- projects/Windows/VC9/src/curlsrc.tmpl
+ Closes #491
+
+- openssl: avoid BIO_reset() warnings since it returns a value
+
+- openssl: adapt to 1.1.0+ name changes
+
+- scripts/makefile: add standard header
-- build: Removed unnecessary Precompiled Header file directive in VC7 to VC12
+- scripts/Makefile: fix GNUism and survive no perl
- The curl tool project files for VC7 to VC12 would set this settings to
- $(IntDir)$(TargetName).pch which is the Visual Studio default value. To
- avoid confusion when viewing settings from within Visual Studio and for
- consistency with the libcurl project files removed this setting.
+ Closes #555
- Conflicts:
- projects/Windows/VC10/src/curlsrc.tmpl
- projects/Windows/VC11/src/curlsrc.tmpl
- projects/Windows/VC12/src/curlsrc.tmpl
- projects/Windows/VC8/src/curlsrc.tmpl
- projects/Windows/VC9/src/curlsrc.tmpl
+ Reported-by: Thomas Klausner
-- build: Removed unnecessary ASM and Object file directives in VC7 to VC12
-
- The curl tool project files for VC7 to VC12 would set these settings to
- $(IntDir) which is the Visual Studio default value. To avoid confusion
- when viewing settings from within Visual Studio and for consistency
- with the libcurl project files removed these two settings.
+- fix b6d5cb40d7038fe
-Daniel Stenberg (17 Jul 2014)
-- [Dave Reisner brought this change]
+- [Tatsuhiro Tsujikawa brought this change]
- src/Makefile.am: add .DELETE_ON_ERROR
+ http2: Fix hanging paused stream
- This prevents targets like tool_hugehelp.c from leaving around
- half-constructed files if the rule fails with GNU make.
+ When NGHTTP2_ERR_PAUSE is returned from data_source_read_callback, we
+ might not process DATA frame fully. Calling nghttp2_session_mem_recv()
+ again will continue to process DATA frame, but if there is no incoming
+ frames, then we have to call it again with 0-length data. Without this,
+ on_stream_close callback will not be called, and stream could be hanged.
- Reported-by: Rafaël Carré <funman@videolan.org>
+ Bug: http://curl.haxx.se/mail/lib-2015-11/0103.html
+ Reported-by: Francisco Moraes
-- THANKS: added new contributors from 7.37.1 announcement
+- [Christian Stewart brought this change]
-Dan Fandrich (17 Jul 2014)
-- testcurl.pl: log the value of --runtestopts in the test header
+ build: fix compilation error with CURL_DISABLE_VERBOSE_STRINGS
+
+ With curl disable verbose strings in http.c the compilation fails due to
+ the data variable being undefined later on in the function.
+
+ Closes #558
-Daniel Stenberg (16 Jul 2014)
-- RELEASE-NOTES: cleared, working towards next release
+Jay Satiro (7 Dec 2015)
+- [Gisle Vanem brought this change]
-- curl_gssapi.c: make line shorter than 80 columns
+ config-win32: Fix warning HAVE_WINSOCK2_H undefined
-- [David Woodhouse brought this change]
+- [Gisle Vanem brought this change]
- Fix negotiate auth to proxies to track correct state
+ openssl: BoringSSL doesn't have CONF_modules_free
-- [David Woodhouse brought this change]
+- [Gisle Vanem brought this change]
- Don't abort Negotiate auth when the server has a response for us
+ lwip: Fix compatibility issues with later versions
- It's wrong to assume that we can send a single SPNEGO packet which will
- complete the authentication. It's a *negotiation* — the clue is in the
- name. So make sure we handle responses from the server.
+ The name of the header guard in lwIP's <lwip/opt.h> has changed from
+ '__LWIP_OPT_H__' to 'LWIP_HDR_OPT_H' (bug #35874 in May 2015).
- Curl_input_negotiate() will already handle bailing out if it thinks the
- state is GSS_S_COMPLETE (or SEC_E_OK on Windows) and the server keeps
- talking to us, so we should avoid endless loops that way.
-
-- [David Woodhouse brought this change]
-
- Don't clear GSSAPI state between each exchange in the negotiation
+ Other fixes:
- GSSAPI doesn't work very well if we forget everything ever time.
+ - In curl_setup.h, the problem with an old PSDK doesn't apply if lwIP is
+ used.
- XX: Is Curl_http_done() the right place to do the final cleanup?
-
-- [David Woodhouse brought this change]
-
- Use SPNEGO for HTTP Negotiate
+ - In memdebug.h, the 'socket' should be undefined first due to lwIP's
+ lwip_socket() macro.
- This is the correct way to do SPNEGO. Just ask for it
+ - In curl_addrinfo.c lwIP's getaddrinfo() + freeaddrinfo() macros need
+ special handling because they were undef'ed in memdebug.h.
- Now I correctly see it trying NTLMSSP authentication when a Kerberos ticket
- isn't available. Of course, we bail out when the server responds with the
- challenge packet, since we don't expect that. But I'll fix that bug next...
+ - In select.c we can't use preprocessor conditionals inside select if
+ MSVC and select is a macro, as it is with lwIP.
+
+ http://curl.haxx.se/mail/lib-2015-12/0023.html
+ http://curl.haxx.se/mail/lib-2015-12/0024.html
-- [David Woodhouse brought this change]
+Patrick Monnerat (7 Dec 2015)
+- os400: define CURL_VERSION_PSL in ILE/RPG binding
- Remove all traces of FBOpenSSL SPNEGO support
-
- This is just fundamentally broken. SPNEGO (RFC4178) is a protocol which
- allows client and server to negotiate the underlying mechanism which will
- actually be used to authenticate. This is *often* Kerberos, and can also
- be NTLM and other things. And to complicate matters, there are various
- different OIDs which can be used to specify the Kerberos mechanism too.
-
- A SPNEGO exchange will identify *which* GSSAPI mechanism is being used,
- and will exchange GSSAPI tokens which are appropriate for that mechanism.
+Jay Satiro (7 Dec 2015)
+- [Gisle Vanem brought this change]
+
+ version: Add flag CURL_VERSION_PSL for libpsl
+
+- formdata: Check if length is too large for memory
- But this SPNEGO implementation just strips the incoming SPNEGO packet
- and extracts the token, if any. And completely discards the information
- about *which* mechanism is being used. Then we *assume* it was Kerberos,
- and feed the token into gss_init_sec_context() with the default
- mechanism (GSS_S_NO_OID for the mech_type argument).
+ - If the size of the length type (curl_off_t) is greater than the size
+ of the size_t type then check before allocating memory to make sure the
+ value of length will fit in a size_t without overflow. If it doesn't
+ then return CURLE_BAD_FUNCTION_ARGUMENT.
- Furthermore... broken as this code is, it was never even *used* for input
- tokens anyway, because higher layers of curl would just bail out if the
- server actually said anything *back* to us in the negotiation. We assume
- that we send a single token to the server, and it accepts it. If the server
- wants to continue the exchange (as is required for NTLM and for SPNEGO
- to do anything useful), then curl was broken anyway.
+ Bug: https://github.com/bagder/curl/issues/425#issuecomment-154518679
+ Reported-by: Steve Holme
+
+Steve Holme (3 Dec 2015)
+- tests: Corrected copy and pasted comments from commit e643c5c908
+
+Daniel Stenberg (3 Dec 2015)
+- curl: remove keepalive #ifdef checks done on libcurl's behalf
- So the only bit which actually did anything was the bit in
- Curl_output_negotiate(), which always generates an *initial* SPNEGO
- token saying "Hey, I support only the Kerberos mechanism and this is its
- token".
+ They didn't match the ifdef logic used within libcurl anyway so they
+ could indeed warn for the wrong case - plus the tool cannot know how the
+ lib actually performs at that level.
+
+Steve Holme (2 Dec 2015)
+- test947: Corrected typo in test name
+
+- tests: Disable the OAUTHBEARER tests when using a non-default port number
- You could have done that by manually just prefixing the Kerberos token
- with the appropriate bytes, if you weren't going to do any proper SPNEGO
- handling. There's no need for the FBOpenSSL library at all.
+ Tests 842, 843, 844, 845, 887, 888, 889, 890, 946, 947, 948 and 949 fail
+ if a custom port number is specified via the -b option of runtests.pl.
- The sane way to do SPNEGO is just to *ask* the GSSAPI library to do
- SPNEGO. That's what the 'mech_type' argument to gss_init_sec_context()
- is for. And then it should all Just Work™.
+ Suggested by: Kamil Dudka
+ Bug: http://curl.haxx.se/mail/lib-2015-12/0003.html
+
+Daniel Stenberg (2 Dec 2015)
+- bump: towards next release
- That 'sane way' will be added in a subsequent patch, as will bug fixes
- for our failure to handle any exchange other than a single outbound
- token to the server which results in immediate success.
+ for all we know now, it might be called 7.46.1
-- [David Woodhouse brought this change]
+Version 7.46.0 (1 Dec 2015)
- ntlm_wb: Avoid invoking ntlm_auth helper with empty username
+Daniel Stenberg (1 Dec 2015)
+- RELEASE-NOTES: updated contributor count for 7.46.0
-- [David Woodhouse brought this change]
+- THANKS: new contributors from the 7.46.0 release
- ntlm_wb: Fix hard-coded limit on NTLM auth packet size
-
- Bumping it to 1KiB in commit aaaf9e50ec is all very well, but having hit
- a hard limit once let's just make it cope by reallocating as necessary.
+- THANKS-filter: single Tim Rühsen spelling
+
+- docs/examples: gitignore some more built examples
-Version 7.37.1 (16 Jul 2014)
+- RELEASE-NOTES; this bug was never released
-Daniel Stenberg (16 Jul 2014)
-- RELEASE-NOTES: synced with 4cb2521595
+- RELEASE-NOTES: synced with e55f15454efacb0
-- test506: verify aa6884845168
+- [Flavio Medeiros brought this change]
+
+ Curl_read_plain: clean up ifdefs that break statements
- After the fixed cookie lock deadlock, this test now passes and it
- detects double-locking and double-unlocking of mutexes.
+ Closes #546
-- [Yousuke Kimoto brought this change]
+- http2: convert some verbose output into debug-only output
- cookie: avoid mutex deadlock
+- http2 push: add missing inits of new stream
- ... by removing the extra mutex locks around th call to
- Curl_flush_cookies() which takes care of the locking itself already.
+ - set the correct stream_id for pushed streams
+ - init maxdownload and size properly
+
+- http2 push: set weight for new stream
- Bug: http://curl.haxx.se/mail/lib-2014-02/0184.html
+ give the new stream the old one's stream_weight internally to avoid
+ sending a PRIORITY frame unless asked for it
-- gnutls: fix compiler warning
+- curl_setup.h: undef freeaddrinfo in c-ares block to fix build
- conversion to 'int' from 'long int' may alter its value
+ Fixes warnings 78c25c854a added.
-Dan Fandrich (15 Jul 2014)
-- test320: strip off the actual negotiated cipher width
+- nonblock: fix setting non-blocking mode for Amiga
- It's irrelevant to the test, and will change depending on which SSL
- library is being used by libcurl.
+ IoctlSocket() apparently wants a pointer to a long, passed as a char *
+ in its third parameter. This bug was introduced already back in commit
+ c5fdeef41d from October 1 2001!
+
+ Bug: http://curl.haxx.se/mail/lib-2015-11/0088.html
+ Reported-by: Norbert Kett
-- gnutls: detect lack of SRP support in GnuTLS at run-time and try without
+- zsh install: fix DESTDIR support
- Reported-by: David Woodhouse
+ Reported-by: Mohammad AlSaleh
-Daniel Stenberg (14 Jul 2014)
-- [Michał Górny brought this change]
+Dan Fandrich (27 Nov 2015)
+- lib: Only define curl_dofreeaddrinfo if struct addrinfo is available
- configure: respect host tool prefix for krb5-config
+Steve Holme (27 Nov 2015)
+- tool_paramhlp: Fixed display of URL index in password prompt for --next
- Use ${host_alias}-krb5-config if available. This improves cross-
- compilation support and fixes multilib on Gentoo (at least).
+ Commit f3bae6ed73 added the URL index to the password prompt when using
+ --next. Unfortunately, because the size_t specifier (%zu) is not
+ supported by all sprintf() implementations we use the curl_off_t format
+ specifier instead. The display of an incorrect value arises on platforms
+ where size_t and curl_off_t are of a different size.
-- [David Woodhouse brought this change]
+Daniel Stenberg (25 Nov 2015)
+- timecond: do not add if-modified-since without timecondition
+
+ The RTSP code path didn't skip adding the if-modified-since for certain
+ RTSP code paths, even if CURLOPT_TIMECONDITION was set to
+ CURL_TIMECOND_NONE.
+
+ Also, an unknown non-zero CURLOPT_TIMECONDITION value no longer equals
+ CURL_TIMECOND_IFMODSINCE.
+
+ Bug: http://stackoverflow.com/questions/33903982/curl-timecond-none-doesnt-work-how-to-remove-if-modified-since-header
+
+- RELEASE-NOTES: synced with 99d17a5e2ba77e58
- gnutls: handle IP address in cert name check
+- examples/README: cut out the incomplete list
- Before GnuTLS 3.3.6, the gnutls_x509_crt_check_hostname() function
- didn't actually check IP addresses in SubjectAltName, even though it was
- explicitly documented as doing so. So do it ourselves...
+ ... and add a generic explanation for them instead. Each example file
+ should contain its own description these days.
-Dan Fandrich (14 Jul 2014)
-- build: set _POSIX_PTHREAD_SEMANTICS on Solaris to get proper getpwuid_r
+- test1513: make sure the callback is only called once
-Daniel Stenberg (14 Jul 2014)
-- RELEASE-NOTES: next one is called 7.37.1
+- [Daniel Shahaf brought this change]
-Dan Fandrich (13 Jul 2014)
-- gnutls: improved error message if setting cipher list fails
+ build: Install zsh completion
- Reported-by: David Woodhouse
+ Fixes #534
+ Closes #537
-- netrc: fixed thread safety problem by using getpwuid_r if available
+- done: make sure the final progress update is made
- The old way using getpwuid could cause problems in programs that enable
- reading from netrc files simultaneously in multiple threads.
+ It would previously be skipped if an existing error was returned, but
+ would lead to a previous value being left there and later used.
+ CURLINFO_TOTAL_TIME for example.
- Reported-by: David Woodhouse
-
-- RELEASE-NOTES: add the reporter of the previous bug fix
-
-- netrc: treat failure to find home dir same as missing netrc file
+ Still it avoids that final progress update if we reached DONE as the
+ result of a callback abort to avoid another callback to be called after
+ an abort-by-callback.
- This previously caused a fatal error (with a confusing error code, at
- that).
+ Reported-by: Lukas Ruzicka
- Reported by: Glen A Johnson Jr.
+ Closes #538
-Steve Holme (12 Jul 2014)
-- RELEASE-NOTES: Synced with aaaf9e50ec
+- curl: expanded the -XHEAD warning text
+
+ ... to also mention the specific options used.
-- ntlm_wb: Fixed buffer size not being large enough for NTLMv2 sessions
+- Revert "cleanup: general removal of TODO (and similar) comments"
+
+ This reverts commit 64e959ffe37c436503f9fed1ce2d6ee6ae50bd9a.
- Bug: http://curl.haxx.se/mail/lib-2014-07/0103.html
- Reported-by: David Woodhouse
+ Feedback-by: Dan Fandrich
+ URL: http://curl.haxx.se/mail/lib-2015-11/0062.html
-- build: Fixed overridden compiler PDB settings in VC7 to VC12
+- CURLOPT_HEADERFUNCTION.3: fix typo
- The curl tool project files for VC7 to VC12 would override the default
- setting with the output filename being the same as the linker PDB file.
- As such the compiler file would be overwritten with the linker file
- for all debug builds.
+ Refer to _HEADERDATA not _WRITEDATA.
- To avoid this overwrite and for consistency with the libcurl project
- files, removed the setting to force the default filename to be used.
+ Reported-by: Michał Piechowski
-Dan Fandrich (12 Jul 2014)
-- tests: added globbing keyword to URL globbing tests
+- TODO: TCP Fast Open
-- Fixed some "statement not reached" warnings
+Steve Holme (22 Nov 2015)
+- examples: Added website parse-able descriptions to the e-mail examples
-- gnutls: fixed a couple of uninitialized variable references
+- TODO: Added another 'multi-interface' idea
-- gnutls: fixed compilation against versions < 2.12.0
+- smb.c: Fixed compilation warnings
- The AES-GCM ciphers were added to GnuTLS as late as ver. 3.0.1 but
- the code path in which they're referenced here is only ever used for
- somewhat older GnuTLS versions. This caused undeclared identifier errors
- when compiling against those.
+ smb.c:134:3: warning: conversion to 'short unsigned int' from 'int' may
+ alter its value
+ smb.c:146:42: warning: conversion to 'unsigned int' from 'long long
+ unsigned int' may alter its value
+ smb.c:146:65: warning: conversion to 'unsigned int' from 'long long
+ unsigned int' may alter its value
+
+- schannel: Corrected copy/paste error in commit 8d17117683
-- gnutls: explicitly added SRP to the priority string
+- schannel: Use GetVersionEx() when VerifyVersionInfo() isn't available
- This seems to have become necessary for SRP support to work starting
- with GnuTLS ver. 2.99.0. Since support for SRP was added to GnuTLS
- before the function that takes this priority string, there should be no
- issue with backward compatibility.
+ Regression from commit 7a8e861a5 as highlighted in the msys autobuilds.
-- tests: adjust for capitalization differences in newer gnutls-serv
+- examples: Fixed compilation warnings
+
+ pop3-multi.c:96:5: warning: implicit declaration of function 'memset'
+ imap-multi.c:96:5: warning: implicit declaration of function 'memset'
+ http2-download.c:226:5: warning: implicit declaration of function 'memset'
+ http2-upload.c:290:5: warning: implicit declaration of function 'memset'
+ http2-upload.c:290:5: warning: implicit declaration of function 'memset'
-- test320/1/2/4: fix the port number substitution variables
+- Makefile.inc: Fixed test run error
- These tests have been broken since commit 1958fe57 in Oct. 2011
+ test845 not present in tests/data/Makefile.inc
-- tests: document more test identifiers and variables
+Daniel Stenberg (20 Nov 2015)
+- TODO: remove duplicated title
-- gnutls: ignore invalid certificate dates with VERIFYPEER disabled
+- TODO: added two more libcurl ideas
- This makes the behaviour consistent with what happens if a date can
- be extracted from the certificate but is expired.
+ Moved some ideas from "next major" to just ordinary ideas since we can
+ always add new things while keeping the old without doing a "next
+ major".
-Steve Holme (10 Jul 2014)
-- CURLOPT_UPLOAD: Corrected argument type
+Steve Holme (20 Nov 2015)
+- tests: Re-enabled tests 889 and 890 following POP3 fix
-Daniel Stenberg (9 Jul 2014)
-- FAQ: expand the thread-safe section
-
- ... with a mention of *NOSIGNAL, based on talk in bug #1386
+- pop3: Differentiate between success and continuation responses
-Dan Fandrich (9 Jul 2014)
-- url.c: Fixed memory leak on OOM
+- pop3: Added clarity on some server response codes
+
+Daniel Stenberg (20 Nov 2015)
+- [Daniel Shahaf brought this change]
+
+ build: Fix theoretical infinite loops
- This showed itself on some systems with torture failures
- in tests 1060 and 1061
+ Add error-checking to 'cd' in a few cases where omitting the checks
+ might result in an infinite loop.
+
+ Closes #535
-- Update instances of some obsolete CURLOPTs to their new names
+Patrick Monnerat (19 Nov 2015)
+- curl.h: s/#defien/#define/
-Daniel Stenberg (5 Jul 2014)
-- [Marcel Raad brought this change]
+- os400: synchronize ILE/RPG header file
- compiler warnings: potentially uninitialized variables
+- os400: Provide options for libssh2 use in compile scripts. Adjust README.
+
+Daniel Stenberg (19 Nov 2015)
+- [danielsh@apache.org brought this change]
+
+ zsh completion: Preserve single quotes in output
- ... pointed out by MSVC2013
+ When an option's help string contains literal single quotes, those
+ single quotes would be stripped from the option's description in the
+ completion output (unless the zsh RC_QUOTES option were set while the
+ completion function was being sourced, which is not the default). This
+ patch makes the completion output contain single quotes where the --help
+ output does.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1391
+ Closes #532
-Kamil Dudka (4 Jul 2014)
-- nss: make the list of CRL items global
-
- Otherwise NSS could use an already freed item for another connection.
+Jay Satiro (18 Nov 2015)
+- [MaxGiting brought this change]
-- nss: fix a memory leak when CURLOPT_CRLFILE is used
+ FAQ: Grammar changes
+
+ Closes https://github.com/bagder/curl/pull/533
-- nss: make crl_der allocated on heap
+Daniel Stenberg (17 Nov 2015)
+- http2: http_done: don't free already-freed push headers
- ... and spell it as crl_der instead of crlDER
+ The push headers are freed after the push callback has been invoked,
+ meaning this code should only free the headers if the callback was never
+ invoked and thus the headers weren't freed at that time.
+
+ Reported-by: Davey Shafik
-- nss: let nss_{cache,load}_crl return CURLcode
+- [Anders Bakken brought this change]
-- tool: oops, forgot to include <plarenas.h>
+ getconnectinfo: Don't call recv(2) if socket == -1
- ... that contains the declaration of PL_ArenaFinish()
+ Closes #528
-- tool: call PL_ArenaFinish() on exit if NSPR is used
-
- This prevents valgrind from reporting still reachable memory allocated
- by NSPR arenas (mainly the freelist).
+- CURLMOPT_PUSHFUNCTION.3: *_byname() returns only the first header
- Reported-by: Hubert Kario
+ ... if there are more than one using the same name
-Daniel Stenberg (3 Jul 2014)
-- [Dimitrios Siganos brought this change]
+- http2: minor comment typo
- example: use correct type (long) for CURLOPT_FOLLOWLOCATION
+- sasl; fix checksrc warnings
-- [Dimitrios Siganos brought this change]
+Steve Holme (15 Nov 2015)
+- RELEASE-NOTES: Adjusted for the recent OAuth 2.0 activity
- Document type of argument for CURLOPT_FOLLOWLOCATION.
+- tests: Disabled 889 and 890 until we support POP3 continuation responses
+
+ As POP3 final and continuation responses both begin with a + character,
+ and both the finalcode and contcode variables in SASLprotoc are set as
+ such, we cannot tell the difference between them when we are expecting
+ an optional continuation from the server such as the following:
+
+ + something else from the server
+ +OK final response
+
+ Disabled these tests until such a time we can tell the responses apart.
-- [Dimitrios Siganos brought this change]
+- tests: Corrected typos from commit ba4d8f7eba
- Document type of argument for CURLOPT_ERRORBUFFER.
+- tests: Added OAUTHBEARER failure response tests
-- [Dimitrios Siganos brought this change]
+- oauth2: Support OAUTHBEARER failures sent as continuation responses
+
+ According to RFC7628 a failure message may be sent by the server in a
+ base64 encoded JSON string as a continuation response.
+
+ Currently only implemented for OAUTHBEARER and not XAUTH2.
- Document type of argument for CURLOPT_COPYPOSTFIELDS.
+Daniel Stenberg (15 Nov 2015)
+- RELEASE-NOTES: synced with 808a17ee675
-- [Dimitrios Siganos brought this change]
+Steve Holme (14 Nov 2015)
+- tests: Renamed existing OAuth 2.0 (XOAUTH) tests
- Document type of argument for CURLOPT_ADDRESS_SCOPE.
+- tests: Added OAuth 2.0 (OAUTHBEARER) tests
-- curl.1: minor language fix
+- oauth2: Added support for OAUTHBEARER SASL mechanism to IMAP, POP3 and SNMP
- Bug: http://curl.haxx.se/mail/archive-2014-07/0006.html
+ OAUTHBEARER is now the official "registered" SASL mechanism name for
+ OAuth 2.0. However, we don't want to drop support for XOAUTH2 as some
+ servers won't support the new mechanism yet.
-- [Ray Satiro brought this change]
+Daniel Stenberg (13 Nov 2015)
+- RELEASE-NOTES: recounted curl_easy_setopt() options
- progress callback: skip last callback update on errors
+- typecheck-gcc.h: add missing slist-using options
- When an error has been detected, skip the final forced call to the
- progress callback by making sure to pass the current return code
- variable in the Curl_done() call in the CURLM_STATE_DONE state.
+ CURLOPT_RESOLVE and CURLOPT_PROXYHEADER were missing
- This avoids the "extra" callback that could occur even if you returned
- error from the progress callback.
+ Also sorted the list.
+
+- typecheck-gcc.h: added CURLOPT_CLOSESOCKETDATA
- Bug: http://curl.haxx.se/mail/lib-2014-06/0062.html
- Reported by: Jonathan Cardoso Machado
+ ... and sorted curl_is_cb_data_option alphabetically
-Dan Fandrich (2 Jul 2014)
-- opts: fixed some CURLOPT references so they get turned into links
+Jay Satiro (13 Nov 2015)
+- [Sebastian Pohlschmidt brought this change]
-Kamil Dudka (2 Jul 2014)
-- tool: call PR_Cleanup() on exit if NSPR is used
+ openssl: Free modules on cleanup
- This prevents valgrind from reporting possibly lost memory that NSPR
- uses for file descriptor cache and other globally allocated internal
- data structures.
-
-- nss: make the fallback to SSLv3 work again
+ Curl_ossl_init calls OPENSSL_load_builtin_modules() but
+ Curl_ossl_cleanup doesn't make a call to free these modules.
- This feature was unintentionally disabled by commit ff92fcfb.
+ Bug: https://github.com/bagder/curl/issues/526
-- nss: do not abort on connection failure
+Steve Holme (13 Nov 2015)
+- symbols-in-versions: Added new CURLOPTTYPE_STRINGPOINT alias
- ... due to calling SSL_VersionRangeGet() with NULL file descriptor
+ ...following commit aba281e762 to fix test 1119.
+
+Daniel Stenberg (13 Nov 2015)
+- curl: mark two more options strings for --libcurl output
+
+- typecheck-gcc.h: add some missing string types
- reported-by: upstream tests 305 and 404
+ Also sorted that list alphabetically
-Dan Fandrich (1 Jul 2014)
-- opts: Document the socket callback function parameters
+- curl.h: introducing the STRINGPOINT alias
+
+ As an alias for OBJECTPOINT. Provided to allow us to grep for all string
+ options easier.
-Steve Holme (28 Jun 2014)
-- opts: Fixed some typos
+- cleanup: general removal of TODO (and similar) comments
+
+ They tend to never get updated anyway so they're frequently inaccurate
+ and we never go back to revisit them anyway. We document issues to work
+ on properly in KNOWN_BUGS and TODO instead.
-Dan Fandrich (25 Jun 2014)
-- curl_easy_setopt.3: fixed the error code for an unsupported option
+- ftplistparser: remove empty function
-- opts: added some DEFAULT and RETURN VALUE sections
+- openssl: remove #if check for 0.9.7 for ENGINE_load_private_key
-Daniel Stenberg (21 Jun 2014)
-- libcurl docs: man page edits
+- openssl: all supported versions have X509_STORE_set_flags
- mainly to improve how the web versions render
+ Simplify by removing #ifdefs and macros
-Dan Fandrich (21 Jun 2014)
-- curl_easy_setopt.3: fixed some typos
+- openssl: remove 0.9.3 check
-Daniel Stenberg (21 Jun 2014)
-- lib man pages: update easy setopt option references
+- openssl: remove #ifdefs for < 0.9.5 support
- ... by using the "\fIopt(3)\fP" syntax they will be linked properly when
- the web version of the page is generated.
+ We only support >= 0.9.7
-- opts: the CURLOPT_SSL_ENABLE_*PN options are enabled by default
+- lib/vtls/openssl: remove unused traces of yassl ifdefs
-- [Colin Hogben brought this change]
+Dan Fandrich (12 Nov 2015)
+- [dfandrich brought this change]
- lib: documentation updates in README.hostip
+ unit1603: Demote hash mismatch failure to a warning
- c-ares now does support IPv6;
- avoid implying threaded resolver is Windows-only;
- two referenced source files were renamed in 7de2f92
+ The hashes can vary between architectures (e.g. Sparc differs from x86_64).
+ This is not a fatal problem but just reduces the coverage of these white-box
+ tests, as the assumptions about into which hash bucket each key falls are no
+ longer valid.
-- curl_easy_setopt.3: CURLOPT_POSTFIELDS is the exception
-
- ... to the always-copy-char *-argument.
-
- And fix some minor mistakes.
+- [dfandrich brought this change]
-- curl_easy_setopt.3: refer to the individual man pages
-
- With all the new individual option man pages created, this now refers to
- each separate one instead of duplicaing the info. Also makes this page
- easier to overview.
+ unit1603: Added unit tests for hash functions
-Dan Fandrich (21 Jun 2014)
-- opts: fixed mancheck for out-of-tree builds
+- [dfandrich brought this change]
-Daniel Stenberg (21 Jun 2014)
-- curl_easy_setopt.3: shorten
-
- shorten descriptions, mostly refer to the separate descriptions
+ unit1602: Fixed failure in torture test
-- CURLOPT_DNS_LOCAL_IP4.3: better short desc
+Steve Holme (12 Nov 2015)
+- sasl: Re-introduced XOAUTH2 in the default enabled authentication mechanism
+
+ Following the fix in commit d6d58dd558 it is necessary to re-introduce
+ XOAUTH2 in the default enabled authentication mechanism, which was
+ removed in commit 7b2012f262, otherwise users will have to specify
+ AUTH=XOAUTH2 in the URL.
+
+ Note: OAuth 2.0 will only be used when the bearer is specified.
-Dan Fandrich (20 Jun 2014)
-- opts: document CURLE_OUT_OF_MEMORY among other return values
+- [Stefan Bühler brought this change]
-- opts: fixed some typos
+ sasl_sspi: fix identity memory leak in digest authentication
-Daniel Stenberg (20 Jun 2014)
-- opts: various corrections
+- [Stefan Bühler brought this change]
-- opts: add the rest of the options
+ sasl_sspi: fixed unicode build for digest authentication
- ... and fixed mancheck to ignore obsolete options
+ Closes #525
-- opts: the final bunch of options as man pages
+- oauth2: Re-factored OAuth 2.0 state variable
+
+- sasl: Don't choose OAuth 2.0 if mechanism not advertised
- Now all current options have their own man pages.
+ Regression from commit 9e8ced9890 which meant if --oauth2-bearer was
+ specified but the SASL mechanism wasn't supported by the server then
+ the mechanism would be chosen.
-- opts: 37 additional man pages
+Daniel Stenberg (12 Nov 2015)
+- runtests: more compact "System characteristics" output
+
+ - no point in repeating curl features that is already listed as features
+ from the curl -V output
+
+ - remove the port numbers/unix domain path from the output unless
+ verbose is used, as that is rarely interesting to users.
-- CURLOPT_URL: move up the text from "Notes"
+- runtests: rename conditional curl-features to $has_[name]
-- ROADMAP: removed, now ROADMAP.md
+Steve Holme (11 Nov 2015)
+- oauth2: Introduced support for host and port details
+
+ Added support to the OAuth 2.0 message function for host and port, in
+ order to accommodate the official OAUTHBEARER SASL mechanism which is
+ to be added shortly.
-- ROADMAP.md: make it markdown formatted
+- curl_setup.h: Removed duplicate CURL_DISABLE_RTSP when HTTP_ONLY defined
-- ROADMAP: initial commit of "curl the next few years"
+- cmake: Add missing feature macros in config header (Part 2)
- To be further discussed, debated and edited
+ In addition to commit a215381c94 added the RTSP, RTMP and SMB protocols.
-- opts: more man pages
+Daniel Stenberg (10 Nov 2015)
+- [Douglas Creager brought this change]
-- CURLOPT_UNRESTRICTED_AUTH.3: added missing 'T'
-
-- opts: makefile now includes all current man pages
+ cmake: Add missing feature macros in config header
+
+ The curl_config.h file can be generated either from curl_config.h.cmake
+ or curl_config.h.in, depending on whether you're building using CMake or
+ the autotools. The CMake template header doesn't include entries for
+ all of the protocols that you can disable, which (I think) means that
+ you can't actually disable those protocols when building via CMake.
+
+ Closes #523
-- opts: 11 more man pages
+- [Douglas Creager brought this change]
-Dan Fandrich (18 Jun 2014)
-- opts: document CURLE_OUT_OF_MEMORY as RETURN VALUE
+ BoringSSL: Work with stricter BIO_get_mem_data()
+
+ BoringSSL implements `BIO_get_mem_data` as a function, instead of a
+ macro, and expects the output pointer to be a `char **`. We have to add
+ an explicit cast to grab the pointer as a `const char **`.
+
+ Closes #524
-- opts: fixed a couple of typos
+- http2: rectify the http2 version #if check
+
+ We need 1.0.0 or later. Also verified by configure.
-Patrick Monnerat (18 Jun 2014)
-- OS400: make it compilable again. Make RPG binding up to date.
+Steve Holme (9 Nov 2015)
+- oauth2: Don't use XAUTH2 in OAuth 2.0 function name
-- buildconf: do not search tools in current directory.
+- oauth2: Don't use XOAUTH2 in OAuth 2.0 variables
-Dan Fandrich (18 Jun 2014)
-- curl.h: renamed CURLOPT_DEPRECATEDx to CURLOPT_OBSOLETEx
+- oauth2: Use OAuth 2.0 rather than XOAUTH2 in comments
- This is consistent with the existing obsolete error code naming
- convention.
-
-Daniel Stenberg (18 Jun 2014)
-- opts: 16 more man pages
+ When referring to OAuth 2.0 we should use the official name rather the
+ SASL mechanism name.
projects / platform / upstream / curl.git / blobdiff