Changelog
-Version 7.32.0 (11 Aug 2013)
+Version 7.53.1 (24 Feb 2017)
-Daniel Stenberg (11 Aug 2013)
-- THANKS: added contributors from the 7.32.0 release notes
+Daniel Stenberg (24 Feb 2017)
+- release: 7.53.1
-- [Fabian Keil brought this change]
-
- test1228: add 'HTTP proxy' to the keywords
-
-- [Fabian Keil brought this change]
-
- tests: add keywords for a couple of FILE tests
+- Revert "tests: use consistent environment variables for setting charset"
+
+ This reverts commit ecd1d020abdae3c3ce3643ddab3106501e62e7c0.
+
+ That commit caused test failures on my Debian Linux machine for all
+ changed test cases. We need to reconsider how that should get done.
-- [Fabian Keil brought this change]
+Dan Fandrich (23 Feb 2017)
+- tests: use consistent environment variables for setting charset
+
+ Character set in POSIX is set by the locale defined (in decreasing order
+ of precedence) by the LC_ALL, LC_CTYPE and LANG environment variables (I
+ believe CHARSET is only historic). LC_ALL is cleared to ensure that
+ LC_CTYPE takes effect, but LC_ALL is not used to set the locale to
+ ensure that other parts of the locale aren't overriden, if set. Since
+ there doesn't seem to be a cross-platform way of specifying a UTF-8
+ locale, and not all systems may support UTF-8, a <precheck> is used
+ (where relevant) to skip the test if UTF-8 isn't in use. Test 1035 was
+ also converted to UTF-8 for consistency, as the actual character set
+ used there is irrelevant to the test.
- tests: add 'FAILURE' keywords to tests 1409 and 1410
+Jay Satiro (23 Feb 2017)
+- url: Default the CA proxy bundle location to CURL_CA_BUNDLE
+
+ If the compile-time CURL_CA_BUNDLE location is defined use it as the
+ default value for the proxy CA bundle location, which is the same as
+ what we already do for the regular CA bundle location.
+
+ Ref: https://github.com/curl/curl/pull/1257
-- [Fabian Keil brought this change]
+Daniel Stenberg (23 Feb 2017)
+- [Sergii Pylypenko brought this change]
- tests: add keywords for a couple of HTTP tests
+ rand: added missing #ifdef HAVE_FCNTL_H around fcntl.h header
+
+ Closes #1285
-- [Fabian Keil brought this change]
+- TODO: "OPTIONS *"
+
+ Closes #1280
- tests: add keywords for a couple of FTP tests
+- RELEASE-NOTES: synced with 443e5b03a7d441
-- [Fabian Keil brought this change]
+- THANKS-filter: shachaf
- test1511: consistently terminate headers with CRLF
+- [İsmail Dönmez brought this change]
-- DISABLED: shut of test 1512 for now
+ tests: Set CHARSET & LANG to UTF-8 in 1035, 2046 and 2047
- It shows intermittent failures and I haven't been able to track them
- down yet. Disable this test for now.
+ Closes #1283
+ Fixes #1277
-- curl_multi_add_handle.3: ... that timer callback is for event-based
-
-- comments: remove old and wrong multi/easy interface statements
+- bump: 7.53.1 coming up
+
+ synced with df665f4df0f7a352
-- curl_multi_add_handle.3: mention the CURLMOPT_TIMERFUNCTION use
+- formdata: check for EOF when reading from stdin
+
+ Reported-by: shachaf@users.noreply.github.com
+
+ Fixes #1281
-- [John E. Malmberg brought this change]
+Jay Satiro (22 Feb 2017)
+- docs: gitignore curl.1
+
+ curl.1 is generated by the cmdline-opts script since 4c49b83.
- KNOWN_BUGS: 22 and 57 have been fixed and committed
+Daniel Stenberg (22 Feb 2017)
+- TODO: HTTP Digest using SHA-256
-- RELEASE-NOTES: synced with d20def20462e7
+- TODO: brotli is deployed widely now
-- global dns cache: fix memory leak
-
- The take down of the global dns cache didn't take CURLOPT_RESOLVE names
- into account.
+Jay Satiro (21 Feb 2017)
+- [Viktor Szakats brought this change]
-- global dns cache: didn't work [regression]
+ urldata: include curl_sspi.h when Windows SSPI is enabled
- CURLOPT_DNS_USE_GLOBAL_CACHE broke in commit c43127414d89ccb (been
- broken since the libcurl 7.29.0 release). While this option has been
- documented as deprecated for almost a decade and nobody even reported
- this bug, it should remain functional.
+ f77dabe broke builds in Windows using Windows SSPI but not Windows SSL.
- Added test case 1512 to verify
+ Bug: https://github.com/curl/curl/issues/1276
+ Reported-by: jveazey@users.noreply.github.com
-Yang Tse (8 Aug 2013)
-- [John Malmberg brought this change]
-
- packages/vms: update VMS build files
-
- VMS modified files either missing from a previous commit and changes
- to remove references to CVS repositories.
-
-Daniel Stenberg (8 Aug 2013)
-- FTP: renamed several local functions
+- url: Improve CURLOPT_PROXY_CAPATH error handling
- The previous naming scheme ftp_state_post_XXXX() wasn't really helpful
- as it wasn't always immediately after 'xxxx' and it wasn't easy to
- understand what it does based on such a name.
+ - Change CURLOPT_PROXY_CAPATH to return CURLE_NOT_BUILT_IN if the option
+ is not supported, which is the same as what we already do for
+ CURLOPT_CAPATH.
- This new one is instead ftp_state_yyyy() where yyyy describes what it
- does or sends.
-
-- mk-ca-bundle.1: don't install on make install
+ - Change the curl tool to handle CURLOPT_PROXY_CAPATH error
+ CURLE_NOT_BUILT_IN as a warning instead of as an error, which is the
+ same as what we already do for CURLOPT_CAPATH.
- Since the mk-ca-bundle tool itself isn't installed with make install,
- there's no point in installing its documentation.
+ - Fix CAPATH docs to show that CURLE_NOT_BUILT_IN is returned when the
+ respective CAPATH option is not supported by the SSL library.
- Bug: http://curl.haxx.se/mail/lib-2013-08/0057.html
- Reported-by: Guenter Knauf
+ Ref: https://github.com/curl/curl/pull/1257
-Yang Tse (7 Aug 2013)
-- packages/vms/Makefile.am: add latest file additions to EXTRA_DIST
+- cyassl: fix typo
-- [John Malmberg brought this change]
+Version 7.53.0 (22 Feb 2017)
- Building_vms_pcsi_kit
+Daniel Stenberg (22 Feb 2017)
+- release: 7.53.0
+
+- cookie: fix declaration of 'dup' shadows a global declaration
+
+- TLS: make SSL_VERIFYSTATUS work again
- These are the files needed to build VMS distribution packages known as
- PCSI kits.
+ The CURLOPT_SSL_VERIFYSTATUS option was not properly handled by libcurl
+ and thus even if the status couldn't be verified, the connection would
+ be allowed and the user would not be told about the failed verification.
- Also minor update to the existing files, mainly to the documentation and
- file clean up code.
-
-Daniel Stenberg (6 Aug 2013)
-- LIBCURL-STRUCTS: new document
+ Regression since cb4e2be7c6d42ca
- This is the first version of this new document, detailing the seven
- perhaps most important internal structs in libcurl source code:
+ CVE-2017-2629
+ Bug: https://curl.haxx.se/docs/adv_20170222.html
- 1.1 SessionHandle
- 1.2 connectdata
- 1.3 Curl_multi
- 1.4 Curl_handler
- 1.5 conncache
- 1.6 Curl_share
- 1.7 CookieInfo
-
-- CONTRIBUTE: minor language polish
+ Reported-by: Marcus Hoffmann
-- FTP: when EPSV gets a 229 but fails to connect, retry with PASV
+Jay Satiro (21 Feb 2017)
+- digest_sspi: Handle 'stale=TRUE' directive in HTTP digest
- This is a regression as this logic used to work. It isn't clear when it
- broke, but I'm assuming in 7.28.0 when we went all-multi internally.
+ - If the server has provided another challenge use it as the replacement
+ input token if stale=TRUE. Otherwise previous credentials have failed
+ so return CURLE_LOGIN_DENIED.
- This likely never worked with the multi interface. As the failed
- connection is detected once the multi state has reached DO_MORE, the
- Curl_do_more() function was now expanded somewhat so that the
- ftp_do_more() function can request to go "back" to the previous state
- when it makes another attempt - using PASV.
+ Prior to this change the stale directive was ignored and if another
+ challenge was received it would cause error CURLE_BAD_CONTENT_ENCODING.
- Added test case 1233 to verify this fix. It has the little issue that it
- assumes no service is listening/accepting connections on port 1...
+ Ref: https://tools.ietf.org/html/rfc2617#page-10
- Reported-by: byte_bucket in the #curl IRC channel
+ Bug: https://github.com/curl/curl/issues/928
+ Reported-by: tarek112@users.noreply.github.com
-Nick Zitzmann (5 Aug 2013)
-- md5: remove use of CommonCrypto-to-OpenSSL macros for the benefit of Leopard
+Daniel Stenberg (20 Feb 2017)
+- smb: use getpid replacement for windows UWP builds
- For some reason, OS X 10.5's GCC suddenly stopped working correctly with
- macros that change MD5_Init etc. in the code to CC_MD5_Init etc., so I
- worked around this by removing use of the macros and inserting static
- functions that just call CommonCrypto's implementations of the functions
- instead.
+ Source: https://github.com/Microsoft/vcpkg/blob/7676b8780db1e1e591c4fc7eba4f96f73c428cb4/ports/curl/0002_fix_uwp.patch
-Guenter Knauf (5 Aug 2013)
-- Simplify check for trusted certificates.
+- TODO: CURLOPT_RESOLVE for any port number
- This changes the previous check for untrusted certs to a check for
- certs explicitely marked as trusted.
- The change is backward-compatible (tested with certdata.txt v1.80).
+ Closes #1264
-Daniel Stenberg (5 Aug 2013)
-- configure: warn on bad env variable use, don't error
-
- Use XC_CHECK_BUILD_FLAGS instead XC_CHECK_USER_FLAGS.
+- RELEASE-NOTES: synced with af30f1152d43dcdb
-- Revert "configure: don't error out on variable confusions, just warn"
-
- This reverts commit 6b27703b5f525eccdc0a8409f51de8595c75132a.
+- [Jean Gressmann brought this change]
-- formadd: wrong pointer for file name when CURLFORM_BUFFERPTR used
+ sftp: improved checks for create dir failures
- The internal function that's used to detect known file extensions for
- the default Content-Type got the the wrong pointer passed in when
- CURLFORM_BUFFER + CURLFORM_BUFFERPTR were used. This had the effect that
- strlen() would be used which could lead to an out-of-bounds read (and
- thus segfault). In most cases it would only lead to it not finding or
- using the correct default content-type.
+ Since negative values are errors and not only -1. This makes SFTP upload
+ with --create-dirs work (again).
- It also showed that test 554 and test 587 were testing for the
- previous/wrong behavior and now they're updated as well.
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1262
- Reported-by: Konstantin Isakov
+ Closes #1269
+
+Jay Satiro (20 Feb 2017)
+- [Max Khon brought this change]
-Guenter Knauf (4 Aug 2013)
-- Skip more untrusted certificates.
+ digest_sspi: Fix nonce-count generation in HTTP digest
- Christian Heimes brought to our attention that the certdata.txt
- format has recently changed [1], causing ca-bundle.crt created
- with mk-ca-bundle.[pl|vbs] to include untrusted certs.
+ - on the first invocation: keep security context returned by
+ InitializeSecurityContext()
- [1] http://lists.debian.org/debian-release/2012/11/msg00411.html
+ - on subsequent invocations: use MakeSignature() instead of
+ InitializeSecurityContext() to generate HTTP digest response
+
+ Bug: https://github.com/curl/curl/issues/870
+ Reported-by: Andreas Roth
+
+ Closes https://github.com/curl/curl/pull/1251
-Daniel Stenberg (4 Aug 2013)
-- configure: don't error out on variable confusions, just warn
+- examples/multi-uv: checksrc compliance
-- configure: rephrase the notice in _XC_CHECK_VAR_*
-
- Instead of claiming it is an error, we call it a "note" to reduce the
- severity level. But the following text now says the [variable] "*should*
- only be used to specify"... instead of previously having said "may".
+Michael Kaufmann (19 Feb 2017)
+- string formatting: fix 4 printf-style format strings
-- multi: remove data->state.current_conn struct field
-
- Not needed
+Dan Fandrich (18 Feb 2017)
+- tests: removed the obsolete name parameter
-- multi: remove the one_easy struct field
+Michael Kaufmann (18 Feb 2017)
+- speed caps: update the timeouts if the speed is too low/high
- Since the merge of SessionHandle with Curl_one_easy, this indirection
- isn't used anymore.
+ Follow-up to 4b86113
+
+ Fixes https://github.com/curl/curl/issues/793
+ Fixes https://github.com/curl/curl/issues/942
-- multi: rename all Curl_one_easy to SessionHandle
+- docs: fix timeout handling in multi-uv example
-- multi: remove the multi_pos struct field
+- proxy: fix hostname resolution and IDN conversion
- Since Curl_one_easy is really a SessionHandle now, this indirection
- doesn't exist anymore.
-
-- multi: remove easy_handle struct field
+ Properly resolve, convert and log the proxy host names.
+ Support the "--connect-to" feature for SOCKS proxies and for passive FTP
+ data transfers.
- It isn't needed anymore
+ Follow-up to cb4e2be
+
+ Reported-by: Jay Satiro
+ Fixes https://github.com/curl/curl/issues/1248
+
+Jay Satiro (17 Feb 2017)
+- [Isaac Boukris brought this change]
-- multi: remove 'Curl_one_easy' struct, phase 1
+ http: fix missing 'Content-Length: 0' while negotiating auth
- The motivation for having a separate struct that keep track of an easy
- handle when using the multi handle was removed when we switched to
- always using the multi interface internally. Now they were just two
- separate struct that was always allocated for each easy handle.
+ - While negotiating auth during PUT/POST if a user-specified
+ Content-Length header is set send 'Content-Length: 0'.
- This first step just moves the Curl_one_easy struct members into the
- SessionHandle struct and hides this somehow (== keeps the source code
- changes to a minimum) by defining Curl_one_easy to SessionHandle
+ This is what we do already in HTTPREQ_POST_FORM and what we did in the
+ HTTPREQ_POST case (regression since afd288b).
- The biggest changes in this commit are:
+ Prior to this change no Content-Length header would be sent in such a
+ case.
- 1 - the linked list of easy handles had to be changed somewhat due
- to the new struct layout. This made the main linked list pointer
- get renamed to 'easyp' and there's also a new pointer to the last
- node, called easylp. It is no longer circular but ends with ->next
- pointing to NULL. New nodes are still added last.
+ Bug: https://curl.haxx.se/mail/lib-2017-02/0006.html
+ Reported-by: Dominik Hölzl
- 2 - easy->state is now called easy->mstate to avoid name collision
+ Closes https://github.com/curl/curl/pull/1242
-Steve Holme (2 Aug 2013)
-- Revert "DOCS: Added IMAP URL example for listing new messages"
-
- This reverts commit 82ab5f1b0c7c3f as this was the wrong place to
- document the complexity of IMAP URLs and Custom Requests.
+Daniel Stenberg (16 Feb 2017)
+- [Simon Warta brought this change]
-- DOCS: Added IMAP URL example for listing new messages
+ winbuild: add note on auto-detection of MACHINE in Makefile.vc
- In addition to listing the folder contents, in the URL examples, added
- an example to list the new messages waiting in the user's inbox.
-
-Yang Tse (1 Aug 2013)
-- packages/vms/Makefile.am: add latest file additions to EXTRA_DIST
+ Closes #1265
-- [John Malmberg brought this change]
+- RELEASE-PROCEDURE: update the upcoming release calendar
- Add in the files needed to build libcurl shared images on VMS.
+- TODO: consider file name from the redirected URL with -O ?
- Update the packages/vms/readme file to be current.
+ It isn't easily solved, but with some thinking someone could probably
+ come up with a working approach?
- Also some files for the GNV based build were either missing or needed an
- update.
-
- curl_crtl_init.c is a special file that is run before main() to
- set up the proper C runtime behavior.
+ Closes #1241
+
+Jay Satiro (15 Feb 2017)
+- tool_urlglob: Allow a glob range with the same start and stop
- generate_vax_transfer.com generates the VAX transfer vector modules from
- the gnv_libcurl_symbols.opt file.
+ For example allow ranges like [1-1] and [a-a] etc.
- gnv_conftest.c_first is a helper file needed for configure scripts to
- come up with the expected answers on VMS.
+ Regression since 5ca96cb.
- gnv_libcurl_symbols.opt is the public symbols for the libcurl shared
- image.
+ Bug: https://github.com/curl/curl/issues/1238
+ Reported-by: R. Dennis Steed
+
+Daniel Stenberg (15 Feb 2017)
+- axtls: adapt to API changes
- gnv_link_curl.com builds the shared libcurl image and rebuilds other
- programs to use it.
+ Builds with axTLS 2.1.2. This then also breaks compatibility with axTLS
+ < 2.1.0 (the older API)
- macro32_exactcase.patch is a hack to make a local copy of the VMS Macro32
- assembler case sensitive, which is needed to build the VAX transfer modules.
+ ... and fix the session_id mixup brought in 04b4ee549
- report_openssl_version.c is a tool for help verify that the libcurl
- shared image is being built for a minium version of openssl.
+ Fixes #1220
-- curl: second follow-up for commit 5af2bfb9
-
- Display progress-bar unconditionally on first call
+- RELEASE-NOTES: synced with 690935390c29c
-- curl: follow-up for commit 5af2bfb9
+- [Nick Draffen brought this change]
+
+ curl: fix typo in time condition warning message
+
+ The warning message had a typo. The argument long form is --time-cond
+ not --timecond
- Use tvnow() and tvdiff() to avoid introducing new linkage issues
+ Closes #1263
-Daniel Stenberg (31 Jul 2013)
-- curl: --progress-bar max update frequency now at 5Hz
+- smb: code indent
-- curl: make --progress-bar update the line less frequently
+Jay Satiro (14 Feb 2017)
+- configure: Allow disabling pthreads, fall back on Win32 threads
- Also, use memset() instead of a lame loop.
+ When the threaded resolver option is specified for configure the default
+ thread library is pthreads. This change makes it possible to
+ --disable-pthreads and then configure can fall back on Win32 threads for
+ native Windows builds.
- The previous logic that tried to avoid too many updates were very
- ineffective for really fast transfers, as then it could easily end up
- doing hundreds of updates per second that would make a significant
- impact in transfer performance!
-
- Bug: http://curl.haxx.se/mail/archive-2013-07/0031.html
- Reported-by: Marc Doughty
+ Closes https://github.com/curl/curl/pull/1260
-Nick Zitzmann (30 Jul 2013)
-- darwinssl: added LFs to some strings passed into infof()
+Daniel Stenberg (13 Feb 2017)
+- http2: fix memory-leak when denying push streams
- (This doesn't need to appear in the release notes.) I noticed a few places
- where infof() was called, and there should've been an LF at the end of the
- string, but there wasn't.
+ Reported-by: zelinchen@users.noreply.github.com
+ Fixes #1229
-- darwinssl: fix build error in crypto authentication under Snow Leopard
-
- It turns out Snow Leopard not only has SecItemCopyMatching() defined in
- a header not included by the omnibus header, but it won't work for our
- purposes, because searching for SecIdentityRef objects wasn't added
- to that API until Lion. So we now use the old SecKeychainSearch API
- instead if the user is building under, or running under, Snow Leopard.
+Jay Satiro (11 Feb 2017)
+- tool_operate: Show HTTPS-Proxy options on CURLE_SSL_CACERT
- Bug: http://sourceforge.net/p/curl/bugs/1255/
- Reported by: Edward Rudd
-
-- md5 & metalink: use better build macros on Apple operating systems
+ When CURLE_SSL_CACERT occurs the tool shows a lengthy error message to
+ the user explaining possible solutions such as --cacert and --insecure.
- Previously we used __MAC_10_X and __IPHONE_X to mark digest-generating
- code that was specific to OS X and iOS. Now we use
- __MAC_OS_X_VERSION_MAX_ALLOWED and __IPHONE_OS_VERSION_MAX_ALLOWED
- instead of those macros.
+ This change appends to that message similar options --proxy-cacert and
+ --proxy-insecure when there's a specified HTTPS proxy.
- Bug: http://sourceforge.net/p/curl/bugs/1255/
- Reported by: Edward Rudd
-
-Yang Tse (29 Jul 2013)
-- tool_operhlp.c: fix add_file_name_to_url() OOM handling
+ Closes https://github.com/curl/curl/issues/1258
-- tool_operate.c: fix brace placement for vi/emacs delimiter matching
+Daniel Stenberg (10 Feb 2017)
+- cmdline-opts/page-footer: ftp.sunet.se is no longer an FTP mirror
-- tool_operate.c: move <fabdef.h> header inclusion location
-
-Daniel Stenberg (29 Jul 2013)
-- RELEASE-NOTES: synced with b5478a0e033e7
+- URL: only accept ";options" in SMTP/POP3/IMAP URL schemes
+
+ Fixes #1252
-- curl_easy_pause: on unpause, trigger mulit-socket handling
+Jay Satiro (9 Feb 2017)
+- cmdline-opts/socks*: Mention --preproxy in --socks* opts
- When the multi-socket API is used, we need the handle to be checked
- again when it gets unpaused.
+ - Document in --socks* opts they're still mutually exclusive of --proxy.
- Bug: http://curl.haxx.se/mail/lib-2013-07/0239.html
- Reported-by: Justin Karneges
+ Partial revert of 423a93c; I had misinterpreted the SOCKS proxy +
+ HTTP/HTTPS proxy combination.
+
+ - Document in --socks* opts that --preproxy can be used to specify a
+ SOCKS proxy at the same time --proxy is used with an HTTP/HTTPS proxy.
-- [John E. Malmberg brought this change]
+Daniel Stenberg (9 Feb 2017)
+- CURLOPT_SSL_VERIFYPEER.3: also the https proxy version
- curl_formadd: fix file upload on VMS
-
- For the standard VMS text file formats, VMS needs to read the file to
- get the actual file size.
+Kamil Dudka (9 Feb 2017)
+- nss: make FTPS work with --proxytunnel
- For the standard VMS binary file formats, VMS needs a special format of
- fopen() call so that it stops reading at the logical end of file instead
- of at the end of the blocks allocated to the file.
+ If the NSS code was in the middle of a non-blocking handshake and it
+ was asked to finish the handshake in blocking mode, it unexpectedly
+ continued in the non-blocking mode, which caused a FTPS connection
+ over CONNECT to fail with "(81) Socket not ready for send/recv".
- I structured the patch this way as I was not sure about changing the
- structures or parameters to the routines, but would prefer to only call
- the stat() function once and pass the information to where the fopen()
- call is made.
-
- Bug: https://sourceforge.net/p/curl/bugs/758/
+ Bug: https://bugzilla.redhat.com/1420327
-- formadd: CURLFORM_FILECONTENT wrongly rejected some option combos
+Daniel Stenberg (9 Feb 2017)
+- examples/multithread.c: link to our multi-thread docs
- The code for CURLFORM_FILECONTENT had its check for duplicate options
- wrong so that it would reject CURLFORM_PTRNAME if used in combination
- with it (but not CURLFORM_COPYNAME)! The flags field used for this
- purpose cannot be interpreted that broadly.
+ ... instead of the OpenSSL mutex page.
+
+- http_proxy: avoid freeing static memory
- Bug: http://curl.haxx.se/mail/lib-2013-07/0258.html
- Reported-by: Byrial Jensen
+ Follow up to 7fe81ec298e0: make sure 'host' is either NULL or malloced.
-Yang Tse (25 Jul 2013)
-- packages/vms/Makefile.am: add latest file additions to EXTRA_DIST
+- [Cameron MacMinn brought this change]
-- [John E. Malmberg brought this change]
+ http_proxy: Fix tiny memory leak upon edge case connecting to proxy
+
+ Fixes #1255
- VMS: intial set of files to allow building using GNV toolkit.
+Michael Kaufmann (8 Feb 2017)
+- polarssl, mbedtls: Fix detection of pending data
+
+ Reported-by: Dan Fandrich
+ Bug: https://curl.haxx.se/mail/lib-2017-02/0032.html
-- string formatting: fix too many arguments for format
+Dan Fandrich (7 Feb 2017)
+- test1139: Added the --manual keyword since the manual is required
-- string formatting: fix zero-length printf format string
+Daniel Stenberg (7 Feb 2017)
+- RELEASE-NOTES: synced with 102454459dd688c
-- easy.c: curl_easy_getinfo() fix va_start/va_end matching
+- THANKS-filter: polish some recent contributors
-- imap.c: imap_sendf() fix va_start/va_end matching
+- http2: reset push header counter fixes crash
+
+ When removing an easy handler from a multi before it completed its
+ transfer, and it had pushed streams, it would segfault due to the pushed
+ counted not being cleared.
+
+ Fixed-by: zelinchen@users.noreply.github.com
+ Fixes #1249
-- string formatting: fix 15+ printf-style format strings
+- [Markus Westerlind brought this change]
-Patrick Monnerat (24 Jul 2013)
-- OS400: sync ILE/RPG binding with current curl.h
+ transfer: only retry nobody-requests for HTTP
+
+ Using sftp to delete a file with CURLOPT_NOBODY set with a reused
+ connection would fail as curl expected to get some data. Thus it would
+ retry the command again which fails as the file has already been
+ deleted.
+
+ Fixes #1243
-Yang Tse (24 Jul 2013)
-- string formatting: fix 25+ printf-style format strings
+Jay Satiro (7 Feb 2017)
+- [Daniel Gustafsson brought this change]
-Daniel Stenberg (23 Jul 2013)
-- Makefile.am: use LDFLAGS as well when linking libcurl
+ telnet: Fix typos
- Linking on Solaris 10 x86 with Sun Studio 12 failed when we upgraded
- automake for the release builds.
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1217
- Reported-by: Dagobert Michelsen
+ Ref: https://github.com/curl/curl/pull/1245
-- [Fabian Keil brought this change]
+- [Daniel Gustafsson brought this change]
- url.c: Fix dot file path cleanup when using an HTTP proxy
+ test552: Fix typos
- Previously the path was cleaned, but the URL wasn't properly updated.
+ Closes https://github.com/curl/curl/pull/1245
-- [Fabian Keil brought this change]
+- [Daniel Gustafsson brought this change]
- tests: test1232 verifies dotdot removal from path with proxy
+ darwinssl: Avoid parsing certificates when not in verbose mode
+
+ The information extracted from the server certificates in step 3 is only
+ used when in verbose mode, and there is no error handling or validation
+ performed as that has already been done. Only run the certificate
+ information extraction when in verbose mode and libcurl was built with
+ verbose strings.
+
+ Closes https://github.com/curl/curl/pull/1246
-- [Fabian Keil brought this change]
+- [JDepooter brought this change]
- dotdot.c: Fix a RFC section number in a comment for Curl_dedotdotify()
+ schannel: Remove incorrect SNI disabled message
+
+ - Remove the SNI disabled when host verification disabled message
+ since that is incorrect.
+
+ - Show a message for legacy versions of Windows <= XP that connections
+ may fail since those versions of WinSSL lack SNI, algorithms, etc.
+
+ Bug: https://github.com/curl/curl/pull/1240
-- [John E. Malmberg brought this change]
+Daniel Stenberg (7 Feb 2017)
+- CHANGES: spell fix, use correct path to script
- build_vms.com: fix debug and float options
+- CHANGES.0: removed
- In the reorganization of the build_vms.com the debug and float options
- were not fixed up correctly.
+ This is the previously manually edited changelog, not touched since Aug
+ 2015. Still present in git for those who wants it.
-- [John E. Malmberg brought this change]
+Dan Fandrich (6 Feb 2017)
+- cmdline-opts: Fixed build and test in out of source tree builds
+
+Viktor Szakats (6 Feb 2017)
+- use *.sourceforge.io and misc URL updates
+
+ Ref: https://sourceforge.net/blog/introducing-https-for-project-websites/
+ Closes: https://github.com/curl/curl/pull/1247
- curl: fix upload of a zip file in OpenVMS
+Jay Satiro (6 Feb 2017)
+- docs: Add more HTTPS proxy documentation
- Two fixes:
+ - Document HTTPS proxy type.
- 1. Force output file format to be stream-lf so that partial downloads
- can be continued.
+ - Document --write-out %{proxy_ssl_verify_result}.
- This should have minor impact as if the file does not exist, it was
- created with stream-lf format. The only time this was an issue is if
- there was already an existing file with a different format.
+ - Document SOCKS proxy + HTTP/HTTPS proxy combination.
- 2. Fix file uploads are now fixed.
+ HTTPS proxy support was added in 7.52.0 for OpenSSL, GnuTLS and NSS.
- a. VMS binary files such as ZIP archives are now uploaded
- correctly.
+ Ref: https://github.com/curl/curl/commit/cb4e2be
+
+- OS400: Fix symbols
- b. VMS text files are read once to get the correct size
- and then converted to line-feed terminated records as
- they are read into curl.
+ - s/CURLOPT_SOCKS_PROXY/CURLOPT_PRE_PROXY
+ Follow-up to 7907a2b and 845522c.
- The default VMS text formats do not contain either line-feed or
- carriage-return terminated records. Those delimiters are added by the
- operating system file read calls if the application requests them.
+ - Fix incorrect id for CURLOPT_PROXY_PINNEDPUBLICKEY.
- Bug: http://curl.haxx.se/bug/view.cgi?id=496
-
-Yang Tse (22 Jul 2013)
-- libtest: fix data type of some *_setopt() 'long' arguments
-
-- curl: fix symbolic names for CURL_NETRC_* enum in --libcurl output
+ - Add id for CURLOPT_ABSTRACT_UNIX_SOCKET.
+
+ Bug: https://github.com/curl/curl/issues/1237
+ Reported-by: jonrumsey@users.noreply.github.com
-- curl: fix symbolic names for CURLUSESSL_* enum in --libcurl output
+- [Sean Burford brought this change]
-- tool_operate.c: fix passing curl_easy_setopt long arg on some x64 ABIs
+ cmake: Support curl --xattr when built with cmake
- We no longer pass our 'bool' data type variables nor constants as
- an argument to my_setopt(), instead we use proper 1L or 0L values.
+ - Test for and set HAVE_FSETXATTR when support for extended file
+ attributes is present.
- This also fixes macro used to pass string argument for CURLOPT_SSLCERT,
- CURLOPT_SSLKEY and CURLOPT_EGDSOCKET using my_setopt_str() instead of
- my_setopt().
-
- This also casts enum or int argument data types to long when passed to
- my_setopt_enum().
+ Closes https://github.com/curl/curl/pull/1176
+
+- [Adam Langley brought this change]
-Daniel Stenberg (21 Jul 2013)
-- curl_multi_wait: fix revents
+ openssl: Don't use certificate after transferring ownership
- Commit 6d30f8ebed34e7276 didn't work properly. First, it used the wrong
- array index, but this fix also:
+ SSL_CTX_add_extra_chain_cert takes ownership of the given certificate
+ while, despite the similar name, SSL_CTX_add_client_CA does not. Thus
+ it's best to call SSL_CTX_add_client_CA before
+ SSL_CTX_add_extra_chain_cert, while the code still has ownership of the
+ argument.
- 1 - only does the copying if indeed there was any activity
+ Closes https://github.com/curl/curl/pull/1236
+
+Daniel Stenberg (29 Jan 2017)
+- [Antoine Aubert brought this change]
+
+ mbedtls: implement CTR-DRBG and HAVEGE random generators
- 2 - makes sure to properly translate between internal and external
- bitfields, which are not guaranteed to match
+ closes #1227
+
+- docs: we no longer ship HTML versions of man pages
- Reported-by: Evgeny Turnaev
+ ... refer to the web site for the web versions.
-- RELEASE-NOTES: synced with d529f3882b9bca
+- [railsnewbie257 brought this change]
-- curl_easy_perform: gradually increase the delay time
+ docs: proofread README.netware README.win32
- Instead of going 50,100,150 etc millisecond delay time when nothing has
- been found to do or wait for, we now start lower and double each loop as
- in 4,8,16,32 etc.
+ Closes #1231
+
+- RELEASE-NOTES; synced with ab08d82648
+
+Michael Kaufmann (28 Jan 2017)
+- mbedtls: disable TLS session tickets
- This lowers the minimum wait without sacrifizing the longer wait too
- much with unnecessary CPU cycles burnt.
+ SSL session reuse with TLS session tickets is not supported yet.
+ Use SSL session IDs instead.
- Bug: http://curl.haxx.se/mail/lib-2013-07/0103.html
- Reported-by: Andreas Malzahn
+ See https://github.com/curl/curl/issues/1109
-- ftp_do_more: consider DO_MORE complete when server connects back
+- gnutls: disable TLS session tickets
- In the case of an active connection when ftp_do_more() detects that the
- server has connected back, it must make sure to mark it as complete so
- that the multi_runsingle() function will detect this and move on to the
- next state.
+ SSL session reuse with TLS session tickets is not supported yet.
+ Use SSL session IDs instead.
- Bug: http://curl.haxx.se/mail/lib-2013-07/0115.html
- Reported-by: Clemens Gruber
-
-Yang Tse (19 Jul 2013)
-- Makefile.b32: Borland makefile adjustments. Tested with BCC 5.5.1
+ Fixes https://github.com/curl/curl/issues/1109
-- WIN32 MemoryTracking: require UNICODE for wide strdup code support
+- polarssl: fix hangs
+
+ This bugfix is similar to commit c111178bd4.
-Daniel Stenberg (18 Jul 2013)
-- CURLOPT_XFERINFOFUNCTION: introducing a new progress callback
+Daniel Stenberg (27 Jan 2017)
+- cookies: do not assume a valid domain has a dot
+
+ This repairs cookies for localhost.
- CURLOPT_XFERINFOFUNCTION is now the preferred progress callback function
- and CURLOPT_PROGRESSFUNCTION is considered deprecated.
+ Non-PSL builds will now only accept "localhost" without dots, while PSL
+ builds okeys everything not listed as PSL.
- This new callback uses pure 'curl_off_t' arguments to pass on full
- resolution sizes. It otherwise retains the same characteristics: the
- same call rate, the same meanings for the arguments and the return code
- is used the same way.
+ Added test 1258 to verify.
- The progressfunc.c example is updated to show how to use the new
- callback for newer libcurls while supporting the older one if built with
- an older libcurl or even built with a newer libcurl while running with
- an older.
+ This was a regression brought in a76825a5efa6b4
-Yang Tse (18 Jul 2013)
-- Reinstate "WIN32 MemoryTracking: track wcsdup() _wcsdup() and _tcsdup() usage".
+- TODO: remove "Support TLS v1.3"
- This reverts commit 7ed25cc, reinstating commit 8ec2cb5.
+ Support is trickling in already.
+
+- [railsnewbie257 brought this change]
+
+ INTERNALS.md: language improvements
- As of 18-jul-2013 we still do have code in libcurl that makes use of these
- memory functions. Commit 8ec2cb5 comment still applies and is yet valid.
+ Closes #1226
+
+- telnet: fix windows compiler warnings
- These memory functions are solely used in Windows builds, so all related
- code is protected with '#ifdef WIN32' preprocessor conditional compilation
- directives.
+ Thumbs-up-by: Jay Satiro
- Specifically, wcsdup() _wcsdup() are used when building a Windows target with
- UNICODE and USE_WINDOWS_SSPI preprocessor symbols defined. This is the case
- when building a Windows UNICODE target with Windows native SSL/TLS support
- enabled.
+ Closes #1225
+
+- VC: remove the makefile.vc6 build infra
- Realizing that wcsdup() _wcsdup() are used is a bit tricky given that usage
- of these is hidden behind _tcsdup() which is MS way of dealing with code
- that must tolerate UNICODE and non-UNICODE compilation. Additionally, MS
- header files and those compatible from other compilers use this preprocessor
- conditional compilation directive in order to select at compilation time
- whether 'wide' or 'ansi' MS API functions are used.
+ The winbuild/ build files is now the single MSVC makefile build choice.
- Without this code, Windows build targets with Windows native SSL/TLS support
- enabled and MemoryTracking support enabled misbehave in tracking memory usage,
- regardless of being a UNICODE enabled build or not.
+ Closes #1215
-- xc-am-iface.m4: comments refinement
+- [Jay Satiro brought this change]
-- configure: fix 'subdir-objects' distclean related issue
+ cmdline-opts/gen.pl: Open input files in CRLF mode
+
+ On Windows it's possible to have input files with CRLF line endings and
+ a perl that defaults to LF line endings (eg msysgit). Currently that
+ results in generator output of mixed line endings of CR, LF and CRLF.
- See XC_AMEND_DISTCLEAN comments for details.
+ This change fixes that issue in the most succinct way by opening the
+ files in :crlf text mode even when the perl being used does not default
+ to that mode. (On operating systems that don't have a separate text mode
+ it's essentially a no-op.) The output continues to be in the perl's
+ native line ending.
-Daniel Stenberg (18 Jul 2013)
-- [Evgeny Turnaev brought this change]
+- docs/curl.1: generate from the cmdline-opts script
- curl_multi_wait: set revents for extra fds
-
- Pass back the revents that happened for the user-provided file
- descriptors.
+- vtls: source indentation fix
+
+- contri*.sh: cut off parentheses from names too
-- [Ben Greear brought this change]
+- RELEASE-NOTES: synced with 01ab7c30bba6f
- asyn-ares: Don't blank ares servers if none configured.
+- vtls: fix PolarSSL non-blocking handling
- Best to just let c-ares use it's defaults if none are configured
- in (lib)curl.
+ A regression brought in cb4e2be
- Signed-off-by: Ben Greear <greearb@candelatech.com>
+ Reported-by: Michael Kaufmann
+ Bug: https://github.com/curl/curl/issues/1174#issuecomment-274018791
-- [Sergei Nikulov brought this change]
+- [Antoine Aubert brought this change]
- cmake: Fix for MSVC2010 project generation
+ vtls: fix mbedtls multi non blocking handshake.
+
+ When using multi, mbedtls handshake is in non blocking mode. vtls must
+ set wait for read/write flags for the socket.
- Fixed issue with static build for MSVC2010.
+ Closes #1223
+
+- [Richy Kim brought this change]
+
+ CURLOPT_BUFFERSIZE: support enlarging receive buffer
- After some investigation I've discovered known issue
- http://public.kitware.com/Bug/view.php?id=11240 When .rc file is linked
- to static lib it fails with following linker error
+ Replace use of fixed macro BUFSIZE to define the size of the receive
+ buffer. Reappropriate CURLOPT_BUFFERSIZE to include enlarging receive
+ buffer size. Upon setting, resize buffer if larger than the current
+ default size up to a MAX_BUFSIZE (512KB). This can benefit protocols
+ like SFTP.
- LINK : warning LNK4068: /MACHINE not specified; defaulting to X86
- file.obj : fatal error LNK1112: module machine type 'x64' conflicts with
- target machine type 'X86'
+ Closes #1222
+
+- sws: use SOCKERRNO, not errno
- Fix add target property /MACHINE: for MSVC generation.
+ Reported-by: Gisle Vanem
+
+Michael Kaufmann (19 Jan 2017)
+- KNOWN_BUGS: HTTP/2 server push enabled when no pushes can be accepted
- Also removed old workarounds - it caused errors during msvc build.
+ This has been implemented with commit 9ad034e.
+
+Viktor Szakats (19 Jan 2017)
+- *.rc: escape non-ASCII/non-UTF-8 character for clarity
- Bug: http://curl.haxx.se/mail/lib-2013-07/0046.html
+ Closes https://github.com/curl/curl/pull/1217
-- mk-ca-bundle.1: point out certdata.txt format docs
+Kamil Dudka (19 Jan 2017)
+- docs: non-blocking SSL handshake is now supported with NSS
+
+ Implemented since curl-7_36_0-130-g8868a22
+
+ Reported-by: Fahim Chandurwala
-Yang Tse (16 Jul 2013)
-- slist.c: Curl_slist_append_nodup() OOM handling fix
+Michael Kaufmann (18 Jan 2017)
+- CURLOPT_CONNECT_TO: Fix compile warnings
+
+ Fix compile warnings that appeared only when curl has been configured
+ with '--disable-verbose'.
-Daniel Stenberg (16 Jul 2013)
-- test1414: FTP PORT download without SIZE support
+Daniel Stenberg (18 Jan 2017)
+- usercertinmem.c: improve the short description
-Yang Tse (16 Jul 2013)
-- tests/Makefile.am: add configurehelp.pm to DISTCLEANFILES
+- parseurl: move back buffer to function scope
+
+ Regression since 1d4202ad, which moved the buffer into a more narrow
+ scope, but the data in that buffer was used outside of that more narrow
+ scope.
+
+ Reported-by: Dan Fandrich
+ Bug: https://curl.haxx.se/mail/lib-2017-01/0093.html
-Patrick Monnerat (15 Jul 2013)
-- curl_slist_append(): fix error detection
+Jay Satiro (17 Jan 2017)
+- openssl: Fix random generation
+
+ - Fix logic error in Curl_ossl_random.
+
+ Broken a few days ago in 807698d.
-- slist.c: fix indentation
+Daniel Stenberg (17 Jan 2017)
+- TODO: share OpenSSL contexts
+
+ By supporting this, subsequent connects would load a lot less data from
+ disk.
+
+ Closes #1110
-- OS400: new SSL backend GSKit
+- bump: next release will be 7.53.0
-- OS400: add slist and certinfo EBCDIC support
+Kamil Dudka (15 Jan 2017)
+- nss: use the correct lock in nss_find_slot_by_name()
-- config-os400.h: enable system strdup(), strcmpi(), etc.
+Alessandro Ghedini (15 Jan 2017)
+- http2: disable server push if not requested
+
+ Ref: https://github.com/curl/curl/pull/1160
-- x509asn1.c,x509asn1.h: new module to support ASN.1/X509 parsing & info extract
- Use from qssl backend
+Daniel Stenberg (14 Jan 2017)
+- [railsnewbie257 brought this change]
-- ssluse.c,sslgen.c,sslgen.h: move certinfo support to generic SSL
+ docs: improved language in README.md HISTORY.md CONTRIBUTE.md
+
+ Closes #1211
-- Merge branch 'master' of github.com:bagder/curl
+Alessandro Ghedini (14 Jan 2017)
+- http: print correct HTTP string in verbose output when using HTTP/2
- Merge for resync
+ Before:
+ ```
+ % src/curl https://sigsegv.ninja/ -v --http2
+ ...
+ > GET / HTTP/1.1
+ > Host: sigsegv.ninja
+ > User-Agent: curl/7.52.2-DEV
+ > Accept: */*
+ >
+ ...
+ ```
+
+ After:
+ ```
+ % src/curl https://sigsegv.ninja/ -v --http2
+ ...
+ > GET / HTTP/2
+ > Host: sigsegv.ninja
+ > User-Agent: curl/7.52.2-DEV
+ > Accept: */*
+ >
+ ```
-- slist.c, slist.h, cookie.c: new internal procedure Curl_slist_append_nodup()
+Daniel Stenberg (14 Jan 2017)
+- TODO: send only part of --data
+
+ Closes #1200
-Yang Tse (15 Jul 2013)
-- sslgen.c: fix Curl_rand() compiler warning
+- TODO: implemened "--fail-fast to exit on first transfer fail"
- Use simple seeding method upon RANDOM_FILE seeding method failure.
+ Even though it is called --fail-early
-- sslgen.c: fix unreleased Curl_rand() infinite recursion
+- TODO: Chunked transfer multipart formpost
+
+ Closes #1139
-Daniel Stenberg (14 Jul 2013)
-- [Dave Reisner brought this change]
+- TODO: Improve formpost API, not just add an easy argument
- src/tool: allow timeouts to accept decimal values
+- addrinfo: fix compiler warning on offsetof() use
- Implement wrappers around strtod to convert the user argument to a
- double with sane error checking. Use this to allow --max-time and
- --connect-timeout to accept decimal values instead of strictly integers.
+ curl_addrinfo.c:519:20: error: conversion to ‘curl_socklen_t {aka
+ unsigned int}’ from ‘long unsigned int’ may alter its value
+ [-Werror=conversion]
- The manpage is updated to make mention of this feature and,
- additionally, forewarn that the actual timeout of the operation can
- vary in its precision (particularly as the value increases in its
- decimal precision).
+ Follow-up to 1d786faee1046f
-- [Dave Reisner brought this change]
+- THANKS-filter: Jiri Malak
- curl.1: fix long line, found by checksrc.pl
+- RELEASE-NOTES: synced with a7c73ae309c
-- [Dave Reisner brought this change]
+Peter Wu (13 Jan 2017)
+- [Isaac Boukris brought this change]
- src/tool_paramhlp: try harder to catch negatives
+ unix_socket: add support for abstract unix domain socket
- strto* functions happily chomp off leading whitespace, so simply
- checking for str[0] can lead to false negatives. Do the full parse and
- check the out value instead.
-
-- [John E. Malmberg brought this change]
-
- build_vms.com: detect and use zlib shared image
+ In addition to unix domain sockets, Linux also supports an
+ abstract namespace which is independent of the filesystem.
- Update the build_vms.com to detect and use zlib shared image installed
- by the ZLIB kit produced by Jean-Francois Pieronne, and the also the
- future ZLIB 1.2.8 kit in addition to the older ZLIB kits.
+ In order to support it, add new CURLOPT_ABSTRACT_UNIX_SOCKET
+ option which uses the same storage as CURLOPT_UNIX_SOCKET_PATH
+ internally, along with a flag to specify abstract socket.
- Also fix the indentation to match one of the common standards used for
- VMS DCL command files and removed the hard tab characters.
+ On non-supporting platforms, the abstract address will be
+ interpreted as an empty string and fail gracefully.
- Tested on OpenVMS 8.4 Alpha and IA64, and OpenVMS 7.3 VAX.
-
-Yang Tse (14 Jul 2013)
-- url.c: fix parse_url_login() OOM handling
+ Also add new --abstract-unix-socket tool parameter.
+
+ Signed-off-by: Isaac Boukris <iboukris@gmail.com>
+ Reported-by: Chungtsun Li (typeless)
+ Reviewed-by: Daniel Stenberg
+ Reviewed-by: Peter Wu
+ Closes #1197
+ Fixes #1061
-- http_digest.c: SIGSEGV and OOM handling fixes
+Daniel Stenberg (13 Jan 2017)
+- write-out.d: 'time_total' is not always shown with ms precision
+
+ We have higher resolution since 7.52.0
-- url.c: fix parse_login_details() OOM handling
+- next.d: --trace and --trace-ascii are also global
-- [John E. Malmberg brought this change]
+- [Isaac Boukris brought this change]
- setup-vms.h: sk_pop symbol tweak
+ curl: reset the easy handle at --next
- Newer versions of curl are referencing a sk_pop symbol while the HP
- OpenSSL library has the symbol in uppercase only.
+ So that only "global" options (verbose mostly) survive into the next
+ transfer, and the others have to be set again unless default is fine.
-- getinfo.c: fix enumerated type mixed with another type
+- [Frank Gevaerts brought this change]
-- test 1511: fix enumerated type mixed with another type
+ docs: Add note about libcurl copying strings to CURLOPT_* manpages
+
+ Closes #1169
-- url.c: fix SIGSEGV
+- [Frank Gevaerts brought this change]
-- dotdot.c: fix global declaration shadowing
+ CURLOPT_PREQUOTE.3: takes a struct curl_slist*, not a char*
-- easy.c: fix global declaration shadowing
+- IDN: Use TR46 non-transitional
+
+ Assisted-by: Tim Rühsen
-Kamil Dudka (9 Jul 2013)
-- Revert "curl.1: document the --time-cond option in the man page"
+- IDN: revert use of the transitional option
- This reverts commit 3a0e931fc715a80004958794a96b12cf90503f99 because
- the documentation of --time-cond was duplicated by mistake.
+ It made the german ß get converted to ss, IDNA2003 style, and we can't
+ have that for the .de TLD - a primary reason for our switch to IDNA2008.
- Reported by: Dave Reisner
-
-- curl.1: document the --sasl-ir option in the man page
-
-- curl.1: document the --post303 option in the man page
+ Test 165 verifies.
-- curl.1: document the --time-cond option in the man page
+- [Tim Rühsen brought this change]
-Yang Tse (9 Jul 2013)
-- configure: automake 1.14 compatibility tweak (use XC_AUTOMAKE)
-
-- xc-am-iface.m4: provide XC_AUTOMAKE macro
+ IDN: Fix compile time detection of linidn2 TR46
+
+ Follow-up to f30cbcac1
+
+ Closes #1207
-Guenter Knauf (8 Jul 2013)
-- Added winssl-zlib target to VC builds.
+- [ERAMOTO Masaya brought this change]
-- Synced Makefile.vc6 with recent changes.
+ url: --noproxy option overrides NO_PROXY environment variable
+
+ Under condition using http_proxy env var, noproxy list was the
+ combination of --noproxy option and NO_PROXY env var previously. Since
+ this commit, --noproxy option overrides NO_PROXY environment variable
+ even if use http_proxy env var.
- Issue posted to the list by malinowsky AT FTW DOT at.
+ Closes #1140
-- Added libmetalink URL; added Android versions.
+- [ERAMOTO Masaya brought this change]
-Dan Fandrich (3 Jul 2013)
-- examples: Moved usercertinmem.c to COMPLICATED_EXAMPLES
+ url: Refactor detect_proxy()
- This prevents it from being built during a "make check" since it
- depends on OpenSSL.
+ If defined CURL_DISABLE_HTTP, detect_proxy() returned NULL. If not
+ defined CURL_DISABLE_HTTP, detect_proxy() checked noproxy list.
+
+ Thus refactor to set proxy to NULL instead of calling detect_proxy() if
+ define CURL_DISABLE_HTTP, and refactor to call detect_proxy() if not
+ define CURL_DISABLE_HTTP and the host is not in the noproxy list.
-Nick Zitzmann (2 Jul 2013)
-- Merge branch 'master' of https://github.com/bagder/curl
+- [ERAMOTO Masaya brought this change]
-- darwinssl: SSLv2 connections are aborted if unsupported by the OS
+ url: Fix NO_PROXY env var to work properly with --proxy option.
+
+ The combination of --noproxy option and http_proxy env var works well
+ both for proxied hosts and non-proxied hosts.
- I just noticed that OS X no longer supports SSLv2. Other TLS engines return
- an error if the requested protocol isn't supported by the underlying
- engine, so we do that now for SSLv2 if the framework returns an error
- when trying to turn on SSLv2 support. (Note: As always, SSLv2 support is
- only enabled in curl when starting the app with the -2 argument; it's off
- by default. SSLv2 is really old and insecure.)
+ However, when combining NO_PROXY env var with --proxy option,
+ non-proxied hosts are not reachable while proxied host is OK.
+
+ This patch allows us to access non-proxied hosts even if using NO_PROXY
+ env var with --proxy option.
-Marc Hoersken (1 Jul 2013)
-- lib506.c: Fixed possible use of uninitialized variables
+- [Tim Rühsen brought this change]
-Kamil Dudka (30 Jun 2013)
-- url: restore the functionality of 'curl -u :'
+ IDN: Use TR46 'transitional' for toASCII translations
- This commit fixes a regression introduced in
- fddb7b44a79d78e05043e1c97e069308b6b85f79.
+ References: http://unicode.org/faq/idn.html
+ http://unicode.org/reports/tr46
- Reported by: Markus Moeller
- Bug: http://curl.haxx.se/mail/archive-2013-06/0052.html
+ Closes #1206
-Daniel Stenberg (25 Jun 2013)
-- digest: append the timer to the random for the nonce
+- [railsnewbie257 brought this change]
-- digest: improve nonce generation
+ docs: FAQ MAIL-ETIQUETTE language fixes
- Use the new improved Curl_rand() to generate better random nonce for
- Digest auth.
+ Closes #1194
-- curl.1: fix typo in --xattr description
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1252
- Reported-by: Jean-Noël Rouvignac
+- [Marcus Hoffmann brought this change]
-- RELEASE-NOTES: synced with 365c5ba39591
+ gnutls: check for alpn and ocsp in configure
- The 10 first bug fixes for the pending release...
+ Check for presence of gnutls_alpn_* and gnutls_ocsp_* functions during
+ configure instead of relying on the version number. GnuTLS has options
+ to turn these features off and we ca just work with with such builds
+ like we work with older versions.
+
+ Signed-off-by: Marcus Hoffmann <m.hoffmann@cartelsol.com>
+
+ Closes #1204
-- formpost: better random boundaries
+Jay Satiro (12 Jan 2017)
+- url: Fix parsing for when 'file' is the default protocol
- When doing multi-part formposts, libcurl used a pseudo-random value that
- was seeded with time(). This turns out to be bad for users who formpost
- data that is provided with users who then can guess how the boundary
- string will look like and then they can forge a different formpost part
- and trick the receiver.
+ Follow-up to 3463408.
- My advice to such implementors is (still even after this change) to not
- rely on the boundary strings being cryptographically strong. Fix your
- code and logic to not depend on them that much!
+ Prior to 3463408 file:// hostnames were silently stripped.
- I moved the Curl_rand() function into the sslgen.c source file now to be
- able to take advantage of the SSL library's random function if it
- provides one. If not, try to use the RANDOM_FILE for seeding and as a
- last resort keep the old logic, just modified to also add microseconds
- which makes it harder to properly guess the exact seed.
+ Prior to this commit it did not work when a schemeless url was used with
+ file as the default protocol.
- The formboundary() function in formdata.c is now using 64 bit entropy
- for the boundary and therefore the string of dashes was reduced by 4
- letters and there are 16 hex digits following it. The total length is
- thus still the same.
+ Ref: https://curl.haxx.se/mail/lib-2016-11/0081.html
+ Closes https://github.com/curl/curl/pull/1124
- Bug: http://curl.haxx.se/bug/view.cgi?id=1251
- Reported-by: "Floris"
-
-- printf: make sure %x are treated unsigned
+ Also fix for drive letters:
+
+ - Support --proto-default file c:/foo/bar.txt
- When using %x, the number must be treated as unsigned as otherwise it
- would get sign-extended on for example 64bit machines and do wrong
- output. This problem showed when doing printf("%08x", 0xffeeddcc) on a
- 64bit host.
+ - Support file://c:/foo/bar.txt
+
+ - Fail when a file:// drive letter is detected and not MSDOS/Windows.
+
+ Bug: https://github.com/curl/curl/issues/1187
+ Reported-by: Anatol Belski
+ Assisted-by: Anatol Belski
-- tests: add test1395 to the tarball
+Daniel Stenberg (12 Jan 2017)
+- rand: make it work without TLS backing
+
+ Regression introduced in commit f682156a4fc6c4
+
+ Reported-by: John Kohl
+ Bug: https://curl.haxx.se/mail/lib-2017-01/0055.html
-- SIGPIPE: don't use 'data' in sigpipe restore
+Jay Satiro (12 Jan 2017)
+- STARTTLS: Don't print response character in denied messages
- Follow-up fix from 7d80ed64e43515.
+ Both IMAP and POP3 response characters are used internally, but when
+ appended to the STARTTLS denial message likely could confuse the user.
- The SessionHandle may not be around to use when we restore the sigpipe
- sighandler so we store the no_signal boolean in the local struct to know
- if/how to restore.
+ Closes https://github.com/curl/curl/pull/1203
-- TODO: 1.8 Modified buffer size approach
+- smtp: Fix STARTTLS denied error message
- Thoughts around buffer sizes and what might be possible to do...
+ - Format the numeric denial code as an integer instead of a character.
-- c-ares: improve error message on failed resolve
+Daniel Stenberg (11 Jan 2017)
+- http2_send: avoid unsigned integer wrap around
- When the c-ares based resolver backend failed to resolve a name, it
- tried to show the name that failed from existing structs. This caused
- the wrong output and shown hostname when for example --interface
- [hostname] was used and that name resolving failed.
+ ... when checking for a too large request.
+
+Jay Satiro (9 Jan 2017)
+- [Jiri Malak brought this change]
+
+ cmake: Fix passing _WINSOCKAPI_ macro to compiler
- Now we use the hostname used in the actual resolve attempt in the error
- message as well.
+ Define _WINSOCKAPI_ blank rather than to 1 in order to match the value
+ used by Microsoft's winsock header files.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1191
- Reported-by: Kim Vandry
+ Closes https://github.com/curl/curl/pull/1195
-- ossl_recv: check for an OpenSSL error, don't assume
+Daniel Stenberg (9 Jan 2017)
+- sws: retry send() on EWOULDBLOCK
- When we recently started to treat a zero return code from SSL_read() as
- an error we also got false positives - which primarily looks to be
- because the OpenSSL documentation is wrong and a zero return code is not
- at all an error case in many situations.
+ Fixes spurious test 1060 and 1061 failures on OpenBSD, Solaris and more.
- Now ossl_recv() will check with ERR_get_error() to see if there is a
- stored error and only then consider it to be a true error if SSL_read()
- returned zero.
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1249
- Reported-by: Nach M. S.
- Patch-by: Nach M. S.
+ Bug: https://curl.haxx.se/mail/lib-2017-01/0009.html
+ Reported-by: Christian Weisgerber
-Nick Zitzmann (22 Jun 2013)
-- Merge branch 'master' of https://github.com/bagder/curl
+- RELEASE-NOTES: synced with a41e8592d6b3e58
-- darwinssl: fix crash that started happening in Lion
+- examples: make the C++ examples follow our code style too
- Something (a recent security update maybe?) changed in Lion, and now it
- has changed SSLCopyPeerTrust such that it may return noErr but also give
- us a null trust, which caught us off guard and caused an eventual crash.
+ At least mostly, not counting // comments.
-Daniel Stenberg (22 Jun 2013)
-- SIGPIPE: ignored while inside the library
+- [Aulddays brought this change]
+
+ asiohiper: improved socket handling
- ... and restore the ordinary handling again when it returns. This is
- done for curl_easy_perform() and curl_easy_cleanup() only for now - and
- only when built to use OpenSSL as backend as this is the known culprit
- for the spurious SIGPIPEs people have received.
+ libcurl requires CURLMOPT_SOCKETFUNCTION to KEEP watching socket events
+ and notify back. Modify event_cb() to continue watching events when
+ fired.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1180
- Reported by: Lluís Batlle i Rossell
+ Fixes #1191
+ Closes #1192
+ Fixed-by: Mingliang Zhu
-- KNOWN_BUGS: #83 unable to load non-default openssl engines
+- [Jiří Malák brought this change]
-- test1396: invoke the correct test tool!
+ lib506: fix build for Open Watcom
- This erroneously run unit test 1310 instead of 1396!
-
-Kamil Dudka (22 Jun 2013)
-- test1230: avoid using hard-wired port number
+ Rename symbol lock to locks to not clash with OW CRTL function name.
- ... to prevent failure when a non-default -b option is given
+ Closes #1196
-- curl-config.in: replace tabs by spaces
-
-Nick Zitzmann (22 Jun 2013)
-- darwinssl: reform OS-specific #defines
+- ROADMAP: 2017 cleanup
- This doesn't need to be in the release notes. I cleaned up a lot of the #if
- lines in the code to use MAC_OS_X_VERSION_MIN_REQUIRED and
- MAC_OS_X_VERSION_MAX_ALLOWED instead of checking for whether things like
- __MAC_10_6 or whatever were defined, because for some SDKs Apple has released
- they were defined out of place.
+ Removed items already fixed, clarified a few others.
-Daniel Stenberg (22 Jun 2013)
-- [Alessandro Ghedini brought this change]
+- COPYING: update the generic copyright year range
- docs: fix typo in curl_easy_getinfo manpage
+- docs/silent: mention --show-error in --silent description
+
+ Reported in #1190
+ Reported-by: Dan Jacobson
-- dotdot: introducing dot file path cleanup
+- docs/page-header: mention how to disable the progress meter
- RFC3986 details how a path part passed in as part of a URI should be
- "cleaned" from dot sequences before getting used. The described
- algorithm is now implemented in lib/dotdot.c with the accompanied test
- case in test 1395.
+ curl.1 is regenerated
- Bug: http://curl.haxx.se/bug/view.cgi?id=1200
- Reported-by: Alex Vinnik
+ Fixes #1190
-- bump: start working towards what most likely will become 7.32.0
+Dan Fandrich (7 Jan 2017)
+- wolfssl: display negotiated SSL version and cipher
-- THANKS: added 24 new contributors from the 7.31.0 release
+- wolfssl: support setting cipher list
-Version 7.31.0 (22 Jun 2013)
+Patrick Monnerat (6 Jan 2017)
+- CIPHERS.md: document GSKit ciphers
-Daniel Stenberg (22 Jun 2013)
-- RELEASE-NOTES: synced with 0de7249bb39a2 - 7.31.0
+Jay Satiro (5 Jan 2017)
+- [peterpih brought this change]
-- unit1396: unit tests to verify curl_easy_(un)escape
+ TheArtOfHttpScripting: grammar
-- Curl_urldecode: no peeking beyond end of input buffer
+Nick Zitzmann (3 Jan 2017)
+- darwinssl: --insecure overrides --cacert if both settings are in use
- Security problem: CVE-2013-2174
+ Fixes #1184
+
+Jay Satiro (2 Jan 2017)
+- docs/libcurl: TCP_KEEPALIVE start and interval default to 60
- If a program would give a string like "%FF" to curl_easy_unescape() but
- ask for it to decode only the first byte, it would still parse and
- decode the full hex sequence. The function then not only read beyond the
- allowed buffer but it would also deduct the *unsigned* counter variable
- for how many more bytes there's left to read in the buffer by two,
- making the counter wrap. Continuing this, the function would go on
- reading beyond the buffer and soon writing beyond the allocated target
- buffer...
+ Since the TCP keep-alive options were added in 705f0f7 the start and
+ interval default values have been 60, but that wasn't documented.
- Bug: http://curl.haxx.se/docs/adv_20130622.html
- Reported-by: Timo Sirainen
+ Bug: https://curl.haxx.se/mail/lib-2017-01/0000.html
+ Reported-by: Praveen Pvs
-Guenter Knauf (20 Jun 2013)
-- Use opened body.out file and write content to it.
-
-Daniel Stenberg (20 Jun 2013)
-- multi_socket: react on socket close immediately
-
- As a remedy to the problem when a socket gets closed and a new one is
- opened with the same file descriptor number and as a result
- multi.c:singlesocket() doesn't detect the difference, the new function
- Curl_multi_closed() gets told when a socket is closed so that it can be
- removed from the socket hash. When the old one has been removed, a new
- socket should be detected fine by the singlesocket() on next invoke.
+Daniel Stenberg (29 Dec 2016)
+- curl.h: CURLE_FUNCTION_NOT_FOUND is no longer in use
- Bug: http://curl.haxx.se/bug/view.cgi?id=1248
- Reported-by: Erik Johansson
+ This error code was once introduced when some library was dynamically
+ loaded and a funciton within said library couldn't be found.
-- RELEASE-NOTES: synced with e305f5ec715f
+- content_encoding: change return code on a failure
+
+ Failure to decompress is now a write error instead of the weird
+ "function not found".
-- TODO: mention the DANE patch from March
+- page-footer: error 36 is protocol agnostic!
-- CURLOPT_COOKIELIST: take cookie share lock
+Jay Satiro (28 Dec 2016)
+- tool_operate: Fix --remote-time incorrect times on Windows
- When performing COOKIELIST operations the cookie lock needs to be taken
- for the cases where the cookies are shared among multiple handles!
+ - Use Windows API SetFileTime to set the file time instead of utime.
- Verified by Benjamin Gilbert's updated test 506
+ Avoid utime on Windows if possible because it may apply a daylight
+ saving time offset to our UTC file time.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1215
- Reported-by: Benjamin Gilbert
-
-- [Benjamin Gilbert brought this change]
-
- test506: verify that CURLOPT_COOKIELIST takes share lock
+ Bug: https://curl.haxx.se/mail/archive-2016-11/0033.html
+ Reported-by: Tim
- It doesn't right now: http://curl.haxx.se/bug/view.cgi?id=1215
+ Closes https://github.com/curl/curl/pull/1121
-- TODO: HTTP2/SPDY support
+Daniel Stenberg (29 Dec 2016)
+- [Max Khon brought this change]
-- curl_easy_setopt.3: clarify CURLOPT_PROGRESSFUNCTION frequency
+ digest_sspi: copy terminating NUL as well
- Make it clearer that the CURLOPT_PROGRESSFUNCTION callback will be
- called more frequently than once per second when things are happening.
-
-- RELEASE-NOTES: synced with 9c3e098259b82
+ Curl_auth_decode_digest_http_message(): copy terminating NUL as later
+ Curl_override_sspi_http_realm() expects a NUL-terminated string.
- Mention 7 recent bug fixes and their associated contributors
+ Fixes #1180
-- curl_multi_wait.3: clarify the numfds counter
-
-- curl_easy_perform: avoid busy-looping
-
- When curl_multi_wait() finds no file descriptor to wait for, it returns
- instantly and this must be handled gracefully within curl_easy_perform()
- or cause a busy-loop. Starting now, repeated fast returns without any
- file descriptors is detected and a gradually increasing sleep will be
- used (up to a max of 1000 milliseconds) before continuing the loop.
+- curl_formadd.3: CURLFORM_CONTENTSLENGTH not needed when chunked
- Bug: http://curl.haxx.se/bug/view.cgi?id=1238
- Reported-by: Miguel Angel
+ Mentioned in #1013
-- [YAMADA Yasuharu brought this change]
+- [Kyselgov E.N brought this change]
- cookies: follow-up fix for path checking
+ cmake: use crypt32.lib when building with OpenSSL on windows
- The initial fix to only compare full path names were done in commit
- 04f52e9b4db0 but found out to be incomplete. This takes should make the
- change more complete and there's now two additional tests to verify
- (test 31 and 62).
+ Reviewed-by: Peter Wu
+ Closes #1149
+ Fixes #1147
-- [Sergei Nikulov brought this change]
+- [Chris Araman brought this change]
- lib1900: use tutil_tvnow instead of gettimeofday
+ darwinssl: fix CFArrayRef leak
- Makes it build on windows
-
-- [Eric Hu brought this change]
+ Reviewed-by: Nick Zitzmann
+ Closes #1173
- axtls: now done non-blocking
+- [Chris Araman brought this change]
-- [Eric Hu brought this change]
-
- test2033: requires NTLM support
-
-- KNOWN_BUGS: #82 failed build with Borland compiler
+ darwinssl: fix iOS build
+
+ Reviewed-by: Nick Zitzmann
+ Fixes #1172
-- Curl_output_digest: support auth-int for empty entity body
+- curl: remove superfluous include file
+
+ The <netinet/tcp.h> is a leftover from the past when TCP socket options
+ were set in this file. This include causes build issues on AIX 4.3.
- By always returning the md5 for an empty body when auth-int is asked
- for, libcurl now at least sometimes does the right thing.
+ Reported-by: Kim Minjoong
- Bug: http://curl.haxx.se/bug/view.cgi?id=1235
- Patched-by: Nach M. S.
+ Closes #1178
-- multi_socket: reduce timeout inaccuracy margin
+- RELEASE-NOTES: synced with a7b38c9dc98481e
+
+- vtls: s/SSLEAY/OPENSSL
- Allow less room for "triggered too early" mistakes by applications /
- timers on non-windows platforms. Starting now, we assume that a timeout
- call is never made earlier than 3 milliseconds before the actual
- timeout. This greatly improves timeout accuracy on Linux.
+ Fixed an old leftover use of the USE_SSLEAY define which would make a
+ socket get removed from the applications sockets to monitor when the
+ multi_socket API was used, leading to timeouts.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1228
- Reported-by: Hang Su
+ Bug: #1174
-- cert_stuff: avoid double free in the PKCS12 code
-
- In the pkcs12 code, we get a list of x509 records returned from
- PKCS12_parse but when iterating over the list and passing each to
- SSL_CTX_add_extra_chain_cert() we didn't also properly remove them from
- the "stack", which made them get freed twice (both in sk_X509_pop_free()
- and then later in SSL_CTX_free).
+- docs/ciphers: link to our own new page about ciphers
- This isn't really documented anywhere...
+ ... as the former ones always go stale!
+
+- cmdline-opts/page-footer: add three more exit codes
- Bug: http://curl.haxx.se/bug/view.cgi?id=1236
- Reported-by: Nikaiw
+ ... and regenerated curl.1
-- cert_stuff: remove code duplication in the pkcs12 logic
+- formdata: use NULL, not 0, when returning pointers
-- [Aleksey Tulinov brought this change]
+- ftp: failure to resolve proxy should return that error code
- axtls: honor disabled VERIFYHOST
+- configure: accept --with-libidn2 instead
+
+ ... which the help text already implied since we switched to libidn2
+ from libidn in commit 9c91ec778104ae3b back in October 2016.
- When VERIFYHOST == 0, libcurl should let invalid certificates to pass.
+ Reported-by: Christian Weisgerber
+ Bug: https://curl.haxx.se/mail/lib-2016-12/0110.html
-- [Peter Gal brought this change]
+- test1282: verify the ftp-gss check
- curl_easy_setopt.3: HTTP header with no content
+- ftp-gss: check for init before use
- Update the documentation on how to specify a HTTP header with no
- content.
-
-- RELEASE-NOTES: synced with 87cf677eca55
+ To avoid dereferencing a NULL pointer.
- Added 11 bugs and 7 contributors
+ Reported-by: Daniel Romero
-- lib1500: remove bad check
+Jay Satiro (24 Dec 2016)
+- build-wolfssl: Sync config with wolfSSL 3.10
- After curl_multi_wait() returns, this test checked that we got exactly
- one file descriptor told to read from, but we cannot be sure that is
- true. curl_multi_wait() will sometimes return earlier without any file
- descriptor to handle, just just because it is a suitable time to call
- *perform().
+ wolfSSL configure script relevant changes from 3.9 to 3.10:
- This problem showed up with commit 29bf0598.
+ - DES3 no longer enabled by default
+ - Shamir no longer enabled by default
+ - Extended master secret enabled by default
+ - RSA and ECC timing protections enabled by default
- Bug: http://curl.haxx.se/mail/lib-2013-06/0029.html
- Reported-by: Fabian Keil
+ For backwards compatibility I enabled DES3 and ECC shamir config options
+ (ie no change from 3.9), and the other changes are included.
-- tests/Makefile: typo in the perlcheck target
-
- Bug: http://curl.haxx.se/bug/view.cgi?id=1239
- Reported-by: Christian Weisgerber
+- cyassl: use time_t instead of long for timeout
-- test1230: verify CONNECT to a numerical ipv6-address
+Daniel Stenberg (23 Dec 2016)
+- bump: toward next release
-- sws: support extracting test number from CONNECT ipv6-address!
+- http: remove "Curl_http_done: called premature" message
- If an ipv6-address is provided to CONNECT, the last hexadecimal group in
- the address will be used as the test number! For example the address
- "[1234::ff]" would be treated as test case 255.
+ ... it only confuses people.
-- curl_multi_wait: only use internal timer if not -1
+- openssl-random: check return code when asking for random
- commit 29bf0598aad5 introduced a problem when the "internal" timeout is
- prefered to the given if shorter, as it didn't consider the case where
- -1 was returned. Now the internal timeout is only considered if not -1.
-
- Reported-by: Tor Arntsen
- Bug: http://curl.haxx.se/mail/lib-2013-06/0015.html
+ and fail appropriately if it returns error
-Dan Fandrich (3 Jun 2013)
-- libcurl-tutorial.3: added a section on IPv6
-
- Also added a (correctly-escaped) backslash to the autoexec.bat
- example file and a new Windows character device name with
- a colon as examples of other characters that are special
- and potentially dangerous (this reverts and reworks commit
- 7d8d2a54).
+- gnutls-random: check return code for failed random
-Daniel Stenberg (3 Jun 2013)
-- curl_multi_wait: reduce timeout if the multi handle wants to
-
- If the multi handle's pending timeout is less than what is passed into
- this function, it will now opt to use the shorter time anyway since it
- is a very good hint that the handle wants to process something in a
- shorter time than what otherwise would happen.
-
- curl_multi_wait.3 was updated accordingly to clarify
+Version 7.52.1 (22 Dec 2016)
+
+Daniel Stenberg (22 Dec 2016)
+- RELEASE-NOTES: curl 7.52.1
+
+- lib557.c: use a shorter MAXIMIZE representation
- This is the reason for bug #1224
+ Since several compilers had problems with the previous one
- Bug: http://curl.haxx.se/bug/view.cgi?id=1224
- Reported-by: Andrii Moiseiev
+ Reported-by: Ray Satiro
+ Bug: https://curl.haxx.se/mail/lib-2016-12/0098.html
-- multi_runsingle: switch an if() condition for readability
+- runtests: remove the valgrind parser
- ... because there's an identical check right next to it so using the
- operators in the check in the same order increases readability.
+ Old legacy parsing that 1) hid problems for us and 2) probably isn't
+ needed anymore.
-Marc Hoersken (2 Jun 2013)
-- curl_schannel.c: Removed variable unused since 35874298e4
+- [Kamil Dudka brought this change]
-- curl_setup.h: Fixed redefinition warning using mingw-w64
+ randit: store the value in the buffer
-Daniel Stenberg (30 May 2013)
-- multi_runsingle: add braces to clarify the code
-
-- libcurl-tutorial.3: remove incorrect backslash
-
- A single backslash in the content is not legal nroff syntax.
+- tests/Makefile: run checksrc on debug builds
- Reported and fixed by: Eric S. Raymond
- Bug: http://curl.haxx.se/bug/view.cgi?id=1234
+ ... just like we already do in src/ and lib/
-- curl_formadd.3: fixed wrong "end-marker" syntax
+- lib557: move the "enable LONGLINE" to allow more long lines
- Reported and fixed by: Eric S. Raymond
- Bug: http://curl.haxx.se/bug/view.cgi?id=1233
+ This file is riddled with them...
-- curl.1: clarify that --silent still outputs data
+- bump: toward next release
-- Digest auth: escape user names with \ or " in them
+Marcel Raad (21 Dec 2016)
+- lib: fix MSVC compiler warnings
- When sending the HTTP Authorization: header for digest, the user name
- needs to be escaped if it contains a double-quote or backslash.
-
- Test 1229 was added to verify
-
- Reported and fixed by: Nach M. S
- Bug: http://curl.haxx.se/bug/view.cgi?id=1230
+ Visual C++ complained:
+ warning C4267: '=': conversion from 'size_t' to 'long', possible loss of data
+ warning C4701: potentially uninitialized local variable 'path' used
-- [Mike Giancola brought this change]
+Version 7.52.0 (20 Dec 2016)
- ossl_recv: SSL_read() returning 0 is an error too
-
- SSL_read can return 0 for "not successful", according to the open SSL
- documentation: http://www.openssl.org/docs/ssl/SSL_read.html
+Daniel Stenberg (20 Dec 2016)
+- THANKS: 13 new contributors from 7.52.0
-- [Mike Giancola brought this change]
+- RELEASE-NOTES: 7.52.0
- ossl_send: SSL_write() returning 0 is an error too
-
- We found that in specific cases if the connection is abruptly closed,
- the underlying socket is listed in a close_wait state. We continue to
- call the curl_multi_perform, curl_mutli_fdset etc. None of these APIs
- report the socket closed / connection finished. Since we have cases
- where the multi connection is only used once, this can pose a problem
- for us. I've read that if another connection was to come in, curl would
- see the socket as bad and attempt to close it at that time -
- unfortunately, this does not work for us.
+- ssh: inhibit coverity warning with (void)
- I found that in specific situations, if SSL_write returns 0, curl did
- not recognize the socket as closed (or errored out) and did not report
- it to the application. I believe we need to change the code slightly, to
- check if ssl_write returns 0. If so, treat it as an error - the same as
- a negative return code.
-
- For OpenSSL - the ssl_write documentation is here:
- http://www.openssl.org/docs/ssl/SSL_write.html
+ CID 1397391 (#1 of 1): Unchecked return value (CHECKED_RETURN)
-- KNOWN_BUGS: curl -OJC- fails to resume
+- Curl_recv_has_postponed_data: silence compiler warnings
- Bug: http://curl.haxx.se/bug/view.cgi?id=1169
+ Follow-up to d00f2a8f2
-- Curl_cookie_add: handle IPv6 hosts
-
- 1 - don't skip host names with a colon in them in an attempt to bail out
- on HTTP headers in the cookie file parser. It was only a shortcut anyway
- and trying to parse a file with HTTP headers will still be handled, only
- slightly slower.
+Jay Satiro (19 Dec 2016)
+- tests: checksrc compliance
+
+- http_proxy: Fix proxy CONNECT hang on pending data
- 2 - don't skip domain names based on number of dots. The original
- netscape cookie spec had this oddity mentioned and while our code
- decreased the check to only check for two, the existing cookie spec has
- no such dot counting required.
+ - Check for pending data before waiting on the socket.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1221
- Reported-by: Stefan Neis
+ Bug: https://github.com/curl/curl/issues/1156
+ Reported-by: Adam Langley
+
+Daniel Stenberg (19 Dec 2016)
+- cmdline-opts/tlsv1.d: rephrased
-- curl_easy_setopt.3: expand the PROGRESSFUNCTION section
+- [Dan McNulty brought this change]
+
+ schannel: fix wildcard cert name validation on Win CE
- Explain the callback and its arguments better and with more descriptive
- text.
+ Fixes a few issues in manual wildcard cert name validation in
+ schannel support code for Win32 CE:
+ - when comparing the wildcard name to the hostname, the wildcard
+ character was removed from the cert name and the hostname
+ was checked to see if it ended with the modified cert name.
+ This allowed cert names like *.com to match the connection
+ hostname. This violates recommendations from RFC 6125.
+ - when the wildcard name in the certificate is longer than the
+ connection hostname, a buffer overread of the connection
+ hostname buffer would occur during the comparison of the
+ certificate name and the connection hostname.
-- tests: add test1394 file to the tarball
+- printf: fix floating point buffer overflow issues
+
+ ... and add a bunch of floating point printf tests
-- tarball: include the xmlstream example
+- config-amigaos.h: (embarrassed) made the line shorter
-- [David Strauss brought this change]
+- config-amigaos.h: fix bug report email reference
- xmlstream: XML stream parsing example source code
-
- Add an XML stream parsing example using Expat. Add missing ignore for
- the binary from an unrelated example.
+- RELEASE-NOTES: synced with 4517158abfeba
-- [YAMADA Yasuharu brought this change]
+- CIPHERS.md: backtick the names to show underscores fine
- cookies: only consider full path matches
-
- I found a bug which cURL sends cookies to the path not to aim at.
- For example:
- - cURL sends a request to http://example.fake/hoge/
- - server returns cookie which with path=/hoge;
- the point is there is NOT the '/' end of path string.
- - cURL sends a request to http://example.fake/hogege/ with the cookie.
+- form-string.d: fix format mistake
- The reason for this old "feature" is because that behavior is what is
- described in the original netscape cookie spec:
- http://curl.haxx.se/rfc/cookie_spec.html
+ and regenerated curl.1
- The current cookie spec (RFC6265) clarifies the situation:
- http://tools.ietf.org/html/rfc6265#section-5.2.4
+ Reported-by: Gisle Vanem
-- [Eric Hu brought this change]
+Michael Kaufmann (18 Dec 2016)
+- openssl: simplify expression in Curl_ossl_version
- axtls: prevent memleaks on SSL handshake failures
-
-- Revert "WIN32 MemoryTracking: track wcsdup() _wcsdup() and _tcsdup() usage"
+- curl_easy_recv: Improve documentation and example program
- This reverts commit 8ec2cb5544b86306b702484ea785b6b9596562ab.
+ Follow-up to 82245ea: Fix the example program sendrecv.c (handle
+ CURLE_AGAIN, handle incomplete send). Improve the documentation
+ for curl_easy_recv() and curl_easy_send().
- We don't have any code anywhere in libcurl (or the curl tool) that use
- wcsdup so there's no such memory use to track. It seems to cause mild
- problems with the Borland compiler though that we may avoid by reverting
- this change again.
+ Reviewed-by: Frank Meier
+ Assisted-by: Jay Satiro
- Bug: http://curl.haxx.se/mail/lib-2013-05/0070.html
-
-- RELEASE-NOTES: synced with ae26ee3489588f0
-
-Guenter Knauf (11 May 2013)
-- Updated zlib version in build files.
-
-Daniel Stenberg (9 May 2013)
-- [Renaud Guillard brought this change]
+ See https://github.com/curl/curl/pull/1134
- OS X framework: fix invalid symbolic link
+- [Isaac Boukris brought this change]
-Kamil Dudka (9 May 2013)
-- [Daniel Stenberg brought this change]
-
- nss: give PR_INTERVAL_NO_WAIT instead of -1 to PR_Recv/PR_Send
+ Curl_getconnectinfo: avoid checking if the connection is closed
- Reported by: David Strauss
- Bug: http://curl.haxx.se/mail/lib-2013-05/0088.html
-
-Daniel Stenberg (8 May 2013)
-- libtest: gitignore more binary files
-
-- servercert: allow empty subject
+ It doesn't benefit us much as the connection could get closed at
+ any time, and also by checking we lose the ability to determine
+ if the socket was closed by reading zero bytes.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1220
- Patch by: John Gardiner Myers
-
-- [Steve Holme brought this change]
-
- tests: Added new SMTP tests to verify commit 99b40451836d
-
-- runtests.pl: support nonewline="yes" in client/stdin sections
+ Reported-by: Michael Kaufmann
+
+ Closes https://github.com/curl/curl/pull/1134
-- build: fixed unit1394 for debug and metlink builds
+Daniel Stenberg (18 Dec 2016)
+- CIPHERS.md: attempt to document TLS cipher names
+
+ As the official docs seems really hard to keep track of and link to over
+ time
-Kamil Dudka (6 May 2013)
-- unit1394.c: plug the curl tool unit test in
+- curl.1: generated after 6cce4dbf830
-- [Jared Jennings brought this change]
+- cmdline-opts/post30X.d: fix the RFC references
- unit1394.c: basis of a unit test for parse_cert_parameter()
+- curl.1: regenerated
+
+ Fixed trailing whitespace and numerous formatting glitches
-- src/Makefile.am: build static lib for unit tests if enabled
+- cmdline-opts: formatting fixes
-- tool_getparam: ensure string termination in parse_cert_parameter()
+- curl_easy_setopt.3: removed CURLOPT_SOCKS_PROXYTYPE
-- tool_getparam: fix memleak in handling the -E option
+- tool_getparam.c: make comments use the up-to-date option names
-- tool_getparam: describe what parse_cert_parameter() does
+- manpage-scan.pl: allow deprecated options to get removed from curl.1
- ... and de-duplicate the code initializing *passphrase
-
-- curl.1: document escape sequences recognized by -E
+ --krb4, --ftp-ssl and --ftp-ssl-reqd no longer need to be documented in the
+ man page
-- [Jared Jennings brought this change]
+- cmdline-opts/gen.pl: trim off trailing spaces
- curl -E: allow to escape ':' in cert nickname
+- cmdline-opts/proxy-tlsuser.d: remove trailing .d
-Marc Hoersken (5 May 2013)
-- curl_schannel.c: Fixed invalid memory access during SSL shutdown
+- curl_easy_setopt.3: CURLOPT_PRE_PROXY instead of CURLOPT_SOCKS_PROXY
-Steve Holme (4 May 2013)
-- smtp: Fix trailing whitespace warning
+- symbols: removed two, added one
-- smtp: Fix compilation warning
-
- comparison between signed and unsigned integer expressions
-
-- RELEASE-NOTES: synced with 92ef5f19c801
+- cmdline-opts: include the man page split up files in the dist
-- smtp: Updated RFC-2821 references to RFC-5321
-
-- smtp: Fixed sending of double CRLF caused by first in EOB
+- curl.1: generated with gen.pl
- If the mail sent during the transfer contains a terminating <CRLF> then
- we should not send the first <CRLF> of the EOB as specified in RFC-5321.
+ This is the first time we replace the manually edited curt.1 with the
+ generated one created by gen.pl and the individual option documentation
+ pages.
- Additionally don't send the <CRLF> if there is "no mail data" as the
- DATA command already includes it.
-
-- tests: Corrected MAIL SIZE for CRLF line endings
+ Do not edit this file, edit the individual pages and regenerate this
+ output.
- ... which was missed in commit: f5c3d9538452
+ This file will be generated by the build system soon and then removed
+ from git.
-- tests: Corrected infilesize for CRLF line endings
-
- ... which was missed in commit: f5c3d9538452
+- cmdline-opts: added some missing info
-- tests: Corrected test1406 to be RFC2821 compliant
+- CURLINFO_SSL_VERIFYRESULT.3: language
-- tests: Corrected test1320 to be RFC2821 compliant
+- HTTPS-PROXY docs: update/polish
-- tests: Corrected typo in test909
+- cmdline-opts/page-header: mention it is generated
- Introduced in commit: 514817669e9e
-
-- tests: Corrected test909 to be RFC2821 compliant
+ ... to avoid people from trying to edit the pending curl.1 version that
+ gets generated by gen.pl
-- tests: Updated test references to 909 from 1411
+- preproxy: renamed what was added as SOCKS_PROXY
- ...and removed references to libcurl and test1406.
-
-- tests: Renamed test1411 to test909 as this is a main SMTP test
-
-Daniel Stenberg (1 May 2013)
-- [Lars Johannesen brought this change]
+ CURLOPT_SOCKS_PROXY -> CURLOPT_PRE_PROXY
+
+ Added the corresponding --preroxy command line option. Sets a SOCKS
+ proxy to connect to _before_ connecting to a HTTP(S) proxy.
- bindlocal: move brace out of #ifdef
+- curl: normal socks proxies still use CURLOPT_PROXY
- The code within #ifdef HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID wrongly had two
- closing braces when it should only have one, so builds without that
- define would fail.
+ ... the newly introduced CURLOPT_SOCKS_PROXY is special and should be
+ asked for specially. (Needs new code.)
- Bug: http://curl.haxx.se/mail/lib-2013-05/0000.html
+ Unified proxy type to a single variable in the config struct.
-Steve Holme (30 Apr 2013)
-- smtp: Tidy up to move the eob counter to the per-request structure
+- CURLOPT_SOCKS_PROXYTYPE: removed
- Move the eob counter from the smtp_conn structure to the SMTP structure
- as it is associated with a SMTP payload on a per-request basis.
+ This was added as part of the SOCKS+HTTPS proxy merge but there's no
+ need to support this as we prefer to have the protocol specified as a
+ prefix instead.
-- TODO: Updated following the addition of CURLOPT_SASL_IR
+- curl_multi_socket.3: fix typo
-- smtp: Fixed unknown percentage complete in progress bar
+- checksrc: warn for assignments within if() expressions
- The curl command line utility would display the the completed progress
- bar with a percentage of zero as the progress routines didn't know the
- size of the transfer.
+ ... they're already frowned upon in our source code style guide, this
+ now enforces the rule harder.
-Daniel Stenberg (29 Apr 2013)
-- ftpserver: silence warnings
+- checksrc: stricter no-space-before-paren enforcement
- Fix regressions in commit b56e3d43e5d. Make @data local and filter off
- non-numerical digits from $testno in STATUS_imap.
+ In order to make the code style more uniform everywhere
-Steve Holme (29 Apr 2013)
-- ftpserver.pl: Corrected the imap LOGIN response
-
- ...to be more realistic and consistent with the other imap responses.
+- ISSUE_TEMPLATE: try mentioning known bugs/todo in new issue template
-- tests: Added imap STATUS command test
+- RELEASE-NOTES: synced with 71a55534fa6
-- tests: Corrected the SMTP tests to be RFC2821 compliant
+- [Adam Langley brought this change]
+
+ openssl: don't use OpenSSL's ERR_PACK.
- The emails that are sent to the server during these tests were
- incorrectly formatted as they contained one or more LF terminated lines
- rather than being CRLF terminated as per Section 2.3.7 of RFC-2821.
+ ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
+ function name must be specified which is overly specific: the test will
+ break whenever OpenSSL internally change things so that a different
+ function creates the error.
- This wasn't a problem for the test suite as the <stdin> data matched the
- <upload> data but anyone using these tests as reference would be sending
- incorrect data to a server.
+ Closes #1157
-- email: Tidy up of *_perform_authenticate()
-
- Removed the hard returns from imap and pop3 by using the same style for
- sending the authentication string as smtp. Moved the "Other mechanisms
- not supported" check in smtp to match that of imap and pop3 to provide
- consistency between the three email protocols.
+Dan Fandrich (5 Dec 2016)
+- test2032: Mark test as flaky
-- smtp: Updated limit check to be more readable like the check in pop3
+Jay Satiro (3 Dec 2016)
+- [Jeremy Pearson brought this change]
-- pop3: Added 255 octet limit check when sending initial response
+ libcurl-multi.3: typo
- Added 255 octet limit check as per Section 4. Paragraph 8 of RFC-5034.
+ Closes https://github.com/curl/curl/pull/1153
-- DOCS: Corrected line length of recent Secure Transport changes
+Dan Fandrich (2 Dec 2016)
+- test1281: added http as a required feature
-Nick Zitzmann (27 Apr 2013)
-- darwinssl: add TLS crypto authentication
+Daniel Stenberg (2 Dec 2016)
+- curl: support zero-length argument strings in config files
- Users using the Secure Transport (darwinssl) back-end can now use a
- certificate and private key to authenticate with a site using TLS. Because
- Apple's security system is based around the keychain and does not have any
- non-public function to create a SecIdentityRef data structure from data
- loaded outside of the Keychain, the certificate and private key have to be
- loaded into the Keychain first (using the certtool command line tool or
- the Security framework's C API) before we can find it and use it.
-
-Steve Holme (27 Apr 2013)
-- Corrected version numbers after bump
-
-Daniel Stenberg (27 Apr 2013)
-- bump version
+ ... like 'user-agent = ""'
- Since we're adding new stuff, the next release will bump the minor
- version and we're looking forward to 7.31.0
+ Adjusted test 71 to verify.
-Steve Holme (27 Apr 2013)
-- RELEASE-NOTES: synced with f4e6e201b146
-
-- DOCS: Updated following the addition of CURLOPT_SASL_IR
+- http_proxy: simplify CONNECT response reading
- Documented the the option in curl_easy_setopt() and added it to
- symbols-in-versions.
-
-- tests: Corrected command line arguments in test907 and test908
+ Since it now reads responses one byte a time, a loop could be removed
+ and it is no longer limited to get the whole response within 16K, it is
+ now instead only limited to 16K maximum header line lengths.
-- tests: Added SMTP AUTH with initial response tests
-
-- tests: Updated SMTP tests to decouple client initial response
+- tests: fix CONNECT test cases to be more strict
- Updated test903 and test904 following the addition of CURLOPT_SASL_IR
- as the default behaviour of SMTP AUTH responses is now to not include
- the initial response. New tests with --sasl-ir support to follow.
+ ... as they broke with the cleaned up CONNECT handling
-- imap: Added support for overriding the SASL initial response
+- CONNECT: read responses one byte at a time
+
+ ... so that it doesn't read data that is actually coming from the
+ remote. 2xx responses have no body from the proxy, that data is from the
+ peer.
- In addition to checking for the SASL-IR capability the user can override
- the sending of the client's initial response in the AUTHENTICATION
- command with the use of CURLOPT_SASL_IR should the server erroneously
- not report SASL-IR when it does support it.
+ Fixes #1132
-- smtp: Added support for disabling the SASL initial response
+- CONNECT: reject TE or CL in 2xx responses
- Updated the default behaviour of sending the client's initial response in the AUTH
- command to not send it and added support for CURLOPT_SASL_IR to allow the user to
- specify including the response.
+ A server MUST NOT send any Transfer-Encoding or Content-Length header
+ fields in a 2xx (Successful) response to CONNECT. (RFC 7231 section
+ 4.3.6)
- Related Bug: http://curl.haxx.se/mail/lib-2012-03/0114.html
- Reported-by: Gokhan Sengun
+ Also fixes the three test cases that did this.
-- pop3: Added support for enabling the SASL initial response
+- URL parser: reject non-numerical port numbers
- Allowed the user to specify whether to send the client's intial response
- in the AUTH command via CURLOPT_SASL_IR.
-
-- sasl-ir: Added --sasl-ir option to curl command line tool
-
-- sasl-ir: Added CURLOPT_SASL_IR to enable/disable the SASL initial response
+ Test 1281 added to verify
-Daniel Stenberg (26 Apr 2013)
-- curl_easy_init: use less mallocs
-
- By introducing an internal alternative to curl_multi_init() that accepts
- parameters to set the hash sizes, easy handles will now use tiny socket
- and connection hash tables since it will only ever add a single easy
- handle to that multi handle.
-
- This decreased the number mallocs in test 40 (which is a rather simple
- and typical easy interface use case) from 1142 to 138. The maximum
- amount of memory allocated used went down from 118969 to 78805.
+Dan Fandrich (30 Nov 2016)
+- runtests: made Servers: output be more consistent by removing OFF
-Steve Holme (26 Apr 2013)
-- ftpserver.pl: Fixed imap logout confirmation data
-
- An IMAP server should response with the BYE continuation response before
- confirming the LOGOUT command was successful.
+- cyassl: fixed typo introduced in 4f8b1774
-Daniel Stenberg (26 Apr 2013)
-- ftp_state_pasv_resp: connect through proxy also when set by env
+Michael Kaufmann (30 Nov 2016)
+- CURLOPT_CONNECT_TO: Skip non-matching "connect-to" entries properly
- When connecting back to an FTP server after having sent PASV/EPSV,
- libcurl sometimes didn't use the proxy properly even though the proxy
- was used for the initial connect.
+ If a port number in a "connect-to" entry does not match, skip this
+ entry instead of connecting to port 0.
- The function wrongly checked for the CURLOPT_PROXY variable to be set,
- which made it act wrongly if the proxy information was set with an
- environment variable.
+ If a port number in a "connect-to" entry matches, use this entry
+ and look no further.
- Added test case 711 to verify (based on 707 which uses --socks5). Also
- added test712 to verify another variation of setting the proxy: with
- --proxy socks5://
+ Reported-by: Jay Satiro
+ Assisted-by: Jay Satiro, Daniel Stenberg
- Bug: http://curl.haxx.se/bug/view.cgi?id=1218
- Reported-by: Zekun Ni
+ Closes #1148
+
+Daniel Stenberg (29 Nov 2016)
+- BUGS: describe bug handling process
-Kamil Dudka (26 Apr 2013)
-- [Zdenek Pavlas brought this change]
+- RELEASE-NOTES: synced with 19613fb3
- url: initialize speed-check data for file:// protocol
+Jay Satiro (28 Nov 2016)
+- http2: check nghttp2_session_set_local_window_size exists
- ... in order to prevent an artificial timeout event based on stale
- speed-check data from a previous network transfer. This commit fixes
- a regression caused by 9dd85bced56f6951107f69e581c872c1e7e3e58e.
+ The function only exists since nghttp2 1.12.0.
- Bug: https://bugzilla.redhat.com/906031
+ Bug: https://github.com/curl/curl/commit/a4d8888#commitcomment-19985676
+ Reported-by: Michael Kaufmann
-Daniel Stenberg (25 Apr 2013)
-- test709: clarify the test in the name
+Daniel Stenberg (28 Nov 2016)
+- [Anders Bakken brought this change]
-- sshserver: disable StrictHostKeyChecking
+ http2: Fix crashes when parent stream gets aborted
- I couldn't figure out why the host key logic isn't working, but having
- it set to yes prevents my SSH-based test cases to run. I also don't see
- a strong need to use strict host key checking on this test server.
-
- So I disabled it.
+ Closes #1125
-- runtests: log more commands in verbose mode
+- cmdline-docs: more options converted and fixed
- ... to aid tracking down failures
+ Now all options are in the new system.
-Steve Holme (25 Apr 2013)
-- TODO: Corrected copy/paste typo
+- gen: include footer in mainpage output
-- TODO: Added new ideas for future SMTP, POP3 and IMAP features
+Jay Satiro (28 Nov 2016)
+- lib1536: checksrc compliance
-- TODO: Updated following the addition of ;auth=<MECH> support
+Daniel Stenberg (28 Nov 2016)
+- cmdline-opts: more command line options documented
+
+ Moved over to the new format
-- DOCS: Minor rewording / clarification of host name protocol detection
+- curl: remove --proxy-ssl* options
+
+ There's mostly likely no need to allow setting SSLv2/3 version for HTTPS
+ proxy. Those protocols are insecure by design and deprecated.
-- RELEASE-NOTES: synced with a8c92cb60890
+- CURLOPT_PROXY_*.3: polished some proxy option man pages
-- DOCS: Added reference to IETF draft for SMTP URL Interface
+Patrick Monnerat (26 Nov 2016)
+- os400: support CURLOPT_PROXY_PINNEDPUBLICKEY
- ...when mentioning login options. Additional minor clarification of
- "Windows builds" to be "Windows builds with SSPI"as a way of enabling
- NTLM as Windows builds may be built with OpenSSL to enable NTLM or
- without NTLM support altogether.
+ Also define it in ILE/RPG binding.
-Linus Nielsen Feltzing (23 Apr 2013)
-- HISTORY: Fix spelling error.
+Daniel Stenberg (26 Nov 2016)
+- [Okhin Vasilij brought this change]
-Steve Holme (23 Apr 2013)
-- DOCS: Reworked the scheme calculation explanation under CURLOPT_URL
+ curl_version_info: add CURL_VERSION_HTTPS_PROXY
+
+ Closes #1142
-- url: Added smtp and pop3 hostnames to the protocol detection list
+- [Frank Gevaerts brought this change]
-Daniel Stenberg (23 Apr 2013)
-- HISTORY: correct some years/dates
+ tests: Add some testcases for recent new features.
- Thanks to archive.org's wayback machine I updated this document with
- some facts from the early httpget/urlget web page:
+ Add missing tests for CURLINFO_SCHEME, CURLINFO_PROTOCOL, %{scheme},
+ and %{http_version}
- http://web.archive.org/web/19980216125115/http://www.inf.ufrgs.br/~sagula/urlget.html
+ closes #1143
-- [Alessandro Ghedini brought this change]
+- [Frank Gevaerts brought this change]
- tests: add test1511 to check timecond clean-up
-
- Verifies the timecond fix in commit c49ed0b6c0f
+ curl_easy_reset: clear info for CULRINFO_PROTOCOL and CURLINFO_SCHEME
-- [Alessandro Ghedini brought this change]
+- CURLOPT_PROXY_CAINFO.3: clarify proxy use
+
+- CURLOPT_PROXY_CRLFILE.3: clarify https proxy and availability
- getinfo.c: reset timecond when clearing session-info variables
+- curl_easy_setopt.3: add CURLOPT_PROXY_PINNEDPUBLICKEY
- Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=705783
- Reported-by: Ludovico Cavedon <cavedon@debian.org>
+ Follow-up to 4f8b17743d7c55a
-Steve Holme (22 Apr 2013)
-- DOCS: Added information about login options to CURLOPT_USERPWD
+- docs: include all opts man pages in dist
+
+ Sorted the lists too.
+
+ ... and include the new ones in the PDF and HTML generation targets
-- DOCS: Added information about login options in the URL
+- [Thomas Glanzmann brought this change]
-- url: Fixed missing length check in parse_proxy()
-
- Commit 11332577b3cb removed the length check that was performed by the
- old scanf() code.
+ HTTPS Proxy: Implement CURLOPT_PROXY_PINNEDPUBLICKEY
-- url: Fixed crash when no username or password supplied for proxy
-
- Fixed an issue in parse_proxy(), introduced in commit 11332577b3cb,
- where an empty username or password (For example: http://:@example.com)
- would cause a crash.
+- [Thomas Glanzmann brought this change]
-- url: Removed unused text length constants
+ url: proxy: Use 443 as default port for https proxies
-- url: Updated proxy URL parsing to use parse_login_details()
+- TODO: removed "HTTPS proxy"
-- url: Tidy up of setstropt_userpwd() parameters
+- [Jan-E brought this change]
+
+ winbuild: add config option ENABLE_NGHTTP2
- Updated the naming convention of the login parameters to match those of
- other functions.
+ Closes #1141
-- url: Tidy up of code and comments following recent changes
+Jay Satiro (24 Nov 2016)
+- tool_urlglob: Improve sanity check in glob_range
+
+ Prior to this change we depended on errno if strtol could not perform a
+ conversion. POSIX says EINVAL *may* be set. Some implementations like
+ Microsoft's will not set it if there's no conversion.
- Tidy up of variable names and comments in setstropt_userpwd() and
- parse_login_details().
+ Ref: https://github.com/curl/curl/commit/ee4f7660#commitcomment-19658189
-- url: Simplified setstropt_userpwd() following recent changes
+- tool_help: Change description for --retry-connrefused
- There is no need to perform separate clearing of data if a NULL option
- pointer is passed in. Instead this operation can be performed by simply
- not calling parse_login_details() and letting the rest of the code do
- the work.
+ Ref: https://github.com/curl/curl/pull/1064#issuecomment-260052409
-- url: Correction to scope of if statements when setting data
+Patrick Monnerat (25 Nov 2016)
+- os400: sync ILE/RPG binding
+
+Jay Satiro (24 Nov 2016)
+- test1135: Fix curl_easy_duphandle prototype for code style
+
+ Follow-up to dbadaeb which changed the style.
-- url: Fixed memory leak in setstropt_userpwd()
+- x509asn1: Restore the parameter check in Curl_getASN1Element
- setstropt_userpwd() was calling setstropt() in commit fddb7b44a79d to
- set each of the login details which would duplicate the strings and
- subsequently cause a memory leak.
+ - Restore the removed parts of the parameter check.
+
+ Follow-up to 945f60e which altered the parameter check.
-- RELEASE-NOTES: synced with d535c4a2e1f7
+Daniel Stenberg (25 Nov 2016)
+- RELEASE-NOTES: update option counters
-- url: Added overriding of URL login options from CURLOPT_USERPWD
+- [Frank Gevaerts brought this change]
-- tool_paramhlp: Fixed options being included in username
+ add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
- Fix to prevent the options from being displayed when curl requests the
- user's password if the following command line is specified:
+ Adds access to the effectively used protocol/scheme to both libcurl and
+ curl, both in string and numeric (CURLPROTO_*) form.
- --user username;options
-
-- url: Added support for parsing login options from the CURLOPT_USERPWD
+ Note that the string form will be uppercase, as it is just the internal
+ string.
- In addition to parsing the optional login options from the URL, added
- support for parsing them from CURLOPT_USERPWD, to allow the following
- supported command line:
+ As these strings are declared internally as const, and all other strings
+ returned by curl_easy_getinfo() are de-facto const as well, string
+ handling in getinfo.c got const-ified.
- --user username:password;options
+ Closes #1137
-- url: Added bounds checking to parse_login_details()
-
- Added bounds checking when searching for the separator characters within
- the login string as this string may not be NULL terminated (For example
- it is the login part of a URL). We do this in preference to allocating a
- new string to copy the login details into which could then be passed to
- parse_login_details() for performance reasons.
+- RELEASE-NOTES: synced with 63198a4750aeb
-- url: Added size_t cast to pointer based length calculations
+- curl.1: the new --proxy options ship in 7.52.0
-- url: Corrected minor typo in comment
+- checksrc: move open braces to comply with function declaration style
-Daniel Stenberg (18 Apr 2013)
-- CURL_CHECK_CA_BUNDLE: don't check for paths when cross-compiling
-
- When cross-compiling we can't scan and detect existing files or paths.
-
- Bug: http://curl.haxx.se/mail/lib-2013-04/0294.html
+- checksrc: detect wrongly placed open braces in func declarations
-- [Ishan SinghLevett brought this change]
+- checksrc: white space edits to comply to stricter checksrc
- usercertinmem.c: add example showing user cert in memory
+- checksrc: verify ASTERISKNOSPACE
- Relies on CURLOPT_SSL_CTX_FUNCTION, which is OpenSSL specific
-
-Steve Holme (18 Apr 2013)
-- url: Fix chksrc longer than 79 columns warning
+ Detects (char*) and 'char*foo' uses.
-- url: Fix incorrect variable type for result code
+- checksrc: code style: use 'char *name' style
-- url: Fix compiler warning
+- checksrc: add ASTERISKSPACE
- signed and unsigned type in conditional expression
+ Verifies a 'char *name' style, with no space after the asterisk.
-- url: Moved parsing of login details out of parse_url_login()
+- openssl: remove dead code
- Separated the parsing of login details from the processing of them in
- parse_url_login() ready for use by setstropt_userpwd().
+ Coverity CID 1394666
-- url: Re-factored set_userpass() and parse_url_userpass()
-
- Re-factored these functions to reflect their new behaviour following the
- addition of login options.
+- [Okhin Vasilij brought this change]
-- url: Reworked URL parsing to allow overriding by CURLOPT_USERPWD
+ HTTPS-proxy: fixed mbedtls and polishing
-Daniel Stenberg (18 Apr 2013)
-- maketgz: make bzip2 creation work with Parallel BZIP2 too
+- darwinssl: adopted to the HTTPS proxy changes
- Apparently the previous usage didn't work with that implementation,
- while this updated version works with at least both Parallel BZIP2
- v1.1.8 and regular bzip "Version 1.0.6, 6-Sept-2010".
-
-Linus Nielsen Feltzing (18 Apr 2013)
-- Add tests/http_pipe.py to the tarball build
+ It builds and runs all test cases. No adaptations for actual HTTPS proxy
+ support has been made.
-Steve Holme (16 Apr 2013)
-- smtp: Re-factored all perform based functions
+- gtls: fix indent to silence compiler warning
- Standardised the naming of all perform based functions to be in the form
- smtp_perform_something().
+ vtls/gtls.c: In function ‘Curl_gtls_data_pending’:
+ vtls/gtls.c:1429:3: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
+ if(conn->proxy_ssl[connindex].session &&
+ ^~
+ vtls/gtls.c:1433:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
+ return res;
-- smtp: Added description comments to all perform based functions
+- [Thomas Glanzmann brought this change]
-- smtp: Moved smtp_quit() to be with the other perform functions
+ mbedtls: Fix compile errors
-- smtp: Moved smtp_rcpt_to() to be with the other perform functions
+- [Alex Rousskov brought this change]
-- smtp: Moved smtp_mail() to be with the other perform functions
-
-Daniel Stenberg (16 Apr 2013)
-- [Wouter Van Rooy brought this change]
-
- curl-config: don't output static libs when they are disabled
+ proxy: Support HTTPS proxy and SOCKS+HTTP(s)
- Curl-config outputs static libraries even when they are disabled in
- configure.
+ * HTTPS proxies:
- This causes problems with the build of pycurl.
-
-- [Dave Reisner brought this change]
-
- docs/libcurl: fix formatting in manpage
+ An HTTPS proxy receives all transactions over an SSL/TLS connection.
+ Once a secure connection with the proxy is established, the user agent
+ uses the proxy as usual, including sending CONNECT requests to instruct
+ the proxy to establish a [usually secure] TCP tunnel with an origin
+ server. HTTPS proxies protect nearly all aspects of user-proxy
+ communications as opposed to HTTP proxies that receive all requests
+ (including CONNECT requests) in vulnerable clear text.
- Commit c3ea3eb6 introduced some minor cosmetic errors in
- curl_mutli_socket_action(3).
-
-- [Paul Howarth brought this change]
-
- Add extra libs for lib1900 and lib2033 test programs
+ With HTTPS proxies, it is possible to have two concurrent _nested_
+ SSL/TLS sessions: the "outer" one between the user agent and the proxy
+ and the "inner" one between the user agent and the origin server
+ (through the proxy). This change adds supports for such nested sessions
+ as well.
- These are needed in cases where clock_gettime is used, from librt.
-
-Dan Fandrich (15 Apr 2013)
-- FAQ: mention that the network connection can be monitored
+ A secure connection with a proxy requires its own set of the usual SSL
+ options (their actual descriptions differ and need polishing, see TODO):
- Also note the prohibition on sharing handles across threads.
-
-Steve Holme (15 Apr 2013)
-- pop3: Added missing comment for pop3_state_apop_resp()
-
-- smtp: Updated the coding style of smtp_state_servergreet_resp()
+ --proxy-cacert FILE CA certificate to verify peer against
+ --proxy-capath DIR CA directory to verify peer against
+ --proxy-cert CERT[:PASSWD] Client certificate file and password
+ --proxy-cert-type TYPE Certificate file type (DER/PEM/ENG)
+ --proxy-ciphers LIST SSL ciphers to use
+ --proxy-crlfile FILE Get a CRL list in PEM format from the file
+ --proxy-insecure Allow connections to proxies with bad certs
+ --proxy-key KEY Private key file name
+ --proxy-key-type TYPE Private key file type (DER/PEM/ENG)
+ --proxy-pass PASS Pass phrase for the private key
+ --proxy-ssl-allow-beast Allow security flaw to improve interop
+ --proxy-sslv2 Use SSLv2
+ --proxy-sslv3 Use SSLv3
+ --proxy-tlsv1 Use TLSv1
+ --proxy-tlsuser USER TLS username
+ --proxy-tlspassword STRING TLS password
+ --proxy-tlsauthtype STRING TLS authentication type (default SRP)
- Updated the coding style, in this function, to be consistant with other
- response functions rather then performing a hard return on failure.
-
-- pop3: Updated the coding style of pop3_state_servergreet_resp()
+ All --proxy-foo options are independent from their --foo counterparts,
+ except --proxy-crlfile which defaults to --crlfile and --proxy-capath
+ which defaults to --capath.
- Updated the coding style, in this function, to be consistent with other
- response functions rather then performing a hard return on failure.
-
-- pop3: Re-factored all perform based functions
+ Curl now also supports %{proxy_ssl_verify_result} --write-out variable,
+ similar to the existing %{ssl_verify_result} variable.
+
+ Supported backends: OpenSSL, GnuTLS, and NSS.
- Standardised the naming of all perform based functions to be in the form
- pop3_perform_something() following the changes made to IMAP.
+ * A SOCKS proxy + HTTP/HTTPS proxy combination:
+
+ If both --socks* and --proxy options are given, Curl first connects to
+ the SOCKS proxy and then connects (through SOCKS) to the HTTP or HTTPS
+ proxy.
+
+ TODO: Update documentation for the new APIs and --proxy-* options.
+ Look for "Added in 7.XXX" marks.
-- pop3: Added description comments to all perform based functions
+Patrick Monnerat (24 Nov 2016)
+- Declare endian read functions argument as a const pointer.
+ This is done for all functions of the form Curl_read[136][624]_[lb]e.
-- pop3: Moved pop3_quit() to be with the other perform functions
+- Limit ASN.1 structure sizes to 256K. Prevent some allocation size overflows.
+ See CRL-01-006.
-- pop3: Moved pop3_command() to be with the other perform functions
+Jay Satiro (22 Nov 2016)
+- url: Fix conn reuse for local ports and interfaces
- Started to apply the same tidy up to the POP3 code as applied to the
- IMAP code in the 7.30.0 release.
+ - Fix connection reuse for when the proposed new conn 'needle' has a
+ specified local port but does not have a specified device interface.
+
+ Bug: https://curl.haxx.se/mail/lib-2016-11/0137.html
+ Reported-by: bjt3[at]hotmail.com
-- RELEASE-NOTES: Removed erroneous spaces
+Daniel Stenberg (21 Nov 2016)
+- rand: pass in number of randoms as an unsigned argument
-- RELEASE-NOTES: synced with 8723cade21fb
+Jay Satiro (20 Nov 2016)
+- rand: Fix potentially uninitialized result warning
-- smtp: Added support for ;auth=<mech> in the URL
+Marcel Raad (19 Nov 2016)
+- vtls: fix build warnings
- Added support for specifying the preferred authentication mechanism in
- the URL as per Internet-Draft 'draft-earhart-url-smtp-00'.
-
-- pop3: Reworked authentication type constants
+ Fix warnings about conversions from long to time_t in openssl.c and
+ schannel.c.
- ... to use left-shifted values, like those defined in curl.h, rather
- than 16-bit hexadecimal values.
+ Follow-up to de4de4e3c7c
-- pop3: Small consistency tidy up
+Daniel Stenberg (18 Nov 2016)
+- [Marcel Raad brought this change]
-- pop3: Added support for ;auth=<mech> in the URL
+ lib: fix compiler warnings after de4de4e3c7c
- Added support for specifying the preferred authentication type and SASL
- mechanism in the URL as per RFC-2384.
-
-- imap: Added support for ;auth=<mech> in the URL
+ Visual C++ now complains about implicitly casting time_t (64-bit) to
+ long (32-bit). Fix this by changing some variables from long to time_t,
+ or explicitly casting to long where the public interface would be
+ affected.
- Added support for specifying the preferred authentication mechanism in
- the URL as per RFC-5092.
+ Closes #1131
+
+Peter Wu (17 Nov 2016)
+- [Isaac Boukris brought this change]
-- sasl: Reworked SASL mechanism constants
+ Don't mix unix domain sockets with regular ones
- ... to use left-shifted values, like those defined in curl.h, rather
- than 16-bit hexadecimal values.
+ When reusing a connection, make sure the unix domain
+ socket option matches.
-- sasl: Added predefined preferred mechanism values
+Jay Satiro (17 Nov 2016)
+- tests: Fix HTTP2-Settings header for huge window size
- In preparation for the upcoming changes to IMAP, POP3 and SMTP added
- preferred mechanism values.
+ Follow-up to a4d8888. Changing the window size in that commit resulted
+ in a different HTTP2-Settings upgrade header, causing test 1800 to fail.
-- url: Added support for parsing login options from the URL
+- http2: Use huge HTTP/2 windows
- As well as parsing the username and password from the URL, added support
- for parsing the optional options part from the login details, to allow
- the following supported URL format:
+ - Improve performance by using a huge HTTP/2 window size.
- schema://username:password;options@example.com/path?q=foobar
+ Bug: https://github.com/curl/curl/issues/1102
+ Reported-by: afrind@users.noreply.github.com
+ Assisted-by: Tatsuhiro Tsujikawa
+
+Daniel Stenberg (16 Nov 2016)
+- cmdline-docs: more conversion
+
+- gen: support 'protos'
- This will only be used by IMAP, POP3 and SMTP at present but any
- protocol that may be given login options in the URL will be able to
- add support for them.
+ and warn on unrecognized lines
-- smtp: Fix compiler warning
+- gen: support 'single' to make an individual page man page
+
+- cmdline-docs: more options converted over
+
+- gen: support 'redirect'
- warning: unused variable 'smtp' introduced in commit 73cbd21b5ee6.
+ ... and warn for too long --help lines
-- smtp: Moved parsing of url path into separate function
+- cmdline/gen: replace options in texts better
-Daniel Stenberg (12 Apr 2013)
-- FTP: handle a 230 welcome response
+Jay Satiro (16 Nov 2016)
+- http2: Fix address sanitizer memcpy warning
- ...instead of the 220 we otherwise expect.
+ - In Curl_http2_switched don't call memcpy when src is NULL.
- Made the ftpserver.pl support sending a custom "welcome" and then
- created test 1219 to verify this fix with such a 230 welcome.
+ Curl_http2_switched can be called like:
- Bug: http://curl.haxx.se/mail/lib-2013-02/0102.html
- Reported by: Anders Havn
-
-- configure: try pthread_create without -lpthread
+ Curl_http2_switched(conn, NULL, 0);
- For libc variants without a spearate pthread lib (like bionic), try
- using pthreads without the pthreads lib first and only if that fails try
- the -lpthread linker flag.
+ .. and prior to this change memcpy was then called like:
- Bug: http://curl.haxx.se/bug/view.cgi?id=1216
- Reported by: Duncan
-
-- FTP: access files in root dir correctly
+ memcpy(dest, NULL, 0)
- Accessing a file with an absolute path in the root dir but with no
- directory specified was not handled correctly. This fix comes with four
- new test cases that verify it.
+ .. causing address sanitizer to warn:
- Bug: http://curl.haxx.se/mail/lib-2013-04/0142.html
- Reported by: Sam Deane
+ http2.c:2057:3: runtime error: null pointer passed as argument 2, which
+ is declared to never be null
-Steve Holme (12 Apr 2013)
-- pop3: Reworked the function description for Curl_pop3_write()
+- tool_help: Clarify --dump-header only writes received headers
-- pop3: Added function description to pop3_parse_custom_request()
+- curl.1: Clarify --dump-header only writes received headers
-- pop3: Moved utility functions to end of pop3.c
+Daniel Stenberg (15 Nov 2016)
+- [Alex Chan brought this change]
-Nick Zitzmann (12 Apr 2013)
-- darwinssl: add TLS session resumption
-
- This ought to speed up additional TLS handshakes, at least in theory.
+ docs: Spelling fixes
-Steve Holme (12 Apr 2013)
-- imap: Added function description to imap_parse_custom_request()
+Kamil Dudka (15 Nov 2016)
+- docs: the next release will be 7.52.0
-- imap: Moved utility functions to end of imap.c (Part 3/3)
-
- Moved imap_is_bchar() be with the other utility based functions.
+Daniel Stenberg (15 Nov 2016)
+- cmdline-opts: support generating the --help output
-- imap: Moved utility functions to end of imap.c (Part 2/3)
-
- Moved imap_parse_url_path() and imap_parse_custom_request() to the end of the
- file allowing all utility functions to be grouped together.
+- [David Schweikert brought this change]
-- imap: Moved utility functions to end of imap.c (Part 1/3)
+ darwinssl: fix SSL client certificate not found on MacOS Sierra
- Moved imap_atom() and imap_sendf() to the end of the file allowing all
- utility functions to be grouped together.
-
-- imap: Corrected function description for imap_connect()
+ Reviewed-by: Nick Zitzmann
+
+ Closes #1105
-Kamil Dudka (12 Apr 2013)
-- tests: prevent test206, test1060, and test1061 from failing
+- curl: add --fail-early to help output
- ... in case runtests.pl is invoked with non-default -b option
+ Fixes test 1139 failures
- Fixes a regression caused by 1e29d275c643ef6aab7948f0f55a7a9397e56b42.
-
-Daniel Stenberg (12 Apr 2013)
-- [David Strauss brought this change]
+ Follow-up to f82bbe01c8835
- libcurl-share.3: update what it does and does not share.
+- glob: fix [a-c] globbing regression
- Update sharing interface documentation to provide exhaustive list of
- what it does and does not share.
-
-- THANKS: remove duplicated names
-
-- bump: start working towards next release
-
-- THANKS: added people from the 7.30.0 RELEASE-NOTES
-
-Version 7.30.0 (12 Apr 2013)
-
-Daniel Stenberg (12 Apr 2013)
-- RELEASE-NOTES: cleaned up for 7.30 (synced with 5c5e1a1cd20)
+ Brought in ee4f76606cf
- Most notable the security advisory:
- http://curl.haxx.se/docs/adv_20130412.html
-
-- test1218: another cookie tailmatch test
+ Added test case 1280 to verify
- ... and make 1216 also verify it with a file input
+ Reported-by: Dave Reisner
- These tests verify commit 3604fde3d3c9b0d, the fix for the "cookie
- domain tailmatch" vulnerability. See
- http://curl.haxx.se/docs/adv_20130412.html
+ Bug: https://github.com/curl/curl/commit/ee4f76606cfa4ee068bf28edd37c8dae7e8db317#commitcomment-19823146
-- [YAMADA Yasuharu brought this change]
+- curl: add --fail-early
+
+ Exit with an error on the first transfer error instead of continuing to
+ do the rest of the URLs.
+
+ Discussion: https://curl.haxx.se/mail/archive-2016-11/0038.html
- cookie: fix tailmatching to prevent cross-domain leakage
+- Curl_rand: fixed and moved to rand.c
- Cookies set for 'example.com' could accidentaly also be sent by libcurl
- to the 'bexample.com' (ie with a prefix to the first domain name).
+ Now Curl_rand() is made to fail if it cannot get the necessary random
+ level.
- This is a security vulnerabilty, CVE-2013-1944.
+ Changed the proto of Curl_rand() slightly to provide a number of ints at
+ once.
- Bug: http://curl.haxx.se/docs/adv_20130412.html
+ Moved out from vtls, since it isn't a TLS function and vtls provides
+ Curl_ssl_random() for this to use.
+
+ Discussion: https://curl.haxx.se/mail/lib-2016-11/0119.html
-Guenter Knauf (11 Apr 2013)
-- Enabled MinGW sync resolver builds.
+- cmdline-opts: first test version of a new man page generator kit
+
+ See MANPAGE.md for the description of how this works. Each command line
+ option is now described in a separate .d file.
-Yang Tse (10 Apr 2013)
-- if2ip.c: fix compiler warning
+- time_t fix: follow-up to de4de4e3c7c
+
+ Blah, I accidentally wrote size_t instead of time_t for two variables.
+
+ Reported-by: Dave Reisner
-Guenter Knauf (10 Apr 2013)
-- Fixed lost OpenSSL output with "-t" - followup.
+- timeval: prefer time_t to hold seconds instead of long
- The previously applied patch didnt work on Windows; we cant rely
- on shell commands like 'echo' since they act diffently on each
- platform and each shell.
- In order to keep this script platform-independent the code must
- only use pure Perl.
+ ... as long is still 32bit on modern 64bit windows machines, while
+ time_t is generally 64bit.
-Daniel Stenberg (9 Apr 2013)
-- test1217: verify parsing 257 responses with "rubbish" before path
+Dan Fandrich (12 Nov 2016)
+- tests: fixed variable might be clobbered warning
- Test 1217 verifies commit e0fb2d86c9f78, and without that change this
- test fails.
+ This stops the compiler from potentially making invalid assumptions
+ about the immutability of sdp and sap across the longjmp boundary.
-- [Bill Middlecamp brought this change]
+Daniel Stenberg (12 Nov 2016)
+- RELEASE-NOTES: synced with 346340808c
- FTP: handle "rubbish" in front of directory name in 257 responses
+- URL-parser: for file://[host]/ URLs, the [host] must be localhost
- When doing PWD, there's a 257 response which apparently some servers
- prefix with a comment before the path instead of after it as is
- otherwise the norm.
+ Previously, the [host] part was just ignored which made libcurl accept
+ strange URLs misleading users. like "file://etc/passwd" which might've
+ looked like it refers to "/etc/passwd" but is just "/passwd" since the
+ "etc" is an ignored host name.
- Failing to parse this, several otherwise legitimate use cases break.
-
- Bug: http://curl.haxx.se/mail/lib-2013-04/0113.html
-
-Guenter Knauf (9 Apr 2013)
-- Fixed ares-enabled builds with static makefiles.
+ Reported-by: Mike Crowe
+ Assisted-by: Kamil Dudka
-- Fixed lost OpenSSL output with "-t".
-
- The OpenSSL pipe wrote to the final CA bundle file, but the encoded PEM
- output wrote to a temporary file. Consequently, the OpenSSL output was
- lost when the temp file was renamed to the final file at script finish
- (overwriting the final file written earlier by openssl).
- Patch posted to the list by Richard Michael (rmichael edgeofthenet org).
+- test558: adapt to 0649433da
-Daniel Stenberg (9 Apr 2013)
-- test1216: test tailmatching cookie domains
-
- This test is an attempt to repeat the problem YAMADA Yasuharu reported
- at http://curl.haxx.se/mail/lib-2013-04/0108.html
+- openssl: make sure to fail in the unlikely event that PRNG seeding fails
-- RELEASe-NOTES: synced with 29fdb2700f797
+- openssl: avoid unnecessary seeding if already done
- added "tcpkeepalive on Mac OS X"
+ 1.1.0+ does more of this by itself so we can avoid extra processing this
+ way.
-Nick Zitzmann (8 Apr 2013)
-- darwinssl: disable insecure ciphers by default
+- openssl: RAND_status always exists in OpenSSL >= 0.9.7
- I noticed that aria2's SecureTransport code disables insecure ciphers such
- as NULL, anonymous, IDEA, and weak-key ciphers used by SSLv3 and later.
- That's a good idea, and now we do the same thing in order to prevent curl
- from accessing a "secure" site that only negotiates insecure ciphersuites.
+ and remove RAND_screen from configure since nothing is using that
+ function
-Daniel Stenberg (8 Apr 2013)
-- [Robert Wruck brought this change]
+- Curl_pgrsUpdate: use dedicated function for time passed
- tcpkeepalive: Support CURLOPT_TCP_KEEPIDLE on OSX
+- realloc: use Curl_saferealloc to avoid common mistakes
- MacOS X doesn't have TCP_KEEPIDLE/TCP_KEEPINTVL but only a single
- TCP_KEEPALIVE (see
- http://developer.apple.com/library/mac/#DOCUMENTATION/Darwin/Reference/ManPages/man4/tcp.4.html).
- Here is a patch for CURLOPT_TCP_KEEPIDLE on OSX platforms.
+ Discussed: https://curl.haxx.se/mail/lib-2016-11/0087.html
-- configure: remove CURL_CHECK_FUNC_RECVFROM
+- [Daniel Hwang brought this change]
+
+ curl: Add --retry-connrefused
- 1 - We don't use the results from the test and we never did. recvfrom()
- is only used by the TFTP code and it has not caused any problems.
+ to consider ECONNREFUSED as a transient error.
- 2 - the CURL_CHECK_FUNC_RECVFROM function is extremely slow
+ Closes #1064
-Steve Holme (8 Apr 2013)
-- RELEASE-NOTES: Corrected duplicate NTLM memory leaks
+- openssl: raise the max_version to 1.3 if asked for
+
+ Now I've managed to negotiate TLS 1.3 with https://enabled.tls13.com/ when
+ using boringssl.
-- RELEASE-NOTES: Removed trailing full stop
+Jay Satiro (9 Nov 2016)
+- vtls: Fail on unrecognized param for CURLOPT_SSLVERSION
+
+ - Fix GnuTLS code for CURL_SSLVERSION_TLSv1_2 that broke when the
+ TLS 1.3 support was added in 6ad3add.
+
+ - Homogenize across code for all backends the error message when TLS 1.3
+ is not available to "<backend>: TLS 1.3 is not yet supported".
+
+ - Return an error when a user-specified ssl version is unrecognized.
+
+ ---
+
+ Prior to this change our code for some of the backends used the
+ 'default' label in the switch statement (ie ver unrecognized) for
+ ssl.version and treated it the same as CURL_SSLVERSION_DEFAULT.
+
+ Bug: https://curl.haxx.se/mail/lib-2016-11/0048.html
+ Reported-by: Kamil Dudka
-Daniel Stenberg (8 Apr 2013)
-- [Fabian Keil brought this change]
+Daniel Stenberg (9 Nov 2016)
+- [Isaac Boukris brought this change]
- proxy: make ConnectionExists() check credential of proxyconnections too
+ SPNEGO: Fix memory leak when authentication fails
- Previously it only compared credentials if the requested needle
- connection wasn't using a proxy. This caused NTLM authentication
- failures when using proxies as the authentication code wasn't send on
- the connection where the challenge arrived.
+ If SPNEGO fails, cleanup the negotiate handle right away.
- Added test 1215 to verify: NTLM server authentication through a proxy
- (This is a modified copy of test 67)
+ Fixes #1115
+
+ Signed-off-by: Isaac Boukris <iboukris@gmail.com>
+ Reported-by: ashman-p
-- RELEASE-NOTES: sync with 704a5dfca9
+- CODE_STYLE.md: link to INTERNALS.md correctly
-- TODO-RELEASE: cleaned up, not really maintained lately
+- bump: next version will be 7.52.0
-Marc Hoersken (7 Apr 2013)
-- if2ip.c: Fixed another warning: unused parameter 'remote_scope'
+- RELEASE-NOTES: synced with dfcdaaba371e9a3
-Daniel Stenberg (7 Apr 2013)
-- [Marc Hoersken brought this change]
+- examples/fileupload.c: fclose the file as well
- cookie.c: Made cookie sort function more deterministic
+- printf: fix ".*f" handling
+
+ It would always use precision 1 instead of reading it from the argument
+ list as intended.
- Since qsort implementations vary with regards to handling the order
- of similiar elements, this change makes the internal sort function
- more deterministic by comparing path length first, then domain length
- and finally the cookie name. Spotted with testcase 62 on Windows.
+ Reported-by: Ray Satiro
+
+ Bug: #1113
-Marc Hoersken (7 Apr 2013)
-- curl_schannel.c: Follow up on memory leak fix ae4558d
+- curl_formadd.3: *_FILECONTENT and *_FILE need the file to be kept
+
+ Reported-by: Frank Gevaerts
-- Revert "getpart.pm: Strip carriage returns to fix Windows support"
+Kamil Dudka (7 Nov 2016)
+- nss: silence warning 'SSL_NEXT_PROTO_EARLY_VALUE not handled in switch'
- This reverts commit e51b23c925a2721cf7c29b2b376d3d8903cfb067.
- As discussed on the mailinglist, this was not the correct approach.
+ ... with nss-3.26.0 and newer
+
+ Reported-by: Daniel Stenberg
-- http_negotiate.c: Fixed passing argument from incompatible pointer type
+Daniel Stenberg (7 Nov 2016)
+- openssl: initial TLS 1.3 adaptions
+
+ BoringSSL supports TLSv1.3 already, but these changes don't seem to be anough
+ to get it working.
-- ftp.c: Added missing brackets around ABOR command logic
+- ssh: check md5 fingerprints case insensitively (regression)
+
+ Revert the change from ce8d09483eea but use the new function
+
+ Reported-by: Kamil Dudka
+ Bug: https://github.com/curl/curl/commit/ce8d09483eea2fcb1b50e323e1a8ed1f3613b2e3#commitcomment-19666146
-- sockfilt.c: Fixed detection of client-side connection close
+Kamil Dudka (7 Nov 2016)
+- curl: introduce the --tlsv1.3 option to force TLS 1.3
- WINSOCK only:
- Since FD_CLOSE is only signaled once, it may trigger at the same
- time as FD_READ. Data actually being available makes it impossible
- to detect that the connection was closed by checking that recv returns
- zero. Another recv attempt could block the connection if it was
- not closed. This workaround abuses exceptfds in conjunction with
- readfds to signal that the connection has actually closed.
+ Fully implemented with the NSS backend only for now.
+
+ Reviewed-by: Ray Satiro
-- curl_schannel.c: Fixed memory leak if connection was not successful
+- vtls: support TLS 1.3 via CURL_SSLVERSION_TLSv1_3
+
+ Fully implemented with the NSS backend only for now.
+
+ Reviewed-by: Ray Satiro
-- if2ip.c: Fixed warning: unused parameter 'remote_scope'
+- nss: map CURL_SSLVERSION_DEFAULT to NSS default
+
+ ... but make sure we use at least TLSv1.0 according to libcurl API
+
+ Reported-by: Cure53
+ Reviewed-by: Ray Satiro
-- runtests.pl: Fixed --verbose parameter passed to http_pipe.py
+Daniel Stenberg (7 Nov 2016)
+- s/cURL/curl
+
+ We're mostly saying just "curl" in lower case these days so here's a big
+ cleanup to adapt to this reality. A few instances are left as the
+ project could still formally be considered called cURL.
-- sockfilt.c: Reduce CPU load while running under a Windows PIPE
+Jay Satiro (7 Nov 2016)
+- [Tatsuhiro Tsujikawa brought this change]
-- tftpd.c: Apply sread timeout to the whole data transfer session
+ http2: Don't send header fields prohibited by HTTP/2 spec
+
+ Previously, we just ignored "Connection" header field. But HTTP/2
+ specification actually prohibits few more header fields. This commit
+ ignores all of them so that we don't send these bad header fields.
+
+ Bug: https://curl.haxx.se/mail/archive-2016-10/0033.html
+ Reported-by: Ricki Hirner
+
+ Closes https://github.com/curl/curl/pull/1092
-- getpart.pm: Strip carriage returns to fix Windows support
+Daniel Stenberg (7 Nov 2016)
+- curl.1: explain the SMTP data expected for -T
+
+ Fixes #1107
+
+ Reported-by: Adam Piggott
-Daniel Stenberg (6 Apr 2013)
-- ftp tests: libcurl returns CURLE_FTP_ACCEPT_FAILED better now
+Peter Wu (6 Nov 2016)
+- cmake: disable poll for macOS
- Since commit 57aeabcc1a20f, it handles errors on the control connection
- while waiting for the data connection better.
+ Mirrors the autotools behavior introduced with curl-7_50_3-83-ga34c7ce.
- Test 591 and 592 are updated accordingly.
+ Fixes #1089
-- FTP: wait on both connections during active STOR state
+Jay Satiro (5 Nov 2016)
+- easy: Initialize info variables on easy init and duphandle
- When doing PORT and upload (STOR), this function needs to extract the
- file descriptor for both connections so that it will respond immediately
- when the server eventually connects back.
+ - Call Curl_initinfo on init and duphandle.
- This flaw caused active connections to become unnecessary slow but they
- would still often work due to the normal polling on a timeout. The bug
- also would not occur if the server connected back very fast, like when
- testing on local networks.
+ Prior to this change the statistical and informational variables were
+ simply zeroed by calloc on easy init and duphandle. While zero is the
+ correct default value for almost all info variables, there is one where
+ it isn't (filetime initializes to -1).
- Bug: http://curl.haxx.se/bug/view.cgi?id=1183
- Reported by: Daniel Theron
-
-Marc Hoersken (6 Apr 2013)
-- tftpd.c: Follow up cleanup and restore of previous sockopt
+ Bug: https://github.com/curl/curl/issues/1103
+ Reported-by: Neal Poole
-Daniel Stenberg (6 Apr 2013)
-- [Kim Vandry brought this change]
+Daniel Stenberg (5 Nov 2016)
+- [Mauro Rappa brought this change]
- connect: treat an interface bindlocal() problem as a non-fatal error
-
- I am using curl_easy_setopt(CURLOPT_INTERFACE, "if!something") to force
- transfers to use a particular interface but the transfer fails with
- CURLE_INTERFACE_FAILED, "Failed binding local connection end" if the
- interface I specify has no IPv6 address. The cause is as follows:
-
- The remote hostname resolves successfully and has an IPv6 address and an
- IPv4 address.
+ curl -w: added more decimal digits to timing counters
- cURL attempts to connect to the IPv6 address first.
+ Now showing microsecond resolution.
- bindlocal (in lib/connect.c) fails because Curl_if2ip cannot find an
- IPv6 address on the interface.
+ Closes #1106
+
+Jakub Zakrzewski (4 Nov 2016)
+- dist: add CMakeLists.txt to the tarball
+
+Daniel Stenberg (4 Nov 2016)
+- mbedtls: fix build with mbedtls versions < 2.4.0
- This is a fatal error in singleipconnect()
+ Regression added in 62a8095e714
- This change will make cURL try the next IP address in the list.
+ Reported-by: Tony Kelman
- Also included are two changes related to IPv6 address scope:
+ Discussed in #1087
+
+- configure: verify that compiler groks -Werror=partial-availability
- - Filter the choice of address in Curl_if2ip to only consider addresses
- with the same scope ID as the connection address (mismatched scope for
- local and remote address does not result in a working connection).
+ Reported-by: bemoody
- - bindlocal was ignoring the scope ID of addresses returned by
- Curl_if2ip . Now it uses them.
+ Fixes #1104
+
+- docs: shorten and simplify the top comment in multi-uv.c
- Bug: http://curl.haxx.se/bug/view.cgi?id=1189
+ and change URL to use https
-Marc Hoersken (6 Apr 2013)
-- tftpd.c: Fixed sread timeout on Windows by setting it manually
+- [Andrei Sedoi brought this change]
-- ftp.pm: Added tskill to support Windows XP Home
+ docs: handle CURL_POLL_INOUT in multi-uv example
-- runtests.pl: Modularization of MinGW/Msys compatibility functions
+- [Andrei Sedoi brought this change]
-- ftp.pm: Made Perl testsuite able to handle Windows processes
+ docs: multi-uv: don't use CURLMsg after cleanup
-- util.c: Revert workaround eeefcdf, 6eb56e7 and e3787e8
+- [Andrei Sedoi brought this change]
-- ftp.pm: Made Perl testsuite able to kill Windows processes
+ docs: remove unused variables in multi-uv example
-- util.c: Follow up cleanup on eeefcdf
+- bump: start working on 7.51.1
-Daniel Stenberg (6 Apr 2013)
-- cpp: use #ifdef __MINGW32__ to avoid compiler complaints
+- winbuild: remove strcase.obj from curl build
- ... instead of just #if
+ Reported-by: Bruce Stephens
+
+ Fixes #1098
-Marc Hoersken (6 Apr 2013)
-- util.c: Made write_pidfile write the correct PID on MinGW/Msys
+Dan Fandrich (2 Nov 2016)
+- msvc: removed a straggling reference to strequal.c
- This workaround fixes an issue on MinGW/Msys regarding the Perl
- testsuite scripts not being able to signal or control the server
- processes. The MinGW Perl runtime only sees the Msys processes and
- their corresponding PIDs, but sockfilt (and other servers) wrote the
- Windows PID into their PID-files. Since this PID is useless to the
- testsuite, the write_pidfile function was changed to search for the
- Msys PID and write that into the PID-file.
+ Follow-up to 502acba2
+
+Version 7.51.0 (2 Nov 2016)
+
+Daniel Stenberg (2 Nov 2016)
+- THANKS: synced with 7.51.0
+
+- RELEASE-NOTES: 7.51.0
-Daniel Stenberg (5 Apr 2013)
-- RELEASE-NOTES: synced with 5e722b2d09087
+- ftp_done: don't clobber the passed in error code
- 3 more bug fixes, 6 more contributors
+ Coverity CID 1374359 pointed out the unused result value.
-Marc Hoersken (5 Apr 2013)
-- sockfilt.c: Fixed handling of multiple fds being signaled
+- ftp: remove dead code in ftp_done
+
+ Coverity CID 1374358
-Kamil Dudka (5 Apr 2013)
-- curl_global_init.3: improve description of CURL_GLOBAL_ALL
+Jay Satiro (1 Nov 2016)
+- generate.bat: Include include/curl in libcurl VS projects
- Reported by: Tomas Mlcoch
+ .. because including those headers helps Visual Studio's Intellisense.
-- examples/multi-single.c: fix the order of destructions
+- generate.bat: Remove strcase.[ch] from curl tool VS projects
- ... so that it adheres to the API documentation.
+ ..because they're no longer needed in the tool build. strcase is still
+ built by the libcurl project and exports curl_str(n)equal which is used
+ by the curl tool.
- Reported by: Tomas Mlcoch
+ Bug: https://github.com/curl/curl/commit/9363f1a#all_commit_comments
-Daniel Stenberg (5 Apr 2013)
-- Curl_open: restore default MAXCONNECTS to 5
+Daniel Stenberg (2 Nov 2016)
+- metalink: simplify the hex parsing function
- At some point recently we lost the default value for the easy handle's
- connection cache, and this change puts it back to 5 - which is the
- former default value and it is documented in the curl_easy_setopt.3 man
- page.
+ ... and now it avoids using the libcurl toupper() function
-Marc Hoersken (4 Apr 2013)
-- sockfilt.c: Added wrapper functions to fix Windows console issues
+Michael Kaufmann (1 Nov 2016)
+- file: fix compiler warning
- The new read and write wrapper functions support reading from stdin
- and writing to stdout/stderr on Windows by using the appropriate
- Windows API functions and data types.
+ follow-up to 46133aa5
-Yang Tse (4 Apr 2013)
-- lib1509.c: fix compiler warnings
+Dan Fandrich (1 Nov 2016)
+- strcase: fixed Metalink builds by redefining checkprefix()
+
+ ...to use the public function curl_strnequal(). This isn't ideal because
+ it adds extra overhead to any internal calls to checkprefix.
+
+ follow-up to 95bd2b3e
-- easy.c: fix compiler warning
+Daniel Stenberg (1 Nov 2016)
+- curl.1: typo
-Daniel Stenberg (4 Apr 2013)
-- --engine: spellfix the help message
+- curl.1: expand on how multiple uses of -o looks
- Reported by: Fredrik Thulin
+ Suggested-by: Dan Jacobson
+ Issue: https://github.com/curl/curl/issues/1097
-Yang Tse (4 Apr 2013)
-- http_negotiate.c: follow-up for commit 3dcc1a9c
+- tests/util: get a private strncasecompare clone
+
+ ... since the curlx_* code no longer provides one and we don't link
+ libcurl to these test servers.
-Linus Nielsen Feltzing (4 Apr 2013)
-- easy: Fix the broken CURLOPT_MAXCONNECTS option
+- strcase: make the tool use curl_str[n]equal instead
- Copy the CURLOPT_MAXCONNECTS option to CURLMOPT_MAXCONNECTS in
- curl_easy_perform().
+ As they are after all part of the public API. Saves space and reduces
+ complexity. Remove the strcase defines from the curlx_ family.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1212
- Reported-by: Steven Gu
+ Suggested-by: Dan Fandrich
+ Idea: https://curl.haxx.se/mail/lib-2016-10/0136.html
-Guenter Knauf (4 Apr 2013)
-- Updated copyright date.
-
-- Another small output fix for --help and --version.
+Kamil Dudka (31 Oct 2016)
+- gskit, nss: do not include strequal.h
+
+ follow-up to 811a693b80
-Yang Tse (4 Apr 2013)
-- http_negotiate.c: fix several SPNEGO memory handling issues
+Dan Fandrich (31 Oct 2016)
+- strcasecompare: include curl.h in strcase.c
+
+ This should fix the "warning: 'curl_strequal' redeclared without
+ dllimport attribute: previous dllimport ignored" message and subsequent
+ link error on Windows because of the missing CURL_EXTERN on the
+ prototype.
-Guenter Knauf (4 Apr 2013)
-- Added a cont to specify base64 line wrap.
+Daniel Stenberg (31 Oct 2016)
+- strcase: fix the remaining rawstr users
-- Fixed version output.
+- msvc builds: s/rawstr/strcase
+
+ Follow-up to 811a693b
-- Added support for --help and --version options.
+Dan Fandrich (31 Oct 2016)
+- strcasecompare: replaced remaining rawstr.h with strcase.h
+
+ This is a followup to commit 811a693b
-- Added option to specify length of base64 output.
+Marcel Raad (31 Oct 2016)
+- digest_sspi: fix include
- Based on a patch posted to the list by Richard Michael.
+ Fix compile break from 811a693b80
-Daniel Stenberg (3 Apr 2013)
-- curl_easy_setopt.3: CURLOPT_HTTPGET disables CURLOPT_UPLOAD
+Dan Fandrich (31 Oct 2016)
+- libauthretry: use the external function curl_strequal
+
+ The internal version strcasecompare isn't available outside libcurl
-- [Yasuharu Yamada brought this change]
+Daniel Stenberg (31 Oct 2016)
+- RELEASE-NOTES: synced with d14538d2501ef0da
- Curl_cookie_add: only increase numcookies for new cookies
+- configure: raise the default minimum version for macos to 10.8
- Count up numcookies in Curl_cookie_add() only when cookie is new one
+ follow-up to 4f8d0b6f02aa7043. Since the darwinssl code breaks
+ otherwise. If you build without darwinssl 10.5 works fine.
-- SO_SNDBUF: don't set SNDBUF for win32 versions vista or later
-
- The Microsoft knowledge-base article
- http://support.microsoft.com/kb/823764 describes how to use SNDBUF to
- overcome a performance shortcoming in winsock, but it doesn't apply to
- Windows Vista and later versions. If the described SNDBUF magic is
- applied when running on those more recent Windows versions, it seems to
- instead have the reversed effect in many cases and thus make libcurl
- perform less good on those systems.
-
- This fix thus adds a run-time version-check that does the SNDBUF magic
- conditionally depending if it is deemed necessary or not.
+- unit1301: keep testing curl_strequal
- Bug: http://curl.haxx.se/bug/view.cgi?id=1188
- Reported by: Andrew Kurushin
- Tested by: Christian Hägele
+ as that is still part of the API, fix from 8fe4bd084412f30
-Nick Zitzmann (1 Apr 2013)
-- darwinssl: additional descriptive messages of SSL handshake errors
+- ldap: fix include
- (This doesn't need to appear in the release notes.)
+ Fix bug from 811a693b80
-Guenter Knauf (1 Apr 2013)
-- Added dns and connect time to output.
+- url: remove unconditional idn2.h include
+
+ Mistake brought by 9c91ec778104a
-Daniel Stenberg (1 Apr 2013)
-- RELEASE-NOTES: synced with 0614b902136
+- curl_strequal: part of public API/ABI, needs to be kept
+
+ These two public functions have been mentioned as deprecated since a
+ very long time but since they are still part of the API and ABI we need
+ to keep them around.
-- code-policed
+- strcase: s/strequal/strcasecompare
+
+ some more follow-ups to 811a693b80
-- tcpkeepalive: support TCP_KEEPIDLE/TCP_KEEPINTVL on win32
+- ldap: fix strcase use
- Patch by: Robert Wruck
- Bug: http://curl.haxx.se/bug/view.cgi?id=1209
+ follow-up to 811a693b80
-- BINDINGS: BBHTTP is a cocoa binding, Julia has a binding
+- test165: adapted to the libidn2 use and IDNA2008 fix
-- ftp_sendquote: use PPSENDF, not FTPSENDF
+- cookie: replace use of fgets() with custom version
+
+ ... that will ignore lines that are too long to fit in the buffer.
- The last remaining code piece that still used FTPSENDF now uses PPSENDF.
- In the problematic case, a PREQUOTE series was done on a re-used
- connection when Curl_pp_init() hadn't been called so it had messed up
- pointers. The init call is done properly from Curl_pp_sendf() so this
- change fixes this particular crash.
+ CVE-2016-8615
- Bug: http://curl.haxx.se/mail/lib-2013-03/0319.html
- Reported by: Sam Deane
+ Bug: https://curl.haxx.se/docs/adv_20161102A.html
+ Reported-by: Cure53
-Steve Holme (27 Mar 2013)
-- RELEASE-NOTES: Corrected typo
+- strcasecompare: all case insensitive string compares ignore locale now
+
+ We had some confusions on when each function was used. We should not act
+ differently on different locales anyway.
-Daniel Stenberg (27 Mar 2013)
-- [Clemens Gruber brought this change]
+- strcasecompare: is the new name for strequal()
+
+ ... to make it less likely that we forget that the function actually
+ does case insentive compares. Also replaced several invokes of the
+ function with a plain strcmp when case sensitivity is not an issue (like
+ comparing with "-").
- multi-uv.c: remove unused variable
+- ftp: check for previous patch must be case sensitive!
+
+ ... otherwise example.com/PATH and example.com/path would be assumed to
+ be the same and they usually aren't!
-- RELEASE-NOTES: add two references
+- SSH: check md5 fingerprint case sensitively
-- test1509: verify proxy header response headers count
-
- Modified sws to support and use custom CONNECT responses instead of the
- previously naive hard-coded version. Made the HTTP test server able to
- extract test case number from the host name in a CONNECT request by
- finding the number after the last dot. It makes 'machine.moo.123' use
- test case 123.
+- connectionexists: use case sensitive user/password comparisons
- Adapted a larger amount of tests to the new <connect> style.
+ CVE-2016-8616
- Bug: http://curl.haxx.se/bug/view.cgi?id=1204
- Reported by: Martin Jansen
+ Bug: https://curl.haxx.se/docs/adv_20161102B.html
+ Reported-by: Cure53
-- [Clemens Gruber brought this change]
-
- Added libuv example multi-uv.c
-
-Yang Tse (25 Mar 2013)
-- NTLM: fix several NTLM code paths memory leaks
+- base64: check for integer overflow on large input
+
+ CVE-2016-8617
+
+ Bug: https://curl.haxx.se/docs/adv_20161102C.html
+ Reported-by: Cure53
-- WIN32 MemoryTracking: track wcsdup() _wcsdup() and _tcsdup() usage
+- krb5: avoid realloc(0)
- As of 25-mar-2013 wcsdup() _wcsdup() and _tcsdup() are only used in
- WIN32 specific code, so tracking of these has not been extended for
- other build targets. Without this fix, memory tracking system on
- WIN32 builds, when using these functions, would provide misleading
- results.
+ If the requested size is zero, bail out with error instead of doing a
+ realloc() that would cause a double-free: realloc(0) acts as a free()
+ and then there's a second free in the cleanup path.
- In order to properly extend this support for all targets curl.h
- would have to define curl_wcsdup_callback prototype and consequently
- wchar_t should be visible before that in curl.h. IOW curl_wchar_t
- defined in curlbuild.h and this pulling whatever system header is
- required to get wchar_t definition.
+ CVE-2016-8619
- Additionally a new curl_global_init_mem() function that also receives
- user defined wcsdup() callback would be required.
+ Bug: https://curl.haxx.se/docs/adv_20161102E.html
+ Reported-by: Cure53
-- curl_ntlm_msgs.c: revert commit 463082bea4
+- aprintf: detect wrap-around when growing allocation
- reverts unreleased invalid memory leak fix
+ On 32bit systems we could otherwise wrap around after 2GB and allocate 0
+ bytes and crash.
+
+ CVE-2016-8618
+
+ Bug: https://curl.haxx.se/docs/adv_20161102D.html
+ Reported-by: Cure53
-Daniel Stenberg (23 Mar 2013)
-- RELEASE-NOTES: synced with bc6037ed3ec02
+- range: reject char globs with missing end like '[L-]'
- More changes, bugfixes and contributors!
+ ... which previously would lead to out of boundary reads.
+
+ Reported-by: Luật Nguyễn
-- [Martin Jansen brought this change]
+- glob_next_url: make sure to stay within the given output buffer
- Curl_proxyCONNECT: count received headers
+- range: prevent negative end number in a glob range
- Proxy servers tend to add their own headers at the beginning of
- responses. The size of these headers was not taken into account by
- CURLINFO_HEADER_SIZE before this change.
+ CVE-2016-8620
- Bug: http://curl.haxx.se/bug/view.cgi?id=1204
+ Bug: https://curl.haxx.se/docs/adv_20161102F.html
+ Reported-by: Luật Nguyễn
-Steve Holme (21 Mar 2013)
-- sasl: Corrected a few violations of the curl coding standards
+- parsedate: handle cut off numbers better
- Corrected some incorrectly positioned pointer variable declarations to
- be "char *" rather than "char* ".
-
-- multi.c: Corrected a couple of violations of the curl coding standards
+ ... and don't read outside of the given buffer!
- Corrected some incorrectly positioned pointer variable declarations to
- be "type *" rather than "type* ".
-
-- imap-tests: Added CRLF to reply data to be compliant with RFC-822
+ CVE-2016-8621
- Updated the reply data in tests: 800, 801, 802, 804 and 1321 to possess
- the CRLF as per RFC-822.
+ bug: https://curl.haxx.se/docs/adv_20161102G.html
+ Reported-by: Luật Nguyễn
-- multi.c: Fix compilation warning
+- escape: avoid using curl_easy_unescape() internally
- warning: an enumerated type is mixed with another type
+ Since the internal Curl_urldecode() function has a better API.
-- multi.c: fix compilation error
+- unescape: avoid integer overflow
- warning: conversion from enumeration type to different enumeration type
-
-- lib1900.c: fix compilation warning
+ CVE-2016-8622
- warning: declaration of 'time' shadows a global declaration
+ Bug: https://curl.haxx.se/docs/adv_20161102H.html
+ Reported-by: Cure53
-Yang Tse (20 Mar 2013)
-- [John E. Malmberg brought this change]
-
- build_vms.com: use existing curlbuild.h and parsing fix
-
- This patch removes building curlbuild.h from the build_vms.com procedure
- and uses the one in the daily or release tarball instead.
+- cookies: getlist() now holds deep copies of all cookies
- packages/vms/build_curlbuild_h.com is obsolete with this change.
+ Previously it only held references to them, which was reckless as the
+ thread lock was released so the cookies could get modified by other
+ handles that share the same cookie jar over the share interface.
- Accessing the library module name "tool_main" needs different handling
- when the optional extended parsing is enabled.
+ CVE-2016-8623
- Tested on IA64/VMS 8.4 and VAX/VMS 7.3
+ Bug: https://curl.haxx.se/docs/adv_20161102I.html
+ Reported-by: Cure53
-Nick Zitzmann (19 Mar 2013)
-- darwinssl: disable ECC ciphers under Mountain Lion by default
-
- I found out that ECC doesn't work as of OS X 10.8.3, so those ciphers are
- turned off until the next point release of OS X.
+- TODO: remove IDNA2008
-Steve Holme (18 Mar 2013)
-- FEATURES: Small tidy up for constancy and grammar
+- idn: switch to libidn2 use and IDNA2008 support
+
+ CVE-2016-8625
+
+ Bug: https://curl.haxx.se/docs/adv_20161102K.html
+ Reported-by: Christian Heimes
-Daniel Stenberg (18 Mar 2013)
-- [Oliver Schindler brought this change]
+- test1246: verify URL parsing with host name ending with '#'
- Curl_proxyCONNECT: clear 'rewindaftersend' on success
+- urlparse: accept '#' as end of host name
- After having done a POST over a CONNECT request, the 'rewindaftersend'
- boolean could be holding the previous value which could lead to badness.
+ 'http://example.com#@127.0.0.1/x.txt' equals a request to example.com
+ for the '/' document with the rest of the URL being a fragment.
- This should be tested for in a new test case!
+ CVE-2016-8624
- Bug: https://groups.google.com/d/msg/msysgit/B31LNftR4BI/KhRTz0iuGmUJ
+ Bug: https://curl.haxx.se/docs/adv_20161102J.html
+ Reported-by: Fernando Muñoz
-Steve Holme (18 Mar 2013)
-- TODO: Reordered the protocol and security sections
+Jay Satiro (31 Oct 2016)
+- INTERNALS: better markdown (follow-up)
- Moved SMTP, POP3, IMAP and New Protocol sections to be listed after the
- other protocols (FTP, HTTP and TELNET) and SASL to be after SSL and
- GnuTLS as these are all security related.
+ - Wrap more words with underscores in backticks.
- Additionally fixed numbering of the SSL and GnuTLS sections as they
- weren't consecutive.
-
-Yang Tse (18 Mar 2013)
-- tests: specify 'text' mode for some output files in verify section
+ Follow-up to 13f4913.
-Steve Holme (17 Mar 2013)
-- imap: Fixed incorrect initial response generation for SASL AUTHENTICATE
+Daniel Stenberg (30 Oct 2016)
+- INTERNALS: better markdown
- Fixed incorrect initial response generation for the NTLM and LOGIN SASL
- authentication mechanisms when the SASL-IR was detected.
+ words with underscore need to be within `these`
- Introduced in commit: 6da7dc026c14.
-
-- FEATURES: Expanded the supported enhanced IMAP command list
-
-- TODO: Corrected typo in TOC
-
-- TODO: Added IMAP section and removed unused Other protocols section
-
-- TODO: Added graceful base64 decoding failure to SMTP and POP3
+ Bug: https://github.com/curl/curl-www/issues/19
+ Reported-by : Jay Satiro
-- TODO: Corrected typo on section 10.2 heading
-
-Yang Tse (16 Mar 2013)
-- tests: 96, 558, 1330: strip build subdirectory dependent leading path
-
-Steve Holme (15 Mar 2013)
-- TODO: Added section 10.2 Initial response to POP3 to do list
+Jay Satiro (30 Oct 2016)
+- mk-ca-bundle.vbs: Fix UTF-8 output
+
+ - Change initial message box to mention delay when downloading/parsing.
+
+ Since there is no progress meter it was somewhat unexpected that after
+ choosing a filename nothing appears to happen, when actually the cert
+ data is in the process of being downloaded and parsed.
+
+ - Warn if OpenSSL is not present.
+
+ - Use a UTF-8 stream to make the ca-bundle data.
+
+ - Save the UTF-8 ca-bundle stream as binary so that no BOM is added.
+
+ ---
+
+ This is a follow-up to d2c6d15 which switched mk-ca-bundle.vbs output to
+ ANSI due to corrupt UTF-8 output, now fixed.
+
+ This change completes making the default certificate bundle output of
+ mk-ca-bundle.vbs as close as possible to that of mk-ca-bundle.pl, which
+ should make it easier to review any difference between their output.
+
+ Ref: https://github.com/curl/curl/pull/1012
-- imap-tests: Corrected copy/paste error in test808 reply data
+Daniel Stenberg (28 Oct 2016)
+- BINDINGS: converted to markdown
+
+ To make it render better on the web site, at the price of it becoming
+ slightly less readable as text.
-Yang Tse (15 Mar 2013)
-- unit1330.c: fix date
+Jay Satiro (27 Oct 2016)
+- CURLMOPT_MAX_PIPELINE_LENGTH.3: Clarify it's not for HTTP/2
+
+ - Clarify that this option is only for HTTP/1.1 pipelining.
+
+ Bug: https://github.com/curl/curl/issues/1059
+ Reported-by: Jeroen Ooms
+
+ Assisted-by: Daniel Stenberg
-- tests: add #96 #558 and #1330
+Daniel Stenberg (27 Oct 2016)
+- KNOWN_BUGS: HTTP/2 server push enabled when no pushes can be accepted
- These verfy that the 'memory tracking' subsystem is actually doing its
- job when using curl tool (#96), a test in libtest (#558) and also a unit
- test (#1330), in order to prevent regressions in this functionallity.
+ Closes #927
-Steve Holme (15 Mar 2013)
-- imap-tests: Added test808 for custom EXAMINE command
+- KNOWN_BUGS: c-ares deviates from stock resolver on http://1346569778
+
+ Closes #893
-Daniel Stenberg (15 Mar 2013)
-- HTTP proxy: insert slash in URL if missing
+Michael Osipov (27 Oct 2016)
+- configure.in: Fix test syntax
- curl has been accepting URLs using slightly wrong syntax for a long
- time, such as when completely missing as slash "http://example.org" or
- missing a slash when a query part is given
- "http://example.org?q=foobar".
+ Some versions of test allow == for equality, but others (such as the HP-UX
+ version) do not. Use a single = for correctness.
- curl would translate these into a legitimate HTTP request to servers,
- although as was shown in bug #1206 it was not adjusted properly in the
- cases where a HTTP proxy was used.
+ Error output:
+ checking for monotonic clock_gettime... ./configure[20445]: ==: A test command parameter is not valid.
+
+Daniel Stenberg (27 Oct 2016)
+- SECURITY: minor updates
- Test 1213 and 1214 were added to the test suite to verify this fix.
+ - we allow the security push up to 48 hours before the release
- The test HTTP server was adjusted to allow us to specify test number in
- the host name only without using any slashes in a given URL.
+ - add a mention about possible pre-notifications
- Bug: http://curl.haxx.se/bug/view.cgi?id=1206
- Reported by: ScottJi
+ - lower case the 'curl-security' title
-Steve Holme (14 Mar 2013)
-- ftpserver.pl: Added EXAMINE_imap() for IMAP EXAMINE commands
-
- Used hard coded data from RFC-3501 section 6.3.2.
+- [Andrei Sedoi brought this change]
-Yang Tse (14 Mar 2013)
-- curl_memory.h: introduce CURLX_NO_MEMORY_CALLBACKS usage possibility
+ docs: fix req->data in multi-uv example
- This commit alone does not fix anything nor modifies existing
- interfaces or behaviors, although it is a prerequisite for other
- fixes.
+ Closes #1088
-- Makefile.vc6: add missing files
+- mbedtls: stop using deprecated include file
+
+ Reported-by: wyattoday
+ Fixes #1087
-Linus Nielsen Feltzing (14 Mar 2013)
-- pipelining: Remove dead code.
+Kamil Dudka (25 Oct 2016)
+- [Martin Frodl brought this change]
-- Multiple pipelines and limiting the number of connections.
+ nss: fix tight loop in non-blocking TLS handhsake over proxy
- Introducing a number of options to the multi interface that
- allows for multiple pipelines to the same host, in order to
- optimize the balance between the penalty for opening new
- connections and the potential pipelining latency.
+ ... in case the handshake completes before entering
+ CURLM_STATE_PROTOCONNECT
- Two new options for limiting the number of connections:
+ Bug: https://bugzilla.redhat.com/1388162
+
+Jay Satiro (25 Oct 2016)
+- mk-ca-bundle: Update the vbscript version
- CURLMOPT_MAX_HOST_CONNECTIONS - Limits the number of running connections
- to the same host. When adding a handle that exceeds this limit,
- that handle will be put in a pending state until another handle is
- finished, so we can reuse the connection.
+ Bring the VBScript version more in line with the perl version:
- CURLMOPT_MAX_TOTAL_CONNECTIONS - Limits the number of connections in total.
- When adding a handle that exceeds this limit,
- that handle will be put in a pending state until another handle is
- finished. The free connection will then be reused, if possible, or
- closed if the pending handle can't reuse it.
+ - Change timestamp to UTC.
- Several new options for pipelining:
+ - Change URL retrieval to HTTPS-only by default.
- CURLMOPT_MAX_PIPELINE_LENGTH - Limits the pipeling length. If a
- pipeline is "full" when a connection is to be reused, a new connection
- will be opened if the CURLMOPT_MAX_xxx_CONNECTIONS limits allow it.
- If not, the handle will be put in a pending state until a connection is
- ready (either free or a pipe got shorter).
+ - Comment out the options that disabled SSL cert checking by default.
- CURLMOPT_CONTENT_LENGTH_PENALTY_SIZE - A pipelined connection will not
- be reused if it is currently processing a transfer with a content
- length that is larger than this.
+ - Assume OpenSSL is present, get SHA256. And add a flag to toggle it.
- CURLMOPT_CHUNK_LENGTH_PENALTY_SIZE - A pipelined connection will not
- be reused if it is currently processing a chunk larger than this.
+ - Fix cert issuer name output.
- CURLMOPT_PIPELINING_SITE_BL - A blacklist of hosts that don't allow
- pipelining.
+ The cert issuer output is now ansi, converted from UTF-8. Prior to this
+ it was corrupt UTF-8. It turns out though we can work with UTF-8 the
+ FSO object that writes ca-bundle can't write UTF-8, so there will have
+ to be some alternative if UTF-8 is needed (like an ADODB.Stream).
- CURLMOPT_PIPELINING_SERVER_BL - A blacklist of server types that don't allow
- pipelining.
+ - Disable the certificate text info feature.
- See the curl_multi_setopt() man page for details.
+ The certificate text info doesn't work properly with any recent OpenSSL.
-Yang Tse (13 Mar 2013)
-- tool_main.c: remove redundant vms_show storage-class specifier
-
- vms_show 'extern' storage-class specifier removed from tool_main.c due to...
-
- - Advice from Tor Arntsen: http://curl.haxx.se/mail/lib-2013-03/0164.html
-
- - HP OpenVMS docs stating that 'Extern is the default storage class for
- variables declared outside a function.'
- http://h71000.www7.hp.com/commercial/c/docs/dec_c_help_5.html
- (Storage_Classes section)
+Daniel Stenberg (24 Oct 2016)
+- TODO: indent code to make it render properly
-- test509: libcurl initialization with memory callbacks and actual usage
+- TODO: Remove the generated include file
-Steve Holme (13 Mar 2013)
-- pop3: Removed unnecessary transfer cancellation
+- TODO: add "--retry should resume"
- Following commit e450f66a02d8 and the changes in the multi interface
- being used internally, from 7.29.0, the transfer cancellation in
- pop3_dophase_done() is no longer required.
+ See #1084
-Yang Tse (13 Mar 2013)
-- Makefile.am: add VMS files not being included in tarball
+- mk-ca-bundle.1: document -k
+
+ Brought in 1ad2bdcf110266c. Now does HTTPS by default and needs -k to
+ fall back to plain HTTP.
-- [Tom Grace brought this change]
+- [Jay Satiro brought this change]
- build_vms.com: VMS build fixes
+ mk-ca-bundle: Change URL retrieval to HTTPS-only by default
- Added missing slash in cc_full_list.
- Removed unwanted extra quotes inside symbol tool_main
- for non-VAX architectures that triggered link failure.
- Replaced curl_sys_inc with sys_inc.
+ - Change all predefined Mozilla URLs to HTTPS (Gregory Szorc).
+
+ - New option -k to allow URLs other than HTTPS and enable HTTP fallback.
+
+ Prior to this change the default URL retrieval mode was to fall back to
+ HTTP if HTTPS didn't work.
+
+ Reported-by: Gregory Szorc
+
+ Closes #1012
-- [Tom Grace brought this change]
+- RELEASE-NOTES: synced with 50ee3aaf1a9b22d
- tool_main.c: fix VMS global variable storage-class specifier
+Dan Fandrich (23 Oct 2016)
+- INSTALL.md: Updated minimum file sizes for 7.50.3
+
+Daniel Stenberg (22 Oct 2016)
+- multi: force connections to get closed in close_all_connections
+
+ Several independent reports on infinite loops hanging in the
+ close_all_connections() function when closing a multi handle, can be
+ fixed by first marking the connection to get closed before calling
+ Curl_disconnect.
- An extern submits a psect and a global reference to the linker to point
- to it. Using "extern int vms_show = 0" also creates a globaldef.
+ This is more fixing-the-symptom rather than the underlying problem
+ though.
- The use of the extern by itself does declare a psect but does not declare
- a globalsymbol. It does declare a globalref. But the linker needs one and
- only one globaldef or there is an error.
+ Bug: https://curl.haxx.se/mail/lib-2016-10/0011.html
+ Bug: https://curl.haxx.se/mail/lib-2016-10/0059.html
+
+ Reported-by: Dan Fandrich, Valentin David, Miloš Ljumović
-Patrick Monnerat (12 Mar 2013)
-- OS400: synchronize RPG binding
+- [Anders Bakken brought this change]
-Steve Holme (12 Mar 2013)
-- pop3: Fixed continuous wait when using --ftp-list
+ curl_multi_remove_handle: fix a double-free
+
+ In short the easy handle needs to be disconnected from its connection at
+ this point since the connection still is serving other easy handles.
+
+ In our app we can reliably reproduce a crash in our http2 stress test
+ that is fixed by this change. I can't easily reproduce the same test in
+ a small example.
+
+ This is the gdb/asan output:
+
+ ==11785==ERROR: AddressSanitizer: heap-use-after-free on address 0xe9f4fb80 at pc 0x09f41f19 bp 0xf27be688 sp 0xf27be67c
+ READ of size 4 at 0xe9f4fb80 thread T13 (RESOURCE_HTTP)
+ #0 0x9f41f18 in curl_multi_remove_handle /path/to/source/3rdparty/curl/lib/multi.c:666
+
+ 0xe9f4fb80 is located 0 bytes inside of 1128-byte region [0xe9f4fb80,0xe9f4ffe8)
+ freed by thread T13 (RESOURCE_HTTP) here:
+ #0 0xf7b1b5c2 in __interceptor_free /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_malloc_linux.cc:45
+ #1 0x9f7862d in conn_free /path/to/source/3rdparty/curl/lib/url.c:2808
+ #2 0x9f78c6a in Curl_disconnect /path/to/source/3rdparty/curl/lib/url.c:2876
+ #3 0x9f41b09 in multi_done /path/to/source/3rdparty/curl/lib/multi.c:615
+ #4 0x9f48017 in multi_runsingle /path/to/source/3rdparty/curl/lib/multi.c:1896
+ #5 0x9f490f1 in curl_multi_perform /path/to/source/3rdparty/curl/lib/multi.c:2123
+ #6 0x9c4443c in perform /path/to/source/src/net/resourcemanager/ResourceManagerCurlThread.cpp:854
+ #7 0x9c445e0 in ...
+ #8 0x9c4cf1d in ...
+ #9 0xa2be6b5 in ...
+ #10 0xf7aa5780 in asan_thread_start /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_interceptors.cc:226
+ #11 0xf4d3a16d in __clone (/lib/i386-linux-gnu/libc.so.6+0xe716d)
+
+ previously allocated by thread T13 (RESOURCE_HTTP) here:
+ #0 0xf7b1ba27 in __interceptor_calloc /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_malloc_linux.cc:70
+ #1 0x9f7dfa6 in allocate_conn /path/to/source/3rdparty/curl/lib/url.c:3904
+ #2 0x9f88ca0 in create_conn /path/to/source/3rdparty/curl/lib/url.c:5797
+ #3 0x9f8c928 in Curl_connect /path/to/source/3rdparty/curl/lib/url.c:6438
+ #4 0x9f45a8c in multi_runsingle /path/to/source/3rdparty/curl/lib/multi.c:1411
+ #5 0x9f490f1 in curl_multi_perform /path/to/source/3rdparty/curl/lib/multi.c:2123
+ #6 0x9c4443c in perform /path/to/source/src/net/resourcemanager/ResourceManagerCurlThread.cpp:854
+ #7 0x9c445e0 in ...
+ #8 0x9c4cf1d in ...
+ #9 0xa2be6b5 in ...
+ #10 0xf7aa5780 in asan_thread_start /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_interceptors.cc:226
+ #11 0xf4d3a16d in __clone (/lib/i386-linux-gnu/libc.so.6+0xe716d)
- Don't initiate a transfer when using --ftp-list.
+ SUMMARY: AddressSanitizer: heap-use-after-free /path/to/source/3rdparty/curl/lib/multi.c:666 in curl_multi_remove_handle
+ Shadow bytes around the buggy address:
+ 0x3d3e9f20: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9f30: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9f40: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9f50: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa
+ 0x3d3e9f60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
+ =>0x3d3e9f70:[fd]fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9f80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9f90: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9fa0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9fb0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ 0x3d3e9fc0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
+ Shadow byte legend (one shadow byte represents 8 application bytes):
+ Addressable: 00
+ Partially addressable: 01 02 03 04 05 06 07
+ Heap left redzone: fa
+ Heap right redzone: fb
+ Freed heap region: fd
+ Stack left redzone: f1
+ Stack mid redzone: f2
+ Stack right redzone: f3
+ Stack partial redzone: f4
+ Stack after return: f5
+ Stack use after scope: f8
+ Global redzone: f9
+ Global init order: f6
+ Poisoned by user: f7
+ Container overflow: fc
+ Array cookie: ac
+ Intra object redzone: bb
+ ASan internal: fe
+ Left alloca redzone: ca
+ Right alloca redzone: cb
+ ==11785==ABORTING
+
+ Thread 14 "RESOURCE_HTTP" received signal SIGABRT, Aborted.
+ [Switching to Thread 0xf27bfb40 (LWP 12324)]
+ 0xf7fd8be9 in __kernel_vsyscall ()
+ (gdb) bt
+ #0 0xf7fd8be9 in __kernel_vsyscall ()
+ #1 0xf4c7ee89 in __GI_raise (sig=6) at ../sysdeps/unix/sysv/linux/raise.c:54
+ #2 0xf4c803e7 in __GI_abort () at abort.c:89
+ #3 0xf7b2ef2e in __sanitizer::Abort () at /opt/toolchain/src/gcc-6.2.0/libsanitizer/sanitizer_common/sanitizer_posix_libcdep.cc:122
+ #4 0xf7b262fa in __sanitizer::Die () at /opt/toolchain/src/gcc-6.2.0/libsanitizer/sanitizer_common/sanitizer_common.cc:145
+ #5 0xf7b21ab3 in __asan::ScopedInErrorReport::~ScopedInErrorReport (this=0xf27be171, __in_chrg=<optimized out>) at /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_report.cc:689
+ #6 0xf7b214a5 in __asan::ReportGenericError (pc=166993689, bp=4068206216, sp=4068206204, addr=3925146496, is_write=false, access_size=4, exp=0, fatal=true) at /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_report.cc:1074
+ #7 0xf7b21fce in __asan::__asan_report_load4 (addr=3925146496) at /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_rtl.cc:129
+ #8 0x09f41f19 in curl_multi_remove_handle (multi=0xf3406080, data=0xde582400) at /path/to/source3rdparty/curl/lib/multi.c:666
+ #9 0x09f6b277 in Curl_close (data=0xde582400) at /path/to/source3rdparty/curl/lib/url.c:415
+ #10 0x09f3354e in curl_easy_cleanup (data=0xde582400) at /path/to/source3rdparty/curl/lib/easy.c:860
+ #11 0x09c6de3f in ...
+ #12 0x09c378c5 in ...
+ #13 0x09c48133 in ...
+ #14 0x09c4d092 in ...
+ #15 0x0a2be6b6 in ...
+ #16 0xf7aa5781 in asan_thread_start (arg=0xf2d22938) at /opt/toolchain/src/gcc-6.2.0/libsanitizer/asan/asan_interceptors.cc:226
+ #17 0xf5de52b5 in start_thread (arg=0xf27bfb40) at pthread_create.c:333
+ #18 0xf4d3a16e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:114
+
+ Fixes #1083
+
+- testcurl.1: fix the URL to the autobuild summary
+
+- testcurl.1: update URLs
+
+- INSTALL: converted to markdown => INSTALL.md
+
+ Also heavily edited for content. Removed lots of old cruft that we added
+ like 10+ years ago that is likely incorrect by now.
+
+ Also removed INSTALL.devcpp for same reason.
+
+- [Martin Storsjo brought this change]
-Kamil Dudka (12 Mar 2013)
-- [Zdenek Pavlas brought this change]
+ configure: Check for other variants of the -m*os*-version-min flags
+
+ In addition to -miphoneos-version-min, the same version can be set
+ using -mios-version-min. And for WatchOS and TvOS, there's
+ -mwatchos-version-min and -mtvos-version-min.
- curl_global_init: accept the CURL_GLOBAL_ACK_EINTR flag
+- configure: set min version flags for builds on mac
- The flag can be used in pycurl-based applications where using the multi
- interface would not be acceptable because of the performance lost caused
- by implementing the select() loop in python.
+ This helps building binaries that can work on multiple macOS versions.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1168
- Downstream Bug: https://bugzilla.redhat.com/919127
-
-- easy: do not ignore poll() failures other than EINTR
+ Help-by: Martin Storsjö
+
+ Fixes #1069
-Yang Tse (12 Mar 2013)
-- curl.h: stricter CURL_EXTERN linkage decorations logic
+- curl_multi_add_handle: set timeouts in closure handles
- No API change involved.
+ The closure handle only ever has default timeouts set. To improve the
+ state somewhat we clone the timeouts from each added handle so that the
+ closure handle always has the same timeouts as the most recently added
+ easy handle.
- Info: http://curl.haxx.se/mail/lib-2013-02/0234.html
-
-Daniel Stenberg (11 Mar 2013)
-- THANKS: Latin-1'ified Jiri's name
-
-Steve Holme (11 Mar 2013)
-- test806: Added CRLF to reply data to be compliant with RFC-822
+ Fixes #739
-Daniel Stenberg (11 Mar 2013)
-- test805: added crlf newlines to make data size match
+- configure/CURL_CHECK_FUNC_POLL: disable poll completely on mac
- since mails sent are supposed to have CRLF line endings I added them and
- now the data size after (\Seen) matches again properly
+ ... so that the same libcurl build easier can run on any version.
+
+ Follow-up to issue #1057
-- test: fix newline for the data check of 807
+- RELEASE-NOTES: synced with f36f8c14551efc6772
-Yang Tse (11 Mar 2013)
-- test801 to test807: fix protocol section line endings
+- test14xx: fixed --libcurl output tests again after 8e8afa82cbb
-Steve Holme (10 Mar 2013)
-- Makefile.am: Corrected a couple of spurious tab characters
+- s/cURL/curl
- Corrected a couple of tab characters between test702 and test703, and
- between test900 and test901 which should be spaces.
+ The tool was never called cURL, only the project. But even so, we have
+ more and more over time switched to just use lower case.
+
+- polarssl: indented code, removed unused variables
-- [Jiri Hruska brought this change]
+- polarssl: reduce #ifdef madness with a macro
- imap: Added test807 for custom request functionality (STORE)
+- polarssl: fix unaligned SSL session-id lock
-- [Jiri Hruska brought this change]
+- Curl_polarsslthreadlock_thread_setup: clear array at init
+
+ ... since if it fails to init the entire array and then tries to clean
+ it up, it would attempt to work on an uninitialized pointer.
- imap: Added test806 for IMAP (folder) LIST command
+- curl: set INTERLEAVEDATA too
+
+ As otherwise the callback could be called with a NULL pointer when RTSP
+ data is provided.
-- [Jiri Hruska brought this change]
+- gopher: properly return error for poll failures
- imap: Added test805 for APPEND functionality
+- select: switch to macros in uppercase
+
+ Curl_select_ready() was the former API that was replaced with
+ Curl_select_check() a while back and the former arg setup was provided
+ with a define (in order to leave existing code unmodified).
+
+ Now we instead offer SOCKET_READABLE and SOCKET_WRITABLE for the most
+ common shortcuts where only one socket is checked. They're also more
+ visibly macros.
-- [Jiri Hruska brought this change]
+- select: use more proper macro-looking names
+
+ ... so that it becomes more obvious in the code what is what. Also added
+ a typecast for one of the calculations.
- imap: Added test804 for skipping SELECT if in the same mailbox
+- Curl_socket_check: add extra check to avoid integer overflow
-- [Jiri Hruska brought this change]
+- maketgz: make it support "only" generating version info
+
+ ... to allow you to update the local repository with the given version
+ number data.
- imap: Added test802 and test803 for UIDVALIDITY verification
+Jay Satiro (17 Oct 2016)
+- url: skip to-be-closed connections when pipelining (follow-up)
- Added one test for a request with matching UIDVALIDITY and one which is
- a mismatched request that will fail.
+ - Change back behavior so that pipelining is considered possible for
+ connections that have not yet reached the protocol level.
+
+ This is a follow-up to e5f0b1a which had changed the behavior of
+ checking if pipelining is possible to ignore connections that had
+ 'bits.close' set. Connections that have not yet reached the protocol
+ level also have that bit set, and we need to consider pipelining
+ possible on those connections.
-- [Jiri Hruska brought this change]
+Daniel Stenberg (17 Oct 2016)
+- HTTP2: mention the tool's limited support
- imap: Added test801 for UID and SECTION URL parameters
+- RELEASE-NOTES: synced with a1a5cd04877fd6fd
-- [Jiri Hruska brought this change]
+- [David Woodhouse brought this change]
- imap-tests: Accept quoted parameters in ftpserver.pl
+ curl: do not set CURLOPT_SSLENGINEDEFAULT automatically
- Any IMAP parameter can come in escaped and in double quotes. Added a
- simple function to unquote the command parameters and applied it to
- the IMAP command handlers.
-
-- [Jiri Hruska brought this change]
-
- tests: Fix ftpserver.pl indentation
+ There were bugs in the PKCS#11 engine, and fixing them triggers bugs in
+ OpenSSL. Just don't get involved; there's no need to be making the
+ engine methods the default anyway.
- The whole of FETCH_imap() had one extra space of indentation, whilst
- APPEND_imap() used indentation of 2 instead of 4 in places.
-
-- Makefile.am: Corrected end of line filler character
+ https://github.com/OpenSC/libp11/pull/108
+ https://github.com/openssl/openssl/pull/1639
- The majority of lines, that specify a test file for inclusion, end with
- a tab character before the slash whilst some end with a space. Corrected
- those that end with a space to end with a tab character as well.
+ Merges #1042
-- email-tests: Updated the test data that corresponds to the test number
-
- Finished segregating the email protocol tests, into their own protocol
- based ranges, in preparation of adding more e-mail related tests to the
- test suite.
+- KNOWN_BUGS: two more existing problems
-- email-tests: Renamed the IMAP test to be 800
+Marcel Raad (16 Oct 2016)
+- win: fix Universal Windows Platform build
- Continued segregating the email protocol tests, into their own protocol
- based ranges, in preparation of adding more e-mail related tests to the
- test suite.
-
-- email-tests: Renamed the SMTP tests to be in the range 900-906
+ This fixes a merge error in commit 7f3df80 caused by commit 332e8d6.
- Continued segregating the email protocol tests, into their own protocol
- based ranges, in preparation of adding more e-mail related tests to the
- test suite.
-
-- email-tests: Renamed the POP3 tests to be in the range 850-857
+ Additionally, this changes Curl_verify_windows_version for Windows App
+ builds to assume to always be running on the target Windows version.
+ There seems to be no way to determine the Windows version from a
+ UWP app. Neither GetVersion(Ex), nor VerifyVersionInfo, nor the
+ Version Helper functions are supported.
- Started segregating the email protocol tests, into their own protocol
- based ranges, in preparation of adding more e-mail related tests to the
- test suite.
-
-Daniel Stenberg (10 Mar 2013)
-- hiperfifo: updated to use current libevent API
+ Bug: https://github.com/curl/curl/pull/820#issuecomment-250889878
+ Reported-by: Paul Joyce
- Patch by: Myk Taylor
+ Closes https://github.com/curl/curl/pull/1048
-Steve Holme (10 Mar 2013)
-- imap: Reworked some function descriptions
+Daniel Stenberg (16 Oct 2016)
+- KNOWN_BUGS: minor formatting edit
-- imap: Added some missing comments to imap_sendf()
+Jay Satiro (14 Oct 2016)
+- [Rider Linden brought this change]
-- email: Removed hard returns from init functions
-
-Daniel Stenberg (9 Mar 2013)
-- curl_multi_wait: avoid second loop if nothing to do
+ url: skip to-be-closed connections when pipelining
- ... hopefully this will also make clang-analyzer stop warning on
- potentional NULL dereferences (which were false positives anyway).
-
-- multi_runsingle: avoid NULL dereference
+ No longer attempt to use "doomed" to-be-closed connections when
+ pipelining. Prior to this change connections marked for deletion (e.g.
+ timeout) would be erroneously used, resulting in sporadic crashes.
- When Curl_do() returns failure, the connection pointer could be NULL so
- the code path following needs to that that into account.
+ As originally reported and fixed by Carlo Wood (origin unknown).
- Bug: http://curl.haxx.se/mail/lib-2013-03/0062.html
- Reported by: Eric Hu
+ Bug: https://github.com/curl/curl/issues/627
+ Reported-by: Rider Linden
+
+ Closes https://github.com/curl/curl/pull/1075
+ Participation-by: nopjmp@users.noreply.github.com
-Steve Holme (9 Mar 2013)
-- imap: Re-factored all perform based functions
+Daniel Stenberg (13 Oct 2016)
+- vtls: only re-use session-ids using the same scheme
- Standardised the naming of all perform based functions to be in the form
- imap_perform_something().
+ To make it harder to do cross-protocol mistakes
-Daniel Stenberg (9 Mar 2013)
-- [Cédric Deltheil brought this change]
+Jay Satiro (11 Oct 2016)
+- [Torben Dannhauer brought this change]
- examples/getinmemory.c: abort the transfer if not enough memory
+ dist: add missing cmake modules to the tarball
- No more use exit(3) but instead tell libcurl that no byte has been
- written to let it return a `CURLE_WRITE_ERROR`. In addition, check
- curl easy handle return code.
+ Closes https://github.com/curl/curl/pull/1070
-- RELEASE-NOTES: synced with ca3c0ed3a9c
+Daniel Stenberg (11 Oct 2016)
+- configure: detect the broken poll() in macOS 10.12
- 8 more bugfixes, one change and a bunch of contributors
+ Fixes #1057
-Yang Tse (9 Mar 2013)
-- Makefile.am: empty AM_LDFLAGS definition for automake 1.7 compatibility
+- dist: remove PDF and HTML converted docs from the releases
-Steve Holme (9 Mar 2013)
-- imap: Added description comments to all perform based functions
+- [Remo E brought this change]
-- imap: Removed the need for separate custom request functions
+ cmake: add nghttp2 support
- Moved the custom request processing into the LIST command as the logic
- is the same.
-
-- imap: Corrected typo in comment
+ Closes #922
-Yang Tse (9 Mar 2013)
-- Makefile.am: empty AM_LDFLAGS definition for automake 1.7 compatibility
+- [Andreas Streichardt brought this change]
-Steve Holme (9 Mar 2013)
-- imap: Moved imap_logout() to be grouped with the other perform functions
-
-- email: Updated the function descriptions for the logout / quit functions
+ resolve: add error message when resolving using SIGALRM
- Updated the function description comments following commit 4838d196fdbf.
+ Closes #1066
-- email: Simplified the logout / quit functions
+- GIT-INFO: remove the Mac 10.1-specific details
- Moved the blocking state machine to the disconnect functions so that the
- logout / quit functions are only responsible for sending the actual
- command needed to logout or quit.
+ There shouldn't be many devs out there anymore using such outdated macOS
+ versions. And it removes the dead link.
- Additionally removed the hard return on failure.
+ Closes #1049
+
+- RELEASE-NOTES: spellfix
-- email: Tidied up the *_regular_transfer() functions
+- RELEASE-NOTES: synced with 82720490628cb53a
- Added comments and simplified convoluted dophase_done comparison.
+ 5 more fixes, 2 more contributors
-- email: Simplified nesting of if statements in *_doing() functions
+- [Tobias Stoeckmann brought this change]
+
+ smb: properly check incoming packet boundaries
+
+ Not all reply messages were properly checked for their lengths, which
+ made it possible to access uninitialized memory (but this does not lead
+ to out of boundary accesses).
+
+ Closes #1052
-Daniel Stenberg (8 Mar 2013)
-- RELEASE-NOTES: mention that krb4 is up for consideration
+- test557: verify printf() with 128 and 129 arguments
-Steve Holme (8 Mar 2013)
-- imap: Fixed handling of untagged responses for the STORE custom command
+- mprintf: return error on too many arguments
- Added an exception, for the STORE command, to the untagged response
- processor in imap_endofresp() as servers will back respones containing
- the FETCH keyword instead.
+ 128 arguments should be enough for everyone
-Yang Tse (8 Mar 2013)
-- curlbuild.h.dist: enhance non-configure GCC ABI detection logic
+- ftp: fix Curl_ftpsendf()
- GCC specific adjustments:
+ ... it no longer takes printf() arguments since it was only really taken
+ advantage by one user and it was not written and used in a safe
+ way. Thus the 'f' is removed from the function name and the proto is
+ changed.
- - check __ILP32__ before 32 and 64bit processor architectures in
- order to detect ILP32 programming model on 64 bit processors
- which, of course, also support LP64 programming model, when using
- gcc 4.7 or newer.
+ Although the current code wouldn't end up in badness, it was a risk that
+ future changes could end up springf()ing too large data or passing in a
+ format string inadvertently.
+
+- formpost: avoid silent snprintf() truncation
- - keep 32bit processor architecture checks in order to support gcc
- versions older than 4.7 which don't define __ILP32__
+ The previous use of snprintf() could make libcurl silently truncate some
+ input data and not report that back on overly large input, which could
+ make data get sent over the network in a bad format.
- - check __LP64__ for gcc 3.3 and newer, while keeping 64bit processor
- architecture checks for older versions which don't define __LP64__
-
-- curlbuild.h.dist: fix GCC build on ARM systems without configure script
+ Example:
- Bug: http://curl.haxx.se/bug/view.cgi?id=1205
- Reported by: technion
-
-- [Gisle Vanem brought this change]
-
- polarssl.c: fix header filename typo
-
-- configure: use XC_LIBTOOL for portability across libtool versions
-
-- xc-lt-iface.m4: provide XC_LIBTOOL macro
+ $ curl --form 'a=b' -H "Content-Type: $(perl -e 'print "A"x4100')"
-Steve Holme (7 Mar 2013)
-- imap: Fixed SELECT not being performed for custom requests
+- TODO: build: Enable PIE and RELRO by default
-- email: Minor code tidy up following recent changes
-
- Removed unwanted braces and added variable initialisation.
-
-- DOCS: Corrected the IMAP URL grammar of the UIDVALIDITY parameter
+- TODO: Support better than MD5 hostkey hash (for ssh)
-- FEATURES: Provided a little clarity in some IMAP features
+- [Daniel Gustafsson brought this change]
-- email: Optimised block_statemach() functions
+ tests: Fix a small typo in the tests README (#1060)
- Optimised the result test in each of the block_statemach() functions.
+ The subdirectory for logs in tests/ is named log/ without an 's'
+ at the end.
-- DOCS: Added the list command to the IMAP URL section
+- TODO: Introduce --fail-fast to exit on first transfer fail
- Added examples of the list command and clarified existing example URLs
- following recent changes.
+ See #1054
-- FEATURES: Updated for recent imap additions
-
- Updated the imap features list, corrected a typo in the smtp features
- and clarified a pop3 feature.
+- TODO: Leave secure cookies alone
-Daniel Stenberg (7 Mar 2013)
-- version bump: the next release will be 7.30.0
+- [Rainer Müller brought this change]
-- checksrc: ban unsafe functions
-
- The list of unsafe functions currently consists of sprintf, vsprintf,
- strcat, strncat and gets.
+ CURLOPT_DEBUGFUNCTION.3: unused argument warning (#1056)
- Subsequently, some existing code needed updating to avoid warnings on
- this.
+ The 'userp' argument is unused in this example code.
-Steve Holme (7 Mar 2013)
-- RELEASE-NOTES: Added missing imap fixes and additions
-
- With all the recent imap changes it wasn't clear what new features and
- fixes should be included in the release notes.
+- TODO: TCP Fast Open for windows
-Nick Zitzmann (6 Mar 2013)
-- RELEASE-NOTES: brought this up-to-date with the latest changes
+- RELEASE-NOTES: synced with 8fd2a754f0de
-Steve Holme (6 Mar 2013)
-- [Jiri Hruska brought this change]
+- CURLOPT_KEEP_SENDING_ON_ERROR.3: mention when it is added
- imap: Fixed test801 and test1321 to specify a message UID
-
- Just a folder list would be retrieved if UID was not specified now.
+- memdup: use 'void *' as return and source type
-- [Jiri Hruska brought this change]
+- TODO: Add easy argument to formpost functions
- imap: Fixed ftpserver.pl to allow verification even through LIST command
+- formpost: trying to attach a directory no longer crashes
- Commit 198012ee inadvertently broke LIST_imap().
-
-- imap: Tidied up the APPEND and final APPEND response functions
+ The error path would previously add a freed entry to the linked list.
- Removed unnecessary state changes on failure and setting of result codes
- on success.
-
-- imap: Tidied up the final FETCH response function
+ Reported-by: Toby Peterson
- Removed unnecessary state change on failure and setting of result code on
- success.
+ Fixes #1053
-- imap: Tidied up the LIST response function
-
- Reworked comments as they referenced custom commands, removed
- unnecessary state change on failure and setting of result code on
- success.
+- [Sergei Kuzmin brought this change]
-- imap: Removed the custom request response function
+ cookies: same domain handling changed to match browser behavior
- Removed imap_state_custom_resp() as imap_state_list_resp() provides the
- same functionality.
-
-- [Jiri Hruska brought this change]
-
- imap: Updated ftpserver.pl to be more compliant, added new commands
+ Cokie with the same domain but different tailmatching property are now
+ considered different and do not replace each other. If header contains
+ following lines then two cookies will be set: Set-Cookie: foo=bar;
+ domain=.foo.com; expires=Thu Mar 3 GMT 8:56:27 2033 Set-Cookie: foo=baz;
+ domain=foo.com; expires=Thu Mar 3 GMT 8:56:27 2033
- Enriched IMAP capabilities of ftpserver.pl in order to be able to
- add tests for the new IMAP features.
+ This matches Chrome, Opera, Safari, and Firefox behavior. When sending
+ stored tokens to foo.com Chrome, Opera, Firefox store send them in the
+ stored order, while Safari pre-sort the cookies.
- * Added support for APPEND - Saves uploaded data to log/upload.$testno
- * Added support for LIST - Returns the contents of <reply/> section in
- the current test, like e.g FETCH.
- * Added support for STORE - Returns hardcoded updated flags
- * Changed handling of SELECT - Returns much more information in the
- usual set of untagged responses; uses hardcoded data from an example
- in the IMAP RFC
- * Changed handling of FETCH - Fixed response format
+ Closes #1050
-- imap: Added check for empty UID in FETCH command
-
- As the UID has to be specified by the user for the FETCH command to work
- correctly, added a check to imap_fetch(), although strictly speaking it
- is protected by the call from imap_perform().
+- [Stephen Brokenshire brought this change]
-Kamil Dudka (6 Mar 2013)
-- nss: fix misplaced code enabling non-blocking socket mode
+ FAQ: Fix typos in section 5.14 (#1047)
- The option needs to be set on the SSL socket. Setting it on the model
- takes no effect. Note that the non-blocking mode is still not enabled
- for the handshake because the code is not yet ready for that.
+ Type required for YourClass::func C++ function (using size_t in line
+ with the documentation for CURLOPT_WRITEFUNCTION) and missing second
+ colon when specifying the static function for CURLOPT_WRITEFUNCTION.
-Daniel Stenberg (6 Mar 2013)
-- imap: fix compiler warning
+- [Sebastian Mundry brought this change]
+
+ KNOWN_BUGS: Fix typos in section 5.8.
- imap.c:694:21: error: unused variable 'imapc' [-Werror=unused-variable]
+ Closes #1046
-Steve Holme (5 Mar 2013)
-- imap: Added support for list command
+- [mundry brought this change]
-- imap: Added list perform and response handler functions
+ CONTRIBUTE.md: Fix typo in 'About pull requests' section. (#1045)
-- imap: Introduced IMAP_LIST state
+- curl.1: --trace supports % for sending to stderr!
-- imap: Small tidy up of imap_select() to match imap_append()
-
- Updated the style of imap_select() before adding the LIST command.
+- KNOWN_BUGS: 5.8 configure finding libs in wrong directory
-- imap: Moved mailbox check from the imap_do() function
+Dan Fandrich (24 Sep 2016)
+- configure: Fixed builds with libssh2 in a custom location
- In preparation for the addition of the LIST command, moved the mailbox
- check from imap_do() to imap_select() and imap_append().
+ A libssh2 library in the standard system location was being used in
+ preference to the desired one while linking.
-- curl_setup.h: Added S_IRDIR() macro for compilers that don't support it
-
- Commit 26eaa8383001 introduces the use of S_ISDIR() yet some compilers,
- such as MSVC don't support it, so we must define a substitute using
- file flags and mask.
+Daniel Stenberg (23 Sep 2016)
+- SECURITY: remove the top ascii logo
-Daniel Stenberg (4 Mar 2013)
-- AddFormData: prevent only directories from being posted
+Michael Kaufmann (22 Sep 2016)
+- New libcurl option to keep sending on error
- Commit f4cc54cb4746ae5a6d (shipped as part of the 7.29.0 release) was a
- bug fix that introduced a regression in that while trying to avoid
- allowing directory names, it also forbade "special" files like character
- devices and more. like "/dev/null" as was used by Oliver who reported
- this regression.
+ Add the new option CURLOPT_KEEP_SENDING_ON_ERROR to control whether
+ sending the request body shall be completed when the server responds
+ early with an error status code.
- Reported by: Oliver Gondža
- Bug: http://curl.haxx.se/mail/archive-2013-02/0040.html
-
-Nick Zitzmann (3 Mar 2013)
-- darwinssl: fix infinite loop if server disconnected abruptly
+ This is suitable for manual NTLM authentication.
- If the server hung up the connection without sending a closure alert,
- then we'd keep probing the socket for data even though it's dead. Now
- we're ready for this situation.
+ Reviewed-by: Jay Satiro
- Bug: http://curl.haxx.se/mail/lib-2013-03/0014.html
- Reported by: Aki Koskinen
+ Closes https://github.com/curl/curl/pull/904
-Steve Holme (3 Mar 2013)
-- imap: Added comments to imap_append()
+Kamil Dudka (22 Sep 2016)
+- nss: add chacha20-poly1305 cipher suites if supported by NSS
-- [Jiri Hruska brought this change]
+- nss: add cipher suites using SHA384 if supported by NSS
- imap: Added required mailbox check for FETCH and APPEND commands
-
-- pingpong.c: Fix enumerated type mixed with another type
-
-- smtp: Updated the coding style for state changes after a send operation
+- nss: fix typo in ecdhe_rsa_null cipher suite string
- Some state changes would be performed after a failure test that
- performed a hard return, whilst others would be performed within a test
- for success. Updated the code, for consistency, so all instances are
- performed within a success test.
+ As it seems to be a rarely used cipher suite (for securely established
+ but _unencrypted_ connections), I believe it is fine not to provide an
+ alias for the misspelled variant.
-- pop3: Updated the coding style for state changes after a send operation
+Jay Satiro (21 Sep 2016)
+- docs: Remove that --proto is just used for initial retrieval
- Some state changes would be performed after a failure test that
- performed a hard return, whilst others would be performed within a test
- for success. Updated the code, for consistency, so all instances are
- performed within a success test.
-
-- imap: Fixed typo in variable assignment
+ .. and add that --proto-redir and CURLOPT_REDIR_PROTOCOLS do not
+ override protocols denied by --proto and CURLOPT_PROTOCOLS.
+
+ - Add a test to enforce: --proto deny must override --proto-redir allow
+
+ Closes https://github.com/curl/curl/pull/1031
-- [Jiri Hruska brought this change]
+Daniel Stenberg (21 Sep 2016)
+- dist: add CurlSymbolHiding.cmake to the tarball
+
+ Follow-up to 6140dfcf3e784
+
+ Reported-by: Alexander Sinditskiy
- imap: Fixed custom request handling in imap_done()
+- curl_global_cleanup.3: don't unload the lib with sub threads running
+
+ Discussed in #997
- Fixed imap_done() so that neither the FINAL states are not entered when
- a custom command has been performed.
+ Assisted-by: Jay Satiro
-- [Jiri Hruska brought this change]
+- MAIL-ETIQUETTE: language
- imap: Enabled custom requests in imap_select_resp()
+Jay Satiro (20 Sep 2016)
+- easy: Reset all statistical session info in curl_easy_reset
- Changed imap_select_resp() to invoke imap_custom() instead of
- imap_fetch() after the mailbox has been selected if a custom
- command has been set.
+ Bug: https://github.com/curl/curl/issues/1017
+ Reported-by: Jeroen Ooms
-- [Jiri Hruska brought this change]
+Daniel Stenberg (19 Sep 2016)
+- RELEASE-NOTES: synced with 79607eec51055
- imap: Enabled custom requests in imap_perform()
+Jay Satiro (19 Sep 2016)
+- [Daniel Gustafsson brought this change]
+
+ darwinssl: Fix typo in comment
- Modified imap_perform() to start with the custom command instead of
- SELECT when a custom command is to be performed and no mailbox has
- been given.
+ Closes https://github.com/curl/curl/pull/1028
-- [Jiri Hruska brought this change]
+Daniel Stenberg (19 Sep 2016)
+- [Bernard Spil brought this change]
- imap: Added custom request perform and response handler functions
+ libressl: fix version output
- Added imap_custom(), which initiates the custom command processing,
- and an associated response handler imap_state_custom_resp(), which
- handles any responses by sending them to the client as body data.
+ LibreSSL defines `OPENSSL_VERSION_NUMBER` as `0x20000000L` for all
+ versions returning `LibreSSL/2.0.0` for any LibreSSL version.
- All untagged responses with the same name as the first word of the
- custom request string are accepted, with the exception of SELECT and
- EXAMINE which have responses that cannot be easily identified. An
- extra check has been provided for them so that any untagged responses
- are accepted for them.
-
-- pop3: Fixed unnecessary parent structure reference
+ This change provides a local OpenSSL_version_num function replacement
+ returning LIBRESSL_VERSION_NUMBER instead.
- Updated pop3 code following recent imap changes.
+ Closes #1029
-- [Jiri Hruska brought this change]
+- [rugk brought this change]
- imap: Added custom request parsing
+ TODO: Add PINNEDPUBLICKEY - HPKP compatibility, HSTS & HPKP
- Added imap_parse_custom_request() for parsing the CURLOPT_CUSTOMREQUEST
- parameter which URL decodes the value and separates the request from
- any parameters - This makes it easier to filter untagged responses
- by the request command.
+ Closes #1025
+ Closes #1026
+ Closes #1027
-- [Jiri Hruska brought this change]
+- openssl: don't call ERR_remote_thread_state on >= 1.1.0
+
+ Follow-up fix to d9321562
- imap: Introduced custom request parameters
+- openssl: don’t call CRYTPO_cleanup_all_ex_data
+
+ The OpenSSL function CRYTPO_cleanup_all_ex_data() cannot be called
+ multiple times without crashing - and other libs might call it! We
+ basically cannot call it without risking a crash. The function is a
+ no-op since OpenSSL 1.1.0.
- Added custom request parameters to the per-request structure.
+ Not calling this function only risks a small memory leak with OpenSSL <
+ 1.1.0.
+
+ Bug: https://curl.haxx.se/mail/lib-2016-09/0045.html
+ Reported-by: Todd Short
-- [Jiri Hruska brought this change]
+- TODO: Support SSLKEYLOGFILE
- imap: Introduced IMAP_CUSTOM state
+Jay Satiro (18 Sep 2016)
+- CURLOPT_PINNEDPUBLICKEY.3: fix the AVAILABILITY formatting
-- imap: Minor code tidy up
+Nick Zitzmann (18 Sep 2016)
+- darwinssl: disable RC4 cipher-suite support
- Minor tidy up of code layout and comments following recent changes.
+ RC4 was a nice alternative to CBC back in the days of BEAST, but it's insecure and obsolete now.
-- imap: Simplified the imap_state_append_resp() function
+- configure: change "iOS/Mac OS X native" to "Apple OS native"
- Introduced the result code variable to simplify the state changes and
- remove the hard returns.
+ Since I first wrote that text, Apple introduced tvOS and watchOS, and renamed "Mac OS X" to "macOS." Let's make the text a little more inclusive, since curl can be built for all four operating systems.
-- imap: Changed successful response logic in imap_state_append_resp()
-
- For consistency changed the logic of the imap_state_append_resp()
- function to test for an unsucessful continuation response rather than a
- succesful one.
+Jay Satiro (18 Sep 2016)
+- test2048: fix url
-- imap: Standardised imapcode condition tests
+- examples/imap-append: Set size of data to be uploaded
- For consistency changed two if(constant != imapcode) tests to be
- if(imapcode != constant).
-
-- imap: Moved imap_append() to be with the other perform functions
+ Prior to this commit this example failed with error
+ 'Cannot APPEND with unknown input file size'.
+
+ Bug: https://github.com/curl/curl/issues/1008
+ Reported-by: lukaszgn@users.noreply.github.com
+
+ Closes https://github.com/curl/curl/pull/1011
-- [Jiri Hruska brought this change]
+Daniel Stenberg (16 Sep 2016)
+- [Tony Kelman brought this change]
- imap: Enabled APPEND support in imap_perform()
+ LICENSE-MIXING.md: update with mbedTLS dual licensing
+
+ Recent versions of mbedTLS are available under either Apache 2.0 or GPL
+ 2.0, see https://tls.mbed.org/how-to-get
- Added logic in imap_perform() to perform an APPEND rather than SELECT
- and FETCH if an upload has been specified.
+ Closes #1019
-- [Jiri Hruska brought this change]
+- KNOWN_BUGS: chunked-encoded requests with HTTP/2 is fixed
- imap: Implemented APPEND final processing
+- http2: debug ouput sent HTTP/2 request headers
+
+- http: accept "Transfer-Encoding: chunked" for HTTP/2 as well
- The APPEND operation needs to be performed in several steps:
- 1) We send "<tag> APPEND <mailbox> <flags> {<size>}\r\n"
- 2) Server responds with continuation respose "+ ...\r\n"
- 3) We start the transfer and send <size> bytes of data
- 4) Only now we end the request command line by sending "\r\n"
- 5) Server responds with "<tag> OK ...\r\n"
+ ... but don't send the actual header over the wire as it isn't accepted.
+ Chunked uploading is still triggered using this method.
- This commit performs steps 4 and 5, in the DONE phase, as more
- processing is required after the transfer.
-
-- [Jiri Hruska brought this change]
+ Fixes #1013
+ Fixes #662
- imap: Added APPEND perform and response handler functions
+- openssl: fix per-thread memory leak usiong 1.0.1 or 1.0.2
- Added imap_append() function to initiate upload and imap_append_resp()
- to handle the continuation response and start the transfer.
+ OpenSSL 1.0.1 and 1.0.2 build an error queue that is stored per-thread
+ so we need to clean it when easy handles are freed, in case the thread
+ will be killed in which the easy handle was used. All OpenSSL code in
+ libcurl should extract the error in association with the error already
+ so clearing this queue here should be harmless at worst.
+
+ Fixes #964
-- [Jiri Hruska brought this change]
+- RELEASE-NOTES: reset and go toward 7.51.0 (again)
- imap: Introduced IMAP_APPEND and IMAP_APPEND_FINAL states
+Version 7.50.3 (14 Sep 2016)
-- [Jiri Hruska brought this change]
+Daniel Stenberg (14 Sep 2016)
+- THANKS: updated with curl 7.50.3 contributors
- imap: Updated setting of transfer variables in imap_state_fetch_resp()
-
- Add number of bytes retrieved from the PP cache to req.bytecount and set
- req.maxdownload only when starting a proper download.
+- RELEASE-NOTES: curl 7.50.3
-- [Jiri Hruska brought this change]
+- test1605: verify negative input lengths to (un)escape functions
- imap: Improved FETCH response parsing
+- curl_easy_unescape: deny negative string lengths as input
- Added safer parsing of the untagged FETCH response line and the size of
- continuation data.
-
-- imap: Fixed accidentally lossing the result code
+ CVE-2016-7167
- Accidentally lost the result code in imap_state_capability() and
- imap_state_login() with commit b06a78622609.
-
-- imap: Another minor comment addition / tidy up
+ Bug: https://curl.haxx.se/docs/adv_20160914.html
-- imap: Updated the coding style for state changes after a send operation
+- curl_easy_escape: deny negative string lengths as input
- Some state changes would be performed after a failure test that
- performed a hard return, whilst others would be performed within a test
- for success. Updated the code, for consistency, so all instances are
- performed within a success test.
-
-- pop3 / smtp: Small comment tidy up
+ CVE-2016-7167
- Small tidy up to keep some comments consistant across each of the email
- protocols.
-
-- [Jiri Hruska brought this change]
+ Bug: https://curl.haxx.se/docs/adv_20160914.html
- imap: FETCH response handler cleanup before further changes
+- curl: make --create-dirs on windows grok both forward and backward slashes
- Removed superfluous NULL assignment after Curl_safefree() and rewrote
- some comments and logging messages.
+ Reported-by: Ryan Scott
+
+ Fixes #1007
-- pop3: Small tidy up of function arguments
+- RELEASE-NOTES: synced with 665694979b6
-- imap: Small tidy up of function arguments
+- [Tony Kelman brought this change]
-- smtp: Corrected debug message for POP3_AUTH_FINAL constant
+ mbedtls: switch off NTLM in build if md4 isn't available
- Following commit ad3177da24b8 corrected the debug message in state()
- from AUTH to AUTH_FINAL.
-
-- pop3: Corrected debug message for POP3_AUTH_FINAL constant
+ NTLM support with mbedTLS was added in 497e7c9 but requires that mbedTLS
+ is built with the MD4 functions available, which it isn't in default
+ builds. This now adapts if the funtion isn't there and builds libcurl
+ without NTLM support if so.
- Following commit afad1ce753a1 corrected the debug message in state()
- from AUTH to AUTH_FINAL.
+ Fixes #1004
-- imap: Corrected debug message for IMAP_AUTHENTICATE_FINAL constant
+Jay Satiro (12 Sep 2016)
+- CODE_STYLE: fix long-line guideline
- Following commit 13006f3de9ec corrected the debug message in state()
- from AUTHENTICATE to AUTHENTICATE_FINAL.
+ - Change maximum allowed line length from 80 to 79.
-- [Jiri Hruska brought this change]
-
- imap: Fixed error code returned for invalid FETCH response
+- CODE_STYLE: add column alignment section
- If the FETCH command does not result in an untagged response the the
- UID is probably invalid. As such do not return CURLE_OK.
-
-- [Jiri Hruska brought this change]
+ Note that since the added examples are for column alignment I had to
+ encapsulate with ~~~c markdown to preserve their alignment.
- imap: Added processing of the final FETCH responses
+Peter Wu (11 Sep 2016)
+- cmake: fix curl-config --static-libs
- Not processing the final FETCH responses was not optimal, not only
- because the response code would be ignored but it would also leave data
- unread on the socket which would prohibit connection reuse.
-
-- [Jiri Hruska brought this change]
+ The `curl-config --static-libs` command should not output paths like
+ -l/usr/lib/libssl.so, instead print the absolute path without `-l`.
+
+ This also removes the confusing message "Static linking is broken" which
+ was printed because curl-config --static-libs was disfunctional even
+ though the static libcurl.a library works properly.
+
+ Fixes https://github.com/curl/curl/issues/841
- imap: Introduced FETCH_FINAL state for processing final fetch responses
+Daniel Stenberg (11 Sep 2016)
+- http: refuse to pass on response body with NO_NODY was set
- A typical FETCH response can be broken down into four parts:
+ ... like when a HTTP/0.9 response comes back without any headers at all
+ and just a body this now prevents that body from being sent to the
+ callback etc.
- 1) "* <uid> FETCH (<what> {<size>}\r\n", using continuation syntax
- 2) <size> bytes of the actual message
- 3) ")\r\n", finishing the untagged response
- 4) "<tag> OK ...", finishing the command
+ Adapted test 1144 to verify.
- Part 1 is read in imap_fetch_resp(), part 2 is consumed in the PERFORM
- phase by the transfer subsystem, parts 3 and 4 are currently ignored.
-
-- imap: fix autobuild warning
+ Fixes #973
- Removed whitespace from imap_perform()
+ Assisted-by: Ray Satiro
-- imap: fix compiler warning
-
- error: declaration of 'imap' shadows a previous local
+- RELEASE-NOTES: synced with 257bf3ac67eb6
-- smtp: Re-factored the final SMTP_AUTH constant
+Jakub Zakrzewski (10 Sep 2016)
+- CMake: Don't build unit tests if private symbols are hidden
- Changed the final SMTP_AUTH constant to SMTP_AUTH_FINAL for consistency
- with the response function.
-
-- pop3: Re-factored the final POP3_AUTH constant
+ This only excludes building unit tests from default build ( 'all' Make
+ target or "Build Solution" in VisualStudio). The projects and Make
+ targets will still be generated and shown in supporting IDEs.
- Changed the final POP3_AUTH constant to POP3_AUTH_FINAL for consistency
- with the response function.
-
-- imap: Re-factored final IMAP_AUTHENTICATE constant
+ Fixes https://github.com/curl/curl/issues/981
+ Reported-by: Randy Armstrong
- Changed the final IMAP_AUTHENTICATE constant to IMAP_AUTHENTICATE_FINAL
- for consistency with the response function.
+ Closes https://github.com/curl/curl/pull/990
-- imap: Updated the coding style of imap_state_servergreet_resp()
+- CMake: Try to (un-)hide private library symbols
+
+ Detect support for compiler symbol visibility flags and apply those
+ according to CURL_HIDDEN_SYMBOLS option.
+ It should work true to the autotools build except it tries to unhide
+ symbols on Windows when requested and prints warning if it fails.
- Updated the coding style, in this function, to be consistant with other
- response functions rather then performing a hard return on failure.
+ Ref: https://github.com/curl/curl/issues/981#issuecomment-242665951
+ Reported-by: Daniel Stenberg
-- imap: Reversed the logic of the (un)successful tagged SELECT response
+Daniel Stenberg (9 Sep 2016)
+- openssl: fix bad memory free (regression)
- Reversed the logic of the unsuccessful vs successful tagged SELECT
- response in imap_state_select_resp() to be more logical to read.
+ ... by partially reverting f975f06033b1. The allocation could be made by
+ OpenSSL so the free must be made with OPENSSL_free() to avoid problems.
+
+ Reported-by: Harold Stuart
+ Fixes #1005
-- imap: Reversed the logic of the (un)successful tagged CAPABILITY response
+- http2: support > 64bit sized uploads
+
+ ... by making sure we don't count down the "upload left" counter when the
+ uploaded size is unknown and then it can be allowed to continue forever.
- Reversed the logic of the unsuccessful vs successful tagged CAPABILITY
- response in imap_state_capability_resp() to be more logical to read.
+ Fixes #996
-- imap: Corrected char* references with char *
+Jay Satiro (7 Sep 2016)
+- errors: new alias CURLE_WEIRD_SERVER_REPLY (8)
- Corrected char* references made in commit: 709b3506cd9b.
+ Since we're using CURLE_FTP_WEIRD_SERVER_REPLY in imap, pop3 and smtp as
+ more of a generic "failed to parse" introduce an alias without FTP in
+ the name.
+
+ Closes https://github.com/curl/curl/pull/975
-- [Jiri Hruska brought this change]
+Daniel Stenberg (7 Sep 2016)
+- bump: toward 7.51.0
- imap: Added processing of more than one response when sent in same packet
-
- Added a loop to imap_statemach_act() in which Curl_pp_readresp() is
- called until the cache is drained. Without this multiple responses
- received in a single packet could result in a hang or delay.
+- HISTORY: remove ascii logo to render nicer on web
-- [Jiri Hruska brought this change]
+- curl: whitelist use of strtok() in non-threaded context
- imap: Added skipping of SELECT command if already in the same mailbox
+- checksrc: detect strtok() use
- Added storage and checking of the last mailbox userd to prevent
- unnecessary switching.
+ ... as that function slipped through once before.
-- [Jiri Hruska brought this change]
+GitHub (7 Sep 2016)
+- [Viktor Szakats brought this change]
- imap: Introduced the mailbox variable
+ mk-ca-bundle.pl: use SHA256 instead of SHA1
- Added the mailbox variable to the per-connection structure in
- preparation for checking for an already selected mailbox.
+ This hash is used to verify the original downloaded certificate bundle
+ and also included in the generated bundle's comment header. Also
+ rename related internal symbols to algorithm-agnostic names.
-- email: Slight reordering of connection based variables
-
- Reordered the state and ssl_done variables in order to provide more
- consistency between the email protocols as well as for for an upcoming
- change.
+Version 7.50.2 (7 Sep 2016)
-- imap: Tidied up comments for connection based variables
+Daniel Stenberg (7 Sep 2016)
+- RELEASE-NOTES: curl 7.50.2 release
-- DOCS: Added the IMAP UIDVALIDITY property to the CURLOPT_URL section
+- THANKS: updated for 7.50.2
-- [Jiri Hruska brought this change]
+Jay Satiro (6 Sep 2016)
+- [Gaurav Malhotra brought this change]
- imap: Added verification of UIDVALIDITY mailbox attribute
+ openssl: fix CURLINFO_SSL_VERIFYRESULT
- Added support for checking the UIDVALIDITY, and aborting the request, if
- it has been specified in the URL and the server response is different.
-
-- [Jiri Hruska brought this change]
-
- imap: Added support for parsing the UIDVALIDITY property
+ CURLINFO_SSL_VERIFYRESULT does not get the certificate verification
+ result when SSL_connect fails because of a certificate verification
+ error.
+
+ This fix saves the result of SSL_get_verify_result so that it is
+ returned by CURLINFO_SSL_VERIFYRESULT.
- Added support for parsing the UIDVALIDITY property from the SELECT
- response and storing it in the per-connection structure.
+ Closes https://github.com/curl/curl/pull/995
-- [Jiri Hruska brought this change]
+Daniel Stenberg (6 Sep 2016)
+- [Daniel Gustafsson brought this change]
- imap: Introduced the mailbox_uidvalidity variable
+ darwinssl: test for errSecSuccess in PKCS12 import rather than noErr (#993)
- Added the mailbox_uidvalidity variable to the per-connection structure
- in preparation for checking the UIDVALIDITY mailbox attribute.
+ While noErr and errSecSuccess are defined as the same value, the API
+ documentation states that SecPKCS12Import() returns errSecSuccess if
+ there were no errors in importing. Ensure that a future change of the
+ defined value doesn't break (however unlikely) and be consistent with
+ the API docs.
-- imap: Corrected comment in imap_endofresp()
+- [Daniel Gustafsson brought this change]
-- imap: Corrected whitespace
+ docs: Fix link to CONTRIBUTE in Github contribution guidelines (#994)
-- [Jiri Hruska brought this change]
+- [Marcel Raad brought this change]
- imap: Added filtering of CAPABILITY and FETCH untagged responses
+ openssl: Fix compilation with OPENSSL_API_COMPAT=0x10100000L
- Only responses that contain "CAPABILITY" and "FETCH", respectively,
- will be sent to their response handler.
-
-- [Jiri Hruska brought this change]
-
- imap: Added a helper function for upcoming untagged response filtering
+ With OPENSSL_API_COMPAT=0x10100000L (OpenSSL 1.1 API), the cleanup
+ functions are unavailable (they're no-ops anyway in OpenSSL 1.1). The
+ replacements for SSL_load_error_strings, SSLeay_add_ssl_algorithms, and
+ OpenSSL_add_all_algorithms are called automatically [1][2]. SSLeay() is
+ now called OpenSSL_version_num().
- RFC 3501 states that "the client MUST be prepared to accept any response
- at all times" yet we assume anything received with "* " at the beginning
- is the untagged response we want.
+ [1]: https://www.openssl.org/docs/man1.1.0/ssl/OPENSSL_init_ssl.html
+ [2]: https://www.openssl.org/docs/man1.1.0/crypto/OPENSSL_init_crypto.html
- Introduced a helper function that checks whether the input looks like a
- response to specified command, so that we may filter the ones we are
- interested in according to the current state.
+ Closes #992
-- [Jiri Hruska brought this change]
+- RELEASE-NOTES: synced with 3d4c0c8b9bc1d
- imap: Moved CAPABILITY response handling to imap_state_capability_resp()
+- http2: return EOF when done uploading without known size
- Introduced similar handling to the FETCH responses, where even the
- untagged data responses are handled by the response handler of the
- individual state.
+ Fixes #982
-Linus Nielsen Feltzing (26 Feb 2013)
-- Remove unused variable in smtp_state_data_resp()
+- http2: skip the content-length parsing, detect unknown size
-Steve Holme (25 Feb 2013)
-- email: Small tidy up following recent changes
+- http2: minor white space edit
-- smtp: Removed bytecountp from the per-request structure
-
- Removed this pointer to a downloaded bytes counter because it was set in
- smtp_init() to point to the same variable the transfer functions keep
- the count in (k->bytecount), effectively making the code in transfer.c
- "*k->bytecountp = k->bytecount" a no-op.
-
-- pop3: Removed bytecountp from the per-request structure
-
- Removed this pointer to a downloaded bytes counter because it was set in
- pop3_init() to point to the same variable the transfer functions keep
- the count in (k->bytecount), effectively making the code in transfer.c
- "*k->bytecountp = k->bytecount" a no-op.
+- http2: use named define instead of magic constant in read callback
-- [Jiri Hruska brought this change]
+- [Craig Davison brought this change]
- imap: Removed bytecountp from the per-request structure
+ configure: make the cpp -P detection not clobber CPPFLAGS
+
+ CPPPFLAGS is now CPPPFLAG. Fixes CURL_CHECK_DEF.
- Removed this pointer to a downloaded bytes counter because it was set in
- imap_init() to point to the same variable the transfer functions keep
- the count in (k->bytecount), effectively making the code in transfer.c
- "*k->bytecountp = k->bytecount" a no-op.
+ Fixes #958
-- [Jiri Hruska brought this change]
+- [Olivier Brunel brought this change]
- imap: Adjusted SELECT and FETCH function order
+ speed caps: not based on average speeds anymore
- Moved imap_select() and imap_fetch() to be grouped with the other
- perform functions.
-
-- [Jiri Hruska brought this change]
-
- imap: Adjusted SELECT and FETCH state order in imap_statemach_act()
+ Speed limits (from CURLOPT_MAX_RECV_SPEED_LARGE &
+ CURLOPT_MAX_SEND_SPEED_LARGE) were applied simply by comparing limits
+ with the cumulative average speed of the entire transfer; While this
+ might work at times with good/constant connections, in other cases it
+ can result to the limits simply being "ignored" for more than "short
+ bursts" (as told in man page).
- Exchanged the position of these states in the switch statements to
- match the state enum, execution and function order.
-
-- imap: Minor tidy up of comments in imap_parse_url_path()
+ Consider a download that goes on much slower than the limit for some
+ time (because bandwidth is used elsewhere, server is slow, whatever the
+ reason), then once things get better, curl would simply ignore the limit
+ up until the average speed (since the beginning of the transfer) reached
+ the limit. This could prove the limit useless to effectively avoid
+ using the entire bandwidth (at least for quite some time).
- Tidy up of comments before next round of imap changes.
-
-- imap: Fixed incorrect comparison for STARTTLS in imap_endofresp()
+ So instead, we now use a "moving starting point" as reference, and every
+ time at least as much as the limit as been transferred, we can reset
+ this starting point to the current position. This gets a good limiting
+ effect that applies to the "current speed" with instant reactivity (in
+ case of sudden speed burst).
- Corrected the comparison type in addition to commit 1dac29fa83a9.
+ Closes #971
-- DOCS: Corrected IMAP URL examples according to RFC5092
-
- URL examples that included the UID weren't technically correct although
- would pass the curl parser.
+- HISTORY.md: the multi socket was put in the wrong year!
-Nick Zitzmann (24 Feb 2013)
-- darwinssl: fix undefined $ssllib warning in runtests.pl
-
- I also added --with-darwinssl to the list of SSL options in configure.
+- [Mark Hamilton brought this change]
-Steve Holme (24 Feb 2013)
-- imap: Added check for new internal imap response code
+ tool_helpers.c: fix comment typo (#989)
-- imap: Changed the order of the response types in imap_endofresp()
-
- From a maintenance point of view the code reads better to view tagged
- responses, then untagged followed by continuation responses.
-
- Additionally, this matches the order of responses in POP3.
+- [Mark Hamilton brought this change]
-- [Jiri Hruska brought this change]
+ libtest/test.h: fix typo (#988)
- imap: Added stricter parsing of continuation responses
-
- Enhanced the parsing to only allow continuation responses in some
- states.
+- CURLMOPT_PIPELINING.3: language
-- imap: Simplified memcmp() in tagged response parsing
+- CURLMOPT_PIPELINING.3: extended and clarified
+
+ Especially in regards to the multiplexing part.
-- [Jiri Hruska brought this change]
+Steve Holme (31 Aug 2016)
+- curl_sspi.c: Updated function description comments
+
+ * Added description to Curl_sspi_free_identity()
+ * Added parameter and return explanations to Curl_sspi_global_init()
+ * Added parameter explaination to Curl_sspi_global_cleanup()
- imap: Reworked the logic of untagged command responses
+- README: Corrected the supported Visual Studio versions
+
+ Missed from commit 8356022d17.
-- imap: Corrected spacing of trailing brace
+- KNOWN_BUGS: Move the Visual Studio project shortcomings from local README
-- [Jiri Hruska brought this change]
+- KNOWN_BUGS: Expand 6.4 to include Kerberos V5
+
+ ...and discuss a possible solution.
- imap: Added stricter parsing of tagged command responses
+Daniel Stenberg (30 Aug 2016)
+- connect: fix #ifdefs for debug versions of conn/streamclose() macros
+
+ CURLDEBUG is for the memory debugging
- Enhanced the parsing of tagged responses which must start with "OK",
- "NO" or "BAD"
+ DEBUGBUILD is for the extra debug stuff
+
+ Pointed-out-by: Steve Holme
-- [Jiri Hruska brought this change]
+- KNOWN_BUGS: mention some cmake "support gaps"
- imap: Simplified command response test in imap_endofresp()
+Nick Zitzmann (28 Aug 2016)
+- darwinssl: add documentation stating that the --cainfo option is intended for backward compatibility only
+
+ In other news, I changed one other reference to "Mac OS X" in the documentation (that I previously wrote) to say "macOS" instead.
-- [Jiri Hruska brought this change]
+Daniel Stenberg (28 Aug 2016)
+- http2: return CURLE_HTTP2_STREAM for unexpected stream close
+
+ Follow-up to c3e906e9cd0f, seems like a more appropriate error code
+
+ Suggested-by: Jay Satiro
- imap: Corrected comment in imap_endofresp()
+- [Tatsuhiro Tsujikawa brought this change]
-- DOCS: Corrected layout of POP3 and IMAP URL examples
+ http2: handle closed streams when uploading
- Corrected layout issues with the POP3 and IMAP URL examples introduced
- in commit cb3ae6894fb2.
+ Fixes #986
-- DOCS: Updated CURLOPT_URL section following recent POP3 and IMAP changes
+- http2: make sure stream errors don't needlessly close the connection
- Updated the POP3 sub-section to refer to message ID rather than mailbox.
+ With HTTP/2 each transfer is made in an indivial logical stream over the
+ connection, making most previous errors that caused the connection to get
+ forced-closed now instead just kill the stream and not the connection.
- Added an IMAP sub-section with example URLs depicting the specification
- of mailbox, uid and section.
+ Fixes #941
-- pop3: Refactored the mailbox variable as it didn't reflect it's purpose
+- Curl_verify_windows_version: minor edit to avoid compiler warnings
- Updated the mailbox variable to correctly reflect it's purpose. The
- name mailbox was a leftover from when IMAP and POP3 support was
- initially added to curl.
+ ... instead of if() before the switch(), add a default to the switch so
+ that the compilers don't warn on "warning: enumeration value
+ 'PLATFORM_DONT_CARE' not handled in switch" anymore.
-- FEATURES: Updated following recent IMAP changes
+Steve Holme (27 Aug 2016)
+- RELEASE-NOTES: Added missing fix from commit 15592143f
-- [Jiri Hruska brought this change]
-
- imap: Added the ability to FETCH a specific UID and SECTION
+Jay Satiro (26 Aug 2016)
+- schannel: Disable ALPN for Wine since it is causing problems
+
+ - Disable ALPN on Wine.
+
+ - Don't pass input secbuffer when ALPN is disabled.
- Updated the FETCH command to send the UID and SECTION parsed from the
- URL. By default the BODY specifier doesn't include a section, BODY[] is
- now sent whereas BODY[TEXT] was previously sent. In my opinion
- retrieving just the message text is rarely useful when dealing with
- emails, as the headers are required for example, so that functionality
- is not retained. In can however be simulated by adding SECTION=TEXT to
- the URL.
+ When ALPN support was added a change was made to pass an input secbuffer
+ to initialize the context. When ALPN is enabled the buffer contains the
+ ALPN information, and when it's disabled the buffer is empty. In either
+ case this input buffer caused problems with Wine and connections would
+ not complete.
- Also updated test801 and test1321 due to the BODY change.
+ Bug: https://github.com/curl/curl/issues/983
+ Reported-by: Christian Fillion
-- email: Additional tidy up of comments following recent changes
+Kamil Dudka (26 Aug 2016)
+- [Peter Wang brought this change]
-- smtp: Removed some FTP heritage leftovers
+ nss: work around race condition in PK11_FindSlotByName()
- Removed user and passwd from the SMTP struct as these cannot be set on
- a per-request basis and are leftover from legacy FTP code.
+ Serialise the call to PK11_FindSlotByName() to avoid spurious errors in
+ a multi-threaded environment. The underlying cause is a race condition
+ in nssSlot_IsTokenPresent().
- Changed some comments still using FTP terminology.
-
-- smtp: Moved the per-request variables to the per-request data structure
+ Bug: https://bugzilla.mozilla.org/1297397
- Moved the rcpt variable from the per-connection struct smtp_conn to the
- new per-request struct and fixed references accordingly.
+ Closes #985
-- pop3: Introduced a custom SMTP structure for per-request data
+- nss: refuse previously loaded certificate from file
- Created a new SMTP structure and changed the type of the smtp proto
- variable in connectdata from FTP* to SMTP*.
+ ... when we are not asked to use a certificate from file
-unknown (23 Feb 2013)
-- [Steve Holme brought this change]
+Daniel Stenberg (26 Aug 2016)
+- ftp_done: remove dead code
- imap: Minor correction of comments for max line length
+- TLS: random file/egd doesn't have to match for conn reuse
-Daniel Stenberg (23 Feb 2013)
-- strcasestr: remove check for this unused function
+- test161: add comment for the exit code
-- pop3: fix compiler warning
-
- error: declaration of 'pop3' shadows a previous local
+Dan Fandrich (26 Aug 2016)
+- test219: Add http as a required feature
-Steve Holme (23 Feb 2013)
-- [Jiri Hruska brought this change]
+Daniel Stenberg (25 Aug 2016)
+- [Michael Kaufmann brought this change]
- imap: Added URL parsing of new variables
+ HTTP: stop parsing headers when switching to unknown protocols
- Updated the imap_parse_url_path() function to parse uidvalidity, uid and
- section parameters based on RFC-5092.
-
-- [Jiri Hruska brought this change]
-
- imap: Introduced imap_is_bchar() function
+ - unknown protocols probably won't send more headers (e.g. WebSocket)
+ - improved comments and moved them to the correct case statements
- Added imap_is_bchar() for testing if a given character is a valid bchar
- or not.
-
-- [Jiri Hruska brought this change]
+ Closes #899
- imap: Introduced new per-request veriables
+- openssl: make build with 1.1.0 again
- Added uidvalidity, uid and section variables to the per-request IMAP
- structure in preparation for upcoming URL parsing.
+ synced with OpenSSL git master commit cc06906707
-- pingpong: Renamed curl_ftptransfer to curl_pp_transfer
+- INTERNALS: fix title
-- pop3: Removed some FTP heritage leftovers
+- configure: detect zlib with our pkg-config macros
- Removed user and passwd from the POP3 struct as these cannot be set on
- a per-request basis and are leftover from legacy FTP code.
+ ... instead of relying on the pkg-config autoconf macros to be present.
- Changed some comments still using FTP terminology.
+ Fixes #972 (again...)
-- pop3: Moved the per-request variables to the per-request data structure
+Jay Satiro (25 Aug 2016)
+- http2: Remove incorrect comments
- Moved the mailbox and custom request variables from the per-connection
- struct pop3_conn to the new per-request struct and fixed references
- accordingly.
+ .. also remove same from scp
+
+Daniel Stenberg (23 Aug 2016)
+- [Ales Novak brought this change]
-- pop3: Introduced a custom POP3 structure for per-request data
+ ftp: fix wrong poll on the secondary socket
- Created a new POP3 structure and changed the type of the pop3 proto
- variable in connectdata from FTP* to POP*.
+ When we're uploading using FTP and the server issues a tiny pause
+ between opening the connection to the client's secondary socket, the
+ client's initial poll() times out, which leads to second poll() which
+ does not wait for POLLIN on the secondary socket. So that poll() also
+ has to time out, creating a long (200ms) pause.
+
+ This patch adds the correct flag to the secondary socket, making the
+ second poll() correctly wait for the connection there too.
+
+ Signed-off-by: Ales Novak <alnovak@suse.cz>
+
+ Closes #978
-- [Jiri Hruska brought this change]
+- RELEASE-NOTES: synced with 95ded2c56
- imap: Fixed escaping of mailbox names
+- configure: make it work without PKG_CHECK_MODULES
- Used imap_atom() to escape mailbox names in imap_select().
-
-- pingpong: Moved curl_ftptransfer definition to pingpong.h
+ With commit c2f9b78 we added a new dependency on pkg-config for
+ developers which may be unwanted. This change make the configure script
+ still work as before if pkg-config isn't installed, it'll just use the
+ old zlib detection logic without pkg-config.
- Moved the ftp transfer structure into pingpong.h so other protocols that
- require it don't have to include ftp.h.
-
-- urldata.h: Fixed comment for opt_no_body variable
+ Reported-by: Marc Hörsken
- Corrected comment for opt_no_body variable to CURLOPT_NOBODY.
+ Fixes #972
-- email: Minor tidy up following IMAP changes
+Marc Hoersken (21 Aug 2016)
+- Revert "KNOWN_BUGS: SOCKS proxy not working via IPv6"
+
+ This reverts commit 9cb1059f92286a6eb5d28c477fdd3f26aed1d554.
+
+ As discussed in #835 SOCKS5 supports IPv6 proxies and destinations.
-- [Jiri Hruska brought this change]
+Daniel Stenberg (21 Aug 2016)
+- [Marco Deckel brought this change]
- imap: Removed more FTP leftovers
+ win: Basic support for Universal Windows Platform apps
- Changed some variables and comments still using FTP terminology.
+ Closes #820
-- [Jiri Hruska brought this change]
+Steve Holme (21 Aug 2016)
+- sasl: Don't use GSSAPI authentication when domain name not specified
+
+ Only choose the GSSAPI authentication mechanism when the user name
+ contains a Windows domain name or the user is a valid UPN.
+
+ Fixes #718
- imap: Removed some FTP heritage leftovers
+- vauth: Added check for supported SSPI based authentication mechanisms
- Removed user and passwd from the IMAP struct as these cannot be set on
- a per-request basis and are leftover from legacy FTP code.
+ Completing commit 00417fd66c and 2708d4259b.
-- [Jiri Hruska brought this change]
+- http.c: Remove duplicate (authp->avail & CURLAUTH_DIGEST) check
+
+ From commit 2708d4259b.
- imap: Introduced a custom IMAP structure for per-request data
+Marc Hoersken (20 Aug 2016)
+- socks.c: display the hostname returned by the SOCKS5 proxy server
- Created a new IMAP structure and changed the type of the imap proto
- variable in connectdata from FTP* to the new IMAP*.
+ Instead of displaying the requested hostname the one returned
+ by the SOCKS5 proxy server is used in case of connection error.
+ The requested hostname is displayed earlier in the connection sequence.
- Moved the mailbox variable from the per-connection struct imap_conn to
- the new per-request struct and fixed references accordingly.
+ The upper-value of the port is moved to a temporary variable and
+ replaced with a 0-byte to make sure the hostname is 0-terminated.
-- pop3: Updated do phrase clean-up comment
+Steve Holme (20 Aug 2016)
+- urldata.h: Corrected comment for httpcode which is also populated by SMTP
- Following commit 65644b833532 for the IMAP module updated the clean-up
- comment in POP3.
+ As of 7.25.0 and commit 5430007222.
-- imap: Fixed memory leak when performing multiple selects
+Marc Hoersken (20 Aug 2016)
+- socks.c: use Curl_printable_address in SOCKS5 connection sequence
- Moved the clean-up of the mailbox variable from imap_disconnect() to
- imap_done() as this variable is allocated in the do phase, yet would
- have only been freed only once if multiple selects where preformed
- on a single connection.
-
-Daniel Stenberg (22 Feb 2013)
-- [Alexander Klauer brought this change]
+ Replace custom string formatting with Curl_printable_address.
+ Add additional debug and error output in case of failures.
- Documentation: Typo in docs/CONTRIBUTE
+- socks.c: align SOCKS4 connection sequence with SOCKS5
- Fixes a typo get → git in docs/CONTRIBUTE.
+ Calling sscanf is not required since the raw IPv4 address is
+ available and the protocol can be detected using ai_family.
-- [Alexander Klauer brought this change]
+Steve Holme (20 Aug 2016)
+- http.c: Corrected indentation change from commit 2708d4259b
+
+ Made by Visual Studio's auto-correct feature and missed by me in my own
+ code reviews!
- repository: ignore patch files generated by git
+- http: Added calls to Curl_auth_is_<mechansism>_supported()
+
+ Hooked up the HTTP authentication layer to query the new 'is mechanism
+ supported' functions when deciding what mechanism to use.
- Ignores the patch files generated by the 'git format-patch' command.
+ As per commit 00417fd66c existing functionality is maintained for now.
+
+Marc Hoersken (20 Aug 2016)
+- socks.c: improve verbose output of SOCKS5 connection sequence
-- [Alexander Klauer brought this change]
+- configure.ac: add missing quotes to PKG_CHECK_MODULES
- libcurl documentation: clarifications and typos
+Steve Holme (20 Aug 2016)
+- sasl: Added calls to Curl_auth_is_<mechansism>_supported()
- * Elaborates on default values of some curl_easy_setopt() options.
- * Reminds the user to cast variadic arguments to curl_easy_setopt() to
- 'void *' where curl internally interprets them as such.
- * Clarifies the working of the CURLOPT_SEEKFUNCTION option for
- curl_easy_setopt().
- * Fixes typo 'forth' → 'fourth'.
- * Elaborates on CURL_SOCKET_TIMEOUT.
- * Adds some missing periods.
- * Notes that the return value of curl_version() must not be passed to
- free().
+ Hooked up the SASL authentication layer to query the new 'is mechanism
+ supported' functions when deciding what mechanism to use.
+
+ For now existing functionality is maintained.
-- [Alexander Klauer brought this change]
+Daniel Stenberg (19 Aug 2016)
+- [Miroslav Franc brought this change]
- lib/url.c: Generic read/write data pointers
-
- Always interprets the pointer passed with the CURLOPT_WRITEDATA or
- CURLOPT_READDATA options of curl_easy_setopt() as a void pointer in
- order to avoid problems in environments where FILE and void pointers
- have non-trivial conversion.
+ spnego_sspi: fix memory leak in case *outlen is zero (#970)
-- [Alexander Klauer brought this change]
+- CURLMOPT_MAX_TOTAL_CONNECTIONS.3: mention it can also multiplex
- libcurl documentation: updates HTML index
+Steve Holme (18 Aug 2016)
+- vauth: Introduced Curl_auth_is_<mechansism>_supported() functions
- * Adds several links to documentation of library functions which were
- missing.
- * Marks documentation of deprecated library functions "(deprecated)".
- * Removes spurious .html suffixes.
-
-- ossl_seed: avoid recursive seeding!
+ As Windows SSPI authentication calls fail when a particular mechanism
+ isn't available, introduced these functions for DIGEST, NTLM, Kerberos 5
+ and Negotiate to allow both HTTP and SASL authentication the opportunity
+ to query support for a supported mechanism before selecting it.
+
+ For now each function returns TRUE to maintain compatability with the
+ existing code when called.
-Steve Holme (22 Feb 2013)
-- [Jiri Hruska brought this change]
+Daniel Stenberg (18 Aug 2016)
+- test1144: verify HEAD with body-only response
- Fixed checking the socket if there is data waiting in the cache
+Steve Holme (17 Aug 2016)
+- RELEASE-PROCEDURE: Added some more future release dates
- Use Curl_pp_moredata() in Curl_pp_multi_statemach() to check if there is
- more data to be received, rather than the socket state, as a task could
- hang waiting for more data from the socket itself.
+ ...and removed some old ones
-- imap.c: Fixed an incorrect variable reference
+Daniel Stenberg (17 Aug 2016)
+- [David Woodhouse brought this change]
+
+ curl: allow "pkcs11:" prefix for client certificates
+
+ RFC7512 provides a standard method to reference certificates in PKCS#11
+ tokens, by means of a URI starting 'pkcs11:'.
+
+ We're working on fixing various applications so that whenever they would
+ have been able to use certificates from a file, users can simply insert
+ a PKCS#11 URI instead and expect it to work. This expectation is now a
+ part of the Fedora packaging guidelines, for example.
+
+ This doesn't work with cURL because of the way that the colon is used
+ to separate the certificate argument from the passphrase. So instead of
+
+ curl -E 'pkcs11:manufacturer=piv_II;id=%01' …
+
+ I instead need to invoke cURL with the colon escaped, like this:
+
+ curl -E 'pkcs11\:manufacturer=piv_II;id=%01' …
+
+ This is suboptimal because we want *consistency* — the URI should be
+ usable in place of a filename anywhere, without having strange
+ differences for different applications.
+
+ This patch therefore disables the processing in parse_cert_parameter()
+ when the string starts with 'pkcs11:'. It means you can't pass a
+ passphrase with an unescaped PKCS#11 URI, but there's no need to do so
+ because RFC7512 allows a PIN to be given as a 'pin-value' attribute in
+ the URI itself.
+
+ Also, if users are already using RFC7512 URIs with the colon escaped as
+ in the above example — even providing a passphrase for cURL to handling
+ instead of using a pin-value attribute, that will continue to work
+ because their string will start 'pkcs11\:' and won't match the check.
- Fixed an incorrect variable reference which was introduced in commit
- a1701eea289f as a result of a copy and paste from SMTP/POP3.
+ What *does* break with this patch is the extremely unlikely case that a
+ user has a file which is in the local directory and literally named
+ just "pkcs11", and they have a passphrase on it. If that ever happened,
+ the user would need to refer to it as './pkcs11:<passphrase>' instead.
-- [Jiri Hruska brought this change]
+- nss: make the global variables static
- pingpong: Introduce Curl_pp_moredata()
+- openssl: use regular malloc instead of OPENSSL_malloc
- A simple function to test whether the PP is not sending and there are
- still more data in its receiver cache. This will be later utilized to:
+ This allows for better memmory debugging and torture tests.
+
+- proxy: fix tests as follow-up to 93b0d907d5
+
+ This fixes tests that were added after 113f04e664b as the tests would
+ fail otherwise.
- 1) Change Curl_pp_multi_statemach() and Curl_pp_easy_statemach() to
- not test socket state and just call user's statemach_act() function
- when there are more data to process, because otherwise the task would
- just hang, waiting for more data from the socket.
+ We bring back "Proxy-Connection: Keep-Alive" now unconditionally to fix
+ regressions with old and stupid proxies, but we could possibly switch to
+ using it only for CONNECT or only for NTLM in a future if we want to
+ gradually reduce it.
- 2) Allow PP users to read multiple responses by looping as long as there
- are more data available and current phase is not finished.
- (Currently needed for correct processing of IMAP SELECT responses.)
+ Fixes #954
+
+ Reported-by: János Fekete
-Nick Zitzmann (19 Feb 2013)
-- FEATURES: why yes, we do support metalink
+- Revert "Proxy-Connection: stop sending this header by default"
- I just noticed Metalink support wasn't listed as a feature of the tool.
+ This reverts commit 113f04e664b16b944e64498a73a4dab990fe9a68.
-- metalink: fix improbable crash parsing metalink filename
+- CURLOPT_PROXY.3: unsupported schemes cause errors now
- The this_url pointer wasn't being initialized, so if strdup() would return
- null when copying the filename in a metalink file, then hilarity would
- ensue during the cleanup phase. This change was brought to you by clang,
- which noticed this and raised a warning.
+ Follow-up to a96319ebb9 (document the new behavior)
-Yang Tse (19 Feb 2013)
-- smtp.c: fix enumerated type mixed with another type
+- tests/README: mention nghttpx for HTTP/2 tests
-- polarssl threadlock cleanup
+- README.md: add our CII Best Practices badge
-Nick Zitzmann (18 Feb 2013)
-- docs: schannel and darwinssl documentation improvements
+- proxy: polished the error message for unsupported schemes
- Schannel and darwinssl use the certificates built into the
- OS to do vert verification instead of bundles. darwinssl
- is thread-safe. Corrected typos in the NSS docs.
+ Follow up to a96319ebb93
-Daniel Stenberg (18 Feb 2013)
-- resolver_error: remove wrong error message output
-
- The attempt to use gai_strerror() or alternative function didn't work as
- the 'sock_error' field didn't contain the proper error code. But since
- this hasn't been reported and thus isn't really a big deal I decided to
- just scrap the whole attempt to output the detailed resolver error and
- instead remain with just stating that the resolving of the name failed.
+- test219: verify unsupported scheme for proxies get rejected
-- [Kim Vandry brought this change]
+- proxy: reject attempts to use unsupported proxy schemes
+
+ I discovered some people have been using "https://example.com" style
+ strings as proxy and it "works" (curl doesn't complain) because curl
+ ignores unknown schemes and then assumes plain HTTP instead.
+
+ I think this misleads users into believing curl uses HTTPS to proxies
+ when it doesn't. Now curl rejects proxy strings using unsupported
+ schemes instead of just ignoring and defaulting to HTTP.
- Curl_resolver_is_resolved: show proper host name on failed resolve
+- RELEASE-NOTES: synced with b7ee5316c2fd5b
-- Curl_resolver_is_resolved: fix compiler warning
+Marc Hoersken (14 Aug 2016)
+- socks.c: Correctly calculate position of port in response packet
- conversion to 'int' from 'long int' may alter its value
-
-- compiler warning fix
+ Third commit to fix issue #944 regarding SOCKS5 error handling.
- follow-up to commit ed7174c6f66, rename 'wait' to 'block'
+ Reported-by: David Kalnischkies
-- compiler warning fix: declaration of 'wait' shadows a global declaration
+- socks.c: Do not modify and invalidate calculated response length
- It seems older gcc installations (at least) will cause warnings if we
- name a variable 'wait'. Now changed to 'block' instead.
+ Second commit to fix issue #944 regarding SOCKS5 error handling.
- Reported by: Jiří Hruška
- Bug: http://curl.haxx.se/mail/lib-2013-02/0247.html
+ Reported-by: David Kalnischkies
-Nick Zitzmann (17 Feb 2013)
-- MacOSX-Framework: Make script work in Xcode 4.0 and later
+- socks.c: Move error output after reading the whole response packet
- Apple made a number of changes to Xcode 4. The SDKs were moved, the entire
- Developer folder was moved, and PowerPC support was removed. The script
- will now adapt to those changes and should be future-proofed against
- additional changes in case Apple moves the Developer folder ever again.
- Also, the minimum OS X version compiler option was removed, so that the
- framework can be built against the latest SDK but still run in older cats.
+ First commit to fix issue #944 regarding SOCKS5 error handling.
+
+ Reported-by: David Kalnischkies
-Daniel Stenberg (17 Feb 2013)
-- docs: refer to CURLOPT_ACCEPT_ENCODING instead of the old name
+Daniel Stenberg (13 Aug 2016)
+- [Ronnie Mose brought this change]
-Steve Holme (16 Feb 2013)
-- email: Tidied up result code variables
+ MANUAL: Remove invalid link to LDAP documentation (#962)
- Tidied up result variables to be consistent in name, declaration order
- and default values.
+ The server developer.netscape.com does not resolve into any
+ ip address and can be removed.
-Nick Zitzmann (16 Feb 2013)
-- ntlm_core: fix compiler warning when building with clang
+Jay Satiro (13 Aug 2016)
+- openssl: accept subjectAltName iPAddress if no dNSName match
+
+ Undo change introduced in d4643d6 which caused iPAddress match to be
+ ignored if dNSName was present but did not match.
- Fixed a 64-to-32 compiler warning raised when building with
- clang and the --with-darwinssl option.
+ Also, if iPAddress is present but does not match, and dNSName is not
+ present, fail as no-match. Prior to this change in such a case the CN
+ would be checked for a match.
+
+ Bug: https://github.com/curl/curl/issues/959
+ Reported-by: wmsch@users.noreply.github.com
-Daniel Stenberg (16 Feb 2013)
-- Guile-curl: a new libcurl binding
+Daniel Stenberg (12 Aug 2016)
+- [Dambaev Alexander brought this change]
-- polarsslthreadlock: #include the proper memory and debug includes
+ configure.ac: add zlib search with pkg-config
- Pointed out by Steve Holme
+ Closes #956
-Steve Holme (16 Feb 2013)
-- email: Removed unnecessary forward declaration
+- rtsp: ignore whitespace in session id
+
+ Follow-up to e577c43bb to fix test case 569 brekage: stop the parser at
+ whitespace as well.
- Due to the reordering of functions in commit 586f5d361474 the forward
- declaration to state_upgrade_tls() are no longer required.
+ Help-by: Erik Janssen
-- pop3.c: Added reference to RFC-5034
+- HTTP: retry failed HEAD requests too
+
+ Mark's new document about HTTP Retries
+ (https://mnot.github.io/I-D/httpbis-retry/) made me check our code and I
+ spotted that we don't retry failed HEAD requests which seems totally
+ inconsistent and I can't see any reason for that separate treatment.
+
+ So, no separate treatment for HEAD starting now. A HTTP request sent
+ over a reused connection that gets cut off before a single byte is
+ received will be retried on a fresh connection.
+
+ Made-aware-by: Mark Nottingham
-Daniel Stenberg (15 Feb 2013)
-- [Willem Sparreboom brought this change]
+- mk-ca-bundle.1: document -m, added in 1.26
- PolarSSL: Change to cURL coding style
-
- Repaired all curl/lib/checksrc.pl warnings in the previous four patches
+- RELEASE-NOTES: synced with e577c43bb5
-- [Willem Sparreboom brought this change]
+- [Erik Janssen brought this change]
- PolarSSL: WIN32 threading support for entropy
+ rtsp: accept any RTSP session id
- Added WIN32 threading support for PolarSSL entropy if
- --enable-threaded-resolver config flag is set and process.h can be found.
-
-- [Willem Sparreboom brought this change]
+ Makes libcurl work in communication with gstreamer-based RTSP
+ servers. The original code validates the session id to be in accordance
+ with the RFC. I think it is better not to do that:
+
+ - For curl the actual content is a don't care.
+
+ - The clarity of the RFC is debatable, is $ allowed or only as \$, that
+ is imho not clear
+
+ - Gstreamer seems to url-encode the session id but % is not allowed by
+ the RFC
+
+ - less code
+
+ With this patch curl will correctly handle real-life lines like:
+ Session: biTN4Kc.8%2B1w-AF.; timeout=60
+
+ Bug: https://curl.haxx.se/mail/lib-2016-08/0076.html
- PolarSSL: pthread support for entropy
+- symbols-in-versions: add CURL_STRICTER
- Added pthread support for polarssl entropy if --enable-threaded-resolver
- config flag is set and pthread.h can be found.
+ Added in 5fce88aa8c12564
-- [Willem Sparreboom brought this change]
+- [Simon Warta brought this change]
- PolarSSL: changes to entropy/ctr_drbg/HAVEGE_RANDOM
+ winbuild: Allow changing C compiler via environment variable CC (#952)
+
+ This makes it possible to use specific compilers or a cache.
- Add non-threaded entropy and ctr_drbg and removed HAVEGE_RANDOM define
+ Sample use for clcache:
+ set CC=clcache.bat
+ nmake /f Makefile.vc DEBUG=no MODE=static VC=14 GEN_PDB=no
-- [Willem Sparreboom brought this change]
+- LICENSE-MIXING.md: switched to markdown
- PolarSSL: added human readable error strings
-
- Print out human readable error strings for PolarSSL related errors
+- docs-make: have markdown files use .md
-Steve Holme (15 Feb 2013)
-- pop3: Removed unnecessary state changes on failure
+- curl.h: make CURL_NO_OLDIES define CURL_STRICTER
-- imap: Removed unnecessary state change on failure
+- HISTORY.md: use markdown extension
-Daniel Stenberg (15 Feb 2013)
-- metalink_cleanup: yet another follow-up fix
+- SSLCERTS.md: renamed to markdown extension
-- metalink_cleanup: define it without argument
-
- Since the function takes no argument, the macro shouldn't take one as
- some compilers will error out on that.
+- INTERNALS.md: use markdown extension for markdown content
-- rename "easy" statemachines: call them block instead
-
- ... since they're not used by the easy interface really, I wanted to
- remove the association. Also, I unified the pingpong statemachine driver
- into a single function with a 'wait' argument: Curl_pp_statemach.
+- CONTRIBUTE.md: markdown extension
-Yang Tse (15 Feb 2013)
-- [Gisle Vanem brought this change]
+- CONTRIBUTE: changed to markdown
- curl_setup_once.h: definition of HAVE_CLOSE_S defines sclose() to close_s()
+- CONTRIBUTE: refreshed
-- [Gisle Vanem brought this change]
+- TODO: added an SSH section and two SFTP things to do
- config-dos.h: define HAVE_CLOSE_S for MSDOS/Watt-32
+- TODO: remove the 1.22 duplicated item
-- [Gisle Vanem brought this change]
+- TODO: move "CURLOPT_MAIL_CLIENT" to SMTP section
- config-dos.h: define strerror() to strerror_s_() for High-C
+- TODO: API for URL parsing/splitting
-- [Gisle Vanem brought this change]
+- TODO: move QUIC to the HTTP section
- config-dos.h: define HAVE_TERMIOS_H only for djgpp
+- [Simon Warta brought this change]
-Steve Holme (14 Feb 2013)
-- smtp.c: Fixed a trailing whitespace
+ winbuild: Free name $(CC) in Makefile (#950)
- Remove tailing whitespace introduced in commit 7ed689d24a4e.
+ In the old line number 290, CC and CURL_CC had the same value. After
+ that, /DCURL_STATICLIB was added to CC but not CURL_CC (intended?).
+
+ This gets rid of the CC variable entirely. It is a first step to make it
+ possible to manualyl set a CC variable in order to be able to change the
+ compiler.
+
+- TODO: Use huge HTTP/2 windows
-- pop3: Fixed blocking SSL connect when connecting via POP3S
+- [Simon Warta brought this change]
+
+ winbuild: Avoid setting redundant CFLAGS to compile commands (#949)
- A call to Curl_ssl_connect() was accidentally left in when the SSL/TLS
- connection layer was reworked in 7.29. Not only would this cause the
- connection to block but had the additional overhead of calling the
- non-blocking connect a little bit later.
+ $(CURL_CC) is always used with $(CURL_CFLAGS) appended, so before this,
+ all arguments in CURL_CFLAGS have been added twice.
-- smtp: Refactored the smtp_state_auth_resp() function
+Jay Satiro (8 Aug 2016)
+- cmake: Enable win32 threaded resolver by default
+
+ - Turn on USE_THREADS_WIN32 in Windows if ares isn't on
- Renamed smtp_state_auth_resp() function to match the implementations in
- IMAP and POP3.
+ This change is similar to what we already do in the autotools build.
-Daniel Stenberg (14 Feb 2013)
-- remove ifdefs
+- cmake: Enable win32 large file support by default
+
+ All compilers used by cmake in Windows should support large files.
- Clarify the code by reducing ifdefs
+ - Add test SIZEOF_OFF_T
+ - Remove outdated test SIZEOF_CURL_OFF_T
+ - Turn on USE_WIN32_LARGE_FILES in Windows
+ - Check for 'Largefile' during the features output
-- strlcat: remove function
+Daniel Stenberg (7 Aug 2016)
+- TODO: added several ideas, removed SPDY
+
+- http2: always wait for readable socket
- This function was only used twice, both in places where performance
- isn't crucial (socks + if2ip). Removing the use of this function removes
- the need to have our private version for systems without it == reduced
- amount of code.
+ Since the server can at any time send a HTTP/2 frame to us, we need to
+ wait for the socket to be readable during all transfers so that we can
+ act on incoming frames even when uploading etc.
- Also, in the SOCKS case it is clearly better to fail gracefully rather
- than to truncate the results.
+ Reminded-by: Tatsuhiro Tsujikawa
+
+- RELEASE-NOTES: synced with 7b4bf37a44791
+
+- [Thomas Glanzmann brought this change]
+
+ mbedtls: set debug threshold to 4 (verbose) when MBEDTLS_DEBUG is defined
- This work was triggered by a bug report on the strcal prototype in
- strequal.h.
+ In order to make MBEDTLS_DEBUG work, the debug threshold must be unequal
+ to 0. This patch also adds a comment how mbedtls must be compiled in
+ order to make debugging work, and explains the possible debug levels.
+
+- CURLOPT_TCP_NODELAY: now enabled by default
+
+ After a few wasted hours hunting down the reason for slowness during a
+ TLS handshake that turned out to be because of TCP_NODELAY not being
+ set, I think we have enough motivation to toggle the default for this
+ option. We now enable TCP_NODELAY by default and allow applications to
+ switch it off.
- strlcat was added in commit db70cd28 in February 2001!
+ This also makes --tcp-nodelay unnecessary, but --no-tcp-nodelay can be
+ used to disable it.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1192
- Reported by: Jeremy Huddleston
+ Thanks-to: Tim Rühsen
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0143.html
+
+- [Serj Kalichev brought this change]
-- Curl_FormBoundary: made static
+ TFTP: Fix upload problem with piped input
- As Curl_FormBoundary() is no longer used outside of this file (since
- commit ad7291c1a9d), it is now renamed to formboundary() and is made
- static.
+ When input stream for curl is stdin and input stream is not a file but
+ generated by a script then curl can truncate data transfer to arbitrary
+ size since a partial packet is treated as end of transfer by TFTP.
+
+ Fixes #857
-- ossl_seed: fix the last resort PRNG seeding
+- mk-ca-bundle.pl: -m keeps ca cert meta data in output
+
+ Makes the script pass on comments holding meta data to the output
+ file. Like fingerprinters, issuer, date ranges etc.
- Instead of just abusing the pseudo-randomizer from Curl_FormBoundary(),
- this now uses Curl_ossl_random() to get entropy.
+ Closes #937
-Steve Holme (13 Feb 2013)
-- email: Tidy up before additional IMAP work
+- multi: make Curl_expire() work with 0 ms timeouts
- Replaced two explicit comparisons of CURLE_OK with boolean alternatives.
+ Previously, passing a timeout of zero to Curl_expire() was a magic code
+ for clearing all timeouts for the handle. That is now instead made with
+ the new Curl_expire_clear() function and thus a 0 timeout is fine to set
+ and will trigger a timeout ASAP.
+
+ This will help removing short delays, in particular notable when doing
+ HTTP/2.
+
+- transfer: return without select when the read loop reached maxcount
+
+ Regression added in 790d6de48515. The was then added to avoid one
+ particular transfer to starve out others. But when aborting due to
+ reading the maxcount, the connection must be marked to be read from
+ again without first doing a select as for some protocols (like SFTP/SCP)
+ the data may already have been read off the socket.
+
+ Reported-by: Dan Donahue
+ Bug: https://curl.haxx.se/mail/lib-2016-07/0057.html
+
+Steve Holme (3 Aug 2016)
+- [Bill Nagel brought this change]
+
+ mbedtls: Added support for NTLM
+
+Daniel Stenberg (3 Aug 2016)
+- [Sergei Nikulov brought this change]
+
+ travis: removed option to rebuild autotool from source
+
+ Fixes #943
+
+- bump: start working toward 7.50.2
+
+Version 7.50.1 (3 Aug 2016)
+
+Daniel Stenberg (3 Aug 2016)
+- THANKS: 7 new contributors from the 7.50.1 release
+
+- RELEASE-NOTES: 7.50.1
+
+- TLS: only reuse connections with the same client cert
- General tidy up of comments.
+ CVE-2016-5420
+ Bug: https://curl.haxx.se/docs/adv_20160803B.html
-- smtp: Removed duplicate pingpong structure initialisation
+- TLS: switch off SSL session id when client cert is used
- The smtp_connect() function was setting the member variables of the
- pingpong structure twice, once before calling Curl_pp_init() and once
- after!
+ CVE-2016-5419
+ Bug: https://curl.haxx.se/docs/adv_20160803A.html
+ Reported-by: Bru Rom
+ Contributions-by: Eric Rescorla and Ray Satiro
-Yang Tse (13 Feb 2013)
-- move msvc IDE related files to 'vs' directory tree
+- curl_multi_cleanup: clear connection pointer for easy handles
- Use 'vs' directory tree given that 'vc' intended one clashes
- with an already existing build target in file Makefile.dist.
+ CVE-2016-5421
+ Bug: https://curl.haxx.se/docs/adv_20160803C.html
+ Reported-by: Marcelo Echeverria and Fernando Muñoz
-Daniel Stenberg (13 Feb 2013)
-- install-sh: updated to support multiple source files as arguments
+- KNOWN_BUGS: SOCKS proxy not working via IPv6
- Version 7.29.0 uses Makefiles generated with a newer version of the
- autotools than the previous 7.28.1. These Makefiles try to install
- e.g. header files by calling install-sh with multiple source files as
- arguments. The bundled install-sh is to old and does not support this.
+ Closes #835
+
+- KNOWN_BUGS: CURLOPT_SEEKFUNCTION not called with CURLFORM_STREAM
- The problem only occurs, if install-sh is actually being used, ie. the
- platform install executable is to old or not usable. Example: Solaris
- 10.
+ Closes #768
+
+- KNOWN_BUGS: transfer-encoding: chunked in HTTP/2
- The files install-sh and mkinstalldirs are now updated with the automake
- 1.11.3 versions. A better fix might be to completely remove them from
- git and force the files to be added/created during buildconf.
+ Closes #662
+
+- TODO: Provide cmake config-file
- Bug: http://curl.haxx.se/bug/view.cgi?id=1195
- Reported by: Rainer Jung
+ Closes #885
-Yang Tse (13 Feb 2013)
-- move msvc IDE related files to 'vc' directory tree
+Patrick Monnerat (2 Aug 2016)
+- os400: define BUILDING_LIBCURL in make script.
-- msvc IDE 'vc' directory tree preparation
+Daniel Stenberg (1 Aug 2016)
+- RELEASE-NOTES: synced with aa9f536a18b
-Steve Holme (12 Feb 2013)
-- imap: Corrected a whitespace issue from previous commit
+Jay Satiro (1 Aug 2016)
+- [Thomas Glanzmann brought this change]
+
+ mbedtls: Fix debug function name
+
+ This patch is necessary so that curl compiles if MBEDTLS_DEBUG is
+ defined.
- Fixed a small whitespace issue that crept in there in commit
- 508cdf4da4d7.
+ Bug: https://curl.haxx.se/mail/lib-2016-08/0001.html
-- email: Another post optimisation of endofresp() tidy up
+Daniel Stenberg (1 Aug 2016)
+- [Sergei Nikulov brought this change]
-- sasl: Fixed null pointer reference when decoding empty digest challenge
+ travis: fix OSX build by re-installing libtool
- Fixed a null pointer reference when an empty challenge is passed to the
- Curl_sasl_create_digest_md5_message() function.
+ Apparently due to a broken homebrew install
- Bug: http://sourceforge.net/p/curl/bugs/1193/
- Reported by: Saran Neti
+ fixes #934
+ Closes #939
-- email: Post optimisation of endofresp() tidy up
+- [Martin Vejnár brought this change]
+
+ win32: fix a potential memory leak in Curl_load_library
+
+ If a call to GetSystemDirectory fails, the `path` pointer that was
+ previously allocated would be leaked. This makes sure that `path` is
+ always freed.
- Removed unnecessary end of line check and return.
+ Closes #938
-Nick Zitzmann (12 Feb 2013)
-- darwinssl: Fix send glitchiness with data > 32 or so KB
+- include: revert 9adf3c4 and make public types void * again
+
+ Many applications assume the actual contents of the public types and use
+ that do for example forward declarations (saving them from including our
+ public header) which then breaks when we switch from void * to a struct
+ *.
- An ambiguity in the SSLWrite() documentation lead to a bad inference in the
- code where we assumed SSLWrite() returned the amount of bytes written to
- the socket, when that is not actually true; it returns the amount of data
- that is buffered for writing to the socket if it returns errSSLWouldBlock.
- Now darwinssl_send() returns CURLE_AGAIN if data is buffered but not written.
+ I'm not convinced we were wrong, but since this practise seems
+ widespread enough I'm willing to (partly) step down.
- Reference URL: http://curl.haxx.se/mail/lib-2013-02/0145.html
+ Now libcurl uses the struct itself when it is built and it allows
+ applications to use the struct type if CURL_STRICTER is defined at the
+ time of the #include.
+
+ Reported-by: Peter Frühberger
+ Fixes #926
-Steve Holme (12 Feb 2013)
-- pingpong.h: Fixed line length over 78 characters from b56c9eb48e3c
+Jay Satiro (28 Jul 2016)
+- [Yonggang Luo brought this change]
-- pingpong: Optimised the endofresp() function
+ cmake: Fix for schannel support
+
+ The check_library_exists_concat do not check crypt32 library properly.
+ So include it directly.
- Reworked the pp->endofresp() function so that the conndata, line and
- line length are passed down to it just as with Curl_client_write()
- rather than each implementation of the function having to query
- these values.
+ Bug: https://github.com/curl/curl/pull/917
+ Reported-by: Yonggang Luo
- Additionally changed the int return type to bool as this is more
- representative of the function's usage.
+ Bug: https://github.com/curl/curl/issues/935
+ Reported-by: Alain Danteny
-- email: Post STARTLS capability code tidy up (Part Three)
+- Revert "travis: Install libtool for OS X builds"
- Corrected the order of the upgrade_tls() functions and moved the handler
- upgrade and getsock() functions out from the middle of the state related
- functions.
+ Didn't work.
+
+ This reverts commit 50723585ed380744358de054e2a55dccee65dfd7.
-- email: Post STARTLS capability code tidy up (Part Two)
+- travis: Install libtool for OS X builds
- Corrected the order of the pop3_state_capa() / imap_state_capability()
- and the pop3_state_capa_resp() / imap_state_capability_resp() functions
- to match the execution order.
+ CI is failing due to missing libtoolize, so I'm trying this.
-Daniel Stenberg (11 Feb 2013)
-- [ulion brought this change]
+Daniel Stenberg (26 Jul 2016)
+- [Viktor Szakats brought this change]
- SOCKS: fix socks proxy when noproxy matched
-
- Test 1212 added to verify
+ TODO: minor typo in last commit
- Bug: http://curl.haxx.se/bug/view.cgi?id=1190
+ merged #931
-Steve Holme (11 Feb 2013)
-- ntlm: Updated comments for the addition of SASL support to IMAP in v7.29
+- TODO: Timeout idle connections from the pool
-- RELEASE-NOTES: Updated following the recent imap/pop3/smtp changes
+Patrick Monnerat (25 Jul 2016)
+- os400: minimum supported OS version: V6R1M0.
+ Do not log compilation informational messages.
-Linus Nielsen Feltzing (10 Feb 2013)
-- Fix NULL pointer reference when closing an unused multi handle.
-
-Steve Holme (10 Feb 2013)
-- email: Post STARTLS capability code tidy up (Part One)
+Jay Satiro (24 Jul 2016)
+- tests: Fix for http/2 feature
- Corrected the order of the CAPA / CAPABILITY state machine constants to
- match the execution order.
+ Bug: https://curl.haxx.se/mail/lib-2016-07/0070.html
+ Reported-by: Paul Howarth
-- imap: Fixed memory leak following commit f6010d9a0359
+Steve Holme (23 Jul 2016)
+- README: Mention wolfSSL in the 'Dependencies' section
-- smtp: Added support for the STARTTLS capability (Part Two)
+- vauth.h: No need to query HAVE_GSSAPI || USE_WINDOWS_SSPI for SPNEGO
- Added honoring of the tls_supported flag when starting a TLS upgrade
- rather than unconditionally attempting it. If the use_ssl flag is set
- to CURLUSESSL_TRY and the server doesn't support TLS upgrades then the
- connection will continue to authenticate. If this flag is set to
- CURLUSESSL_ALL then the connection will complete with a failure as it
- did previously.
+ As SPNEGO is only defined when these pre-processor variables are defined
+ there is no need to query them explicitly.
-- pop3: Added support for the STLS capability (Part Three)
+- spnego: Corrected miss-placed * in Curl_auth_spnego_cleanup() declaration
- Added honoring of the tls_supported flag when starting a TLS upgrade
- rather than unconditionally attempting it. If the use_ssl flag is set
- to CURLUSESSL_TRY and the server doesn't support TLS upgrades then the
- connection will continue to authenticate. If this flag is set to
- CURLUSESSL_ALL then the connection will complete with a failure as it
- did previously.
+ Typo introduced in commit ad5e9bfd5d.
-- imap: Added support for the STARTTLS capability (Part Three)
+Daniel Stenberg (22 Jul 2016)
+- SECURITY: mention how to get windows-specific CVEs
- Added honoring of the tls_supported flag when starting a TLS upgrade
- rather than unconditionally attempting it. If the use_ssl flag is set
- to CURLUSESSL_TRY and the server doesn't support TLS upgrades then the
- connection will continue to authenticate. If this flag is set to
- CURLUSESSL_ALL then the connection will complete with a failure as it
- did previously.
+ ... and make the distros link a proper link
-Daniel Stenberg (10 Feb 2013)
-- [Alessandro Ghedini brought this change]
+Dan Fandrich (21 Jul 2016)
+- test558: fix test by stripping file paths from FD lines
- htmltitle: fix suggested build command
+Kamil Dudka (21 Jul 2016)
+- tests: distribute the http2-server.pl script, too
-Steve Holme (10 Feb 2013)
-- pop3: Added support for the STLS capability (Part Two)
-
- Added sending of initial CAPA command before STLS is sent. This allows
- for the detection of the capability before trying to upgrade the
- connection.
+- docs: distribute the CURLINFO_HTTP_VERSION(3) man page, too
-- imap: Added support for the STARTTLS capability (Part Two)
-
- Added sending of initial CAPABILITY command before STARTTLS is sent.
- This allows for the detection of the capability before trying to
- upgrade the connection.
+Daniel Stenberg (21 Jul 2016)
+- bump: start working on 7.50.1
-- smtp: Added support for the STLS capability (Part One)
-
- Introduced detection of the STARTTLS capability, in order to add support
- for TLS upgrades without unconditionally sending the STARTTLS command.
+Version 7.50.0 (21 Jul 2016)
+
+Daniel Stenberg (21 Jul 2016)
+- RELEASE-NOTES: version 7.50.0 ready
+
+- THANKS: 13 new contributors from the 7.50.0 release
-- pop3: Added support for the STLS capability (Part One)
+Jay Satiro (21 Jul 2016)
+- winbuild: fix embedded manifest option
- Introduced detection of the STLS capability, in order to add support
- for TLS upgrades without unconditionally sending the STLS command.
+ Embedded manifest option didn't work due to typo.
+
+ Reported-by: Stefan Kanthak
-- imap: Added support for the STARTTLS capability (Part One)
+- vauth: Fix memleak by freeing credentials if out of memory
- Introduced detection of the STARTTLS capability, in order to add support
- for TLS upgrades without unconditionally sending the STARTTLS command.
+ This is a follow up to the parent commit dcdd4be which fixes one leak
+ but creates another by failing to free the credentials handle if out of
+ memory. Also there's a second location a few lines down where we fail to
+ do same. This commit fixes both of those issues.
-- RELEASE-NOTES: synced with 92f7606f29b704
+Daniel Stenberg (20 Jul 2016)
+- [Saurav Babu brought this change]
-- smtp: Fixed an issue when processing EHLO failure responses (Part 3)
+ vauth: Fixed memory leak due to function returning without free
- Follow up fix to commit 62bd21746443 to cater for servers that don't
- respond with a 250 in their EHLO responses. Additionally updated the
- SMTP tests to respond with a 250 response code as per RFC5321.
+ This patch allocates memory to "output_token" only when it is required
+ so that memory is not leaked if function returns.
-- pop3: Fixed SASL authentication capability detection
+- test558: updated after ipv6-check move
- Fixed the SASL capability detection to include the space character
- before the authentication mechanism list. Otherwise a capability such
- as SASLSOMETHING would be interpreted as enabling SASL and potentially
- trying to identify SOMETHING as a mechanism.
+ Follow-up commit to c50980807c5 to make this test pass.
-- pop3: Fixed incorrect return value from pop3_endofresp()
+Jay Satiro (20 Jul 2016)
+- connect: disable TFO on Linux when using SSL
+
+ - Linux TFO + TLS is not implemented yet.
- Corrected an incorrect return value when -ERR is received from the
- server - introduced in commit b5bb61ee697b (June 2012).
+ Bug: https://github.com/curl/curl/issues/907
+
+Daniel Stenberg (19 Jul 2016)
+- ROADMAP: QUIC and TLS 1.3
-- smtp: Fixed an issue when processing EHLO failure responses (Part 2)
+- RELEASE-NOTES: synced with c50980807c5
+
+Jay Satiro (18 Jul 2016)
+- [Brian Prodoehl brought this change]
+
+ curl_global_init: Check if IPv6 works
- Follow up fix to commit 23d17190ee32 as EHLO capabilities can exist
- within a positive response line.
+ - Curl_ipv6works() is not thread-safe until after the first call, so
+ call it once during global init to avoid a possible race condition.
+
+ Bug: https://github.com/curl/curl/issues/915
+ PR: https://github.com/curl/curl/pull/918
+
+- [Timothy Polich brought this change]
-- smtp: Fixed an issue with missing capabilities after the AUTH line
+ CURLMOPT_SOCKETFUNCTION.3: fix typo
- Follow up to commit 40f9bb787f05 to fix missing capabilities after an
- AUTH line.
+ Closes https://github.com/curl/curl/pull/914
-Nick Zitzmann (8 Feb 2013)
-- darwinssl: Make certificate errors less techy
+- [Miroslav Franc brought this change]
+
+ library: Fix memory leaks found during static analysis
- Previously if a problem was found with one of the server's certificates,
- we'd log an OSStatus for the end user to look up. Now we explain what
- was wrong with the site's certificate chain. Also un-did part of the
- previous commit where the code wouldn't catch errSSLServerAuthCompleted
- if built under Leopard.
+ Closes https://github.com/curl/curl/pull/913
-Guenter Knauf (9 Feb 2013)
-- Updated dependency libs.
+- [Viktor Szakats brought this change]
-Steve Holme (9 Feb 2013)
-- imap: Corrected some comments
+ cookie.c: Fix misleading indentation
+
+ Closes https://github.com/curl/curl/pull/911
-- smtp: Fixed an issue when processing EHLO failure responses
+- FAQ: Update FTP directory listing section for MLSD command
+
+ Explain how some FTP servers support the machine readable listing
+ format MLSD from RFC 3659 and compare it to LIST.
- Fixed a small issue where smtp_endofresp() would look for capabilities
- in the description part of a failure response. In theory a server
- shouldn't respond with SIZE or AUTH in an EHLO command's failure
- response but if it did then capabilities would be unnecessarily set
- before eventually failing.
+ Ref: https://github.com/curl/curl/issues/906
-- pop3: Reworked pop3_endofresp() to simplify it little
+Daniel Stenberg (1 Jul 2016)
+- [Sergei Nikulov brought this change]
+
+ Appveyor: Updates for options - CURL_STATICLIB/BUILD_TESTING
- Reworked pop3_endofresp() to simplify it and provide consistency between
- imap and smtp.
+ Closes #892
-- imap: Renamed state variables in imap_authenticate()
+- TODO: 17.4 also brings more HTTP/2 support
+
+- TODO: try next proxy if one doesn't work
- Renamed the authstate1 and authstate2 variables in imap_authenticate()
- as the old name was a left over from when there was only one state
- variable which was named due to a clash with the state() function.
+ Closes #896
+
+- conn: don't free easy handle data in handler->disconnect
- Additionally this provides consistency with the smtp module.
+ Reported-by: Gou Lingfeng
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0139.html
-- smtp: Reworked smtp_endofresp() to allow for extra capability detection
+- test1244: test different proxy ports same URL
-- smtp: Renamed smtp_state_auth_passwd_resp() function
+- curl_global_init.3: improved formatting of the flags
+
+- curl_global_init.3: expand on the SSL and WIN32 bits purpose
- Renamed the login password response function to better describe it's
- purpose as well as for consistency with the imap and pop3 modules.
+ Reported-by: Richard Gray
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0136.html
-Daniel Stenberg (8 Feb 2013)
-- [Gisle Vanem brought this change]
+- [Michael Kaufmann brought this change]
- ntlm: fix memory leak
-
- Running tests\libtest\libntlmconnect.exe reveals a 1 byte (!) leak in
- ./lib/curl_ntlm_msgs.c:
+ cleanup: minor code cleanup in Curl_http_readwrite_headers()
- perl ..\memanalyze.pl c:memdebug.curl
- Leak detected: memory still allocated: 1 bytes
- At 9771e8, there's 1 bytes.
- allocated by curl_ntlm_msgs.c:399
+ - the expression of an 'if' was always true
+ - a 'while' contained a condition that was always true
+ - use 'if(k->exp100 > EXP100_SEND_DATA)' instead of 'if(k->exp100)'
+ - fixed a typo
- Snippet from curl_ntlm_msgs.c:
- /* setup ntlm identity's domain and length */
- dup_domain.tchar_ptr = malloc(sizeof(TCHAR) * (domlen + 1));
+ Closes #889
+
+- SFTP: set a generic error when no SFTP one exists...
- (my domlen == 0).
+ ... as otherwise we could get a 0 which would count as no error and we'd
+ wrongly continue and could end up segfaulting.
- 'dup_domain.tbyte_ptr' looks to be freed in Curl_ntlm_sspi_cleanup() via
- 'ntlm->identity.Domain'. But I see no freeing of 'dup_domain.tchar_ptr'.
+ Bug: https://curl.haxx.se/mail/lib-2016-06/0052.html
+ Reported-by: 暖和的和暖
+
+- ROADMAP: http2 tests are merged, mention http2 perf
-- DONE: consider callback-aborted transfers premature
+- docs/README.md: to render nicer pages on github
- This bug report properly identified that when doing SMTP and aborting
- the transfer with a callback, it must be considered aborted prematurely
- by the code to avoid QUIT etc to be attempted as that would cause a
- hang.
+ ... as previously the README.cmake would be picked and put at the bottom
+ of the docs page there and it wasn't very representative!
+
+- README.md: change host name for the svg logo
- The new test case 1507 verifies this behavior.
+ rawgit.com asks to use the domain cdn.rawgit.com for production
- Reported by: Patricia Muscalu
- Bug: http://curl.haxx.se/bug/view.cgi?id=1184
+ See #900
+
+- [Viktor Szakats brought this change]
-- FAQ: refreshed some phrases
+ README.md: use the SVG logo
-Nick Zitzmann (7 Feb 2013)
-- darwinssl: Fix build under Leopard
+- README.md: logo on top!
+
+- KNOWN_BUGS: 3.4 POP3 expects "CRLF.CRLF" eob for some
- It turns out that Leopard (OS X 10.5) doesn't have constants for the ECDH
- ciphers in its headers, so the cases for them have been taken out of the
- build when building under Leopard. Also added a standard function for
- getting a string description of a SecCertificateRef.
+ Closes #740
+
+- RELEASE-NOTES: synced with d61c80515aa8
-Steve Holme (7 Feb 2013)
-- RELEASE-NOTES: Added new imap features
+- [Michael Osipov brought this change]
-- imap: Added support for SASL-IR extension (Part 2)
+ acinclude.m4: improve autodetection of CA bundle on FreeBSD
+
+ The FreeBSD Port security/ca_root_nss installs the Mozilla NSS CA bundle
+ to /usr/local/share/certs/ca-root-nss.crt. Use this bundle in the
+ discovery process.
- Modified imap_authenticate() to add support for sending the initial
- response with the AUTHENTICATE command, as per RFC4959.
+ This change also removes the former FreeBSD path that has been obsolete
+ for 8 years since this FreeBSD ports commit:
+ https://svnweb.freebsd.org/ports/head/security/?view=revision&revision=215953
+
+ Closes #894
-- smtp: Updated SMTP_AUTH_PASSWD state constant
+- configure: don't specify .lib for libs on windows
- Changed the SMTP_AUTH_PASSWD state constant to SMTP_AUTH_LOGIN_PASSWD to
- better describe the state as the second part of an AUTH LOGIN command,
- as well as for consistency with the imap and pop3 modules.
+ Another follow up for crypt32.lib linking with winssl
-- imap: Added support for SASL-IR extension (Part 1)
+- configure: fix winssl LIBS change typo
- Introduced detection of the SASL-IR capability, in order to add support
- for sending the initial response with the AUTHENTICATE command, as per
- RFC4959.
+ follow-up from 120bf29e
+
+- TODO: "TCP Fast Open" is done, add monitor pool connections
-Daniel Stenberg (7 Feb 2013)
-- Revert "vc: remove explicit MSVC6 IDE project file and documentation"
+- configure: add crypt32.lib for winssl builds
- This reverts commit 0e66d5878edc3d7ffc445116d194b58bbc7504b9.
+ Necessary since 6cabd78531f
-Steve Holme (7 Feb 2013)
-- imap: Changed response tag generation to be completely unique
+- Makefile.vc: link with crypt32.lib for winssl builds
- Updated the automatic response tag generation to follow the examples
- given in RC3501, which list a 4 character string such as A001, A002,
- etc.
+ Necessary since 6cabd78531f
- As a unique identifier should be generated for each command the string
- generation is based on the connection id and the incrementing command
- id.
+ Fixes #853
-Dan Fandrich (6 Feb 2013)
-- Tweak the Android.mk file for its new location
-
- This is untested, but ought to be enough to still allow it
- to work automatically when the entire curl source tree is
- dropped into a full Android source tree.
+- [Joel Depooter brought this change]
-Daniel Stenberg (6 Feb 2013)
-- vc: remove explicit MSVC6 IDE project file and documentation
+ VC: Add crypt32.lib to Visual Sudio project template files
- VC6 is _very_ old and we provide working makefiles even for that
- compiler. Users who build with the IDE never use that method and project
- file anyway and it was just lingering in the root dir.
+ Closes #854
-Steve Holme (6 Feb 2013)
-- imap: Small variable rename in preparation for upcoming change
+- vc: fix the build for schannel certinfo support
- Renamed a couple of variables and updated some comments in
- preparation for upcoming command id / response tag change.
+ Broken since 6cabd785, which adds use of the Curl_extract_certinfo
+ function from the x509asn1.c file.
-Daniel Stenberg (6 Feb 2013)
-- msvc: move Makefile.msvc.names into winbuild/
+- typedefs: use the full structs in internal code...
- In an attempt to clear up misc files from the root dir
+ ... and save the typedef'ed names for headers and external APIs.
-- build: move Android.mk to packages/Android/
+- internals: rename the SessionHandle struct to Curl_easy
-- emacs files: remove from git and dist
+- headers: forward declare CURL, CURLM and CURLSH as structs
+
+ Instead of typedef'ing to void, typedef to their corresponding actual
+ struct names to allow compilers to type-check.
- We don't need them and I doubt many people used them. We also don't have
- any configs for other editors and we wouldn't want that.
+ Assisted-by: Reinhard Max
-Steve Holme (6 Feb 2013)
-- email: Moved starttls code in separate functions
+Jay Satiro (22 Jun 2016)
+- vtls: Only call add/getsession if session id is enabled
- To help maintain the readability of the code in imap.c, pop3.c and
- smtp.c moved the starttls code into state_starttls() functions.
+ Prior to this change we called Curl_ssl_getsessionid and
+ Curl_ssl_addsessionid regardless of whether session ID reusing was
+ enabled. According to comments that is in case session ID reuse was
+ disabled but then later enabled.
+
+ The old way was not intuitive and probably not something users expected.
+ When a user disables session ID caching I'd guess they don't expect the
+ session ID to be cached anyway in case the caching is later enabled.
-- [Nick Zitzmann brought this change]
+Daniel Stenberg (22 Jun 2016)
+- curl.1: the used progress meter suffix is k in lower case
+
+ Closes #883
- FEATURES: More NTLM and SSL changes, added two others, fixed typo
+- [Sergei Nikulov brought this change]
+
+ cmake: now using BUILD_TESTING=ON/OFF
- Added IDN and HTTP data compression as they were left out of the
- document until now.
+ CMake build now using BUILD_TESTING=ON/OFF (default is OFF) to build
+ tests and enabling CTest integration. Options BUILD_CURL_TESTS and
+ BUILD_DASHBOARD_REPORTS was removed.
- Added notes for qssl, schannel and Secure Transport supporting SSLv2,
- Secure Transport supports NTLM, and axTLS does not support SSLv3.
+ Closes #882
- There was also a typo; "AUTH TSL" should be "AUTH TLS".
+ Reviewed-by: Brad King
-Kamil Dudka (6 Feb 2013)
-- curl-config.in: do not randomly mix tabs and spaces
+- [Michael Kaufmann brought this change]
-Daniel Stenberg (6 Feb 2013)
-- 7.29.1: onwards!
+ cleanup: fix method names in code comments
+
+ Closes #887
-- THANKS: 12 contributors from 7.29.0
+Kamil Dudka (21 Jun 2016)
+- curl-compilers.m4: improve detection of GCC's -fvisibility= flag
+
+ Some builds of GCC produce output on both stdout and stderr when --help
+ --verbose is used. The 2>&1 redirection caused them to be arbitrarily
+ interleaved with each other because of stream buffering. Consequently,
+ grep failed to match the fvisibility= string in the mixed output, even
+ though the string was present in GCC's standard output.
+
+ This led to silently disabling symbol hiding in some builds of curl.
-Version 7.29.0 (6 Feb 2013)
+Daniel Stenberg (19 Jun 2016)
+- tests: fix the HTTP/2 tests
+
+ The HTTP/2 tests brought with commit bf05606ef1f were using the internal
+ name 'http2' for the HTTP/2 server, while in fact that name was already
+ used for the second instance of the HTTP server. This made tests using
+ the second instance (like test 2050) fail after a HTTP/2 test had run.
+
+ The server is now known as HTTP/2 internally and within the <server>
+ section in test cases. 1700, 1701 and 1702 were updated accordingly.
-Daniel Stenberg (6 Feb 2013)
-- vms: config-vms.h is removed, no use trying to distribute it
+- openssl: use more 'const' to fix build warnings with 1.1.0 branch
-- RELEASE-NOTES: mention the SASL buffer overflow
+- curl.1: missed 'T' in the progress unit suffixes
-- [Eldar Zaitov brought this change]
+- curl.1: mention the unix for the progress meter
- Curl_sasl_create_digest_md5_message: fix buffer overflow
-
- When negotiating SASL DIGEST-MD5 authentication, the function
- Curl_sasl_create_digest_md5_message() uses the data provided from the
- server without doing the proper length checks and that data is then
- appended to a local fixed-size buffer on the stack.
+Patrick Monnerat (16 Jun 2016)
+- os400: add new definitions to ILE/RPG binding.
+
+Daniel Stenberg (16 Jun 2016)
+- openssl: fix cert check with non-DNS name fields present
- This vulnerability can be exploited by someone who is in control of a
- server that a libcurl based program is accessing with POP3, SMTP or
- IMAP. For applications that accept user provided URLs, it is also
- thinkable that a malicious user would feed an application with a URL to
- a server hosting code targetting this flaw.
+ Regression introduced in 5f5b62635 (released in 7.48.0)
- Bug: http://curl.haxx.se/docs/adv_20130206.html
+ Reported-by: Fabian Ruff
+ Fixes #875
-Steve Holme (6 Feb 2013)
-- FEATURES: Removed erroneous whitespace
-
- Removed whitespace introduced in commit 5f8f20f5e65b that caused
- formatting issues when generating the website docs.
+Dan Fandrich (16 Jun 2016)
+- axtls: Use Curl_wait_ms instead of the less-portable usleep
+
+- axtls: Fixed compile after compile 31c521b0
+
+- tests: Added HTTP proxy keywords to tests 1141 & 1142
-Yang Tse (6 Feb 2013)
-- setup-vms.h: post VMS patch cleanup - III
+Jay Satiro (15 Jun 2016)
+- [Sergei Nikulov brought this change]
+
+ cmake: Fix build with winldap
- - rename post-config-vms.h to setup-vms.h
- - move its inclusion into proper location in curl_setup.h
+ Bug: https://github.com/curl/curl/pull/874
+ Reported-by: Sergei Nikulov
-- vms_show: post VMS patch cleanup - II
+- CURLOPT_POSTFIELDS.3: Clarify what happens when set empty
+
+ When CURLOPT_POSTFIELDS is set to an empty string libcurl will send a
+ zero-byte POST. Prior to this change it was documented as sending data
+ from the read callback.
- - remove multiple declarations of vms_show and add comments
+ This also changes the wording of what happens when empty or NULL so that
+ it's hopefully easier to understand for people whose primary language
+ isn't English.
+
+ Bug: https://github.com/curl/curl/issues/862
+ Reported-by: Askar Safin
+
+- [Michael Wallner brought this change]
-- tool_main.c: post VMS patch cleanup - I
+ curl_multi_socket_action.3: Fix rewording
- - remove header inclusion already done in curl_setup_once.h
+ - Remove some erroneous text.
+
+ Closes https://github.com/curl/curl/pull/865
+
+- [Luo Jinghua brought this change]
-Steve Holme (6 Feb 2013)
-- FEATURES: Added SSPI to list of NTLM libraries
+ resolve: enable protocol family logic for synthesized IPv6
+
+ - Enable protocol family logic for IPv6 resolves even when support
+ for synthesized addresses is enabled.
+
+ This is a follow up to the parent commit that added support for
+ synthesized IPv6 addresses from IPv4 on iOS/OS X. The protocol family
+ logic needed for IPv6 was inadvertently excluded if support for
+ synthesized addresses was enabled.
+
+ Bug: https://github.com/curl/curl/issues/863
+ Ref: https://github.com/curl/curl/pull/866
+ Ref: https://github.com/curl/curl/pull/867
-- FEATURES: Added Secure Transport and qssl to list of SSL libraries
+Daniel Stenberg (7 Jun 2016)
+- [Luo Jinghua brought this change]
-- FEATURES: Added email feature set
+ resolve: add support for IPv6 DNS64/NAT64 Networks on OS X + iOS
- Added SMTP, SMTPS, POP3, POP3S, IMAP and IMAPS features.
+ Use getaddrinfo() to resolve the IPv4 address literal on iOS/Mac OS X.
+ If the current network interface doesn’t support IPv4, but supports
+ IPv6, NAT64, and DNS64.
+
+ Closes #866
+ Fixes #863
-- imap.h: Corrected incorrect comment clarification
+- tests: two more HTTP/2 tests
- Corrected comment clarification made in commit 167717b8069a.
+ 1701 and 1702
-- COPYING: Updated copyright year to include 2013
+- runtests: don't display logs when http2 server fails to start
-Daniel Stenberg (5 Feb 2013)
-- RELEASE-NOTES: synced with 25f351424b3538
+- runtests: make stripfile work on stdout as well
- 8 more bug fixes mentioned
+ ... and have test 1700 use that to strip out the nghttpx server: headers
-- [John E. Malmberg brought this change]
+- http2-tests: test1700 is the first real HTTP/2 test
+
+ It requires that 'nghttpx' is in the PATH, and it will run the tests
+ using nghttpx as a front-end proxy in front of the standard HTTP/1 test
+ server. This uses HTTP/2 over plain TCP.
+
+ If you like me have nghttpx installed in a custom path, you can run test 1700
+ like this:
+
+ $ PATH=$PATH:$HOME/build-nghttp2/bin/ ./runtests.pl 1700
- VMS: fix and generate the VMS build config
+- RELEASE-NOTES: synced with 34855feeb4c299
+
+Steve Holme (6 Jun 2016)
+- schannel: Disable ALPN on Windows < 8.1
- config_h.com is a new file that generates a config.h file based on the
- curl_config.h.in file and a quick scan of the configure script. This is
- actually a generic procedure that is shared with other VMS packages.
+ Calling QueryContextAttributes with SECPKG_ATTR_APPLICATION_PROTOCOL
+ fails on Windows < 8.1 so we need to disable ALPN on these OS versions.
- The existing pre-built config-vms.h had over 100 entries that were not
- correct and in some cases conflicted with the build options available in
- the build_vms.com.
+ Inspiration provide by: Daniel Seither
- generate_config_vms_h_curl.com is a helper procedure to the
- config_h.com. It covers the cases that the generic config_h.com is not
- able to figure out, and accepts input from the build_vms.com procedure.
+ Closes #848
+ Fixes #840
+
+Jay Satiro (5 Jun 2016)
+- checksrc: Add LoadLibrary to the banned functions list
- build_curlbuild_h.com is a new file to generate the curlbuild.h file
- that Curl is now using when it is using a curl_config.h file.
+ LoadLibrary was supplanted by Curl_load_library for security
+ reasons in 6df916d.
+
+- http: Fix HTTP/2 connection reuse
- post-config-vms.h is a new file that is needed to provide VMS specific
- definitions, and most of them need to be set before the system header
- files are included.
+ - Change the parser to not require a minor version for HTTP/2.
- The VMS build procedure is fixed:
+ HTTP/2 connection reuse broke when we changed from HTTP/2.0 to HTTP/2
+ in 8243a95 because the parser still expected a minor version.
- 1. Fixed to link in the correct HP ssl library.
- 2. Fixed to detect if HP Kerberos is installed.
- 3. Fixed to detect if HP LDAP is installed.
- 4. Fixed to detect if gnv$libzshr is installed.
- 5. Simplified the input parameter parsing to not use a loop.
- 6. Warn that 64 bit pointer option support is not complete
- in comments.
- 7. Default to IEEE floating if platform supports it so
- resulting libcurl will be compatible with other
- open source projects on VMS.
- 8. Default to LARGEFILE if platform supports it.
- 9. Default to enable SSL, LDAP, Kerberos, libz
- if the libraries are present.
- 10. Build with exact case global symbols for libcurl.
- 11. Generate linker option file needed.
- 12. Compiler list option only commonly needed items.
- 13. fulllist option for those who really want it.
- 14. Create debug symbol file on Alpha, IA64.
+ Bug: https://github.com/curl/curl/issues/855
+ Reported-by: Andrew Robbins, Frank Gevaerts
-- Curl_proxyCONNECT: return once CONNECT is sent
+Steve Holme (4 Jun 2016)
+- connect.c: Fixed compilation warning from commit 332e8d6164
- By doing this unconditionally, we infer a simpler and more defined
- behavior. This also has the upside that test 1021 no longer fails for me
- even if I run with valgrind.
+ connect.c:952:5: warning: suggest explicit braces to avoid ambiguous 'else'
+
+- win32: Used centralised verify windows version function
- Also fixed some wrong comments.
+ Closes #845
+
+- win32: Added verify windows version functionality
-Steve Holme (5 Feb 2013)
-- email: Reworked comments in the endofresp() functions
+- win32: Introduced centralised verify windows version function
+
+Kamil Dudka (3 Jun 2016)
+- tool_urlglob: fix off-by-one error in glob_parse()
+
+ ... causing SIGSEGV while parsing URL with too many globs.
+ Minimal example:
- Tidied up the comments in the endofresp() functions to be more
- meaningful prior to release.
+ $ curl $(for i in $(seq 101); do printf '{a}'; done)
+
+ Reported-by: Romain Coltel
+ Bug: https://bugzilla.redhat.com/1340757
+
+Daniel Stenberg (1 Jun 2016)
+- [Benjamin Kircher brought this change]
-Marc Hoersken (5 Feb 2013)
-- schannel: Removed extended error connection setup flag
+ libcurl-multi.3: fix small typo
- According KB975858 this flag may cause problems on Windows 7 and
- Windows Server 2008 R2 systems. Extended error information is not
- currently used by libcurl and therefore not a requirement.
+ Closes #850
+
+- [Viktor Szakats brought this change]
+
+ makefile.m32: add crypt32 for winssl builds
- The flag may improve the SSL-connection shutdown in case of an
- error. This means it might be a good improvement in the future.
+ Dependency added by 6cabd78
- Fixes bug/issue #1187 - thanks for the report
+ Closes #849
-Daniel Stenberg (5 Feb 2013)
-- [Tor Arntsen brought this change]
+- [Ivan Avdeev brought this change]
- singleipconnect: Update *sockp for all CURLE_OK
+ vtls: fix ssl session cache race condition
+
+ Sessionid cache management is inseparable from managing individual
+ session lifetimes. E.g. for reference-counted sessions (like those in
+ SChannel and OpenSSL engines) every session addition and removal
+ should be accompanied with refcount increment and decrement
+ respectively. Failing to do so synchronously leads to a race condition
+ that causes symptoms like use-after-free and memory corruption.
+ This commit:
+ - makes existing session cache locking explicit, thus allowing
+ individual engines to manage lock's scope.
+ - fixes OpenSSL and SChannel engines by putting refcount management
+ inside this lock's scope in relevant places.
+ - adds these explicit locking calls to other engines that use
+ sessionid cache to accommodate for this change. Note, however,
+ that it is unknown whether any of these engines could also have
+ this race.
- The 56b7c87c7 change left a case where a good sockfd was not copied to
- *sockp before returning with CURLE_OK
+ Bug: https://github.com/curl/curl/issues/815
+ Fixes #815
+ Closes #847
-- curl_easy_perform: Value stored to 'mcode' is never read
+- [Andrew Kurushin brought this change]
+
+ schannel: add CURLOPT_CERTINFO support
- pointed out by clang-analyzer
+ Closes #822
+
+- RELEASE-NOTES: synced with 142ee9fa15002315
-- singleipconnect: remove dead assignment
+- openssl: rename the private SSL_strerror
- pointed out by clang-analyzer
+ ... to make it not look like an OpenSSL function
-Linus Nielsen Feltzing (5 Feb 2013)
-- CURLMOPT_MAXCONNECTS: restore functionality
+- [Michael Kaufmann brought this change]
+
+ openssl: Use correct buffer sizes for error messages
- When a connection is no longer used, it is kept in the cache. If the
- cache is full, the oldest idle connection is closed. If no connection is
- idle, the current one is closed instead.
+ Closes #844
-Steve Holme (5 Feb 2013)
-- RELEASE-NOTES: Updated following recent changes to the email protocols
+- curl: fix -q [regression]
+
+ This broke in 7.49.0 with commit e200034425a7625
- Added recent additions and fixes following the changes to imap, pop3
- and smtp. Additionally added another contributor that helped to test
- the imap sasl changes.
+ Fixes #842
-- email: Provided extra comments following recent pop3/imap fixes
+- URL parser: allow URLs to use one, two or three slashes
+
+ Mostly in order to support broken web sites that redirect to broken URLs
+ that are accepted by browsers.
- Provided additional clarification about the logic of the authenticate()
- functions following commit 6b6bdc83bd36 and b4270a9af1d0.
+ Browsers are typically even more leniant than this as the WHATWG URL
+ spec they should allow an _infinite_ amount. I tested 8000 slashes with
+ Firefox and it just worked.
+
+ Added test case 1141, 1142 and 1143 to verify the new parser.
+
+ Closes #791
-Daniel Stenberg (5 Feb 2013)
-- [Andrei Kurushin brought this change]
+- [Renaud Lehoux brought this change]
- winbuild: include version info for .dll .exe
+ cmake: Added missing mbedTLS support
- Bug: http://curl.haxx.se/bug/view.cgi?id=1186
+ Closes #837
-- FAQ: clarify 5.13 How do I stop an ongoing transfer
+- [Renaud Lehoux brought this change]
+
+ mbedtls: removed unused variables
- Rich Gray provided good feedback and we now clarify that you can in fact
- stop a multi transfer at any point you like by removing the easy handle.
+ Closes #838
-- [Matt Arsenault brought this change]
+- [Frank Gevaerts brought this change]
- cmake: Fix mingw build
+ http: add CURLINFO_HTTP_VERSION and %{http_version}
+
+ Adds access to the effectively used http version to both libcurl and
+ curl.
+
+ Closes #799
-- [Sergei Nikulov brought this change]
+- bump: start the journey toward 7.50.0
- cmake: updated OpenSSL build
+- [Marcel Raad brought this change]
-Steve Holme (4 Feb 2013)
-- pop3.c: Updated variable names to use shorter / more readable variant
+ openssl: fix build with OPENSSL_NO_COMP
+
+ With OPENSSL_NO_COMP defined, there is no function
+ SSL_COMP_free_compression_methods
- Tidied up code from commit 6b6bdc83bdUpdated where a few instances of
- the pop3c struct variable used the longer conndata struct rather than
- matching what other code in pop3_authenticate() used.
+ Closes #836
-Guenter Knauf (4 Feb 2013)
-- updated copyright years.
+- [Gisle Vanem brought this change]
+
+ memdebug: fix MSVC crash with -DMEMDEBUG_LOG_SYNC
+
+ Fixes #828
-- configure: update the copyright years for the output.
+- [Jonathan brought this change]
-Steve Holme (3 Feb 2013)
-- imap: Fixed no known authentication mechanism when fallback is required
+ README.md: polish
- Fixed an issue where (lib)curl is compiled without support for a
- supported challenge-response based SASL authentication mechanism, such
- as CRAM-MD5 or NTLM, the server doesn't support the LOGIN or PLAIN
- mechanisms and (lib)curl doesn't fallback to Clear Text authentication.
+ Closes #834
+
+- RELEASE-NOTES: fix vuln link
+
+Version 7.49.1 (30 May 2016)
+
+Daniel Stenberg (30 May 2016)
+- RELEASE-NOTES: 7.49.1
+
+- [Steve Holme brought this change]
+
+ loadlibrary: Only load system DLLs from the system directory
- Note: In order to fallback to Clear Text authentication properly this
- fix adds support for the LOGINDISABLED server capability.
- imap: Fixed no known authentication mechanism when fallback is required
+ Inspiration provided by: Daniel Stenberg and Ray Satiro
- Fixed an issue where (lib)curl is compiled without support for a
- supported challenge-response based SASL authentication mechanism, such
- as CRAM-MD5 or NTLM, the server doesn't support the LOGIN or PLAIN
- mechanisms and (lib)curl doesn't fallback to Clear Text authentication.
+ Bug: https://curl.haxx.se/docs/adv_20160530.html
- Note: In order to fallback to Clear Text authentication properly this
- fix adds support for the LOGINDISABLED server capability.
+ Ref: Windows DLL hijacking with curl, CVE-2016-4802
+
+- ssh: fix version number check typo
+
+Jay Satiro (29 May 2016)
+- curl_share_setopt.3: Add min ver needed for ssl session lock
- Related bug: http://curl.haxx.se/mail/lib-2013-02/0004.html
- Reported by: Stanislav Ivochkin
+ Bug: https://github.com/curl/curl/issues/826
+ Reported-by: Michael Wallner
-- pop3: Fixed no known authentication mechanism when fallback is required
+Daniel Stenberg (29 May 2016)
+- ssh: fix build for libssh2 before 1.2.6
- Fixed an issue where (lib)curl is compiled without support for a
- supported challenge-response based SASL authentication mechanism, such
- as CRAM-MD5 or NTLM, the server doesn't support the LOGIN or PLAIN
- mechanisms and (lib)curl doesn't fallback to APOP or Clear Text
- authentication.
+ The statvfs functionality was added to libssh2 in that version, so we
+ switch off that functionality when built with older libraries.
- Bug: http://curl.haxx.se/mail/lib-2013-02/0004.html
- Reported by: Stanislav Ivochkin
+ Fixes #831
-Daniel Stenberg (1 Feb 2013)
-- singleipconnect: simplify and clean up
+- mbedtls: fix includes so snprintf() works
- Remove timeout argument that's never used.
+ Regression from the previous *printf() rearrangements, this file missed to
+ include the correct header to make sure snprintf() works universally.
- Make the actual connection get detected on a single spot to reduce code
- duplication.
+ Reported-by: Moti Avrahami
+ Bug: https://curl.haxx.se/mail/lib-2016-05/0196.html
+
+Steve Holme (23 May 2016)
+- checksrc.pl: Added variants of strcat() & strncat() to banned function list
- Store the IPv6 state already when the connection is attempted.
+ Added support for checking the tchar, unicode and mbcs variants of
+ strcat() and strncat() in the banned function list.
-- Curl_perfom: removed
+Daniel Stenberg (23 May 2016)
+- smtp: minor ident (white space) fixes
+
+- THANKS: updated after script fixes
- Curl_perfom is no longer used anywhere since the always-multi commit
- c43127414d89ccb9, and some related functions were used only from within
- Curl_perfom.
+ Now giving credit properly to github user names, fixed some UTF-8 issues
+ and added names discovered when contrithanks was improved.
+
+- THANKS-filter: more name cleanups
+
+- contrithanks.sh: exclude existing names case insensitively
+
+- contrithanks.sh: use same grep pattern and -a flag as contributors.sh
-Guenter Knauf (30 Jan 2013)
-- Updated date.
+- contributors.sh: better grep pattern, use grep -a
+
+- THANKS-filter: fix more names
+
+- contrithanks.sh: do the same github fix as contributors.sh
+
+ from 1577bfa35ba
-Yang Tse (30 Jan 2013)
-- zz40-xc-ovr.m4: fix 'wc' detection - follow-up 2
+Jay Satiro (23 May 2016)
+- contributors: Show GitHub username if real name unknown
- - Fix a pair of single quotes to double quotes.
+ Prior to this change if a GitHub contributor's real name was unknown
+ they would be omitted from the list.
- URL: http://curl.haxx.se/mail/lib-2013-01/0355.html
- Reported by: Tor Arntsen
+ Bug: https://github.com/curl/curl/issues/824
-- zz40-xc-ovr.m4: fix 'wc' detection - follow-up
+Daniel Stenberg (21 May 2016)
+- RELEASE-NOTES: synced with 3caaeffbe8ded4
+
+Jay Satiro (20 May 2016)
+- openssl: cleanup must free compression methods
- - Take into account that 'wc' may return leading spaces and/or tabs.
+ - Free compression methods if OpenSSL 1.0.2 to avoid a memory leak.
- - Set initial IFS to space, tab and newline.
+ Bug: https://github.com/curl/curl/issues/817
+ Reported-by: jveazey@users.noreply.github.com
+
+Daniel Stenberg (20 May 2016)
+- [Gisle Vanem brought this change]
-- zz40-xc-ovr.m4: fix 'wc' detection
+ curl_multibyte: fix compiler error
- - Take into account that 'wc' may return leading spaces.
+ While compiling lib/curl_multibyte.c with '-DUSE_WIN32_IDN' etc. I was
+ getting:
- - Set internationalization behavior variables.
+ f:\mingw32\src\inet\curl\lib\memdebug.h(38): error C2054: expected '('
+ to follow 'CURL_EXTERN'
- Tor Arntsen analyzed and reported the issue.
+ f:\mingw32\src\inet\curl\lib\memdebug.h(38): error C2085:
+ 'curl_domalloc': not in formal parameter list
+
+- THANKS-filter: make Jan-E get proper credit
+
+- [Jan-E brought this change]
+
+ winbuild/Makefile.vc: Fix check on SSL, MBEDTLS, WINSSL exclusivity
- URL: http://curl.haxx.se/mail/lib-2013-01/0351.html
+ Closes #818
-- zz40-xc-ovr.m4: check another three basic utilities
+- [Alexander Traud brought this change]
-Guenter Knauf (29 Jan 2013)
-- Fixed debug.c to work again unchanged.
+ libcurl.m4: Avoid obsolete warning
- Added CURLOPT_FOLLOWLOCATION since example.com is now redirected.
+ Closes #821
-Daniel Stenberg (29 Jan 2013)
-- [Nick Zitzmann brought this change]
+Jay Satiro (20 May 2016)
+- [Michael Kaufmann brought this change]
- darwinssl: Fix bug where packets were sometimes transmitted twice
+ CURLOPT_CONNECT_TO.3: user must not free the list prematurely
- There was a bug where, if SSLWrite() returned errSSLWouldBlock but did
- succeed in transmitting at least something, then we'd incorrectly
- resend the packet. Now we never take errSSLWouldBlock as a sign that
- nothing was transferred to/from the server.
+ The connect-to list isn't copied so as long as the handle may be used
+ for a transfer the list must be valid.
- Bug: http://curl.haxx.se/mail/lib-2013-01/0295.html
- Reported by: Bruno de Carvalho
-
-- [Nick Zitzmann brought this change]
+ Bug: https://github.com/curl/curl/pull/819
+ Reported-by: Michael Kaufmann
- FAQ: "Darwinssl" is AKA "Secure Transport" and supports NTLM
+Daniel Stenberg (19 May 2016)
+- RELEASE-NOTES: synced with 48114a8634242c
-- RELEASE-NOTES: only list Nick once
+- openssl: ERR_remove_thread_state() is deprecated in latest 1.1.0
- Even though he's a fine dude, once is enough for this time!
+ See OpenSSL commit 21e001747d4a
-Yang Tse (28 Jan 2013)
-- zz40-xc-ovr.m4: 1.0 interface stabilization
+- http2: use HTTP/2 in the HTTP/1.1-alike header
- - Stabilization results in 4 public interface m4 macros:
- XC_CONFIGURE_PREAMBLE
- XC_CONFIGURE_PREAMBLE_VER_MAJOR
- XC_CONFIGURE_PREAMBLE_VER_MINOR
- XC_CHECK_PATH_SEPARATOR
- - Avoid one level of internal indirection
- - Update comments
- - Drop XC_OVR_ZZ40 macro
+ ... when generating them, not "2.0" as the protocol is called just
+ HTTP/2 and nothing else.
-Kamil Dudka (28 Jan 2013)
-- docs: fix typos in man pages
+Jay Satiro (19 May 2016)
+- dist: include curl_multi_socket_all.3
- Reported by: Jiri Jaburek
- Bug: https://bugzilla.redhat.com/896544
+ Closes https://github.com/curl/curl/pull/816
-- docs: update the comments about loading CA certs with NSS
+Steve Holme (18 May 2016)
+- bump: Start work on 7.49.1
+
+Daniel Stenberg (18 May 2016)
+- curlbuild.h.dist: check __LP64__ as well to fix MIPS build
+
+ The preprocessor check that sets up the 32bit defines for non-configure
+ builds didn't work properly for MIPS systems as __mips__ is defined for
+ both 32bit and 64bit. Now __LP64__ is also checked and indicates 64bit.
- Bug: https://bugzilla.redhat.com/696783
+ Reported-by: Tomas Jakobsson
+ Fixes #813
-Guenter Knauf (28 Jan 2013)
-- Updated dependency libs.
+- [Marcel Raad brought this change]
-- Fixed simple.c to work again unchanged.
+ schannel: fix compile break with MSVC XP toolset
- Added CURLOPT_FOLLOWLOCATION since example.com is now redirected.
+ For the Windows XP toolset of Visual C++ 2013/2015, the old Windows SDK
+ 7.1 is used. In this case, _USING_V110_SDK71_ is defined.
+
+ Closes #812
-Steve Holme (27 Jan 2013)
-- smtp.c: Fixed unnecessary state change if starttls fails
+- dist: include CHECKSRC.md
- The state machine should only be changed to SMTP_STARTTLS when the
- STARTTLS command has been successfully sent to the server.
+ Reported-by: Paul Howarth
+ Bug: https://curl.haxx.se/mail/lib-2016-05/0116.html
-- pop3.c: Fixed unnecessary state change if starttls fails
+- test/Makefile.am: include manpage-scan.pl and nroff-scan.pl in dist
- The state machine should only be changed to POP3_STARTTLS when the
- STLS command has been successfully sent to the server.
+ Reported-by: Ray Satiro
+ Bug: https://curl.haxx.se/mail/lib-2016-05/0113.html
+
+Version 7.49.0 (17 May 2016)
-- imap.c: Fixed unnecessary state change if starttls fails
+Daniel Stenberg (17 May 2016)
+- THANKS: 24 new names from 7.49.0 release notes
+
+- RELEASE-NOTES: 7.49.0
+
+- mbedtls/polarssl: set "hostname" unconditionally
+
+ ...as otherwise the TLS libs will skip the CN/SAN check and just allow
+ connection to any server. curl previously skipped this function when SNI
+ wasn't used or when connecting to an IP address specified host.
- The state machine should only be changed to IMAP_STARTTLS when the
- STARTTLS command has been successfully sent to the server.
+ CVE-2016-3739
+
+ Bug: https://curl.haxx.se/docs/adv_20160518A.html
+ Reported-by: Moti Avrahami
+
+- [Frank Gevaerts brought this change]
-- email: Updated comment regarding ssldone usage
+ CURLOPT_RESOLVE.3: fix typo
- Updated the ssldone comment as multi mode is always used internally now.
+ Closes #811
-Yang Tse (26 Jan 2013)
-- zz40-xc-ovr.m4: emit witness message in configure BODY
+- docs: CURLOPT_RESOLVE overrides CURLOPT_IPRESOLVE
+
+- KNOWN_BUGS: GnuTLS backend skips really long certificate fields
- This avoids witness message in output when running configure --help,
- while sending the message to config.log for other configure runs.
+ Closes #762
+
+- CURLOPT_HTTPPOST.3: the data needs to be around while in use
-Steve Holme (25 Jan 2013)
-- smtp.c: Added comments to smtp_endofresp()
+- openssl: get_cert_chain: fix NULL dereference
- Minor code tidy up to add comments similar to those used in the pop3
- and imap end of resp functions, in order to assist anyone reading the
- code and highlight the similarities between each of these protocols.
+ CID 1361815: Explicit null dereferenced (FORWARD_NULL)
-Yang Tse (25 Jan 2013)
-- zz40-xc-ovr.m4: truly do version conditional overriding
+- openssl: get_cert_chain: avoid NULL dereference
- - version conditional overriding
- - catch unexpanded XC macros
- - fix double words in comments
+ CID 1361811: Explicit null dereferenced (FORWARD_NULL)
-- zz40-xc-ovr.m4: fix variable assignment of subshell output bashism
+- dprintf_formatf: fix (false?) Coverity warning
- Tor Arntsen analyzed and reported the issue.
+ CID 1024412: Memory - illegal accesses (OVERRUN). Claimed to happen when
+ we run over 'workend' but the condition says <= workend and for all I
+ can see it should be safe. Compensating for the warning by adding a byte
+ margin in the buffer.
- URL: http://curl.haxx.se/mail/lib-2013-01/0306.html
+ Also, removed the extra brace level indentation in the code and made it
+ so that 'workend' is only assigned once within the function.
-- zz40-xc-ovr.m4: reinstate strict AC_REQUIRE macro dependencies
+- RELEASE-NOTES: synced with 2dcb5adc72d6
-- zz40-xc-ovr.m4: avoid double single-quote usage
+- THANKS-filter: fixed Jonathan Cardoso
-- zz40-xc-ovr.m4: parentheses balancing of 'case' statements
+Jay Satiro (15 May 2016)
+- ftp: fix incorrect out-of-memory code in Curl_pretransfer
- m4 quadrigraph shell comment technique allows proper autoconf
- parentheses balancing in shell 'case' statements. The presence
- of unbalanced parentheses may otherwise trigger expansion bugs.
-
-Steve Holme (24 Jan 2013)
-- smtp.c: Corrected RFC references
+ - Return value type must match function type.
- The most recent version of the SMTP RFC is RFC5321 and not RFC2821 as
- previously documented.
+ s/CURLM_OUT_OF_MEMORY/CURLE_OUT_OF_MEMORY/
- Added RFC1870 and re-ordered list numerically.
+ Caught by Travis CI
-- smtp.c: Fixed failure detection during TLS upgrade
+Daniel Stenberg (15 May 2016)
+- ftp wildcard: segfault due to init only in multi_perform
- smtp_state_upgrade_tls() would attempt to incorrectly complete the
- upgrade to smtps and start the EHLO command if
- Curl_ssl_connect_nonblocking() returned a failure code and if ssldone
- was set to TRUE. This would only happen when a non-blocking API hadn't
- been provided by the SSL implementation and curlssl_connect() was
- called underneath.
-
-- pop3.c: Fixed failure detection during TLS upgrade
+ The proper FTP wildcard init is now more properly done in Curl_pretransfer()
+ and the corresponding cleanup in Curl_close().
+
+ The previous place of init/cleanup code made the internal pointer to be NULL
+ when this feature was used with the multi_socket() API, as it was made within
+ the curl_multi_perform() function.
- pop3_state_upgrade_tls() would attempt to incorrectly complete the
- upgrade to pop3s and start the CAPA command if
- Curl_ssl_connect_nonblocking() returned a failure code and if ssldone
- was set to TRUE. This would only happen when a non-blocking API hadn't
- been provided by the SSL implementation and curlssl_connect() was
- called underneath.
+ Reported-by: Jonathan Cardoso Machado
+ Fixes #800
-- imap.c: Fixed failure detection during TLS upgrade
+Jay Satiro (13 May 2016)
+- libcurl-tlibcurl-thread: Update OpenSSL links
- imap_state_upgrade_tls() would attempt to incorrectly complete the
- upgrade to imaps and start the CAPABILITY command if
- Curl_ssl_connect_nonblocking() returned a failure code and if ssldone
- was set to TRUE. This would only happen when a non-blocking API hadn't
- been provided by the SSL implementation and curlssl_connect() was
- called underneath.
+ Because the old OpenSSL link now redirects to their master documentation
+ (currently 1.1.0), which does not document the required actions for
+ OpenSSL <= 1.0.2.
-Yang Tse (24 Jan 2013)
-- zz40-xc-ovr.m4: internals overhauling
+Daniel Stenberg (13 May 2016)
+- [Viktor Szakats brought this change]
+
+ darwinssl.c: fix OS X codename typo in comment
+
+- RELEASE-NOTES: synced with 68701e51c1f7
- - Update comments
- - Execute commands in subshells
- - Faster path separator check
- - Fix missing 'test' command
- - Rename private macros
- - Minimize AC_REQUIRE usage
+ Added 8 bug fixes and 5 more contrbutors
-Steve Holme (23 Jan 2013)
-- email: Removed unnecessary return statements
+- [Jay Satiro brought this change]
+
+ mprintf: Fix processing of width and prec args
+
+ Prior to this change a width arg could be erroneously output, and also
+ width and precision args could not be used together without crashing.
+
+ "%0*d%s", 2, 9, "foo"
+
+ Before: "092"
+ After: "09foo"
+
+ "%*.*s", 5, 2, "foo"
- Small tidy up to remove unnecessary return statements prior to the next
- fix.
+ Before: crash
+ After: " fo"
+
+ Test 557 is updated to verify this and more
-Yang Tse (23 Jan 2013)
-- zz40-xc-ovr.m4: redirect errors and warnings to stderr
+- [Michael Kaufmann brought this change]
-- zz40-xc-ovr.m4: AC_REQUIRE also XC_CONFIGURE_PREAMBLE success message
+ ConnectionExists: follow-up fix for proxy re-use
+
+ Follow-up commit to 5823179
+
+ Closes #648
-- zz60-xc-ovr.m4: tighten XC_OVR_ZZ60 macro placement requirements
+- [Per Malmberg brought this change]
-- configure: use XC_CONFIGURE_PREAMBLE early checks
+ darwinssl: fix certificate verification disable on OS X 10.8
+
+ The new way of disabling certificate verification doesn't work on
+ Mountain Lion (OS X 10.8) so we need to use the old way in that version
+ too. I've tested this solution on versions 10.7.5, 10.8, 10.9, 10.10.2
+ and 10.11.
- Some basic checks we make were placed early enough in generated
- configure script when using autoconf 2.5X versions. Newer autoconf
- versions expand these checks much further into the configure script,
- rendering them useless. Using XC_CONFIGURE_PREAMBLE fixes placement
- of early intended checks across all our autoconf supported versions.
+ Closes #802
-- zz40-xc-ovr.m4: provide XC_CONFIGURE_PREAMBLE macro
+- [Cory Benfield brought this change]
-Daniel Stenberg (23 Jan 2013)
-- FAQ: update the SSL lib list and wording in question 2.2
+ http2: Add space between colon and header value
+
+ curl's representation of HTTP/2 responses involves transforming the
+ response to a format that is similar to HTTP/1.1. Prior to this change,
+ curl would do this by separating header names and values with only a
+ colon, without introducing a space after the colon.
+
+ While this is technically a valid way to represent a HTTP/1.1 header
+ block, it is much more common to see a space following the colon. This
+ change introduces that space, to ensure that incautious tools are safely
+ able to parse the header block.
+
+ This also ensures that the difference between the HTTP/1.1 and HTTP/2
+ response layout is as minimal as possible.
+
+ Bug: https://github.com/curl/curl/issues/797
+
+ Closes #798
+ Fixes #797
-Steve Holme (22 Jan 2013)
-- curl_sasl.c: Corrected references to RFC
+Kamil Dudka (12 May 2016)
+- openssl: fix compile-time warning in Curl_ossl_check_cxn()
- The most recent version of the RFC is RFC4422 and not RFC2222 as
- previously documented.
+ ... introduced in curl-7_48_0-293-g2968c83:
+
+ Error: COMPILER_WARNING:
+ lib/vtls/openssl.c: scope_hint: In function ‘Curl_ossl_check_cxn’
+ lib/vtls/openssl.c:767:15: warning: conversion to ‘int’ from ‘ssize_t’
+ may alter its value [-Wconversion]
-- email: Corrected references to SASL RFC
+Jay Satiro (11 May 2016)
+- openssl: stricter connection check function
+
+ - In the case of recv error, limit returning 'connection still in place'
+ to EINPROGRESS, EAGAIN and EWOULDBLOCK.
- The most recent version of the SASL RFC is RFC4422 and not RFC2222 as
- previously documented.
+ This is an improvement on the parent commit which changed the openssl
+ connection check to use recv MSG_PEEK instead of SSL_peek.
+
+ Ref: https://github.com/curl/curl/commit/856baf5#comments
-Daniel Stenberg (22 Jan 2013)
-- [Ulion brought this change]
+Daniel Stenberg (11 May 2016)
+- [Anders Bakken brought this change]
- formpost: support quotes, commas and semicolon in file names
+ TLS: SSL_peek is not a const operation
+
+ Calling SSL_peek can cause bytes to be read from the raw socket which in
+ turn can upset the select machinery that determines whether there's data
+ available on the socket.
+
+ Since Curl_ossl_check_cxn only tries to determine whether the socket is
+ alive and doesn't actually need to see the bytes SSL_peek seems like
+ the wrong function to call.
- - document the double-quote and backslash need be escaped if quoting.
- - libcurl formdata escape double-quote in filename by backslash.
- - curl formparse can parse filename both contains '"' and ',' or ';'.
- - curl now can uploading file with ',' or ';' in filename.
+ We're able to occasionally reproduce a connect timeout due to this
+ bug. What happens is that Curl doesn't know to call SSL_connect again
+ after the peek happens since data is buffered in the SSL buffer and thus
+ select won't fire for this socket.
- Bug: http://curl.haxx.se/bug/view.cgi?id=1171
+ Closes #795
-- memanalyze.pl: handle fopen() of file names with quotes
+Jay Satiro (9 May 2016)
+- [Daniel Stenberg brought this change]
+
+ TLS: move the ALPN/NPN enable bits to the connection
+
+ Only protocols that actually have a protocol registered for ALPN and NPN
+ should try to get that negotiated in the TLS handshake. That is only
+ HTTPS (well, http/1.1 and http/2) right now. Previously ALPN and NPN
+ would wrongly be used in all handshakes if libcurl was built with it
+ enabled.
+
+ Reported-by: Jay Satiro
+
+ Fixes #789
+
+Daniel Stenberg (8 May 2016)
+- libcurl-thread.3: openssl 1.1.0 is safe, and so is boringssl
-Yang Tse (21 Jan 2013)
-- xc-cc-check.m4: re-evaluate exporting and AC_SUBST'ing vars
+- [Antonio Larrosa brought this change]
+
+ connect: fix invalid "Network is unreachable" errors
- Notes:
+ Sometimes, in systems with both ipv4 and ipv6 addresses but where the
+ network doesn't support ipv6, Curl_is_connected returns an error
+ (intermittently) even if the ipv4 socket connects successfully.
- When running a configure script that has nested packages (for example
- libcurl's configure with --enable-ares and c-ares sources embedded in
- curl tree) and AC_CONFIG_SUBDIRS([nested-subdir]) machinery is used to
- automatically run the nested configure script from within the parent
- configure script, it happens that the nested _shell_ script will
- inherit shell variables exported from the parent _shell_ script.
+ This happens because there's a for-loop that iterates on the sockets but
+ the error variable is not resetted when the ipv4 is checked and is ok.
- If for example parent configure script sets and exports LDFLAGS and LIBS
- variables with proper values in order to link either a parent library or
- program with a library which will be configured and built by a nested
- package; It will happen that when the nested configure script runs, the
- nested library does not exist yet and _any_ link-test done in the nested
- configure will fail, such as those that autoconf macros perform in order
- to detect existing compiler and its characteristics, the result is that
- the nested configure script will fail with errors such as:
+ This patch fixes this problem by setting error to 0 when checking the
+ second socket and not having a result yet.
- configure: error: C compiler cannot create executables
+ Fixes #794
+
+Jay Satiro (5 May 2016)
+- FAQ: refer to thread safety guidelines
+
+Daniel Stenberg (3 May 2016)
+- connections: non-HTTP proxies on different ports aren't reused either
- For now, we no longer export variables previously exported here.
+ Reported-by: Oleg Pudeyev and fuchaoqun
- On the other hand, AC_SUBST'ing them is appropriate and even with nested
- packages each package's config.status gets its own package values.
+ Fixes #648
+
+- http: make sure a blank header overrides accept_decoding
- So we reinstate AC_SUBST'ing previously AC_SUBST'ed variables.
+ Reported-by: rcanavan
+ Assisted-by: Isaac Boukris
+ Closes #785
-Daniel Stenberg (21 Jan 2013)
-- FAQ: 3.22 curl -X gives me HTTP problems
+- CHECKSRC.md: clarified, explained the whitelist file
-Yang Tse (21 Jan 2013)
-- xc-cc-check.m4: avoid recursive package automake'ing breakage
+- nroff-scan.pl: verify that references are made with \fI
-- xc-cc-check.m4: mark earlier variables that are to be exported
+- docs: unified man page references to use \fI
-- configure: autotools compatibility fixes - step I
+- TODO: 17.14 --fail without --location should treat 3xx as a failure
- Fix proper macro expansion order across autotools versions for
- C compiler and preprocessor program checks.
+ Closes #727
-Steve Holme (20 Jan 2013)
-- pop3.c: Fixed conditional compilation of the apop response function
+- RELEASE-NOTES: synced with 7987f5cb14d
+
+- [Isaac Boukris brought this change]
+
+ CURLOPT_ACCEPT_ENCODING.3: Follow-up clarification
- Extended the fix from commit 8b15c84ea91e to additionally exclude
- pop3_state_apop_resp() if the CURL_DISABLE_CRYPTO_AUTH flag is
- defined.
+ Mention possible content-length mismatch with sum of bytes reported
+ by write callbacks when auto decoding is enabled.
+
+ See #785
+
+- test1140: run nroff-scan to verify man pages
+
+- nroff-scan.pl: verify the .BR references as well
+
+- CURLOPT_CONV_TO_NETWORK_FUNCTION.3: fix bad man page reference
-Yang Tse (20 Jan 2013)
-- Makefile.inc: fix $(top_srcdir) not allowed in _SOURCES variables
+- CURLOPT_BUFFERSIZE.3: fix reference to CURLOPT_MAX_RECV_SPEED_LARGE
-Daniel Stenberg (19 Jan 2013)
-- formadd: reject trying to read a directory where a file is expected
+- curl_easy_pause.3: fix man page reference
+
+Jay Satiro (1 May 2016)
+- tool_cb_hdr: Fix --remote-header-name with schemeless URL
+
+ - Move the existing scheme check from tool_operate.
+
+ In the case of --remote-header-name we want to parse Content-disposition
+ for a filename, but only if the scheme is http or https. A recent
+ adjustment 0dc4d8e was made to account for schemeless URLs however it's
+ not 100% accurate. To remedy that I've moved the scheme check to the
+ header callback, since at that point the library has already determined
+ the scheme.
- Bug: http://curl.haxx.se/mail/archive-2013-01/0017.html
- Reported by: Ulrich Doehner
+ Bug: https://github.com/curl/curl/issues/760
+ Reported-by: Kai Noda
-- curl_easy_send.3: document return codes
+Daniel Stenberg (1 May 2016)
+- tls: make setting pinnedkey option fail if not supported
- Reported by: Craig Davison
- Bug: http://curl.haxx.se/mail/lib-2013-01/0234.html
+ to make it obvious to users trying to use the feature with TLS backends
+ not supporting it.
+
+ Discussed in #781
+ Reported-by: Travis Burtrum
-- curl_easy_recv.3: document return codes
+- nroff-scan.pl: verifies nroff pages
- Reported by: Craig Davison
- Bug: http://curl.haxx.se/mail/lib-2013-01/0234.html
+ ... not used by any test yet but can be used stand-alone.
+
+- opts: fix broken/bad references
-Steve Holme (19 Jan 2013)
-- email: General code tidy up
+- [Michael Kaufmann brought this change]
+
+ docs: fix bugs in CURLOPT_HTTP_VERSION.3 and CURLOPT_PIPEWAIT.3
- Corrected some function argument definitions to maximize the 80
- character line length limit and be in keeping with the curl
- coding style.
+ Closes #786
-- pop3.c: Fixed a problem with pop3s connections not connecting properly
+- CURLOPT_ACCEPT_ENCODING.3: clarified
- Fixed an issue where Curl_ssl_connect_nonblocking() wouldn't complete
- correctly and the ssldone flag wouldn't be set to true for pop3s based
- connections.
+ As discussed in #785
+
+- curl.1: --mail-rcpt can be used multiple times
- Bug introduced in commit: 4ffb8a6398ed.
+ Reported-by: mgendre
+ Closes #784
-Daniel Stenberg (18 Jan 2013)
-- RELEASE-NOTES: add references to several bugfixes+changes
+- [Karlson2k brought this change]
-Steve Holme (18 Jan 2013)
-- RELEASE-NOTES: Added missing imap fix
+ tests: Use 'pathhelp' for paths conversions in secureserver.pl
- Added missing imap fix as per commit 709b3506cd9b.
+ Closes #675
-Yang Tse (18 Jan 2013)
-- runtests.pl: make VPATH builds find valgrind.supp
+- [Karlson2k brought this change]
-Daniel Stenberg (18 Jan 2013)
-- RELEASE-NOTES: synced with c43127414d89
+ tests: Use 'pathhelp' for paths conversions in sshserver.pl
-- always-multi: always use non-blocking internals
-
- Remove internal separated behavior of the easy vs multi intercace.
- curl_easy_perform() is now using the multi interface itself.
+- [Karlson2k brought this change]
+
+ tests: Use 'pathhelp' for current path in runtests.pl
+
+- [Karlson2k brought this change]
+
+ tests: pathhelp.pm to process paths on Msys/Cygwin
+
+- lib: include curl_printf.h as one of the last headers
- Several minor multi interface quirks and bugs have been fixed in the
- process.
+ curl_printf.h defines printf to curl_mprintf, etc. This can cause
+ problems with external headers which may use
+ __attribute__((format(printf, ...))) markers etc.
- Much help with debugging this has been provided by: Yang Tse
-
-Yang Tse (17 Jan 2013)
-- url.c: fix HTTP CONNECT tunnel establishment upon delayed response
+ To avoid that they cause problems with system includes, we include
+ curl_printf.h after any system headers. That makes the three last
+ headers to always be, and we keep them in this order:
- Fixes initial proxy response being processed by the tunneled protocol
- handler instead of the HTTP wrapper handler. This issue would trigger
- upon delayed CONNECT response from the proxy.
+ curl_printf.h
+ curl_memory.h
+ memdebug.h
- Additionally fixes a multi interface code-path in which connections
- would not time out properly.
+ None of them include system headers, they all do funny #defines.
- This does not fix known bug #39.
+ Reported-by: David Benjamin
- URL: http://curl.haxx.se/mail/lib-2013-01/0191.html
-
-Daniel Stenberg (16 Jan 2013)
-- [Yves Arrouye brought this change]
+ Fixes #743
- --libcurl: fix for non-zero default options
+- memdebug.h: remove inclusion of other headers
- If the default value for an option taking a long as its value is non
- zero, and it is set by zero by a command line option, then that command
- line option is not reflected in --libcurl's output. This is because line
- 520-521 of tool_setopt.c look like:
+ Mostly because they're not needed, because memdebug.h is always included
+ last of all headers so the others already included the correct ones.
- if(!lval)
- skip = TRUE;
-
- An example of a command-line option doing so is the -k option that sets
- CURLOPT_SLL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST to 0L, when the
- defaults are non-zero.
-
-- FTP: reject illegal port numbers in EPSV 229 responses
+ But also, starting now we don't want this to accidentally include any
+ system headers, as the header included _before_ this header may add
+ defines and other fun stuff that we won't want used in system includes.
-Yang Tse (15 Jan 2013)
-- commit bc682cbd follow-up
+- [Jay Satiro brought this change]
-- build: use per-target '_CPPFLAGS' for those currently using default
-
- Automake documents that doing this will make it choose a different name
- for intermediate object files even when sharing source files across
- targets of same Makefile.am.
+ curl -J: make it work even without http:// scheme on URL
- Up to automake 1.13.1 target's intermediate object files were placed
- in the build subdirectory of the target. We depended on this, probably
- undocumented behavior, to achieve same behavior as if a per-target flag
- had been specified when building targets that actually belong to
- different Makefile.am files.
+ It does open up a miniscule risk that one of the other protocols that
+ libcurl could use would send back a Content-Disposition header and then
+ curl would act on it even if not HTTP.
- It seems automake 1.13.2 is going to break behavior mentioned above.
+ A future mitigation for this risk would be to allow the callback to ask
+ libcurl which protocol is being used.
- So, lets use a documented behavior in order to achieve same purpose,
- across automake versions, no matter where automake wishes to place
- intermediate object files.
+ Verified with test 1312
- Our build targets that already were using a per-target '_CFLAGS' or
- '_CPPFLAGS' need no 'fixing', these were already 'fixed'. The only
- Makefile.am or Makefile.in files in libcurl's source tree touched by
- this 'fix' are tests/libtest/Makefile.inc and tests/unit/Makefile.inc.
+ Closes #760
-- tests/libtest/Makefile.inc: sort build targets
+- manpage-scan.pl: also verify the command line option docs
+
+ This script now also scans src/tool_getparam.c, docs/curl.1 and
+ src/tool_help.c and will warn if any of them lists a command line option
+ not mentioned in one of the other places.
-- tests/Makefile.am: remove wildcard usage in EXTRA_DIST
+- curl: show the long option version of -q in the -h list
-Kamil Dudka (15 Jan 2013)
-- nss: fix error messages for CURLE_SSL_{CACERT,CRL}_BADFILE
+- curl: remove "--socks" as "--socks5" turned 8
- Do not use the error messages from NSS for errors not occurring in NSS.
+ In commit 2e42b0a2524 (Jan 2008) we made the option "--socks" deprecated
+ and it has not been documented since. The more explicit socks options
+ (like --socks4 or --socks5) should be used.
-Steve Holme (14 Jan 2013)
-- TODO: Updated following IMAP SASL additions
+- curl.1: document the deprecated --ftp-ssl option
-Yang Tse (14 Jan 2013)
-- configure: fix automake 1.13 compatibility
+- curl: remove --http-request
- Tested with:
+ It was mentioned as deprecated already in commit ae1912cb0d4 from
+ 1999. It has not been documented in this millennium.
+
+- curl: mention --ntlm-wb in -h list
+
+- curl: -h output lacked --proxy-header
+
+- curl.1: document --ntlm-wb
+
+- curl.1: document the long format of -q: --disable
+
+- curl.1: mention the deprecated --krb4 option
+
+- curl.1: document --ftp-ssl-reqd
- buildconf: autoconf version 2.69
- buildconf: autom4te version 2.69
- buildconf: autoheader version 2.69
- buildconf: automake version 1.13.1
- buildconf: aclocal version 1.13.1
- buildconf: libtool version 2.4
- buildconf: GNU m4 version 1.4.16
+ Even if deprecated, document it so that people will find it as old
+ scripts may still use it.
-Daniel Stenberg (13 Jan 2013)
-- BUGS: update bug tracker URL
+- curl: use --telnet-option as documented
- ... and refresh number of lines of code
+ The code said "telnet-options" but no documentation ever said so. It
+ worked fine since the code is fine with a unique match of the first
+ part.
-- Curl_resolver_getsock: fix the function description comment
+- getparam: remove support for --ftpport
- It referred to it by the wrong name and said it returned the wrong value.
+ It has been deprecated and undocumented since commit ad5ead8bed7 (Dec
+ 2003). --ftp-port is the proper long option name.
+
+- curl: make --disable work as long form of -q
- Reported by: Gisle Vanem
+ To make the aliases list reflect reality.
+
+- aliases: remove trailing space from capath string
-Kamil Dudka (11 Jan 2013)
-- nss: clear session cache if a client cert from file is used
+- cmdline parse: only single letter options have single-letter strings
- This commit fixes a regression introduced in 052a08ff.
+ ... moved around options so that parsing the code to find all
+ single-letter options easier.
+
+Jay Satiro (28 Apr 2016)
+- CURLINFO_TLS_SSL_PTR.3: Clarify SSL pointer availability
- NSS caches certs/keys returned by the SSL_GetClientAuthDataHook callback
- and if we connect second time to the same server, the cached cert/key
- pair is used. If we use multiple client certificates for different
- paths on the same server, we need to clear the session cache to force
- NSS to call the hook again. The commit 052a08ff prevented the session
- cache from being cleared if a client certificate from file was used.
+ Bug: https://curl.haxx.se/mail/lib-2016-04/0126.html
+ Reported-by: Bru Rom
+
+Daniel Stenberg (28 Apr 2016)
+- curl_easy_getinfo.3: remove superfluous blank lines
+
+- test1139: verifies libcurl option man page presence
- The condition is now fixed to cover both cases: consssl->client_nickname
- is not NULL if a client certificate from the NSS database is used and
- connssl->obj_clicert is not NULL if a client certificate from file is
- used.
+ - checks that each option has its own man page present
- Review by: Kai Engert
-
-Yang Tse (11 Jan 2013)
-- sockfilt.c: log file descriptor number on read/write error
+ - checks that each option is mentioned in its corresponding index man
+ page
-- [Gisle Vanem brought this change]
+- curl_easy_getinfo.3: added missing mention of CURLINFO_TLS_SESSION
+
+ ... although it is deprecated.
- packages/DOS/common.dj: remove COFF debug info generation
+Jay Satiro (28 Apr 2016)
+- mbedtls: Fix session resume
- gcc on DOS hasn't really supported COFF-debug (-gcoff) on djgpp for a
- long time.
+ This also fixes PolarSSL session resume.
- "Sounds like the COFF debug info generation has bit-rotted in GCC.
- Nothing new here, no other platform uses COFF AFAIK."
+ Prior to this change the TLS session information wasn't properly
+ saved and restored for PolarSSL and mbedTLS.
- So lets drop it too.
+ Bug: https://curl.haxx.se/mail/lib-2016-01/0070.html
+ Reported-by: Thomas Glanzmann
- URL: http://curl.haxx.se/mail/lib-2013-01/0130.html
-
-- curl: ignore SIGPIPE - compilation fix - follow-up
-
-- test servers: handle W32/W64 SIGBREAK with exit_signal_handler
-
-- test servers: fix errno, ERRNO and SOCKERRNO usage for W32/W64
-
-- sockfilt.c: fix some W64 compiler warnings
-
-Daniel Stenberg (9 Jan 2013)
-- [Nick Zitzmann brought this change]
+ Bug: https://curl.haxx.se/mail/lib-2016-04/0095.html
+ Reported-by: Moti Avrahami
- docs: the --with-darwinssl option is available on Apple OSes
+Daniel Stenberg (27 Apr 2016)
+- RELEASE-NOTES: synced with f4298fcc6d2
-Yang Tse (9 Jan 2013)
-- curl: ignore SIGPIPE - compilation fix
+- [Michael Kaufmann brought this change]
-- build: fix circular header inclusion with other packages
+ opts: Fix some syntax errors in example code fragments
- This commit renames lib/setup.h to lib/curl_setup.h and
- renames lib/setup_once.h to lib/curl_setup_once.h.
+ Fixes #779
+
+- openssl: avoid BN_print a NULL bignum
- Removes the need and usage of a header inclusion guard foreign
- to libcurl. [1]
+ OpenSSL 1.1.0-pre seems to return NULL(?) for a whole lot of those
+ numbers so make sure the function handles this.
- Removes the need and presence of an alarming notice we carried
- in old setup_once.h [2]
+ Reported-by: Linus Nordberg
+
+- [Marcel Raad brought this change]
+
+ CONNECT_ONLY: don't close connection on GSS 401/407 reponses
- ----------------------------------------
+ Previously, connections were closed immediately before the user had a
+ chance to extract the socket when the proxy required Negotiate
+ authentication.
- 1 - lib/setup_once.h used __SETUP_ONCE_H macro as header inclusion guard
- up to commit ec691ca3 which changed this to HEADER_CURL_SETUP_ONCE_H,
- this single inclusion guard is enough to ensure that inclusion of
- lib/setup_once.h done from lib/setup.h is only done once.
+ This regression was brought in with the security fix in commit
+ 79b9d5f1a42578f
- Additionally lib/setup.h has always used __SETUP_ONCE_H macro to
- protect inclusion of setup_once.h even after commit ec691ca3, this
- was to avoid a circular header inclusion triggered when building a
- c-ares enabled version with c-ares sources available which also has
- a setup_once.h header. Commit ec691ca3 exposes the real nature of
- __SETUP_ONCE_H usage in lib/setup.h, it is a header inclusion guard
- foreign to libcurl belonging to c-ares's setup_once.h
+ Closes #655
+
+- CURLINFO_TLS_SESSION.3: clarify TLS library support before 7.48.0
+
+- mbedtls.c: silly spellfix of a comment
+
+- KNOWN_BUGS: 1.10 Strips trailing dot from host name
- The renaming this commit does, fixes the circular header inclusion,
- and as such removes the need and usage of a header inclusion guard
- foreign to libcurl. Macro __SETUP_ONCE_H no longer used in libcurl.
+ Closes #716
+
+- test1322: verify stripping of trailing dot from host name
- 2 - Due to the circular interdependency of old lib/setup_once.h and the
- c-ares setup_once.h header, old file lib/setup_once.h has carried
- back from 2006 up to now days an alarming and prominent notice about
- the need of keeping libcurl's and c-ares's setup_once.h in sync.
+ While being debated (in #716) and a violation of RFC 7230 section 5.4,
+ this test verifies that the existing functionality works as intended. It
+ strips the dot from the host name and uses the host without dot
+ throughout the internals.
+
+- multi: accidentally used resolved host name instead of proxy
- Given that this commit fixes the circular interdependency, the need
- and presence of mentioned notice is removed.
+ Regression introduced in 09b5a998
- All mentioned interdependencies come back from now old days when
- the c-ares project lived inside a curl subdirectory. This commit
- removes last traces of such fact.
+ Bug: https://curl.haxx.se/mail/lib-2016-04/0084.html
+ Reported-by: BoBo
-Daniel Stenberg (8 Jan 2013)
-- curl: ignore SIGPIPE
-
- This is a work-around for bug #1180 which is really libcurl's inability
- to ignore SIGPIPE in a few cases. With this work-around at least curl
- won't suffer from it!
+- symbols-in-versions: added new CURLSSLBACKEND_ symbols
+
+- test148: fixed after the --ftp-create-dirs retry change
- Bug: http://curl.haxx.se/bug/view.cgi?id=1180
- Reported by: Lluís Batlle i Rossell
+ follow-up commit to 3c1e84f569 as it made curl try a little harder
-Yang Tse (8 Jan 2013)
-- sockfilt.c: fix some compiler warnings
+- curl.h: clarify curl_sslbackend for openssl clones and renames
-Daniel Stenberg (8 Jan 2013)
-- Revert "configure: update req to 2.59"
+- [Karlson2k brought this change]
+
+ url.c: fixed DEBUGASSERT() for WinSock workaround
- This reverts commit 7a6d8b1b1a8fcc184c36d6b6e741e32250b4bacb.
+ If buffer is allocated, but nothing is received during prereceive
+ stage, than number of processed bytes must be zero.
- URL: http://curl.haxx.se/mail/lib-2013-01/0103.html
+ Closes #778
-Steve Holme (8 Jan 2013)
-- pop3: Added support for non-blocking SSL upgrade
+- KNOWN_BUGS: --interface for ipv6 binds to unusable IP address
- Added support for asynchronous SSL upgrade when using the
- multi-interface.
+ Closes #686 for now.
-Daniel Stenberg (8 Jan 2013)
-- configure: update req to 2.59
-
- I ran the 2.59 version of autoupdate that updates obsoleted configure.ac
- constructs to the 2.59 standard. With a little hands-on fiddling I
- prevented it from ruining the quoting in AS_HELP_STRING() uses.
+- TODO: 1.17 Add support for IRIs
- I subsequently also bumped the required autoconf version to 2.59
- (released in December 2003) as I don't have an older autoconf version
- around to test with and I can't be bothered to install one either...
+ Adding support for IRIs is a mouthful, but is probably interesting at
+ least for areas and countries where the use of such "URLs" are growing
+ popularity.
- Inspired by: Björn Stenberg
- Related blog post: http://cazfi.livejournal.com/195108.html
+ Closes #776
+
+- THANKS-filter: Travis Burtrum
-Steve Holme (7 Jan 2013)
-- imap.c: Small tidy up to add missing comment
+- lib1517: checksrc compliance
-- imap: Added support for sasl digest-md5 authentication
+- [moparisthebest brought this change]
-- imap: Added support for sasl cram-md5 authentication
+ PolarSSL: Implement public key pinning
-Marc Hoersken (7 Jan 2013)
-- tests/server/sockfilt.c: Fixed integer comparison warning
+Patrick Monnerat (22 Apr 2016)
+- os400: upgrade ILE/RPG binding
-- tests/server/sockfilt.c: Include required Win32 headers
+- curl.h: CURLOPT_CONNECT_TO sets a struct slist *, not a string
-Steve Holme (7 Jan 2013)
-- imap: Added support for sasl ntlm authentication
+Daniel Stenberg (22 Apr 2016)
+- contributors.sh: make --releasenotes implied
+
+ It got too annoying to type =)
-- imap: Added support for sasl login authentication
+- RELEASE-NOTES: synced with 3c1e84f5693d8093
-- pop3.c: Fixed default authentication detection
+- curl: make --ftp-create-dirs retry on failure
+
+ The underlying libcurl option used for this feature is
+ CURLOPT_FTP_CREATE_MISSING_DIRS which has the ability to retry the dir
+ creation, but it was never set to do that by the command line tool.
- Fixed an issue where a server may positively respond to the CAPA command
- but not list clear text as a valid authentication type.
+ Now it does.
+
+ Bug: https://curl.haxx.se/mail/archive-2016-04/0021.html
+ Reported-by: John Wanghui
+ Help-by: Leif W
-- curl_sasl.c: Small code tidy up following imap changes
+- [Henrik Gaßmann brought this change]
-- smtp.c: Small code tidy up following imap changes
+ winbuild: add mbedtls support
+
+ Add WITH_MBEDTLS option. Make WITH_SSL, WITH_MBEDTLS and ENABLE_WINSSL
+ options mutual exclusive.
+
+ Closes #606
-- pop3.c: Small code tidy up following imap changes
+- KNOWN_BUGS: fixed "5.6 Improper use of Autoconf cache variables"
+
+ As of commit d9f3b365a3
-- imap: Added support for sasl plain text authentication
+- [Irfan Adilovic brought this change]
-Marc Hoersken (6 Jan 2013)
-- tests/server/sockfilt.c: Fixed support for listening sockets
+ configure: ac_cv_ -> curl_cv_ for write-only vars
+
+ These configure vars are modified in a curl-specific way but never
+ evaluated or loaded from cache, even though they are designated as
+ _cv_. We could either implement proper AC_CACHE_CHECKs for them, or
+ remove them completely.
- This commit fixes support for sockets that are ready to accept
- a new connection and have previously been put into listening mode.
+ Fixes #603 as ac_cv_func_gethostbyname is no longer clobbered, and
+ AC_CHECK_FUNC(gethostbyname...) will no longer spuriously succeed after
+ the first configure run with caching.
- It also includes changes which are the result of investigation
- regarding Windows STDIN. These changes are the preparation for further
- improvements regarding support for reading data from STDIN on Windows.
+ `ac_cv_func_strcasecmp` is curious, see #770.
- Open issue: WaitForMultipleObjectsEx does not support PIPE handles
- which are returned by GetStdHandle while running without a GUI.
+ `eval "ac_cv_func_$func=yes"` can still cause problems as it works in
+ tandem with AC_CHECK_FUNCS and then potentially modifies its result. It
+ would be best to rewrite this test to use a new CURL_CHECK_FUNCS macro,
+ which works the same as AC_CHECK_FUNCS but relies on caching the values
+ of curl_cv_func_* variables, without modifiying ac_cv_func_*.
-- tests/server/sockfilt.c: Set Windows Console to binary mode
+- [Irfan Adilovic brought this change]
-- tests/server/sockfilt.c: Improved log error messages
+ configure: ac_cv_ -> curl_cv_ for r/w vars
- Include error code and parameters in error messages.
+ These configure vars are modified in a curl-specific way and modified by
+ the configure process, but are never loaded from cache, even though they
+ are designated as _cv_. We should implement proper AC_CACHE_CHECKs for
+ them eventually.
-Steve Holme (6 Jan 2013)
-- imap: Introduced the continue response in imap_endofresp()
+- [Irfan Adilovic brought this change]
-- imap: Added support for SASL based authentication mechanism detection
+ configure: ac_cv_func_clock_gettime -> curl_...
- Added support for detecting the supported SASL authentication mechanisms
- via the CAPABILITY command.
+ This variable must not be cached in its current form, as any cached
+ information will prevent the next configure run from determining the
+ correct LIBS needed for the function. Thus, rename prefix `ac_cv_` to
+ just `curl_`.
-Yang Tse (6 Jan 2013)
-- Revert changes relative to lib/*.[ch] recent renaming
-
- This reverts renaming and usage of lib/*.h header files done
- 28-12-2012, reverting 2 commits:
+- [Irfan Adilovic brought this change]
+
+ configure: ac_cv_ -> curl_cv_ for all cached vars
- f871de0... build: make use of 76 lib/*.h renamed files
- ffd8e12... build: rename 76 lib/*.h files
+ This was automated by:
- This also reverts removal of redundant include guard (redundant thanks
- to changes in above commits) done 2-12-2013, reverting 1 commit:
+ sed -b -i -f <(ack -A1 AC_CACHE_CHECK | \
+ ack -o 'ac_cv_.*?\b' | \
+ sort -u | xargs -n1 bash -c \
+ 'echo "s/$0/curl_cv_${0#ac_cv_}/g"') \
+ $(git ls-files)
- c087374... curl_setup.h: remove redundant include guard
+ This only changed the prefix for 16 variables actually checked with
+ AC_CACHE_CHECK.
+
+- openssl: builds with OpenSSL 1.1.0-pre5
- This also reverts renaming and usage of lib/*.c source files done
- 3-12-2013, reverting 3 commits:
+ The RSA, DSA and DH structs are now opaque and require use of new APIs
- 13606bb... build: make use of 93 lib/*.c renamed files
- 5b6e792... build: rename 93 lib/*.c files
- 7d83dff... build: commit 13606bbfde follow-up 1
+ Fixes #763
+
+Steve Holme (20 Apr 2016)
+- url.c: Prefer we don't use explicit NULLs in conditions
- Start of related discussion thread:
+ Fixed commit fa5fa65a30 to not use NULLs in if condition.
+
+Daniel Stenberg (20 Apr 2016)
+- [Isaac Boukris brought this change]
+
+ NTLM: check for NULL pointer before deferencing
- http://curl.haxx.se/mail/lib-2013-01/0012.html
+ At ConnectionExists, both check->proxyuser and check->proxypasswd
+ could be NULL, so make sure to check first.
- Asking for confirmation on pushing this revertion commit:
+ Fixes #765
+
+- [Karlson2k brought this change]
+
+ tests: added test1517
- http://curl.haxx.se/mail/lib-2013-01/0048.html
+ ... for checking ability to receive full HTTP response when POST request
+ is used with slow read callback function.
- Confirmation summary:
+ This test checks for bug #657 and verifies the work-around from
+ 72d5e144fbc6.
- http://curl.haxx.se/mail/lib-2013-01/0079.html
+ Closes #720
+
+- [Karlson2k brought this change]
+
+ sendf.c: added ability to call recv() before send() as workaround
- NOTICE: The list of 2 files that have been modified by other
- intermixed commits, while renamed, and also by at least one
- of the 6 commits this one reverts follows below. These 2 files
- will exhibit a hole in history unless git's '--follow' option
- is used when viewing logs.
+ WinSock destroys recv() buffer if send() is failed. As result - server
+ response may be lost if server sent it while curl is still sending
+ request. This behavior noticeable on HTTP server short replies if
+ libcurl use several send() for request (usually for POST request).
+ To workaround this problem, libcurl use recv() before every send() and
+ keeps received data in intermediate buffer for further processing.
- lib/curl_imap.h
- lib/curl_smtp.h
+ Fixes: #657
+ Closes: #668
-Daniel Stenberg (6 Jan 2013)
-- mk-ca-bundle.1: convert syntax to what's used elsewhere
+Kamil Dudka (19 Apr 2016)
+- connect: make sure that rc is initialized in singleipconnect()
+
+ This commit fixes a Clang warning introduced in curl-7_48_0-190-g8f72b13:
- ... mostly to make sure roffit works better on it, but also to make our
- man pages use a more unified style.
+ Error: CLANG_WARNING:
+ lib/connect.c:1120:11: warning: The right operand of '==' is a garbage value
+ 1118| }
+ 1119|
+ 1120|-> if(-1 == rc)
+ 1121| error = SOCKERRNO;
+ 1122| }
+
+Daniel Stenberg (19 Apr 2016)
+- make/checksrc: use $srcdir, not $top_srcdir
+
+- src/checksrc.whitelist: removed
+
+- tool_operate: switch to inline checksrc ignore
-- mk-ca-bundle.1: mention new -f, fix outputfile output
+- lib/checksrc.whitelist: not needed anymore
- also edited a few sentences to become more verbose
+ ... as checksrc now skips comments
-- mk-ca-bundle: add -f, support passing to stdout and more
+- vtls.h: remove a space before semicolon
- 1. When the downloaded data file from Mozilla is current, but the output
- bundle does not exist: continue processing to create the bundle. The
- goal is to have the output file - not just download the latest input.
+ ... that the new checksrc detected
+
+- darwinssl: removed commented out code
+
+- http_chunks: removed checksrc disable
- 2. added -f option to force re-processing the file. Useful for
- debugging/testing the process.
+ ... since checksrc now skips comments
+
+- imap: inlined checksrc disable instead of whitelist edit
+
+- checksrc: taught to skip comments
- 3. added support for output to '-' (stdout), allowing the output to be
- piped.
+ ... but output non-stripped version of the line, even if that then can
+ make the script identify the wrong position in the line at
+ times. Showing the line stripped (ie without comments) is just too
+ surprising.
+
+- opts/Makefile.am: list all docs file one by one
- 4. All progress and error messages go to STDERR rather than STDOUT (3)
+ ... to make it easier to add lines in patches that won't just break all
+ other patches trying to add lines too.
+
+- curl_easy_setopt.3: mention CURLOPT_TCP_FASTOPEN
+
+- RELEASE-NOTES: synced with 03de4e4b219
- 5. The script opened and closed the output file many times
- unnecessarily. It now opens it once, does the output and closes it.
+ (since we just merged two major features)
+
+- [Alessandro Ghedini brought this change]
+
+ connect: implement TCP Fast Open for Linux
- 6. Backup of the input files happens after successful processing, not
- before.
+ Closes #660
+
+- [Alessandro Ghedini brought this change]
+
+ tool: add --tcp-fastopen option
+
+- [Alessandro Ghedini brought this change]
+
+ connect: implement TCP Fast Open for OS X
+
+- [Alessandro Ghedini brought this change]
+
+ url: add CURLOPT_TCP_FASTOPEN option
+
+- checksrc: pass on -D so the whitelists are found correctly
+
+- configure: remove check for libresolve
- 7. The output is written to a temporary file, and renamed to the
- requested name after backup - this greatly reduces the window where the
- file can be seen partially written.
+ 'strncasecmp' was once provided by libresolv (no trailing e) for SunOS,
+ but this check is broken and most likely adds nothing useful. Removing
+ now.
- 8. all die calls have a \n at the end to suppress perl's traceback - the
- traceback isn't useful to end users.
+ Reported-by: Irfan Adilovic
- Patch: http://curl.haxx.se/mail/lib-2013-01/0045.html
+ Discussed in #770
-Yang Tse (5 Jan 2013)
-- imap test server: fix typo in name of SELECT_imap() sub definition
+- scripts/make: use $(EXEEXT) for executables
- IMAP test server breaking typo introduced with commit b708a522a1
+ Reported-by: bodop
+
+ Fixes #771
+
+- includes: avoid duplicate memory callback typdefs even harder
-Steve Holme (4 Jan 2013)
-- imap test server: Added support for the CAPABILITY command
-
- Added support for the CAPABILITY command in preparation of upcoming
- changes.
-
-Daniel Stenberg (3 Jan 2013)
-- writeout: -w now supports remote_ip/port and local_ip/port
-
- Added mention to the curl.1 man page.
-
- Test case 1223 verifies remote_ip/port.
-
-Yang Tse (3 Jan 2013)
-- test 1222: 8 chars object name generation && test 1221: adjustments
-
-Daniel Stenberg (3 Jan 2013)
-- INTERNALS: remove "footnote" never used
-
-Yang Tse (3 Jan 2013)
-- build: commit 13606bbfde follow-up 1
-
-Daniel Stenberg (3 Jan 2013)
-- FAQ: Can I write a server with libcurl?
-
-Yang Tse (3 Jan 2013)
-- build: rename 93 lib/*.c files
-
- 93 lib/*.c source files renamed to use our standard naming scheme.
-
- This commit only does the file renaming.
-
- ----------------------------------------
-
- renamed: lib/amigaos.c -> lib/curl_amigaos.c
- renamed: lib/asyn-ares.c -> lib/curl_asyn_ares.c
- renamed: lib/asyn-thread.c -> lib/curl_asyn_thread.c
- renamed: lib/axtls.c -> lib/curl_axtls.c
- renamed: lib/base64.c -> lib/curl_base64.c
- renamed: lib/bundles.c -> lib/curl_bundles.c
- renamed: lib/conncache.c -> lib/curl_conncache.c
- renamed: lib/connect.c -> lib/curl_connect.c
- renamed: lib/content_encoding.c -> lib/curl_content_encoding.c
- renamed: lib/cookie.c -> lib/curl_cookie.c
- renamed: lib/cyassl.c -> lib/curl_cyassl.c
- renamed: lib/dict.c -> lib/curl_dict.c
- renamed: lib/easy.c -> lib/curl_easy.c
- renamed: lib/escape.c -> lib/curl_escape.c
- renamed: lib/file.c -> lib/curl_file.c
- renamed: lib/fileinfo.c -> lib/curl_fileinfo.c
- renamed: lib/formdata.c -> lib/curl_formdata.c
- renamed: lib/ftp.c -> lib/curl_ftp.c
- renamed: lib/ftplistparser.c -> lib/curl_ftplistparser.c
- renamed: lib/getenv.c -> lib/curl_getenv.c
- renamed: lib/getinfo.c -> lib/curl_getinfo.c
- renamed: lib/gopher.c -> lib/curl_gopher.c
- renamed: lib/gtls.c -> lib/curl_gtls.c
- renamed: lib/hash.c -> lib/curl_hash.c
- renamed: lib/hmac.c -> lib/curl_hmac.c
- renamed: lib/hostasyn.c -> lib/curl_hostasyn.c
- renamed: lib/hostcheck.c -> lib/curl_hostcheck.c
- renamed: lib/hostip.c -> lib/curl_hostip.c
- renamed: lib/hostip4.c -> lib/curl_hostip4.c
- renamed: lib/hostip6.c -> lib/curl_hostip6.c
- renamed: lib/hostsyn.c -> lib/curl_hostsyn.c
- renamed: lib/http.c -> lib/curl_http.c
- renamed: lib/http_chunks.c -> lib/curl_http_chunks.c
- renamed: lib/http_digest.c -> lib/curl_http_digest.c
- renamed: lib/http_negotiate.c -> lib/curl_http_negotiate.c
- renamed: lib/http_negotiate_sspi.c -> lib/curl_http_negotiate_sspi.c
- renamed: lib/http_proxy.c -> lib/curl_http_proxy.c
- renamed: lib/idn_win32.c -> lib/curl_idn_win32.c
- renamed: lib/if2ip.c -> lib/curl_if2ip.c
- renamed: lib/imap.c -> lib/curl_imap.c
- renamed: lib/inet_ntop.c -> lib/curl_inet_ntop.c
- renamed: lib/inet_pton.c -> lib/curl_inet_pton.c
- renamed: lib/krb4.c -> lib/curl_krb4.c
- renamed: lib/krb5.c -> lib/curl_krb5.c
- renamed: lib/ldap.c -> lib/curl_ldap.c
- renamed: lib/llist.c -> lib/curl_llist.c
- renamed: lib/md4.c -> lib/curl_md4.c
- renamed: lib/md5.c -> lib/curl_md5.c
- renamed: lib/memdebug.c -> lib/curl_memdebug.c
- renamed: lib/mprintf.c -> lib/curl_mprintf.c
- renamed: lib/multi.c -> lib/curl_multi.c
- renamed: lib/netrc.c -> lib/curl_netrc.c
- renamed: lib/non-ascii.c -> lib/curl_non_ascii.c
- renamed: lib/curl_non-ascii.h -> lib/curl_non_ascii.h
- renamed: lib/nonblock.c -> lib/curl_nonblock.c
- renamed: lib/nss.c -> lib/curl_nss.c
- renamed: lib/nwlib.c -> lib/curl_nwlib.c
- renamed: lib/nwos.c -> lib/curl_nwos.c
- renamed: lib/openldap.c -> lib/curl_openldap.c
- renamed: lib/parsedate.c -> lib/curl_parsedate.c
- renamed: lib/pingpong.c -> lib/curl_pingpong.c
- renamed: lib/polarssl.c -> lib/curl_polarssl.c
- renamed: lib/pop3.c -> lib/curl_pop3.c
- renamed: lib/progress.c -> lib/curl_progress.c
- renamed: lib/qssl.c -> lib/curl_qssl.c
- renamed: lib/rawstr.c -> lib/curl_rawstr.c
- renamed: lib/rtsp.c -> lib/curl_rtsp.c
- renamed: lib/security.c -> lib/curl_security.c
- renamed: lib/select.c -> lib/curl_select.c
- renamed: lib/sendf.c -> lib/curl_sendf.c
- renamed: lib/share.c -> lib/curl_share.c
- renamed: lib/slist.c -> lib/curl_slist.c
- renamed: lib/smtp.c -> lib/curl_smtp.c
- renamed: lib/socks.c -> lib/curl_socks.c
- renamed: lib/socks_gssapi.c -> lib/curl_socks_gssapi.c
- renamed: lib/socks_sspi.c -> lib/curl_socks_sspi.c
- renamed: lib/speedcheck.c -> lib/curl_speedcheck.c
- renamed: lib/splay.c -> lib/curl_splay.c
- renamed: lib/ssh.c -> lib/curl_ssh.c
- renamed: lib/sslgen.c -> lib/curl_sslgen.c
- renamed: lib/ssluse.c -> lib/curl_ssluse.c
- renamed: lib/strdup.c -> lib/curl_strdup.c
- renamed: lib/strequal.c -> lib/curl_strequal.c
- renamed: lib/strerror.c -> lib/curl_strerror.c
- renamed: lib/strtok.c -> lib/curl_strtok.c
- renamed: lib/strtoofft.c -> lib/curl_strtoofft.c
- renamed: lib/telnet.c -> lib/curl_telnet.c
- renamed: lib/tftp.c -> lib/curl_tftp.c
- renamed: lib/timeval.c -> lib/curl_timeval.c
- renamed: lib/transfer.c -> lib/curl_transfer.c
- renamed: lib/url.c -> lib/curl_url.c
- renamed: lib/version.c -> lib/curl_version.c
- renamed: lib/warnless.c -> lib/curl_warnless.c
- renamed: lib/wildcard.c -> lib/curl_wildcard.c
-
- ----------------------------------------
-
-- build: make use of 93 lib/*.c renamed files
-
- 93 *.c source files renamed to use our standard naming scheme.
-
- This change affects 77 files in libcurl's source tree.
-
-Daniel Stenberg (3 Jan 2013)
-- INSTALL: unify the SSL library texts
-
- Make them smaller and more similar for each separate SSL library
- supported by the configure build
-
-Yang Tse (2 Jan 2013)
-- curl_setup.h: remove redundant include guard
-
-- build and tests: curl_10char_object_name() shell function
-
- lib/objnames.inc provides definition of curl_10char_object_name() shell
- function. The intended purpose of this function is to transliterate a
- (*.c) source file name that may be longer than 10 characters, or not,
- into a string with at most 10 characters which may be used as an OS/400
- object name.
-
- Test case 1221 does unit testng of this function and also verifies
- that it is possible to generate distinct short object names for all
- curl and libcurl *.c source file names.
-
- lib/objnames-test.sh is the shell script used for test case 1221.
-
- tests/runtests.pl modified to accept shell script test cases.
+- checksrc/makefile.am: use $top_srcdir to find source files
- More details inside lib/objnames.inc and lib/objnames-test.sh
+ ... to properly support out of source tree builds.
+
+- RELEASE-NOTES: synced with 26ec93dd6aeba8dfb5
+
+- opts: fix option references missing (section)
-- configure.ac: replace AM_CONFIG_HEADER with AC_CONFIG_HEADERS
+- [Michael Kaufmann brought this change]
+
+ news: CURLOPT_CONNECT_TO and --connect-to
- automake 1.13 errors if AM_CONFIG_HEADER is used in configure script.
- automake 1.13 no longer autoupdates AM_CONFIG_HEADER to
- AC_CONFIG_HEADERS, thing which automake has been doing since automake
- version 1.7
+ Makes curl connect to the given host+port instead of the host+port found
+ in the URL.
+
+- makefile.vc6: use d suffix on debug object
- Given that our first automake supported version is automake 1.7,
- simply replacing AM_CONFIG_HEADER usage with AC_CONFIG_HEADERS seems
- enough to yet support same automake versions.
+ To allow both release and debug builds in parallel.
- Dave Reisner reported issue with 1.13 and provided patch.
+ Reported-by: Rod Widdowson
- http://curl.haxx.se/mail/lib-2012-12/0246.html
+ Fixes #769
-- curl-override.m4: provide AC_CONFIG_MACRO_DIR definition conditionally
+Jay Satiro (12 Apr 2016)
+- http2: Use size_t type for data drain count
- Provide a 'traceable' AC_CONFIG_MACRO_DIR definition only when using
- an autoconf version that does not provide it, instead of what we were
- doing up to now of providing and overriding AC_CONFIG_MACRO_DIR for
- all autoconf versions.
-
-Steve Holme (30 Dec 2012)
-- imap.c: Minor follow up tidy up
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- imap: Code tidy up prior to adding support for the CAPABILITY command
+- http2: Improve header parsing
- * Changing the order of the state machine to represent the order in
- which commands are sent to the server.
+ - Error if a header line is larger than supported.
- * Reworking the imap_endofresp() function as the FETCH response doesn't
- include the command id and shouldn't be part of the length comparison
- that takes into account the id string.
-
-- pop3_doing: Applied debug info message when function fails
+ - Warn if cumulative header line length may be larger than supported.
- Applied the same debug message as used in smtp_doing() and imap_doing()
- when pop3_multi_statemach() fails.
-
-- imap_doing: don't call imap_dophase_done() if already failed
+ - Allow spaces when parsing the path component.
+
+ - Make sure each header line ends in \r\n. This fixes an out of bounds.
+
+ - Disallow header continuation lines until we decide what to do.
- Applied the POP3 fix from commit 2897ce7dc2e1 so imap_dophase_done()
- isn't called if imap_multi_statemach() fails.
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- smtp_doing: don't call smtp_dophase_done() if already failed
+- http2: Add Curl_http2_strerror for HTTP/2 error codes
- Applied the POP3 fix from commit 2897ce7dc2e1 so smtp_dophase_done()
- isn't called if smtp_multi_statemach() fails.
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-Yang Tse (29 Dec 2012)
-- examples/certinfo.c: fix compiler warning
+- [Tatsuhiro Tsujikawa brought this change]
-Steve Holme (29 Dec 2012)
-- pop3.c: Removed unnecessary POP3_STOP state changes
+ http2: Don't increment drain when one header field is received
- Removed unnecessary state changes in pop3_state_starttls_resp()
- following previous fix in IMAP module.
-
-- smtp.c: Added extra comments around SMTP_STOP state change
+ Sicne we write header field in temporary location, not in the memory
+ that upper layer provides, incrementing drain should not happen.
- Provided extra comments in the SMTP module following previous IMAP fix.
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
+
+- [Tatsuhiro Tsujikawa brought this change]
-- imap.c: Fixed bad state error when logging in with invalid credentials
+ http2: Ensure that http2_handle_stream_close is called
+
+ This commit ensures that streams which was closed in on_stream_close
+ callback gets passed to http2_handle_stream_close. Previously, this
+ might not happen. To achieve this, we increment drain property to
+ forcibly call recv function for that stream.
- Fixed a problem with the state machine when attempting to log in with
- invalid credentials. The server would report login failure but libcurl
- would not read the response due to inappropriate IMAP_STOP states being
- set after the login was sent.
+ To more accurately check that we have no pending event before shutting
+ down HTTP/2 session, we sum up drain property into
+ http_conn.drain_total. We only shutdown session if that value is 0.
+
+ With this commit, when stream was closed before reading response
+ header fields, error code CURLE_HTTP2_STREAM is returned even if
+ HTTP/2 level error is NO_ERROR. This signals the upper layer that
+ stream was closed by error just like TCP connection close in HTTP/1.
+
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-Yang Tse (29 Dec 2012)
-- imap.c: remove trailing whitespace
+- [Tatsuhiro Tsujikawa brought this change]
-Steve Holme (28 Dec 2012)
-- imap.c: Code tidy up - Part 2
-
-- imap.c: Code tidy up - Part 1
-
- Applied some of the comment and layout changes that had already been
- applied to the pop3 and smtp code over the last 6 to 9 months.
-
- This is in preparation of adding SASL based authentication.
-
-- pop3.c: Minor code tidy up
-
- Minor tidy up of comments and layout prior to next part of imap work.
-
-- smtp: Minor code tidy up
-
- Minor tidy up of comments and layout prior to next part of imap work.
-
-- curl_imap.h: Tidy up of comments to be more readable
-
-- imap.c: Code tidy up renaming imapsendf() to imap_sendf()
+ http2: Process paused data first before tear down http2 session
- Renamed imapsendf() to imap_sendf() to be more in keeping with the
- other imap functions as well as Curl_pp_sendf() that it replaces.
-
-Yang Tse (28 Dec 2012)
-- build: rename 76 lib/*.h files
-
- 76 private header files renamed to use our standard naming scheme.
-
- This commit only does the file renaming.
-
- ----------------------------------------
+ This commit ensures that data from network are processed before HTTP/2
+ session is terminated. This is achieved by pausing nghttp2 whenever
+ different stream than current easy handle receives data.
- renamed: amigaos.h -> curl_amigaos.h
- renamed: arpa_telnet.h -> curl_arpa_telnet.h
- renamed: asyn.h -> curl_asyn.h
- renamed: axtls.h -> curl_axtls.h
- renamed: bundles.h -> curl_bundles.h
- renamed: conncache.h -> curl_conncache.h
- renamed: connect.h -> curl_connect.h
- renamed: content_encoding.h -> curl_content_encoding.h
- renamed: cookie.h -> curl_cookie.h
- renamed: cyassl.h -> curl_cyassl.h
- renamed: dict.h -> curl_dict.h
- renamed: easyif.h -> curl_easyif.h
- renamed: escape.h -> curl_escape.h
- renamed: file.h -> curl_file.h
- renamed: fileinfo.h -> curl_fileinfo.h
- renamed: formdata.h -> curl_formdata.h
- renamed: ftp.h -> curl_ftp.h
- renamed: ftplistparser.h -> curl_ftplistparser.h
- renamed: getinfo.h -> curl_getinfo.h
- renamed: gopher.h -> curl_gopher.h
- renamed: gtls.h -> curl_gtls.h
- renamed: hash.h -> curl_hash.h
- renamed: hostcheck.h -> curl_hostcheck.h
- renamed: hostip.h -> curl_hostip.h
- renamed: http.h -> curl_http.h
- renamed: http_chunks.h -> curl_http_chunks.h
- renamed: http_digest.h -> curl_http_digest.h
- renamed: http_negotiate.h -> curl_http_negotiate.h
- renamed: http_proxy.h -> curl_http_proxy.h
- renamed: if2ip.h -> curl_if2ip.h
- renamed: imap.h -> curl_imap.h
- renamed: inet_ntop.h -> curl_inet_ntop.h
- renamed: inet_pton.h -> curl_inet_pton.h
- renamed: krb4.h -> curl_krb4.h
- renamed: llist.h -> curl_llist.h
- renamed: memdebug.h -> curl_memdebug.h
- renamed: multiif.h -> curl_multiif.h
- renamed: netrc.h -> curl_netrc.h
- renamed: non-ascii.h -> curl_non-ascii.h
- renamed: nonblock.h -> curl_nonblock.h
- renamed: nssg.h -> curl_nssg.h
- renamed: parsedate.h -> curl_parsedate.h
- renamed: pingpong.h -> curl_pingpong.h
- renamed: polarssl.h -> curl_polarssl.h
- renamed: pop3.h -> curl_pop3.h
- renamed: progress.h -> curl_progress.h
- renamed: qssl.h -> curl_qssl.h
- renamed: rawstr.h -> curl_rawstr.h
- renamed: rtsp.h -> curl_rtsp.h
- renamed: select.h -> curl_select.h
- renamed: sendf.h -> curl_sendf.h
- renamed: setup.h -> curl_setup.h
- renamed: setup_once.h -> curl_setup_once.h
- renamed: share.h -> curl_share.h
- renamed: slist.h -> curl_slist.h
- renamed: smtp.h -> curl_smtp.h
- renamed: sockaddr.h -> curl_sockaddr.h
- renamed: socks.h -> curl_socks.h
- renamed: speedcheck.h -> curl_speedcheck.h
- renamed: splay.h -> curl_splay.h
- renamed: ssh.h -> curl_ssh.h
- renamed: sslgen.h -> curl_sslgen.h
- renamed: ssluse.h -> curl_ssluse.h
- renamed: strdup.h -> curl_strdup.h
- renamed: strequal.h -> curl_strequal.h
- renamed: strerror.h -> curl_strerror.h
- renamed: strtok.h -> curl_strtok.h
- renamed: strtoofft.h -> curl_strtoofft.h
- renamed: telnet.h -> curl_telnet.h
- renamed: tftp.h -> curl_tftp.h
- renamed: timeval.h -> curl_timeval.h
- renamed: transfer.h -> curl_transfer.h
- renamed: url.h -> curl_url.h
- renamed: urldata.h -> curl_urldata.h
- renamed: warnless.h -> curl_warnless.h
- renamed: wildcard.h -> curl_wildcard.h
+ This commit also fixes the bug that sometimes processing hangs when
+ multiple HTTP/2 streams are multiplexed.
- ----------------------------------------
-
-- build: make use of 76 lib/*.h renamed files
-
- 76 private header files renamed to use our standard naming scheme.
-
- This change affects 322 files in libcurl's source tree.
-
-- lib/*.h: use our standard naming scheme for header inclusion guards
-
-Steve Holme (28 Dec 2012)
-- imsp.c: Fixed usernames and passwords that contain escape characters
-
- Fixed a problem with sending usernames and passwords that contain
- backslash, quotation mark and space characters.
-
-Daniel Stenberg (27 Dec 2012)
-- curl.1: extend the -X, --request description
-
-- RELEASE-NOTES: synced with e3ed2b82e6
-
-- [Nick Zitzmann brought this change]
-
- darwinssl: Fixed inability to disable peer verification
-
- ... on Snow Leopard and Lion
-
- Snow Leopard introduced the SSLSetSessionOption() function, but it
- doesn't disable peer verification as expected on Snow Leopard or
- Lion (it works as expected in Mountain Lion). So we now use sysctl()
- to detect whether or not the user is using Snow Leopard or Lion,
- and if that's the case, then we now use the deprecated
- SSLSetEnableCertVerify() function instead to disable peer verification.
-
-Yang Tse (26 Dec 2012)
-- curl tool: rename hugehelp files to tool_hugehelp
-
-- curl tool: renaming hugehelp files to tool_hugehelp
-
-- sockfilt.c: commit b44da5a82a follow-up 2
-
-- sockfilt.c: commit b44da5a82a follow-up
-
-- sockfilt.c: fix some compiler warnings
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-- curl_multi_remove_handle: commit 0aabfd9963 follow-up
+- [Tatsuhiro Tsujikawa brought this change]
-Daniel Stenberg (25 Dec 2012)
-- lib556: enable VERBOSE to ease debugging on failures
+ http2: Check session closure early in http2_recv
+
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-Marc Hoersken (25 Dec 2012)
-- socklift.c: Quick fix to re-add missing code
+- [Tatsuhiro Tsujikawa brought this change]
-- socklift.c: Added select_ws function to support Windows
+ http2: Add handling stream level error
+
+ Previously, when a stream was closed with other than NGHTTP2_NO_ERROR
+ by RST_STREAM, underlying TCP connection was dropped. This is
+ undesirable since there may be other streams multiplexed and they are
+ very much fine. This change introduce new error code
+ CURLE_HTTP2_STREAM, which indicates stream error that only affects the
+ relevant stream, and connection should be kept open. The existing
+ CURLE_HTTP2 means connection error in general.
- WinSock select() does not support standard file descriptors,
- it can only check SOCKETs. The following function is an attempt
- to create a select() function with support for other handles.
+ Ref: https://github.com/curl/curl/issues/659
+ Ref: https://github.com/curl/curl/pull/663
-Yang Tse (25 Dec 2012)
-- Enable tests 1503, 1504 and 1505
+Daniel Stenberg (11 Apr 2016)
+- http2: drain the socket better...
+
+ ... but ignore EAGAIN if the stream has ended so that we don't end up in
+ a loop. This is a follow-up to c8ab613 in order to avoid the problem
+ d261652 was made to fix.
+
+ Reported-by: Jay Satiro
+ Clues-provided-by: Tatsuhiro Tsujikawa
+
+ Discussed in #750
-- curl_multi_remove_handle: fix memory leak triggered with CURLOPT_RESOLVE
+- KNOWN_BUGS: added info for "Hangs with PolarSSL"
-- Curl_hash_clean: OOM handling fix
+- KNOWN_BUGS: 1.9 HTTP/2 frames while in the connection pool kill reuse
+
+ Closes #750
-- test 1504 and 1505: same as 1502 but with different cleanup sequences
+- build: include scripts/ in the dist
-Daniel Stenberg (24 Dec 2012)
-- Curl_conncache_foreach: allow callback to break loop
+Steve Holme (9 Apr 2016)
+- CURLOPT_SOCKS5_GSSAPI_SERVICE: Merged with CURLOPT_PROXY_SERVICE_NAME
- ... and have it take a proper 'struct connectdata *' as first argument
-
-- pop3_doing: don't call pop3_dophase_done() if already failed
+ As these two options provide identical functionality, the former for
+ SOCK5 proxies and the latter for HTTP proxies, merged the two options
+ together.
- ... it also clobbered the 'result' return value so that it wouldn't
- return the error back to the parent function properly, which broke test
- 809 when run with 'multi-always'.
+ As such CURLOPT_SOCKS5_GSSAPI_SERVICE is marked as deprecated as of
+ 7.49.0.
-Yang Tse (23 Dec 2012)
-- test 1503: same as 1502 but with a different cleanup sequence
+- urldata: Use bool for socks5_gssapi_nec as it is a flag
+
+ This value is set to TRUE or FALSE so should be a bool and not a long.
-- test 1502: OOM handling fixes
+- url: Ternary operator code style changes
-- curl_multi_wait: OOM handling fix
+- CODE_STYLE: Added ternary operator example to 'Space around operators'
+
+ Following conversation on the libcurl mailing list.
-- [Daniel Stenberg brought this change]
+- sasl: Fixed compilation errors from commit 9d89a0387
+
+ ...when GSS-API or Windows SSPI are not used.
- curl_multi_wait: avoid an unnecessary memory allocation
+- url: Corrected comments following 9d89a0387
-- runtests.pl: prepend $srcdir to HTTPTLS server config files path
+- docs: Added clarification following commit 9d89a0387
-- multi.c: OOM handling fix
+- Makefile: Fixed echo of checksrc check
-- lib543.c: OOM handling fixes
+- checksrc: Fix issue with the autobuilds not picking up the whitelist
-- configure: add internal sanity check (warn only) on vars for makefiles
+- checksrc: Added missing vauth and vtls directories
-Daniel Stenberg (21 Dec 2012)
-- SCP: relative path didn't work
+- ftp/imap/pop3/smtp: Allow the service name to be overridden
- When prefixing a path with /~/ it is supposed to be used relative to the
- user's home directory but it didn't work. Now we cut off the entire
- three byte sequenct "/~/" which seems to be how OpenSSH does it.
+ Allow the service name to be overridden for DIGIST-MD5 and Kerberos 5
+ authentication in FTP, IMAP, POP3 and SMTP.
+
+- http_negotiate: Calculate service name and proxy service name locally
- Bug: http://curl.haxx.se/bug/view.cgi?id=1173
- Reported by: Balaji Parasuram
+ Calculate the service name and proxy service names locally, rather than
+ in url.c which will allow for us to support overriding the service name
+ for other protocols such as FTP, IMAP, POP3 and SMTP.
-Yang Tse (21 Dec 2012)
-- configure: LIBMETALINK_CFLAGS actually is LIBMETALINK_CPPFLAGS
+- ROADMAP: Updated following the move of the authentication code
-- configure: add minimal sanity check on user provided CFLAGS and CPPFLAGS
+Patrick Monnerat (8 Apr 2016)
+- KNOWN_BUGS: openldap hangs. TODO: binary SASL.
-- bundles connection caching: some out of memory handling fixes
+Daniel Stenberg (8 Apr 2016)
+- KNOWN_BUGS: 5.6 Improper use of Autoconf cache variables
+
+ Closes #603
-- libntlmconnect.c: fix compiler warnings and OOM handling
+- KNOWN_BUGS: 11.2 error buffer not set...
+
+ Closes #544
-- configure.ac: clear local test intended variables before use
+- KNOWN_BUGS: 11.1 Curl leaks .onion hostnames in DNS
+
+ Closes #543
-- VC6 IDE: link with advapi32.lib when using WIN32 crypto API (md5.c)
+- KNOWN_BUGS: 1.8 DNS timing is wrong for HTTP redirects
+
+ Closes #522
-- curl-functions.m4: improve gethostname arg 2 data type check
+- TODO: HTTP/2 "prior knowledge" is implemented!
-- setup_once.h: HP-UX specific 'bool', 'false' and 'true' definitions.
+- [Damien Vielpeau brought this change]
+
+ mbedtls: fix MBEDTLS_DEBUG builds
+
+- mbedtls: implement and provide *_data_pending()
+
+ ... as otherwise we might get stuck thinking there's no more data to
+ handle.
- Also reverts commit f254c59dc7
+ Reported-by: Damien Vielpeau
+
+ Fixes #737
-- configure: check if compiler halts on function prototype mismatch
+- mbedtls: follow-up for the previous commit
-- warnless.c: fix compiler warnings
+- mbedtls.c: name space pollution fix, Use 'Curl_'
-- curl-functions.m4: add gethostname arg 2 data type check and definition
+- mbedtls.c: changed private prefix to mbed_
+
+ mbedtls_ is the prefix used by the mbedTLS library itself so we should
+ avoid using that for our private functions.
-Daniel Stenberg (14 Dec 2012)
-- [Nick Zitzmann brought this change]
+- mbedtls.h: fix compiler warnings
- darwinssl: Fix implicit conversion compiler warnings
+- Revert "winbuild: trying to set some files eol=crlf for git"
+
+ This reverts commit 9c08b4f1e7eced5a4d3782a3e0daa484c9d77d21.
+
+ Didn't help. Caused problems.
- The Clang compiler found a few implicit conversion problems that have
- now been fixed.
+ Fixes #756
+
+- curl.1: use example.com more
+
+ Make (most) example snippets use the example.com domain instead of the
+ random ones picked and used before. Some of those were probably
+ legitimate sites and some not. example.com is designed for this purpose.
+
+- [Michael Kaufmann brought this change]
-Yang Tse (14 Dec 2012)
-- setup_once.h: HP-UX <sys/socket.h> issue workaround
+ HTTP2: Add a space character after the status code
- Issue: When building a 32bit target with large file support HP-UX
- <sys/socket.h> header file may simultaneously provide two different
- sets of declarations for sendfile and sendpath functions, one with
- static and another with external linkage. Given that we do not use
- mentioned functions we really don't care which linkage is the
- appropriate one, but on the other hand, the double declaration emmits
- warnings when using the HP-UX compiler and errors when using modern
- gcc versions resulting in fatal compilation errors.
+ The space character after the status code is mandatory, even if the
+ reason phrase is empty (see RFC 7230 section 3.1.2)
- Mentioned issue is now fixed as long as we don't use sendfile nor
- sendpath functions.
+ Closes #755
-- setup_once.h: refactor inclusion of <unistd.h> and <sys/socket.h>
+- [Viktor Szakats brought this change]
+
+ URLs: change http to https in many places
- Inclusion of top two most included header files now done in setup_once.h
+ Closes #754
-- setup_once.h: HP-UX specific TRUE and FALSE definitions
+- winbuild: trying to set some files eol=crlf for git
- Some HP-UX system headers require TRUE defined to 1 and FALSE to 0.
+ Thinking it might help to apply patches etc with git.
+
+- [Theodore Dubois brought this change]
-Daniel Stenberg (12 Dec 2012)
-- gopher: #include cleanup
+ curl.1: change example for -F
- Remove all system file includes from this file as they're not needed
+ It's a bad idea to send your passwords anywhere, especially over HTTP.
+ Modified example to send a picture instead.
- Reported by: Dan Fandrich
+ Fixes #752
-Yang Tse (11 Dec 2012)
-- examples/simplessl.c: fix compiler warning
+- KNOWN_BUGS: reorganized and cleaned up
+
+ Now sorted into categories and organized in the same style we do the
+ TODO document. It will make each issue linked properly on the
+ https://curl.haxx.se/docs/knownbugs.html web page.
+
+ The sections should make it easier to find issues and issues related to
+ areas of the reader's specific interest.
-- examples/externalsocket.c: fix SunPro compilation issue
+Jay Satiro (6 Apr 2016)
+- KNOWN_BUGS: #95 curl in Windows can't handle Unicode arguments
-- examples/simplessl.c: fix compiler warning
+Steve Holme (6 Apr 2016)
+- KNOWN_BUGS: Use https://curl.haxx.se URL for github based issues
-- build: add bundles and conncache files to other build systems
+- CHECKSRC.md: Corrected some typos
-- conncache: fix enumerated type mixed with another type
+- RELEASE-NOTES: Corrected last updated
+
+ Included a summary of the checksrc.bat updates and combined two krb5
+ changes as they should have been implemented at the same time.
-- examples/anyauthput.c: fix Tru64 compilation issue
+- vauth: Corrected a number of typos in comments
+
+ Reported-by: Michael Osipov
-Daniel Stenberg (8 Dec 2012)
-- [Colin Watson brought this change]
+Jay Satiro (5 Apr 2016)
+- KNOWN_BUGS: #94 IMAP custom requests use the LIST handler
+
+ Bug: https://github.com/curl/curl/issues/536
+ Reported-by: eXeC64@users.noreply.github.com
- configure: fix cross pkg-config detection
+Daniel Stenberg (5 Apr 2016)
+- KNOWN_BUGS: remove 68, 70 and 72.
- When cross-compiling, CURL_CHECK_PKGCONFIG was checking for the cross
- pkg-config using ${host}-pkg-config.
+ Due to their age (we don't fully know if they actually remain) and lack
+ of detail - very few people will bother to find out what they're about
+ or work on them. If people truly still suffer from any of these, I
+ assume they will be reported again and then we'll deal with them.
- The gold standard for doing this correctly is pkg-config's own macro,
- PKG_PROG_PKG_CONFIG. However, on the assumption that you have a good
- reason not to use that directly (reduced dependencies for maintainer
- builds?), the behaviour of cURL's version should at least match.
- PKG_PROG_PKG_CONFIG uses AC_PATH_TOOL, which ultimately ends up trying
- ${host_alias}-pkg-config; this is not quite the same as what cURL does,
- and may differ because ${host} has been run through config.sub. For
- instance, when cross-building to the armhf architecture on Ubuntu,
- ${host_alias} is arm-linux-gnueabihf while ${host} is
- arm-unknown-linux-gnueabihf. This may also have been the cause of the
- problem reported at http://curl.haxx.se/mail/lib-2012-04/0224.html.
+ 72. "Pausing pipeline problems."
+ https://curl.haxx.se/mail/lib-2009-07/0214.html
- AC_PATH_TOOL is significantly simpler than cURL's current code, and
- dates back to well before the current minimum of Autoconf 2.57, so let's
- use it instead.
+ 70. Problem re-using easy handle after call to curl_multi_remove_handle
+ https://curl.haxx.se/mail/lib-2009-07/0249.html
+
+ 68. "More questions about ares behavior".
+ https://curl.haxx.se/mail/lib-2009-08/0012.html
-- [Linus Nielsen Feltzing brought this change]
+- KNOWN_BUGS: remove 92 and 88, fixed
- Introducing a new persistent connection caching system using "bundles".
-
- A bundle is a list of all persistent connections to the same host.
- The connection cache consists of a hash of bundles, with the
- hostname as the key.
- The benefits may not be obvious, but they are two:
+- http2: fix connection reuse when PING comes after last DATA
- 1) Faster search for connections to reuse, since the hash
- lookup only finds connections to the host in question.
- 2) It lays out the groundworks for an upcoming patch,
- which will introduce multiple HTTP pipelines.
+ It turns out the google GFE HTTP/2 servers send a PING frame immediately
+ after a stream ends and its last DATA has been received by curl. So if
+ we don't drain that from the socket, it makes the socket readable in
+ subsequent checks and libcurl then (wrongly) assumes the connection is
+ dead when trying to reuse the connection.
- This patch also removes the awkward list of "closure handles",
- which were needed to send QUIT commands to the FTP server
- when closing a connection.
- Now we allocate a separate closure handle and use that
- one to close all connections.
+ Reported-by: Joonas Kuorilehto
- This has been tested in a live system for a few weeks, and of
- course passes the test suite.
+ Discussed in #750
-- [Fabian Keil brought this change]
+- multi: remove trailing space in debug output
- runtests and friends: Do not add undefined values to @INC
-
- On FreeBSD this fixes the warning:
- Use of uninitialized value $p in string eq at /usr/local/lib/perl5/5.14.2/BSDPAN/BSDPAN.pm line 36.
+- RELEASE-NOTES: synced with 86e97b642fb
+
+- CHECKSRC.md: mention cmdline options, fix the bullet list
+
+- docs/CHECKSRC.md: initial version
+
+Steve Holme (3 Apr 2016)
+- checksrc.bat: Added support for the examples
-Steve Holme (5 Dec 2012)
-- Merge pull request #52 from isn-/master
+Daniel Stenberg (3 Apr 2016)
+- lib/src: fix the checksrc invoke
- small compilation fix
+ ... now works correctly when invoke from the root makefile
projects / platform / upstream / curl.git / blobdiff