{
// The Texture has already loaded. The other observers have already been notified.
// We need to send a "late" loaded notification for this observer.
- observer->UploadComplete( true,
- textureInfo.textureSet, textureInfo.useAtlas,
- textureInfo.atlasRect );
+ observer->UploadComplete( true, textureInfo.textureId, textureInfo.textureSet,
+ textureInfo.useAtlas, textureInfo.atlasRect );
}
break;
}
{
TextureInfo& textureInfo( mTextureInfoContainer[ textureInfoIndex ] );
-
DALI_LOG_INFO( gTextureManagerLogFilter, Debug::Concise, "TextureManager::Remove(%d) cacheIdx:%d loadState:%s\n",
textureId, textureInfoIndex,
textureInfo.loadState == TextureManager::NOT_STARTED ? "NOT_STARTED" :
{
TextureId textureId = textureInfo.textureId;
- // If there is an observer: Notify the load is complete, whether successful or not:
- // And erase it from the list
+ // If there is an observer: Notify the load is complete, whether successful or not,
+ // and erase it from the list
unsigned int observerCount = textureInfo.observerList.Count();
TextureInfo* info = &textureInfo;
{
TextureUploadObserver* observer = info->observerList[0];
- // During UploadComplete() a Control ResourceReady() signal is emitted
- // During that signal the app may add remove /add Textures (e.g. via ImageViews).
- // At this point no more observers can be added to the observerList, because textureInfo.loadState = UPLOADED
- // However it is possible for observers to be removed, hence we check the observer list count every iteration
-
- // Also the reference to the textureInfo struct can become invalidated, because new load requests can modify
- // the mTextureInfoContainer list (e.g. if more requests are pushed_back it can cause the list to be resized
- // invalidating the reference to the TextureInfo ).
- observer->UploadComplete( success, info->textureSet, info->useAtlas, info->atlasRect );
+ // During UploadComplete() a Control ResourceReady() signal is emitted.
+ // During that signal the app may add remove /add Textures (e.g. via
+ // ImageViews). At this point no more observers can be added to the
+ // observerList, because textureInfo.loadState = UPLOADED. However it is
+ // possible for observers to be removed, hence we check the observer list
+ // count every iteration.
+
+ // The reference to the textureInfo struct can also become invalidated,
+ // because new load requests can modify the mTextureInfoContainer list
+ // (e.g. if more requests are pushed back it can cause the list to be
+ // resized invalidating the reference to the TextureInfo ).
+ observer->UploadComplete( success, info->textureId, info->textureSet, info->useAtlas, info->atlasRect );
observer->DestructionSignal().Disconnect( this, &TextureManager::ObserverDestroyed );
- // regrab the textureInfo from the container as it may have been invalidated, if textures have been removed
- // or added during the ResourceReady() signal emission (from UploadComplete() )
- int textureInfoIndex = GetCacheIndexFromId( textureId );
+ // Get the textureInfo from the container again as it may have been
+ // invalidated,
+ int textureInfoIndex = GetCacheIndexFromId( textureId );
if( textureInfoIndex == INVALID_CACHE_INDEX)
{
- // texture has been removed
- return;
+ return; // texture has been removed - can stop.
}
+
info = &mTextureInfoContainer[ textureInfoIndex ];
observerCount = info->observerList.Count();
if ( observerCount > 0 )
info->observerList.Erase( j );
observerCount--;
break;
- }
+ }
}
}
-
}
-
}
-
TextureManager::TextureId TextureManager::GenerateUniqueTextureId()
{
return mCurrentTextureId++;
for( unsigned int i = 0; i < count; ++i )
{
TextureInfo& textureInfo( mTextureInfoContainer[i] );
- for( TextureInfo::ObserverListType::Iterator j = textureInfo.observerList.Begin(); j != textureInfo.observerList.End(); ++j )
+ for( TextureInfo::ObserverListType::Iterator j = textureInfo.observerList.Begin(); j != textureInfo.observerList.End(); )
{
if( *j == observer )
{
- textureInfo.observerList.Erase( j );
- break;
+ j = textureInfo.observerList.Erase( j );
+ }
+ else
+ {
+ ++j;
}
}
}