2 # Copyright 2002-2019 The OpenSSL Project Authors. All Rights Reserved.
4 # Licensed under the OpenSSL license (the "License"). You may not use
5 # this file except in compliance with the License. You can obtain a copy
6 # in the file LICENSE in the source distribution or at
7 # https://www.openssl.org/source/license.html
16 use File::Spec::Functions;
18 use lib catdir(dirname($0), "perl");
19 use OpenSSL::Util::Pod;
33 Find small errors (nits) in documentation. Options:
34 -d Detailed list of undocumented (implies -u)
36 -n Print nits in POD pages
37 -p Warn if non-public name documented (implies -n)
38 -u List undocumented functions
39 -h Print this help message
40 -c List undocumented commands and options
45 my $temp = '/tmp/docnits.txt';
49 my %mandatory_sections =
50 ( '*' => [ 'NAME', 'DESCRIPTION', 'COPYRIGHT' ],
51 1 => [ 'SYNOPSIS', 'OPTIONS' ],
52 3 => [ 'SYNOPSIS', 'RETURN VALUES' ],
56 # Cross-check functions in the NAME and SYNOPSIS section.
63 # Get NAME section and all words in it.
64 return unless $contents =~ /=head1 NAME(.*)=head1 SYNOPSIS/ms;
67 print "$id trailing comma before - in NAME\n" if $tmp =~ /, *-/;
70 print "$id missing comma in NAME\n" if $tmp =~ /[^,] /;
73 my $dirname = dirname($filename);
74 my $simplename = basename($filename);
75 $simplename =~ s/.pod$//;
76 my $foundfilename = 0;
77 my %foundfilenames = ();
79 foreach my $n ( split ' ', $tmp ) {
81 $foundfilename++ if $n eq $simplename;
82 $foundfilenames{$n} = 1
83 if -f "$dirname/$n.pod" && $n ne $simplename;
85 print "$id the following exist as other .pod files:\n",
86 join(" ", sort keys %foundfilenames), "\n"
88 print "$id $simplename (filename) missing from NAME section\n"
89 unless $foundfilename;
90 foreach my $n ( keys %names ) {
91 print "$id $n is not public\n"
92 if $opt_p and !defined $public{$n};
95 # Find all functions in SYNOPSIS
96 return unless $contents =~ /=head1 SYNOPSIS(.*)=head1 DESCRIPTION/ms;
98 foreach my $line ( split /\n+/, $syn ) {
100 $line =~ s/STACK_OF\([^)]+\)/int/g;
101 $line =~ s/__declspec\([^)]+\)//;
102 if ( $line =~ /env (\S*)=/ ) {
103 # environment variable env NAME=...
105 } elsif ( $line =~ /typedef.*\(\*(\S+)\)\(.*/ ) {
106 # a callback function pointer: typedef ... (*NAME)(...
108 } elsif ( $line =~ /typedef.* (\S+)\(.*/ ) {
109 # a callback function signature: typedef ... NAME(...
111 } elsif ( $line =~ /typedef.* (\S+);/ ) {
112 # a simple typedef: typedef ... NAME;
114 } elsif ( $line =~ /enum (\S*) \{/ ) {
115 # an enumeration: enum ... {
117 } elsif ( $line =~ /#define ([A-Za-z0-9_]+)/ ) {
119 } elsif ( $line =~ /([A-Za-z0-9_]+)\(/ ) {
125 print "$id $sym missing from NAME section\n"
126 unless defined $names{$sym};
129 # Do some sanity checks on the prototype.
130 print "$id prototype missing spaces around commas: $line\n"
131 if ( $line =~ /[a-z0-9],[^ ]/ );
134 foreach my $n ( keys %names ) {
135 next if $names{$n} == 2;
136 print "$id $n missing from SYNOPSIS\n";
140 # Check if SECTION ($3) is located before BEFORE ($4)
141 sub check_section_location()
144 my $contents = shift;
149 unless $contents =~ /=head1 $section/ and $contents =~ /=head1 $before/;
150 print "$id $section should be placed before $before section\n"
151 if $contents =~ /=head1 $before.*=head1 $section/ms;
156 my $filename = shift;
157 my $dirname = basename(dirname($filename));
162 open POD, $filename or die "Couldn't open $filename, $!";
167 my $id = "${filename}:1:";
169 # Check ordering of some sections in man3
170 if ( $filename =~ m|man3/| ) {
171 &check_section_location($id, $contents, "RETURN VALUES", "EXAMPLES");
172 &check_section_location($id, $contents, "SEE ALSO", "HISTORY");
173 &check_section_location($id, $contents, "EXAMPLES", "SEE ALSO");
176 &name_synopsis($id, $filename, $contents)
177 unless $contents =~ /=for comment generic/
178 or $filename =~ m@man[157]/@;
180 print "$id doesn't start with =pod\n"
181 if $contents !~ /^=pod/;
182 print "$id doesn't end with =cut\n"
183 if $contents !~ /=cut\n$/;
184 print "$id more than one cut line.\n"
185 if $contents =~ /=cut.*=cut/ms;
186 print "$id EXAMPLE not EXAMPLES section.\n"
187 if $contents =~ /=head1 EXAMPLE[^S]/;
188 print "$id WARNING not WARNINGS section.\n"
189 if $contents =~ /=head1 WARNING[^S]/;
190 print "$id missing copyright\n"
191 if $contents !~ /Copyright .* The OpenSSL Project Authors/;
192 print "$id copyright not last\n"
193 if $contents =~ /head1 COPYRIGHT.*=head/ms;
194 print "$id head2 in All uppercase\n"
195 if $contents =~ /head2\s+[A-Z ]+\n/;
196 print "$id extra space after head\n"
197 if $contents =~ /=head\d\s\s+/;
198 print "$id period in NAME section\n"
199 if $contents =~ /=head1 NAME.*\.\n.*=head1 SYNOPSIS/ms;
200 print "$id POD markup in NAME section\n"
201 if $contents =~ /=head1 NAME.*[<>].*=head1 SYNOPSIS/ms;
202 print "$id Duplicate $1 in L<>\n"
203 if $contents =~ /L<([^>]*)\|([^>]*)>/ && $1 eq $2;
204 print "$id Bad =over $1\n"
205 if $contents =~ /=over([^ ][^24])/;
206 print "$id Possible version style issue\n"
207 if $contents =~ /OpenSSL version [019]/;
209 if ( $contents !~ /=for comment multiple includes/ ) {
210 # Look for multiple consecutive openssl #include lines
211 # (non-consecutive lines are okay; see man3/MD5.pod).
212 if ( $contents =~ /=head1 SYNOPSIS(.*)=head1 DESCRIPTION/ms ) {
214 foreach my $line ( split /\n+/, $1 ) {
215 if ( $line =~ m@include <openssl/@ ) {
216 print "$id has multiple includes\n" if ++$count == 2;
224 open my $OUT, '>', $temp
225 or die "Can't open $temp, $!";
226 podchecker($filename, $OUT);
228 open $OUT, '<', $temp
229 or die "Can't read $temp, $!";
231 next if /\(section\) in.*deprecated/;
235 unlink $temp || warn "Can't remove $temp, $!";
237 # Find what section this page is in; assume 3.
239 $section = $1 if $dirname =~ /man([1-9])/;
241 foreach ((@{$mandatory_sections{'*'}}, @{$mandatory_sections{$section}})) {
242 # Skip "return values" if not -s
243 print "$id: missing $_ head1 section\n"
244 if $contents !~ /^=head1\s+${_}\s*$/m;
255 open my $IN, '<', $file
256 or die "Can't open $file, $!, stopped";
260 next if /\bNOEXIST\b/;
261 next if /\bEXPORT_VAR_AS_FUNC\b/;
262 my @fields = split();
263 die "Malformed line $_"
264 if scalar @fields != 2 && scalar @fields != 4;
265 push @apis, $fields[0];
270 print "# Found ", scalar(@apis), " in $file\n" unless $opt_p;
279 foreach my $pod ( glob("$dir/*.pod") ) {
280 my %podinfo = extract_pod_info($pod);
281 foreach my $n ( @{$podinfo{names}} ) {
283 print "# Duplicate $n in $pod and $dups{$n}\n"
284 if defined $dups{$n} && $dups{$n} ne $pod;
298 print "# Checking macros (approximate)\n";
299 foreach my $f ( glob('include/openssl/*.h') ) {
300 # Skip some internals we don't want to document yet.
301 next if $f eq 'include/openssl/asn1.h';
302 next if $f eq 'include/openssl/asn1t.h';
303 next if $f eq 'include/openssl/err.h';
304 open(IN, $f) || die "Can't open $f, $!";
306 next unless /^#\s*define\s*(\S+)\(/;
308 next if $docced{$macro};
309 next if $macro =~ /i2d_/
311 || $macro =~ /DEPRECATEDIN/
312 || $macro =~ /IMPLEMENT_/
313 || $macro =~ /DECLARE_/;
314 print "$f:$macro\n" if $opt_d;
319 print "# Found $count macros missing (not all should be documented)\n"
328 foreach my $func ( &parsenum($numfile) ) {
329 next if $docced{$func};
331 # Skip ASN1 utilities
332 next if $func =~ /^ASN1_/;
334 print "$libname:$func\n" if $opt_d;
337 print "# Found $count missing from $numfile\n\n";
341 # Collection of links in each POD file.
342 # filename => [ "foo(1)", "bar(3)", ... ]
343 my %link_collection = ();
344 # Collection of names in each POD file.
345 # "name(s)" => filename
346 my %name_collection = ();
349 my $filename = shift;
350 $filename =~ m|man(\d)/|;
352 my $simplename = basename($filename, ".pod");
353 my $id = "${filename}:1:";
358 open POD, $filename or die "Couldn't open $filename, $!";
363 $contents =~ /=head1 NAME([^=]*)=head1 /ms;
365 unless (defined $tmp) {
366 print "$id weird name section\n";
372 my @names = map { s/\s+//g; $_ } split(/,/, $tmp);
373 unless (grep { $simplename eq $_ } @names) {
374 print "$id missing $simplename\n";
375 push @names, $simplename;
377 foreach my $name (@names) {
379 my $name_sec = "$name($section)";
380 if (! exists $name_collection{$name_sec}) {
381 $name_collection{$name_sec} = $filename;
382 } else { #elsif ($filename ne $name_collection{$name_sec}) {
383 print "$id $name_sec also in $name_collection{$name_sec}\n";
388 map { map { s/\s+//g; $_ } split(/,/, $_) }
389 $contents =~ /=for\s+comment\s+foreign\s+manuals:\s*(.*)\n\n/;
390 foreach (@foreign_names) {
391 $name_collection{$_} = undef; # It still exists!
394 my @links = $contents =~ /L<
395 # if the link is of the form L<something|name(s)>,
396 # then remove 'something'. Note that 'something'
397 # may contain POD codes as well...
398 (?:(?:[^\|]|<[^>]*>)*\|)?
399 # we're only interested in references that have
400 # a one digit section number
403 $link_collection{$filename} = [ @links ];
407 foreach my $filename (sort keys %link_collection) {
408 foreach my $link (@{$link_collection{$filename}}) {
409 print "${filename}:1: reference to non-existing $link\n"
410 unless exists $name_collection{$link};
416 foreach my $name ( &parsenum('util/libcrypto.num') ) {
419 foreach my $name ( &parsenum('util/libssl.num') ) {
422 foreach my $name ( &parsenum('util/private.num') ) {
450 # Get the list of options in the command.
451 open CFH, "./apps/openssl list --options $cmd|"
452 || die "Can list options for $cmd, $!";
460 # Get the list of flags from the synopsis
461 open CFH, "<doc/man1/$cmd.pod"
462 || die "Can't open $cmd.pod, $!";
465 last if /DESCRIPTION/;
466 next unless /\[B<-([^ >]+)/;
471 # See what's in the command not the manpage.
473 foreach my $k ( keys %cmdopts ) {
474 push @undocced, $k unless $docopts{$k};
476 if ( scalar @undocced > 0 ) {
478 foreach ( @undocced ) {
479 print "doc/man1/$cmd.pod: Missing -$_\n";
483 # See what's in the command not the manpage.
485 foreach my $k ( keys %docopts ) {
486 push @unimpl, $k unless $cmdopts{$k};
488 if ( scalar @unimpl > 0 ) {
490 foreach ( @unimpl ) {
491 next if defined $skips{$_};
492 print "doc/man1/$cmd.pod: Not implemented -$_\n";
502 $opt_n = 1 if $opt_p;
503 $opt_u = 1 if $opt_d;
505 die "Need one of -[cdlnpu] flags.\n"
506 unless $opt_c or $opt_l or $opt_n or $opt_u;
512 # Get list of commands.
513 open FH, "./apps/openssl list -1 -commands|"
514 || die "Can't list commands, $!";
521 # See if each has a manpage.
522 foreach ( @commands ) {
523 next if $_ eq 'help' || $_ eq 'exit';
524 if ( ! -f "doc/man1/$_.pod" ) {
525 print "doc/man1/$_.pod does not exist\n";
528 $ok = 0 if not &checkflags($_);
532 # See what help is missing.
533 open FH, "./apps/openssl list --missing-help |"
534 || die "Can't list missing help, $!";
537 my ($cmd, $flag) = split;
538 print "$cmd has no help for -$flag\n";
547 foreach (@ARGV ? @ARGV : glob('doc/*/*.pod')) {
554 &publicize() if $opt_p;
555 foreach (@ARGV ? @ARGV : glob('doc/*/*.pod')) {
561 my %temp = &getdocced('doc/man3');
562 foreach ( keys %temp ) {
563 $docced{$_} = $temp{$_};
565 &printem('crypto', 'util/libcrypto.num');
566 &printem('ssl', 'util/libssl.num');