src/rules.c

   1 /*
   2  * Copyright (c) 2007-2009, Novell Inc.
   3  *
   4  * This program is licensed under the BSD license, read LICENSE.BSD
   5  * for further information
   6  */
   7
   8 /*
   9  * rules.c
  10  *
  11  * SAT based dependency solver
  12  */
  13
  14 #include <stdio.h>
  15 #include <stdlib.h>
  16 #include <unistd.h>
  17 #include <string.h>
  18 #include <assert.h>
  19
  20 #include "solver.h"
  21 #include "solver_private.h"
  22 #include "bitmap.h"
  23 #include "pool.h"
  24 #include "poolarch.h"
  25 #include "util.h"
  26 #include "evr.h"
  27 #include "policy.h"
  28 #include "solverdebug.h"
  29
  30 #define RULES_BLOCK 63
  31
  32 static void addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep);
  33 static void solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded);
  34
  35 /*-------------------------------------------------------------------
  36  * Check if dependency is possible
  37  *
  38  * mirrors solver_dep_fulfilled but uses map m instead of the decisionmap
  39  * used in solver_addrpmrulesforweak and solver_createcleandepsmap
  40  */
  41
  42 static inline int
  43 dep_possible(Solver *solv, Id dep, Map *m)
  44 {
  45   Pool *pool = solv->pool;
  46   Id p, pp;
  47
  48   if (ISRELDEP(dep))
  49     {
  50       Reldep *rd = GETRELDEP(pool, dep);
  51       if (rd->flags >= 8)
  52         {
  53           if (rd->flags == REL_AND)
  54             {
  55               if (!dep_possible(solv, rd->name, m))
  56                 return 0;
  57               return dep_possible(solv, rd->evr, m);
  58             }
  59           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
  60             return solver_splitprovides(solv, rd->evr);
  61           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
  62             return solver_dep_installed(solv, rd->evr);
  63         }
  64     }
  65   FOR_PROVIDES(p, pp, dep)
  66     {
  67       if (MAPTST(m, p))
  68         return 1;
  69     }
  70   return 0;
  71 }
  72
  73 /********************************************************************
  74  *
  75  * Rule handling
  76  *
  77  * - unify rules, remove duplicates
  78  */
  79
  80 /*-------------------------------------------------------------------
  81  *
  82  * compare rules for unification sort
  83  *
  84  */
  85
  86 static int
  87 unifyrules_sortcmp(const void *ap, const void *bp, void *dp)
  88 {
  89   Pool *pool = dp;
  90   Rule *a = (Rule *)ap;
  91   Rule *b = (Rule *)bp;
  92   Id *ad, *bd;
  93   int x;
  94
  95   x = a->p - b->p;
  96   if (x)
  97     return x;                          /* p differs */
  98
  99   /* identical p */
 100   if (a->d == 0 && b->d == 0)
 101     return a->w2 - b->w2;              /* assertion: return w2 diff */
 102
 103   if (a->d == 0)                       /* a is assertion, b not */
 104     {
 105       x = a->w2 - pool->whatprovidesdata[b->d];
 106       return x ? x : -1;
 107     }
 108
 109   if (b->d == 0)                       /* b is assertion, a not */
 110     {
 111       x = pool->whatprovidesdata[a->d] - b->w2;
 112       return x ? x : 1;
 113     }
 114
 115   /* compare whatprovidesdata */
 116   ad = pool->whatprovidesdata + a->d;
 117   bd = pool->whatprovidesdata + b->d;
 118   while (*bd)
 119     if ((x = *ad++ - *bd++) != 0)
 120       return x;
 121   return *ad;
 122 }
 123
 124 int
 125 solver_rulecmp(Solver *solv, Rule *r1, Rule *r2)
 126 {
 127   return unifyrules_sortcmp(r1, r2, solv->pool);
 128 }
 129
 130
 131 /*-------------------------------------------------------------------
 132  *
 133  * unify rules
 134  * go over all rules and remove duplicates
 135  */
 136
 137 void
 138 solver_unifyrules(Solver *solv)
 139 {
 140   Pool *pool = solv->pool;
 141   int i, j;
 142   Rule *ir, *jr;
 143
 144   if (solv->nrules <= 2)               /* nothing to unify */
 145     return;
 146
 147   /* sort rules first */
 148   solv_sort(solv->rules + 1, solv->nrules - 1, sizeof(Rule), unifyrules_sortcmp, solv->pool);
 149
 150   /* prune rules
 151    * i = unpruned
 152    * j = pruned
 153    */
 154   jr = 0;
 155   for (i = j = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
 156     {
 157       if (jr && !unifyrules_sortcmp(ir, jr, pool))
 158         continue;                      /* prune! */
 159       jr = solv->rules + j++;          /* keep! */
 160       if (ir != jr)
 161         *jr = *ir;
 162     }
 163
 164   /* reduced count from nrules to j rules */
 165   POOL_DEBUG(SOLV_DEBUG_STATS, "pruned rules from %d to %d\n", solv->nrules, j);
 166
 167   /* adapt rule buffer */
 168   solv->nrules = j;
 169   solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
 170
 171   /*
 172    * debug: log rule statistics
 173    */
 174   IF_POOLDEBUG (SOLV_DEBUG_STATS)
 175     {
 176       int binr = 0;
 177       int lits = 0;
 178       Id *dp;
 179       Rule *r;
 180
 181       for (i = 1; i < solv->nrules; i++)
 182         {
 183           r = solv->rules + i;
 184           if (r->d == 0)
 185             binr++;
 186           else
 187             {
 188               dp = solv->pool->whatprovidesdata + r->d;
 189               while (*dp++)
 190                 lits++;
 191             }
 192         }
 193       POOL_DEBUG(SOLV_DEBUG_STATS, "  binary: %d\n", binr);
 194       POOL_DEBUG(SOLV_DEBUG_STATS, "  normal: %d, %d literals\n", solv->nrules - 1 - binr, lits);
 195     }
 196 }
 197
 198 #if 0
 199
 200 /*
 201  * hash rule
 202  */
 203
 204 static Hashval
 205 hashrule(Solver *solv, Id p, Id d, int n)
 206 {
 207   unsigned int x = (unsigned int)p;
 208   int *dp;
 209
 210   if (n <= 1)
 211     return (x * 37) ^ (unsigned int)d;
 212   dp = solv->pool->whatprovidesdata + d;
 213   while (*dp)
 214     x = (x * 37) ^ (unsigned int)*dp++;
 215   return x;
 216 }
 217 #endif
 218
 219
 220 /*-------------------------------------------------------------------
 221  *
 222  */
 223
 224 /*
 225  * add rule
 226  *  p = direct literal; always < 0 for installed rpm rules
 227  *  d, if < 0 direct literal, if > 0 offset into whatprovides, if == 0 rule is assertion (look at p only)
 228  *
 229  *
 230  * A requires b, b provided by B1,B2,B3 => (-A|B1|B2|B3)
 231  *
 232  * p < 0 : pkg id of A
 233  * d > 0 : Offset in whatprovidesdata (list of providers of b)
 234  *
 235  * A conflicts b, b provided by B1,B2,B3 => (-A|-B1), (-A|-B2), (-A|-B3)
 236  * p < 0 : pkg id of A
 237  * d < 0 : Id of solvable (e.g. B1)
 238  *
 239  * d == 0: unary rule, assertion => (A) or (-A)
 240  *
 241  *   Install:    p > 0, d = 0   (A)             user requested install
 242  *   Remove:     p < 0, d = 0   (-A)            user requested remove (also: uninstallable)
 243  *   Requires:   p < 0, d > 0   (-A|B1|B2|...)  d: <list of providers for requirement of p>
 244  *   Updates:    p > 0, d > 0   (A|B1|B2|...)   d: <list of updates for solvable p>
 245  *   Conflicts:  p < 0, d < 0   (-A|-B)         either p (conflict issuer) or d (conflict provider) (binary rule)
 246  *                                              also used for obsoletes
 247  *   ?:          p > 0, d < 0   (A|-B)
 248  *   No-op ?:    p = 0, d = 0   (null)          (used as policy rule placeholder)
 249  *
 250  *   resulting watches:
 251  *   ------------------
 252  *   Direct assertion (no watch needed) --> d = 0, w1 = p, w2 = 0
 253  *   Binary rule: p = first literal, d = 0, w2 = second literal, w1 = p
 254  *   every other : w1 = p, w2 = whatprovidesdata[d];
 255  *   Disabled rule: w1 = 0
 256  *
 257  *   always returns a rule for non-rpm rules
 258  */
 259
 260 Rule *
 261 solver_addrule(Solver *solv, Id p, Id d)
 262 {
 263   Pool *pool = solv->pool;
 264   Rule *r = 0;
 265   Id *dp = 0;
 266
 267   int n = 0;                           /* number of literals in rule - 1
 268                                           0 = direct assertion (single literal)
 269                                           1 = binary rule
 270                                           >1 =
 271                                         */
 272
 273   /* it often happenes that requires lead to adding the same rpm rule
 274    * multiple times, so we prune those duplicates right away to make
 275    * the work for unifyrules a bit easier */
 276
 277   if (!solv->rpmrules_end)              /* we add rpm rules */
 278     {
 279       r = solv->rules + solv->nrules - 1;       /* get the last added rule */
 280       if (r->p == p && r->d == d && (d != 0 || !r->w2))
 281         return r;
 282     }
 283
 284     /*
 285      * compute number of literals (n) in rule
 286      */
 287
 288   if (d < 0)
 289     {
 290       /* always a binary rule */
 291       if (p == d)
 292         return 0;                      /* ignore self conflict */
 293       n = 1;
 294     }
 295   else if (d > 0)
 296     {
 297       for (dp = pool->whatprovidesdata + d; *dp; dp++, n++)
 298         if (*dp == -p)
 299           return 0;                     /* rule is self-fulfilling */
 300
 301       if (n == 1)                       /* convert to binary rule */
 302         d = dp[-1];
 303     }
 304
 305   if (n == 1 && p > d && !solv->rpmrules_end)
 306     {
 307       /* smallest literal first so we can find dups */
 308       n = p; p = d; d = n;             /* p <-> d */
 309       n = 1;                           /* re-set n, was used as temp var */
 310     }
 311
 312   /*
 313    * check for duplicate
 314    */
 315
 316   /* check if the last added rule (r) is exactly the same as what we're looking for. */
 317   if (r && n == 1 && !r->d && r->p == p && r->w2 == d)
 318     return r;  /* binary rule */
 319
 320     /* have n-ary rule with same first literal, check other literals */
 321   if (r && n > 1 && r->d && r->p == p)
 322     {
 323       /* Rule where d is an offset in whatprovidesdata */
 324       Id *dp2;
 325       if (d == r->d)
 326         return r;
 327       dp2 = pool->whatprovidesdata + r->d;
 328       for (dp = pool->whatprovidesdata + d; *dp; dp++, dp2++)
 329         if (*dp != *dp2)
 330           break;
 331       if (*dp == *dp2)
 332         return r;
 333    }
 334
 335   /*
 336    * allocate new rule
 337    */
 338
 339   /* extend rule buffer */
 340   solv->rules = solv_extend(solv->rules, solv->nrules, 1, sizeof(Rule), RULES_BLOCK);
 341   r = solv->rules + solv->nrules++;    /* point to rule space */
 342
 343     /*
 344      * r = new rule
 345      */
 346
 347   r->p = p;
 348   if (n == 0)
 349     {
 350       /* direct assertion, no watch needed */
 351       r->d = 0;
 352       r->w1 = p;
 353       r->w2 = 0;
 354     }
 355   else if (n == 1)
 356     {
 357       /* binary rule */
 358       r->d = 0;
 359       r->w1 = p;
 360       r->w2 = d;
 361     }
 362   else
 363     {
 364       r->d = d;
 365       r->w1 = p;
 366       r->w2 = pool->whatprovidesdata[d];
 367     }
 368   r->n1 = 0;
 369   r->n2 = 0;
 370
 371   IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 372     {
 373       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "  Add rule: ");
 374       solver_printrule(solv, SOLV_DEBUG_RULE_CREATION, r);
 375     }
 376
 377   return r;
 378 }
 379
 380
 381 /******************************************************************************
 382  ***
 383  *** rpm rule part: create rules representing the package dependencies
 384  ***
 385  ***/
 386
 387 /*
 388  *  special multiversion patch conflict handling:
 389  *  a patch conflict is also satisfied if some other
 390  *  version with the same name/arch that doesn't conflict
 391  *  gets installed. The generated rule is thus:
 392  *  -patch|-cpack|opack1|opack2|...
 393  */
 394 static Id
 395 makemultiversionconflict(Solver *solv, Id n, Id con)
 396 {
 397   Pool *pool = solv->pool;
 398   Solvable *s, *sn;
 399   Queue q;
 400   Id p, pp, qbuf[64];
 401
 402   sn = pool->solvables + n;
 403   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
 404   queue_push(&q, -n);
 405   FOR_PROVIDES(p, pp, sn->name)
 406     {
 407       s = pool->solvables + p;
 408       if (s->name != sn->name || s->arch != sn->arch)
 409         continue;
 410       if (!MAPTST(&solv->noobsoletes, p))
 411         continue;
 412       if (pool_match_nevr(pool, pool->solvables + p, con))
 413         continue;
 414       /* here we have a multiversion solvable that doesn't conflict */
 415       /* thus we're not in conflict if it is installed */
 416       queue_push(&q, p);
 417     }
 418   if (q.count == 1)
 419     return -n;  /* no other package found, generate normal conflict */
 420   return pool_queuetowhatprovides(pool, &q);
 421 }
 422
 423 static inline void
 424 addrpmrule(Solver *solv, Id p, Id d, int type, Id dep)
 425 {
 426   if (!solv->ruleinfoq)
 427     solver_addrule(solv, p, d);
 428   else
 429     addrpmruleinfo(solv, p, d, type, dep);
 430 }
 431
 432 /*-------------------------------------------------------------------
 433  *
 434  * add (install) rules for solvable
 435  *
 436  * s: Solvable for which to add rules
 437  * m: m[s] = 1 for solvables which have rules, prevent rule duplication
 438  *
 439  * Algorithm: 'visit all nodes of a graph'. The graph nodes are
 440  *  solvables, the edges their dependencies.
 441  *  Starting from an installed solvable, this will create all rules
 442  *  representing the graph created by the solvables dependencies.
 443  *
 444  * for unfulfilled requirements, conflicts, obsoletes,....
 445  * add a negative assertion for solvables that are not installable
 446  *
 447  * It will also create rules for all solvables referenced by 's'
 448  *  i.e. descend to all providers of requirements of 's'
 449  *
 450  */
 451
 452 void
 453 solver_addrpmrulesforsolvable(Solver *solv, Solvable *s, Map *m)
 454 {
 455   Pool *pool = solv->pool;
 456   Repo *installed = solv->installed;
 457
 458   /* 'work' queue. keeps Ids of solvables we still have to work on.
 459      And buffer for it. */
 460   Queue workq;
 461   Id workqbuf[64];
 462
 463   int i;
 464     /* if to add rules for broken deps ('rpm -V' functionality)
 465      * 0 = yes, 1 = no
 466      */
 467   int dontfix;
 468     /* Id var and pointer for each dependency
 469      * (not used in parallel)
 470      */
 471   Id req, *reqp;
 472   Id con, *conp;
 473   Id obs, *obsp;
 474   Id rec, *recp;
 475   Id sug, *sugp;
 476   Id p, pp;             /* whatprovides loops */
 477   Id *dp;               /* ptr to 'whatprovides' */
 478   Id n;                 /* Id for current solvable 's' */
 479
 480   queue_init_buffer(&workq, workqbuf, sizeof(workqbuf)/sizeof(*workqbuf));
 481   queue_push(&workq, s - pool->solvables);      /* push solvable Id to work queue */
 482
 483   /* loop until there's no more work left */
 484   while (workq.count)
 485     {
 486       /*
 487        * n: Id of solvable
 488        * s: Pointer to solvable
 489        */
 490
 491       n = queue_shift(&workq);          /* 'pop' next solvable to work on from queue */
 492       if (m)
 493         {
 494           if (MAPTST(m, n))             /* continue if already visited */
 495             continue;
 496           MAPSET(m, n);                 /* mark as visited */
 497         }
 498
 499       s = pool->solvables + n;          /* s = Solvable in question */
 500
 501       dontfix = 0;
 502       if (installed                     /* Installed system available */
 503           && s->repo == installed       /* solvable is installed */
 504           && !solv->fixmap_all          /* NOT repair errors in rpm dependency graph */
 505           && !(solv->fixmap.size && MAPTST(&solv->fixmap, n - installed->start)))
 506         {
 507           dontfix = 1;                  /* dont care about broken rpm deps */
 508         }
 509
 510       if (!dontfix
 511           && s->arch != ARCH_SRC
 512           && s->arch != ARCH_NOSRC
 513           && !pool_installable(pool, s))
 514         {
 515           POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables));
 516           addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOT_INSTALLABLE, 0);
 517         }
 518
 519       /* yet another SUSE hack, sigh */
 520       if (pool->nscallback && !strncmp("product:", pool_id2str(pool, s->name), 8))
 521         {
 522           Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, n);
 523           if (buddy > 0 && buddy != SYSTEMSOLVABLE && buddy != n && buddy < pool->nsolvables)
 524             {
 525               addrpmrule(solv, n, -buddy, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + n));
 526               addrpmrule(solv, buddy, -n, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + buddy));
 527               if (m && !MAPTST(m, buddy))
 528                 queue_push(&workq, buddy);
 529             }
 530         }
 531
 532       /*-----------------------------------------
 533        * check requires of s
 534        */
 535
 536       if (s->requires)
 537         {
 538           reqp = s->repo->idarraydata + s->requires;
 539           while ((req = *reqp++) != 0)            /* go through all requires */
 540             {
 541               if (req == SOLVABLE_PREREQMARKER)   /* skip the marker */
 542                 continue;
 543
 544               /* find list of solvables providing 'req' */
 545               dp = pool_whatprovides_ptr(pool, req);
 546
 547               if (*dp == SYSTEMSOLVABLE)          /* always installed */
 548                 continue;
 549
 550               if (dontfix)
 551                 {
 552                   /* the strategy here is to not insist on dependencies
 553                    * that are already broken. so if we find one provider
 554                    * that was already installed, we know that the
 555                    * dependency was not broken before so we enforce it */
 556
 557                   /* check if any of the providers for 'req' is installed */
 558                   for (i = 0; (p = dp[i]) != 0; i++)
 559                     {
 560                       if (pool->solvables[p].repo == installed)
 561                         break;          /* provider was installed */
 562                     }
 563                   /* didn't find an installed provider: previously broken dependency */
 564                   if (!p)
 565                     {
 566                       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken requires %s of installed package %s\n", pool_dep2str(pool, req), pool_solvable2str(pool, s));
 567                       continue;
 568                     }
 569                 }
 570
 571               if (!*dp)
 572                 {
 573                   /* nothing provides req! */
 574                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables), pool_dep2str(pool, req));
 575                   addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOTHING_PROVIDES_DEP, req);
 576                   continue;
 577                 }
 578
 579               IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 580                 {
 581                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION,"  %s requires %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
 582                   for (i = 0; dp[i]; i++)
 583                     POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "   provided by %s\n", pool_solvid2str(pool, dp[i]));
 584                 }
 585
 586               /* add 'requires' dependency */
 587               /* rule: (-requestor|provider1|provider2|...|providerN) */
 588               addrpmrule(solv, -n, dp - pool->whatprovidesdata, SOLVER_RULE_RPM_PACKAGE_REQUIRES, req);
 589
 590               /* descend the dependency tree
 591                  push all non-visited providers on the work queue */
 592               if (m)
 593                 {
 594                   for (; *dp; dp++)
 595                     {
 596                       if (!MAPTST(m, *dp))
 597                         queue_push(&workq, *dp);
 598                     }
 599                 }
 600
 601             } /* while, requirements of n */
 602
 603         } /* if, requirements */
 604
 605       /* that's all we check for src packages */
 606       if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC)
 607         continue;
 608
 609       /*-----------------------------------------
 610        * check conflicts of s
 611        */
 612
 613       if (s->conflicts)
 614         {
 615           int ispatch = 0;
 616
 617           /* we treat conflicts in patches a bit differen:
 618            * - nevr matching
 619            * - multiversion handling
 620            * XXX: we should really handle this different, looking
 621            * at the name is a bad hack
 622            */
 623           if (!strncmp("patch:", pool_id2str(pool, s->name), 6))
 624             ispatch = 1;
 625           conp = s->repo->idarraydata + s->conflicts;
 626           /* foreach conflicts of 's' */
 627           while ((con = *conp++) != 0)
 628             {
 629               /* foreach providers of a conflict of 's' */
 630               FOR_PROVIDES(p, pp, con)
 631                 {
 632                   if (ispatch && !pool_match_nevr(pool, pool->solvables + p, con))
 633                     continue;
 634                   /* dontfix: dont care about conflicts with already installed packs */
 635                   if (dontfix && pool->solvables[p].repo == installed)
 636                     continue;
 637                   /* p == n: self conflict */
 638                   if (p == n && pool->forbidselfconflicts)
 639                     {
 640                       if (ISRELDEP(con))
 641                         {
 642                           Reldep *rd = GETRELDEP(pool, con);
 643                           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_OTHERPROVIDERS)
 644                             continue;
 645                         }
 646                       p = 0;    /* make it a negative assertion, aka 'uninstallable' */
 647                     }
 648                   if (p && ispatch && solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p) && ISRELDEP(con))
 649                     {
 650                       /* our patch conflicts with a noobsoletes (aka multiversion) package */
 651                       p = -makemultiversionconflict(solv, p, con);
 652                     }
 653                  /* rule: -n|-p: either solvable _or_ provider of conflict */
 654                   addrpmrule(solv, -n, -p, p ? SOLVER_RULE_RPM_PACKAGE_CONFLICT : SOLVER_RULE_RPM_SELF_CONFLICT, con);
 655                 }
 656             }
 657         }
 658
 659       /*-----------------------------------------
 660        * check obsoletes and implicit obsoletes of a package
 661        * if ignoreinstalledsobsoletes is not set, we're also checking
 662        * obsoletes of installed packages (like newer rpm versions)
 663        */
 664       if ((!installed || s->repo != installed) || !pool->noinstalledobsoletes)
 665         {
 666           int noobs = solv->noobsoletes.size && MAPTST(&solv->noobsoletes, n);
 667           int isinstalled = (installed && s->repo == installed);
 668           if (s->obsoletes && (!noobs || solv->keepexplicitobsoletes))
 669             {
 670               obsp = s->repo->idarraydata + s->obsoletes;
 671               /* foreach obsoletes */
 672               while ((obs = *obsp++) != 0)
 673                 {
 674                   /* foreach provider of an obsoletes of 's' */
 675                   FOR_PROVIDES(p, pp, obs)
 676                     {
 677                       Solvable *ps = pool->solvables + p;
 678                       if (p == n)
 679                         continue;
 680                       if (isinstalled && dontfix && ps->repo == installed)
 681                         continue;       /* don't repair installed/installed problems */
 682                       if (!pool->obsoleteusesprovides /* obsoletes are matched names, not provides */
 683                           && !pool_match_nevr(pool, ps, obs))
 684                         continue;
 685                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 686                         continue;
 687                       if (!isinstalled)
 688                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_PACKAGE_OBSOLETES, obs);
 689                       else
 690                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_INSTALLEDPKG_OBSOLETES, obs);
 691                     }
 692                 }
 693             }
 694           /* check implicit obsoletes
 695            * for installed packages we only need to check installed/installed problems (and
 696            * only when dontfix is not set), as the others are picked up when looking at the
 697            * uninstalled package.
 698            */
 699           if (!isinstalled || !dontfix)
 700             {
 701               FOR_PROVIDES(p, pp, s->name)
 702                 {
 703                   Solvable *ps = pool->solvables + p;
 704                   if (p == n)
 705                     continue;
 706                   if (isinstalled && ps->repo != installed)
 707                     continue;
 708                   /* we still obsolete packages with same nevra, like rpm does */
 709                   /* (actually, rpm mixes those packages. yuck...) */
 710                   if (noobs && (s->name != ps->name || s->evr != ps->evr || s->arch != ps->arch))
 711                     continue;
 712                   if (!pool->implicitobsoleteusesprovides && s->name != ps->name)
 713                     continue;
 714                   if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 715                     continue;
 716                   if (s->name == ps->name)
 717                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_SAME_NAME, 0);
 718                   else
 719                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_IMPLICIT_OBSOLETES, s->name);
 720                 }
 721             }
 722         }
 723
 724       /*-----------------------------------------
 725        * add recommends to the work queue
 726        */
 727       if (s->recommends && m)
 728         {
 729           recp = s->repo->idarraydata + s->recommends;
 730           while ((rec = *recp++) != 0)
 731             {
 732               FOR_PROVIDES(p, pp, rec)
 733                 if (!MAPTST(m, p))
 734                   queue_push(&workq, p);
 735             }
 736         }
 737       if (s->suggests && m)
 738         {
 739           sugp = s->repo->idarraydata + s->suggests;
 740           while ((sug = *sugp++) != 0)
 741             {
 742               FOR_PROVIDES(p, pp, sug)
 743                 if (!MAPTST(m, p))
 744                   queue_push(&workq, p);
 745             }
 746         }
 747     }
 748   queue_free(&workq);
 749 }
 750
 751
 752 /*-------------------------------------------------------------------
 753  *
 754  * Add rules for packages possibly selected in by weak dependencies
 755  *
 756  * m: already added solvables
 757  */
 758
 759 void
 760 solver_addrpmrulesforweak(Solver *solv, Map *m)
 761 {
 762   Pool *pool = solv->pool;
 763   Solvable *s;
 764   Id sup, *supp;
 765   int i, n;
 766
 767   /* foreach solvable in pool */
 768   for (i = n = 1; n < pool->nsolvables; i++, n++)
 769     {
 770       if (i == pool->nsolvables)                /* wrap i */
 771         i = 1;
 772       if (MAPTST(m, i))                         /* already added that one */
 773         continue;
 774
 775       s = pool->solvables + i;
 776       if (!s->repo)
 777         continue;
 778       if (s->repo != pool->installed && !pool_installable(pool, s))
 779         continue;       /* only look at installable ones */
 780
 781       sup = 0;
 782       if (s->supplements)
 783         {
 784           /* find possible supplements */
 785           supp = s->repo->idarraydata + s->supplements;
 786           while ((sup = *supp++) != 0)
 787             if (dep_possible(solv, sup, m))
 788               break;
 789         }
 790
 791       /* if nothing found, check for enhances */
 792       if (!sup && s->enhances)
 793         {
 794           supp = s->repo->idarraydata + s->enhances;
 795           while ((sup = *supp++) != 0)
 796             if (dep_possible(solv, sup, m))
 797               break;
 798         }
 799       /* if nothing found, goto next solvables */
 800       if (!sup)
 801         continue;
 802       solver_addrpmrulesforsolvable(solv, s, m);
 803       n = 0;                    /* check all solvables again because we added solvables to m */
 804     }
 805 }
 806
 807
 808 /*-------------------------------------------------------------------
 809  *
 810  * add package rules for possible updates
 811  *
 812  * s: solvable
 813  * m: map of already visited solvables
 814  * allow_all: 0 = dont allow downgrades, 1 = allow all candidates
 815  */
 816
 817 void
 818 solver_addrpmrulesforupdaters(Solver *solv, Solvable *s, Map *m, int allow_all)
 819 {
 820   Pool *pool = solv->pool;
 821   int i;
 822     /* queue and buffer for it */
 823   Queue qs;
 824   Id qsbuf[64];
 825
 826   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 827     /* find update candidates for 's' */
 828   policy_findupdatepackages(solv, s, &qs, allow_all);
 829     /* add rule for 's' if not already done */
 830   if (!MAPTST(m, s - pool->solvables))
 831     solver_addrpmrulesforsolvable(solv, s, m);
 832     /* foreach update candidate, add rule if not already done */
 833   for (i = 0; i < qs.count; i++)
 834     if (!MAPTST(m, qs.elements[i]))
 835       solver_addrpmrulesforsolvable(solv, pool->solvables + qs.elements[i], m);
 836   queue_free(&qs);
 837 }
 838
 839
 840 /***********************************************************************
 841  ***
 842  ***  Update/Feature rule part
 843  ***
 844  ***  Those rules make sure an installed package isn't silently deleted
 845  ***
 846  ***/
 847
 848 static Id
 849 finddistupgradepackages(Solver *solv, Solvable *s, Queue *qs, int allow_all)
 850 {
 851   Pool *pool = solv->pool;
 852   int i;
 853
 854   policy_findupdatepackages(solv, s, qs, allow_all ? allow_all : 2);
 855   if (!qs->count)
 856     {
 857       if (allow_all)
 858         return 0;       /* orphaned, don't create feature rule */
 859       /* check if this is an orphaned package */
 860       policy_findupdatepackages(solv, s, qs, 1);
 861       if (!qs->count)
 862         return 0;       /* orphaned, don't create update rule */
 863       qs->count = 0;
 864       return -SYSTEMSOLVABLE;   /* supported but not installable */
 865     }
 866   if (allow_all)
 867     return s - pool->solvables;
 868   /* check if it is ok to keep the installed package */
 869   for (i = 0; i < qs->count; i++)
 870     {
 871       Solvable *ns = pool->solvables + qs->elements[i];
 872       if (s->evr == ns->evr && solvable_identical(s, ns))
 873         return s - pool->solvables;
 874     }
 875   /* nope, it must be some other package */
 876   return -SYSTEMSOLVABLE;
 877 }
 878
 879 /* add packages from the dup repositories to the update candidates
 880  * this isn't needed for the global dup mode as all packages are
 881  * from dup repos in that case */
 882 static void
 883 addduppackages(Solver *solv, Solvable *s, Queue *qs)
 884 {
 885   Queue dupqs;
 886   Id p, dupqsbuf[64];
 887   int i;
 888   int oldnoupdateprovide = solv->noupdateprovide;
 889
 890   queue_init_buffer(&dupqs, dupqsbuf, sizeof(dupqsbuf)/sizeof(*dupqsbuf));
 891   solv->noupdateprovide = 1;
 892   policy_findupdatepackages(solv, s, &dupqs, 2);
 893   solv->noupdateprovide = oldnoupdateprovide;
 894   for (i = 0; i < dupqs.count; i++)
 895     {
 896       p = dupqs.elements[i];
 897       if (MAPTST(&solv->dupmap, p))
 898         queue_pushunique(qs, p);
 899     }
 900   queue_free(&dupqs);
 901 }
 902
 903 /*-------------------------------------------------------------------
 904  *
 905  * add rule for update
 906  *   (A|A1|A2|A3...)  An = update candidates for A
 907  *
 908  * s = (installed) solvable
 909  */
 910
 911 void
 912 solver_addupdaterule(Solver *solv, Solvable *s, int allow_all)
 913 {
 914   /* installed packages get a special upgrade allowed rule */
 915   Pool *pool = solv->pool;
 916   Id p, d;
 917   Queue qs;
 918   Id qsbuf[64];
 919
 920   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 921   p = s - pool->solvables;
 922   /* find update candidates for 's' */
 923   if (solv->dupmap_all)
 924     p = finddistupgradepackages(solv, s, &qs, allow_all);
 925   else
 926     policy_findupdatepackages(solv, s, &qs, allow_all);
 927   if (!allow_all && !solv->dupmap_all && solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
 928     addduppackages(solv, s, &qs);
 929
 930   if (!allow_all && qs.count && solv->noobsoletes.size)
 931     {
 932       int i, j;
 933
 934       d = pool_queuetowhatprovides(pool, &qs);
 935       /* filter out all noobsoletes packages as they don't update */
 936       for (i = j = 0; i < qs.count; i++)
 937         {
 938           if (MAPTST(&solv->noobsoletes, qs.elements[i]))
 939             {
 940               /* it's ok if they have same nevra */
 941               Solvable *ps = pool->solvables + qs.elements[i];
 942               if (ps->name != s->name || ps->evr != s->evr || ps->arch != s->arch)
 943                 continue;
 944             }
 945           qs.elements[j++] = qs.elements[i];
 946         }
 947       if (j < qs.count)
 948         {
 949           if (d && solv->installed && s->repo == solv->installed &&
 950               (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, s - pool->solvables - solv->installed->start))))
 951             {
 952               if (!solv->multiversionupdaters)
 953                 solv->multiversionupdaters = solv_calloc(solv->installed->end - solv->installed->start, sizeof(Id));
 954               solv->multiversionupdaters[s - pool->solvables - solv->installed->start] = d;
 955             }
 956           if (j == 0 && p == -SYSTEMSOLVABLE && solv->dupmap_all)
 957             {
 958               queue_push(&solv->orphaned, s - pool->solvables); /* treat as orphaned */
 959               j = qs.count;
 960             }
 961           qs.count = j;
 962         }
 963       else if (p != -SYSTEMSOLVABLE)
 964         {
 965           /* could fallthrough, but then we would do pool_queuetowhatprovides twice */
 966           queue_free(&qs);
 967           solver_addrule(solv, p, d);   /* allow update of s */
 968           return;
 969         }
 970     }
 971   if (qs.count && p == -SYSTEMSOLVABLE)
 972     p = queue_shift(&qs);
 973   d = qs.count ? pool_queuetowhatprovides(pool, &qs) : 0;
 974   queue_free(&qs);
 975   solver_addrule(solv, p, d);   /* allow update of s */
 976 }
 977
 978 static inline void
 979 disableupdaterule(Solver *solv, Id p)
 980 {
 981   Rule *r;
 982
 983   MAPSET(&solv->noupdate, p - solv->installed->start);
 984   r = solv->rules + solv->updaterules + (p - solv->installed->start);
 985   if (r->p && r->d >= 0)
 986     solver_disablerule(solv, r);
 987   r = solv->rules + solv->featurerules + (p - solv->installed->start);
 988   if (r->p && r->d >= 0)
 989     solver_disablerule(solv, r);
 990   if (solv->bestrules_pkg)
 991     {
 992       int i, ni;
 993       ni = solv->bestrules_end - solv->bestrules;
 994       for (i = 0; i < ni; i++)
 995         if (solv->bestrules_pkg[i] == p)
 996           solver_disablerule(solv, solv->rules + solv->bestrules + i);
 997     }
 998 }
 999
1000 static inline void
1001 reenableupdaterule(Solver *solv, Id p)
1002 {
1003   Pool *pool = solv->pool;
1004   Rule *r;
1005
1006   MAPCLR(&solv->noupdate, p - solv->installed->start);
1007   r = solv->rules + solv->updaterules + (p - solv->installed->start);
1008   if (r->p)
1009     {
1010       if (r->d < 0)
1011         {
1012           solver_enablerule(solv, r);
1013           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1014             {
1015               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1016               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1017             }
1018         }
1019     }
1020   else
1021     {
1022       r = solv->rules + solv->featurerules + (p - solv->installed->start);
1023       if (r->p && r->d < 0)
1024         {
1025           solver_enablerule(solv, r);
1026           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1027             {
1028               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1029               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1030             }
1031         }
1032     }
1033   if (solv->bestrules_pkg)
1034     {
1035       int i, ni;
1036       ni = solv->bestrules_end - solv->bestrules;
1037       for (i = 0; i < ni; i++)
1038         if (solv->bestrules_pkg[i] == p)
1039           solver_enablerule(solv, solv->rules + solv->bestrules + i);
1040     }
1041 }
1042
1043
1044 /***********************************************************************
1045  ***
1046  ***  Infarch rule part
1047  ***
1048  ***  Infarch rules make sure the solver uses the best architecture of
1049  ***  a package if multiple archetectures are available
1050  ***
1051  ***/
1052
1053 void
1054 solver_addinfarchrules(Solver *solv, Map *addedmap)
1055 {
1056   Pool *pool = solv->pool;
1057   int first, i, j;
1058   Id p, pp, a, aa, bestarch;
1059   Solvable *s, *ps, *bests;
1060   Queue badq, allowedarchs;
1061
1062   queue_init(&badq);
1063   queue_init(&allowedarchs);
1064   solv->infarchrules = solv->nrules;
1065   for (i = 1; i < pool->nsolvables; i++)
1066     {
1067       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1068         continue;
1069       s = pool->solvables + i;
1070       first = i;
1071       bestarch = 0;
1072       bests = 0;
1073       queue_empty(&allowedarchs);
1074       FOR_PROVIDES(p, pp, s->name)
1075         {
1076           ps = pool->solvables + p;
1077           if (ps->name != s->name || !MAPTST(addedmap, p))
1078             continue;
1079           if (p == i)
1080             first = 0;
1081           if (first)
1082             break;
1083           a = ps->arch;
1084           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1085           if (a != 1 && pool->installed && ps->repo == pool->installed)
1086             {
1087               if (!solv->dupmap_all && !(solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1088                 queue_pushunique(&allowedarchs, ps->arch);      /* also ok to keep this architecture */
1089               continue;         /* ignore installed solvables when calculating the best arch */
1090             }
1091           if (a && a != 1 && (!bestarch || a < bestarch))
1092             {
1093               bestarch = a;
1094               bests = ps;
1095             }
1096         }
1097       if (first)
1098         continue;
1099       /* speed up common case where installed package already has best arch */
1100       if (allowedarchs.count == 1 && bests && allowedarchs.elements[0] == bests->arch)
1101         allowedarchs.count--;   /* installed arch is best */
1102       queue_empty(&badq);
1103       FOR_PROVIDES(p, pp, s->name)
1104         {
1105           ps = pool->solvables + p;
1106           if (ps->name != s->name || !MAPTST(addedmap, p))
1107             continue;
1108           a = ps->arch;
1109           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1110           if (a != 1 && bestarch && ((a ^ bestarch) & 0xffff0000) != 0)
1111             {
1112               if (pool->installed && ps->repo == pool->installed)
1113                 continue;       /* always ok to keep an installed package */
1114               for (j = 0; j < allowedarchs.count; j++)
1115                 {
1116                   aa = allowedarchs.elements[j];
1117                   if (ps->arch == aa)
1118                     break;
1119                   aa = (aa <= pool->lastarch) ? pool->id2arch[aa] : 0;
1120                   if (aa && ((a ^ aa) & 0xffff0000) == 0)
1121                     break;      /* compatible */
1122                 }
1123               if (j == allowedarchs.count)
1124                 queue_push(&badq, p);
1125             }
1126         }
1127       if (!badq.count)
1128         continue;
1129       /* block all solvables in the badq! */
1130       for (j = 0; j < badq.count; j++)
1131         {
1132           p = badq.elements[j];
1133           solver_addrule(solv, -p, 0);
1134         }
1135     }
1136   queue_free(&badq);
1137   queue_free(&allowedarchs);
1138   solv->infarchrules_end = solv->nrules;
1139 }
1140
1141 static inline void
1142 disableinfarchrule(Solver *solv, Id name)
1143 {
1144   Pool *pool = solv->pool;
1145   Rule *r;
1146   int i;
1147   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1148     {
1149       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1150         solver_disablerule(solv, r);
1151     }
1152 }
1153
1154 static inline void
1155 reenableinfarchrule(Solver *solv, Id name)
1156 {
1157   Pool *pool = solv->pool;
1158   Rule *r;
1159   int i;
1160   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1161     {
1162       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1163         {
1164           solver_enablerule(solv, r);
1165           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1166             {
1167               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1168               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1169             }
1170         }
1171     }
1172 }
1173
1174
1175 /***********************************************************************
1176  ***
1177  ***  Dup rule part
1178  ***
1179  ***  Dup rules make sure a package is selected from the specified dup
1180  ***  repositories if an update candidate is included in one of them.
1181  ***
1182  ***/
1183
1184 static inline void
1185 solver_addtodupmaps(Solver *solv, Id p, Id how, int targeted)
1186 {
1187   Pool *pool = solv->pool;
1188   Solvable *ps, *s = pool->solvables + p;
1189   Repo *installed = solv->installed;
1190   Id pi, pip, obs, *obsp;
1191
1192   MAPSET(&solv->dupinvolvedmap, p);
1193   if (targeted)
1194     MAPSET(&solv->dupmap, p);
1195   FOR_PROVIDES(pi, pip, s->name)
1196     {
1197       ps = pool->solvables + pi;
1198       if (ps->name != s->name)
1199         continue;
1200       MAPSET(&solv->dupinvolvedmap, pi);
1201       if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
1202         {
1203           Id *opp, pi2;
1204           for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
1205             if (pool->solvables[pi2].repo != installed)
1206               MAPSET(&solv->dupinvolvedmap, pi2);
1207         }
1208       if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1209         {
1210           if (!solv->bestupdatemap.size)
1211             map_grow(&solv->bestupdatemap, installed->end - installed->start);
1212           MAPSET(&solv->bestupdatemap, pi - installed->start);
1213         }
1214       if (!targeted && ps->repo != installed)
1215         MAPSET(&solv->dupmap, pi);
1216     }
1217   if (s->repo == installed && solv->obsoletes && solv->obsoletes[p - installed->start])
1218     {
1219       Id *opp;
1220       for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (pi = *opp++) != 0;)
1221         {
1222           ps = pool->solvables + pi;
1223           if (ps->repo == installed)
1224             continue;
1225           MAPSET(&solv->dupinvolvedmap, pi);
1226           if (!targeted)
1227             MAPSET(&solv->dupmap, pi);
1228         }
1229     }
1230   if (targeted && s->repo != installed && s->obsoletes)
1231     {
1232       /* XXX: check obsoletes/provides combination */
1233       obsp = s->repo->idarraydata + s->obsoletes;
1234       while ((obs = *obsp++) != 0)
1235         {
1236           FOR_PROVIDES(pi, pip, obs)
1237             {
1238               Solvable *ps = pool->solvables + pi;
1239               if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1240                 continue;
1241               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1242                 continue;
1243               MAPSET(&solv->dupinvolvedmap, pi);
1244               if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
1245                 {
1246                   Id *opp, pi2;
1247                   for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
1248                     if (pool->solvables[pi2].repo != installed)
1249                       MAPSET(&solv->dupinvolvedmap, pi2);
1250                 }
1251               if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1252                 {
1253                   if (!solv->bestupdatemap.size)
1254                     map_grow(&solv->bestupdatemap, installed->end - installed->start);
1255                   MAPSET(&solv->bestupdatemap, pi - installed->start);
1256                 }
1257             }
1258         }
1259     }
1260 }
1261
1262 void
1263 solver_createdupmaps(Solver *solv)
1264 {
1265   Queue *job = &solv->job;
1266   Pool *pool = solv->pool;
1267   Repo *installed = solv->installed;
1268   Id select, how, what, p, pp;
1269   Solvable *s;
1270   int i, targeted;
1271
1272   map_init(&solv->dupmap, pool->nsolvables);
1273   map_init(&solv->dupinvolvedmap, pool->nsolvables);
1274   for (i = 0; i < job->count; i += 2)
1275     {
1276       how = job->elements[i];
1277       select = job->elements[i] & SOLVER_SELECTMASK;
1278       what = job->elements[i + 1];
1279       switch (how & SOLVER_JOBMASK)
1280         {
1281         case SOLVER_DISTUPGRADE:
1282           if (select == SOLVER_SOLVABLE_REPO)
1283             {
1284               Repo *repo;
1285               if (what <= 0 || what > pool->nrepos)
1286                 break;
1287               repo = pool_id2repo(pool, what);
1288               if (!repo)
1289                 break;
1290               if (repo != installed && !(how & SOLVER_TARGETED) && solv->noautotarget)
1291                 break;
1292               targeted = repo != installed || (how & SOLVER_TARGETED) != 0;
1293               FOR_REPO_SOLVABLES(repo, p, s)
1294                 {
1295                   if (repo != installed && !pool_installable(pool, s))
1296                     continue;
1297                   solver_addtodupmaps(solv, p, how, targeted);
1298                 }
1299             }
1300           else
1301             {
1302               targeted = how & SOLVER_TARGETED ? 1 : 0;
1303               if (installed && !targeted && !solv->noautotarget)
1304                 {
1305                   FOR_JOB_SELECT(p, pp, select, what)
1306                     if (pool->solvables[p].repo == installed)
1307                       break;
1308                   targeted = p == 0;
1309                 }
1310               else if (!installed && !solv->noautotarget)
1311                 targeted = 1;
1312               FOR_JOB_SELECT(p, pp, select, what)
1313                 {
1314                   Solvable *s = pool->solvables + p;
1315                   if (!s->repo)
1316                     continue;
1317                   if (s->repo != installed && !targeted)
1318                     continue;
1319                   if (s->repo != installed && !pool_installable(pool, s))
1320                     continue;
1321                   solver_addtodupmaps(solv, p, how, targeted);
1322                 }
1323             }
1324           break;
1325         default:
1326           break;
1327         }
1328     }
1329   MAPCLR(&solv->dupinvolvedmap, SYSTEMSOLVABLE);
1330 }
1331
1332 void
1333 solver_freedupmaps(Solver *solv)
1334 {
1335   map_free(&solv->dupmap);
1336   /* we no longer free solv->dupinvolvedmap as we need it in
1337    * policy's priority pruning code. sigh. */
1338 }
1339
1340 void
1341 solver_addduprules(Solver *solv, Map *addedmap)
1342 {
1343   Pool *pool = solv->pool;
1344   Id p, pp;
1345   Solvable *s, *ps;
1346   int first, i;
1347
1348   solv->duprules = solv->nrules;
1349   for (i = 1; i < pool->nsolvables; i++)
1350     {
1351       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1352         continue;
1353       s = pool->solvables + i;
1354       first = i;
1355       FOR_PROVIDES(p, pp, s->name)
1356         {
1357           ps = pool->solvables + p;
1358           if (ps->name != s->name || !MAPTST(addedmap, p))
1359             continue;
1360           if (p == i)
1361             first = 0;
1362           if (first)
1363             break;
1364           if (!MAPTST(&solv->dupinvolvedmap, p))
1365             continue;
1366           if (solv->installed && ps->repo == solv->installed)
1367             {
1368               if (!solv->updatemap.size)
1369                 map_grow(&solv->updatemap, solv->installed->end - solv->installed->start);
1370               MAPSET(&solv->updatemap, p - solv->installed->start);
1371               if (!MAPTST(&solv->dupmap, p))
1372                 {
1373                   Id ip, ipp;
1374                   /* is installed identical to a good one? */
1375                   FOR_PROVIDES(ip, ipp, ps->name)
1376                     {
1377                       Solvable *is = pool->solvables + ip;
1378                       if (!MAPTST(&solv->dupmap, ip))
1379                         continue;
1380                       if (is->evr == ps->evr && solvable_identical(ps, is))
1381                         break;
1382                     }
1383                   if (!ip)
1384                     solver_addrule(solv, -p, 0);        /* no match, sorry */
1385                   else
1386                     MAPSET(&solv->dupmap, p);           /* for best rules processing */
1387                 }
1388             }
1389           else if (!MAPTST(&solv->dupmap, p))
1390             solver_addrule(solv, -p, 0);
1391         }
1392     }
1393   solv->duprules_end = solv->nrules;
1394 }
1395
1396
1397 static inline void
1398 disableduprule(Solver *solv, Id name)
1399 {
1400   Pool *pool = solv->pool;
1401   Rule *r;
1402   int i;
1403   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1404     {
1405       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1406         solver_disablerule(solv, r);
1407     }
1408 }
1409
1410 static inline void
1411 reenableduprule(Solver *solv, Id name)
1412 {
1413   Pool *pool = solv->pool;
1414   Rule *r;
1415   int i;
1416   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1417     {
1418       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1419         {
1420           solver_enablerule(solv, r);
1421           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1422             {
1423               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1424               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1425             }
1426         }
1427     }
1428 }
1429
1430
1431 /***********************************************************************
1432  ***
1433  ***  Policy rule disabling/reenabling
1434  ***
1435  ***  Disable all policy rules that conflict with our jobs. If a job
1436  ***  gets disabled later on, reenable the involved policy rules again.
1437  ***
1438  ***/
1439
1440 #define DISABLE_UPDATE  1
1441 #define DISABLE_INFARCH 2
1442 #define DISABLE_DUP     3
1443
1444 /*
1445  * add all installed packages that package p obsoletes to Queue q.
1446  * Package p is not installed. Also, we know that if
1447  * solv->keepexplicitobsoletes is not set, p is not in the noobs map.
1448  * Entries may get added multiple times.
1449  */
1450 static void
1451 add_obsoletes(Solver *solv, Id p, Queue *q)
1452 {
1453   Pool *pool = solv->pool;
1454   Repo *installed = solv->installed;
1455   Id p2, pp2;
1456   Solvable *s = pool->solvables + p;
1457   Id obs, *obsp;
1458   Id lastp2 = 0;
1459
1460   if (!solv->keepexplicitobsoletes || !(solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p)))
1461     {
1462       FOR_PROVIDES(p2, pp2, s->name)
1463         {
1464           Solvable *ps = pool->solvables + p2;
1465           if (ps->repo != installed)
1466             continue;
1467           if (!pool->implicitobsoleteusesprovides && ps->name != s->name)
1468             continue;
1469           if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1470             continue;
1471           queue_push(q, p2);
1472           lastp2 = p2;
1473         }
1474     }
1475   if (!s->obsoletes)
1476     return;
1477   obsp = s->repo->idarraydata + s->obsoletes;
1478   while ((obs = *obsp++) != 0)
1479     FOR_PROVIDES(p2, pp2, obs)
1480       {
1481         Solvable *ps = pool->solvables + p2;
1482         if (ps->repo != installed)
1483           continue;
1484         if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1485           continue;
1486         if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1487           continue;
1488         if (p2 == lastp2)
1489           continue;
1490         queue_push(q, p2);
1491         lastp2 = p2;
1492       }
1493 }
1494
1495 /*
1496  * Call add_obsoletes and intersect the result with the
1497  * elements in Queue q starting at qstart.
1498  * Assumes that it's the first call if qstart == q->count.
1499  * May use auxillary map m for the intersection process, all
1500  * elements of q starting at qstart must have their bit cleared.
1501  * (This is also true after the function returns.)
1502  */
1503 static void
1504 intersect_obsoletes(Solver *solv, Id p, Queue *q, int qstart, Map *m)
1505 {
1506   int i, j;
1507   int qcount = q->count;
1508
1509   add_obsoletes(solv, p, q);
1510   if (qcount == qstart)
1511     return;     /* first call */
1512   if (qcount == q->count)
1513     j = qstart;
1514   else if (qcount == qstart + 1)
1515     {
1516       /* easy if there's just one element */
1517       j = qstart;
1518       for (i = qcount; i < q->count; i++)
1519         if (q->elements[i] == q->elements[qstart])
1520           {
1521             j++;        /* keep the element */
1522             break;
1523           }
1524     }
1525   else if (!m->size && q->count - qstart <= 8)
1526     {
1527       /* faster than a map most of the time */
1528       int k;
1529       for (i = j = qstart; i < qcount; i++)
1530         {
1531           Id ip = q->elements[i];
1532           for (k = qcount; k < q->count; k++)
1533             if (q->elements[k] == ip)
1534               {
1535                 q->elements[j++] = ip;
1536                 break;
1537               }
1538         }
1539     }
1540   else
1541     {
1542       /* for the really pathologic cases we use the map */
1543       Repo *installed = solv->installed;
1544       if (!m->size)
1545         map_init(m, installed->end - installed->start);
1546       for (i = qcount; i < q->count; i++)
1547         MAPSET(m, q->elements[i] - installed->start);
1548       for (i = j = qstart; i < qcount; i++)
1549         if (MAPTST(m, q->elements[i] - installed->start))
1550           {
1551             MAPCLR(m, q->elements[i] - installed->start);
1552             q->elements[j++] = q->elements[i];
1553           }
1554     }
1555   queue_truncate(q, j);
1556 }
1557
1558 static void
1559 jobtodisablelist(Solver *solv, Id how, Id what, Queue *q)
1560 {
1561   Pool *pool = solv->pool;
1562   Id select, p, pp;
1563   Repo *installed;
1564   Solvable *s;
1565   int i, j, set, qstart;
1566   Map omap;
1567
1568   installed = solv->installed;
1569   select = how & SOLVER_SELECTMASK;
1570   switch (how & SOLVER_JOBMASK)
1571     {
1572     case SOLVER_INSTALL:
1573       set = how & SOLVER_SETMASK;
1574       if (!(set & SOLVER_NOAUTOSET))
1575         {
1576           /* automatically add set bits by analysing the job */
1577           if (select == SOLVER_SOLVABLE_NAME)
1578             set |= SOLVER_SETNAME;
1579           if (select == SOLVER_SOLVABLE)
1580             set |= SOLVER_SETNAME | SOLVER_SETARCH | SOLVER_SETVENDOR | SOLVER_SETREPO | SOLVER_SETEVR;
1581           else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
1582             {
1583               Reldep *rd = GETRELDEP(pool, what);
1584               if (rd->flags == REL_EQ && select == SOLVER_SOLVABLE_NAME)
1585                 {
1586                   if (pool->disttype != DISTTYPE_DEB)
1587                     {
1588                       const char *evr = pool_id2str(pool, rd->evr);
1589                       if (strchr(evr, '-'))
1590                         set |= SOLVER_SETEVR;
1591                       else
1592                         set |= SOLVER_SETEV;
1593                     }
1594                   else
1595                     set |= SOLVER_SETEVR;
1596                 }
1597               if (rd->flags <= 7 && ISRELDEP(rd->name))
1598                 rd = GETRELDEP(pool, rd->name);
1599               if (rd->flags == REL_ARCH)
1600                 set |= SOLVER_SETARCH;
1601             }
1602         }
1603       else
1604         set &= ~SOLVER_NOAUTOSET;
1605       if (!set)
1606         return;
1607       if ((set & SOLVER_SETARCH) != 0 && solv->infarchrules != solv->infarchrules_end)
1608         {
1609           if (select == SOLVER_SOLVABLE)
1610             queue_push2(q, DISABLE_INFARCH, pool->solvables[what].name);
1611           else
1612             {
1613               int qcnt = q->count;
1614               /* does not work for SOLVER_SOLVABLE_ALL and SOLVER_SOLVABLE_REPO, but
1615                  they are not useful for SOLVER_INSTALL jobs anyway */
1616               FOR_JOB_SELECT(p, pp, select, what)
1617                 {
1618                   s = pool->solvables + p;
1619                   /* unify names */
1620                   for (i = qcnt; i < q->count; i += 2)
1621                     if (q->elements[i + 1] == s->name)
1622                       break;
1623                   if (i < q->count)
1624                     continue;
1625                   queue_push2(q, DISABLE_INFARCH, s->name);
1626                 }
1627             }
1628         }
1629       if ((set & SOLVER_SETREPO) != 0 && solv->duprules != solv->duprules_end)
1630         {
1631           if (select == SOLVER_SOLVABLE)
1632             queue_push2(q, DISABLE_DUP, pool->solvables[what].name);
1633           else
1634             {
1635               int qcnt = q->count;
1636               FOR_JOB_SELECT(p, pp, select, what)
1637                 {
1638                   s = pool->solvables + p;
1639                   /* unify names */
1640                   for (i = qcnt; i < q->count; i += 2)
1641                     if (q->elements[i + 1] == s->name)
1642                       break;
1643                   if (i < q->count)
1644                     continue;
1645                   queue_push2(q, DISABLE_DUP, s->name);
1646                 }
1647             }
1648         }
1649       if (!installed || installed->end == installed->start)
1650         return;
1651       /* now the hard part: disable some update rules */
1652
1653       /* first check if we have noobs or installed packages in the job */
1654       i = j = 0;
1655       FOR_JOB_SELECT(p, pp, select, what)
1656         {
1657           if (pool->solvables[p].repo == installed)
1658             j = p;
1659           else if (solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p) && !solv->keepexplicitobsoletes)
1660             return;
1661           i++;
1662         }
1663       if (j)    /* have installed packages */
1664         {
1665           /* this is for dupmap_all jobs, it can go away if we create
1666            * duprules for them */
1667           if (i == 1 && (set & SOLVER_SETREPO) != 0)
1668             queue_push2(q, DISABLE_UPDATE, j);
1669           return;
1670         }
1671
1672       omap.size = 0;
1673       qstart = q->count;
1674       FOR_JOB_SELECT(p, pp, select, what)
1675         {
1676           intersect_obsoletes(solv, p, q, qstart, &omap);
1677           if (q->count == qstart)
1678             break;
1679         }
1680       if (omap.size)
1681         map_free(&omap);
1682
1683       if (qstart == q->count)
1684         return;         /* nothing to prune */
1685
1686       /* convert result to (DISABLE_UPDATE, p) pairs */
1687       i = q->count;
1688       for (j = qstart; j < i; j++)
1689         queue_push(q, q->elements[j]);
1690       for (j = qstart; j < q->count; j += 2)
1691         {
1692           q->elements[j] = DISABLE_UPDATE;
1693           q->elements[j + 1] = q->elements[i++];
1694         }
1695
1696       /* now that we know which installed packages are obsoleted check each of them */
1697       if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
1698         return;         /* all is set, nothing to do */
1699
1700       for (i = j = qstart; i < q->count; i += 2)
1701         {
1702           Solvable *is = pool->solvables + q->elements[i + 1];
1703           FOR_JOB_SELECT(p, pp, select, what)
1704             {
1705               int illegal = 0;
1706               s = pool->solvables + p;
1707               if ((set & SOLVER_SETEVR) != 0)
1708                 illegal |= POLICY_ILLEGAL_DOWNGRADE;    /* ignore */
1709               if ((set & SOLVER_SETNAME) != 0)
1710                 illegal |= POLICY_ILLEGAL_NAMECHANGE;   /* ignore */
1711               if ((set & SOLVER_SETARCH) != 0)
1712                 illegal |= POLICY_ILLEGAL_ARCHCHANGE;   /* ignore */
1713               if ((set & SOLVER_SETVENDOR) != 0)
1714                 illegal |= POLICY_ILLEGAL_VENDORCHANGE; /* ignore */
1715               illegal = policy_is_illegal(solv, is, s, illegal);
1716               if (illegal && illegal == POLICY_ILLEGAL_DOWNGRADE && (set & SOLVER_SETEV) != 0)
1717                 {
1718                   /* it's ok if the EV is different */
1719                   if (pool_evrcmp(pool, is->evr, s->evr, EVRCMP_COMPARE_EVONLY) != 0)
1720                     illegal = 0;
1721                 }
1722               if (illegal)
1723                 break;
1724             }
1725           if (!p)
1726             {
1727               /* no package conflicts with the update rule */
1728               /* thus keep the DISABLE_UPDATE */
1729               q->elements[j + 1] = q->elements[i + 1];
1730               j += 2;
1731             }
1732         }
1733       queue_truncate(q, j);
1734       return;
1735
1736     case SOLVER_ERASE:
1737       if (!installed)
1738         break;
1739       if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
1740         FOR_REPO_SOLVABLES(installed, p, s)
1741           queue_push2(q, DISABLE_UPDATE, p);
1742       FOR_JOB_SELECT(p, pp, select, what)
1743         if (pool->solvables[p].repo == installed)
1744           queue_push2(q, DISABLE_UPDATE, p);
1745       return;
1746     default:
1747       return;
1748     }
1749 }
1750
1751 /* disable all policy rules that are in conflict with our job list */
1752 void
1753 solver_disablepolicyrules(Solver *solv)
1754 {
1755   Queue *job = &solv->job;
1756   int i, j;
1757   Queue allq;
1758   Rule *r;
1759   Id lastjob = -1;
1760   Id allqbuf[128];
1761
1762   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1763
1764   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1765     {
1766       r = solv->rules + i;
1767       if (r->d < 0)     /* disabled? */
1768         continue;
1769       j = solv->ruletojob.elements[i - solv->jobrules];
1770       if (j == lastjob)
1771         continue;
1772       lastjob = j;
1773       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1774     }
1775   if (solv->cleandepsmap.size)
1776     {
1777       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1778       for (i = solv->installed->start; i < solv->installed->end; i++)
1779         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1780           queue_push2(&allq, DISABLE_UPDATE, i);
1781     }
1782   MAPZERO(&solv->noupdate);
1783   for (i = 0; i < allq.count; i += 2)
1784     {
1785       Id type = allq.elements[i], arg = allq.elements[i + 1];
1786       switch(type)
1787         {
1788         case DISABLE_UPDATE:
1789           disableupdaterule(solv, arg);
1790           break;
1791         case DISABLE_INFARCH:
1792           disableinfarchrule(solv, arg);
1793           break;
1794         case DISABLE_DUP:
1795           disableduprule(solv, arg);
1796           break;
1797         default:
1798           break;
1799         }
1800     }
1801   queue_free(&allq);
1802 }
1803
1804 /* we just disabled job #jobidx, now reenable all policy rules that were
1805  * disabled because of this job */
1806 void
1807 solver_reenablepolicyrules(Solver *solv, int jobidx)
1808 {
1809   Queue *job = &solv->job;
1810   int i, j;
1811   Queue q, allq;
1812   Rule *r;
1813   Id lastjob = -1;
1814   Id qbuf[32], allqbuf[128];
1815
1816   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
1817   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1818   jobtodisablelist(solv, job->elements[jobidx - 1], job->elements[jobidx], &q);
1819   if (!q.count)
1820     return;
1821   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1822     {
1823       r = solv->rules + i;
1824       if (r->d < 0)     /* disabled? */
1825         continue;
1826       j = solv->ruletojob.elements[i - solv->jobrules];
1827       if (j == lastjob)
1828         continue;
1829       lastjob = j;
1830       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1831     }
1832   if (solv->cleandepsmap.size)
1833     {
1834       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1835       for (i = solv->installed->start; i < solv->installed->end; i++)
1836         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1837           queue_push2(&allq, DISABLE_UPDATE, i);
1838     }
1839   for (j = 0; j < q.count; j += 2)
1840     {
1841       Id type = q.elements[j], arg = q.elements[j + 1];
1842       for (i = 0; i < allq.count; i += 2)
1843         if (allq.elements[i] == type && allq.elements[i + 1] == arg)
1844           break;
1845       if (i < allq.count)
1846         continue;       /* still disabled */
1847       switch(type)
1848         {
1849         case DISABLE_UPDATE:
1850           reenableupdaterule(solv, arg);
1851           break;
1852         case DISABLE_INFARCH:
1853           reenableinfarchrule(solv, arg);
1854           break;
1855         case DISABLE_DUP:
1856           reenableduprule(solv, arg);
1857           break;
1858         }
1859     }
1860   queue_free(&allq);
1861   queue_free(&q);
1862 }
1863
1864 /* we just removed a package from the cleandeps map, now reenable all policy rules that were
1865  * disabled because of this */
1866 void
1867 solver_reenablepolicyrules_cleandeps(Solver *solv, Id pkg)
1868 {
1869   Queue *job = &solv->job;
1870   int i, j;
1871   Queue allq;
1872   Rule *r;
1873   Id lastjob = -1;
1874   Id allqbuf[128];
1875
1876   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1877   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1878     {
1879       r = solv->rules + i;
1880       if (r->d < 0)     /* disabled? */
1881         continue;
1882       j = solv->ruletojob.elements[i - solv->jobrules];
1883       if (j == lastjob)
1884         continue;
1885       lastjob = j;
1886       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1887     }
1888   for (i = 0; i < allq.count; i += 2)
1889     if (allq.elements[i] == DISABLE_UPDATE && allq.elements[i + 1] == pkg)
1890       break;
1891   if (i == allq.count)
1892     reenableupdaterule(solv, pkg);
1893   queue_free(&allq);
1894 }
1895
1896
1897 /***********************************************************************
1898  ***
1899  ***  Rule info part, tell the user what the rule is about.
1900  ***
1901  ***/
1902
1903 static void
1904 addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep)
1905 {
1906   Pool *pool = solv->pool;
1907   Rule *r;
1908   Id w2, op, od, ow2;
1909
1910   /* check if this creates the rule we're searching for */
1911   r = solv->rules + solv->ruleinfoq->elements[0];
1912   op = r->p;
1913   od = r->d < 0 ? -r->d - 1 : r->d;
1914   ow2 = 0;
1915
1916   /* normalize */
1917   w2 = d > 0 ? 0 : d;
1918   if (p < 0 && d > 0 && (!pool->whatprovidesdata[d] || !pool->whatprovidesdata[d + 1]))
1919     {
1920       w2 = pool->whatprovidesdata[d];
1921       d = 0;
1922
1923     }
1924   if (p > 0 && d < 0)           /* this hack is used for buddy deps */
1925     {
1926       w2 = p;
1927       p = d;
1928     }
1929
1930   if (d > 0)
1931     {
1932       if (p != op && !od)
1933         return;
1934       if (d != od)
1935         {
1936           Id *dp = pool->whatprovidesdata + d;
1937           Id *odp = pool->whatprovidesdata + od;
1938           while (*dp)
1939             if (*dp++ != *odp++)
1940               return;
1941           if (*odp)
1942             return;
1943         }
1944       w2 = 0;
1945       /* handle multiversion conflict rules */
1946       if (p < 0 && pool->whatprovidesdata[d] < 0)
1947         {
1948           w2 = pool->whatprovidesdata[d];
1949           /* XXX: free memory */
1950         }
1951     }
1952   else
1953     {
1954       if (od)
1955         return;
1956       ow2 = r->w2;
1957       if (p > w2)
1958         {
1959           if (w2 != op || p != ow2)
1960             return;
1961         }
1962       else
1963         {
1964           if (p != op || w2 != ow2)
1965             return;
1966         }
1967     }
1968   /* yep, rule matches. record info */
1969   queue_push(solv->ruleinfoq, type);
1970   if (type == SOLVER_RULE_RPM_SAME_NAME)
1971     {
1972       /* we normalize same name order */
1973       queue_push(solv->ruleinfoq, op < 0 ? -op : 0);
1974       queue_push(solv->ruleinfoq, ow2 < 0 ? -ow2 : 0);
1975     }
1976   else
1977     {
1978       queue_push(solv->ruleinfoq, p < 0 ? -p : 0);
1979       queue_push(solv->ruleinfoq, w2 < 0 ? -w2 : 0);
1980     }
1981   queue_push(solv->ruleinfoq, dep);
1982 }
1983
1984 static int
1985 solver_allruleinfos_cmp(const void *ap, const void *bp, void *dp)
1986 {
1987   const Id *a = ap, *b = bp;
1988   int r;
1989
1990   r = a[0] - b[0];
1991   if (r)
1992     return r;
1993   r = a[1] - b[1];
1994   if (r)
1995     return r;
1996   r = a[2] - b[2];
1997   if (r)
1998     return r;
1999   r = a[3] - b[3];
2000   if (r)
2001     return r;
2002   return 0;
2003 }
2004
2005 int
2006 solver_allruleinfos(Solver *solv, Id rid, Queue *rq)
2007 {
2008   Pool *pool = solv->pool;
2009   Rule *r = solv->rules + rid;
2010   int i, j;
2011
2012   queue_empty(rq);
2013   if (rid <= 0 || rid >= solv->rpmrules_end)
2014     {
2015       Id type, from, to, dep;
2016       type = solver_ruleinfo(solv, rid, &from, &to, &dep);
2017       queue_push(rq, type);
2018       queue_push(rq, from);
2019       queue_push(rq, to);
2020       queue_push(rq, dep);
2021       return 1;
2022     }
2023   if (r->p >= 0)
2024     return 0;
2025   queue_push(rq, rid);
2026   solv->ruleinfoq = rq;
2027   solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2028   /* also try reverse direction for conflicts */
2029   if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2030     solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2031   solv->ruleinfoq = 0;
2032   queue_shift(rq);
2033   /* now sort & unify em */
2034   if (!rq->count)
2035     return 0;
2036   solv_sort(rq->elements, rq->count / 4, 4 * sizeof(Id), solver_allruleinfos_cmp, 0);
2037   /* throw out identical entries */
2038   for (i = j = 0; i < rq->count; i += 4)
2039     {
2040       if (j)
2041         {
2042           if (rq->elements[i] == rq->elements[j - 4] &&
2043               rq->elements[i + 1] == rq->elements[j - 3] &&
2044               rq->elements[i + 2] == rq->elements[j - 2] &&
2045               rq->elements[i + 3] == rq->elements[j - 1])
2046             continue;
2047         }
2048       rq->elements[j++] = rq->elements[i];
2049       rq->elements[j++] = rq->elements[i + 1];
2050       rq->elements[j++] = rq->elements[i + 2];
2051       rq->elements[j++] = rq->elements[i + 3];
2052     }
2053   rq->count = j;
2054   return j / 4;
2055 }
2056
2057 SolverRuleinfo
2058 solver_ruleinfo(Solver *solv, Id rid, Id *fromp, Id *top, Id *depp)
2059 {
2060   Pool *pool = solv->pool;
2061   Rule *r = solv->rules + rid;
2062   SolverRuleinfo type = SOLVER_RULE_UNKNOWN;
2063
2064   if (fromp)
2065     *fromp = 0;
2066   if (top)
2067     *top = 0;
2068   if (depp)
2069     *depp = 0;
2070   if (rid > 0 && rid < solv->rpmrules_end)
2071     {
2072       Queue rq;
2073       int i;
2074
2075       if (r->p >= 0)
2076         return SOLVER_RULE_RPM;
2077       if (fromp)
2078         *fromp = -r->p;
2079       queue_init(&rq);
2080       queue_push(&rq, rid);
2081       solv->ruleinfoq = &rq;
2082       solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2083       /* also try reverse direction for conflicts */
2084       if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2085         solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2086       solv->ruleinfoq = 0;
2087       type = SOLVER_RULE_RPM;
2088       for (i = 1; i < rq.count; i += 4)
2089         {
2090           Id qt, qo, qp, qd;
2091           qt = rq.elements[i];
2092           qp = rq.elements[i + 1];
2093           qo = rq.elements[i + 2];
2094           qd = rq.elements[i + 3];
2095           if (type == SOLVER_RULE_RPM || type > qt)
2096             {
2097               type = qt;
2098               if (fromp)
2099                 *fromp = qp;
2100               if (top)
2101                 *top = qo;
2102               if (depp)
2103                 *depp = qd;
2104             }
2105         }
2106       queue_free(&rq);
2107       return type;
2108     }
2109   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2110     {
2111       Id jidx = solv->ruletojob.elements[rid - solv->jobrules];
2112       if (fromp)
2113         *fromp = jidx;
2114       if (top)
2115         *top = solv->job.elements[jidx];
2116       if (depp)
2117         *depp = solv->job.elements[jidx + 1];
2118       if ((r->d == 0 || r->d == -1) && r->w2 == 0 && r->p == -SYSTEMSOLVABLE)
2119         {
2120           if ((solv->job.elements[jidx] & SOLVER_SELECTMASK) == SOLVER_SOLVABLE_NAME)
2121             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2122           if ((solv->job.elements[jidx] & SOLVER_SELECTMASK) == SOLVER_SOLVABLE_PROVIDES)
2123             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2124         }
2125       return SOLVER_RULE_JOB;
2126     }
2127   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2128     {
2129       if (fromp)
2130         *fromp = solv->installed->start + (rid - solv->updaterules);
2131       return SOLVER_RULE_UPDATE;
2132     }
2133   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2134     {
2135       if (fromp)
2136         *fromp = solv->installed->start + (rid - solv->featurerules);
2137       return SOLVER_RULE_FEATURE;
2138     }
2139   if (rid >= solv->duprules && rid < solv->duprules_end)
2140     {
2141       if (fromp)
2142         *fromp = -r->p;
2143       if (depp)
2144         *depp = pool->solvables[-r->p].name;
2145       return SOLVER_RULE_DISTUPGRADE;
2146     }
2147   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2148     {
2149       if (fromp)
2150         *fromp = -r->p;
2151       if (depp)
2152         *depp = pool->solvables[-r->p].name;
2153       return SOLVER_RULE_INFARCH;
2154     }
2155   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2156     {
2157       return SOLVER_RULE_BEST;
2158     }
2159   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2160     {
2161       return SOLVER_RULE_CHOICE;
2162     }
2163   if (rid >= solv->learntrules)
2164     {
2165       return SOLVER_RULE_LEARNT;
2166     }
2167   return SOLVER_RULE_UNKNOWN;
2168 }
2169
2170 SolverRuleinfo
2171 solver_ruleclass(Solver *solv, Id rid)
2172 {
2173   if (rid <= 0)
2174     return SOLVER_RULE_UNKNOWN;
2175   if (rid > 0 && rid < solv->rpmrules_end)
2176     return SOLVER_RULE_RPM;
2177   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2178     return SOLVER_RULE_JOB;
2179   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2180     return SOLVER_RULE_UPDATE;
2181   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2182     return SOLVER_RULE_FEATURE;
2183   if (rid >= solv->duprules && rid < solv->duprules_end)
2184     return SOLVER_RULE_DISTUPGRADE;
2185   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2186     return SOLVER_RULE_INFARCH;
2187   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2188     return SOLVER_RULE_BEST;
2189   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2190     return SOLVER_RULE_CHOICE;
2191   if (rid >= solv->learntrules)
2192     return SOLVER_RULE_LEARNT;
2193   return SOLVER_RULE_UNKNOWN;
2194 }
2195
2196 void
2197 solver_ruleliterals(Solver *solv, Id rid, Queue *q)
2198 {
2199   Pool *pool = solv->pool;
2200   Id p, pp;
2201   Rule *r;
2202
2203   queue_empty(q);
2204   r = solv->rules + rid;
2205   FOR_RULELITERALS(p, pp, r)
2206     if (p != -SYSTEMSOLVABLE)
2207       queue_push(q, p);
2208   if (!q->count)
2209     queue_push(q, -SYSTEMSOLVABLE);     /* hmm, better to return an empty result? */
2210 }
2211
2212 int
2213 solver_rule2jobidx(Solver *solv, Id rid)
2214 {
2215   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2216     return 0;
2217   return solv->ruletojob.elements[rid - solv->jobrules] + 1;
2218 }
2219
2220 Id
2221 solver_rule2job(Solver *solv, Id rid, Id *whatp)
2222 {
2223   int idx;
2224   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2225     {
2226       if (whatp)
2227         *whatp = 0;
2228       return 0;
2229     }
2230   idx = solv->ruletojob.elements[rid - solv->jobrules];
2231   if (whatp)
2232     *whatp = solv->job.elements[idx + 1];
2233   return solv->job.elements[idx];
2234 }
2235
2236 void
2237 solver_addchoicerules(Solver *solv)
2238 {
2239   Pool *pool = solv->pool;
2240   Map m, mneg;
2241   Rule *r;
2242   Queue q, qi;
2243   int i, j, rid, havechoice;
2244   Id p, d, pp;
2245   Id p2, pp2;
2246   Solvable *s, *s2;
2247   Id lastaddedp, lastaddedd;
2248   int lastaddedcnt;
2249
2250   solv->choicerules = solv->nrules;
2251   if (!pool->installed)
2252     {
2253       solv->choicerules_end = solv->nrules;
2254       return;
2255     }
2256   solv->choicerules_ref = solv_calloc(solv->rpmrules_end, sizeof(Id));
2257   queue_init(&q);
2258   queue_init(&qi);
2259   map_init(&m, pool->nsolvables);
2260   map_init(&mneg, pool->nsolvables);
2261   /* set up negative assertion map from infarch and dup rules */
2262   for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
2263     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2264       MAPSET(&mneg, -r->p);
2265   for (rid = solv->duprules, r = solv->rules + rid; rid < solv->duprules_end; rid++, r++)
2266     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2267       MAPSET(&mneg, -r->p);
2268   lastaddedp = 0;
2269   lastaddedd = 0;
2270   lastaddedcnt = 0;
2271   for (rid = 1; rid < solv->rpmrules_end ; rid++)
2272     {
2273       r = solv->rules + rid;
2274       if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 < 0))
2275         continue;       /* only look at requires rules */
2276       /* solver_printrule(solv, SOLV_DEBUG_RESULT, r); */
2277       queue_empty(&q);
2278       queue_empty(&qi);
2279       havechoice = 0;
2280       FOR_RULELITERALS(p, pp, r)
2281         {
2282           if (p < 0)
2283             continue;
2284           s = pool->solvables + p;
2285           if (!s->repo)
2286             continue;
2287           if (s->repo == pool->installed)
2288             {
2289               queue_push(&q, p);
2290               continue;
2291             }
2292           /* check if this package is "blocked" by a installed package */
2293           s2 = 0;
2294           FOR_PROVIDES(p2, pp2, s->name)
2295             {
2296               s2 = pool->solvables + p2;
2297               if (s2->repo != pool->installed)
2298                 continue;
2299               if (!pool->implicitobsoleteusesprovides && s->name != s2->name)
2300                 continue;
2301               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2302                 continue;
2303               break;
2304             }
2305           if (p2)
2306             {
2307               /* found installed package p2 that we can update to p */
2308               if (MAPTST(&mneg, p))
2309                 continue;
2310               if (policy_is_illegal(solv, s2, s, 0))
2311                 continue;
2312               queue_push(&qi, p2);
2313               queue_push(&q, p);
2314               continue;
2315             }
2316           if (s->obsoletes)
2317             {
2318               Id obs, *obsp = s->repo->idarraydata + s->obsoletes;
2319               s2 = 0;
2320               while ((obs = *obsp++) != 0)
2321                 {
2322                   FOR_PROVIDES(p2, pp2, obs)
2323                     {
2324                       s2 = pool->solvables + p2;
2325                       if (s2->repo != pool->installed)
2326                         continue;
2327                       if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
2328                         continue;
2329                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2330                         continue;
2331                       break;
2332                     }
2333                   if (p2)
2334                     break;
2335                 }
2336               if (obs)
2337                 {
2338                   /* found installed package p2 that we can update to p */
2339                   if (MAPTST(&mneg, p))
2340                     continue;
2341                   if (policy_is_illegal(solv, s2, s, 0))
2342                     continue;
2343                   queue_push(&qi, p2);
2344                   queue_push(&q, p);
2345                   continue;
2346                 }
2347             }
2348           /* package p is independent of the installed ones */
2349           havechoice = 1;
2350         }
2351       if (!havechoice || !q.count)
2352         continue;       /* no choice */
2353
2354       /* now check the update rules of the installed package.
2355        * if all packages of the update rules are contained in
2356        * the dependency rules, there's no need to set up the choice rule */
2357       map_empty(&m);
2358       FOR_RULELITERALS(p, pp, r)
2359         if (p > 0)
2360           MAPSET(&m, p);
2361       for (i = 0; i < qi.count; i++)
2362         {
2363           Rule *ur;
2364           if (!qi.elements[i])
2365             continue;
2366           ur = solv->rules + solv->updaterules + (qi.elements[i] - pool->installed->start);
2367           if (!ur->p)
2368             ur = solv->rules + solv->featurerules + (qi.elements[i] - pool->installed->start);
2369           if (!ur->p)
2370             continue;
2371           FOR_RULELITERALS(p, pp, ur)
2372             if (!MAPTST(&m, p))
2373               break;
2374           if (p)
2375             break;
2376           for (j = i + 1; j < qi.count; j++)
2377             if (qi.elements[i] == qi.elements[j])
2378               qi.elements[j] = 0;
2379         }
2380       if (i == qi.count)
2381         {
2382 #if 0
2383           printf("skipping choice ");
2384           solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2385 #endif
2386           continue;
2387         }
2388
2389       /* don't add identical rules */
2390       if (lastaddedp == r->p && lastaddedcnt == q.count)
2391         {
2392           for (i = 0; i < q.count; i++)
2393             if (q.elements[i] != pool->whatprovidesdata[lastaddedd + i])
2394               break;
2395           if (i == q.count)
2396             continue;   /* already added that one */
2397         }
2398
2399       d = q.count ? pool_queuetowhatprovides(pool, &q) : 0;
2400       solver_addrule(solv, r->p, d);
2401       queue_push(&solv->weakruleq, solv->nrules - 1);
2402       solv->choicerules_ref[solv->nrules - 1 - solv->choicerules] = rid;
2403       lastaddedp = r->p;
2404       lastaddedd = d;
2405       lastaddedcnt = q.count;
2406 #if 0
2407       printf("OLD ");
2408       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2409       printf("WEAK CHOICE ");
2410       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + solv->nrules - 1);
2411 #endif
2412     }
2413   queue_free(&q);
2414   queue_free(&qi);
2415   map_free(&m);
2416   map_free(&mneg);
2417   solv->choicerules_end = solv->nrules;
2418 }
2419
2420 /* called when a choice rule is disabled by analyze_unsolvable. We also
2421  * have to disable all other choice rules so that the best packages get
2422  * picked */
2423 void
2424 solver_disablechoicerules(Solver *solv, Rule *r)
2425 {
2426   Id rid, p, pp;
2427   Pool *pool = solv->pool;
2428   Map m;
2429   Rule *or;
2430
2431   or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2432   map_init(&m, pool->nsolvables);
2433   FOR_RULELITERALS(p, pp, or)
2434     if (p > 0)
2435       MAPSET(&m, p);
2436   FOR_RULELITERALS(p, pp, r)
2437     if (p > 0)
2438       MAPCLR(&m, p);
2439   for (rid = solv->choicerules; rid < solv->choicerules_end; rid++)
2440     {
2441       r = solv->rules + rid;
2442       if (r->d < 0)
2443         continue;
2444       or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2445       FOR_RULELITERALS(p, pp, or)
2446         if (p > 0 && MAPTST(&m, p))
2447           break;
2448       if (p)
2449         solver_disablerule(solv, r);
2450     }
2451 }
2452
2453 static void
2454 prune_to_update_targets(Solver *solv, Id *cp, Queue *q)
2455 {
2456   int i, j;
2457   Id p, *cp2;
2458   for (i = j = 0; i < q->count; i++)
2459     {
2460       p = q->elements[i];
2461       for (cp2 = cp; *cp2; cp2++)
2462         if (*cp2 == p)
2463           {
2464             q->elements[j++] = p;
2465             break;
2466           }
2467     }
2468   queue_truncate(q, j);
2469 }
2470
2471 static void
2472 prune_to_dup_packages(Solver *solv, Id p, Queue *q)
2473 {
2474   int i, j;
2475   for (i = j = 0; i < q->count; i++)
2476     {
2477       Id p = q->elements[i];
2478       if (MAPTST(&solv->dupmap, p))
2479         q->elements[j++] = p;
2480     }
2481   queue_truncate(q, j);
2482 }
2483
2484 void
2485 solver_addbestrules(Solver *solv, int havebestinstalljobs)
2486 {
2487   Pool *pool = solv->pool;
2488   Id p;
2489   Solvable *s;
2490   Repo *installed = solv->installed;
2491   Queue q, q2;
2492   Rule *r;
2493   Queue r2pkg;
2494   int i, oldcnt;
2495
2496   solv->bestrules = solv->nrules;
2497   if (!installed)
2498     {
2499       solv->bestrules_end = solv->nrules;
2500       return;
2501     }
2502   queue_init(&q);
2503   queue_init(&q2);
2504   queue_init(&r2pkg);
2505
2506   if (havebestinstalljobs)
2507     {
2508       for (i = 0; i < solv->job.count; i += 2)
2509         {
2510           if ((solv->job.elements[i] & (SOLVER_JOBMASK | SOLVER_FORCEBEST)) == (SOLVER_INSTALL | SOLVER_FORCEBEST))
2511             {
2512               int j;
2513               Id p2, pp2;
2514               for (j = 0; j < solv->ruletojob.count; j++)
2515                 if (solv->ruletojob.elements[j] == i)
2516                   break;
2517               if (j == solv->ruletojob.count)
2518                 continue;
2519               r = solv->rules + solv->jobrules + j;
2520               queue_empty(&q);
2521               FOR_RULELITERALS(p2, pp2, r)
2522                 if (p2 > 0)
2523                   queue_push(&q, p2);
2524               if (!q.count)
2525                 continue;       /* orphaned */
2526               /* select best packages, just look at prio and version */
2527               oldcnt = q.count;
2528               policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2529               if (q.count == oldcnt)
2530                 continue;       /* nothing filtered */
2531               p2 = queue_shift(&q);
2532               solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2533               queue_push(&r2pkg, -(solv->jobrules + j));
2534             }
2535         }
2536     }
2537
2538   if (solv->bestupdatemap_all || solv->bestupdatemap.size)
2539     {
2540       FOR_REPO_SOLVABLES(installed, p, s)
2541         {
2542           Id d, p2, pp2;
2543           if (!solv->updatemap_all && (!solv->updatemap.size || !MAPTST(&solv->updatemap, p - installed->start)))
2544             continue;
2545           if (!solv->bestupdatemap_all && (!solv->bestupdatemap.size || !MAPTST(&solv->bestupdatemap, p - installed->start)))
2546             continue;
2547           queue_empty(&q);
2548           if (solv->bestobeypolicy)
2549             r = solv->rules + solv->updaterules + (p - installed->start);
2550           else
2551             {
2552               r = solv->rules + solv->featurerules + (p - installed->start);
2553               if (!r->p)        /* identical to update rule? */
2554                 r = solv->rules + solv->updaterules + (p - installed->start);
2555             }
2556           if (solv->multiversionupdaters && (d = solv->multiversionupdaters[p - installed->start]) != 0 && r == solv->rules + solv->updaterules + (p - installed->start))
2557             {
2558               /* need to check multiversionupdaters */
2559               if (r->p == p)    /* be careful with the dup case */
2560                 queue_push(&q, p);
2561               while ((p2 = pool->whatprovidesdata[d++]) != 0)
2562                 queue_push(&q, p2);
2563             }
2564           else
2565             {
2566               FOR_RULELITERALS(p2, pp2, r)
2567                 if (p2 > 0)
2568                   queue_push(&q, p2);
2569             }
2570           if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2571             prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q);
2572           if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2573             prune_to_dup_packages(solv, p, &q);
2574           /* select best packages, just look at prio and version */
2575           policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2576           if (!q.count)
2577             continue;   /* orphaned */
2578           if (solv->bestobeypolicy)
2579             {
2580               /* also filter the best of the feature rule packages and add them */
2581               r = solv->rules + solv->featurerules + (p - installed->start);
2582               if (r->p)
2583                 {
2584                   int j;
2585                   queue_empty(&q2);
2586                   FOR_RULELITERALS(p2, pp2, r)
2587                     if (p2 > 0)
2588                       queue_push(&q2, p2);
2589                   if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2590                     prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q2);
2591                   if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2592                     prune_to_dup_packages(solv, p, &q);
2593                   policy_filter_unwanted(solv, &q2, POLICY_MODE_RECOMMEND);
2594                   for (j = 0; j < q2.count; j++)
2595                     queue_pushunique(&q, q2.elements[j]);
2596                 }
2597             }
2598           p2 = queue_shift(&q);
2599           solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2600           queue_push(&r2pkg, p);
2601         }
2602     }
2603   if (r2pkg.count)
2604     {
2605       solv->bestrules_pkg = solv_calloc(r2pkg.count, sizeof(Id));
2606       memcpy(solv->bestrules_pkg, r2pkg.elements, r2pkg.count * sizeof(Id));
2607     }
2608   solv->bestrules_end = solv->nrules;
2609   queue_free(&q);
2610   queue_free(&q2);
2611   queue_free(&r2pkg);
2612 }
2613
2614 #undef CLEANDEPSDEBUG
2615
2616 /*
2617  * This functions collects all packages that are looked at
2618  * when a dependency is checked. We need it to "pin" installed
2619  * packages when removing a supplemented package in createcleandepsmap.
2620  * Here's an not uncommon example:
2621  *   A contains "Supplements: packageand(B, C)"
2622  *   B contains "Requires: A"
2623  * Now if we remove C, the supplements is no longer true,
2624  * thus we also remove A. Without the dep_pkgcheck function, we
2625  * would now also remove B, but this is wrong, as adding back
2626  * C doesn't make the supplements true again. Thus we "pin" B
2627  * when we remove A.
2628  * There's probably a better way to do this, but I haven't come
2629  * up with it yet ;)
2630  */
2631 static inline void
2632 dep_pkgcheck(Solver *solv, Id dep, Map *m, Queue *q)
2633 {
2634   Pool *pool = solv->pool;
2635   Id p, pp;
2636
2637   if (ISRELDEP(dep))
2638     {
2639       Reldep *rd = GETRELDEP(pool, dep);
2640       if (rd->flags >= 8)
2641         {
2642           if (rd->flags == REL_AND)
2643             {
2644               dep_pkgcheck(solv, rd->name, m, q);
2645               dep_pkgcheck(solv, rd->evr, m, q);
2646               return;
2647             }
2648           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
2649             return;
2650           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
2651             return;
2652         }
2653     }
2654   FOR_PROVIDES(p, pp, dep)
2655     if (!m || MAPTST(m, p))
2656       queue_push(q, p);
2657 }
2658
2659 /*
2660  * Find all installed packages that are no longer
2661  * needed regarding the current solver job.
2662  *
2663  * The algorithm is:
2664  * - remove pass: remove all packages that could have
2665  *   been dragged in by the obsoleted packages.
2666  *   i.e. if package A is obsolete and contains "Requires: B",
2667  *   also remove B, as installing A will have pulled in B.
2668  *   after this pass, we have a set of still installed packages
2669  *   with broken dependencies.
2670  * - add back pass:
2671  *   now add back all packages that the still installed packages
2672  *   require.
2673  *
2674  * The cleandeps packages are the packages removed in the first
2675  * pass and not added back in the second pass.
2676  *
2677  * If we search for unneeded packages (unneeded is true), we
2678  * simply remove all packages except the userinstalled ones in
2679  * the first pass.
2680  */
2681 static void
2682 solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded)
2683 {
2684   Pool *pool = solv->pool;
2685   Repo *installed = solv->installed;
2686   Queue *job = &solv->job;
2687   Map userinstalled;
2688   Map im;
2689   Map installedm;
2690   Rule *r;
2691   Id rid, how, what, select;
2692   Id p, pp, ip, jp;
2693   Id req, *reqp, sup, *supp;
2694   Solvable *s;
2695   Queue iq;
2696   int i;
2697
2698   map_empty(cleandepsmap);
2699   if (!installed || installed->end == installed->start)
2700     return;
2701   map_init(&userinstalled, installed->end - installed->start);
2702   map_init(&im, pool->nsolvables);
2703   map_init(&installedm, pool->nsolvables);
2704   queue_init(&iq);
2705
2706   for (i = 0; i < job->count; i += 2)
2707     {
2708       how = job->elements[i];
2709       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
2710         {
2711           what = job->elements[i + 1];
2712           select = how & SOLVER_SELECTMASK;
2713           if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
2714             FOR_REPO_SOLVABLES(installed, p, s)
2715               MAPSET(&userinstalled, p - installed->start);
2716           FOR_JOB_SELECT(p, pp, select, what)
2717             if (pool->solvables[p].repo == installed)
2718               MAPSET(&userinstalled, p - installed->start);
2719         }
2720     }
2721
2722   /* also add visible patterns to userinstalled for openSUSE */
2723   if (1)
2724     {
2725       Dataiterator di;
2726       dataiterator_init(&di, pool, 0, 0, SOLVABLE_ISVISIBLE, 0, 0);
2727       while (dataiterator_step(&di))
2728         {
2729           Id *dp;
2730           if (di.solvid <= 0)
2731             continue;
2732           s = pool->solvables + di.solvid;
2733           if (!s->repo || !s->requires)
2734             continue;
2735           if (s->repo != installed && !pool_installable(pool, s))
2736             continue;
2737           if (strncmp(pool_id2str(pool, s->name), "pattern:", 8) != 0)
2738             continue;
2739           dp = s->repo->idarraydata + s->requires;
2740           for (dp = s->repo->idarraydata + s->requires; *dp; dp++)
2741             FOR_PROVIDES(p, pp, *dp)
2742               if (pool->solvables[p].repo == installed)
2743                 {
2744                   if (strncmp(pool_id2str(pool, pool->solvables[p].name), "pattern", 7) != 0)
2745                     continue;
2746                   MAPSET(&userinstalled, p - installed->start);
2747                 }
2748         }
2749       dataiterator_free(&di);
2750     }
2751   if (1)
2752     {
2753       /* all products and their buddies are userinstalled */
2754       for (p = installed->start; p < installed->end; p++)
2755         {
2756           Solvable *s = pool->solvables + p;
2757           if (s->repo != installed)
2758             continue;
2759           if (!strncmp("product:", pool_id2str(pool, s->name), 8))
2760             {
2761               MAPSET(&userinstalled, p - installed->start);
2762               if (pool->nscallback)
2763                 {
2764                   Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, p);
2765                   if (buddy >= installed->start && buddy < installed->end && pool->solvables[buddy].repo == installed)
2766                     MAPSET(&userinstalled, buddy - installed->start);
2767                 }
2768             }
2769         }
2770     }
2771
2772   /* add all positive elements (e.g. locks) to "userinstalled" */
2773   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2774     {
2775       r = solv->rules + rid;
2776       if (r->d < 0)
2777         continue;
2778       i = solv->ruletojob.elements[rid - solv->jobrules];
2779       if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2780         continue;
2781       FOR_RULELITERALS(p, jp, r)
2782         if (p > 0 && pool->solvables[p].repo == installed)
2783           MAPSET(&userinstalled, p - installed->start);
2784     }
2785
2786   /* add all cleandeps candidates to iq */
2787   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2788     {
2789       r = solv->rules + rid;
2790       if (r->d < 0)
2791         continue;
2792       if (r->d == 0 && r->p < 0 && r->w2 == 0)
2793         {
2794           p = -r->p;
2795           if (pool->solvables[p].repo != installed)
2796             continue;
2797           MAPCLR(&userinstalled, p - installed->start);
2798           if (unneeded)
2799             continue;
2800           i = solv->ruletojob.elements[rid - solv->jobrules];
2801           how = job->elements[i];
2802           if ((how & (SOLVER_JOBMASK|SOLVER_CLEANDEPS)) == (SOLVER_ERASE|SOLVER_CLEANDEPS))
2803             queue_push(&iq, p);
2804         }
2805       else if (r->p > 0)
2806         {
2807           if (unneeded)
2808             continue;
2809           i = solv->ruletojob.elements[rid - solv->jobrules];
2810           if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2811             {
2812               /* check if the literals all obsolete some installed package */
2813               Map om;
2814               int iqstart;
2815
2816               /* just one installed literal */
2817               if (r->d == 0 && r->w2 == 0 && pool->solvables[r->p].repo == installed)
2818                 continue;
2819               /* noobs is bad */
2820               if (solv->noobsoletes.size && !solv->keepexplicitobsoletes)
2821                 {
2822                   FOR_RULELITERALS(p, jp, r)
2823                     if (MAPTST(&solv->noobsoletes, p))
2824                       break;
2825                   if (p)
2826                     continue;
2827                 }
2828
2829               om.size = 0;
2830               iqstart = iq.count;
2831               FOR_RULELITERALS(p, jp, r)
2832                 {
2833                   if (p < 0)
2834                     {
2835                       queue_truncate(&iq, iqstart);     /* abort */
2836                       break;
2837                     }
2838                   if (pool->solvables[p].repo == installed)
2839                     {
2840                       if (iq.count == iqstart)
2841                         queue_push(&iq, p);
2842                       else
2843                         {
2844                           for (i = iqstart; i < iq.count; i++)
2845                             if (iq.elements[i] == p)
2846                               break;
2847                           queue_truncate(&iq, iqstart);
2848                           if (i < iq.count)
2849                             queue_push(&iq, p);
2850                         }
2851                     }
2852                   else
2853                     intersect_obsoletes(solv, p, &iq, iqstart, &om);
2854                   if (iq.count == iqstart)
2855                     break;
2856                 }
2857               if (om.size)
2858                 map_free(&om);
2859             }
2860         }
2861     }
2862
2863   if (!unneeded)
2864     {
2865       if (solv->cleandeps_updatepkgs)
2866         for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
2867           queue_push(&iq, solv->cleandeps_updatepkgs->elements[i]);
2868     }
2869
2870   if (unneeded)
2871     queue_empty(&iq);   /* just in case... */
2872
2873   /* clear userinstalled bit for the packages we really want to delete/update */
2874   for (i = 0; i < iq.count; i++)
2875     {
2876       p = iq.elements[i];
2877       if (pool->solvables[p].repo != installed)
2878         continue;
2879       MAPCLR(&userinstalled, p - installed->start);
2880     }
2881
2882   for (p = installed->start; p < installed->end; p++)
2883     {
2884       if (pool->solvables[p].repo != installed)
2885         continue;
2886       MAPSET(&installedm, p);
2887       if (unneeded && !MAPTST(&userinstalled, p - installed->start))
2888         continue;
2889       MAPSET(&im, p);
2890     }
2891
2892 #ifdef CLEANDEPSDEBUG
2893   printf("REMOVE PASS\n");
2894 #endif
2895
2896   for (;;)
2897     {
2898       if (!iq.count)
2899         {
2900           if (unneeded)
2901             break;
2902           /* supplements pass */
2903           for (ip = solv->installed->start; ip < solv->installed->end; ip++)
2904             {
2905               if (!MAPTST(&installedm, ip))
2906                 continue;
2907               s = pool->solvables + ip;
2908               if (!s->supplements)
2909                 continue;
2910               if (!MAPTST(&im, ip))
2911                 continue;
2912               if (MAPTST(&userinstalled, ip - installed->start))
2913                 continue;
2914               supp = s->repo->idarraydata + s->supplements;
2915               while ((sup = *supp++) != 0)
2916                 if (dep_possible(solv, sup, &im))
2917                   break;
2918               if (!sup)
2919                 {
2920                   supp = s->repo->idarraydata + s->supplements;
2921                   while ((sup = *supp++) != 0)
2922                     if (dep_possible(solv, sup, &installedm))
2923                       {
2924                         /* no longer supplemented, also erase */
2925                         int iqcount = iq.count;
2926                         /* pin packages, see comment above dep_pkgcheck */
2927                         dep_pkgcheck(solv, sup, &im, &iq);
2928                         for (i = iqcount; i < iq.count; i++)
2929                           {
2930                             Id pqp = iq.elements[i];
2931                             if (pool->solvables[pqp].repo == installed)
2932                               MAPSET(&userinstalled, pqp - installed->start);
2933                           }
2934                         queue_truncate(&iq, iqcount);
2935 #ifdef CLEANDEPSDEBUG
2936                         printf("%s supplemented\n", pool_solvid2str(pool, ip));
2937 #endif
2938                         queue_push(&iq, ip);
2939                       }
2940                 }
2941             }
2942           if (!iq.count)
2943             break;
2944         }
2945       ip = queue_shift(&iq);
2946       s = pool->solvables + ip;
2947       if (!MAPTST(&im, ip))
2948         continue;
2949       if (!MAPTST(&installedm, ip))
2950         continue;
2951       if (s->repo == installed && MAPTST(&userinstalled, ip - installed->start))
2952         continue;
2953       MAPCLR(&im, ip);
2954 #ifdef CLEANDEPSDEBUG
2955       printf("removing %s\n", pool_solvable2str(pool, s));
2956 #endif
2957       if (s->requires)
2958         {
2959           reqp = s->repo->idarraydata + s->requires;
2960           while ((req = *reqp++) != 0)
2961             {
2962               if (req == SOLVABLE_PREREQMARKER)
2963                 continue;
2964 #if 0
2965               /* count number of installed packages that match */
2966               count = 0;
2967               FOR_PROVIDES(p, pp, req)
2968                 if (MAPTST(&installedm, p))
2969                   count++;
2970               if (count > 1)
2971                 continue;
2972 #endif
2973               FOR_PROVIDES(p, pp, req)
2974                 {
2975                   if (MAPTST(&im, p))
2976                     {
2977 #ifdef CLEANDEPSDEBUG
2978                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
2979 #endif
2980                       queue_push(&iq, p);
2981                     }
2982                 }
2983             }
2984         }
2985       if (s->recommends)
2986         {
2987           reqp = s->repo->idarraydata + s->recommends;
2988           while ((req = *reqp++) != 0)
2989             {
2990 #if 0
2991               count = 0;
2992               FOR_PROVIDES(p, pp, req)
2993                 if (MAPTST(&installedm, p))
2994                   count++;
2995               if (count > 1)
2996                 continue;
2997 #endif
2998               FOR_PROVIDES(p, pp, req)
2999                 {
3000                   if (MAPTST(&im, p))
3001                     {
3002 #ifdef CLEANDEPSDEBUG
3003                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3004 #endif
3005                       queue_push(&iq, p);
3006                     }
3007                 }
3008             }
3009         }
3010     }
3011
3012   /* turn userinstalled into remove set for pruning */
3013   map_empty(&userinstalled);
3014   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3015     {
3016       r = solv->rules + rid;
3017       if (r->p >= 0 || r->d != 0 || r->w2 != 0)
3018         continue;       /* disabled or not erase */
3019       p = -r->p;
3020       MAPCLR(&im, p);
3021       if (pool->solvables[p].repo == installed)
3022         MAPSET(&userinstalled, p - installed->start);
3023     }
3024   for (p = installed->start; p < installed->end; p++)
3025     if (MAPTST(&im, p))
3026       queue_push(&iq, p);
3027   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3028     {
3029       r = solv->rules + rid;
3030       if (r->d < 0)
3031         continue;
3032       FOR_RULELITERALS(p, jp, r)
3033         if (p > 0)
3034           queue_push(&iq, p);
3035     }
3036   /* also put directly addressed packages on the install queue
3037    * so we can mark patterns as installed */
3038   for (i = 0; i < job->count; i += 2)
3039     {
3040       how = job->elements[i];
3041       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
3042         {
3043           what = job->elements[i + 1];
3044           select = how & SOLVER_SELECTMASK;
3045           if (select == SOLVER_SOLVABLE && pool->solvables[what].repo != installed)
3046             queue_push(&iq, what);
3047         }
3048     }
3049
3050 #ifdef CLEANDEPSDEBUG
3051   printf("ADDBACK PASS\n");
3052 #endif
3053   for (;;)
3054     {
3055       if (!iq.count)
3056         {
3057           /* supplements pass */
3058           for (ip = installed->start; ip < installed->end; ip++)
3059             {
3060               if (!MAPTST(&installedm, ip))
3061                 continue;
3062               if (MAPTST(&userinstalled, ip - installed->start))
3063                 continue;
3064               s = pool->solvables + ip;
3065               if (!s->supplements)
3066                 continue;
3067               if (MAPTST(&im, ip))
3068                 continue;
3069               supp = s->repo->idarraydata + s->supplements;
3070               while ((sup = *supp++) != 0)
3071                 if (dep_possible(solv, sup, &im))
3072                   break;
3073               if (sup)
3074                 {
3075 #ifdef CLEANDEPSDEBUG
3076                   printf("%s supplemented\n", pool_solvid2str(pool, ip));
3077 #endif
3078                   MAPSET(&im, ip);
3079                   queue_push(&iq, ip);
3080                 }
3081             }
3082           if (!iq.count)
3083             break;
3084         }
3085       ip = queue_shift(&iq);
3086       s = pool->solvables + ip;
3087 #ifdef CLEANDEPSDEBUG
3088       printf("adding back %s\n", pool_solvable2str(pool, s));
3089 #endif
3090       if (s->requires)
3091         {
3092           reqp = s->repo->idarraydata + s->requires;
3093           while ((req = *reqp++) != 0)
3094             {
3095               FOR_PROVIDES(p, pp, req)
3096                 {
3097                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3098                     {
3099                       if (p == ip)
3100                         continue;
3101                       if (MAPTST(&userinstalled, p - installed->start))
3102                         continue;
3103 #ifdef CLEANDEPSDEBUG
3104                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3105 #endif
3106                       MAPSET(&im, p);
3107                       queue_push(&iq, p);
3108                     }
3109                 }
3110             }
3111         }
3112       if (s->recommends)
3113         {
3114           reqp = s->repo->idarraydata + s->recommends;
3115           while ((req = *reqp++) != 0)
3116             {
3117               FOR_PROVIDES(p, pp, req)
3118                 {
3119                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3120                     {
3121                       if (p == ip)
3122                         continue;
3123                       if (MAPTST(&userinstalled, p - installed->start))
3124                         continue;
3125 #ifdef CLEANDEPSDEBUG
3126                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3127 #endif
3128                       MAPSET(&im, p);
3129                       queue_push(&iq, p);
3130                     }
3131                 }
3132             }
3133         }
3134     }
3135
3136   queue_free(&iq);
3137   if (solv->cleandeps_updatepkgs)
3138     for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
3139       MAPSET(&im, solv->cleandeps_updatepkgs->elements[i]);
3140   if (solv->cleandeps_mistakes)
3141     for (i = 0; i < solv->cleandeps_mistakes->count; i++)
3142       MAPSET(&im, solv->cleandeps_mistakes->elements[i]);
3143   for (p = installed->start; p < installed->end; p++)
3144     {
3145       if (pool->solvables[p].repo != installed)
3146         continue;
3147       if (!MAPTST(&im, p))
3148         MAPSET(cleandepsmap, p - installed->start);
3149     }
3150   map_free(&im);
3151   map_free(&installedm);
3152   map_free(&userinstalled);
3153 }
3154
3155
3156 struct trj_data {
3157   Queue *edges;
3158   Id *low;
3159   Id idx;
3160   Id nstack;
3161   Id firstidx;
3162 };
3163
3164 /* Tarjan's SCC algorithm, slightly modifed */
3165 static void
3166 trj_visit(struct trj_data *trj, Id node)
3167 {
3168   Id *low = trj->low;
3169   Queue *edges = trj->edges;
3170   Id nnode, myidx, stackstart;
3171   int i;
3172
3173   low[node] = myidx = trj->idx++;
3174   low[(stackstart = trj->nstack++)] = node;
3175   for (i = edges->elements[node]; (nnode = edges->elements[i]) != 0; i++)
3176     {
3177       Id l = low[nnode];
3178       if (!l)
3179         {
3180           if (!edges->elements[edges->elements[nnode]])
3181             {
3182               trj->idx++;
3183               low[nnode] = -1;
3184               continue;
3185             }
3186           trj_visit(trj, nnode);
3187           l = low[nnode];
3188         }
3189       if (l < 0)
3190         continue;
3191       if (l < trj->firstidx)
3192         {
3193           int k;
3194           for (k = l; low[low[k]] == l; k++)
3195             low[low[k]] = -1;
3196         }
3197       else if (l < low[node])
3198         low[node] = l;
3199     }
3200   if (low[node] == myidx)
3201     {
3202       if (myidx != trj->firstidx)
3203         myidx = -1;
3204       for (i = stackstart; i < trj->nstack; i++)
3205         low[low[i]] = myidx;
3206       trj->nstack = stackstart;
3207     }
3208 }
3209
3210
3211 void
3212 solver_get_unneeded(Solver *solv, Queue *unneededq, int filtered)
3213 {
3214   Repo *installed = solv->installed;
3215   int i;
3216   Map cleandepsmap;
3217
3218   queue_empty(unneededq);
3219   if (!installed || installed->end == installed->start)
3220     return;
3221
3222   map_init(&cleandepsmap, installed->end - installed->start);
3223   solver_createcleandepsmap(solv, &cleandepsmap, 1);
3224   for (i = installed->start; i < installed->end; i++)
3225     if (MAPTST(&cleandepsmap, i - installed->start))
3226       queue_push(unneededq, i);
3227
3228   if (filtered && unneededq->count > 1)
3229     {
3230       Pool *pool = solv->pool;
3231       Queue edges;
3232       Id *nrequires;
3233       Map installedm;
3234       int j, pass, count = unneededq->count;
3235       Id *low;
3236
3237       map_init(&installedm, pool->nsolvables);
3238       for (i = installed->start; i < installed->end; i++)
3239         if (pool->solvables[i].repo == installed)
3240           MAPSET(&installedm, i);
3241
3242       nrequires = solv_calloc(count, sizeof(Id));
3243       queue_init(&edges);
3244       queue_prealloc(&edges, count * 4 + 10);   /* pre-size */
3245
3246       /*
3247        * Go through the solvables in the nodes queue and create edges for
3248        * all requires/recommends/supplements between the nodes.
3249        * The edges are stored in the edges queue, we add 1 to the node
3250        * index so that nodes in the edges queue are != 0 and we can
3251        * terminate the edge list with 0.
3252        * Thus for node element 5, the edges are stored starting at
3253        * edges.elements[6] and are 0-terminated.
3254        */
3255       /* leave first element zero to make things easier */
3256       /* also add trailing zero */
3257       queue_insertn(&edges, 0, 1 + count + 1);
3258
3259       /* first requires and recommends */
3260       for (i = 0; i < count; i++)
3261         {
3262           Solvable *s = pool->solvables + unneededq->elements[i];
3263           edges.elements[i + 1] = edges.count;
3264           for (pass = 0; pass < 2; pass++)
3265             {
3266               int num = 0;
3267               unsigned int off = pass == 0 ? s->requires : s->recommends;
3268               Id p, pp, *dp;
3269               if (off)
3270                 for (dp = s->repo->idarraydata + off; *dp; dp++)
3271                   FOR_PROVIDES(p, pp, *dp)
3272                     {
3273                       Solvable *sp = pool->solvables + p;
3274                       if (s == sp || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3275                         continue;
3276                       for (j = 0; j < count; j++)
3277                         if (p == unneededq->elements[j])
3278                           break;
3279                       if (j == count)
3280                         continue;
3281                       if (num && edges.elements[edges.count - 1] == j + 1)
3282                         continue;
3283                       queue_push(&edges, j + 1);
3284                       num++;
3285                     }
3286                 if (pass == 0)
3287                   nrequires[i] = num;
3288             }
3289           queue_push(&edges, 0);
3290         }
3291 #if 0
3292       printf("requires + recommends\n");
3293       for (i = 0; i < count; i++)
3294         {
3295           int j;
3296           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3297           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3298             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3299         }
3300 #endif
3301
3302       /* then add supplements */
3303       for (i = 0; i < count; i++)
3304         {
3305           Solvable *s = pool->solvables + unneededq->elements[i];
3306           if (s->supplements)
3307             {
3308               Id *dp;
3309               int k;
3310               for (dp = s->repo->idarraydata + s->supplements; *dp; dp++)
3311                 if (dep_possible(solv, *dp, &installedm))
3312                   {
3313                     Queue iq;
3314                     Id iqbuf[16];
3315                     queue_init_buffer(&iq, iqbuf, sizeof(iqbuf)/sizeof(*iqbuf));
3316                     dep_pkgcheck(solv, *dp, 0, &iq);
3317                     for (k = 0; k < iq.count; k++)
3318                       {
3319                         Id p = iq.elements[k];
3320                         Solvable *sp = pool->solvables + p;
3321                         if (p == unneededq->elements[i] || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3322                           continue;
3323                         for (j = 0; j < count; j++)
3324                           if (p == unneededq->elements[j])
3325                             break;
3326                         /* now add edge from j + 1 to i + 1 */
3327                         queue_insert(&edges, edges.elements[j + 1] + nrequires[j], i + 1);
3328                         /* addapt following edge pointers */
3329                         for (k = j + 2; k < count + 2; k++)
3330                           edges.elements[k]++;
3331                       }
3332                     queue_free(&iq);
3333                   }
3334             }
3335         }
3336 #if 0
3337       /* print result */
3338       printf("+ supplements\n");
3339       for (i = 0; i < count; i++)
3340         {
3341           int j;
3342           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3343           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3344             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3345     }
3346 #endif
3347       map_free(&installedm);
3348
3349       /* now run SCC algo two times, first with requires+recommends+supplements,
3350        * then again without the requires. We run it the second time to get rid
3351        * of packages that got dragged in via recommends/supplements */
3352       /*
3353        * low will contain the result of the SCC search.
3354        * it must be of at least size 2 * (count + 1) and
3355        * must be zero initialized.
3356        * The layout is:
3357        *    0  low low ... low stack stack ...stack 0
3358        *            count              count
3359        */
3360       low = solv_calloc(count + 1, 2 * sizeof(Id));
3361       for (pass = 0; pass < 2; pass++)
3362         {
3363           struct trj_data trj;
3364           if (pass)
3365             {
3366               memset(low, 0, (count + 1) * (2 * sizeof(Id)));
3367               for (i = 0; i < count; i++)
3368                 {
3369                   edges.elements[i + 1] += nrequires[i];
3370                   if (!unneededq->elements[i])
3371                     low[i + 1] = -1;    /* ignore this node */
3372                 }
3373             }
3374           trj.edges = &edges;
3375           trj.low = low;
3376           trj.idx = count + 1;  /* stack starts here */
3377           for (i = 1; i <= count; i++)
3378             {
3379               if (low[i])
3380                 continue;
3381               if (edges.elements[edges.elements[i]])
3382                 {
3383                   trj.firstidx = trj.nstack = trj.idx;
3384                   trj_visit(&trj, i);
3385                 }
3386               else
3387                 {
3388                   Id myidx = trj.idx++;
3389                   low[i] = myidx;
3390                   low[myidx] = i;
3391                 }
3392             }
3393           /* prune packages */
3394           for (i = 0; i < count; i++)
3395             if (low[i + 1] <= 0)
3396               unneededq->elements[i] = 0;
3397         }
3398       solv_free(low);
3399       solv_free(nrequires);
3400       queue_free(&edges);
3401
3402       /* finally remove all pruned entries from unneededq */
3403       for (i = j = 0; i < count; i++)
3404         if (unneededq->elements[i])
3405           unneededq->elements[j++] = unneededq->elements[i];
3406       queue_truncate(unneededq, j);
3407     }
3408   map_free(&cleandepsmap);
3409 }
3410
3411 /* EOF */