src/rules.c

   1 /*
   2  * Copyright (c) 2007-2009, Novell Inc.
   3  *
   4  * This program is licensed under the BSD license, read LICENSE.BSD
   5  * for further information
   6  */
   7
   8 /*
   9  * rules.c
  10  *
  11  * SAT based dependency solver
  12  */
  13
  14 #include <stdio.h>
  15 #include <stdlib.h>
  16 #include <unistd.h>
  17 #include <string.h>
  18 #include <assert.h>
  19
  20 #include "solver.h"
  21 #include "solver_private.h"
  22 #include "bitmap.h"
  23 #include "pool.h"
  24 #include "poolarch.h"
  25 #include "util.h"
  26 #include "evr.h"
  27 #include "policy.h"
  28 #include "solverdebug.h"
  29
  30 #define RULES_BLOCK 63
  31
  32 static void addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep);
  33 static void solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded);
  34
  35 /*-------------------------------------------------------------------
  36  * Check if dependency is possible
  37  *
  38  * mirrors solver_dep_fulfilled but uses map m instead of the decisionmap
  39  * used in solver_addrpmrulesforweak and solver_createcleandepsmap
  40  */
  41
  42 static inline int
  43 dep_possible(Solver *solv, Id dep, Map *m)
  44 {
  45   Pool *pool = solv->pool;
  46   Id p, pp;
  47
  48   if (ISRELDEP(dep))
  49     {
  50       Reldep *rd = GETRELDEP(pool, dep);
  51       if (rd->flags >= 8)
  52         {
  53           if (rd->flags == REL_AND)
  54             {
  55               if (!dep_possible(solv, rd->name, m))
  56                 return 0;
  57               return dep_possible(solv, rd->evr, m);
  58             }
  59           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
  60             return solver_splitprovides(solv, rd->evr);
  61           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
  62             return solver_dep_installed(solv, rd->evr);
  63         }
  64     }
  65   FOR_PROVIDES(p, pp, dep)
  66     {
  67       if (MAPTST(m, p))
  68         return 1;
  69     }
  70   return 0;
  71 }
  72
  73 /********************************************************************
  74  *
  75  * Rule handling
  76  *
  77  * - unify rules, remove duplicates
  78  */
  79
  80 /*-------------------------------------------------------------------
  81  *
  82  * compare rules for unification sort
  83  *
  84  */
  85
  86 static int
  87 unifyrules_sortcmp(const void *ap, const void *bp, void *dp)
  88 {
  89   Pool *pool = dp;
  90   Rule *a = (Rule *)ap;
  91   Rule *b = (Rule *)bp;
  92   Id *ad, *bd;
  93   int x;
  94
  95   x = a->p - b->p;
  96   if (x)
  97     return x;                          /* p differs */
  98
  99   /* identical p */
 100   if (a->d == 0 && b->d == 0)
 101     return a->w2 - b->w2;              /* assertion: return w2 diff */
 102
 103   if (a->d == 0)                       /* a is assertion, b not */
 104     {
 105       x = a->w2 - pool->whatprovidesdata[b->d];
 106       return x ? x : -1;
 107     }
 108
 109   if (b->d == 0)                       /* b is assertion, a not */
 110     {
 111       x = pool->whatprovidesdata[a->d] - b->w2;
 112       return x ? x : 1;
 113     }
 114
 115   /* compare whatprovidesdata */
 116   ad = pool->whatprovidesdata + a->d;
 117   bd = pool->whatprovidesdata + b->d;
 118   while (*bd)
 119     if ((x = *ad++ - *bd++) != 0)
 120       return x;
 121   return *ad;
 122 }
 123
 124 int
 125 solver_rulecmp(Solver *solv, Rule *r1, Rule *r2)
 126 {
 127   return unifyrules_sortcmp(r1, r2, solv->pool);
 128 }
 129
 130
 131 /*-------------------------------------------------------------------
 132  *
 133  * unify rules
 134  * go over all rules and remove duplicates
 135  */
 136
 137 void
 138 solver_unifyrules(Solver *solv)
 139 {
 140   Pool *pool = solv->pool;
 141   int i, j;
 142   Rule *ir, *jr;
 143
 144   if (solv->nrules <= 2)               /* nothing to unify */
 145     return;
 146
 147   /* sort rules first */
 148   solv_sort(solv->rules + 1, solv->nrules - 1, sizeof(Rule), unifyrules_sortcmp, solv->pool);
 149
 150   /* prune rules
 151    * i = unpruned
 152    * j = pruned
 153    */
 154   jr = 0;
 155   for (i = j = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
 156     {
 157       if (jr && !unifyrules_sortcmp(ir, jr, pool))
 158         continue;                      /* prune! */
 159       jr = solv->rules + j++;          /* keep! */
 160       if (ir != jr)
 161         *jr = *ir;
 162     }
 163
 164   /* reduced count from nrules to j rules */
 165   POOL_DEBUG(SOLV_DEBUG_STATS, "pruned rules from %d to %d\n", solv->nrules, j);
 166
 167   /* adapt rule buffer */
 168   solv->nrules = j;
 169   solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
 170
 171   /*
 172    * debug: log rule statistics
 173    */
 174   IF_POOLDEBUG (SOLV_DEBUG_STATS)
 175     {
 176       int binr = 0;
 177       int lits = 0;
 178       Id *dp;
 179       Rule *r;
 180
 181       for (i = 1; i < solv->nrules; i++)
 182         {
 183           r = solv->rules + i;
 184           if (r->d == 0)
 185             binr++;
 186           else
 187             {
 188               dp = solv->pool->whatprovidesdata + r->d;
 189               while (*dp++)
 190                 lits++;
 191             }
 192         }
 193       POOL_DEBUG(SOLV_DEBUG_STATS, "  binary: %d\n", binr);
 194       POOL_DEBUG(SOLV_DEBUG_STATS, "  normal: %d, %d literals\n", solv->nrules - 1 - binr, lits);
 195     }
 196 }
 197
 198 #if 0
 199
 200 /*
 201  * hash rule
 202  */
 203
 204 static Hashval
 205 hashrule(Solver *solv, Id p, Id d, int n)
 206 {
 207   unsigned int x = (unsigned int)p;
 208   int *dp;
 209
 210   if (n <= 1)
 211     return (x * 37) ^ (unsigned int)d;
 212   dp = solv->pool->whatprovidesdata + d;
 213   while (*dp)
 214     x = (x * 37) ^ (unsigned int)*dp++;
 215   return x;
 216 }
 217 #endif
 218
 219
 220 /*-------------------------------------------------------------------
 221  *
 222  */
 223
 224 /*
 225  * add rule
 226  *  p = direct literal; always < 0 for installed rpm rules
 227  *  d, if < 0 direct literal, if > 0 offset into whatprovides, if == 0 rule is assertion (look at p only)
 228  *
 229  *
 230  * A requires b, b provided by B1,B2,B3 => (-A|B1|B2|B3)
 231  *
 232  * p < 0 : pkg id of A
 233  * d > 0 : Offset in whatprovidesdata (list of providers of b)
 234  *
 235  * A conflicts b, b provided by B1,B2,B3 => (-A|-B1), (-A|-B2), (-A|-B3)
 236  * p < 0 : pkg id of A
 237  * d < 0 : Id of solvable (e.g. B1)
 238  *
 239  * d == 0: unary rule, assertion => (A) or (-A)
 240  *
 241  *   Install:    p > 0, d = 0   (A)             user requested install
 242  *   Remove:     p < 0, d = 0   (-A)            user requested remove (also: uninstallable)
 243  *   Requires:   p < 0, d > 0   (-A|B1|B2|...)  d: <list of providers for requirement of p>
 244  *   Updates:    p > 0, d > 0   (A|B1|B2|...)   d: <list of updates for solvable p>
 245  *   Conflicts:  p < 0, d < 0   (-A|-B)         either p (conflict issuer) or d (conflict provider) (binary rule)
 246  *                                              also used for obsoletes
 247  *   ?:          p > 0, d < 0   (A|-B)
 248  *   No-op ?:    p = 0, d = 0   (null)          (used as policy rule placeholder)
 249  *
 250  *   resulting watches:
 251  *   ------------------
 252  *   Direct assertion (no watch needed) --> d = 0, w1 = p, w2 = 0
 253  *   Binary rule: p = first literal, d = 0, w2 = second literal, w1 = p
 254  *   every other : w1 = p, w2 = whatprovidesdata[d];
 255  *   Disabled rule: w1 = 0
 256  *
 257  *   always returns a rule for non-rpm rules
 258  */
 259
 260 Rule *
 261 solver_addrule(Solver *solv, Id p, Id d)
 262 {
 263   Pool *pool = solv->pool;
 264   Rule *r = 0;
 265   Id *dp = 0;
 266
 267   int n = 0;                           /* number of literals in rule - 1
 268                                           0 = direct assertion (single literal)
 269                                           1 = binary rule
 270                                           >1 =
 271                                         */
 272
 273   /* it often happenes that requires lead to adding the same rpm rule
 274    * multiple times, so we prune those duplicates right away to make
 275    * the work for unifyrules a bit easier */
 276
 277   if (!solv->rpmrules_end)              /* we add rpm rules */
 278     {
 279       r = solv->rules + solv->nrules - 1;       /* get the last added rule */
 280       if (r->p == p && r->d == d && (d != 0 || !r->w2))
 281         return r;
 282     }
 283
 284     /*
 285      * compute number of literals (n) in rule
 286      */
 287
 288   if (d < 0)
 289     {
 290       /* always a binary rule */
 291       if (p == d)
 292         return 0;                      /* ignore self conflict */
 293       n = 1;
 294     }
 295   else if (d > 0)
 296     {
 297       for (dp = pool->whatprovidesdata + d; *dp; dp++, n++)
 298         if (*dp == -p)
 299           return 0;                     /* rule is self-fulfilling */
 300
 301       if (n == 1)                       /* convert to binary rule */
 302         d = dp[-1];
 303     }
 304
 305   if (n == 1 && p > d && !solv->rpmrules_end)
 306     {
 307       /* smallest literal first so we can find dups */
 308       n = p; p = d; d = n;             /* p <-> d */
 309       n = 1;                           /* re-set n, was used as temp var */
 310     }
 311
 312   /*
 313    * check for duplicate
 314    */
 315
 316   /* check if the last added rule (r) is exactly the same as what we're looking for. */
 317   if (r && n == 1 && !r->d && r->p == p && r->w2 == d)
 318     return r;  /* binary rule */
 319
 320     /* have n-ary rule with same first literal, check other literals */
 321   if (r && n > 1 && r->d && r->p == p)
 322     {
 323       /* Rule where d is an offset in whatprovidesdata */
 324       Id *dp2;
 325       if (d == r->d)
 326         return r;
 327       dp2 = pool->whatprovidesdata + r->d;
 328       for (dp = pool->whatprovidesdata + d; *dp; dp++, dp2++)
 329         if (*dp != *dp2)
 330           break;
 331       if (*dp == *dp2)
 332         return r;
 333    }
 334
 335   /*
 336    * allocate new rule
 337    */
 338
 339   /* extend rule buffer */
 340   solv->rules = solv_extend(solv->rules, solv->nrules, 1, sizeof(Rule), RULES_BLOCK);
 341   r = solv->rules + solv->nrules++;    /* point to rule space */
 342
 343     /*
 344      * r = new rule
 345      */
 346
 347   r->p = p;
 348   if (n == 0)
 349     {
 350       /* direct assertion, no watch needed */
 351       r->d = 0;
 352       r->w1 = p;
 353       r->w2 = 0;
 354     }
 355   else if (n == 1)
 356     {
 357       /* binary rule */
 358       r->d = 0;
 359       r->w1 = p;
 360       r->w2 = d;
 361     }
 362   else
 363     {
 364       r->d = d;
 365       r->w1 = p;
 366       r->w2 = pool->whatprovidesdata[d];
 367     }
 368   r->n1 = 0;
 369   r->n2 = 0;
 370
 371   IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 372     {
 373       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "  Add rule: ");
 374       solver_printrule(solv, SOLV_DEBUG_RULE_CREATION, r);
 375     }
 376
 377   return r;
 378 }
 379
 380
 381 /******************************************************************************
 382  ***
 383  *** rpm rule part: create rules representing the package dependencies
 384  ***
 385  ***/
 386
 387 /*
 388  *  special multiversion patch conflict handling:
 389  *  a patch conflict is also satisfied if some other
 390  *  version with the same name/arch that doesn't conflict
 391  *  gets installed. The generated rule is thus:
 392  *  -patch|-cpack|opack1|opack2|...
 393  */
 394 static Id
 395 makemultiversionconflict(Solver *solv, Id n, Id con)
 396 {
 397   Pool *pool = solv->pool;
 398   Solvable *s, *sn;
 399   Queue q;
 400   Id p, pp, qbuf[64];
 401
 402   sn = pool->solvables + n;
 403   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
 404   queue_push(&q, -n);
 405   FOR_PROVIDES(p, pp, sn->name)
 406     {
 407       s = pool->solvables + p;
 408       if (s->name != sn->name || s->arch != sn->arch)
 409         continue;
 410       if (!MAPTST(&solv->noobsoletes, p))
 411         continue;
 412       if (pool_match_nevr(pool, pool->solvables + p, con))
 413         continue;
 414       /* here we have a multiversion solvable that doesn't conflict */
 415       /* thus we're not in conflict if it is installed */
 416       queue_push(&q, p);
 417     }
 418   if (q.count == 1)
 419     return -n;  /* no other package found, generate normal conflict */
 420   return pool_queuetowhatprovides(pool, &q);
 421 }
 422
 423 static inline void
 424 addrpmrule(Solver *solv, Id p, Id d, int type, Id dep)
 425 {
 426   if (!solv->ruleinfoq)
 427     solver_addrule(solv, p, d);
 428   else
 429     addrpmruleinfo(solv, p, d, type, dep);
 430 }
 431
 432 /*-------------------------------------------------------------------
 433  *
 434  * add (install) rules for solvable
 435  *
 436  * s: Solvable for which to add rules
 437  * m: m[s] = 1 for solvables which have rules, prevent rule duplication
 438  *
 439  * Algorithm: 'visit all nodes of a graph'. The graph nodes are
 440  *  solvables, the edges their dependencies.
 441  *  Starting from an installed solvable, this will create all rules
 442  *  representing the graph created by the solvables dependencies.
 443  *
 444  * for unfulfilled requirements, conflicts, obsoletes,....
 445  * add a negative assertion for solvables that are not installable
 446  *
 447  * It will also create rules for all solvables referenced by 's'
 448  *  i.e. descend to all providers of requirements of 's'
 449  *
 450  */
 451
 452 void
 453 solver_addrpmrulesforsolvable(Solver *solv, Solvable *s, Map *m)
 454 {
 455   Pool *pool = solv->pool;
 456   Repo *installed = solv->installed;
 457
 458   /* 'work' queue. keeps Ids of solvables we still have to work on.
 459      And buffer for it. */
 460   Queue workq;
 461   Id workqbuf[64];
 462
 463   int i;
 464     /* if to add rules for broken deps ('rpm -V' functionality)
 465      * 0 = yes, 1 = no
 466      */
 467   int dontfix;
 468     /* Id var and pointer for each dependency
 469      * (not used in parallel)
 470      */
 471   Id req, *reqp;
 472   Id con, *conp;
 473   Id obs, *obsp;
 474   Id rec, *recp;
 475   Id sug, *sugp;
 476   Id p, pp;             /* whatprovides loops */
 477   Id *dp;               /* ptr to 'whatprovides' */
 478   Id n;                 /* Id for current solvable 's' */
 479
 480   queue_init_buffer(&workq, workqbuf, sizeof(workqbuf)/sizeof(*workqbuf));
 481   queue_push(&workq, s - pool->solvables);      /* push solvable Id to work queue */
 482
 483   /* loop until there's no more work left */
 484   while (workq.count)
 485     {
 486       /*
 487        * n: Id of solvable
 488        * s: Pointer to solvable
 489        */
 490
 491       n = queue_shift(&workq);          /* 'pop' next solvable to work on from queue */
 492       if (m)
 493         {
 494           if (MAPTST(m, n))             /* continue if already visited */
 495             continue;
 496           MAPSET(m, n);                 /* mark as visited */
 497         }
 498
 499       s = pool->solvables + n;          /* s = Solvable in question */
 500
 501       dontfix = 0;
 502       if (installed                     /* Installed system available */
 503           && s->repo == installed       /* solvable is installed */
 504           && !solv->fixmap_all          /* NOT repair errors in rpm dependency graph */
 505           && !(solv->fixmap.size && MAPTST(&solv->fixmap, n - installed->start)))
 506         {
 507           dontfix = 1;                  /* dont care about broken rpm deps */
 508         }
 509
 510       if (!dontfix
 511           && s->arch != ARCH_SRC
 512           && s->arch != ARCH_NOSRC
 513           && !pool_installable(pool, s))
 514         {
 515           POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables));
 516           addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOT_INSTALLABLE, 0);
 517         }
 518
 519       /* yet another SUSE hack, sigh */
 520       if (pool->nscallback && !strncmp("product:", pool_id2str(pool, s->name), 8))
 521         {
 522           Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, n);
 523           if (buddy > 0 && buddy != SYSTEMSOLVABLE && buddy != n && buddy < pool->nsolvables)
 524             {
 525               addrpmrule(solv, n, -buddy, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + n));
 526               addrpmrule(solv, buddy, -n, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + buddy));
 527               if (m && !MAPTST(m, buddy))
 528                 queue_push(&workq, buddy);
 529             }
 530         }
 531
 532       /*-----------------------------------------
 533        * check requires of s
 534        */
 535
 536       if (s->requires)
 537         {
 538           reqp = s->repo->idarraydata + s->requires;
 539           while ((req = *reqp++) != 0)            /* go through all requires */
 540             {
 541               if (req == SOLVABLE_PREREQMARKER)   /* skip the marker */
 542                 continue;
 543
 544               /* find list of solvables providing 'req' */
 545               dp = pool_whatprovides_ptr(pool, req);
 546
 547               if (*dp == SYSTEMSOLVABLE)          /* always installed */
 548                 continue;
 549
 550               if (dontfix)
 551                 {
 552                   /* the strategy here is to not insist on dependencies
 553                    * that are already broken. so if we find one provider
 554                    * that was already installed, we know that the
 555                    * dependency was not broken before so we enforce it */
 556
 557                   /* check if any of the providers for 'req' is installed */
 558                   for (i = 0; (p = dp[i]) != 0; i++)
 559                     {
 560                       if (pool->solvables[p].repo == installed)
 561                         break;          /* provider was installed */
 562                     }
 563                   /* didn't find an installed provider: previously broken dependency */
 564                   if (!p)
 565                     {
 566                       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken requires %s of installed package %s\n", pool_dep2str(pool, req), pool_solvable2str(pool, s));
 567                       continue;
 568                     }
 569                 }
 570
 571               if (!*dp)
 572                 {
 573                   /* nothing provides req! */
 574                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables), pool_dep2str(pool, req));
 575                   addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOTHING_PROVIDES_DEP, req);
 576                   continue;
 577                 }
 578
 579               IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 580                 {
 581                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION,"  %s requires %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
 582                   for (i = 0; dp[i]; i++)
 583                     POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "   provided by %s\n", pool_solvid2str(pool, dp[i]));
 584                 }
 585
 586               /* add 'requires' dependency */
 587               /* rule: (-requestor|provider1|provider2|...|providerN) */
 588               addrpmrule(solv, -n, dp - pool->whatprovidesdata, SOLVER_RULE_RPM_PACKAGE_REQUIRES, req);
 589
 590               /* descend the dependency tree
 591                  push all non-visited providers on the work queue */
 592               if (m)
 593                 {
 594                   for (; *dp; dp++)
 595                     {
 596                       if (!MAPTST(m, *dp))
 597                         queue_push(&workq, *dp);
 598                     }
 599                 }
 600
 601             } /* while, requirements of n */
 602
 603         } /* if, requirements */
 604
 605       /* that's all we check for src packages */
 606       if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC)
 607         continue;
 608
 609       /*-----------------------------------------
 610        * check conflicts of s
 611        */
 612
 613       if (s->conflicts)
 614         {
 615           int ispatch = 0;
 616
 617           /* we treat conflicts in patches a bit differen:
 618            * - nevr matching
 619            * - multiversion handling
 620            * XXX: we should really handle this different, looking
 621            * at the name is a bad hack
 622            */
 623           if (!strncmp("patch:", pool_id2str(pool, s->name), 6))
 624             ispatch = 1;
 625           conp = s->repo->idarraydata + s->conflicts;
 626           /* foreach conflicts of 's' */
 627           while ((con = *conp++) != 0)
 628             {
 629               /* foreach providers of a conflict of 's' */
 630               FOR_PROVIDES(p, pp, con)
 631                 {
 632                   if (ispatch && !pool_match_nevr(pool, pool->solvables + p, con))
 633                     continue;
 634                   /* dontfix: dont care about conflicts with already installed packs */
 635                   if (dontfix && pool->solvables[p].repo == installed)
 636                     continue;
 637                   /* p == n: self conflict */
 638                   if (p == n && pool->forbidselfconflicts)
 639                     {
 640                       if (ISRELDEP(con))
 641                         {
 642                           Reldep *rd = GETRELDEP(pool, con);
 643                           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_OTHERPROVIDERS)
 644                             continue;
 645                         }
 646                       p = 0;    /* make it a negative assertion, aka 'uninstallable' */
 647                     }
 648                   if (p && ispatch && solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p) && ISRELDEP(con))
 649                     {
 650                       /* our patch conflicts with a noobsoletes (aka multiversion) package */
 651                       p = -makemultiversionconflict(solv, p, con);
 652                     }
 653                  /* rule: -n|-p: either solvable _or_ provider of conflict */
 654                   addrpmrule(solv, -n, -p, p ? SOLVER_RULE_RPM_PACKAGE_CONFLICT : SOLVER_RULE_RPM_SELF_CONFLICT, con);
 655                 }
 656             }
 657         }
 658
 659       /*-----------------------------------------
 660        * check obsoletes and implicit obsoletes of a package
 661        * if ignoreinstalledsobsoletes is not set, we're also checking
 662        * obsoletes of installed packages (like newer rpm versions)
 663        */
 664       if ((!installed || s->repo != installed) || !pool->noinstalledobsoletes)
 665         {
 666           int noobs = solv->noobsoletes.size && MAPTST(&solv->noobsoletes, n);
 667           int isinstalled = (installed && s->repo == installed);
 668           if (s->obsoletes && (!noobs || solv->keepexplicitobsoletes))
 669             {
 670               obsp = s->repo->idarraydata + s->obsoletes;
 671               /* foreach obsoletes */
 672               while ((obs = *obsp++) != 0)
 673                 {
 674                   /* foreach provider of an obsoletes of 's' */
 675                   FOR_PROVIDES(p, pp, obs)
 676                     {
 677                       Solvable *ps = pool->solvables + p;
 678                       if (p == n)
 679                         continue;
 680                       if (isinstalled && dontfix && ps->repo == installed)
 681                         continue;       /* don't repair installed/installed problems */
 682                       if (!pool->obsoleteusesprovides /* obsoletes are matched names, not provides */
 683                           && !pool_match_nevr(pool, ps, obs))
 684                         continue;
 685                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 686                         continue;
 687                       if (!isinstalled)
 688                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_PACKAGE_OBSOLETES, obs);
 689                       else
 690                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_INSTALLEDPKG_OBSOLETES, obs);
 691                     }
 692                 }
 693             }
 694           /* check implicit obsoletes
 695            * for installed packages we only need to check installed/installed problems (and
 696            * only when dontfix is not set), as the others are picked up when looking at the
 697            * uninstalled package.
 698            */
 699           if (!isinstalled || !dontfix)
 700             {
 701               FOR_PROVIDES(p, pp, s->name)
 702                 {
 703                   Solvable *ps = pool->solvables + p;
 704                   if (p == n)
 705                     continue;
 706                   if (isinstalled && ps->repo != installed)
 707                     continue;
 708                   /* we still obsolete packages with same nevra, like rpm does */
 709                   /* (actually, rpm mixes those packages. yuck...) */
 710                   if (noobs && (s->name != ps->name || s->evr != ps->evr || s->arch != ps->arch))
 711                     continue;
 712                   if (!pool->implicitobsoleteusesprovides && s->name != ps->name)
 713                     continue;
 714                   if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 715                     continue;
 716                   if (s->name == ps->name)
 717                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_SAME_NAME, 0);
 718                   else
 719                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_IMPLICIT_OBSOLETES, s->name);
 720                 }
 721             }
 722         }
 723
 724       /*-----------------------------------------
 725        * add recommends to the work queue
 726        */
 727       if (s->recommends && m)
 728         {
 729           recp = s->repo->idarraydata + s->recommends;
 730           while ((rec = *recp++) != 0)
 731             {
 732               FOR_PROVIDES(p, pp, rec)
 733                 if (!MAPTST(m, p))
 734                   queue_push(&workq, p);
 735             }
 736         }
 737       if (s->suggests && m)
 738         {
 739           sugp = s->repo->idarraydata + s->suggests;
 740           while ((sug = *sugp++) != 0)
 741             {
 742               FOR_PROVIDES(p, pp, sug)
 743                 if (!MAPTST(m, p))
 744                   queue_push(&workq, p);
 745             }
 746         }
 747     }
 748   queue_free(&workq);
 749 }
 750
 751
 752 /*-------------------------------------------------------------------
 753  *
 754  * Add rules for packages possibly selected in by weak dependencies
 755  *
 756  * m: already added solvables
 757  */
 758
 759 void
 760 solver_addrpmrulesforweak(Solver *solv, Map *m)
 761 {
 762   Pool *pool = solv->pool;
 763   Solvable *s;
 764   Id sup, *supp;
 765   int i, n;
 766
 767   /* foreach solvable in pool */
 768   for (i = n = 1; n < pool->nsolvables; i++, n++)
 769     {
 770       if (i == pool->nsolvables)                /* wrap i */
 771         i = 1;
 772       if (MAPTST(m, i))                         /* already added that one */
 773         continue;
 774
 775       s = pool->solvables + i;
 776       if (!s->repo)
 777         continue;
 778       if (s->repo != pool->installed && !pool_installable(pool, s))
 779         continue;       /* only look at installable ones */
 780
 781       sup = 0;
 782       if (s->supplements)
 783         {
 784           /* find possible supplements */
 785           supp = s->repo->idarraydata + s->supplements;
 786           while ((sup = *supp++) != 0)
 787             if (dep_possible(solv, sup, m))
 788               break;
 789         }
 790
 791       /* if nothing found, check for enhances */
 792       if (!sup && s->enhances)
 793         {
 794           supp = s->repo->idarraydata + s->enhances;
 795           while ((sup = *supp++) != 0)
 796             if (dep_possible(solv, sup, m))
 797               break;
 798         }
 799       /* if nothing found, goto next solvables */
 800       if (!sup)
 801         continue;
 802       solver_addrpmrulesforsolvable(solv, s, m);
 803       n = 0;                    /* check all solvables again because we added solvables to m */
 804     }
 805 }
 806
 807
 808 /*-------------------------------------------------------------------
 809  *
 810  * add package rules for possible updates
 811  *
 812  * s: solvable
 813  * m: map of already visited solvables
 814  * allow_all: 0 = dont allow downgrades, 1 = allow all candidates
 815  */
 816
 817 void
 818 solver_addrpmrulesforupdaters(Solver *solv, Solvable *s, Map *m, int allow_all)
 819 {
 820   Pool *pool = solv->pool;
 821   int i;
 822     /* queue and buffer for it */
 823   Queue qs;
 824   Id qsbuf[64];
 825
 826   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 827     /* find update candidates for 's' */
 828   policy_findupdatepackages(solv, s, &qs, allow_all);
 829     /* add rule for 's' if not already done */
 830   if (!MAPTST(m, s - pool->solvables))
 831     solver_addrpmrulesforsolvable(solv, s, m);
 832     /* foreach update candidate, add rule if not already done */
 833   for (i = 0; i < qs.count; i++)
 834     if (!MAPTST(m, qs.elements[i]))
 835       solver_addrpmrulesforsolvable(solv, pool->solvables + qs.elements[i], m);
 836   queue_free(&qs);
 837 }
 838
 839
 840 /***********************************************************************
 841  ***
 842  ***  Update/Feature rule part
 843  ***
 844  ***  Those rules make sure an installed package isn't silently deleted
 845  ***
 846  ***/
 847
 848 static Id
 849 finddistupgradepackages(Solver *solv, Solvable *s, Queue *qs, int allow_all)
 850 {
 851   Pool *pool = solv->pool;
 852   int i;
 853
 854   policy_findupdatepackages(solv, s, qs, allow_all ? allow_all : 2);
 855   if (!qs->count)
 856     {
 857       if (allow_all)
 858         return 0;       /* orphaned, don't create feature rule */
 859       /* check if this is an orphaned package */
 860       policy_findupdatepackages(solv, s, qs, 1);
 861       if (!qs->count)
 862         return 0;       /* orphaned, don't create update rule */
 863       qs->count = 0;
 864       return -SYSTEMSOLVABLE;   /* supported but not installable */
 865     }
 866   if (allow_all)
 867     return s - pool->solvables;
 868   /* check if it is ok to keep the installed package */
 869   for (i = 0; i < qs->count; i++)
 870     {
 871       Solvable *ns = pool->solvables + qs->elements[i];
 872       if (s->evr == ns->evr && solvable_identical(s, ns))
 873         return s - pool->solvables;
 874     }
 875   /* nope, it must be some other package */
 876   return -SYSTEMSOLVABLE;
 877 }
 878
 879 /* add packages from the dup repositories to the update candidates
 880  * this isn't needed for the global dup mode as all packages are
 881  * from dup repos in that case */
 882 static void
 883 addduppackages(Solver *solv, Solvable *s, Queue *qs)
 884 {
 885   Queue dupqs;
 886   Id p, dupqsbuf[64];
 887   int i;
 888   int oldnoupdateprovide = solv->noupdateprovide;
 889
 890   queue_init_buffer(&dupqs, dupqsbuf, sizeof(dupqsbuf)/sizeof(*dupqsbuf));
 891   solv->noupdateprovide = 1;
 892   policy_findupdatepackages(solv, s, &dupqs, 2);
 893   solv->noupdateprovide = oldnoupdateprovide;
 894   for (i = 0; i < dupqs.count; i++)
 895     {
 896       p = dupqs.elements[i];
 897       if (MAPTST(&solv->dupmap, p))
 898         queue_pushunique(qs, p);
 899     }
 900   queue_free(&dupqs);
 901 }
 902
 903 /*-------------------------------------------------------------------
 904  *
 905  * add rule for update
 906  *   (A|A1|A2|A3...)  An = update candidates for A
 907  *
 908  * s = (installed) solvable
 909  */
 910
 911 void
 912 solver_addupdaterule(Solver *solv, Solvable *s, int allow_all)
 913 {
 914   /* installed packages get a special upgrade allowed rule */
 915   Pool *pool = solv->pool;
 916   Id p, d;
 917   Queue qs;
 918   Id qsbuf[64];
 919
 920   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 921   p = s - pool->solvables;
 922   /* find update candidates for 's' */
 923   if (solv->dupmap_all)
 924     p = finddistupgradepackages(solv, s, &qs, allow_all);
 925   else
 926     policy_findupdatepackages(solv, s, &qs, allow_all);
 927   if (!allow_all && !solv->dupmap_all && solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
 928     addduppackages(solv, s, &qs);
 929
 930   if (!allow_all && qs.count && solv->noobsoletes.size)
 931     {
 932       int i, j;
 933
 934       d = pool_queuetowhatprovides(pool, &qs);
 935       /* filter out all noobsoletes packages as they don't update */
 936       for (i = j = 0; i < qs.count; i++)
 937         {
 938           if (MAPTST(&solv->noobsoletes, qs.elements[i]))
 939             {
 940               /* it's ok if they have same nevra */
 941               Solvable *ps = pool->solvables + qs.elements[i];
 942               if (ps->name != s->name || ps->evr != s->evr || ps->arch != s->arch)
 943                 continue;
 944             }
 945           qs.elements[j++] = qs.elements[i];
 946         }
 947       if (j < qs.count)
 948         {
 949           if (d && solv->installed && s->repo == solv->installed &&
 950               (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, s - pool->solvables - solv->installed->start))))
 951             {
 952               if (!solv->multiversionupdaters)
 953                 solv->multiversionupdaters = solv_calloc(solv->installed->end - solv->installed->start, sizeof(Id));
 954               solv->multiversionupdaters[s - pool->solvables - solv->installed->start] = d;
 955             }
 956           if (j == 0 && p == -SYSTEMSOLVABLE && solv->dupmap_all)
 957             {
 958               queue_push(&solv->orphaned, s - pool->solvables); /* treat as orphaned */
 959               j = qs.count;
 960             }
 961           qs.count = j;
 962         }
 963       else if (p != -SYSTEMSOLVABLE)
 964         {
 965           /* could fallthrough, but then we would do pool_queuetowhatprovides twice */
 966           queue_free(&qs);
 967           solver_addrule(solv, p, d);   /* allow update of s */
 968           return;
 969         }
 970     }
 971   if (qs.count && p == -SYSTEMSOLVABLE)
 972     p = queue_shift(&qs);
 973   d = qs.count ? pool_queuetowhatprovides(pool, &qs) : 0;
 974   queue_free(&qs);
 975   solver_addrule(solv, p, d);   /* allow update of s */
 976 }
 977
 978 static inline void
 979 disableupdaterule(Solver *solv, Id p)
 980 {
 981   Rule *r;
 982
 983   MAPSET(&solv->noupdate, p - solv->installed->start);
 984   r = solv->rules + solv->updaterules + (p - solv->installed->start);
 985   if (r->p && r->d >= 0)
 986     solver_disablerule(solv, r);
 987   r = solv->rules + solv->featurerules + (p - solv->installed->start);
 988   if (r->p && r->d >= 0)
 989     solver_disablerule(solv, r);
 990   if (solv->bestrules_pkg)
 991     {
 992       int i, ni;
 993       ni = solv->bestrules_end - solv->bestrules;
 994       for (i = 0; i < ni; i++)
 995         if (solv->bestrules_pkg[i] == p)
 996           solver_disablerule(solv, solv->rules + solv->bestrules + i);
 997     }
 998 }
 999
1000 static inline void
1001 reenableupdaterule(Solver *solv, Id p)
1002 {
1003   Pool *pool = solv->pool;
1004   Rule *r;
1005
1006   MAPCLR(&solv->noupdate, p - solv->installed->start);
1007   r = solv->rules + solv->updaterules + (p - solv->installed->start);
1008   if (r->p)
1009     {
1010       if (r->d < 0)
1011         {
1012           solver_enablerule(solv, r);
1013           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1014             {
1015               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1016               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1017             }
1018         }
1019     }
1020   else
1021     {
1022       r = solv->rules + solv->featurerules + (p - solv->installed->start);
1023       if (r->p && r->d < 0)
1024         {
1025           solver_enablerule(solv, r);
1026           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1027             {
1028               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1029               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1030             }
1031         }
1032     }
1033   if (solv->bestrules_pkg)
1034     {
1035       int i, ni;
1036       ni = solv->bestrules_end - solv->bestrules;
1037       for (i = 0; i < ni; i++)
1038         if (solv->bestrules_pkg[i] == p)
1039           solver_enablerule(solv, solv->rules + solv->bestrules + i);
1040     }
1041 }
1042
1043
1044 /***********************************************************************
1045  ***
1046  ***  Infarch rule part
1047  ***
1048  ***  Infarch rules make sure the solver uses the best architecture of
1049  ***  a package if multiple archetectures are available
1050  ***
1051  ***/
1052
1053 void
1054 solver_addinfarchrules(Solver *solv, Map *addedmap)
1055 {
1056   Pool *pool = solv->pool;
1057   int first, i, j;
1058   Id p, pp, a, aa, bestarch;
1059   Solvable *s, *ps, *bests;
1060   Queue badq, allowedarchs;
1061
1062   queue_init(&badq);
1063   queue_init(&allowedarchs);
1064   solv->infarchrules = solv->nrules;
1065   for (i = 1; i < pool->nsolvables; i++)
1066     {
1067       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1068         continue;
1069       s = pool->solvables + i;
1070       first = i;
1071       bestarch = 0;
1072       bests = 0;
1073       queue_empty(&allowedarchs);
1074       FOR_PROVIDES(p, pp, s->name)
1075         {
1076           ps = pool->solvables + p;
1077           if (ps->name != s->name || !MAPTST(addedmap, p))
1078             continue;
1079           if (p == i)
1080             first = 0;
1081           if (first)
1082             break;
1083           a = ps->arch;
1084           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1085           if (a != 1 && pool->installed && ps->repo == pool->installed)
1086             {
1087               if (!solv->dupmap_all && !(solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1088                 queue_pushunique(&allowedarchs, ps->arch);      /* also ok to keep this architecture */
1089               continue;         /* ignore installed solvables when calculating the best arch */
1090             }
1091           if (a && a != 1 && (!bestarch || a < bestarch))
1092             {
1093               bestarch = a;
1094               bests = ps;
1095             }
1096         }
1097       if (first)
1098         continue;
1099       /* speed up common case where installed package already has best arch */
1100       if (allowedarchs.count == 1 && bests && allowedarchs.elements[0] == bests->arch)
1101         allowedarchs.count--;   /* installed arch is best */
1102       queue_empty(&badq);
1103       FOR_PROVIDES(p, pp, s->name)
1104         {
1105           ps = pool->solvables + p;
1106           if (ps->name != s->name || !MAPTST(addedmap, p))
1107             continue;
1108           a = ps->arch;
1109           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1110           if (a != 1 && bestarch && ((a ^ bestarch) & 0xffff0000) != 0)
1111             {
1112               if (pool->installed && ps->repo == pool->installed)
1113                 continue;       /* always ok to keep an installed package */
1114               for (j = 0; j < allowedarchs.count; j++)
1115                 {
1116                   aa = allowedarchs.elements[j];
1117                   if (ps->arch == aa)
1118                     break;
1119                   aa = (aa <= pool->lastarch) ? pool->id2arch[aa] : 0;
1120                   if (aa && ((a ^ aa) & 0xffff0000) == 0)
1121                     break;      /* compatible */
1122                 }
1123               if (j == allowedarchs.count)
1124                 queue_push(&badq, p);
1125             }
1126         }
1127       if (!badq.count)
1128         continue;
1129       /* block all solvables in the badq! */
1130       for (j = 0; j < badq.count; j++)
1131         {
1132           p = badq.elements[j];
1133           solver_addrule(solv, -p, 0);
1134         }
1135     }
1136   queue_free(&badq);
1137   queue_free(&allowedarchs);
1138   solv->infarchrules_end = solv->nrules;
1139 }
1140
1141 static inline void
1142 disableinfarchrule(Solver *solv, Id name)
1143 {
1144   Pool *pool = solv->pool;
1145   Rule *r;
1146   int i;
1147   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1148     {
1149       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1150         solver_disablerule(solv, r);
1151     }
1152 }
1153
1154 static inline void
1155 reenableinfarchrule(Solver *solv, Id name)
1156 {
1157   Pool *pool = solv->pool;
1158   Rule *r;
1159   int i;
1160   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1161     {
1162       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1163         {
1164           solver_enablerule(solv, r);
1165           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1166             {
1167               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1168               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1169             }
1170         }
1171     }
1172 }
1173
1174
1175 /***********************************************************************
1176  ***
1177  ***  Dup rule part
1178  ***
1179  ***  Dup rules make sure a package is selected from the specified dup
1180  ***  repositories if an update candidate is included in one of them.
1181  ***
1182  ***/
1183
1184 void
1185 solver_createdupmaps(Solver *solv)
1186 {
1187   Queue *job = &solv->job;
1188   Pool *pool = solv->pool;
1189   Repo *repo;
1190   Repo *installed = solv->installed;
1191   Id select, how, what, p, pi, pp, pip, obs, *obsp;
1192   Solvable *s, *ps;
1193   int i, targeted;
1194
1195   map_init(&solv->dupmap, pool->nsolvables);
1196   map_init(&solv->dupinvolvedmap, pool->nsolvables);
1197   for (i = 0; i < job->count; i += 2)
1198     {
1199       how = job->elements[i];
1200       select = job->elements[i] & SOLVER_SELECTMASK;
1201       what = job->elements[i + 1];
1202       switch (how & SOLVER_JOBMASK)
1203         {
1204         case SOLVER_DISTUPGRADE:
1205           if (select != SOLVER_SOLVABLE_REPO)
1206             {
1207               targeted = how & SOLVER_TARGETED ? 1 : 0;
1208               if (installed && !targeted && !solv->noautotarget)
1209                 {
1210                   FOR_JOB_SELECT(p, pp, select, what)
1211                     if (pool->solvables[p].repo == installed)
1212                       break;
1213                   targeted = p == 0;
1214                 }
1215               else if (!installed && !solv->noautotarget)
1216                 targeted = 1;
1217               FOR_JOB_SELECT(p, pp, select, what)
1218                 {
1219                   Solvable *s = pool->solvables + p;
1220                   if (!s->repo)
1221                     continue;
1222                   if (!targeted && s->repo != installed)
1223                     continue;
1224                   if (s->repo != installed && !pool_installable(pool, s))
1225                     continue;
1226                   MAPSET(&solv->dupinvolvedmap, p);
1227                   if (targeted)
1228                     MAPSET(&solv->dupmap, p);
1229                   FOR_PROVIDES(pi, pip, s->name)
1230                     {
1231                       ps = pool->solvables + pi;
1232                       if (ps->name != s->name)
1233                         continue;
1234                       MAPSET(&solv->dupinvolvedmap, pi);
1235                       if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1236                         {
1237                           if (!solv->bestupdatemap.size)
1238                             map_grow(&solv->bestupdatemap, installed->end - installed->start);
1239                           MAPSET(&solv->bestupdatemap, pi - installed->start);
1240                         }
1241                       if (!targeted && ps->repo != installed)
1242                         MAPSET(&solv->dupmap, pi);
1243                     }
1244                   if (s->repo == installed && solv->obsoletes && solv->obsoletes[p - installed->start])
1245                     {
1246                       Id *opp;
1247                       for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (pi = *opp++) != 0;)
1248                         {
1249                           ps = pool->solvables + pi;
1250                           if (ps->repo == installed)
1251                             continue;
1252                           MAPSET(&solv->dupinvolvedmap, pi);
1253                           if (!targeted)
1254                             MAPSET(&solv->dupmap, pi);
1255                         }
1256                     }
1257                   if (targeted && s->obsoletes)
1258                     {
1259                       /* XXX: check obsoletes/provides combination */
1260                       obsp = s->repo->idarraydata + s->obsoletes;
1261                       while ((obs = *obsp++) != 0)
1262                         {
1263                           FOR_PROVIDES(pi, pp, obs)
1264                             {
1265                               Solvable *ps = pool->solvables + pi;
1266                               if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1267                                 continue;
1268                               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1269                                 continue;
1270                               MAPSET(&solv->dupinvolvedmap, pi);
1271                               if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1272                                 {
1273                                   if (!solv->bestupdatemap.size)
1274                                     map_grow(&solv->bestupdatemap, installed->end - installed->start);
1275                                   MAPSET(&solv->bestupdatemap, pi - installed->start);
1276                                 }
1277                             }
1278                         }
1279                     }
1280                 }
1281               break;
1282             }
1283           if (what <= 0 || what > pool->nrepos)
1284             break;
1285           repo = pool_id2repo(pool, what);
1286           if (!repo)
1287             break;
1288           if (repo != installed && !(how & SOLVER_TARGETED) && solv->noautotarget)
1289             break;
1290           targeted = repo != installed || (how & SOLVER_TARGETED) != 0;
1291           FOR_REPO_SOLVABLES(repo, p, s)
1292             {
1293               if (repo != installed && !pool_installable(pool, s))
1294                 continue;
1295               MAPSET(&solv->dupinvolvedmap, p);
1296               if (targeted)
1297                 MAPSET(&solv->dupmap, p);
1298               FOR_PROVIDES(pi, pip, s->name)
1299                 {
1300                   ps = pool->solvables + pi;
1301                   if (ps->name != s->name)
1302                     continue;
1303                   MAPSET(&solv->dupinvolvedmap, pi);
1304                   if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1305                     {
1306                       if (!solv->bestupdatemap.size)
1307                         map_grow(&solv->bestupdatemap, installed->end - installed->start);
1308                       MAPSET(&solv->bestupdatemap, pi - installed->start);
1309                     }
1310                   if (!targeted && ps->repo != installed)
1311                     MAPSET(&solv->dupmap, pi);
1312                 }
1313               if (s->repo == installed && solv->obsoletes && solv->obsoletes[p - installed->start])
1314                 {
1315                   Id *opp;
1316                   for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (pi = *opp++) != 0;)
1317                     {
1318                       ps = pool->solvables + pi;
1319                       if (ps->repo == installed)
1320                         continue;
1321                       MAPSET(&solv->dupinvolvedmap, pi);
1322                       if (!targeted)
1323                         MAPSET(&solv->dupmap, pi);
1324                     }
1325                 }
1326               if (targeted && s->obsoletes)
1327                 {
1328                   /* XXX: check obsoletes/provides combination */
1329                   obsp = s->repo->idarraydata + s->obsoletes;
1330                   while ((obs = *obsp++) != 0)
1331                     {
1332                       FOR_PROVIDES(pi, pp, obs)
1333                         {
1334                           Solvable *ps = pool->solvables + pi;
1335                           if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1336                             continue;
1337                           if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1338                             continue;
1339                           MAPSET(&solv->dupinvolvedmap, pi);
1340                           if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1341                             {
1342                               if (!solv->bestupdatemap.size)
1343                                 map_grow(&solv->bestupdatemap, installed->end - installed->start);
1344                               MAPSET(&solv->bestupdatemap, pi - installed->start);
1345                             }
1346                         }
1347                     }
1348                 }
1349             }
1350           break;
1351         default:
1352           break;
1353         }
1354     }
1355   MAPCLR(&solv->dupinvolvedmap, SYSTEMSOLVABLE);
1356 }
1357
1358 void
1359 solver_freedupmaps(Solver *solv)
1360 {
1361   map_free(&solv->dupmap);
1362   /* we no longer free solv->dupinvolvedmap as we need it in
1363    * policy's priority pruning code. sigh. */
1364 }
1365
1366 void
1367 solver_addduprules(Solver *solv, Map *addedmap)
1368 {
1369   Pool *pool = solv->pool;
1370   Id p, pp;
1371   Solvable *s, *ps;
1372   int first, i;
1373
1374   solv->duprules = solv->nrules;
1375   for (i = 1; i < pool->nsolvables; i++)
1376     {
1377       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1378         continue;
1379       s = pool->solvables + i;
1380       first = i;
1381       FOR_PROVIDES(p, pp, s->name)
1382         {
1383           ps = pool->solvables + p;
1384           if (ps->name != s->name || !MAPTST(addedmap, p))
1385             continue;
1386           if (p == i)
1387             first = 0;
1388           if (first)
1389             break;
1390           if (!MAPTST(&solv->dupinvolvedmap, p))
1391             continue;
1392           if (solv->installed && ps->repo == solv->installed)
1393             {
1394               if (!solv->updatemap.size)
1395                 map_grow(&solv->updatemap, solv->installed->end - solv->installed->start);
1396               MAPSET(&solv->updatemap, p - solv->installed->start);
1397               if (!MAPTST(&solv->dupmap, p))
1398                 {
1399                   Id ip, ipp;
1400                   /* is installed identical to a good one? */
1401                   FOR_PROVIDES(ip, ipp, ps->name)
1402                     {
1403                       Solvable *is = pool->solvables + ip;
1404                       if (!MAPTST(&solv->dupmap, ip))
1405                         continue;
1406                       if (is->evr == ps->evr && solvable_identical(ps, is))
1407                         break;
1408                     }
1409                   if (!ip)
1410                     solver_addrule(solv, -p, 0);        /* no match, sorry */
1411                   else
1412                     MAPSET(&solv->dupmap, p);           /* for best rules processing */
1413                 }
1414             }
1415           else if (!MAPTST(&solv->dupmap, p))
1416             solver_addrule(solv, -p, 0);
1417         }
1418     }
1419   solv->duprules_end = solv->nrules;
1420 }
1421
1422
1423 static inline void
1424 disableduprule(Solver *solv, Id name)
1425 {
1426   Pool *pool = solv->pool;
1427   Rule *r;
1428   int i;
1429   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1430     {
1431       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1432         solver_disablerule(solv, r);
1433     }
1434 }
1435
1436 static inline void
1437 reenableduprule(Solver *solv, Id name)
1438 {
1439   Pool *pool = solv->pool;
1440   Rule *r;
1441   int i;
1442   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1443     {
1444       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1445         {
1446           solver_enablerule(solv, r);
1447           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1448             {
1449               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1450               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1451             }
1452         }
1453     }
1454 }
1455
1456
1457 /***********************************************************************
1458  ***
1459  ***  Policy rule disabling/reenabling
1460  ***
1461  ***  Disable all policy rules that conflict with our jobs. If a job
1462  ***  gets disabled later on, reenable the involved policy rules again.
1463  ***
1464  ***/
1465
1466 #define DISABLE_UPDATE  1
1467 #define DISABLE_INFARCH 2
1468 #define DISABLE_DUP     3
1469
1470 /*
1471  * add all installed packages that package p obsoletes to Queue q.
1472  * Package p is not installed. Also, we know that if
1473  * solv->keepexplicitobsoletes is not set, p is not in the noobs map.
1474  * Entries may get added multiple times.
1475  */
1476 static void
1477 add_obsoletes(Solver *solv, Id p, Queue *q)
1478 {
1479   Pool *pool = solv->pool;
1480   Repo *installed = solv->installed;
1481   Id p2, pp2;
1482   Solvable *s = pool->solvables + p;
1483   Id obs, *obsp;
1484   Id lastp2 = 0;
1485
1486   if (!solv->keepexplicitobsoletes || !(solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p)))
1487     {
1488       FOR_PROVIDES(p2, pp2, s->name)
1489         {
1490           Solvable *ps = pool->solvables + p2;
1491           if (ps->repo != installed)
1492             continue;
1493           if (!pool->implicitobsoleteusesprovides && ps->name != s->name)
1494             continue;
1495           if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1496             continue;
1497           queue_push(q, p2);
1498           lastp2 = p2;
1499         }
1500     }
1501   if (!s->obsoletes)
1502     return;
1503   obsp = s->repo->idarraydata + s->obsoletes;
1504   while ((obs = *obsp++) != 0)
1505     FOR_PROVIDES(p2, pp2, obs)
1506       {
1507         Solvable *ps = pool->solvables + p2;
1508         if (ps->repo != installed)
1509           continue;
1510         if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1511           continue;
1512         if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1513           continue;
1514         if (p2 == lastp2)
1515           continue;
1516         queue_push(q, p2);
1517         lastp2 = p2;
1518       }
1519 }
1520
1521 /*
1522  * Call add_obsoletes and intersect the result with the
1523  * elements in Queue q starting at qstart.
1524  * Assumes that it's the first call if qstart == q->count.
1525  * May use auxillary map m for the intersection process, all
1526  * elements of q starting at qstart must have their bit cleared.
1527  * (This is also true after the function returns.)
1528  */
1529 static void
1530 intersect_obsoletes(Solver *solv, Id p, Queue *q, int qstart, Map *m)
1531 {
1532   int i, j;
1533   int qcount = q->count;
1534
1535   add_obsoletes(solv, p, q);
1536   if (qcount == qstart)
1537     return;     /* first call */
1538   if (qcount == q->count)
1539     j = qstart;
1540   else if (qcount == qstart + 1)
1541     {
1542       /* easy if there's just one element */
1543       j = qstart;
1544       for (i = qcount; i < q->count; i++)
1545         if (q->elements[i] == q->elements[qstart])
1546           {
1547             j++;        /* keep the element */
1548             break;
1549           }
1550     }
1551   else if (!m->size && q->count - qstart <= 8)
1552     {
1553       /* faster than a map most of the time */
1554       int k;
1555       for (i = j = qstart; i < qcount; i++)
1556         {
1557           Id ip = q->elements[i];
1558           for (k = qcount; k < q->count; k++)
1559             if (q->elements[k] == ip)
1560               {
1561                 q->elements[j++] = ip;
1562                 break;
1563               }
1564         }
1565     }
1566   else
1567     {
1568       /* for the really pathologic cases we use the map */
1569       Repo *installed = solv->installed;
1570       if (!m->size)
1571         map_init(m, installed->end - installed->start);
1572       for (i = qcount; i < q->count; i++)
1573         MAPSET(m, q->elements[i] - installed->start);
1574       for (i = j = qstart; i < qcount; i++)
1575         if (MAPTST(m, q->elements[i] - installed->start))
1576           {
1577             MAPCLR(m, q->elements[i] - installed->start);
1578             q->elements[j++] = q->elements[i];
1579           }
1580     }
1581   queue_truncate(q, j);
1582 }
1583
1584 static void
1585 jobtodisablelist(Solver *solv, Id how, Id what, Queue *q)
1586 {
1587   Pool *pool = solv->pool;
1588   Id select, p, pp;
1589   Repo *installed;
1590   Solvable *s;
1591   int i, j, set, qstart;
1592   Map omap;
1593
1594   installed = solv->installed;
1595   select = how & SOLVER_SELECTMASK;
1596   switch (how & SOLVER_JOBMASK)
1597     {
1598     case SOLVER_INSTALL:
1599       set = how & SOLVER_SETMASK;
1600       if (!(set & SOLVER_NOAUTOSET))
1601         {
1602           /* automatically add set bits by analysing the job */
1603           if (select == SOLVER_SOLVABLE_NAME)
1604             set |= SOLVER_SETNAME;
1605           if (select == SOLVER_SOLVABLE)
1606             set |= SOLVER_SETNAME | SOLVER_SETARCH | SOLVER_SETVENDOR | SOLVER_SETREPO | SOLVER_SETEVR;
1607           else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
1608             {
1609               Reldep *rd = GETRELDEP(pool, what);
1610               if (rd->flags == REL_EQ && select == SOLVER_SOLVABLE_NAME)
1611                 {
1612                   if (pool->disttype != DISTTYPE_DEB)
1613                     {
1614                       const char *evr = pool_id2str(pool, rd->evr);
1615                       if (strchr(evr, '-'))
1616                         set |= SOLVER_SETEVR;
1617                       else
1618                         set |= SOLVER_SETEV;
1619                     }
1620                   else
1621                     set |= SOLVER_SETEVR;
1622                 }
1623               if (rd->flags <= 7 && ISRELDEP(rd->name))
1624                 rd = GETRELDEP(pool, rd->name);
1625               if (rd->flags == REL_ARCH)
1626                 set |= SOLVER_SETARCH;
1627             }
1628         }
1629       else
1630         set &= ~SOLVER_NOAUTOSET;
1631       if (!set)
1632         return;
1633       if ((set & SOLVER_SETARCH) != 0 && solv->infarchrules != solv->infarchrules_end)
1634         {
1635           if (select == SOLVER_SOLVABLE)
1636             queue_push2(q, DISABLE_INFARCH, pool->solvables[what].name);
1637           else
1638             {
1639               int qcnt = q->count;
1640               /* does not work for SOLVER_SOLVABLE_ALL and SOLVER_SOLVABLE_REPO, but
1641                  they are not useful for SOLVER_INSTALL jobs anyway */
1642               FOR_JOB_SELECT(p, pp, select, what)
1643                 {
1644                   s = pool->solvables + p;
1645                   /* unify names */
1646                   for (i = qcnt; i < q->count; i += 2)
1647                     if (q->elements[i + 1] == s->name)
1648                       break;
1649                   if (i < q->count)
1650                     continue;
1651                   queue_push2(q, DISABLE_INFARCH, s->name);
1652                 }
1653             }
1654         }
1655       if ((set & SOLVER_SETREPO) != 0 && solv->duprules != solv->duprules_end)
1656         {
1657           if (select == SOLVER_SOLVABLE)
1658             queue_push2(q, DISABLE_DUP, pool->solvables[what].name);
1659           else
1660             {
1661               int qcnt = q->count;
1662               FOR_JOB_SELECT(p, pp, select, what)
1663                 {
1664                   s = pool->solvables + p;
1665                   /* unify names */
1666                   for (i = qcnt; i < q->count; i += 2)
1667                     if (q->elements[i + 1] == s->name)
1668                       break;
1669                   if (i < q->count)
1670                     continue;
1671                   queue_push2(q, DISABLE_DUP, s->name);
1672                 }
1673             }
1674         }
1675       if (!installed || installed->end == installed->start)
1676         return;
1677       /* now the hard part: disable some update rules */
1678
1679       /* first check if we have noobs or installed packages in the job */
1680       i = j = 0;
1681       FOR_JOB_SELECT(p, pp, select, what)
1682         {
1683           if (pool->solvables[p].repo == installed)
1684             j = p;
1685           else if (solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p) && !solv->keepexplicitobsoletes)
1686             return;
1687           i++;
1688         }
1689       if (j)    /* have installed packages */
1690         {
1691           /* this is for dupmap_all jobs, it can go away if we create
1692            * duprules for them */
1693           if (i == 1 && (set & SOLVER_SETREPO) != 0)
1694             queue_push2(q, DISABLE_UPDATE, j);
1695           return;
1696         }
1697
1698       omap.size = 0;
1699       qstart = q->count;
1700       FOR_JOB_SELECT(p, pp, select, what)
1701         {
1702           intersect_obsoletes(solv, p, q, qstart, &omap);
1703           if (q->count == qstart)
1704             break;
1705         }
1706       if (omap.size)
1707         map_free(&omap);
1708
1709       if (qstart == q->count)
1710         return;         /* nothing to prune */
1711
1712       /* convert result to (DISABLE_UPDATE, p) pairs */
1713       i = q->count;
1714       for (j = qstart; j < i; j++)
1715         queue_push(q, q->elements[j]);
1716       for (j = qstart; j < q->count; j += 2)
1717         {
1718           q->elements[j] = DISABLE_UPDATE;
1719           q->elements[j + 1] = q->elements[i++];
1720         }
1721
1722       /* now that we know which installed packages are obsoleted check each of them */
1723       if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
1724         return;         /* all is set, nothing to do */
1725
1726       for (i = j = qstart; i < q->count; i += 2)
1727         {
1728           Solvable *is = pool->solvables + q->elements[i + 1];
1729           FOR_JOB_SELECT(p, pp, select, what)
1730             {
1731               int illegal = 0;
1732               s = pool->solvables + p;
1733               if ((set & SOLVER_SETEVR) != 0)
1734                 illegal |= POLICY_ILLEGAL_DOWNGRADE;    /* ignore */
1735               if ((set & SOLVER_SETNAME) != 0)
1736                 illegal |= POLICY_ILLEGAL_NAMECHANGE;   /* ignore */
1737               if ((set & SOLVER_SETARCH) != 0)
1738                 illegal |= POLICY_ILLEGAL_ARCHCHANGE;   /* ignore */
1739               if ((set & SOLVER_SETVENDOR) != 0)
1740                 illegal |= POLICY_ILLEGAL_VENDORCHANGE; /* ignore */
1741               illegal = policy_is_illegal(solv, is, s, illegal);
1742               if (illegal && illegal == POLICY_ILLEGAL_DOWNGRADE && (set & SOLVER_SETEV) != 0)
1743                 {
1744                   /* it's ok if the EV is different */
1745                   if (pool_evrcmp(pool, is->evr, s->evr, EVRCMP_COMPARE_EVONLY) != 0)
1746                     illegal = 0;
1747                 }
1748               if (illegal)
1749                 break;
1750             }
1751           if (!p)
1752             {
1753               /* no package conflicts with the update rule */
1754               /* thus keep the DISABLE_UPDATE */
1755               q->elements[j + 1] = q->elements[i + 1];
1756               j += 2;
1757             }
1758         }
1759       queue_truncate(q, j);
1760       return;
1761
1762     case SOLVER_ERASE:
1763       if (!installed)
1764         break;
1765       if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
1766         FOR_REPO_SOLVABLES(installed, p, s)
1767           queue_push2(q, DISABLE_UPDATE, p);
1768       FOR_JOB_SELECT(p, pp, select, what)
1769         if (pool->solvables[p].repo == installed)
1770           queue_push2(q, DISABLE_UPDATE, p);
1771       return;
1772     default:
1773       return;
1774     }
1775 }
1776
1777 /* disable all policy rules that are in conflict with our job list */
1778 void
1779 solver_disablepolicyrules(Solver *solv)
1780 {
1781   Queue *job = &solv->job;
1782   int i, j;
1783   Queue allq;
1784   Rule *r;
1785   Id lastjob = -1;
1786   Id allqbuf[128];
1787
1788   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1789
1790   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1791     {
1792       r = solv->rules + i;
1793       if (r->d < 0)     /* disabled? */
1794         continue;
1795       j = solv->ruletojob.elements[i - solv->jobrules];
1796       if (j == lastjob)
1797         continue;
1798       lastjob = j;
1799       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1800     }
1801   if (solv->cleandepsmap.size)
1802     {
1803       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1804       for (i = solv->installed->start; i < solv->installed->end; i++)
1805         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1806           queue_push2(&allq, DISABLE_UPDATE, i);
1807     }
1808   MAPZERO(&solv->noupdate);
1809   for (i = 0; i < allq.count; i += 2)
1810     {
1811       Id type = allq.elements[i], arg = allq.elements[i + 1];
1812       switch(type)
1813         {
1814         case DISABLE_UPDATE:
1815           disableupdaterule(solv, arg);
1816           break;
1817         case DISABLE_INFARCH:
1818           disableinfarchrule(solv, arg);
1819           break;
1820         case DISABLE_DUP:
1821           disableduprule(solv, arg);
1822           break;
1823         default:
1824           break;
1825         }
1826     }
1827   queue_free(&allq);
1828 }
1829
1830 /* we just disabled job #jobidx, now reenable all policy rules that were
1831  * disabled because of this job */
1832 void
1833 solver_reenablepolicyrules(Solver *solv, int jobidx)
1834 {
1835   Queue *job = &solv->job;
1836   int i, j;
1837   Queue q, allq;
1838   Rule *r;
1839   Id lastjob = -1;
1840   Id qbuf[32], allqbuf[128];
1841
1842   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
1843   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1844   jobtodisablelist(solv, job->elements[jobidx - 1], job->elements[jobidx], &q);
1845   if (!q.count)
1846     return;
1847   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1848     {
1849       r = solv->rules + i;
1850       if (r->d < 0)     /* disabled? */
1851         continue;
1852       j = solv->ruletojob.elements[i - solv->jobrules];
1853       if (j == lastjob)
1854         continue;
1855       lastjob = j;
1856       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1857     }
1858   if (solv->cleandepsmap.size)
1859     {
1860       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1861       for (i = solv->installed->start; i < solv->installed->end; i++)
1862         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1863           queue_push2(&allq, DISABLE_UPDATE, i);
1864     }
1865   for (j = 0; j < q.count; j += 2)
1866     {
1867       Id type = q.elements[j], arg = q.elements[j + 1];
1868       for (i = 0; i < allq.count; i += 2)
1869         if (allq.elements[i] == type && allq.elements[i + 1] == arg)
1870           break;
1871       if (i < allq.count)
1872         continue;       /* still disabled */
1873       switch(type)
1874         {
1875         case DISABLE_UPDATE:
1876           reenableupdaterule(solv, arg);
1877           break;
1878         case DISABLE_INFARCH:
1879           reenableinfarchrule(solv, arg);
1880           break;
1881         case DISABLE_DUP:
1882           reenableduprule(solv, arg);
1883           break;
1884         }
1885     }
1886   queue_free(&allq);
1887   queue_free(&q);
1888 }
1889
1890 /* we just removed a package from the cleandeps map, now reenable all policy rules that were
1891  * disabled because of this */
1892 void
1893 solver_reenablepolicyrules_cleandeps(Solver *solv, Id pkg)
1894 {
1895   Queue *job = &solv->job;
1896   int i, j;
1897   Queue allq;
1898   Rule *r;
1899   Id lastjob = -1;
1900   Id allqbuf[128];
1901
1902   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1903   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1904     {
1905       r = solv->rules + i;
1906       if (r->d < 0)     /* disabled? */
1907         continue;
1908       j = solv->ruletojob.elements[i - solv->jobrules];
1909       if (j == lastjob)
1910         continue;
1911       lastjob = j;
1912       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1913     }
1914   for (i = 0; i < allq.count; i += 2)
1915     if (allq.elements[i] == DISABLE_UPDATE && allq.elements[i + 1] == pkg)
1916       break;
1917   if (i == allq.count)
1918     reenableupdaterule(solv, pkg);
1919   queue_free(&allq);
1920 }
1921
1922
1923 /***********************************************************************
1924  ***
1925  ***  Rule info part, tell the user what the rule is about.
1926  ***
1927  ***/
1928
1929 static void
1930 addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep)
1931 {
1932   Pool *pool = solv->pool;
1933   Rule *r;
1934   Id w2, op, od, ow2;
1935
1936   /* check if this creates the rule we're searching for */
1937   r = solv->rules + solv->ruleinfoq->elements[0];
1938   op = r->p;
1939   od = r->d < 0 ? -r->d - 1 : r->d;
1940   ow2 = 0;
1941
1942   /* normalize */
1943   w2 = d > 0 ? 0 : d;
1944   if (p < 0 && d > 0 && (!pool->whatprovidesdata[d] || !pool->whatprovidesdata[d + 1]))
1945     {
1946       w2 = pool->whatprovidesdata[d];
1947       d = 0;
1948
1949     }
1950   if (p > 0 && d < 0)           /* this hack is used for buddy deps */
1951     {
1952       w2 = p;
1953       p = d;
1954     }
1955
1956   if (d > 0)
1957     {
1958       if (p != op && !od)
1959         return;
1960       if (d != od)
1961         {
1962           Id *dp = pool->whatprovidesdata + d;
1963           Id *odp = pool->whatprovidesdata + od;
1964           while (*dp)
1965             if (*dp++ != *odp++)
1966               return;
1967           if (*odp)
1968             return;
1969         }
1970       w2 = 0;
1971       /* handle multiversion conflict rules */
1972       if (p < 0 && pool->whatprovidesdata[d] < 0)
1973         {
1974           w2 = pool->whatprovidesdata[d];
1975           /* XXX: free memory */
1976         }
1977     }
1978   else
1979     {
1980       if (od)
1981         return;
1982       ow2 = r->w2;
1983       if (p > w2)
1984         {
1985           if (w2 != op || p != ow2)
1986             return;
1987         }
1988       else
1989         {
1990           if (p != op || w2 != ow2)
1991             return;
1992         }
1993     }
1994   /* yep, rule matches. record info */
1995   queue_push(solv->ruleinfoq, type);
1996   if (type == SOLVER_RULE_RPM_SAME_NAME)
1997     {
1998       /* we normalize same name order */
1999       queue_push(solv->ruleinfoq, op < 0 ? -op : 0);
2000       queue_push(solv->ruleinfoq, ow2 < 0 ? -ow2 : 0);
2001     }
2002   else
2003     {
2004       queue_push(solv->ruleinfoq, p < 0 ? -p : 0);
2005       queue_push(solv->ruleinfoq, w2 < 0 ? -w2 : 0);
2006     }
2007   queue_push(solv->ruleinfoq, dep);
2008 }
2009
2010 static int
2011 solver_allruleinfos_cmp(const void *ap, const void *bp, void *dp)
2012 {
2013   const Id *a = ap, *b = bp;
2014   int r;
2015
2016   r = a[0] - b[0];
2017   if (r)
2018     return r;
2019   r = a[1] - b[1];
2020   if (r)
2021     return r;
2022   r = a[2] - b[2];
2023   if (r)
2024     return r;
2025   r = a[3] - b[3];
2026   if (r)
2027     return r;
2028   return 0;
2029 }
2030
2031 int
2032 solver_allruleinfos(Solver *solv, Id rid, Queue *rq)
2033 {
2034   Pool *pool = solv->pool;
2035   Rule *r = solv->rules + rid;
2036   int i, j;
2037
2038   queue_empty(rq);
2039   if (rid <= 0 || rid >= solv->rpmrules_end)
2040     {
2041       Id type, from, to, dep;
2042       type = solver_ruleinfo(solv, rid, &from, &to, &dep);
2043       queue_push(rq, type);
2044       queue_push(rq, from);
2045       queue_push(rq, to);
2046       queue_push(rq, dep);
2047       return 1;
2048     }
2049   if (r->p >= 0)
2050     return 0;
2051   queue_push(rq, rid);
2052   solv->ruleinfoq = rq;
2053   solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2054   /* also try reverse direction for conflicts */
2055   if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2056     solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2057   solv->ruleinfoq = 0;
2058   queue_shift(rq);
2059   /* now sort & unify em */
2060   if (!rq->count)
2061     return 0;
2062   solv_sort(rq->elements, rq->count / 4, 4 * sizeof(Id), solver_allruleinfos_cmp, 0);
2063   /* throw out identical entries */
2064   for (i = j = 0; i < rq->count; i += 4)
2065     {
2066       if (j)
2067         {
2068           if (rq->elements[i] == rq->elements[j - 4] &&
2069               rq->elements[i + 1] == rq->elements[j - 3] &&
2070               rq->elements[i + 2] == rq->elements[j - 2] &&
2071               rq->elements[i + 3] == rq->elements[j - 1])
2072             continue;
2073         }
2074       rq->elements[j++] = rq->elements[i];
2075       rq->elements[j++] = rq->elements[i + 1];
2076       rq->elements[j++] = rq->elements[i + 2];
2077       rq->elements[j++] = rq->elements[i + 3];
2078     }
2079   rq->count = j;
2080   return j / 4;
2081 }
2082
2083 SolverRuleinfo
2084 solver_ruleinfo(Solver *solv, Id rid, Id *fromp, Id *top, Id *depp)
2085 {
2086   Pool *pool = solv->pool;
2087   Rule *r = solv->rules + rid;
2088   SolverRuleinfo type = SOLVER_RULE_UNKNOWN;
2089
2090   if (fromp)
2091     *fromp = 0;
2092   if (top)
2093     *top = 0;
2094   if (depp)
2095     *depp = 0;
2096   if (rid > 0 && rid < solv->rpmrules_end)
2097     {
2098       Queue rq;
2099       int i;
2100
2101       if (r->p >= 0)
2102         return SOLVER_RULE_RPM;
2103       if (fromp)
2104         *fromp = -r->p;
2105       queue_init(&rq);
2106       queue_push(&rq, rid);
2107       solv->ruleinfoq = &rq;
2108       solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2109       /* also try reverse direction for conflicts */
2110       if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2111         solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2112       solv->ruleinfoq = 0;
2113       type = SOLVER_RULE_RPM;
2114       for (i = 1; i < rq.count; i += 4)
2115         {
2116           Id qt, qo, qp, qd;
2117           qt = rq.elements[i];
2118           qp = rq.elements[i + 1];
2119           qo = rq.elements[i + 2];
2120           qd = rq.elements[i + 3];
2121           if (type == SOLVER_RULE_RPM || type > qt)
2122             {
2123               type = qt;
2124               if (fromp)
2125                 *fromp = qp;
2126               if (top)
2127                 *top = qo;
2128               if (depp)
2129                 *depp = qd;
2130             }
2131         }
2132       queue_free(&rq);
2133       return type;
2134     }
2135   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2136     {
2137       Id jidx = solv->ruletojob.elements[rid - solv->jobrules];
2138       if (fromp)
2139         *fromp = jidx;
2140       if (top)
2141         *top = solv->job.elements[jidx];
2142       if (depp)
2143         *depp = solv->job.elements[jidx + 1];
2144       if ((r->d == 0 || r->d == -1) && r->w2 == 0 && r->p == -SYSTEMSOLVABLE)
2145         {
2146           if ((solv->job.elements[jidx] & SOLVER_SELECTMASK) == SOLVER_SOLVABLE_NAME)
2147             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2148           if ((solv->job.elements[jidx] & SOLVER_SELECTMASK) == SOLVER_SOLVABLE_PROVIDES)
2149             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2150         }
2151       return SOLVER_RULE_JOB;
2152     }
2153   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2154     {
2155       if (fromp)
2156         *fromp = solv->installed->start + (rid - solv->updaterules);
2157       return SOLVER_RULE_UPDATE;
2158     }
2159   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2160     {
2161       if (fromp)
2162         *fromp = solv->installed->start + (rid - solv->featurerules);
2163       return SOLVER_RULE_FEATURE;
2164     }
2165   if (rid >= solv->duprules && rid < solv->duprules_end)
2166     {
2167       if (fromp)
2168         *fromp = -r->p;
2169       if (depp)
2170         *depp = pool->solvables[-r->p].name;
2171       return SOLVER_RULE_DISTUPGRADE;
2172     }
2173   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2174     {
2175       if (fromp)
2176         *fromp = -r->p;
2177       if (depp)
2178         *depp = pool->solvables[-r->p].name;
2179       return SOLVER_RULE_INFARCH;
2180     }
2181   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2182     {
2183       return SOLVER_RULE_BEST;
2184     }
2185   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2186     {
2187       return SOLVER_RULE_CHOICE;
2188     }
2189   if (rid >= solv->learntrules)
2190     {
2191       return SOLVER_RULE_LEARNT;
2192     }
2193   return SOLVER_RULE_UNKNOWN;
2194 }
2195
2196 SolverRuleinfo
2197 solver_ruleclass(Solver *solv, Id rid)
2198 {
2199   if (rid <= 0)
2200     return SOLVER_RULE_UNKNOWN;
2201   if (rid > 0 && rid < solv->rpmrules_end)
2202     return SOLVER_RULE_RPM;
2203   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2204     return SOLVER_RULE_JOB;
2205   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2206     return SOLVER_RULE_UPDATE;
2207   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2208     return SOLVER_RULE_FEATURE;
2209   if (rid >= solv->duprules && rid < solv->duprules_end)
2210     return SOLVER_RULE_DISTUPGRADE;
2211   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2212     return SOLVER_RULE_INFARCH;
2213   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2214     return SOLVER_RULE_BEST;
2215   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2216     return SOLVER_RULE_CHOICE;
2217   if (rid >= solv->learntrules)
2218     return SOLVER_RULE_LEARNT;
2219   return SOLVER_RULE_UNKNOWN;
2220 }
2221
2222 void
2223 solver_ruleliterals(Solver *solv, Id rid, Queue *q)
2224 {
2225   Pool *pool = solv->pool;
2226   Id p, pp;
2227   Rule *r;
2228
2229   queue_empty(q);
2230   r = solv->rules + rid;
2231   FOR_RULELITERALS(p, pp, r)
2232     if (p != -SYSTEMSOLVABLE)
2233       queue_push(q, p);
2234   if (!q->count)
2235     queue_push(q, -SYSTEMSOLVABLE);     /* hmm, better to return an empty result? */
2236 }
2237
2238 int
2239 solver_rule2jobidx(Solver *solv, Id rid)
2240 {
2241   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2242     return 0;
2243   return solv->ruletojob.elements[rid - solv->jobrules] + 1;
2244 }
2245
2246 Id
2247 solver_rule2job(Solver *solv, Id rid, Id *whatp)
2248 {
2249   int idx;
2250   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2251     {
2252       if (whatp)
2253         *whatp = 0;
2254       return 0;
2255     }
2256   idx = solv->ruletojob.elements[rid - solv->jobrules];
2257   if (whatp)
2258     *whatp = solv->job.elements[idx + 1];
2259   return solv->job.elements[idx];
2260 }
2261
2262 void
2263 solver_addchoicerules(Solver *solv)
2264 {
2265   Pool *pool = solv->pool;
2266   Map m, mneg;
2267   Rule *r;
2268   Queue q, qi;
2269   int i, j, rid, havechoice;
2270   Id p, d, pp;
2271   Id p2, pp2;
2272   Solvable *s, *s2;
2273   Id lastaddedp, lastaddedd;
2274   int lastaddedcnt;
2275
2276   solv->choicerules = solv->nrules;
2277   if (!pool->installed)
2278     {
2279       solv->choicerules_end = solv->nrules;
2280       return;
2281     }
2282   solv->choicerules_ref = solv_calloc(solv->rpmrules_end, sizeof(Id));
2283   queue_init(&q);
2284   queue_init(&qi);
2285   map_init(&m, pool->nsolvables);
2286   map_init(&mneg, pool->nsolvables);
2287   /* set up negative assertion map from infarch and dup rules */
2288   for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
2289     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2290       MAPSET(&mneg, -r->p);
2291   for (rid = solv->duprules, r = solv->rules + rid; rid < solv->duprules_end; rid++, r++)
2292     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2293       MAPSET(&mneg, -r->p);
2294   lastaddedp = 0;
2295   lastaddedd = 0;
2296   lastaddedcnt = 0;
2297   for (rid = 1; rid < solv->rpmrules_end ; rid++)
2298     {
2299       r = solv->rules + rid;
2300       if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 < 0))
2301         continue;       /* only look at requires rules */
2302       /* solver_printrule(solv, SOLV_DEBUG_RESULT, r); */
2303       queue_empty(&q);
2304       queue_empty(&qi);
2305       havechoice = 0;
2306       FOR_RULELITERALS(p, pp, r)
2307         {
2308           if (p < 0)
2309             continue;
2310           s = pool->solvables + p;
2311           if (!s->repo)
2312             continue;
2313           if (s->repo == pool->installed)
2314             {
2315               queue_push(&q, p);
2316               continue;
2317             }
2318           /* check if this package is "blocked" by a installed package */
2319           s2 = 0;
2320           FOR_PROVIDES(p2, pp2, s->name)
2321             {
2322               s2 = pool->solvables + p2;
2323               if (s2->repo != pool->installed)
2324                 continue;
2325               if (!pool->implicitobsoleteusesprovides && s->name != s2->name)
2326                 continue;
2327               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2328                 continue;
2329               break;
2330             }
2331           if (p2)
2332             {
2333               /* found installed package p2 that we can update to p */
2334               if (MAPTST(&mneg, p))
2335                 continue;
2336               if (policy_is_illegal(solv, s2, s, 0))
2337                 continue;
2338               queue_push(&qi, p2);
2339               queue_push(&q, p);
2340               continue;
2341             }
2342           if (s->obsoletes)
2343             {
2344               Id obs, *obsp = s->repo->idarraydata + s->obsoletes;
2345               s2 = 0;
2346               while ((obs = *obsp++) != 0)
2347                 {
2348                   FOR_PROVIDES(p2, pp2, obs)
2349                     {
2350                       s2 = pool->solvables + p2;
2351                       if (s2->repo != pool->installed)
2352                         continue;
2353                       if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
2354                         continue;
2355                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2356                         continue;
2357                       break;
2358                     }
2359                   if (p2)
2360                     break;
2361                 }
2362               if (obs)
2363                 {
2364                   /* found installed package p2 that we can update to p */
2365                   if (MAPTST(&mneg, p))
2366                     continue;
2367                   if (policy_is_illegal(solv, s2, s, 0))
2368                     continue;
2369                   queue_push(&qi, p2);
2370                   queue_push(&q, p);
2371                   continue;
2372                 }
2373             }
2374           /* package p is independent of the installed ones */
2375           havechoice = 1;
2376         }
2377       if (!havechoice || !q.count)
2378         continue;       /* no choice */
2379
2380       /* now check the update rules of the installed package.
2381        * if all packages of the update rules are contained in
2382        * the dependency rules, there's no need to set up the choice rule */
2383       map_empty(&m);
2384       FOR_RULELITERALS(p, pp, r)
2385         if (p > 0)
2386           MAPSET(&m, p);
2387       for (i = 0; i < qi.count; i++)
2388         {
2389           Rule *ur;
2390           if (!qi.elements[i])
2391             continue;
2392           ur = solv->rules + solv->updaterules + (qi.elements[i] - pool->installed->start);
2393           if (!ur->p)
2394             ur = solv->rules + solv->featurerules + (qi.elements[i] - pool->installed->start);
2395           if (!ur->p)
2396             continue;
2397           FOR_RULELITERALS(p, pp, ur)
2398             if (!MAPTST(&m, p))
2399               break;
2400           if (p)
2401             break;
2402           for (j = i + 1; j < qi.count; j++)
2403             if (qi.elements[i] == qi.elements[j])
2404               qi.elements[j] = 0;
2405         }
2406       if (i == qi.count)
2407         {
2408 #if 0
2409           printf("skipping choice ");
2410           solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2411 #endif
2412           continue;
2413         }
2414
2415       /* don't add identical rules */
2416       if (lastaddedp == r->p && lastaddedcnt == q.count)
2417         {
2418           for (i = 0; i < q.count; i++)
2419             if (q.elements[i] != pool->whatprovidesdata[lastaddedd + i])
2420               break;
2421           if (i == q.count)
2422             continue;   /* already added that one */
2423         }
2424
2425       d = q.count ? pool_queuetowhatprovides(pool, &q) : 0;
2426       solver_addrule(solv, r->p, d);
2427       queue_push(&solv->weakruleq, solv->nrules - 1);
2428       solv->choicerules_ref[solv->nrules - 1 - solv->choicerules] = rid;
2429       lastaddedp = r->p;
2430       lastaddedd = d;
2431       lastaddedcnt = q.count;
2432 #if 0
2433       printf("OLD ");
2434       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2435       printf("WEAK CHOICE ");
2436       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + solv->nrules - 1);
2437 #endif
2438     }
2439   queue_free(&q);
2440   queue_free(&qi);
2441   map_free(&m);
2442   map_free(&mneg);
2443   solv->choicerules_end = solv->nrules;
2444 }
2445
2446 /* called when a choice rule is disabled by analyze_unsolvable. We also
2447  * have to disable all other choice rules so that the best packages get
2448  * picked */
2449 void
2450 solver_disablechoicerules(Solver *solv, Rule *r)
2451 {
2452   Id rid, p, pp;
2453   Pool *pool = solv->pool;
2454   Map m;
2455   Rule *or;
2456
2457   or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2458   map_init(&m, pool->nsolvables);
2459   FOR_RULELITERALS(p, pp, or)
2460     if (p > 0)
2461       MAPSET(&m, p);
2462   FOR_RULELITERALS(p, pp, r)
2463     if (p > 0)
2464       MAPCLR(&m, p);
2465   for (rid = solv->choicerules; rid < solv->choicerules_end; rid++)
2466     {
2467       r = solv->rules + rid;
2468       if (r->d < 0)
2469         continue;
2470       or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2471       FOR_RULELITERALS(p, pp, or)
2472         if (p > 0 && MAPTST(&m, p))
2473           break;
2474       if (p)
2475         solver_disablerule(solv, r);
2476     }
2477 }
2478
2479 static void
2480 prune_to_update_targets(Solver *solv, Id *cp, Queue *q)
2481 {
2482   int i, j;
2483   Id p, *cp2;
2484   for (i = j = 0; i < q->count; i++)
2485     {
2486       p = q->elements[i];
2487       for (cp2 = cp; *cp2; cp2++)
2488         if (*cp2 == p)
2489           {
2490             q->elements[j++] = p;
2491             break;
2492           }
2493     }
2494   queue_truncate(q, j);
2495 }
2496
2497 static void
2498 prune_to_dup_packages(Solver *solv, Id p, Queue *q)
2499 {
2500   int i, j;
2501   for (i = j = 0; i < q->count; i++)
2502     {
2503       Id p = q->elements[i];
2504       if (MAPTST(&solv->dupmap, p))
2505         q->elements[j++] = p;
2506     }
2507   queue_truncate(q, j);
2508 }
2509
2510 void
2511 solver_addbestrules(Solver *solv, int havebestinstalljobs)
2512 {
2513   Pool *pool = solv->pool;
2514   Id p;
2515   Solvable *s;
2516   Repo *installed = solv->installed;
2517   Queue q, q2;
2518   Rule *r;
2519   Queue r2pkg;
2520   int i, oldcnt;
2521
2522   solv->bestrules = solv->nrules;
2523   if (!installed)
2524     {
2525       solv->bestrules_end = solv->nrules;
2526       return;
2527     }
2528   queue_init(&q);
2529   queue_init(&q2);
2530   queue_init(&r2pkg);
2531
2532   if (havebestinstalljobs)
2533     {
2534       for (i = 0; i < solv->job.count; i += 2)
2535         {
2536           if ((solv->job.elements[i] & (SOLVER_JOBMASK | SOLVER_FORCEBEST)) == (SOLVER_INSTALL | SOLVER_FORCEBEST))
2537             {
2538               int j;
2539               Id p2, pp2;
2540               for (j = 0; j < solv->ruletojob.count; j++)
2541                 if (solv->ruletojob.elements[j] == i)
2542                   break;
2543               if (j == solv->ruletojob.count)
2544                 continue;
2545               r = solv->rules + solv->jobrules + j;
2546               queue_empty(&q);
2547               FOR_RULELITERALS(p2, pp2, r)
2548                 if (p2 > 0)
2549                   queue_push(&q, p2);
2550               if (!q.count)
2551                 continue;       /* orphaned */
2552               /* select best packages, just look at prio and version */
2553               oldcnt = q.count;
2554               policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2555               if (q.count == oldcnt)
2556                 continue;       /* nothing filtered */
2557               p2 = queue_shift(&q);
2558               solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2559               queue_push(&r2pkg, -(solv->jobrules + j));
2560             }
2561         }
2562     }
2563
2564   if (solv->bestupdatemap_all || solv->bestupdatemap.size)
2565     {
2566       FOR_REPO_SOLVABLES(installed, p, s)
2567         {
2568           Id d, p2, pp2;
2569           if (!solv->updatemap_all && (!solv->updatemap.size || !MAPTST(&solv->updatemap, p - installed->start)))
2570             continue;
2571           if (!solv->bestupdatemap_all && (!solv->bestupdatemap.size || !MAPTST(&solv->bestupdatemap, p - installed->start)))
2572             continue;
2573           queue_empty(&q);
2574           if (solv->bestobeypolicy)
2575             r = solv->rules + solv->updaterules + (p - installed->start);
2576           else
2577             {
2578               r = solv->rules + solv->featurerules + (p - installed->start);
2579               if (!r->p)        /* identical to update rule? */
2580                 r = solv->rules + solv->updaterules + (p - installed->start);
2581             }
2582           if (solv->multiversionupdaters && (d = solv->multiversionupdaters[p - installed->start]) != 0 && r == solv->rules + solv->updaterules + (p - installed->start))
2583             {
2584               /* need to check multiversionupdaters */
2585               if (r->p == p)    /* be careful with the dup case */
2586                 queue_push(&q, p);
2587               while ((p2 = pool->whatprovidesdata[d++]) != 0)
2588                 queue_push(&q, p2);
2589             }
2590           else
2591             {
2592               FOR_RULELITERALS(p2, pp2, r)
2593                 if (p2 > 0)
2594                   queue_push(&q, p2);
2595             }
2596           if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2597             prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q);
2598           if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2599             prune_to_dup_packages(solv, p, &q);
2600           /* select best packages, just look at prio and version */
2601           policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2602           if (!q.count)
2603             continue;   /* orphaned */
2604           if (solv->bestobeypolicy)
2605             {
2606               /* also filter the best of the feature rule packages and add them */
2607               r = solv->rules + solv->featurerules + (p - installed->start);
2608               if (r->p)
2609                 {
2610                   int j;
2611                   queue_empty(&q2);
2612                   FOR_RULELITERALS(p2, pp2, r)
2613                     if (p2 > 0)
2614                       queue_push(&q2, p2);
2615                   if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2616                     prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q2);
2617                   if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2618                     prune_to_dup_packages(solv, p, &q);
2619                   policy_filter_unwanted(solv, &q2, POLICY_MODE_RECOMMEND);
2620                   for (j = 0; j < q2.count; j++)
2621                     queue_pushunique(&q, q2.elements[j]);
2622                 }
2623             }
2624           p2 = queue_shift(&q);
2625           solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2626           queue_push(&r2pkg, p);
2627         }
2628     }
2629   if (r2pkg.count)
2630     {
2631       solv->bestrules_pkg = solv_calloc(r2pkg.count, sizeof(Id));
2632       memcpy(solv->bestrules_pkg, r2pkg.elements, r2pkg.count * sizeof(Id));
2633     }
2634   solv->bestrules_end = solv->nrules;
2635   queue_free(&q);
2636   queue_free(&q2);
2637   queue_free(&r2pkg);
2638 }
2639
2640 #undef CLEANDEPSDEBUG
2641
2642 /*
2643  * This functions collects all packages that are looked at
2644  * when a dependency is checked. We need it to "pin" installed
2645  * packages when removing a supplemented package in createcleandepsmap.
2646  * Here's an not uncommon example:
2647  *   A contains "Supplements: packageand(B, C)"
2648  *   B contains "Requires: A"
2649  * Now if we remove C, the supplements is no longer true,
2650  * thus we also remove A. Without the dep_pkgcheck function, we
2651  * would now also remove B, but this is wrong, as adding back
2652  * C doesn't make the supplements true again. Thus we "pin" B
2653  * when we remove A.
2654  * There's probably a better way to do this, but I haven't come
2655  * up with it yet ;)
2656  */
2657 static inline void
2658 dep_pkgcheck(Solver *solv, Id dep, Map *m, Queue *q)
2659 {
2660   Pool *pool = solv->pool;
2661   Id p, pp;
2662
2663   if (ISRELDEP(dep))
2664     {
2665       Reldep *rd = GETRELDEP(pool, dep);
2666       if (rd->flags >= 8)
2667         {
2668           if (rd->flags == REL_AND)
2669             {
2670               dep_pkgcheck(solv, rd->name, m, q);
2671               dep_pkgcheck(solv, rd->evr, m, q);
2672               return;
2673             }
2674           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
2675             return;
2676           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
2677             return;
2678         }
2679     }
2680   FOR_PROVIDES(p, pp, dep)
2681     if (!m || MAPTST(m, p))
2682       queue_push(q, p);
2683 }
2684
2685 /*
2686  * Find all installed packages that are no longer
2687  * needed regarding the current solver job.
2688  *
2689  * The algorithm is:
2690  * - remove pass: remove all packages that could have
2691  *   been dragged in by the obsoleted packages.
2692  *   i.e. if package A is obsolete and contains "Requires: B",
2693  *   also remove B, as installing A will have pulled in B.
2694  *   after this pass, we have a set of still installed packages
2695  *   with broken dependencies.
2696  * - add back pass:
2697  *   now add back all packages that the still installed packages
2698  *   require.
2699  *
2700  * The cleandeps packages are the packages removed in the first
2701  * pass and not added back in the second pass.
2702  *
2703  * If we search for unneeded packages (unneeded is true), we
2704  * simply remove all packages except the userinstalled ones in
2705  * the first pass.
2706  */
2707 static void
2708 solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded)
2709 {
2710   Pool *pool = solv->pool;
2711   Repo *installed = solv->installed;
2712   Queue *job = &solv->job;
2713   Map userinstalled;
2714   Map im;
2715   Map installedm;
2716   Rule *r;
2717   Id rid, how, what, select;
2718   Id p, pp, ip, jp;
2719   Id req, *reqp, sup, *supp;
2720   Solvable *s;
2721   Queue iq;
2722   int i;
2723
2724   map_empty(cleandepsmap);
2725   if (!installed || installed->end == installed->start)
2726     return;
2727   map_init(&userinstalled, installed->end - installed->start);
2728   map_init(&im, pool->nsolvables);
2729   map_init(&installedm, pool->nsolvables);
2730   queue_init(&iq);
2731
2732   for (i = 0; i < job->count; i += 2)
2733     {
2734       how = job->elements[i];
2735       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
2736         {
2737           what = job->elements[i + 1];
2738           select = how & SOLVER_SELECTMASK;
2739           if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
2740             FOR_REPO_SOLVABLES(installed, p, s)
2741               MAPSET(&userinstalled, p - installed->start);
2742           FOR_JOB_SELECT(p, pp, select, what)
2743             if (pool->solvables[p].repo == installed)
2744               MAPSET(&userinstalled, p - installed->start);
2745         }
2746     }
2747
2748   /* also add visible patterns to userinstalled for openSUSE */
2749   if (1)
2750     {
2751       Dataiterator di;
2752       dataiterator_init(&di, pool, 0, 0, SOLVABLE_ISVISIBLE, 0, 0);
2753       while (dataiterator_step(&di))
2754         {
2755           Id *dp;
2756           if (di.solvid <= 0)
2757             continue;
2758           s = pool->solvables + di.solvid;
2759           if (!s->repo || !s->requires)
2760             continue;
2761           if (s->repo != installed && !pool_installable(pool, s))
2762             continue;
2763           if (strncmp(pool_id2str(pool, s->name), "pattern:", 8) != 0)
2764             continue;
2765           dp = s->repo->idarraydata + s->requires;
2766           for (dp = s->repo->idarraydata + s->requires; *dp; dp++)
2767             FOR_PROVIDES(p, pp, *dp)
2768               if (pool->solvables[p].repo == installed)
2769                 {
2770                   if (strncmp(pool_id2str(pool, pool->solvables[p].name), "pattern", 7) != 0)
2771                     continue;
2772                   MAPSET(&userinstalled, p - installed->start);
2773                 }
2774         }
2775       dataiterator_free(&di);
2776     }
2777   if (1)
2778     {
2779       /* all products and their buddies are userinstalled */
2780       for (p = installed->start; p < installed->end; p++)
2781         {
2782           Solvable *s = pool->solvables + p;
2783           if (s->repo != installed)
2784             continue;
2785           if (!strncmp("product:", pool_id2str(pool, s->name), 8))
2786             {
2787               MAPSET(&userinstalled, p - installed->start);
2788               if (pool->nscallback)
2789                 {
2790                   Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, p);
2791                   if (buddy >= installed->start && buddy < installed->end && pool->solvables[buddy].repo == installed)
2792                     MAPSET(&userinstalled, buddy - installed->start);
2793                 }
2794             }
2795         }
2796     }
2797
2798   /* add all positive elements (e.g. locks) to "userinstalled" */
2799   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2800     {
2801       r = solv->rules + rid;
2802       if (r->d < 0)
2803         continue;
2804       i = solv->ruletojob.elements[rid - solv->jobrules];
2805       if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2806         continue;
2807       FOR_RULELITERALS(p, jp, r)
2808         if (p > 0 && pool->solvables[p].repo == installed)
2809           MAPSET(&userinstalled, p - installed->start);
2810     }
2811
2812   /* add all cleandeps candidates to iq */
2813   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2814     {
2815       r = solv->rules + rid;
2816       if (r->d < 0)
2817         continue;
2818       if (r->d == 0 && r->p < 0 && r->w2 == 0)
2819         {
2820           p = -r->p;
2821           if (pool->solvables[p].repo != installed)
2822             continue;
2823           MAPCLR(&userinstalled, p - installed->start);
2824           if (unneeded)
2825             continue;
2826           i = solv->ruletojob.elements[rid - solv->jobrules];
2827           how = job->elements[i];
2828           if ((how & (SOLVER_JOBMASK|SOLVER_CLEANDEPS)) == (SOLVER_ERASE|SOLVER_CLEANDEPS))
2829             queue_push(&iq, p);
2830         }
2831       else if (r->p > 0)
2832         {
2833           if (unneeded)
2834             continue;
2835           i = solv->ruletojob.elements[rid - solv->jobrules];
2836           if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2837             {
2838               /* check if the literals all obsolete some installed package */
2839               Map om;
2840               int iqstart;
2841
2842               /* just one installed literal */
2843               if (r->d == 0 && r->w2 == 0 && pool->solvables[r->p].repo == installed)
2844                 continue;
2845               /* noobs is bad */
2846               if (solv->noobsoletes.size && !solv->keepexplicitobsoletes)
2847                 {
2848                   FOR_RULELITERALS(p, jp, r)
2849                     if (MAPTST(&solv->noobsoletes, p))
2850                       break;
2851                   if (p)
2852                     continue;
2853                 }
2854
2855               om.size = 0;
2856               iqstart = iq.count;
2857               FOR_RULELITERALS(p, jp, r)
2858                 {
2859                   if (p < 0)
2860                     {
2861                       queue_truncate(&iq, iqstart);     /* abort */
2862                       break;
2863                     }
2864                   if (pool->solvables[p].repo == installed)
2865                     {
2866                       if (iq.count == iqstart)
2867                         queue_push(&iq, p);
2868                       else
2869                         {
2870                           for (i = iqstart; i < iq.count; i++)
2871                             if (iq.elements[i] == p)
2872                               break;
2873                           queue_truncate(&iq, iqstart);
2874                           if (i < iq.count)
2875                             queue_push(&iq, p);
2876                         }
2877                     }
2878                   else
2879                     intersect_obsoletes(solv, p, &iq, iqstart, &om);
2880                   if (iq.count == iqstart)
2881                     break;
2882                 }
2883               if (om.size)
2884                 map_free(&om);
2885             }
2886         }
2887     }
2888
2889   if (!unneeded)
2890     {
2891       if (solv->cleandeps_updatepkgs)
2892         for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
2893           queue_push(&iq, solv->cleandeps_updatepkgs->elements[i]);
2894     }
2895
2896   if (unneeded)
2897     queue_empty(&iq);   /* just in case... */
2898
2899   /* clear userinstalled bit for the packages we really want to delete/update */
2900   for (i = 0; i < iq.count; i++)
2901     {
2902       p = iq.elements[i];
2903       if (pool->solvables[p].repo != installed)
2904         continue;
2905       MAPCLR(&userinstalled, p - installed->start);
2906     }
2907
2908   for (p = installed->start; p < installed->end; p++)
2909     {
2910       if (pool->solvables[p].repo != installed)
2911         continue;
2912       MAPSET(&installedm, p);
2913       if (unneeded && !MAPTST(&userinstalled, p - installed->start))
2914         continue;
2915       MAPSET(&im, p);
2916     }
2917
2918 #ifdef CLEANDEPSDEBUG
2919   printf("REMOVE PASS\n");
2920 #endif
2921
2922   for (;;)
2923     {
2924       if (!iq.count)
2925         {
2926           if (unneeded)
2927             break;
2928           /* supplements pass */
2929           for (ip = solv->installed->start; ip < solv->installed->end; ip++)
2930             {
2931               if (!MAPTST(&installedm, ip))
2932                 continue;
2933               s = pool->solvables + ip;
2934               if (!s->supplements)
2935                 continue;
2936               if (!MAPTST(&im, ip))
2937                 continue;
2938               if (MAPTST(&userinstalled, ip - installed->start))
2939                 continue;
2940               supp = s->repo->idarraydata + s->supplements;
2941               while ((sup = *supp++) != 0)
2942                 if (dep_possible(solv, sup, &im))
2943                   break;
2944               if (!sup)
2945                 {
2946                   supp = s->repo->idarraydata + s->supplements;
2947                   while ((sup = *supp++) != 0)
2948                     if (dep_possible(solv, sup, &installedm))
2949                       {
2950                         /* no longer supplemented, also erase */
2951                         int iqcount = iq.count;
2952                         /* pin packages, see comment above dep_pkgcheck */
2953                         dep_pkgcheck(solv, sup, &im, &iq);
2954                         for (i = iqcount; i < iq.count; i++)
2955                           {
2956                             Id pqp = iq.elements[i];
2957                             if (pool->solvables[pqp].repo == installed)
2958                               MAPSET(&userinstalled, pqp - installed->start);
2959                           }
2960                         queue_truncate(&iq, iqcount);
2961 #ifdef CLEANDEPSDEBUG
2962                         printf("%s supplemented\n", pool_solvid2str(pool, ip));
2963 #endif
2964                         queue_push(&iq, ip);
2965                       }
2966                 }
2967             }
2968           if (!iq.count)
2969             break;
2970         }
2971       ip = queue_shift(&iq);
2972       s = pool->solvables + ip;
2973       if (!MAPTST(&im, ip))
2974         continue;
2975       if (!MAPTST(&installedm, ip))
2976         continue;
2977       if (s->repo == installed && MAPTST(&userinstalled, ip - installed->start))
2978         continue;
2979       MAPCLR(&im, ip);
2980 #ifdef CLEANDEPSDEBUG
2981       printf("removing %s\n", pool_solvable2str(pool, s));
2982 #endif
2983       if (s->requires)
2984         {
2985           reqp = s->repo->idarraydata + s->requires;
2986           while ((req = *reqp++) != 0)
2987             {
2988               if (req == SOLVABLE_PREREQMARKER)
2989                 continue;
2990 #if 0
2991               /* count number of installed packages that match */
2992               count = 0;
2993               FOR_PROVIDES(p, pp, req)
2994                 if (MAPTST(&installedm, p))
2995                   count++;
2996               if (count > 1)
2997                 continue;
2998 #endif
2999               FOR_PROVIDES(p, pp, req)
3000                 {
3001                   if (MAPTST(&im, p))
3002                     {
3003 #ifdef CLEANDEPSDEBUG
3004                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3005 #endif
3006                       queue_push(&iq, p);
3007                     }
3008                 }
3009             }
3010         }
3011       if (s->recommends)
3012         {
3013           reqp = s->repo->idarraydata + s->recommends;
3014           while ((req = *reqp++) != 0)
3015             {
3016 #if 0
3017               count = 0;
3018               FOR_PROVIDES(p, pp, req)
3019                 if (MAPTST(&installedm, p))
3020                   count++;
3021               if (count > 1)
3022                 continue;
3023 #endif
3024               FOR_PROVIDES(p, pp, req)
3025                 {
3026                   if (MAPTST(&im, p))
3027                     {
3028 #ifdef CLEANDEPSDEBUG
3029                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3030 #endif
3031                       queue_push(&iq, p);
3032                     }
3033                 }
3034             }
3035         }
3036     }
3037
3038   /* turn userinstalled into remove set for pruning */
3039   map_empty(&userinstalled);
3040   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3041     {
3042       r = solv->rules + rid;
3043       if (r->p >= 0 || r->d != 0 || r->w2 != 0)
3044         continue;       /* disabled or not erase */
3045       p = -r->p;
3046       MAPCLR(&im, p);
3047       if (pool->solvables[p].repo == installed)
3048         MAPSET(&userinstalled, p - installed->start);
3049     }
3050   for (p = installed->start; p < installed->end; p++)
3051     if (MAPTST(&im, p))
3052       queue_push(&iq, p);
3053   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3054     {
3055       r = solv->rules + rid;
3056       if (r->d < 0)
3057         continue;
3058       FOR_RULELITERALS(p, jp, r)
3059         if (p > 0)
3060           queue_push(&iq, p);
3061     }
3062   /* also put directly addressed packages on the install queue
3063    * so we can mark patterns as installed */
3064   for (i = 0; i < job->count; i += 2)
3065     {
3066       how = job->elements[i];
3067       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
3068         {
3069           what = job->elements[i + 1];
3070           select = how & SOLVER_SELECTMASK;
3071           if (select == SOLVER_SOLVABLE && pool->solvables[what].repo != installed)
3072             queue_push(&iq, what);
3073         }
3074     }
3075
3076 #ifdef CLEANDEPSDEBUG
3077   printf("ADDBACK PASS\n");
3078 #endif
3079   for (;;)
3080     {
3081       if (!iq.count)
3082         {
3083           /* supplements pass */
3084           for (ip = installed->start; ip < installed->end; ip++)
3085             {
3086               if (!MAPTST(&installedm, ip))
3087                 continue;
3088               if (MAPTST(&userinstalled, ip - installed->start))
3089                 continue;
3090               s = pool->solvables + ip;
3091               if (!s->supplements)
3092                 continue;
3093               if (MAPTST(&im, ip))
3094                 continue;
3095               supp = s->repo->idarraydata + s->supplements;
3096               while ((sup = *supp++) != 0)
3097                 if (dep_possible(solv, sup, &im))
3098                   break;
3099               if (sup)
3100                 {
3101 #ifdef CLEANDEPSDEBUG
3102                   printf("%s supplemented\n", pool_solvid2str(pool, ip));
3103 #endif
3104                   MAPSET(&im, ip);
3105                   queue_push(&iq, ip);
3106                 }
3107             }
3108           if (!iq.count)
3109             break;
3110         }
3111       ip = queue_shift(&iq);
3112       s = pool->solvables + ip;
3113 #ifdef CLEANDEPSDEBUG
3114       printf("adding back %s\n", pool_solvable2str(pool, s));
3115 #endif
3116       if (s->requires)
3117         {
3118           reqp = s->repo->idarraydata + s->requires;
3119           while ((req = *reqp++) != 0)
3120             {
3121               FOR_PROVIDES(p, pp, req)
3122                 {
3123                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3124                     {
3125                       if (p == ip)
3126                         continue;
3127                       if (MAPTST(&userinstalled, p - installed->start))
3128                         continue;
3129 #ifdef CLEANDEPSDEBUG
3130                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3131 #endif
3132                       MAPSET(&im, p);
3133                       queue_push(&iq, p);
3134                     }
3135                 }
3136             }
3137         }
3138       if (s->recommends)
3139         {
3140           reqp = s->repo->idarraydata + s->recommends;
3141           while ((req = *reqp++) != 0)
3142             {
3143               FOR_PROVIDES(p, pp, req)
3144                 {
3145                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3146                     {
3147                       if (p == ip)
3148                         continue;
3149                       if (MAPTST(&userinstalled, p - installed->start))
3150                         continue;
3151 #ifdef CLEANDEPSDEBUG
3152                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3153 #endif
3154                       MAPSET(&im, p);
3155                       queue_push(&iq, p);
3156                     }
3157                 }
3158             }
3159         }
3160     }
3161
3162   queue_free(&iq);
3163   if (solv->cleandeps_updatepkgs)
3164     for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
3165       MAPSET(&im, solv->cleandeps_updatepkgs->elements[i]);
3166   if (solv->cleandeps_mistakes)
3167     for (i = 0; i < solv->cleandeps_mistakes->count; i++)
3168       MAPSET(&im, solv->cleandeps_mistakes->elements[i]);
3169   for (p = installed->start; p < installed->end; p++)
3170     {
3171       if (pool->solvables[p].repo != installed)
3172         continue;
3173       if (!MAPTST(&im, p))
3174         MAPSET(cleandepsmap, p - installed->start);
3175     }
3176   map_free(&im);
3177   map_free(&installedm);
3178   map_free(&userinstalled);
3179 }
3180
3181
3182 struct trj_data {
3183   Queue *edges;
3184   Id *low;
3185   Id idx;
3186   Id nstack;
3187   Id firstidx;
3188 };
3189
3190 /* Tarjan's SCC algorithm, slightly modifed */
3191 static void
3192 trj_visit(struct trj_data *trj, Id node)
3193 {
3194   Id *low = trj->low;
3195   Queue *edges = trj->edges;
3196   Id nnode, myidx, stackstart;
3197   int i;
3198
3199   low[node] = myidx = trj->idx++;
3200   low[(stackstart = trj->nstack++)] = node;
3201   for (i = edges->elements[node]; (nnode = edges->elements[i]) != 0; i++)
3202     {
3203       Id l = low[nnode];
3204       if (!l)
3205         {
3206           if (!edges->elements[edges->elements[nnode]])
3207             {
3208               trj->idx++;
3209               low[nnode] = -1;
3210               continue;
3211             }
3212           trj_visit(trj, nnode);
3213           l = low[nnode];
3214         }
3215       if (l < 0)
3216         continue;
3217       if (l < trj->firstidx)
3218         {
3219           int k;
3220           for (k = l; low[low[k]] == l; k++)
3221             low[low[k]] = -1;
3222         }
3223       else if (l < low[node])
3224         low[node] = l;
3225     }
3226   if (low[node] == myidx)
3227     {
3228       if (myidx != trj->firstidx)
3229         myidx = -1;
3230       for (i = stackstart; i < trj->nstack; i++)
3231         low[low[i]] = myidx;
3232       trj->nstack = stackstart;
3233     }
3234 }
3235
3236
3237 void
3238 solver_get_unneeded(Solver *solv, Queue *unneededq, int filtered)
3239 {
3240   Repo *installed = solv->installed;
3241   int i;
3242   Map cleandepsmap;
3243
3244   queue_empty(unneededq);
3245   if (!installed || installed->end == installed->start)
3246     return;
3247
3248   map_init(&cleandepsmap, installed->end - installed->start);
3249   solver_createcleandepsmap(solv, &cleandepsmap, 1);
3250   for (i = installed->start; i < installed->end; i++)
3251     if (MAPTST(&cleandepsmap, i - installed->start))
3252       queue_push(unneededq, i);
3253
3254   if (filtered && unneededq->count > 1)
3255     {
3256       Pool *pool = solv->pool;
3257       Queue edges;
3258       Id *nrequires;
3259       Map installedm;
3260       int j, pass, count = unneededq->count;
3261       Id *low;
3262
3263       map_init(&installedm, pool->nsolvables);
3264       for (i = installed->start; i < installed->end; i++)
3265         if (pool->solvables[i].repo == installed)
3266           MAPSET(&installedm, i);
3267
3268       nrequires = solv_calloc(count, sizeof(Id));
3269       queue_init(&edges);
3270       queue_prealloc(&edges, count * 4 + 10);   /* pre-size */
3271
3272       /*
3273        * Go through the solvables in the nodes queue and create edges for
3274        * all requires/recommends/supplements between the nodes.
3275        * The edges are stored in the edges queue, we add 1 to the node
3276        * index so that nodes in the edges queue are != 0 and we can
3277        * terminate the edge list with 0.
3278        * Thus for node element 5, the edges are stored starting at
3279        * edges.elements[6] and are 0-terminated.
3280        */
3281       /* leave first element zero to make things easier */
3282       /* also add trailing zero */
3283       queue_insertn(&edges, 0, 1 + count + 1);
3284
3285       /* first requires and recommends */
3286       for (i = 0; i < count; i++)
3287         {
3288           Solvable *s = pool->solvables + unneededq->elements[i];
3289           edges.elements[i + 1] = edges.count;
3290           for (pass = 0; pass < 2; pass++)
3291             {
3292               int num = 0;
3293               unsigned int off = pass == 0 ? s->requires : s->recommends;
3294               Id p, pp, *dp;
3295               if (off)
3296                 for (dp = s->repo->idarraydata + off; *dp; dp++)
3297                   FOR_PROVIDES(p, pp, *dp)
3298                     {
3299                       Solvable *sp = pool->solvables + p;
3300                       if (s == sp || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3301                         continue;
3302                       for (j = 0; j < count; j++)
3303                         if (p == unneededq->elements[j])
3304                           break;
3305                       if (j == count)
3306                         continue;
3307                       if (num && edges.elements[edges.count - 1] == j + 1)
3308                         continue;
3309                       queue_push(&edges, j + 1);
3310                       num++;
3311                     }
3312                 if (pass == 0)
3313                   nrequires[i] = num;
3314             }
3315           queue_push(&edges, 0);
3316         }
3317 #if 0
3318       printf("requires + recommends\n");
3319       for (i = 0; i < count; i++)
3320         {
3321           int j;
3322           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3323           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3324             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3325         }
3326 #endif
3327
3328       /* then add supplements */
3329       for (i = 0; i < count; i++)
3330         {
3331           Solvable *s = pool->solvables + unneededq->elements[i];
3332           if (s->supplements)
3333             {
3334               Id *dp;
3335               int k;
3336               for (dp = s->repo->idarraydata + s->supplements; *dp; dp++)
3337                 if (dep_possible(solv, *dp, &installedm))
3338                   {
3339                     Queue iq;
3340                     Id iqbuf[16];
3341                     queue_init_buffer(&iq, iqbuf, sizeof(iqbuf)/sizeof(*iqbuf));
3342                     dep_pkgcheck(solv, *dp, 0, &iq);
3343                     for (k = 0; k < iq.count; k++)
3344                       {
3345                         Id p = iq.elements[k];
3346                         Solvable *sp = pool->solvables + p;
3347                         if (p == unneededq->elements[i] || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3348                           continue;
3349                         for (j = 0; j < count; j++)
3350                           if (p == unneededq->elements[j])
3351                             break;
3352                         /* now add edge from j + 1 to i + 1 */
3353                         queue_insert(&edges, edges.elements[j + 1] + nrequires[j], i + 1);
3354                         /* addapt following edge pointers */
3355                         for (k = j + 2; k < count + 2; k++)
3356                           edges.elements[k]++;
3357                       }
3358                     queue_free(&iq);
3359                   }
3360             }
3361         }
3362 #if 0
3363       /* print result */
3364       printf("+ supplements\n");
3365       for (i = 0; i < count; i++)
3366         {
3367           int j;
3368           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3369           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3370             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3371     }
3372 #endif
3373       map_free(&installedm);
3374
3375       /* now run SCC algo two times, first with requires+recommends+supplements,
3376        * then again without the requires. We run it the second time to get rid
3377        * of packages that got dragged in via recommends/supplements */
3378       /*
3379        * low will contain the result of the SCC search.
3380        * it must be of at least size 2 * (count + 1) and
3381        * must be zero initialized.
3382        * The layout is:
3383        *    0  low low ... low stack stack ...stack 0
3384        *            count              count
3385        */
3386       low = solv_calloc(count + 1, 2 * sizeof(Id));
3387       for (pass = 0; pass < 2; pass++)
3388         {
3389           struct trj_data trj;
3390           if (pass)
3391             {
3392               memset(low, 0, (count + 1) * (2 * sizeof(Id)));
3393               for (i = 0; i < count; i++)
3394                 {
3395                   edges.elements[i + 1] += nrequires[i];
3396                   if (!unneededq->elements[i])
3397                     low[i + 1] = -1;    /* ignore this node */
3398                 }
3399             }
3400           trj.edges = &edges;
3401           trj.low = low;
3402           trj.idx = count + 1;  /* stack starts here */
3403           for (i = 1; i <= count; i++)
3404             {
3405               if (low[i])
3406                 continue;
3407               if (edges.elements[edges.elements[i]])
3408                 {
3409                   trj.firstidx = trj.nstack = trj.idx;
3410                   trj_visit(&trj, i);
3411                 }
3412               else
3413                 {
3414                   Id myidx = trj.idx++;
3415                   low[i] = myidx;
3416                   low[myidx] = i;
3417                 }
3418             }
3419           /* prune packages */
3420           for (i = 0; i < count; i++)
3421             if (low[i + 1] <= 0)
3422               unneededq->elements[i] = 0;
3423         }
3424       solv_free(low);
3425       solv_free(nrequires);
3426       queue_free(&edges);
3427
3428       /* finally remove all pruned entries from unneededq */
3429       for (i = j = 0; i < count; i++)
3430         if (unneededq->elements[i])
3431           unneededq->elements[j++] = unneededq->elements[i];
3432       queue_truncate(unneededq, j);
3433     }
3434   map_free(&cleandepsmap);
3435 }
3436
3437 /* EOF */