src/rules.c

   1 /*
   2  * Copyright (c) 2007-2009, Novell Inc.
   3  *
   4  * This program is licensed under the BSD license, read LICENSE.BSD
   5  * for further information
   6  */
   7
   8 /*
   9  * rules.c
  10  *
  11  * SAT based dependency solver
  12  */
  13
  14 #include <stdio.h>
  15 #include <stdlib.h>
  16 #include <unistd.h>
  17 #include <string.h>
  18 #include <assert.h>
  19
  20 #include "solver.h"
  21 #include "solver_private.h"
  22 #include "bitmap.h"
  23 #include "pool.h"
  24 #include "poolarch.h"
  25 #include "util.h"
  26 #include "evr.h"
  27 #include "policy.h"
  28 #include "solverdebug.h"
  29
  30 #define RULES_BLOCK 63
  31
  32 static void addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep);
  33 static void solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded);
  34
  35 /*-------------------------------------------------------------------
  36  * Check if dependency is possible
  37  *
  38  * mirrors solver_dep_fulfilled but uses map m instead of the decisionmap
  39  * used in solver_addrpmrulesforweak and solver_createcleandepsmap
  40  */
  41
  42 static inline int
  43 dep_possible(Solver *solv, Id dep, Map *m)
  44 {
  45   Pool *pool = solv->pool;
  46   Id p, pp;
  47
  48   if (ISRELDEP(dep))
  49     {
  50       Reldep *rd = GETRELDEP(pool, dep);
  51       if (rd->flags >= 8)
  52         {
  53           if (rd->flags == REL_AND)
  54             {
  55               if (!dep_possible(solv, rd->name, m))
  56                 return 0;
  57               return dep_possible(solv, rd->evr, m);
  58             }
  59           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
  60             return solver_splitprovides(solv, rd->evr);
  61           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
  62             return solver_dep_installed(solv, rd->evr);
  63         }
  64     }
  65   FOR_PROVIDES(p, pp, dep)
  66     {
  67       if (MAPTST(m, p))
  68         return 1;
  69     }
  70   return 0;
  71 }
  72
  73 /********************************************************************
  74  *
  75  * Rule handling
  76  *
  77  * - unify rules, remove duplicates
  78  */
  79
  80 /*-------------------------------------------------------------------
  81  *
  82  * compare rules for unification sort
  83  *
  84  */
  85
  86 static int
  87 unifyrules_sortcmp(const void *ap, const void *bp, void *dp)
  88 {
  89   Pool *pool = dp;
  90   Rule *a = (Rule *)ap;
  91   Rule *b = (Rule *)bp;
  92   Id *ad, *bd;
  93   int x;
  94
  95   x = a->p - b->p;
  96   if (x)
  97     return x;                          /* p differs */
  98
  99   /* identical p */
 100   if (a->d == 0 && b->d == 0)
 101     return a->w2 - b->w2;              /* assertion: return w2 diff */
 102
 103   if (a->d == 0)                       /* a is assertion, b not */
 104     {
 105       x = a->w2 - pool->whatprovidesdata[b->d];
 106       return x ? x : -1;
 107     }
 108
 109   if (b->d == 0)                       /* b is assertion, a not */
 110     {
 111       x = pool->whatprovidesdata[a->d] - b->w2;
 112       return x ? x : 1;
 113     }
 114
 115   /* compare whatprovidesdata */
 116   ad = pool->whatprovidesdata + a->d;
 117   bd = pool->whatprovidesdata + b->d;
 118   while (*bd)
 119     if ((x = *ad++ - *bd++) != 0)
 120       return x;
 121   return *ad;
 122 }
 123
 124 int
 125 solver_rulecmp(Solver *solv, Rule *r1, Rule *r2)
 126 {
 127   return unifyrules_sortcmp(r1, r2, solv->pool);
 128 }
 129
 130
 131 /*-------------------------------------------------------------------
 132  *
 133  * unify rules
 134  * go over all rules and remove duplicates
 135  */
 136
 137 void
 138 solver_unifyrules(Solver *solv)
 139 {
 140   Pool *pool = solv->pool;
 141   int i, j;
 142   Rule *ir, *jr;
 143
 144   if (solv->nrules <= 2)               /* nothing to unify */
 145     return;
 146
 147   /* sort rules first */
 148   solv_sort(solv->rules + 1, solv->nrules - 1, sizeof(Rule), unifyrules_sortcmp, solv->pool);
 149
 150   /* prune rules
 151    * i = unpruned
 152    * j = pruned
 153    */
 154   jr = 0;
 155   for (i = j = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
 156     {
 157       if (jr && !unifyrules_sortcmp(ir, jr, pool))
 158         continue;                      /* prune! */
 159       jr = solv->rules + j++;          /* keep! */
 160       if (ir != jr)
 161         *jr = *ir;
 162     }
 163
 164   /* reduced count from nrules to j rules */
 165   POOL_DEBUG(SOLV_DEBUG_STATS, "pruned rules from %d to %d\n", solv->nrules, j);
 166
 167   /* adapt rule buffer */
 168   solv->nrules = j;
 169   solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
 170
 171   /*
 172    * debug: log rule statistics
 173    */
 174   IF_POOLDEBUG (SOLV_DEBUG_STATS)
 175     {
 176       int binr = 0;
 177       int lits = 0;
 178       Id *dp;
 179       Rule *r;
 180
 181       for (i = 1; i < solv->nrules; i++)
 182         {
 183           r = solv->rules + i;
 184           if (r->d == 0)
 185             binr++;
 186           else
 187             {
 188               dp = solv->pool->whatprovidesdata + r->d;
 189               while (*dp++)
 190                 lits++;
 191             }
 192         }
 193       POOL_DEBUG(SOLV_DEBUG_STATS, "  binary: %d\n", binr);
 194       POOL_DEBUG(SOLV_DEBUG_STATS, "  normal: %d, %d literals\n", solv->nrules - 1 - binr, lits);
 195     }
 196 }
 197
 198 #if 0
 199
 200 /*
 201  * hash rule
 202  */
 203
 204 static Hashval
 205 hashrule(Solver *solv, Id p, Id d, int n)
 206 {
 207   unsigned int x = (unsigned int)p;
 208   int *dp;
 209
 210   if (n <= 1)
 211     return (x * 37) ^ (unsigned int)d;
 212   dp = solv->pool->whatprovidesdata + d;
 213   while (*dp)
 214     x = (x * 37) ^ (unsigned int)*dp++;
 215   return x;
 216 }
 217 #endif
 218
 219
 220 /*-------------------------------------------------------------------
 221  *
 222  */
 223
 224 /*
 225  * add rule
 226  *  p = direct literal; always < 0 for installed rpm rules
 227  *  d, if < 0 direct literal, if > 0 offset into whatprovides, if == 0 rule is assertion (look at p only)
 228  *
 229  *
 230  * A requires b, b provided by B1,B2,B3 => (-A|B1|B2|B3)
 231  *
 232  * p < 0 : pkg id of A
 233  * d > 0 : Offset in whatprovidesdata (list of providers of b)
 234  *
 235  * A conflicts b, b provided by B1,B2,B3 => (-A|-B1), (-A|-B2), (-A|-B3)
 236  * p < 0 : pkg id of A
 237  * d < 0 : Id of solvable (e.g. B1)
 238  *
 239  * d == 0: unary rule, assertion => (A) or (-A)
 240  *
 241  *   Install:    p > 0, d = 0   (A)             user requested install
 242  *   Remove:     p < 0, d = 0   (-A)            user requested remove (also: uninstallable)
 243  *   Requires:   p < 0, d > 0   (-A|B1|B2|...)  d: <list of providers for requirement of p>
 244  *   Updates:    p > 0, d > 0   (A|B1|B2|...)   d: <list of updates for solvable p>
 245  *   Conflicts:  p < 0, d < 0   (-A|-B)         either p (conflict issuer) or d (conflict provider) (binary rule)
 246  *                                              also used for obsoletes
 247  *   ?:          p > 0, d < 0   (A|-B)
 248  *   No-op ?:    p = 0, d = 0   (null)          (used as policy rule placeholder)
 249  *
 250  *   resulting watches:
 251  *   ------------------
 252  *   Direct assertion (no watch needed) --> d = 0, w1 = p, w2 = 0
 253  *   Binary rule: p = first literal, d = 0, w2 = second literal, w1 = p
 254  *   every other : w1 = p, w2 = whatprovidesdata[d];
 255  *   Disabled rule: w1 = 0
 256  *
 257  *   always returns a rule for non-rpm rules
 258  */
 259
 260 Rule *
 261 solver_addrule(Solver *solv, Id p, Id d)
 262 {
 263   Pool *pool = solv->pool;
 264   Rule *r = 0;
 265   Id *dp = 0;
 266
 267   int n = 0;                           /* number of literals in rule - 1
 268                                           0 = direct assertion (single literal)
 269                                           1 = binary rule
 270                                           >1 =
 271                                         */
 272
 273   /* it often happenes that requires lead to adding the same rpm rule
 274    * multiple times, so we prune those duplicates right away to make
 275    * the work for unifyrules a bit easier */
 276
 277   if (!solv->rpmrules_end)              /* we add rpm rules */
 278     {
 279       r = solv->rules + solv->nrules - 1;       /* get the last added rule */
 280       if (r->p == p && r->d == d && (d != 0 || !r->w2))
 281         return r;
 282     }
 283
 284     /*
 285      * compute number of literals (n) in rule
 286      */
 287
 288   if (d < 0)
 289     {
 290       /* always a binary rule */
 291       if (p == d)
 292         return 0;                      /* ignore self conflict */
 293       n = 1;
 294     }
 295   else if (d > 0)
 296     {
 297       for (dp = pool->whatprovidesdata + d; *dp; dp++, n++)
 298         if (*dp == -p)
 299           return 0;                     /* rule is self-fulfilling */
 300
 301       if (n == 1)                       /* convert to binary rule */
 302         d = dp[-1];
 303     }
 304
 305   if (n == 1 && p > d && !solv->rpmrules_end)
 306     {
 307       /* smallest literal first so we can find dups */
 308       n = p; p = d; d = n;             /* p <-> d */
 309       n = 1;                           /* re-set n, was used as temp var */
 310     }
 311
 312   /*
 313    * check for duplicate
 314    */
 315
 316   /* check if the last added rule (r) is exactly the same as what we're looking for. */
 317   if (r && n == 1 && !r->d && r->p == p && r->w2 == d)
 318     return r;  /* binary rule */
 319
 320     /* have n-ary rule with same first literal, check other literals */
 321   if (r && n > 1 && r->d && r->p == p)
 322     {
 323       /* Rule where d is an offset in whatprovidesdata */
 324       Id *dp2;
 325       if (d == r->d)
 326         return r;
 327       dp2 = pool->whatprovidesdata + r->d;
 328       for (dp = pool->whatprovidesdata + d; *dp; dp++, dp2++)
 329         if (*dp != *dp2)
 330           break;
 331       if (*dp == *dp2)
 332         return r;
 333    }
 334
 335   /*
 336    * allocate new rule
 337    */
 338
 339   /* extend rule buffer */
 340   solv->rules = solv_extend(solv->rules, solv->nrules, 1, sizeof(Rule), RULES_BLOCK);
 341   r = solv->rules + solv->nrules++;    /* point to rule space */
 342
 343     /*
 344      * r = new rule
 345      */
 346
 347   r->p = p;
 348   if (n == 0)
 349     {
 350       /* direct assertion, no watch needed */
 351       r->d = 0;
 352       r->w1 = p;
 353       r->w2 = 0;
 354     }
 355   else if (n == 1)
 356     {
 357       /* binary rule */
 358       r->d = 0;
 359       r->w1 = p;
 360       r->w2 = d;
 361     }
 362   else
 363     {
 364       r->d = d;
 365       r->w1 = p;
 366       r->w2 = pool->whatprovidesdata[d];
 367     }
 368   r->n1 = 0;
 369   r->n2 = 0;
 370
 371   IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 372     {
 373       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "  Add rule: ");
 374       solver_printrule(solv, SOLV_DEBUG_RULE_CREATION, r);
 375     }
 376
 377   return r;
 378 }
 379
 380
 381 /******************************************************************************
 382  ***
 383  *** rpm rule part: create rules representing the package dependencies
 384  ***
 385  ***/
 386
 387 /*
 388  *  special multiversion patch conflict handling:
 389  *  a patch conflict is also satisfied if some other
 390  *  version with the same name/arch that doesn't conflict
 391  *  gets installed. The generated rule is thus:
 392  *  -patch|-cpack|opack1|opack2|...
 393  */
 394 static Id
 395 makemultiversionconflict(Solver *solv, Id n, Id con)
 396 {
 397   Pool *pool = solv->pool;
 398   Solvable *s, *sn;
 399   Queue q;
 400   Id p, pp, qbuf[64];
 401
 402   sn = pool->solvables + n;
 403   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
 404   queue_push(&q, -n);
 405   FOR_PROVIDES(p, pp, sn->name)
 406     {
 407       s = pool->solvables + p;
 408       if (s->name != sn->name || s->arch != sn->arch)
 409         continue;
 410       if (!MAPTST(&solv->noobsoletes, p))
 411         continue;
 412       if (pool_match_nevr(pool, pool->solvables + p, con))
 413         continue;
 414       /* here we have a multiversion solvable that doesn't conflict */
 415       /* thus we're not in conflict if it is installed */
 416       queue_push(&q, p);
 417     }
 418   if (q.count == 1)
 419     return -n;  /* no other package found, generate normal conflict */
 420   return pool_queuetowhatprovides(pool, &q);
 421 }
 422
 423 static inline void
 424 addrpmrule(Solver *solv, Id p, Id d, int type, Id dep)
 425 {
 426   if (!solv->ruleinfoq)
 427     solver_addrule(solv, p, d);
 428   else
 429     addrpmruleinfo(solv, p, d, type, dep);
 430 }
 431
 432 /*-------------------------------------------------------------------
 433  *
 434  * add (install) rules for solvable
 435  *
 436  * s: Solvable for which to add rules
 437  * m: m[s] = 1 for solvables which have rules, prevent rule duplication
 438  *
 439  * Algorithm: 'visit all nodes of a graph'. The graph nodes are
 440  *  solvables, the edges their dependencies.
 441  *  Starting from an installed solvable, this will create all rules
 442  *  representing the graph created by the solvables dependencies.
 443  *
 444  * for unfulfilled requirements, conflicts, obsoletes,....
 445  * add a negative assertion for solvables that are not installable
 446  *
 447  * It will also create rules for all solvables referenced by 's'
 448  *  i.e. descend to all providers of requirements of 's'
 449  *
 450  */
 451
 452 void
 453 solver_addrpmrulesforsolvable(Solver *solv, Solvable *s, Map *m)
 454 {
 455   Pool *pool = solv->pool;
 456   Repo *installed = solv->installed;
 457
 458   /* 'work' queue. keeps Ids of solvables we still have to work on.
 459      And buffer for it. */
 460   Queue workq;
 461   Id workqbuf[64];
 462
 463   int i;
 464     /* if to add rules for broken deps ('rpm -V' functionality)
 465      * 0 = yes, 1 = no
 466      */
 467   int dontfix;
 468     /* Id var and pointer for each dependency
 469      * (not used in parallel)
 470      */
 471   Id req, *reqp;
 472   Id con, *conp;
 473   Id obs, *obsp;
 474   Id rec, *recp;
 475   Id sug, *sugp;
 476   Id p, pp;             /* whatprovides loops */
 477   Id *dp;               /* ptr to 'whatprovides' */
 478   Id n;                 /* Id for current solvable 's' */
 479
 480   queue_init_buffer(&workq, workqbuf, sizeof(workqbuf)/sizeof(*workqbuf));
 481   queue_push(&workq, s - pool->solvables);      /* push solvable Id to work queue */
 482
 483   /* loop until there's no more work left */
 484   while (workq.count)
 485     {
 486       /*
 487        * n: Id of solvable
 488        * s: Pointer to solvable
 489        */
 490
 491       n = queue_shift(&workq);          /* 'pop' next solvable to work on from queue */
 492       if (m)
 493         {
 494           if (MAPTST(m, n))             /* continue if already visited */
 495             continue;
 496           MAPSET(m, n);                 /* mark as visited */
 497         }
 498
 499       s = pool->solvables + n;          /* s = Solvable in question */
 500
 501       dontfix = 0;
 502       if (installed                     /* Installed system available */
 503           && s->repo == installed       /* solvable is installed */
 504           && !solv->fixmap_all          /* NOT repair errors in rpm dependency graph */
 505           && !(solv->fixmap.size && MAPTST(&solv->fixmap, n - installed->start)))
 506         {
 507           dontfix = 1;                  /* dont care about broken rpm deps */
 508         }
 509
 510       if (!dontfix
 511           && s->arch != ARCH_SRC
 512           && s->arch != ARCH_NOSRC
 513           && !pool_installable(pool, s))
 514         {
 515           POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables));
 516           addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOT_INSTALLABLE, 0);
 517         }
 518
 519       /* yet another SUSE hack, sigh */
 520       if (pool->nscallback && !strncmp("product:", pool_id2str(pool, s->name), 8))
 521         {
 522           Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, n);
 523           if (buddy > 0 && buddy != SYSTEMSOLVABLE && buddy != n && buddy < pool->nsolvables)
 524             {
 525               addrpmrule(solv, n, -buddy, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + n));
 526               addrpmrule(solv, buddy, -n, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + buddy));
 527               if (m && !MAPTST(m, buddy))
 528                 queue_push(&workq, buddy);
 529             }
 530         }
 531
 532       /*-----------------------------------------
 533        * check requires of s
 534        */
 535
 536       if (s->requires)
 537         {
 538           reqp = s->repo->idarraydata + s->requires;
 539           while ((req = *reqp++) != 0)            /* go through all requires */
 540             {
 541               if (req == SOLVABLE_PREREQMARKER)   /* skip the marker */
 542                 continue;
 543
 544               /* find list of solvables providing 'req' */
 545               dp = pool_whatprovides_ptr(pool, req);
 546
 547               if (*dp == SYSTEMSOLVABLE)          /* always installed */
 548                 continue;
 549
 550               if (dontfix)
 551                 {
 552                   /* the strategy here is to not insist on dependencies
 553                    * that are already broken. so if we find one provider
 554                    * that was already installed, we know that the
 555                    * dependency was not broken before so we enforce it */
 556
 557                   /* check if any of the providers for 'req' is installed */
 558                   for (i = 0; (p = dp[i]) != 0; i++)
 559                     {
 560                       if (pool->solvables[p].repo == installed)
 561                         break;          /* provider was installed */
 562                     }
 563                   /* didn't find an installed provider: previously broken dependency */
 564                   if (!p)
 565                     {
 566                       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken requires %s of installed package %s\n", pool_dep2str(pool, req), pool_solvable2str(pool, s));
 567                       continue;
 568                     }
 569                 }
 570
 571               if (!*dp)
 572                 {
 573                   /* nothing provides req! */
 574                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables), pool_dep2str(pool, req));
 575                   addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOTHING_PROVIDES_DEP, req);
 576                   continue;
 577                 }
 578
 579               IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 580                 {
 581                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION,"  %s requires %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
 582                   for (i = 0; dp[i]; i++)
 583                     POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "   provided by %s\n", pool_solvid2str(pool, dp[i]));
 584                 }
 585
 586               /* add 'requires' dependency */
 587               /* rule: (-requestor|provider1|provider2|...|providerN) */
 588               addrpmrule(solv, -n, dp - pool->whatprovidesdata, SOLVER_RULE_RPM_PACKAGE_REQUIRES, req);
 589
 590               /* descend the dependency tree
 591                  push all non-visited providers on the work queue */
 592               if (m)
 593                 {
 594                   for (; *dp; dp++)
 595                     {
 596                       if (!MAPTST(m, *dp))
 597                         queue_push(&workq, *dp);
 598                     }
 599                 }
 600
 601             } /* while, requirements of n */
 602
 603         } /* if, requirements */
 604
 605       /* that's all we check for src packages */
 606       if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC)
 607         continue;
 608
 609       /*-----------------------------------------
 610        * check conflicts of s
 611        */
 612
 613       if (s->conflicts)
 614         {
 615           int ispatch = 0;
 616
 617           /* we treat conflicts in patches a bit differen:
 618            * - nevr matching
 619            * - multiversion handling
 620            * XXX: we should really handle this different, looking
 621            * at the name is a bad hack
 622            */
 623           if (!strncmp("patch:", pool_id2str(pool, s->name), 6))
 624             ispatch = 1;
 625           conp = s->repo->idarraydata + s->conflicts;
 626           /* foreach conflicts of 's' */
 627           while ((con = *conp++) != 0)
 628             {
 629               /* foreach providers of a conflict of 's' */
 630               FOR_PROVIDES(p, pp, con)
 631                 {
 632                   if (ispatch && !pool_match_nevr(pool, pool->solvables + p, con))
 633                     continue;
 634                   /* dontfix: dont care about conflicts with already installed packs */
 635                   if (dontfix && pool->solvables[p].repo == installed)
 636                     continue;
 637                   /* p == n: self conflict */
 638                   if (p == n && pool->forbidselfconflicts)
 639                     {
 640                       if (ISRELDEP(con))
 641                         {
 642                           Reldep *rd = GETRELDEP(pool, con);
 643                           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_OTHERPROVIDERS)
 644                             continue;
 645                         }
 646                       p = 0;    /* make it a negative assertion, aka 'uninstallable' */
 647                     }
 648                   if (p && ispatch && solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p) && ISRELDEP(con))
 649                     {
 650                       /* our patch conflicts with a noobsoletes (aka multiversion) package */
 651                       p = -makemultiversionconflict(solv, p, con);
 652                     }
 653                  /* rule: -n|-p: either solvable _or_ provider of conflict */
 654                   addrpmrule(solv, -n, -p, p ? SOLVER_RULE_RPM_PACKAGE_CONFLICT : SOLVER_RULE_RPM_SELF_CONFLICT, con);
 655                 }
 656             }
 657         }
 658
 659       /*-----------------------------------------
 660        * check obsoletes and implicit obsoletes of a package
 661        * if ignoreinstalledsobsoletes is not set, we're also checking
 662        * obsoletes of installed packages (like newer rpm versions)
 663        */
 664       if ((!installed || s->repo != installed) || !pool->noinstalledobsoletes)
 665         {
 666           int noobs = solv->noobsoletes.size && MAPTST(&solv->noobsoletes, n);
 667           int isinstalled = (installed && s->repo == installed);
 668           if (s->obsoletes && (!noobs || solv->keepexplicitobsoletes))
 669             {
 670               obsp = s->repo->idarraydata + s->obsoletes;
 671               /* foreach obsoletes */
 672               while ((obs = *obsp++) != 0)
 673                 {
 674                   /* foreach provider of an obsoletes of 's' */
 675                   FOR_PROVIDES(p, pp, obs)
 676                     {
 677                       Solvable *ps = pool->solvables + p;
 678                       if (p == n)
 679                         continue;
 680                       if (isinstalled && dontfix && ps->repo == installed)
 681                         continue;       /* don't repair installed/installed problems */
 682                       if (!pool->obsoleteusesprovides /* obsoletes are matched names, not provides */
 683                           && !pool_match_nevr(pool, ps, obs))
 684                         continue;
 685                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 686                         continue;
 687                       if (!isinstalled)
 688                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_PACKAGE_OBSOLETES, obs);
 689                       else
 690                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_INSTALLEDPKG_OBSOLETES, obs);
 691                     }
 692                 }
 693             }
 694           /* check implicit obsoletes
 695            * for installed packages we only need to check installed/installed problems (and
 696            * only when dontfix is not set), as the others are picked up when looking at the
 697            * uninstalled package.
 698            */
 699           if (!isinstalled || !dontfix)
 700             {
 701               FOR_PROVIDES(p, pp, s->name)
 702                 {
 703                   Solvable *ps = pool->solvables + p;
 704                   if (p == n)
 705                     continue;
 706                   if (isinstalled && ps->repo != installed)
 707                     continue;
 708                   /* we still obsolete packages with same nevra, like rpm does */
 709                   /* (actually, rpm mixes those packages. yuck...) */
 710                   if (noobs && (s->name != ps->name || s->evr != ps->evr || s->arch != ps->arch))
 711                     continue;
 712                   if (!pool->implicitobsoleteusesprovides && s->name != ps->name)
 713                     continue;
 714                   if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 715                     continue;
 716                   if (s->name == ps->name)
 717                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_SAME_NAME, 0);
 718                   else
 719                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_IMPLICIT_OBSOLETES, s->name);
 720                 }
 721             }
 722         }
 723
 724       /*-----------------------------------------
 725        * add recommends to the work queue
 726        */
 727       if (s->recommends && m)
 728         {
 729           recp = s->repo->idarraydata + s->recommends;
 730           while ((rec = *recp++) != 0)
 731             {
 732               FOR_PROVIDES(p, pp, rec)
 733                 if (!MAPTST(m, p))
 734                   queue_push(&workq, p);
 735             }
 736         }
 737       if (s->suggests && m)
 738         {
 739           sugp = s->repo->idarraydata + s->suggests;
 740           while ((sug = *sugp++) != 0)
 741             {
 742               FOR_PROVIDES(p, pp, sug)
 743                 if (!MAPTST(m, p))
 744                   queue_push(&workq, p);
 745             }
 746         }
 747     }
 748   queue_free(&workq);
 749 }
 750
 751
 752 /*-------------------------------------------------------------------
 753  *
 754  * Add rules for packages possibly selected in by weak dependencies
 755  *
 756  * m: already added solvables
 757  */
 758
 759 void
 760 solver_addrpmrulesforweak(Solver *solv, Map *m)
 761 {
 762   Pool *pool = solv->pool;
 763   Solvable *s;
 764   Id sup, *supp;
 765   int i, n;
 766
 767   /* foreach solvable in pool */
 768   for (i = n = 1; n < pool->nsolvables; i++, n++)
 769     {
 770       if (i == pool->nsolvables)                /* wrap i */
 771         i = 1;
 772       if (MAPTST(m, i))                         /* already added that one */
 773         continue;
 774
 775       s = pool->solvables + i;
 776       if (!s->repo)
 777         continue;
 778       if (s->repo != pool->installed && !pool_installable(pool, s))
 779         continue;       /* only look at installable ones */
 780
 781       sup = 0;
 782       if (s->supplements)
 783         {
 784           /* find possible supplements */
 785           supp = s->repo->idarraydata + s->supplements;
 786           while ((sup = *supp++) != 0)
 787             if (dep_possible(solv, sup, m))
 788               break;
 789         }
 790
 791       /* if nothing found, check for enhances */
 792       if (!sup && s->enhances)
 793         {
 794           supp = s->repo->idarraydata + s->enhances;
 795           while ((sup = *supp++) != 0)
 796             if (dep_possible(solv, sup, m))
 797               break;
 798         }
 799       /* if nothing found, goto next solvables */
 800       if (!sup)
 801         continue;
 802       solver_addrpmrulesforsolvable(solv, s, m);
 803       n = 0;                    /* check all solvables again because we added solvables to m */
 804     }
 805 }
 806
 807
 808 /*-------------------------------------------------------------------
 809  *
 810  * add package rules for possible updates
 811  *
 812  * s: solvable
 813  * m: map of already visited solvables
 814  * allow_all: 0 = dont allow downgrades, 1 = allow all candidates
 815  */
 816
 817 void
 818 solver_addrpmrulesforupdaters(Solver *solv, Solvable *s, Map *m, int allow_all)
 819 {
 820   Pool *pool = solv->pool;
 821   int i;
 822     /* queue and buffer for it */
 823   Queue qs;
 824   Id qsbuf[64];
 825
 826   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 827     /* find update candidates for 's' */
 828   policy_findupdatepackages(solv, s, &qs, allow_all);
 829     /* add rule for 's' if not already done */
 830   if (!MAPTST(m, s - pool->solvables))
 831     solver_addrpmrulesforsolvable(solv, s, m);
 832     /* foreach update candidate, add rule if not already done */
 833   for (i = 0; i < qs.count; i++)
 834     if (!MAPTST(m, qs.elements[i]))
 835       solver_addrpmrulesforsolvable(solv, pool->solvables + qs.elements[i], m);
 836   queue_free(&qs);
 837 }
 838
 839
 840 /***********************************************************************
 841  ***
 842  ***  Update/Feature rule part
 843  ***
 844  ***  Those rules make sure an installed package isn't silently deleted
 845  ***
 846  ***/
 847
 848 static Id
 849 finddistupgradepackages(Solver *solv, Solvable *s, Queue *qs, int allow_all)
 850 {
 851   Pool *pool = solv->pool;
 852   int i;
 853
 854   policy_findupdatepackages(solv, s, qs, allow_all ? allow_all : 2);
 855   if (!qs->count)
 856     {
 857       if (allow_all)
 858         return 0;       /* orphaned, don't create feature rule */
 859       /* check if this is an orphaned package */
 860       policy_findupdatepackages(solv, s, qs, 1);
 861       if (!qs->count)
 862         return 0;       /* orphaned, don't create update rule */
 863       qs->count = 0;
 864       return -SYSTEMSOLVABLE;   /* supported but not installable */
 865     }
 866   if (allow_all)
 867     return s - pool->solvables;
 868   /* check if it is ok to keep the installed package */
 869   for (i = 0; i < qs->count; i++)
 870     {
 871       Solvable *ns = pool->solvables + qs->elements[i];
 872       if (s->evr == ns->evr && solvable_identical(s, ns))
 873         return s - pool->solvables;
 874     }
 875   /* nope, it must be some other package */
 876   return -SYSTEMSOLVABLE;
 877 }
 878
 879 /* add packages from the dup repositories to the update candidates
 880  * this isn't needed for the global dup mode as all packages are
 881  * from dup repos in that case */
 882 static void
 883 addduppackages(Solver *solv, Solvable *s, Queue *qs)
 884 {
 885   Queue dupqs;
 886   Id p, dupqsbuf[64];
 887   int i;
 888   int oldnoupdateprovide = solv->noupdateprovide;
 889
 890   queue_init_buffer(&dupqs, dupqsbuf, sizeof(dupqsbuf)/sizeof(*dupqsbuf));
 891   solv->noupdateprovide = 1;
 892   policy_findupdatepackages(solv, s, &dupqs, 2);
 893   solv->noupdateprovide = oldnoupdateprovide;
 894   for (i = 0; i < dupqs.count; i++)
 895     {
 896       p = dupqs.elements[i];
 897       if (MAPTST(&solv->dupmap, p))
 898         queue_pushunique(qs, p);
 899     }
 900   queue_free(&dupqs);
 901 }
 902
 903 /*-------------------------------------------------------------------
 904  *
 905  * add rule for update
 906  *   (A|A1|A2|A3...)  An = update candidates for A
 907  *
 908  * s = (installed) solvable
 909  */
 910
 911 void
 912 solver_addupdaterule(Solver *solv, Solvable *s, int allow_all)
 913 {
 914   /* installed packages get a special upgrade allowed rule */
 915   Pool *pool = solv->pool;
 916   Id p, d;
 917   Queue qs;
 918   Id qsbuf[64];
 919
 920   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 921   p = s - pool->solvables;
 922   /* find update candidates for 's' */
 923   if (solv->dupmap_all)
 924     p = finddistupgradepackages(solv, s, &qs, allow_all);
 925   else
 926     policy_findupdatepackages(solv, s, &qs, allow_all);
 927   if (!allow_all && !solv->dupmap_all && solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
 928     addduppackages(solv, s, &qs);
 929
 930   if (!allow_all && qs.count && solv->noobsoletes.size)
 931     {
 932       int i, j;
 933
 934       d = pool_queuetowhatprovides(pool, &qs);
 935       /* filter out all noobsoletes packages as they don't update */
 936       for (i = j = 0; i < qs.count; i++)
 937         {
 938           if (MAPTST(&solv->noobsoletes, qs.elements[i]))
 939             {
 940               /* it's ok if they have same nevra */
 941               Solvable *ps = pool->solvables + qs.elements[i];
 942               if (ps->name != s->name || ps->evr != s->evr || ps->arch != s->arch)
 943                 continue;
 944             }
 945           qs.elements[j++] = qs.elements[i];
 946         }
 947       if (j < qs.count)
 948         {
 949           if (d && solv->installed && s->repo == solv->installed &&
 950               (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, s - pool->solvables - solv->installed->start))))
 951             {
 952               if (!solv->multiversionupdaters)
 953                 solv->multiversionupdaters = solv_calloc(solv->installed->end - solv->installed->start, sizeof(Id));
 954               solv->multiversionupdaters[s - pool->solvables - solv->installed->start] = d;
 955             }
 956           if (j == 0 && p == -SYSTEMSOLVABLE && solv->dupmap_all)
 957             {
 958               queue_push(&solv->orphaned, s - pool->solvables); /* treat as orphaned */
 959               j = qs.count;
 960             }
 961           qs.count = j;
 962         }
 963       else if (p != -SYSTEMSOLVABLE)
 964         {
 965           /* could fallthrough, but then we would do pool_queuetowhatprovides twice */
 966           queue_free(&qs);
 967           solver_addrule(solv, p, d);   /* allow update of s */
 968           return;
 969         }
 970     }
 971   if (qs.count && p == -SYSTEMSOLVABLE)
 972     p = queue_shift(&qs);
 973   d = qs.count ? pool_queuetowhatprovides(pool, &qs) : 0;
 974   queue_free(&qs);
 975   solver_addrule(solv, p, d);   /* allow update of s */
 976 }
 977
 978 static inline void
 979 disableupdaterule(Solver *solv, Id p)
 980 {
 981   Rule *r;
 982
 983   MAPSET(&solv->noupdate, p - solv->installed->start);
 984   r = solv->rules + solv->updaterules + (p - solv->installed->start);
 985   if (r->p && r->d >= 0)
 986     solver_disablerule(solv, r);
 987   r = solv->rules + solv->featurerules + (p - solv->installed->start);
 988   if (r->p && r->d >= 0)
 989     solver_disablerule(solv, r);
 990   if (solv->bestrules_pkg)
 991     {
 992       int i, ni;
 993       ni = solv->bestrules_end - solv->bestrules;
 994       for (i = 0; i < ni; i++)
 995         if (solv->bestrules_pkg[i] == p)
 996           solver_disablerule(solv, solv->rules + solv->bestrules + i);
 997     }
 998 }
 999
1000 static inline void
1001 reenableupdaterule(Solver *solv, Id p)
1002 {
1003   Pool *pool = solv->pool;
1004   Rule *r;
1005
1006   MAPCLR(&solv->noupdate, p - solv->installed->start);
1007   r = solv->rules + solv->updaterules + (p - solv->installed->start);
1008   if (r->p)
1009     {
1010       if (r->d < 0)
1011         {
1012           solver_enablerule(solv, r);
1013           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1014             {
1015               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1016               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1017             }
1018         }
1019     }
1020   else
1021     {
1022       r = solv->rules + solv->featurerules + (p - solv->installed->start);
1023       if (r->p && r->d < 0)
1024         {
1025           solver_enablerule(solv, r);
1026           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1027             {
1028               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1029               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1030             }
1031         }
1032     }
1033   if (solv->bestrules_pkg)
1034     {
1035       int i, ni;
1036       ni = solv->bestrules_end - solv->bestrules;
1037       for (i = 0; i < ni; i++)
1038         if (solv->bestrules_pkg[i] == p)
1039           solver_enablerule(solv, solv->rules + solv->bestrules + i);
1040     }
1041 }
1042
1043
1044 /***********************************************************************
1045  ***
1046  ***  Infarch rule part
1047  ***
1048  ***  Infarch rules make sure the solver uses the best architecture of
1049  ***  a package if multiple archetectures are available
1050  ***
1051  ***/
1052
1053 void
1054 solver_addinfarchrules(Solver *solv, Map *addedmap)
1055 {
1056   Pool *pool = solv->pool;
1057   int first, i, j;
1058   Id p, pp, a, aa, bestarch;
1059   Solvable *s, *ps, *bests;
1060   Queue badq, allowedarchs;
1061
1062   queue_init(&badq);
1063   queue_init(&allowedarchs);
1064   solv->infarchrules = solv->nrules;
1065   for (i = 1; i < pool->nsolvables; i++)
1066     {
1067       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1068         continue;
1069       s = pool->solvables + i;
1070       first = i;
1071       bestarch = 0;
1072       bests = 0;
1073       queue_empty(&allowedarchs);
1074       FOR_PROVIDES(p, pp, s->name)
1075         {
1076           ps = pool->solvables + p;
1077           if (ps->name != s->name || !MAPTST(addedmap, p))
1078             continue;
1079           if (p == i)
1080             first = 0;
1081           if (first)
1082             break;
1083           a = ps->arch;
1084           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1085           if (a != 1 && pool->installed && ps->repo == pool->installed)
1086             {
1087               if (!solv->dupmap_all && !(solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1088                 queue_pushunique(&allowedarchs, ps->arch);      /* also ok to keep this architecture */
1089               continue;         /* ignore installed solvables when calculating the best arch */
1090             }
1091           if (a && a != 1 && (!bestarch || a < bestarch))
1092             {
1093               bestarch = a;
1094               bests = ps;
1095             }
1096         }
1097       if (first)
1098         continue;
1099       /* speed up common case where installed package already has best arch */
1100       if (allowedarchs.count == 1 && bests && allowedarchs.elements[0] == bests->arch)
1101         allowedarchs.count--;   /* installed arch is best */
1102       queue_empty(&badq);
1103       FOR_PROVIDES(p, pp, s->name)
1104         {
1105           ps = pool->solvables + p;
1106           if (ps->name != s->name || !MAPTST(addedmap, p))
1107             continue;
1108           a = ps->arch;
1109           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1110           if (a != 1 && bestarch && ((a ^ bestarch) & 0xffff0000) != 0)
1111             {
1112               if (pool->installed && ps->repo == pool->installed)
1113                 continue;       /* always ok to keep an installed package */
1114               for (j = 0; j < allowedarchs.count; j++)
1115                 {
1116                   aa = allowedarchs.elements[j];
1117                   if (ps->arch == aa)
1118                     break;
1119                   aa = (aa <= pool->lastarch) ? pool->id2arch[aa] : 0;
1120                   if (aa && ((a ^ aa) & 0xffff0000) == 0)
1121                     break;      /* compatible */
1122                 }
1123               if (j == allowedarchs.count)
1124                 queue_push(&badq, p);
1125             }
1126         }
1127       if (!badq.count)
1128         continue;
1129       /* block all solvables in the badq! */
1130       for (j = 0; j < badq.count; j++)
1131         {
1132           p = badq.elements[j];
1133           solver_addrule(solv, -p, 0);
1134         }
1135     }
1136   queue_free(&badq);
1137   queue_free(&allowedarchs);
1138   solv->infarchrules_end = solv->nrules;
1139 }
1140
1141 static inline void
1142 disableinfarchrule(Solver *solv, Id name)
1143 {
1144   Pool *pool = solv->pool;
1145   Rule *r;
1146   int i;
1147   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1148     {
1149       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1150         solver_disablerule(solv, r);
1151     }
1152 }
1153
1154 static inline void
1155 reenableinfarchrule(Solver *solv, Id name)
1156 {
1157   Pool *pool = solv->pool;
1158   Rule *r;
1159   int i;
1160   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1161     {
1162       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1163         {
1164           solver_enablerule(solv, r);
1165           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1166             {
1167               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1168               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1169             }
1170         }
1171     }
1172 }
1173
1174
1175 /***********************************************************************
1176  ***
1177  ***  Dup rule part
1178  ***
1179  ***  Dup rules make sure a package is selected from the specified dup
1180  ***  repositories if an update candidate is included in one of them.
1181  ***
1182  ***/
1183
1184 void
1185 solver_createdupmaps(Solver *solv)
1186 {
1187   Queue *job = &solv->job;
1188   Pool *pool = solv->pool;
1189   Repo *repo;
1190   Repo *installed = solv->installed;
1191   Id select, how, what, p, pi, pp, pip, obs, *obsp;
1192   Solvable *s, *ps;
1193   int i;
1194
1195   map_init(&solv->dupmap, pool->nsolvables);
1196   map_init(&solv->dupinvolvedmap, pool->nsolvables);
1197   for (i = 0; i < job->count; i += 2)
1198     {
1199       how = job->elements[i];
1200       select = job->elements[i] & SOLVER_SELECTMASK;
1201       what = job->elements[i + 1];
1202       switch (how & SOLVER_JOBMASK)
1203         {
1204         case SOLVER_DISTUPGRADE:
1205           if (select != SOLVER_SOLVABLE_REPO)
1206             {
1207               int haveinstalled;
1208               p = 0;
1209               if (installed)
1210                 {
1211                   FOR_JOB_SELECT(p, pp, select, what)
1212                     if (pool->solvables[p].repo == installed)
1213                       break;
1214                 }
1215               haveinstalled = p != 0;
1216               FOR_JOB_SELECT(p, pp, select, what)
1217                 {
1218                   Solvable *s = pool->solvables + p;
1219                   if (!s->repo)
1220                     continue;
1221                   if (haveinstalled && s->repo != installed)
1222                     continue;
1223                   if (s->repo != installed && !pool_installable(pool, s))
1224                     continue;
1225                   MAPSET(&solv->dupinvolvedmap, p);
1226                   if (!haveinstalled)
1227                     MAPSET(&solv->dupmap, p);
1228                   FOR_PROVIDES(pi, pip, s->name)
1229                     {
1230                       ps = pool->solvables + pi;
1231                       if (ps->name != s->name)
1232                         continue;
1233                       MAPSET(&solv->dupinvolvedmap, pi);
1234                       if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1235                         {
1236                           if (!solv->bestupdatemap.size)
1237                             map_grow(&solv->bestupdatemap, installed->end - installed->start);
1238                           MAPSET(&solv->bestupdatemap, pi - installed->start);
1239                         }
1240                       if (haveinstalled && ps->repo != installed)
1241                         MAPSET(&solv->dupmap, pi);
1242                     }
1243                   if (haveinstalled)
1244                     {
1245                       if (solv->obsoletes && solv->obsoletes[p - installed->start])
1246                         {
1247                           Id *opp;
1248                           for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (pi = *opp++) != 0;)
1249                             {
1250                               ps = pool->solvables + pi;
1251                               if (ps->repo == installed)
1252                                 continue;
1253                               MAPSET(&solv->dupinvolvedmap, pi);
1254                               MAPSET(&solv->dupmap, pi);
1255                             }
1256                         }
1257                     }
1258                   else if (s->obsoletes)
1259                     {
1260                       /* XXX: check obsoletes/provides combination */
1261                       obsp = s->repo->idarraydata + s->obsoletes;
1262                       while ((obs = *obsp++) != 0)
1263                         {
1264                           FOR_PROVIDES(pi, pp, obs)
1265                             {
1266                               Solvable *ps = pool->solvables + pi;
1267                               if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1268                                 continue;
1269                               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1270                                 continue;
1271                               MAPSET(&solv->dupinvolvedmap, pi);
1272                               if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1273                                 {
1274                                   if (!solv->bestupdatemap.size)
1275                                     map_grow(&solv->bestupdatemap, installed->end - installed->start);
1276                                   MAPSET(&solv->bestupdatemap, pi - installed->start);
1277                                 }
1278                             }
1279                         }
1280                     }
1281                 }
1282               break;
1283             }
1284           if (what <= 0 || what > pool->nrepos)
1285             break;
1286           repo = pool_id2repo(pool, what);
1287           FOR_REPO_SOLVABLES(repo, p, s)
1288             {
1289               if (repo != installed && !pool_installable(pool, s))
1290                 continue;
1291               MAPSET(&solv->dupmap, p);
1292               FOR_PROVIDES(pi, pip, s->name)
1293                 {
1294                   ps = pool->solvables + pi;
1295                   if (ps->name != s->name)
1296                     continue;
1297                   MAPSET(&solv->dupinvolvedmap, pi);
1298                   if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1299                     {
1300                       if (!solv->bestupdatemap.size)
1301                         map_grow(&solv->bestupdatemap, installed->end - installed->start);
1302                       MAPSET(&solv->bestupdatemap, pi - installed->start);
1303                     }
1304                 }
1305               if (s->obsoletes)
1306                 {
1307                   /* XXX: check obsoletes/provides combination */
1308                   obsp = s->repo->idarraydata + s->obsoletes;
1309                   while ((obs = *obsp++) != 0)
1310                     {
1311                       FOR_PROVIDES(pi, pp, obs)
1312                         {
1313                           Solvable *ps = pool->solvables + pi;
1314                           if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1315                             continue;
1316                           if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1317                             continue;
1318                           MAPSET(&solv->dupinvolvedmap, pi);
1319                           if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1320                             {
1321                               if (!solv->bestupdatemap.size)
1322                                 map_grow(&solv->bestupdatemap, installed->end - installed->start);
1323                               MAPSET(&solv->bestupdatemap, pi - installed->start);
1324                             }
1325                         }
1326                     }
1327                 }
1328             }
1329           break;
1330         default:
1331           break;
1332         }
1333     }
1334   MAPCLR(&solv->dupinvolvedmap, SYSTEMSOLVABLE);
1335 }
1336
1337 void
1338 solver_freedupmaps(Solver *solv)
1339 {
1340   map_free(&solv->dupmap);
1341   /* we no longer free solv->dupinvolvedmap as we need it in
1342    * policy's priority pruning code. sigh. */
1343 }
1344
1345 void
1346 solver_addduprules(Solver *solv, Map *addedmap)
1347 {
1348   Pool *pool = solv->pool;
1349   Id p, pp;
1350   Solvable *s, *ps;
1351   int first, i;
1352
1353   solv->duprules = solv->nrules;
1354   for (i = 1; i < pool->nsolvables; i++)
1355     {
1356       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1357         continue;
1358       s = pool->solvables + i;
1359       first = i;
1360       FOR_PROVIDES(p, pp, s->name)
1361         {
1362           ps = pool->solvables + p;
1363           if (ps->name != s->name || !MAPTST(addedmap, p))
1364             continue;
1365           if (p == i)
1366             first = 0;
1367           if (first)
1368             break;
1369           if (!MAPTST(&solv->dupinvolvedmap, p))
1370             continue;
1371           if (solv->installed && ps->repo == solv->installed)
1372             {
1373               if (!solv->updatemap.size)
1374                 map_grow(&solv->updatemap, solv->installed->end - solv->installed->start);
1375               MAPSET(&solv->updatemap, p - solv->installed->start);
1376               if (!MAPTST(&solv->dupmap, p))
1377                 {
1378                   Id ip, ipp;
1379                   /* is installed identical to a good one? */
1380                   FOR_PROVIDES(ip, ipp, ps->name)
1381                     {
1382                       Solvable *is = pool->solvables + ip;
1383                       if (!MAPTST(&solv->dupmap, ip))
1384                         continue;
1385                       if (is->evr == ps->evr && solvable_identical(ps, is))
1386                         break;
1387                     }
1388                   if (!ip)
1389                     solver_addrule(solv, -p, 0);        /* no match, sorry */
1390                   else
1391                     MAPSET(&solv->dupmap, p);           /* for best rules processing */
1392                 }
1393             }
1394           else if (!MAPTST(&solv->dupmap, p))
1395             solver_addrule(solv, -p, 0);
1396         }
1397     }
1398   solv->duprules_end = solv->nrules;
1399 }
1400
1401
1402 static inline void
1403 disableduprule(Solver *solv, Id name)
1404 {
1405   Pool *pool = solv->pool;
1406   Rule *r;
1407   int i;
1408   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1409     {
1410       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1411         solver_disablerule(solv, r);
1412     }
1413 }
1414
1415 static inline void
1416 reenableduprule(Solver *solv, Id name)
1417 {
1418   Pool *pool = solv->pool;
1419   Rule *r;
1420   int i;
1421   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1422     {
1423       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1424         {
1425           solver_enablerule(solv, r);
1426           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1427             {
1428               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1429               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1430             }
1431         }
1432     }
1433 }
1434
1435
1436 /***********************************************************************
1437  ***
1438  ***  Policy rule disabling/reenabling
1439  ***
1440  ***  Disable all policy rules that conflict with our jobs. If a job
1441  ***  gets disabled later on, reenable the involved policy rules again.
1442  ***
1443  ***/
1444
1445 #define DISABLE_UPDATE  1
1446 #define DISABLE_INFARCH 2
1447 #define DISABLE_DUP     3
1448
1449 /*
1450  * add all installed packages that package p obsoletes to Queue q.
1451  * Package p is not installed. Also, we know that if
1452  * solv->keepexplicitobsoletes is not set, p is not in the noobs map.
1453  * Entries may get added multiple times.
1454  */
1455 static void
1456 add_obsoletes(Solver *solv, Id p, Queue *q)
1457 {
1458   Pool *pool = solv->pool;
1459   Repo *installed = solv->installed;
1460   Id p2, pp2;
1461   Solvable *s = pool->solvables + p;
1462   Id obs, *obsp;
1463   Id lastp2 = 0;
1464
1465   if (!solv->keepexplicitobsoletes || !(solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p)))
1466     {
1467       FOR_PROVIDES(p2, pp2, s->name)
1468         {
1469           Solvable *ps = pool->solvables + p2;
1470           if (ps->repo != installed)
1471             continue;
1472           if (!pool->implicitobsoleteusesprovides && ps->name != s->name)
1473             continue;
1474           if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1475             continue;
1476           queue_push(q, p2);
1477           lastp2 = p2;
1478         }
1479     }
1480   if (!s->obsoletes)
1481     return;
1482   obsp = s->repo->idarraydata + s->obsoletes;
1483   while ((obs = *obsp++) != 0)
1484     FOR_PROVIDES(p2, pp2, obs)
1485       {
1486         Solvable *ps = pool->solvables + p2;
1487         if (ps->repo != installed)
1488           continue;
1489         if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1490           continue;
1491         if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1492           continue;
1493         if (p2 == lastp2)
1494           continue;
1495         queue_push(q, p2);
1496         lastp2 = p2;
1497       }
1498 }
1499
1500 /*
1501  * Call add_obsoletes and intersect the result with the
1502  * elements in Queue q starting at qstart.
1503  * Assumes that it's the first call if qstart == q->count.
1504  * May use auxillary map m for the intersection process, all
1505  * elements of q starting at qstart must have their bit cleared.
1506  * (This is also true after the function returns.)
1507  */
1508 static void
1509 intersect_obsoletes(Solver *solv, Id p, Queue *q, int qstart, Map *m)
1510 {
1511   int i, j;
1512   int qcount = q->count;
1513
1514   add_obsoletes(solv, p, q);
1515   if (qcount == qstart)
1516     return;     /* first call */
1517   if (qcount == q->count)
1518     j = qstart;
1519   else if (qcount == qstart + 1)
1520     {
1521       /* easy if there's just one element */
1522       j = qstart;
1523       for (i = qcount; i < q->count; i++)
1524         if (q->elements[i] == q->elements[qstart])
1525           {
1526             j++;        /* keep the element */
1527             break;
1528           }
1529     }
1530   else if (!m->size && q->count - qstart <= 8)
1531     {
1532       /* faster than a map most of the time */
1533       int k;
1534       for (i = j = qstart; i < qcount; i++)
1535         {
1536           Id ip = q->elements[i];
1537           for (k = qcount; k < q->count; k++)
1538             if (q->elements[k] == ip)
1539               {
1540                 q->elements[j++] = ip;
1541                 break;
1542               }
1543         }
1544     }
1545   else
1546     {
1547       /* for the really pathologic cases we use the map */
1548       Repo *installed = solv->installed;
1549       if (!m->size)
1550         map_init(m, installed->end - installed->start);
1551       for (i = qcount; i < q->count; i++)
1552         MAPSET(m, q->elements[i] - installed->start);
1553       for (i = j = qstart; i < qcount; i++)
1554         if (MAPTST(m, q->elements[i] - installed->start))
1555           {
1556             MAPCLR(m, q->elements[i] - installed->start);
1557             q->elements[j++] = q->elements[i];
1558           }
1559     }
1560   queue_truncate(q, j);
1561 }
1562
1563 static void
1564 jobtodisablelist(Solver *solv, Id how, Id what, Queue *q)
1565 {
1566   Pool *pool = solv->pool;
1567   Id select, p, pp;
1568   Repo *installed;
1569   Solvable *s;
1570   int i, j, set, qstart;
1571   Map omap;
1572
1573   installed = solv->installed;
1574   select = how & SOLVER_SELECTMASK;
1575   switch (how & SOLVER_JOBMASK)
1576     {
1577     case SOLVER_INSTALL:
1578       set = how & SOLVER_SETMASK;
1579       if (!(set & SOLVER_NOAUTOSET))
1580         {
1581           /* automatically add set bits by analysing the job */
1582           if (select == SOLVER_SOLVABLE_NAME)
1583             set |= SOLVER_SETNAME;
1584           if (select == SOLVER_SOLVABLE)
1585             set |= SOLVER_SETNAME | SOLVER_SETARCH | SOLVER_SETVENDOR | SOLVER_SETREPO | SOLVER_SETEVR;
1586           else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
1587             {
1588               Reldep *rd = GETRELDEP(pool, what);
1589               if (rd->flags == REL_EQ && select == SOLVER_SOLVABLE_NAME)
1590                 {
1591                   if (pool->disttype != DISTTYPE_DEB)
1592                     {
1593                       const char *evr = pool_id2str(pool, rd->evr);
1594                       if (strchr(evr, '-'))
1595                         set |= SOLVER_SETEVR;
1596                       else
1597                         set |= SOLVER_SETEV;
1598                     }
1599                   else
1600                     set |= SOLVER_SETEVR;
1601                 }
1602               if (rd->flags <= 7 && ISRELDEP(rd->name))
1603                 rd = GETRELDEP(pool, rd->name);
1604               if (rd->flags == REL_ARCH)
1605                 set |= SOLVER_SETARCH;
1606             }
1607         }
1608       else
1609         set &= ~SOLVER_NOAUTOSET;
1610       if (!set)
1611         return;
1612       if ((set & SOLVER_SETARCH) != 0 && solv->infarchrules != solv->infarchrules_end)
1613         {
1614           if (select == SOLVER_SOLVABLE)
1615             queue_push2(q, DISABLE_INFARCH, pool->solvables[what].name);
1616           else
1617             {
1618               int qcnt = q->count;
1619               /* does not work for SOLVER_SOLVABLE_ALL and SOLVER_SOLVABLE_REPO, but
1620                  they are not useful for SOLVER_INSTALL jobs anyway */
1621               FOR_JOB_SELECT(p, pp, select, what)
1622                 {
1623                   s = pool->solvables + p;
1624                   /* unify names */
1625                   for (i = qcnt; i < q->count; i += 2)
1626                     if (q->elements[i + 1] == s->name)
1627                       break;
1628                   if (i < q->count)
1629                     continue;
1630                   queue_push2(q, DISABLE_INFARCH, s->name);
1631                 }
1632             }
1633         }
1634       if ((set & SOLVER_SETREPO) != 0 && solv->duprules != solv->duprules_end)
1635         {
1636           if (select == SOLVER_SOLVABLE)
1637             queue_push2(q, DISABLE_DUP, pool->solvables[what].name);
1638           else
1639             {
1640               int qcnt = q->count;
1641               FOR_JOB_SELECT(p, pp, select, what)
1642                 {
1643                   s = pool->solvables + p;
1644                   /* unify names */
1645                   for (i = qcnt; i < q->count; i += 2)
1646                     if (q->elements[i + 1] == s->name)
1647                       break;
1648                   if (i < q->count)
1649                     continue;
1650                   queue_push2(q, DISABLE_DUP, s->name);
1651                 }
1652             }
1653         }
1654       if (!installed || installed->end == installed->start)
1655         return;
1656       /* now the hard part: disable some update rules */
1657
1658       /* first check if we have noobs or installed packages in the job */
1659       i = j = 0;
1660       FOR_JOB_SELECT(p, pp, select, what)
1661         {
1662           if (pool->solvables[p].repo == installed)
1663             j = p;
1664           else if (solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p) && !solv->keepexplicitobsoletes)
1665             return;
1666           i++;
1667         }
1668       if (j)    /* have installed packages */
1669         {
1670           /* this is for dupmap_all jobs, it can go away if we create
1671            * duprules for them */
1672           if (i == 1 && (set & SOLVER_SETREPO) != 0)
1673             queue_push2(q, DISABLE_UPDATE, j);
1674           return;
1675         }
1676
1677       omap.size = 0;
1678       qstart = q->count;
1679       FOR_JOB_SELECT(p, pp, select, what)
1680         {
1681           intersect_obsoletes(solv, p, q, qstart, &omap);
1682           if (q->count == qstart)
1683             break;
1684         }
1685       if (omap.size)
1686         map_free(&omap);
1687
1688       if (qstart == q->count)
1689         return;         /* nothing to prune */
1690
1691       /* convert result to (DISABLE_UPDATE, p) pairs */
1692       i = q->count;
1693       for (j = qstart; j < i; j++)
1694         queue_push(q, q->elements[j]);
1695       for (j = qstart; j < q->count; j += 2)
1696         {
1697           q->elements[j] = DISABLE_UPDATE;
1698           q->elements[j + 1] = q->elements[i++];
1699         }
1700
1701       /* now that we know which installed packages are obsoleted check each of them */
1702       if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
1703         return;         /* all is set, nothing to do */
1704
1705       for (i = j = qstart; i < q->count; i += 2)
1706         {
1707           Solvable *is = pool->solvables + q->elements[i + 1];
1708           FOR_JOB_SELECT(p, pp, select, what)
1709             {
1710               int illegal = 0;
1711               s = pool->solvables + p;
1712               if ((set & SOLVER_SETEVR) != 0)
1713                 illegal |= POLICY_ILLEGAL_DOWNGRADE;    /* ignore */
1714               if ((set & SOLVER_SETNAME) != 0)
1715                 illegal |= POLICY_ILLEGAL_NAMECHANGE;   /* ignore */
1716               if ((set & SOLVER_SETARCH) != 0)
1717                 illegal |= POLICY_ILLEGAL_ARCHCHANGE;   /* ignore */
1718               if ((set & SOLVER_SETVENDOR) != 0)
1719                 illegal |= POLICY_ILLEGAL_VENDORCHANGE; /* ignore */
1720               illegal = policy_is_illegal(solv, is, s, illegal);
1721               if (illegal && illegal == POLICY_ILLEGAL_DOWNGRADE && (set & SOLVER_SETEV) != 0)
1722                 {
1723                   /* it's ok if the EV is different */
1724                   if (pool_evrcmp(pool, is->evr, s->evr, EVRCMP_COMPARE_EVONLY) != 0)
1725                     illegal = 0;
1726                 }
1727               if (illegal)
1728                 break;
1729             }
1730           if (!p)
1731             {
1732               /* no package conflicts with the update rule */
1733               /* thus keep the DISABLE_UPDATE */
1734               q->elements[j + 1] = q->elements[i + 1];
1735               j += 2;
1736             }
1737         }
1738       queue_truncate(q, j);
1739       return;
1740
1741     case SOLVER_ERASE:
1742       if (!installed)
1743         break;
1744       if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
1745         FOR_REPO_SOLVABLES(installed, p, s)
1746           queue_push2(q, DISABLE_UPDATE, p);
1747       FOR_JOB_SELECT(p, pp, select, what)
1748         if (pool->solvables[p].repo == installed)
1749           queue_push2(q, DISABLE_UPDATE, p);
1750       return;
1751     default:
1752       return;
1753     }
1754 }
1755
1756 /* disable all policy rules that are in conflict with our job list */
1757 void
1758 solver_disablepolicyrules(Solver *solv)
1759 {
1760   Queue *job = &solv->job;
1761   int i, j;
1762   Queue allq;
1763   Rule *r;
1764   Id lastjob = -1;
1765   Id allqbuf[128];
1766
1767   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1768
1769   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1770     {
1771       r = solv->rules + i;
1772       if (r->d < 0)     /* disabled? */
1773         continue;
1774       j = solv->ruletojob.elements[i - solv->jobrules];
1775       if (j == lastjob)
1776         continue;
1777       lastjob = j;
1778       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1779     }
1780   if (solv->cleandepsmap.size)
1781     {
1782       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1783       for (i = solv->installed->start; i < solv->installed->end; i++)
1784         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1785           queue_push2(&allq, DISABLE_UPDATE, i);
1786     }
1787   MAPZERO(&solv->noupdate);
1788   for (i = 0; i < allq.count; i += 2)
1789     {
1790       Id type = allq.elements[i], arg = allq.elements[i + 1];
1791       switch(type)
1792         {
1793         case DISABLE_UPDATE:
1794           disableupdaterule(solv, arg);
1795           break;
1796         case DISABLE_INFARCH:
1797           disableinfarchrule(solv, arg);
1798           break;
1799         case DISABLE_DUP:
1800           disableduprule(solv, arg);
1801           break;
1802         default:
1803           break;
1804         }
1805     }
1806   queue_free(&allq);
1807 }
1808
1809 /* we just disabled job #jobidx, now reenable all policy rules that were
1810  * disabled because of this job */
1811 void
1812 solver_reenablepolicyrules(Solver *solv, int jobidx)
1813 {
1814   Queue *job = &solv->job;
1815   int i, j;
1816   Queue q, allq;
1817   Rule *r;
1818   Id lastjob = -1;
1819   Id qbuf[32], allqbuf[128];
1820
1821   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
1822   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1823   jobtodisablelist(solv, job->elements[jobidx - 1], job->elements[jobidx], &q);
1824   if (!q.count)
1825     return;
1826   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1827     {
1828       r = solv->rules + i;
1829       if (r->d < 0)     /* disabled? */
1830         continue;
1831       j = solv->ruletojob.elements[i - solv->jobrules];
1832       if (j == lastjob)
1833         continue;
1834       lastjob = j;
1835       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1836     }
1837   if (solv->cleandepsmap.size)
1838     {
1839       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1840       for (i = solv->installed->start; i < solv->installed->end; i++)
1841         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1842           queue_push2(&allq, DISABLE_UPDATE, i);
1843     }
1844   for (j = 0; j < q.count; j += 2)
1845     {
1846       Id type = q.elements[j], arg = q.elements[j + 1];
1847       for (i = 0; i < allq.count; i += 2)
1848         if (allq.elements[i] == type && allq.elements[i + 1] == arg)
1849           break;
1850       if (i < allq.count)
1851         continue;       /* still disabled */
1852       switch(type)
1853         {
1854         case DISABLE_UPDATE:
1855           reenableupdaterule(solv, arg);
1856           break;
1857         case DISABLE_INFARCH:
1858           reenableinfarchrule(solv, arg);
1859           break;
1860         case DISABLE_DUP:
1861           reenableduprule(solv, arg);
1862           break;
1863         }
1864     }
1865   queue_free(&allq);
1866   queue_free(&q);
1867 }
1868
1869 /* we just removed a package from the cleandeps map, now reenable all policy rules that were
1870  * disabled because of this */
1871 void
1872 solver_reenablepolicyrules_cleandeps(Solver *solv, Id pkg)
1873 {
1874   Queue *job = &solv->job;
1875   int i, j;
1876   Queue allq;
1877   Rule *r;
1878   Id lastjob = -1;
1879   Id allqbuf[128];
1880
1881   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1882   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1883     {
1884       r = solv->rules + i;
1885       if (r->d < 0)     /* disabled? */
1886         continue;
1887       j = solv->ruletojob.elements[i - solv->jobrules];
1888       if (j == lastjob)
1889         continue;
1890       lastjob = j;
1891       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1892     }
1893   for (i = 0; i < allq.count; i += 2)
1894     if (allq.elements[i] == DISABLE_UPDATE && allq.elements[i + 1] == pkg)
1895       break;
1896   if (i == allq.count)
1897     reenableupdaterule(solv, pkg);
1898   queue_free(&allq);
1899 }
1900
1901
1902 /***********************************************************************
1903  ***
1904  ***  Rule info part, tell the user what the rule is about.
1905  ***
1906  ***/
1907
1908 static void
1909 addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep)
1910 {
1911   Pool *pool = solv->pool;
1912   Rule *r;
1913   Id w2, op, od, ow2;
1914
1915   /* check if this creates the rule we're searching for */
1916   r = solv->rules + solv->ruleinfoq->elements[0];
1917   op = r->p;
1918   od = r->d < 0 ? -r->d - 1 : r->d;
1919   ow2 = 0;
1920
1921   /* normalize */
1922   w2 = d > 0 ? 0 : d;
1923   if (p < 0 && d > 0 && (!pool->whatprovidesdata[d] || !pool->whatprovidesdata[d + 1]))
1924     {
1925       w2 = pool->whatprovidesdata[d];
1926       d = 0;
1927
1928     }
1929   if (p > 0 && d < 0)           /* this hack is used for buddy deps */
1930     {
1931       w2 = p;
1932       p = d;
1933     }
1934
1935   if (d > 0)
1936     {
1937       if (p != op && !od)
1938         return;
1939       if (d != od)
1940         {
1941           Id *dp = pool->whatprovidesdata + d;
1942           Id *odp = pool->whatprovidesdata + od;
1943           while (*dp)
1944             if (*dp++ != *odp++)
1945               return;
1946           if (*odp)
1947             return;
1948         }
1949       w2 = 0;
1950       /* handle multiversion conflict rules */
1951       if (p < 0 && pool->whatprovidesdata[d] < 0)
1952         {
1953           w2 = pool->whatprovidesdata[d];
1954           /* XXX: free memory */
1955         }
1956     }
1957   else
1958     {
1959       if (od)
1960         return;
1961       ow2 = r->w2;
1962       if (p > w2)
1963         {
1964           if (w2 != op || p != ow2)
1965             return;
1966         }
1967       else
1968         {
1969           if (p != op || w2 != ow2)
1970             return;
1971         }
1972     }
1973   /* yep, rule matches. record info */
1974   queue_push(solv->ruleinfoq, type);
1975   if (type == SOLVER_RULE_RPM_SAME_NAME)
1976     {
1977       /* we normalize same name order */
1978       queue_push(solv->ruleinfoq, op < 0 ? -op : 0);
1979       queue_push(solv->ruleinfoq, ow2 < 0 ? -ow2 : 0);
1980     }
1981   else
1982     {
1983       queue_push(solv->ruleinfoq, p < 0 ? -p : 0);
1984       queue_push(solv->ruleinfoq, w2 < 0 ? -w2 : 0);
1985     }
1986   queue_push(solv->ruleinfoq, dep);
1987 }
1988
1989 static int
1990 solver_allruleinfos_cmp(const void *ap, const void *bp, void *dp)
1991 {
1992   const Id *a = ap, *b = bp;
1993   int r;
1994
1995   r = a[0] - b[0];
1996   if (r)
1997     return r;
1998   r = a[1] - b[1];
1999   if (r)
2000     return r;
2001   r = a[2] - b[2];
2002   if (r)
2003     return r;
2004   r = a[3] - b[3];
2005   if (r)
2006     return r;
2007   return 0;
2008 }
2009
2010 int
2011 solver_allruleinfos(Solver *solv, Id rid, Queue *rq)
2012 {
2013   Pool *pool = solv->pool;
2014   Rule *r = solv->rules + rid;
2015   int i, j;
2016
2017   queue_empty(rq);
2018   if (rid <= 0 || rid >= solv->rpmrules_end)
2019     {
2020       Id type, from, to, dep;
2021       type = solver_ruleinfo(solv, rid, &from, &to, &dep);
2022       queue_push(rq, type);
2023       queue_push(rq, from);
2024       queue_push(rq, to);
2025       queue_push(rq, dep);
2026       return 1;
2027     }
2028   if (r->p >= 0)
2029     return 0;
2030   queue_push(rq, rid);
2031   solv->ruleinfoq = rq;
2032   solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2033   /* also try reverse direction for conflicts */
2034   if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2035     solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2036   solv->ruleinfoq = 0;
2037   queue_shift(rq);
2038   /* now sort & unify em */
2039   if (!rq->count)
2040     return 0;
2041   solv_sort(rq->elements, rq->count / 4, 4 * sizeof(Id), solver_allruleinfos_cmp, 0);
2042   /* throw out identical entries */
2043   for (i = j = 0; i < rq->count; i += 4)
2044     {
2045       if (j)
2046         {
2047           if (rq->elements[i] == rq->elements[j - 4] &&
2048               rq->elements[i + 1] == rq->elements[j - 3] &&
2049               rq->elements[i + 2] == rq->elements[j - 2] &&
2050               rq->elements[i + 3] == rq->elements[j - 1])
2051             continue;
2052         }
2053       rq->elements[j++] = rq->elements[i];
2054       rq->elements[j++] = rq->elements[i + 1];
2055       rq->elements[j++] = rq->elements[i + 2];
2056       rq->elements[j++] = rq->elements[i + 3];
2057     }
2058   rq->count = j;
2059   return j / 4;
2060 }
2061
2062 SolverRuleinfo
2063 solver_ruleinfo(Solver *solv, Id rid, Id *fromp, Id *top, Id *depp)
2064 {
2065   Pool *pool = solv->pool;
2066   Rule *r = solv->rules + rid;
2067   SolverRuleinfo type = SOLVER_RULE_UNKNOWN;
2068
2069   if (fromp)
2070     *fromp = 0;
2071   if (top)
2072     *top = 0;
2073   if (depp)
2074     *depp = 0;
2075   if (rid > 0 && rid < solv->rpmrules_end)
2076     {
2077       Queue rq;
2078       int i;
2079
2080       if (r->p >= 0)
2081         return SOLVER_RULE_RPM;
2082       if (fromp)
2083         *fromp = -r->p;
2084       queue_init(&rq);
2085       queue_push(&rq, rid);
2086       solv->ruleinfoq = &rq;
2087       solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2088       /* also try reverse direction for conflicts */
2089       if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2090         solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2091       solv->ruleinfoq = 0;
2092       type = SOLVER_RULE_RPM;
2093       for (i = 1; i < rq.count; i += 4)
2094         {
2095           Id qt, qo, qp, qd;
2096           qt = rq.elements[i];
2097           qp = rq.elements[i + 1];
2098           qo = rq.elements[i + 2];
2099           qd = rq.elements[i + 3];
2100           if (type == SOLVER_RULE_RPM || type > qt)
2101             {
2102               type = qt;
2103               if (fromp)
2104                 *fromp = qp;
2105               if (top)
2106                 *top = qo;
2107               if (depp)
2108                 *depp = qd;
2109             }
2110         }
2111       queue_free(&rq);
2112       return type;
2113     }
2114   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2115     {
2116       Id jidx = solv->ruletojob.elements[rid - solv->jobrules];
2117       if (fromp)
2118         *fromp = jidx;
2119       if (top)
2120         *top = solv->job.elements[jidx];
2121       if (depp)
2122         *depp = solv->job.elements[jidx + 1];
2123       if ((r->d == 0 || r->d == -1) && r->w2 == 0 && r->p == -SYSTEMSOLVABLE)
2124         {
2125           if ((solv->job.elements[jidx] & SOLVER_SELECTMASK) == SOLVER_SOLVABLE_NAME)
2126             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2127           if ((solv->job.elements[jidx] & SOLVER_SELECTMASK) == SOLVER_SOLVABLE_PROVIDES)
2128             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2129         }
2130       return SOLVER_RULE_JOB;
2131     }
2132   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2133     {
2134       if (fromp)
2135         *fromp = solv->installed->start + (rid - solv->updaterules);
2136       return SOLVER_RULE_UPDATE;
2137     }
2138   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2139     {
2140       if (fromp)
2141         *fromp = solv->installed->start + (rid - solv->featurerules);
2142       return SOLVER_RULE_FEATURE;
2143     }
2144   if (rid >= solv->duprules && rid < solv->duprules_end)
2145     {
2146       if (fromp)
2147         *fromp = -r->p;
2148       if (depp)
2149         *depp = pool->solvables[-r->p].name;
2150       return SOLVER_RULE_DISTUPGRADE;
2151     }
2152   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2153     {
2154       if (fromp)
2155         *fromp = -r->p;
2156       if (depp)
2157         *depp = pool->solvables[-r->p].name;
2158       return SOLVER_RULE_INFARCH;
2159     }
2160   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2161     {
2162       return SOLVER_RULE_BEST;
2163     }
2164   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2165     {
2166       return SOLVER_RULE_CHOICE;
2167     }
2168   if (rid >= solv->learntrules)
2169     {
2170       return SOLVER_RULE_LEARNT;
2171     }
2172   return SOLVER_RULE_UNKNOWN;
2173 }
2174
2175 SolverRuleinfo
2176 solver_ruleclass(Solver *solv, Id rid)
2177 {
2178   if (rid <= 0)
2179     return SOLVER_RULE_UNKNOWN;
2180   if (rid > 0 && rid < solv->rpmrules_end)
2181     return SOLVER_RULE_RPM;
2182   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2183     return SOLVER_RULE_JOB;
2184   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2185     return SOLVER_RULE_UPDATE;
2186   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2187     return SOLVER_RULE_FEATURE;
2188   if (rid >= solv->duprules && rid < solv->duprules_end)
2189     return SOLVER_RULE_DISTUPGRADE;
2190   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2191     return SOLVER_RULE_INFARCH;
2192   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2193     return SOLVER_RULE_BEST;
2194   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2195     return SOLVER_RULE_CHOICE;
2196   if (rid >= solv->learntrules)
2197     return SOLVER_RULE_LEARNT;
2198   return SOLVER_RULE_UNKNOWN;
2199 }
2200
2201 void
2202 solver_ruleliterals(Solver *solv, Id rid, Queue *q)
2203 {
2204   Pool *pool = solv->pool;
2205   Id p, pp;
2206   Rule *r;
2207
2208   queue_empty(q);
2209   r = solv->rules + rid;
2210   FOR_RULELITERALS(p, pp, r)
2211     if (p != -SYSTEMSOLVABLE)
2212       queue_push(q, p);
2213   if (!q->count)
2214     queue_push(q, -SYSTEMSOLVABLE);     /* hmm, better to return an empty result? */
2215 }
2216
2217 int
2218 solver_rule2jobidx(Solver *solv, Id rid)
2219 {
2220   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2221     return 0;
2222   return solv->ruletojob.elements[rid - solv->jobrules] + 1;
2223 }
2224
2225 Id
2226 solver_rule2job(Solver *solv, Id rid, Id *whatp)
2227 {
2228   int idx;
2229   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2230     {
2231       if (whatp)
2232         *whatp = 0;
2233       return 0;
2234     }
2235   idx = solv->ruletojob.elements[rid - solv->jobrules];
2236   if (whatp)
2237     *whatp = solv->job.elements[idx + 1];
2238   return solv->job.elements[idx];
2239 }
2240
2241 void
2242 solver_addchoicerules(Solver *solv)
2243 {
2244   Pool *pool = solv->pool;
2245   Map m, mneg;
2246   Rule *r;
2247   Queue q, qi;
2248   int i, j, rid, havechoice;
2249   Id p, d, pp;
2250   Id p2, pp2;
2251   Solvable *s, *s2;
2252   Id lastaddedp, lastaddedd;
2253   int lastaddedcnt;
2254
2255   solv->choicerules = solv->nrules;
2256   if (!pool->installed)
2257     {
2258       solv->choicerules_end = solv->nrules;
2259       return;
2260     }
2261   solv->choicerules_ref = solv_calloc(solv->rpmrules_end, sizeof(Id));
2262   queue_init(&q);
2263   queue_init(&qi);
2264   map_init(&m, pool->nsolvables);
2265   map_init(&mneg, pool->nsolvables);
2266   /* set up negative assertion map from infarch and dup rules */
2267   for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
2268     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2269       MAPSET(&mneg, -r->p);
2270   for (rid = solv->duprules, r = solv->rules + rid; rid < solv->duprules_end; rid++, r++)
2271     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2272       MAPSET(&mneg, -r->p);
2273   lastaddedp = 0;
2274   lastaddedd = 0;
2275   lastaddedcnt = 0;
2276   for (rid = 1; rid < solv->rpmrules_end ; rid++)
2277     {
2278       r = solv->rules + rid;
2279       if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 < 0))
2280         continue;       /* only look at requires rules */
2281       /* solver_printrule(solv, SOLV_DEBUG_RESULT, r); */
2282       queue_empty(&q);
2283       queue_empty(&qi);
2284       havechoice = 0;
2285       FOR_RULELITERALS(p, pp, r)
2286         {
2287           if (p < 0)
2288             continue;
2289           s = pool->solvables + p;
2290           if (!s->repo)
2291             continue;
2292           if (s->repo == pool->installed)
2293             {
2294               queue_push(&q, p);
2295               continue;
2296             }
2297           /* check if this package is "blocked" by a installed package */
2298           s2 = 0;
2299           FOR_PROVIDES(p2, pp2, s->name)
2300             {
2301               s2 = pool->solvables + p2;
2302               if (s2->repo != pool->installed)
2303                 continue;
2304               if (!pool->implicitobsoleteusesprovides && s->name != s2->name)
2305                 continue;
2306               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2307                 continue;
2308               break;
2309             }
2310           if (p2)
2311             {
2312               /* found installed package p2 that we can update to p */
2313               if (MAPTST(&mneg, p))
2314                 continue;
2315               if (policy_is_illegal(solv, s2, s, 0))
2316                 continue;
2317               queue_push(&qi, p2);
2318               queue_push(&q, p);
2319               continue;
2320             }
2321           if (s->obsoletes)
2322             {
2323               Id obs, *obsp = s->repo->idarraydata + s->obsoletes;
2324               s2 = 0;
2325               while ((obs = *obsp++) != 0)
2326                 {
2327                   FOR_PROVIDES(p2, pp2, obs)
2328                     {
2329                       s2 = pool->solvables + p2;
2330                       if (s2->repo != pool->installed)
2331                         continue;
2332                       if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
2333                         continue;
2334                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2335                         continue;
2336                       break;
2337                     }
2338                   if (p2)
2339                     break;
2340                 }
2341               if (obs)
2342                 {
2343                   /* found installed package p2 that we can update to p */
2344                   if (MAPTST(&mneg, p))
2345                     continue;
2346                   if (policy_is_illegal(solv, s2, s, 0))
2347                     continue;
2348                   queue_push(&qi, p2);
2349                   queue_push(&q, p);
2350                   continue;
2351                 }
2352             }
2353           /* package p is independent of the installed ones */
2354           havechoice = 1;
2355         }
2356       if (!havechoice || !q.count)
2357         continue;       /* no choice */
2358
2359       /* now check the update rules of the installed package.
2360        * if all packages of the update rules are contained in
2361        * the dependency rules, there's no need to set up the choice rule */
2362       map_empty(&m);
2363       FOR_RULELITERALS(p, pp, r)
2364         if (p > 0)
2365           MAPSET(&m, p);
2366       for (i = 0; i < qi.count; i++)
2367         {
2368           Rule *ur;
2369           if (!qi.elements[i])
2370             continue;
2371           ur = solv->rules + solv->updaterules + (qi.elements[i] - pool->installed->start);
2372           if (!ur->p)
2373             ur = solv->rules + solv->featurerules + (qi.elements[i] - pool->installed->start);
2374           if (!ur->p)
2375             continue;
2376           FOR_RULELITERALS(p, pp, ur)
2377             if (!MAPTST(&m, p))
2378               break;
2379           if (p)
2380             break;
2381           for (j = i + 1; j < qi.count; j++)
2382             if (qi.elements[i] == qi.elements[j])
2383               qi.elements[j] = 0;
2384         }
2385       if (i == qi.count)
2386         {
2387 #if 0
2388           printf("skipping choice ");
2389           solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2390 #endif
2391           continue;
2392         }
2393
2394       /* don't add identical rules */
2395       if (lastaddedp == r->p && lastaddedcnt == q.count)
2396         {
2397           for (i = 0; i < q.count; i++)
2398             if (q.elements[i] != pool->whatprovidesdata[lastaddedd + i])
2399               break;
2400           if (i == q.count)
2401             continue;   /* already added that one */
2402         }
2403
2404       d = q.count ? pool_queuetowhatprovides(pool, &q) : 0;
2405       solver_addrule(solv, r->p, d);
2406       queue_push(&solv->weakruleq, solv->nrules - 1);
2407       solv->choicerules_ref[solv->nrules - 1 - solv->choicerules] = rid;
2408       lastaddedp = r->p;
2409       lastaddedd = d;
2410       lastaddedcnt = q.count;
2411 #if 0
2412       printf("OLD ");
2413       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2414       printf("WEAK CHOICE ");
2415       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + solv->nrules - 1);
2416 #endif
2417     }
2418   queue_free(&q);
2419   queue_free(&qi);
2420   map_free(&m);
2421   map_free(&mneg);
2422   solv->choicerules_end = solv->nrules;
2423 }
2424
2425 /* called when a choice rule is disabled by analyze_unsolvable. We also
2426  * have to disable all other choice rules so that the best packages get
2427  * picked */
2428 void
2429 solver_disablechoicerules(Solver *solv, Rule *r)
2430 {
2431   Id rid, p, pp;
2432   Pool *pool = solv->pool;
2433   Map m;
2434   Rule *or;
2435
2436   or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2437   map_init(&m, pool->nsolvables);
2438   FOR_RULELITERALS(p, pp, or)
2439     if (p > 0)
2440       MAPSET(&m, p);
2441   FOR_RULELITERALS(p, pp, r)
2442     if (p > 0)
2443       MAPCLR(&m, p);
2444   for (rid = solv->choicerules; rid < solv->choicerules_end; rid++)
2445     {
2446       r = solv->rules + rid;
2447       if (r->d < 0)
2448         continue;
2449       or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2450       FOR_RULELITERALS(p, pp, or)
2451         if (p > 0 && MAPTST(&m, p))
2452           break;
2453       if (p)
2454         solver_disablerule(solv, r);
2455     }
2456 }
2457
2458 static void
2459 prune_to_update_targets(Solver *solv, Id *cp, Queue *q)
2460 {
2461   int i, j;
2462   Id p, *cp2;
2463   for (i = j = 0; i < q->count; i++)
2464     {
2465       p = q->elements[i];
2466       for (cp2 = cp; *cp2; cp2++)
2467         if (*cp2 == p)
2468           {
2469             q->elements[j++] = p;
2470             break;
2471           }
2472     }
2473   queue_truncate(q, j);
2474 }
2475
2476 static void
2477 prune_to_dup_packages(Solver *solv, Id p, Queue *q)
2478 {
2479   int i, j;
2480   for (i = j = 0; i < q->count; i++)
2481     {
2482       Id p = q->elements[i];
2483       if (MAPTST(&solv->dupmap, p))
2484         q->elements[j++] = p;
2485     }
2486   queue_truncate(q, j);
2487 }
2488
2489 void
2490 solver_addbestrules(Solver *solv, int havebestinstalljobs)
2491 {
2492   Pool *pool = solv->pool;
2493   Id p;
2494   Solvable *s;
2495   Repo *installed = solv->installed;
2496   Queue q, q2;
2497   Rule *r;
2498   Queue r2pkg;
2499   int i, oldcnt;
2500
2501   solv->bestrules = solv->nrules;
2502   if (!installed)
2503     {
2504       solv->bestrules_end = solv->nrules;
2505       return;
2506     }
2507   queue_init(&q);
2508   queue_init(&q2);
2509   queue_init(&r2pkg);
2510
2511   if (havebestinstalljobs)
2512     {
2513       for (i = 0; i < solv->job.count; i += 2)
2514         {
2515           if ((solv->job.elements[i] & (SOLVER_JOBMASK | SOLVER_FORCEBEST)) == (SOLVER_INSTALL | SOLVER_FORCEBEST))
2516             {
2517               int j;
2518               Id p2, pp2;
2519               for (j = 0; j < solv->ruletojob.count; j++)
2520                 if (solv->ruletojob.elements[j] == i)
2521                   break;
2522               if (j == solv->ruletojob.count)
2523                 continue;
2524               r = solv->rules + solv->jobrules + j;
2525               queue_empty(&q);
2526               FOR_RULELITERALS(p2, pp2, r)
2527                 if (p2 > 0)
2528                   queue_push(&q, p2);
2529               if (!q.count)
2530                 continue;       /* orphaned */
2531               /* select best packages, just look at prio and version */
2532               oldcnt = q.count;
2533               policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2534               if (q.count == oldcnt)
2535                 continue;       /* nothing filtered */
2536               p2 = queue_shift(&q);
2537               solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2538               queue_push(&r2pkg, -(solv->jobrules + j));
2539             }
2540         }
2541     }
2542
2543   if (solv->bestupdatemap_all || solv->bestupdatemap.size)
2544     {
2545       FOR_REPO_SOLVABLES(installed, p, s)
2546         {
2547           Id d, p2, pp2;
2548           if (!solv->updatemap_all && (!solv->updatemap.size || !MAPTST(&solv->updatemap, p - installed->start)))
2549             continue;
2550           if (!solv->bestupdatemap_all && (!solv->bestupdatemap.size || !MAPTST(&solv->bestupdatemap, p - installed->start)))
2551             continue;
2552           queue_empty(&q);
2553           if (solv->bestobeypolicy)
2554             r = solv->rules + solv->updaterules + (p - installed->start);
2555           else
2556             {
2557               r = solv->rules + solv->featurerules + (p - installed->start);
2558               if (!r->p)        /* identical to update rule? */
2559                 r = solv->rules + solv->updaterules + (p - installed->start);
2560             }
2561           if (solv->multiversionupdaters && (d = solv->multiversionupdaters[p - installed->start]) != 0 && r == solv->rules + solv->updaterules + (p - installed->start))
2562             {
2563               /* need to check multiversionupdaters */
2564               if (r->p == p)    /* be careful with the dup case */
2565                 queue_push(&q, p);
2566               while ((p2 = pool->whatprovidesdata[d++]) != 0)
2567                 queue_push(&q, p2);
2568             }
2569           else
2570             {
2571               FOR_RULELITERALS(p2, pp2, r)
2572                 if (p2 > 0)
2573                   queue_push(&q, p2);
2574             }
2575           if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2576             prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q);
2577           if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2578             prune_to_dup_packages(solv, p, &q);
2579           /* select best packages, just look at prio and version */
2580           policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2581           if (!q.count)
2582             continue;   /* orphaned */
2583           if (solv->bestobeypolicy)
2584             {
2585               /* also filter the best of the feature rule packages and add them */
2586               r = solv->rules + solv->featurerules + (p - installed->start);
2587               if (r->p)
2588                 {
2589                   int j;
2590                   queue_empty(&q2);
2591                   FOR_RULELITERALS(p2, pp2, r)
2592                     if (p2 > 0)
2593                       queue_push(&q2, p2);
2594                   if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2595                     prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q2);
2596                   if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2597                     prune_to_dup_packages(solv, p, &q);
2598                   policy_filter_unwanted(solv, &q2, POLICY_MODE_RECOMMEND);
2599                   for (j = 0; j < q2.count; j++)
2600                     queue_pushunique(&q, q2.elements[j]);
2601                 }
2602             }
2603           p2 = queue_shift(&q);
2604           solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2605           queue_push(&r2pkg, p);
2606         }
2607     }
2608   if (r2pkg.count)
2609     {
2610       solv->bestrules_pkg = solv_calloc(r2pkg.count, sizeof(Id));
2611       memcpy(solv->bestrules_pkg, r2pkg.elements, r2pkg.count * sizeof(Id));
2612     }
2613   solv->bestrules_end = solv->nrules;
2614   queue_free(&q);
2615   queue_free(&q2);
2616   queue_free(&r2pkg);
2617 }
2618
2619 #undef CLEANDEPSDEBUG
2620
2621 /*
2622  * This functions collects all packages that are looked at
2623  * when a dependency is checked. We need it to "pin" installed
2624  * packages when removing a supplemented package in createcleandepsmap.
2625  * Here's an not uncommon example:
2626  *   A contains "Supplements: packageand(B, C)"
2627  *   B contains "Requires: A"
2628  * Now if we remove C, the supplements is no longer true,
2629  * thus we also remove A. Without the dep_pkgcheck function, we
2630  * would now also remove B, but this is wrong, as adding back
2631  * C doesn't make the supplements true again. Thus we "pin" B
2632  * when we remove A.
2633  * There's probably a better way to do this, but I haven't come
2634  * up with it yet ;)
2635  */
2636 static inline void
2637 dep_pkgcheck(Solver *solv, Id dep, Map *m, Queue *q)
2638 {
2639   Pool *pool = solv->pool;
2640   Id p, pp;
2641
2642   if (ISRELDEP(dep))
2643     {
2644       Reldep *rd = GETRELDEP(pool, dep);
2645       if (rd->flags >= 8)
2646         {
2647           if (rd->flags == REL_AND)
2648             {
2649               dep_pkgcheck(solv, rd->name, m, q);
2650               dep_pkgcheck(solv, rd->evr, m, q);
2651               return;
2652             }
2653           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
2654             return;
2655           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
2656             return;
2657         }
2658     }
2659   FOR_PROVIDES(p, pp, dep)
2660     if (!m || MAPTST(m, p))
2661       queue_push(q, p);
2662 }
2663
2664 /*
2665  * Find all installed packages that are no longer
2666  * needed regarding the current solver job.
2667  *
2668  * The algorithm is:
2669  * - remove pass: remove all packages that could have
2670  *   been dragged in by the obsoleted packages.
2671  *   i.e. if package A is obsolete and contains "Requires: B",
2672  *   also remove B, as installing A will have pulled in B.
2673  *   after this pass, we have a set of still installed packages
2674  *   with broken dependencies.
2675  * - add back pass:
2676  *   now add back all packages that the still installed packages
2677  *   require.
2678  *
2679  * The cleandeps packages are the packages removed in the first
2680  * pass and not added back in the second pass.
2681  *
2682  * If we search for unneeded packages (unneeded is true), we
2683  * simply remove all packages except the userinstalled ones in
2684  * the first pass.
2685  */
2686 static void
2687 solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded)
2688 {
2689   Pool *pool = solv->pool;
2690   Repo *installed = solv->installed;
2691   Queue *job = &solv->job;
2692   Map userinstalled;
2693   Map im;
2694   Map installedm;
2695   Rule *r;
2696   Id rid, how, what, select;
2697   Id p, pp, ip, jp;
2698   Id req, *reqp, sup, *supp;
2699   Solvable *s;
2700   Queue iq;
2701   int i;
2702
2703   map_empty(cleandepsmap);
2704   if (!installed || installed->end == installed->start)
2705     return;
2706   map_init(&userinstalled, installed->end - installed->start);
2707   map_init(&im, pool->nsolvables);
2708   map_init(&installedm, pool->nsolvables);
2709   queue_init(&iq);
2710
2711   for (i = 0; i < job->count; i += 2)
2712     {
2713       how = job->elements[i];
2714       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
2715         {
2716           what = job->elements[i + 1];
2717           select = how & SOLVER_SELECTMASK;
2718           if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
2719             FOR_REPO_SOLVABLES(installed, p, s)
2720               MAPSET(&userinstalled, p - installed->start);
2721           FOR_JOB_SELECT(p, pp, select, what)
2722             if (pool->solvables[p].repo == installed)
2723               MAPSET(&userinstalled, p - installed->start);
2724         }
2725     }
2726
2727   /* also add visible patterns to userinstalled for openSUSE */
2728   if (1)
2729     {
2730       Dataiterator di;
2731       dataiterator_init(&di, pool, 0, 0, SOLVABLE_ISVISIBLE, 0, 0);
2732       while (dataiterator_step(&di))
2733         {
2734           Id *dp;
2735           if (di.solvid <= 0)
2736             continue;
2737           s = pool->solvables + di.solvid;
2738           if (!s->repo || !s->requires)
2739             continue;
2740           if (s->repo != installed && !pool_installable(pool, s))
2741             continue;
2742           if (strncmp(pool_id2str(pool, s->name), "pattern:", 8) != 0)
2743             continue;
2744           dp = s->repo->idarraydata + s->requires;
2745           for (dp = s->repo->idarraydata + s->requires; *dp; dp++)
2746             FOR_PROVIDES(p, pp, *dp)
2747               if (pool->solvables[p].repo == installed)
2748                 {
2749                   if (strncmp(pool_id2str(pool, pool->solvables[p].name), "pattern", 7) != 0)
2750                     continue;
2751                   MAPSET(&userinstalled, p - installed->start);
2752                 }
2753         }
2754       dataiterator_free(&di);
2755     }
2756   if (1)
2757     {
2758       /* all products and their buddies are userinstalled */
2759       for (p = installed->start; p < installed->end; p++)
2760         {
2761           Solvable *s = pool->solvables + p;
2762           if (s->repo != installed)
2763             continue;
2764           if (!strncmp("product:", pool_id2str(pool, s->name), 8))
2765             {
2766               MAPSET(&userinstalled, p - installed->start);
2767               if (pool->nscallback)
2768                 {
2769                   Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, p);
2770                   if (buddy >= installed->start && buddy < installed->end && pool->solvables[buddy].repo == installed)
2771                     MAPSET(&userinstalled, buddy - installed->start);
2772                 }
2773             }
2774         }
2775     }
2776
2777   /* add all positive elements (e.g. locks) to "userinstalled" */
2778   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2779     {
2780       r = solv->rules + rid;
2781       if (r->d < 0)
2782         continue;
2783       i = solv->ruletojob.elements[rid - solv->jobrules];
2784       if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2785         continue;
2786       FOR_RULELITERALS(p, jp, r)
2787         if (p > 0 && pool->solvables[p].repo == installed)
2788           MAPSET(&userinstalled, p - installed->start);
2789     }
2790
2791   /* add all cleandeps candidates to iq */
2792   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2793     {
2794       r = solv->rules + rid;
2795       if (r->d < 0)
2796         continue;
2797       if (r->d == 0 && r->p < 0 && r->w2 == 0)
2798         {
2799           p = -r->p;
2800           if (pool->solvables[p].repo != installed)
2801             continue;
2802           MAPCLR(&userinstalled, p - installed->start);
2803           if (unneeded)
2804             continue;
2805           i = solv->ruletojob.elements[rid - solv->jobrules];
2806           how = job->elements[i];
2807           if ((how & (SOLVER_JOBMASK|SOLVER_CLEANDEPS)) == (SOLVER_ERASE|SOLVER_CLEANDEPS))
2808             queue_push(&iq, p);
2809         }
2810       else if (r->p > 0)
2811         {
2812           if (unneeded)
2813             continue;
2814           i = solv->ruletojob.elements[rid - solv->jobrules];
2815           if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2816             {
2817               /* check if the literals all obsolete some installed package */
2818               Map om;
2819               int iqstart;
2820
2821               /* just one installed literal */
2822               if (r->d == 0 && r->w2 == 0 && pool->solvables[r->p].repo == installed)
2823                 continue;
2824               /* noobs is bad */
2825               if (solv->noobsoletes.size && !solv->keepexplicitobsoletes)
2826                 {
2827                   FOR_RULELITERALS(p, jp, r)
2828                     if (MAPTST(&solv->noobsoletes, p))
2829                       break;
2830                   if (p)
2831                     continue;
2832                 }
2833
2834               om.size = 0;
2835               iqstart = iq.count;
2836               FOR_RULELITERALS(p, jp, r)
2837                 {
2838                   if (p < 0)
2839                     {
2840                       queue_truncate(&iq, iqstart);     /* abort */
2841                       break;
2842                     }
2843                   if (pool->solvables[p].repo == installed)
2844                     {
2845                       if (iq.count == iqstart)
2846                         queue_push(&iq, p);
2847                       else
2848                         {
2849                           for (i = iqstart; i < iq.count; i++)
2850                             if (iq.elements[i] == p)
2851                               break;
2852                           queue_truncate(&iq, iqstart);
2853                           if (i < iq.count)
2854                             queue_push(&iq, p);
2855                         }
2856                     }
2857                   else
2858                     intersect_obsoletes(solv, p, &iq, iqstart, &om);
2859                   if (iq.count == iqstart)
2860                     break;
2861                 }
2862               if (om.size)
2863                 map_free(&om);
2864             }
2865         }
2866     }
2867
2868   if (!unneeded)
2869     {
2870       if (solv->cleandeps_updatepkgs)
2871         for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
2872           queue_push(&iq, solv->cleandeps_updatepkgs->elements[i]);
2873     }
2874
2875   if (unneeded)
2876     queue_empty(&iq);   /* just in case... */
2877
2878   /* clear userinstalled bit for the packages we really want to delete/update */
2879   for (i = 0; i < iq.count; i++)
2880     {
2881       p = iq.elements[i];
2882       if (pool->solvables[p].repo != installed)
2883         continue;
2884       MAPCLR(&userinstalled, p - installed->start);
2885     }
2886
2887   for (p = installed->start; p < installed->end; p++)
2888     {
2889       if (pool->solvables[p].repo != installed)
2890         continue;
2891       MAPSET(&installedm, p);
2892       if (unneeded && !MAPTST(&userinstalled, p - installed->start))
2893         continue;
2894       MAPSET(&im, p);
2895     }
2896
2897 #ifdef CLEANDEPSDEBUG
2898   printf("REMOVE PASS\n");
2899 #endif
2900
2901   for (;;)
2902     {
2903       if (!iq.count)
2904         {
2905           if (unneeded)
2906             break;
2907           /* supplements pass */
2908           for (ip = solv->installed->start; ip < solv->installed->end; ip++)
2909             {
2910               if (!MAPTST(&installedm, ip))
2911                 continue;
2912               s = pool->solvables + ip;
2913               if (!s->supplements)
2914                 continue;
2915               if (!MAPTST(&im, ip))
2916                 continue;
2917               if (MAPTST(&userinstalled, ip - installed->start))
2918                 continue;
2919               supp = s->repo->idarraydata + s->supplements;
2920               while ((sup = *supp++) != 0)
2921                 if (dep_possible(solv, sup, &im))
2922                   break;
2923               if (!sup)
2924                 {
2925                   supp = s->repo->idarraydata + s->supplements;
2926                   while ((sup = *supp++) != 0)
2927                     if (dep_possible(solv, sup, &installedm))
2928                       {
2929                         /* no longer supplemented, also erase */
2930                         int iqcount = iq.count;
2931                         /* pin packages, see comment above dep_pkgcheck */
2932                         dep_pkgcheck(solv, sup, &im, &iq);
2933                         for (i = iqcount; i < iq.count; i++)
2934                           {
2935                             Id pqp = iq.elements[i];
2936                             if (pool->solvables[pqp].repo == installed)
2937                               MAPSET(&userinstalled, pqp - installed->start);
2938                           }
2939                         queue_truncate(&iq, iqcount);
2940 #ifdef CLEANDEPSDEBUG
2941                         printf("%s supplemented\n", pool_solvid2str(pool, ip));
2942 #endif
2943                         queue_push(&iq, ip);
2944                       }
2945                 }
2946             }
2947           if (!iq.count)
2948             break;
2949         }
2950       ip = queue_shift(&iq);
2951       s = pool->solvables + ip;
2952       if (!MAPTST(&im, ip))
2953         continue;
2954       if (!MAPTST(&installedm, ip))
2955         continue;
2956       if (s->repo == installed && MAPTST(&userinstalled, ip - installed->start))
2957         continue;
2958       MAPCLR(&im, ip);
2959 #ifdef CLEANDEPSDEBUG
2960       printf("removing %s\n", pool_solvable2str(pool, s));
2961 #endif
2962       if (s->requires)
2963         {
2964           reqp = s->repo->idarraydata + s->requires;
2965           while ((req = *reqp++) != 0)
2966             {
2967               if (req == SOLVABLE_PREREQMARKER)
2968                 continue;
2969 #if 0
2970               /* count number of installed packages that match */
2971               count = 0;
2972               FOR_PROVIDES(p, pp, req)
2973                 if (MAPTST(&installedm, p))
2974                   count++;
2975               if (count > 1)
2976                 continue;
2977 #endif
2978               FOR_PROVIDES(p, pp, req)
2979                 {
2980                   if (MAPTST(&im, p))
2981                     {
2982 #ifdef CLEANDEPSDEBUG
2983                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
2984 #endif
2985                       queue_push(&iq, p);
2986                     }
2987                 }
2988             }
2989         }
2990       if (s->recommends)
2991         {
2992           reqp = s->repo->idarraydata + s->recommends;
2993           while ((req = *reqp++) != 0)
2994             {
2995 #if 0
2996               count = 0;
2997               FOR_PROVIDES(p, pp, req)
2998                 if (MAPTST(&installedm, p))
2999                   count++;
3000               if (count > 1)
3001                 continue;
3002 #endif
3003               FOR_PROVIDES(p, pp, req)
3004                 {
3005                   if (MAPTST(&im, p))
3006                     {
3007 #ifdef CLEANDEPSDEBUG
3008                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3009 #endif
3010                       queue_push(&iq, p);
3011                     }
3012                 }
3013             }
3014         }
3015     }
3016
3017   /* turn userinstalled into remove set for pruning */
3018   map_empty(&userinstalled);
3019   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3020     {
3021       r = solv->rules + rid;
3022       if (r->p >= 0 || r->d != 0 || r->w2 != 0)
3023         continue;       /* disabled or not erase */
3024       p = -r->p;
3025       MAPCLR(&im, p);
3026       if (pool->solvables[p].repo == installed)
3027         MAPSET(&userinstalled, p - installed->start);
3028     }
3029   for (p = installed->start; p < installed->end; p++)
3030     if (MAPTST(&im, p))
3031       queue_push(&iq, p);
3032   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3033     {
3034       r = solv->rules + rid;
3035       if (r->d < 0)
3036         continue;
3037       FOR_RULELITERALS(p, jp, r)
3038         if (p > 0)
3039           queue_push(&iq, p);
3040     }
3041   /* also put directly addressed packages on the install queue
3042    * so we can mark patterns as installed */
3043   for (i = 0; i < job->count; i += 2)
3044     {
3045       how = job->elements[i];
3046       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
3047         {
3048           what = job->elements[i + 1];
3049           select = how & SOLVER_SELECTMASK;
3050           if (select == SOLVER_SOLVABLE && pool->solvables[what].repo != installed)
3051             queue_push(&iq, what);
3052         }
3053     }
3054
3055 #ifdef CLEANDEPSDEBUG
3056   printf("ADDBACK PASS\n");
3057 #endif
3058   for (;;)
3059     {
3060       if (!iq.count)
3061         {
3062           /* supplements pass */
3063           for (ip = installed->start; ip < installed->end; ip++)
3064             {
3065               if (!MAPTST(&installedm, ip))
3066                 continue;
3067               if (MAPTST(&userinstalled, ip - installed->start))
3068                 continue;
3069               s = pool->solvables + ip;
3070               if (!s->supplements)
3071                 continue;
3072               if (MAPTST(&im, ip))
3073                 continue;
3074               supp = s->repo->idarraydata + s->supplements;
3075               while ((sup = *supp++) != 0)
3076                 if (dep_possible(solv, sup, &im))
3077                   break;
3078               if (sup)
3079                 {
3080 #ifdef CLEANDEPSDEBUG
3081                   printf("%s supplemented\n", pool_solvid2str(pool, ip));
3082 #endif
3083                   MAPSET(&im, ip);
3084                   queue_push(&iq, ip);
3085                 }
3086             }
3087           if (!iq.count)
3088             break;
3089         }
3090       ip = queue_shift(&iq);
3091       s = pool->solvables + ip;
3092 #ifdef CLEANDEPSDEBUG
3093       printf("adding back %s\n", pool_solvable2str(pool, s));
3094 #endif
3095       if (s->requires)
3096         {
3097           reqp = s->repo->idarraydata + s->requires;
3098           while ((req = *reqp++) != 0)
3099             {
3100               FOR_PROVIDES(p, pp, req)
3101                 {
3102                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3103                     {
3104                       if (p == ip)
3105                         continue;
3106                       if (MAPTST(&userinstalled, p - installed->start))
3107                         continue;
3108 #ifdef CLEANDEPSDEBUG
3109                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3110 #endif
3111                       MAPSET(&im, p);
3112                       queue_push(&iq, p);
3113                     }
3114                 }
3115             }
3116         }
3117       if (s->recommends)
3118         {
3119           reqp = s->repo->idarraydata + s->recommends;
3120           while ((req = *reqp++) != 0)
3121             {
3122               FOR_PROVIDES(p, pp, req)
3123                 {
3124                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3125                     {
3126                       if (p == ip)
3127                         continue;
3128                       if (MAPTST(&userinstalled, p - installed->start))
3129                         continue;
3130 #ifdef CLEANDEPSDEBUG
3131                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3132 #endif
3133                       MAPSET(&im, p);
3134                       queue_push(&iq, p);
3135                     }
3136                 }
3137             }
3138         }
3139     }
3140
3141   queue_free(&iq);
3142   if (solv->cleandeps_updatepkgs)
3143     for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
3144       MAPSET(&im, solv->cleandeps_updatepkgs->elements[i]);
3145   if (solv->cleandeps_mistakes)
3146     for (i = 0; i < solv->cleandeps_mistakes->count; i++)
3147       MAPSET(&im, solv->cleandeps_mistakes->elements[i]);
3148   for (p = installed->start; p < installed->end; p++)
3149     {
3150       if (pool->solvables[p].repo != installed)
3151         continue;
3152       if (!MAPTST(&im, p))
3153         MAPSET(cleandepsmap, p - installed->start);
3154     }
3155   map_free(&im);
3156   map_free(&installedm);
3157   map_free(&userinstalled);
3158 }
3159
3160
3161 struct trj_data {
3162   Queue *edges;
3163   Id *low;
3164   Id idx;
3165   Id nstack;
3166   Id firstidx;
3167 };
3168
3169 /* Tarjan's SCC algorithm, slightly modifed */
3170 static void
3171 trj_visit(struct trj_data *trj, Id node)
3172 {
3173   Id *low = trj->low;
3174   Queue *edges = trj->edges;
3175   Id nnode, myidx, stackstart;
3176   int i;
3177
3178   low[node] = myidx = trj->idx++;
3179   low[(stackstart = trj->nstack++)] = node;
3180   for (i = edges->elements[node]; (nnode = edges->elements[i]) != 0; i++)
3181     {
3182       Id l = low[nnode];
3183       if (!l)
3184         {
3185           if (!edges->elements[edges->elements[nnode]])
3186             {
3187               trj->idx++;
3188               low[nnode] = -1;
3189               continue;
3190             }
3191           trj_visit(trj, nnode);
3192           l = low[nnode];
3193         }
3194       if (l < 0)
3195         continue;
3196       if (l < trj->firstidx)
3197         {
3198           int k;
3199           for (k = l; low[low[k]] == l; k++)
3200             low[low[k]] = -1;
3201         }
3202       else if (l < low[node])
3203         low[node] = l;
3204     }
3205   if (low[node] == myidx)
3206     {
3207       if (myidx != trj->firstidx)
3208         myidx = -1;
3209       for (i = stackstart; i < trj->nstack; i++)
3210         low[low[i]] = myidx;
3211       trj->nstack = stackstart;
3212     }
3213 }
3214
3215
3216 void
3217 solver_get_unneeded(Solver *solv, Queue *unneededq, int filtered)
3218 {
3219   Repo *installed = solv->installed;
3220   int i;
3221   Map cleandepsmap;
3222
3223   queue_empty(unneededq);
3224   if (!installed || installed->end == installed->start)
3225     return;
3226
3227   map_init(&cleandepsmap, installed->end - installed->start);
3228   solver_createcleandepsmap(solv, &cleandepsmap, 1);
3229   for (i = installed->start; i < installed->end; i++)
3230     if (MAPTST(&cleandepsmap, i - installed->start))
3231       queue_push(unneededq, i);
3232
3233   if (filtered && unneededq->count > 1)
3234     {
3235       Pool *pool = solv->pool;
3236       Queue edges;
3237       Id *nrequires;
3238       Map installedm;
3239       int j, pass, count = unneededq->count;
3240       Id *low;
3241
3242       map_init(&installedm, pool->nsolvables);
3243       for (i = installed->start; i < installed->end; i++)
3244         if (pool->solvables[i].repo == installed)
3245           MAPSET(&installedm, i);
3246
3247       nrequires = solv_calloc(count, sizeof(Id));
3248       queue_init(&edges);
3249       queue_prealloc(&edges, count * 4 + 10);   /* pre-size */
3250
3251       /*
3252        * Go through the solvables in the nodes queue and create edges for
3253        * all requires/recommends/supplements between the nodes.
3254        * The edges are stored in the edges queue, we add 1 to the node
3255        * index so that nodes in the edges queue are != 0 and we can
3256        * terminate the edge list with 0.
3257        * Thus for node element 5, the edges are stored starting at
3258        * edges.elements[6] and are 0-terminated.
3259        */
3260       /* leave first element zero to make things easier */
3261       /* also add trailing zero */
3262       queue_insertn(&edges, 0, 1 + count + 1);
3263
3264       /* first requires and recommends */
3265       for (i = 0; i < count; i++)
3266         {
3267           Solvable *s = pool->solvables + unneededq->elements[i];
3268           edges.elements[i + 1] = edges.count;
3269           for (pass = 0; pass < 2; pass++)
3270             {
3271               int num = 0;
3272               unsigned int off = pass == 0 ? s->requires : s->recommends;
3273               Id p, pp, *dp;
3274               if (off)
3275                 for (dp = s->repo->idarraydata + off; *dp; dp++)
3276                   FOR_PROVIDES(p, pp, *dp)
3277                     {
3278                       Solvable *sp = pool->solvables + p;
3279                       if (s == sp || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3280                         continue;
3281                       for (j = 0; j < count; j++)
3282                         if (p == unneededq->elements[j])
3283                           break;
3284                       if (j == count)
3285                         continue;
3286                       if (num && edges.elements[edges.count - 1] == j + 1)
3287                         continue;
3288                       queue_push(&edges, j + 1);
3289                       num++;
3290                     }
3291                 if (pass == 0)
3292                   nrequires[i] = num;
3293             }
3294           queue_push(&edges, 0);
3295         }
3296 #if 0
3297       printf("requires + recommends\n");
3298       for (i = 0; i < count; i++)
3299         {
3300           int j;
3301           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3302           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3303             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3304         }
3305 #endif
3306
3307       /* then add supplements */
3308       for (i = 0; i < count; i++)
3309         {
3310           Solvable *s = pool->solvables + unneededq->elements[i];
3311           if (s->supplements)
3312             {
3313               Id *dp;
3314               int k;
3315               for (dp = s->repo->idarraydata + s->supplements; *dp; dp++)
3316                 if (dep_possible(solv, *dp, &installedm))
3317                   {
3318                     Queue iq;
3319                     Id iqbuf[16];
3320                     queue_init_buffer(&iq, iqbuf, sizeof(iqbuf)/sizeof(*iqbuf));
3321                     dep_pkgcheck(solv, *dp, 0, &iq);
3322                     for (k = 0; k < iq.count; k++)
3323                       {
3324                         Id p = iq.elements[k];
3325                         Solvable *sp = pool->solvables + p;
3326                         if (p == unneededq->elements[i] || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3327                           continue;
3328                         for (j = 0; j < count; j++)
3329                           if (p == unneededq->elements[j])
3330                             break;
3331                         /* now add edge from j + 1 to i + 1 */
3332                         queue_insert(&edges, edges.elements[j + 1] + nrequires[j], i + 1);
3333                         /* addapt following edge pointers */
3334                         for (k = j + 2; k < count + 2; k++)
3335                           edges.elements[k]++;
3336                       }
3337                     queue_free(&iq);
3338                   }
3339             }
3340         }
3341 #if 0
3342       /* print result */
3343       printf("+ supplements\n");
3344       for (i = 0; i < count; i++)
3345         {
3346           int j;
3347           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3348           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3349             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3350     }
3351 #endif
3352       map_free(&installedm);
3353
3354       /* now run SCC algo two times, first with requires+recommends+supplements,
3355        * then again without the requires. We run it the second time to get rid
3356        * of packages that got dragged in via recommends/supplements */
3357       /*
3358        * low will contain the result of the SCC search.
3359        * it must be of at least size 2 * (count + 1) and
3360        * must be zero initialized.
3361        * The layout is:
3362        *    0  low low ... low stack stack ...stack 0
3363        *            count              count
3364        */
3365       low = solv_calloc(count + 1, 2 * sizeof(Id));
3366       for (pass = 0; pass < 2; pass++)
3367         {
3368           struct trj_data trj;
3369           if (pass)
3370             {
3371               memset(low, 0, (count + 1) * (2 * sizeof(Id)));
3372               for (i = 0; i < count; i++)
3373                 {
3374                   edges.elements[i + 1] += nrequires[i];
3375                   if (!unneededq->elements[i])
3376                     low[i + 1] = -1;    /* ignore this node */
3377                 }
3378             }
3379           trj.edges = &edges;
3380           trj.low = low;
3381           trj.idx = count + 1;  /* stack starts here */
3382           for (i = 1; i <= count; i++)
3383             {
3384               if (low[i])
3385                 continue;
3386               if (edges.elements[edges.elements[i]])
3387                 {
3388                   trj.firstidx = trj.nstack = trj.idx;
3389                   trj_visit(&trj, i);
3390                 }
3391               else
3392                 {
3393                   Id myidx = trj.idx++;
3394                   low[i] = myidx;
3395                   low[myidx] = i;
3396                 }
3397             }
3398           /* prune packages */
3399           for (i = 0; i < count; i++)
3400             if (low[i + 1] <= 0)
3401               unneededq->elements[i] = 0;
3402         }
3403       solv_free(low);
3404       solv_free(nrequires);
3405       queue_free(&edges);
3406
3407       /* finally remove all pruned entries from unneededq */
3408       for (i = j = 0; i < count; i++)
3409         if (unneededq->elements[i])
3410           unneededq->elements[j++] = unneededq->elements[i];
3411       queue_truncate(unneededq, j);
3412     }
3413   map_free(&cleandepsmap);
3414 }
3415
3416 /* EOF */