- change duprule generation to ignore uninstallable packages
[platform/upstream/libsolv.git] / src / rules.c
1 /*
2  * Copyright (c) 2007-2009, Novell Inc.
3  *
4  * This program is licensed under the BSD license, read LICENSE.BSD
5  * for further information
6  */
7
8 /*
9  * rules.c
10  *
11  * SAT based dependency solver
12  */
13
14 #include <stdio.h>
15 #include <stdlib.h>
16 #include <unistd.h>
17 #include <string.h>
18 #include <assert.h>
19
20 #include "solver.h"
21 #include "solver_private.h"
22 #include "bitmap.h"
23 #include "pool.h"
24 #include "poolarch.h"
25 #include "util.h"
26 #include "evr.h"
27 #include "policy.h"
28 #include "solverdebug.h"
29
30 #define RULES_BLOCK 63
31
32 static void addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep);
33 static void solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded);
34
35 /*-------------------------------------------------------------------
36  * Check if dependency is possible
37  * 
38  * mirrors solver_dep_fulfilled but uses map m instead of the decisionmap
39  * used in solver_addrpmrulesforweak and solver_createcleandepsmap
40  */
41
42 static inline int
43 dep_possible(Solver *solv, Id dep, Map *m)
44 {
45   Pool *pool = solv->pool;
46   Id p, pp;
47
48   if (ISRELDEP(dep))
49     {
50       Reldep *rd = GETRELDEP(pool, dep);
51       if (rd->flags >= 8)
52         {
53           if (rd->flags == REL_AND)
54             {
55               if (!dep_possible(solv, rd->name, m))
56                 return 0;
57               return dep_possible(solv, rd->evr, m);
58             }
59           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
60             return solver_splitprovides(solv, rd->evr);
61           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
62             return solver_dep_installed(solv, rd->evr);
63         }
64     }
65   FOR_PROVIDES(p, pp, dep)
66     {
67       if (MAPTST(m, p))
68         return 1;
69     }
70   return 0;
71 }
72
73 /********************************************************************
74  *
75  * Rule handling
76  *
77  * - unify rules, remove duplicates
78  */
79
80 /*-------------------------------------------------------------------
81  *
82  * compare rules for unification sort
83  *
84  */
85
86 static int
87 unifyrules_sortcmp(const void *ap, const void *bp, void *dp)
88 {
89   Pool *pool = dp;
90   Rule *a = (Rule *)ap;
91   Rule *b = (Rule *)bp;
92   Id *ad, *bd;
93   int x;
94
95   x = a->p - b->p;
96   if (x)
97     return x;                          /* p differs */
98
99   /* identical p */
100   if (a->d == 0 && b->d == 0)
101     return a->w2 - b->w2;              /* assertion: return w2 diff */
102
103   if (a->d == 0)                       /* a is assertion, b not */
104     {
105       x = a->w2 - pool->whatprovidesdata[b->d];
106       return x ? x : -1;
107     }
108
109   if (b->d == 0)                       /* b is assertion, a not */
110     {
111       x = pool->whatprovidesdata[a->d] - b->w2;
112       return x ? x : 1;
113     }
114
115   /* compare whatprovidesdata */
116   ad = pool->whatprovidesdata + a->d;
117   bd = pool->whatprovidesdata + b->d;
118   while (*bd)
119     if ((x = *ad++ - *bd++) != 0)
120       return x;
121   return *ad;
122 }
123
124 int
125 solver_samerule(Solver *solv, Rule *r1, Rule *r2)
126 {
127   return unifyrules_sortcmp(r1, r2, solv->pool);
128 }
129
130
131 /*-------------------------------------------------------------------
132  *
133  * unify rules
134  * go over all rules and remove duplicates
135  */
136
137 void
138 solver_unifyrules(Solver *solv)
139 {
140   Pool *pool = solv->pool;
141   int i, j;
142   Rule *ir, *jr;
143
144   if (solv->nrules <= 2)               /* nothing to unify */
145     return;
146
147   /* sort rules first */
148   solv_sort(solv->rules + 1, solv->nrules - 1, sizeof(Rule), unifyrules_sortcmp, solv->pool);
149
150   /* prune rules
151    * i = unpruned
152    * j = pruned
153    */
154   jr = 0;
155   for (i = j = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
156     {
157       if (jr && !unifyrules_sortcmp(ir, jr, pool))
158         continue;                      /* prune! */
159       jr = solv->rules + j++;          /* keep! */
160       if (ir != jr)
161         *jr = *ir;
162     }
163
164   /* reduced count from nrules to j rules */
165   POOL_DEBUG(SOLV_DEBUG_STATS, "pruned rules from %d to %d\n", solv->nrules, j);
166
167   /* adapt rule buffer */
168   solv->nrules = j;
169   solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
170
171   /*
172    * debug: log rule statistics
173    */
174   IF_POOLDEBUG (SOLV_DEBUG_STATS)
175     {
176       int binr = 0;
177       int lits = 0;
178       Id *dp;
179       Rule *r;
180
181       for (i = 1; i < solv->nrules; i++)
182         {
183           r = solv->rules + i;
184           if (r->d == 0)
185             binr++;
186           else
187             {
188               dp = solv->pool->whatprovidesdata + r->d;
189               while (*dp++)
190                 lits++;
191             }
192         }
193       POOL_DEBUG(SOLV_DEBUG_STATS, "  binary: %d\n", binr);
194       POOL_DEBUG(SOLV_DEBUG_STATS, "  normal: %d, %d literals\n", solv->nrules - 1 - binr, lits);
195     }
196 }
197
198 #if 0
199
200 /*
201  * hash rule
202  */
203
204 static Hashval
205 hashrule(Solver *solv, Id p, Id d, int n)
206 {
207   unsigned int x = (unsigned int)p;
208   int *dp;
209
210   if (n <= 1)
211     return (x * 37) ^ (unsigned int)d;
212   dp = solv->pool->whatprovidesdata + d;
213   while (*dp)
214     x = (x * 37) ^ (unsigned int)*dp++;
215   return x;
216 }
217 #endif
218
219
220 /*-------------------------------------------------------------------
221  * 
222  */
223
224 /*
225  * add rule
226  *  p = direct literal; always < 0 for installed rpm rules
227  *  d, if < 0 direct literal, if > 0 offset into whatprovides, if == 0 rule is assertion (look at p only)
228  *
229  *
230  * A requires b, b provided by B1,B2,B3 => (-A|B1|B2|B3)
231  *
232  * p < 0 : pkg id of A
233  * d > 0 : Offset in whatprovidesdata (list of providers of b)
234  *
235  * A conflicts b, b provided by B1,B2,B3 => (-A|-B1), (-A|-B2), (-A|-B3)
236  * p < 0 : pkg id of A
237  * d < 0 : Id of solvable (e.g. B1)
238  *
239  * d == 0: unary rule, assertion => (A) or (-A)
240  *
241  *   Install:    p > 0, d = 0   (A)             user requested install
242  *   Remove:     p < 0, d = 0   (-A)            user requested remove (also: uninstallable)
243  *   Requires:   p < 0, d > 0   (-A|B1|B2|...)  d: <list of providers for requirement of p>
244  *   Updates:    p > 0, d > 0   (A|B1|B2|...)   d: <list of updates for solvable p>
245  *   Conflicts:  p < 0, d < 0   (-A|-B)         either p (conflict issuer) or d (conflict provider) (binary rule)
246  *                                              also used for obsoletes
247  *   ?:          p > 0, d < 0   (A|-B)          
248  *   No-op ?:    p = 0, d = 0   (null)          (used as policy rule placeholder)
249  *
250  *   resulting watches:
251  *   ------------------
252  *   Direct assertion (no watch needed) --> d = 0, w1 = p, w2 = 0
253  *   Binary rule: p = first literal, d = 0, w2 = second literal, w1 = p
254  *   every other : w1 = p, w2 = whatprovidesdata[d];
255  *   Disabled rule: w1 = 0
256  *
257  *   always returns a rule for non-rpm rules
258  */
259
260 Rule *
261 solver_addrule(Solver *solv, Id p, Id d)
262 {
263   Pool *pool = solv->pool;
264   Rule *r = 0;
265   Id *dp = 0;
266
267   int n = 0;                           /* number of literals in rule - 1
268                                           0 = direct assertion (single literal)
269                                           1 = binary rule
270                                           >1 = 
271                                         */
272
273   /* it often happenes that requires lead to adding the same rpm rule
274    * multiple times, so we prune those duplicates right away to make
275    * the work for unifyrules a bit easier */
276
277   if (!solv->rpmrules_end)              /* we add rpm rules */
278     {
279       r = solv->rules + solv->nrules - 1;       /* get the last added rule */
280       if (r->p == p && r->d == d && (d != 0 || !r->w2))
281         return r;
282     }
283
284     /*
285      * compute number of literals (n) in rule
286      */
287     
288   if (d < 0)
289     {
290       /* always a binary rule */
291       if (p == d)
292         return 0;                      /* ignore self conflict */
293       n = 1;
294     }
295   else if (d > 0)
296     {
297       for (dp = pool->whatprovidesdata + d; *dp; dp++, n++)
298         if (*dp == -p)
299           return 0;                     /* rule is self-fulfilling */
300         
301       if (n == 1)                       /* convert to binary rule */
302         d = dp[-1];
303     }
304
305   if (n == 1 && p > d && !solv->rpmrules_end)
306     {
307       /* smallest literal first so we can find dups */
308       n = p; p = d; d = n;             /* p <-> d */
309       n = 1;                           /* re-set n, was used as temp var */
310     }
311
312   /*
313    * check for duplicate
314    */
315     
316   /* check if the last added rule (r) is exactly the same as what we're looking for. */
317   if (r && n == 1 && !r->d && r->p == p && r->w2 == d)
318     return r;  /* binary rule */
319
320     /* have n-ary rule with same first literal, check other literals */
321   if (r && n > 1 && r->d && r->p == p)
322     {
323       /* Rule where d is an offset in whatprovidesdata */
324       Id *dp2;
325       if (d == r->d)
326         return r;
327       dp2 = pool->whatprovidesdata + r->d;
328       for (dp = pool->whatprovidesdata + d; *dp; dp++, dp2++)
329         if (*dp != *dp2)
330           break;
331       if (*dp == *dp2)
332         return r;
333    }
334
335   /*
336    * allocate new rule
337    */
338
339   /* extend rule buffer */
340   solv->rules = solv_extend(solv->rules, solv->nrules, 1, sizeof(Rule), RULES_BLOCK);
341   r = solv->rules + solv->nrules++;    /* point to rule space */
342
343     /*
344      * r = new rule
345      */
346     
347   r->p = p;
348   if (n == 0)
349     {
350       /* direct assertion, no watch needed */
351       r->d = 0;
352       r->w1 = p;
353       r->w2 = 0;
354     }
355   else if (n == 1)
356     {
357       /* binary rule */
358       r->d = 0;
359       r->w1 = p;
360       r->w2 = d;
361     }
362   else
363     {
364       r->d = d;
365       r->w1 = p;
366       r->w2 = pool->whatprovidesdata[d];
367     }
368   r->n1 = 0;
369   r->n2 = 0;
370
371   IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
372     {
373       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "  Add rule: ");
374       solver_printrule(solv, SOLV_DEBUG_RULE_CREATION, r);
375     }
376
377   return r;
378 }
379
380
381 /******************************************************************************
382  ***
383  *** rpm rule part: create rules representing the package dependencies
384  ***
385  ***/
386
387 /*
388  *  special multiversion patch conflict handling:
389  *  a patch conflict is also satisfied if some other
390  *  version with the same name/arch that doesn't conflict
391  *  gets installed. The generated rule is thus:
392  *  -patch|-cpack|opack1|opack2|...
393  */
394 static Id
395 makemultiversionconflict(Solver *solv, Id n, Id con)
396 {
397   Pool *pool = solv->pool;
398   Solvable *s, *sn;
399   Queue q;
400   Id p, pp, qbuf[64];
401
402   sn = pool->solvables + n;
403   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
404   queue_push(&q, -n);
405   FOR_PROVIDES(p, pp, sn->name)
406     {
407       s = pool->solvables + p;
408       if (s->name != sn->name || s->arch != sn->arch)
409         continue;
410       if (!MAPTST(&solv->noobsoletes, p))
411         continue;
412       if (pool_match_nevr(pool, pool->solvables + p, con))
413         continue;
414       /* here we have a multiversion solvable that doesn't conflict */
415       /* thus we're not in conflict if it is installed */
416       queue_push(&q, p);
417     }
418   if (q.count == 1)
419     return -n;  /* no other package found, generate normal conflict */
420   return pool_queuetowhatprovides(pool, &q);
421 }
422
423 static inline void
424 addrpmrule(Solver *solv, Id p, Id d, int type, Id dep)
425 {
426   if (!solv->ruleinfoq)
427     solver_addrule(solv, p, d);
428   else
429     addrpmruleinfo(solv, p, d, type, dep);
430 }
431
432 /*-------------------------------------------------------------------
433  * 
434  * add (install) rules for solvable
435  * 
436  * s: Solvable for which to add rules
437  * m: m[s] = 1 for solvables which have rules, prevent rule duplication
438  * 
439  * Algorithm: 'visit all nodes of a graph'. The graph nodes are
440  *  solvables, the edges their dependencies.
441  *  Starting from an installed solvable, this will create all rules
442  *  representing the graph created by the solvables dependencies.
443  * 
444  * for unfulfilled requirements, conflicts, obsoletes,....
445  * add a negative assertion for solvables that are not installable
446  * 
447  * It will also create rules for all solvables referenced by 's'
448  *  i.e. descend to all providers of requirements of 's'
449  *
450  */
451
452 void
453 solver_addrpmrulesforsolvable(Solver *solv, Solvable *s, Map *m)
454 {
455   Pool *pool = solv->pool;
456   Repo *installed = solv->installed;
457
458   /* 'work' queue. keeps Ids of solvables we still have to work on.
459      And buffer for it. */
460   Queue workq;
461   Id workqbuf[64];
462     
463   int i;
464     /* if to add rules for broken deps ('rpm -V' functionality)
465      * 0 = yes, 1 = no
466      */
467   int dontfix;
468     /* Id var and pointer for each dependency
469      * (not used in parallel)
470      */
471   Id req, *reqp;
472   Id con, *conp;
473   Id obs, *obsp;
474   Id rec, *recp;
475   Id sug, *sugp;
476   Id p, pp;             /* whatprovides loops */
477   Id *dp;               /* ptr to 'whatprovides' */
478   Id n;                 /* Id for current solvable 's' */
479
480   queue_init_buffer(&workq, workqbuf, sizeof(workqbuf)/sizeof(*workqbuf));
481   queue_push(&workq, s - pool->solvables);      /* push solvable Id to work queue */
482
483   /* loop until there's no more work left */
484   while (workq.count)
485     {
486       /*
487        * n: Id of solvable
488        * s: Pointer to solvable
489        */
490
491       n = queue_shift(&workq);          /* 'pop' next solvable to work on from queue */
492       if (m)
493         {
494           if (MAPTST(m, n))             /* continue if already visited */
495             continue;
496           MAPSET(m, n);                 /* mark as visited */
497         }
498
499       s = pool->solvables + n;          /* s = Solvable in question */
500
501       dontfix = 0;
502       if (installed                     /* Installed system available */
503           && s->repo == installed       /* solvable is installed */
504           && !solv->fixmap_all          /* NOT repair errors in rpm dependency graph */
505           && !(solv->fixmap.size && MAPTST(&solv->fixmap, n - installed->start)))
506         {
507           dontfix = 1;                  /* dont care about broken rpm deps */
508         }
509
510       if (!dontfix
511           && s->arch != ARCH_SRC
512           && s->arch != ARCH_NOSRC
513           && !pool_installable(pool, s))
514         {
515           POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables));
516           addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOT_INSTALLABLE, 0);
517         }
518
519       /* yet another SUSE hack, sigh */
520       if (pool->nscallback && !strncmp("product:", pool_id2str(pool, s->name), 8))
521         {
522           Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, n);
523           if (buddy > 0 && buddy != SYSTEMSOLVABLE && buddy != n && buddy < pool->nsolvables)
524             {
525               addrpmrule(solv, n, -buddy, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + n));
526               addrpmrule(solv, buddy, -n, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + buddy)); 
527               if (m && !MAPTST(m, buddy))
528                 queue_push(&workq, buddy);
529             }
530         }
531
532       /*-----------------------------------------
533        * check requires of s
534        */
535
536       if (s->requires)
537         {
538           reqp = s->repo->idarraydata + s->requires;
539           while ((req = *reqp++) != 0)            /* go through all requires */
540             {
541               if (req == SOLVABLE_PREREQMARKER)   /* skip the marker */
542                 continue;
543
544               /* find list of solvables providing 'req' */
545               dp = pool_whatprovides_ptr(pool, req);
546
547               if (*dp == SYSTEMSOLVABLE)          /* always installed */
548                 continue;
549
550               if (dontfix)
551                 {
552                   /* the strategy here is to not insist on dependencies
553                    * that are already broken. so if we find one provider
554                    * that was already installed, we know that the
555                    * dependency was not broken before so we enforce it */
556                  
557                   /* check if any of the providers for 'req' is installed */
558                   for (i = 0; (p = dp[i]) != 0; i++)
559                     {
560                       if (pool->solvables[p].repo == installed)
561                         break;          /* provider was installed */
562                     }
563                   /* didn't find an installed provider: previously broken dependency */
564                   if (!p)
565                     {
566                       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken requires %s of installed package %s\n", pool_dep2str(pool, req), pool_solvable2str(pool, s));
567                       continue;
568                     }
569                 }
570
571               if (!*dp)
572                 {
573                   /* nothing provides req! */
574                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables), pool_dep2str(pool, req));
575                   addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOTHING_PROVIDES_DEP, req);
576                   continue;
577                 }
578
579               IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
580                 {
581                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION,"  %s requires %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
582                   for (i = 0; dp[i]; i++)
583                     POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "   provided by %s\n", pool_solvid2str(pool, dp[i]));
584                 }
585
586               /* add 'requires' dependency */
587               /* rule: (-requestor|provider1|provider2|...|providerN) */
588               addrpmrule(solv, -n, dp - pool->whatprovidesdata, SOLVER_RULE_RPM_PACKAGE_REQUIRES, req);
589
590               /* descend the dependency tree
591                  push all non-visited providers on the work queue */
592               if (m)
593                 {
594                   for (; *dp; dp++)
595                     {
596                       if (!MAPTST(m, *dp))
597                         queue_push(&workq, *dp);
598                     }
599                 }
600
601             } /* while, requirements of n */
602
603         } /* if, requirements */
604
605       /* that's all we check for src packages */
606       if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC)
607         continue;
608
609       /*-----------------------------------------
610        * check conflicts of s
611        */
612
613       if (s->conflicts)
614         {
615           int ispatch = 0;
616
617           /* we treat conflicts in patches a bit differen:
618            * - nevr matching
619            * - multiversion handling
620            * XXX: we should really handle this different, looking
621            * at the name is a bad hack
622            */
623           if (!strncmp("patch:", pool_id2str(pool, s->name), 6))
624             ispatch = 1;
625           conp = s->repo->idarraydata + s->conflicts;
626           /* foreach conflicts of 's' */
627           while ((con = *conp++) != 0)
628             {
629               /* foreach providers of a conflict of 's' */
630               FOR_PROVIDES(p, pp, con)
631                 {
632                   if (ispatch && !pool_match_nevr(pool, pool->solvables + p, con))
633                     continue;
634                   /* dontfix: dont care about conflicts with already installed packs */
635                   if (dontfix && pool->solvables[p].repo == installed)
636                     continue;
637                   /* p == n: self conflict */
638                   if (p == n && pool->forbidselfconflicts)
639                     {
640                       if (ISRELDEP(con))
641                         {
642                           Reldep *rd = GETRELDEP(pool, con);
643                           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_OTHERPROVIDERS)
644                             continue;
645                         }
646                       p = 0;    /* make it a negative assertion, aka 'uninstallable' */
647                     }
648                   if (p && ispatch && solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p) && ISRELDEP(con))
649                     {
650                       /* our patch conflicts with a noobsoletes (aka multiversion) package */
651                       p = -makemultiversionconflict(solv, p, con);
652                     }
653                  /* rule: -n|-p: either solvable _or_ provider of conflict */
654                   addrpmrule(solv, -n, -p, p ? SOLVER_RULE_RPM_PACKAGE_CONFLICT : SOLVER_RULE_RPM_SELF_CONFLICT, con);
655                 }
656             }
657         }
658
659       /*-----------------------------------------
660        * check obsoletes and implicit obsoletes of a package
661        * if ignoreinstalledsobsoletes is not set, we're also checking
662        * obsoletes of installed packages (like newer rpm versions)
663        */
664       if ((!installed || s->repo != installed) || !pool->noinstalledobsoletes)
665         {
666           int noobs = solv->noobsoletes.size && MAPTST(&solv->noobsoletes, n);
667           int isinstalled = (installed && s->repo == installed);
668           if (s->obsoletes && !noobs)
669             {
670               obsp = s->repo->idarraydata + s->obsoletes;
671               /* foreach obsoletes */
672               while ((obs = *obsp++) != 0)
673                 {
674                   /* foreach provider of an obsoletes of 's' */ 
675                   FOR_PROVIDES(p, pp, obs)
676                     {
677                       Solvable *ps = pool->solvables + p;
678                       if (p == n)
679                         continue;
680                       if (isinstalled && dontfix && ps->repo == installed)
681                         continue;       /* don't repair installed/installed problems */
682                       if (!pool->obsoleteusesprovides /* obsoletes are matched names, not provides */
683                           && !pool_match_nevr(pool, ps, obs))
684                         continue;
685                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
686                         continue;
687                       if (!isinstalled)
688                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_PACKAGE_OBSOLETES, obs);
689                       else
690                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_INSTALLEDPKG_OBSOLETES, obs);
691                     }
692                 }
693             }
694           /* check implicit obsoletes
695            * for installed packages we only need to check installed/installed problems (and
696            * only when dontfix is not set), as the others are picked up when looking at the
697            * uninstalled package.
698            */
699           if (!isinstalled || !dontfix)
700             {
701               FOR_PROVIDES(p, pp, s->name)
702                 {
703                   Solvable *ps = pool->solvables + p;
704                   if (p == n)
705                     continue;
706                   if (isinstalled && ps->repo != installed)
707                     continue;
708                   /* we still obsolete packages with same nevra, like rpm does */
709                   /* (actually, rpm mixes those packages. yuck...) */
710                   if (noobs && (s->name != ps->name || s->evr != ps->evr || s->arch != ps->arch))
711                     continue;
712                   if (!pool->implicitobsoleteusesprovides && s->name != ps->name)
713                     continue;
714                   if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
715                     continue;
716                   if (s->name == ps->name)
717                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_SAME_NAME, 0);
718                   else
719                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_IMPLICIT_OBSOLETES, s->name);
720                 }
721             }
722         }
723
724       /*-----------------------------------------
725        * add recommends to the work queue
726        */
727       if (s->recommends && m)
728         {
729           recp = s->repo->idarraydata + s->recommends;
730           while ((rec = *recp++) != 0)
731             {
732               FOR_PROVIDES(p, pp, rec)
733                 if (!MAPTST(m, p))
734                   queue_push(&workq, p);
735             }
736         }
737       if (s->suggests && m)
738         {
739           sugp = s->repo->idarraydata + s->suggests;
740           while ((sug = *sugp++) != 0)
741             {
742               FOR_PROVIDES(p, pp, sug)
743                 if (!MAPTST(m, p))
744                   queue_push(&workq, p);
745             }
746         }
747     }
748   queue_free(&workq);
749 }
750
751
752 /*-------------------------------------------------------------------
753  * 
754  * Add rules for packages possibly selected in by weak dependencies
755  *
756  * m: already added solvables
757  */
758
759 void
760 solver_addrpmrulesforweak(Solver *solv, Map *m)
761 {
762   Pool *pool = solv->pool;
763   Solvable *s;
764   Id sup, *supp;
765   int i, n;
766
767   /* foreach solvable in pool */
768   for (i = n = 1; n < pool->nsolvables; i++, n++)
769     {
770       if (i == pool->nsolvables)                /* wrap i */
771         i = 1;
772       if (MAPTST(m, i))                         /* already added that one */
773         continue;
774
775       s = pool->solvables + i;
776       if (!pool_installable(pool, s))           /* only look at installable ones */
777         continue;
778
779       sup = 0;
780       if (s->supplements)
781         {
782           /* find possible supplements */
783           supp = s->repo->idarraydata + s->supplements;
784           while ((sup = *supp++) != 0)
785             if (dep_possible(solv, sup, m))
786               break;
787         }
788
789       /* if nothing found, check for enhances */
790       if (!sup && s->enhances)
791         {
792           supp = s->repo->idarraydata + s->enhances;
793           while ((sup = *supp++) != 0)
794             if (dep_possible(solv, sup, m))
795               break;
796         }
797       /* if nothing found, goto next solvables */
798       if (!sup)
799         continue;
800       solver_addrpmrulesforsolvable(solv, s, m);
801       n = 0;                    /* check all solvables again because we added solvables to m */
802     }
803 }
804
805
806 /*-------------------------------------------------------------------
807  * 
808  * add package rules for possible updates
809  * 
810  * s: solvable
811  * m: map of already visited solvables
812  * allow_all: 0 = dont allow downgrades, 1 = allow all candidates
813  */
814
815 void
816 solver_addrpmrulesforupdaters(Solver *solv, Solvable *s, Map *m, int allow_all)
817 {
818   Pool *pool = solv->pool;
819   int i;
820     /* queue and buffer for it */
821   Queue qs;
822   Id qsbuf[64];
823
824   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
825     /* find update candidates for 's' */
826   policy_findupdatepackages(solv, s, &qs, allow_all);
827     /* add rule for 's' if not already done */
828   if (!MAPTST(m, s - pool->solvables))
829     solver_addrpmrulesforsolvable(solv, s, m);
830     /* foreach update candidate, add rule if not already done */
831   for (i = 0; i < qs.count; i++)
832     if (!MAPTST(m, qs.elements[i]))
833       solver_addrpmrulesforsolvable(solv, pool->solvables + qs.elements[i], m);
834   queue_free(&qs);
835 }
836
837
838 /***********************************************************************
839  ***
840  ***  Update/Feature rule part
841  ***
842  ***  Those rules make sure an installed package isn't silently deleted
843  ***
844  ***/
845
846 static Id
847 finddistupgradepackages(Solver *solv, Solvable *s, Queue *qs, int allow_all)
848 {
849   Pool *pool = solv->pool;
850   int i;
851
852   policy_findupdatepackages(solv, s, qs, allow_all ? allow_all : 2);
853   if (!qs->count)
854     {
855       if (allow_all)
856         return 0;       /* orphaned, don't create feature rule */
857       /* check if this is an orphaned package */
858       policy_findupdatepackages(solv, s, qs, 1);
859       if (!qs->count)
860         return 0;       /* orphaned, don't create update rule */
861       qs->count = 0;
862       return -SYSTEMSOLVABLE;   /* supported but not installable */
863     }
864   if (allow_all)
865     return s - pool->solvables;
866   /* check if it is ok to keep the installed package */
867   for (i = 0; i < qs->count; i++)
868     {
869       Solvable *ns = pool->solvables + qs->elements[i];
870       if (s->evr == ns->evr && solvable_identical(s, ns))
871         return s - pool->solvables;
872     }
873   /* nope, it must be some other package */
874   return -SYSTEMSOLVABLE;
875 }
876
877 /* add packages from the dup repositories to the update candidates
878  * this isn't needed for the global dup mode as all packages are
879  * from dup repos in that case */
880 static void
881 addduppackages(Solver *solv, Solvable *s, Queue *qs)
882 {
883   Queue dupqs;
884   Id p, dupqsbuf[64];
885   int i;
886   int oldnoupdateprovide = solv->noupdateprovide;
887
888   queue_init_buffer(&dupqs, dupqsbuf, sizeof(dupqsbuf)/sizeof(*dupqsbuf));
889   solv->noupdateprovide = 1;
890   policy_findupdatepackages(solv, s, &dupqs, 2);
891   solv->noupdateprovide = oldnoupdateprovide;
892   for (i = 0; i < dupqs.count; i++)
893     {
894       p = dupqs.elements[i];
895       if (MAPTST(&solv->dupmap, p))
896         queue_pushunique(qs, p);
897     }
898   queue_free(&dupqs);
899 }
900
901 /*-------------------------------------------------------------------
902  * 
903  * add rule for update
904  *   (A|A1|A2|A3...)  An = update candidates for A
905  *
906  * s = (installed) solvable
907  */
908
909 void
910 solver_addupdaterule(Solver *solv, Solvable *s, int allow_all)
911 {
912   /* installed packages get a special upgrade allowed rule */
913   Pool *pool = solv->pool;
914   Id p, d;
915   Queue qs;
916   Id qsbuf[64];
917
918   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
919   p = s - pool->solvables;
920   /* find update candidates for 's' */
921   if (solv->dupmap_all)
922     p = finddistupgradepackages(solv, s, &qs, allow_all);
923   else
924     policy_findupdatepackages(solv, s, &qs, allow_all);
925   if (!allow_all && !solv->dupmap_all && solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
926     addduppackages(solv, s, &qs);
927
928   if (!allow_all && qs.count && solv->noobsoletes.size)
929     {
930       int i, j;
931
932       d = pool_queuetowhatprovides(pool, &qs);
933       /* filter out all noobsoletes packages as they don't update */
934       for (i = j = 0; i < qs.count; i++)
935         {
936           if (MAPTST(&solv->noobsoletes, qs.elements[i]))
937             {
938               /* it's ok if they have same nevra */
939               Solvable *ps = pool->solvables + qs.elements[i];
940               if (ps->name != s->name || ps->evr != s->evr || ps->arch != s->arch)
941                 continue;
942             }
943           qs.elements[j++] = qs.elements[i];
944         }
945       if (j < qs.count)
946         {
947           if (d && solv->installed && s->repo == solv->installed &&
948               (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, s - pool->solvables - solv->installed->start))))
949             {
950               if (!solv->multiversionupdaters)
951                 solv->multiversionupdaters = solv_calloc(solv->installed->end - solv->installed->start, sizeof(Id));
952               solv->multiversionupdaters[s - pool->solvables - solv->installed->start] = d;
953             }
954           if (j == 0 && p == -SYSTEMSOLVABLE && solv->dupmap_all)
955             {
956               queue_push(&solv->orphaned, s - pool->solvables); /* treat as orphaned */
957               j = qs.count;
958             }
959           qs.count = j;
960         }
961     }
962   if (qs.count && p == -SYSTEMSOLVABLE)
963     p = queue_shift(&qs);
964   d = qs.count ? pool_queuetowhatprovides(pool, &qs) : 0;
965   queue_free(&qs);
966   solver_addrule(solv, p, d);   /* allow update of s */
967 }
968
969 static inline void 
970 disableupdaterule(Solver *solv, Id p)
971 {
972   Rule *r;
973
974   MAPSET(&solv->noupdate, p - solv->installed->start);
975   r = solv->rules + solv->updaterules + (p - solv->installed->start);
976   if (r->p && r->d >= 0)
977     solver_disablerule(solv, r);
978   r = solv->rules + solv->featurerules + (p - solv->installed->start);
979   if (r->p && r->d >= 0)
980     solver_disablerule(solv, r);
981 }
982
983 static inline void 
984 reenableupdaterule(Solver *solv, Id p)
985 {
986   Pool *pool = solv->pool;
987   Rule *r;
988
989   MAPCLR(&solv->noupdate, p - solv->installed->start);
990   r = solv->rules + solv->updaterules + (p - solv->installed->start);
991   if (r->p)
992     {    
993       if (r->d >= 0)
994         return;
995       solver_enablerule(solv, r);
996       IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
997         {
998           POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
999           solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1000         }
1001       return;
1002     }
1003   r = solv->rules + solv->featurerules + (p - solv->installed->start);
1004   if (r->p && r->d < 0)
1005     {
1006       solver_enablerule(solv, r);
1007       IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1008         {
1009           POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1010           solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1011         }
1012     }
1013 }
1014
1015
1016 /***********************************************************************
1017  ***
1018  ***  Infarch rule part
1019  ***
1020  ***  Infarch rules make sure the solver uses the best architecture of
1021  ***  a package if multiple archetectures are available
1022  ***
1023  ***/
1024
1025 void
1026 solver_addinfarchrules(Solver *solv, Map *addedmap)
1027 {
1028   Pool *pool = solv->pool;
1029   int first, i, j;
1030   Id p, pp, a, aa, bestarch;
1031   Solvable *s, *ps, *bests;
1032   Queue badq, allowedarchs;
1033
1034   queue_init(&badq);
1035   queue_init(&allowedarchs);
1036   solv->infarchrules = solv->nrules;
1037   for (i = 1; i < pool->nsolvables; i++)
1038     {
1039       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1040         continue;
1041       s = pool->solvables + i;
1042       first = i;
1043       bestarch = 0;
1044       bests = 0;
1045       queue_empty(&allowedarchs);
1046       FOR_PROVIDES(p, pp, s->name)
1047         {
1048           ps = pool->solvables + p;
1049           if (ps->name != s->name || !MAPTST(addedmap, p))
1050             continue;
1051           if (p == i)
1052             first = 0;
1053           if (first)
1054             break;
1055           a = ps->arch;
1056           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1057           if (a != 1 && pool->installed && ps->repo == pool->installed)
1058             {
1059               if (!solv->dupmap_all && !(solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1060                 queue_pushunique(&allowedarchs, ps->arch);      /* also ok to keep this architecture */
1061               continue;         /* ignore installed solvables when calculating the best arch */
1062             }
1063           if (a && a != 1 && (!bestarch || a < bestarch))
1064             {
1065               bestarch = a;
1066               bests = ps;
1067             }
1068         }
1069       if (first)
1070         continue;
1071       /* speed up common case where installed package already has best arch */
1072       if (allowedarchs.count == 1 && bests && allowedarchs.elements[0] == bests->arch)
1073         allowedarchs.count--;   /* installed arch is best */
1074       queue_empty(&badq);
1075       FOR_PROVIDES(p, pp, s->name)
1076         {
1077           ps = pool->solvables + p;
1078           if (ps->name != s->name || !MAPTST(addedmap, p))
1079             continue;
1080           a = ps->arch;
1081           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1082           if (a != 1 && bestarch && ((a ^ bestarch) & 0xffff0000) != 0)
1083             {
1084               if (pool->installed && ps->repo == pool->installed)
1085                 continue;       /* always ok to keep an installed package */
1086               for (j = 0; j < allowedarchs.count; j++)
1087                 {
1088                   aa = allowedarchs.elements[j];
1089                   if (ps->arch == aa)
1090                     break;
1091                   aa = (aa <= pool->lastarch) ? pool->id2arch[aa] : 0;
1092                   if (aa && ((a ^ aa) & 0xffff0000) == 0)
1093                     break;      /* compatible */
1094                 }
1095               if (j == allowedarchs.count)
1096                 queue_push(&badq, p);
1097             }
1098         }
1099       if (!badq.count)
1100         continue;
1101       /* block all solvables in the badq! */
1102       for (j = 0; j < badq.count; j++)
1103         {
1104           p = badq.elements[j];
1105           solver_addrule(solv, -p, 0);
1106         }
1107     }
1108   queue_free(&badq);
1109   queue_free(&allowedarchs);
1110   solv->infarchrules_end = solv->nrules;
1111 }
1112
1113 static inline void
1114 disableinfarchrule(Solver *solv, Id name)
1115 {
1116   Pool *pool = solv->pool;
1117   Rule *r;
1118   int i;
1119   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1120     {
1121       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1122         solver_disablerule(solv, r);
1123     }
1124 }
1125
1126 static inline void
1127 reenableinfarchrule(Solver *solv, Id name)
1128 {
1129   Pool *pool = solv->pool;
1130   Rule *r;
1131   int i;
1132   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1133     {
1134       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1135         {
1136           solver_enablerule(solv, r);
1137           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1138             {
1139               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1140               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1141             }
1142         }
1143     }
1144 }
1145
1146
1147 /***********************************************************************
1148  ***
1149  ***  Dup rule part
1150  ***
1151  ***  Dup rules make sure a package is selected from the specified dup
1152  ***  repositories if an update candidate is included in one of them.
1153  ***
1154  ***/
1155
1156 void
1157 solver_createdupmaps(Solver *solv)
1158 {
1159   Queue *job = &solv->job;
1160   Pool *pool = solv->pool;
1161   Repo *repo;
1162   Id how, what, p, pi, pp, obs, *obsp;
1163   Solvable *s, *ps;
1164   int i;
1165
1166   map_init(&solv->dupmap, pool->nsolvables);
1167   map_init(&solv->dupinvolvedmap, pool->nsolvables);
1168   for (i = 0; i < job->count; i += 2)
1169     {
1170       how = job->elements[i];
1171       what = job->elements[i + 1];
1172       switch (how & SOLVER_JOBMASK)
1173         {
1174         case SOLVER_DISTUPGRADE:
1175           if ((how & SOLVER_SELECTMASK) != SOLVER_SOLVABLE_REPO)
1176             break;
1177           if (what <= 0 || what > pool->nrepos)
1178             break;
1179           repo = pool_id2repo(pool, what);
1180           FOR_REPO_SOLVABLES(repo, p, s)
1181             {
1182               if (repo != solv->installed && !pool_installable(pool, s))
1183                 continue;
1184               MAPSET(&solv->dupmap, p);
1185               FOR_PROVIDES(pi, pp, s->name)
1186                 {
1187                   ps = pool->solvables + pi;
1188                   if (ps->name != s->name)
1189                     continue;
1190                   MAPSET(&solv->dupinvolvedmap, pi);
1191                 }
1192               if (s->obsoletes)
1193                 {
1194                   /* FIXME: check obsoletes/provides combination */
1195                   obsp = s->repo->idarraydata + s->obsoletes;
1196                   while ((obs = *obsp++) != 0)
1197                     {
1198                       FOR_PROVIDES(pi, pp, obs)
1199                         {
1200                           Solvable *pis = pool->solvables + pi;
1201                           if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pis, obs))
1202                             continue;
1203                           if (pool->obsoleteusescolors && !pool_colormatch(pool, s, pis))
1204                             continue;
1205                           MAPSET(&solv->dupinvolvedmap, pi);
1206                         }
1207                     }
1208                 }
1209             }
1210           break;
1211         default:
1212           break;
1213         }
1214     }
1215   MAPCLR(&solv->dupinvolvedmap, SYSTEMSOLVABLE);
1216 }
1217
1218 void
1219 solver_freedupmaps(Solver *solv)
1220 {
1221   map_free(&solv->dupmap);
1222   /* we no longer free solv->dupinvolvedmap as we need it in
1223    * policy's priority pruning code. sigh. */
1224 }
1225
1226 void
1227 solver_addduprules(Solver *solv, Map *addedmap)
1228 {
1229   Pool *pool = solv->pool;
1230   Id p, pp;
1231   Solvable *s, *ps;
1232   int first, i;
1233
1234   solv->duprules = solv->nrules;
1235   for (i = 1; i < pool->nsolvables; i++)
1236     {
1237       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1238         continue;
1239       s = pool->solvables + i;
1240       first = i;
1241       FOR_PROVIDES(p, pp, s->name)
1242         {
1243           ps = pool->solvables + p;
1244           if (ps->name != s->name || !MAPTST(addedmap, p))
1245             continue;
1246           if (p == i)
1247             first = 0;
1248           if (first)
1249             break;
1250           if (!MAPTST(&solv->dupinvolvedmap, p))
1251             continue;
1252           if (solv->installed && ps->repo == solv->installed)
1253             {
1254               if (!solv->updatemap.size)
1255                 map_grow(&solv->updatemap, solv->installed->end - solv->installed->start);
1256               MAPSET(&solv->updatemap, p - solv->installed->start);
1257               if (!MAPTST(&solv->dupmap, p))
1258                 {
1259                   Id ip, ipp;
1260                   /* is installed identical to a good one? */
1261                   FOR_PROVIDES(ip, ipp, ps->name)
1262                     {
1263                       Solvable *is = pool->solvables + ip;
1264                       if (!MAPTST(&solv->dupmap, ip))
1265                         continue;
1266                       if (is->evr == ps->evr && solvable_identical(ps, is))
1267                         break;
1268                     }
1269                   if (!ip)
1270                     solver_addrule(solv, -p, 0);        /* no match, sorry */
1271                 }
1272             }
1273           else if (!MAPTST(&solv->dupmap, p))
1274             solver_addrule(solv, -p, 0);
1275         }
1276     }
1277   solv->duprules_end = solv->nrules;
1278 }
1279
1280
1281 static inline void
1282 disableduprule(Solver *solv, Id name)
1283 {
1284   Pool *pool = solv->pool;
1285   Rule *r;
1286   int i;
1287   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++) 
1288     {    
1289       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1290         solver_disablerule(solv, r);
1291     }    
1292 }
1293
1294 static inline void 
1295 reenableduprule(Solver *solv, Id name)
1296 {
1297   Pool *pool = solv->pool;
1298   Rule *r;
1299   int i;
1300   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++) 
1301     {    
1302       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1303         {
1304           solver_enablerule(solv, r);
1305           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1306             {
1307               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1308               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1309             }
1310         }
1311     }
1312 }
1313
1314
1315 /***********************************************************************
1316  ***
1317  ***  Policy rule disabling/reenabling
1318  ***
1319  ***  Disable all policy rules that conflict with our jobs. If a job
1320  ***  gets disabled later on, reenable the involved policy rules again.
1321  ***
1322  ***/
1323
1324 #define DISABLE_UPDATE  1
1325 #define DISABLE_INFARCH 2
1326 #define DISABLE_DUP     3
1327
1328 /* 
1329  * add all installed packages that package p obsoletes to Queue q.
1330  * Package p is not installed and not in oobs map.
1331  * Entries may get added multiple times.
1332  */
1333 static void
1334 add_obsoletes(Solver *solv, Id p, Queue *q)
1335 {
1336   Pool *pool = solv->pool;
1337   Repo *installed = solv->installed;
1338   Id p2, pp2;
1339   Solvable *s = pool->solvables + p;
1340   Id obs, *obsp;
1341   Id lastp2 = 0;
1342
1343   /* we already know: p is not installed, p is not noobs */
1344   FOR_PROVIDES(p2, pp2, s->name)
1345     {
1346       Solvable *ps = pool->solvables + p2;
1347       if (ps->repo != installed)
1348         continue;
1349       if (!pool->implicitobsoleteusesprovides && ps->name != s->name)
1350         continue;
1351       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps)) 
1352         continue;
1353       queue_push(q, p2);
1354       lastp2 = p2;
1355     }
1356   if (!s->obsoletes)
1357     return;
1358   obsp = s->repo->idarraydata + s->obsoletes;
1359   while ((obs = *obsp++) != 0)
1360     FOR_PROVIDES(p2, pp2, obs) 
1361       {
1362         Solvable *ps = pool->solvables + p2;
1363         if (ps->repo != installed)
1364           continue;
1365         if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1366           continue;
1367         if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps)) 
1368           continue;
1369         if (p2 == lastp2)
1370           continue;
1371         queue_push(q, p2);
1372         lastp2 = p2;
1373       }
1374 }
1375
1376 /*
1377  * Call add_obsoletes and intersect the result with the
1378  * elements in Queue q starting at qstart.
1379  * Assumes that it's the first call if qstart == q->count.
1380  * May use auxillary map m for the intersection process, all
1381  * elements of q starting at qstart must have their bit cleared.
1382  * (This is also true after the function returns.)
1383  */
1384 static void
1385 intersect_obsoletes(Solver *solv, Id p, Queue *q, int qstart, Map *m)
1386 {
1387   int i, j;
1388   int qcount = q->count;
1389
1390   add_obsoletes(solv, p, q);
1391   if (qcount == qstart)
1392     return;     /* first call */
1393   if (qcount == q->count)
1394     j = qstart; 
1395   else if (qcount == qstart + 1)
1396     {
1397       /* easy if there's just one element */
1398       j = qstart;
1399       for (i = qcount; i < q->count; i++)
1400         if (q->elements[i] == q->elements[qstart])
1401           {
1402             j++;        /* keep the element */
1403             break;
1404           }
1405     }
1406   else if (!m->size && q->count - qstart <= 8)
1407     {
1408       /* faster than a map most of the time */
1409       int k;
1410       for (i = j = qstart; i < qcount; i++)
1411         {
1412           Id ip = q->elements[i];
1413           for (k = qcount; k < q->count; k++)
1414             if (q->elements[k] == ip)
1415               {
1416                 q->elements[j++] = ip;
1417                 break;
1418               }
1419         }
1420     }
1421   else
1422     {
1423       /* for the really pathologic cases we use the map */
1424       Repo *installed = solv->installed;
1425       if (!m->size)
1426         map_init(m, installed->end - installed->start);
1427       for (i = qcount; i < q->count; i++)
1428         MAPSET(m, q->elements[i] - installed->start);
1429       for (i = j = qstart; i < qcount; i++)
1430         if (MAPTST(m, q->elements[i] - installed->start))
1431           {
1432             MAPCLR(m, q->elements[i] - installed->start);
1433             q->elements[j++] = q->elements[i];
1434           }
1435     }
1436   queue_truncate(q, j);
1437 }
1438
1439 static void
1440 jobtodisablelist(Solver *solv, Id how, Id what, Queue *q)
1441 {
1442   Pool *pool = solv->pool;
1443   Id select, p, pp;
1444   Repo *installed;
1445   Solvable *s;
1446   int i, j, set, qstart;
1447   Map omap;
1448
1449   installed = solv->installed;
1450   select = how & SOLVER_SELECTMASK;
1451   switch (how & SOLVER_JOBMASK)
1452     {
1453     case SOLVER_INSTALL:
1454       set = how & SOLVER_SETMASK;
1455       if (!(set & SOLVER_NOAUTOSET))
1456         {
1457           /* automatically add set bits by analysing the job */
1458           if (select == SOLVER_SOLVABLE)
1459             set |= SOLVER_SETARCH | SOLVER_SETVENDOR | SOLVER_SETREPO | SOLVER_SETEVR;
1460           else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
1461             {
1462               Reldep *rd = GETRELDEP(pool, what);
1463               if (rd->flags == REL_EQ && select == SOLVER_SOLVABLE_NAME)
1464                 {
1465 #if !defined(DEBIAN_SEMANTICS)
1466                   const char *evr = pool_id2str(pool, rd->evr);
1467                   if (strchr(evr, '-'))
1468                     set |= SOLVER_SETEVR;
1469                   else
1470                     set |= SOLVER_SETEV;
1471 #else
1472                   set |= SOLVER_SETEVR;
1473 #endif
1474                 }
1475               if (rd->flags <= 7 && ISRELDEP(rd->name))
1476                 rd = GETRELDEP(pool, rd->name);
1477               if (rd->flags == REL_ARCH)
1478                 set |= SOLVER_SETARCH;
1479             }
1480         }
1481       else
1482         set &= ~SOLVER_NOAUTOSET;
1483       if (!set)
1484         return;
1485       if ((set & SOLVER_SETARCH) != 0 && solv->infarchrules != solv->infarchrules_end)
1486         {
1487           if (select == SOLVER_SOLVABLE)
1488             queue_push2(q, DISABLE_INFARCH, pool->solvables[what].name);
1489           else
1490             {
1491               int qcnt = q->count;
1492               FOR_JOB_SELECT(p, pp, select, what)
1493                 {
1494                   s = pool->solvables + p;
1495                   /* unify names */
1496                   for (i = qcnt; i < q->count; i += 2)
1497                     if (q->elements[i + 1] == s->name)
1498                       break;
1499                   if (i < q->count)
1500                     continue;
1501                   queue_push2(q, DISABLE_INFARCH, s->name);
1502                 }
1503             }
1504         }
1505       if ((set & SOLVER_SETREPO) != 0 && solv->duprules != solv->duprules_end)
1506         {
1507           if (select == SOLVER_SOLVABLE)
1508             queue_push2(q, DISABLE_DUP, pool->solvables[what].name);
1509           else
1510             {
1511               int qcnt = q->count;
1512               FOR_JOB_SELECT(p, pp, select, what)
1513                 {
1514                   s = pool->solvables + p;
1515                   /* unify names */
1516                   for (i = qcnt; i < q->count; i += 2)
1517                     if (q->elements[i + 1] == s->name)
1518                       break;
1519                   if (i < q->count)
1520                     continue;
1521                   queue_push2(q, DISABLE_DUP, s->name);
1522                 }
1523             }
1524         }
1525       if (!installed || installed->end == installed->start)
1526         return;
1527       /* now the hard part: disable some update rules */
1528
1529       /* first check if we have noobs or installed packages in the job */
1530       i = j = 0;
1531       FOR_JOB_SELECT(p, pp, select, what)
1532         {
1533           if (pool->solvables[p].repo == installed)
1534             j = p;
1535           else if (solv->noobsoletes.size && MAPTST(&solv->noobsoletes, p))
1536             return;
1537           i++;
1538         }
1539       if (j)    /* have installed packages */
1540         {
1541           /* this is for dupmap_all jobs, it can go away if we create
1542            * duprules for them */
1543           if (i == 1 && (set & SOLVER_SETREPO) != 0)
1544             queue_push2(q, DISABLE_UPDATE, j);
1545           return;
1546         }
1547
1548       omap.size = 0;
1549       qstart = q->count;
1550       FOR_JOB_SELECT(p, pp, select, what)
1551         {
1552           intersect_obsoletes(solv, p, q, qstart, &omap);
1553           if (q->count == qstart)
1554             break;
1555         }
1556       if (omap.size)
1557         map_free(&omap);
1558
1559       if (qstart == q->count)
1560         return;         /* nothing to prune */
1561
1562       /* convert result to (DISABLE_UPDATE, p) pairs */
1563       i = q->count;
1564       for (j = qstart; j < i; j++)
1565         queue_push(q, q->elements[j]);
1566       for (j = qstart; j < q->count; j += 2)
1567         {
1568           q->elements[j] = DISABLE_UPDATE;
1569           q->elements[j + 1] = q->elements[i++];
1570         }
1571
1572       /* now that we know which installed packages are obsoleted check each of them */
1573       if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
1574         return;         /* all is set, nothing to do */
1575
1576       for (i = j = qstart; i < q->count; i += 2)
1577         {
1578           Solvable *is = pool->solvables + q->elements[i + 1];
1579           FOR_JOB_SELECT(p, pp, select, what)
1580             {
1581               int illegal = 0;
1582               s = pool->solvables + p;
1583               if ((set & SOLVER_SETEVR) != 0)
1584                 illegal |= POLICY_ILLEGAL_DOWNGRADE;    /* ignore */
1585               if ((set & SOLVER_SETARCH) != 0)
1586                 illegal |= POLICY_ILLEGAL_ARCHCHANGE;   /* ignore */
1587               if ((set & SOLVER_SETVENDOR) != 0)
1588                 illegal |= POLICY_ILLEGAL_VENDORCHANGE; /* ignore */
1589               illegal = policy_is_illegal(solv, is, s, illegal);
1590               if (illegal && illegal == POLICY_ILLEGAL_DOWNGRADE && (set & SOLVER_SETEV) != 0)
1591                 {
1592                   /* it's ok if the EV is different */
1593                   if (pool_evrcmp(pool, is->evr, s->evr, EVRCMP_COMPARE_EVONLY) != 0)
1594                     illegal = 0;
1595                 }
1596               if (illegal)
1597                 break;
1598             }
1599           if (!p)
1600             {   
1601               /* no package conflicts with the update rule */
1602               /* thus keep the DISABLE_UPDATE */
1603               q->elements[j + 1] = q->elements[i + 1];
1604               j += 2;
1605             }
1606         }
1607       queue_truncate(q, j);
1608       return;
1609
1610     case SOLVER_ERASE:
1611       if (!installed)
1612         break;
1613       FOR_JOB_SELECT(p, pp, select, what)
1614         if (pool->solvables[p].repo == installed)
1615           queue_push2(q, DISABLE_UPDATE, p);
1616       return;
1617     default:
1618       return;
1619     }
1620 }
1621
1622 /* disable all policy rules that are in conflict with our job list */
1623 void
1624 solver_disablepolicyrules(Solver *solv)
1625 {
1626   Queue *job = &solv->job;
1627   int i, j;
1628   Queue allq;
1629   Rule *r;
1630   Id lastjob = -1;
1631   Id allqbuf[128];
1632
1633   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1634
1635   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1636     {
1637       r = solv->rules + i;
1638       if (r->d < 0)     /* disabled? */
1639         continue;
1640       j = solv->ruletojob.elements[i - solv->jobrules];
1641       if (j == lastjob)
1642         continue;
1643       lastjob = j;
1644       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1645     }
1646   if (solv->cleandepsmap.size)
1647     {
1648       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1649       for (i = solv->installed->start; i < solv->installed->end; i++)
1650         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1651           queue_push2(&allq, DISABLE_UPDATE, i);
1652     }
1653   MAPZERO(&solv->noupdate);
1654   for (i = 0; i < allq.count; i += 2)
1655     {
1656       Id type = allq.elements[i], arg = allq.elements[i + 1];
1657       switch(type)
1658         {
1659         case DISABLE_UPDATE:
1660           disableupdaterule(solv, arg);
1661           break;
1662         case DISABLE_INFARCH:
1663           disableinfarchrule(solv, arg);
1664           break;
1665         case DISABLE_DUP:
1666           disableduprule(solv, arg);
1667           break;
1668         default:
1669           break;
1670         }
1671     }
1672   queue_free(&allq);
1673 }
1674
1675 /* we just disabled job #jobidx, now reenable all policy rules that were
1676  * disabled because of this job */
1677 void
1678 solver_reenablepolicyrules(Solver *solv, int jobidx)
1679 {
1680   Queue *job = &solv->job;
1681   int i, j;
1682   Queue q, allq;
1683   Rule *r;
1684   Id lastjob = -1;
1685   Id qbuf[32], allqbuf[128];
1686
1687   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
1688   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1689   jobtodisablelist(solv, job->elements[jobidx - 1], job->elements[jobidx], &q);
1690   if (!q.count)
1691     return;
1692   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1693     {
1694       r = solv->rules + i;
1695       if (r->d < 0)     /* disabled? */
1696         continue;
1697       j = solv->ruletojob.elements[i - solv->jobrules];
1698       if (j == lastjob)
1699         continue;
1700       lastjob = j;
1701       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1702     }
1703   if (solv->cleandepsmap.size)
1704     {
1705       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1706       for (i = solv->installed->start; i < solv->installed->end; i++)
1707         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1708           queue_push2(&allq, DISABLE_UPDATE, i);
1709     }
1710   for (j = 0; j < q.count; j += 2)
1711     {
1712       Id type = q.elements[j], arg = q.elements[j + 1];
1713       for (i = 0; i < allq.count; i += 2)
1714         if (allq.elements[i] == type && allq.elements[i + 1] == arg)
1715           break;
1716       if (i < allq.count)
1717         continue;       /* still disabled */
1718       switch(type)
1719         {
1720         case DISABLE_UPDATE:
1721           reenableupdaterule(solv, arg);
1722           break;
1723         case DISABLE_INFARCH:
1724           reenableinfarchrule(solv, arg);
1725           break;
1726         case DISABLE_DUP:
1727           reenableduprule(solv, arg);
1728           break;
1729         }
1730     }
1731   queue_free(&allq);
1732   queue_free(&q);
1733 }
1734
1735 /* we just removed a package from the cleandeps map, now reenable all policy rules that were
1736  * disabled because of this */
1737 void
1738 solver_reenablepolicyrules_cleandeps(Solver *solv, Id pkg)
1739 {
1740   Queue *job = &solv->job;
1741   int i, j;
1742   Queue allq;
1743   Rule *r;
1744   Id lastjob = -1;
1745   Id allqbuf[128];
1746
1747   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1748   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1749     {
1750       r = solv->rules + i;
1751       if (r->d < 0)     /* disabled? */
1752         continue;
1753       j = solv->ruletojob.elements[i - solv->jobrules];
1754       if (j == lastjob)
1755         continue;
1756       lastjob = j;
1757       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1758     }
1759   for (i = 0; i < allq.count; i += 2)
1760     if (allq.elements[i] == DISABLE_UPDATE && allq.elements[i + 1] == pkg)
1761       break;
1762   if (i == allq.count)
1763     reenableupdaterule(solv, pkg);
1764   queue_free(&allq);
1765 }
1766
1767
1768 /***********************************************************************
1769  ***
1770  ***  Rule info part, tell the user what the rule is about.
1771  ***
1772  ***/
1773
1774 static void
1775 addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep)
1776 {
1777   Pool *pool = solv->pool;
1778   Rule *r;
1779   Id w2, op, od, ow2;
1780
1781   /* check if this creates the rule we're searching for */
1782   r = solv->rules + solv->ruleinfoq->elements[0];
1783   op = r->p;
1784   od = r->d < 0 ? -r->d - 1 : r->d;
1785   ow2 = 0;
1786
1787   /* normalize */
1788   w2 = d > 0 ? 0 : d;
1789   if (p < 0 && d > 0 && (!pool->whatprovidesdata[d] || !pool->whatprovidesdata[d + 1]))
1790     {
1791       w2 = pool->whatprovidesdata[d];
1792       d = 0;
1793
1794     }
1795   if (p > 0 && d < 0)           /* this hack is used for buddy deps */
1796     {
1797       w2 = p;
1798       p = d;
1799     }
1800
1801   if (d > 0)
1802     {
1803       if (p != op && !od)
1804         return;
1805       if (d != od)
1806         {
1807           Id *dp = pool->whatprovidesdata + d;
1808           Id *odp = pool->whatprovidesdata + od;
1809           while (*dp)
1810             if (*dp++ != *odp++)
1811               return;
1812           if (*odp)
1813             return;
1814         }
1815       w2 = 0;
1816       /* handle multiversion conflict rules */
1817       if (p < 0 && pool->whatprovidesdata[d] < 0)
1818         {
1819           w2 = pool->whatprovidesdata[d];
1820           /* XXX: free memory */
1821         }
1822     }
1823   else
1824     {
1825       if (od)
1826         return;
1827       ow2 = r->w2;
1828       if (p > w2)
1829         {
1830           if (w2 != op || p != ow2)
1831             return;
1832         }
1833       else
1834         {
1835           if (p != op || w2 != ow2)
1836             return;
1837         }
1838     }
1839   /* yep, rule matches. record info */
1840   queue_push(solv->ruleinfoq, type);
1841   if (type == SOLVER_RULE_RPM_SAME_NAME)
1842     {
1843       /* we normalize same name order */
1844       queue_push(solv->ruleinfoq, op < 0 ? -op : 0);
1845       queue_push(solv->ruleinfoq, ow2 < 0 ? -ow2 : 0);
1846     }
1847   else
1848     {
1849       queue_push(solv->ruleinfoq, p < 0 ? -p : 0);
1850       queue_push(solv->ruleinfoq, w2 < 0 ? -w2 : 0);
1851     }
1852   queue_push(solv->ruleinfoq, dep);
1853 }
1854
1855 static int
1856 solver_allruleinfos_cmp(const void *ap, const void *bp, void *dp)
1857 {
1858   const Id *a = ap, *b = bp;
1859   int r;
1860
1861   r = a[0] - b[0];
1862   if (r)
1863     return r;
1864   r = a[1] - b[1];
1865   if (r)
1866     return r;
1867   r = a[2] - b[2];
1868   if (r)
1869     return r;
1870   r = a[3] - b[3];
1871   if (r)
1872     return r;
1873   return 0;
1874 }
1875
1876 int
1877 solver_allruleinfos(Solver *solv, Id rid, Queue *rq)
1878 {
1879   Pool *pool = solv->pool;
1880   Rule *r = solv->rules + rid;
1881   int i, j;
1882
1883   queue_empty(rq);
1884   if (rid <= 0 || rid >= solv->rpmrules_end)
1885     {
1886       Id type, from, to, dep;
1887       type = solver_ruleinfo(solv, rid, &from, &to, &dep);
1888       queue_push(rq, type);
1889       queue_push(rq, from);
1890       queue_push(rq, to);
1891       queue_push(rq, dep);
1892       return 1;
1893     }
1894   if (r->p >= 0)
1895     return 0;
1896   queue_push(rq, rid);
1897   solv->ruleinfoq = rq;
1898   solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
1899   /* also try reverse direction for conflicts */
1900   if ((r->d == 0 || r->d == -1) && r->w2 < 0)
1901     solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
1902   solv->ruleinfoq = 0;
1903   queue_shift(rq);
1904   /* now sort & unify em */
1905   if (!rq->count)
1906     return 0;
1907   solv_sort(rq->elements, rq->count / 4, 4 * sizeof(Id), solver_allruleinfos_cmp, 0);
1908   /* throw out identical entries */
1909   for (i = j = 0; i < rq->count; i += 4)
1910     {
1911       if (j)
1912         {
1913           if (rq->elements[i] == rq->elements[j - 4] && 
1914               rq->elements[i + 1] == rq->elements[j - 3] &&
1915               rq->elements[i + 2] == rq->elements[j - 2] &&
1916               rq->elements[i + 3] == rq->elements[j - 1])
1917             continue;
1918         }
1919       rq->elements[j++] = rq->elements[i];
1920       rq->elements[j++] = rq->elements[i + 1];
1921       rq->elements[j++] = rq->elements[i + 2];
1922       rq->elements[j++] = rq->elements[i + 3];
1923     }
1924   rq->count = j;
1925   return j / 4;
1926 }
1927
1928 SolverRuleinfo
1929 solver_ruleinfo(Solver *solv, Id rid, Id *fromp, Id *top, Id *depp)
1930 {
1931   Pool *pool = solv->pool;
1932   Rule *r = solv->rules + rid;
1933   SolverRuleinfo type = SOLVER_RULE_UNKNOWN;
1934
1935   if (fromp)
1936     *fromp = 0;
1937   if (top)
1938     *top = 0;
1939   if (depp)
1940     *depp = 0;
1941   if (rid > 0 && rid < solv->rpmrules_end)
1942     {
1943       Queue rq;
1944       int i;
1945
1946       if (r->p >= 0)
1947         return SOLVER_RULE_RPM;
1948       if (fromp)
1949         *fromp = -r->p;
1950       queue_init(&rq);
1951       queue_push(&rq, rid);
1952       solv->ruleinfoq = &rq;
1953       solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
1954       /* also try reverse direction for conflicts */
1955       if ((r->d == 0 || r->d == -1) && r->w2 < 0)
1956         solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
1957       solv->ruleinfoq = 0;
1958       type = SOLVER_RULE_RPM;
1959       for (i = 1; i < rq.count; i += 4)
1960         {
1961           Id qt, qo, qp, qd;
1962           qt = rq.elements[i];
1963           qp = rq.elements[i + 1];
1964           qo = rq.elements[i + 2];
1965           qd = rq.elements[i + 3];
1966           if (type == SOLVER_RULE_RPM || type > qt)
1967             {
1968               type = qt;
1969               if (fromp)
1970                 *fromp = qp;
1971               if (top)
1972                 *top = qo;
1973               if (depp)
1974                 *depp = qd;
1975             }
1976         }
1977       queue_free(&rq);
1978       return type;
1979     }
1980   if (rid >= solv->jobrules && rid < solv->jobrules_end)
1981     {
1982       Id jidx = solv->ruletojob.elements[rid - solv->jobrules];
1983       if (fromp)
1984         *fromp = jidx;
1985       if (top)
1986         *top = solv->job.elements[jidx];
1987       if (depp)
1988         *depp = solv->job.elements[jidx + 1];
1989       if ((r->d == 0 || r->d == -1) && r->w2 == 0 && r->p == -SYSTEMSOLVABLE && (solv->job.elements[jidx] & SOLVER_SELECTMASK) != SOLVER_SOLVABLE_ONE_OF)
1990         return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
1991       return SOLVER_RULE_JOB;
1992     }
1993   if (rid >= solv->updaterules && rid < solv->updaterules_end)
1994     {
1995       if (fromp)
1996         *fromp = solv->installed->start + (rid - solv->updaterules);
1997       return SOLVER_RULE_UPDATE;
1998     }
1999   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2000     {
2001       if (fromp)
2002         *fromp = solv->installed->start + (rid - solv->featurerules);
2003       return SOLVER_RULE_FEATURE;
2004     }
2005   if (rid >= solv->duprules && rid < solv->duprules_end)
2006     {
2007       if (fromp)
2008         *fromp = -r->p;
2009       if (depp)
2010         *depp = pool->solvables[-r->p].name;
2011       return SOLVER_RULE_DISTUPGRADE;
2012     }
2013   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2014     {
2015       if (fromp)
2016         *fromp = -r->p;
2017       if (depp)
2018         *depp = pool->solvables[-r->p].name;
2019       return SOLVER_RULE_INFARCH;
2020     }
2021   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2022     {
2023       return SOLVER_RULE_CHOICE;
2024     }
2025   if (rid >= solv->learntrules)
2026     {
2027       return SOLVER_RULE_LEARNT;
2028     }
2029   return SOLVER_RULE_UNKNOWN;
2030 }
2031
2032 SolverRuleinfo
2033 solver_ruleclass(Solver *solv, Id rid)
2034 {
2035   if (rid <= 0)
2036     return SOLVER_RULE_UNKNOWN;
2037   if (rid > 0 && rid < solv->rpmrules_end)
2038     return SOLVER_RULE_RPM;
2039   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2040     return SOLVER_RULE_JOB;
2041   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2042     return SOLVER_RULE_UPDATE;
2043   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2044     return SOLVER_RULE_FEATURE;
2045   if (rid >= solv->duprules && rid < solv->duprules_end)
2046     return SOLVER_RULE_DISTUPGRADE;
2047   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2048     return SOLVER_RULE_INFARCH;
2049   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2050     return SOLVER_RULE_CHOICE;
2051   if (rid >= solv->learntrules)
2052     return SOLVER_RULE_LEARNT;
2053   return SOLVER_RULE_UNKNOWN;
2054 }
2055
2056 void
2057 solver_ruleliterals(Solver *solv, Id rid, Queue *q)
2058 {
2059   Pool *pool = solv->pool;
2060   Id p, *pp;
2061   Rule *r;
2062
2063   queue_empty(q);
2064   r = solv->rules + rid;
2065   FOR_RULELITERALS(p, pp, r)
2066     if (p != -SYSTEMSOLVABLE)
2067       queue_push(q, p);
2068   if (!q->count)
2069     queue_push(q, -SYSTEMSOLVABLE);     /* hmm, better to return an empty result? */
2070 }
2071
2072 int
2073 solver_rule2jobidx(Solver *solv, Id rid)
2074 {
2075   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2076     return 0;
2077   return solv->ruletojob.elements[rid - solv->jobrules] + 1;
2078 }
2079
2080 Id
2081 solver_rule2job(Solver *solv, Id rid, Id *whatp)
2082 {
2083   int idx;
2084   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2085     {
2086       if (whatp)
2087         *whatp = 0;
2088       return 0;
2089     }
2090   idx = solv->ruletojob.elements[rid - solv->jobrules];
2091   if (whatp)
2092     *whatp = solv->job.elements[idx + 1];
2093   return solv->job.elements[idx];
2094 }
2095
2096 void
2097 solver_addchoicerules(Solver *solv)
2098 {
2099   Pool *pool = solv->pool;
2100   Map m, mneg;
2101   Rule *r;
2102   Queue q, qi;
2103   int i, j, rid, havechoice;
2104   Id p, d, *pp;
2105   Id p2, pp2;
2106   Solvable *s, *s2;
2107
2108   solv->choicerules = solv->nrules;
2109   if (!pool->installed)
2110     {
2111       solv->choicerules_end = solv->nrules;
2112       return;
2113     }
2114   solv->choicerules_ref = solv_calloc(solv->rpmrules_end, sizeof(Id));
2115   queue_init(&q);
2116   queue_init(&qi);
2117   map_init(&m, pool->nsolvables);
2118   map_init(&mneg, pool->nsolvables);
2119   /* set up negative assertion map from infarch and dup rules */
2120   for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
2121     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2122       MAPSET(&mneg, -r->p);
2123   for (rid = solv->duprules, r = solv->rules + rid; rid < solv->duprules_end; rid++, r++)
2124     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2125       MAPSET(&mneg, -r->p);
2126   for (rid = 1; rid < solv->rpmrules_end ; rid++)
2127     {
2128       r = solv->rules + rid;
2129       if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 < 0))
2130         continue;       /* only look at requires rules */
2131       /* solver_printrule(solv, SOLV_DEBUG_RESULT, r); */
2132       queue_empty(&q);
2133       queue_empty(&qi);
2134       havechoice = 0;
2135       FOR_RULELITERALS(p, pp, r)
2136         {
2137           if (p < 0)
2138             continue;
2139           s = pool->solvables + p;
2140           if (!s->repo)
2141             continue;
2142           if (s->repo == pool->installed)
2143             {
2144               queue_push(&q, p);
2145               continue;
2146             }
2147           /* check if this package is "blocked" by a installed package */
2148           s2 = 0;
2149           FOR_PROVIDES(p2, pp2, s->name)
2150             {
2151               s2 = pool->solvables + p2;
2152               if (s2->repo != pool->installed)
2153                 continue;
2154               if (!pool->implicitobsoleteusesprovides && s->name != s2->name)
2155                 continue;
2156               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2157                 continue;
2158               break;
2159             }
2160           if (p2)
2161             {
2162               /* found installed package p2 that we can update to p */
2163               if (MAPTST(&mneg, p))
2164                 continue;
2165               if (policy_is_illegal(solv, s2, s, 0))
2166                 continue;
2167               queue_push(&qi, p2);
2168               queue_push(&q, p);
2169               continue;
2170             }
2171           if (s->obsoletes)
2172             {
2173               Id obs, *obsp = s->repo->idarraydata + s->obsoletes;
2174               s2 = 0;
2175               while ((obs = *obsp++) != 0)
2176                 {
2177                   FOR_PROVIDES(p2, pp2, obs)
2178                     {
2179                       s2 = pool->solvables + p2;
2180                       if (s2->repo != pool->installed)
2181                         continue;
2182                       if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
2183                         continue;
2184                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2185                         continue;
2186                       break;
2187                     }
2188                   if (p2)
2189                     break;
2190                 }
2191               if (obs)
2192                 {
2193                   /* found installed package p2 that we can update to p */
2194                   if (MAPTST(&mneg, p))
2195                     continue;
2196                   if (policy_is_illegal(solv, s2, s, 0))
2197                     continue;
2198                   queue_push(&qi, p2);
2199                   queue_push(&q, p);
2200                   continue;
2201                 }
2202             }
2203           /* package p is independent of the installed ones */
2204           havechoice = 1;
2205         }
2206       if (!havechoice || !q.count)
2207         continue;       /* no choice */
2208
2209       /* now check the update rules of the installed package.
2210        * if all packages of the update rules are contained in
2211        * the dependency rules, there's no need to set up the choice rule */
2212       map_empty(&m);
2213       FOR_RULELITERALS(p, pp, r)
2214         if (p > 0)
2215           MAPSET(&m, p);
2216       for (i = 0; i < qi.count; i++)
2217         {
2218           Rule *ur;
2219           if (!qi.elements[i])
2220             continue;
2221           ur = solv->rules + solv->updaterules + (qi.elements[i] - pool->installed->start);
2222           if (!ur->p)
2223             ur = solv->rules + solv->featurerules + (qi.elements[i] - pool->installed->start);
2224           if (!ur->p)
2225             continue;
2226           FOR_RULELITERALS(p, pp, ur)
2227             if (!MAPTST(&m, p))
2228               break;
2229           if (p)
2230             break;
2231           for (j = i + 1; j < qi.count; j++)
2232             if (qi.elements[i] == qi.elements[j])
2233               qi.elements[j] = 0;
2234         }
2235       if (i == qi.count)
2236         {
2237 #if 0
2238           printf("skipping choice ");
2239           solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2240 #endif
2241           continue;
2242         }
2243       d = q.count ? pool_queuetowhatprovides(pool, &q) : 0;
2244       solver_addrule(solv, r->p, d);
2245       queue_push(&solv->weakruleq, solv->nrules - 1);
2246       solv->choicerules_ref[solv->nrules - 1 - solv->choicerules] = rid;
2247 #if 0
2248       printf("OLD ");
2249       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2250       printf("WEAK CHOICE ");
2251       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + solv->nrules - 1);
2252 #endif
2253     }
2254   queue_free(&q);
2255   queue_free(&qi);
2256   map_free(&m);
2257   map_free(&mneg);
2258   solv->choicerules_end = solv->nrules;
2259 }
2260
2261 /* called when a choice rule is disabled by analyze_unsolvable. We also
2262  * have to disable all other choice rules so that the best packages get
2263  * picked */
2264 void
2265 solver_disablechoicerules(Solver *solv, Rule *r)
2266 {
2267   Id rid, p, *pp;
2268   Pool *pool = solv->pool;
2269   Map m;
2270   Rule *or;
2271
2272   or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2273   map_init(&m, pool->nsolvables);
2274   FOR_RULELITERALS(p, pp, or)
2275     if (p > 0)
2276       MAPSET(&m, p);
2277   FOR_RULELITERALS(p, pp, r)
2278     if (p > 0)
2279       MAPCLR(&m, p);
2280   for (rid = solv->choicerules; rid < solv->choicerules_end; rid++)
2281     {
2282       r = solv->rules + rid;
2283       if (r->d < 0)
2284         continue;
2285       or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2286       FOR_RULELITERALS(p, pp, or)
2287         if (p > 0 && MAPTST(&m, p))
2288           break;
2289       if (p)
2290         solver_disablerule(solv, r);
2291     }
2292 }
2293
2294 #undef CLEANDEPSDEBUG
2295
2296 /*
2297  * This functions collects all packages that are looked at
2298  * when a dependency is checked. We need it to "pin" installed
2299  * packages when removing a supplemented package in createcleandepsmap.
2300  * Here's an not uncommon example:
2301  *   A contains "Supplements: packageand(B, C)"
2302  *   B contains "Requires: A"
2303  * Now if we remove C, the supplements is no longer true,
2304  * thus we also remove A. Without the dep_pkgcheck function, we
2305  * would now also remove B, but this is wrong, as adding back
2306  * C doesn't make the supplements true again. Thus we "pin" B
2307  * when we remove A.
2308  * There's probably a better way to do this, but I haven't come
2309  * up with it yet ;)
2310  */
2311 static inline void
2312 dep_pkgcheck(Solver *solv, Id dep, Map *m, Queue *q)
2313 {
2314   Pool *pool = solv->pool;
2315   Id p, pp;
2316
2317   if (ISRELDEP(dep))
2318     {
2319       Reldep *rd = GETRELDEP(pool, dep);
2320       if (rd->flags >= 8)
2321         {
2322           if (rd->flags == REL_AND)
2323             {
2324               dep_pkgcheck(solv, rd->name, m, q);
2325               dep_pkgcheck(solv, rd->evr, m, q);
2326               return;
2327             }
2328           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
2329             return;
2330           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
2331             return;
2332         }
2333     }
2334   FOR_PROVIDES(p, pp, dep)
2335     if (!m || MAPTST(m, p))
2336       queue_push(q, p);
2337 }
2338
2339 /*
2340  * Find all installed packages that are no longer
2341  * needed regarding the current solver job.
2342  *
2343  * The algorithm is:
2344  * - remove pass: remove all packages that could have
2345  *   been dragged in by the obsoleted packages.
2346  *   i.e. if package A is obsolete and contains "Requires: B",
2347  *   also remove B, as installing A will have pulled in B.
2348  *   after this pass, we have a set of still installed packages
2349  *   with broken dependencies.
2350  * - add back pass:
2351  *   now add back all packages that the still installed packages
2352  *   require.
2353  *
2354  * The cleandeps packages are the packages removed in the first
2355  * pass and not added back in the second pass.
2356  *
2357  * If we search for unneeded packages (unneeded is true), we
2358  * simply remove all packages except the userinstalled ones in
2359  * the first pass.
2360  */
2361 static void
2362 solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded)
2363 {
2364   Pool *pool = solv->pool;
2365   Repo *installed = solv->installed;
2366   Queue *job = &solv->job;
2367   Map userinstalled;
2368   Map im;
2369   Map installedm;
2370   Rule *r;
2371   Id rid, how, what, select;
2372   Id p, pp, ip, *jp;
2373   Id req, *reqp, sup, *supp;
2374   Solvable *s;
2375   Queue iq;
2376   int i;
2377
2378   map_empty(cleandepsmap);
2379   if (!installed || installed->end == installed->start)
2380     return;
2381   map_init(&userinstalled, installed->end - installed->start);
2382   map_init(&im, pool->nsolvables);
2383   map_init(&installedm, pool->nsolvables);
2384   queue_init(&iq);
2385
2386   for (i = 0; i < job->count; i += 2)
2387     {
2388       how = job->elements[i];
2389       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
2390         {
2391           what = job->elements[i + 1];
2392           select = how & SOLVER_SELECTMASK;
2393           FOR_JOB_SELECT(p, pp, select, what)
2394             if (pool->solvables[p].repo == installed)
2395               MAPSET(&userinstalled, p - installed->start);
2396         }
2397     }
2398
2399   /* also add visible patterns to userinstalled for openSUSE */
2400   if (1)
2401     {
2402       Dataiterator di;
2403       dataiterator_init(&di, pool, 0, 0, SOLVABLE_ISVISIBLE, 0, 0);
2404       while (dataiterator_step(&di))
2405         {
2406           Id *dp;
2407           if (di.solvid <= 0)
2408             continue;
2409           s = pool->solvables + di.solvid;
2410           if (!s->requires)
2411             continue;
2412           if (!pool_installable(pool, s))
2413             continue;
2414           if (strncmp(pool_id2str(pool, s->name), "pattern:", 8) != 0)
2415             continue;
2416           dp = s->repo->idarraydata + s->requires;
2417           for (dp = s->repo->idarraydata + s->requires; *dp; dp++)
2418             FOR_PROVIDES(p, pp, *dp)
2419               if (pool->solvables[p].repo == installed)
2420                 {
2421                   if (strncmp(pool_id2str(pool, pool->solvables[p].name), "pattern", 7) != 0)
2422                     continue;
2423                   MAPSET(&userinstalled, p - installed->start);
2424                 }
2425         }
2426       dataiterator_free(&di);
2427     }
2428   if (1)
2429     {
2430       /* all products and their buddies are userinstalled */
2431       for (p = installed->start; p < installed->end; p++)
2432         {
2433           Solvable *s = pool->solvables + p;
2434           if (s->repo != installed)
2435             continue;
2436           if (!strncmp("product:", pool_id2str(pool, s->name), 8))
2437             {
2438               MAPSET(&userinstalled, p - installed->start);
2439               if (pool->nscallback)
2440                 {
2441                   Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, p);
2442                   if (buddy >= installed->start && buddy < installed->end && pool->solvables[buddy].repo == installed)
2443                     MAPSET(&userinstalled, buddy);
2444                 }
2445             }
2446         }
2447     }
2448   
2449   /* add all positive elements (e.g. locks) to "userinstalled" */
2450   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2451     {
2452       r = solv->rules + rid;
2453       if (r->d < 0)
2454         continue;
2455       i = solv->ruletojob.elements[rid - solv->jobrules];
2456       if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2457         continue;
2458       FOR_RULELITERALS(p, jp, r)
2459         if (p > 0 && pool->solvables[p].repo == installed)
2460           MAPSET(&userinstalled, p - installed->start);
2461     }
2462
2463   /* add all cleandeps candidates to iq */
2464   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2465     {
2466       r = solv->rules + rid;
2467       if (r->d < 0)
2468         continue;
2469       if (r->d == 0 && r->p < 0 && r->w2 == 0)
2470         {
2471           p = -r->p;
2472           if (pool->solvables[p].repo != installed)
2473             continue;
2474           MAPCLR(&userinstalled, p - installed->start);
2475           if (unneeded)
2476             continue;
2477           i = solv->ruletojob.elements[rid - solv->jobrules];
2478           how = job->elements[i];
2479           if ((how & (SOLVER_JOBMASK|SOLVER_CLEANDEPS)) == (SOLVER_ERASE|SOLVER_CLEANDEPS))
2480             queue_push(&iq, p);
2481         }
2482       else if (r->p > 0)
2483         {
2484           if (unneeded)
2485             continue;
2486           i = solv->ruletojob.elements[rid - solv->jobrules];
2487           if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
2488             {
2489               /* check if the literals all obsolete some installed package */
2490               Map om;
2491               int iqstart;
2492
2493               /* just one installed literal */
2494               if (r->d == 0 && r->w2 == 0 && pool->solvables[r->p].repo == installed)
2495                 continue;
2496               /* noobs is bad */
2497               if (solv->noobsoletes.size)
2498                 {
2499                   FOR_RULELITERALS(p, jp, r)
2500                     if (MAPTST(&solv->noobsoletes, p))
2501                       break;
2502                   if (p)
2503                     continue;
2504                 }
2505
2506               om.size = 0;
2507               iqstart = iq.count;
2508               FOR_RULELITERALS(p, jp, r)
2509                 {
2510                   if (p < 0)
2511                     {
2512                       queue_truncate(&iq, iqstart);     /* abort */
2513                       break;
2514                     }
2515                   if (pool->solvables[p].repo == installed)
2516                     {
2517                       if (iq.count == iqstart)
2518                         queue_push(&iq, p);
2519                       else
2520                         {
2521                           for (i = iqstart; i < iq.count; i++)
2522                             if (iq.elements[i] == p)
2523                               break;
2524                           queue_truncate(&iq, iqstart);
2525                           if (i < iq.count)
2526                             queue_push(&iq, p);
2527                         }
2528                     }
2529                   else
2530                     intersect_obsoletes(solv, p, &iq, iqstart, &om);
2531                   if (iq.count == iqstart)
2532                     break;
2533                 }
2534               if (om.size)
2535                 map_free(&om);
2536             }
2537         }
2538     }
2539
2540   if (!unneeded)
2541     {
2542       if (solv->cleandeps_updatepkgs)
2543         for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
2544           queue_push(&iq, solv->cleandeps_updatepkgs->elements[i]);
2545     }
2546
2547   if (unneeded)
2548     queue_empty(&iq);   /* just in case... */
2549
2550   /* clear userinstalled bit for the packages we really want to delete/update */
2551   for (i = 0; i < iq.count; i++)
2552     {
2553       p = iq.elements[i];
2554       if (pool->solvables[p].repo != installed)
2555         continue;
2556       MAPCLR(&userinstalled, p - installed->start);
2557     }
2558
2559   for (p = installed->start; p < installed->end; p++)
2560     {
2561       if (pool->solvables[p].repo != installed)
2562         continue;
2563       MAPSET(&installedm, p);
2564       if (unneeded && !MAPTST(&userinstalled, p - installed->start))
2565         continue;
2566       MAPSET(&im, p);
2567     }
2568
2569 #ifdef CLEANDEPSDEBUG
2570   printf("REMOVE PASS\n");
2571 #endif
2572
2573   for (;;)
2574     {
2575       if (!iq.count)
2576         {
2577           if (unneeded)
2578             break;
2579           /* supplements pass */
2580           for (ip = solv->installed->start; ip < solv->installed->end; ip++)
2581             {
2582               if (!MAPTST(&installedm, ip))
2583                 continue;
2584               s = pool->solvables + ip;
2585               if (!s->supplements)
2586                 continue;
2587               if (!MAPTST(&im, ip))
2588                 continue;
2589               if (MAPTST(&userinstalled, ip - installed->start))
2590                 continue;
2591               supp = s->repo->idarraydata + s->supplements;
2592               while ((sup = *supp++) != 0)
2593                 if (dep_possible(solv, sup, &im))
2594                   break;
2595               if (!sup)
2596                 {
2597                   supp = s->repo->idarraydata + s->supplements;
2598                   while ((sup = *supp++) != 0)
2599                     if (dep_possible(solv, sup, &installedm))
2600                       {
2601                         /* no longer supplemented, also erase */
2602                         int iqcount = iq.count;
2603                         /* pin packages, see comment above dep_pkgcheck */
2604                         dep_pkgcheck(solv, sup, &im, &iq);
2605                         for (i = iqcount; i < iq.count; i++)
2606                           {
2607                             Id pqp = iq.elements[i];
2608                             if (pool->solvables[pqp].repo == installed)
2609                               MAPSET(&userinstalled, pqp - installed->start);
2610                           }
2611                         queue_truncate(&iq, iqcount);
2612 #ifdef CLEANDEPSDEBUG
2613                         printf("%s supplemented\n", pool_solvid2str(pool, ip));
2614 #endif
2615                         queue_push(&iq, ip);
2616                       }
2617                 }
2618             }
2619           if (!iq.count)
2620             break;
2621         }
2622       ip = queue_shift(&iq);
2623       s = pool->solvables + ip;
2624       if (!MAPTST(&im, ip))
2625         continue;
2626       if (!MAPTST(&installedm, ip))
2627         continue;
2628       if (s->repo == installed && MAPTST(&userinstalled, ip - installed->start))
2629         continue;
2630       MAPCLR(&im, ip);
2631 #ifdef CLEANDEPSDEBUG
2632       printf("removing %s\n", pool_solvable2str(pool, s));
2633 #endif
2634       if (s->requires)
2635         {
2636           reqp = s->repo->idarraydata + s->requires;
2637           while ((req = *reqp++) != 0)
2638             {
2639               if (req == SOLVABLE_PREREQMARKER)
2640                 continue;
2641 #if 0
2642               /* count number of installed packages that match */
2643               count = 0;
2644               FOR_PROVIDES(p, pp, req)
2645                 if (MAPTST(&installedm, p))
2646                   count++;
2647               if (count > 1)
2648                 continue;
2649 #endif
2650               FOR_PROVIDES(p, pp, req)
2651                 {
2652                   if (MAPTST(&im, p))
2653                     {
2654 #ifdef CLEANDEPSDEBUG
2655                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
2656 #endif
2657                       queue_push(&iq, p);
2658                     }
2659                 }
2660             }
2661         }
2662       if (s->recommends)
2663         {
2664           reqp = s->repo->idarraydata + s->recommends;
2665           while ((req = *reqp++) != 0)
2666             {
2667 #if 0
2668               count = 0;
2669               FOR_PROVIDES(p, pp, req)
2670                 if (MAPTST(&installedm, p))
2671                   count++;
2672               if (count > 1)
2673                 continue;
2674 #endif
2675               FOR_PROVIDES(p, pp, req)
2676                 {
2677                   if (MAPTST(&im, p))
2678                     {
2679 #ifdef CLEANDEPSDEBUG
2680                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
2681 #endif
2682                       queue_push(&iq, p);
2683                     }
2684                 }
2685             }
2686         }
2687     }
2688
2689   /* turn userinstalled into remove set for pruning */
2690   map_empty(&userinstalled);
2691   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2692     {
2693       r = solv->rules + rid;
2694       if (r->p >= 0 || r->d != 0 || r->w2 != 0)
2695         continue;       /* disabled or not erase */
2696       p = -r->p;
2697       MAPCLR(&im, p);
2698       if (pool->solvables[p].repo == installed)
2699         MAPSET(&userinstalled, p - installed->start);
2700     }
2701   for (p = installed->start; p < installed->end; p++)
2702     if (MAPTST(&im, p))
2703       queue_push(&iq, p);
2704   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
2705     {
2706       r = solv->rules + rid;
2707       if (r->d < 0)
2708         continue;
2709       FOR_RULELITERALS(p, jp, r)
2710         if (p > 0)
2711           queue_push(&iq, p);
2712     }
2713   /* also put directly addressed packages on the install queue
2714    * so we can mark patterns as installed */
2715   for (i = 0; i < job->count; i += 2)
2716     {
2717       how = job->elements[i];
2718       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
2719         {
2720           what = job->elements[i + 1];
2721           select = how & SOLVER_SELECTMASK;
2722           if (select == SOLVER_SOLVABLE && pool->solvables[what].repo != installed)
2723             queue_push(&iq, what);
2724         }
2725     }
2726
2727 #ifdef CLEANDEPSDEBUG
2728   printf("ADDBACK PASS\n");
2729 #endif
2730   for (;;)
2731     {
2732       if (!iq.count)
2733         {
2734           /* supplements pass */
2735           for (ip = installed->start; ip < installed->end; ip++)
2736             {
2737               if (!MAPTST(&installedm, ip))
2738                 continue;
2739               if (MAPTST(&userinstalled, ip - installed->start))
2740                 continue;
2741               s = pool->solvables + ip;
2742               if (!s->supplements)
2743                 continue;
2744               if (MAPTST(&im, ip))
2745                 continue;
2746               supp = s->repo->idarraydata + s->supplements;
2747               while ((sup = *supp++) != 0)
2748                 if (dep_possible(solv, sup, &im))
2749                   break;
2750               if (sup)
2751                 {
2752 #ifdef CLEANDEPSDEBUG
2753                   printf("%s supplemented\n", pool_solvid2str(pool, ip));
2754 #endif
2755                   MAPSET(&im, ip);
2756                   queue_push(&iq, ip);
2757                 }
2758             }
2759           if (!iq.count)
2760             break;
2761         }
2762       ip = queue_shift(&iq);
2763       s = pool->solvables + ip;
2764 #ifdef CLEANDEPSDEBUG
2765       printf("adding back %s\n", pool_solvable2str(pool, s));
2766 #endif
2767       if (s->requires)
2768         {
2769           reqp = s->repo->idarraydata + s->requires;
2770           while ((req = *reqp++) != 0)
2771             {
2772               FOR_PROVIDES(p, pp, req)
2773                 {
2774                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
2775                     {
2776                       if (p == ip)
2777                         continue;
2778                       if (MAPTST(&userinstalled, p - installed->start))
2779                         continue;
2780 #ifdef CLEANDEPSDEBUG
2781                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
2782 #endif
2783                       MAPSET(&im, p);
2784                       queue_push(&iq, p);
2785                     }
2786                 }
2787             }
2788         }
2789       if (s->recommends)
2790         {
2791           reqp = s->repo->idarraydata + s->recommends;
2792           while ((req = *reqp++) != 0)
2793             {
2794               FOR_PROVIDES(p, pp, req)
2795                 {
2796                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
2797                     {
2798                       if (p == ip)
2799                         continue;
2800                       if (MAPTST(&userinstalled, p - installed->start))
2801                         continue;
2802 #ifdef CLEANDEPSDEBUG
2803                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
2804 #endif
2805                       MAPSET(&im, p);
2806                       queue_push(&iq, p);
2807                     }
2808                 }
2809             }
2810         }
2811     }
2812     
2813   queue_free(&iq);
2814   if (solv->cleandeps_updatepkgs)
2815     for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
2816       MAPSET(&im, solv->cleandeps_updatepkgs->elements[i]);
2817   if (solv->cleandeps_mistakes)
2818     for (i = 0; i < solv->cleandeps_mistakes->count; i++)
2819       MAPSET(&im, solv->cleandeps_mistakes->elements[i]);
2820   for (p = installed->start; p < installed->end; p++)
2821     {
2822       if (pool->solvables[p].repo != installed)
2823         continue;
2824       if (!MAPTST(&im, p))
2825         MAPSET(cleandepsmap, p - installed->start);
2826     }
2827   map_free(&im);
2828   map_free(&installedm);
2829   map_free(&userinstalled);
2830 }
2831
2832
2833 struct trj_data {
2834   Queue *edges;
2835   Id *low;
2836   Id idx;
2837   Id nstack;
2838   Id firstidx;
2839 };
2840
2841 /* Tarjan's SCC algorithm, slightly modifed */
2842 static void
2843 trj_visit(struct trj_data *trj, Id node)
2844 {
2845   Id *low = trj->low;
2846   Queue *edges = trj->edges;
2847   Id nnode, myidx, stackstart;
2848   int i;
2849
2850   low[node] = myidx = trj->idx++;
2851   low[(stackstart = trj->nstack++)] = node;
2852   for (i = edges->elements[node]; (nnode = edges->elements[i]) != 0; i++)
2853     {
2854       Id l = low[nnode];
2855       if (!l)
2856         {
2857           if (!edges->elements[edges->elements[nnode]])
2858             {
2859               trj->idx++;
2860               low[nnode] = -1;
2861               continue;
2862             }
2863           trj_visit(trj, nnode);
2864           l = low[nnode];
2865         }
2866       if (l < 0)
2867         continue;
2868       if (l < trj->firstidx)
2869         {
2870           int k;
2871           for (k = l; low[low[k]] == l; k++)
2872             low[low[k]] = -1;
2873         }
2874       else if (l < low[node])
2875         low[node] = l;
2876     }
2877   if (low[node] == myidx)
2878     {
2879       if (myidx != trj->firstidx)
2880         myidx = -1;
2881       for (i = stackstart; i < trj->nstack; i++)
2882         low[low[i]] = myidx;
2883       trj->nstack = stackstart;
2884     }
2885 }
2886
2887
2888 void
2889 solver_get_unneeded(Solver *solv, Queue *unneededq, int filtered)
2890 {
2891   Repo *installed = solv->installed;
2892   int i;
2893   Map cleandepsmap;
2894
2895   queue_empty(unneededq);
2896   if (!installed || installed->end == installed->start)
2897     return;
2898
2899   map_init(&cleandepsmap, installed->end - installed->start);
2900   solver_createcleandepsmap(solv, &cleandepsmap, 1);
2901   for (i = installed->start; i < installed->end; i++)
2902     if (MAPTST(&cleandepsmap, i - installed->start))
2903       queue_push(unneededq, i);
2904
2905   if (filtered && unneededq->count > 1)
2906     {
2907       Pool *pool = solv->pool;
2908       Queue edges;
2909       Id *nrequires;
2910       Map installedm;
2911       int j, pass, count = unneededq->count;
2912       Id *low;
2913
2914       map_init(&installedm, pool->nsolvables);
2915       for (i = installed->start; i < installed->end; i++)
2916         if (pool->solvables[i].repo == installed)
2917           MAPSET(&installedm, i);
2918
2919       nrequires = solv_calloc(count, sizeof(Id));
2920       queue_init(&edges);
2921       /* pre-size */
2922       queue_insertn(&edges, 0, count * 4 + 10);
2923       queue_empty(&edges);
2924
2925       /*
2926        * Go through the solvables in the nodes queue and create edges for
2927        * all requires/recommends/supplements between the nodes.
2928        * The edges are stored in the edges queue, we add 1 to the node
2929        * index so that nodes in the edges queue are != 0 and we can
2930        * terminate the edge list with 0.
2931        * Thus for node element 5, the edges are stored starting at
2932        * edges.elements[6] and are 0-terminated.
2933        */
2934       /* leave first element zero to make things easier */
2935       /* also add trailing zero */
2936       queue_insertn(&edges, 0, 1 + count + 1);
2937
2938       /* first requires and recommends */
2939       for (i = 0; i < count; i++)
2940         {
2941           Solvable *s = pool->solvables + unneededq->elements[i];
2942           edges.elements[i + 1] = edges.count;
2943           for (pass = 0; pass < 2; pass++)
2944             {
2945               int num = 0;
2946               unsigned int off = pass == 0 ? s->requires : s->recommends;
2947               Id p, pp, *dp;
2948               if (off)
2949                 for (dp = s->repo->idarraydata + off; *dp; dp++)
2950                   FOR_PROVIDES(p, pp, *dp)
2951                     {
2952                       Solvable *sp = pool->solvables + p;
2953                       if (s == sp || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
2954                         continue;
2955                       for (j = 0; j < count; j++)
2956                         if (p == unneededq->elements[j])
2957                           break;
2958                       if (j == count)
2959                         continue;
2960                       if (num && edges.elements[edges.count - 1] == j + 1)
2961                         continue;
2962                       queue_push(&edges, j + 1);
2963                       num++;
2964                     }
2965                 if (pass == 0)
2966                   nrequires[i] = num;
2967             }
2968           queue_push(&edges, 0);
2969         }
2970 #if 0
2971       printf("requires + recommends\n");
2972       for (i = 0; i < count; i++)
2973         {
2974           int j;
2975           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
2976           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
2977             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
2978         }
2979 #endif
2980
2981       /* then add supplements */
2982       for (i = 0; i < count; i++)
2983         {
2984           Solvable *s = pool->solvables + unneededq->elements[i];
2985           if (s->supplements)
2986             {
2987               Id *dp;
2988               int k;
2989               for (dp = s->repo->idarraydata + s->supplements; *dp; dp++)
2990                 if (dep_possible(solv, *dp, &installedm))
2991                   {
2992                     Queue iq;
2993                     Id iqbuf[16];
2994                     queue_init_buffer(&iq, iqbuf, sizeof(iqbuf)/sizeof(*iqbuf));
2995                     dep_pkgcheck(solv, *dp, 0, &iq);
2996                     for (k = 0; k < iq.count; k++)
2997                       {
2998                         Id p = iq.elements[k];
2999                         Solvable *sp = pool->solvables + p;
3000                         if (p == unneededq->elements[i] || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3001                           continue;
3002                         for (j = 0; j < count; j++)
3003                           if (p == unneededq->elements[j])
3004                             break;
3005                         /* now add edge from j + 1 to i + 1 */
3006                         queue_insert(&edges, edges.elements[j + 1] + nrequires[j], i + 1);
3007                         /* addapt following edge pointers */
3008                         for (k = j + 2; k < count + 2; k++)
3009                           edges.elements[k]++;
3010                       }
3011                     queue_free(&iq);
3012                   }
3013             }
3014         }
3015 #if 0
3016       /* print result */
3017       printf("+ supplements\n");
3018       for (i = 0; i < count; i++)
3019         {
3020           int j;
3021           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3022           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3023             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3024     }
3025 #endif
3026       map_free(&installedm);
3027
3028       /* now run SCC algo two times, first with requires+recommends+supplements,
3029        * then again without the requires. We run it the second time to get rid
3030        * of packages that got dragged in via recommends/supplements */
3031       /*
3032        * low will contain the result of the SCC search.
3033        * it must be of at least size 2 * (count + 1) and
3034        * must be zero initialized.
3035        * The layout is:
3036        *    0  low low ... low stack stack ...stack 0
3037        *            count              count
3038        */
3039       low = solv_calloc(count + 1, 2 * sizeof(Id));
3040       for (pass = 0; pass < 2; pass++)
3041         {
3042           struct trj_data trj;
3043           if (pass)
3044             {
3045               memset(low, 0, (count + 1) * (2 * sizeof(Id)));
3046               for (i = 0; i < count; i++)
3047                 {
3048                   edges.elements[i + 1] += nrequires[i];
3049                   if (!unneededq->elements[i])
3050                     low[i + 1] = -1;    /* ignore this node */
3051                 }
3052             }
3053           trj.edges = &edges;
3054           trj.low = low;
3055           trj.idx = count + 1;  /* stack starts here */
3056           for (i = 1; i <= count; i++)
3057             {
3058               if (low[i])
3059                 continue;
3060               if (edges.elements[edges.elements[i]])
3061                 {
3062                   trj.firstidx = trj.nstack = trj.idx;
3063                   trj_visit(&trj, i);
3064                 }
3065               else
3066                 {
3067                   Id myidx = trj.idx++;
3068                   low[i] = myidx;
3069                   low[myidx] = i;
3070                 }
3071             }
3072           /* prune packages */
3073           for (i = 0; i < count; i++)
3074             if (low[i + 1] <= 0)
3075               unneededq->elements[i] = 0;
3076         }
3077       solv_free(low);
3078       solv_free(nrequires);
3079       queue_free(&edges);
3080
3081       /* finally remove all pruned entries from unneededq */
3082       for (i = j = 0; i < count; i++)
3083         if (unneededq->elements[i])
3084           unneededq->elements[j++] = unneededq->elements[i];
3085       queue_truncate(unneededq, j);
3086     }
3087   map_free(&cleandepsmap);
3088 }
3089
3090 /* EOF */