src/rules.c

   1 /*
   2  * Copyright (c) 2007-2009, Novell Inc.
   3  *
   4  * This program is licensed under the BSD license, read LICENSE.BSD
   5  * for further information
   6  */
   7
   8 /*
   9  * rules.c
  10  *
  11  * SAT based dependency solver
  12  */
  13
  14 #include <stdio.h>
  15 #include <stdlib.h>
  16 #include <unistd.h>
  17 #include <string.h>
  18 #include <assert.h>
  19
  20 #include "solver.h"
  21 #include "solver_private.h"
  22 #include "bitmap.h"
  23 #include "pool.h"
  24 #include "poolarch.h"
  25 #include "util.h"
  26 #include "evr.h"
  27 #include "policy.h"
  28 #include "solverdebug.h"
  29
  30 #define RULES_BLOCK 63
  31
  32 static void addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep);
  33 static void solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded);
  34
  35 /*-------------------------------------------------------------------
  36  * Check if dependency is possible
  37  *
  38  * mirrors solver_dep_fulfilled but uses map m instead of the decisionmap.
  39  * used in solver_addrpmrulesforweak and solver_createcleandepsmap.
  40  */
  41
  42 static inline int
  43 dep_possible(Solver *solv, Id dep, Map *m)
  44 {
  45   Pool *pool = solv->pool;
  46   Id p, pp;
  47
  48   if (ISRELDEP(dep))
  49     {
  50       Reldep *rd = GETRELDEP(pool, dep);
  51       if (rd->flags >= 8)
  52         {
  53           if (rd->flags == REL_AND)
  54             {
  55               if (!dep_possible(solv, rd->name, m))
  56                 return 0;
  57               return dep_possible(solv, rd->evr, m);
  58             }
  59           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
  60             return solver_splitprovides(solv, rd->evr);
  61           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
  62             return solver_dep_installed(solv, rd->evr);
  63         }
  64     }
  65   FOR_PROVIDES(p, pp, dep)
  66     {
  67       if (MAPTST(m, p))
  68         return 1;
  69     }
  70   return 0;
  71 }
  72
  73 /********************************************************************
  74  *
  75  * Rule handling
  76  *
  77  * - unify rules, remove duplicates
  78  */
  79
  80 /*-------------------------------------------------------------------
  81  *
  82  * compare rules for unification sort
  83  *
  84  */
  85
  86 static int
  87 unifyrules_sortcmp(const void *ap, const void *bp, void *dp)
  88 {
  89   Pool *pool = dp;
  90   Rule *a = (Rule *)ap;
  91   Rule *b = (Rule *)bp;
  92   Id *ad, *bd;
  93   int x;
  94
  95   x = a->p - b->p;
  96   if (x)
  97     return x;                          /* p differs */
  98
  99   /* identical p */
 100   if (a->d == 0 && b->d == 0)
 101     return a->w2 - b->w2;              /* assertion: return w2 diff */
 102
 103   if (a->d == 0)                       /* a is assertion, b not */
 104     {
 105       x = a->w2 - pool->whatprovidesdata[b->d];
 106       return x ? x : -1;
 107     }
 108
 109   if (b->d == 0)                       /* b is assertion, a not */
 110     {
 111       x = pool->whatprovidesdata[a->d] - b->w2;
 112       return x ? x : 1;
 113     }
 114
 115   /* compare whatprovidesdata */
 116   ad = pool->whatprovidesdata + a->d;
 117   bd = pool->whatprovidesdata + b->d;
 118   while (*bd)
 119     if ((x = *ad++ - *bd++) != 0)
 120       return x;
 121   return *ad;
 122 }
 123
 124 int
 125 solver_rulecmp(Solver *solv, Rule *r1, Rule *r2)
 126 {
 127   return unifyrules_sortcmp(r1, r2, solv->pool);
 128 }
 129
 130
 131 /*-------------------------------------------------------------------
 132  *
 133  * unify rules
 134  * go over all rules and remove duplicates
 135  */
 136
 137 void
 138 solver_unifyrules(Solver *solv)
 139 {
 140   Pool *pool = solv->pool;
 141   int i, j;
 142   Rule *ir, *jr;
 143
 144   if (solv->nrules <= 2)               /* nothing to unify */
 145     return;
 146
 147   /* sort rules first */
 148   solv_sort(solv->rules + 1, solv->nrules - 1, sizeof(Rule), unifyrules_sortcmp, solv->pool);
 149
 150   /* prune rules
 151    * i = unpruned
 152    * j = pruned
 153    */
 154   jr = 0;
 155   for (i = j = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
 156     {
 157       if (jr && !unifyrules_sortcmp(ir, jr, pool))
 158         continue;                      /* prune! */
 159       jr = solv->rules + j++;          /* keep! */
 160       if (ir != jr)
 161         *jr = *ir;
 162     }
 163
 164   /* reduced count from nrules to j rules */
 165   POOL_DEBUG(SOLV_DEBUG_STATS, "pruned rules from %d to %d\n", solv->nrules, j);
 166
 167   /* adapt rule buffer */
 168   solv->nrules = j;
 169   solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
 170
 171   /*
 172    * debug: log rule statistics
 173    */
 174   IF_POOLDEBUG (SOLV_DEBUG_STATS)
 175     {
 176       int binr = 0;
 177       int lits = 0;
 178       Id *dp;
 179       Rule *r;
 180
 181       for (i = 1; i < solv->nrules; i++)
 182         {
 183           r = solv->rules + i;
 184           if (r->d == 0)
 185             binr++;
 186           else
 187             {
 188               dp = solv->pool->whatprovidesdata + r->d;
 189               while (*dp++)
 190                 lits++;
 191             }
 192         }
 193       POOL_DEBUG(SOLV_DEBUG_STATS, "  binary: %d\n", binr);
 194       POOL_DEBUG(SOLV_DEBUG_STATS, "  normal: %d, %d literals\n", solv->nrules - 1 - binr, lits);
 195     }
 196 }
 197
 198 #if 0
 199
 200 /*
 201  * hash rule
 202  */
 203
 204 static Hashval
 205 hashrule(Solver *solv, Id p, Id d, int n)
 206 {
 207   unsigned int x = (unsigned int)p;
 208   int *dp;
 209
 210   if (n <= 1)
 211     return (x * 37) ^ (unsigned int)d;
 212   dp = solv->pool->whatprovidesdata + d;
 213   while (*dp)
 214     x = (x * 37) ^ (unsigned int)*dp++;
 215   return x;
 216 }
 217 #endif
 218
 219
 220 /*-------------------------------------------------------------------
 221  *
 222  */
 223
 224 /*
 225  * add rule
 226  *  p = direct literal; always < 0 for installed rpm rules
 227  *  d, if < 0 direct literal, if > 0 offset into whatprovides, if == 0 rule is assertion (look at p only)
 228  *
 229  *
 230  * A requires b, b provided by B1,B2,B3 => (-A|B1|B2|B3)
 231  *
 232  * p < 0 : pkg id of A
 233  * d > 0 : Offset in whatprovidesdata (list of providers of b)
 234  *
 235  * A conflicts b, b provided by B1,B2,B3 => (-A|-B1), (-A|-B2), (-A|-B3)
 236  * p < 0 : pkg id of A
 237  * d < 0 : Id of solvable (e.g. B1)
 238  *
 239  * d == 0: unary rule, assertion => (A) or (-A)
 240  *
 241  *   Install:    p > 0, d = 0   (A)             user requested install
 242  *   Remove:     p < 0, d = 0   (-A)            user requested remove (also: uninstallable)
 243  *   Requires:   p < 0, d > 0   (-A|B1|B2|...)  d: <list of providers for requirement of p>
 244  *   Updates:    p > 0, d > 0   (A|B1|B2|...)   d: <list of updates for solvable p>
 245  *   Conflicts:  p < 0, d < 0   (-A|-B)         either p (conflict issuer) or d (conflict provider) (binary rule)
 246  *                                              also used for obsoletes
 247  *   ?:          p > 0, d < 0   (A|-B)
 248  *   No-op ?:    p = 0, d = 0   (null)          (used as policy rule placeholder)
 249  *
 250  *   resulting watches:
 251  *   ------------------
 252  *   Direct assertion (no watch needed) --> d = 0, w1 = p, w2 = 0
 253  *   Binary rule: p = first literal, d = 0, w2 = second literal, w1 = p
 254  *   every other : w1 = p, w2 = whatprovidesdata[d];
 255  *   Disabled rule: w1 = 0
 256  *
 257  *   always returns a rule for non-rpm rules
 258  */
 259
 260 Rule *
 261 solver_addrule(Solver *solv, Id p, Id d)
 262 {
 263   Pool *pool = solv->pool;
 264   Rule *r = 0;
 265   Id *dp = 0;
 266
 267   int n = 0;                           /* number of literals in rule - 1
 268                                           0 = direct assertion (single literal)
 269                                           1 = binary rule
 270                                           >1 =
 271                                         */
 272
 273   /* it often happenes that requires lead to adding the same rpm rule
 274    * multiple times, so we prune those duplicates right away to make
 275    * the work for unifyrules a bit easier */
 276
 277   if (!solv->rpmrules_end)              /* we add rpm rules */
 278     {
 279       r = solv->rules + solv->nrules - 1;       /* get the last added rule */
 280       if (r->p == p && r->d == d && (d != 0 || !r->w2))
 281         return r;
 282     }
 283
 284     /*
 285      * compute number of literals (n) in rule
 286      */
 287
 288   if (d < 0)
 289     {
 290       /* always a binary rule */
 291       if (p == d)
 292         return 0;                      /* ignore self conflict */
 293       n = 1;
 294     }
 295   else if (d > 0)
 296     {
 297       for (dp = pool->whatprovidesdata + d; *dp; dp++, n++)
 298         if (*dp == -p)
 299           return 0;                     /* rule is self-fulfilling */
 300
 301       if (n == 1)                       /* convert to binary rule */
 302         d = dp[-1];
 303     }
 304
 305   if (n == 1 && p > d && !solv->rpmrules_end)
 306     {
 307       /* smallest literal first so we can find dups */
 308       n = p; p = d; d = n;             /* p <-> d */
 309       n = 1;                           /* re-set n, was used as temp var */
 310     }
 311
 312   /*
 313    * check for duplicate
 314    */
 315
 316   /* check if the last added rule (r) is exactly the same as what we're looking for. */
 317   if (r && n == 1 && !r->d && r->p == p && r->w2 == d)
 318     return r;  /* binary rule */
 319
 320     /* have n-ary rule with same first literal, check other literals */
 321   if (r && n > 1 && r->d && r->p == p)
 322     {
 323       /* Rule where d is an offset in whatprovidesdata */
 324       Id *dp2;
 325       if (d == r->d)
 326         return r;
 327       dp2 = pool->whatprovidesdata + r->d;
 328       for (dp = pool->whatprovidesdata + d; *dp; dp++, dp2++)
 329         if (*dp != *dp2)
 330           break;
 331       if (*dp == *dp2)
 332         return r;
 333    }
 334
 335   /*
 336    * allocate new rule
 337    */
 338
 339   /* extend rule buffer */
 340   solv->rules = solv_extend(solv->rules, solv->nrules, 1, sizeof(Rule), RULES_BLOCK);
 341   r = solv->rules + solv->nrules++;    /* point to rule space */
 342
 343     /*
 344      * r = new rule
 345      */
 346
 347   r->p = p;
 348   if (n == 0)
 349     {
 350       /* direct assertion, no watch needed */
 351       r->d = 0;
 352       r->w1 = p;
 353       r->w2 = 0;
 354     }
 355   else if (n == 1)
 356     {
 357       /* binary rule */
 358       r->d = 0;
 359       r->w1 = p;
 360       r->w2 = d;
 361     }
 362   else
 363     {
 364       r->d = d;
 365       r->w1 = p;
 366       r->w2 = pool->whatprovidesdata[d];
 367     }
 368   r->n1 = 0;
 369   r->n2 = 0;
 370
 371   IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 372     {
 373       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "  Add rule: ");
 374       solver_printrule(solv, SOLV_DEBUG_RULE_CREATION, r);
 375     }
 376
 377   return r;
 378 }
 379
 380 void
 381 solver_shrinkrules(Solver *solv, int nrules)
 382 {
 383   solv->nrules = nrules;
 384   solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
 385 }
 386
 387 /******************************************************************************
 388  ***
 389  *** rpm rule part: create rules representing the package dependencies
 390  ***
 391  ***/
 392
 393 /*
 394  *  special multiversion patch conflict handling:
 395  *  a patch conflict is also satisfied if some other
 396  *  version with the same name/arch that doesn't conflict
 397  *  gets installed. The generated rule is thus:
 398  *  -patch|-cpack|opack1|opack2|...
 399  */
 400 static Id
 401 makemultiversionconflict(Solver *solv, Id n, Id con)
 402 {
 403   Pool *pool = solv->pool;
 404   Solvable *s, *sn;
 405   Queue q;
 406   Id p, pp, qbuf[64];
 407
 408   sn = pool->solvables + n;
 409   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
 410   queue_push(&q, -n);
 411   FOR_PROVIDES(p, pp, sn->name)
 412     {
 413       s = pool->solvables + p;
 414       if (s->name != sn->name || s->arch != sn->arch)
 415         continue;
 416       if (!MAPTST(&solv->multiversion, p))
 417         continue;
 418       if (pool_match_nevr(pool, pool->solvables + p, con))
 419         continue;
 420       /* here we have a multiversion solvable that doesn't conflict */
 421       /* thus we're not in conflict if it is installed */
 422       queue_push(&q, p);
 423     }
 424   if (q.count == 1)
 425     return -n;  /* no other package found, generate normal conflict */
 426   return pool_queuetowhatprovides(pool, &q);
 427 }
 428
 429 static inline void
 430 addrpmrule(Solver *solv, Id p, Id d, int type, Id dep)
 431 {
 432   if (!solv->ruleinfoq)
 433     solver_addrule(solv, p, d);
 434   else
 435     addrpmruleinfo(solv, p, d, type, dep);
 436 }
 437
 438 /*-------------------------------------------------------------------
 439  *
 440  * add (install) rules for solvable
 441  *
 442  * s: Solvable for which to add rules
 443  * m: m[s] = 1 for solvables which have rules, prevent rule duplication
 444  *
 445  * Algorithm: 'visit all nodes of a graph'. The graph nodes are
 446  *  solvables, the edges their dependencies.
 447  *  Starting from an installed solvable, this will create all rules
 448  *  representing the graph created by the solvables dependencies.
 449  *
 450  * for unfulfilled requirements, conflicts, obsoletes,....
 451  * add a negative assertion for solvables that are not installable
 452  *
 453  * It will also create rules for all solvables referenced by 's'
 454  *  i.e. descend to all providers of requirements of 's'
 455  *
 456  */
 457
 458 void
 459 solver_addrpmrulesforsolvable(Solver *solv, Solvable *s, Map *m)
 460 {
 461   Pool *pool = solv->pool;
 462   Repo *installed = solv->installed;
 463
 464   /* 'work' queue. keeps Ids of solvables we still have to work on.
 465      And buffer for it. */
 466   Queue workq;
 467   Id workqbuf[64];
 468
 469   int i;
 470     /* if to add rules for broken deps ('rpm -V' functionality)
 471      * 0 = yes, 1 = no
 472      */
 473   int dontfix;
 474     /* Id var and pointer for each dependency
 475      * (not used in parallel)
 476      */
 477   Id req, *reqp;
 478   Id con, *conp;
 479   Id obs, *obsp;
 480   Id rec, *recp;
 481   Id sug, *sugp;
 482   Id p, pp;             /* whatprovides loops */
 483   Id *dp;               /* ptr to 'whatprovides' */
 484   Id n;                 /* Id for current solvable 's' */
 485
 486   queue_init_buffer(&workq, workqbuf, sizeof(workqbuf)/sizeof(*workqbuf));
 487   queue_push(&workq, s - pool->solvables);      /* push solvable Id to work queue */
 488
 489   /* loop until there's no more work left */
 490   while (workq.count)
 491     {
 492       /*
 493        * n: Id of solvable
 494        * s: Pointer to solvable
 495        */
 496
 497       n = queue_shift(&workq);          /* 'pop' next solvable to work on from queue */
 498       if (m)
 499         {
 500           if (MAPTST(m, n))             /* continue if already visited */
 501             continue;
 502           MAPSET(m, n);                 /* mark as visited */
 503         }
 504
 505       s = pool->solvables + n;          /* s = Solvable in question */
 506
 507       dontfix = 0;
 508       if (installed                     /* Installed system available */
 509           && s->repo == installed       /* solvable is installed */
 510           && !solv->fixmap_all          /* NOT repair errors in rpm dependency graph */
 511           && !(solv->fixmap.size && MAPTST(&solv->fixmap, n - installed->start)))
 512         {
 513           dontfix = 1;                  /* dont care about broken rpm deps */
 514         }
 515
 516       if (!dontfix)
 517         {
 518           if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC
 519                 ? pool_disabled_solvable(pool, s)
 520                 : !pool_installable(pool, s))
 521             {
 522               POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables));
 523               addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOT_INSTALLABLE, 0);
 524             }
 525         }
 526
 527       /* yet another SUSE hack, sigh */
 528       if (pool->nscallback && !strncmp("product:", pool_id2str(pool, s->name), 8))
 529         {
 530           Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, n);
 531           if (buddy > 0 && buddy != SYSTEMSOLVABLE && buddy != n && buddy < pool->nsolvables)
 532             {
 533               addrpmrule(solv, n, -buddy, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + n));
 534               addrpmrule(solv, buddy, -n, SOLVER_RULE_RPM_PACKAGE_REQUIRES, solvable_selfprovidedep(pool->solvables + buddy));
 535               if (m && !MAPTST(m, buddy))
 536                 queue_push(&workq, buddy);
 537             }
 538         }
 539
 540       /*-----------------------------------------
 541        * check requires of s
 542        */
 543
 544       if (s->requires)
 545         {
 546           reqp = s->repo->idarraydata + s->requires;
 547           while ((req = *reqp++) != 0)            /* go through all requires */
 548             {
 549               if (req == SOLVABLE_PREREQMARKER)   /* skip the marker */
 550                 continue;
 551
 552               /* find list of solvables providing 'req' */
 553               dp = pool_whatprovides_ptr(pool, req);
 554
 555               if (*dp == SYSTEMSOLVABLE)          /* always installed */
 556                 continue;
 557
 558               if (dontfix)
 559                 {
 560                   /* the strategy here is to not insist on dependencies
 561                    * that are already broken. so if we find one provider
 562                    * that was already installed, we know that the
 563                    * dependency was not broken before so we enforce it */
 564
 565                   /* check if any of the providers for 'req' is installed */
 566                   for (i = 0; (p = dp[i]) != 0; i++)
 567                     {
 568                       if (pool->solvables[p].repo == installed)
 569                         break;          /* provider was installed */
 570                     }
 571                   /* didn't find an installed provider: previously broken dependency */
 572                   if (!p)
 573                     {
 574                       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken requires %s of installed package %s\n", pool_dep2str(pool, req), pool_solvable2str(pool, s));
 575                       continue;
 576                     }
 577                 }
 578
 579               if (!*dp)
 580                 {
 581                   /* nothing provides req! */
 582                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvable2str(pool, s), (Id)(s - pool->solvables), pool_dep2str(pool, req));
 583                   addrpmrule(solv, -n, 0, SOLVER_RULE_RPM_NOTHING_PROVIDES_DEP, req);
 584                   continue;
 585                 }
 586
 587               IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 588                 {
 589                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION,"  %s requires %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
 590                   for (i = 0; dp[i]; i++)
 591                     POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "   provided by %s\n", pool_solvid2str(pool, dp[i]));
 592                 }
 593
 594               /* add 'requires' dependency */
 595               /* rule: (-requestor|provider1|provider2|...|providerN) */
 596               addrpmrule(solv, -n, dp - pool->whatprovidesdata, SOLVER_RULE_RPM_PACKAGE_REQUIRES, req);
 597
 598               /* descend the dependency tree
 599                  push all non-visited providers on the work queue */
 600               if (m)
 601                 {
 602                   for (; *dp; dp++)
 603                     {
 604                       if (!MAPTST(m, *dp))
 605                         queue_push(&workq, *dp);
 606                     }
 607                 }
 608
 609             } /* while, requirements of n */
 610
 611         } /* if, requirements */
 612
 613       /* that's all we check for src packages */
 614       if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC)
 615         continue;
 616
 617       /*-----------------------------------------
 618        * check conflicts of s
 619        */
 620
 621       if (s->conflicts)
 622         {
 623           int ispatch = 0;
 624
 625           /* we treat conflicts in patches a bit differen:
 626            * - nevr matching
 627            * - multiversion handling
 628            * XXX: we should really handle this different, looking
 629            * at the name is a bad hack
 630            */
 631           if (!strncmp("patch:", pool_id2str(pool, s->name), 6))
 632             ispatch = 1;
 633           conp = s->repo->idarraydata + s->conflicts;
 634           /* foreach conflicts of 's' */
 635           while ((con = *conp++) != 0)
 636             {
 637               /* foreach providers of a conflict of 's' */
 638               FOR_PROVIDES(p, pp, con)
 639                 {
 640                   if (ispatch && !pool_match_nevr(pool, pool->solvables + p, con))
 641                     continue;
 642                   /* dontfix: dont care about conflicts with already installed packs */
 643                   if (dontfix && pool->solvables[p].repo == installed)
 644                     continue;
 645                   /* p == n: self conflict */
 646                   if (p == n && pool->forbidselfconflicts)
 647                     {
 648                       if (ISRELDEP(con))
 649                         {
 650                           Reldep *rd = GETRELDEP(pool, con);
 651                           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_OTHERPROVIDERS)
 652                             continue;
 653                         }
 654                       p = 0;    /* make it a negative assertion, aka 'uninstallable' */
 655                     }
 656                   if (p && ispatch && solv->multiversion.size && MAPTST(&solv->multiversion, p) && ISRELDEP(con))
 657                     {
 658                       /* our patch conflicts with a multiversion package */
 659                       p = -makemultiversionconflict(solv, p, con);
 660                     }
 661                  /* rule: -n|-p: either solvable _or_ provider of conflict */
 662                   addrpmrule(solv, -n, -p, p ? SOLVER_RULE_RPM_PACKAGE_CONFLICT : SOLVER_RULE_RPM_SELF_CONFLICT, con);
 663                 }
 664             }
 665         }
 666
 667       /*-----------------------------------------
 668        * check obsoletes and implicit obsoletes of a package
 669        * if ignoreinstalledsobsoletes is not set, we're also checking
 670        * obsoletes of installed packages (like newer rpm versions)
 671        */
 672       if ((!installed || s->repo != installed) || !pool->noinstalledobsoletes)
 673         {
 674           int multi = solv->multiversion.size && MAPTST(&solv->multiversion, n);
 675           int isinstalled = (installed && s->repo == installed);
 676           if (s->obsoletes && (!multi || solv->keepexplicitobsoletes))
 677             {
 678               obsp = s->repo->idarraydata + s->obsoletes;
 679               /* foreach obsoletes */
 680               while ((obs = *obsp++) != 0)
 681                 {
 682                   /* foreach provider of an obsoletes of 's' */
 683                   FOR_PROVIDES(p, pp, obs)
 684                     {
 685                       Solvable *ps = pool->solvables + p;
 686                       if (p == n)
 687                         continue;
 688                       if (isinstalled && dontfix && ps->repo == installed)
 689                         continue;       /* don't repair installed/installed problems */
 690                       if (!pool->obsoleteusesprovides /* obsoletes are matched names, not provides */
 691                           && !pool_match_nevr(pool, ps, obs))
 692                         continue;
 693                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 694                         continue;
 695                       if (!isinstalled)
 696                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_PACKAGE_OBSOLETES, obs);
 697                       else
 698                         addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_INSTALLEDPKG_OBSOLETES, obs);
 699                     }
 700                 }
 701             }
 702           /* check implicit obsoletes
 703            * for installed packages we only need to check installed/installed problems (and
 704            * only when dontfix is not set), as the others are picked up when looking at the
 705            * uninstalled package.
 706            */
 707           if (!isinstalled || !dontfix)
 708             {
 709               FOR_PROVIDES(p, pp, s->name)
 710                 {
 711                   Solvable *ps = pool->solvables + p;
 712                   if (p == n)
 713                     continue;
 714                   if (isinstalled && ps->repo != installed)
 715                     continue;
 716                   /* we still obsolete packages with same nevra, like rpm does */
 717                   /* (actually, rpm mixes those packages. yuck...) */
 718                   if (multi && (s->name != ps->name || s->evr != ps->evr || s->arch != ps->arch))
 719                     continue;
 720                   if (!pool->implicitobsoleteusesprovides && s->name != ps->name)
 721                     continue;
 722                   if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 723                     continue;
 724                   if (s->name == ps->name)
 725                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_SAME_NAME, 0);
 726                   else
 727                     addrpmrule(solv, -n, -p, SOLVER_RULE_RPM_IMPLICIT_OBSOLETES, s->name);
 728                 }
 729             }
 730         }
 731
 732       /*-----------------------------------------
 733        * add recommends to the work queue
 734        */
 735       if (s->recommends && m)
 736         {
 737           recp = s->repo->idarraydata + s->recommends;
 738           while ((rec = *recp++) != 0)
 739             {
 740               FOR_PROVIDES(p, pp, rec)
 741                 if (!MAPTST(m, p))
 742                   queue_push(&workq, p);
 743             }
 744         }
 745       if (s->suggests && m)
 746         {
 747           sugp = s->repo->idarraydata + s->suggests;
 748           while ((sug = *sugp++) != 0)
 749             {
 750               FOR_PROVIDES(p, pp, sug)
 751                 if (!MAPTST(m, p))
 752                   queue_push(&workq, p);
 753             }
 754         }
 755     }
 756   queue_free(&workq);
 757 }
 758
 759
 760 /*-------------------------------------------------------------------
 761  *
 762  * Add rules for packages possibly selected in by weak dependencies
 763  *
 764  * m: already added solvables
 765  */
 766
 767 void
 768 solver_addrpmrulesforweak(Solver *solv, Map *m)
 769 {
 770   Pool *pool = solv->pool;
 771   Solvable *s;
 772   Id sup, *supp;
 773   int i, n;
 774
 775   /* foreach solvable in pool */
 776   for (i = n = 1; n < pool->nsolvables; i++, n++)
 777     {
 778       if (i == pool->nsolvables)                /* wrap i */
 779         i = 1;
 780       if (MAPTST(m, i))                         /* already added that one */
 781         continue;
 782
 783       s = pool->solvables + i;
 784       if (!s->repo)
 785         continue;
 786       if (s->repo != pool->installed && !pool_installable(pool, s))
 787         continue;       /* only look at installable ones */
 788
 789       sup = 0;
 790       if (s->supplements)
 791         {
 792           /* find possible supplements */
 793           supp = s->repo->idarraydata + s->supplements;
 794           while ((sup = *supp++) != 0)
 795             if (dep_possible(solv, sup, m))
 796               break;
 797         }
 798
 799       /* if nothing found, check for enhances */
 800       if (!sup && s->enhances)
 801         {
 802           supp = s->repo->idarraydata + s->enhances;
 803           while ((sup = *supp++) != 0)
 804             if (dep_possible(solv, sup, m))
 805               break;
 806         }
 807       /* if nothing found, goto next solvables */
 808       if (!sup)
 809         continue;
 810       solver_addrpmrulesforsolvable(solv, s, m);
 811       n = 0;                    /* check all solvables again because we added solvables to m */
 812     }
 813 }
 814
 815
 816 /*-------------------------------------------------------------------
 817  *
 818  * add package rules for possible updates
 819  *
 820  * s: solvable
 821  * m: map of already visited solvables
 822  * allow_all: 0 = dont allow downgrades, 1 = allow all candidates
 823  */
 824
 825 void
 826 solver_addrpmrulesforupdaters(Solver *solv, Solvable *s, Map *m, int allow_all)
 827 {
 828   Pool *pool = solv->pool;
 829   int i;
 830     /* queue and buffer for it */
 831   Queue qs;
 832   Id qsbuf[64];
 833
 834   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 835     /* find update candidates for 's' */
 836   policy_findupdatepackages(solv, s, &qs, allow_all);
 837     /* add rule for 's' if not already done */
 838   if (!MAPTST(m, s - pool->solvables))
 839     solver_addrpmrulesforsolvable(solv, s, m);
 840     /* foreach update candidate, add rule if not already done */
 841   for (i = 0; i < qs.count; i++)
 842     if (!MAPTST(m, qs.elements[i]))
 843       solver_addrpmrulesforsolvable(solv, pool->solvables + qs.elements[i], m);
 844   queue_free(&qs);
 845 }
 846
 847
 848 /***********************************************************************
 849  ***
 850  ***  Update/Feature rule part
 851  ***
 852  ***  Those rules make sure an installed package isn't silently deleted
 853  ***
 854  ***/
 855
 856 static Id
 857 finddistupgradepackages(Solver *solv, Solvable *s, Queue *qs, int allow_all)
 858 {
 859   Pool *pool = solv->pool;
 860   int i;
 861
 862   policy_findupdatepackages(solv, s, qs, allow_all ? allow_all : 2);
 863   if (!qs->count)
 864     {
 865       if (allow_all)
 866         return 0;       /* orphaned, don't create feature rule */
 867       /* check if this is an orphaned package */
 868       policy_findupdatepackages(solv, s, qs, 1);
 869       if (!qs->count)
 870         return 0;       /* orphaned, don't create update rule */
 871       qs->count = 0;
 872       return -SYSTEMSOLVABLE;   /* supported but not installable */
 873     }
 874   if (allow_all)
 875     return s - pool->solvables;
 876   /* check if it is ok to keep the installed package */
 877   for (i = 0; i < qs->count; i++)
 878     {
 879       Solvable *ns = pool->solvables + qs->elements[i];
 880       if (s->evr == ns->evr && solvable_identical(s, ns))
 881         return s - pool->solvables;
 882     }
 883   /* nope, it must be some other package */
 884   return -SYSTEMSOLVABLE;
 885 }
 886
 887 /* add packages from the dup repositories to the update candidates
 888  * this isn't needed for the global dup mode as all packages are
 889  * from dup repos in that case */
 890 static void
 891 addduppackages(Solver *solv, Solvable *s, Queue *qs)
 892 {
 893   Queue dupqs;
 894   Id p, dupqsbuf[64];
 895   int i;
 896   int oldnoupdateprovide = solv->noupdateprovide;
 897
 898   queue_init_buffer(&dupqs, dupqsbuf, sizeof(dupqsbuf)/sizeof(*dupqsbuf));
 899   solv->noupdateprovide = 1;
 900   policy_findupdatepackages(solv, s, &dupqs, 2);
 901   solv->noupdateprovide = oldnoupdateprovide;
 902   for (i = 0; i < dupqs.count; i++)
 903     {
 904       p = dupqs.elements[i];
 905       if (MAPTST(&solv->dupmap, p))
 906         queue_pushunique(qs, p);
 907     }
 908   queue_free(&dupqs);
 909 }
 910
 911 /*-------------------------------------------------------------------
 912  *
 913  * add rule for update
 914  *   (A|A1|A2|A3...)  An = update candidates for A
 915  *
 916  * s = (installed) solvable
 917  */
 918
 919 void
 920 solver_addupdaterule(Solver *solv, Solvable *s, int allow_all)
 921 {
 922   /* installed packages get a special upgrade allowed rule */
 923   Pool *pool = solv->pool;
 924   Id p, d;
 925   Queue qs;
 926   Id qsbuf[64];
 927
 928   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
 929   p = s - pool->solvables;
 930   /* find update candidates for 's' */
 931   if (solv->dupmap_all)
 932     p = finddistupgradepackages(solv, s, &qs, allow_all);
 933   else
 934     policy_findupdatepackages(solv, s, &qs, allow_all);
 935   if (!allow_all && !solv->dupmap_all && solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
 936     addduppackages(solv, s, &qs);
 937
 938   if (!allow_all && qs.count && solv->multiversion.size)
 939     {
 940       int i, j;
 941
 942       d = pool_queuetowhatprovides(pool, &qs);
 943       /* filter out all multiversion packages as they don't update */
 944       for (i = j = 0; i < qs.count; i++)
 945         {
 946           if (MAPTST(&solv->multiversion, qs.elements[i]))
 947             {
 948               /* it's ok if they have same nevra */
 949               Solvable *ps = pool->solvables + qs.elements[i];
 950               if (ps->name != s->name || ps->evr != s->evr || ps->arch != s->arch)
 951                 continue;
 952             }
 953           qs.elements[j++] = qs.elements[i];
 954         }
 955       if (j < qs.count)
 956         {
 957           if (d && solv->installed && s->repo == solv->installed &&
 958               (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, s - pool->solvables - solv->installed->start))))
 959             {
 960               if (!solv->multiversionupdaters)
 961                 solv->multiversionupdaters = solv_calloc(solv->installed->end - solv->installed->start, sizeof(Id));
 962               solv->multiversionupdaters[s - pool->solvables - solv->installed->start] = d;
 963             }
 964           if (j == 0 && p == -SYSTEMSOLVABLE && solv->dupmap_all)
 965             {
 966               queue_push(&solv->orphaned, s - pool->solvables); /* treat as orphaned */
 967               j = qs.count;
 968             }
 969           qs.count = j;
 970         }
 971       else if (p != -SYSTEMSOLVABLE)
 972         {
 973           /* could fallthrough, but then we would do pool_queuetowhatprovides twice */
 974           queue_free(&qs);
 975           solver_addrule(solv, p, d);   /* allow update of s */
 976           return;
 977         }
 978     }
 979   if (qs.count && p == -SYSTEMSOLVABLE)
 980     p = queue_shift(&qs);
 981   d = qs.count ? pool_queuetowhatprovides(pool, &qs) : 0;
 982   queue_free(&qs);
 983   solver_addrule(solv, p, d);   /* allow update of s */
 984 }
 985
 986 static inline void
 987 disableupdaterule(Solver *solv, Id p)
 988 {
 989   Rule *r;
 990
 991   MAPSET(&solv->noupdate, p - solv->installed->start);
 992   r = solv->rules + solv->updaterules + (p - solv->installed->start);
 993   if (r->p && r->d >= 0)
 994     solver_disablerule(solv, r);
 995   r = solv->rules + solv->featurerules + (p - solv->installed->start);
 996   if (r->p && r->d >= 0)
 997     solver_disablerule(solv, r);
 998   if (solv->bestrules_pkg)
 999     {
1000       int i, ni;
1001       ni = solv->bestrules_end - solv->bestrules;
1002       for (i = 0; i < ni; i++)
1003         if (solv->bestrules_pkg[i] == p)
1004           solver_disablerule(solv, solv->rules + solv->bestrules + i);
1005     }
1006 }
1007
1008 static inline void
1009 reenableupdaterule(Solver *solv, Id p)
1010 {
1011   Pool *pool = solv->pool;
1012   Rule *r;
1013
1014   MAPCLR(&solv->noupdate, p - solv->installed->start);
1015   r = solv->rules + solv->updaterules + (p - solv->installed->start);
1016   if (r->p)
1017     {
1018       if (r->d < 0)
1019         {
1020           solver_enablerule(solv, r);
1021           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1022             {
1023               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1024               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1025             }
1026         }
1027     }
1028   else
1029     {
1030       r = solv->rules + solv->featurerules + (p - solv->installed->start);
1031       if (r->p && r->d < 0)
1032         {
1033           solver_enablerule(solv, r);
1034           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1035             {
1036               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1037               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1038             }
1039         }
1040     }
1041   if (solv->bestrules_pkg)
1042     {
1043       int i, ni;
1044       ni = solv->bestrules_end - solv->bestrules;
1045       for (i = 0; i < ni; i++)
1046         if (solv->bestrules_pkg[i] == p)
1047           solver_enablerule(solv, solv->rules + solv->bestrules + i);
1048     }
1049 }
1050
1051
1052 /***********************************************************************
1053  ***
1054  ***  Infarch rule part
1055  ***
1056  ***  Infarch rules make sure the solver uses the best architecture of
1057  ***  a package if multiple archetectures are available
1058  ***
1059  ***/
1060
1061 void
1062 solver_addinfarchrules(Solver *solv, Map *addedmap)
1063 {
1064   Pool *pool = solv->pool;
1065   int first, i, j;
1066   Id p, pp, a, aa, bestarch;
1067   Solvable *s, *ps, *bests;
1068   Queue badq, allowedarchs;
1069
1070   queue_init(&badq);
1071   queue_init(&allowedarchs);
1072   solv->infarchrules = solv->nrules;
1073   for (i = 1; i < pool->nsolvables; i++)
1074     {
1075       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1076         continue;
1077       s = pool->solvables + i;
1078       first = i;
1079       bestarch = 0;
1080       bests = 0;
1081       queue_empty(&allowedarchs);
1082       FOR_PROVIDES(p, pp, s->name)
1083         {
1084           ps = pool->solvables + p;
1085           if (ps->name != s->name || !MAPTST(addedmap, p))
1086             continue;
1087           if (p == i)
1088             first = 0;
1089           if (first)
1090             break;
1091           a = ps->arch;
1092           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1093           if (a != 1 && pool->installed && ps->repo == pool->installed)
1094             {
1095               if (!solv->dupmap_all && !(solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1096                 queue_pushunique(&allowedarchs, ps->arch);      /* also ok to keep this architecture */
1097               continue;         /* ignore installed solvables when calculating the best arch */
1098             }
1099           if (a && a != 1 && (!bestarch || a < bestarch))
1100             {
1101               bestarch = a;
1102               bests = ps;
1103             }
1104         }
1105       if (first)
1106         continue;
1107       /* speed up common case where installed package already has best arch */
1108       if (allowedarchs.count == 1 && bests && allowedarchs.elements[0] == bests->arch)
1109         allowedarchs.count--;   /* installed arch is best */
1110       queue_empty(&badq);
1111       FOR_PROVIDES(p, pp, s->name)
1112         {
1113           ps = pool->solvables + p;
1114           if (ps->name != s->name || !MAPTST(addedmap, p))
1115             continue;
1116           a = ps->arch;
1117           a = (a <= pool->lastarch) ? pool->id2arch[a] : 0;
1118           if (a != 1 && bestarch && ((a ^ bestarch) & 0xffff0000) != 0)
1119             {
1120               if (pool->installed && ps->repo == pool->installed)
1121                 continue;       /* always ok to keep an installed package */
1122               for (j = 0; j < allowedarchs.count; j++)
1123                 {
1124                   aa = allowedarchs.elements[j];
1125                   if (ps->arch == aa)
1126                     break;
1127                   aa = (aa <= pool->lastarch) ? pool->id2arch[aa] : 0;
1128                   if (aa && ((a ^ aa) & 0xffff0000) == 0)
1129                     break;      /* compatible */
1130                 }
1131               if (j == allowedarchs.count)
1132                 queue_push(&badq, p);
1133             }
1134         }
1135       if (!badq.count)
1136         continue;
1137       /* block all solvables in the badq! */
1138       for (j = 0; j < badq.count; j++)
1139         {
1140           p = badq.elements[j];
1141           solver_addrule(solv, -p, 0);
1142         }
1143     }
1144   queue_free(&badq);
1145   queue_free(&allowedarchs);
1146   solv->infarchrules_end = solv->nrules;
1147 }
1148
1149 static inline void
1150 disableinfarchrule(Solver *solv, Id name)
1151 {
1152   Pool *pool = solv->pool;
1153   Rule *r;
1154   int i;
1155   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1156     {
1157       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1158         solver_disablerule(solv, r);
1159     }
1160 }
1161
1162 static inline void
1163 reenableinfarchrule(Solver *solv, Id name)
1164 {
1165   Pool *pool = solv->pool;
1166   Rule *r;
1167   int i;
1168   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1169     {
1170       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1171         {
1172           solver_enablerule(solv, r);
1173           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1174             {
1175               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1176               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1177             }
1178         }
1179     }
1180 }
1181
1182
1183 /***********************************************************************
1184  ***
1185  ***  Dup rule part
1186  ***
1187  ***  Dup rules make sure a package is selected from the specified dup
1188  ***  repositories if an update candidate is included in one of them.
1189  ***
1190  ***/
1191
1192 static inline void
1193 add_cleandeps_package(Solver *solv, Id p)
1194 {
1195   if (!solv->cleandeps_updatepkgs)
1196     {
1197       solv->cleandeps_updatepkgs = solv_calloc(1, sizeof(Queue));
1198       queue_init(solv->cleandeps_updatepkgs);
1199     }
1200   queue_pushunique(solv->cleandeps_updatepkgs, p);
1201 }
1202
1203 static inline void
1204 solver_addtodupmaps(Solver *solv, Id p, Id how, int targeted)
1205 {
1206   Pool *pool = solv->pool;
1207   Solvable *ps, *s = pool->solvables + p;
1208   Repo *installed = solv->installed;
1209   Id pi, pip, obs, *obsp;
1210
1211   MAPSET(&solv->dupinvolvedmap, p);
1212   if (targeted)
1213     MAPSET(&solv->dupmap, p);
1214   FOR_PROVIDES(pi, pip, s->name)
1215     {
1216       ps = pool->solvables + pi;
1217       if (ps->name != s->name)
1218         continue;
1219       MAPSET(&solv->dupinvolvedmap, pi);
1220       if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
1221         {
1222           Id *opp, pi2;
1223           for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
1224             if (pool->solvables[pi2].repo != installed)
1225               MAPSET(&solv->dupinvolvedmap, pi2);
1226         }
1227       if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1228         {
1229           if (!solv->bestupdatemap.size)
1230             map_grow(&solv->bestupdatemap, installed->end - installed->start);
1231           MAPSET(&solv->bestupdatemap, pi - installed->start);
1232         }
1233       if (ps->repo == installed && (how & SOLVER_CLEANDEPS) != 0)
1234         add_cleandeps_package(solv, pi);
1235       if (!targeted && ps->repo != installed)
1236         MAPSET(&solv->dupmap, pi);
1237     }
1238   if (s->repo == installed && solv->obsoletes && solv->obsoletes[p - installed->start])
1239     {
1240       Id *opp;
1241       for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (pi = *opp++) != 0;)
1242         {
1243           ps = pool->solvables + pi;
1244           if (ps->repo == installed)
1245             continue;
1246           MAPSET(&solv->dupinvolvedmap, pi);
1247           if (!targeted)
1248             MAPSET(&solv->dupmap, pi);
1249         }
1250     }
1251   if (targeted && s->repo != installed && s->obsoletes)
1252     {
1253       /* XXX: check obsoletes/provides combination */
1254       obsp = s->repo->idarraydata + s->obsoletes;
1255       while ((obs = *obsp++) != 0)
1256         {
1257           FOR_PROVIDES(pi, pip, obs)
1258             {
1259               Solvable *ps = pool->solvables + pi;
1260               if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1261                 continue;
1262               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1263                 continue;
1264               MAPSET(&solv->dupinvolvedmap, pi);
1265               if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
1266                 {
1267                   Id *opp, pi2;
1268                   for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
1269                     if (pool->solvables[pi2].repo != installed)
1270                       MAPSET(&solv->dupinvolvedmap, pi2);
1271                 }
1272               if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0)
1273                 {
1274                   if (!solv->bestupdatemap.size)
1275                     map_grow(&solv->bestupdatemap, installed->end - installed->start);
1276                   MAPSET(&solv->bestupdatemap, pi - installed->start);
1277                 }
1278               if (ps->repo == installed && (how & SOLVER_CLEANDEPS) != 0)
1279                 add_cleandeps_package(solv, pi);
1280             }
1281         }
1282     }
1283 }
1284
1285 void
1286 solver_createdupmaps(Solver *solv)
1287 {
1288   Queue *job = &solv->job;
1289   Pool *pool = solv->pool;
1290   Repo *installed = solv->installed;
1291   Id select, how, what, p, pp;
1292   Solvable *s;
1293   int i, targeted;
1294
1295   map_init(&solv->dupmap, pool->nsolvables);
1296   map_init(&solv->dupinvolvedmap, pool->nsolvables);
1297   for (i = 0; i < job->count; i += 2)
1298     {
1299       how = job->elements[i];
1300       select = job->elements[i] & SOLVER_SELECTMASK;
1301       what = job->elements[i + 1];
1302       switch (how & SOLVER_JOBMASK)
1303         {
1304         case SOLVER_DISTUPGRADE:
1305           if (select == SOLVER_SOLVABLE_REPO)
1306             {
1307               Repo *repo;
1308               if (what <= 0 || what > pool->nrepos)
1309                 break;
1310               repo = pool_id2repo(pool, what);
1311               if (!repo)
1312                 break;
1313               if (repo != installed && !(how & SOLVER_TARGETED) && solv->noautotarget)
1314                 break;
1315               targeted = repo != installed || (how & SOLVER_TARGETED) != 0;
1316               FOR_REPO_SOLVABLES(repo, p, s)
1317                 {
1318                   if (repo != installed && !pool_installable(pool, s))
1319                     continue;
1320                   solver_addtodupmaps(solv, p, how, targeted);
1321                 }
1322             }
1323           else
1324             {
1325               targeted = how & SOLVER_TARGETED ? 1 : 0;
1326               if (installed && !targeted && !solv->noautotarget)
1327                 {
1328                   FOR_JOB_SELECT(p, pp, select, what)
1329                     if (pool->solvables[p].repo == installed)
1330                       break;
1331                   targeted = p == 0;
1332                 }
1333               else if (!installed && !solv->noautotarget)
1334                 targeted = 1;
1335               FOR_JOB_SELECT(p, pp, select, what)
1336                 {
1337                   Solvable *s = pool->solvables + p;
1338                   if (!s->repo)
1339                     continue;
1340                   if (s->repo != installed && !targeted)
1341                     continue;
1342                   if (s->repo != installed && !pool_installable(pool, s))
1343                     continue;
1344                   solver_addtodupmaps(solv, p, how, targeted);
1345                 }
1346             }
1347           break;
1348         default:
1349           break;
1350         }
1351     }
1352   MAPCLR(&solv->dupinvolvedmap, SYSTEMSOLVABLE);
1353 }
1354
1355 void
1356 solver_freedupmaps(Solver *solv)
1357 {
1358   map_free(&solv->dupmap);
1359   /* we no longer free solv->dupinvolvedmap as we need it in
1360    * policy's priority pruning code. sigh. */
1361 }
1362
1363 void
1364 solver_addduprules(Solver *solv, Map *addedmap)
1365 {
1366   Pool *pool = solv->pool;
1367   Id p, pp;
1368   Solvable *s, *ps;
1369   int first, i;
1370
1371   solv->duprules = solv->nrules;
1372   for (i = 1; i < pool->nsolvables; i++)
1373     {
1374       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1375         continue;
1376       s = pool->solvables + i;
1377       first = i;
1378       FOR_PROVIDES(p, pp, s->name)
1379         {
1380           ps = pool->solvables + p;
1381           if (ps->name != s->name || !MAPTST(addedmap, p))
1382             continue;
1383           if (p == i)
1384             first = 0;
1385           if (first)
1386             break;
1387           if (!MAPTST(&solv->dupinvolvedmap, p))
1388             continue;
1389           if (solv->installed && ps->repo == solv->installed)
1390             {
1391               if (!solv->updatemap.size)
1392                 map_grow(&solv->updatemap, solv->installed->end - solv->installed->start);
1393               MAPSET(&solv->updatemap, p - solv->installed->start);
1394               if (!MAPTST(&solv->dupmap, p))
1395                 {
1396                   Id ip, ipp;
1397                   /* is installed identical to a good one? */
1398                   FOR_PROVIDES(ip, ipp, ps->name)
1399                     {
1400                       Solvable *is = pool->solvables + ip;
1401                       if (!MAPTST(&solv->dupmap, ip))
1402                         continue;
1403                       if (is->evr == ps->evr && solvable_identical(ps, is))
1404                         break;
1405                     }
1406                   if (!ip)
1407                     solver_addrule(solv, -p, 0);        /* no match, sorry */
1408                   else
1409                     MAPSET(&solv->dupmap, p);           /* for best rules processing */
1410                 }
1411             }
1412           else if (!MAPTST(&solv->dupmap, p))
1413             solver_addrule(solv, -p, 0);
1414         }
1415     }
1416   solv->duprules_end = solv->nrules;
1417 }
1418
1419
1420 static inline void
1421 disableduprule(Solver *solv, Id name)
1422 {
1423   Pool *pool = solv->pool;
1424   Rule *r;
1425   int i;
1426   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1427     {
1428       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1429         solver_disablerule(solv, r);
1430     }
1431 }
1432
1433 static inline void
1434 reenableduprule(Solver *solv, Id name)
1435 {
1436   Pool *pool = solv->pool;
1437   Rule *r;
1438   int i;
1439   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
1440     {
1441       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1442         {
1443           solver_enablerule(solv, r);
1444           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1445             {
1446               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1447               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1448             }
1449         }
1450     }
1451 }
1452
1453
1454 /***********************************************************************
1455  ***
1456  ***  Policy rule disabling/reenabling
1457  ***
1458  ***  Disable all policy rules that conflict with our jobs. If a job
1459  ***  gets disabled later on, reenable the involved policy rules again.
1460  ***
1461  ***/
1462
1463 #define DISABLE_UPDATE  1
1464 #define DISABLE_INFARCH 2
1465 #define DISABLE_DUP     3
1466
1467 /*
1468  * add all installed packages that package p obsoletes to Queue q.
1469  * Package p is not installed. Also, we know that if
1470  * solv->keepexplicitobsoletes is not set, p is not in the multiversion map.
1471  * Entries may get added multiple times.
1472  */
1473 static void
1474 add_obsoletes(Solver *solv, Id p, Queue *q)
1475 {
1476   Pool *pool = solv->pool;
1477   Repo *installed = solv->installed;
1478   Id p2, pp2;
1479   Solvable *s = pool->solvables + p;
1480   Id obs, *obsp;
1481   Id lastp2 = 0;
1482
1483   if (!solv->keepexplicitobsoletes || !(solv->multiversion.size && MAPTST(&solv->multiversion, p)))
1484     {
1485       FOR_PROVIDES(p2, pp2, s->name)
1486         {
1487           Solvable *ps = pool->solvables + p2;
1488           if (ps->repo != installed)
1489             continue;
1490           if (!pool->implicitobsoleteusesprovides && ps->name != s->name)
1491             continue;
1492           if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1493             continue;
1494           queue_push(q, p2);
1495           lastp2 = p2;
1496         }
1497     }
1498   if (!s->obsoletes)
1499     return;
1500   obsp = s->repo->idarraydata + s->obsoletes;
1501   while ((obs = *obsp++) != 0)
1502     FOR_PROVIDES(p2, pp2, obs)
1503       {
1504         Solvable *ps = pool->solvables + p2;
1505         if (ps->repo != installed)
1506           continue;
1507         if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1508           continue;
1509         if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1510           continue;
1511         if (p2 == lastp2)
1512           continue;
1513         queue_push(q, p2);
1514         lastp2 = p2;
1515       }
1516 }
1517
1518 /*
1519  * Call add_obsoletes and intersect the result with the
1520  * elements in Queue q starting at qstart.
1521  * Assumes that it's the first call if qstart == q->count.
1522  * May use auxillary map m for the intersection process, all
1523  * elements of q starting at qstart must have their bit cleared.
1524  * (This is also true after the function returns.)
1525  */
1526 static void
1527 intersect_obsoletes(Solver *solv, Id p, Queue *q, int qstart, Map *m)
1528 {
1529   int i, j;
1530   int qcount = q->count;
1531
1532   add_obsoletes(solv, p, q);
1533   if (qcount == qstart)
1534     return;     /* first call */
1535   if (qcount == q->count)
1536     j = qstart;
1537   else if (qcount == qstart + 1)
1538     {
1539       /* easy if there's just one element */
1540       j = qstart;
1541       for (i = qcount; i < q->count; i++)
1542         if (q->elements[i] == q->elements[qstart])
1543           {
1544             j++;        /* keep the element */
1545             break;
1546           }
1547     }
1548   else if (!m->size && q->count - qstart <= 8)
1549     {
1550       /* faster than a map most of the time */
1551       int k;
1552       for (i = j = qstart; i < qcount; i++)
1553         {
1554           Id ip = q->elements[i];
1555           for (k = qcount; k < q->count; k++)
1556             if (q->elements[k] == ip)
1557               {
1558                 q->elements[j++] = ip;
1559                 break;
1560               }
1561         }
1562     }
1563   else
1564     {
1565       /* for the really pathologic cases we use the map */
1566       Repo *installed = solv->installed;
1567       if (!m->size)
1568         map_init(m, installed->end - installed->start);
1569       for (i = qcount; i < q->count; i++)
1570         MAPSET(m, q->elements[i] - installed->start);
1571       for (i = j = qstart; i < qcount; i++)
1572         if (MAPTST(m, q->elements[i] - installed->start))
1573           {
1574             MAPCLR(m, q->elements[i] - installed->start);
1575             q->elements[j++] = q->elements[i];
1576           }
1577     }
1578   queue_truncate(q, j);
1579 }
1580
1581 static void
1582 jobtodisablelist(Solver *solv, Id how, Id what, Queue *q)
1583 {
1584   Pool *pool = solv->pool;
1585   Id select, p, pp;
1586   Repo *installed;
1587   Solvable *s;
1588   int i, j, set, qstart;
1589   Map omap;
1590
1591   installed = solv->installed;
1592   select = how & SOLVER_SELECTMASK;
1593   switch (how & SOLVER_JOBMASK)
1594     {
1595     case SOLVER_INSTALL:
1596       set = how & SOLVER_SETMASK;
1597       if (!(set & SOLVER_NOAUTOSET))
1598         {
1599           /* automatically add set bits by analysing the job */
1600           if (select == SOLVER_SOLVABLE_NAME)
1601             set |= SOLVER_SETNAME;
1602           if (select == SOLVER_SOLVABLE)
1603             set |= SOLVER_SETNAME | SOLVER_SETARCH | SOLVER_SETVENDOR | SOLVER_SETREPO | SOLVER_SETEVR;
1604           else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
1605             {
1606               Reldep *rd = GETRELDEP(pool, what);
1607               if (rd->flags == REL_EQ && select == SOLVER_SOLVABLE_NAME)
1608                 {
1609                   if (pool->disttype != DISTTYPE_DEB)
1610                     {
1611                       const char *evr = pool_id2str(pool, rd->evr);
1612                       if (strchr(evr, '-'))
1613                         set |= SOLVER_SETEVR;
1614                       else
1615                         set |= SOLVER_SETEV;
1616                     }
1617                   else
1618                     set |= SOLVER_SETEVR;
1619                 }
1620               if (rd->flags <= 7 && ISRELDEP(rd->name))
1621                 rd = GETRELDEP(pool, rd->name);
1622               if (rd->flags == REL_ARCH)
1623                 set |= SOLVER_SETARCH;
1624             }
1625         }
1626       else
1627         set &= ~SOLVER_NOAUTOSET;
1628       if (!set)
1629         return;
1630       if ((set & SOLVER_SETARCH) != 0 && solv->infarchrules != solv->infarchrules_end)
1631         {
1632           if (select == SOLVER_SOLVABLE)
1633             queue_push2(q, DISABLE_INFARCH, pool->solvables[what].name);
1634           else
1635             {
1636               int qcnt = q->count;
1637               /* does not work for SOLVER_SOLVABLE_ALL and SOLVER_SOLVABLE_REPO, but
1638                  they are not useful for SOLVER_INSTALL jobs anyway */
1639               FOR_JOB_SELECT(p, pp, select, what)
1640                 {
1641                   s = pool->solvables + p;
1642                   /* unify names */
1643                   for (i = qcnt; i < q->count; i += 2)
1644                     if (q->elements[i + 1] == s->name)
1645                       break;
1646                   if (i < q->count)
1647                     continue;
1648                   queue_push2(q, DISABLE_INFARCH, s->name);
1649                 }
1650             }
1651         }
1652       if ((set & SOLVER_SETREPO) != 0 && solv->duprules != solv->duprules_end)
1653         {
1654           if (select == SOLVER_SOLVABLE)
1655             queue_push2(q, DISABLE_DUP, pool->solvables[what].name);
1656           else
1657             {
1658               int qcnt = q->count;
1659               FOR_JOB_SELECT(p, pp, select, what)
1660                 {
1661                   s = pool->solvables + p;
1662                   /* unify names */
1663                   for (i = qcnt; i < q->count; i += 2)
1664                     if (q->elements[i + 1] == s->name)
1665                       break;
1666                   if (i < q->count)
1667                     continue;
1668                   queue_push2(q, DISABLE_DUP, s->name);
1669                 }
1670             }
1671         }
1672       if (!installed || installed->end == installed->start)
1673         return;
1674       /* now the hard part: disable some update rules */
1675
1676       /* first check if we have multiversion or installed packages in the job */
1677       i = j = 0;
1678       FOR_JOB_SELECT(p, pp, select, what)
1679         {
1680           if (pool->solvables[p].repo == installed)
1681             j = p;
1682           else if (solv->multiversion.size && MAPTST(&solv->multiversion, p) && !solv->keepexplicitobsoletes)
1683             return;
1684           i++;
1685         }
1686       if (j)    /* have installed packages */
1687         {
1688           /* this is for dupmap_all jobs, it can go away if we create
1689            * duprules for them */
1690           if (i == 1 && (set & SOLVER_SETREPO) != 0)
1691             queue_push2(q, DISABLE_UPDATE, j);
1692           return;
1693         }
1694
1695       omap.size = 0;
1696       qstart = q->count;
1697       FOR_JOB_SELECT(p, pp, select, what)
1698         {
1699           intersect_obsoletes(solv, p, q, qstart, &omap);
1700           if (q->count == qstart)
1701             break;
1702         }
1703       if (omap.size)
1704         map_free(&omap);
1705
1706       if (qstart == q->count)
1707         return;         /* nothing to prune */
1708
1709       /* convert result to (DISABLE_UPDATE, p) pairs */
1710       i = q->count;
1711       for (j = qstart; j < i; j++)
1712         queue_push(q, q->elements[j]);
1713       for (j = qstart; j < q->count; j += 2)
1714         {
1715           q->elements[j] = DISABLE_UPDATE;
1716           q->elements[j + 1] = q->elements[i++];
1717         }
1718
1719       /* now that we know which installed packages are obsoleted check each of them */
1720       if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
1721         return;         /* all is set, nothing to do */
1722
1723       for (i = j = qstart; i < q->count; i += 2)
1724         {
1725           Solvable *is = pool->solvables + q->elements[i + 1];
1726           FOR_JOB_SELECT(p, pp, select, what)
1727             {
1728               int illegal = 0;
1729               s = pool->solvables + p;
1730               if ((set & SOLVER_SETEVR) != 0)
1731                 illegal |= POLICY_ILLEGAL_DOWNGRADE;    /* ignore */
1732               if ((set & SOLVER_SETNAME) != 0)
1733                 illegal |= POLICY_ILLEGAL_NAMECHANGE;   /* ignore */
1734               if ((set & SOLVER_SETARCH) != 0)
1735                 illegal |= POLICY_ILLEGAL_ARCHCHANGE;   /* ignore */
1736               if ((set & SOLVER_SETVENDOR) != 0)
1737                 illegal |= POLICY_ILLEGAL_VENDORCHANGE; /* ignore */
1738               illegal = policy_is_illegal(solv, is, s, illegal);
1739               if (illegal && illegal == POLICY_ILLEGAL_DOWNGRADE && (set & SOLVER_SETEV) != 0)
1740                 {
1741                   /* it's ok if the EV is different */
1742                   if (pool_evrcmp(pool, is->evr, s->evr, EVRCMP_COMPARE_EVONLY) != 0)
1743                     illegal = 0;
1744                 }
1745               if (illegal)
1746                 break;
1747             }
1748           if (!p)
1749             {
1750               /* no package conflicts with the update rule */
1751               /* thus keep the DISABLE_UPDATE */
1752               q->elements[j + 1] = q->elements[i + 1];
1753               j += 2;
1754             }
1755         }
1756       queue_truncate(q, j);
1757       return;
1758
1759     case SOLVER_ERASE:
1760       if (!installed)
1761         break;
1762       if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
1763         FOR_REPO_SOLVABLES(installed, p, s)
1764           queue_push2(q, DISABLE_UPDATE, p);
1765       FOR_JOB_SELECT(p, pp, select, what)
1766         if (pool->solvables[p].repo == installed)
1767           queue_push2(q, DISABLE_UPDATE, p);
1768       return;
1769     default:
1770       return;
1771     }
1772 }
1773
1774 /* disable all policy rules that are in conflict with our job list */
1775 void
1776 solver_disablepolicyrules(Solver *solv)
1777 {
1778   Queue *job = &solv->job;
1779   int i, j;
1780   Queue allq;
1781   Rule *r;
1782   Id lastjob = -1;
1783   Id allqbuf[128];
1784
1785   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1786
1787   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1788     {
1789       r = solv->rules + i;
1790       if (r->d < 0)     /* disabled? */
1791         continue;
1792       j = solv->ruletojob.elements[i - solv->jobrules];
1793       if (j == lastjob)
1794         continue;
1795       lastjob = j;
1796       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1797     }
1798   if (solv->cleandepsmap.size)
1799     {
1800       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1801       for (i = solv->installed->start; i < solv->installed->end; i++)
1802         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
1803           queue_push2(&allq, DISABLE_UPDATE, i);
1804     }
1805   MAPZERO(&solv->noupdate);
1806   for (i = 0; i < allq.count; i += 2)
1807     {
1808       Id type = allq.elements[i], arg = allq.elements[i + 1];
1809       switch(type)
1810         {
1811         case DISABLE_UPDATE:
1812           disableupdaterule(solv, arg);
1813           break;
1814         case DISABLE_INFARCH:
1815           disableinfarchrule(solv, arg);
1816           break;
1817         case DISABLE_DUP:
1818           disableduprule(solv, arg);
1819           break;
1820         default:
1821           break;
1822         }
1823     }
1824   queue_free(&allq);
1825 }
1826
1827 /* we just disabled job #jobidx, now reenable all policy rules that were
1828  * disabled because of this job */
1829 void
1830 solver_reenablepolicyrules(Solver *solv, int jobidx)
1831 {
1832   Queue *job = &solv->job;
1833   int i, j, k, ai;
1834   Queue q, allq;
1835   Rule *r;
1836   Id lastjob = -1;
1837   Id qbuf[32], allqbuf[32];
1838
1839   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
1840   jobtodisablelist(solv, job->elements[jobidx - 1], job->elements[jobidx], &q);
1841   if (!q.count)
1842     {
1843       queue_free(&q);
1844       return;
1845     }
1846   /* now remove everything from q that is disabled by other jobs */
1847
1848   /* first remove cleandeps packages, they count as DISABLE_UPDATE */
1849   if (solv->cleandepsmap.size)
1850     {
1851       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
1852       for (j = k = 0; j < q.count; j += 2)
1853         {
1854           if (q.elements[j] == DISABLE_UPDATE)
1855             {
1856               Id p = q.elements[j + 1];
1857               if (p >= solv->installed->start && p < solv->installed->end && MAPTST(&solv->cleandepsmap, p - solv->installed->start))
1858                 continue;       /* remove element from q */
1859             }
1860           q.elements[k++] = q.elements[j];
1861           q.elements[k++] = q.elements[j + 1];
1862         }
1863       q.count = k;
1864       if (!q.count)
1865         {
1866           queue_free(&q);
1867           return;
1868         }
1869     }
1870
1871   /* now go through the disable list of all other jobs */
1872   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1873   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1874     {
1875       r = solv->rules + i;
1876       if (r->d < 0)     /* disabled? */
1877         continue;
1878       j = solv->ruletojob.elements[i - solv->jobrules];
1879       if (j == lastjob)
1880         continue;
1881       lastjob = j;
1882       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1883       if (!allq.count)
1884         continue;
1885       /* remove all elements in allq from q */
1886       for (j = k = 0; j < q.count; j += 2)
1887         {
1888           Id type = q.elements[j], arg = q.elements[j + 1];
1889           for (ai = 0; ai < allq.count; ai += 2)
1890             if (allq.elements[ai] == type && allq.elements[ai + 1] == arg)
1891               break;
1892           if (ai < allq.count)
1893             continue;   /* found it in allq, remove element from q */
1894           q.elements[k++] = q.elements[j];
1895           q.elements[k++] = q.elements[j + 1];
1896         }
1897       q.count = k;
1898       if (!q.count)
1899         {
1900           queue_free(&q);
1901           queue_free(&allq);
1902           return;
1903         }
1904       queue_empty(&allq);
1905     }
1906   queue_free(&allq);
1907
1908   /* now re-enable anything that's left in q */
1909   for (j = 0; j < q.count; j += 2)
1910     {
1911       Id type = q.elements[j], arg = q.elements[j + 1];
1912       switch(type)
1913         {
1914         case DISABLE_UPDATE:
1915           reenableupdaterule(solv, arg);
1916           break;
1917         case DISABLE_INFARCH:
1918           reenableinfarchrule(solv, arg);
1919           break;
1920         case DISABLE_DUP:
1921           reenableduprule(solv, arg);
1922           break;
1923         }
1924     }
1925   queue_free(&q);
1926 }
1927
1928 /* we just removed a package from the cleandeps map, now reenable all policy rules that were
1929  * disabled because of this */
1930 void
1931 solver_reenablepolicyrules_cleandeps(Solver *solv, Id pkg)
1932 {
1933   Queue *job = &solv->job;
1934   int i, j;
1935   Queue allq;
1936   Rule *r;
1937   Id lastjob = -1;
1938   Id allqbuf[128];
1939
1940   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
1941   for (i = solv->jobrules; i < solv->jobrules_end; i++)
1942     {
1943       r = solv->rules + i;
1944       if (r->d < 0)     /* disabled? */
1945         continue;
1946       j = solv->ruletojob.elements[i - solv->jobrules];
1947       if (j == lastjob)
1948         continue;
1949       lastjob = j;
1950       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
1951     }
1952   for (i = 0; i < allq.count; i += 2)
1953     if (allq.elements[i] == DISABLE_UPDATE && allq.elements[i + 1] == pkg)
1954       break;
1955   if (i == allq.count)
1956     reenableupdaterule(solv, pkg);
1957   queue_free(&allq);
1958 }
1959
1960
1961 /***********************************************************************
1962  ***
1963  ***  Rule info part, tell the user what the rule is about.
1964  ***
1965  ***/
1966
1967 static void
1968 addrpmruleinfo(Solver *solv, Id p, Id d, int type, Id dep)
1969 {
1970   Pool *pool = solv->pool;
1971   Rule *r;
1972   Id w2, op, od, ow2;
1973
1974   /* check if this creates the rule we're searching for */
1975   r = solv->rules + solv->ruleinfoq->elements[0];
1976   op = r->p;
1977   od = r->d < 0 ? -r->d - 1 : r->d;
1978   ow2 = 0;
1979
1980   /* normalize */
1981   w2 = d > 0 ? 0 : d;
1982   if (p < 0 && d > 0 && (!pool->whatprovidesdata[d] || !pool->whatprovidesdata[d + 1]))
1983     {
1984       w2 = pool->whatprovidesdata[d];
1985       d = 0;
1986
1987     }
1988   if (p > 0 && d < 0)           /* this hack is used for buddy deps */
1989     {
1990       w2 = p;
1991       p = d;
1992     }
1993
1994   if (d > 0)
1995     {
1996       if (p != op && !od)
1997         return;
1998       if (d != od)
1999         {
2000           Id *dp = pool->whatprovidesdata + d;
2001           Id *odp = pool->whatprovidesdata + od;
2002           while (*dp)
2003             if (*dp++ != *odp++)
2004               return;
2005           if (*odp)
2006             return;
2007         }
2008       w2 = 0;
2009       /* handle multiversion conflict rules */
2010       if (p < 0 && pool->whatprovidesdata[d] < 0)
2011         {
2012           w2 = pool->whatprovidesdata[d];
2013           /* XXX: free memory */
2014         }
2015     }
2016   else
2017     {
2018       if (od)
2019         return;
2020       ow2 = r->w2;
2021       if (p > w2)
2022         {
2023           if (w2 != op || p != ow2)
2024             return;
2025         }
2026       else
2027         {
2028           if (p != op || w2 != ow2)
2029             return;
2030         }
2031     }
2032   /* yep, rule matches. record info */
2033   queue_push(solv->ruleinfoq, type);
2034   if (type == SOLVER_RULE_RPM_SAME_NAME)
2035     {
2036       /* we normalize same name order */
2037       queue_push(solv->ruleinfoq, op < 0 ? -op : 0);
2038       queue_push(solv->ruleinfoq, ow2 < 0 ? -ow2 : 0);
2039     }
2040   else
2041     {
2042       queue_push(solv->ruleinfoq, p < 0 ? -p : 0);
2043       queue_push(solv->ruleinfoq, w2 < 0 ? -w2 : 0);
2044     }
2045   queue_push(solv->ruleinfoq, dep);
2046 }
2047
2048 static int
2049 solver_allruleinfos_cmp(const void *ap, const void *bp, void *dp)
2050 {
2051   const Id *a = ap, *b = bp;
2052   int r;
2053
2054   r = a[0] - b[0];
2055   if (r)
2056     return r;
2057   r = a[1] - b[1];
2058   if (r)
2059     return r;
2060   r = a[2] - b[2];
2061   if (r)
2062     return r;
2063   r = a[3] - b[3];
2064   if (r)
2065     return r;
2066   return 0;
2067 }
2068
2069 int
2070 solver_allruleinfos(Solver *solv, Id rid, Queue *rq)
2071 {
2072   Pool *pool = solv->pool;
2073   Rule *r = solv->rules + rid;
2074   int i, j;
2075
2076   queue_empty(rq);
2077   if (rid <= 0 || rid >= solv->rpmrules_end)
2078     {
2079       Id type, from, to, dep;
2080       type = solver_ruleinfo(solv, rid, &from, &to, &dep);
2081       queue_push(rq, type);
2082       queue_push(rq, from);
2083       queue_push(rq, to);
2084       queue_push(rq, dep);
2085       return 1;
2086     }
2087   if (r->p >= 0)
2088     return 0;
2089   queue_push(rq, rid);
2090   solv->ruleinfoq = rq;
2091   solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2092   /* also try reverse direction for conflicts */
2093   if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2094     solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2095   solv->ruleinfoq = 0;
2096   queue_shift(rq);
2097   /* now sort & unify em */
2098   if (!rq->count)
2099     return 0;
2100   solv_sort(rq->elements, rq->count / 4, 4 * sizeof(Id), solver_allruleinfos_cmp, 0);
2101   /* throw out identical entries */
2102   for (i = j = 0; i < rq->count; i += 4)
2103     {
2104       if (j)
2105         {
2106           if (rq->elements[i] == rq->elements[j - 4] &&
2107               rq->elements[i + 1] == rq->elements[j - 3] &&
2108               rq->elements[i + 2] == rq->elements[j - 2] &&
2109               rq->elements[i + 3] == rq->elements[j - 1])
2110             continue;
2111         }
2112       rq->elements[j++] = rq->elements[i];
2113       rq->elements[j++] = rq->elements[i + 1];
2114       rq->elements[j++] = rq->elements[i + 2];
2115       rq->elements[j++] = rq->elements[i + 3];
2116     }
2117   rq->count = j;
2118   return j / 4;
2119 }
2120
2121 SolverRuleinfo
2122 solver_ruleinfo(Solver *solv, Id rid, Id *fromp, Id *top, Id *depp)
2123 {
2124   Pool *pool = solv->pool;
2125   Rule *r = solv->rules + rid;
2126   SolverRuleinfo type = SOLVER_RULE_UNKNOWN;
2127
2128   if (fromp)
2129     *fromp = 0;
2130   if (top)
2131     *top = 0;
2132   if (depp)
2133     *depp = 0;
2134   if (rid > 0 && rid < solv->rpmrules_end)
2135     {
2136       Queue rq;
2137       int i;
2138
2139       if (r->p >= 0)
2140         return SOLVER_RULE_RPM;
2141       if (fromp)
2142         *fromp = -r->p;
2143       queue_init(&rq);
2144       queue_push(&rq, rid);
2145       solv->ruleinfoq = &rq;
2146       solver_addrpmrulesforsolvable(solv, pool->solvables - r->p, 0);
2147       /* also try reverse direction for conflicts */
2148       if ((r->d == 0 || r->d == -1) && r->w2 < 0)
2149         solver_addrpmrulesforsolvable(solv, pool->solvables - r->w2, 0);
2150       solv->ruleinfoq = 0;
2151       type = SOLVER_RULE_RPM;
2152       for (i = 1; i < rq.count; i += 4)
2153         {
2154           Id qt, qo, qp, qd;
2155           qt = rq.elements[i];
2156           qp = rq.elements[i + 1];
2157           qo = rq.elements[i + 2];
2158           qd = rq.elements[i + 3];
2159           if (type == SOLVER_RULE_RPM || type > qt)
2160             {
2161               type = qt;
2162               if (fromp)
2163                 *fromp = qp;
2164               if (top)
2165                 *top = qo;
2166               if (depp)
2167                 *depp = qd;
2168             }
2169         }
2170       queue_free(&rq);
2171       return type;
2172     }
2173   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2174     {
2175       Id jidx = solv->ruletojob.elements[rid - solv->jobrules];
2176       if (fromp)
2177         *fromp = jidx;
2178       if (top)
2179         *top = solv->job.elements[jidx];
2180       if (depp)
2181         *depp = solv->job.elements[jidx + 1];
2182       if ((r->d == 0 || r->d == -1) && r->w2 == 0 && r->p == -SYSTEMSOLVABLE)
2183         {
2184           if ((solv->job.elements[jidx] & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_INSTALL|SOLVER_SOLVABLE_NAME))
2185             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2186           if ((solv->job.elements[jidx] & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_INSTALL|SOLVER_SOLVABLE_PROVIDES))
2187             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2188           if ((solv->job.elements[jidx] & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_ERASE|SOLVER_SOLVABLE_NAME))
2189             return SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM;
2190           if ((solv->job.elements[jidx] & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_ERASE|SOLVER_SOLVABLE_PROVIDES))
2191             return SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM;
2192         }
2193       return SOLVER_RULE_JOB;
2194     }
2195   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2196     {
2197       if (fromp)
2198         *fromp = solv->installed->start + (rid - solv->updaterules);
2199       return SOLVER_RULE_UPDATE;
2200     }
2201   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2202     {
2203       if (fromp)
2204         *fromp = solv->installed->start + (rid - solv->featurerules);
2205       return SOLVER_RULE_FEATURE;
2206     }
2207   if (rid >= solv->duprules && rid < solv->duprules_end)
2208     {
2209       if (fromp)
2210         *fromp = -r->p;
2211       if (depp)
2212         *depp = pool->solvables[-r->p].name;
2213       return SOLVER_RULE_DISTUPGRADE;
2214     }
2215   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2216     {
2217       if (fromp)
2218         *fromp = -r->p;
2219       if (depp)
2220         *depp = pool->solvables[-r->p].name;
2221       return SOLVER_RULE_INFARCH;
2222     }
2223   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2224     {
2225       return SOLVER_RULE_BEST;
2226     }
2227   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2228     {
2229       return SOLVER_RULE_CHOICE;
2230     }
2231   if (rid >= solv->learntrules)
2232     {
2233       return SOLVER_RULE_LEARNT;
2234     }
2235   return SOLVER_RULE_UNKNOWN;
2236 }
2237
2238 SolverRuleinfo
2239 solver_ruleclass(Solver *solv, Id rid)
2240 {
2241   if (rid <= 0)
2242     return SOLVER_RULE_UNKNOWN;
2243   if (rid > 0 && rid < solv->rpmrules_end)
2244     return SOLVER_RULE_RPM;
2245   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2246     return SOLVER_RULE_JOB;
2247   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2248     return SOLVER_RULE_UPDATE;
2249   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2250     return SOLVER_RULE_FEATURE;
2251   if (rid >= solv->duprules && rid < solv->duprules_end)
2252     return SOLVER_RULE_DISTUPGRADE;
2253   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2254     return SOLVER_RULE_INFARCH;
2255   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2256     return SOLVER_RULE_BEST;
2257   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2258     return SOLVER_RULE_CHOICE;
2259   if (rid >= solv->learntrules)
2260     return SOLVER_RULE_LEARNT;
2261   return SOLVER_RULE_UNKNOWN;
2262 }
2263
2264 void
2265 solver_ruleliterals(Solver *solv, Id rid, Queue *q)
2266 {
2267   Pool *pool = solv->pool;
2268   Id p, pp;
2269   Rule *r;
2270
2271   queue_empty(q);
2272   r = solv->rules + rid;
2273   FOR_RULELITERALS(p, pp, r)
2274     if (p != -SYSTEMSOLVABLE)
2275       queue_push(q, p);
2276   if (!q->count)
2277     queue_push(q, -SYSTEMSOLVABLE);     /* hmm, better to return an empty result? */
2278 }
2279
2280 int
2281 solver_rule2jobidx(Solver *solv, Id rid)
2282 {
2283   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2284     return 0;
2285   return solv->ruletojob.elements[rid - solv->jobrules] + 1;
2286 }
2287
2288 Id
2289 solver_rule2job(Solver *solv, Id rid, Id *whatp)
2290 {
2291   int idx;
2292   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2293     {
2294       if (whatp)
2295         *whatp = 0;
2296       return 0;
2297     }
2298   idx = solv->ruletojob.elements[rid - solv->jobrules];
2299   if (whatp)
2300     *whatp = solv->job.elements[idx + 1];
2301   return solv->job.elements[idx];
2302 }
2303
2304 /* check if the newest versions of pi still provides the dependency we're looking for */
2305 static int
2306 solver_choicerulecheck(Solver *solv, Id pi, Rule *r, Map *m)
2307 {
2308   Pool *pool = solv->pool;
2309   Rule *ur;
2310   Queue q;
2311   Id p, pp, qbuf[32];
2312   int i;
2313
2314   ur = solv->rules + solv->updaterules + (pi - pool->installed->start);
2315   if (!ur->p)
2316     ur = solv->rules + solv->featurerules + (pi - pool->installed->start);
2317   if (!ur->p)
2318     return 0;
2319   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
2320   FOR_RULELITERALS(p, pp, ur)
2321     if (p > 0)
2322       queue_push(&q, p);
2323   if (q.count > 1)
2324     policy_filter_unwanted(solv, &q, POLICY_MODE_CHOOSE);
2325   for (i = 0; i < q.count; i++)
2326     if (MAPTST(m, q.elements[i]))
2327       break;
2328   /* 1: none of the newest versions provide it */
2329   i = i == q.count ? 1 : 0;
2330   queue_free(&q);
2331   return i;
2332 }
2333
2334 void
2335 solver_addchoicerules(Solver *solv)
2336 {
2337   Pool *pool = solv->pool;
2338   Map m, mneg;
2339   Rule *r;
2340   Queue q, qi;
2341   int i, j, rid, havechoice;
2342   Id p, d, pp;
2343   Id p2, pp2;
2344   Solvable *s, *s2;
2345   Id lastaddedp, lastaddedd;
2346   int lastaddedcnt;
2347   unsigned int now;
2348
2349   solv->choicerules = solv->nrules;
2350   if (!pool->installed)
2351     {
2352       solv->choicerules_end = solv->nrules;
2353       return;
2354     }
2355   now = solv_timems(0);
2356   solv->choicerules_ref = solv_calloc(solv->rpmrules_end, sizeof(Id));
2357   queue_init(&q);
2358   queue_init(&qi);
2359   map_init(&m, pool->nsolvables);
2360   map_init(&mneg, pool->nsolvables);
2361   /* set up negative assertion map from infarch and dup rules */
2362   for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
2363     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2364       MAPSET(&mneg, -r->p);
2365   for (rid = solv->duprules, r = solv->rules + rid; rid < solv->duprules_end; rid++, r++)
2366     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2367       MAPSET(&mneg, -r->p);
2368   lastaddedp = 0;
2369   lastaddedd = 0;
2370   lastaddedcnt = 0;
2371   for (rid = 1; rid < solv->rpmrules_end ; rid++)
2372     {
2373       r = solv->rules + rid;
2374       if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 < 0))
2375         continue;       /* only look at requires rules */
2376       /* solver_printrule(solv, SOLV_DEBUG_RESULT, r); */
2377       queue_empty(&q);
2378       queue_empty(&qi);
2379       havechoice = 0;
2380       FOR_RULELITERALS(p, pp, r)
2381         {
2382           if (p < 0)
2383             continue;
2384           s = pool->solvables + p;
2385           if (!s->repo)
2386             continue;
2387           if (s->repo == pool->installed)
2388             {
2389               queue_push(&q, p);
2390               continue;
2391             }
2392           /* check if this package is "blocked" by a installed package */
2393           s2 = 0;
2394           FOR_PROVIDES(p2, pp2, s->name)
2395             {
2396               s2 = pool->solvables + p2;
2397               if (s2->repo != pool->installed)
2398                 continue;
2399               if (!pool->implicitobsoleteusesprovides && s->name != s2->name)
2400                 continue;
2401               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2402                 continue;
2403               break;
2404             }
2405           if (p2)
2406             {
2407               /* found installed package p2 that we can update to p */
2408               if (MAPTST(&mneg, p))
2409                 continue;
2410               if (policy_is_illegal(solv, s2, s, 0))
2411                 continue;
2412 #if 0
2413               if (solver_choicerulecheck(solv, p2, r, &m))
2414                 continue;
2415               queue_push(&qi, p2);
2416 #else
2417               queue_push2(&qi, p2, p);
2418 #endif
2419               queue_push(&q, p);
2420               continue;
2421             }
2422           if (s->obsoletes)
2423             {
2424               Id obs, *obsp = s->repo->idarraydata + s->obsoletes;
2425               s2 = 0;
2426               while ((obs = *obsp++) != 0)
2427                 {
2428                   FOR_PROVIDES(p2, pp2, obs)
2429                     {
2430                       s2 = pool->solvables + p2;
2431                       if (s2->repo != pool->installed)
2432                         continue;
2433                       if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
2434                         continue;
2435                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
2436                         continue;
2437                       break;
2438                     }
2439                   if (p2)
2440                     break;
2441                 }
2442               if (obs)
2443                 {
2444                   /* found installed package p2 that we can update to p */
2445                   if (MAPTST(&mneg, p))
2446                     continue;
2447                   if (policy_is_illegal(solv, s2, s, 0))
2448                     continue;
2449 #if 0
2450                   if (solver_choicerulecheck(solv, p2, r, &m))
2451                     continue;
2452                   queue_push(&qi, p2);
2453 #else
2454                   queue_push2(&qi, p2, p);
2455 #endif
2456                   queue_push(&q, p);
2457                   continue;
2458                 }
2459             }
2460           /* package p is independent of the installed ones */
2461           havechoice = 1;
2462         }
2463       if (!havechoice || !q.count || !qi.count)
2464         continue;       /* no choice */
2465
2466       FOR_RULELITERALS(p, pp, r)
2467         if (p > 0)
2468           MAPSET(&m, p);
2469
2470       /* do extra checking */
2471       for (i = j = 0; i < qi.count; i += 2)
2472         {
2473           p2 = qi.elements[i];
2474           if (!p2)
2475             continue;
2476           if (solver_choicerulecheck(solv, p2, r, &m))
2477             {
2478               /* oops, remove element p from q */
2479               int k, l;
2480               p = qi.elements[i + 1];
2481               for (k = l = 0; k < q.count; k++)
2482                 if (q.elements[k] != p)
2483                   q.elements[l++] = q.elements[k];
2484               queue_truncate(&q, l);
2485               continue;
2486             }
2487           qi.elements[j++] = p2;
2488         }
2489       queue_truncate(&qi, j);
2490       if (!q.count || !qi.count)
2491         {
2492           FOR_RULELITERALS(p, pp, r)
2493             if (p > 0)
2494               MAPCLR(&m, p);
2495           continue;
2496         }
2497
2498
2499       /* now check the update rules of the installed package.
2500        * if all packages of the update rules are contained in
2501        * the dependency rules, there's no need to set up the choice rule */
2502       for (i = 0; i < qi.count; i++)
2503         {
2504           Rule *ur;
2505           if (!qi.elements[i])
2506             continue;
2507           ur = solv->rules + solv->updaterules + (qi.elements[i] - pool->installed->start);
2508           if (!ur->p)
2509             ur = solv->rules + solv->featurerules + (qi.elements[i] - pool->installed->start);
2510           if (!ur->p)
2511             continue;
2512           FOR_RULELITERALS(p, pp, ur)
2513             if (!MAPTST(&m, p))
2514               break;
2515           if (p)
2516             break;
2517           for (j = i + 1; j < qi.count; j++)
2518             if (qi.elements[i] == qi.elements[j])
2519               qi.elements[j] = 0;
2520         }
2521       /* empty map again */
2522       FOR_RULELITERALS(p, pp, r)
2523         if (p > 0)
2524           MAPCLR(&m, p);
2525       if (i == qi.count)
2526         {
2527 #if 0
2528           printf("skipping choice ");
2529           solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2530 #endif
2531           continue;
2532         }
2533
2534       /* don't add identical rules */
2535       if (lastaddedp == r->p && lastaddedcnt == q.count)
2536         {
2537           for (i = 0; i < q.count; i++)
2538             if (q.elements[i] != pool->whatprovidesdata[lastaddedd + i])
2539               break;
2540           if (i == q.count)
2541             continue;   /* already added that one */
2542         }
2543       d = q.count ? pool_queuetowhatprovides(pool, &q) : 0;
2544
2545       lastaddedp = r->p;
2546       lastaddedd = d;
2547       lastaddedcnt = q.count;
2548
2549       solver_addrule(solv, r->p, d);
2550       queue_push(&solv->weakruleq, solv->nrules - 1);
2551       solv->choicerules_ref[solv->nrules - 1 - solv->choicerules] = rid;
2552 #if 0
2553       printf("OLD ");
2554       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
2555       printf("WEAK CHOICE ");
2556       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + solv->nrules - 1);
2557 #endif
2558     }
2559   queue_free(&q);
2560   queue_free(&qi);
2561   map_free(&m);
2562   map_free(&mneg);
2563   solv->choicerules_end = solv->nrules;
2564   /* shrink choicerules_ref */
2565   solv->choicerules_ref = solv_realloc2(solv->choicerules_ref, solv->choicerules_end - solv->choicerules, sizeof(Id));
2566   POOL_DEBUG(SOLV_DEBUG_STATS, "choice rule creation took %d ms\n", solv_timems(now));
2567 }
2568
2569 /* called when a choice rule is disabled by analyze_unsolvable. We also
2570  * have to disable all other choice rules so that the best packages get
2571  * picked */
2572 void
2573 solver_disablechoicerules(Solver *solv, Rule *r)
2574 {
2575   Id rid, p, pp;
2576   Pool *pool = solv->pool;
2577   Map m;
2578   Rule *or;
2579
2580   or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2581   map_init(&m, pool->nsolvables);
2582   FOR_RULELITERALS(p, pp, or)
2583     if (p > 0)
2584       MAPSET(&m, p);
2585   FOR_RULELITERALS(p, pp, r)
2586     if (p > 0)
2587       MAPCLR(&m, p);
2588   for (rid = solv->choicerules; rid < solv->choicerules_end; rid++)
2589     {
2590       r = solv->rules + rid;
2591       if (r->d < 0)
2592         continue;
2593       or = solv->rules + solv->choicerules_ref[(r - solv->rules) - solv->choicerules];
2594       FOR_RULELITERALS(p, pp, or)
2595         if (p > 0 && MAPTST(&m, p))
2596           break;
2597       if (p)
2598         solver_disablerule(solv, r);
2599     }
2600 }
2601
2602 static void
2603 prune_to_update_targets(Solver *solv, Id *cp, Queue *q)
2604 {
2605   int i, j;
2606   Id p, *cp2;
2607   for (i = j = 0; i < q->count; i++)
2608     {
2609       p = q->elements[i];
2610       for (cp2 = cp; *cp2; cp2++)
2611         if (*cp2 == p)
2612           {
2613             q->elements[j++] = p;
2614             break;
2615           }
2616     }
2617   queue_truncate(q, j);
2618 }
2619
2620 static void
2621 prune_to_dup_packages(Solver *solv, Id p, Queue *q)
2622 {
2623   int i, j;
2624   for (i = j = 0; i < q->count; i++)
2625     {
2626       Id p = q->elements[i];
2627       if (MAPTST(&solv->dupmap, p))
2628         q->elements[j++] = p;
2629     }
2630   queue_truncate(q, j);
2631 }
2632
2633 void
2634 solver_addbestrules(Solver *solv, int havebestinstalljobs)
2635 {
2636   Pool *pool = solv->pool;
2637   Id p;
2638   Solvable *s;
2639   Repo *installed = solv->installed;
2640   Queue q, q2;
2641   Rule *r;
2642   Queue r2pkg;
2643   int i, oldcnt;
2644
2645   solv->bestrules = solv->nrules;
2646   if (!installed)
2647     {
2648       solv->bestrules_end = solv->nrules;
2649       return;
2650     }
2651   queue_init(&q);
2652   queue_init(&q2);
2653   queue_init(&r2pkg);
2654
2655   if (havebestinstalljobs)
2656     {
2657       for (i = 0; i < solv->job.count; i += 2)
2658         {
2659           if ((solv->job.elements[i] & (SOLVER_JOBMASK | SOLVER_FORCEBEST)) == (SOLVER_INSTALL | SOLVER_FORCEBEST))
2660             {
2661               int j;
2662               Id p2, pp2;
2663               for (j = 0; j < solv->ruletojob.count; j++)
2664                 if (solv->ruletojob.elements[j] == i)
2665                   break;
2666               if (j == solv->ruletojob.count)
2667                 continue;
2668               r = solv->rules + solv->jobrules + j;
2669               queue_empty(&q);
2670               FOR_RULELITERALS(p2, pp2, r)
2671                 if (p2 > 0)
2672                   queue_push(&q, p2);
2673               if (!q.count)
2674                 continue;       /* orphaned */
2675               /* select best packages, just look at prio and version */
2676               oldcnt = q.count;
2677               policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2678               if (q.count == oldcnt)
2679                 continue;       /* nothing filtered */
2680               p2 = queue_shift(&q);
2681               solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2682               queue_push(&r2pkg, -(solv->jobrules + j));
2683             }
2684         }
2685     }
2686
2687   if (solv->bestupdatemap_all || solv->bestupdatemap.size)
2688     {
2689       FOR_REPO_SOLVABLES(installed, p, s)
2690         {
2691           Id d, p2, pp2;
2692           if (!solv->updatemap_all && (!solv->updatemap.size || !MAPTST(&solv->updatemap, p - installed->start)))
2693             continue;
2694           if (!solv->bestupdatemap_all && (!solv->bestupdatemap.size || !MAPTST(&solv->bestupdatemap, p - installed->start)))
2695             continue;
2696           queue_empty(&q);
2697           if (solv->bestobeypolicy)
2698             r = solv->rules + solv->updaterules + (p - installed->start);
2699           else
2700             {
2701               r = solv->rules + solv->featurerules + (p - installed->start);
2702               if (!r->p)        /* identical to update rule? */
2703                 r = solv->rules + solv->updaterules + (p - installed->start);
2704             }
2705           if (solv->multiversionupdaters && (d = solv->multiversionupdaters[p - installed->start]) != 0 && r == solv->rules + solv->updaterules + (p - installed->start))
2706             {
2707               /* need to check multiversionupdaters */
2708               if (r->p == p)    /* be careful with the dup case */
2709                 queue_push(&q, p);
2710               while ((p2 = pool->whatprovidesdata[d++]) != 0)
2711                 queue_push(&q, p2);
2712             }
2713           else
2714             {
2715               FOR_RULELITERALS(p2, pp2, r)
2716                 if (p2 > 0)
2717                   queue_push(&q, p2);
2718             }
2719           if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2720             prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q);
2721           if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2722             prune_to_dup_packages(solv, p, &q);
2723           /* select best packages, just look at prio and version */
2724           policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
2725           if (!q.count)
2726             continue;   /* orphaned */
2727           if (solv->bestobeypolicy)
2728             {
2729               /* also filter the best of the feature rule packages and add them */
2730               r = solv->rules + solv->featurerules + (p - installed->start);
2731               if (r->p)
2732                 {
2733                   int j;
2734                   queue_empty(&q2);
2735                   FOR_RULELITERALS(p2, pp2, r)
2736                     if (p2 > 0)
2737                       queue_push(&q2, p2);
2738                   if (solv->update_targets && solv->update_targets->elements[p - installed->start])
2739                     prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q2);
2740                   if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
2741                     prune_to_dup_packages(solv, p, &q);
2742                   policy_filter_unwanted(solv, &q2, POLICY_MODE_RECOMMEND);
2743                   for (j = 0; j < q2.count; j++)
2744                     queue_pushunique(&q, q2.elements[j]);
2745                 }
2746             }
2747           p2 = queue_shift(&q);
2748           solver_addrule(solv, p2, q.count ? pool_queuetowhatprovides(pool, &q) : 0);
2749           queue_push(&r2pkg, p);
2750         }
2751     }
2752   if (r2pkg.count)
2753     {
2754       solv->bestrules_pkg = solv_calloc(r2pkg.count, sizeof(Id));
2755       memcpy(solv->bestrules_pkg, r2pkg.elements, r2pkg.count * sizeof(Id));
2756     }
2757   solv->bestrules_end = solv->nrules;
2758   queue_free(&q);
2759   queue_free(&q2);
2760   queue_free(&r2pkg);
2761 }
2762
2763 #undef CLEANDEPSDEBUG
2764
2765 /*
2766  * This functions collects all packages that are looked at
2767  * when a dependency is checked. We need it to "pin" installed
2768  * packages when removing a supplemented package in createcleandepsmap.
2769  * Here's an not uncommon example:
2770  *   A contains "Supplements: packageand(B, C)"
2771  *   B contains "Requires: A"
2772  * Now if we remove C, the supplements is no longer true,
2773  * thus we also remove A. Without the dep_pkgcheck function, we
2774  * would now also remove B, but this is wrong, as adding back
2775  * C doesn't make the supplements true again. Thus we "pin" B
2776  * when we remove A.
2777  * There's probably a better way to do this, but I haven't come
2778  * up with it yet ;)
2779  */
2780 static inline void
2781 dep_pkgcheck(Solver *solv, Id dep, Map *m, Queue *q)
2782 {
2783   Pool *pool = solv->pool;
2784   Id p, pp;
2785
2786   if (ISRELDEP(dep))
2787     {
2788       Reldep *rd = GETRELDEP(pool, dep);
2789       if (rd->flags >= 8)
2790         {
2791           if (rd->flags == REL_AND)
2792             {
2793               dep_pkgcheck(solv, rd->name, m, q);
2794               dep_pkgcheck(solv, rd->evr, m, q);
2795               return;
2796             }
2797           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
2798             return;
2799           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
2800             return;
2801         }
2802     }
2803   FOR_PROVIDES(p, pp, dep)
2804     if (!m || MAPTST(m, p))
2805       queue_push(q, p);
2806 }
2807
2808 static int
2809 check_xsupp(Solver *solv, Queue *depq, Id dep)
2810 {
2811   Pool *pool = solv->pool;
2812   Id p, pp;
2813
2814   if (ISRELDEP(dep))
2815     {
2816       Reldep *rd = GETRELDEP(pool, dep);
2817       if (rd->flags >= 8)
2818         {
2819           if (rd->flags == REL_AND)
2820             {
2821               if (!check_xsupp(solv, depq, rd->name))
2822                 return 0;
2823               return check_xsupp(solv, depq, rd->evr);
2824             }
2825           if (rd->flags == REL_OR)
2826             {
2827               if (check_xsupp(solv, depq, rd->name))
2828                 return 1;
2829               return check_xsupp(solv, depq, rd->evr);
2830             }
2831           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
2832             return solver_splitprovides(solv, rd->evr);
2833           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_INSTALLED)
2834             return solver_dep_installed(solv, rd->evr);
2835         }
2836       if (depq && rd->flags == REL_NAMESPACE)
2837         {
2838           int i;
2839           for (i = 0; i < depq->count; i++)
2840             if (depq->elements[i] == dep || depq->elements[i] == rd->name)
2841              return 1;
2842         }
2843     }
2844   FOR_PROVIDES(p, pp, dep)
2845     if (p == SYSTEMSOLVABLE || pool->solvables[p].repo == solv->installed)
2846       return 1;
2847   return 0;
2848 }
2849
2850 static inline int
2851 queue_contains(Queue *q, Id id)
2852 {
2853   int i;
2854   for (i = 0; i < q->count; i++)
2855     if (q->elements[i] == id)
2856       return 1;
2857   return 0;
2858 }
2859
2860
2861 /*
2862  * Find all installed packages that are no longer
2863  * needed regarding the current solver job.
2864  *
2865  * The algorithm is:
2866  * - remove pass: remove all packages that could have
2867  *   been dragged in by the obsoleted packages.
2868  *   i.e. if package A is obsolete and contains "Requires: B",
2869  *   also remove B, as installing A will have pulled in B.
2870  *   after this pass, we have a set of still installed packages
2871  *   with broken dependencies.
2872  * - add back pass:
2873  *   now add back all packages that the still installed packages
2874  *   require.
2875  *
2876  * The cleandeps packages are the packages removed in the first
2877  * pass and not added back in the second pass.
2878  *
2879  * If we search for unneeded packages (unneeded is true), we
2880  * simply remove all packages except the userinstalled ones in
2881  * the first pass.
2882  */
2883 static void
2884 solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded)
2885 {
2886   Pool *pool = solv->pool;
2887   Repo *installed = solv->installed;
2888   Queue *job = &solv->job;
2889   Map userinstalled;
2890   Map im;
2891   Map installedm;
2892   Rule *r;
2893   Id rid, how, what, select;
2894   Id p, pp, ip, jp;
2895   Id req, *reqp, sup, *supp;
2896   Solvable *s;
2897   Queue iq, iqcopy, xsuppq;
2898   int i;
2899
2900   map_empty(cleandepsmap);
2901   if (!installed || installed->end == installed->start)
2902     return;
2903   map_init(&userinstalled, installed->end - installed->start);
2904   map_init(&im, pool->nsolvables);
2905   map_init(&installedm, pool->nsolvables);
2906   queue_init(&iq);
2907   queue_init(&xsuppq);
2908
2909   for (i = 0; i < job->count; i += 2)
2910     {
2911       how = job->elements[i];
2912       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
2913         {
2914           what = job->elements[i + 1];
2915           select = how & SOLVER_SELECTMASK;
2916           if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
2917             FOR_REPO_SOLVABLES(installed, p, s)
2918               MAPSET(&userinstalled, p - installed->start);
2919           FOR_JOB_SELECT(p, pp, select, what)
2920             if (pool->solvables[p].repo == installed)
2921               MAPSET(&userinstalled, p - installed->start);
2922         }
2923       if ((how & (SOLVER_JOBMASK | SOLVER_SELECTMASK)) == (SOLVER_ERASE | SOLVER_SOLVABLE_PROVIDES))
2924         {
2925           what = job->elements[i + 1];
2926           if (ISRELDEP(what))
2927             {
2928               Reldep *rd = GETRELDEP(pool, what);
2929               if (rd->flags != REL_NAMESPACE)
2930                 continue;
2931               if (rd->evr == 0)
2932                 {
2933                   queue_pushunique(&iq, rd->name);
2934                   continue;
2935                 }
2936               FOR_PROVIDES(p, pp, what)
2937                 if (p)
2938                   break;
2939               if (p)
2940                 continue;
2941               queue_pushunique(&iq, what);
2942             }
2943         }
2944     }
2945
2946   /* have special namespace cleandeps erases */
2947   if (iq.count)
2948     {
2949       for (ip = solv->installed->start; ip < solv->installed->end; ip++)
2950         {
2951           s = pool->solvables + ip;
2952           if (s->repo != installed)
2953             continue;
2954           if (!s->supplements)
2955             continue;
2956           supp = s->repo->idarraydata + s->supplements;
2957           while ((sup = *supp++) != 0)
2958             if (check_xsupp(solv, &iq, sup) && !check_xsupp(solv, 0, sup))
2959               {
2960 #ifdef CLEANDEPSDEBUG
2961                 printf("xsupp %s from %s\n", pool_dep2str(pool, sup), pool_solvid2str(pool, ip));
2962 #endif
2963                 queue_pushunique(&xsuppq, sup);
2964               }
2965         }
2966       queue_empty(&iq);
2967     }
2968
2969   /* also add visible patterns to userinstalled for openSUSE */
2970   if (1)
2971     {
2972       Dataiterator di;
2973       dataiterator_init(&di, pool, 0, 0, SOLVABLE_ISVISIBLE, 0, 0);
2974       while (dataiterator_step(&di))
2975         {
2976           Id *dp;
2977           if (di.solvid <= 0)
2978             continue;
2979           s = pool->solvables + di.solvid;
2980           if (!s->repo || !s->requires)
2981             continue;
2982           if (s->repo != installed && !pool_installable(pool, s))
2983             continue;
2984           if (strncmp(pool_id2str(pool, s->name), "pattern:", 8) != 0)
2985             continue;
2986           dp = s->repo->idarraydata + s->requires;
2987           for (dp = s->repo->idarraydata + s->requires; *dp; dp++)
2988             FOR_PROVIDES(p, pp, *dp)
2989               if (pool->solvables[p].repo == installed)
2990                 {
2991                   if (strncmp(pool_id2str(pool, pool->solvables[p].name), "pattern", 7) != 0)
2992                     continue;
2993                   MAPSET(&userinstalled, p - installed->start);
2994                 }
2995         }
2996       dataiterator_free(&di);
2997     }
2998   if (1)
2999     {
3000       /* all products and their buddies are userinstalled */
3001       for (p = installed->start; p < installed->end; p++)
3002         {
3003           Solvable *s = pool->solvables + p;
3004           if (s->repo != installed)
3005             continue;
3006           if (!strncmp("product:", pool_id2str(pool, s->name), 8))
3007             {
3008               MAPSET(&userinstalled, p - installed->start);
3009               if (pool->nscallback)
3010                 {
3011                   Id buddy = pool->nscallback(pool, pool->nscallbackdata, NAMESPACE_PRODUCTBUDDY, p);
3012                   if (buddy >= installed->start && buddy < installed->end && pool->solvables[buddy].repo == installed)
3013                     MAPSET(&userinstalled, buddy - installed->start);
3014                 }
3015             }
3016         }
3017     }
3018
3019   /* add all positive elements (e.g. locks) to "userinstalled" */
3020   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3021     {
3022       r = solv->rules + rid;
3023       if (r->d < 0)
3024         continue;
3025       i = solv->ruletojob.elements[rid - solv->jobrules];
3026       if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
3027         continue;
3028       FOR_RULELITERALS(p, jp, r)
3029         if (p > 0 && pool->solvables[p].repo == installed)
3030           MAPSET(&userinstalled, p - installed->start);
3031     }
3032
3033   /* add all cleandeps candidates to iq */
3034   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3035     {
3036       r = solv->rules + rid;
3037       if (r->d < 0)                             /* disabled? */
3038         continue;
3039       if (r->d == 0 && r->p < 0 && r->w2 == 0)  /* negative assertion (erase job)? */
3040         {
3041           p = -r->p;
3042           if (pool->solvables[p].repo != installed)
3043             continue;
3044           MAPCLR(&userinstalled, p - installed->start);
3045           if (unneeded)
3046             continue;
3047           i = solv->ruletojob.elements[rid - solv->jobrules];
3048           how = job->elements[i];
3049           if ((how & (SOLVER_JOBMASK|SOLVER_CLEANDEPS)) == (SOLVER_ERASE|SOLVER_CLEANDEPS))
3050             queue_push(&iq, p);
3051         }
3052       else if (r->p > 0)                        /* install job */
3053         {
3054           if (unneeded)
3055             continue;
3056           i = solv->ruletojob.elements[rid - solv->jobrules];
3057           if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
3058             {
3059               /* check if the literals all obsolete some installed package */
3060               Map om;
3061               int iqstart;
3062
3063               /* just one installed literal */
3064               if (r->d == 0 && r->w2 == 0 && pool->solvables[r->p].repo == installed)
3065                 continue;
3066               /* multiversion is bad */
3067               if (solv->multiversion.size && !solv->keepexplicitobsoletes)
3068                 {
3069                   FOR_RULELITERALS(p, jp, r)
3070                     if (MAPTST(&solv->multiversion, p))
3071                       break;
3072                   if (p)
3073                     continue;
3074                 }
3075
3076               om.size = 0;
3077               iqstart = iq.count;
3078               FOR_RULELITERALS(p, jp, r)
3079                 {
3080                   if (p < 0)
3081                     {
3082                       queue_truncate(&iq, iqstart);     /* abort */
3083                       break;
3084                     }
3085                   if (pool->solvables[p].repo == installed)
3086                     {
3087                       if (iq.count == iqstart)
3088                         queue_push(&iq, p);
3089                       else
3090                         {
3091                           for (i = iqstart; i < iq.count; i++)
3092                             if (iq.elements[i] == p)
3093                               break;
3094                           queue_truncate(&iq, iqstart);
3095                           if (i < iq.count)
3096                             queue_push(&iq, p);
3097                         }
3098                     }
3099                   else
3100                     intersect_obsoletes(solv, p, &iq, iqstart, &om);
3101                   if (iq.count == iqstart)
3102                     break;
3103                 }
3104               if (om.size)
3105                 map_free(&om);
3106             }
3107         }
3108     }
3109   queue_init_clone(&iqcopy, &iq);
3110
3111   if (!unneeded)
3112     {
3113       if (solv->cleandeps_updatepkgs)
3114         for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
3115           queue_push(&iq, solv->cleandeps_updatepkgs->elements[i]);
3116     }
3117
3118   if (unneeded)
3119     queue_empty(&iq);   /* just in case... */
3120
3121   /* clear userinstalled bit for the packages we really want to delete/update */
3122   for (i = 0; i < iq.count; i++)
3123     {
3124       p = iq.elements[i];
3125       if (pool->solvables[p].repo != installed)
3126         continue;
3127       MAPCLR(&userinstalled, p - installed->start);
3128     }
3129
3130   for (p = installed->start; p < installed->end; p++)
3131     {
3132       if (pool->solvables[p].repo != installed)
3133         continue;
3134       MAPSET(&installedm, p);
3135       if (unneeded && !MAPTST(&userinstalled, p - installed->start))
3136         continue;
3137       MAPSET(&im, p);
3138     }
3139   MAPSET(&installedm, SYSTEMSOLVABLE);
3140   MAPSET(&im, SYSTEMSOLVABLE);
3141
3142 #ifdef CLEANDEPSDEBUG
3143   printf("REMOVE PASS\n");
3144 #endif
3145
3146   for (;;)
3147     {
3148       if (!iq.count)
3149         {
3150           if (unneeded)
3151             break;
3152           /* supplements pass */
3153           for (ip = installed->start; ip < installed->end; ip++)
3154             {
3155               if (!MAPTST(&installedm, ip))
3156                 continue;
3157               s = pool->solvables + ip;
3158               if (!s->supplements)
3159                 continue;
3160               if (!MAPTST(&im, ip))
3161                 continue;
3162               if (MAPTST(&userinstalled, ip - installed->start))
3163                 continue;
3164               supp = s->repo->idarraydata + s->supplements;
3165               while ((sup = *supp++) != 0)
3166                 if (dep_possible(solv, sup, &im))
3167                   break;
3168               if (!sup)
3169                 {
3170                   supp = s->repo->idarraydata + s->supplements;
3171                   while ((sup = *supp++) != 0)
3172                     if (dep_possible(solv, sup, &installedm) || (xsuppq.count && queue_contains(&xsuppq, sup)))
3173                       {
3174                         /* no longer supplemented, also erase */
3175                         int iqcount = iq.count;
3176                         /* pin packages, see comment above dep_pkgcheck */
3177                         dep_pkgcheck(solv, sup, &im, &iq);
3178                         for (i = iqcount; i < iq.count; i++)
3179                           {
3180                             Id pqp = iq.elements[i];
3181                             if (pool->solvables[pqp].repo == installed)
3182                               MAPSET(&userinstalled, pqp - installed->start);
3183                           }
3184                         queue_truncate(&iq, iqcount);
3185 #ifdef CLEANDEPSDEBUG
3186                         printf("%s supplemented [%s]\n", pool_solvid2str(pool, ip), pool_dep2str(pool, sup));
3187 #endif
3188                         queue_push(&iq, ip);
3189                       }
3190                 }
3191             }
3192           if (!iq.count)
3193             break;      /* no supplementing package found, we're done */
3194         }
3195       ip = queue_shift(&iq);
3196       s = pool->solvables + ip;
3197       if (!MAPTST(&im, ip))
3198         continue;
3199       if (!MAPTST(&installedm, ip))
3200         continue;
3201       if (s->repo == installed && MAPTST(&userinstalled, ip - installed->start))
3202         continue;
3203       MAPCLR(&im, ip);
3204 #ifdef CLEANDEPSDEBUG
3205       printf("removing %s\n", pool_solvable2str(pool, s));
3206 #endif
3207       if (s->requires)
3208         {
3209           reqp = s->repo->idarraydata + s->requires;
3210           while ((req = *reqp++) != 0)
3211             {
3212               if (req == SOLVABLE_PREREQMARKER)
3213                 continue;
3214 #if 0
3215               /* count number of installed packages that match */
3216               count = 0;
3217               FOR_PROVIDES(p, pp, req)
3218                 if (MAPTST(&installedm, p))
3219                   count++;
3220               if (count > 1)
3221                 continue;
3222 #endif
3223               FOR_PROVIDES(p, pp, req)
3224                 {
3225                   if (p != SYSTEMSOLVABLE && MAPTST(&im, p))
3226                     {
3227 #ifdef CLEANDEPSDEBUG
3228                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3229 #endif
3230                       queue_push(&iq, p);
3231                     }
3232                 }
3233             }
3234         }
3235       if (s->recommends)
3236         {
3237           reqp = s->repo->idarraydata + s->recommends;
3238           while ((req = *reqp++) != 0)
3239             {
3240 #if 0
3241               count = 0;
3242               FOR_PROVIDES(p, pp, req)
3243                 if (MAPTST(&installedm, p))
3244                   count++;
3245               if (count > 1)
3246                 continue;
3247 #endif
3248               FOR_PROVIDES(p, pp, req)
3249                 {
3250                   if (p != SYSTEMSOLVABLE && MAPTST(&im, p))
3251                     {
3252 #ifdef CLEANDEPSDEBUG
3253                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3254 #endif
3255                       queue_push(&iq, p);
3256                     }
3257                 }
3258             }
3259         }
3260     }
3261
3262   /* turn userinstalled into remove set for pruning */
3263   map_empty(&userinstalled);
3264   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3265     {
3266       r = solv->rules + rid;
3267       if (r->p >= 0 || r->d != 0 || r->w2 != 0)
3268         continue;       /* disabled or not erase */
3269       p = -r->p;
3270       MAPCLR(&im, p);
3271       if (pool->solvables[p].repo == installed)
3272         MAPSET(&userinstalled, p - installed->start);
3273     }
3274   MAPSET(&im, SYSTEMSOLVABLE);  /* in case we cleared it above */
3275   for (p = installed->start; p < installed->end; p++)
3276     if (MAPTST(&im, p))
3277       queue_push(&iq, p);
3278   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
3279     {
3280       r = solv->rules + rid;
3281       if (r->d < 0)
3282         continue;
3283       FOR_RULELITERALS(p, jp, r)
3284         if (p > 0)
3285           queue_push(&iq, p);
3286     }
3287   /* also put directly addressed packages on the install queue
3288    * so we can mark patterns as installed */
3289   for (i = 0; i < job->count; i += 2)
3290     {
3291       how = job->elements[i];
3292       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
3293         {
3294           what = job->elements[i + 1];
3295           select = how & SOLVER_SELECTMASK;
3296           if (select == SOLVER_SOLVABLE && pool->solvables[what].repo != installed)
3297             queue_push(&iq, what);
3298         }
3299     }
3300
3301 #ifdef CLEANDEPSDEBUG
3302   printf("ADDBACK PASS\n");
3303 #endif
3304   for (;;)
3305     {
3306       if (!iq.count)
3307         {
3308           /* supplements pass */
3309           for (ip = installed->start; ip < installed->end; ip++)
3310             {
3311               if (!MAPTST(&installedm, ip))
3312                 continue;
3313               if (MAPTST(&userinstalled, ip - installed->start))
3314                 continue;
3315               s = pool->solvables + ip;
3316               if (!s->supplements)
3317                 continue;
3318               if (MAPTST(&im, ip))
3319                 continue;
3320               supp = s->repo->idarraydata + s->supplements;
3321               while ((sup = *supp++) != 0)
3322                 if (dep_possible(solv, sup, &im))
3323                   break;
3324               if (sup)
3325                 {
3326 #ifdef CLEANDEPSDEBUG
3327                   printf("%s supplemented\n", pool_solvid2str(pool, ip));
3328 #endif
3329                   MAPSET(&im, ip);
3330                   queue_push(&iq, ip);
3331                 }
3332             }
3333           if (!iq.count)
3334             break;
3335         }
3336       ip = queue_shift(&iq);
3337       s = pool->solvables + ip;
3338 #ifdef CLEANDEPSDEBUG
3339       printf("adding back %s\n", pool_solvable2str(pool, s));
3340 #endif
3341       if (s->requires)
3342         {
3343           reqp = s->repo->idarraydata + s->requires;
3344           while ((req = *reqp++) != 0)
3345             {
3346               FOR_PROVIDES(p, pp, req)
3347                 if (MAPTST(&im, p))
3348                   break;
3349               if (p)
3350                 continue;
3351               FOR_PROVIDES(p, pp, req)
3352                 {
3353                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3354                     {
3355                       if (p == ip)
3356                         continue;
3357                       if (MAPTST(&userinstalled, p - installed->start))
3358                         continue;
3359 #ifdef CLEANDEPSDEBUG
3360                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3361 #endif
3362                       MAPSET(&im, p);
3363                       queue_push(&iq, p);
3364                     }
3365                 }
3366             }
3367         }
3368       if (s->recommends)
3369         {
3370           reqp = s->repo->idarraydata + s->recommends;
3371           while ((req = *reqp++) != 0)
3372             {
3373               FOR_PROVIDES(p, pp, req)
3374                 if (MAPTST(&im, p))
3375                   break;
3376               if (p)
3377                 continue;
3378               FOR_PROVIDES(p, pp, req)
3379                 {
3380                   if (!MAPTST(&im, p) && MAPTST(&installedm, p))
3381                     {
3382                       if (p == ip)
3383                         continue;
3384                       if (MAPTST(&userinstalled, p - installed->start))
3385                         continue;
3386 #ifdef CLEANDEPSDEBUG
3387                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
3388 #endif
3389                       MAPSET(&im, p);
3390                       queue_push(&iq, p);
3391                     }
3392                 }
3393             }
3394         }
3395     }
3396
3397   queue_free(&iq);
3398   /* make sure the updatepkgs and mistakes are not in the cleandeps map */
3399   if (solv->cleandeps_updatepkgs)
3400     for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
3401       MAPSET(&im, solv->cleandeps_updatepkgs->elements[i]);
3402   if (solv->cleandeps_mistakes)
3403     for (i = 0; i < solv->cleandeps_mistakes->count; i++)
3404       MAPSET(&im, solv->cleandeps_mistakes->elements[i]);
3405   /* also remove original iq packages */
3406   for (i = 0; i < iqcopy.count; i++)
3407     MAPSET(&im, iqcopy.elements[i]);
3408   queue_free(&iqcopy);
3409   for (p = installed->start; p < installed->end; p++)
3410     {
3411       if (pool->solvables[p].repo != installed)
3412         continue;
3413       if (!MAPTST(&im, p))
3414         MAPSET(cleandepsmap, p - installed->start);
3415     }
3416   map_free(&im);
3417   map_free(&installedm);
3418   map_free(&userinstalled);
3419   queue_free(&xsuppq);
3420 #ifdef CLEANDEPSDEBUG
3421   printf("=== final cleandeps map:\n");
3422   for (p = installed->start; p < installed->end; p++)
3423     if (MAPTST(cleandepsmap, p - installed->start))
3424       printf("  - %s\n", pool_solvid2str(pool, p));
3425 #endif
3426 }
3427
3428
3429 struct trj_data {
3430   Queue *edges;
3431   Id *low;
3432   Id idx;
3433   Id nstack;
3434   Id firstidx;
3435 };
3436
3437 /* Tarjan's SCC algorithm, slightly modifed */
3438 static void
3439 trj_visit(struct trj_data *trj, Id node)
3440 {
3441   Id *low = trj->low;
3442   Queue *edges = trj->edges;
3443   Id nnode, myidx, stackstart;
3444   int i;
3445
3446   low[node] = myidx = trj->idx++;
3447   low[(stackstart = trj->nstack++)] = node;
3448   for (i = edges->elements[node]; (nnode = edges->elements[i]) != 0; i++)
3449     {
3450       Id l = low[nnode];
3451       if (!l)
3452         {
3453           if (!edges->elements[edges->elements[nnode]])
3454             {
3455               trj->idx++;
3456               low[nnode] = -1;
3457               continue;
3458             }
3459           trj_visit(trj, nnode);
3460           l = low[nnode];
3461         }
3462       if (l < 0)
3463         continue;
3464       if (l < trj->firstidx)
3465         {
3466           int k;
3467           for (k = l; low[low[k]] == l; k++)
3468             low[low[k]] = -1;
3469         }
3470       else if (l < low[node])
3471         low[node] = l;
3472     }
3473   if (low[node] == myidx)
3474     {
3475       if (myidx != trj->firstidx)
3476         myidx = -1;
3477       for (i = stackstart; i < trj->nstack; i++)
3478         low[low[i]] = myidx;
3479       trj->nstack = stackstart;
3480     }
3481 }
3482
3483
3484 void
3485 solver_get_unneeded(Solver *solv, Queue *unneededq, int filtered)
3486 {
3487   Repo *installed = solv->installed;
3488   int i;
3489   Map cleandepsmap;
3490
3491   queue_empty(unneededq);
3492   if (!installed || installed->end == installed->start)
3493     return;
3494
3495   map_init(&cleandepsmap, installed->end - installed->start);
3496   solver_createcleandepsmap(solv, &cleandepsmap, 1);
3497   for (i = installed->start; i < installed->end; i++)
3498     if (MAPTST(&cleandepsmap, i - installed->start))
3499       queue_push(unneededq, i);
3500
3501   if (filtered && unneededq->count > 1)
3502     {
3503       Pool *pool = solv->pool;
3504       Queue edges;
3505       Id *nrequires;
3506       Map installedm;
3507       int j, pass, count = unneededq->count;
3508       Id *low;
3509
3510       map_init(&installedm, pool->nsolvables);
3511       for (i = installed->start; i < installed->end; i++)
3512         if (pool->solvables[i].repo == installed)
3513           MAPSET(&installedm, i);
3514
3515       nrequires = solv_calloc(count, sizeof(Id));
3516       queue_init(&edges);
3517       queue_prealloc(&edges, count * 4 + 10);   /* pre-size */
3518
3519       /*
3520        * Go through the solvables in the nodes queue and create edges for
3521        * all requires/recommends/supplements between the nodes.
3522        * The edges are stored in the edges queue, we add 1 to the node
3523        * index so that nodes in the edges queue are != 0 and we can
3524        * terminate the edge list with 0.
3525        * Thus for node element 5, the edges are stored starting at
3526        * edges.elements[6] and are 0-terminated.
3527        */
3528       /* leave first element zero to make things easier */
3529       /* also add trailing zero */
3530       queue_insertn(&edges, 0, 1 + count + 1);
3531
3532       /* first requires and recommends */
3533       for (i = 0; i < count; i++)
3534         {
3535           Solvable *s = pool->solvables + unneededq->elements[i];
3536           edges.elements[i + 1] = edges.count;
3537           for (pass = 0; pass < 2; pass++)
3538             {
3539               int num = 0;
3540               unsigned int off = pass == 0 ? s->requires : s->recommends;
3541               Id p, pp, *dp;
3542               if (off)
3543                 for (dp = s->repo->idarraydata + off; *dp; dp++)
3544                   FOR_PROVIDES(p, pp, *dp)
3545                     {
3546                       Solvable *sp = pool->solvables + p;
3547                       if (s == sp || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3548                         continue;
3549                       for (j = 0; j < count; j++)
3550                         if (p == unneededq->elements[j])
3551                           break;
3552                       if (j == count)
3553                         continue;
3554                       if (num && edges.elements[edges.count - 1] == j + 1)
3555                         continue;
3556                       queue_push(&edges, j + 1);
3557                       num++;
3558                     }
3559                 if (pass == 0)
3560                   nrequires[i] = num;
3561             }
3562           queue_push(&edges, 0);
3563         }
3564 #if 0
3565       printf("requires + recommends\n");
3566       for (i = 0; i < count; i++)
3567         {
3568           int j;
3569           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3570           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3571             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3572         }
3573 #endif
3574
3575       /* then add supplements */
3576       for (i = 0; i < count; i++)
3577         {
3578           Solvable *s = pool->solvables + unneededq->elements[i];
3579           if (s->supplements)
3580             {
3581               Id *dp;
3582               int k;
3583               for (dp = s->repo->idarraydata + s->supplements; *dp; dp++)
3584                 if (dep_possible(solv, *dp, &installedm))
3585                   {
3586                     Queue iq;
3587                     Id iqbuf[16];
3588                     queue_init_buffer(&iq, iqbuf, sizeof(iqbuf)/sizeof(*iqbuf));
3589                     dep_pkgcheck(solv, *dp, 0, &iq);
3590                     for (k = 0; k < iq.count; k++)
3591                       {
3592                         Id p = iq.elements[k];
3593                         Solvable *sp = pool->solvables + p;
3594                         if (p == unneededq->elements[i] || sp->repo != installed || !MAPTST(&cleandepsmap, p - installed->start))
3595                           continue;
3596                         for (j = 0; j < count; j++)
3597                           if (p == unneededq->elements[j])
3598                             break;
3599                         /* now add edge from j + 1 to i + 1 */
3600                         queue_insert(&edges, edges.elements[j + 1] + nrequires[j], i + 1);
3601                         /* addapt following edge pointers */
3602                         for (k = j + 2; k < count + 2; k++)
3603                           edges.elements[k]++;
3604                       }
3605                     queue_free(&iq);
3606                   }
3607             }
3608         }
3609 #if 0
3610       /* print result */
3611       printf("+ supplements\n");
3612       for (i = 0; i < count; i++)
3613         {
3614           int j;
3615           printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
3616           for (j = edges.elements[i + 1]; edges.elements[j]; j++)
3617             printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
3618     }
3619 #endif
3620       map_free(&installedm);
3621
3622       /* now run SCC algo two times, first with requires+recommends+supplements,
3623        * then again without the requires. We run it the second time to get rid
3624        * of packages that got dragged in via recommends/supplements */
3625       /*
3626        * low will contain the result of the SCC search.
3627        * it must be of at least size 2 * (count + 1) and
3628        * must be zero initialized.
3629        * The layout is:
3630        *    0  low low ... low stack stack ...stack 0
3631        *            count              count
3632        */
3633       low = solv_calloc(count + 1, 2 * sizeof(Id));
3634       for (pass = 0; pass < 2; pass++)
3635         {
3636           struct trj_data trj;
3637           if (pass)
3638             {
3639               memset(low, 0, (count + 1) * (2 * sizeof(Id)));
3640               for (i = 0; i < count; i++)
3641                 {
3642                   edges.elements[i + 1] += nrequires[i];
3643                   if (!unneededq->elements[i])
3644                     low[i + 1] = -1;    /* ignore this node */
3645                 }
3646             }
3647           trj.edges = &edges;
3648           trj.low = low;
3649           trj.idx = count + 1;  /* stack starts here */
3650           for (i = 1; i <= count; i++)
3651             {
3652               if (low[i])
3653                 continue;
3654               if (edges.elements[edges.elements[i]])
3655                 {
3656                   trj.firstidx = trj.nstack = trj.idx;
3657                   trj_visit(&trj, i);
3658                 }
3659               else
3660                 {
3661                   Id myidx = trj.idx++;
3662                   low[i] = myidx;
3663                   low[myidx] = i;
3664                 }
3665             }
3666           /* prune packages */
3667           for (i = 0; i < count; i++)
3668             if (low[i + 1] <= 0)
3669               unneededq->elements[i] = 0;
3670         }
3671       solv_free(low);
3672       solv_free(nrequires);
3673       queue_free(&edges);
3674
3675       /* finally remove all pruned entries from unneededq */
3676       for (i = j = 0; i < count; i++)
3677         if (unneededq->elements[i])
3678           unneededq->elements[j++] = unneededq->elements[i];
3679       queue_truncate(unneededq, j);
3680     }
3681   map_free(&cleandepsmap);
3682 }
3683
3684 /* EOF */