1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
5 """Presubmit script for changes affecting chrome/
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl.
13 INCLUDE_CPP_FILES_ONLY = (
18 # Objective C confuses everything.
22 # All the messages files do weird multiple include trickery
24 r'render_messages.h$',
25 # Autogenerated window resources files are off limits
30 r'sigslotrepeater\.h$',
31 # GCC attribute trickery
36 r'nss_decryptor_linux\.cc$',
37 # Has safe printf usage that cpplint complains about
38 r'safe_browsing_util\.cc$',
40 r'renderer_webkitplatformsupport_impl\.cc$',
45 def _CheckChangeLintsClean(input_api, output_api):
46 """Makes sure that the chrome/ code is cpplint clean."""
47 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDE
48 sources = lambda x: input_api.FilterSourceFile(
49 x, white_list=INCLUDE_CPP_FILES_ONLY, black_list=black_list)
50 return input_api.canned_checks.CheckChangeLintsClean(
51 input_api, output_api, sources)
53 def _CheckNoContentUnitTestsInChrome(input_api, output_api):
54 """Makes sure that no unit tests from content/ are included in unit_tests."""
56 for f in input_api.AffectedFiles():
57 if not f.LocalPath().endswith('chrome_tests.gypi'):
60 for line_num, line in f.ChangedContents():
61 m = re.search(r"'(.*\/content\/.*unittest.*)'", line)
63 problems.append(m.group(1))
67 return [output_api.PresubmitPromptWarning(
68 'Unit tests located in content/ should be added to the ' +
69 'content_tests.gypi:content_unittests target.',
72 def _CommonChecks(input_api, output_api):
73 """Checks common to both upload and commit."""
75 results.extend(_CheckNoContentUnitTestsInChrome(input_api, output_api))
78 def CheckChangeOnUpload(input_api, output_api):
80 results.extend(_CommonChecks(input_api, output_api))
81 results.extend(_CheckChangeLintsClean(input_api, output_api))
84 def CheckChangeOnCommit(input_api, output_api):
86 results.extend(_CommonChecks(input_api, output_api))