src/build_test.cc

   1 // Copyright 2011 Google Inc. All Rights Reserved.
   2 //
   3 // Licensed under the Apache License, Version 2.0 (the "License");
   4 // you may not use this file except in compliance with the License.
   5 // You may obtain a copy of the License at
   6 //
   7 //     http://www.apache.org/licenses/LICENSE-2.0
   8 //
   9 // Unless required by applicable law or agreed to in writing, software
  10 // distributed under the License is distributed on an "AS IS" BASIS,
  11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12 // See the License for the specific language governing permissions and
  13 // limitations under the License.
  14
  15 #include "build.h"
  16
  17 #include <assert.h>
  18
  19 #include "build_log.h"
  20 #include "deps_log.h"
  21 #include "graph.h"
  22 #include "test.h"
  23
  24 /// Fixture for tests involving Plan.
  25 // Though Plan doesn't use State, it's useful to have one around
  26 // to create Nodes and Edges.
  27 struct PlanTest : public StateTestWithBuiltinRules {
  28   Plan plan_;
  29
  30   /// Because FindWork does not return Edges in any sort of predictable order,
  31   // provide a means to get available Edges in order and in a format which is
  32   // easy to write tests around.
  33   void FindWorkSorted(deque<Edge*>* ret, int count) {
  34     struct CompareEdgesByOutput {
  35       static bool cmp(const Edge* a, const Edge* b) {
  36         return a->outputs_[0]->path() < b->outputs_[0]->path();
  37       }
  38     };
  39
  40     for (int i = 0; i < count; ++i) {
  41       ASSERT_TRUE(plan_.more_to_do());
  42       Edge* edge = plan_.FindWork();
  43       ASSERT_TRUE(edge);
  44       ret->push_back(edge);
  45     }
  46     ASSERT_FALSE(plan_.FindWork());
  47     sort(ret->begin(), ret->end(), CompareEdgesByOutput::cmp);
  48   }
  49
  50   void TestPoolWithDepthOne(const char *test_case);
  51 };
  52
  53 TEST_F(PlanTest, Basic) {
  54   AssertParse(&state_,
  55 "build out: cat mid\n"
  56 "build mid: cat in\n");
  57   GetNode("mid")->MarkDirty();
  58   GetNode("out")->MarkDirty();
  59   string err;
  60   EXPECT_TRUE(plan_.AddTarget(GetNode("out"), &err));
  61   ASSERT_EQ("", err);
  62   ASSERT_TRUE(plan_.more_to_do());
  63
  64   Edge* edge = plan_.FindWork();
  65   ASSERT_TRUE(edge);
  66   ASSERT_EQ("in",  edge->inputs_[0]->path());
  67   ASSERT_EQ("mid", edge->outputs_[0]->path());
  68
  69   ASSERT_FALSE(plan_.FindWork());
  70
  71   plan_.EdgeFinished(edge);
  72
  73   edge = plan_.FindWork();
  74   ASSERT_TRUE(edge);
  75   ASSERT_EQ("mid", edge->inputs_[0]->path());
  76   ASSERT_EQ("out", edge->outputs_[0]->path());
  77
  78   plan_.EdgeFinished(edge);
  79
  80   ASSERT_FALSE(plan_.more_to_do());
  81   edge = plan_.FindWork();
  82   ASSERT_EQ(0, edge);
  83 }
  84
  85 // Test that two outputs from one rule can be handled as inputs to the next.
  86 TEST_F(PlanTest, DoubleOutputDirect) {
  87   AssertParse(&state_,
  88 "build out: cat mid1 mid2\n"
  89 "build mid1 mid2: cat in\n");
  90   GetNode("mid1")->MarkDirty();
  91   GetNode("mid2")->MarkDirty();
  92   GetNode("out")->MarkDirty();
  93
  94   string err;
  95   EXPECT_TRUE(plan_.AddTarget(GetNode("out"), &err));
  96   ASSERT_EQ("", err);
  97   ASSERT_TRUE(plan_.more_to_do());
  98
  99   Edge* edge;
 100   edge = plan_.FindWork();
 101   ASSERT_TRUE(edge);  // cat in
 102   plan_.EdgeFinished(edge);
 103
 104   edge = plan_.FindWork();
 105   ASSERT_TRUE(edge);  // cat mid1 mid2
 106   plan_.EdgeFinished(edge);
 107
 108   edge = plan_.FindWork();
 109   ASSERT_FALSE(edge);  // done
 110 }
 111
 112 // Test that two outputs from one rule can eventually be routed to another.
 113 TEST_F(PlanTest, DoubleOutputIndirect) {
 114   AssertParse(&state_,
 115 "build out: cat b1 b2\n"
 116 "build b1: cat a1\n"
 117 "build b2: cat a2\n"
 118 "build a1 a2: cat in\n");
 119   GetNode("a1")->MarkDirty();
 120   GetNode("a2")->MarkDirty();
 121   GetNode("b1")->MarkDirty();
 122   GetNode("b2")->MarkDirty();
 123   GetNode("out")->MarkDirty();
 124   string err;
 125   EXPECT_TRUE(plan_.AddTarget(GetNode("out"), &err));
 126   ASSERT_EQ("", err);
 127   ASSERT_TRUE(plan_.more_to_do());
 128
 129   Edge* edge;
 130   edge = plan_.FindWork();
 131   ASSERT_TRUE(edge);  // cat in
 132   plan_.EdgeFinished(edge);
 133
 134   edge = plan_.FindWork();
 135   ASSERT_TRUE(edge);  // cat a1
 136   plan_.EdgeFinished(edge);
 137
 138   edge = plan_.FindWork();
 139   ASSERT_TRUE(edge);  // cat a2
 140   plan_.EdgeFinished(edge);
 141
 142   edge = plan_.FindWork();
 143   ASSERT_TRUE(edge);  // cat b1 b2
 144   plan_.EdgeFinished(edge);
 145
 146   edge = plan_.FindWork();
 147   ASSERT_FALSE(edge);  // done
 148 }
 149
 150 // Test that two edges from one output can both execute.
 151 TEST_F(PlanTest, DoubleDependent) {
 152   AssertParse(&state_,
 153 "build out: cat a1 a2\n"
 154 "build a1: cat mid\n"
 155 "build a2: cat mid\n"
 156 "build mid: cat in\n");
 157   GetNode("mid")->MarkDirty();
 158   GetNode("a1")->MarkDirty();
 159   GetNode("a2")->MarkDirty();
 160   GetNode("out")->MarkDirty();
 161
 162   string err;
 163   EXPECT_TRUE(plan_.AddTarget(GetNode("out"), &err));
 164   ASSERT_EQ("", err);
 165   ASSERT_TRUE(plan_.more_to_do());
 166
 167   Edge* edge;
 168   edge = plan_.FindWork();
 169   ASSERT_TRUE(edge);  // cat in
 170   plan_.EdgeFinished(edge);
 171
 172   edge = plan_.FindWork();
 173   ASSERT_TRUE(edge);  // cat mid
 174   plan_.EdgeFinished(edge);
 175
 176   edge = plan_.FindWork();
 177   ASSERT_TRUE(edge);  // cat mid
 178   plan_.EdgeFinished(edge);
 179
 180   edge = plan_.FindWork();
 181   ASSERT_TRUE(edge);  // cat a1 a2
 182   plan_.EdgeFinished(edge);
 183
 184   edge = plan_.FindWork();
 185   ASSERT_FALSE(edge);  // done
 186 }
 187
 188 TEST_F(PlanTest, DependencyCycle) {
 189   AssertParse(&state_,
 190 "build out: cat mid\n"
 191 "build mid: cat in\n"
 192 "build in: cat pre\n"
 193 "build pre: cat out\n");
 194   GetNode("out")->MarkDirty();
 195   GetNode("mid")->MarkDirty();
 196   GetNode("in")->MarkDirty();
 197   GetNode("pre")->MarkDirty();
 198
 199   string err;
 200   EXPECT_FALSE(plan_.AddTarget(GetNode("out"), &err));
 201   ASSERT_EQ("dependency cycle: out -> mid -> in -> pre -> out", err);
 202 }
 203
 204 void PlanTest::TestPoolWithDepthOne(const char* test_case) {
 205   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_, test_case));
 206   GetNode("out1")->MarkDirty();
 207   GetNode("out2")->MarkDirty();
 208   string err;
 209   EXPECT_TRUE(plan_.AddTarget(GetNode("out1"), &err));
 210   ASSERT_EQ("", err);
 211   EXPECT_TRUE(plan_.AddTarget(GetNode("out2"), &err));
 212   ASSERT_EQ("", err);
 213   ASSERT_TRUE(plan_.more_to_do());
 214
 215   Edge* edge = plan_.FindWork();
 216   ASSERT_TRUE(edge);
 217   ASSERT_EQ("in",  edge->inputs_[0]->path());
 218   ASSERT_EQ("out1", edge->outputs_[0]->path());
 219
 220   // This will be false since poolcat is serialized
 221   ASSERT_FALSE(plan_.FindWork());
 222
 223   plan_.EdgeFinished(edge);
 224
 225   edge = plan_.FindWork();
 226   ASSERT_TRUE(edge);
 227   ASSERT_EQ("in", edge->inputs_[0]->path());
 228   ASSERT_EQ("out2", edge->outputs_[0]->path());
 229
 230   ASSERT_FALSE(plan_.FindWork());
 231
 232   plan_.EdgeFinished(edge);
 233
 234   ASSERT_FALSE(plan_.more_to_do());
 235   edge = plan_.FindWork();
 236   ASSERT_EQ(0, edge);
 237 }
 238
 239 TEST_F(PlanTest, PoolWithDepthOne) {
 240   TestPoolWithDepthOne(
 241 "pool foobar\n"
 242 "  depth = 1\n"
 243 "rule poolcat\n"
 244 "  command = cat $in > $out\n"
 245 "  pool = foobar\n"
 246 "build out1: poolcat in\n"
 247 "build out2: poolcat in\n");
 248 }
 249
 250 TEST_F(PlanTest, ConsolePool) {
 251   TestPoolWithDepthOne(
 252 "rule poolcat\n"
 253 "  command = cat $in > $out\n"
 254 "  pool = console\n"
 255 "build out1: poolcat in\n"
 256 "build out2: poolcat in\n");
 257 }
 258
 259 TEST_F(PlanTest, PoolsWithDepthTwo) {
 260   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 261 "pool foobar\n"
 262 "  depth = 2\n"
 263 "pool bazbin\n"
 264 "  depth = 2\n"
 265 "rule foocat\n"
 266 "  command = cat $in > $out\n"
 267 "  pool = foobar\n"
 268 "rule bazcat\n"
 269 "  command = cat $in > $out\n"
 270 "  pool = bazbin\n"
 271 "build out1: foocat in\n"
 272 "build out2: foocat in\n"
 273 "build out3: foocat in\n"
 274 "build outb1: bazcat in\n"
 275 "build outb2: bazcat in\n"
 276 "build outb3: bazcat in\n"
 277 "  pool =\n"
 278 "build allTheThings: cat out1 out2 out3 outb1 outb2 outb3\n"
 279 ));
 280   // Mark all the out* nodes dirty
 281   for (int i = 0; i < 3; ++i) {
 282     GetNode("out" + string(1, '1' + static_cast<char>(i)))->MarkDirty();
 283     GetNode("outb" + string(1, '1' + static_cast<char>(i)))->MarkDirty();
 284   }
 285   GetNode("allTheThings")->MarkDirty();
 286
 287   string err;
 288   EXPECT_TRUE(plan_.AddTarget(GetNode("allTheThings"), &err));
 289   ASSERT_EQ("", err);
 290
 291   deque<Edge*> edges;
 292   FindWorkSorted(&edges, 5);
 293
 294   for (int i = 0; i < 4; ++i) {
 295     Edge *edge = edges[i];
 296     ASSERT_EQ("in",  edge->inputs_[0]->path());
 297     string base_name(i < 2 ? "out" : "outb");
 298     ASSERT_EQ(base_name + string(1, '1' + (i % 2)), edge->outputs_[0]->path());
 299   }
 300
 301   // outb3 is exempt because it has an empty pool
 302   Edge* edge = edges[4];
 303   ASSERT_TRUE(edge);
 304   ASSERT_EQ("in",  edge->inputs_[0]->path());
 305   ASSERT_EQ("outb3", edge->outputs_[0]->path());
 306
 307   // finish out1
 308   plan_.EdgeFinished(edges.front());
 309   edges.pop_front();
 310
 311   // out3 should be available
 312   Edge* out3 = plan_.FindWork();
 313   ASSERT_TRUE(out3);
 314   ASSERT_EQ("in",  out3->inputs_[0]->path());
 315   ASSERT_EQ("out3", out3->outputs_[0]->path());
 316
 317   ASSERT_FALSE(plan_.FindWork());
 318
 319   plan_.EdgeFinished(out3);
 320
 321   ASSERT_FALSE(plan_.FindWork());
 322
 323   for (deque<Edge*>::iterator it = edges.begin(); it != edges.end(); ++it) {
 324     plan_.EdgeFinished(*it);
 325   }
 326
 327   Edge* last = plan_.FindWork();
 328   ASSERT_TRUE(last);
 329   ASSERT_EQ("allTheThings", last->outputs_[0]->path());
 330
 331   plan_.EdgeFinished(last);
 332
 333   ASSERT_FALSE(plan_.more_to_do());
 334   ASSERT_FALSE(plan_.FindWork());
 335 }
 336
 337 TEST_F(PlanTest, PoolWithRedundantEdges) {
 338   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 339     "pool compile\n"
 340     "  depth = 1\n"
 341     "rule gen_foo\n"
 342     "  command = touch foo.cpp\n"
 343     "rule gen_bar\n"
 344     "  command = touch bar.cpp\n"
 345     "rule echo\n"
 346     "  command = echo $out > $out\n"
 347     "build foo.cpp.obj: echo foo.cpp || foo.cpp\n"
 348     "  pool = compile\n"
 349     "build bar.cpp.obj: echo bar.cpp || bar.cpp\n"
 350     "  pool = compile\n"
 351     "build libfoo.a: echo foo.cpp.obj bar.cpp.obj\n"
 352     "build foo.cpp: gen_foo\n"
 353     "build bar.cpp: gen_bar\n"
 354     "build all: phony libfoo.a\n"));
 355   GetNode("foo.cpp")->MarkDirty();
 356   GetNode("foo.cpp.obj")->MarkDirty();
 357   GetNode("bar.cpp")->MarkDirty();
 358   GetNode("bar.cpp.obj")->MarkDirty();
 359   GetNode("libfoo.a")->MarkDirty();
 360   GetNode("all")->MarkDirty();
 361   string err;
 362   EXPECT_TRUE(plan_.AddTarget(GetNode("all"), &err));
 363   ASSERT_EQ("", err);
 364   ASSERT_TRUE(plan_.more_to_do());
 365
 366   Edge* edge = NULL;
 367
 368   deque<Edge*> initial_edges;
 369   FindWorkSorted(&initial_edges, 2);
 370
 371   edge = initial_edges[1];  // Foo first
 372   ASSERT_EQ("foo.cpp", edge->outputs_[0]->path());
 373   plan_.EdgeFinished(edge);
 374
 375   edge = plan_.FindWork();
 376   ASSERT_TRUE(edge);
 377   ASSERT_FALSE(plan_.FindWork());
 378   ASSERT_EQ("foo.cpp", edge->inputs_[0]->path());
 379   ASSERT_EQ("foo.cpp", edge->inputs_[1]->path());
 380   ASSERT_EQ("foo.cpp.obj", edge->outputs_[0]->path());
 381   plan_.EdgeFinished(edge);
 382
 383   edge = initial_edges[0];  // Now for bar
 384   ASSERT_EQ("bar.cpp", edge->outputs_[0]->path());
 385   plan_.EdgeFinished(edge);
 386
 387   edge = plan_.FindWork();
 388   ASSERT_TRUE(edge);
 389   ASSERT_FALSE(plan_.FindWork());
 390   ASSERT_EQ("bar.cpp", edge->inputs_[0]->path());
 391   ASSERT_EQ("bar.cpp", edge->inputs_[1]->path());
 392   ASSERT_EQ("bar.cpp.obj", edge->outputs_[0]->path());
 393   plan_.EdgeFinished(edge);
 394
 395   edge = plan_.FindWork();
 396   ASSERT_TRUE(edge);
 397   ASSERT_FALSE(plan_.FindWork());
 398   ASSERT_EQ("foo.cpp.obj", edge->inputs_[0]->path());
 399   ASSERT_EQ("bar.cpp.obj", edge->inputs_[1]->path());
 400   ASSERT_EQ("libfoo.a", edge->outputs_[0]->path());
 401   plan_.EdgeFinished(edge);
 402
 403   edge = plan_.FindWork();
 404   ASSERT_TRUE(edge);
 405   ASSERT_FALSE(plan_.FindWork());
 406   ASSERT_EQ("libfoo.a", edge->inputs_[0]->path());
 407   ASSERT_EQ("all", edge->outputs_[0]->path());
 408   plan_.EdgeFinished(edge);
 409
 410   edge = plan_.FindWork();
 411   ASSERT_FALSE(edge);
 412   ASSERT_FALSE(plan_.more_to_do());
 413 }
 414
 415 /// Fake implementation of CommandRunner, useful for tests.
 416 struct FakeCommandRunner : public CommandRunner {
 417   explicit FakeCommandRunner(VirtualFileSystem* fs) :
 418       last_command_(NULL), fs_(fs) {}
 419
 420   // CommandRunner impl
 421   virtual bool CanRunMore();
 422   virtual bool StartCommand(Edge* edge);
 423   virtual bool WaitForCommand(Result* result);
 424   virtual vector<Edge*> GetActiveEdges();
 425   virtual void Abort();
 426
 427   vector<string> commands_ran_;
 428   Edge* last_command_;
 429   VirtualFileSystem* fs_;
 430 };
 431
 432 struct BuildTest : public StateTestWithBuiltinRules, public BuildLogUser {
 433   BuildTest() : config_(MakeConfig()), command_runner_(&fs_),
 434                 builder_(&state_, config_, NULL, NULL, &fs_),
 435                 status_(config_) {
 436   }
 437
 438   virtual void SetUp() {
 439     StateTestWithBuiltinRules::SetUp();
 440
 441     builder_.command_runner_.reset(&command_runner_);
 442     AssertParse(&state_,
 443 "build cat1: cat in1\n"
 444 "build cat2: cat in1 in2\n"
 445 "build cat12: cat cat1 cat2\n");
 446
 447     fs_.Create("in1", "");
 448     fs_.Create("in2", "");
 449   }
 450
 451   ~BuildTest() {
 452     builder_.command_runner_.release();
 453   }
 454
 455   virtual bool IsPathDead(StringPiece s) const { return false; }
 456
 457   /// Rebuild target in the 'working tree' (fs_).
 458   /// State of command_runner_ and logs contents (if specified) ARE MODIFIED.
 459   /// Handy to check for NOOP builds, and higher-level rebuild tests.
 460   void RebuildTarget(const string& target, const char* manifest,
 461                      const char* log_path = NULL,
 462                      const char* deps_path = NULL);
 463
 464   // Mark a path dirty.
 465   void Dirty(const string& path);
 466
 467   BuildConfig MakeConfig() {
 468     BuildConfig config;
 469     config.verbosity = BuildConfig::QUIET;
 470     return config;
 471   }
 472
 473   BuildConfig config_;
 474   FakeCommandRunner command_runner_;
 475   VirtualFileSystem fs_;
 476   Builder builder_;
 477
 478   BuildStatus status_;
 479 };
 480
 481 void BuildTest::RebuildTarget(const string& target, const char* manifest,
 482                               const char* log_path, const char* deps_path) {
 483   State state;
 484   ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
 485   AssertParse(&state, manifest);
 486
 487   string err;
 488   BuildLog build_log, *pbuild_log = NULL;
 489   if (log_path) {
 490     ASSERT_TRUE(build_log.Load(log_path, &err));
 491     ASSERT_TRUE(build_log.OpenForWrite(log_path, *this, &err));
 492     ASSERT_EQ("", err);
 493     pbuild_log = &build_log;
 494   }
 495
 496   DepsLog deps_log, *pdeps_log = NULL;
 497   if (deps_path) {
 498     ASSERT_TRUE(deps_log.Load(deps_path, &state, &err));
 499     ASSERT_TRUE(deps_log.OpenForWrite(deps_path, &err));
 500     ASSERT_EQ("", err);
 501     pdeps_log = &deps_log;
 502   }
 503
 504   Builder builder(&state, config_, pbuild_log, pdeps_log, &fs_);
 505   EXPECT_TRUE(builder.AddTarget(target, &err));
 506
 507   command_runner_.commands_ran_.clear();
 508   builder.command_runner_.reset(&command_runner_);
 509   if (!builder.AlreadyUpToDate()) {
 510     bool build_res = builder.Build(&err);
 511     EXPECT_TRUE(build_res);
 512   }
 513   builder.command_runner_.release();
 514 }
 515
 516 bool FakeCommandRunner::CanRunMore() {
 517   // Only run one at a time.
 518   return last_command_ == NULL;
 519 }
 520
 521 bool FakeCommandRunner::StartCommand(Edge* edge) {
 522   assert(!last_command_);
 523   commands_ran_.push_back(edge->EvaluateCommand());
 524   if (edge->rule().name() == "cat"  ||
 525       edge->rule().name() == "cat_rsp" ||
 526       edge->rule().name() == "cat_rsp_out" ||
 527       edge->rule().name() == "cc" ||
 528       edge->rule().name() == "touch" ||
 529       edge->rule().name() == "touch-interrupt") {
 530     for (vector<Node*>::iterator out = edge->outputs_.begin();
 531          out != edge->outputs_.end(); ++out) {
 532       fs_->Create((*out)->path(), "");
 533     }
 534   } else if (edge->rule().name() == "true" ||
 535              edge->rule().name() == "fail" ||
 536              edge->rule().name() == "interrupt" ||
 537              edge->rule().name() == "console") {
 538     // Don't do anything.
 539   } else {
 540     printf("unknown command\n");
 541     return false;
 542   }
 543
 544   last_command_ = edge;
 545   return true;
 546 }
 547
 548 bool FakeCommandRunner::WaitForCommand(Result* result) {
 549   if (!last_command_)
 550     return false;
 551
 552   Edge* edge = last_command_;
 553   result->edge = edge;
 554
 555   if (edge->rule().name() == "interrupt" ||
 556       edge->rule().name() == "touch-interrupt") {
 557     result->status = ExitInterrupted;
 558     return true;
 559   }
 560
 561   if (edge->rule().name() == "console") {
 562     if (edge->use_console())
 563       result->status = ExitSuccess;
 564     else
 565       result->status = ExitFailure;
 566     last_command_ = NULL;
 567     return true;
 568   }
 569
 570   if (edge->rule().name() == "fail")
 571     result->status = ExitFailure;
 572   else
 573     result->status = ExitSuccess;
 574   last_command_ = NULL;
 575   return true;
 576 }
 577
 578 vector<Edge*> FakeCommandRunner::GetActiveEdges() {
 579   vector<Edge*> edges;
 580   if (last_command_)
 581     edges.push_back(last_command_);
 582   return edges;
 583 }
 584
 585 void FakeCommandRunner::Abort() {
 586   last_command_ = NULL;
 587 }
 588
 589 void BuildTest::Dirty(const string& path) {
 590   Node* node = GetNode(path);
 591   node->MarkDirty();
 592
 593   // If it's an input file, mark that we've already stat()ed it and
 594   // it's missing.
 595   if (!node->in_edge())
 596     node->MarkMissing();
 597 }
 598
 599 TEST_F(BuildTest, NoWork) {
 600   string err;
 601   EXPECT_TRUE(builder_.AlreadyUpToDate());
 602 }
 603
 604 TEST_F(BuildTest, OneStep) {
 605   // Given a dirty target with one ready input,
 606   // we should rebuild the target.
 607   Dirty("cat1");
 608   string err;
 609   EXPECT_TRUE(builder_.AddTarget("cat1", &err));
 610   ASSERT_EQ("", err);
 611   EXPECT_TRUE(builder_.Build(&err));
 612   ASSERT_EQ("", err);
 613
 614   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 615   EXPECT_EQ("cat in1 > cat1", command_runner_.commands_ran_[0]);
 616 }
 617
 618 TEST_F(BuildTest, OneStep2) {
 619   // Given a target with one dirty input,
 620   // we should rebuild the target.
 621   Dirty("cat1");
 622   string err;
 623   EXPECT_TRUE(builder_.AddTarget("cat1", &err));
 624   ASSERT_EQ("", err);
 625   EXPECT_TRUE(builder_.Build(&err));
 626   EXPECT_EQ("", err);
 627
 628   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 629   EXPECT_EQ("cat in1 > cat1", command_runner_.commands_ran_[0]);
 630 }
 631
 632 TEST_F(BuildTest, TwoStep) {
 633   string err;
 634   EXPECT_TRUE(builder_.AddTarget("cat12", &err));
 635   ASSERT_EQ("", err);
 636   EXPECT_TRUE(builder_.Build(&err));
 637   EXPECT_EQ("", err);
 638   ASSERT_EQ(3u, command_runner_.commands_ran_.size());
 639   // Depending on how the pointers work out, we could've ran
 640   // the first two commands in either order.
 641   EXPECT_TRUE((command_runner_.commands_ran_[0] == "cat in1 > cat1" &&
 642                command_runner_.commands_ran_[1] == "cat in1 in2 > cat2") ||
 643               (command_runner_.commands_ran_[1] == "cat in1 > cat1" &&
 644                command_runner_.commands_ran_[0] == "cat in1 in2 > cat2"));
 645
 646   EXPECT_EQ("cat cat1 cat2 > cat12", command_runner_.commands_ran_[2]);
 647
 648   fs_.Tick();
 649
 650   // Modifying in2 requires rebuilding one intermediate file
 651   // and the final file.
 652   fs_.Create("in2", "");
 653   state_.Reset();
 654   EXPECT_TRUE(builder_.AddTarget("cat12", &err));
 655   ASSERT_EQ("", err);
 656   EXPECT_TRUE(builder_.Build(&err));
 657   ASSERT_EQ("", err);
 658   ASSERT_EQ(5u, command_runner_.commands_ran_.size());
 659   EXPECT_EQ("cat in1 in2 > cat2", command_runner_.commands_ran_[3]);
 660   EXPECT_EQ("cat cat1 cat2 > cat12", command_runner_.commands_ran_[4]);
 661 }
 662
 663 TEST_F(BuildTest, TwoOutputs) {
 664   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 665 "rule touch\n"
 666 "  command = touch $out\n"
 667 "build out1 out2: touch in.txt\n"));
 668
 669   fs_.Create("in.txt", "");
 670
 671   string err;
 672   EXPECT_TRUE(builder_.AddTarget("out1", &err));
 673   ASSERT_EQ("", err);
 674   EXPECT_TRUE(builder_.Build(&err));
 675   EXPECT_EQ("", err);
 676   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 677   EXPECT_EQ("touch out1 out2", command_runner_.commands_ran_[0]);
 678 }
 679
 680 // Test case from
 681 //   https://github.com/martine/ninja/issues/148
 682 TEST_F(BuildTest, MultiOutIn) {
 683   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 684 "rule touch\n"
 685 "  command = touch $out\n"
 686 "build in1 otherfile: touch in\n"
 687 "build out: touch in | in1\n"));
 688
 689   fs_.Create("in", "");
 690   fs_.Tick();
 691   fs_.Create("in1", "");
 692
 693   string err;
 694   EXPECT_TRUE(builder_.AddTarget("out", &err));
 695   ASSERT_EQ("", err);
 696   EXPECT_TRUE(builder_.Build(&err));
 697   EXPECT_EQ("", err);
 698 }
 699
 700 TEST_F(BuildTest, Chain) {
 701   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 702 "build c2: cat c1\n"
 703 "build c3: cat c2\n"
 704 "build c4: cat c3\n"
 705 "build c5: cat c4\n"));
 706
 707   fs_.Create("c1", "");
 708
 709   string err;
 710   EXPECT_TRUE(builder_.AddTarget("c5", &err));
 711   ASSERT_EQ("", err);
 712   EXPECT_TRUE(builder_.Build(&err));
 713   EXPECT_EQ("", err);
 714   ASSERT_EQ(4u, command_runner_.commands_ran_.size());
 715
 716   err.clear();
 717   command_runner_.commands_ran_.clear();
 718   state_.Reset();
 719   EXPECT_TRUE(builder_.AddTarget("c5", &err));
 720   ASSERT_EQ("", err);
 721   EXPECT_TRUE(builder_.AlreadyUpToDate());
 722
 723   fs_.Tick();
 724
 725   fs_.Create("c3", "");
 726   err.clear();
 727   command_runner_.commands_ran_.clear();
 728   state_.Reset();
 729   EXPECT_TRUE(builder_.AddTarget("c5", &err));
 730   ASSERT_EQ("", err);
 731   EXPECT_FALSE(builder_.AlreadyUpToDate());
 732   EXPECT_TRUE(builder_.Build(&err));
 733   ASSERT_EQ(2u, command_runner_.commands_ran_.size());  // 3->4, 4->5
 734 }
 735
 736 TEST_F(BuildTest, MissingInput) {
 737   // Input is referenced by build file, but no rule for it.
 738   string err;
 739   Dirty("in1");
 740   EXPECT_FALSE(builder_.AddTarget("cat1", &err));
 741   EXPECT_EQ("'in1', needed by 'cat1', missing and no known rule to make it",
 742             err);
 743 }
 744
 745 TEST_F(BuildTest, MissingTarget) {
 746   // Target is not referenced by build file.
 747   string err;
 748   EXPECT_FALSE(builder_.AddTarget("meow", &err));
 749   EXPECT_EQ("unknown target: 'meow'", err);
 750 }
 751
 752 TEST_F(BuildTest, MakeDirs) {
 753   string err;
 754
 755 #ifdef _WIN32
 756   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 757                                       "build subdir\\dir2\\file: cat in1\n"));
 758 #else
 759   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 760                                       "build subdir/dir2/file: cat in1\n"));
 761 #endif
 762   EXPECT_TRUE(builder_.AddTarget("subdir/dir2/file", &err));
 763
 764   EXPECT_EQ("", err);
 765   EXPECT_TRUE(builder_.Build(&err));
 766   ASSERT_EQ("", err);
 767   ASSERT_EQ(2u, fs_.directories_made_.size());
 768   EXPECT_EQ("subdir", fs_.directories_made_[0]);
 769   EXPECT_EQ("subdir/dir2", fs_.directories_made_[1]);
 770 }
 771
 772 TEST_F(BuildTest, DepFileMissing) {
 773   string err;
 774   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 775 "rule cc\n  command = cc $in\n  depfile = $out.d\n"
 776 "build fo$ o.o: cc foo.c\n"));
 777   fs_.Create("foo.c", "");
 778
 779   EXPECT_TRUE(builder_.AddTarget("fo o.o", &err));
 780   ASSERT_EQ("", err);
 781   ASSERT_EQ(1u, fs_.files_read_.size());
 782   EXPECT_EQ("fo o.o.d", fs_.files_read_[0]);
 783 }
 784
 785 TEST_F(BuildTest, DepFileOK) {
 786   string err;
 787   int orig_edges = state_.edges_.size();
 788   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 789 "rule cc\n  command = cc $in\n  depfile = $out.d\n"
 790 "build foo.o: cc foo.c\n"));
 791   Edge* edge = state_.edges_.back();
 792
 793   fs_.Create("foo.c", "");
 794   GetNode("bar.h")->MarkDirty();  // Mark bar.h as missing.
 795   fs_.Create("foo.o.d", "foo.o: blah.h bar.h\n");
 796   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 797   ASSERT_EQ("", err);
 798   ASSERT_EQ(1u, fs_.files_read_.size());
 799   EXPECT_EQ("foo.o.d", fs_.files_read_[0]);
 800
 801   // Expect three new edges: one generating foo.o, and two more from
 802   // loading the depfile.
 803   ASSERT_EQ(orig_edges + 3, (int)state_.edges_.size());
 804   // Expect our edge to now have three inputs: foo.c and two headers.
 805   ASSERT_EQ(3u, edge->inputs_.size());
 806
 807   // Expect the command line we generate to only use the original input.
 808   ASSERT_EQ("cc foo.c", edge->EvaluateCommand());
 809 }
 810
 811 TEST_F(BuildTest, DepFileParseError) {
 812   string err;
 813   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 814 "rule cc\n  command = cc $in\n  depfile = $out.d\n"
 815 "build foo.o: cc foo.c\n"));
 816   fs_.Create("foo.c", "");
 817   fs_.Create("foo.o.d", "randomtext\n");
 818   EXPECT_FALSE(builder_.AddTarget("foo.o", &err));
 819   EXPECT_EQ("expected depfile 'foo.o.d' to mention 'foo.o', got 'randomtext'",
 820             err);
 821 }
 822
 823 TEST_F(BuildTest, OrderOnlyDeps) {
 824   string err;
 825   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 826 "rule cc\n  command = cc $in\n  depfile = $out.d\n"
 827 "build foo.o: cc foo.c || otherfile\n"));
 828   Edge* edge = state_.edges_.back();
 829
 830   fs_.Create("foo.c", "");
 831   fs_.Create("otherfile", "");
 832   fs_.Create("foo.o.d", "foo.o: blah.h bar.h\n");
 833   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 834   ASSERT_EQ("", err);
 835
 836   // One explicit, two implicit, one order only.
 837   ASSERT_EQ(4u, edge->inputs_.size());
 838   EXPECT_EQ(2, edge->implicit_deps_);
 839   EXPECT_EQ(1, edge->order_only_deps_);
 840   // Verify the inputs are in the order we expect
 841   // (explicit then implicit then orderonly).
 842   EXPECT_EQ("foo.c", edge->inputs_[0]->path());
 843   EXPECT_EQ("blah.h", edge->inputs_[1]->path());
 844   EXPECT_EQ("bar.h", edge->inputs_[2]->path());
 845   EXPECT_EQ("otherfile", edge->inputs_[3]->path());
 846
 847   // Expect the command line we generate to only use the original input.
 848   ASSERT_EQ("cc foo.c", edge->EvaluateCommand());
 849
 850   // explicit dep dirty, expect a rebuild.
 851   EXPECT_TRUE(builder_.Build(&err));
 852   ASSERT_EQ("", err);
 853   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 854
 855   fs_.Tick();
 856
 857   // Recreate the depfile, as it should have been deleted by the build.
 858   fs_.Create("foo.o.d", "foo.o: blah.h bar.h\n");
 859
 860   // implicit dep dirty, expect a rebuild.
 861   fs_.Create("blah.h", "");
 862   fs_.Create("bar.h", "");
 863   command_runner_.commands_ran_.clear();
 864   state_.Reset();
 865   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 866   EXPECT_TRUE(builder_.Build(&err));
 867   ASSERT_EQ("", err);
 868   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 869
 870   fs_.Tick();
 871
 872   // Recreate the depfile, as it should have been deleted by the build.
 873   fs_.Create("foo.o.d", "foo.o: blah.h bar.h\n");
 874
 875   // order only dep dirty, no rebuild.
 876   fs_.Create("otherfile", "");
 877   command_runner_.commands_ran_.clear();
 878   state_.Reset();
 879   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 880   EXPECT_EQ("", err);
 881   EXPECT_TRUE(builder_.AlreadyUpToDate());
 882
 883   // implicit dep missing, expect rebuild.
 884   fs_.RemoveFile("bar.h");
 885   command_runner_.commands_ran_.clear();
 886   state_.Reset();
 887   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 888   EXPECT_TRUE(builder_.Build(&err));
 889   ASSERT_EQ("", err);
 890   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 891 }
 892
 893 TEST_F(BuildTest, RebuildOrderOnlyDeps) {
 894   string err;
 895   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 896 "rule cc\n  command = cc $in\n"
 897 "rule true\n  command = true\n"
 898 "build oo.h: cc oo.h.in\n"
 899 "build foo.o: cc foo.c || oo.h\n"));
 900
 901   fs_.Create("foo.c", "");
 902   fs_.Create("oo.h.in", "");
 903
 904   // foo.o and order-only dep dirty, build both.
 905   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 906   EXPECT_TRUE(builder_.Build(&err));
 907   ASSERT_EQ("", err);
 908   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
 909
 910   // all clean, no rebuild.
 911   command_runner_.commands_ran_.clear();
 912   state_.Reset();
 913   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 914   EXPECT_EQ("", err);
 915   EXPECT_TRUE(builder_.AlreadyUpToDate());
 916
 917   // order-only dep missing, build it only.
 918   fs_.RemoveFile("oo.h");
 919   command_runner_.commands_ran_.clear();
 920   state_.Reset();
 921   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 922   EXPECT_TRUE(builder_.Build(&err));
 923   ASSERT_EQ("", err);
 924   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 925   ASSERT_EQ("cc oo.h.in", command_runner_.commands_ran_[0]);
 926
 927   fs_.Tick();
 928
 929   // order-only dep dirty, build it only.
 930   fs_.Create("oo.h.in", "");
 931   command_runner_.commands_ran_.clear();
 932   state_.Reset();
 933   EXPECT_TRUE(builder_.AddTarget("foo.o", &err));
 934   EXPECT_TRUE(builder_.Build(&err));
 935   ASSERT_EQ("", err);
 936   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 937   ASSERT_EQ("cc oo.h.in", command_runner_.commands_ran_[0]);
 938 }
 939
 940 TEST_F(BuildTest, Phony) {
 941   string err;
 942   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 943 "build out: cat bar.cc\n"
 944 "build all: phony out\n"));
 945   fs_.Create("bar.cc", "");
 946
 947   EXPECT_TRUE(builder_.AddTarget("all", &err));
 948   ASSERT_EQ("", err);
 949
 950   // Only one command to run, because phony runs no command.
 951   EXPECT_FALSE(builder_.AlreadyUpToDate());
 952   EXPECT_TRUE(builder_.Build(&err));
 953   ASSERT_EQ("", err);
 954   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 955 }
 956
 957 TEST_F(BuildTest, PhonyNoWork) {
 958   string err;
 959   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 960 "build out: cat bar.cc\n"
 961 "build all: phony out\n"));
 962   fs_.Create("bar.cc", "");
 963   fs_.Create("out", "");
 964
 965   EXPECT_TRUE(builder_.AddTarget("all", &err));
 966   ASSERT_EQ("", err);
 967   EXPECT_TRUE(builder_.AlreadyUpToDate());
 968 }
 969
 970 TEST_F(BuildTest, Fail) {
 971   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 972 "rule fail\n"
 973 "  command = fail\n"
 974 "build out1: fail\n"));
 975
 976   string err;
 977   EXPECT_TRUE(builder_.AddTarget("out1", &err));
 978   ASSERT_EQ("", err);
 979
 980   EXPECT_FALSE(builder_.Build(&err));
 981   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
 982   ASSERT_EQ("subcommand failed", err);
 983 }
 984
 985 TEST_F(BuildTest, SwallowFailures) {
 986   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
 987 "rule fail\n"
 988 "  command = fail\n"
 989 "build out1: fail\n"
 990 "build out2: fail\n"
 991 "build out3: fail\n"
 992 "build all: phony out1 out2 out3\n"));
 993
 994   // Swallow two failures, die on the third.
 995   config_.failures_allowed = 3;
 996
 997   string err;
 998   EXPECT_TRUE(builder_.AddTarget("all", &err));
 999   ASSERT_EQ("", err);
1000
1001   EXPECT_FALSE(builder_.Build(&err));
1002   ASSERT_EQ(3u, command_runner_.commands_ran_.size());
1003   ASSERT_EQ("subcommands failed", err);
1004 }
1005
1006 TEST_F(BuildTest, SwallowFailuresLimit) {
1007   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1008 "rule fail\n"
1009 "  command = fail\n"
1010 "build out1: fail\n"
1011 "build out2: fail\n"
1012 "build out3: fail\n"
1013 "build final: cat out1 out2 out3\n"));
1014
1015   // Swallow ten failures; we should stop before building final.
1016   config_.failures_allowed = 11;
1017
1018   string err;
1019   EXPECT_TRUE(builder_.AddTarget("final", &err));
1020   ASSERT_EQ("", err);
1021
1022   EXPECT_FALSE(builder_.Build(&err));
1023   ASSERT_EQ(3u, command_runner_.commands_ran_.size());
1024   ASSERT_EQ("cannot make progress due to previous errors", err);
1025 }
1026
1027 struct BuildWithLogTest : public BuildTest {
1028   BuildWithLogTest() {
1029     builder_.SetBuildLog(&build_log_);
1030   }
1031
1032   BuildLog build_log_;
1033 };
1034
1035 TEST_F(BuildWithLogTest, NotInLogButOnDisk) {
1036   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1037 "rule cc\n"
1038 "  command = cc\n"
1039 "build out1: cc in\n"));
1040
1041   // Create input/output that would be considered up to date when
1042   // not considering the command line hash.
1043   fs_.Create("in", "");
1044   fs_.Create("out1", "");
1045   string err;
1046
1047   // Because it's not in the log, it should not be up-to-date until
1048   // we build again.
1049   EXPECT_TRUE(builder_.AddTarget("out1", &err));
1050   EXPECT_FALSE(builder_.AlreadyUpToDate());
1051
1052   command_runner_.commands_ran_.clear();
1053   state_.Reset();
1054
1055   EXPECT_TRUE(builder_.AddTarget("out1", &err));
1056   EXPECT_TRUE(builder_.Build(&err));
1057   EXPECT_TRUE(builder_.AlreadyUpToDate());
1058 }
1059
1060 TEST_F(BuildWithLogTest, RestatTest) {
1061   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1062 "rule true\n"
1063 "  command = true\n"
1064 "  restat = 1\n"
1065 "rule cc\n"
1066 "  command = cc\n"
1067 "  restat = 1\n"
1068 "build out1: cc in\n"
1069 "build out2: true out1\n"
1070 "build out3: cat out2\n"));
1071
1072   fs_.Create("out1", "");
1073   fs_.Create("out2", "");
1074   fs_.Create("out3", "");
1075
1076   fs_.Tick();
1077
1078   fs_.Create("in", "");
1079
1080   // Do a pre-build so that there's commands in the log for the outputs,
1081   // otherwise, the lack of an entry in the build log will cause out3 to rebuild
1082   // regardless of restat.
1083   string err;
1084   EXPECT_TRUE(builder_.AddTarget("out3", &err));
1085   ASSERT_EQ("", err);
1086   EXPECT_TRUE(builder_.Build(&err));
1087   ASSERT_EQ("", err);
1088   EXPECT_EQ("[3/3]", builder_.status_->FormatProgressStatus("[%s/%t]"));
1089   command_runner_.commands_ran_.clear();
1090   state_.Reset();
1091
1092   fs_.Tick();
1093
1094   fs_.Create("in", "");
1095   // "cc" touches out1, so we should build out2.  But because "true" does not
1096   // touch out2, we should cancel the build of out3.
1097   EXPECT_TRUE(builder_.AddTarget("out3", &err));
1098   ASSERT_EQ("", err);
1099   EXPECT_TRUE(builder_.Build(&err));
1100   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
1101
1102   // If we run again, it should be a no-op, because the build log has recorded
1103   // that we've already built out2 with an input timestamp of 2 (from out1).
1104   command_runner_.commands_ran_.clear();
1105   state_.Reset();
1106   EXPECT_TRUE(builder_.AddTarget("out3", &err));
1107   ASSERT_EQ("", err);
1108   EXPECT_TRUE(builder_.AlreadyUpToDate());
1109
1110   fs_.Tick();
1111
1112   fs_.Create("in", "");
1113
1114   // The build log entry should not, however, prevent us from rebuilding out2
1115   // if out1 changes.
1116   command_runner_.commands_ran_.clear();
1117   state_.Reset();
1118   EXPECT_TRUE(builder_.AddTarget("out3", &err));
1119   ASSERT_EQ("", err);
1120   EXPECT_TRUE(builder_.Build(&err));
1121   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
1122 }
1123
1124 TEST_F(BuildWithLogTest, RestatMissingFile) {
1125   // If a restat rule doesn't create its output, and the output didn't
1126   // exist before the rule was run, consider that behavior equivalent
1127   // to a rule that doesn't modify its existent output file.
1128
1129   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1130 "rule true\n"
1131 "  command = true\n"
1132 "  restat = 1\n"
1133 "rule cc\n"
1134 "  command = cc\n"
1135 "build out1: true in\n"
1136 "build out2: cc out1\n"));
1137
1138   fs_.Create("in", "");
1139   fs_.Create("out2", "");
1140
1141   // Do a pre-build so that there's commands in the log for the outputs,
1142   // otherwise, the lack of an entry in the build log will cause out2 to rebuild
1143   // regardless of restat.
1144   string err;
1145   EXPECT_TRUE(builder_.AddTarget("out2", &err));
1146   ASSERT_EQ("", err);
1147   EXPECT_TRUE(builder_.Build(&err));
1148   ASSERT_EQ("", err);
1149   command_runner_.commands_ran_.clear();
1150   state_.Reset();
1151
1152   fs_.Tick();
1153   fs_.Create("in", "");
1154   fs_.Create("out2", "");
1155
1156   // Run a build, expect only the first command to run.
1157   // It doesn't touch its output (due to being the "true" command), so
1158   // we shouldn't run the dependent build.
1159   EXPECT_TRUE(builder_.AddTarget("out2", &err));
1160   ASSERT_EQ("", err);
1161   EXPECT_TRUE(builder_.Build(&err));
1162   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1163 }
1164
1165 TEST_F(BuildWithLogTest, RestatSingleDependentOutputDirty) {
1166   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1167     "rule true\n"
1168     "  command = true\n"
1169     "  restat = 1\n"
1170     "rule touch\n"
1171     "  command = touch\n"
1172     "build out1: true in\n"
1173     "build out2 out3: touch out1\n"
1174     "build out4: touch out2\n"
1175     ));
1176
1177   // Create the necessary files
1178   fs_.Create("in", "");
1179
1180   string err;
1181   EXPECT_TRUE(builder_.AddTarget("out4", &err));
1182   ASSERT_EQ("", err);
1183   EXPECT_TRUE(builder_.Build(&err));
1184   ASSERT_EQ("", err);
1185   ASSERT_EQ(3u, command_runner_.commands_ran_.size());
1186
1187   fs_.Tick();
1188   fs_.Create("in", "");
1189   fs_.RemoveFile("out3");
1190
1191   // Since "in" is missing, out1 will be built. Since "out3" is missing,
1192   // out2 and out3 will be built even though "in" is not touched when built.
1193   // Then, since out2 is rebuilt, out4 should be rebuilt -- the restat on the
1194   // "true" rule should not lead to the "touch" edge writing out2 and out3 being
1195   // cleard.
1196   command_runner_.commands_ran_.clear();
1197   state_.Reset();
1198   EXPECT_TRUE(builder_.AddTarget("out4", &err));
1199   ASSERT_EQ("", err);
1200   EXPECT_TRUE(builder_.Build(&err));
1201   ASSERT_EQ("", err);
1202   ASSERT_EQ(3u, command_runner_.commands_ran_.size());
1203 }
1204
1205 // Test scenario, in which an input file is removed, but output isn't changed
1206 // https://github.com/martine/ninja/issues/295
1207 TEST_F(BuildWithLogTest, RestatMissingInput) {
1208   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1209     "rule true\n"
1210     "  command = true\n"
1211     "  depfile = $out.d\n"
1212     "  restat = 1\n"
1213     "rule cc\n"
1214     "  command = cc\n"
1215     "build out1: true in\n"
1216     "build out2: cc out1\n"));
1217
1218   // Create all necessary files
1219   fs_.Create("in", "");
1220
1221   // The implicit dependencies and the depfile itself
1222   // are newer than the output
1223   TimeStamp restat_mtime = fs_.Tick();
1224   fs_.Create("out1.d", "out1: will.be.deleted restat.file\n");
1225   fs_.Create("will.be.deleted", "");
1226   fs_.Create("restat.file", "");
1227
1228   // Run the build, out1 and out2 get built
1229   string err;
1230   EXPECT_TRUE(builder_.AddTarget("out2", &err));
1231   ASSERT_EQ("", err);
1232   EXPECT_TRUE(builder_.Build(&err));
1233   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
1234
1235   // See that an entry in the logfile is created, capturing
1236   // the right mtime
1237   BuildLog::LogEntry* log_entry = build_log_.LookupByOutput("out1");
1238   ASSERT_TRUE(NULL != log_entry);
1239   ASSERT_EQ(restat_mtime, log_entry->restat_mtime);
1240
1241   // Now remove a file, referenced from depfile, so that target becomes
1242   // dirty, but the output does not change
1243   fs_.RemoveFile("will.be.deleted");
1244
1245   // Trigger the build again - only out1 gets built
1246   command_runner_.commands_ran_.clear();
1247   state_.Reset();
1248   EXPECT_TRUE(builder_.AddTarget("out2", &err));
1249   ASSERT_EQ("", err);
1250   EXPECT_TRUE(builder_.Build(&err));
1251   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1252
1253   // Check that the logfile entry remains correctly set
1254   log_entry = build_log_.LookupByOutput("out1");
1255   ASSERT_TRUE(NULL != log_entry);
1256   ASSERT_EQ(restat_mtime, log_entry->restat_mtime);
1257 }
1258
1259 struct BuildDryRun : public BuildWithLogTest {
1260   BuildDryRun() {
1261     config_.dry_run = true;
1262   }
1263 };
1264
1265 TEST_F(BuildDryRun, AllCommandsShown) {
1266   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1267 "rule true\n"
1268 "  command = true\n"
1269 "  restat = 1\n"
1270 "rule cc\n"
1271 "  command = cc\n"
1272 "  restat = 1\n"
1273 "build out1: cc in\n"
1274 "build out2: true out1\n"
1275 "build out3: cat out2\n"));
1276
1277   fs_.Create("out1", "");
1278   fs_.Create("out2", "");
1279   fs_.Create("out3", "");
1280
1281   fs_.Tick();
1282
1283   fs_.Create("in", "");
1284
1285   // "cc" touches out1, so we should build out2.  But because "true" does not
1286   // touch out2, we should cancel the build of out3.
1287   string err;
1288   EXPECT_TRUE(builder_.AddTarget("out3", &err));
1289   ASSERT_EQ("", err);
1290   EXPECT_TRUE(builder_.Build(&err));
1291   ASSERT_EQ(3u, command_runner_.commands_ran_.size());
1292 }
1293
1294 // Test that RSP files are created when & where appropriate and deleted after
1295 // successful execution.
1296 TEST_F(BuildTest, RspFileSuccess)
1297 {
1298   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1299     "rule cat_rsp\n"
1300     "  command = cat $rspfile > $out\n"
1301     "  rspfile = $rspfile\n"
1302     "  rspfile_content = $long_command\n"
1303     "rule cat_rsp_out\n"
1304     "  command = cat $rspfile > $out\n"
1305     "  rspfile = $out.rsp\n"
1306     "  rspfile_content = $long_command\n"
1307     "build out1: cat in\n"
1308     "build out2: cat_rsp in\n"
1309     "  rspfile = out 2.rsp\n"
1310     "  long_command = Some very long command\n"
1311     "build out$ 3: cat_rsp_out in\n"
1312     "  long_command = Some very long command\n"));
1313
1314   fs_.Create("out1", "");
1315   fs_.Create("out2", "");
1316   fs_.Create("out 3", "");
1317
1318   fs_.Tick();
1319
1320   fs_.Create("in", "");
1321
1322   string err;
1323   EXPECT_TRUE(builder_.AddTarget("out1", &err));
1324   ASSERT_EQ("", err);
1325   EXPECT_TRUE(builder_.AddTarget("out2", &err));
1326   ASSERT_EQ("", err);
1327   EXPECT_TRUE(builder_.AddTarget("out 3", &err));
1328   ASSERT_EQ("", err);
1329
1330   size_t files_created = fs_.files_created_.size();
1331   size_t files_removed = fs_.files_removed_.size();
1332
1333   EXPECT_TRUE(builder_.Build(&err));
1334   ASSERT_EQ(3u, command_runner_.commands_ran_.size());
1335
1336   // The RSP files were created
1337   ASSERT_EQ(files_created + 2, fs_.files_created_.size());
1338   ASSERT_EQ(1u, fs_.files_created_.count("out 2.rsp"));
1339   ASSERT_EQ(1u, fs_.files_created_.count("out 3.rsp"));
1340
1341   // The RSP files were removed
1342   ASSERT_EQ(files_removed + 2, fs_.files_removed_.size());
1343   ASSERT_EQ(1u, fs_.files_removed_.count("out 2.rsp"));
1344   ASSERT_EQ(1u, fs_.files_removed_.count("out 3.rsp"));
1345 }
1346
1347 // Test that RSP file is created but not removed for commands, which fail
1348 TEST_F(BuildTest, RspFileFailure) {
1349   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1350     "rule fail\n"
1351     "  command = fail\n"
1352     "  rspfile = $rspfile\n"
1353     "  rspfile_content = $long_command\n"
1354     "build out: fail in\n"
1355     "  rspfile = out.rsp\n"
1356     "  long_command = Another very long command\n"));
1357
1358   fs_.Create("out", "");
1359   fs_.Tick();
1360   fs_.Create("in", "");
1361
1362   string err;
1363   EXPECT_TRUE(builder_.AddTarget("out", &err));
1364   ASSERT_EQ("", err);
1365
1366   size_t files_created = fs_.files_created_.size();
1367   size_t files_removed = fs_.files_removed_.size();
1368
1369   EXPECT_FALSE(builder_.Build(&err));
1370   ASSERT_EQ("subcommand failed", err);
1371   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1372
1373   // The RSP file was created
1374   ASSERT_EQ(files_created + 1, fs_.files_created_.size());
1375   ASSERT_EQ(1u, fs_.files_created_.count("out.rsp"));
1376
1377   // The RSP file was NOT removed
1378   ASSERT_EQ(files_removed, fs_.files_removed_.size());
1379   ASSERT_EQ(0u, fs_.files_removed_.count("out.rsp"));
1380
1381   // The RSP file contains what it should
1382   ASSERT_EQ("Another very long command", fs_.files_["out.rsp"].contents);
1383 }
1384
1385 // Test that contens of the RSP file behaves like a regular part of
1386 // command line, i.e. triggers a rebuild if changed
1387 TEST_F(BuildWithLogTest, RspFileCmdLineChange) {
1388   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1389     "rule cat_rsp\n"
1390     "  command = cat $rspfile > $out\n"
1391     "  rspfile = $rspfile\n"
1392     "  rspfile_content = $long_command\n"
1393     "build out: cat_rsp in\n"
1394     "  rspfile = out.rsp\n"
1395     "  long_command = Original very long command\n"));
1396
1397   fs_.Create("out", "");
1398   fs_.Tick();
1399   fs_.Create("in", "");
1400
1401   string err;
1402   EXPECT_TRUE(builder_.AddTarget("out", &err));
1403   ASSERT_EQ("", err);
1404
1405   // 1. Build for the 1st time (-> populate log)
1406   EXPECT_TRUE(builder_.Build(&err));
1407   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1408
1409   // 2. Build again (no change)
1410   command_runner_.commands_ran_.clear();
1411   state_.Reset();
1412   EXPECT_TRUE(builder_.AddTarget("out", &err));
1413   EXPECT_EQ("", err);
1414   ASSERT_TRUE(builder_.AlreadyUpToDate());
1415
1416   // 3. Alter the entry in the logfile
1417   // (to simulate a change in the command line between 2 builds)
1418   BuildLog::LogEntry* log_entry = build_log_.LookupByOutput("out");
1419   ASSERT_TRUE(NULL != log_entry);
1420   ASSERT_NO_FATAL_FAILURE(AssertHash(
1421         "cat out.rsp > out;rspfile=Original very long command",
1422         log_entry->command_hash));
1423   log_entry->command_hash++;  // Change the command hash to something else.
1424   // Now expect the target to be rebuilt
1425   command_runner_.commands_ran_.clear();
1426   state_.Reset();
1427   EXPECT_TRUE(builder_.AddTarget("out", &err));
1428   EXPECT_EQ("", err);
1429   EXPECT_TRUE(builder_.Build(&err));
1430   EXPECT_EQ(1u, command_runner_.commands_ran_.size());
1431 }
1432
1433 TEST_F(BuildTest, InterruptCleanup) {
1434   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1435 "rule interrupt\n"
1436 "  command = interrupt\n"
1437 "rule touch-interrupt\n"
1438 "  command = touch-interrupt\n"
1439 "build out1: interrupt in1\n"
1440 "build out2: touch-interrupt in2\n"));
1441
1442   fs_.Create("out1", "");
1443   fs_.Create("out2", "");
1444   fs_.Tick();
1445   fs_.Create("in1", "");
1446   fs_.Create("in2", "");
1447
1448   // An untouched output of an interrupted command should be retained.
1449   string err;
1450   EXPECT_TRUE(builder_.AddTarget("out1", &err));
1451   EXPECT_EQ("", err);
1452   EXPECT_FALSE(builder_.Build(&err));
1453   EXPECT_EQ("interrupted by user", err);
1454   builder_.Cleanup();
1455   EXPECT_GT(fs_.Stat("out1"), 0);
1456   err = "";
1457
1458   // A touched output of an interrupted command should be deleted.
1459   EXPECT_TRUE(builder_.AddTarget("out2", &err));
1460   EXPECT_EQ("", err);
1461   EXPECT_FALSE(builder_.Build(&err));
1462   EXPECT_EQ("interrupted by user", err);
1463   builder_.Cleanup();
1464   EXPECT_EQ(0, fs_.Stat("out2"));
1465 }
1466
1467 TEST_F(BuildTest, PhonyWithNoInputs) {
1468   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1469 "build nonexistent: phony\n"
1470 "build out1: cat || nonexistent\n"
1471 "build out2: cat nonexistent\n"));
1472   fs_.Create("out1", "");
1473   fs_.Create("out2", "");
1474
1475   // out1 should be up to date even though its input is dirty, because its
1476   // order-only dependency has nothing to do.
1477   string err;
1478   EXPECT_TRUE(builder_.AddTarget("out1", &err));
1479   ASSERT_EQ("", err);
1480   EXPECT_TRUE(builder_.AlreadyUpToDate());
1481
1482   // out2 should still be out of date though, because its input is dirty.
1483   err.clear();
1484   command_runner_.commands_ran_.clear();
1485   state_.Reset();
1486   EXPECT_TRUE(builder_.AddTarget("out2", &err));
1487   ASSERT_EQ("", err);
1488   EXPECT_TRUE(builder_.Build(&err));
1489   EXPECT_EQ("", err);
1490   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1491 }
1492
1493 TEST_F(BuildTest, DepsGccWithEmptyDepfileErrorsOut) {
1494   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1495 "rule cc\n"
1496 "  command = cc\n"
1497 "  deps = gcc\n"
1498 "build out: cc\n"));
1499   Dirty("out");
1500
1501   string err;
1502   EXPECT_TRUE(builder_.AddTarget("out", &err));
1503   ASSERT_EQ("", err);
1504   EXPECT_FALSE(builder_.AlreadyUpToDate());
1505
1506   EXPECT_FALSE(builder_.Build(&err));
1507   ASSERT_EQ("subcommand failed", err);
1508   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1509 }
1510
1511 TEST_F(BuildTest, StatusFormatReplacePlaceholder) {
1512   EXPECT_EQ("[%/s0/t0/r0/u0/f0]",
1513             status_.FormatProgressStatus("[%%/s%s/t%t/r%r/u%u/f%f]"));
1514 }
1515
1516 TEST_F(BuildTest, FailedDepsParse) {
1517   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1518 "build bad_deps.o: cat in1\n"
1519 "  deps = gcc\n"
1520 "  depfile = in1.d\n"));
1521
1522   string err;
1523   EXPECT_TRUE(builder_.AddTarget("bad_deps.o", &err));
1524   ASSERT_EQ("", err);
1525
1526   // These deps will fail to parse, as they should only have one
1527   // path to the left of the colon.
1528   fs_.Create("in1.d", "AAA BBB");
1529
1530   EXPECT_FALSE(builder_.Build(&err));
1531   EXPECT_EQ("subcommand failed", err);
1532 }
1533
1534 /// Tests of builds involving deps logs necessarily must span
1535 /// multiple builds.  We reuse methods on BuildTest but not the
1536 /// builder_ it sets up, because we want pristine objects for
1537 /// each build.
1538 struct BuildWithDepsLogTest : public BuildTest {
1539   BuildWithDepsLogTest() {}
1540
1541   virtual void SetUp() {
1542     BuildTest::SetUp();
1543
1544     temp_dir_.CreateAndEnter("BuildWithDepsLogTest");
1545   }
1546
1547   virtual void TearDown() {
1548     temp_dir_.Cleanup();
1549   }
1550
1551   ScopedTempDir temp_dir_;
1552
1553   /// Shadow parent class builder_ so we don't accidentally use it.
1554   void* builder_;
1555 };
1556
1557 /// Run a straightforwad build where the deps log is used.
1558 TEST_F(BuildWithDepsLogTest, Straightforward) {
1559   string err;
1560   // Note: in1 was created by the superclass SetUp().
1561   const char* manifest =
1562       "build out: cat in1\n"
1563       "  deps = gcc\n"
1564       "  depfile = in1.d\n";
1565   {
1566     State state;
1567     ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
1568     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1569
1570     // Run the build once, everything should be ok.
1571     DepsLog deps_log;
1572     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1573     ASSERT_EQ("", err);
1574
1575     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1576     builder.command_runner_.reset(&command_runner_);
1577     EXPECT_TRUE(builder.AddTarget("out", &err));
1578     ASSERT_EQ("", err);
1579     fs_.Create("in1.d", "out: in2");
1580     EXPECT_TRUE(builder.Build(&err));
1581     EXPECT_EQ("", err);
1582
1583     // The deps file should have been removed.
1584     EXPECT_EQ(0, fs_.Stat("in1.d"));
1585     // Recreate it for the next step.
1586     fs_.Create("in1.d", "out: in2");
1587     deps_log.Close();
1588     builder.command_runner_.release();
1589   }
1590
1591   {
1592     State state;
1593     ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
1594     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1595
1596     // Touch the file only mentioned in the deps.
1597     fs_.Tick();
1598     fs_.Create("in2", "");
1599
1600     // Run the build again.
1601     DepsLog deps_log;
1602     ASSERT_TRUE(deps_log.Load("ninja_deps", &state, &err));
1603     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1604
1605     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1606     builder.command_runner_.reset(&command_runner_);
1607     command_runner_.commands_ran_.clear();
1608     EXPECT_TRUE(builder.AddTarget("out", &err));
1609     ASSERT_EQ("", err);
1610     EXPECT_TRUE(builder.Build(&err));
1611     EXPECT_EQ("", err);
1612
1613     // We should have rebuilt the output due to in2 being
1614     // out of date.
1615     EXPECT_EQ(1u, command_runner_.commands_ran_.size());
1616
1617     builder.command_runner_.release();
1618   }
1619 }
1620
1621 /// Verify that obsolete dependency info causes a rebuild.
1622 /// 1) Run a successful build where everything has time t, record deps.
1623 /// 2) Move input/output to time t+1 -- despite files in alignment,
1624 ///    should still need to rebuild due to deps at older time.
1625 TEST_F(BuildWithDepsLogTest, ObsoleteDeps) {
1626   string err;
1627   // Note: in1 was created by the superclass SetUp().
1628   const char* manifest =
1629       "build out: cat in1\n"
1630       "  deps = gcc\n"
1631       "  depfile = in1.d\n";
1632   {
1633     // Run an ordinary build that gathers dependencies.
1634     fs_.Create("in1", "");
1635     fs_.Create("in1.d", "out: ");
1636
1637     State state;
1638     ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
1639     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1640
1641     // Run the build once, everything should be ok.
1642     DepsLog deps_log;
1643     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1644     ASSERT_EQ("", err);
1645
1646     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1647     builder.command_runner_.reset(&command_runner_);
1648     EXPECT_TRUE(builder.AddTarget("out", &err));
1649     ASSERT_EQ("", err);
1650     EXPECT_TRUE(builder.Build(&err));
1651     EXPECT_EQ("", err);
1652
1653     deps_log.Close();
1654     builder.command_runner_.release();
1655   }
1656
1657   // Push all files one tick forward so that only the deps are out
1658   // of date.
1659   fs_.Tick();
1660   fs_.Create("in1", "");
1661   fs_.Create("out", "");
1662
1663   // The deps file should have been removed, so no need to timestamp it.
1664   EXPECT_EQ(0, fs_.Stat("in1.d"));
1665
1666   {
1667     State state;
1668     ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
1669     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1670
1671     DepsLog deps_log;
1672     ASSERT_TRUE(deps_log.Load("ninja_deps", &state, &err));
1673     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1674
1675     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1676     builder.command_runner_.reset(&command_runner_);
1677     command_runner_.commands_ran_.clear();
1678     EXPECT_TRUE(builder.AddTarget("out", &err));
1679     ASSERT_EQ("", err);
1680
1681     // Recreate the deps file here because the build expects them to exist.
1682     fs_.Create("in1.d", "out: ");
1683
1684     EXPECT_TRUE(builder.Build(&err));
1685     EXPECT_EQ("", err);
1686
1687     // We should have rebuilt the output due to the deps being
1688     // out of date.
1689     EXPECT_EQ(1u, command_runner_.commands_ran_.size());
1690
1691     builder.command_runner_.release();
1692   }
1693 }
1694
1695 TEST_F(BuildWithDepsLogTest, DepsIgnoredInDryRun) {
1696   const char* manifest =
1697       "build out: cat in1\n"
1698       "  deps = gcc\n"
1699       "  depfile = in1.d\n";
1700
1701   fs_.Create("out", "");
1702   fs_.Tick();
1703   fs_.Create("in1", "");
1704
1705   State state;
1706   ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
1707   ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1708
1709   // The deps log is NULL in dry runs.
1710   config_.dry_run = true;
1711   Builder builder(&state, config_, NULL, NULL, &fs_);
1712   builder.command_runner_.reset(&command_runner_);
1713   command_runner_.commands_ran_.clear();
1714
1715   string err;
1716   EXPECT_TRUE(builder.AddTarget("out", &err));
1717   ASSERT_EQ("", err);
1718   EXPECT_TRUE(builder.Build(&err));
1719   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1720
1721   builder.command_runner_.release();
1722 }
1723
1724 /// Check that a restat rule generating a header cancels compilations correctly.
1725 TEST_F(BuildTest, RestatDepfileDependency) {
1726   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1727 "rule true\n"
1728 "  command = true\n"  // Would be "write if out-of-date" in reality.
1729 "  restat = 1\n"
1730 "build header.h: true header.in\n"
1731 "build out: cat in1\n"
1732 "  depfile = in1.d\n"));
1733
1734   fs_.Create("header.h", "");
1735   fs_.Create("in1.d", "out: header.h");
1736   fs_.Tick();
1737   fs_.Create("header.in", "");
1738
1739   string err;
1740   EXPECT_TRUE(builder_.AddTarget("out", &err));
1741   ASSERT_EQ("", err);
1742   EXPECT_TRUE(builder_.Build(&err));
1743   EXPECT_EQ("", err);
1744 }
1745
1746 /// Check that a restat rule generating a header cancels compilations correctly,
1747 /// depslog case.
1748 TEST_F(BuildWithDepsLogTest, RestatDepfileDependencyDepsLog) {
1749   string err;
1750   // Note: in1 was created by the superclass SetUp().
1751   const char* manifest =
1752       "rule true\n"
1753       "  command = true\n"  // Would be "write if out-of-date" in reality.
1754       "  restat = 1\n"
1755       "build header.h: true header.in\n"
1756       "build out: cat in1\n"
1757       "  deps = gcc\n"
1758       "  depfile = in1.d\n";
1759   {
1760     State state;
1761     ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
1762     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1763
1764     // Run the build once, everything should be ok.
1765     DepsLog deps_log;
1766     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1767     ASSERT_EQ("", err);
1768
1769     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1770     builder.command_runner_.reset(&command_runner_);
1771     EXPECT_TRUE(builder.AddTarget("out", &err));
1772     ASSERT_EQ("", err);
1773     fs_.Create("in1.d", "out: header.h");
1774     EXPECT_TRUE(builder.Build(&err));
1775     EXPECT_EQ("", err);
1776
1777     deps_log.Close();
1778     builder.command_runner_.release();
1779   }
1780
1781   {
1782     State state;
1783     ASSERT_NO_FATAL_FAILURE(AddCatRule(&state));
1784     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1785
1786     // Touch the input of the restat rule.
1787     fs_.Tick();
1788     fs_.Create("header.in", "");
1789
1790     // Run the build again.
1791     DepsLog deps_log;
1792     ASSERT_TRUE(deps_log.Load("ninja_deps", &state, &err));
1793     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1794
1795     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1796     builder.command_runner_.reset(&command_runner_);
1797     command_runner_.commands_ran_.clear();
1798     EXPECT_TRUE(builder.AddTarget("out", &err));
1799     ASSERT_EQ("", err);
1800     EXPECT_TRUE(builder.Build(&err));
1801     EXPECT_EQ("", err);
1802
1803     // Rule "true" should have run again, but the build of "out" should have
1804     // been cancelled due to restat propagating through the depfile header.
1805     EXPECT_EQ(1u, command_runner_.commands_ran_.size());
1806
1807     builder.command_runner_.release();
1808   }
1809 }
1810
1811 TEST_F(BuildWithDepsLogTest, DepFileOKDepsLog) {
1812   string err;
1813   const char* manifest =
1814       "rule cc\n  command = cc $in\n  depfile = $out.d\n  deps = gcc\n"
1815       "build fo$ o.o: cc foo.c\n";
1816
1817   fs_.Create("foo.c", "");
1818
1819   {
1820     State state;
1821     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1822
1823     // Run the build once, everything should be ok.
1824     DepsLog deps_log;
1825     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1826     ASSERT_EQ("", err);
1827
1828     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1829     builder.command_runner_.reset(&command_runner_);
1830     EXPECT_TRUE(builder.AddTarget("fo o.o", &err));
1831     ASSERT_EQ("", err);
1832     fs_.Create("fo o.o.d", "fo\\ o.o: blah.h bar.h\n");
1833     EXPECT_TRUE(builder.Build(&err));
1834     EXPECT_EQ("", err);
1835
1836     deps_log.Close();
1837     builder.command_runner_.release();
1838   }
1839
1840   {
1841     State state;
1842     ASSERT_NO_FATAL_FAILURE(AssertParse(&state, manifest));
1843
1844     DepsLog deps_log;
1845     ASSERT_TRUE(deps_log.Load("ninja_deps", &state, &err));
1846     ASSERT_TRUE(deps_log.OpenForWrite("ninja_deps", &err));
1847     ASSERT_EQ("", err);
1848
1849     Builder builder(&state, config_, NULL, &deps_log, &fs_);
1850     builder.command_runner_.reset(&command_runner_);
1851
1852     Edge* edge = state.edges_.back();
1853
1854     state.GetNode("bar.h")->MarkDirty();  // Mark bar.h as missing.
1855     EXPECT_TRUE(builder.AddTarget("fo o.o", &err));
1856     ASSERT_EQ("", err);
1857
1858     // Expect three new edges: one generating fo o.o, and two more from
1859     // loading the depfile.
1860     ASSERT_EQ(3u, state.edges_.size());
1861     // Expect our edge to now have three inputs: foo.c and two headers.
1862     ASSERT_EQ(3u, edge->inputs_.size());
1863
1864     // Expect the command line we generate to only use the original input.
1865     ASSERT_EQ("cc foo.c", edge->EvaluateCommand());
1866
1867     deps_log.Close();
1868     builder.command_runner_.release();
1869   }
1870 }
1871
1872 /// Check that a restat rule doesn't clear an edge if the depfile is missing.
1873 /// Follows from: https://github.com/martine/ninja/issues/603
1874 TEST_F(BuildTest, RestatMissingDepfile) {
1875 const char* manifest =
1876 "rule true\n"
1877 "  command = true\n"  // Would be "write if out-of-date" in reality.
1878 "  restat = 1\n"
1879 "build header.h: true header.in\n"
1880 "build out: cat header.h\n"
1881 "  depfile = out.d\n";
1882
1883   fs_.Create("header.h", "");
1884   fs_.Tick();
1885   fs_.Create("out", "");
1886   fs_.Create("header.in", "");
1887
1888   // Normally, only 'header.h' would be rebuilt, as
1889   // its rule doesn't touch the output and has 'restat=1' set.
1890   // But we are also missing the depfile for 'out',
1891   // which should force its command to run anyway!
1892   RebuildTarget("out", manifest);
1893   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
1894 }
1895
1896 /// Check that a restat rule doesn't clear an edge if the deps are missing.
1897 /// https://github.com/martine/ninja/issues/603
1898 TEST_F(BuildWithDepsLogTest, RestatMissingDepfileDepslog) {
1899   string err;
1900   const char* manifest =
1901 "rule true\n"
1902 "  command = true\n"  // Would be "write if out-of-date" in reality.
1903 "  restat = 1\n"
1904 "build header.h: true header.in\n"
1905 "build out: cat header.h\n"
1906 "  deps = gcc\n"
1907 "  depfile = out.d\n";
1908
1909   // Build once to populate ninja deps logs from out.d
1910   fs_.Create("header.in", "");
1911   fs_.Create("out.d", "out: header.h");
1912   fs_.Create("header.h", "");
1913
1914   RebuildTarget("out", manifest, "build_log", "ninja_deps");
1915   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
1916
1917   // Sanity: this rebuild should be NOOP
1918   RebuildTarget("out", manifest, "build_log", "ninja_deps");
1919   ASSERT_EQ(0u, command_runner_.commands_ran_.size());
1920
1921   // Touch 'header.in', blank dependencies log (create a different one).
1922   // Building header.h triggers 'restat' outputs cleanup.
1923   // Validate that out is rebuilt netherless, as deps are missing.
1924   fs_.Tick();
1925   fs_.Create("header.in", "");
1926
1927   // (switch to a new blank deps_log "ninja_deps2")
1928   RebuildTarget("out", manifest, "build_log", "ninja_deps2");
1929   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
1930
1931   // Sanity: this build should be NOOP
1932   RebuildTarget("out", manifest, "build_log", "ninja_deps2");
1933   ASSERT_EQ(0u, command_runner_.commands_ran_.size());
1934
1935   // Check that invalidating deps by target timestamp also works here
1936   // Repeat the test but touch target instead of blanking the log.
1937   fs_.Tick();
1938   fs_.Create("header.in", "");
1939   fs_.Create("out", "");
1940   RebuildTarget("out", manifest, "build_log", "ninja_deps2");
1941   ASSERT_EQ(2u, command_runner_.commands_ran_.size());
1942
1943   // And this build should be NOOP again
1944   RebuildTarget("out", manifest, "build_log", "ninja_deps2");
1945   ASSERT_EQ(0u, command_runner_.commands_ran_.size());
1946 }
1947
1948 TEST_F(BuildTest, Console) {
1949   ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
1950 "rule console\n"
1951 "  command = console\n"
1952 "  pool = console\n"
1953 "build cons: console in.txt\n"));
1954
1955   fs_.Create("in.txt", "");
1956
1957   string err;
1958   EXPECT_TRUE(builder_.AddTarget("cons", &err));
1959   ASSERT_EQ("", err);
1960   EXPECT_TRUE(builder_.Build(&err));
1961   EXPECT_EQ("", err);
1962   ASSERT_EQ(1u, command_runner_.commands_ran_.size());
1963 }