2 * \file lib/transaction.c
7 #include <rpmmacro.h> /* XXX for rpmExpand */
9 #define _NEED_TEITERATOR 1
13 #include "legacy.h" /* XXX domd5 */
14 #include "misc.h" /* XXX stripTrailingChar, splitString, currentDirectory */
17 /*@-redecl -exportheadervar@*/
19 extern const char * chroot_prefix;
20 /*@=redecl =exportheadervar@*/
22 /* XXX FIXME: merge with existing (broken?) tests in system.h */
23 /* portability fiddles */
24 #if STATFS_IN_SYS_STATVFS
26 # include <sys/statvfs.h>
27 #if defined(__LCLINT__)
28 /*@-declundef -exportheader -protoparammatch @*/ /* LCL: missing annotation */
29 extern int statvfs (const char * file, /*@out@*/ struct statvfs * buf)
30 /*@globals fileSystem @*/
31 /*@modifies *buf, fileSystem @*/;
32 /*@=declundef =exportheader =protoparammatch @*/
36 # if STATFS_IN_SYS_VFS
39 # if STATFS_IN_SYS_MOUNT
40 # include <sys/mount.h>
42 # if STATFS_IN_SYS_STATFS
43 # include <sys/statfs.h>
51 /*@access FD_t @*/ /* XXX compared with NULL */
52 /*@access Header @*/ /* XXX compared with NULL */
53 /*@access rpmProblemSet @*/ /* XXX need rpmProblemSetOK() */
54 /*@access dbiIndexSet @*/
64 /*@access teIterator @*/
65 /*@access rpmTransactionSet @*/
69 struct diskspaceInfo {
70 dev_t dev; /*!< File system device number. */
71 signed long bneeded; /*!< No. of blocks needed. */
72 signed long ineeded; /*!< No. of inodes needed. */
73 int bsize; /*!< File system block size. */
74 signed long bavail; /*!< No. of blocks available. */
75 signed long iavail; /*!< No. of inodes available. */
79 * Adjust for root only reserved space. On linux e2fs, this is 5%.
81 #define adj_fs_blocks(_nb) (((_nb) * 21) / 20)
83 /* argon thought a shift optimization here was a waste of time... he's
85 #define BLOCK_ROUND(size, block) (((size) + (block) - 1) / (block))
87 void rpmtransSetScriptFd(rpmTransactionSet ts, FD_t fd)
89 ts->scriptFd = (fd ? fdLink(fd, "rpmtransSetScriptFd") : NULL);
92 int rpmtransGetKeys(const rpmTransactionSet ts, fnpyKey ** ep, int * nep)
96 if (nep) *nep = ts->orderCount;
98 teIterator pi; transactionElement p;
101 *ep = e = xmalloc(ts->orderCount * sizeof(*e));
102 pi = teInitIterator(ts);
103 while ((p = teNextIterator(pi)) != NULL) {
104 switch (teGetType(p)) {
106 /*@-dependenttrans@*/
108 /*@=dependenttrans@*/
109 /*@switchbreak@*/ break;
113 /*@switchbreak@*/ break;
117 pi = teFreeIterator(pi);
124 static int archOkay(/*@null@*/ const char * pkgArch)
127 if (pkgArch == NULL) return 0;
128 return (rpmMachineScore(RPM_MACHTABLE_INSTARCH, pkgArch) ? 1 : 0);
133 static int osOkay(/*@null@*/ const char * pkgOs)
136 if (pkgOs == NULL) return 0;
137 return (rpmMachineScore(RPM_MACHTABLE_INSTOS, pkgOs) ? 1 : 0);
142 static int sharedCmp(const void * one, const void * two)
145 sharedFileInfo a = (sharedFileInfo) one;
146 sharedFileInfo b = (sharedFileInfo) two;
148 if (a->otherPkg < b->otherPkg)
150 else if (a->otherPkg > b->otherPkg)
158 static fileAction decideFileFate(const rpmTransactionSet ts,
159 const TFI_t ofi, TFI_t nfi)
160 /*@globals fileSystem @*/
161 /*@modifies nfi, fileSystem @*/
163 const char * fn = tfiGetFN(nfi);
164 int newFlags = tfiGetFFlags(nfi);
166 fileTypes dbWhat, newWhat, diskWhat;
168 int save = (newFlags & RPMFILE_NOREPLACE) ? FA_ALTNAME : FA_SAVE;
170 if (lstat(fn, &sb)) {
172 * The file doesn't exist on the disk. Create it unless the new
173 * package has marked it as missingok, or allfiles is requested.
175 if (!(ts->transFlags & RPMTRANS_FLAG_ALLFILES)
176 && (newFlags & RPMFILE_MISSINGOK))
178 rpmMessage(RPMMESS_DEBUG, _("%s skipped due to missingok flag\n"),
186 diskWhat = whatis(sb.st_mode);
187 dbWhat = whatis(ofi->fmodes[ofi->i]);
188 newWhat = whatis(nfi->fmodes[nfi->i]);
191 * RPM >= 2.3.10 shouldn't create config directories -- we'll ignore
192 * them in older packages as well.
197 if (diskWhat != newWhat)
199 else if (newWhat != dbWhat && diskWhat != dbWhat)
201 else if (dbWhat != newWhat)
203 else if (dbWhat != LINK && dbWhat != REG)
207 * This order matters - we'd prefer to CREATE the file if at all
208 * possible in case something else (like the timestamp) has changed.
211 if (ofi->md5s != NULL && nfi->md5s != NULL) {
212 const unsigned char * omd5 = ofi->md5s + (16 * ofi->i);
213 const unsigned char * nmd5 = nfi->md5s + (16 * nfi->i);
214 if (domd5(fn, buffer, 0))
215 return FA_CREATE; /* assume file has been removed */
216 if (!memcmp(omd5, buffer, 16))
217 return FA_CREATE; /* unmodified config file, replace. */
218 if (!memcmp(omd5, nmd5, 16))
219 return FA_SKIP; /* identical file, don't bother. */
221 const char * omd5 = ofi->fmd5s[ofi->i];
222 const char * nmd5 = nfi->fmd5s[nfi->i];
223 if (domd5(fn, buffer, 1))
224 return FA_CREATE; /* assume file has been removed */
225 if (!strcmp(omd5, buffer))
226 return FA_CREATE; /* unmodified config file, replace. */
227 if (!strcmp(omd5, nmd5))
228 return FA_SKIP; /* identical file, don't bother. */
230 } else /* dbWhat == LINK */ {
231 memset(buffer, 0, sizeof(buffer));
232 if (readlink(fn, buffer, sizeof(buffer) - 1) == -1)
233 return FA_CREATE; /* assume file has been removed */
234 if (!strcmp(ofi->flinks[ofi->i], buffer))
235 return FA_CREATE; /* unmodified config file, replace. */
236 if (!strcmp(ofi->flinks[ofi->i], nfi->flinks[nfi->i]))
237 return FA_SKIP; /* identical file, don't bother. */
241 * The config file on the disk has been modified, but
242 * the ones in the two packages are different. It would
243 * be nice if RPM was smart enough to at least try and
244 * merge the difference ala CVS, but...
251 static int filecmp(TFI_t afi, TFI_t bfi)
254 fileTypes awhat = whatis(afi->fmodes[afi->i]);
255 fileTypes bwhat = whatis(bfi->fmodes[bfi->i]);
257 if (awhat != bwhat) return 1;
260 const char * alink = afi->flinks[afi->i];
261 const char * blink = bfi->flinks[bfi->i];
262 return strcmp(alink, blink);
263 } else if (awhat == REG) {
264 if (afi->md5s != NULL && bfi->md5s != NULL) {
265 const unsigned char * amd5 = afi->md5s + (16 * afi->i);
266 const unsigned char * bmd5 = bfi->md5s + (16 * bfi->i);
267 return memcmp(amd5, bmd5, 16);
269 const char * amd5 = afi->fmd5s[afi->i];
270 const char * bmd5 = bfi->fmd5s[bfi->i];
271 return strcmp(amd5, bmd5);
280 /* XXX only ts->{probs,rpmdb} modified */
281 static int handleInstInstalledFiles(const rpmTransactionSet ts,
282 transactionElement p, TFI_t fi,
283 sharedFileInfo shared,
284 int sharedCount, int reportConflicts)
285 /*@globals fileSystem @*/
286 /*@modifies ts, fi, fileSystem @*/
288 const char * altNEVR = NULL;
289 TFI_t otherFi = NULL;
293 { rpmdbMatchIterator mi;
297 mi = rpmtsInitIterator(ts, RPMDBI_PACKAGES,
298 &shared->otherPkg, sizeof(shared->otherPkg));
299 while ((h = rpmdbNextIterator(mi)) != NULL) {
300 altNEVR = hGetNEVR(h, NULL);
301 otherFi = fiNew(ts, NULL, h, RPMTAG_BASENAMES, scareMem);
304 mi = rpmdbFreeIterator(mi);
310 fi->replaced = xcalloc(sharedCount, sizeof(*fi->replaced));
312 for (i = 0; i < sharedCount; i++, shared++) {
313 int otherFileNum, fileNum;
315 otherFileNum = shared->otherFileNum;
316 (void) tfiSetFX(otherFi, otherFileNum);
318 fileNum = shared->pkgFileNum;
319 (void) tfiSetFX(fi, fileNum);
322 /* XXX another tedious segfault, assume file state normal. */
323 if (otherStates && otherStates[otherFileNum] != RPMFILE_STATE_NORMAL)
327 if (XFA_SKIPPING(fi->actions[fileNum]))
330 if (filecmp(otherFi, fi)) {
331 if (reportConflicts) {
332 rpmProblemSetAppend(ts->probs, RPMPROB_FILE_CONFLICT,
333 teGetNEVR(p), teGetKey(p),
334 tfiGetDN(fi), tfiGetBN(fi),
338 if (!(tfiGetFFlags(otherFi) | tfiGetFFlags(fi)) & RPMFILE_CONFIG) {
339 /*@-assignexpose@*/ /* FIX: p->replaced, not fi */
340 if (!shared->isRemoved)
341 fi->replaced[numReplaced++] = *shared;
346 if ((tfiGetFFlags(otherFi) | tfiGetFFlags(fi)) & RPMFILE_CONFIG) {
348 action = decideFileFate(ts, otherFi, fi);
349 fi->actions[fileNum] = action;
351 fi->replacedSizes[fileNum] = otherFi->fsizes[otherFi->i];
355 altNEVR = _free(altNEVR);
356 otherFi = fiFree(otherFi, 1);
358 fi->replaced = xrealloc(fi->replaced, /* XXX memory leak */
359 sizeof(*fi->replaced) * (numReplaced + 1));
360 fi->replaced[numReplaced].otherPkg = 0;
367 /* XXX only ts->rpmdb modified */
368 static int handleRmvdInstalledFiles(const rpmTransactionSet ts, TFI_t fi,
369 sharedFileInfo shared, int sharedCount)
370 /*@globals fileSystem @*/
371 /*@modifies ts, fi, fileSystem @*/
375 const char * otherStates;
378 rpmdbMatchIterator mi;
380 mi = rpmtsInitIterator(ts, RPMDBI_PACKAGES,
381 &shared->otherPkg, sizeof(shared->otherPkg));
382 h = rpmdbNextIterator(mi);
384 mi = rpmdbFreeIterator(mi);
388 xx = hge(h, RPMTAG_FILESTATES, NULL, (void **) &otherStates, NULL);
390 for (i = 0; i < sharedCount; i++, shared++) {
391 int otherFileNum, fileNum;
392 otherFileNum = shared->otherFileNum;
393 fileNum = shared->pkgFileNum;
395 if (otherStates[otherFileNum] != RPMFILE_STATE_NORMAL)
398 fi->actions[fileNum] = FA_SKIP;
401 mi = rpmdbFreeIterator(mi);
406 #define ISROOT(_d) (((_d)[0] == '/' && (_d)[1] == '\0') ? "" : (_d))
409 static int _fps_debug = 0;
411 static int fpsCompare (const void * one, const void * two)
413 const struct fingerPrint_s * a = (const struct fingerPrint_s *)one;
414 const struct fingerPrint_s * b = (const struct fingerPrint_s *)two;
415 int adnlen = strlen(a->entry->dirName);
416 int asnlen = (a->subDir ? strlen(a->subDir) : 0);
417 int abnlen = strlen(a->baseName);
418 int bdnlen = strlen(b->entry->dirName);
419 int bsnlen = (b->subDir ? strlen(b->subDir) : 0);
420 int bbnlen = strlen(b->baseName);
421 char * afn, * bfn, * t;
424 if (adnlen == 1 && asnlen != 0) adnlen = 0;
425 if (bdnlen == 1 && bsnlen != 0) bdnlen = 0;
427 afn = t = alloca(adnlen+asnlen+abnlen+2);
428 if (adnlen) t = stpcpy(t, a->entry->dirName);
430 if (a->subDir && asnlen) t = stpcpy(t, a->subDir);
431 if (abnlen) t = stpcpy(t, a->baseName);
432 if (afn[0] == '/' && afn[1] == '/') afn++;
434 bfn = t = alloca(bdnlen+bsnlen+bbnlen+2);
435 if (bdnlen) t = stpcpy(t, b->entry->dirName);
437 if (b->subDir && bsnlen) t = stpcpy(t, b->subDir);
438 if (bbnlen) t = stpcpy(t, b->baseName);
439 if (bfn[0] == '/' && bfn[1] == '/') bfn++;
441 rc = strcmp(afn, bfn);
444 fprintf(stderr, "\trc(%d) = strcmp(\"%s\", \"%s\")\n", rc, afn, bfn);
449 fprintf(stderr, "\t%s/%s%s\trc %d\n",
450 ISROOT(b->entry->dirName),
451 (b->subDir ? b->subDir : ""),
461 static int _linear_fps_search = 0;
463 static int findFps(const struct fingerPrint_s * fiFps,
464 const struct fingerPrint_s * otherFps,
472 fprintf(stderr, "==> %s/%s%s\n",
473 ISROOT(fiFps->entry->dirName),
474 (fiFps->subDir ? fiFps->subDir : ""),
478 if (_linear_fps_search) {
481 for (otherFileNum = 0; otherFileNum < otherFc; otherFileNum++, otherFps++) {
485 fprintf(stderr, "\t%4d %s/%s%s\n", otherFileNum,
486 ISROOT(otherFps->entry->dirName),
487 (otherFps->subDir ? otherFps->subDir : ""),
491 /* If the addresses are the same, so are the values. */
492 if (fiFps == otherFps)
495 /* Otherwise, compare fingerprints by value. */
496 /*@-nullpass@*/ /* LCL: looks good to me */
497 if (FP_EQUAL((*fiFps), (*otherFps)))
502 if (otherFileNum == otherFc) {
505 fprintf(stderr, "*** NULL %s/%s%s\n",
506 ISROOT(fiFps->entry->dirName),
507 (fiFps->subDir ? fiFps->subDir : ""),
516 const struct fingerPrint_s * bingoFps;
518 bingoFps = bsearch(fiFps, otherFps, otherFc, sizeof(*otherFps), fpsCompare);
519 if (bingoFps == NULL) {
521 fprintf(stderr, "*** NULL %s/%s%s\n",
522 ISROOT(fiFps->entry->dirName),
523 (fiFps->subDir ? fiFps->subDir : ""),
529 /* If the addresses are the same, so are the values. */
530 /*@-nullpass@*/ /* LCL: looks good to me */
531 if (!(fiFps == bingoFps || FP_EQUAL((*fiFps), (*bingoFps)))) {
533 fprintf(stderr, "*** BAD %s/%s%s\n",
534 ISROOT(bingoFps->entry->dirName),
535 (bingoFps->subDir ? bingoFps->subDir : ""),
541 otherFileNum = (bingoFps != NULL ? (bingoFps - otherFps) : 0);
549 * Update disk space needs on each partition for this package.
551 /* XXX only ts->{probs,di} modified */
552 static void handleOverlappedFiles(const rpmTransactionSet ts,
553 const transactionElement p, TFI_t fi)
554 /*@globals fileSystem @*/
555 /*@modifies ts, fi, fileSystem @*/
557 struct diskspaceInfo * ds = NULL;
558 uint_32 fixupSize = 0;
564 while ((i = tfiNext(fi)) >= 0) {
565 struct fingerPrint_s * fiFps;
566 int otherPkgNum, otherFileNum;
571 if (XFA_SKIPPING(fi->actions[i]))
579 while (ds->bsize && ds->dev != fi->fps[i].entry->dev) ds++;
580 if (!ds->bsize) ds = NULL;
585 * Retrieve all records that apply to this file. Note that the
586 * file info records were built in the same order as the packages
587 * will be installed and removed so the records for an overlapped
588 * files will be sorted in exactly the same order.
590 (void) htGetEntry(ts->ht, fiFps,
591 (const void ***) &recs, &numRecs, NULL);
594 * If this package is being added, look only at other packages
595 * being added -- removed packages dance to a different tune.
596 * If both this and the other package are being added, overlapped
597 * files must be identical (or marked as a conflict). The
598 * disposition of already installed config files leads to
599 * a small amount of extra complexity.
601 * If this package is being removed, then there are two cases that
602 * need to be worried about:
603 * If the other package is being added, then skip any overlapped files
604 * so that this package removal doesn't nuke the overlapped files
605 * that were just installed.
606 * If both this and the other package are being removed, then each
607 * file removal from preceding packages needs to be skipped so that
608 * the file removal occurs only on the last occurence of an overlapped
609 * file in the transaction set.
613 /* Locate this overlapped file in the set of added/removed packages. */
614 for (j = 0; j < numRecs && recs[j] != fi; j++)
617 /* Find what the previous disposition of this file was. */
618 otherFileNum = -1; /* keep gcc quiet */
620 for (otherPkgNum = j - 1; otherPkgNum >= 0; otherPkgNum--) {
621 struct fingerPrint_s * otherFps;
624 otherFi = recs[otherPkgNum];
626 /* Added packages need only look at other added packages. */
627 if (teGetType(p) == TR_ADDED && teGetType(otherFi->te) != TR_ADDED)
628 /*@innercontinue@*/ continue;
630 otherFps = otherFi->fps;
631 otherFc = tfiGetFC(otherFi);
633 otherFileNum = findFps(fiFps, otherFps, otherFc);
634 (void) tfiSetFX(otherFi, otherFileNum);
636 /* XXX is this test still necessary? */
637 if (otherFi->actions[otherFileNum] != FA_UNKNOWN)
638 /*@innerbreak@*/ break;
641 switch (teGetType(p)) {
644 if (otherPkgNum < 0) {
645 /* XXX is this test still necessary? */
646 if (fi->actions[i] != FA_UNKNOWN)
647 /*@switchbreak@*/ break;
648 if ((tfiGetFFlags(fi) & RPMFILE_CONFIG) &&
650 /* Here is a non-overlapped pre-existing config file. */
651 fi->actions[i] = (tfiGetFFlags(fi) & RPMFILE_NOREPLACE)
652 ? FA_ALTNAME : FA_BACKUP;
654 fi->actions[i] = FA_CREATE;
656 /*@switchbreak@*/ break;
659 assert(otherFi != NULL);
660 /* Mark added overlapped non-identical files as a conflict. */
661 if ((ts->ignoreSet & RPMPROB_FILTER_REPLACENEWFILES)
662 && filecmp(otherFi, fi))
664 rpmProblemSetAppend(ts->probs, RPMPROB_NEW_FILE_CONFLICT,
665 teGetNEVR(p), teGetKey(p),
667 teGetNEVR(otherFi->te),
671 /* Try to get the disk accounting correct even if a conflict. */
672 fixupSize = otherFi->fsizes[otherFileNum];
674 if ((tfiGetFFlags(fi) & RPMFILE_CONFIG) && !lstat(fn, &sb)) {
675 /* Here is an overlapped pre-existing config file. */
676 fi->actions[i] = (tfiGetFFlags(fi) & RPMFILE_NOREPLACE)
677 ? FA_ALTNAME : FA_SKIP;
679 fi->actions[i] = FA_CREATE;
681 } /*@switchbreak@*/ break;
684 if (otherPkgNum >= 0) {
685 assert(otherFi != NULL);
686 /* Here is an overlapped added file we don't want to nuke. */
687 if (otherFi->actions[otherFileNum] != FA_ERASE) {
688 /* On updates, don't remove files. */
689 fi->actions[i] = FA_SKIP;
690 /*@switchbreak@*/ break;
692 /* Here is an overlapped removed file: skip in previous. */
693 otherFi->actions[otherFileNum] = FA_SKIP;
695 if (XFA_SKIPPING(fi->actions[i]))
696 /*@switchbreak@*/ break;
697 if (fi->fstates && fi->fstates[i] != RPMFILE_STATE_NORMAL)
698 /*@switchbreak@*/ break;
699 if (!(S_ISREG(fi->fmodes[i]) && (tfiGetFFlags(fi) & RPMFILE_CONFIG))) {
700 fi->actions[i] = FA_ERASE;
701 /*@switchbreak@*/ break;
704 /* Here is a pre-existing modified config file that needs saving. */
706 if (fi->md5s != NULL) {
707 const unsigned char * fmd5 = fi->md5s + (16 * i);
708 if (!domd5(fn, md5sum, 0) && memcmp(fmd5, md5sum, 16)) {
709 fi->actions[i] = FA_BACKUP;
710 /*@switchbreak@*/ break;
713 const char * fmd5 = fi->fmd5s[i];
714 if (!domd5(fn, md5sum, 1) && strcmp(fmd5, md5sum)) {
715 fi->actions[i] = FA_BACKUP;
716 /*@switchbreak@*/ break;
720 fi->actions[i] = FA_ERASE;
721 /*@switchbreak@*/ break;
725 uint_32 s = BLOCK_ROUND(fi->fsizes[i], ds->bsize);
727 switch (fi->actions[i]) {
733 /*@switchbreak@*/ break;
736 * FIXME: If two packages share a file (same md5sum), and
737 * that file is being replaced on disk, will ds->bneeded get
738 * decremented twice? Quite probably!
742 ds->bneeded -= BLOCK_ROUND(fi->replacedSizes[i], ds->bsize);
743 /*@switchbreak@*/ break;
748 /*@switchbreak@*/ break;
751 /*@switchbreak@*/ break;
754 ds->bneeded -= BLOCK_ROUND(fixupSize, ds->bsize);
760 * Ensure that current package is newer than installed package.
761 * @param ts transaction set
762 * @param p current transaction element
763 * @param h installed header
764 * @return 0 if not newer, 1 if okay
766 static int ensureOlder(rpmTransactionSet ts,
767 const transactionElement p, const Header h)
770 int_32 reqFlags = (RPMSENSE_LESS | RPMSENSE_EQUAL);
777 if (p == NULL || h == NULL)
780 nb = strlen(teGetNEVR(p)) + (teGetE(p) != NULL ? strlen(teGetE(p)) : 0) + 1;
784 if (teGetE(p) != NULL) t = stpcpy( stpcpy(t, teGetE(p)), ":");
785 if (teGetV(p) != NULL) t = stpcpy(t, teGetV(p));
787 if (teGetR(p) != NULL) t = stpcpy(t, teGetR(p));
789 req = dsSingle(RPMTAG_REQUIRENAME, teGetN(p), reqEVR, reqFlags);
790 rc = headerMatchesDepFlags(h, req);
794 const char * altNEVR = hGetNEVR(h, NULL);
795 rpmProblemSetAppend(ts->probs, RPMPROB_OLDPACKAGE,
796 teGetNEVR(p), teGetKey(p),
800 altNEVR = _free(altNEVR);
810 /*@-mustmod@*/ /* FIX: fi->actions is modified. */
811 static void skipFiles(const rpmTransactionSet ts, TFI_t fi)
812 /*@globals rpmGlobalMacroContext @*/
813 /*@modifies fi, rpmGlobalMacroContext @*/
815 int noDocs = (ts->transFlags & RPMTRANS_FLAG_NODOCS);
816 char ** netsharedPaths = NULL;
817 const char ** languages;
818 const char * dn, * bn;
819 int dnlen, bnlen, ix;
827 noDocs = rpmExpandNumeric("%{_excludedocs}");
829 { const char *tmpPath = rpmExpand("%{_netsharedpath}", NULL);
831 if (tmpPath && *tmpPath != '%')
832 netsharedPaths = splitString(tmpPath, strlen(tmpPath), ':');
834 tmpPath = _free(tmpPath);
837 s = rpmExpand("%{_install_langs}", NULL);
839 if (!(s && *s != '%'))
842 languages = (const char **) splitString(s, strlen(s), ':');
848 /* Compute directory refcount, skip directory if now empty. */
850 drc = alloca(dc * sizeof(*drc));
851 memset(drc, 0, dc * sizeof(*drc));
852 dff = alloca(dc * sizeof(*dff));
853 memset(dff, 0, dc * sizeof(*dff));
855 if ((fi = tfiInit(fi, 0)) != NULL)
856 while ((i = tfiNext(fi)) >= 0)
866 continue; /* XXX can't happen */
870 /* Don't bother with skipped files */
871 if (XFA_SKIPPING(fi->actions[i])) {
877 * Skip net shared paths.
878 * Net shared paths are not relative to the current root (though
879 * they do need to take package relocations into account).
881 for (nsp = netsharedPaths; nsp && *nsp; nsp++) {
886 if (strncmp(dn, *nsp, len))
887 /*@innercontinue@*/ continue;
888 /* Only directories or complete file paths can be net shared */
889 if (!(dn[len] == '/' || dn[len] == '\0'))
890 /*@innercontinue@*/ continue;
892 if (len < (dnlen + bnlen))
893 /*@innercontinue@*/ continue;
894 if (strncmp(dn, *nsp, dnlen))
895 /*@innercontinue@*/ continue;
896 if (strncmp(bn, (*nsp) + dnlen, bnlen))
897 /*@innercontinue@*/ continue;
899 /* Only directories or complete file paths can be net shared */
900 if (!((*nsp)[len] == '/' || (*nsp)[len] == '\0'))
901 /*@innercontinue@*/ continue;
904 /*@innerbreak@*/ break;
908 drc[ix]--; dff[ix] = 1;
909 fi->actions[i] = FA_SKIPNETSHARED;
914 * Skip i18n language specific files.
916 if (fi->flangs && languages && *fi->flangs[i]) {
917 const char **lang, *l, *le;
918 for (lang = languages; *lang != NULL; lang++) {
919 if (!strcmp(*lang, "all"))
920 /*@innerbreak@*/ break;
921 for (l = fi->flangs[i]; *l != '\0'; l = le) {
922 for (le = l; *le != '\0' && *le != '|'; le++)
924 if ((le-l) > 0 && !strncmp(*lang, l, (le-l)))
925 /*@innerbreak@*/ break;
926 if (*le == '|') le++; /* skip over | */
929 /*@innerbreak@*/ break;
932 drc[ix]--; dff[ix] = 1;
933 fi->actions[i] = FA_SKIPNSTATE;
939 * Skip documentation if requested.
941 if (noDocs && (tfiGetFFlags(fi) & RPMFILE_DOC)) {
942 drc[ix]--; dff[ix] = 1;
943 fi->actions[i] = FA_SKIPNSTATE;
948 /* Skip (now empty) directories that had skipped files. */
950 if (fi != NULL) /* XXX can't happen */
951 for (j = 0; j < dc; j++)
953 if ((fi = tdiInit(fi)) != NULL)
954 while (j = tdiNext(fi) >= 0)
958 if (drc[j]) continue; /* dir still has files. */
959 if (!dff[j]) continue; /* dir was not emptied here. */
961 /* Find parent directory and basename. */
962 dn = fi->dnl[j]; dnlen = strlen(dn) - 1;
963 bn = dn + dnlen; bnlen = 0;
964 while (bn > dn && bn[-1] != '/') {
970 /* If explicitly included in the package, skip the directory. */
971 if ((fi = tfiInit(fi, 0)) != NULL)
972 while ((i = tfiNext(fi)) >= 0) {
975 if (XFA_SKIPPING(fi->actions[i]))
976 /*@innercontinue@*/ continue;
977 if (whatis(fi->fmodes[i]) != XDIR)
978 /*@innercontinue@*/ continue;
979 dir = fi->dnl[fi->dil[i]];
980 if (strlen(dir) != dnlen)
981 /*@innercontinue@*/ continue;
982 if (strncmp(dir, dn, dnlen))
983 /*@innercontinue@*/ continue;
984 if (strlen(fi->bnl[i]) != bnlen)
985 /*@innercontinue@*/ continue;
986 if (strncmp(fi->bnl[i], bn, bnlen))
987 /*@innercontinue@*/ continue;
988 rpmMessage(RPMMESS_DEBUG, _("excluding directory %s\n"), dn);
989 fi->actions[i] = FA_SKIPNSTATE;
990 /*@innerbreak@*/ break;
994 if (netsharedPaths) freeSplitString(netsharedPaths);
995 #ifdef DYING /* XXX freeFi will deal with this later. */
996 fi->flangs = _free(fi->flangs);
998 if (languages) freeSplitString((char **)languages);
1003 * Return transaction element's file info.
1004 * @todo Take a TFI_t refcount here.
1005 * @param tei transaction element iterator
1006 * @return transaction element file info
1009 TFI_t teiGetFi(const teIterator tei)
1014 if (tei != NULL && tei->ocsave != -1) {
1015 /*@-type -abstract@*/ /* FIX: transactionElement not opaque */
1016 transactionElement te = tei->ts->order[tei->ocsave];
1018 if ((fi = te->fi) != NULL)
1021 /*@=type =abstract@*/
1023 /*@-compdef -refcounttrans -usereleased @*/
1025 /*@=compdef =refcounttrans =usereleased @*/
1028 #define NOTIFY(_ts, _al) if ((_ts)->notify) (void) (_ts)->notify _al
1030 int rpmRunTransactions( rpmTransactionSet ts,
1031 rpmCallbackFunction notify, rpmCallbackData notifyData,
1032 rpmProblemSet okProbs, rpmProblemSet * newProbs,
1033 rpmtransFlags transFlags, rpmprobFilterFlags ignoreSet)
1037 int totalFileCount = 0;
1039 struct diskspaceInfo * dip;
1040 sharedFileInfo shared, sharedList;
1044 fingerPrintCache fpc;
1045 PSM_t psm = memset(alloca(sizeof(*psm)), 0, sizeof(*psm));
1046 teIterator pi; transactionElement p;
1047 teIterator qi; transactionElement q;
1050 /* FIXME: what if the same package is included in ts twice? */
1052 ts->transFlags = transFlags;
1053 if (ts->transFlags & RPMTRANS_FLAG_NOSCRIPTS)
1054 ts->transFlags |= (_noTransScripts | _noTransTriggers);
1055 if (ts->transFlags & RPMTRANS_FLAG_NOTRIGGERS)
1056 ts->transFlags |= _noTransTriggers;
1058 /* XXX MULTILIB is broken, as packages can and do execute /sbin/ldconfig. */
1059 if (ts->transFlags & (RPMTRANS_FLAG_JUSTDB | RPMTRANS_FLAG_MULTILIB))
1060 ts->transFlags |= (_noTransScripts | _noTransTriggers);
1062 ts->notify = notify;
1063 ts->notifyData = notifyData;
1064 ts->probs = rpmProblemSetFree(ts->probs);
1065 ts->probs = rpmProblemSetCreate();
1066 *newProbs = rpmpsLink(ts->probs, "RunTransactions");
1067 ts->ignoreSet = ignoreSet;
1068 ts->currDir = _free(ts->currDir);
1069 ts->currDir = currentDirectory();
1071 if (ts->rpmdb) ts->rpmdb->db_chrootDone = 0;
1072 ts->id = (int_32) time(NULL);
1074 memset(psm, 0, sizeof(*psm));
1075 psm->ts = rpmtsLink(ts, "tsRun");
1077 /* Get available space on mounted file systems. */
1078 if (!(ts->ignoreSet & RPMPROB_FILTER_DISKSPACE) &&
1079 !rpmGetFilesystemList(&ts->filesystems, &ts->filesystemCount))
1083 rpmMessage(RPMMESS_DEBUG, _("getting list of mounted filesystems\n"));
1085 ts->di = _free(ts->di);
1086 dip = ts->di = xcalloc((ts->filesystemCount + 1), sizeof(*ts->di));
1088 for (i = 0; (i < ts->filesystemCount) && dip; i++) {
1089 #if STATFS_IN_SYS_STATVFS
1091 memset(&sfb, 0, sizeof(sfb));
1092 if (statvfs(ts->filesystems[i], &sfb))
1096 /* This platform has the 4-argument version of the statfs call. The last two
1097 * should be the size of struct statfs and 0, respectively. The 0 is the
1098 * filesystem type, and is always 0 when statfs is called on a mounted
1099 * filesystem, as we're doing.
1101 memset(&sfb, 0, sizeof(sfb));
1102 if (statfs(ts->filesystems[i], &sfb, sizeof(sfb), 0))
1104 memset(&sfb, 0, sizeof(sfb));
1105 if (statfs(ts->filesystems[i], &sfb))
1111 ts->di[i].bsize = sfb.f_bsize;
1112 ts->di[i].bneeded = 0;
1113 ts->di[i].ineeded = 0;
1114 #ifdef STATFS_HAS_F_BAVAIL
1115 ts->di[i].bavail = sfb.f_bavail;
1117 /* FIXME: the statfs struct doesn't have a member to tell how many blocks are
1118 * available for non-superusers. f_blocks - f_bfree is probably too big, but
1119 * it's about all we can do.
1121 ts->di[i].bavail = sfb.f_blocks - sfb.f_bfree;
1123 /* XXX Avoid FAT and other file systems that have not inodes. */
1124 ts->di[i].iavail = !(sfb.f_ffree == 0 && sfb.f_files == 0)
1127 xx = stat(ts->filesystems[i], &sb);
1128 ts->di[i].dev = sb.st_dev;
1132 if (dip) ts->di[i].bsize = 0;
1135 /* ===============================================
1136 * For packages being installed:
1137 * - verify package arch/os.
1138 * - verify package epoch:version-release is newer.
1140 * For packages being removed:
1143 /* The ordering doesn't matter here */
1144 pi = teInitIterator(ts);
1145 while ((p = teNext(pi, TR_ADDED)) != NULL) {
1146 rpmdbMatchIterator mi;
1149 if ((fi = teiGetFi(pi)) == NULL)
1150 continue; /* XXX can't happen */
1153 if (!(ts->ignoreSet & RPMPROB_FILTER_IGNOREARCH))
1154 if (!archOkay(teGetA(p)))
1155 rpmProblemSetAppend(ts->probs, RPMPROB_BADARCH,
1156 teGetNEVR(p), teGetKey(p),
1160 if (!(ts->ignoreSet & RPMPROB_FILTER_IGNOREOS))
1161 if (!osOkay(teGetO(p)))
1162 rpmProblemSetAppend(ts->probs, RPMPROB_BADOS,
1163 teGetNEVR(p), teGetKey(p),
1167 if (!(ts->ignoreSet & RPMPROB_FILTER_OLDPACKAGE)) {
1169 mi = rpmtsInitIterator(ts, RPMTAG_NAME, teGetN(p), 0);
1170 while ((h = rpmdbNextIterator(mi)) != NULL)
1171 xx = ensureOlder(ts, p, h);
1172 mi = rpmdbFreeIterator(mi);
1175 /* XXX multilib should not display "already installed" problems */
1176 if (!(ts->ignoreSet & RPMPROB_FILTER_REPLACEPKG) && !teGetMultiLib(p)) {
1177 mi = rpmtsInitIterator(ts, RPMTAG_NAME, teGetN(p), 0);
1178 xx = rpmdbSetIteratorRE(mi, RPMTAG_VERSION, RPMMIRE_DEFAULT,
1180 xx = rpmdbSetIteratorRE(mi, RPMTAG_RELEASE, RPMMIRE_DEFAULT,
1183 while (rpmdbNextIterator(mi) != NULL) {
1184 rpmProblemSetAppend(ts->probs, RPMPROB_PKG_INSTALLED,
1185 teGetNEVR(p), teGetKey(p),
1188 /*@innerbreak@*/ break;
1190 mi = rpmdbFreeIterator(mi);
1193 /* Count no. of files (if any). */
1194 totalFileCount += fc;
1197 pi = teFreeIterator(pi);
1199 /* The ordering doesn't matter here */
1200 pi = teInitIterator(ts);
1201 while ((p = teNext(pi, TR_REMOVED)) != NULL) {
1204 if ((fi = teiGetFi(pi)) == NULL)
1205 continue; /* XXX can't happen */
1208 totalFileCount += fc;
1210 pi = teFreeIterator(pi);
1212 /* ===============================================
1213 * Initialize transaction element file info for package:
1217 * FIXME?: we'd be better off assembling one very large file list and
1218 * calling fpLookupList only once. I'm not sure that the speedup is
1219 * worth the trouble though.
1221 pi = teInitIterator(ts);
1222 while ((p = teNextIterator(pi)) != NULL) {
1225 if ((fi = teiGetFi(pi)) == NULL)
1226 continue; /* XXX can't happen */
1229 #ifdef DYING /* XXX W2DO? this is now done teiGetFi, okay ??? */
1230 fi->magic = TFIMAGIC;
1235 switch (teGetType(p)) {
1238 /* Skip netshared paths, not our i18n files, and excluded docs */
1241 /*@switchbreak@*/ break;
1243 fi->record = teGetDBOffset(p);
1244 /*@switchbreak@*/ break;
1248 fi->fps = (fc > 0 ? xmalloc(fc * sizeof(*fi->fps)) : NULL);
1250 pi = teFreeIterator(pi);
1252 if (!ts->chrootDone) {
1254 /*@-superuser -noeffect @*/
1255 xx = chroot(ts->rootDir);
1256 /*@=superuser =noeffect @*/
1258 if (ts->rpmdb) ts->rpmdb->db_chrootDone = 1;
1261 chroot_prefix = ts->rootDir;
1266 ts->ht = htCreate(totalFileCount * 2, 0, 0, fpHashFunction, fpEqual);
1267 fpc = fpCacheCreate(totalFileCount);
1269 /* ===============================================
1270 * Add fingerprint for each file not skipped.
1272 pi = teInitIterator(ts);
1273 while ((p = teNextIterator(pi)) != NULL) {
1276 if ((fi = teiGetFi(pi)) == NULL)
1277 continue; /* XXX can't happen */
1280 fpLookupList(fpc, fi->dnl, fi->bnl, fi->dil, fc, fi->fps);
1282 if ((fi = tfiInit(fi, 0)) != NULL)
1283 while ((i = tfiNext(fi)) >= 0) {
1284 if (XFA_SKIPPING(fi->actions[i]))
1285 /*@innercontinue@*/ continue;
1286 /*@-dependenttrans@*/
1287 htAddEntry(ts->ht, fi->fps + i, (void *) fi);
1288 /*@=dependenttrans@*/
1292 pi = teFreeIterator(pi);
1294 /*@-noeffectuncon @*/ /* FIX: check rc */
1295 NOTIFY(ts, (NULL, RPMCALLBACK_TRANS_START, 6, ts->orderCount,
1296 NULL, ts->notifyData));
1297 /*@=noeffectuncon@*/
1299 /* ===============================================
1300 * Compute file disposition for each package in transaction set.
1302 pi = teInitIterator(ts);
1303 while ((p = teNextIterator(pi)) != NULL) {
1304 dbiIndexSet * matches;
1308 if ((fi = teiGetFi(pi)) == NULL)
1309 continue; /* XXX can't happen */
1312 /*@-noeffectuncon @*/ /* FIX: check rc */
1313 NOTIFY(ts, (NULL, RPMCALLBACK_TRANS_PROGRESS, teiGetOc(pi),
1314 ts->orderCount, NULL, ts->notifyData));
1315 /*@=noeffectuncon@*/
1317 if (fc == 0) continue;
1319 /* Extract file info for all files in this package from the database. */
1320 matches = xcalloc(fc, sizeof(*matches));
1321 if (rpmdbFindFpList(ts->rpmdb, fi->fps, matches, fc)) {
1322 psm->ts = rpmtsUnlink(ts, "tsRun (rpmFindFpList fail)");
1323 return 1; /* XXX WTFO? */
1327 if ((fi = tfiInit(fi, 0)) != NULL)
1328 while ((i = tfiNext(fi)) >= 0)
1329 numShared += dbiIndexSetCount(matches[i]);
1331 /* Build sorted file info list for this package. */
1332 shared = sharedList = xcalloc((numShared + 1), sizeof(*sharedList));
1334 if ((fi = tfiInit(fi, 0)) != NULL)
1335 while ((i = tfiNext(fi)) >= 0) {
1337 * Take care not to mark files as replaced in packages that will
1338 * have been removed before we will get here.
1340 for (j = 0; j < dbiIndexSetCount(matches[i]); j++) {
1342 ro = dbiIndexRecordOffset(matches[i], j);
1344 qi = teInitIterator(ts);
1345 while ((q = teNext(qi, TR_REMOVED)) != NULL) {
1347 /*@innerbreak@*/ break;
1348 if (teGetDBOffset(q) == ro)
1351 qi = teFreeIterator(qi);
1353 shared->pkgFileNum = i;
1354 shared->otherPkg = dbiIndexRecordOffset(matches[i], j);
1355 shared->otherFileNum = dbiIndexRecordFileNumber(matches[i], j);
1356 shared->isRemoved = (knownBad == ro);
1359 matches[i] = dbiFreeIndexSet(matches[i]);
1361 numShared = shared - sharedList;
1362 shared->otherPkg = -1;
1363 matches = _free(matches);
1365 /* Sort file info by other package index (otherPkg) */
1366 qsort(sharedList, numShared, sizeof(*shared), sharedCmp);
1368 /* For all files from this package that are in the database ... */
1369 for (i = 0; i < numShared; i = nexti) {
1372 shared = sharedList + i;
1374 /* Find the end of the files in the other package. */
1375 for (nexti = i + 1; nexti < numShared; nexti++) {
1376 if (sharedList[nexti].otherPkg != shared->otherPkg)
1377 /*@innerbreak@*/ break;
1380 /* Is this file from a package being removed? */
1382 if (ts->removedPackages != NULL)
1383 for (j = 0; j < ts->numRemovedPackages; j++) {
1384 if (ts->removedPackages[j] != shared->otherPkg)
1385 /*@innercontinue@*/ continue;
1387 /*@innerbreak@*/ break;
1390 /* Determine the fate of each file. */
1391 switch (teGetType(p)) {
1393 xx = handleInstInstalledFiles(ts, p, fi, shared, nexti - i,
1394 !(beingRemoved || (ts->ignoreSet & RPMPROB_FILTER_REPLACEOLDFILES)));
1395 /*@switchbreak@*/ break;
1398 xx = handleRmvdInstalledFiles(ts, fi, shared, nexti - i);
1399 /*@switchbreak@*/ break;
1405 /* Update disk space needs on each partition for this package. */
1406 handleOverlappedFiles(ts, p, fi);
1408 /* Check added package has sufficient space on each partition used. */
1409 switch (teGetType(p)) {
1411 if (!(ts->di && tfiGetFC(fi) > 0))
1412 /*@switchbreak@*/ break;
1413 for (i = 0; i < ts->filesystemCount; i++) {
1417 /* XXX Avoid FAT and other file systems that have not inodes. */
1418 if (dip->iavail <= 0)
1419 /*@innercontinue@*/ continue;
1421 if (adj_fs_blocks(dip->bneeded) > dip->bavail) {
1422 rpmProblemSetAppend(ts->probs, RPMPROB_DISKSPACE,
1423 teGetNEVR(p), teGetKey(p),
1424 ts->filesystems[i], NULL, NULL,
1425 (adj_fs_blocks(dip->bneeded) - dip->bavail) * dip->bsize);
1428 if (adj_fs_blocks(dip->ineeded) > dip->iavail) {
1429 rpmProblemSetAppend(ts->probs, RPMPROB_DISKNODES,
1430 teGetNEVR(p), teGetKey(p),
1431 ts->filesystems[i], NULL, NULL,
1432 (adj_fs_blocks(dip->ineeded) - dip->iavail));
1435 /*@switchbreak@*/ break;
1437 /*@switchbreak@*/ break;
1440 pi = teFreeIterator(pi);
1442 if (ts->chrootDone) {
1443 /*@-superuser -noeffect @*/
1445 /*@=superuser =noeffect @*/
1447 if (ts->rpmdb) ts->rpmdb->db_chrootDone = 0;
1449 chroot_prefix = NULL;
1451 xx = chdir(ts->currDir);
1454 /*@-noeffectuncon @*/ /* FIX: check rc */
1455 NOTIFY(ts, (NULL, RPMCALLBACK_TRANS_STOP, 6, ts->orderCount,
1456 NULL, ts->notifyData));
1457 /*@=noeffectuncon @*/
1459 /* ===============================================
1460 * Free unused memory as soon as possible.
1462 pi = teInitIterator(ts);
1463 while ((p = teNextIterator(pi)) != NULL) {
1464 if ((fi = teiGetFi(pi)) == NULL)
1465 continue; /* XXX can't happen */
1466 if (tfiGetFC(fi) == 0)
1468 fi->fps = _free(fi->fps);
1470 pi = teFreeIterator(pi);
1476 /* ===============================================
1477 * If unfiltered problems exist, free memory and return.
1479 if ((ts->transFlags & RPMTRANS_FLAG_BUILD_PROBS)
1480 || (ts->probs->numProblems &&
1481 (okProbs != NULL || rpmProblemSetTrim(ts->probs, okProbs)))
1484 if (psm->ts != NULL)
1485 psm->ts = rpmtsUnlink(psm->ts, "tsRun (problems)");
1486 return ts->orderCount;
1489 /* ===============================================
1490 * Save removed files before erasing.
1492 if (ts->transFlags & (RPMTRANS_FLAG_DIRSTASH | RPMTRANS_FLAG_REPACKAGE)) {
1493 pi = teInitIterator(ts);
1494 while ((p = teNextIterator(pi)) != NULL) {
1496 switch (teGetType(p)) {
1498 /*@switchbreak@*/ break;
1500 if (!(ts->transFlags & RPMTRANS_FLAG_REPACKAGE))
1501 /*@switchbreak@*/ break;
1503 psm->fi = rpmfiLink(fi, "tsRepackage");
1504 xx = psmStage(psm, PSM_PKGSAVE);
1505 (void) rpmfiUnlink(fi, "tsRepackage");
1508 /*@switchbreak@*/ break;
1511 pi = teFreeIterator(pi);
1514 /* ===============================================
1515 * Install and remove packages.
1517 lastKey = (alKey)-2; /* erased packages have -1 */
1518 pi = teInitIterator(ts);
1519 /*@-branchstate@*/ /* FIX: fi reload needs work */
1520 while ((p = teNextIterator(pi)) != NULL) {
1526 if ((fi = teiGetFi(pi)) == NULL)
1527 continue; /* XXX can't happen */
1530 psm->fi = rpmfiLink(fi, "tsInstall");
1531 switch (teGetType(p)) {
1534 pkgKey = teGetAddedKey(p);
1536 rpmMessage(RPMMESS_DEBUG, "========== +++ %s\n", teGetNEVR(p));
1538 /*@-type@*/ /* FIX: transactionElement not opaque */
1540 /*@-noeffectuncon@*/ /* FIX: notify annotations */
1541 p->fd = ts->notify(fi->h, RPMCALLBACK_INST_OPEN_FILE, 0, 0,
1542 teGetKey(p), ts->notifyData);
1543 /*@=noeffectuncon@*/
1544 if (teGetFd(p) != NULL) {
1547 rpmrc = rpmReadPackageFile(ts, teGetFd(p),
1548 "rpmRunTransactions", &h);
1550 if (!(rpmrc == RPMRC_OK || rpmrc == RPMRC_BADSIZE)) {
1551 /*@-noeffectuncon@*/ /* FIX: notify annotations */
1552 p->fd = ts->notify(fi->h, RPMCALLBACK_INST_CLOSE_FILE,
1554 teGetKey(p), ts->notifyData);
1555 /*@=noeffectuncon@*/
1559 if (teGetFd(p) != NULL) gotfd = 1;
1564 if (teGetFd(p) != NULL) {
1566 char * fstates = fi->fstates;
1567 fileAction * actions = fi->actions;
1571 (void) fiFree(fi, 0);
1573 fi->magic = TFIMAGIC;
1576 (void) fiNew(ts, fi, h, RPMTAG_BASENAMES, 1);
1577 fi->fstates = _free(fi->fstates);
1578 fi->fstates = fstates;
1579 fi->actions = _free(fi->actions);
1580 fi->actions = actions;
1584 if (teGetMultiLib(p))
1585 ts->transFlags |= RPMTRANS_FLAG_MULTILIB;
1587 if (psmStage(psm, PSM_PKGINSTALL)) {
1591 fi->h = headerFree(fi->h, "TR_ADDED fi->h free");
1597 h = headerFree(h, "TR_ADDED h free");
1600 /*@-noeffectuncon @*/ /* FIX: check rc */
1601 (void) ts->notify(fi->h, RPMCALLBACK_INST_CLOSE_FILE, 0, 0,
1602 teGetKey(p), ts->notifyData);
1603 /*@=noeffectuncon @*/
1608 (void) fiFree(fi, 0);
1609 /*@switchbreak@*/ break;
1611 rpmMessage(RPMMESS_DEBUG, "========== --- %s\n", teGetNEVR(p));
1612 /* If install failed, then we shouldn't erase. */
1613 if (teGetDependsOnKey(p) != lastKey) {
1614 if (psmStage(psm, PSM_PKGERASE))
1617 (void) fiFree(fi, 0);
1618 /*@switchbreak@*/ break;
1620 xx = rpmdbSync(ts->rpmdb);
1621 (void) rpmfiUnlink(psm->fi, "tsInstall");
1626 pi = teFreeIterator(pi);
1628 psm->ts = rpmtsUnlink(psm->ts, "tsRun");
1630 /*@-nullstate@*/ /* FIX: ts->flList may be NULL */