Make remote.c ptid constants "const"
[external/binutils.git] / gdb / ChangeLog
1 2019-03-12  Tom Tromey  <tromey@adacore.com>
2
3         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4         const.  Add initializers.
5         (_initialize_remote): Don't initialize ptid globals.
6
7 2019-03-12  Pedro Alves  <palves@redhat.com>
8
9         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10
11 2019-03-12  Pedro Alves  <palves@redhat.com>
12
13         * cp-name-parser.y (main): Remove unused 'len' variable.
14
15 2019-03-12  Tom Tromey  <tromey@adacore.com>
16
17         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
18         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
19
20 2019-03-12  Tom Tromey  <tromey@adacore.com>
21
22         * linux-nat.c (iterate_over_lwps): Update.
23         (stop_callback): Remove parameter.
24         (stop_wait_callback, detach_callback, resume_set_callback)
25         (select_singlestep_lwp_callback, set_ignore_sigint)
26         (status_callback, resumed_callback, resume_clear_callback)
27         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
28         data parameter.
29         (linux_nat_target::detach, linux_nat_target::resume)
30         (linux_stop_and_wait_all_lwps, select_event_lwp)
31         (linux_nat_filter_event, linux_nat_wait_1)
32         (linux_nat_target::kill, linux_nat_target::stop)
33         (linux_nat_target::stop): Update.
34         (linux_nat_resume_callback): Change type.
35         (resume_stopped_resumed_lwps, count_events_callback)
36         (select_event_lwp_callback): Likewise.
37         (linux_stop_lwp, linux_nat_stop_lwp): Update.
38         * arm-linux-nat.c (struct update_registers_data): Remove.
39         (update_registers_callback): Change type.
40         (arm_linux_insert_hw_breakpoint1): Update.
41         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
42         parameter.
43         (x86_linux_dr_set_addr): Update.
44         (x86_linux_dr_set_control): Update.
45         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
46         (iterate_over_lwps): Use gdb::function_view.
47         * nat/aarch64-linux-hw-point.c (struct
48         aarch64_dr_update_callback_param): Remove.
49         (debug_reg_change_callback): Change type.
50         (aarch64_notify_debug_reg_change): Update.
51         * s390-linux-nat.c (s390_refresh_per_info): Update.
52
53 2019-03-11  Tom Tromey  <tromey@adacore.com>
54
55         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
56         redundant assignment to "this_cu".
57
58 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
59
60         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
61
62 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
63
64         * gdbtypes.c (rank_one_type_parm_set): New function extracted
65         from...
66         (rank_one_type): ... this.
67
68 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
69
70         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
71         from...
72         (rank_one_type): ... this.
73
74 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
75
76         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
77         from...
78         (rank_one_type): ... this.
79
80 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
81
82         * gdbtypes.c (rank_one_type_parm_float): New function extracted
83         from...
84         (rank_one_type): ... this.
85
86 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
87
88         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
89         from...
90         (rank_one_type): ... this.
91
92 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
93
94         * gdbtypes.c (rank_one_type_parm_range): New function extracted
95         from...
96         (rank_one_type): ... this.
97
98 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
99
100         * gdbtypes.c (rank_one_type_parm_char): New function extracted
101         from...
102         (rank_one_type): ... this.
103
104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
105
106         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
107         from...
108         (rank_one_type): ... this.
109
110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
111
112         * gdbtypes.c (rank_one_type_parm_int): New function extracted
113         from...
114         (rank_one_type): ... this.
115
116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
117
118         * gdbtypes.c (rank_one_type_parm_func): New function extracted
119         from...
120         (rank_one_type): ... this.
121
122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
123
124         * gdbtypes.c (rank_one_type_parm_array): New function extracted
125         from...
126         (rank_one_type): ... this.
127
128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
129
130         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
131         from...
132         (rank_one_type): ... this.
133
134 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
135
136         * inferior.c (initialize_inferiors): Ensure 'help set/show print
137         inferior-events' shows the example events.
138
139 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
140
141         Support styling on native MS-Windows console
142
143         PR/24315
144         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
145         on MS-Windows if $TERM is not defined.
146
147         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
148
149         * posix-hdep.c (gdb_console_fputs):
150         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
151         functions.
152         * ui-file.h (gdb_console_fputs): Add prototype.
153
154         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
155         back to fputs only if the former returns zero.
156
157 2019-03-07  Tom Tromey  <tom@tromey.com>
158
159         * symmisc.c (print_symbol_bcache_statistics): Update.
160         (print_objfile_statistics): Update.
161         * symfile.c (allocate_symtab): Update.
162         * stabsread.c: Don't include bcache.h.
163         * psymtab.h (struct psymbol_bcache): Don't declare.
164         (class psymtab_storage) <psymbol_cache>: Now a bcache.
165         (psymbol_bcache_init, psymbol_bcache_free)
166         (psymbol_bcache_get_bcache): Don't declare.
167         * psymtab.c (struct psymbol_bcache): Remove.
168         (psymtab_storage::psymtab_storage): Update.
169         (psymtab_storage::~psymtab_storage): Update.
170         (psymbol_bcache_init, psymbol_bcache_free)
171         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
172         (add_psymbol_to_bcache): Update.
173         (allocate_psymtab): Update.
174         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
175         macro_cache>: No longer pointers.
176         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
177         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
178         * macrotab.c (macro_bcache): Update.
179         * macroexp.c: Don't include bcache.h.
180         * gdbtypes.c (check_types_worklist): Update.
181         (types_deeply_equal): Remove TRY/CATCH.  Update.
182         * elfread.c (elf_symtab_read): Update.
183         * dwarf2read.c: Don't include bcache.h.
184         * buildsym.c (buildsym_compunit::get_macro_table): Update.
185         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
186         (print_bcache_statistics, bcache_memory_used): Don't declare.
187         (struct bcache): Move from bcache.c.  Add constructor, destructor,
188         methods.  Rename all data members.
189         * bcache.c (struct bcache): Move to bcache.h.
190         (bcache::expand_hash_table): Rename from expand_hash_table.
191         (bcache): Remove.
192         (bcache::insert): Rename from bcache_full.
193         (bcache::compare): Rename from bcache_compare.
194         (bcache_xmalloc): Remove.
195         (bcache::~bcache): Rename from bcache_xfree.
196         (bcache::print_statistics): Rename from print_bcache_statistics.
197         (bcache::memory_used): Rename from bcache_memory_used.
198
199 2019-03-07  Pedro Alves  <palves@redhat.com>
200
201         * infrun.c (normal_stop): Also check for
202         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
203
204 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
205
206         * f-lang.c (value_from_host_double): Moved to...
207         * value.c (value_from_host_double): ...here.
208         * value.h (value_from_host_double): Declare.
209         * guile/scm-math.c (vlscm_convert_typed_number): Use
210         value_from_host_double.
211         (vlscm_convert_number): Likewise.
212         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
213         * python/py-value.c (convert_value_from_python): Likewise.
214
215 2019-03-06  Tom Tromey  <tom@tromey.com>
216
217         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
218
219 2019-03-06  Tom Tromey  <tom@tromey.com>
220
221         * utils.h (free_current_contents): Don't declare.
222         * utils.c (free_current_contents): Remove.
223
224 2019-03-06  Tom Tromey  <tom@tromey.com>
225
226         * top.c (quit_force): Update.
227         * main.c (captured_command_loop): Update.
228         * common/new-op.c (operator new): Update.
229         * common/common-exceptions.c (struct catcher)
230         <save_cleanup_chain>: Remove member.
231         (exceptions_state_mc_init): Update.
232         (exception_try_scope_entry): Return nullptr.
233         (exception_try_scope_exit, exception_rethrow)
234         (throw_exception_sjlj, throw_exception_cxx): Update.
235         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
236         (all_cleanups, do_cleanups, discard_cleanups)
237         (discard_final_cleanups, save_cleanups, save_final_cleanups)
238         (restore_cleanups, restore_final_cleanups): Don't declare.
239         (do_final_cleanups): Remove parameter.
240         * common/cleanups.c (cleanup_chain, make_cleanup)
241         (make_cleanup_dtor, all_cleanups, do_cleanups)
242         (discard_my_cleanups, discard_cleanups)
243         (discard_final_cleanups, save_my_cleanups, save_cleanups)
244         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
245         (null_cleanup): Remove.
246         (do_final_cleanups): Remove parameter.
247
248 2019-03-06  Tom Tromey  <tom@tromey.com>
249
250         * remote.c (remote_target::remote_parse_stop_reply): Use
251         unique_xmalloc_ptr.
252
253 2019-03-06  Tom Tromey  <tom@tromey.com>
254
255         * stabsread.c (struct stabs_field_info): Rename from field_info.
256         <list, fnlist>: Add initializers.
257         <obstack>: New member.
258         (read_member_functions, read_struct_fields, read_baseclasses):
259         Allocate on obstack.  Don't use cleanups.
260         (read_one_struct_field, read_member_functions, read_struct_fields)
261         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
262         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
263         (read_struct_type): Update.
264
265 2019-03-06  Tom Tromey  <tom@tromey.com>
266
267         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
268         * common/filestuff.h (make_cleanup_close): Don't declare.
269         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
270         Remove.
271
272 2019-03-06  Tom Tromey  <tom@tromey.com>
273
274         * solib-aix.c: Use make_scope_exit.
275
276 2019-03-06  Tom Tromey  <tom@tromey.com>
277
278         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
279         Use make_scope_exit.
280
281 2019-03-06  Tom Tromey  <tom@tromey.com>
282
283         * solib-svr4.c (disable_probes_interface): Remove parameter.
284         (svr4_handle_solib_event): Use make_scope_exit.
285
286 2019-03-06  Tom Tromey  <tom@tromey.com>
287
288         * remote.c (struct stop_reply_deleter): Remove.
289         (stop_reply_up): Update.
290         (struct stop_reply): Derive from notif_event.  Don't typedef.
291         <regcache>: Now a std::vector.
292         (stop_reply_xfree): Remove.
293         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
294         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
295         (remote_target::discard_pending_stop_replies): Use delete.
296         (remote_target::remote_parse_stop_reply): Update.
297         (remote_target::process_stop_reply): Update.
298         * remote-notif.h (struct notif_event): Add virtual destructor.
299         Remove "dtr" member.
300         (struct notif_client) <alloc_event>: Return a unique_ptr.
301         (notif_event_xfree): Don't declare.
302         (notif_event_up): New typedef.
303         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
304         (notif_event_xfree, do_notif_event_xfree): Remove.
305         (remote_notif_state_xfree): Update.
306
307 2019-03-06  Tom Tromey  <tom@tromey.com>
308
309         * infrun.c (displaced_step_clear_cleanup): Now a
310         forward_scope_exit type.
311         (displaced_step_prepare_throw): Update.
312         (displaced_step_fixup): Update.
313
314 2019-03-06  Tom Tromey  <tom@tromey.com>
315
316         * inferior.h (class inferior): Update comment.
317         * gdbthread.h (class thread_info): Update comment.
318
319 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
320             Tom Tromey  <tom@tromey.com>
321
322         * stabsread.h (struct stab_section_list): Remove.
323         (coffstab_build_psymtabs): Update.
324         * dbxread.c (symbuf_sections): Now a std::vector.
325         (sect_idx): New global.
326         (fill_symbuf): Update.
327         (coffstab_build_psymtabs): Change type of stabsects parameter.
328         Update.
329         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
330         std::vector.
331         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
332         (coff_locate_sections): Update.
333         (coff_symfile_read): Remove cleanups.  Update.
334         (init_stringtab): Add storage parameter.
335         (free_stringtab, free_stringtab_cleanup): Remove.
336         (init_lineno): Add storage parameter.
337         (free_linetab, free_linetab_cleanup): Remove.
338
339 2019-03-06  Pedro Alves  <palves@redhat.com>
340
341         * linux-fork.c (fork_info::clobber_regs): Delete.
342         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
343         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
344         comment.  Adjust.
345         (scoped_switch_fork_info::scoped_switch_fork_info)
346         (checkpoint_command, linux_fork_context): Adjust
347         fork_save_infrun_state calls.
348
349 2019-03-06  Pedro Alves  <palves@redhat.com>
350
351         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
352         (inf_has_multiple_threads): Return 'bool' and rewrite using
353         inferior_info::threads().
354
355 2019-03-06  Pedro Alves  <palves@redhat.com>
356
357         * linux-fork.c: Include <list>.
358         (fork_list): Now a std::list instance.
359         (fork_info): Add ctor, dtor, and in-class initialize all fields.
360         (forks_exist_p, find_last_fork): Adjust.
361         (new_fork): Delete.
362         (one_fork_p): New.
363         (add_fork): Adjust.
364         (free_fork): Delete, folded into fork_info::~fork_info().
365         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
366         Adjust.
367         (init_fork_list): Delete.
368         (linux_fork_killall, linux_fork_mourn_inferior)
369         (linux_fork_detach, info_checkpoints_command): Adjust.
370         (_initialize_linux_fork): No longer call init_fork_list.
371
372 2019-03-06  Pedro Alves  <palves@redhat.com>
373
374         * linux-fork.c (new_fork): New, split out of ...
375         (add_fork): ... this.  Return void.  Move "first fork" special
376         case from here, to ...
377         (checkpoint_command): ... here.
378         * linux-linux.h (add_fork): Return void.
379
380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
381
382         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
383
384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
385             Chris January  <chris.january@arm.com>
386             David Lecomber  <david.lecomber@arm.com>
387
388         * f-exp.y: New token, UNOP_INTRINSIC.
389         (exp): New pattern using UNOP_INTRINSIC token.
390         (f77_keywords): Add 'abs' keyword.
391         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
392         (value_from_host_double): New function.
393         (evaluate_subexp_f): Support UNOP_ABS.
394
395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
396
397         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
398         types.
399
400 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
401
402         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
403         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
404         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
405
406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
407
408         * f-exp.y (convert_to_kind_type): Handle more type kinds.
409
410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
411             Chris January  <chris.january@arm.com>
412
413         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
414         * f-exp.y: Define 'KIND' token.
415         (exp): New pattern for KIND expressions.
416         (ptype): Handle types with a kind extension.
417         (direct_abs_decl): Extend to spot kind extensions.
418         (f77_keywords): Add 'kind' to the list.
419         (push_kind_type): New function.
420         (convert_to_kind_type): New function.
421         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
422         * parse.c (operator_length_standard): Likewise.
423         * parser-defs.h (enum type_pieces): Add tp_kind.
424         * std-operator.def: Add UNOP_KIND.
425
426 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
427
428         * f-exp.y (f_parse): Set yydebug.
429
430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
431
432         * f-lang.c (evaluate_subexp_f): New function.
433         (exp_descriptor_f): New global.
434         (f_language_defn): Use exp_descriptor_f instead of
435         exp_descriptor_standard.
436
437 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
438
439         * f-exp.y (struct token): Add comments.
440         (dot_ops): Remove uppercase versions and the end marker.
441         (f77_keywords): Likewise.
442         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
443         entries in the dot_ops array are case insensitive, and use
444         strncasecmp to compare strings.  Also some whitespace cleanup in
445         this area.  Similar for the f77_keywords array, except entries in
446         this list might be case sensitive.
447
448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
449
450         * f-exp.y (struct f77_boolean_val): Add comments.
451         (boolean_values): Remove uppercase versions, and end marker.
452         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
453         and use strncasecmp to achieve case insensitivity.  Additionally,
454         perform whitespace cleanup around this code.
455
456 2019-03-06  Tom Tromey  <tromey@adacore.com>
457
458         * remote-sim.c (gdbsim_target_open): Use result of
459         gdb_argv::release.
460
461 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
462         Dirk Schubert  <dirk.schubert@arm.com>
463         Chris January  <chris.january@arm.com>
464
465         * eval.c (evaluate_subexp_standard): Call Fortran argument
466         wrapping logic.
467         * f-lang.c (struct value): A value which can be passed into a
468         Fortran function call.
469         (fortran_argument_convert): Wrap Fortran arguments in a pointer
470         where appropriate.
471         (struct type): Value ready for a Fortran function call.
472         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
473         is needed.
474         * f-lang.h (fortran_argument_convert): Declaration.
475         (fortran_preserve_arg_pointer): Declaration.
476         * infcall.c (value_arg_coerce): Call Fortran argument logic.
477
478 2019-03-05  Tom Tromey  <tromey@adacore.com>
479
480         * python/py-prettyprint.c (print_string_repr): Remove #if.
481         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
482
483 2019-03-05  Tom Tromey  <tromey@adacore.com>
484
485         * target.c (the_dummy_target): Move later.  Change type to
486         "dummy_target".
487         (initialize_targets): Don't initialize the_dummy_target.
488
489 2019-03-05  Tom Tromey  <tromey@adacore.com>
490
491         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
492         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
493
494 2019-03-05  Tom Tromey  <tromey@adacore.com>
495
496         * windows-nat.c (windows_nat_target::attach)
497         (windows_nat_target::detach): Don't call gdb_flush.
498         * valprint.c (generic_val_print, val_print, val_print_string):
499         Don't call gdb_flush.
500         * utils.c (defaulted_query): Don't call gdb_flush.
501         * typeprint.c (print_type_scalar): Don't call gdb_flush.
502         * target.c (target_announce_detach): Don't call gdb_flush.
503         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
504         * remote.c (extended_remote_target::attach): Don't call
505         gdb_flush.
506         * procfs.c (procfs_target::detach): Don't call gdb_flush.
507         * printcmd.c (do_examine): Don't call gdb_flush.
508         (info_display_command): Don't call gdb_flush.
509         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
510         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
511         * memattr.c (info_mem_command): Don't call gdb_flush.
512         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
513         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
514         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
515         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
516         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
517         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
518         (gnu_nat_target::detach): Don't call gdb_flush.
519         * f-valprint.c (f_val_print): Don't call gdb_flush.
520         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
521         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
522         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
523         gdb_flush.
524         * c-valprint.c (c_val_print): Don't call gdb_flush.
525         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
526
527 2019-03-05  Tom Tromey  <tromey@adacore.com>
528
529         * varobj.c (update_dynamic_varobj_children): Update.
530         (install_default_visualizer): Use reset, not release.
531         * value.c (set_internalvar): Update.
532         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
533         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
534         ATTRIBUTE_UNUSED_RESULT.
535
536 2019-03-05  Tom Tromey  <tromey@adacore.com>
537
538         * remote.c (class scoped_remote_fd) <release>: Add
539         ATTRIBUTE_UNUSED_RESULT.
540
541 2019-03-05  Tom Tromey  <tromey@adacore.com>
542
543         * macroexp.c (struct macro_buffer) <release>: Add
544         ATTRIBUTE_UNUSED_RESULT.
545
546 2019-03-05  Tom Tromey  <tromey@adacore.com>
547
548         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
549         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
550         ATTRIBUTE_UNUSED_RESULT.
551
552 2019-03-05  Tom Tromey  <tromey@adacore.com>
553
554         * common/scoped_fd.h (class scoped_fd) <release>: Add
555         ATTRIBUTE_UNUSED_RESULT.
556
557 2019-03-05  Tom Tromey  <tromey@adacore.com>
558
559         * parser-defs.h (struct parser_state) <release>: Add
560         ATTRIBUTE_UNUSED_RESULT.
561
562 2019-03-05  Tom Tromey  <tromey@adacore.com>
563
564         * utils.h (class gdb_argv) <release>: Add
565         ATTRIBUTE_UNUSED_RESULT.
566         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
567
568 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
569
570         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
571         for-loop range, to avoid compiler warnings.
572
573         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
574         avoid compiler warnings about unused variables.
575
576         * NEWS: Mention end of support for native debugging on MS-Windows
577         before XP.
578
579         PR gdb/24292
580         * common/netstuff.c:
581         * gdbserver/gdbreplay.c
582         * gdbserver/remote-utils.c:
583         * ser-tcp.c:
584         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
585         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
586         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
587         'getaddrinfo' and 'freeaddrinfo' were not available before
588         Windows XP, and mingw.org's MinGW headers by default define
589         _WIN32_WINNT to 0x500.
590
591 2019-03-01  Gary Benson <gbenson@redhat.com>
592
593         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
594
595 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
596             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
597
598         PR gdb/8527
599         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
600         set_sigint_trap, clear_sigint_trap.
601
602 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
603
604         * target.c (target_detach): Clear the regcache and the
605         frame cache.
606
607 2019-02-27  Pedro Alves  <palves@redhat.com>
608
609         * utils.c (set_screen_size): When we cap the height/width sizes,
610         tweak the corresponding command variable to show "unlimited":
611
612 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
613             Pedro Alves  <palves@redhat.com>
614
615         * utils.c (set_screen_size): Reduce "infinite" rows and columns
616         before calling rl_set_screen_size.
617
618 2019-02-27  Tom Tromey  <tromey@adacore.com>
619
620         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
621         define.
622         * python/py-value.c: Remove Python 2.4 workaround.
623         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
624         workaround.
625         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
626         Python 2.4 workaround.
627         * python/python-internal.h: Remove Python 2.4 comment.
628         (Py_ssize_t): Don't define.
629         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
630         (gdb_Py_DECREF): Remove Python 2.4 workaround.
631         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
632         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
633         * python/python.c (do_start_initialization): Remove Python 2.4
634         workaround.
635         * python/py-prettyprint.c (class dummy_python_frame): Remove.
636         (print_children): Remove Python 2.4 workaround.
637         * python/py-inferior.c (buffer_procs): Remove Python 2.4
638         workaround.
639         (CHARBUFFERPROC_NAME): Remove.
640         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
641         Python 2.4 workaround.
642
643 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
644
645         * NEWS: Note minimum Python version.
646
647 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
648
649         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
650         code from these functions.  Remove corresponding ifdefs.  Use
651         Py_buffer_up instead of explicit calls to PyBuffer_Release.
652         Remove gotos and target of gotos.
653         (infpy_search_memory): Likewise.
654
655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
656
657         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
658         (hppa_gdbarch_init): Don't register deleted functions with
659         gdbarch.
660
661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
662
663         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
664         (h8300_unwind_sp): Delete.
665         (h8300_dummy_id): Delete.
666         (h8300_gdbarch_init): Don't register deleted functions with
667         gdbarch.
668
669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
670
671         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
672         (ft32_unwind_pc): Delete.
673         (ft32_unwind_sp): Delete.
674         (ft32_gdbarch_init): Don't register deleted functions with
675         gdbarch.
676
677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
678
679         * gdb/frv-tdep.c (frv_dummy_id): Delete.
680         (frv_unwind_pc): Delete.
681         (frv_unwind_sp): Delete.
682         (frv_gdbarch_init): Don't register deleted functions with
683         gdbarch.
684
685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
686
687         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
688         (riscv_unwind_pc): Delete.
689         (riscv_unwind_sp): Delete.
690         (riscv_gdbarch_init): Don't register deleted functions with
691         gdbarch.
692
693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
694
695         * gdb/csky-tdep.c (csky_dummy_id): Delete.
696         (csky_unwind_pc): Delete.
697         (csky_unwind_sp): Delete.
698         (csky_gdbarch_init): Don't register deleted functions with
699         gdbarch.
700
701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
702
703         * gdb/cris-tdep.c (cris_dummy_id): Delete.
704         (cris_unwind_pc): Delete.
705         (cris_unwind_sp): Delete.
706         (cris_gdbarch_init): Don't register deleted functions with
707         gdbarch.
708
709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
710
711         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
712         (bfin_unwind_pc): Delete.
713         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
714
715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
716
717         * gdb/arm-tdep.c (arm_dummy_id): Delete.
718         (arm_unwind_pc): Delete.
719         (arm_unwind_sp): Delete.
720         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
721
722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
723
724         * gdb/arc-tdep.c (arc_dummy_id): Delete.
725         (arc_unwind_pc): Delete.
726         (arc_unwind_sp): Delete.
727         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
728
729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
730
731         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
732         (alpha_unwind_pc): Delete.
733         (alpha_gdbarch_init): Don't register deleted functions with
734         gdbarch.
735
736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
737
738         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
739         (aarch64_unwind_pc): Delete.
740         (aarch64_unwind_sp): Delete.
741         (aarch64_gdbarch_init): Don't register deleted functions with
742         gdbarch.
743
744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
745
746         * gdbtypes.c (type_align): Don't consider static members when
747         computing structure alignment.
748
749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
750
751         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
752         return 0 for other types.
753         * arch-utils.c (default_type_align): Always return 0.
754         * gdbarch.h: Regenerate.
755         * gdbarch.sh (type_align): Extend comment.
756         * gdbtypes.c (type_align): Add additional comments, always call
757         gdbarch_type_align before applying the default rules.
758         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
759         generic code will then apply a suitable default.
760         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
761         types, return 0 for other types.
762
763 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
764
765         * NEWS: Create a new section for the next release branch.
766         Rename the section of the current branch, now that it has
767         been cut.
768
769 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
770
771         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
772         * version.in: Bump version to 8.3.50.DATE-git.
773
774 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
775
776         * aix-thread.c (ptid_cmp): Remove unused variable.
777         (get_signaled_thread): Likewise.
778         (store_regs_user_thread): Likewise.
779         (store_regs_kernel_thread): Likewise.
780         (fetch_regs_kernel_thread): Remove shadowed variable.
781
782 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
783
784         * features/riscv/32bit-cpu.xml: Add register numbers.
785         * features/riscv/32bit-fpu.c: Regenerate.
786         * features/riscv/32bit-fpu.xml: Add register numbers.
787         * features/riscv/64bit-cpu.xml: Add register numbers.
788         * features/riscv/64bit-fpu.c: Regenerate.
789         * features/riscv/64bit-fpu.xml: Add register numbers.
790
791 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
792
793         * NEWS: Mention two argument form of gdb.Value constructor.
794         * python/py-value.c (convert_buffer_and_type_to_value): New
795         function.
796         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
797         Add support for handling an optional second argument.  Call
798         convert_buffer_and_type_to_value as appropriate.
799         * python/python-internal.h (Py_buffer_deleter): New struct.
800         (Py_buffer_up): New typedef.
801
802 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
803
804         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
805         instead of releasing ownership.
806
807 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
808
809         * dwarf2read.c (open_and_init_dwp_file): Call
810         elf_numsections instead of bfd_count_sections to initialize
811         dwp_file->num_sections.
812
813 2019-02-25  Tom Tromey  <tromey@adacore.com>
814
815         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
816
817 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
818
819         * gcore.in: Add '--readnever' option when invoking GDB.
820
821 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
822
823         * MAINTAINERS: Update my email address.
824
825 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
826
827         * build-id.c (build_id_to_debug_bfd_1): New function.
828         (build_id_to_debug_bfd): Look for separate debug file in
829         sysroot.
830
831 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
832
833         * gdbarch.sh: Update the copyright year range that is placed into
834         generated files.
835
836 2019-02-22  Keith Seitz  <keiths@redhat.com>
837
838         PR symtab/23853
839         * linespec.c (create_sals_line_offset): Search for the default
840         symtab's filename instead of its fullname.
841
842 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
843
844         * NEWS: Update style defaults.
845
846 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
847
848         * main.c (captured_main_1): Disable styling in batch mode.
849
850 2019-02-20  Tom Tromey  <tom@tromey.com>
851
852         * symtab.c (symtab_symbol_info): Fix typos.
853
854 2019-02-20  Tom Tromey  <tromey@adacore.com>
855
856         * findcmd.c (_initialize_mem_search): Use upper case for
857         metasyntactic variables.
858
859 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
860
861         * aarch64-tdep.c (aarch64_add_reggroups): New function.
862         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
863
864 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
865
866         * top.h (source_file_name): Change to std::string.
867         * top.c (source_file_name): Likewise.
868         (command_line_input): Adjust.
869         * cli/cli-script.c (script_from_file): Adjust.
870
871 2019-02-19  Tom Tromey  <tromey@adacore.com>
872
873         * ravenscar-thread.c
874         (ravenscar_thread_target::update_thread_list): Don't call
875         ada_build_task_list.
876         * ada-lang.h (ada_build_task_list): Don't declare.
877         * ada-tasks.c (struct ada_tasks_inferior_data)
878         <task_list_valid_p>: Now bool.
879         (read_known_tasks, ada_task_list_changed)
880         (ada_tasks_invalidate_inferior_data): Update.
881         (read_known_tasks_array): Return bool.
882         (read_known_tasks_list): Likewise.
883         (read_known_tasks): Return void.
884         (ada_build_task_list): Now static.
885
886 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
887
888         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
889         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
890
891 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
892
893         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
894         variant for ada_tasks_pspace_data_handle and
895         ada_tasks_inferior_data_handle.
896         (ada_tasks_pspace_data_cleanup): New function.
897         (ada_tasks_inferior_data_cleanup): New function.
898
899 2019-02-17  Tom Tromey  <tom@tromey.com>
900
901         * macrotab.h (macro_source_fullname): Return a std::string.
902         * macrotab.c (macro_include, check_for_redefinition)
903         (macro_undef, macro_lookup_definition, foreach_macro)
904         (foreach_macro_in_scope): Update.
905         (macro_source_fullname): Return a std::string.
906         * macrocmd.c (show_pp_source_pos): Update.
907
908 2019-02-17  Tom Tromey  <tom@tromey.com>
909
910         * macrocmd.c (show_pp_source_pos): Style the file names.
911
912 2019-02-17  Tom Tromey  <tom@tromey.com>
913
914         PR tui/24197:
915         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
916
917 2019-02-17  Tom Tromey  <tom@tromey.com>
918
919         * ada-lang.c (user_select_syms): Use filtered printing.
920         * utils.c (wrap_style): New global.
921         (desired_style): Remove.
922         (emit_style_escape): Add stream parameter.
923         (set_output_style, reset_terminal_style, prompt_for_continue):
924         Update.
925         (flush_wrap_buffer): Only flush gdb_stdout.
926         (wrap_here): Set wrap_style.
927         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
928         treat escape sequences as a character.  Change when wrap buffer is
929         flushed.
930         (fputs_styled): Do not set the output style when the default is
931         requested.
932         * ui-style.h (struct ui_file_style) <is_default>: New method.
933         * source.c (print_source_lines_base): Emit escape sequences in one
934         piece.
935
936 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
937
938         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
939         integers and enumeration types.
940
941 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
942
943         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
944         instead of lookup_symbol_in_language
945         (do_exact_match): New function.
946         (ada_get_symbol_name_matcher): Return do_exact_match when
947         doing a verbatim match.
948
949 2019-02-15  Tom Tromey  <tromey@adacore.com>
950
951         * ravenscar-thread.c (ravenscar_thread_target::resume)
952         (ravenscar_thread_target::wait): Special case wildcard requests.
953
954 2019-02-15  Tom Tromey  <tromey@adacore.com>
955
956         * ravenscar-thread.c (base_ptid): Remove.
957         (struct ravenscar_thread_target) <close>: New method.
958         <m_base_ptid>: New member.
959         <update_inferior_ptid, active_task, task_is_currently_active,
960         runtime_initialized>: Declare methods.
961         <ravenscar_thread_target>: Add constructor.
962         (ravenscar_thread_target::task_is_currently_active)
963         (ravenscar_thread_target::update_inferior_ptid)
964         (ravenscar_runtime_initialized): Rename.  Now methods.
965         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
966         (ravenscar_thread_target::update_thread_list): Update.
967         (ravenscar_thread_target::active_task): Now method.
968         (ravenscar_thread_target::store_registers)
969         (ravenscar_thread_target::prepare_to_store)
970         (ravenscar_thread_target::prepare_to_store)
971         (ravenscar_thread_target::mourn_inferior): Update.
972         (ravenscar_inferior_created): Use "new" to create target.
973         (ravenscar_thread_target::get_ada_task_ptid): Update.
974         (_initialize_ravenscar): Don't initialize base_ptid.
975         (ravenscar_ops): Remove global.
976
977 2019-02-15  Tom Tromey  <tromey@adacore.com>
978
979         * target.h (push_target): Declare new overload.
980         * target.c (push_target): New overload, taking an rvalue reference.
981         * remote.c (remote_target::open_1): Use push_target overload.
982         * corelow.c (core_target_open): Use push_target overload.
983
984 2019-02-15  Tom Tromey  <tromey@adacore.com>
985
986         * ravenscar-thread.c (is_ravenscar_task)
987         (ravenscar_task_is_currently_active): Return bool.
988         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
989         (_initialize_ravenscar): Remove "(void)".
990         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
991         Return bool.
992
993 2019-02-15  Tom Tromey  <tromey@adacore.com>
994
995         * ravenscar-thread.c (ravenscar_runtime_initializer)
996         (has_ravenscar_runtime, get_running_thread_id)
997         (ravenscar_thread_target::resume): Fix indentation.
998
999 2019-02-15  Tom Tromey  <tromey@adacore.com>
1000
1001         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1002         from ravenscar_arch_ops.
1003         (sparc_ravenscar_ops::fetch_registers)
1004         (sparc_ravenscar_ops::store_registers): Now methods.
1005         (sparc_ravenscar_prepare_to_store): Remove.
1006         (sparc_ravenscar_ops): Redefine.
1007         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1008         methods and destructor.  Remove members.
1009         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1010         (ravenscar_thread_target::store_registers)
1011         (ravenscar_thread_target::prepare_to_store): Update.
1012         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1013         Remove.
1014         (struct ppc_ravenscar_powerpc_ops): Derive from
1015         ravenscar_arch_ops.
1016         (ppc_ravenscar_powerpc_ops::fetch_registers)
1017         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1018         (ppc_ravenscar_powerpc_ops): Redefine.
1019         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1020         (ppc_ravenscar_e500_ops::fetch_registers)
1021         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1022         (ppc_ravenscar_e500_ops): Redefine.
1023         * aarch64-ravenscar-thread.c
1024         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1025         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1026         (aarch64_ravenscar_fetch_registers)
1027         (aarch64_ravenscar_store_registers): Now methods.
1028         (aarch64_ravenscar_ops): Redefine.
1029
1030 2019-02-15  Tom Tromey  <tromey@adacore.com>
1031
1032         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1033         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1034         (ravenscar_thread_target::stopped_by_watchpoint)
1035         (ravenscar_thread_target::stopped_data_address)
1036         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1037
1038 2019-02-15  Tom Tromey  <tromey@adacore.com>
1039
1040         * ravenscar-thread.c: Fix some typos.
1041
1042 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1043             Tom Tromey  <tromey@adacore.com>
1044
1045         * ada-lang.c (ada_exception_sal): Change addr_string to a
1046         std::string.
1047         (create_ada_exception_catchpoint): Update.
1048
1049 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1050             Tom Tromey  <tromey@adacore.com>
1051
1052         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1053         (bp_location_ops): Remove.
1054         (base_breakpoint_allocate_location): Update.
1055         (free_bp_location): Update.
1056         * ada-lang.c (class ada_catchpoint_location)
1057         <ada_catchpoint_location>: Remove ops parameter.
1058         (ada_catchpoint_location_dtor): Remove.
1059         (ada_catchpoint_location_ops): Remove.
1060         (allocate_location_exception): Update.
1061         * breakpoint.h (struct bp_location_ops): Remove.
1062         (class bp_location) <bp_location>: Remove bp_location_ops
1063         parameter.
1064         <~bp_location>: Add destructor.
1065         <ops>: Remove.
1066
1067 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1068             Pedro Alves  <palves@redhat.com>
1069
1070         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1071         'PATH_MAX'.
1072
1073 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1074             Samuel Thibault  <samuel.thibault@gnu.org>
1075             Thomas Schwinge  <thomas@codesourcery.com>
1076
1077         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1078         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1079
1080 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1081
1082         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1083         (check_empty): Use "const char *".
1084
1085         * gnu-nat.c (gnu_nat_target::detach): Instead of
1086         'detach_inferior (pid)' call
1087         'detach_inferior (find_inferior_pid (pid))'.
1088
1089         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1090         'nat/fork-inferior.o'.
1091         * gnu-nat.c: #include "nat/fork-inferior.h".
1092
1093         * gnu-nat.c (gnu_nat_target::detach): Instead of
1094         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1095         * gnu-nat.h: #include "inf-child.h".
1096         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1097         'i386_gnu_nat_target::fetch_registers'.
1098         (gnu_store_registers): Rename/move to
1099         'i386_gnu_nat_target::store_registers'.
1100
1101         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1102         * gnu-nat.h (mach_thread_info): New function.
1103         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1104
1105         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1106
1107 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1108
1109         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1110
1111 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1112
1113         * windows-nat.c (windows_add_thread): Add new parameter
1114         "main_thread_p" with default value set to false.  Update
1115         function documentation as well as all callers.
1116         (windows_delete_thread): Likewise.
1117         (fake_create_process): Update call to windows_add_thread.
1118         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1119         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1120         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1121         call to windows_delete_thread.
1122
1123 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1124
1125         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1126
1127 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1128
1129         * symfile.c (find_separate_debug_file): Use canonical path of
1130         sysroot with child_path instead of gdb_sysroot if it is valid.
1131
1132 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1133
1134         * symfile.c (find_separate_debug_file): Use child_path to
1135         determine if an object file is under a sysroot.
1136
1137 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1138
1139         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1140         unittests/child-path-selftests.c.
1141         * common/pathstuff.c (child_path): New function.
1142         * common/pathstuff.h (child_path): New prototype.
1143         * unittests/child-path-selftests.c: New file.
1144
1145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1146
1147         * symfile.c (find_separate_debug_file): Look for separate debug
1148         files in debug directories under the sysroot.
1149
1150 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1151
1152         * symtab.h (struct minimal_symbol data_p): New const method.
1153         (struct minimal_symbol text_p): Likewise.
1154         * symtab.c (output_source_filename): Use file name style
1155         to print file name.
1156         (print_symbol_info): Likewise.
1157         (print_msymbol_info): Use address style to print addresses.
1158         Use function name style to print executable text symbols.
1159         (expand_symtab_containing_pc): Use data_p.
1160         (find_pc_sect_compunit_symtab): Likewise.
1161
1162 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1163
1164         * breakpoint.c (describe_other_breakpoints): Use address style
1165         to print addresses.
1166         (say_where): Likewise.
1167
1168 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1169
1170         * ada-typeprint.c (print_func_type): Print function name
1171         style to print function name.
1172         * c-typeprint.c (c_print_type_1): Likewise.
1173
1174 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1175
1176         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1177         for execve.
1178
1179 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1180
1181         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1182         type_stack.
1183
1184 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1185
1186         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1187         TYPE_CODE_REF types.
1188
1189 2019-02-08  Jim Wilson  <jimw@sifive.com>
1190
1191         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1192         (riscv_linux_fregset): New.
1193         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1194
1195 2019-02-07  Tom Tromey  <tom@tromey.com>
1196
1197         * thread.c (thread_cancel_execution_command): Update.
1198         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1199         methods.
1200         (struct thread_fsm_ops): Remove.
1201         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1202         (thread_fsm_should_stop, thread_fsm_return_value)
1203         (thread_fsm_set_finished, thread_fsm_finished_p)
1204         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1205         Don't declare.
1206         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1207         * infrun.c (clear_proceed_status_thread)
1208         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1209         (print_stop_event): Update.
1210         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1211         Add constructor.
1212         (step_command_fsm_ops): Remove.
1213         (new_step_command_fsm): Remove.
1214         (step_1): Update.
1215         (step_command_fsm::should_stop): Rename from
1216         step_command_fsm_should_stop.
1217         (step_command_fsm::clean_up): Rename from
1218         step_command_fsm_clean_up.
1219         (step_command_fsm::do_async_reply_reason): Rename from
1220         step_command_fsm_async_reply_reason.
1221         (struct until_next_fsm): Inherit from thread_fsm.  Add
1222         constructor.
1223         (until_next_fsm_ops): Remove.
1224         (new_until_next_fsm): Remove.
1225         (until_next_fsm::should_stop): Rename from
1226         until_next_fsm_should_stop.
1227         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1228         (until_next_fsm::do_async_reply_reason): Rename from
1229         until_next_fsm_async_reply_reason.
1230         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1231         constructor.  Change type of breakpoint.
1232         (finish_command_fsm_ops): Remove.
1233         (new_finish_command_fsm): Remove.
1234         (finish_command_fsm::should_stop): Rename from
1235         finish_command_fsm_should_stop.
1236         (finish_command_fsm::clean_up): Rename from
1237         finish_command_fsm_clean_up.
1238         (finish_command_fsm::return_value): Rename from
1239         finish_command_fsm_return_value.
1240         (finish_command_fsm::do_async_reply_reason): Rename from
1241         finish_command_fsm_async_reply_reason.
1242         (finish_command): Update.
1243         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1244         Add constructor.
1245         (call_thread_fsm_ops): Remove.
1246         (call_thread_fsm::call_thread_fsm): Rename from
1247         new_call_thread_fsm.
1248         (call_thread_fsm::should_stop): Rename from
1249         call_thread_fsm_should_stop.
1250         (call_thread_fsm::should_notify_stop): Rename from
1251         call_thread_fsm_should_notify_stop.
1252         (run_inferior_call, call_function_by_hand_dummy): Update.
1253         * cli/cli-interp.c (should_print_stop_to_console): Update.
1254         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1255         Add constructor.  Change type of location_breakpoint,
1256         caller_breakpoint.
1257         (until_break_fsm_ops): Remove.
1258         (new_until_break_fsm): Remove.
1259         (until_break_fsm::should_stop): Rename from
1260         until_break_fsm_should_stop.
1261         (until_break_fsm::clean_up): Rename from
1262         until_break_fsm_clean_up.
1263         (until_break_fsm::do_async_reply_reason): Rename from
1264         until_break_fsm_async_reply_reason.
1265         (until_break_command): Update.
1266         * thread-fsm.c: Remove.
1267         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1268
1269 2019-02-07  Tom Tromey  <tom@tromey.com>
1270
1271         * yy-remap.h: Add include guard.
1272         * xtensa-tdep.h: Add include guard.
1273         * xcoffread.h: Rename include guard.
1274         * varobj-iter.h: Add include guard.
1275         * tui/tui.h: Rename include guard.
1276         * tui/tui-winsource.h: Rename include guard.
1277         * tui/tui-wingeneral.h: Rename include guard.
1278         * tui/tui-windata.h: Rename include guard.
1279         * tui/tui-win.h: Rename include guard.
1280         * tui/tui-stack.h: Rename include guard.
1281         * tui/tui-source.h: Rename include guard.
1282         * tui/tui-regs.h: Rename include guard.
1283         * tui/tui-out.h: Rename include guard.
1284         * tui/tui-layout.h: Rename include guard.
1285         * tui/tui-io.h: Rename include guard.
1286         * tui/tui-hooks.h: Rename include guard.
1287         * tui/tui-file.h: Rename include guard.
1288         * tui/tui-disasm.h: Rename include guard.
1289         * tui/tui-data.h: Rename include guard.
1290         * tui/tui-command.h: Rename include guard.
1291         * tic6x-tdep.h: Add include guard.
1292         * target/waitstatus.h: Rename include guard.
1293         * target/wait.h: Rename include guard.
1294         * target/target.h: Rename include guard.
1295         * target/resume.h: Rename include guard.
1296         * target-float.h: Rename include guard.
1297         * stabsread.h: Add include guard.
1298         * rs6000-tdep.h: Add include guard.
1299         * riscv-fbsd-tdep.h: Add include guard.
1300         * regformats/regdef.h: Rename include guard.
1301         * record.h: Rename include guard.
1302         * python/python.h: Rename include guard.
1303         * python/python-internal.h: Rename include guard.
1304         * python/py-stopevent.h: Rename include guard.
1305         * python/py-ref.h: Rename include guard.
1306         * python/py-record.h: Rename include guard.
1307         * python/py-record-full.h: Rename include guard.
1308         * python/py-record-btrace.h: Rename include guard.
1309         * python/py-instruction.h: Rename include guard.
1310         * python/py-events.h: Rename include guard.
1311         * python/py-event.h: Rename include guard.
1312         * procfs.h: Add include guard.
1313         * proc-utils.h: Add include guard.
1314         * p-lang.h: Add include guard.
1315         * or1k-tdep.h: Rename include guard.
1316         * observable.h: Rename include guard.
1317         * nto-tdep.h: Rename include guard.
1318         * nat/x86-linux.h: Rename include guard.
1319         * nat/x86-linux-dregs.h: Rename include guard.
1320         * nat/x86-gcc-cpuid.h: Add include guard.
1321         * nat/x86-dregs.h: Rename include guard.
1322         * nat/x86-cpuid.h: Rename include guard.
1323         * nat/ppc-linux.h: Rename include guard.
1324         * nat/mips-linux-watch.h: Rename include guard.
1325         * nat/linux-waitpid.h: Rename include guard.
1326         * nat/linux-ptrace.h: Rename include guard.
1327         * nat/linux-procfs.h: Rename include guard.
1328         * nat/linux-osdata.h: Rename include guard.
1329         * nat/linux-nat.h: Rename include guard.
1330         * nat/linux-namespaces.h: Rename include guard.
1331         * nat/linux-btrace.h: Rename include guard.
1332         * nat/glibc_thread_db.h: Rename include guard.
1333         * nat/gdb_thread_db.h: Rename include guard.
1334         * nat/gdb_ptrace.h: Rename include guard.
1335         * nat/fork-inferior.h: Rename include guard.
1336         * nat/amd64-linux-siginfo.h: Rename include guard.
1337         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1338         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1339         * nat/aarch64-linux.h: Rename include guard.
1340         * nat/aarch64-linux-hw-point.h: Rename include guard.
1341         * mn10300-tdep.h: Add include guard.
1342         * mips-linux-tdep.h: Add include guard.
1343         * mi/mi-parse.h: Rename include guard.
1344         * mi/mi-out.h: Rename include guard.
1345         * mi/mi-main.h: Rename include guard.
1346         * mi/mi-interp.h: Rename include guard.
1347         * mi/mi-getopt.h: Rename include guard.
1348         * mi/mi-console.h: Rename include guard.
1349         * mi/mi-common.h: Rename include guard.
1350         * mi/mi-cmds.h: Rename include guard.
1351         * mi/mi-cmd-break.h: Rename include guard.
1352         * m2-lang.h: Add include guard.
1353         * location.h: Rename include guard.
1354         * linux-record.h: Rename include guard.
1355         * linux-nat.h: Add include guard.
1356         * linux-fork.h: Add include guard.
1357         * i386-darwin-tdep.h: Rename include guard.
1358         * hppa-linux-offsets.h: Add include guard.
1359         * guile/guile.h: Rename include guard.
1360         * guile/guile-internal.h: Rename include guard.
1361         * gnu-nat.h: Rename include guard.
1362         * gdb-stabs.h: Rename include guard.
1363         * frv-tdep.h: Add include guard.
1364         * f-lang.h: Add include guard.
1365         * event-loop.h: Add include guard.
1366         * darwin-nat.h: Rename include guard.
1367         * cp-abi.h: Rename include guard.
1368         * config/sparc/nm-sol2.h: Rename include guard.
1369         * config/nm-nto.h: Rename include guard.
1370         * config/nm-linux.h: Add include guard.
1371         * config/i386/nm-i386gnu.h: Rename include guard.
1372         * config/djgpp/nl_types.h: Rename include guard.
1373         * config/djgpp/langinfo.h: Rename include guard.
1374         * compile/gcc-cp-plugin.h: Add include guard.
1375         * compile/gcc-c-plugin.h: Add include guard.
1376         * compile/compile.h: Rename include guard.
1377         * compile/compile-object-run.h: Rename include guard.
1378         * compile/compile-object-load.h: Rename include guard.
1379         * compile/compile-internal.h: Rename include guard.
1380         * compile/compile-cplus.h: Rename include guard.
1381         * compile/compile-c.h: Rename include guard.
1382         * common/xml-utils.h: Rename include guard.
1383         * common/x86-xstate.h: Rename include guard.
1384         * common/version.h: Rename include guard.
1385         * common/vec.h: Rename include guard.
1386         * common/tdesc.h: Rename include guard.
1387         * common/selftest.h: Rename include guard.
1388         * common/scoped_restore.h: Rename include guard.
1389         * common/scoped_mmap.h: Rename include guard.
1390         * common/scoped_fd.h: Rename include guard.
1391         * common/safe-iterator.h: Rename include guard.
1392         * common/run-time-clock.h: Rename include guard.
1393         * common/refcounted-object.h: Rename include guard.
1394         * common/queue.h: Rename include guard.
1395         * common/ptid.h: Rename include guard.
1396         * common/print-utils.h: Rename include guard.
1397         * common/preprocessor.h: Rename include guard.
1398         * common/pathstuff.h: Rename include guard.
1399         * common/observable.h: Rename include guard.
1400         * common/netstuff.h: Rename include guard.
1401         * common/job-control.h: Rename include guard.
1402         * common/host-defs.h: Rename include guard.
1403         * common/gdb_wait.h: Rename include guard.
1404         * common/gdb_vecs.h: Rename include guard.
1405         * common/gdb_unlinker.h: Rename include guard.
1406         * common/gdb_unique_ptr.h: Rename include guard.
1407         * common/gdb_tilde_expand.h: Rename include guard.
1408         * common/gdb_sys_time.h: Rename include guard.
1409         * common/gdb_string_view.h: Rename include guard.
1410         * common/gdb_splay_tree.h: Rename include guard.
1411         * common/gdb_setjmp.h: Rename include guard.
1412         * common/gdb_ref_ptr.h: Rename include guard.
1413         * common/gdb_optional.h: Rename include guard.
1414         * common/gdb_locale.h: Rename include guard.
1415         * common/gdb_assert.h: Rename include guard.
1416         * common/filtered-iterator.h: Rename include guard.
1417         * common/filestuff.h: Rename include guard.
1418         * common/fileio.h: Rename include guard.
1419         * common/environ.h: Rename include guard.
1420         * common/common-utils.h: Rename include guard.
1421         * common/common-types.h: Rename include guard.
1422         * common/common-regcache.h: Rename include guard.
1423         * common/common-inferior.h: Rename include guard.
1424         * common/common-gdbthread.h: Rename include guard.
1425         * common/common-exceptions.h: Rename include guard.
1426         * common/common-defs.h: Rename include guard.
1427         * common/common-debug.h: Rename include guard.
1428         * common/cleanups.h: Rename include guard.
1429         * common/buffer.h: Rename include guard.
1430         * common/btrace-common.h: Rename include guard.
1431         * common/break-common.h: Rename include guard.
1432         * cli/cli-utils.h: Rename include guard.
1433         * cli/cli-style.h: Rename include guard.
1434         * cli/cli-setshow.h: Rename include guard.
1435         * cli/cli-script.h: Rename include guard.
1436         * cli/cli-interp.h: Rename include guard.
1437         * cli/cli-decode.h: Rename include guard.
1438         * cli/cli-cmds.h: Rename include guard.
1439         * charset-list.h: Add include guard.
1440         * buildsym-legacy.h: Rename include guard.
1441         * bfin-tdep.h: Add include guard.
1442         * ax.h: Rename include guard.
1443         * arm-linux-tdep.h: Add include guard.
1444         * arm-fbsd-tdep.h: Add include guard.
1445         * arch/xtensa.h: Rename include guard.
1446         * arch/tic6x.h: Add include guard.
1447         * arch/i386.h: Add include guard.
1448         * arch/arm.h: Rename include guard.
1449         * arch/arm-linux.h: Rename include guard.
1450         * arch/arm-get-next-pcs.h: Rename include guard.
1451         * arch/amd64.h: Add include guard.
1452         * arch/aarch64-insn.h: Rename include guard.
1453         * arch-utils.h: Rename include guard.
1454         * annotate.h: Add include guard.
1455         * amd64-darwin-tdep.h: Rename include guard.
1456         * aarch64-linux-tdep.h: Add include guard.
1457         * aarch64-fbsd-tdep.h: Add include guard.
1458         * aarch32-linux-nat.h: Add include guard.
1459
1460 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1461
1462         * macrotab.c (macro_define_internal): New function that
1463         factorizes macro_define_object_internal and macro_define_function
1464         code.
1465         (macro_define_object_internal): Use macro_define_internal.
1466         (macro_define_function): Likewise.
1467
1468 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1469
1470         * macrocmd.c (extract_identifier): Return
1471         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1472         callers.
1473
1474 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1475
1476         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1477
1478 2019-02-05  Tom Tromey  <tom@tromey.com>
1479
1480         * target.c (target_stack::unpush): Move assertion earlier.
1481
1482 2019-01-30  Tom Tromey  <tom@tromey.com>
1483
1484         PR python/23615:
1485         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1486         (gdbpy_parse_and_eval): Likewise.
1487         * python/python-internal.h (gdbpy_allow_threads): New class.
1488
1489 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1490
1491         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1492         (aarch64_fbsd_fpregmap): Move earlier.
1493         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1494         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1495         instead of individual calls to trad_frame_set_reg_addr.
1496         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1497         earlier.
1498         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1499         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1500         instead of individual calls to trad_frame_set_reg_addr.
1501
1502 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1503
1504         * CONTRIBUTE: Replace contribution list with wiki link.
1505
1506 2019-01-25  Tom Tromey  <tom@tromey.com>
1507
1508         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1509
1510 2019-01-25  Tom Tromey  <tom@tromey.com>
1511
1512         * xtensa-linux-nat.c: Fix common/ includes.
1513         * xml-support.h: Fix common/ includes.
1514         * xml-support.c: Fix common/ includes.
1515         * x86-linux-nat.c: Fix common/ includes.
1516         * windows-nat.c: Fix common/ includes.
1517         * varobj.h: Fix common/ includes.
1518         * varobj.c: Fix common/ includes.
1519         * value.c: Fix common/ includes.
1520         * valops.c: Fix common/ includes.
1521         * utils.c: Fix common/ includes.
1522         * unittests/xml-utils-selftests.c: Fix common/ includes.
1523         * unittests/utils-selftests.c: Fix common/ includes.
1524         * unittests/unpack-selftests.c: Fix common/ includes.
1525         * unittests/tracepoint-selftests.c: Fix common/ includes.
1526         * unittests/style-selftests.c: Fix common/ includes.
1527         * unittests/string_view-selftests.c: Fix common/ includes.
1528         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1529         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1530         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1531         * unittests/rsp-low-selftests.c: Fix common/ includes.
1532         * unittests/parse-connection-spec-selftests.c: Fix common/
1533         includes.
1534         * unittests/optional-selftests.c: Fix common/ includes.
1535         * unittests/offset-type-selftests.c: Fix common/ includes.
1536         * unittests/observable-selftests.c: Fix common/ includes.
1537         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1538         * unittests/memrange-selftests.c: Fix common/ includes.
1539         * unittests/memory-map-selftests.c: Fix common/ includes.
1540         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1541         * unittests/function-view-selftests.c: Fix common/ includes.
1542         * unittests/environ-selftests.c: Fix common/ includes.
1543         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1544         * unittests/common-utils-selftests.c: Fix common/ includes.
1545         * unittests/cli-utils-selftests.c: Fix common/ includes.
1546         * unittests/array-view-selftests.c: Fix common/ includes.
1547         * ui-file.c: Fix common/ includes.
1548         * tui/tui-io.c: Fix common/ includes.
1549         * tracepoint.h: Fix common/ includes.
1550         * tracepoint.c: Fix common/ includes.
1551         * tracefile-tfile.c: Fix common/ includes.
1552         * top.h: Fix common/ includes.
1553         * top.c: Fix common/ includes.
1554         * thread.c: Fix common/ includes.
1555         * target/waitstatus.h: Fix common/ includes.
1556         * target/waitstatus.c: Fix common/ includes.
1557         * target.h: Fix common/ includes.
1558         * target.c: Fix common/ includes.
1559         * target-memory.c: Fix common/ includes.
1560         * target-descriptions.c: Fix common/ includes.
1561         * symtab.h: Fix common/ includes.
1562         * symfile.c: Fix common/ includes.
1563         * stap-probe.c: Fix common/ includes.
1564         * spu-linux-nat.c: Fix common/ includes.
1565         * sparc-nat.c: Fix common/ includes.
1566         * source.c: Fix common/ includes.
1567         * solib.c: Fix common/ includes.
1568         * solib-target.c: Fix common/ includes.
1569         * ser-unix.c: Fix common/ includes.
1570         * ser-tcp.c: Fix common/ includes.
1571         * ser-pipe.c: Fix common/ includes.
1572         * ser-base.c: Fix common/ includes.
1573         * selftest-arch.c: Fix common/ includes.
1574         * s12z-tdep.c: Fix common/ includes.
1575         * rust-exp.y: Fix common/ includes.
1576         * rs6000-aix-tdep.c: Fix common/ includes.
1577         * riscv-tdep.c: Fix common/ includes.
1578         * remote.c: Fix common/ includes.
1579         * remote-notif.h: Fix common/ includes.
1580         * remote-fileio.h: Fix common/ includes.
1581         * remote-fileio.c: Fix common/ includes.
1582         * regcache.h: Fix common/ includes.
1583         * regcache.c: Fix common/ includes.
1584         * record-btrace.c: Fix common/ includes.
1585         * python/python.c: Fix common/ includes.
1586         * python/py-type.c: Fix common/ includes.
1587         * python/py-inferior.c: Fix common/ includes.
1588         * progspace.h: Fix common/ includes.
1589         * producer.c: Fix common/ includes.
1590         * procfs.c: Fix common/ includes.
1591         * proc-api.c: Fix common/ includes.
1592         * printcmd.c: Fix common/ includes.
1593         * ppc-linux-nat.c: Fix common/ includes.
1594         * parser-defs.h: Fix common/ includes.
1595         * osdata.c: Fix common/ includes.
1596         * obsd-nat.c: Fix common/ includes.
1597         * nat/x86-linux.c: Fix common/ includes.
1598         * nat/x86-linux-dregs.c: Fix common/ includes.
1599         * nat/x86-dregs.h: Fix common/ includes.
1600         * nat/x86-dregs.c: Fix common/ includes.
1601         * nat/ppc-linux.c: Fix common/ includes.
1602         * nat/mips-linux-watch.h: Fix common/ includes.
1603         * nat/mips-linux-watch.c: Fix common/ includes.
1604         * nat/linux-waitpid.c: Fix common/ includes.
1605         * nat/linux-ptrace.h: Fix common/ includes.
1606         * nat/linux-ptrace.c: Fix common/ includes.
1607         * nat/linux-procfs.c: Fix common/ includes.
1608         * nat/linux-personality.c: Fix common/ includes.
1609         * nat/linux-osdata.c: Fix common/ includes.
1610         * nat/linux-namespaces.c: Fix common/ includes.
1611         * nat/linux-btrace.h: Fix common/ includes.
1612         * nat/linux-btrace.c: Fix common/ includes.
1613         * nat/fork-inferior.c: Fix common/ includes.
1614         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1615         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1616         * nat/aarch64-linux.c: Fix common/ includes.
1617         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1618         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1619         * namespace.h: Fix common/ includes.
1620         * mips-linux-tdep.c: Fix common/ includes.
1621         * minsyms.c: Fix common/ includes.
1622         * mi/mi-parse.h: Fix common/ includes.
1623         * mi/mi-main.c: Fix common/ includes.
1624         * mi/mi-cmd-env.c: Fix common/ includes.
1625         * memrange.h: Fix common/ includes.
1626         * memattr.c: Fix common/ includes.
1627         * maint.h: Fix common/ includes.
1628         * maint.c: Fix common/ includes.
1629         * main.c: Fix common/ includes.
1630         * machoread.c: Fix common/ includes.
1631         * location.c: Fix common/ includes.
1632         * linux-thread-db.c: Fix common/ includes.
1633         * linux-nat.c: Fix common/ includes.
1634         * linux-fork.c: Fix common/ includes.
1635         * inline-frame.c: Fix common/ includes.
1636         * infrun.c: Fix common/ includes.
1637         * inflow.c: Fix common/ includes.
1638         * inferior.h: Fix common/ includes.
1639         * inferior.c: Fix common/ includes.
1640         * infcmd.c: Fix common/ includes.
1641         * inf-ptrace.c: Fix common/ includes.
1642         * inf-child.c: Fix common/ includes.
1643         * ia64-linux-nat.c: Fix common/ includes.
1644         * i387-tdep.c: Fix common/ includes.
1645         * i386-tdep.c: Fix common/ includes.
1646         * i386-linux-tdep.c: Fix common/ includes.
1647         * i386-linux-nat.c: Fix common/ includes.
1648         * i386-go32-tdep.c: Fix common/ includes.
1649         * i386-fbsd-tdep.c: Fix common/ includes.
1650         * i386-fbsd-nat.c: Fix common/ includes.
1651         * guile/scm-type.c: Fix common/ includes.
1652         * guile/guile.c: Fix common/ includes.
1653         * go32-nat.c: Fix common/ includes.
1654         * gnu-nat.c: Fix common/ includes.
1655         * gdbthread.h: Fix common/ includes.
1656         * gdbarch-selftests.c: Fix common/ includes.
1657         * gdb_usleep.c: Fix common/ includes.
1658         * gdb_select.h: Fix common/ includes.
1659         * gdb_bfd.c: Fix common/ includes.
1660         * gcore.c: Fix common/ includes.
1661         * fork-child.c: Fix common/ includes.
1662         * findvar.c: Fix common/ includes.
1663         * fbsd-nat.c: Fix common/ includes.
1664         * event-top.c: Fix common/ includes.
1665         * event-loop.c: Fix common/ includes.
1666         * dwarf2read.c: Fix common/ includes.
1667         * dwarf2loc.c: Fix common/ includes.
1668         * dwarf2-frame.c: Fix common/ includes.
1669         * dwarf-index-cache.c: Fix common/ includes.
1670         * dtrace-probe.c: Fix common/ includes.
1671         * disasm-selftests.c: Fix common/ includes.
1672         * defs.h: Fix common/ includes.
1673         * csky-tdep.c: Fix common/ includes.
1674         * cp-valprint.c: Fix common/ includes.
1675         * cp-support.h: Fix common/ includes.
1676         * cp-support.c: Fix common/ includes.
1677         * corelow.c: Fix common/ includes.
1678         * completer.h: Fix common/ includes.
1679         * completer.c: Fix common/ includes.
1680         * compile/compile.c: Fix common/ includes.
1681         * compile/compile-loc2c.c: Fix common/ includes.
1682         * compile/compile-cplus-types.c: Fix common/ includes.
1683         * compile/compile-cplus-symbols.c: Fix common/ includes.
1684         * command.h: Fix common/ includes.
1685         * cli/cli-dump.c: Fix common/ includes.
1686         * cli/cli-cmds.c: Fix common/ includes.
1687         * charset.c: Fix common/ includes.
1688         * build-id.c: Fix common/ includes.
1689         * btrace.h: Fix common/ includes.
1690         * btrace.c: Fix common/ includes.
1691         * breakpoint.h: Fix common/ includes.
1692         * breakpoint.c: Fix common/ includes.
1693         * ax.h: 
1694         (enum agent_op): Fix common/ includes.
1695         * ax-general.c (struct aop_map): Fix common/ includes.
1696         * ax-gdb.c: Fix common/ includes.
1697         * auxv.c: Fix common/ includes.
1698         * auto-load.c: Fix common/ includes.
1699         * arm-tdep.c: Fix common/ includes.
1700         * arch/riscv.c: Fix common/ includes.
1701         * arch/ppc-linux-common.c: Fix common/ includes.
1702         * arch/i386.c: Fix common/ includes.
1703         * arch/arm.c: Fix common/ includes.
1704         * arch/arm-linux.c: Fix common/ includes.
1705         * arch/arm-get-next-pcs.c: Fix common/ includes.
1706         * arch/amd64.c: Fix common/ includes.
1707         * arch/aarch64.c: Fix common/ includes.
1708         * arch/aarch64-insn.c: Fix common/ includes.
1709         * arch-utils.c: Fix common/ includes.
1710         * amd64-windows-tdep.c: Fix common/ includes.
1711         * amd64-tdep.c: Fix common/ includes.
1712         * amd64-sol2-tdep.c: Fix common/ includes.
1713         * amd64-obsd-tdep.c: Fix common/ includes.
1714         * amd64-nbsd-tdep.c: Fix common/ includes.
1715         * amd64-linux-tdep.c: Fix common/ includes.
1716         * amd64-linux-nat.c: Fix common/ includes.
1717         * amd64-fbsd-tdep.c: Fix common/ includes.
1718         * amd64-fbsd-nat.c: Fix common/ includes.
1719         * amd64-dicos-tdep.c: Fix common/ includes.
1720         * amd64-darwin-tdep.c: Fix common/ includes.
1721         * agent.c: Fix common/ includes.
1722         * ada-lang.h: Fix common/ includes.
1723         * ada-lang.c: Fix common/ includes.
1724         * aarch64-tdep.c: Fix common/ includes.
1725
1726 2019-01-25  Tom Tromey  <tom@tromey.com>
1727
1728         * common/create-version.sh: Use common/version.h.
1729
1730 2019-01-24  Pedro Alves  <palves@redhat.com>
1731
1732         * infrun.c (signal_stop, signal_print, signal_program)
1733         (signal_catch, signal_pass): Now arrays instead of pointers.
1734         (update_signals_program_target, do_target_resume)
1735         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1736         * linux-nat.c (linux_nat_target::pass_signals)
1737         (linux_nat_target::create_inferior, linux_nat_target::attach):
1738         Adjust.
1739         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1740         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1741         * procfs.c (procfs_target::pass_signals): Adjust.
1742         * record-full.c (record_full_target::resume): Adjust.
1743         * remote.c (remote_target::pass_signals)
1744         (remote_target::program_signals): Adjust.
1745         * target-debug.h (target_debug_print_signals): Now takes a
1746         gdb::array_view as parameter.  Adjust.
1747         * target.h (target_ops) <pass_signals, program_signals>: Replace
1748         pointer and length parameters with gdb::array_view.
1749         (target_pass_signals, target_program_signals): Likewise.
1750         * target-delegates.c: Regenerate.
1751
1752 2019-01-24  Pedro Alves  <palves@redhat.com>
1753
1754         * common/forward-scope-exit.h
1755         (forward_scope_exit::forward_scope_exit): Pass arguments to
1756         m_bind_function directly, instead of creating a std::bind and
1757         copying that.
1758
1759 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1760
1761         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1762         for static members.
1763         (pass_in_v_vfp_candidate): Likewise.
1764
1765 2019-01-23  Tom Tromey  <tom@tromey.com>
1766             Pedro Alves  <palves@redhat.com>
1767
1768         * regcache.c (class regcache_invalidator): Remove.
1769         (regcache::raw_write): Use make_scope_exit.
1770
1771 2019-01-23  Tom Tromey  <tom@tromey.com>
1772
1773         * ui-out.h (class ui_out_emit_type): Update comment.
1774
1775 2019-01-23  Tom Tromey  <tom@tromey.com>
1776
1777         * infrun.c (fetch_inferior_event): Update comment.
1778
1779 2019-01-23  Tom Tromey  <tom@tromey.com>
1780             Pedro Alves  <palves@redhat.com>
1781
1782         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1783         parameter.
1784         (fetch_inferior_event): Use SCOPE_EXIT.
1785
1786
1787 2019-01-23  Tom Tromey  <tom@tromey.com>
1788             Pedro Alves  <palves@redhat.com>
1789
1790         * infrun.c (disable_thread_events): Delete.
1791         (stop_all_threads): Use SCOPE_EXIT.
1792
1793 2019-01-23  Tom Tromey  <tom@tromey.com>
1794             Pedro Alves  <palves@redhat.com>
1795
1796         * symfile.c: Include forward-scope-exit.h.
1797         (clear_symtab_users_cleanup): Replace forward declaration with
1798         a FORWARD_SCOPE_EXIT.
1799         (syms_from_objfile_1): Use the forward_scope_exit and
1800         gdb::optional instead of cleanup_function.
1801         (reread_symbols): Use the forward_scope_exit instead of
1802         cleanup_function.
1803         (clear_symtab_users_cleanup): Remove function.
1804
1805 2019-01-23  Tom Tromey  <tom@tromey.com>
1806             Pedro Alves  <palves@redhat.com>
1807
1808         * linux-nat.c: Include scope-exit.h.
1809         (cleanup_target_stop): Remove.
1810         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1811         SCOPE_EXIT.
1812
1813 2019-01-23  Tom Tromey  <tom@tromey.com>
1814             Pedro Alves  <palves@redhat.com>
1815
1816         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1817         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1818
1819 2019-01-23  Tom Tromey  <tom@tromey.com>
1820             Andrew Burgess  <andrew.burgess@embecosm.com>
1821             Pedro Alves  <palves@redhat.com>
1822
1823         * infrun.c (fetch_inferior_event): Use scope_exit.
1824         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1825         * top.c (execute_command): Use scope_exit.
1826         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1827         * utils.c (do_bpstat_clear_actions_cleanup)
1828         (make_bpstat_clear_actions_cleanup): Remove.
1829
1830 2019-01-23  Tom Tromey  <tom@tromey.com>
1831             Pedro Alves  <palves@redhat.com>
1832
1833         * infrun.c: Include "common/scope-exit.h"
1834         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1835         (wait_for_inferior): Use SCOPE_EXIT.
1836         (fetch_inferior_event): Use scope_exit.
1837
1838 2019-01-23  Tom Tromey  <tom@tromey.com>
1839             Pedro Alves  <palves@redhat.com>
1840
1841         * breakpoint.c (create_breakpoint): Remove cleanup.
1842
1843 2019-01-23  Tom Tromey  <tom@tromey.com>
1844             Andrew Burgess  <andrew.burgess@embecosm.com>
1845             Pedro Alves  <palves@redhat.com>
1846
1847 2019-01-23  Pedro Alves  <palves@redhat.com>
1848
1849         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1850
1851 2019-01-23  Pedro Alves  <palves@redhat.com>
1852             Andrew Burgess  <andrew.burgess@embecosm.com>
1853
1854         * gdbthread.h: Include "common/forward-scope-exit.h".
1855         (scoped_finish_thread_state): Redefine custom class in terms of
1856         forward_scope_exit.
1857
1858 2019-01-23  Pedro Alves  <palves@redhat.com>
1859             Andrew Burgess  <andrew.burgess@embecosm.com>
1860
1861         * common/forward-scope-exit.h: New file.
1862
1863 2019-01-23  Pedro Alves  <palves@redhat.com>
1864             Andrew Burgess  <andrew.burgess@embecosm.com>
1865             Tom Tromey  <tom@tromey.com>
1866
1867         * common/scope-exit.h: New file.
1868
1869 2019-01-23  Pedro Alves  <palves@redhat.com>
1870
1871         * common/preprocessor.h (ESC): Rename to ...
1872         (ESC_PARENS): ... this.
1873         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1874         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1875
1876 2019-01-23  Tom Tromey  <tom@tromey.com>
1877
1878         * language.h (class scoped_switch_to_sym_language_if_auto):
1879         Initialize m_lang in both cases.
1880
1881 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1882
1883         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1884         with XCNEW.
1885
1886 2019-01-22  Tom Tromey  <tom@tromey.com>
1887
1888         * corelow.c: Do not include sys/file.h.
1889
1890 2019-01-22  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-wingeneral.h: Include gdb_curses.h.
1893
1894 2019-01-22  Tom Tromey  <tom@tromey.com>
1895
1896         * source-cache.h (class source_cache) <get_source_lines,
1897         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1898
1899 2019-01-22  Tom Tromey  <tom@tromey.com>
1900
1901         * remote-fileio.h (struct remote_target): Declare.
1902
1903 2019-01-22  Tom Tromey  <tom@tromey.com>
1904
1905         * python/py-arch.c: Do not include py-ref.h.
1906         * python/py-bpevent.c: Do not include py-ref.h.
1907         * python/py-cmd.c: Do not include py-ref.h.
1908         * python/py-continueevent.c: Do not include py-ref.h.
1909         * python/py-event.h: Do not include py-ref.h.
1910         * python/py-evtregistry.c: Do not include py-ref.h.
1911         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1912         * python/py-frame.c: Do not include py-ref.h.
1913         * python/py-framefilter.c: Do not include py-ref.h.
1914         * python/py-function.c: Do not include py-ref.h.
1915         * python/py-infevents.c: Do not include py-ref.h.
1916         * python/py-linetable.c: Do not include py-ref.h.
1917         * python/py-objfile.c: Do not include py-ref.h.
1918         * python/py-param.c: Do not include py-ref.h.
1919         * python/py-prettyprint.c: Do not include py-ref.h.
1920         * python/py-progspace.c: Do not include py-ref.h.
1921         * python/py-symbol.c: Do not include py-ref.h.
1922         * python/py-symtab.c: Do not include py-ref.h.
1923         * python/py-type.c: Do not include py-ref.h.
1924         * python/py-unwind.c: Do not include py-ref.h.
1925         * python/py-utils.c: Do not include py-ref.h.
1926         * python/py-value.c: Do not include py-ref.h.
1927         * python/py-varobj.c: Do not include py-ref.h.
1928         * python/py-xmethods.c: Do not include py-ref.h.
1929         * python/python.c: Do not include py-ref.h.
1930         * varobj.c: Do not include py-ref.h.
1931
1932 2019-01-22  Tom Tromey  <tom@tromey.com>
1933
1934         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1935         keyword for bcache.
1936
1937 2019-01-22  Tom Tromey  <tom@tromey.com>
1938
1939         * compile/compile-cplus-types.c: Remove a comment by #include.
1940
1941 2019-01-22  Tom Tromey  <tom@tromey.com>
1942
1943         * compile/gcc-c-plugin.h: Include compile-internal.h.
1944
1945 2019-01-22  Tom Tromey  <tom@tromey.com>
1946
1947         * stabsread.c (EXTERN): Do not define.
1948         (symnum, next_symbol_text_func, processing_gcc_compilation)
1949         (within_function, global_sym_chain, global_stabs)
1950         (previous_stab_code, this_object_header_files)
1951         (n_this_object_header_files)
1952         (n_allocated_this_object_header_files): Define.
1953         * stabsread.h (EXTERN): Never define.  Use "extern".
1954
1955 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1956
1957         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1958         history_value.
1959
1960 2019-01-21  Tom Tromey  <tom@tromey.com>
1961
1962         * ui-out.c: Fix includes.
1963         * tui/tui-source.c: Fix includes.
1964         * target.c: Fix includes.
1965         * remote.c: Fix includes.
1966         * regcache.c: Fix includes.
1967         * python/py-block.c: Fix includes.
1968         * printcmd.c: Fix includes.
1969         * or1k-tdep.c: Fix includes.
1970         * mi/mi-main.c: Fix includes.
1971         * m32r-tdep.c: Fix includes.
1972         * csky-tdep.c: Fix includes.
1973         * compile/compile-cplus-types.c: Fix includes.
1974         * cli/cli-interp.c: Fix includes.
1975
1976 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1977
1978         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1979         for padding.
1980
1981 2019-01-16  Tom Tromey  <tom@tromey.com>
1982
1983         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1984         earlier.
1985         (struct objfile) <msymbols_range>: Move from top level.
1986         <msymbols>: New method.
1987         (class objfile_msymbols): Remove.
1988         * symtab.c (default_collect_symbol_completion_matches_break_on):
1989         Update.
1990         * symmisc.c (dump_msymbols): Update.
1991         * stabsread.c (scan_file_globals): Update.
1992         * objc-lang.c (info_selectors_command, info_classes_command)
1993         (find_methods): Update.
1994         * minsyms.c (find_solib_trampoline_target): Update.
1995         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1996         * coffread.c (coff_symfile_read): Update.
1997         * ada-lang.c (ada_lookup_simple_minsym)
1998         (ada_collect_symbol_completion_matches): Update.
1999
2000 2019-01-16  Tom Tromey  <tom@tromey.com>
2001
2002         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2003         type.  Remove no-argument constructor.
2004         <iterator::operator++>: Simplify.
2005         <begin>: Update.
2006         <end>: Use minimal_symbol_count.
2007
2008 2019-01-16  Tom Tromey  <tom@tromey.com>
2009
2010         * objfiles.h (struct objfile) <psymtabs>: New method.
2011         (class objfile_psymtabs): Remove.
2012         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2013         typedef.
2014         <range>: New method.
2015         (require_partial_symbols): Change return type.
2016         * psymtab.c (require_partial_symbols)
2017         (psym_expand_symtabs_matching): Update.
2018         * mdebugread.c (parse_partial_symbols): Update.
2019         * dbxread.c (dbx_end_psymtab): Update.
2020
2021 2019-01-15  Tom Tromey  <tom@tromey.com>
2022
2023         * symtab.c (lookup_objfile_from_block)
2024         (lookup_symbol_in_objfile_symtabs)
2025         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2026         (find_line_symtab, info_sources_command)
2027         (default_collect_symbol_completion_matches_break_on)
2028         (make_source_files_completion_list): Update.
2029         * symmisc.c (print_objfile_statistics, dump_objfile)
2030         (maintenance_print_symbols, maintenance_info_symtabs)
2031         (maintenance_check_symtabs, maintenance_info_line_tables):
2032         Update.
2033         * source.c (select_source_symtab)
2034         (forget_cached_source_info_for_objfile): Update.
2035         * objfiles.h (class objfile_compunits): Remove.
2036         (struct objfile) <compunits_range>: New typedef.
2037         (compunits): New method.
2038         * objfiles.c (objfile_relocate1): Update.
2039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2040         * maint.c (count_symtabs_and_blocks): Update.
2041         * linespec.c (iterate_over_all_matching_symtabs): Update.
2042         * cp-support.c (add_symbol_overload_list_qualified): Update.
2043         * coffread.c (coff_symtab_read): Update.
2044         * ada-lang.c (add_nonlocal_symbols)
2045         (ada_collect_symbol_completion_matches)
2046         (ada_add_global_exceptions): Update.
2047
2048 2019-01-15  Tom Tromey  <tom@tromey.com>
2049
2050         * progspace.h (program_space) <objfiles_safe_range>: New
2051         typedef.
2052         <objfiles_safe>: New method.
2053         * objfiles.h (class all_objfiles_safe): Remove.
2054         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2055         * jit.c (jit_inferior_exit_hook): Update.
2056
2057 2019-01-17  Tom Tromey  <tom@tromey.com>
2058
2059         * progspace.h (program_space) <objfiles_range>: New typedef.
2060         <objfiles>: New method.
2061         <objfiles_head>: Rename from objfiles.
2062         (object_files): Update.
2063         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2064         * guile/scm-pretty-print.c
2065         (ppscm_find_pretty_printer_from_objfiles): Update.
2066         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2067         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2068         Update.
2069         * python/py-progspace.c (pspy_get_objfiles): Update.
2070         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2071         Update.
2072         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2073         (objfpy_lookup_objfile_by_build_id): Update.
2074         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2075         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2076         Update.
2077         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2078         (expand_symtab_containing_pc, lookup_objfile_from_block)
2079         (lookup_static_symbol, basic_lookup_transparent_type)
2080         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2081         (find_line_symtab, info_sources_command)
2082         (default_collect_symbol_completion_matches_break_on)
2083         (make_source_files_completion_list, find_main_name): Update.
2084         * symmisc.c (print_symbol_bcache_statistics)
2085         (print_objfile_statistics, maintenance_print_symbols)
2086         (maintenance_print_msymbols, maintenance_print_objfiles)
2087         (maintenance_info_symtabs, maintenance_check_symtabs)
2088         (maintenance_expand_symtabs, maintenance_info_line_tables):
2089         Update.
2090         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2091         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2092         (map_overlay_command, unmap_overlay_command)
2093         (simple_overlay_update, expand_symtabs_matching)
2094         (map_symbol_filenames): Update.
2095         * symfile-debug.c (set_debug_symfile): Update.
2096         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2097         Update.
2098         * source.c (select_source_symtab, forget_cached_source_info):
2099         Update.
2100         * solib.c (solib_read_symbols): Update.
2101         * solib-spu.c (append_ocl_sos): Update.
2102         * psymtab.c (maintenance_print_psymbols)
2103         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2104         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2105         * printcmd.c (info_symbol_command): Update.
2106         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2107         Update.
2108         * objfiles.h (class all_objfiles): Remove.
2109         * objfiles.c (have_partial_symbols, have_full_symbols)
2110         (have_minimal_symbols, qsort_cmp, update_section_map)
2111         (shared_objfile_contains_address_p)
2112         (default_iterate_over_objfiles_in_search_order): Update.
2113         * objc-lang.c (info_selectors_command, info_classes_command)
2114         (find_methods): Update.
2115         * minsyms.c (find_solib_trampoline_target): Update.
2116         * maint.c (maintenance_info_sections)
2117         (maintenance_translate_address, count_symtabs_and_blocks):
2118         Update.
2119         * main.c (captured_main_1): Update.
2120         * linux-thread-db.c (try_thread_db_load_from_pdir)
2121         (has_libpthread): Update.
2122         * linespec.c (iterate_over_all_matching_symtabs)
2123         (search_minsyms_for_name): Update.
2124         * jit.c (jit_find_objf_with_entry_addr): Update.
2125         * hppa-tdep.c (find_unwind_entry)
2126         (hppa_lookup_stub_minimal_symbol): Update.
2127         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2128         Update.
2129         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2130         (elf_gnu_ifunc_resolve_by_got): Update.
2131         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2132         * dwarf-index-write.c (save_gdb_index_command): Update.
2133         * cp-support.c (add_symbol_overload_list_qualified): Update.
2134         * breakpoint.c (create_overlay_event_breakpoint)
2135         (create_longjmp_master_breakpoint)
2136         (create_std_terminate_master_breakpoint)
2137         (create_exception_master_breakpoint): Update.
2138         * blockframe.c (find_pc_partial_function): Update.
2139         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2140         (ada_collect_symbol_completion_matches)
2141         (ada_add_global_exceptions): Update.
2142
2143 2019-01-17  Tom Tromey  <tom@tromey.com>
2144
2145         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2146         declare VEC.
2147         (solib_target_parse_libraries): Change return type.
2148         (library_list_start_segment, library_list_start_section)
2149         (library_list_end_library, library_list_start_library); Update.
2150         (solib_target_free_library_list): Remove.
2151         (solib_target_parse_libraries): Remove cleanup.  Change return
2152         type.
2153         (solib_target_current_sos): Update.
2154
2155 2019-01-17  Tom Tromey  <tromey@bapiya>
2156
2157         * valprint.c: Replace "the the" with "the".
2158         * symtab.c: Replace "the the" with "the".
2159         * solib.c: Replace "the the" with "the".
2160         * solib-dsbt.c: Replace "the the" with "the".
2161         * linespec.c: Replace "the the" with "the".
2162         * dwarf2loc.h: Replace "the the" with "the".
2163         * amd64-windows-tdep.c: Replace "the the" with "the".
2164         * aarch64-tdep.c: Replace "the the" with "the".
2165
2166 2019-01-16  Keith Seitz  <keiths@redhat.com>
2167
2168         PR gdb/23773
2169         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2170         <builder>: Rename to ..
2171         <m_builder>: ... this and make private.
2172         (dwarf2_cu::get_builder): New method.  Change all users of
2173         `builder' to use this method.
2174         (dwarf2_start_symtab): Move to ...
2175         (dwarf2_cu::start_symtab): ... here.  Update all callers
2176         (setup_type_unit_groups): Move to ...
2177         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2178         callers.
2179         (dwarf2_cu::reset_builder): New method.
2180         (process_full_compunit, process_full_type_unit): Use
2181         dwarf2_cu::reset_builder.
2182         (follow_die_offset): Record the ancestor CU if it is different
2183         from the followed DIE's CU.
2184         (follow_die_sig_1): Likewise.
2185
2186 2019-01-15  Tom Tromey  <tom@tromey.com>
2187
2188         * remote.c (class remote_state) <buf>: Now a char_vector.
2189         <buf_size>: Remove.
2190         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2191         parameter.
2192         (remote_target::getpkt_or_notif_sane_1)
2193         (remote_target::getpkt_sane)
2194         (remote_target::getpkt_or_notif_sane): Likewise.
2195         (class remote_target) <putpkt>: New overload.
2196         (remote_target::read_frame): Change type of "buf_p".  Remove
2197         sizeof_p parameter.
2198         (packet_ok): New overload.
2199         (packet_check_result): New overload.
2200         Update all uses.
2201
2202 2019-01-14  Tom Tromey  <tom@tromey.com>
2203
2204         * remote-notif.c (handle_notification, remote_notif_ack)
2205         (remote_notif_parse): Make "buf" const.
2206         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2207         const.
2208         (remote_notif_parse, remote_notif_ack, handle_notification):
2209         Likewise.
2210         * remote.c (remote_notif_stop_parse): Make "buf" const.
2211         (remote_target::remote_parse_stop_reply): Make "buf" const.
2212         (remote_notif_stop_ack): Make "buf" const.
2213
2214 2019-01-14  Tom Tromey  <tom@tromey.com>
2215
2216         * remote.c (remote_console_output): Make parameter const.
2217
2218 2019-01-14  Tom Tromey  <tom@tromey.com>
2219
2220         * target-debug.h (target_debug_print_signals): Constify.
2221         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2222         * procfs.c (procfs_target::pass_signals): Update.
2223         * linux-nat.c (linux_nat_target::pass_signals): Update.
2224         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2225         * target-delegates.c: Rebuild.
2226         * remote.c (remote_target::program_signals): Update.
2227         (remote_target::pass_signals): Update.
2228         * target.c (target_pass_signals): Constify argument.
2229         (target_program_signals): Likewise.
2230         * target.h (struct target_ops) <pass_signals, program_signals>:
2231         Constify argument.
2232         (target_pass_signals, target_program_signals): Constify argument.
2233
2234 2019-01-14  Tom Tromey  <tom@tromey.com>
2235
2236         PR tui/28819:
2237         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2238
2239 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2240
2241         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2242         field.
2243         * rs6000-tdep.c: Include reggroups.h.
2244         (IS_V_ALIAS_PSEUDOREG): Define.
2245         (rs6000_register_name): Return names for the "vX" aliases.
2246         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2247         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2248         aliases.  Call default_register_reggroup_p for all other
2249         pseudo-registers.
2250         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2251         New functions.
2252         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2253         Handle "vX" aliases.
2254         (v_alias_pseudo_register_collect): New function.
2255         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2256         (rs6000_gdbarch_init): Initialize "vX" aliases as
2257         pseudo-registers.  Restore registration of
2258         rs6000_pseudo_register_reggroup_p with
2259         set_tdesc_pseudo_register_reggroup_p.
2260
2261 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2262
2263         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2264         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2265         set_gdbarch_num_pseudo_regs.
2266
2267 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2268
2269         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2270         Remove arg prefixname, add do_set and do_show.
2271         Add member functions set_list and show_list.
2272         * cli/cli-style.c (class cli_style_option): Update accordingly.
2273         (style_set_list): Move to file scope.
2274         (style_show_list): Likewise.
2275         (set_style): Call help_list.
2276         (show_style): Call cmd_show_list.
2277         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2278         Update to use the new macro.
2279
2280 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2281
2282         * ada-lang.c (_initialize_ada_language): Expand the help text
2283         for the "catch exception" command.
2284
2285 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2286
2287         * symtab.c (matching_obj_sections): Initialize obj,
2288         declare it closer to its usage.
2289
2290 2019-01-10  Tom Tromey  <tom@tromey.com>
2291
2292         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2293         (basic_inf_threads_range): Remove.
2294         (inf_threads_range, inf_non_exited_threads_range)
2295         (safe_inf_threads_range): Use next_adapter.
2296
2297 2019-01-10  Keith Seitz  <keiths@redhat.com>
2298
2299         PR gdb/23712
2300         PR symtab/23010
2301         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2302         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2303
2304 2019-01-10  Keith Seitz  <keiths@redhat.com>
2305
2306         PR gdb/23712
2307         PR symtab/23010
2308         * dictionary.c (pending_to_vector): Remove.
2309         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2310         Remove _1 suffix, replacing functions of the same name.  Update
2311         all callers.
2312         (dict_create_hashed, dict_create_hashed_expandable)
2313         (dict_create_linear, dict_create_linear_expandable, dict_free)
2314         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2315         Make functions static.
2316
2317 2019-01-10  Keith Seitz  <keiths@redhat.com>
2318
2319         PR gdb/23712
2320         PR symtab/23010
2321         * dictionary.h (struct dictionary): Replace declaration with
2322         multidictionary.
2323         (dict_create_hashed, dict_create_hashed_expandable)
2324         (dict_create_linear, dict_create_linear_expandable)
2325         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2326         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2327         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2328         taking multidictionary argument.
2329         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2330         * block.h (struct block) <dict>: Change to multidictionary
2331         and rename `multidict'.
2332         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2333         symmisc.c: Update all dictionary references to multidictionary.
2334
2335 2019-01-10  Keith Seitz  <keiths@redhat.com>
2336
2337         PR gdb/23712
2338         PR symtab/23010
2339         * dictionary.c: Include unordered_map.
2340         (pending_to_vector): New function.
2341         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2342         Rewrite the non-"_1" functions to take vector instead
2343         of linked list.
2344         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2345         "new" _1 versions of the same name.
2346         (multidictionary): Define.
2347         (std::hash<enum language): New definition.
2348         (collate_pending_symbols_by_language, mdict_create_hashed)
2349         (mdict_create_hashed_expandable, mdict_create_linear)
2350         (mdict_create_linear_expandable, mdict_free)
2351         (find_language_dictionary, create_new_language_dictionary)
2352         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2353         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2354         (mdict_size, mdict_empty): New functions.
2355         * dictionary.h (mdict_iterator): Define.
2356
2357 2019-01-10  Pedro Alves  <palves@redhat.com>
2358
2359         * breakpoint.c (read_uploaded_action)
2360         (create_tracepoint_from_upload): Adjust to use
2361         gdb::unique_xmalloc_ptr.
2362         * ctf.c (ctf_write_uploaded_tp):
2363         (SET_ARRAY_FIELD): Use emplace_back.
2364         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2365         * tracefile-tfile.c (tfile_write_uploaded_tp):
2366         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2367         gdb::unique_xmalloc_ptr.
2368         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2369         at_string, cond_string, cmd_strings>: Replace char pointers
2370         with gdb::unique_xmalloc_ptr.
2371
2372 2019-01-10  Pedro Alves  <palves@redhat.com>
2373
2374         * solib-target.c (library_list_start_library): Don't xstrdup name.
2375
2376 2019-01-10  Pedro Alves  <palves@redhat.com>
2377
2378         * mdebugread.c (parse_partial_symbols): Use
2379         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2380
2381 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * linux-fork.c (scoped_switch_fork_info)
2384         <~scoped_switch_fork_info>: Fix incorrect variable name.
2385
2386 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * linux-fork.c (scoped_switch_fork_info)
2389         <scoped_switch_fork_info>: Make explicit.
2390         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2391
2392 2019-01-10  Tom Tromey  <tom@tromey.com>
2393
2394         * objfiles.h (objfile::reset_psymtabs): Update.
2395         * objfiles.c (objfile::objfile): Update.
2396         * psymtab.h (psymtab_storage::obstack): Update.
2397         (psymtab_storage::m_obstack): Use gdb::optional.
2398         (class psymtab_storage): Update comment.  Remove objfile
2399         parameter.
2400         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2401
2402 2019-01-10  Tom Tromey  <tom@tromey.com>
2403
2404         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2405         <free_psymtabs>: Now private.
2406         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2407         (allocate_psymtab): Use new method.
2408
2409 2019-01-10  Tom Tromey  <tom@tromey.com>
2410
2411         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2412         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2413         * mdebugread.c (parse_partial_symbols): Use
2414         allocate_dependencies.
2415         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2416         allocate_dependencies.
2417         (process_psymtab_comp_unit_reader)
2418         (build_type_psymtab_dependencies): Likewise.
2419         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2420
2421 2019-01-10  Tom Tromey  <tom@tromey.com>
2422
2423         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2424         PSYMBOL_SET_LANGUAGE.
2425         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2426
2427 2019-01-10  Tom Tromey  <tom@tromey.com>
2428
2429         * psymtab.h (psymtab_storage::obstack): New method.
2430         <m_obstack>: Rename from obstack; now private.
2431         * psymtab.c (psymtab_storage): Update.
2432         * dwarf2read.c (create_addrmap_from_index)
2433         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2434         Update.
2435
2436 2019-01-10  Tom Tromey  <tom@tromey.com>
2437
2438         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2439         * objfiles.h (objfile::reset_psymtabs): New method.
2440
2441 2019-01-10  Tom Tromey  <tom@tromey.com>
2442
2443         * symmisc.c (print_symbol_bcache_statistics): Update.
2444         (print_objfile_statistics): Update.
2445         * symfile.c (reread_symbols): Update.
2446         * psymtab.h (class psymtab_storage): New.
2447         * psymtab.c (psymtab_storage): New constructor.
2448         (~psymtab_storage): New destructor.
2449         (require_partial_symbols): Update.
2450         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2451         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2452         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2453         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2454         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2455         (start_psymtab_common, end_psymtab_common)
2456         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2457         (allocate_psymtab): Update.
2458         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2459         Update.
2460         (dump_psymtab_addrmap, maintenance_print_psymbols)
2461         (maintenance_check_psymtabs): Update.
2462         (class objfile_psymtabs): Move to objfiles.h.
2463         * psympriv.h (discard_psymtab): Now inline.
2464         (psymtab_discarder::psymtab_discarder): Update.
2465         (psymtab_discarder::~psymtab_discarder): Update.
2466         (ALL_OBJFILE_PSYMTABS): Rewrite.
2467         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2468         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2469         Remove fields.
2470         <partial_symtabs>: New field.
2471         (class objfile_psymtabs): Move from psymtab.h.  Update.
2472         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2473         psymbol_cache.
2474         (objfile::~objfile): Don't destroy psymbol_cache.
2475         * mdebugread.c (parse_partial_symbols): Update.
2476         * dwarf2read.c (create_addrmap_from_index)
2477         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2478         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2479         (add_partial_subprogram, dwarf2_ranges_read): Update.
2480         * dwarf-index-write.c (write_address_map)
2481         (write_one_signatured_type, recursively_write_psymbols)
2482         (class debug_names, class debug_names, write_psymtabs_to_index):
2483         Update.
2484
2485 2019-01-10  Tom Tromey  <tom@tromey.com>
2486
2487         * symtab.h (SYMBOL_SET_NAMES): Update.
2488         (symbol_set_names): Update.
2489         (MSYMBOL_SET_NAMES): Update.
2490         * symtab.c (symbol_set_names): Change argument to be an
2491         objfile_per_bfd_storage.
2492         * psymtab.c (add_psymbol_to_bcache): Update.
2493         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2494
2495 2019-01-10  Tom Tromey  <tom@tromey.com>
2496
2497         * symtab.c (create_demangled_names_hash): Change argument to be an
2498         objfile_per_bfd_storage.
2499         (symbol_set_names): Update.
2500
2501 2019-01-10  Tom Tromey  <tom@tromey.com>
2502
2503         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2504         init_psymbol_list.
2505         * psymtab.c (init_psymbol_list): Do nothing if already called.
2506         * psympriv.h (init_psymbol_list): Add comment.
2507         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2508         init_psymbol_list.
2509         * dbxread.c (dbx_symfile_read): Unconditionally call
2510         init_psymbol_list.
2511
2512 2019-01-10  Tom Tromey  <tom@tromey.com>
2513
2514         * xcoffread.c (scan_xcoff_symtab): Update.
2515         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2516         "where".
2517         * mdebugread.c (parse_partial_symbols)
2518         (handle_psymbol_enumerators): Update.
2519         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2520         * dbxread.c (read_dbx_symtab): Update.
2521         * psympriv.h (psymbol_placement): New enum.
2522         (add_psymbol_to_list): Update.
2523
2524 2019-01-10  Tom Tromey  <tom@tromey.com>
2525
2526         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2527         static_psymbols parameters.
2528         (scan_xcoff_symtab): Update.
2529         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2530         static_psymbols parameters.
2531         * psympriv.h (start_psymtab_common): Update.
2532         * mdebugread.c (parse_partial_symbols): Update.
2533         * dwarf2read.c (create_partial_symtab): Update.
2534         * dbxread.c (read_dbx_symtab): Update.
2535         (start_psymtab): Remove global_psymbols and static_psymbols
2536         parameters.
2537
2538 2019-01-10  Tom Tromey  <tom@tromey.com>
2539
2540         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2541         * psymtab.c (allocate_psymtab): Add comment.
2542         * psympriv.h (allocate_psymtab): Add comment.
2543         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2544         initializations.
2545         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2546
2547 2019-01-10  Tom Tromey  <tom@tromey.com>
2548
2549         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2550         Don't declare.
2551         * mipsread.c: Include mdebugread.h.
2552         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2553         Declare.
2554         * elfread.c: Include mdebugread.h.
2555
2556 2019-01-09  Tom Tromey  <tom@tromey.com>
2557
2558         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2559         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2560         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2561         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2562         (psym_lookup_symbol, psym_find_last_source_symtab)
2563         (psym_forget_cached_source_info, psym_print_stats)
2564         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2565         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2566         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2567         (psym_find_compunit_symtab_by_address)
2568         (maintenance_print_psymbols, maintenance_info_psymtabs)
2569         (maintenance_check_psymtabs): Use ranged for.
2570         * psymtab.h (class objfile_psymtabs): New.
2571         (require_partial_symbols): Return objfile_psymtabs.
2572         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2573
2574 2019-01-09  Tom Tromey  <tom@tromey.com>
2575
2576         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2577         (find_pc_mapped_section, list_overlays_command)
2578         (map_overlay_command, unmap_overlay_command)
2579         (simple_overlay_update): Use all_objfiles.
2580         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2581         * printcmd.c (info_symbol_command): Use all_objfiles.
2582         * objfiles.h (ALL_OBJSECTIONS): Remove.
2583         * maint.c (maintenance_translate_address): Use all_objfiles.
2584         * gcore.c (gcore_create_callback): Use all_objfiles.
2585         (objfile_find_memory_regions): Likewise.
2586
2587 2019-01-09  Tom Tromey  <tom@tromey.com>
2588
2589         * symtab.c (find_line_symtab, info_sources_command)
2590         (make_source_files_completion_list): Use objfile_compunits.
2591         * source.c (select_source_symtab): Use objfile_compunits.
2592         * objfiles.h (struct objfile): Update comment.
2593         (ALL_OBJFILES): Remove.
2594         (ALL_FILETABS): Remove.
2595         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2596         objfile_compunits.
2597
2598 2019-01-09  Tom Tromey  <tom@tromey.com>
2599
2600         * symmisc.c (print_objfile_statistics, dump_objfile)
2601         (maintenance_print_symbols): Use compunit_filetabs.
2602         * source.c (forget_cached_source_info_for_objfile): Use
2603         compunit_filetabs.
2604         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2605         (ALL_FILETABS): Use compunit_filetabs.
2606         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2607         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2608
2609 2019-01-09  Tom Tromey  <tom@tromey.com>
2610
2611         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2612         (compunit_filetabs): New.
2613         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2614         compunit_filetabs.
2615         (info_sources_command, make_source_files_completion_list): Remove
2616         declaration.
2617         * symmisc.c (print_objfile_statistics, dump_objfile)
2618         (maintenance_print_symbols): Remove declaration.
2619         (maintenance_info_symtabs): Use compunit_filetabs.
2620         (maintenance_info_line_tables): Likewise.
2621         * source.c (select_source_symtab): Change local variable name.
2622         (forget_cached_source_info_for_objfile): Remove declaration.
2623         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2624         * objfiles.c (objfile_relocate1): Remove declaration.
2625         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2626         declaration.
2627         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2628         * coffread.c (coff_symtab_read): Remove declaration.
2629         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2630         compunit_filetabs.
2631
2632 2019-01-09  Tom Tromey  <tom@tromey.com>
2633
2634         * symtab.c (lookup_objfile_from_block)
2635         (find_pc_sect_compunit_symtab, search_symbols)
2636         (default_collect_symbol_completion_matches_break_on): Use
2637         objfile_compunits.
2638         * objfiles.h (ALL_COMPUNITS): Remove.
2639         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2640         * cp-support.c (add_symbol_overload_list_qualified): Use
2641         objfile_compunits.
2642         * ada-lang.c (ada_collect_symbol_completion_matches)
2643         (ada_add_global_exceptions): Use objfile_compunits.
2644
2645 2019-01-09  Tom Tromey  <tom@tromey.com>
2646
2647         * source.c (select_source_symtab)
2648         (forget_cached_source_info_for_objfile): Remove declaration.
2649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2650         declaration.
2651         * maint.c (count_symtabs_and_blocks): Remove declaration.
2652         * cp-support.c (add_symbol_overload_list_qualified): Remove
2653         declaration.
2654         * coffread.c (coff_symtab_read): Remove declaration.
2655         * symtab.c (lookup_symbol_in_objfile_symtabs)
2656         (basic_lookup_transparent_type_1): Use objfile_compunits.
2657         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2658         (info_sources_command, search_symbols)
2659         (default_collect_symbol_completion_matches_break_on)
2660         (make_source_files_completion_list): Remove declaration.
2661         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2662         (ada_collect_symbol_completion_matches)
2663         (ada_add_global_exceptions): Remove declaration.
2664         * linespec.c (iterate_over_all_matching_symtabs): Use
2665         objfile_compunits.
2666         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2667         (class objfile_compunits): New.
2668         (ALL_COMPUNITS): Use objfile_compunits.
2669         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2670         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2671         objfile_compunits.
2672         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2673
2674 2019-01-09  Tom Tromey  <tom@tromey.com>
2675
2676         * symtab.c (search_symbols)
2677         (default_collect_symbol_completion_matches_break_on): Use
2678         objfile_msymbols.
2679         * ada-lang.c (ada_lookup_simple_minsym)
2680         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2681         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2682         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2683         objfile_msymbols.
2684         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2685         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2686         * objc-lang.c (find_methods): Use objfile_msymbols.
2687         (info_selectors_command, info_classes_command): Likewise.
2688         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2689         * objfiles.h (class objfile_msymbols): New.
2690         (ALL_OBJFILE_MSYMBOLS): Remove.
2691         (ALL_MSYMBOLS): Remove.
2692
2693 2019-01-09  Tom Tromey  <tom@tromey.com>
2694
2695         * common/next-iterator.h (next_adapter): Add Iterator template
2696         parameter.
2697         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2698         (class all_objfiles_safe): New.
2699         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2700         * objfiles.c (put_objfile_before): Update comment.
2701         (add_separate_debug_objfile): Likewise.
2702         (free_all_objfiles): Use all_objfiles_safe.
2703         (objfile_purge_solibs): Likewise.
2704
2705 2019-01-09  Tom Tromey  <tom@tromey.com>
2706
2707         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2708         (expand_symtab_containing_pc, lookup_static_symbol)
2709         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2710         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2711         all_objfiles.
2712         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2713         * breakpoint.c (create_overlay_event_breakpoint)
2714         (create_longjmp_master_breakpoint)
2715         (create_std_terminate_master_breakpoint)
2716         (create_exception_master_breakpoint): Use all_objfiles.
2717         * linux-thread-db.c (try_thread_db_load_from_pdir)
2718         (has_libpthread): Use all_objfiles.
2719         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2720         * linespec.c (iterate_over_all_matching_symtabs)
2721         (search_minsyms_for_name): Use all_objfiles.
2722         * maint.c (maintenance_info_sections): Use all_objfiles.
2723         * main.c (captured_main_1): Use all_objfiles.
2724         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2725         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2726         * guile/scm-pretty-print.c
2727         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2728         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2729         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2730         (maintenance_print_msymbols): Use all_objfiles.
2731         * source.c (select_source_symtab): Use all_objfiles.
2732         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2733         * symfile.c (remove_symbol_file_command)
2734         (expand_symtabs_matching, map_symbol_filenames): Use
2735         all_objfiles.
2736         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2737         all_objfiles.
2738         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2739         * objc-lang.c (find_methods): Use all_objfiles.
2740         * objfiles.c (have_partial_symbols, have_full_symbols)
2741         (have_minimal_symbols, qsort_cmp)
2742         (default_iterate_over_objfiles_in_search_order): Use
2743         all_objfiles.
2744         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2745         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2746         (maintenance_check_psymtabs): Use all_objfiles.
2747         (ALL_PSYMTABS): Remove.
2748         * compile/compile-object-run.c (do_module_cleanup): Use
2749         all_objfiles.
2750         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2751         * cp-support.c (add_symbol_overload_list_qualified): Use
2752         all_objfiles.
2753         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2754         Use all_objfiles.
2755         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2756         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2757         all_objfiles.
2758         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2759         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2760         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2761         Uses all_objfiles.
2762         * solib.c (solib_read_symbols): Use all_objfiles
2763
2764 2019-01-09  Tom Tromey  <tom@tromey.com>
2765
2766         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2767         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2768         all_objfiles.
2769         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2770         * symmisc.c (print_symbol_bcache_statistics)
2771         (print_objfile_statistics, maintenance_print_objfiles)
2772         (maintenance_info_symtabs, maintenance_check_symtabs)
2773         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2774         all_objfiles.
2775         * source.c (forget_cached_source_info): Use all_objfiles.
2776         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2777         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2778         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2779         * objfiles.c (update_section_map): Use all_objfiles.
2780         (shared_objfile_contains_address_p): Likewise.
2781         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2782         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2783
2784 2019-01-09  Tom Tromey  <tom@tromey.com>
2785
2786         * common/next-iterator.h: New file.
2787         * objfiles.h (class all_objfiles): New.
2788         (struct objfile_iterator): New.
2789
2790 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2791
2792         * NEWS: Move the description of the changed "frame", "select-frame",
2793          and "info frame" commands to the Changed commands section.
2794
2795 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2796
2797         * gdbtypes.c (check_stub_method_group): Remove handling of old
2798         mangling schemes.
2799         * linespec.c (find_methods): Likewise.
2800         * stabsread.c (read_member_functions): Likewise.
2801         * valops.c (search_struct_method): Likewise.
2802         (value_struct_elt_for_reference): Likewise.
2803         * NEWS: Mention this change.
2804
2805 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2808         print_source_lines.
2809         * source.c (print_source_lines_base): Update line number check.
2810         (print_source_lines): New function.
2811         (source_lines_range::source_lines_range): New function.
2812         * source.h (class source_lines_range): New class.
2813         (print_source_lines): New declaration.
2814
2815 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2816
2817         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2818
2819 2019-01-08  Tom Tromey  <tom@tromey.com>
2820             Simon Marchi  <simon.marchi@ericsson.com>
2821
2822         PR gdb/24060
2823         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2824         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2825         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2826         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2827         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2828         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2829
2830 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * source.c (select_source_symtab): Move header comment to
2833         declaration in source.h.
2834         (forget_cached_source_info_for_objfile): Likewise.
2835         (forget_cached_source_info): Likewise.
2836         (identify_source_line): Likewise.
2837         * source.h (identify_source_line): Move declaration from symtab.h
2838         and add comment from source.c
2839         (print_source_lines): Likewise.
2840         (forget_cached_source_info_for_objfile): Likewise.
2841         (forget_cached_source_info): Likewise.
2842         (select_source_symtab): Likewise.
2843         (enum print_source_lines_flag): Move definition from symtab.h.
2844         * symtab.h (identify_source_line): Move declaration to source.h.
2845         (print_source_lines): Likewise.
2846         (forget_cached_source_info_for_objfile): Likewise.
2847         (forget_cached_source_info): Likewise.
2848         (select_source_symtab): Likewise.
2849         (enum print_source_lines_flag): Move definition to source.h.
2850         * tui/tui-hooks.c: Add 'source.h' include.
2851
2852 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * source.c (print_source_lines_base): Handle requests to print
2855         reverse line number sequences, and guard against empty lines
2856         string.
2857
2858 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * source.c (print_source_lines_base): Fix skip of '\r' if next
2861         character is '\n'.
2862
2863 2019-01-06  Tom Tromey  <tom@tromey.com>
2864
2865         * c-exp.y (struct c_parse_state) <macro_original_text,
2866         expansion_obstack>: New member.
2867         (macro_original_text, expansion_obstack): Remove globals.
2868         (scan_macro_expansion, scanning_macro_expansion)
2869         (finished_macro_expansion): Update.
2870         (scan_macro_cleanup): Remove.
2871         (yylex, c_parse): Update.
2872
2873 2019-01-06  Tom Tromey  <tom@tromey.com>
2874
2875         * c-exp.y (struct c_parse_state) <strings>: New member.
2876         (operator_stoken): Update.
2877
2878 2019-01-06  Tom Tromey  <tom@tromey.com>
2879
2880         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2881         (union type_stack_elt) <typelist_val>: Now a pointer to
2882         std::vector.
2883         (type_stack_cleanup): Don't declare.
2884         (push_typelist): Update.
2885         * parse.c (pop_typelist): Return a std::vector.
2886         (push_typelist): Take a std::vector.
2887         (follow_types): Update.  Do not free args.
2888         (type_stack_cleanup): Remove.
2889         * c-exp.y (struct c_parse_state): New.
2890         (cpstate): New global.
2891         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2892         (nonempty_typelist): Update.
2893         (func_mod): Create a new vector.
2894         (c_parse): Create a c_parse_state.
2895         (check_parameter_typelist): Do not delete params.
2896         (function_method): Update.  Do not delete type_list.
2897
2898 2019-01-06  Tom Tromey  <tom@tromey.com>
2899
2900         PR gdb/28155:
2901         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2902         check_typedef.
2903         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2904         (print_return_value): Likewise.
2905
2906 2019-01-05  Tom Tromey  <tom@tromey.com>
2907
2908         * contrib/cleanup_check.py: Remove.
2909         * contrib/gcc-with-excheck: Remove.
2910         * contrib/exsummary.py: Remove.
2911         * contrib/excheck.py: Remove.
2912
2913 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2914
2915         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2916         NULL. Initialize tpprev to NULL instead of assigning it
2917         to NULL on the next statement.
2918         * windows-nat.c (windows_delete_thread): Remove check for
2919         main_thread_id before printing thread exit notifications.
2920         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2921         Remove thread ID check against main_thread_id.
2922         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2923         windows_delete_thread.
2924         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2925
2926 2019-01-04  Tom Tromey  <tom@tromey.com>
2927
2928         * compile/compile.c (_initialize_compile): Use upper case for
2929         metasyntactic variables.
2930         * symmisc.c (_initialize_symmisc): Use upper case for
2931         metasyntactic variables.
2932         * psymtab.c (_initialize_psymtab): Use upper case for
2933         metasyntactic variables.
2934         * demangle.c (demangle_command): Use upper case for metasyntactic
2935         variables.
2936         (_initialize_demangler): Likewise.
2937         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2938         variables.
2939
2940 2019-01-03  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2943
2944 2019-01-03  Tom Tromey  <tom@tromey.com>
2945
2946         * python/py-symtab.c (salpy_str): Update.
2947         (struct salpy_sal_object) <symtab>: Now a PyObject.
2948         (salpy_dealloc): Update.
2949         (del_objfile_sal): Use gdbpy_ref.
2950
2951 2019-01-03  Tom Tromey  <tom@tromey.com>
2952
2953         * python/py-type.c (convert_field): Use new_reference.  Return
2954         gdbpy_ref.
2955         (make_fielditem): Return gdbpy_ref.
2956         (typy_fields): Update.
2957         (typy_getitem): Update.
2958         (field_name): Return gdbpy_ref.  Use new_reference.
2959         (typy_iterator_iternext): Update.
2960
2961 2019-01-03  Tom Tromey  <tom@tromey.com>
2962
2963         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2964
2965 2019-01-03  Tom Tromey  <tom@tromey.com>
2966
2967         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2968         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2969         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2970         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2971         (pspy_set_type_printers): Likewise.
2972         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2973         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2974         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2975         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2976         (objfpy_set_type_printers): Likewise.
2977
2978 2019-01-03  Tom Tromey  <tom@tromey.com>
2979
2980         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2981         (gdbpy_print_stack): Use gdbpy_err_fetch.
2982         * python/python-internal.h (class gdbpy_err_fetch): New class.
2983         (class gdbpy_enter) <m_error_type, m_error_value,
2984         m_error_traceback>: Remove.
2985         <m_error>: New member.
2986         (gdbpy_exception_to_string): Don't declare.
2987         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2988         * python/py-value.c (convert_value_from_python): Use
2989         gdbpy_err_fetch.
2990         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2991         gdbpy_exception_to_string.
2992         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2993         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2994         gdbpy_err_fetch.
2995
2996 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2997
2998         * linux-nat.c (delete_lwp_cleanup): Delete.
2999         (struct lwp_deleter): New struct.
3000         (lwp_info_up): New typedef.
3001         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3002         lwp_info_up.
3003
3004 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * linux-fork.c (class scoped_switch_fork_info): New class.
3007         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3008
3009 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3010
3011         * valops.c (find_overload_match): Remove use of null_cleanup, and
3012         calls to do_cleanups.
3013
3014 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3015
3016         * compile/compile-cplus-types.c
3017         (compile_cplus_instance::decl_name): Handle changes to
3018         cp_func_name.
3019         * cp-support.c (cp_func_name): Update header comment, update
3020         return type.
3021         * cp-support.h (cp_func_name): Update return type in declaration.
3022         * valops.c (find_overload_match): Move temp_func local to top
3023         level of function and change its type.  Use temp_func to hold and
3024         delete temporary string obtained from cp_func_name.
3025
3026 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3027
3028         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3029         gdb::char_vector, remove cleanup, and update uses of `msg`.
3030
3031 2019-01-03  Jim Wilson  <jimw@sifive.com>
3032
3033         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3034
3035 2019-01-02  Tom Tromey  <tom@tromey.com>
3036
3037         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3038         (tdesc_parse_xml): Remove cleanups.
3039         * target-descriptions.h (make_cleanup_free_target_description):
3040         Don't declare.
3041         (target_desc_deleter): New struct.
3042         (target_desc_up): New typedef.
3043         * target-descriptions.c (target_desc_deleter::operator()): Rename
3044         from free_target_description.
3045         (make_cleanup_free_target_description): Remove.
3046
3047 2019-01-02  Tom Tromey  <tom@tromey.com>
3048
3049         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3050         constructor, destructor.
3051         (linespec_parser): Remove typedef.
3052         (~linespec_parser): Rename from linespec_parser_delete.
3053         (linespec_lex_to_end, linespec_complete_label)
3054         (linespec_complete): Update.
3055         (decode_line_full): Remove cleanups.
3056         (decode_line_1): Update.
3057
3058 2019-01-02  Tom Tromey  <tom@tromey.com>
3059
3060         * python/python-internal.h (inferior_to_inferior_object): Change
3061         return type.
3062         * python/py-exitedevent.c (create_exited_event_object): Update.
3063         * python/py-inferior.c (inferior_to_inferior_object): Return
3064         gdbpy_ref.
3065         (python_new_inferior, python_inferior_deleted)
3066         (thread_to_thread_object, delete_thread_object)
3067         (build_inferior_list, gdbpy_selected_inferior): Update.
3068         * python/py-infthread.c (create_thread_object): Update.  Also fail
3069         if inferior_to_inferior_object fails.
3070
3071 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3072
3073         * inferior.h (class inferior) <displaced_step_state>: New field.
3074         * infrun.h (struct displaced_step_state): Move here from
3075         infrun.c.  Initialize fields, add constructor.
3076         <inf>: Remove field.
3077         <reset>: New method.
3078         * infrun.c (struct displaced_step_inferior_state): Move to
3079         infrun.h.
3080         (displaced_step_inferior_states): Remove.
3081         (get_displaced_stepping_state): Adust.
3082         (displaced_step_in_progress_any_inferior): Adjust.
3083         (displaced_step_in_progress_thread): Adjust.
3084         (displaced_step_in_progress): Adjust.
3085         (add_displaced_stepping_state): Remove.
3086         (get_displaced_step_closure_by_addr): Adjust.
3087         (remove_displaced_stepping_state): Remove.
3088         (infrun_inferior_exit): Call displaced_step_state.reset.
3089         (use_displaced_stepping): Don't check for NULL.
3090         (displaced_step_prepare_throw): Call
3091         get_displaced_stepping_state.
3092         (displaced_step_fixup): Don't check for NULL.
3093         (prepare_for_detach): Don't check for NULL.
3094
3095 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3096
3097         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3098          in case of call that did not complete.
3099
3100 2019-01-02  Andrey Utkin  <autkin@undo.io>
3101
3102         * symfile.c (find_separate_debug_file): Fix search of debug files for
3103         remote debuggee.
3104
3105 2019-01-02  Tom Tromey  <tom@tromey.com>
3106
3107         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3108         indentation.
3109         * python/py-frame.c (frapy_older): Remove cast.
3110         (frapy_newer): Likewise.
3111         * python/py-breakpoint.c (local_setattro): Remove cast.
3112         * python/py-arch.c (archpy_name): Remove local variable.
3113         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3114
3115 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3116
3117         * unittests/basic_string_view/element_access/char/empty.cc:
3118         Fix year range in copyright header.
3119
3120 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3121
3122         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3123         Delete.
3124         <operator==>: Update with for removed field.
3125         <hash>: Likewise.
3126         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3127         <isa_features>: ...this.
3128         <abi_features>: New field.
3129         (riscv_isa_flen): Update comment.
3130         (riscv_abi_xlen): New declaration.
3131         (riscv_abi_flen): New declaration.
3132         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3133         isa_features.
3134         (riscv_abi_xlen): New function.
3135         (riscv_isa_flen): Update to get answer from isa_features.
3136         (riscv_abi_flen): New function.
3137         (riscv_has_fp_abi): Update to get answer from abi_features.
3138         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3139         xlen and flen.
3140         (riscv_call_info) <xlen, flen>: Update comment.
3141         (riscv_call_arg_struct): Remove invalid assertions
3142         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3143         is removed.
3144         (riscv_gdbarch_init): Gather isa features and abi features
3145         separately, ensure both match on the gdbarch when reusing an old
3146         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3147         a target with 64-bit float hardware.
3148
3149 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3150
3151         * source.c (search_command_helper): Stop reverse search
3152         when line 1 has been searched.
3153
3154 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3155
3156         * record-full.c (record_full_base_target::close): Rewrite
3157         record_full_core_buf_list free logic.
3158
3159 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3160
3161         * break-catch-syscall.c (print_one_catch_syscall): xfree
3162         the last text.
3163
3164 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3165
3166         * top.c (print_gdb_version): Update Copyright year in version
3167         message.
3168
3169 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3170
3171         Update copyright year range in all GDB files.
3172
3173 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3174
3175         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3176
3177 For older changes see ChangeLog-2018.
3178 \f
3179 Local Variables:
3180 mode: change-log
3181 left-margin: 8
3182 fill-column: 74
3183 version-control: never
3184 coding: utf-8
3185 End:
3186