gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
   4         parameter.  Don't reference globals.
   5         (tui_reg_command): Update.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-regs.c (tui_show_registers): Simplify.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-regs.c (tui_show_registers): Update.
  14         (tui_show_register_group): Add win_info parameter.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  19         Rename from tui_display_reg_element_at_line.
  20         (tui_data_window::display_registers_from_line): Update.
  21         * tui/tui-data.h (struct tui_data_window)
  22         <display_reg_element_at_line>: New method.
  23
  24 2019-07-17  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-regs.h (tui_display_registers_from)
  27         (tui_display_registers_from_line): Don't declare.
  28         * tui/tui-windata.c (tui_data_window::display_all_data)
  29         (tui_data_window::refresh_all)
  30         (tui_data_window::do_scroll_vertical): Update.
  31         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  32         from tui_display_registers_from.
  33         (tui_display_reg_element_at_line): Update.
  34         (tui_data_window::display_registers_from_line): Rename from
  35         tui_display_registers_from_line.
  36         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  37         display_registers_from_line>: New methods.
  38
  39 2019-07-17  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  42         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  43         from tui_erase_data_content.
  44         (tui_data_window::display_all_data)
  45         (tui_data_window::refresh_all)
  46         (tui_data_window::do_scroll_vertical): Update.
  47         * tui/tui-regs.c (tui_show_registers): Update.
  48         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  49         New method.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  54         declare.
  55         * tui/tui-windata.c
  56         (tui_data_window::delete_data_content_windows): Rename from
  57         tui_delete_data_content_windows.
  58         (tui_data_window::display_all_data)
  59         (tui_data_window::do_scroll_vertical): Update.
  60         * tui/tui-data.h (struct tui_data_window)
  61         <delete_data_content_windows>: New method.
  62
  63 2019-07-17  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  66         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  71         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  72         from tui_display_all_data.
  73         * tui/tui-win.c
  74         (tui_data_window::do_make_visible_with_new_height): Update.
  75         * tui/tui-regs.c (tui_show_registers): Update.
  76         * tui/tui-layout.c (tui_set_layout): Update.
  77         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  78         method.
  79
  80 2019-07-17  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  83         * tui/tui-windata.c (tui_display_data_from): Remove.
  84         (tui_data_window::refresh_all): Update.
  85
  86 2019-07-17  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  89         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  90         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  91         tui_display_registers_from_line.
  92         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  93         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  94         "force_display" parameter.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  99         declare.
 100         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 101         Rename from tui_first_reg_element_no_inline.
 102         (tui_display_reg_element_at_line)
 103         (tui_display_registers_from_line): Update.
 104         * tui/tui-data.h (struct tui_data_window)
 105         <first_reg_element_no_inline>: New method.
 106
 107 2019-07-17  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-windata.c (tui_display_data_from)
 110         (tui_data_window::do_scroll_vertical): Update.
 111         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 112         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 113         Rename from tui_line_from_reg_element_no.
 114         (tui_display_registers_from_line): Update.
 115         * tui/tui-data.h (struct tui_data_window)
 116         <line_from_reg_element_no>: New method.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 121         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 122         tui_last_regs_line_no.
 123         (tui_display_reg_element_at_line)
 124         (tui_display_registers_from_line): Update.
 125         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 126         method.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         PR tui/24722:
 131         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 132         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 133         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 134         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 135         (tui_update_breakpoint_info): Likewise.
 136         * tui/tui-hooks.c (tui_event_create_breakpoint)
 137         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 138         Update.
 139
 140 2019-07-17  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 143
 144 2019-07-17  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-winsource.c (tui_update_source_window_as_is)
 147         (tui_update_source_windows_with_addr): Update.
 148         * tui/tui-source.h (tui_set_source_content)
 149         (tui_show_symtab_source): Add "win_info" parameter.
 150         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 151         parameter.
 152         (tui_show_symtab_source): Likewise.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-wingeneral.c
 157         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 162         (struct tui_cmd_window) <can_scroll>: New method.
 163         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 164         method.
 165
 166 2019-07-17  Tom Tromey  <tromey@adacore.com>
 167
 168         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 169         do_field_signed>: Rename.  Change type of "value".
 170         * ui-out.c (ui_out::field_signed): Rename from field_int.
 171         Change type of "value".
 172         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 173         type of "value".
 174         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 175         do_field_int.  Change type of "value".
 176         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 177         do_field_int.  Change type of "value".
 178         * tracepoint.c (trace_status_mi, tfind_1)
 179         (print_one_static_tracepoint_marker): Update.
 180         * thread.c (print_thread_info_1, print_selected_thread_frame):
 181         Update.
 182         * stack.c (print_frame, print_frame_info): Update.
 183         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 184         Update.
 185         * source.c (print_source_lines_base): Update.
 186         * skip.c (info_skip_command): Update.
 187         * record-btrace.c (btrace_ui_out_decode_error)
 188         (btrace_call_history_src_line): Update.
 189         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 190         Update.
 191         * progspace.c (print_program_space): Update.
 192         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 193         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 194         do_field_int.  Change type of "value".
 195         * mi/mi-out.c (mi_ui_out::do_table_begin)
 196         (mi_ui_out::do_table_header): Update.
 197         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 198         type of "value".
 199         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 200         (mi_cmd_data_list_changed_registers, output_register)
 201         (mi_cmd_data_read_memory, mi_load_progress)
 202         (mi_cmd_trace_frame_collected): Update.
 203         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 204         Update.
 205         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 206         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 207         (mi_cmd_var_list_children, varobj_update_one): Update.
 208         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 209         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 210         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 211         * inferior.c (print_inferior): Update.
 212         * gdb_bfd.c (print_one_bfd): Update.
 213         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 214         Update.
 215         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 216         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 217         do_field_int.  Change type of "value".
 218         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 219         do_field_int.  Change type of "value".
 220         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 221         (print_one_breakpoint_location, print_it_catch_fork)
 222         (print_one_catch_fork, print_it_catch_vfork)
 223         (print_one_catch_vfork, print_it_catch_solib)
 224         (print_it_catch_exec, print_it_ranged_breakpoint)
 225         (print_mention_watchpoint, print_mention_masked_watchpoint)
 226         (bkpt_print_it, update_static_tracepoint): Update.
 227         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 228         * break-catch-syscall.c (print_it_catch_syscall): Update.
 229         * ada-tasks.c (print_ada_task_info): Update.
 230         * ada-lang.c (print_it_exception, print_mention_exception):
 231         Update.
 232
 233 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         PR breakpoints/24541
 236         * gdbarch.c: Regenerate.
 237         * gdbarch.h: Regenerate.
 238         * gdbarch.sh: Adjust return type and parameter types for
 239         'stap_adjust_register'.
 240         (i386_stap_adjust_register): Adjust signature and return new
 241         register name.
 242         * stap-probe.c (stap_parse_register_operand): Adjust use of
 243         'gdbarch_stap_adjust_register'.
 244
 245 2019-07-17  Tom Tromey  <tromey@adacore.com>
 246
 247         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 248         declare VEC.
 249         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 250         std::vector.
 251         (struct s390_process_info): Add initializers.
 252         (s390_add_process): Use new.
 253         (s390_linux_nat_target::low_forget_process): Use delete.
 254         (s390_linux_nat_target::low_new_fork)
 255         (s390_linux_nat_target::stopped_by_watchpoint)
 256         (s390_linux_nat_target::low_prepare_to_resume)
 257         (s390_linux_nat_target::insert_watchpoint)
 258         (s390_linux_nat_target::insert_hw_breakpoint)
 259         (s390_linux_nat_target::remove_watchpoint)
 260         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 261
 262 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 263
 264         * aarch64-fbsd-nat.c: Include regcache.h.
 265         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 266         argument.
 267         (aarch64_fbsd_nat_target::fetch_registers)
 268         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 269         variable.
 270         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 271
 272 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 273
 274         * fbsd-nat.c: Include gdbarch.h.
 275
 276 2019-07-15  Tom Tromey  <tromey@adacore.com>
 277
 278         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 279
 280 2019-07-15  Tom Tromey  <tromey@adacore.com>
 281
 282         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 283         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 284         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 285         * cli-out.c (cli_ui_out::do_field_int): New method.
 286         * ui-out.c (ui_out::field_unsigned): New method.
 287         * symfile.c (generic_load): Use field_unsigned.
 288         (print_transfer_performance): Likewise.
 289         * record-btrace.c (ui_out_field_uint): Remove.
 290         (btrace_call_history_insn_range, btrace_call_history): Use
 291         field_unsigned.
 292         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 293         field_unsigned.
 294         * ui-out.h (class ui_out) <field_unsigned>: New method.
 295         <do_field_unsigned>: Likewise.
 296
 297 2019-07-15  Tom Tromey  <tromey@adacore.com>
 298
 299         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 300         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 301         * target.c (flash_erase_command): Use field_string.
 302         * infrun.c (print_signal_received_reason): Use field_string.
 303         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 304         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 305         field_string.
 306         * ada-tasks.c (print_ada_task_info): Use field_string.
 307
 308 2019-07-15  Tom Tromey  <tromey@adacore.com>
 309
 310         * target.c (flash_erase_command): Use field_core_addr.
 311         * symfile.c (generic_load): Use field_core_addr.
 312         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 313         Use field_core_addr.
 314         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 315         field_core_addr.
 316
 317 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 318
 319         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 320         value if its desired type is smaller than a CORE_ADDR and signed.
 321
 322 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 323
 324         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 325         of changes to field names, and use new is_reference field to
 326         decide if a property is a reference or not.
 327         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 328         field.
 329         (struct dwarf2_property_baton): Update header comment, rename
 330         'referenced_type' to 'property_type' and update comments.
 331         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 332         default property type, store in property baton, update to take
 333         accound of renamed field.
 334         (read_func_scope): Update call to attr_to_dynamic_prop.
 335         (read_array_type): Likewise.
 336         (dwarf2_per_cu_addr_sized_int_type): New function.
 337         (read_subrange_index_type): Move type finding code to
 338         dwarf2_per_cu_addr_sized_int_type.
 339         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 340         (dwarf2_per_cu_addr_type): New function.
 341         (set_die_type): Update calls to attr_to_dynamic_prop.
 342
 343 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * dwarf2read.c (read_subrange_index_type): New function.
 346         (read_subrange_type): Move code into new function and call it.
 347         * gdbtypes.c (create_range_type): Add some asserts.
 348
 349 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 352         update return statements.
 353         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 354         declaration, and update comment to match.
 355         * gdbtypes.c (resolve_dynamic_array): Update call to
 356         dwarf2_evaluate_property to match new return type.
 357
 358 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 359
 360         * valarith.c (value_subscripted_rvalue): Change lowerbound
 361         parameter type from int to LONGEST.
 362         * value.h (value_subscripted_rvalue): Likewise in declaration.
 363
 364 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * cli/cli-utils.c (info_print_command_completer): New function.
 367         * cli/cli-utils.h: Add 'completer.h' include, and forward
 368         declaration for 'struct cmd_list_element'.
 369         (info_print_command_completer): Declare.
 370         * stack.c (_initialize_stack): Add completer for 'info locals' and
 371         'info args'.
 372         * symtab.c (_initialize_symtab): Add completer for 'info
 373         variables' and 'info functions'.
 374         * NEWS: Mention completion for additional info commands.
 375
 376 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 377
 378         * cli/cli-utils.c (extract_info_print_args): Delete.
 379         (extract_arg_maybe_quoted): Delete.
 380         (info_print_options_defs): New variable.
 381         (make_info_print_options_def_group): New function.
 382         (extract_info_print_options): Define new function.
 383         * cli/cli-utils.h (extract_info_print_args): Delete.
 384         (struct info_print_options): New structure.
 385         (extract_info_print_options): Declare new function.
 386         * stack.c (info_locals_command): Update to use new
 387         extract_info_print_options, also add a header comment.
 388         (info_args_command): Likewise.
 389         * symtab.c (info_variables_command): Likewise.
 390         (info_functions_command): Likewise.
 391
 392 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 393
 394         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 395         to extract string arguments.
 396         * common/common-utils.c (extract_string_maybe_quoted): New function.
 397         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 398
 399 2019-07-11  Tom Tromey  <tromey@adacore.com>
 400
 401         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 402         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 403         * top.h (gdbinit): Don't declare.
 404         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 405         into...
 406         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 407         * top.c (gdb_init): Don't call init_cli_cmds.
 408         (gdbinit): Remove.
 409         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 410
 411 2019-07-11  Tom Tromey  <tromey@adacore.com>
 412
 413         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 414         after it has been moved.
 415
 416 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 417
 418         * valops.c (value_must_coerce_to_target): Change return type to
 419         bool.
 420         * value.h (value_must_coerce_to_target): Likewise.
 421
 422 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 423
 424         * breakpoint.c (is_hardware_watchpoint): Remove
 425         forward-declaration.
 426         (is_masked_watchpoint): Change return type to bool.
 427         (is_tracepoint): Likewise.
 428         (is_breakpoint): Likewise.
 429         (is_hardware_watchpoint): Likewise.
 430         (is_watchpoint): Likewise.
 431         (is_no_memory_software_watchpoint): Likewise.
 432         (is_catchpoint): Likewise.
 433         (breakpoint_1): Make FILTER parameter's return type bool.
 434         is_masked_watchpoint): Change return type to bool.
 435         (save_breakpoints): Make FILTER parameter's return type bool.
 436         * breakpoint.h (is_breakpoint): Change return type to bool.
 437         (is_watchpoint): Likewise.
 438         (is_catchpoint): Likewise.
 439         (is_tracepoint): Likewise.
 440
 441 2019-07-10  Tom Tromey  <tom@tromey.com>
 442
 443         * defs.h: Don't include gdbarch.h.
 444         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 445         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 446         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 447         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 448         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 449         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 450         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 451         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 452         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 453         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 454         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 455         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 456         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 457         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 458         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 459         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 460         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 461         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 462         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 463         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 464         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 465         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 466         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 467         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 468         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 469         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 470         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 471
 472 2019-07-10  Tom Tromey  <tromey@adacore.com>
 473
 474         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 475         * breakpoint.c (init_ada_exception_breakpoint): Register as
 476         bp_catchpoint.
 477         (print_one_breakpoint_location, print_one_breakpoint): Use
 478         is_ada_exception_catchpoint.
 479         * ada-lang.c (class ada_catchpoint_location): Pass
 480         bp_loc_software_breakpoint to bp_location constructor.
 481         (is_ada_exception_catchpoint): New function.
 482
 483 2019-07-10  Tom Tromey  <tromey@adacore.com>
 484
 485         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 486         VEC.
 487         (struct arm_exidx_entry): New method operator<.
 488         (struct arm_exidx_data) <section_maps>: Change type.
 489         (arm_exidx_data_free): Remove.
 490         (arm_exidx_data_key): Change type.  Move lower.
 491         (arm_exidx_new_objfile): Update.
 492         (arm_compare_exidx_entries): Remove.
 493         (arm_find_exidx_entry, _initialize_arm_tdep)
 494
 495 2019-07-10  Tom Tromey  <tromey@adacore.com>
 496
 497         * solib-spu.c (ocl_program_data_key): Change type.
 498         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 499         Update.
 500
 501 2019-07-10  Tom Tromey  <tromey@adacore.com>
 502
 503         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 504         (struct solib_aix_inferior_data) <library_list>: Change type.
 505         (solib_aix_inferior_data_handle): Change type.
 506         (get_solib_aix_inferior_data): Update.
 507         (solib_aix_free_library_list): Remove.
 508         (library_list_start_library): Update.
 509         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 510         return type.
 511         (solib_aix_get_library_list)
 512         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 513         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 514
 515 2019-07-10  Tom Tromey  <tromey@adacore.com>
 516
 517         * solib-dsbt.c (struct dsbt_info): Add initializers.
 518         (solib_dsbt_pspace_data): Change type.
 519         (dsbt_pspace_data_cleanup): Remove.
 520         (get_dsbt_info, _initialize_dsbt_solib): Update.
 521
 522 2019-07-10  Tom Tromey  <tromey@adacore.com>
 523
 524         * spu-tdep.c (spu_overlay_data): Change type.
 525         (spu_get_overlay_table, spu_overlay_new_objfile)
 526         (_initialize_spu_tdep): Update.
 527
 528 2019-07-10  Tom Tromey  <tromey@adacore.com>
 529
 530         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 531         destructor.
 532         (dbx_objfile_data_key): Change type and declare later.
 533         (DBX_SYMFILE_INFO): Rewrite.
 534         * dbxread.c (dbx_objfile_data_key): Change type.
 535         (dbx_symfile_init): Update.
 536         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 537         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 538         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 539
 540 2019-07-10  Tom Tromey  <tromey@adacore.com>
 541
 542         * jit.c (jit_program_space_key): Change type.  Move lower.
 543         (get_jit_program_space_data): Update.
 544         (jit_program_space_data_cleanup): Remove.
 545         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 546         Update.
 547         (struct jit_program_space_data): Add initializers.
 548
 549 2019-07-10  Tom Tromey  <tromey@adacore.com>
 550
 551         * solib-darwin.c (struct darwin_info): Add initializers.
 552         (solib_darwin_pspace_data): Change type.
 553         (darwin_pspace_data_cleanup): Remove.
 554         (get_darwin_info, _initialize_darwin_solib): Update.
 555
 556 2019-07-10  Tom Tromey  <tromey@adacore.com>
 557
 558         * remote-sim.c (struct sim_inferior_data): Add initializers,
 559         constructor, and destructor.
 560         (sim_inferior_data_key): Change type.  Move lower.
 561         (check_for_duplicate_sim_descriptor): Update.
 562         (get_sim_inferior_data): Use new.  Update.
 563         (~sim_inferior_data_cleanup): Rename from
 564         sim_inferior_data_cleanup.  Simplify.
 565         (gdbsim_close_inferior, simulator_command)
 566         (sim_command_completer, _initialize_remote_sim): Update.
 567         (next_pid, INITIAL_PID): Move earlier.
 568
 569 2019-07-10  Tom Tromey  <tromey@adacore.com>
 570
 571         * python/python-internal.h (create_thread_object): Return
 572         gdbpy_ref.
 573         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 574         * python/py-inferior.c (struct threadlist_entry): Add
 575         constructor.
 576         <thread_obj>: Now a gdbpy_ref.
 577         (thread_to_thread_object): Update.
 578         (add_thread_object): Use new.
 579         (delete_thread_object): Use delete.
 580         (infpy_threads): Update.
 581         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 582         GIL.
 583
 584 2019-07-10  Tom Tromey  <tromey@adacore.com>
 585
 586         * valops.c (value_cast): Specialize error message for Ada.
 587
 588 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 589
 590         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 591
 592 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 593
 594         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 595         bpstat_should_step): Return bool, adjust comments.
 596         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 597         bpstat_should_step): Likewise.
 598
 599 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 600
 601         * features/Makefile: Use feature target descriptions for Arm.
 602         * features/arm/arm-core.c: Generate new file.
 603         * features/arm/arm-fpa.c: Likewise.
 604         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 605         * features/arm/arm-m-profile.c: Likewise.
 606         * features/arm/arm-vfpv2.c: Likewise.
 607         * features/arm/arm-vfpv3.c: Likewise.
 608         * features/arm/xscale-iwmmxt.c: Likewise.
 609         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 610
 611 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 612
 613         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 614         ptrace earlier.
 615
 616 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 617
 618         * features/aarch64-pauth.c: Regenerate.
 619
 620 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 621
 622         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 623         bool.
 624         (bpstat_what): Use false instead of 0.
 625
 626 2019-07-09  Pedro Alves  <palves@redhat.com>
 627
 628         * break-catch-throw.c (is_exception_catchpoint): New.
 629         * breakpoint.c (print_one_breakpoint_location): New parameter
 630         'raw_loc'.  Handle it.  Use
 631         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 632         looking at the breakpoint's type.
 633         (print_one_breakpoint): If handling "maint info breakpoints", also
 634         print locations of exception catchpoints.
 635         * breakpoint.h (is_exception_catchpoint): Declare.
 636
 637 2019-07-09  Pedro Alves  <palves@redhat.com>
 638
 639         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 640         "addr" field.
 641         (allocate_location_exception_catchpoint): New.
 642         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 643         (initialize_throw_catchpoint_ops): Install
 644         allocate_location_exception_catchpoint as allocate_location
 645         method.
 646         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 647         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 648         bp_loc_other.
 649         (breakpoint_address_is_meaningful): Delete.
 650         (bl_address_is_meaningful): New.
 651         (breakpoint_locations_match): Adjust comment.
 652         (bp_location_from_bp_type): New, factored out of...
 653         (bp_location::bp_location(breakpoint *)): ... this.
 654         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 655         factored out of...
 656         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 657         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 658         breakpoint_address_is_meaningful.
 659         (bp_locations_compare): Adjust comment.
 660         (update_global_location_list): Use bl_address_is_meaningful
 661         instead of breakpoint_address_is_meaningful.
 662         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 663         explicit.
 664         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 665         * python/py-breakpoint.c (bppy_get_location): No longer check
 666         whether location is null.
 667
 668 2019-07-09  Pedro Alves  <palves@redhat.com>
 669
 670         PR c++/15468
 671         * breakpoint.c (print_one_breakpoint_location): Remove
 672         single-location assert.
 673
 674 2019-07-09  Tom Tromey  <tom@tromey.com>
 675
 676         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 677         * configure: Rebuild.
 678         * configure.ac: Change common to gdbsupport.
 679         * gdbsupport: Rename from common.
 680         * acinclude.m4: Change common to gdbsupport.
 681         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 682         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 683         gdbsupport.
 684         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 685         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 686         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 687         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 688         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 689         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 690         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 691         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 692         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 693         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 694         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 695         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 696         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 697         coff-pe-read.c, command.h, compile/compile-c-support.c,
 698         compile/compile-c.h, compile/compile-cplus-symbols.c,
 699         compile/compile-cplus-types.c, compile/compile-cplus.h,
 700         compile/compile-loc2c.c, compile/compile.c, completer.c,
 701         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 702         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 703         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 704         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 705         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 706         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 707         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 708         features/aarch64-core.c, features/aarch64-fpu.c,
 709         features/aarch64-pauth.c, features/aarch64-sve.c,
 710         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 711         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 712         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 713         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 714         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 715         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 716         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 717         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 718         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 719         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 720         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 721         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 722         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 723         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 724         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 725         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 726         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 727         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 728         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 729         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 730         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 731         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 732         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 733         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 734         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 735         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 736         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 737         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 738         minsyms.c, mips-linux-tdep.c, namespace.h,
 739         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 740         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 741         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 742         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 743         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 744         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 745         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 746         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 747         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 748         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 749         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 750         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 751         procfs.c, producer.c, progspace.h, psymtab.h,
 752         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 753         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 754         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 755         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 756         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 757         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 758         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 759         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 760         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 761         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 762         target-memory.c, target.c, target.h, target/waitstatus.c,
 763         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 764         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 765         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 766         unittests/array-view-selftests.c,
 767         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 768         unittests/common-utils-selftests.c,
 769         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 770         unittests/format_pieces-selftests.c,
 771         unittests/function-view-selftests.c,
 772         unittests/lookup_name_info-selftests.c,
 773         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 774         unittests/mkdir-recursive-selftests.c,
 775         unittests/observable-selftests.c,
 776         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 777         unittests/parse-connection-spec-selftests.c,
 778         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 779         unittests/scoped_fd-selftests.c,
 780         unittests/scoped_mmap-selftests.c,
 781         unittests/scoped_restore-selftests.c,
 782         unittests/string_view-selftests.c, unittests/style-selftests.c,
 783         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 784         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 785         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 786         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 787         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 788         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 789
 790 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 791
 792         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 793         bool value.
 794         (decode_digits_ordinary): Set explicit_line field in sal.
 795         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 796         symtab_and_line that was set on an explicit line number in
 797         assembler code.  Do always update the recorded symtab and line if
 798         we do skip the prologue.
 799
 800 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * breakpoint.c (set_breakpoint_location_function): Remove
 803         explicit_loc parameter.
 804         (momentary_breakpoint_from_master): Update call to
 805         set_breakpoint_location_function.
 806         (add_location_to_breakpoint): Likewise.
 807
 808 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 811         required features based on default bfd type when no specific bfd
 812         is present.
 813
 814 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 815
 816         * NEWS: Mention that GDB printf and eval commands can now print
 817         C-style and Ada-style convenience var strings without
 818         calling the inferior.
 819         * printcmd.c (printf_c_string): Locally print GDB internal var
 820         instead of transiting via the inferior.
 821         (printf_wide_c_string): Likewise.
 822
 823 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 824
 825         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 826
 827 2019-07-04  Tom Tromey  <tom@tromey.com>
 828
 829         PR tui/24724:
 830         * tui/tui-winsource.c (tui_clear_source_content): Update.
 831         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 832         (tui_update_breakpoint_info): Update.
 833         (tui_set_exec_info_content): Update.
 834         * tui/tui-source.c (tui_set_source_content_nil): Update.
 835         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 836         has_break.
 837         * tui/tui-data.h (enum tui_bp_flag): New.
 838         (tui_bp_flags): New enum flags type.
 839         (struct tui_source_element) <break_mode>: Change type.  Rename
 840         from has_break.
 841         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 842         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 843         constants.
 844         * tui/tui-winsource.h: Fix comment.
 845
 846 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 847
 848         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 849         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 850         (store_fpregs_to_thread)
 851         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 852         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 853         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 854         (IWMMXT_REGS_SIZE): Add define.
 855         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 856         (fetch_vfp_regs, store_vfp_regs)
 857         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 858         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 859
 860 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 861
 862         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 863         defines.
 864         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 865         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 866         (ARM_INT_REGISTER_SIZE): ...to this.
 867         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 868         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 869         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 870         (arm_linux_collect_gregset, supply_nwfpe_register)
 871         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 872         defines.
 873         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 874         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 875         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 876         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 877         (arm_return_in_memory, arm_store_return_value)
 878         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 879         (arm_record_ld_st_multiple): Likewise.
 880         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 881         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 882
 883 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 884
 885         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 886         AARCH64_DISPLACED_MODIFIED_INSNS.
 887         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 888         (aarch64_displaced_step_copy_insn): Likewise.
 889         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 890         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 891         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 892         ARM_DISPLACED_MODIFIED_INSNS.
 893         * arm-tdep.c (arm_gdbarch_init): Likewise.
 894         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 895         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 896         (struct arm_displaced_step_closure): Use
 897         ARM_DISPLACED_MODIFIED_INSNS.
 898
 899 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 900
 901         * features/Makefile: Remove unused xml files.
 902         * features/aarch64.xml: Remove.
 903         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 904         * features/i386/amd64-avx-avx512.xml: Remove.
 905         * features/i386/amd64-avx-linux.xml: Remove.
 906         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 907         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 908         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 909         * features/i386/amd64-avx-mpx.xml: Remove.
 910         * features/i386/amd64-avx.xml: Remove.
 911         * features/i386/amd64-linux.xml: Remove.
 912         * features/i386/amd64-mpx-linux.xml: Remove.
 913         * features/i386/amd64-mpx.xml: Remove.
 914         * features/i386/amd64.xml: Remove.
 915         * features/i386/i386-avx-avx512-linux.xml: Remove.
 916         * features/i386/i386-avx-avx512.xml: Remove.
 917         * features/i386/i386-avx-linux.xml: Remove.
 918         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 919         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 920         * features/i386/i386-avx-mpx-linux.xml: Remove.
 921         * features/i386/i386-avx-mpx.xml: Remove.
 922         * features/i386/i386-avx.xml: Remove.
 923         * features/i386/i386-linux.xml: Remove.
 924         * features/i386/i386-mmx-linux.xml: Remove.
 925         * features/i386/i386-mmx.xml: Remove.
 926         * features/i386/i386-mpx-linux.xml: Remove.
 927         * features/i386/i386-mpx.xml: Remove.
 928         * features/i386/i386.xml: Remove.
 929         * features/i386/x32-avx-avx512-linux.xml: Remove.
 930         * features/i386/x32-avx-linux.xml: Remove.
 931         * features/i386/x32-linux.xml: Remove.
 932
 933 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 934
 935         * regformats/aarch64.dat: Remove.
 936         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 937         * regformats/i386/amd64-avx-linux.dat: Remove.
 938         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 939         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 940         * regformats/i386/amd64-linux.dat: Remove.
 941         * regformats/i386/amd64-mpx-linux.dat: Remove.
 942         * regformats/i386/amd64.dat: Remove.
 943         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 944         * regformats/i386/i386-avx-linux.dat: Remove.
 945         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 946         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 947         * regformats/i386/i386-linux.dat: Remove.
 948         * regformats/i386/i386-mmx-linux.dat: Remove.
 949         * regformats/i386/i386-mpx-linux.dat: Remove.
 950         * regformats/i386/i386.dat: Remove.
 951         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 952         * regformats/i386/x32-avx-linux.dat: Remove.
 953         * regformats/i386/x32-linux.dat: Remove.
 954
 955 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 956
 957         * aarch64-tdep.c: Remove xml self tests.
 958         * amd64-linux-tdep.c: Likewise.
 959         * amd64-tdep.c: Likewise.
 960         * i386-linux-tdep.c: Likewise.
 961         * i386-tdep.c: Likewise.
 962
 963 2019-07-03  Pedro Alves  <palves@redhat.com>
 964
 965         PR cli/24732
 966         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 967         (pipe_cmd_option_defs): New.
 968         (make_pipe_cmd_options_def_group): New.
 969         (pipe_command): Use gdb::option::process_options.
 970         (pipe_command_completer): New function.
 971         (_initialize_cli_cmds): Install completer for "pipe" command.
 972
 973 2019-07-03  Pedro Alves  <palves@redhat.com>
 974
 975         * cli/cli-option.c (union option_value) <string>: New field.
 976         (struct option_def_and_value): Add ctor, move ctor, dtor and
 977         use DISABLE_COPY_AND_ASSIGN.
 978         (option_def_and_value::clear_value): New.
 979         (parse_option, save_option_value_in_ctx, get_val_type_str)
 980         (add_setshow_cmds_for_options): Handle var_string.
 981         * cli-option.h (union option_def::var_address) <string>: New
 982         field.
 983         (struct string_option_def): New.
 984         * maint-test-options.c (struct test_options_opts): Add default
 985         ctor and use DISABLE_COPY_AND_ASSIGN.
 986         <string_opt>: New field.
 987         (test_options_opts::~test_options_opts): New.
 988         (test_options_opts::dump): Also dump "-string".
 989         (test_options_option_defs): Install "string.
 990
 991 2019-07-03  Pedro Alves  <palves@redhat.com>
 992
 993         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 994         option_value with a null enumeration.
 995         (complete_options): Save the option values in the context.
 996         (save_option_value_in_ctx): New, factored out from ...
 997         (process_options): ... here.
 998         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 999         of the function.
1000         * maint-test-options.c (test_options_opts::dump): New, factored
1001         out from ...
1002         (maintenance_test_options_command_mode): ... here.
1003         (maintenance_test_options_command_completion_result): Delete.
1004         (maintenance_test_options_command_completion_text): Update
1005         comment.
1006         (maintenance_show_test_options_completion_result): Change
1007         prototype.  Just print
1008         maintenance_test_options_command_completion_text.
1009         (save_completion_result): New.
1010         (maintenance_test_options_completer_mode): Pass options context to
1011         complete_options, and then save a dump.
1012         (_initialize_maint_test_options): Use add_cmd to install "maint
1013         show test-options-completion-result".
1014
1015 2019-07-03  Pedro Alves  <palves@redhat.com>
1016
1017         * NEWS (New commands): Mention "with" and "maint with".
1018         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1019         (with_command, with_command_completer): New.
1020         (pipe_command): Adjust to new repeat_previous
1021         interface.
1022         (_initialize_cli_cmds): Install the "with" command and its "w"
1023         alias.
1024         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1025         declarations.
1026         * cli/cli-setshow.c (parse_cli_var_uinteger)
1027         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1028         argument strings for all var_types.
1029         (get_setshow_command_value_string): New, factored out from ...
1030         (do_show_command): ... this.
1031         * cli/cli-setshow.h: Include <string>.
1032         (get_setshow_command_value_string): Declare.
1033         * command.h (repeat_previous): Now returns const char *.  Adjust
1034         comment.
1035         * maint.c: Include "cli/cli-cmds.h".
1036         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1037         (_initialize_maint_cmds): Register the "maintenance with" command.
1038         * top.c (repeat_previous): Move bits from pipe_command here:
1039         Return the saved command line, if any; error out if there's no
1040         command to relaunch.
1041
1042 2019-07-03  Pedro Alves  <palves@redhat.com>
1043
1044         * NEWS (New commands): Mention "maint set/show test-settings"
1045         instead of "maint test-settings".
1046         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1047         (maintenance_test_settings_set_list): Rename to ...
1048         (maintenance_set_test_settings_list): ... this.
1049         (maintenance_test_settings_show_list): Rename to  ...
1050         (maintenance_show_test_settings_list): ... this.
1051         (maintenance_test_settings_cmd): Delete.
1052         (maintenance_test_settings_set_cmd): ...
1053         (maintenance_set_test_settings_cmd): ... this.
1054         (maintenance_test_settings_show_cmd): ...
1055         (maintenance_show_test_settings_cmd): ... this.
1056         (maintenance_test_settings_show_value_cmd):
1057         (maintenance_show_test_settings_value_cmd): ... this.
1058         (_initialize_maint_test_settings): No longer install the "maint
1059         test-settings" prefix command.  Rename "maint test-settings set"
1060         to "maint set test-settings", and "maint test-settings show" to
1061         "maint show test-settings".  Adjust all subcommands.
1062
1063 2019-07-03  Pedro Alves  <palves@redhat.com>
1064
1065         * maint-test-settings.c: Fix file's intro comment.  Replace all
1066         references to "test-options" with references to "test-settings",
1067         in comments.
1068
1069 2019-07-03  Pedro Alves  <palves@redhat.com>
1070
1071         * maint-test-settings.c (maintenance_test_settings_xxx)
1072         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1073         New.
1074         (maintenance_test_settings_enums): Use them.
1075         (maintenance_test_settings_enum): Default to
1076         maintenance_test_settings_xxx.
1077         (_initialize_maint_test_settings): Initialize
1078         MAINTENANCE_TEST_SETTINGS_FILENAME.
1079
1080 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1081
1082         * breakpoint.h (remove_breakpoints_inf): Change return type to
1083         void, move function documentation here.
1084         * breakpoint.c (remove_breakpoints_inf): Change return type to
1085         void, move function documentation to header.
1086
1087 2019-07-02  Pedro Alves  <palves@redhat.com>
1088
1089         * NEWS (Completion improvements): Mention "info threads".
1090         * thread.c (struct info_threads_opts, info_threads_option_defs)
1091         (make_info_threads_options_def_group): New.
1092         (info_threads_command): Use gdb::option::process_options.
1093         (info_threads_command_completer): New.
1094         (_initialize_thread): Use gdb::option::build_help to build the
1095         help text for "info threads".
1096
1097 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1098
1099         * defs.h (generic_load): Move from here...
1100         * symfile.h (generic_load): ... to here.  Rename name parameter
1101         to args.
1102         * symfile.c (generic_load): Add comment.
1103
1104 2019-07-01  Tom Tromey  <tromey@adacore.com>
1105
1106         * dwarf2read.c
1107         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1108         declaration of without_params.  Fix formatting.
1109
1110 2019-07-01  Tom Tromey  <tromey@adacore.com>
1111
1112         * ada-exp.y (find_primitive_type): Update.
1113         * ada-lang.h (ada_lookup_symbol): Update.
1114         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1115         parameter.
1116         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1117
1118 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1119
1120         PR breakpoints/24541
1121         * gdbarch.c: Regenerate.
1122         * gdbarch.h: Regenerate.
1123         * gdbarch.sh: Add 'stap_adjust_register'.
1124         * i386-tdep.c: Include '<unordered_set>'.
1125         (i386_stap_adjust_register): New function.
1126         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1127         * stap-probe.c (stap_parse_register_operand): Call
1128         'gdbarch_stap_adjust_register'.
1129
1130 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1131
1132         PR python/24742
1133         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1134         * python/python.c (do_start_initialization): Use 'xmalloc'
1135         instead of 'PyMem_Malloc'.
1136
1137 2019-06-28  Tom Tromey  <tromey@adacore.com>
1138
1139         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1140         for Ada.
1141
1142 2019-06-27  Tom Tromey  <tromey@adacore.com>
1143
1144         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1145         objfile_key.
1146         (arm_find_mapping_symbol, arm_record_special_symbol)
1147         (_initialize_arm_tdep): Update.
1148         (arm_objfile_data_free): Remove.
1149
1150 2019-06-27  Tom Tromey  <tromey@adacore.com>
1151
1152         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1153         to cp_print_static_field.
1154
1155 2019-06-26  Tom Tromey  <tromey@adacore.com>
1156
1157         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1158         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1159         declare.
1160
1161 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1162
1163         * features/aarch64-core.c (create_feature_aarch64_core):
1164         Regenerate.
1165         * features/aarch64-core.xml: Add cpsr flags.
1166
1167 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1168
1169         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1170         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1171
1172 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1173
1174         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1175         field.
1176         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1177         use.
1178         (arm_record_special_symbol): Don't insert new symbol in sorted
1179         position, push it at the end.
1180
1181 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1182
1183         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1184         (arm_mapping_symbol_s): Remove.
1185         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1186         (arm_mapping_symbol_vec): New typedef.
1187         (struct arm_per_objfile): Add constructor.
1188         <section_maps>: Change type to
1189         std::unique_ptr<arm_mapping_symbol_vec[]>.
1190         (arm_compare_mapping_symbols): Remove.
1191         (arm_find_mapping_symbol): Adjust to section_maps type change.
1192         (arm_objfile_data_free): Call delete on arm_per_objfile.
1193         (arm_record_special_symbol): Adjust to section_maps type change.
1194         Allocate arm_per_objfile with new.
1195
1196 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1197
1198         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1199         with the command prefix.
1200
1201 2019-06-25  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1204         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1205
1206 2019-06-25  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1209         type.
1210         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1211         protected.
1212
1213 2019-06-25  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-winsource.c
1216         (tui_source_window_base::set_is_exec_point_at): Add check against
1217         LOA_ADDRESS.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-source.c (tui_set_source_content): Don't check before
1222         xfree.
1223         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1224
1225 2019-06-25  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-winsource.h (tui_update_source_window_as_is)
1228         (tui_alloc_source_buffer, tui_line_is_displayed)
1229         (tui_addr_is_displayed): Change type of win_info.
1230         * tui/tui-winsource.c (tui_update_source_window_as_is)
1231         (tui_clear_source_content, tui_show_source_line)
1232         (tui_show_source_content, tui_source_window_base::refill)
1233         (tui_source_window_base::set_is_exec_point_at)
1234         (tui_source_window_base::set_is_exec_point_at)
1235         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1236         (tui_alloc_source_buffer, tui_line_is_displayed)
1237         (tui_addr_is_displayed): Change type of win_info.  Update.
1238         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1239         (tui_source_window_base::do_make_visible_with_new_height):
1240         Update.
1241         * tui/tui-source.c (tui_set_source_content)
1242         (tui_set_source_content_nil)
1243         (tui_source_window::do_scroll_vertical): Update.
1244         * tui/tui-layout.c (show_layout): Update.
1245         * tui/tui-disasm.c (tui_set_disassem_content)
1246         (tui_disasm_window::do_scroll_vertical): Update.
1247         * tui/tui-data.h (tui_win_content): Remove.
1248         (struct tui_gen_win_info) <content, content_size>: Remove.
1249         (struct tui_source_element): Add initializers and destructor.
1250         (union tui_which_element, struct tui_win_element): Remove.
1251         (struct tui_source_window_base) <content>: New field.
1252         (struct tui_data_window): Remove destructor.
1253         (tui_alloc_content, tui_free_win_content)
1254         (tui_free_all_source_wins_content): Don't declare.
1255         * tui/tui-data.c (tui_initialize_static_data): Update.
1256         (init_content_element, tui_alloc_content): Remove.
1257         (~tui_gen_win_info): Update.
1258         (~tui_data_window, tui_free_all_source_wins_content)
1259         (tui_free_win_content, free_content, free_content_elements):
1260         Remove.
1261
1262 2019-06-25  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-winsource.h (tui_clear_source_content)
1265         (tui_erase_source_content, tui_show_source_content): Change type
1266         of win_info.
1267         * tui/tui-winsource.c (tui_clear_source_content)
1268         (tui_erase_source_content, tui_show_source_content): Change type
1269         of win_info.
1270         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1271         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1272         win_info.
1273         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1274         win_info.
1275         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1276
1277 2019-06-25  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-winsource.c (tui_clear_source_content)
1280         (tui_source_window_base::set_is_exec_point_at): Update.
1281         * tui/tui-source.c (tui_set_source_content_nil): Update.
1282         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1283         a bool.
1284         * tui/tui-data.c (init_content_element): Update.
1285
1286 2019-06-25  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1289         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1290         * tui/tui-layout.c (init_and_make_win): Update.
1291         * tui/tui.h (enum tui_win_type): Update.
1292         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1293         tui_win_is_auxillary.
1294         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1295         tui_win_is_auxillary.
1296
1297 2019-06-25  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1300         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1301         (tui_delete_data_content_windows, tui_display_all_data)
1302         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1303         Update.
1304         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1305         * tui/tui-regs.c (tui_last_regs_line_no)
1306         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1307         (tui_show_registers): Update.
1308         (tui_show_register_group): Return void.  Update.
1309         (tui_display_registers_from, tui_display_reg_element_at_line)
1310         (tui_display_registers_from_line, tui_check_register_values):
1311         Update.
1312         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1313         member.
1314         (struct tui_data_window) <regs_content>: Now a std::vector.
1315         <regs_content_count>: Remove.
1316         (tui_add_content_elements, tui_free_data_content): Don't declare.
1317         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1318         (init_content_element): Remove DATA_WIN case.  Add assert.
1319         (tui_add_content_elements): Remove.
1320         (tui_data_window): Update.
1321         (tui_free_data_content): Remove.
1322         (free_content_elements): Remove DATA_WIN case.
1323
1324 2019-06-25  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-data.c (tui_data_item_window): Update.
1327         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1328         * tui/tui-windata.c (tui_display_all_data)
1329         (tui_display_data_from_line): Update.
1330         (tui_check_data_values): Remove.
1331         * tui/tui-regs.c (tui_show_register_group)
1332         (tui_display_reg_element_at_line): Update.
1333         * tui/tui-hooks.c (tui_register_changed)
1334         (tui_refresh_frame_and_register_information): Call
1335         tui_check_register_values.
1336         * tui/tui-data.h (struct tui_data_window) <data_content,
1337         data_content_count, data_type>: Remove.
1338         (enum tui_data_type): Remove.
1339
1340         * tui/tui-data.c (tui_data_window::clear_detail)
1341         (~tui_data_window): Update.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1346         declare.
1347         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1348         Rename from tui_first_data_item_displayed.  Update.
1349         (tui_data_window::refresh_all)
1350         (tui_data_window::do_scroll_vertical): Update.
1351         * tui/tui-data.h (struct tui_data_window)
1352         <first_data_item_displayed>: Declare new method.
1353
1354 2019-06-25  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1357         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1358         contents...
1359         (tui_initialize_static_data): ...here.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1364         (tui_display_registers_from, tui_check_register_values): Update.
1365         (tui_display_register): Remove win_info parameter; update.
1366         (tui_get_register): Change type of parameters.
1367         * tui/tui-data.h (struct tui_data_element): Remove.
1368         (union tui_which_element) <data>: Remove.
1369         <data_window>: Change type.
1370         (struct tui_data_item_window): New.
1371         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1372         case.  Add assert.
1373         (~tui_data_item_window): New destructor.
1374         (free_content_elements): Remove DATA_ITEM_WIN case.
1375
1376 2019-06-25  Tom Tromey  <tom@tromey.com>
1377
1378         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1379         Remove.
1380
1381 2019-06-25  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-data.h (struct tui_command_element): Remove.
1384         (union tui_which_element) <command>: Remove.
1385         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1386         assert.
1387         (free_content_elements): Remove CMD_WIN case.
1388
1389 2019-06-25  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-layout.c (tui_set_layout): Update.
1392         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1393         * tui/tui-data.c (layout_def): Update.
1394
1395 2019-06-25  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1398         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1399         (tui_source_window_base::set_new_height): Update.
1400         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1401         Update.
1402         (tui_set_locator_fullname, tui_set_locator_info)
1403         (tui_show_frame_info): Update.
1404         * tui/tui-source.c (tui_set_source_content)
1405         (tui_source_is_displayed): Update.
1406         * tui/tui-layout.c (show_source_disasm_command, show_data)
1407         (show_source_or_disasm_and_command): Update.
1408         * tui/tui-disasm.c (tui_set_disassem_content)
1409         (tui_get_begin_asm_address): Update.
1410         * tui/tui-data.h (struct tui_locator_element): Remove.
1411         (union tui_which_element) <locator>: Remove.
1412         (struct tui_locator_window): New.
1413         (tui_locator_win_info_ptr): Change return type.
1414         * tui/tui-data.c (_locator): Change type.
1415         (tui_locator_win_info_ptr): Change return type.
1416         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1417         (tui_alloc_content): Add assert.
1418
1419 2019-06-25  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-winsource.c
1422         (tui_exec_info_window::maybe_allocate_content): New method.
1423         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1424         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1425         (make_source_or_disasm_window): Add cast.
1426         * tui/tui-data.h (union tui_which_element) <simple_string>:
1427         Remove.
1428         (struct tui_source_info): New.
1429         (struct tui_source_window_base) <execution_info>: Change type.
1430         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1431         case, and add assert.
1432         (tui_alloc_content): Add assert.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1437         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1438         * tui/tui-data.c (tui_alloc_win_info): Remove.
1439
1440 2019-06-25  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1443         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1444         can_highlight.
1445
1446 2019-06-25  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1449         make_visible_with_new_height method.
1450         (tui_win_info::make_visible_with_new_height): New method.
1451         (tui_source_window_base::do_make_visible_with_new_height)
1452         (tui_data_window::do_make_visible_with_new_height)
1453         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1454         (make_visible_with_new_height): Remove.
1455         (tui_resize_all, tui_adjust_win_heights): Use
1456         make_visible_with_new_height method.
1457         * tui/tui-data.h (struct tui_win_info)
1458         <do_make_visible_with_new_height, make_visible_with_new_height>:
1459         New methods.
1460         (struct tui_source_window_base, struct tui_data_window)
1461         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1462         methods.
1463
1464 2019-06-25  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1467         method.
1468         (update_tab_width): Call update_tab_width method.
1469         * tui/tui-data.h (struct tui_win_info)
1470         (struct tui_source_window_base) <update_tab_width>: New methods.
1471
1472 2019-06-25  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1475         parameter.
1476         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1477         parameter.
1478         (tui_gen_win_info::make_visible): Update.
1479         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1480         parameter.
1481         * tui/tui-data.h (enum tui_box): New enum.
1482         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1483
1484 2019-06-25  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1487         init_and_make_win for EXEC_INFO_WIN.
1488         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1489         longer inline.
1490         (struct tui_win_info) <~tui_win_info>: Inline.
1491         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1492         Don't declare.
1493         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1494         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1495         Remove.
1496         (tui_initialize_static_data): Update.
1497         (~tui_gen_win_info): Handle more cleanup here.
1498         (~tui_source_window_base): Delete "execution_info".
1499         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1500
1501 2019-06-25  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-layout.c (make_command_window): Don't set
1504         can_highlight.
1505         (show_source_disasm_command): Call the reset method.
1506         (show_data): Don't set can_highlight.  Call the reset method.
1507         (tui_gen_win_info::reset): Rename from init_gen_win_info
1508         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1509         (show_source_or_disasm_and_command): Call the reset method.
1510         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1511         (struct tui_cmd_window): Set can_highlight.
1512
1513 2019-06-25  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1516         from make_visible.
1517         (tui_make_visible, tui_make_invisible): Rewrite.
1518         (tui_win_info::make_visible): Remove.
1519         (tui_source_window_base::make_visible): Update.
1520         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1521         method.  Moved from...
1522         (struct tui_win_info) <make_visible>: ...here.
1523
1524 2019-06-25  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-winsource.c
1527         (tui_source_window_base::do_scroll_horizontal): Remove direction
1528         parameter.
1529         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1530         direction parameter.
1531         * tui/tui-win.c (tui_win_info::forward_scroll)
1532         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1533         (tui_win_info::right_scroll): Update.
1534         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1535         direction parameter.
1536         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1537         direction parameter.
1538         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1539         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1540         Remove direction parameter.
1541         (struct tui_source_window_base, struct tui_source_window)
1542         (struct tui_disasm_window, struct tui_data_window)
1543         (struct tui_cmd_window): Update.
1544
1545 2019-06-25  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-winsource.h (tui_set_exec_info_content)
1548         (tui_show_exec_info_content, tui_erase_exec_info_content)
1549         (tui_clear_exec_info_content, tui_update_exec_info): Change
1550         argument to tui_source_window_base.
1551         * tui/tui-winsource.c (tui_set_exec_info_content)
1552         (tui_show_exec_info_content, tui_erase_exec_info_content)
1553         (tui_clear_exec_info_content, tui_update_exec_info): Change
1554         argument to tui_source_window_base.
1555
1556 2019-06-25  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1559         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1564         check.
1565
1566 2019-06-25  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1569         type to void.
1570         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1571         type to void.
1572         * tui/tui-source.c (tui_set_source_content): Update.
1573         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1574
1575 2019-06-25  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-win.c (window_name_completer, tui_set_focus)
1578         (tui_all_windows_info): Use name method.
1579         * tui/tui-data.h (struct tui_gen_win_info)
1580         (struct tui_source_window, struct tui_disasm_window)
1581         (struct tui_data_window, struct tui_cmd_window) <name>: New
1582         method.
1583         (tui_win_name): Don't declare.
1584         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1585         (tui_win_name): Remove.
1586
1587 2019-06-25  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-winsource.h (tui_update_source_window)
1590         (tui_update_source_window_as_is): Change parameter type.
1591         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1592         to be a tui_source_window_base.
1593         (tui_update_source_window_as_is): Likewise.
1594         * tui/tui-win.c (make_visible_with_new_height): Update.
1595
1596 2019-06-25  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-winsource.c (tui_erase_source_content)
1599         (tui_show_source_content, tui_show_exec_info_content)
1600         (tui_erase_exec_info_content): Use refresh_window method.
1601         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1602         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1603         from tui_refresh_win.
1604         (tui_data_window::refresh_window): New method.
1605         (tui_win_info::refresh, tui_source_window_base::refresh)
1606         (tui_refresh_all): Use refresh_window method.
1607         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1608         method.
1609         * tui/tui-regs.c (tui_display_register): Call refresh_window
1610         method.
1611         * tui/tui-layout.c (show_source_disasm_command)
1612         (show_source_or_disasm_and_command): Call refresh_window method.
1613         * tui/tui-data.h (struct tui_gen_win_info)
1614         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1615         New method.
1616
1617 2019-06-25  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui.c (tui_rl_other_window, tui_enable)
1620         (tui_is_window_visible, tui_get_command_dimension): Update.
1621         * tui/tui-winsource.c (tui_update_source_window_as_is)
1622         (tui_clear_source_content, tui_erase_source_content)
1623         (tui_show_source_line, tui_source_window_base::refill)
1624         (tui_source_window_base::do_scroll_horizontal)
1625         (tui_source_window_base::set_is_exec_point_at)
1626         (tui_update_breakpoint_info, tui_set_exec_info_content)
1627         (tui_alloc_source_buffer, tui_line_is_displayed)
1628         (tui_addr_is_displayed): Update.
1629         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1630         (tui_check_and_display_highlight_if_needed)
1631         (tui_win_info::make_visible, tui_win_info::refresh)
1632         (tui_refresh_all): Update.
1633         * tui/tui-windata.c (tui_first_data_item_displayed)
1634         (tui_delete_data_content_windows, tui_erase_data_content)
1635         (tui_display_all_data, tui_data_window::refresh_all)
1636         (tui_check_data_values): Update.
1637         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1638         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1639         (tui_win_info::backward_scroll, tui_refresh_all_win)
1640         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1641         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1642         (tui_source_window_base::set_new_height)
1643         (tui_data_window::set_new_height)
1644         (make_invisible_and_set_new_height)
1645         (make_visible_with_new_height, new_height_ok)
1646         (parse_scrolling_args): Update.
1647         * tui/tui-stack.c (tui_show_frame_info): Update.
1648         * tui/tui-source.c (tui_set_source_content)
1649         (tui_set_source_content_nil, tui_source_is_displayed)
1650         (tui_source_window::do_scroll_vertical): Update.
1651         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1652         (tui_display_registers_from, tui_display_reg_element_at_line)
1653         (tui_check_register_values, tui_reg_command): Update.
1654         * tui/tui-layout.c (tui_default_win_height)
1655         (show_source_disasm_command, show_data, init_and_make_win)
1656         (show_source_or_disasm_and_command): Update.
1657         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1658         (tui_redisplay_readline, tui_mld_flush)
1659         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1660         (tui_getc): Update.
1661         * tui/tui-disasm.c (tui_set_disassem_content)
1662         (tui_disasm_window::do_scroll_vertical): Update.
1663         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1664         Now virtual.
1665         (struct tui_win_info): Derive from tui_gen_win_info.
1666         <~tui_win_info>: Mark as override.
1667         <generic>: Remove member.
1668         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1669         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1670         (~tui_data_window, ~tui_win_info)
1671         (tui_free_all_source_wins_content): Update.
1672         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-layout.c (init_and_make_win): Use new.
1677         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1678         destructor, initializers.
1679         (tui_alloc_generic_win_info): Don't declare.
1680         * tui/tui-data.c (_locator): Add argument to constructor.
1681         (source_win, disasm_win): New globals.
1682         (exec_info): Remove.
1683         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1684         Update.
1685         (tui_alloc_generic_win_info): Remove.
1686         (init_content_element): Use new.
1687         (tui_win_info::tui_win_info): Update.
1688         (free_content_elements) <case DATA_WIN>: Use delete.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1693         * tui/tui-windata.c (tui_first_data_item_displayed)
1694         (tui_delete_data_content_windows): Update.
1695         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1696         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1697         (tui_display_registers_from, tui_check_register_values): Update.
1698         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1699         pointer.
1700         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1701         window.
1702         (tui_free_data_content): Update.
1703         (free_content_elements) <case DATA_WIN>: Free the window.
1704
1705 2019-06-25  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1708         Update.
1709         * tui/tui-layout.c (make_command_window)
1710         (show_source_disasm_command, show_data, init_and_make_win)
1711         (show_source_or_disasm_and_command): Update.
1712         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1713         method.
1714         <can_highight, is_highlighted>: Now bool.
1715         (tui_set_win_highlight): Don't declare.
1716         * tui/tui-data.c (tui_set_win_highlight): Remove.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-wingeneral.c (make_visible): Remove check of window
1721         type.
1722
1723 2019-06-25  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-win.c (tui_win_info::max_height)
1726         (tui_cmd_window::max_height): New methods.
1727         (new_height_ok): Call max_height.
1728         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1729         <max_height>: New method.
1730
1731 2019-06-25  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-win.c (tui_source_window_base::set_new_height)
1734         (tui_data_window::set_new_height): New methods.
1735         (make_invisible_and_set_new_height): Call set_new_height method.
1736         * tui/tui-data.h (struct tui_win_info)
1737         (struct tui_source_window_base, struct tui_data_window)
1738         <set_new_height>: New method.
1739
1740 2019-06-25  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1743         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1744         tui_refresh_data_win.
1745         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1746         method.
1747         (tui_refresh_all_win): Call the refresh_all method.
1748         (tui_set_focus): Likewise.
1749         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1750         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1751         Likewise.
1752
1753 2019-06-25  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-winsource.h (tui_refill_source_window)
1756         (tui_set_is_exec_point_at): Don't declare.
1757         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1758         (tui_source_window_base::refill): Rename from
1759         tui_refill_source_window.
1760         (tui_source_window_base::do_scroll_horizontal): Update.
1761         (tui_source_window_base::set_is_exec_point_at): Rename from
1762         tui_set_is_exec_point_at.
1763         (tui_update_all_breakpoint_info): Update.
1764         * tui/tui-stack.c (tui_show_frame_info): Update.
1765         * tui/tui-layout.c (show_data): Add cast.
1766         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1767         * tui/tui-data.h (struct tui_source_window_base) <refill,
1768         set_is_exec_point_at>: New methods.
1769         (tui_source_windows, tui_add_to_source_windows): Update types.
1770         (tui_add_to_source_windows): Remove redundant declaration.
1771         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1772         (tui_source_windows): Change return type.
1773         (tui_clear_source_windows_detail): Update.
1774         (tui_add_to_source_windows): Change type of parameter.
1775         (tui_free_all_source_wins_content): Update.
1776
1777 2019-06-25  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-wingeneral.c (tui_win_info::refresh)
1780         (tui_source_window_base::refresh): New methods.
1781         (tui_refresh_all): Call the refresh method.
1782         * tui/tui-data.h (struct tui_win_info)
1783         (struct tui_source_window_base) <refresh>: New method.
1784
1785 2019-06-25  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui.h (tui_is_window_visible): Return bool.
1788         * tui/tui.c (tui_is_window_visible): Return bool.
1789         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1790         (tui_make_visible, tui_make_invisible)
1791         (tui_win_info::make_visible)
1792         (tui_source_window_base::make_visible, make_all_visible)
1793         (tui_make_all_visible, tui_make_all_invisible): Update.
1794         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1795         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1796         bool.
1797         (struct tui_win_info, struct tui_source_window_base)
1798         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1799         * tui/tui-data.c (tui_init_generic_part): Update.
1800
1801 2019-06-25  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1804         (tui_source_window_base::make_visible): New methods.
1805         (make_all_visible): Make method call.
1806         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1807         (struct tui_source_window_base, struct tui_cmd_window): Override
1808         make_visible.
1809         (tui_win_is_source_type): Don't declare.
1810         * tui/tui-data.c (tui_win_is_source_type): Remove.
1811
1812 2019-06-25  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1815         NULL check.
1816
1817 2019-06-25  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1820         Inline constructor.  Add initializers for members.
1821         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1822         constructors; now inline in class.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-regs.c (tui_show_registers): Update.
1827         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1828         bool.
1829         * tui/tui-data.c (tui_data_window::clear_detail)
1830         (tui_data_window): Update.
1831
1832 2019-06-25  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-windata.c (tui_display_all_data)
1835         (tui_display_data_from_line, tui_display_data_from)
1836         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1837         Update.
1838         * tui/tui-regs.c (tui_last_regs_line_no)
1839         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1840         (tui_show_registers, tui_show_register_group)
1841         (tui_display_registers_from, tui_display_reg_element_at_line)
1842         (tui_display_registers_from_line, tui_check_register_values)
1843         (tui_reg_next, tui_reg_prev): Update.
1844         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1845         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1846         tui_data_window.
1847         (struct tui_win_info) <detail>: Remove.  Add new fields from
1848         tui_data_info.
1849         (TUI_DATA_WIN): Add cast.
1850         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1851         (~tui_data_window): Simplify.
1852
1853 2019-06-25  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-layout.c (show_source_disasm_command)
1856         (show_source_or_disasm_and_command): Update.
1857         * tui/tui-io.c (update_cmdwin_start_line)
1858         (tui_redisplay_readline): Update.
1859         * tui/tui-data.h (struct tui_command_info): Remove.
1860         (struct tui_win_info) <detail>: Remove command_info member.
1861         (struct tui_data_window) <start_line>: New member, from
1862         tui_command_info.
1863         (TUI_CMD_WIN): Add casts.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-winsource.c (tui_update_source_window)
1868         (tui_refill_source_window)
1869         (tui_source_window_base::do_scroll_horizontal)
1870         (tui_update_breakpoint_info, tui_set_exec_info_content)
1871         (tui_show_exec_info_content, tui_erase_exec_info_content)
1872         (tui_clear_exec_info_content): Update.
1873         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1874         Update.
1875         * tui/tui-win.c (make_invisible_and_set_new_height)
1876         (make_visible_with_new_height): Update.
1877         * tui/tui-source.c (tui_set_source_content)
1878         (tui_show_symtab_source): Update.
1879         * tui/tui-layout.c (extract_display_start_addr)
1880         (show_source_disasm_command, show_data)
1881         (make_source_or_disasm_window)
1882         (show_source_or_disasm_and_command): Update.
1883         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1884         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1885         "gdbarch".
1886         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1887         to tui_source_window_base.
1888         (struct tui_win_info) <detail>: Remove source_info member.
1889         (struct tui_source_window_base) <has_locator>: Inline.
1890         Move contents from tui_source_info; rename has_locator member to
1891         m_has_locator.
1892         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1893         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1894         header file.
1895         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1896         Simplify.
1897         (tui_free_all_source_wins_content): Cast to
1898         tui_source_window_base.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-win.c (make_invisible_and_set_new_height)
1903         (make_visible_with_new_height): Call has_locator method.
1904         * tui/tui-layout.c (show_source_disasm_command, show_data)
1905         (show_source_or_disasm_and_command): Update for bool change.
1906         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1907         (tui_win_info) <has_locator>: New method.
1908         (struct tui_source_window_base) <has_locator>: New method.
1909         (tui_win_has_locator): Don't declare.
1910         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1911         from tui_win_has_locator.
1912         (tui_source_window_base): Use false, not FALSE.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1917         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1918         clear_detail method directly.
1919         (tui_clear_win_detail): Remove.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1924         "this", not TUI_DISASM_WIN.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1929         declare.
1930         * tui/tui-winsource.c
1931         (tui_source_window_base::do_scroll_horizontal): Rename from
1932         tui_horizontal_source_scroll.
1933         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1934         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1935         from tui_vertical_data_scroll.
1936         * tui/tui-win.h (tui_scroll): Don't declare.
1937         * tui/tui-win.c (tui_win_info::forward_scroll)
1938         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1939         (tui_win_info::right_scroll): Rename and update.
1940         (tui_scroll_forward_command, tui_scroll_backward_command)
1941         (tui_scroll_left_command, tui_scroll_right_command): Update.
1942         (tui_scroll): Remove.
1943         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1944         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1945         from tui_vertical_source_scroll.
1946         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1947         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1948         from tui_vertical_disassem_scroll.
1949         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1950         do_scroll_horizontal>: New methods.
1951         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1952         Likewise.
1953         (struct tui_source_window_base): Add do_scroll_horizontal.
1954         (struct tui_source_window, struct tui_disasm_window): Add
1955         do_scroll_vertical.
1956         (struct tui_data_window, struct tui_cmd_window): Add
1957         do_scroll_horizontal and do_scroll_vertical.
1958         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1959
1960 2019-06-25  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-data.h (struct tui_source_window_base): New struct.
1963         (struct tui_source_window): Derive from tui_source_window_base.
1964         (struct tui_disasm_window): New struct.
1965         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1966         from tui_source_window::clear_detail.
1967         (tui_source_window_base): Rename from tui_source_window.
1968         (~tui_source_window_base): Rename from ~tui_source_window.
1969         (tui_alloc_win_info): Create a tui_disasm_window.
1970
1971 2019-06-25  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-data.h (struct tui_source_window)
1974         (struct tui_data_window): Declare destructors.
1975         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1976         destructors.
1977         (tui_win_info): Simplify.
1978
1979 2019-06-25  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-winsource.c (tui_display_main)
1982         (tui_update_source_windows_with_addr)
1983         (tui_update_all_breakpoint_info): Update.
1984         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1985         (new_height_ok, parse_scrolling_args): Update.
1986         * tui/tui-stack.c (tui_show_frame_info): Update.
1987         * tui/tui-data.h (struct tui_list): Remove.
1988         (tui_source_windows): Return a reference to a std::vector.
1989         * tui/tui-data.c (source_windows): Now a std::vector.
1990         (tui_source_windows): Change return type.
1991         (tui_clear_source_windows): Rewrite.
1992         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1993         (tui_free_all_source_wins_content): Rewrite.
1994
1995 2019-06-25  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1998         (struct tui_data_window, struct tui_cmd_window): Declare
1999         clear_detail method.
2000         * tui/tui-data.c (tui_source_window::clear_detail)
2001         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2002         methods.
2003         (tui_clear_win_detail): Simplify.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-layout.c (make_source_window, make_disasm_window)
2008         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2009         Return the new window.
2010         (show_source_disasm_command, show_data)
2011         (show_source_or_disasm_and_command): Update.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2016         parameter.  Return the new window.
2017         (show_source_disasm_command): Update and remove NULL check.
2018         (show_source_or_disasm_and_command): Update.
2019
2020 2019-06-25  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-data.h (struct tui_win_info): Make constructor
2027         protected.  Make destructor virtual.  Add initializers.
2028         (tui_source_window, tui_data_window, tui_cmd_window): New
2029         classes.
2030         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2031         constructor.  Add "type" parameter.
2032         (tui_source_window, tui_data_window, tui_cmd_window): New
2033         constructors.
2034         (tui_alloc_win_info): Instantiate the appropriate subclass.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-win.c (tui_resize_all): Use delete.
2039         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2040         destructor.
2041         (tui_free_window): Don't declare.
2042         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2043         Update.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-data.h (struct tui_win_info): Add constructor.
2048         * tui/tui-data.c (tui_alloc_win_info): Use new.
2049         (tui_free_window): Use delete.
2050
2051 2019-06-22  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2054         declare.
2055         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2056
2057 2019-06-22  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2060         declare.
2061         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2062
2063 2019-06-22  Tom de Vries  <tdevries@suse.de>
2064
2065         * dwarf2read.c (create_addrmap_from_aranges)
2066         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2067         instead of '%zu'.
2068
2069 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2070
2071         * dwarf2read.h (dwarf2_section_info_def): Remove.
2072         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2073         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2074         std::vector<dwarf2_section_info>.
2075         (struct dwo_file) <~dwo_file>: Remove.
2076         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2077         types field.
2078         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2079         (dwarf2_read_debug_names): Likewise.
2080         (create_debug_types_hash_table): Change parameter type to
2081         array_view, adjust code accordingly.
2082         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2083         (partial_die_info::fixup): Likewise.
2084         (determine_prefix): Likewise.
2085         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2086
2087 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2088
2089         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2090         gdb_bfd_ref_ptr.
2091         <~dwo_file>: Remove call to gdb_bfd_unref.
2092         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2093         gdb_bfd_ref_ptr::get.
2094
2095 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2096
2097         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2098         type to htab_up.
2099         * dwarf2read.c (struct dwo_file): Initialize fields.
2100         <~dwo_file>: New.
2101         (free_dwo_file): Remove, move content to ~dwo_file.
2102         (struct dwo_file_deleter): Remove.
2103         (dwo_file_up>: Remove custom deleter.
2104         (free_dwo_files): Remove.
2105         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2106         dwo_files.
2107         (process_skeletonless_type_units): Call unique_ptr::get.
2108         (allocate_dwo_file_hash_table): Add deleter to created hash
2109         table.  Change return type to htab_up.
2110         (lookup_dwo_file_slot): Don't memset dwo_file, call
2111         unique_ptr::get.
2112         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2113         (create_dwo_unit_in_dwp_v2): Likewise.
2114         (open_and_init_dwo_file): Likewise.
2115         (free_dwo_file_from_slot): Remove.
2116
2117 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2118
2119         * dwarf2read.h (struct dwarf2_section_info) <readin,
2120         is_virtual>: Change type to bool.
2121         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2122         true instead of 1.
2123
2124 2019-06-19  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-data.h (tui_init_content_element): Don't declare.
2127
2128 2019-06-19  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-data.h (tui_init_win_info): Don't declare.
2131
2132 2019-06-19  Tom de Vries  <tdevries@suse.de>
2133
2134         * dwarf2read.h (abstract_to_concrete): Change type to
2135         std::unordered_map<sect_offset, std::vector<sect_offset>,
2136         gdb::hash_enum<sect_offset>>.
2137
2138 2019-06-19  Tom Tromey  <tromey@adacore.com>
2139
2140         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2141         EVAL_AVOID_SIDE_EFFECTS specially.
2142
2143 2019-06-19  Tom Tromey  <tromey@adacore.com>
2144
2145         * source-cache.c (highlighter): New global.
2146         (source_cache::get_source_lines): Create a highlighter on demand.
2147
2148 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * defs.h (deprecated_interactive_hook): Delete declaration.
2151         * interps.c (clear_interpreter_hooks): Remove use of
2152         deprecated_interactive_hook.
2153         * top.c (deprecated_interactive_hook): Delete definition.
2154         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2155
2156 2019-06-18  Tom de Vries  <tdevries@suse.de>
2157
2158         PR gdb/24515
2159         * dwarf2read.h (abstract_to_concrete): Change type from
2160         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2161         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2162         * dwarf2read.c (read_variable): Update.
2163         (dwarf2_fetch_die_loc_sect_off): Update.
2164
2165 2019-06-17  Tom de Vries  <tdevries@suse.de>
2166
2167         PR gdb/24617
2168         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2169         accessing parent[parent_len - 1].
2170
2171 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2172
2173         PR gdb/24364
2174         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2175         call dtrace_process_dof with NULL dof.
2176
2177 2019-06-16  Tom de Vries  <tdevries@suse.de>
2178
2179         PR gdb/24445
2180         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2181
2182 2019-06-16  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2185         (make_all_visible): Use address of member.
2186
2187 2019-06-16  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2190         (tui_free_window, free_content, free_content_elements): Remove
2191         unnecessary cast.
2192         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2193         cast.
2194         * tui/tui-regs.c (tui_show_register_group)
2195         (tui_display_registers_from, tui_display_reg_element_at_line):
2196         Remove unnecessary cast.
2197
2198 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * linux-nat.c (normal_mask): Delete.
2201         (_initialize_linux_nat): Don't initialise normal_mask.
2202
2203 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2204
2205         PR gdb/24445
2206         * dwarf-index-write.h (write_psymtabs_to_index): Add
2207         dwz_basename parameter.
2208         * dwarf-index-write.c (write_gdbindex): Move file writing to
2209         write_gdbindex_1.  Change return type void.
2210         (assert_file_size): Move up, remove filename parameter.
2211         (write_gdbindex_1): New function.
2212         (write_debug_names): Change return type to void, call
2213         assert_file_size.
2214         (struct index_wip_file): New struct.
2215         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2216         file logic to index_wip_file.  Write index for dwz file if
2217         needed.
2218         (save_gdb_index_command): Pass basename of dwz file, if present.
2219         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2220         build-id of dwz file, if present.
2221         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2222         (dwarf2_get_dwz_file): Likewise.
2223         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2224         (dwarf2_get_dwz_file): Likewise.
2225
2226 2019-06-16  Tom Tromey  <tom@tromey.com>
2227
2228         * coffread.c (process_coff_symbol): Use xstrdup.
2229         * value.c (create_internalvar): Use xstrdup.
2230
2231 2019-06-16  Tom Tromey  <tom@tromey.com>
2232
2233         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2234         * breakpoint.c (stopin_command, stopat_command)
2235         (until_break_command, decode_location_default): Remove unnecessary
2236         cast.
2237         * utils.c (subset_compare): Remove unnecessary cast.
2238         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2239         cast.
2240         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2241         cast.
2242         * infcmd.c (path_command): Remove unnecessary cast.
2243         * coffread.c (decode_type): Remove unnecessary cast.
2244         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2245         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2246         * tui/tui-stack.c (tui_show_locator_content)
2247         (tui_show_frame_info): Remove unnecessary cast.
2248         * tui/tui-win.c (tui_scroll_forward_command)
2249         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2250         (parse_scrolling_args): Remove unnecessary cast.
2251         * tui/tui-data.c (init_win_info, tui_del_window)
2252         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2253         (free_content_elements): Remove unnecessary cast.
2254         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2255         unnecessary cast.
2256         * tui/tui-source.c (tui_set_source_content)
2257         (tui_vertical_source_scroll): Remove unnecessary cast.
2258         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2259         cast.
2260         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2261         * tui/tui-regs.c (tui_display_registers_from)
2262         (tui_display_register): Remove unnecessary cast.
2263         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2264         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2265         (make_visible): Remove unnecessary cast.
2266         * tui/tui-winsource.c (tui_erase_source_content)
2267         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2268         unnecessary cast.
2269         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2270         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2271         * stabsread.c (read_type, read_array_type, read_range_type):
2272         Remove unnecessary cast.
2273         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2274         (parse_symbol, parse_type, upgrade_type, parse_external)
2275         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2276         unnecessary cast.
2277         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2278
2279 2019-06-16  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-data.c (tui_alloc_generic_win_info)
2282         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2283         checks.
2284
2285 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2286             Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * f-typeprint.c (f_print_type): Don't return early for not
2289         associated or not allocated types.
2290         (f_type_print_varspec_suffix): Add print_rank parameter and print
2291         ranks of array types in case they dangling.
2292         (f_type_print_base): Add print_rank parameter.
2293
2294 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * NEWS: Mention new MI commands.
2297         * break-catch-throw.c (enum exception_event_kind): Move to
2298         breakpoint.h.
2299         (print_mention_exception_catchpoint): Output text as a single
2300         message.
2301         (catch_exception_command_1): Rename to...
2302         (catch_exception_event): ...this, make non-static, update header
2303         command, and change some parameter types.
2304         (catch_catch_command): Update for changes to
2305         catch_exception_command_1.
2306         (catch_throw_command): Likewise.
2307         (catch_rethrow_command): Likewise.
2308         * breakpoint.c (enum exception_event_kind): Delete.
2309         * breakpoint.h (enum exception_event_kind): Moved here from
2310         break-catch-throw.c.
2311         (catch_exception_event): Declare.
2312         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2313         (mi_cmd_catch_throw): New function.
2314         (mi_cmd_catch_rethrow): New function.
2315         (mi_cmd_catch_catch): New function.
2316         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2317         'catch-catch' entries.
2318         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2319         (mi_cmd_catch_rethrow): Declare.
2320         (mi_cmd_catch_catch): Declare.
2321
2322 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2323
2324         * annotate.c (annotate_source_line): Change return type to void,
2325         update implementation to match.
2326         * annotate.h (annotate_source_line): Change return type to void,
2327         update header comment.
2328         * stack.c (print_frame_info): Don't change what frame information
2329         is printed based on whether annotations are on or not.
2330
2331 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2334         (annotate_source): Make static.
2335         (annotate_source_line): Moved from source.c and renamed from
2336         identify_source_line.  Update the return type.
2337         * annotate.h (annotate_source): Delete declaration.
2338         (annotate_source_line): Declaration moved from source.h, and
2339         renamed from identify_source_line.  Return type updated.
2340         * source.c (identify_source_line): Moved to annotate.c and renamed
2341         to annotate_source_line.
2342         (info_line_command): Remove check of annotation_level.
2343         * source.h (identify_source_line): Move declaration to annotate.h
2344         and rename to annotate_source_line.
2345         * stack.c: Add 'annotate.h' include.
2346         (print_frame_info): Remove check of annotation_level before
2347         calling annotate_source_line.
2348
2349 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2350
2351         * source-cache.c (source_cache::get_plain_source_lines): Use
2352         open_source_file_with_line_charpos instead of just
2353         open_source_file, remove call to find_source_lines.
2354         (source_cache::get_source_lines): Likewise.
2355         * source.c (find_source_lines): Make static.
2356         (get_filename_and_charpos): Renamed into...
2357         (open_source_file_with_line_charpos): ..this along with changes to
2358         return a scoped_fd, and some other minor clean ups.
2359         (identify_source_line): Use open_source_file_with_line_charpos.
2360         (search_command_helper): Use open_source_file_with_line_charpos
2361         instead of just open_source_file, remove call to
2362         find_source_lines.
2363         * source.h (open_source_file_with_line_charpos): Declare new
2364         function.
2365         (find_source_lines): Delete declaration.
2366
2367 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * source.c (get_filename_and_charpos): Remove fullname
2370         parameter.
2371         (identify_source_line): Update call to get_filename_and_charpos.
2372
2373 2019-06-14  Tom Tromey  <tromey@adacore.com>
2374
2375         PR gdb/24502:
2376         * ui-style.h (skip_ansi_escape): Update comment.
2377         * ui-file.h (class no_terminal_escape_file): New class.
2378         * ui-file.c (no_terminal_escape_file::write)
2379         (no_terminal_escape_file::puts): New methods.
2380         * cli/cli-logging.c (handle_redirections): Use
2381         no_terminal_escape_file.
2382
2383 2019-06-14  Tom Tromey  <tromey@adacore.com>
2384
2385         * NEWS: Move convenience variable news above Python news.
2386
2387 2019-06-14  Tom Tromey  <tom@tromey.com>
2388
2389         * gnulib: Move directory to top-level.
2390         * configure.ac: Don't configure gnulib.
2391         * configure: Rebuild.
2392         * common/common-defs.h: Use new path to gnulib.
2393         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2394         (GNULIB_H): Remove.
2395         (INCGNU): Look in new gnulib location.
2396         (HFILES_NO_SRCDIR): Remove gnulib files.
2397         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2398         (generated_files): Remove GNULIB_H.
2399         ($(LIBGNU), all-lib): Remove targets.
2400         (distclean): Don't mention GNULIB_BUILDDIR.
2401         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2402
2403 2019-06-14  Tom Tromey  <tromey@adacore.com>
2404
2405         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2406         Warn if symbol file does not provide any symbols.
2407
2408 2019-06-14  Tom Tromey  <tromey@adacore.com>
2409
2410         * source.c (find_and_open_source): Respect basenames_may_differ.
2411
2412 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2413
2414         * annotate.c (annotate_breakpoints_invalid): Make use of
2415         scoped_restore_terminal_state.
2416         (annotate_frames_invalid): Likewise.
2417
2418 2019-06-14  Tom Tromey  <tromey@adacore.com>
2419
2420         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2421         allow assignment to an internalvar.
2422
2423 2019-06-14  Tom Tromey  <tromey@adacore.com>
2424
2425         * ada-lex.l: Allow "_" in attribute names.
2426
2427 2019-06-14  Tom Tromey  <tromey@adacore.com>
2428
2429         PR gdb/24653:
2430         * regcache.c (registers_changed): Don't call alloca.
2431         * top.c (execute_command): Don't call alloca.
2432
2433 2019-06-13  Pedro Alves  <palves@redhat.com>
2434
2435         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2436         'expression'.  When parsing an expression, error out if there's
2437         junk after "unlimited".
2438         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2439         (do_set_command): Adjust calls to is_unlimited_literal.
2440
2441 2019-06-13  Pedro Alves  <palves@redhat.com>
2442
2443         * compile/compile.c (make_compile_options_def_group): Add braces
2444         around array_view initializer.
2445         * thread.c (make_thread_apply_all_options_def_group)
2446         (make_thread_apply_all_options_def_group): Likewise.
2447
2448 2019-06-13  Pedro Alves  <palves@redhat.com>
2449
2450         * NEWS (New commands): Mention "maint test-options
2451         require-delimiter", "maint test-options unknown-is-error", "maint
2452         test-options unknown-is-operand" and "maint show
2453         test-options-completion-result".
2454         (New command options, command completion): New section.
2455         (Completion improvements): New section.
2456         Mention that you can abbreviate "unlimited".
2457
2458 2019-06-13  Pedro Alves  <palves@redhat.com>
2459
2460         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2461         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2462         * unittests/cli-utils-selftests.c (test_parse_flags)
2463         (test_parse_flags_qcs): Delete.
2464         (test_cli_utils): Don't call deleted functions.
2465
2466 2019-06-13  Pedro Alves  <palves@redhat.com>
2467
2468         * thread.c: Include "cli/cli-option.h".
2469         (tp_array_compar_ascending): Global.
2470         (tp_array_compar): Delete function.
2471         (tp_array_compar_ascending, tp_array_compar_descending): New
2472         functions.
2473         (ascending_option_def, qcs_flag_option_def)
2474         (thr_qcs_flags_option_defs)
2475         (make_thread_apply_all_options_def_group)
2476         (make_thread_apply_options_def_group): New.
2477         (thread_apply_all_command): Use gdb::option::process_options.
2478         (thread_apply_command_completer)
2479         (thread_apply_all_command_completer): New.
2480         (thread_apply_command): Use gdb::option::process_options.
2481         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2482         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2483         to generate help text of "thread apply".  Adjust "taas"'s help.
2484         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2485         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2486
2487 2019-06-13  Pedro Alves  <palves@redhat.com>
2488
2489         * thread.c (thread_apply_command): Check for invalid TID with
2490         isdigit instead of !isalpha.
2491
2492 2019-06-13  Pedro Alves  <palves@redhat.com>
2493
2494         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2495         (validate_flags_qcs): New.
2496         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2497         (validate_flags_qcs): Declare.
2498         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2499         (make_frame_apply_options_def_group): New.
2500         (frame_apply_command_count): Process options with
2501         gdb::option::process_options.
2502         (frame_apply_completer): New.
2503         (frame_apply_level_completer, frame_apply_all_completer)
2504         (frame_apply_completer): New.
2505         (_initialize_stack): Update help of "frame apply", "frame apply
2506         level", "frame apply all" and "faas" to mention supported options
2507         and install command completers.
2508         * stack.h (frame_apply_all_completer): Declare.
2509         * thread.c: Include "stack.h".
2510         (tfaas_command): Add "--".
2511         (_initialize_thread): Update help "tfaas" to mention supported
2512         options and install command completer.
2513
2514 2019-06-13  Pedro Alves  <palves@redhat.com>
2515
2516         * completer.c (complete_nested_command_line): New.
2517         (gdb_completion_word_break_characters_throw): Add assertion.
2518         * completer.h (complete_nested_command_line): Declare.
2519
2520 2019-06-13  Pedro Alves  <palves@redhat.com>
2521
2522         * stack.c (parse_backtrace_qualifiers): New.
2523         (backtrace_command): Use it.
2524         (backtrace_command_completer): Complete on qualifiers.
2525
2526 2019-06-13  Pedro Alves  <palves@redhat.com>
2527
2528         * frame.c: Include "cli/cli-option.h.
2529         (user_set_backtrace_options): New.
2530         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2531         Delete.
2532         (get_prev_frame): Adjust.
2533         (boolean_option_def, uinteger_option_def)
2534         (set_backtrace_option_defs): New.
2535         (_initialize_frame): Adjust and use
2536         gdb::option::add_setshow_cmds_for_options to install "set
2537         backtrace past-main" and "set backtrace past-entry".
2538         * frame.h: Include "cli/cli-option.h".
2539         (struct frame_print_options): Forward declare.
2540         (print_frame_arguments_all, print_frame_arguments_scalars)
2541         (print_frame_arguments_none): Declare.
2542         (print_entry_values): Delete declaration.
2543         (struct frame_print_options, user_frame_print_options): New.
2544         (struct set_backtrace_options): New.
2545         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2546         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2547         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2548         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2549         (list_args_or_locals): Add frame_print_options parameter.
2550         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2551         * python/py-framefilter.c (enumerate_args): Pass down
2552         USER_FRAME_PRINT_OPTIONS.
2553         * stack.c: Include "cli/cli-option.h".
2554         (print_frame_arguments_all, print_frame_arguments_scalars)
2555         (print_frame_arguments_none): Declare.
2556         (print_raw_frame_arguments, print_entry_values): Delete.
2557         (user_frame_print_options): New.
2558         (boolean_option_def, enum_option_def, frame_print_option_defs):
2559         New.
2560         (struct backtrace_cmd_options): New.
2561         (bt_flag_option_def): New.
2562         (backtrace_command_option_defs): New.
2563         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2564         (print_frame_arg, read_frame_arg, print_frame_args)
2565         (print_frame_info, print_frame): Add frame_print_options parameter
2566         and use it.
2567         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2568         (backtrace_command_1): Add frame_print_options and
2569         backtrace_cmd_options parameters and use them.
2570         (make_backtrace_options_def_group): New.
2571         (backtrace_command): Process command options with
2572         gdb::option::process_options.
2573         (backtrace_command_completer): New.
2574         (_initialize_stack): Extend "backtrace"'s help to mention
2575         supported options.  Install completer for "backtrace".
2576         Install some settings commands with add_setshow_cmds_for_options.
2577
2578 2019-06-13  Pedro Alves  <palves@redhat.com>
2579
2580         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2581         and that "set/show print raw frame-arguments" are now deprecated.
2582
2583         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2584         command.
2585         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2586         * stack.c (_initialize_stack): Install "set/show print
2587         raw-frame-arguments", and deprecate "set/show print raw
2588         frame-arguments".
2589         * valprint.c (_initialize_valprint): Deprecate "set/show print
2590         raw".
2591
2592 2019-06-13  Pedro Alves  <palves@redhat.com>
2593
2594         * compile/compile.c (struct compile_options): New.
2595         (compile_flag_option_def, compile_command_option_defs)
2596         (make_compile_options_def_group): New.
2597         (compile_file_command): Handle options with
2598         gdb::option::process_options.
2599         (compile_file_command_completer): New function.
2600         (compile_code_command): Handle options with
2601         gdb::option::process_options.
2602         (compile_code_command_completer): New function.
2603         (_initialize_compiler): Install completers for "compile code" and
2604         "compile file".  Mention available options in "compile code" and
2605         "compile code"'s help.
2606         * completer.c (advance_to_completion_word): New, factored out from
2607         ...
2608         (advance_to_expression_complete_word_point): ... this.
2609         (advance_to_filename_complete_word_point): New.
2610         * completer.h (advance_to_filename_complete_word_point): New
2611         declaration.
2612
2613 2019-06-13  Pedro Alves  <palves@redhat.com>
2614
2615         * compile/compile.c: Include "cli/cli-option.h".
2616         (compile_print_value): Scope data pointer is now a
2617         value_print_options pointer; adjust.
2618         (compile_print_command): Process options.  Scope data pointer is
2619         now a value_print_options pointer; adjust.
2620         (_initialize_compile): Update "compile print"'s help to include
2621         supported options.  Install a completer for "compile print".
2622         * cp-valprint.c (show_vtblprint, show_objectprint)
2623         (show_static_field_print): Delete.
2624         (_initialize_cp_valprint): Don't install "set print
2625         static-members", "set print vtbl", "set print object" here.
2626         * printcmd.c: Include "cli/cli-option.h" and
2627         "common/gdb_optional.h".
2628         (print_command_parse_format): Rework to fill in a
2629         value_print_options instead of a format_data.
2630         (print_value): Change parameter type from format_data pointer to
2631         value_print_options reference.  Adjust.
2632         (print_command_1): Process options.  Adjust to pass down a
2633         value_print_options.
2634         (print_command_completer): New.
2635         (_initialize_printcmd): Install print_command_completer as
2636         handle_brkchars completer for the "print" command.  Update
2637         "print"'s help to include supported options.
2638         * valprint.c: Include "cli/cli-option.h".
2639         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2640         here from cp-valprint.c.
2641         (boolean_option_def, uinteger_option_def)
2642         (value_print_option_defs, make_value_print_options_def_group):
2643         New.  Use gdb::option::add_setshow_cmds_for_options to install
2644         "set print elements", "set print null-stop", "set print repeats",
2645         "set print pretty", "set print union", "set print array", "set
2646         print address", "set print symbol", "set print array-indexes".
2647         * valprint.h: Include <string> and "cli/cli-option.h".
2648         (make_value_print_options_def_group): Declare.
2649         (print_value): Change parameter type from format_data pointer to
2650         value_print_options reference.
2651         (print_command_completer): Declare.
2652
2653 2019-06-13  Pedro Alves  <palves@redhat.com>
2654
2655         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2656         (COMMON_SFILES): Add maint-test-settings.c.
2657         * cli/cli-decode.c (boolean_enums): New global, factored out from
2658         ...
2659         (add_setshow_boolean_cmd): ... here.
2660         * cli/cli-decode.h (boolean_enums): Declare.
2661         * cli/cli-option.c: New file.
2662         * cli/cli-option.h: New file.
2663         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2664         factored out from ...
2665         (parse_cli_boolean_value(const char *)): ... this.
2666         (is_unlimited_literal): Change parameter type to pointer to
2667         pointer.  Adjust and advance ARG pointer.
2668         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2669         (parse_cli_var_enum): New, factored out from ...
2670         (do_set_command): ... this.  Adjust.
2671         * cli/cli-setshow.h (parse_cli_boolean_value)
2672         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2673         (parse_cli_var_enum): Declare.
2674         * cli/cli-utils.c: Include "cli/cli-option.h".
2675         (get_ulongest): New.
2676         * cli/cli-utils.h (get_ulongest): Declare.
2677         (check_for_argument): New overloads.
2678         * maint-test-options.c: New file.
2679
2680 2019-06-13  Pedro Alves  <palves@redhat.com>
2681
2682         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2683         parse a range if "-" is at the end of the string.
2684
2685 2019-06-13  Pedro Alves  <palves@redhat.com>
2686
2687         * cli/cli-setshow.c (parse_auto_binary_operation)
2688         (parse_cli_boolean_value): Don't allow "o".
2689
2690 2019-06-13  Pedro Alves  <palves@redhat.com>
2691
2692         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2693         * NEWS: Mention maint test-settings KIND.
2694         * maint-test-settings.c: New file.
2695
2696 2019-06-13  Pedro Alves  <palves@redhat.com>
2697
2698         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2699         completer.
2700         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2701         "set" completers.
2702
2703 2019-06-13  Pedro Alves  <palves@redhat.com>
2704
2705         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2706         after item.
2707
2708 2019-06-13  Pedro Alves  <palves@redhat.com>
2709
2710         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2711
2712 2019-06-13  Pedro Alves <palves@redhat.com>
2713
2714         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2715         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2716         call.
2717         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2718         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2719         calls.
2720         (check_for_argument): Skip spaces after argument.
2721
2722 2019-06-13  Pedro Alves  <palves@redhat.com>
2723
2724         * thread.c (thread_apply_command): Adjust TID parsing.
2725         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2726         detected before end of string.
2727         (tid_is_in_list): Error out if LIST is invalid.
2728
2729 2019-06-13  Pedro Alves  <palves@redhat.com>
2730
2731         * completer.c (complete_line_internal_1): Rewind completion word
2732         point.
2733         (completion_tracker::advance_custom_word_point_by): Change
2734         parameter type to int.
2735         * completer.h (completion_tracker::advance_custom_word_point_by):
2736         Likewise.
2737
2738 2019-06-13  Pedro Alves  <palves@redhat.com>
2739
2740         * completer.c (advance_to_completion_word): Handle delimiters.
2741
2742 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2743
2744         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2745
2746 2019-06-11  Tom Tromey  <tom@tromey.com>
2747
2748         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2749         (xmalloc_failed): Move to alloc.c.
2750         * alloc.c: New file.
2751         * Makefile.in (COMMON_SFILES): Add alloc.c.
2752
2753 2019-06-11  Tom Tromey  <tom@tromey.com>
2754
2755         * nat/linux-waitpid.c: Don't include server.h.
2756         (linux_debug): Remove.
2757         (my_waitpid): Update.
2758
2759 2019-06-11  Tom Tromey  <tromey@adacore.com>
2760
2761         * infcall.c (_initialize_infcall): Remove trailing newline from
2762         help.
2763         * user-regs.c (_initialize_user_regs): Remove trailing newline
2764         from help.
2765         * typeprint.c (_initialize_typeprint): Remove trailing newline
2766         from help.
2767         * reverse.c (_initialize_reverse): Remove trailing newlines from
2768         help.
2769         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2770         from help.
2771         * language.c (add_set_language_command): Remove trailing newline
2772         from help.
2773         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2774         help.
2775         * disasm.c (_initialize_disasm): Remove trailing newline from
2776         help.
2777         * top.c (init_main): Remove trailing newline from help.
2778         * interps.c (_initialize_interpreter): Remove trailing newline
2779         from help.
2780         * btrace.c (_initialize_btrace): Remove trailing newlines from
2781         help.
2782         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2783         from help.
2784         * python/python.c (_initialize_python): Remove trailing newline
2785         from help.
2786         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2787         help.
2788         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2789         from help.  Reformat some text.
2790         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2791         from help.
2792         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2793         newline from help.
2794
2795 2019-06-11  Tom Tromey  <tromey@adacore.com>
2796
2797         * darwin-nat.c (darwin_decode_exception_message)
2798         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2799
2800 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * valops.c (value_slice): Check for not allocated or not
2803         associated values.
2804
2805 2019-06-10  Tom de Vries  <tdevries@suse.de>
2806
2807         PR gdb/24618
2808         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2809         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2810         invalid.
2811
2812 2019-06-10  Tom de Vries  <tdevries@suse.de>
2813
2814         PR gdb/24611
2815         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2816         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2817
2818 2019-06-10  Tom de Vries  <tdevries@suse.de>
2819
2820         PR symtab/24545
2821         * symtab.c (struct demangled_name_entry): Add language field.
2822         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2823         static minimal symbol".  Set and use language field.
2824
2825 2019-06-10  Tom Tromey  <tromey@adacore.com>
2826
2827         * ada-lang.c (_initialize_ada_language): Update help text.
2828
2829 2019-06-10  Tom Tromey  <tromey@adacore.com>
2830
2831         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2832         with a newline.
2833         * guile/guile.c (handle_boot_error): Don't end warning with a
2834         newline.
2835         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2836         warning with a newline.
2837         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2838         newline.
2839         (s12z_frame_cache): Likewise.
2840         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2841         a newline.
2842         * solib-svr4.c (disable_probes_interface): Don't end warning with
2843         a newline.
2844         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2845         newline.
2846         * python/python.c (do_finish_initialization): Don't end warning
2847         with a newline.
2848
2849 2019-06-10  Tom Tromey  <tom@tromey.com>
2850
2851         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2852         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2853         gdbpy_enter.
2854
2855 2019-06-10  Tom Tromey  <tromey@adacore.com>
2856
2857         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2858         data.
2859         (elf_new_init): Don't call stabsread_new_init.
2860         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2861         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2862         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2863
2864 2019-06-10  Tom de Vries  <tdevries@suse.de>
2865
2866         PR symtab/16264
2867         PR symtab/24517
2868         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2869
2870 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2871
2872         * source.c (find_and_open_source): Also rewrite relative file
2873         names.
2874
2875 2019-04-26  Amos Bird  <amosbird@gmail.com>
2876
2877         * annotate.c (annotate_thread_exited): Add "thread-exited"
2878         annotation.
2879
2880 2019-06-06  Tom Tromey  <tromey@adacore.com>
2881
2882         * maint.h (class scoped_command_stats): Use
2883         DISABLE_COPY_AND_ASSIGN.
2884         <print_time>: New method.
2885         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2886         print_time.
2887         (scoped_command_stats::print_time): New method.
2888
2889 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2892         instructions of lengths 6 or 8 bytes.
2893
2894 2019-06-04  Pedro Alves  <palves@redhat.com>
2895
2896         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2897
2898         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2899         * breakpoint.c (condition_completer): Likewise.
2900         * cli/cli-dump.c (scan_expression): Likewise.
2901         * common/filestuff.c (mkdir_recursive): Likewise.
2902         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2903         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2904         (gdb_abspath): Likewise.
2905         * compile/compile-cplus-types.c
2906         (compile_cplus_instance::decl_name): Likewise.
2907         * completer.c (complete_explicit_location):
2908         (signal_completer, reg_or_group_completer_1): Likewise.
2909         * cp-support.c (cp_remove_params_if_any): Likewise.
2910         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2911         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2912         * infcmd.c (strip_bg_char): Likewise.
2913         * linespec.c (copy_token_string): Likewise.
2914         * mi/mi-main.c (output_cores): Likewise.
2915         * psymtab.c (psymtab_search_name):
2916         * symfile.c (test_set_ext_lang_command): Likewise.
2917         * target.c (target_fileio_read_stralloc): Likewise.
2918         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2919         * value.c (complete_internalvar): Likewise.
2920
2921 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2922
2923         Add objfile property to gdb.Type.
2924         * NEWS: Mention Python API addition.
2925         * python/py-type.c (typy_get_objfile): New method.
2926
2927 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2928
2929         * NEWS: Mention the new set|show style [title|highlight].
2930         Mention changes to "show style", "help" and "apropos".
2931
2932 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2933
2934         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2935         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2936         instead of print_help_for_command.
2937         (print_doc_of_command): New function.
2938         (help_list): Add 'apropos -v word' suggestion.
2939         (print_help_for_command): Style the command name using title style.
2940         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2941         (_initialize_cli_cmds): Describe -v in apropos_command help.
2942
2943 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2944
2945         * cli/cli-style.h (cli_style_option): Add name in constructor,
2946         add m_name class member, add constructor with intensity,
2947         add name class function.
2948         (cli_style_option::add_setshow_commands): Remove name argument.
2949         (highlight_style, title_style): New styles.
2950         * cli/cli-style.c (do_show): New function that shows a style
2951         characteristic styling the style name with itself.
2952         (set_style_name): New function.
2953         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2954         Update all callers according to the changes in cli/cli-style.h.
2955         * utils.h (fputs_highlighted): New function.
2956         * utils.c (fputs_highlighted): Likewise.
2957
2958 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2959
2960         * NEWS: Mention new pipe command and new convenience variables.
2961
2962 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2963
2964         * cli/cli-cmds.c (pipe_command): New function.
2965         (_initialize_cli_cmds): Call add_com for pipe_command.
2966         Define | as an alias for pipe.
2967         (exit_status_set_internal_vars): New function.
2968         (shell_escape): Call exit_status_set_internal_vars.
2969         cli/cli-decode.c (find_command_name_length): Recognize | as
2970         a single character command.
2971
2972 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2973
2974         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2975         top.c (execute_command_to_ui_file): New function, mostly a copy
2976         of execute_command_to_string.
2977         (execute_command_to_string): Implement by calling
2978         execute_command_to_ui_file.
2979
2980 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2981
2982         * top.h (saved_command_line): Remove declaration.
2983         * top.c (previous_saved_command_line, previous_repeat_arguments):
2984         New variables.
2985         (saved_command_line): Make static, define together with other
2986         'repeat variables'.
2987         (dont_repeat): Clear repeat_arguments.
2988         (repeat_previous, get_saved_command_line, save_command_line):
2989         New functions.
2990         (gdb_init): Initialize saved_command_line
2991         and previous_saved_command_line.
2992         * main.c (captured_main_1): Remove saved_command_line initialization.
2993         * event-top.c (handle_line_of_input): Update to use
2994         the new 'repeat' related functions instead of direct access to
2995         saved_command_line.
2996         * command.h (repeat_previous, get_saved_command_line,
2997         save_command_line): New declarations.
2998         (dont_repeat): Add comment.
2999
3000 2019-05-30  Tom Tromey  <tromey@adacore.com>
3001
3002         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3003         Fix comment.
3004         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3005
3006 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3007
3008         PR cli/24587
3009         * completer.c (complete): Initialize variable word.
3010
3011 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3012
3013         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3014         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3015         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3016         'body' is NULL to the outter 'if', protecting the '!is_define'
3017         situation as well.
3018
3019 2019-05-29  Tom Tromey  <tromey@adacore.com>
3020
3021         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3022         (dwarf_unknown): New function.
3023         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3024         (dwarf_type_encoding_name): Use dwarf_unknown.
3025
3026 2019-05-29  Tom Tromey  <tromey@adacore.com>
3027
3028         PR c++/20020:
3029         * cp-valprint.c (cp_print_value_fields): Call
3030         cp_print_static_field inside "try".
3031
3032 2019-05-29  Tom Tromey  <tromey@adacore.com>
3033
3034         * inflow.c (struct terminal_info): Add default operator=.
3035         * configure: Rebuild.
3036         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3037         -Wdeprecated-copy-dtor, -Wredundant-move.
3038
3039 2019-05-29  Tom Tromey  <tromey@adacore.com>
3040
3041         * NEWS: Add entry.
3042         * infcmd.c (print_return_value_1): Handle finish_print
3043         option.
3044         (show_print_finish): New function.
3045         (_initialize_infcmd): Add "set/show print finish" commands.
3046         * valprint.c (user_print_options): Initialize new member.
3047         * valprint.h (struct value_print_options) <finish_print>: New
3048         member.
3049
3050 2019-05-28  Tom Tromey  <tromey@adacore.com>
3051
3052         * ada-lang.c (ada_remove_Xbn_suffix)
3053         (find_old_style_renaming_symbol)
3054         (parse_old_style_renaming): Remove.
3055         (ada_find_renaming_symbol): Don't call
3056         find_old_style_renaming_symbol.
3057         (ada_is_renaming_symbol): Rename from
3058         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3059         bool.  Now static.
3060         (ada_read_var_value): Update and simplify.
3061         * ada-exp.y (write_var_or_type): Remove old code.
3062
3063 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3064
3065         * event-top.c: Remove include comment.
3066         * inflow.c (class scoped_ignore_sigttou): Move from here...
3067         * inflow.h (class scoped_ignore_sigttou): ...to here.
3068         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3069         * top.c:  Remove include comment.
3070
3071 2019-05-27  Tom Tromey  <tom@tromey.com>
3072
3073         * NEWS: Fix typo.
3074
3075 2019-05-22  Tom Tromey  <tromey@adacore.com>
3076
3077         * target.c (target_follow_exec): Constify parameter.
3078         * target-delegates.c: Rebuild.
3079         * remote.c (remote_target::follow_exec): Constify parameter.
3080         * infrun.c (follow_exec): Constify parameter.
3081         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3082         (target_follow_exec): Likewise.
3083
3084 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3085
3086         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3087         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3088
3089 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3090
3091         * NEWS: Add debugredirect and testsuite sections.
3092
3093 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3094
3095         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3096         target descriptions using exclusively floating point register name
3097         aliases.
3098
3099 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         PR gdb/18644:
3102         * f-lang.c (build_fortran_types): Handle the case where
3103         gdbarch_floatformat_for_type returns a nullptr.
3104
3105 2019-05-21  Tom de Vries  <tdevries@suse.de>
3106
3107         PR cli/24587
3108         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3109
3110 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         PR gdb/18644:
3113         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3114         16-byte floats.
3115         * i386-tdep.c (i386_floatformat_for_type): Use
3116         floatformats_ia64_quad for the 16-byte floating point component
3117         within a fortran 32-byte complex number.
3118
3119 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3120
3121         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3122         delete default constructor.
3123         (find_partial_die): Update to return const struct.
3124         (partial_die_parent_scope): Move variable declaration into scope
3125         of its use and change its type to auto.
3126         (guess_partial_die_structure_name): Likewise.
3127         (partial_die_info::fixup): Likewise.
3128
3129 2019-05-17  Tom Tromey  <tromey@adacore.com>
3130
3131         * source.c (find_and_open_source): Remove cast.
3132
3133 2019-05-17  Tom Tromey  <tromey@adacore.com>
3134
3135         * annotate.c (annotate_source): Make "filename" const.
3136         * annotate.h (annotate_source): Use const.
3137
3138 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3139
3140         * disasm.c (set_disassembler_options): Send errors to stderr.
3141
3142 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3143
3144         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3145         (cli_interp_base::set_logging): Check debug_redirect.
3146         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3147         * cli/cli-logging.c (debug_redirect): Add static variable.
3148         (pop_output_files): Add default param.
3149         (handle_redirections): Print debug setting.
3150         (show_logging_command): Likewise.
3151         (_initialize_cli_logging): Add debugredirect command.
3152         * interps.c (current_interp_set_logging): Add debug_redirect
3153         parameter.
3154         * interps.h (set_logging): Add debug_redirect parameter.
3155         (current_interp_set_logging): Likewise.
3156         * mi/mi-common.h: Likewise.
3157         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3158
3159 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3160             Tom Tromey  <tromey@adacore.com>
3161
3162         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3163         directly.
3164         * cli/cli-interp.h (make_logging_output): Remove declaration.
3165         * cli/cli-logging.c (make_logging_output): Remove function.
3166         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3167         directly.
3168         * ui-file.c (tee_file::tee_file): Remove bools.
3169         (tee_file::~tee_file): Remove deletes.
3170         * ui-file.h (tee_file): Remove bools.
3171
3172 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3173
3174         * mi/mi-cmds.h (mi_cmd_complete): New function.
3175         * mi/mi-main.c (mi_cmd_complete): Likewise.
3176         * mi/mi-cmds.c: Define new MI command -complete.
3177         * NEWS: Mention new -complete command.
3178
3179 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3180
3181         * completer.h (complete): New function.
3182         * completer.c (complete): Likewise.
3183         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3184         function defined in completer.h.
3185
3186 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3187
3188         * MAINTAINERS (Write After Approval): Add myself.
3189
3190 2019-05-17  Tom de Vries  <tdevries@suse.de>
3191
3192         PR gdb/24094
3193         * dwarf2read.c (struct cu_partial_die_info): New struct.
3194         (find_partial_die): Return cu_partial_die_info.
3195         (partial_die_parent_scope, guess_partial_die_structure_name)
3196         (partial_die_info::fixup): Handle new return type of find_partial_die.
3197
3198 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3199
3200         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3201         "std::string", simplifying the algorithm.
3202
3203 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3204
3205         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3206         (stap_static_probe_ops::get_probes): Likewise.
3207
3208 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3209
3210         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3211         '-')" and "else if".
3212         (stap_parse_single_operand): Join checks for
3213         "gdbarch_stap_parse_special_token_p" and
3214         "gdbarch_stap_parse_special_token" in the same "if" statement.
3215         Invert check when verifying for operation on register
3216         displacement.
3217
3218 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3219
3220         * stap-probe.c (stap_get_opcode): Update comment.
3221         (stap_get_expected_argument_type): Likewise.
3222         (handle_stap_probe): Likewise.
3223
3224 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3225
3226         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3227         return type to 'bool'.  Adjust comment.  Use 'bool' when
3228         appropriate.
3229         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3230         * stap-probe.c (stap_parse_argument_1): Likewise.
3231         (stap_is_operator): Likewise.
3232         (stap_is_generic_prefix): Likewise.
3233         (stap_is_register_prefix): Likewise.
3234         (stap_is_register_indirection_prefix): Likewise.
3235         (stap_is_integer_prefix): Likewise.
3236         (stap_generic_check_suffix): Likewise.
3237         (stap_check_integer_suffix): Likewise.
3238         (stap_check_register_suffix): Likewise.
3239         (stap_check_register_indirection_suffix): Likewise.
3240         (stap_parse_register_operand): Likewise.
3241         (stap_parse_single_operand): Likewise.
3242         (stap_parse_argument_1): Likewise.
3243         (stap_probe::get_argument_count): Likewise.
3244         (stap_is_operator): Likewise.
3245
3246 2019-05-16  Tom Tromey  <tromey@adacore.com>
3247
3248         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3249         keyword to foreach.
3250
3251 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3252
3253         * linux-thread-db.c (try_thread_db_load_1): Change return type
3254         to bool.
3255         (try_thread_db_load): Likewise.
3256         (try_thread_db_load_from_pdir_1): Likewise.
3257         (try_thread_db_load_from_pdir): Likewise.
3258         (try_thread_db_load_from_sdir): Likewise.
3259         (try_thread_db_load_from_dir): Likewise.
3260         (thread_db_load_search): Likewise.
3261         (has_libpthread): Likewise.
3262         (thread_db_load): Likewise.
3263
3264 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3265
3266         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3267         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3268         NULL, and complain/return if that's the case.
3269
3270 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3271
3272         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3273         (advance, posn, abstract_read_memory): New functions.
3274         [struct mem_read_abstraction]: New struct.
3275         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3276
3277 2019-05-14  Tom Tromey  <tromey@adacore.com>
3278
3279         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3280         value is not lval_memory.
3281
3282 2019-05-14  Tom Tromey  <tromey@adacore.com>
3283
3284         * solib.c (info_sharedlibrary_command): Style the file name.
3285
3286 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3287
3288         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3289         (aarch64_vnv_type): Likewise.
3290         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3291         * common/tdesc.c: Likewise.
3292         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3293         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3294         * features/aarch64-fpu.xml: Add ieee half view.
3295         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3296         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3297         * gdbtypes.h (struct builtin_type): Likewise.
3298         (struct objfile_type): Likewise.
3299
3300 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3301
3302         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3303         typo.
3304         * location.h (string_to_event_location): Likewise.
3305
3306 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3307
3308         GDB 8.3 released.
3309
3310 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3311
3312         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3313         New variable declaration.
3314         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3315         New variable.
3316         (print_one_breakpoint): Use ui_out::test_flags and new global
3317         variable to compute use_fixed_output.
3318         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3319         Remove.
3320         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3321         (mi_multi_location_breakpoint_output_fixed): Remove.
3322         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3323         new variable.
3324         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3325         fix_multi_location_breakpoint_output flag if version >= 3.
3326         * ui-out.h (enum ui_out_flag)
3327         <fix_multi_location_breakpoint_output>: New enumerator.
3328
3329 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3330
3331         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3332
3333 2019-05-10  Tom Tromey  <tromey@adacore.com>
3334
3335         * ada-lang.c (catch_ada_completer): New function.
3336         (_initialize_ada_language): Use it.
3337
3338 2019-05-10  Tom Tromey  <tromey@adacore.com>
3339
3340         * thread.c (print_thread_info): Make "requested_threads" const.
3341         * gdbthread.h (print_thread_info): Make "requested_threads"
3342         const.
3343         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3344         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3345
3346 2019-05-08  Tom Tromey  <tom@tromey.com>
3347
3348         * gdbtypes.c (objfile_type_data): Change type.
3349         (objfile_type, _initialize_gdbtypes): Update.
3350
3351 2019-05-08  Tom Tromey  <tom@tromey.com>
3352
3353         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3354         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3355         (_initialize_dwarf2_frame): Update.
3356
3357 2019-05-08  Tom Tromey  <tom@tromey.com>
3358
3359         * objc-lang.c (objc_objfile_data): Change type.
3360         (find_methods): Update.
3361         (_initialize_objc_lang): Remove.
3362
3363 2019-05-08  Tom Tromey  <tom@tromey.com>
3364
3365         * stabsread.c (rs6000_builtin_type_data): Change type.
3366         (rs6000_builtin_type, _initialize_stabsread): Update.
3367
3368 2019-05-08  Tom Tromey  <tom@tromey.com>
3369
3370         * mips-tdep.c (mips_pdr_data): Remove.
3371         (_initialize_mips_tdep): Update.
3372
3373 2019-05-08  Tom Tromey  <tom@tromey.com>
3374
3375         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3376         (hppa_init_objfile_priv_data, read_unwind_info)
3377         (find_unwind_entry, _initialize_hppa_tdep): Update.
3378
3379 2019-05-08  Tom Tromey  <tom@tromey.com>
3380
3381         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3382         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3383         on obstack.
3384         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3385
3386 2019-05-08  Tom Tromey  <tom@tromey.com>
3387
3388         * mdebugread.c (basic_type_data): Change type.
3389         (basic_type, _initialize_mdebugread): Update.
3390
3391 2019-05-08  Tom Tromey  <tom@tromey.com>
3392
3393         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3394
3395 2019-05-08  Tom Tromey  <tom@tromey.com>
3396
3397         * nto-tdep.c (nto_inferior_data_reg): Change type.
3398         (nto_inferior_data): Update.
3399         (nto_inferior_data_cleanup, nto_new_inferior_data)
3400         (_initialize_nto_tdep): Remove.
3401         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3402
3403 2019-05-08  Tom Tromey  <tom@tromey.com>
3404
3405         * ada-lang.c (struct ada_inferior_data): Add initializers.
3406         (ada_inferior_data): Change type.
3407         (ada_inferior_data_cleanup): Remove.
3408         (get_ada_inferior_data, ada_inferior_exit)
3409         (struct ada_pspace_data): Add initializers, destructor.
3410         (ada_pspace_data_handle): Change type.
3411         (get_ada_pspace_data): Update.
3412         (ada_pspace_data_cleanup): Remove.
3413
3414 2019-05-08  Tom Tromey  <tom@tromey.com>
3415
3416         * coffread.c (struct coff_symfile_info): Add initializers.
3417         (coff_objfile_data_key): Move lower.  Change type.
3418         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3419         Update.
3420         (coff_free_info): Remove.
3421
3422 2019-05-08  Tom Tromey  <tom@tromey.com>
3423
3424         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3425         (fbsd_pspace_data_handle): Move lower.  Change type.
3426         (get_fbsd_pspace_data): Update.
3427         (fbsd_pspace_data_cleanup): Remove.
3428         (_initialize_fbsd_tdep): Update.
3429
3430 2019-05-08  Tom Tromey  <tom@tromey.com>
3431
3432         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3433         (get_ada_tasks_pspace_data): Update.
3434         (ada_tasks_pspace_data_cleanup): Remove.
3435         (_initialize_tasks): Update.
3436         (ada_tasks_inferior_data_handle): Change type.
3437         (get_ada_tasks_inferior_data): Update.
3438         (ada_tasks_inferior_data_cleanup): Remove.
3439         (struct ada_tasks_pspace_data): Add initializers.
3440
3441 2019-05-08  Tom Tromey  <tom@tromey.com>
3442
3443         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3444         * symfile-debug.c (debug_sym_get_probes): Change type.
3445         * stap-probe.c (handle_stap_probe):
3446         (stap_static_probe_ops::get_probes): Change type.
3447         * probe.h (class static_probe_ops) <get_probes>: Change type.
3448         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3449         (parse_probes_in_pspace): Update.
3450         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3451         Update.
3452         (any_static_probe_ops::get_probes): Change type.
3453         * elfread.c (elfread_data): New typedef.
3454         (probe_key): Change type.
3455         (elf_get_probes): Likewise.  Update.
3456         (probe_key_free): Remove.
3457         (_initialize_elfread): Update.
3458         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3459         Change type.
3460         (dtrace_process_dof_probe, dtrace_process_dof)
3461         (dtrace_static_probe_ops::get_probe): Change type.
3462
3463 2019-05-08  Tom Tromey  <tom@tromey.com>
3464
3465         * xcoffread.c (struct xcoff_symfile_info): Rename from
3466         coff_symfile_info.  Add initializers.
3467         (xcoff_objfile_data_key): Move lower.  Change type.
3468         (XCOFF_DATA): Rewrite.
3469         (xcoff_free_info): Remove.
3470         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3471         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3472         (xcoff_initial_scan): Update.
3473
3474 2019-05-08  Tom Tromey  <tom@tromey.com>
3475
3476         * solib-svr4.c (struct svr4_info): Add initializers and
3477         destructor.
3478         <probes_table>: Now an htab_up.
3479         (solib_svr4_pspace_data): Change type.
3480         (free_probes_table): Simplify.
3481         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3482         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3483         (probes_table_remove_objfile_probes, register_solib_event_probe)
3484         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3485         (_initialize_svr4_solib): Update.
3486
3487 2019-05-08  Tom Tromey  <tom@tromey.com>
3488
3489         * remote.c (remote_pspace_data): Change type.
3490         (remote_pspace_data_cleanup): Remove.
3491         (get_remote_exec_file, set_pspace_remote_exec_file)
3492         (_initialize_remote): Update.
3493
3494 2019-05-08  Tom Tromey  <tom@tromey.com>
3495
3496         * breakpoint.c (breakpoint_objfile_key): Change type.
3497         (get_breakpoint_objfile_data): Update.
3498         (free_breakpoint_objfile_data): Remove.
3499         (_initialize_breakpoint): Update.
3500
3501 2019-05-08  Tom Tromey  <tom@tromey.com>
3502
3503         * linux-tdep.c (struct linux_info): Add initializers.
3504         (linux_inferior_data): Move.  Change type.
3505         (invalidate_linux_cache_inf): Update.
3506         (linux_inferior_data_cleanup): Remove.
3507         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3508
3509 2019-05-08  Tom Tromey  <tom@tromey.com>
3510
3511         * auxv.c (auxv_inferior_data): Move.  Change type.
3512         (auxv_inferior_data_cleanup): Remove.
3513         (invalidate_auxv_cache_inf): Rewrite.
3514         (get_auxv_inferior_data, _initialize_auxv): Update.
3515
3516 2019-05-08  Tom Tromey  <tom@tromey.com>
3517
3518         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3519         (symfile_debug_objfile_data_key): Change type.
3520         (symfile_debug_installed, debug_qf_has_symbols)
3521         (debug_qf_find_last_source_symtab)
3522         (debug_qf_forget_cached_source_info)
3523         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3524         (debug_qf_print_stats, debug_qf_dump)
3525         (debug_qf_expand_symtabs_for_function)
3526         (debug_qf_expand_all_symtabs)
3527         (debug_qf_expand_symtabs_with_fullname)
3528         (debug_qf_map_matching_symbols)
3529         (debug_qf_expand_symtabs_matching)
3530         (debug_qf_find_pc_sect_compunit_symtab)
3531         (debug_qf_map_symbol_filenames)
3532         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3533         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3534         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3535         (debug_sym_read_linetable, debug_sym_relocate): Update.
3536         (symfile_debug_free_objfile): Remove.
3537         (install_symfile_debug_logging, _initialize_symfile_debug):
3538         Update.
3539
3540 2019-05-08  Tom Tromey  <tom@tromey.com>
3541
3542         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3543         allocate_on_obstack.
3544         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3545         (get_dwarf2_per_objfile): Update.
3546         (set_dwarf2_per_objfile): Remove.
3547         (dwarf2_has_info, dwarf2_get_section_info): Update.
3548         (dwarf2_free_objfile): Remove.
3549         (_initialize_dwarf2_read): Update.
3550
3551 2019-05-08  Tom Tromey  <tom@tromey.com>
3552
3553         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3554         initializers.
3555         <unsupported_script_warning_printed,
3556         script_not_found_warning_printed>: Now bool.
3557         (auto_load_pspace_data): Change type.
3558         (~auto_load_pspace_info): Rename from
3559         auto_load_pspace_data_cleanup.
3560         (get_auto_load_pspace_data, init_loaded_scripts_info)
3561         (clear_section_scripts, maybe_print_unsupported_script_warning)
3562         (maybe_print_script_not_found_warning, _initialize_auto_load):
3563         Update.
3564
3565 2019-05-08  Tom Tromey  <tom@tromey.com>
3566
3567         * objfiles.c (objfile_pspace_info): Add destructor and
3568         initializers.
3569         (objfiles_pspace_data): Change type.
3570         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3571         (get_objfile_pspace_data): Update.
3572         (objfiles_bfd_data): Change type.
3573         (get_objfile_bfd_data): Update.
3574         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3575
3576 2019-05-08  Tom Tromey  <tom@tromey.com>
3577
3578         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3579         Change type.
3580         (get_catch_syscall_inferior_data): Update.
3581         (catch_syscall_inferior_data_cleanup): Remove.
3582         (_initialize_break_catch_syscall): Update.
3583
3584 2019-05-08  Tom Tromey  <tom@tromey.com>
3585
3586         * inflow.c (struct terminal_info): Add destructor and
3587         initializers.
3588         (inflow_inferior_data): Change type.
3589         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3590         (get_inflow_inferior_data, inflow_inferior_exit)
3591         (swap_terminal_info, _initialize_inflow): Update.
3592
3593 2019-05-08  Tom Tromey  <tom@tromey.com>
3594
3595         * target-dcache.c (target_dcache_cleanup): Remove.
3596         (target_dcache_aspace_key): Change type.
3597         (target_dcache_init_p, target_dcache_invalidate)
3598         (target_dcache_get, target_dcache_get_or_init)
3599         (_initialize_target_dcache): Update.
3600         * dcache.h (struct dcache_deleter): New.
3601
3602 2019-05-08  Tom Tromey  <tom@tromey.com>
3603
3604         * symtab.c (struct symbol_cache): Add destructor and
3605         initializers.
3606         (symbol_cache_key): Move.  Change type.
3607         (make_symbol_cache, free_symbol_cache): Remove.
3608         (get_symbol_cache): Update.
3609         (symbol_cache_cleanup): Remove.
3610         (ALL_PSPACES, symbol_cache_flush)
3611         (maintenance_print_symbol_cache)
3612         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3613         Update.
3614
3615 2019-05-08  Tom Tromey  <tom@tromey.com>
3616
3617         * symtab.c (struct main_info): Add destructor and initializers.
3618         (main_progspace_key): Move.  Change type.
3619         (get_main_info): Update.
3620         (main_info_cleanup): Remove.
3621         (_initialize_symtab): Update.
3622
3623 2019-05-08  Tom Tromey  <tom@tromey.com>
3624
3625         * registry.h (DECLARE_REGISTRY): Define the _key class.
3626
3627 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * NEWS: Merge two 'New commands' sections.
3630
3631 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3632
3633         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3634         parameter and use Ada language definition instead.
3635         (ada_val_print_ptr): Remove unused language parameter.
3636         (ada_val_print_num): Remove language parameter and use Ada language
3637         definition instead.
3638         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3639         parameter.
3640         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3641         parameter and use Ada language definition instead.
3642         (ada_val_print_1): Update all ada_val_print_xxx calls.
3643         Remove language parameter.
3644         (ada_val_print): Update ada_val_print_1 call.
3645
3646 2019-05-08  Tom Tromey  <tromey@adacore.com>
3647
3648         * remote.c (remote_hw_watchpoint_limit)
3649         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3650         Now static.
3651
3652 2019-05-08  Tom Tromey  <tromey@adacore.com>
3653
3654         * maint.c (_initialize_maint_cmds): Move initialization code to
3655         remote.c.
3656         (watchdog, show_watchdog): Move to remote.c.
3657         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3658         "watchdog" static.
3659         (_initialize_remote): Move initialization code from maint.c.
3660         * defs.h (watchdog): Don't declare.
3661
3662 2019-05-08  Tom Tromey  <tromey@adacore.com>
3663
3664         * tui/tui-interp.c: Include main.h.
3665         * interps.c: Include main.h.
3666         * main.h (interpreter_p): Declare.
3667         * defs.h (interpreter_p): Don't declare.
3668
3669 2019-05-08  Tom Tromey  <tromey@adacore.com>
3670
3671         * dwarf2loc.c: Include dwarf2read.h.
3672         * defs.h (read_unsigned_leb128): Don't declare.
3673         * dwarf2read.h (read_unsigned_leb128): Declare.
3674
3675 2019-05-08  Tom Tromey  <tromey@adacore.com>
3676
3677         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3678         method.
3679
3680 2019-05-08  Tom Tromey  <tromey@adacore.com>
3681
3682         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3683         when no wrap column is set.
3684
3685 2019-05-08  Tom Tromey  <tromey@adacore.com>
3686
3687         * c-lang.c (c_get_string): Handle non-C-style arrays.
3688
3689 2019-05-08  Tom Tromey  <tromey@adacore.com>
3690
3691         * typeprint.c (print_offset_data::update): Print the bit offset,
3692         not the number of bits remaining.
3693
3694 2019-05-08  Tom Tromey  <tromey@adacore.com>
3695
3696         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3697         padding at end of comment.
3698
3699 2019-05-08  Tom Tromey  <tromey@adacore.com>
3700
3701         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3702         Compare main types.
3703
3704 2019-05-06  Tom Tromey  <tom@tromey.com>
3705
3706         * common/scoped_mmap.c: Include common-defs.h.
3707         * common/scoped_mmap.h: Don't include config.h.
3708
3709 2019-05-04  Tom Tromey  <tom@tromey.com>
3710
3711         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3712         (struct aarch64_call_info): Add initializers.
3713         <si>: Now a std::vector.
3714         (pass_on_stack, aarch64_push_dummy_call): Update.
3715
3716 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3717             Tom Tromey  <tom@tromey.com>
3718
3719         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3720         (ppc_threads): Now a std::vector.  Now static.
3721         (hwdebug_find_thread_points_by_tid)
3722         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3723         Update.
3724
3725 2019-05-04  Tom Tromey  <tom@tromey.com>
3726
3727         * arc-tdep.c (arc_tdesc_init): Return bool.
3728
3729 2019-05-04  Tom Tromey  <tom@tromey.com>
3730
3731         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3732         Use gdb_assert_not_reached.
3733
3734 2019-05-04  Tom Tromey  <tom@tromey.com>
3735
3736         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3737         "false".
3738
3739 2019-05-04  Tom Tromey  <tom@tromey.com>
3740
3741         * arc-tdep.c (arc_tdesc_init): Use bool.
3742
3743 2019-05-04  Tom Tromey  <tom@tromey.com>
3744
3745         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3746
3747 2019-05-04  Tom Tromey  <tom@tromey.com>
3748
3749         * cli/cli-cmds.c (valid_command_p): Return bool.
3750
3751 2019-05-04  Tom Tromey  <tom@tromey.com>
3752
3753         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3754         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3755
3756 2019-05-04  Raul Tambre  <raul@tambre.ee>
3757
3758         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3759         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3760         operator for comparison.
3761
3762 2019-05-04  Tom Tromey  <tom@tromey.com>
3763
3764         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3765         (lookup_partial_symbol, print_partial_symbols)
3766         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3767         (psymbol_compare): Update.
3768         (add_psymbol_to_bcache): Clear the entire psymbol.
3769         (maintenance_check_psymtabs): Update.
3770         * psympriv.h (struct partial_symbol): Don't derive from
3771         general_symbol_info.
3772         <obj_section, unrelocated_address, address,
3773         set_unrelocated_address>: Update.
3774         <ginfo>: New member.
3775         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3776         (debug_names::write_psymbols): Update.
3777
3778 2019-05-04  Tom de Vries  <tdevries@suse.de>
3779
3780         * contrib/cc-with-tweaks.sh: Support -n arg.
3781
3782 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3783
3784         * corelow.c (core_target::detach): Ensure frame cache and
3785         register caches are cleared.
3786         inferior.c (exit_inferior_1): Likewise.
3787
3788 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3789             Tom Tromey  <tom@tromey.com>
3790
3791         * dictionary.c (collate_pending_symbols_by_language): Remove
3792         "struct" from foreach.
3793         * symtab.c (lookup_global_symbol_from_objfile)
3794         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3795         foreach.
3796         * ser-tcp.c (net_open): Remove "struct" from foreach.
3797         * objfiles.c (objfile_relocate, objfile_rebase)
3798         (objfile_has_symbols): Remove "struct" from foreach.
3799         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3800         from foreach.
3801         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3802         foreach.
3803         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3804         "struct" from foreach.
3805         * ada-lang.c (create_excep_cond_exprs)
3806         (ada_exception_catchpoint_cond_string): Remove "struct" from
3807         foreach.
3808
3809 2019-05-03  Tom Tromey  <tromey@adacore.com>
3810
3811         * ada-exp.y (convert_char_literal): Check suffix of each
3812         enumerator.
3813
3814 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3815
3816         PR ada/21406:
3817         * ada-exp.y (yywrap): Don't define.
3818         * ada-lex.l (%option): Add noyywrap
3819         (yywrap): Remove.
3820
3821 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3822
3823         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3824         _WIN32_WINNT to the XP level, unless already defined to a higher
3825         level.
3826
3827         * unittests/parse-connection-spec-selftests.c:
3828         * ser-tcp.c:
3829         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3830         override.
3831
3832         * symfile.c (find_separate_debug_file): Remove colon from the
3833         drive spec of DOS/Windows file names of the target, so that the
3834         file name produced from DEBUGDIR and the target's directory will
3835         be valid on DOS/Windows systems.
3836
3837 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3838
3839         * rust-lang.c (val_print_struct): Handle printing structures
3840         containing strings.
3841
3842 2019-05-02  Tom Tromey  <tromey@adacore.com>
3843
3844         * valarith.c (_initialize_valarith): Remove.
3845
3846 2019-05-01  Tom Tromey  <tromey@adacore.com>
3847
3848         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3849         bitfields.
3850
3851 2019-05-01  Tom Tromey  <tromey@adacore.com>
3852
3853         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3854         for big-endian copies.
3855
3856 2019-04-30  Ali Tamur  <tamur@google.com>
3857         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3858         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3859         (read_3_bytes): New function.
3860
3861 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3862
3863         * windows-nat.c (main_thread_id): Delete.
3864         (handle_output_debug_string): Replace main_thread_id by
3865         current_event.dwThreadId.
3866         (fake_create_process): Likewise.
3867         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3868         Do not set main_thread_id.
3869         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3870         current_event.dwThreadId.
3871         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3872
3873 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3874
3875         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3876         Use current_event.dwThreadId instead of main_thread_id.
3877
3878 2019-04-30  Tom Tromey  <tromey@adacore.com>
3879
3880         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3881         (create_excep_cond_exprs): Iterate over program spaces.
3882         (ada_exception_catchpoint_cond_string): Examine all minimal
3883         symbols for exception types.
3884
3885 2019-04-30  Tom Tromey  <tromey@adacore.com>
3886
3887         PR c++/24470:
3888         * dwarf2read.c (process_structure_scope): Handle case where type
3889         has template parameters but no symbol was created.
3890
3891 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3892             Chris January  <chris.january@arm.com>
3893
3894         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3895         qualifier.
3896         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3897
3898 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * f-typeprint.c (f_print_type): Update rules for printing
3901         whitespace.
3902         (f_type_print_varspec_suffix): Likewise.
3903
3904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3905             Chris January  <chris.january@arm.com>
3906
3907         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3908         function arguments.
3909
3910 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * f-lang.c (build_fortran_types): Change name of void type to
3913         lower case.
3914         * f-typeprint.c (f_type_print_base): Print the name of the void
3915         type, rather than a fixed string.
3916         * f-valprint.c (f_decorations): Use lower case void string.
3917
3918 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3919             Chris January  <chris.january@arm.com>
3920
3921         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3922         types for Fortran.
3923
3924 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3925             Chris January  <chris.january@arm.com>
3926             David Lecomber  <david.lecomber@arm.com>
3927
3928         * f-exp.y (BINOP_INTRINSIC): New token.
3929         (exp): New parser rule handling BINOP_INTRINSIC.
3930         (f77_keywords): Add new builtin procedures.
3931         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3932         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3933         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3934         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3935         (print_unop_subexp_f): New function.
3936         (print_binop_subexp_f): New function.
3937         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3938         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3939         (dump_subexp_body_f): Likewise.
3940         (operator_check_f): Likewise.
3941         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3942         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3943
3944 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3947         UNOP_KIND.
3948         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3949         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3950         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3951         (operator_length_f): New fuction.
3952         (print_subexp_f): New function.
3953         (op_name_f): New function.
3954         (dump_subexp_body_f): New function.
3955         (operator_check_f): New function.
3956         (exp_descriptor_f): Replace standard expression handling functions
3957         with new functions.
3958         * gdb/fortran-operator.def: New file.
3959         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3960         * gdb/std-operator.def: Remove UNOP_KIND.
3961
3962 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * std-operator.def: Remove unbalanced, stray double quote
3965         character.
3966
3967 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3968             Chris January  <chris.january@arm.com>
3969             Daniel Everett  <daniel.everett@arm.com>
3970             Nick Forrington  <nick.forrington@arm.com>
3971             Richard Bunt  <richard.bunt@arm.com>
3972
3973         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3974         of depth when printing anonymous structs or unions.
3975         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3976         Don't print either the top-level value, or the children if the
3977         max-depth is exceeded.
3978         (ppscm_print_children): When printing the key of a map, allow one
3979         extra level of depth.
3980         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3981         print either the top-level value, or the children if the max-depth
3982         is exceeded.
3983         (print_children): When printing the key of a map, allow one extra
3984         level of depth.
3985         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3986         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3987         (user_print_options): Initialise max_depth field.
3988         (val_print_scalar_or_string_type_p): New function.
3989         (val_print): Check to see if the max depth has been reached.
3990         (val_print_check_max_depth): Define new function.
3991         (show_print_max_depth): New function.
3992         (_initialize_valprint): Add 'print max-depth' option.
3993         * valprint.h (struct value_print_options) <max_depth>: New field.
3994         (val_print_check_max_depth): Declare new function.
3995         * NEWS: Document new feature.
3996
3997 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3998
3999         * ada-lang.c (ada_language_defn): Initialise new field.
4000         * c-lang.c (c_is_string_type_p): New function.
4001         (c_language_defn): Initialise new field.
4002         (cplus_language_defn): Initialise new field.
4003         (asm_language_defn): Initialise new field.
4004         (minimal_language_defn): Initialise new field.
4005         * c-lang.h (c_is_string_type_p): Declare new function.
4006         * d-lang.c (d_language_defn): Initialise new field.
4007         * f-lang.c (f_is_string_type_p): New function.
4008         (f_language_defn): Initialise new field.
4009         * go-lang.c (go_is_string_type_p): New function.
4010         (go_language_defn): Initialise new field.
4011         * language.c (default_is_string_type_p): New function.
4012         (unknown_language_defn): Initialise new field.
4013         (auto_language_defn): Initialise new field.
4014         * language.h (struct language_defn) <la_is_string_type_p>: New
4015         member variable.
4016         (default_is_string_type_p): Declare new function.
4017         * m2-lang.c (m2_language_defn): Initialise new field.
4018         * objc-lang.c (objc_language_defn): Initialise new field.
4019         * opencl-lang.c (opencl_language_defn): Initialise new field.
4020         * p-lang.c (pascal_is_string_type_p): New function.
4021         (pascal_language_defn): Initialise new field.
4022         * rust-lang.c (rust_is_string_type_p): New function.
4023         (rust_language_defn): Initialise new field.
4024
4025 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4026
4027         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4028         New field.
4029         * ada-lang.c (ada_language_defn): Initialise new field.
4030         * c-lang.c (c_language_defn): Likewise.
4031         (cplus_language_defn): Likewise.
4032         (asm_language_defn): Likewise.
4033         (minimal_language_defn): Likewise.
4034         * d-lang.c (d_language_defn): Likewise.
4035         * f-lang.c (f_language_defn): Likewise.
4036         * go-lang.c (go_language_defn): Likewise.
4037         * language.c (unknown_language_defn): Likewise.
4038         (auto_language_defn): Likewise.
4039         * m2-lang.c (m2_language_defn): Likewise.
4040         * objc-lang.c (objc_language_defn): Likewise.
4041         * opencl-lang.c (opencl_language_defn): Likewise.
4042         * p-lang.c (pascal_language_defn): Likewise.
4043         * rust-lang.c (rust_language_defn): Likewise.
4044
4045 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * ada-lang.c (ada_is_character_type): Change return type to bool.
4048         (ada_is_string_type): Likewise.
4049         * ada-lang.h (ada_is_character_type): Update declaration
4050         (ada_is_string_type): Likewise.
4051
4052 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4053
4054         Support style in 'frame|thread apply'
4055
4056         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4057         * record.c (record_start, record_stop): Update callers of
4058         execute_command_to_string with false.
4059         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4060         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4061         methods.
4062         (class string_file): New constructor with term_out parameter.
4063         Override methods term_out and can_emit_style_escape.  New member
4064         term_out.
4065         (class stdio_file): Override can_emit_style_escape.
4066         (class tee_file): Override term_out and can_emit_style_escape.
4067         * utils.h (can_emit_style_escape): Remove.
4068         * utils.c (can_emit_style_escape): Likewise.
4069         Update all callers of can_emit_style_escape (SOMESTREAM) to
4070         SOMESTREAM->can_emit_style_escape.
4071         * source-cache.c (source_cache::get_source_lines): Likewise.
4072         * stack.c (frame_apply_command_count): Call execute_command_to_string
4073         passing the term_out characteristic of the current gdb_stdout.
4074         * thread.c (thr_try_catch_cmd): Likewise.
4075         * top.c (execute_command_to_string): pass term_out parameter
4076         to construct the string_file for the command output.
4077         * ui-file.c (term_cli_styling): New function (most code moved
4078         from utils.c can_emit_style_escape).
4079         (string_file::string_file, string_file::can_emit_style_escape,
4080         stdio_file::can_emit_style_escape, tee_file::term_out,
4081         tee_file::can_emit_style_escape): New functions.
4082
4083 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4084
4085         * NEWS: Mention the new set|show may-call-functions.
4086         * infcall.c (may_call_functions_p): New variable.
4087         (show_may_call_functions_p): New function.
4088         (call_function_by_hand_dummy): Throws an error if not
4089         may-call-functions.
4090         (_initialize_infcall): Call add_setshow_boolean_cmd for
4091         may-call-functions.
4092
4093 2019-04-25  Keith Seitz  <keiths@redhat.com>
4094
4095         PR c++/24367
4096         * cp-support.c (inspect_type): Don't attempt substitutions
4097         of symbol with the same name.
4098
4099 2019-04-25  Tom Tromey  <tromey@adacore.com>
4100
4101         PR gdb/24475:
4102         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4103         static.
4104
4105 2019-04-25  Tom Tromey  <tromey@adacore.com>
4106
4107         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4108         rvalue reference.
4109         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4110         (gdb_xml_parser::parse): Use std::move.
4111         * python/python-internal.h (gdbpy_convert_exception): Take a const
4112         reference.
4113         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4114         std::move.
4115         * python/py-utils.c (gdbpy_convert_exception): Take a const
4116         reference.
4117         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4118         Use std::move.
4119         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4120         Use std::move.
4121         * mi/mi-main.c (mi_print_exception): Take a const reference.
4122         * main.c (handle_command_errors): Take a const reference.
4123         * linespec.c (parse_linespec): Use std::move.
4124         * infcall.c (run_inferior_call): Use std::move.
4125         (call_function_by_hand_dummy): Use std::move.
4126         * exec.c (try_open_exec_file): Use std::move.
4127         * exceptions.h (exception_print, exception_fprintf)
4128         (exception_print_same): Update.
4129         * exceptions.c (print_exception, exception_print)
4130         (exception_fprintf, exception_print_same): Change parameters to
4131         const reference.
4132         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4133         * common/new-op.c: Use std::move.
4134         * common/common-exceptions.h (struct gdb_exception): Add move
4135         constructor.
4136         (struct gdb_exception_error, struct gdb_exception_quit, struct
4137         gdb_quit_bad_alloc): Change constructor to move constructor.
4138         (throw_exception): Change parameter to rvalue reference.
4139         * common/common-exceptions.c (throw_exception): Take rvalue
4140         reference.
4141         * cli/cli-interp.c (safe_execute_command): Use std::move.
4142         * breakpoint.c (insert_bp_location, location_to_sals): Use
4143         std::move.
4144
4145 2019-04-25  Tom Tromey  <tromey@adacore.com>
4146
4147         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4148         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4149         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4150         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4151         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4152         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4153         guile/scm-value.c: Use unpack.
4154         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4155         gdbscm_gdb_exception.
4156         (gdbscm_throw_gdb_exception): Likewise.
4157         (struct gdbscm_gdb_exception): New.
4158         (unpack): New function.
4159         (gdbscm_wrap): Use unpack.
4160
4161 2019-04-25  Tom Tromey  <tromey@adacore.com>
4162
4163         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4164         (gdb_rl_callback_handler): Use std::move.
4165         * common/common-exceptions.h (struct gdb_exception): Add move
4166         assignment operator.
4167         (throw_exception_sjlj): Change "exception" to const reference.
4168         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4169         (throw_exception_sjlj): Change "exception" to const reference.
4170
4171 2019-04-25  Tom Tromey  <tromey@adacore.com>
4172
4173         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4174         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4175         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4176         Update.
4177         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4178         Update.
4179         * mi/mi-interp.c (mi_interp::exec): Update.
4180         * linespec.c (parse_linespec): Update.
4181         * infcall.c (run_inferior_call): Update.
4182         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4183         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4184         (gdbscm_lookup_global_symbol): Update.
4185         * guile/scm-param.c (gdbscm_parameter_value): Update.
4186         * guile/scm-frame.c (gdbscm_frame_read_register)
4187         (gdbscm_frame_read_var): Update.
4188         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4189         * exec.c (try_open_exec_file): Update.
4190         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4191         (gdb_rl_callback_handler): Update.
4192         * common/common-exceptions.h (exception_none): Don't declare.
4193         * common/common-exceptions.c (exception_none): Don't define.
4194         (struct catcher) <exception>: Update.
4195         * cli/cli-interp.c (safe_execute_command): Update.
4196         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4197
4198 2019-04-25  Ali Tamur  <tamur@google.com>
4199
4200         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4201         (read_attribute_value): Likewise.
4202         (dwarf2_read_addr_index): Update comment.
4203         (read_str_index): Add DW_FORM_strx.
4204         (dwarf2_string_attr): Likewise.
4205         (dwarf2_const_value_attr): Likewise.
4206         (dump_die_shallow): Likewise.
4207         (dwarf2_fetch_constant_bytes): Likewise.
4208         (skip_form_bytes): Likewise.
4209         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4210
4211 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4212
4213         PR corefiles/11608
4214         PR corefiles/18187
4215         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4216         OFFSET.  Verify if current mapping contains an ELF header.
4217         (linux_find_memory_regions_full): Adjust call to
4218         dump_mapping_p.
4219
4220 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4221             Kang Li <kanglictf@gmail.com>
4222
4223         PR gdb/21600
4224
4225         * dwarf2-frame.c (read_initial_length): Be consistent about using
4226         unsigned representation of length.
4227         (decode_frame_entry_1): Likewise.  Check for wraparound of
4228         end pointer as well as buffer overflow.
4229
4230 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4231
4232         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4233         "vq".
4234
4235 2019-04-24  Tom Tromey  <tromey@adacore.com>
4236
4237         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4238
4239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * s12z-tdep.c (s12z_unwind_pc): Delete.
4242         (s12z_unwind_sp): Delete.
4243         (s12z_gdbarch_init): Don't register deleted functions with
4244         gdbarch.
4245
4246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * rl78-tdep.c (rl78_unwind_sp): Delete.
4249         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4250
4251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4254         (xstormy16_unwind_pc): Delete.
4255         (xstormy16_dummy_id): Delete.
4256         (xstormy16_gdbarch_init): Don't register deleted functions with
4257         gdbarch.
4258
4259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * vax-tdep.c (vax_unwind_pc): Delete.
4262         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4263
4264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * v850-tdep.c (v850_unwind_sp): Delete.
4267         (v850_unwind_pc): Delete.
4268         (v850_dummy_id): Delete.
4269         (v850_gdbarch_init): Don't register deleted functions with
4270         gdbarch.
4271
4272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4275         (tilegx_unwind_pc): Delete.
4276         (tilegx_unwind_dummy_id): Delete.
4277         (tilegx_gdbarch_init): Don't register deleted functions with
4278         gdbarch.
4279
4280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4281
4282         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4283         (tic6x_dummy_id): Delete.
4284         (tic6x_gdbarch_init): Don't register deleted functions with
4285         gdbarch.
4286
4287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4288
4289         * sparc-tdep.c (sparc_unwind_pc): Delete.
4290         (sparc32_gdbarch_init): Don't register deleted function with
4291         gdbarch.
4292
4293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4294
4295         * sh-tdep.c (sh_unwind_sp): Delete.
4296         (sh_unwind_pc): Delete.
4297         (sh_dummy_id): Delete.
4298         (sh_gdbarch_init): Don't register deleted functions with
4299         gdbarch.
4300
4301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4302
4303         * score-tdep.c (score_unwind_sp): Delete.
4304         (score_unwind_pc): Delete.
4305         (score_dummy_id): Delete.
4306         (score_gdbarch_init): Don't register deleted functions with
4307         gdbarch.
4308
4309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * rx-tdep.c (rx_unwind_pc): Delete.
4312         (rx_unwind_sp): Delete.
4313         (rx_dummy_id): Delete.
4314         (rx_gdbarch_init): Don't register deleted functions with
4315         gdbarch.  Update comment.
4316
4317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4318
4319         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4320         (rs6000_dummy_id): Delete.
4321         (rs6000_gdbarch_init): Don't register deleted functions with
4322         gdbarch.
4323
4324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * or1k-tdep.c (or1k_dummy_id): Delete.
4327         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4328
4329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * nios2-tdep.c (nios2_dummy_id): Delete.
4332         (nios2_unwind_sp): Delete.
4333         (nios2_gdbarch_init): Don't register deleted functions with
4334         gdbarch.
4335
4336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * nds32-tdep.c (nds32_dummy_id): Delete.
4339         (nds32_unwind_pc): Delete.
4340         (nds32_unwind_sp): Delete.
4341         (nds32_gdbarch_init): Don't register deleted functions with
4342         gdbarch.
4343
4344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4345
4346         * msp430-tdep.c (msp430_unwind_pc): Delete.
4347         (msp430_unwind_sp): Delete.
4348         (msp430_dummy_id): Delete.
4349         (msp430_gdbarch_init): Don't register deleted functions with
4350         gdbarch.
4351
4352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4353
4354         * moxie-tdep.c (moxie_unwind_sp): Delete.
4355         (moxie_unwind_pc): Delete.
4356         (moxie_dummy_id): Delete.
4357         (moxie_gdbarch_init): Don't register deleted functions with
4358         gdbarch.
4359
4360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4361
4362         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4363         (mn10300_unwind_pc): Delete.
4364         (mn10300_unwind_sp): Delete.
4365         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4366         mn10300_unwind_sp.
4367         (mn10300_frame_unwind_init): Don't register deleted functions with
4368         gdbarch.
4369
4370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * mep-tdep.c (mep_unwind_pc): Delete.
4373         (mep_unwind_sp): Delete.
4374         (mep_dummy_id): Delete.
4375         (mep_gdbarch_init): Don't register deleted functions with
4376         gdbarch.
4377
4378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4381         (m68hc11_unwind_sp): Delete.
4382         (m68hc11_gdbarch_init): Don't register deleted functions with
4383         gdbarch.
4384
4385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4386
4387         * m32r-tdep.c (m32r_unwind_sp): Delete.
4388         (m32r_unwind_pc): Delete.
4389         (m32r_dummy_id): Delete.
4390         (m32r_gdbarch_init): Don't register deleted functions with
4391         gdbarch.
4392
4393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4394
4395         * m32c-tdep.c (m32c_unwind_pc): Delete.
4396         (m32c_unwind_sp): Delete.
4397         (m32c_dummy_id): Delete.
4398         (m32c_gdbarch_init): Don't register deleted functions with
4399         gdbarch.
4400
4401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4404         (lm32_unwind_pc): Delete.
4405         (lm32_dummy_id): Delete.
4406         (lm32_gdbarch_init): Don't register deleted functions with
4407         gdbarch.
4408
4409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4412         (iq2000_unwind_pc): Delete.
4413         (iq2000_dummy_id): Delete.
4414         (iq2000_gdbarch_init): Don't register deleted functions with
4415         gdbarch.
4416
4417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * nds32-tdep.c (nds32_type_align): Delete.
4420         (nds32_push_dummy_call): Use type_align instead.
4421
4422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * arm-tdep.c (arm_type_align): Only handle vector override case.
4425         (arm_push_dummy_call): Use type_align.
4426         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4427
4428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4429
4430         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4431         case.
4432         (pass_on_stack): Use type_align.
4433         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4434         function.
4435
4436 2019-04-23  Tom Tromey  <tromey@adacore.com>
4437
4438         * dwarf2read.c (line_header::file_name_at): Remove unused
4439         overload.
4440
4441 2019-04-23  Tom de Vries  <tdevries@suse.de>
4442
4443         PR gdb/24438
4444         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4445         invocation.
4446
4447
4448 2019-03-27  Ali Tamur  <tamur@google.com>
4449
4450         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4451         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4452         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4453         (dwarf_expr_context::get_addr_index): Likewise
4454         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4455         (symbol_needs_eval_context::get_addr_index): Likewise
4456         (disassemble_dwarf_expression): Add DW_OP_addrx
4457         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4458         (read_cutu_die_from_dwo): Update comment
4459         (skip_one_die): Add DW_FORM_addrx
4460         (read_attribute_value): Likewise
4461         (var_decode_location): Add DW_OP_addrx
4462         (dwarf2_const_value_attr): Add DW_FORM_addrx
4463         (dump_die_shallow): Likewise
4464         (dwarf2_fetch_constant_bytes): Likewise
4465         (decode_locdesc): Add DW_OP_addrx
4466         (skip_form_bytes): Add DW_FORM_addrx
4467
4468 2019-04-22  Ali Tamur  <tamur@google.com>
4469
4470         * MAINTAINERS (Write After Approval): Add self.
4471
4472 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4473
4474         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4475         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4476         (open_symbol_file_object): Likewise.
4477         (svr4_default_sos): Add info parameter.
4478         (svr4_read_so_list): Likewise.
4479         (svr4_current_sos_direct): Adjust functions calls to pass down
4480         info.
4481         (svr4_current_sos_1): Add info parameter.
4482         (svr4_current_sos): Call get_svr4_info, pass info down to
4483         svr4_current_sos_1.
4484         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4485         get_svr4_info.
4486         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4487         get_svr4_info.
4488         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4489         to get_svr4_info.
4490         (probes_table_remove_objfile_probes): Likewise.
4491         (register_solib_event_probe): Add info parameter.
4492         (solist_update_incremental): Pass info parameter down to
4493         svr4_read_so_list.
4494         (disable_probes_interface): Add info parameter.
4495         (svr4_handle_solib_event): Pass current_program_space to
4496         get_svr4_info.  Adjust disable_probes_interface cleanup.
4497         (svr4_create_probe_breakpoints): Add info parameter, pass it
4498         down to register_solib_event_probe.
4499         (svr4_create_solib_event_breakpoints): Add info parameter,
4500         pass it down to svr4_create_probe_breakpoints.
4501         (enable_break): Pass info down to
4502         svr4_create_solib_event_breakpoints.
4503         (svr4_solib_create_inferior_hook): Pass current_program_space to
4504         get_svr4_info.
4505         (svr4_clear_solib): Likewise.
4506
4507 2019-04-22  Pedro Alves  <palves@redhat.com>
4508
4509         * solib-svr4.c (svr4_free_objfile_observer): New.
4510         (probe_and_action::objfile): New field.
4511         (probes_table_htab_remove_objfile_probes)
4512         (probes_table_remove_objfile_probes): New functions.
4513         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4514         in the new probe_and_action.  Don't store the probe in 'lookup'.
4515         (svr4_create_probe_breakpoints): Pass objfile to
4516         register_solib_event_probe.
4517         (_initialize_svr4_solib): Register a free_objfile observer.
4518
4519 2019-04-19  Tom Tromey  <tom@tromey.com>
4520
4521         * common/queue.h: Remove.
4522
4523 2019-04-19  Tom Tromey  <tom@tromey.com>
4524
4525         * event-loop.c: Don't include "common/queue.h".
4526
4527 2019-04-19  Tom Tromey  <tom@tromey.com>
4528
4529         * remote.c (remote_target): Use delete.
4530         * remote-notif.h: Include <list>, not "common/queue.h".
4531         (notif_client_p): Remove typedef.
4532         (remote_notif_state): Add constructor, destructor, initializer.
4533         <notif_queue>: Now a std::list.
4534         (remote_notif_state_xfree): Don't declare.
4535         * remote-notif.c (remote_notif_process, handle_notification)
4536         (remote_notif_state_allocate): Update.
4537         (~remote_notif_state): Rename from remote_notif_state_xfree.
4538
4539 2019-04-19  Tom Tromey  <tom@tromey.com>
4540
4541         * symfile.c (reread_symbols): Update.
4542         * objfiles.c (objfile_register_static_link)
4543         (objfile_lookup_static_link): Update
4544         (~objfile) Don't delete static_links.
4545         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4546
4547 2019-04-19  Tom Tromey  <tom@tromey.com>
4548
4549         * type-stack.h (struct type_stack) <insert>: Constify string.
4550         * type-stack.c (type_stack::insert): Constify string.
4551         * gdbtypes.h (lookup_template_type): Update.
4552         (address_space_name_to_int): Update.
4553         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4554         const.
4555         (lookup_template_type): Make name const.
4556         * c-exp.y: Update rules.
4557         (lex_one_token, classify_name, classify_inner_name)
4558         (c_print_token): Update.
4559         * p-exp.y: Update rules.
4560         (yylex): Update.
4561         * f-exp.y: Update rules.
4562         (yylex): Update.
4563         * d-exp.y: Update rules.
4564         (lex_one_token, classify_name, classify_inner_name): Update.
4565         * parse.c (write_dollar_variable, copy_name): Return std::string.
4566         * parser-defs.h (copy_name): Change return type.
4567         * m2-exp.y: Update rules.
4568         (yylex): Update.
4569         * go-exp.y (lex_one_token): Update.
4570         Update rules.
4571         (classify_unsafe_function, classify_packaged_name)
4572         (classify_name, yylex): Update.
4573
4574 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4575
4576         * configure.ac: add --enable-source-highlight switch.
4577         * configure: Regenerate.
4578         * top.c (print_gdb_version): plumb --enable-source-highlight
4579         status to "show configuration".
4580
4581 2019-04-19  Tom Tromey  <tromey@adacore.com>
4582
4583         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4584         Check ADA_TYPE_P.
4585         (empty_record, ada_template_to_fixed_record_type_1)
4586         (template_to_static_fixed_type)
4587         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4588         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4589         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4590         macros.
4591
4592 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4593
4594         PR symtab/24423:
4595         * source.c (print_source_lines_base): Advance "iter" when a
4596         control character is seen.
4597
4598 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4599
4600         * inferior.h (struct infcall_suspend_state_deleter):
4601         Catch exception in destructor to avoid crash.
4602
4603 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4604
4605         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4606         close to the add_com "shell".
4607
4608 2019-04-18  Tom Tromey  <tromey@adacore.com>
4609
4610         * process-stratum-target.h (class process_stratum_target)
4611         <stratum>: Add "final".
4612
4613 2019-04-17  Tom Tromey  <tromey@adacore.com>
4614
4615         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4616         against nullptr before use.
4617
4618 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4619
4620         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4621
4622 2019-04-17  Jim Wilson  <jimw@sifive.com>
4623             Andrew Burgess  <andrew.burgess@embecosm.com>
4624
4625         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4626         code read might fail, assume 4-byte breakpoint in that case.
4627
4628 2019-04-15  Leszek Swirski  <leszeks@google.com>
4629
4630         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4631         rather than a hand-rolled POD check when checking for forced MEMORY
4632         classification.
4633
4634 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4635
4636         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4637         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4638         function.
4639         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4640         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4641         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4642         declaration.
4643
4644 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4645
4646         * aarch64-linux-nat.c
4647         (aarch64_linux_nat_target::thread_architecture): Add override.
4648         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4649         each VQ.
4650
4651 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4652
4653         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4654
4655 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4658         target types of size 96-bits, add some additional comments, and
4659         check that the builtin type we found was the correct size.
4660
4661 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4662
4663         * utils.c (prompt_for_continue): Don't restore the styling at the
4664         end, as applied_style has the wrong value.  This fixes styling in
4665         long lists of file names that are interrupted by the "Continue?"
4666         prompt.
4667
4668 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4669
4670         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4671         * c-lang.c (c_language_defn): Likewise.
4672         (cplus_language_defn): Likewise.
4673         (asm_language_defn): Likewise.
4674         (minimal_language_defn): Likewise.
4675         * d-lang.c (d_language_defn): Likewise.
4676         * f-lang.c (f_language_defn): Likewise.
4677         * go-lang.c (go_language_defn): Likewise.
4678         * language.c (unknown_language_defn): Likewise.
4679         (auto_language_defn): Likewise.
4680         * language.h (struct language_defn): Remove la_magic field.
4681         (LANG_MAGIC): Delete.
4682         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4683         * objc-lang.c (objc_language_defn): Likewise.
4684         * opencl-lang.c (opencl_language_defn): Likewise.
4685         * p-lang.c (pascal_language_defn): Likewise.
4686         * rust-lang.c (rust_language_defn): Likewise.
4687
4688 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * riscv-tdep.c (riscv_type_align): New function.
4691         (riscv_type_alignment): Delete.
4692         (riscv_arg_location): Use 'type_align'.
4693         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4694
4695 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4696
4697         * gdbtypes.c (type_align): A struct with no non-static fields also
4698         has alignment of 1.
4699
4700 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4701
4702         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4703         component to 0.
4704         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4705         member.
4706         (riscv_struct_info::analyse): New implementation using new
4707         analyse_inner member function.
4708         (riscv_struct_info::field_offset): New member function.
4709         (riscv_struct_info::m_offsets): New member variable.
4710         (riscv_struct_info::analyse_inner): New private member function,
4711         takes the old implementation of riscv_struct_info::analyse but
4712         extended to track field offsets.
4713         (riscv_call_arg_struct): Update the struct folding special cases
4714         to handle cases where empty C++ structs, which are non-zero
4715         length, are found.
4716         (riscv_arg_location): Initialise the length of each location, a
4717         non-zero length now indicates the location is in use.
4718         (riscv_push_dummy_call): Allow for the first location having a
4719         non-zero offset when setting up arguments.
4720         (riscv_return_value): Likewise, but for return values.
4721
4722 2019-04-11  Tom Tromey  <tromey@adacore.com>
4723
4724         * utils.c (internal_vproblem): Make "msg" const.
4725
4726 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4727
4728         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4729         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4730         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4731         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4732
4733 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4734
4735         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4736         function.
4737         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4738         of amd64_collect_native_gregset.
4739         (amd64_linux_nat_target::store_registers): Likewise.
4740
4741 2019-04-10  Tom Tromey  <tom@tromey.com>
4742
4743         * symtab.c (lookup_global_symbol_from_objfile)
4744         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4745         * objfiles.h (class separate_debug_iterator): New.
4746         (class separate_debug_range): New.
4747         (struct objfile) <separate_debug_objfiles>: New method.
4748         (objfile_separate_debug_iterate): Don't declare.
4749         * objfiles.c (separate_debug_iterator::operator++): Rename from
4750         objfile_separate_debug_iterate.
4751         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4752         iterator.
4753         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4754         iterator.
4755
4756 2019-04-10  Tom Tromey  <tom@tromey.com>
4757
4758         * symfile.c (reread_symbols): Remove old comment.
4759         * objfiles.c (free_all_objfiles): Fix a typo.
4760
4761 2019-04-10  Tom Tromey  <tom@tromey.com>
4762
4763         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4764         * minsyms.c (lookup_minimal_symbol): Use foreach.
4765         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4766         (lookup_minimal_symbol_solib_trampoline): Likewise.
4767         * symfile.c (reread_symbols): Use foreach.
4768
4769 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4770             Tom Tromey  <tromey@adacore.com>
4771
4772         PR rust/24414:
4773         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4774         (rust_lex_int_test): Change "value" to be LONGEST.
4775         (rust_lex_tests): Add test for long integer literal.
4776
4777 2019-04-09  Tom Tromey  <tromey@adacore.com>
4778
4779         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4780         to bool.
4781         (extended_remote_target::attach): Update.
4782         (remote_target::remote_notice_new_inferior): Update.
4783         (remote_target::add_current_inferior_and_thread): Update.
4784         * inferior.c (exit_inferior_1): Use "false".
4785         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4786
4787 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4788
4789         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4790         the "start" command.
4791
4792 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4793
4794         * python/py-inferior.c (infpy_thread_from_thread_handle):
4795         Adjust comments to reflect renaming of thread_from_thread_handle
4796         to thread_from_handle.  Adjust keywords.  Fix type error message.
4797         (inferior_object_methods): Add thread_from_handle.  Retain
4798         thread_from_thread_handle, but mark it as deprecated.
4799
4800 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4801
4802         * gdbthread.h (find_thread_by_handle): Revise declaration.
4803         * thread.c (find_thread_by_handle): Likewise.  Adjust
4804         implementation too.
4805         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4806         support for buffer objects as handles.
4807
4808 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4809
4810         * python/py-infthread.c (thpy_thread_handle): New function.
4811         (thread_object_methods): Register thpy_thread_handle.
4812
4813 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4814
4815         * gdbthread.h (thread_to_thread_handle): Declare.
4816         * thread.c (gdbtypes.h): Include.
4817         (thread_to_thread_handle): New function.
4818
4819         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4820         (target_thread_info_to_thread_handle): Declare.
4821         * target.c (target_thread_info_to_thread_handle): New function.
4822         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4823         * target-delegates.c: Regenerate.
4824
4825         * linux-thread-db.c (class thread_db_target): Add method
4826         thread_info_to_thread_handle.
4827         (thread_db_target::thread_info_to_thread_handle): Define.
4828         * remote.c (class remote_target): Add new method
4829         thread_info_to_thread_handle.
4830         (remote_target::thread_info_to_thread_handle): Define.
4831
4832 2019-04-08  Pedro Alves  <palves@redhat.com>
4833
4834         * common/common-exceptions.c (throw_exception): Don't create
4835         named object to throw; throw directly.
4836         (throw_it): Likewise.  Don't initialize gdb_exception::message
4837         here, with new; pass FMT and AP to the ctor instead.
4838         * common/common-exceptions.h: Include <string>.
4839         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4840         const char *, va_list)): New ctor.  Use std::make_shared.
4841         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4842         errors)): Delete.
4843         (gdb_exception_error::gdb_exception_error(enum errors, const char
4844         *, va_list)): New.
4845         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4846         Add assertion.
4847         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4848         errors)): Delete.
4849         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4850         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4851         Add assertion.
4852
4853 2019-04-08  Tom Tromey  <tom@tromey.com>
4854
4855         * valops.c (value_rtti_indirect_type): Replace throw_exception
4856         with throw.
4857         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4858         with throw.
4859         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4860         throw.
4861         * target.c (target_translate_tls_address): Replace throw_exception
4862         with throw.
4863         * stack.c (frame_apply_command_count): Replace throw_exception
4864         with throw.
4865         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4866         throw.
4867         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4868         with throw.
4869         * rs6000-tdep.c (rs6000_frame_cache)
4870         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4871         * remote.c: Replace throw_exception with throw.
4872         * record-full.c (record_full_message, record_full_wait_1)
4873         (record_full_restore): Replace throw_exception with throw.
4874         * record-btrace.c:
4875         (get_thread_current_frame_id, record_btrace_start_replaying)
4876         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4877         (cmd_record_btrace_start): Replace throw_exception with throw.
4878         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4879         throw.
4880         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4881         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4882         * linespec.c:
4883         (find_linespec_symbols): Replace throw_exception with throw.
4884         * infrun.c (displaced_step_prepare, resume): Replace
4885         throw_exception with throw.
4886         * infcmd.c (post_create_inferior): Replace throw_exception with
4887         throw.
4888         * inf-loop.c (inferior_event_handler): Replace throw_exception
4889         with throw.
4890         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4891         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4892         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4893         (get_prev_frame_always, get_frame_pc_if_available)
4894         (get_frame_address_in_block_if_available, get_frame_language):
4895         Replace throw_exception with throw.
4896         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4897         throw_exception with throw.
4898         * eval.c (fetch_subexp_value, evaluate_var_value)
4899         (evaluate_funcall, evaluate_subexp_standard): Replace
4900         throw_exception with throw.
4901         * dwarf2loc.c (call_site_find_chain)
4902         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4903         Replace throw_exception with throw.
4904         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4905         with throw.
4906         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4907         throw.
4908         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4909         * completer.c (complete_line_internal): Replace throw_exception
4910         with throw.
4911         * compile/compile-object-run.c (compile_object_run): Replace
4912         throw_exception with throw.
4913         * cli/cli-script.c (process_next_line): Replace throw_exception
4914         with throw.
4915         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4916         (btrace_enable, btrace_maint_update_pt_packets): Replace
4917         throw_exception with throw.
4918         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4919         throw_exception with throw.
4920         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4921         throw_exception with throw.
4922         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4923         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4924         * aarch64-tdep.c (aarch64_make_prologue_cache)
4925         (aarch64_make_stub_cache): Replace throw_exception with throw.
4926
4927 2019-04-08  Tom Tromey  <tom@tromey.com>
4928
4929         * common/common-exceptions.c (throw_exception): Rename from
4930         throw_exception_cxx.  Remove old copy.  Make argument const.
4931         (throw_it): Create and throw exception objects directly.
4932         * common/common-exceptions.h (throw_exception): Make argument
4933         const.
4934         (struct gdb_exception_error): Add constructor.
4935         (struct gdb_exception_quit): Add constructor.
4936
4937 2019-04-08  Tom Tromey  <tom@tromey.com>
4938
4939         * common/common-exceptions.h (exception_rethrow): Don't declare.
4940         (TRY_SJLJ): Update comment.
4941         (TRY, CATCH, END_CATCH): Remove.
4942         * common/common-exceptions.c (exception_rethrow): Remove.
4943
4944 2019-04-08  Tom Tromey  <tom@tromey.com>
4945
4946         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4947         Remove.
4948         (gdb_exception_error): Rename from
4949         gdb_exception_RETURN_MASK_ERROR.
4950         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4951         (gdb_quit_bad_alloc): Update.
4952         * aarch64-tdep.c: Update.
4953         * ada-lang.c: Update.
4954         * ada-typeprint.c: Update.
4955         * ada-valprint.c: Update.
4956         * amd64-tdep.c: Update.
4957         * arch-utils.c: Update.
4958         * break-catch-throw.c: Update.
4959         * breakpoint.c: Update.
4960         * btrace.c: Update.
4961         * c-varobj.c: Update.
4962         * cli/cli-cmds.c: Update.
4963         * cli/cli-interp.c: Update.
4964         * cli/cli-script.c: Update.
4965         * common/common-exceptions.c: Update.
4966         * common/new-op.c: Update.
4967         * common/selftest.c: Update.
4968         * compile/compile-c-symbols.c: Update.
4969         * compile/compile-cplus-symbols.c: Update.
4970         * compile/compile-object-load.c: Update.
4971         * compile/compile-object-run.c: Update.
4972         * completer.c: Update.
4973         * corelow.c: Update.
4974         * cp-abi.c: Update.
4975         * cp-support.c: Update.
4976         * cp-valprint.c: Update.
4977         * darwin-nat.c: Update.
4978         * disasm-selftests.c: Update.
4979         * dtrace-probe.c: Update.
4980         * dwarf-index-cache.c: Update.
4981         * dwarf-index-write.c: Update.
4982         * dwarf2-frame-tailcall.c: Update.
4983         * dwarf2-frame.c: Update.
4984         * dwarf2loc.c: Update.
4985         * dwarf2read.c: Update.
4986         * eval.c: Update.
4987         * event-loop.c: Update.
4988         * event-top.c: Update.
4989         * exec.c: Update.
4990         * f-valprint.c: Update.
4991         * fbsd-tdep.c: Update.
4992         * frame-unwind.c: Update.
4993         * frame.c: Update.
4994         * gdbtypes.c: Update.
4995         * gnu-v3-abi.c: Update.
4996         * guile/guile-internal.h: Update.
4997         * guile/scm-block.c: Update.
4998         * guile/scm-breakpoint.c: Update.
4999         * guile/scm-cmd.c: Update.
5000         * guile/scm-disasm.c: Update.
5001         * guile/scm-frame.c: Update.
5002         * guile/scm-lazy-string.c: Update.
5003         * guile/scm-math.c: Update.
5004         * guile/scm-param.c: Update.
5005         * guile/scm-ports.c: Update.
5006         * guile/scm-pretty-print.c: Update.
5007         * guile/scm-symbol.c: Update.
5008         * guile/scm-symtab.c: Update.
5009         * guile/scm-type.c: Update.
5010         * guile/scm-value.c: Update.
5011         * i386-linux-tdep.c: Update.
5012         * i386-tdep.c: Update.
5013         * inf-loop.c: Update.
5014         * infcall.c: Update.
5015         * infcmd.c: Update.
5016         * infrun.c: Update.
5017         * jit.c: Update.
5018         * language.c: Update.
5019         * linespec.c: Update.
5020         * linux-fork.c: Update.
5021         * linux-nat.c: Update.
5022         * linux-tdep.c: Update.
5023         * linux-thread-db.c: Update.
5024         * main.c: Update.
5025         * mi/mi-cmd-break.c: Update.
5026         * mi/mi-cmd-stack.c: Update.
5027         * mi/mi-interp.c: Update.
5028         * mi/mi-main.c: Update.
5029         * objc-lang.c: Update.
5030         * p-valprint.c: Update.
5031         * parse.c: Update.
5032         * ppc-linux-tdep.c: Update.
5033         * printcmd.c: Update.
5034         * python/py-arch.c: Update.
5035         * python/py-breakpoint.c: Update.
5036         * python/py-cmd.c: Update.
5037         * python/py-finishbreakpoint.c: Update.
5038         * python/py-frame.c: Update.
5039         * python/py-framefilter.c: Update.
5040         * python/py-gdb-readline.c: Update.
5041         * python/py-inferior.c: Update.
5042         * python/py-infthread.c: Update.
5043         * python/py-lazy-string.c: Update.
5044         * python/py-linetable.c: Update.
5045         * python/py-objfile.c: Update.
5046         * python/py-param.c: Update.
5047         * python/py-prettyprint.c: Update.
5048         * python/py-progspace.c: Update.
5049         * python/py-record-btrace.c: Update.
5050         * python/py-record.c: Update.
5051         * python/py-symbol.c: Update.
5052         * python/py-type.c: Update.
5053         * python/py-unwind.c: Update.
5054         * python/py-utils.c: Update.
5055         * python/py-value.c: Update.
5056         * python/python.c: Update.
5057         * record-btrace.c: Update.
5058         * record-full.c: Update.
5059         * remote-fileio.c: Update.
5060         * remote.c: Update.
5061         * riscv-tdep.c: Update.
5062         * rs6000-aix-tdep.c: Update.
5063         * rs6000-tdep.c: Update.
5064         * rust-exp.y: Update.
5065         * rust-lang.c: Update.
5066         * s390-tdep.c: Update.
5067         * selftest-arch.c: Update.
5068         * solib-dsbt.c: Update.
5069         * solib-frv.c: Update.
5070         * solib-spu.c: Update.
5071         * solib-svr4.c: Update.
5072         * solib.c: Update.
5073         * sparc64-linux-tdep.c: Update.
5074         * stack.c: Update.
5075         * symfile-mem.c: Update.
5076         * symmisc.c: Update.
5077         * target.c: Update.
5078         * thread.c: Update.
5079         * top.c: Update.
5080         * tracefile-tfile.c: Update.
5081         * tui/tui.c: Update.
5082         * typeprint.c: Update.
5083         * unittests/cli-utils-selftests.c: Update.
5084         * unittests/parse-connection-spec-selftests.c: Update.
5085         * valops.c: Update.
5086         * valprint.c: Update.
5087         * value.c: Update.
5088         * varobj.c: Update.
5089         * windows-nat.c: Update.
5090         * x86-linux-nat.c: Update.
5091         * xml-support.c: Update.
5092
5093 2019-04-08  Tom Tromey  <tom@tromey.com>
5094
5095         * xml-support.c: Use C++ exception handling.
5096         * x86-linux-nat.c: Use C++ exception handling.
5097         * windows-nat.c: Use C++ exception handling.
5098         * varobj.c: Use C++ exception handling.
5099         * value.c: Use C++ exception handling.
5100         * valprint.c: Use C++ exception handling.
5101         * valops.c: Use C++ exception handling.
5102         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5103         handling.
5104         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5105         * typeprint.c: Use C++ exception handling.
5106         * tui/tui.c: Use C++ exception handling.
5107         * tracefile-tfile.c: Use C++ exception handling.
5108         * top.c: Use C++ exception handling.
5109         * thread.c: Use C++ exception handling.
5110         * target.c: Use C++ exception handling.
5111         * symmisc.c: Use C++ exception handling.
5112         * symfile-mem.c: Use C++ exception handling.
5113         * stack.c: Use C++ exception handling.
5114         * sparc64-linux-tdep.c: Use C++ exception handling.
5115         * solib.c: Use C++ exception handling.
5116         * solib-svr4.c: Use C++ exception handling.
5117         * solib-spu.c: Use C++ exception handling.
5118         * solib-frv.c: Use C++ exception handling.
5119         * solib-dsbt.c: Use C++ exception handling.
5120         * selftest-arch.c: Use C++ exception handling.
5121         * s390-tdep.c: Use C++ exception handling.
5122         * rust-lang.c: Use C++ exception handling.
5123         * rust-exp.y: Use C++ exception handling.
5124         * rs6000-tdep.c: Use C++ exception handling.
5125         * rs6000-aix-tdep.c: Use C++ exception handling.
5126         * riscv-tdep.c: Use C++ exception handling.
5127         * remote.c: Use C++ exception handling.
5128         * remote-fileio.c: Use C++ exception handling.
5129         * record-full.c: Use C++ exception handling.
5130         * record-btrace.c: Use C++ exception handling.
5131         * python/python.c: Use C++ exception handling.
5132         * python/py-value.c: Use C++ exception handling.
5133         * python/py-utils.c: Use C++ exception handling.
5134         * python/py-unwind.c: Use C++ exception handling.
5135         * python/py-type.c: Use C++ exception handling.
5136         * python/py-symbol.c: Use C++ exception handling.
5137         * python/py-record.c: Use C++ exception handling.
5138         * python/py-record-btrace.c: Use C++ exception handling.
5139         * python/py-progspace.c: Use C++ exception handling.
5140         * python/py-prettyprint.c: Use C++ exception handling.
5141         * python/py-param.c: Use C++ exception handling.
5142         * python/py-objfile.c: Use C++ exception handling.
5143         * python/py-linetable.c: Use C++ exception handling.
5144         * python/py-lazy-string.c: Use C++ exception handling.
5145         * python/py-infthread.c: Use C++ exception handling.
5146         * python/py-inferior.c: Use C++ exception handling.
5147         * python/py-gdb-readline.c: Use C++ exception handling.
5148         * python/py-framefilter.c: Use C++ exception handling.
5149         * python/py-frame.c: Use C++ exception handling.
5150         * python/py-finishbreakpoint.c: Use C++ exception handling.
5151         * python/py-cmd.c: Use C++ exception handling.
5152         * python/py-breakpoint.c: Use C++ exception handling.
5153         * python/py-arch.c: Use C++ exception handling.
5154         * printcmd.c: Use C++ exception handling.
5155         * ppc-linux-tdep.c: Use C++ exception handling.
5156         * parse.c: Use C++ exception handling.
5157         * p-valprint.c: Use C++ exception handling.
5158         * objc-lang.c: Use C++ exception handling.
5159         * mi/mi-main.c: Use C++ exception handling.
5160         * mi/mi-interp.c: Use C++ exception handling.
5161         * mi/mi-cmd-stack.c: Use C++ exception handling.
5162         * mi/mi-cmd-break.c: Use C++ exception handling.
5163         * main.c: Use C++ exception handling.
5164         * linux-thread-db.c: Use C++ exception handling.
5165         * linux-tdep.c: Use C++ exception handling.
5166         * linux-nat.c: Use C++ exception handling.
5167         * linux-fork.c: Use C++ exception handling.
5168         * linespec.c: Use C++ exception handling.
5169         * language.c: Use C++ exception handling.
5170         * jit.c: Use C++ exception handling.
5171         * infrun.c: Use C++ exception handling.
5172         * infcmd.c: Use C++ exception handling.
5173         * infcall.c: Use C++ exception handling.
5174         * inf-loop.c: Use C++ exception handling.
5175         * i386-tdep.c: Use C++ exception handling.
5176         * i386-linux-tdep.c: Use C++ exception handling.
5177         * guile/scm-value.c: Use C++ exception handling.
5178         * guile/scm-type.c: Use C++ exception handling.
5179         * guile/scm-symtab.c: Use C++ exception handling.
5180         * guile/scm-symbol.c: Use C++ exception handling.
5181         * guile/scm-pretty-print.c: Use C++ exception handling.
5182         * guile/scm-ports.c: Use C++ exception handling.
5183         * guile/scm-param.c: Use C++ exception handling.
5184         * guile/scm-math.c: Use C++ exception handling.
5185         * guile/scm-lazy-string.c: Use C++ exception handling.
5186         * guile/scm-frame.c: Use C++ exception handling.
5187         * guile/scm-disasm.c: Use C++ exception handling.
5188         * guile/scm-cmd.c: Use C++ exception handling.
5189         * guile/scm-breakpoint.c: Use C++ exception handling.
5190         * guile/scm-block.c: Use C++ exception handling.
5191         * guile/guile-internal.h: Use C++ exception handling.
5192         * gnu-v3-abi.c: Use C++ exception handling.
5193         * gdbtypes.c: Use C++ exception handling.
5194         * frame.c: Use C++ exception handling.
5195         * frame-unwind.c: Use C++ exception handling.
5196         * fbsd-tdep.c: Use C++ exception handling.
5197         * f-valprint.c: Use C++ exception handling.
5198         * exec.c: Use C++ exception handling.
5199         * event-top.c: Use C++ exception handling.
5200         * event-loop.c: Use C++ exception handling.
5201         * eval.c: Use C++ exception handling.
5202         * dwarf2read.c: Use C++ exception handling.
5203         * dwarf2loc.c: Use C++ exception handling.
5204         * dwarf2-frame.c: Use C++ exception handling.
5205         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5206         * dwarf-index-write.c: Use C++ exception handling.
5207         * dwarf-index-cache.c: Use C++ exception handling.
5208         * dtrace-probe.c: Use C++ exception handling.
5209         * disasm-selftests.c: Use C++ exception handling.
5210         * darwin-nat.c: Use C++ exception handling.
5211         * cp-valprint.c: Use C++ exception handling.
5212         * cp-support.c: Use C++ exception handling.
5213         * cp-abi.c: Use C++ exception handling.
5214         * corelow.c: Use C++ exception handling.
5215         * completer.c: Use C++ exception handling.
5216         * compile/compile-object-run.c: Use C++ exception handling.
5217         * compile/compile-object-load.c: Use C++ exception handling.
5218         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5219         * compile/compile-c-symbols.c: Use C++ exception handling.
5220         * common/selftest.c: Use C++ exception handling.
5221         * common/new-op.c: Use C++ exception handling.
5222         * cli/cli-script.c: Use C++ exception handling.
5223         * cli/cli-interp.c: Use C++ exception handling.
5224         * cli/cli-cmds.c: Use C++ exception handling.
5225         * c-varobj.c: Use C++ exception handling.
5226         * btrace.c: Use C++ exception handling.
5227         * breakpoint.c: Use C++ exception handling.
5228         * break-catch-throw.c: Use C++ exception handling.
5229         * arch-utils.c: Use C++ exception handling.
5230         * amd64-tdep.c: Use C++ exception handling.
5231         * ada-valprint.c: Use C++ exception handling.
5232         * ada-typeprint.c: Use C++ exception handling.
5233         * ada-lang.c: Use C++ exception handling.
5234         * aarch64-tdep.c: Use C++ exception handling.
5235
5236 2019-04-08  Tom Tromey  <tom@tromey.com>
5237
5238         * xml-support.c (gdb_xml_parser::parse): Update.
5239         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5240         * value.c (show_convenience): Update.
5241         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5242         (test_parse_flags_qcs): Update.
5243         * thread.c (thr_try_catch_cmd): Update.
5244         * target.c (target_translate_tls_address): Update.
5245         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5246         (info_frame_command_core, frame_apply_command_count): Update.
5247         * rust-exp.y (rust_lex_exception_test): Update.
5248         * riscv-tdep.c (riscv_print_one_register_info): Update.
5249         * remote.c (remote_target::enable_btrace): Update.
5250         * record-btrace.c (record_btrace_enable_warn): Update.
5251         * python/py-utils.c (gdbpy_convert_exception): Update.
5252         * printcmd.c (do_one_display, print_variable_and_value): Update.
5253         * mi/mi-main.c (mi_print_exception): Update.
5254         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5255         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5256         * linux-nat.c (linux_nat_target::attach): Update.
5257         * linux-fork.c (class scoped_switch_fork_info): Update.
5258         * infrun.c (displaced_step_prepare): Update.
5259         * infcall.c (call_function_by_hand_dummy): Update.
5260         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5261         * gnu-v3-abi.c (print_one_vtable): Update.
5262         * frame.c (get_prev_frame_always): Update.
5263         * f-valprint.c (info_common_command_for_block): Update.
5264         * exec.c (try_open_exec_file): Update.
5265         * exceptions.c (print_exception, exception_print)
5266         (exception_fprintf, exception_print_same): Update.
5267         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5268         * dwarf-index-cache.c (index_cache::store)
5269         (index_cache::lookup_gdb_index): Update.
5270         * darwin-nat.c (maybe_cache_shell): Update.
5271         * cp-valprint.c (cp_print_value_fields): Update.
5272         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5273         (gcc_cplus_symbol_address): Update.
5274         * compile/compile-c-symbols.c (gcc_convert_symbol)
5275         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5276         * common/selftest.c: Update.
5277         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5278         a std::string.
5279         (exception_try_scope_entry, exception_try_scope_exit): Don't
5280         declare.
5281         (struct exception_try_scope): Remove.
5282         (TRY): Don't use exception_try_scope.
5283         (struct gdb_exception): Add constructor, operator=.
5284         <what>: New method.
5285         (struct gdb_exception_RETURN_MASK_ALL)
5286         (struct gdb_exception_RETURN_MASK_ERROR)
5287         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5288         (struct gdb_quit_bad_alloc): Update.
5289         * common/common-exceptions.c (exception_none): Change
5290         initializer.
5291         (struct catcher) <state, exception>: Initialize inline.
5292         <prev>: Remove member.
5293         (current_catcher): Remove.
5294         (catchers): New global.
5295         (exceptions_state_mc_init): Simplify.
5296         (catcher_pop): Remove.
5297         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5298         (try_scope_depth, exception_try_scope_entry)
5299         (exception_try_scope_exit): Remove.
5300         (throw_exception_sjlj): Update.
5301         (exception_messages, exception_messages_size): Remove.
5302         (throw_it): Simplify.
5303         (gdb_exception_sliced_copy): Remove.
5304         (throw_exception_cxx): Update.
5305         * cli/cli-script.c (script_from_file): Update.
5306         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5307         Update.
5308         * ada-valprint.c (ada_val_print): Update.
5309         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5310         (create_excep_cond_exprs): Update.
5311
5312 2019-04-08  Tom Tromey  <tom@tromey.com>
5313
5314         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5315         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5316         (TRY, CATCH, END_CATCH): Remove some definitions.
5317         * common/common-exceptions.c: Don't use GDB_XCPT.
5318         (catcher_list_size): Remove.
5319         (throw_exception, throw_it): Simplify.
5320
5321 2019-04-05  Tom Tromey  <tom@tromey.com>
5322
5323         Revert the header-sorting patch.
5324         * ft32-tdep.c: Revert.
5325         * frv-tdep.c: Revert.
5326         * frv-linux-tdep.c: Revert.
5327         * frame.c: Revert.
5328         * frame-unwind.c: Revert.
5329         * frame-base.c: Revert.
5330         * fork-child.c: Revert.
5331         * findvar.c: Revert.
5332         * findcmd.c: Revert.
5333         * filesystem.c: Revert.
5334         * filename-seen-cache.h: Revert.
5335         * filename-seen-cache.c: Revert.
5336         * fbsd-tdep.c: Revert.
5337         * fbsd-nat.h: Revert.
5338         * fbsd-nat.c: Revert.
5339         * f-valprint.c: Revert.
5340         * f-typeprint.c: Revert.
5341         * f-lang.c: Revert.
5342         * extension.h: Revert.
5343         * extension.c: Revert.
5344         * extension-priv.h: Revert.
5345         * expprint.c: Revert.
5346         * exec.h: Revert.
5347         * exec.c: Revert.
5348         * exceptions.c: Revert.
5349         * event-top.c: Revert.
5350         * event-loop.c: Revert.
5351         * eval.c: Revert.
5352         * elfread.c: Revert.
5353         * dwarf2read.h: Revert.
5354         * dwarf2read.c: Revert.
5355         * dwarf2loc.c: Revert.
5356         * dwarf2expr.h: Revert.
5357         * dwarf2expr.c: Revert.
5358         * dwarf2-frame.c: Revert.
5359         * dwarf2-frame-tailcall.c: Revert.
5360         * dwarf-index-write.h: Revert.
5361         * dwarf-index-write.c: Revert.
5362         * dwarf-index-common.c: Revert.
5363         * dwarf-index-cache.h: Revert.
5364         * dwarf-index-cache.c: Revert.
5365         * dummy-frame.c: Revert.
5366         * dtrace-probe.c: Revert.
5367         * disasm.h: Revert.
5368         * disasm.c: Revert.
5369         * disasm-selftests.c: Revert.
5370         * dictionary.c: Revert.
5371         * dicos-tdep.c: Revert.
5372         * demangle.c: Revert.
5373         * dcache.h: Revert.
5374         * dcache.c: Revert.
5375         * darwin-nat.h: Revert.
5376         * darwin-nat.c: Revert.
5377         * darwin-nat-info.c: Revert.
5378         * d-valprint.c: Revert.
5379         * d-namespace.c: Revert.
5380         * d-lang.c: Revert.
5381         * ctf.c: Revert.
5382         * csky-tdep.c: Revert.
5383         * csky-linux-tdep.c: Revert.
5384         * cris-tdep.c: Revert.
5385         * cris-linux-tdep.c: Revert.
5386         * cp-valprint.c: Revert.
5387         * cp-support.c: Revert.
5388         * cp-namespace.c: Revert.
5389         * cp-abi.c: Revert.
5390         * corelow.c: Revert.
5391         * corefile.c: Revert.
5392         * continuations.c: Revert.
5393         * completer.h: Revert.
5394         * completer.c: Revert.
5395         * complaints.c: Revert.
5396         * coffread.c: Revert.
5397         * coff-pe-read.c: Revert.
5398         * cli-out.h: Revert.
5399         * cli-out.c: Revert.
5400         * charset.c: Revert.
5401         * c-varobj.c: Revert.
5402         * c-valprint.c: Revert.
5403         * c-typeprint.c: Revert.
5404         * c-lang.c: Revert.
5405         * buildsym.c: Revert.
5406         * buildsym-legacy.c: Revert.
5407         * build-id.h: Revert.
5408         * build-id.c: Revert.
5409         * btrace.c: Revert.
5410         * bsd-uthread.c: Revert.
5411         * breakpoint.h: Revert.
5412         * breakpoint.c: Revert.
5413         * break-catch-throw.c: Revert.
5414         * break-catch-syscall.c: Revert.
5415         * break-catch-sig.c: Revert.
5416         * blockframe.c: Revert.
5417         * block.c: Revert.
5418         * bfin-tdep.c: Revert.
5419         * bfin-linux-tdep.c: Revert.
5420         * bfd-target.c: Revert.
5421         * bcache.c: Revert.
5422         * ax-general.c: Revert.
5423         * ax-gdb.h: Revert.
5424         * ax-gdb.c: Revert.
5425         * avr-tdep.c: Revert.
5426         * auxv.c: Revert.
5427         * auto-load.c: Revert.
5428         * arm-wince-tdep.c: Revert.
5429         * arm-tdep.c: Revert.
5430         * arm-symbian-tdep.c: Revert.
5431         * arm-pikeos-tdep.c: Revert.
5432         * arm-obsd-tdep.c: Revert.
5433         * arm-nbsd-tdep.c: Revert.
5434         * arm-nbsd-nat.c: Revert.
5435         * arm-linux-tdep.c: Revert.
5436         * arm-linux-nat.c: Revert.
5437         * arm-fbsd-tdep.c: Revert.
5438         * arm-fbsd-nat.c: Revert.
5439         * arm-bsd-tdep.c: Revert.
5440         * arch-utils.c: Revert.
5441         * arc-tdep.c: Revert.
5442         * arc-newlib-tdep.c: Revert.
5443         * annotate.h: Revert.
5444         * annotate.c: Revert.
5445         * amd64-windows-tdep.c: Revert.
5446         * amd64-windows-nat.c: Revert.
5447         * amd64-tdep.c: Revert.
5448         * amd64-sol2-tdep.c: Revert.
5449         * amd64-obsd-tdep.c: Revert.
5450         * amd64-obsd-nat.c: Revert.
5451         * amd64-nbsd-tdep.c: Revert.
5452         * amd64-nbsd-nat.c: Revert.
5453         * amd64-nat.c: Revert.
5454         * amd64-linux-tdep.c: Revert.
5455         * amd64-linux-nat.c: Revert.
5456         * amd64-fbsd-tdep.c: Revert.
5457         * amd64-fbsd-nat.c: Revert.
5458         * amd64-dicos-tdep.c: Revert.
5459         * amd64-darwin-tdep.c: Revert.
5460         * amd64-bsd-nat.c: Revert.
5461         * alpha-tdep.c: Revert.
5462         * alpha-obsd-tdep.c: Revert.
5463         * alpha-nbsd-tdep.c: Revert.
5464         * alpha-mdebug-tdep.c: Revert.
5465         * alpha-linux-tdep.c: Revert.
5466         * alpha-linux-nat.c: Revert.
5467         * alpha-bsd-tdep.c: Revert.
5468         * alpha-bsd-nat.c: Revert.
5469         * aix-thread.c: Revert.
5470         * agent.c: Revert.
5471         * addrmap.c: Revert.
5472         * ada-varobj.c: Revert.
5473         * ada-valprint.c: Revert.
5474         * ada-typeprint.c: Revert.
5475         * ada-tasks.c: Revert.
5476         * ada-lang.c: Revert.
5477         * aarch64-tdep.c: Revert.
5478         * aarch64-ravenscar-thread.c: Revert.
5479         * aarch64-newlib-tdep.c: Revert.
5480         * aarch64-linux-tdep.c: Revert.
5481         * aarch64-linux-nat.c: Revert.
5482         * aarch64-fbsd-tdep.c: Revert.
5483         * aarch64-fbsd-nat.c: Revert.
5484         * aarch32-linux-nat.c: Revert.
5485
5486 2019-04-05  Tom Tromey  <tom@tromey.com>
5487
5488         * ft32-tdep.c: Sort headers.
5489         * frv-tdep.c: Sort headers.
5490         * frv-linux-tdep.c: Sort headers.
5491         * frame.c: Sort headers.
5492         * frame-unwind.c: Sort headers.
5493         * frame-base.c: Sort headers.
5494         * fork-child.c: Sort headers.
5495         * findvar.c: Sort headers.
5496         * findcmd.c: Sort headers.
5497         * filesystem.c: Sort headers.
5498         * filename-seen-cache.h: Sort headers.
5499         * filename-seen-cache.c: Sort headers.
5500         * fbsd-tdep.c: Sort headers.
5501         * fbsd-nat.h: Sort headers.
5502         * fbsd-nat.c: Sort headers.
5503         * f-valprint.c: Sort headers.
5504         * f-typeprint.c: Sort headers.
5505         * f-lang.c: Sort headers.
5506         * extension.h: Sort headers.
5507         * extension.c: Sort headers.
5508         * extension-priv.h: Sort headers.
5509         * expprint.c: Sort headers.
5510         * exec.h: Sort headers.
5511         * exec.c: Sort headers.
5512         * exceptions.c: Sort headers.
5513         * event-top.c: Sort headers.
5514         * event-loop.c: Sort headers.
5515         * eval.c: Sort headers.
5516         * elfread.c: Sort headers.
5517         * dwarf2read.h: Sort headers.
5518         * dwarf2read.c: Sort headers.
5519         * dwarf2loc.c: Sort headers.
5520         * dwarf2expr.h: Sort headers.
5521         * dwarf2expr.c: Sort headers.
5522         * dwarf2-frame.c: Sort headers.
5523         * dwarf2-frame-tailcall.c: Sort headers.
5524         * dwarf-index-write.h: Sort headers.
5525         * dwarf-index-write.c: Sort headers.
5526         * dwarf-index-common.c: Sort headers.
5527         * dwarf-index-cache.h: Sort headers.
5528         * dwarf-index-cache.c: Sort headers.
5529         * dummy-frame.c: Sort headers.
5530         * dtrace-probe.c: Sort headers.
5531         * disasm.h: Sort headers.
5532         * disasm.c: Sort headers.
5533         * disasm-selftests.c: Sort headers.
5534         * dictionary.c: Sort headers.
5535         * dicos-tdep.c: Sort headers.
5536         * demangle.c: Sort headers.
5537         * dcache.h: Sort headers.
5538         * dcache.c: Sort headers.
5539         * darwin-nat.h: Sort headers.
5540         * darwin-nat.c: Sort headers.
5541         * darwin-nat-info.c: Sort headers.
5542         * d-valprint.c: Sort headers.
5543         * d-namespace.c: Sort headers.
5544         * d-lang.c: Sort headers.
5545         * ctf.c: Sort headers.
5546         * csky-tdep.c: Sort headers.
5547         * csky-linux-tdep.c: Sort headers.
5548         * cris-tdep.c: Sort headers.
5549         * cris-linux-tdep.c: Sort headers.
5550         * cp-valprint.c: Sort headers.
5551         * cp-support.c: Sort headers.
5552         * cp-namespace.c: Sort headers.
5553         * cp-abi.c: Sort headers.
5554         * corelow.c: Sort headers.
5555         * corefile.c: Sort headers.
5556         * continuations.c: Sort headers.
5557         * completer.h: Sort headers.
5558         * completer.c: Sort headers.
5559         * complaints.c: Sort headers.
5560         * coffread.c: Sort headers.
5561         * coff-pe-read.c: Sort headers.
5562         * cli-out.h: Sort headers.
5563         * cli-out.c: Sort headers.
5564         * charset.c: Sort headers.
5565         * c-varobj.c: Sort headers.
5566         * c-valprint.c: Sort headers.
5567         * c-typeprint.c: Sort headers.
5568         * c-lang.c: Sort headers.
5569         * buildsym.c: Sort headers.
5570         * buildsym-legacy.c: Sort headers.
5571         * build-id.h: Sort headers.
5572         * build-id.c: Sort headers.
5573         * btrace.c: Sort headers.
5574         * bsd-uthread.c: Sort headers.
5575         * breakpoint.h: Sort headers.
5576         * breakpoint.c: Sort headers.
5577         * break-catch-throw.c: Sort headers.
5578         * break-catch-syscall.c: Sort headers.
5579         * break-catch-sig.c: Sort headers.
5580         * blockframe.c: Sort headers.
5581         * block.c: Sort headers.
5582         * bfin-tdep.c: Sort headers.
5583         * bfin-linux-tdep.c: Sort headers.
5584         * bfd-target.c: Sort headers.
5585         * bcache.c: Sort headers.
5586         * ax-general.c: Sort headers.
5587         * ax-gdb.h: Sort headers.
5588         * ax-gdb.c: Sort headers.
5589         * avr-tdep.c: Sort headers.
5590         * auxv.c: Sort headers.
5591         * auto-load.c: Sort headers.
5592         * arm-wince-tdep.c: Sort headers.
5593         * arm-tdep.c: Sort headers.
5594         * arm-symbian-tdep.c: Sort headers.
5595         * arm-pikeos-tdep.c: Sort headers.
5596         * arm-obsd-tdep.c: Sort headers.
5597         * arm-nbsd-tdep.c: Sort headers.
5598         * arm-nbsd-nat.c: Sort headers.
5599         * arm-linux-tdep.c: Sort headers.
5600         * arm-linux-nat.c: Sort headers.
5601         * arm-fbsd-tdep.c: Sort headers.
5602         * arm-fbsd-nat.c: Sort headers.
5603         * arm-bsd-tdep.c: Sort headers.
5604         * arch-utils.c: Sort headers.
5605         * arc-tdep.c: Sort headers.
5606         * arc-newlib-tdep.c: Sort headers.
5607         * annotate.h: Sort headers.
5608         * annotate.c: Sort headers.
5609         * amd64-windows-tdep.c: Sort headers.
5610         * amd64-windows-nat.c: Sort headers.
5611         * amd64-tdep.c: Sort headers.
5612         * amd64-sol2-tdep.c: Sort headers.
5613         * amd64-obsd-tdep.c: Sort headers.
5614         * amd64-obsd-nat.c: Sort headers.
5615         * amd64-nbsd-tdep.c: Sort headers.
5616         * amd64-nbsd-nat.c: Sort headers.
5617         * amd64-nat.c: Sort headers.
5618         * amd64-linux-tdep.c: Sort headers.
5619         * amd64-linux-nat.c: Sort headers.
5620         * amd64-fbsd-tdep.c: Sort headers.
5621         * amd64-fbsd-nat.c: Sort headers.
5622         * amd64-dicos-tdep.c: Sort headers.
5623         * amd64-darwin-tdep.c: Sort headers.
5624         * amd64-bsd-nat.c: Sort headers.
5625         * alpha-tdep.c: Sort headers.
5626         * alpha-obsd-tdep.c: Sort headers.
5627         * alpha-nbsd-tdep.c: Sort headers.
5628         * alpha-mdebug-tdep.c: Sort headers.
5629         * alpha-linux-tdep.c: Sort headers.
5630         * alpha-linux-nat.c: Sort headers.
5631         * alpha-bsd-tdep.c: Sort headers.
5632         * alpha-bsd-nat.c: Sort headers.
5633         * aix-thread.c: Sort headers.
5634         * agent.c: Sort headers.
5635         * addrmap.c: Sort headers.
5636         * ada-varobj.c: Sort headers.
5637         * ada-valprint.c: Sort headers.
5638         * ada-typeprint.c: Sort headers.
5639         * ada-tasks.c: Sort headers.
5640         * ada-lang.c: Sort headers.
5641         * aarch64-tdep.c: Sort headers.
5642         * aarch64-ravenscar-thread.c: Sort headers.
5643         * aarch64-newlib-tdep.c: Sort headers.
5644         * aarch64-linux-tdep.c: Sort headers.
5645         * aarch64-linux-nat.c: Sort headers.
5646         * aarch64-fbsd-tdep.c: Sort headers.
5647         * aarch64-fbsd-nat.c: Sort headers.
5648         * aarch32-linux-nat.c: Sort headers.
5649
5650 2019-04-04  Tom Tromey  <tom@tromey.com>
5651
5652         * varobj.c (varobj_create): Update.
5653         * rust-exp.y (struct rust_parser) <update_innermost_block,
5654         lookup_symbol>: New methods.
5655         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5656         Rename.
5657         (rust_parser::rust_lookup_type)
5658         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5659         * printcmd.c (display_command, do_one_display): Update.
5660         * parser-defs.h (struct parser_state) <parser_state>: Add
5661         "tracker" parameter.
5662         (block_tracker): New member.
5663         (class innermost_block_tracker) <innermost_block_tracker>: Add
5664         "types" parameter.
5665         <reset>: Remove method.
5666         (innermost_block): Don't declare.
5667         (null_post_parser): Update.
5668         * parse.c (innermost_block): Remove global.
5669         (write_dollar_variable): Update.
5670         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5671         Remove "tracker_types" parameter.
5672         (parse_expression): Add "tracker" parameter.
5673         (parse_expression_for_completion): Update.
5674         (null_post_parser): Add "tracker" parameter.
5675         * p-exp.y: Update rules.
5676         * m2-exp.y: Update rules.
5677         * language.h (struct language_defn) <la_post_parser>: Add
5678         "tracker" parameter.
5679         * go-exp.y: Update rules.
5680         * f-exp.y: Update rules.
5681         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5682         parameter.
5683         * d-exp.y: Update rules.
5684         * c-exp.y: Update rules.
5685         * breakpoint.c (set_breakpoint_condition): Create an
5686         innermost_block_tracker.
5687         (watch_command_1): Likewise.
5688         * ada-lang.c (resolve): Add "tracker" parameter.
5689         (resolve_subexp): Likewise.
5690         * ada-exp.y (write_var_from_sym): Update.
5691
5692 2019-04-04  Tom Tromey  <tom@tromey.com>
5693
5694         * type-stack.h: New file.
5695         * type-stack.c: New file.
5696         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5697         type-stack.h.
5698         (insert_into_type_stack, insert_type, push_type, push_type_int)
5699         (insert_type_address_space, pop_type, pop_type_int)
5700         (pop_typelist, pop_type_stack, append_type_stack)
5701         (push_type_stack, get_type_stack, push_typelist)
5702         (follow_type_instance_flags, follow_types): Don't declare.
5703         * parse.c (type_stack): Remove global.
5704         (parse_exp_in_context): Update.
5705         (insert_into_type_stack, insert_type, push_type, push_type_int)
5706         (insert_type_address_space, pop_type, pop_type_int)
5707         (pop_typelist, pop_type_stack, append_type_stack)
5708         (push_type_stack, get_type_stack, push_typelist)
5709         (follow_type_instance_flags, follow_types): Remove (moved to
5710         type-stack.c).
5711         * f-exp.y (type_stack): New global.
5712         Update rules.
5713         (push_kind_type, f_parse): Update.
5714         * d-exp.y (type_stack): New global.
5715         Update rules.
5716         (d_parse): Update.
5717         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5718         Update rules.
5719         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5720         (HFILES_NO_SRCDIR): Add type-stack.h.
5721
5722 2019-04-04  Tom Tromey  <tom@tromey.com>
5723
5724         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5725         (rust_parser::convert_ast_to_expression, rust_parse)
5726         (rust_lex_test_completion, rust_lex_tests): Update.
5727         * parser-defs.h (struct expr_completion_state): New.
5728         (struct parser_state) <parser_state>: Add completion parameter.
5729         <mark_struct_expression, mark_completion_tag>: New methods.
5730         <parse_completion, m_completion_state>: New members.
5731         (prefixify_expression, null_post_parser): Update.
5732         (mark_struct_expression, mark_completion_tag): Don't declare.
5733         * parse.c (parse_completion, expout_last_struct)
5734         (expout_tag_completion_type, expout_completion_name): Remove
5735         globals.
5736         (parser_state::mark_struct_expression)
5737         (parser_state::mark_completion_tag): Now methods.
5738         (prefixify_expression): Add last_struct parameter.
5739         (prefixify_subexp): Likewise.
5740         (parse_exp_1): Update.
5741         (parse_exp_in_context): Add cstate parameter.  Update.
5742         (parse_expression_for_completion): Create an
5743         expr_completion_state.
5744         (null_post_parser): Add "completion" parameter.
5745         * p-exp.y: Update rules.
5746         (yylex): Update.
5747         * language.h (struct language_defn) <la_post_parser>: Add
5748         "completing" parameter.
5749         * go-exp.y: Update rules.
5750         (lex_one_token): Update.
5751         * expression.h (parse_completion): Don't declare.
5752         * d-exp.y: Update rules.
5753         (lex_one_token): Update rules.
5754         * c-exp.y: Update rules.
5755         (lex_one_token): Update.
5756         * ada-lang.c (resolve): Add "parse_completion" parameter.
5757         (resolve_subexp): Likewise.
5758         (ada_resolve_function): Likewise.
5759
5760 2019-04-04  Tom Tromey  <tom@tromey.com>
5761
5762         * parser-defs.h (struct parser_state) <start_arglist,
5763         end_arglist>: New methods.
5764         <arglist_len, m_funcall_chain>: New members.
5765         (arglist_len, start_arglist, end_arglist): Don't declare.
5766         * parse.c (arglist_len, funcall_chain): Remove global.
5767         (start_arglist, end_arglist): Remove functions.
5768         (parse_exp_in_context): Update.
5769         * p-exp.y: Update rules.
5770         * m2-exp.y: Update rules.
5771         * go-exp.y: Update rules.
5772         * f-exp.y: Update rules.
5773         * d-exp.y: Update rules.
5774         * c-exp.y: Update rules.
5775
5776 2019-04-04  Tom Tromey  <tom@tromey.com>
5777
5778         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5779         lex_operator, push_back>: New methods.
5780         Update all rules.
5781         (rust_parser::lex_hex, lex_escape): Rename and update.
5782         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5783         (rust_parser::lex_operator): Rename and update.
5784         (rust_parser::lex_number, rustyylex, rustyyerror)
5785         (rust_lex_test_init, rust_lex_test_sequence)
5786         (rust_lex_test_push_back, rust_lex_tests): Update.
5787         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5788         parameter.
5789         <lexptr, prev_lexptr>: New members.
5790         (lexptr, prev_lexptr): Don't declare.
5791         * parse.c (lexptr, prev_lexptr): Remove globals.
5792         (parse_exp_in_context): Update.
5793         * p-exp.y (yylex, yyerror): Update.
5794         * m2-exp.y (parse_number, yylex, yyerror): Update.
5795         * go-exp.y (lex_one_token, yyerror): Update.
5796         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5797         * d-exp.y (lex_one_token, yyerror): Update.
5798         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5799         (lex_one_token, yyerror): Update.
5800         * ada-lex.l (YY_INPUT): Update.
5801         (rewind_to_char): Update.
5802         * ada-exp.y (yyerror): Update.
5803
5804 2019-04-04  Tom Tromey  <tom@tromey.com>
5805
5806         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5807         * parser-defs.h (struct parser_state) <parser_state>: Add new
5808         parameter.
5809         <comma_terminates>: New member.
5810         (comma_terminates): Don't declare global.
5811         * parse.c (comma_terminates): Remove global.
5812         (parse_exp_in_context): Update.
5813         * p-exp.y (yylex): Update.
5814         * m2-exp.y (yylex): Update.
5815         * go-exp.y (lex_one_token): Update.
5816         * f-exp.y (yylex): Update.
5817         * d-exp.y (lex_one_token): Update.
5818         * c-exp.y (lex_one_token): Update.
5819         * ada-lex.l: Update.
5820
5821 2019-04-04  Tom Tromey  <tom@tromey.com>
5822
5823         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5824         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5825         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5826         * parser-defs.h (paren_depth): Don't declare.
5827         * parse.c (paren_depth): Remove global.
5828         (parse_exp_in_context): Update.
5829         * p-exp.y (paren_depth): New global.
5830         (pascal_parse): Initialize it.
5831         * m2-exp.y (paren_depth): New global.
5832         (m2_parse): Initialize it.
5833         * go-exp.y (paren_depth): New global.
5834         (go_parse): Initialize it.
5835         * f-exp.y (paren_depth): New global.
5836         (f_parse): Initialize it.
5837         * d-exp.y (paren_depth): New global.
5838         (d_parse): Initialize it.
5839         * c-exp.y (paren_depth): New global.
5840         (c_parse): Initialize it.
5841         * ada-lex.l (paren_depth): New global.
5842         (lexer_init): Initialize it.
5843
5844 2019-04-04  Tom Tromey  <tom@tromey.com>
5845
5846         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5847         (rust_parser::convert_ast_to_type)
5848         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5849         * parser-defs.h (struct parser_state) <parser_state>: Add
5850         parameters.  Initialize new members.
5851         <expression_context_block, expression_context_pc>: New members.
5852         * parse.c (expression_context_block, expression_context_pc):
5853         Remove globals.
5854         (parse_exp_in_context): Update.
5855         * p-exp.y: Update all rules.
5856         (yylex): Update.
5857         * m2-exp.y: Update all rules.
5858         (yylex): Update.
5859         * go-exp.y (yylex): Update.
5860         * f-exp.y (yylex): Update.
5861         * d-exp.y: Update all rules.
5862         (yylex): Update.
5863         * c-exp.y: Update all rules.
5864         (lex_one_token, classify_name, yylex, c_parse): Update.
5865         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5866
5867 2019-04-04  Tom Tromey  <tom@tromey.com>
5868
5869         * gdbarch.h, gdbarch.c: Rebuild.
5870         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5871         * stap-probe.h:
5872         (struct stap_parse_info): Replace "parser_state" with
5873         "expr_builder".
5874         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5875         (parser_state): New class.
5876         * parse.c (expr_builder): Rename.
5877         (expr_builder::release): Rename.
5878         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5879         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5880         (write_exp_elt_longcst, write_exp_elt_floatcst)
5881         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5882         (write_exp_string_vector, write_exp_bitstring)
5883         (write_exp_msymbol, mark_struct_expression)
5884         (write_dollar_variable)
5885         (insert_type_address_space, increase_expout_size): Replace
5886         "parser_state" with "expr_builder".
5887         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5888         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5889         "parser_state" with "expr_builder".
5890
5891 2019-04-04  Tom Tromey  <tom@tromey.com>
5892
5893         * rust-exp.y: Replace "parse_language" with method call.
5894         * p-exp.y:
5895         (yylex): Replace "parse_language" with method call.
5896         * m2-exp.y:
5897         (yylex): Replace "parse_language" with method call.
5898         * go-exp.y (classify_name): Replace "parse_language" with method
5899         call.
5900         * f-exp.y (yylex): Replace "parse_language" with method call.
5901         * d-exp.y (lex_one_token): Replace "parse_language" with method
5902         call.
5903         * c-exp.y:
5904         (lex_one_token, classify_name, yylex): Replace "parse_language"
5905         with method call.
5906         * ada-exp.y (find_primitive_type, type_char)
5907         (type_system_address): Replace "parse_language" with method call.
5908
5909 2019-04-04  Tom Tromey  <tom@tromey.com>
5910
5911         * rust-exp.y: Replace "parse_gdbarch" with method call.
5912         * parse.c (write_dollar_variable, insert_type_address_space):
5913         Replace "parse_gdbarch" with method call.
5914         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5915         call.
5916         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5917         call.
5918         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5919         "parse_gdbarch" with method call.
5920         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5921         with method call.
5922         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5923         "parse_gdbarch" with method call.
5924         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5925         "parse_gdbarch" with method call.
5926         * c-exp.y (parse_type, parse_number, classify_name): Replace
5927         "parse_gdbarch" with method call.
5928         * ada-lex.l: Replace "parse_gdbarch" with method call.
5929         * ada-exp.y (parse_type, find_primitive_type, type_char)
5930         (type_system_address): Replace "parse_gdbarch" with method call.
5931
5932 2019-04-04  Tom Tromey  <tom@tromey.com>
5933
5934         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5935         * stap-probe.c (stap_parse_argument): Update.
5936         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5937         initial_size parameter.
5938         * rust-exp.y (rust_lex_tests): Update.
5939         * parse.c (parser_state): Update.
5940         (parse_exp_in_context): Update.
5941         * parser-defs.h (struct parser_state) <parser_state>: Remove
5942         "initial_size" parameter.
5943
5944 2019-04-04  Tom Tromey  <tom@tromey.com>
5945
5946         * parser-defs.h (increase_expout_size): Don't declare.
5947         * parse.c (increase_expout_size): Now static.
5948
5949 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5950
5951         * gnu-nat.c (gnu_nat_target::wait): Fix
5952         target_waitstatus_to_string call.
5953
5954 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5955
5956         * eval.c (evaluate_subexp_standard): Handle internal functions
5957         during Fortran function call handling.
5958
5959 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5960
5961         * NEWS: Mention new internal functions.
5962         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5963         (read_base_type): Use dwarf2_init_complex_target_type.
5964         * value.c (creal_internal_fn): New function.
5965         (cimag_internal_fn): New function.
5966         (_initialize_values): Register new internal functions.
5967
5968 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5969
5970         * infrun.c (stop_all_threads): If debug_infrun, always
5971         trace the wait status after wait_one, using
5972         target_waitstatus_to_string and target_pid_to_str.
5973         (handle_inferior_event): Replace various trace of
5974         wait status kind by a single trace.
5975         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5976         wait status kind image by target_waitstatus_to_string.
5977         * target/waitstatus.c (target_waitstatus_to_string): Fix
5978         obsolete comment.
5979
5980 2019-04-01  Tom Tromey  <tromey@adacore.com>
5981
5982         PR symtab/23331:
5983         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5984
5985 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5986             Pedro Alves  <palves@redhat.com>
5987
5988         * top.c (quit_force): Call 'finalize_values'.
5989         * value.c (finalize_values): New function.
5990         * value.h (finalize_values): Declare.
5991
5992 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5993
5994         * NEWS: Announce $_gdb_major and $_gdb_minor.
5995
5996         * top.c (init_gdb_version_vars): New function.
5997         (gdb_init): Call init_gdb_version_vars.
5998
5999 2019-03-29  Tom Tromey  <tromey@adacore.com>
6000
6001         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6002         help text.  Remove dead code.
6003
6004 2019-03-29  Keith Seitz  <keiths@redhat.com>
6005
6006         From Siddhesh Poyarekar:
6007         * f-lang.h (f77_get_upperbound): Return LONGEST.
6008         (f77_get_lowerbound): Likewise.
6009         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6010         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6011         print them.
6012         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6013         plongest to format print it.
6014         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6015         (f77_get_upperbound): Likewise.
6016         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6017         LOWER_BOUND to LONGEST.
6018         (f77_create_arrayprint_offset_tbl): Likewise.
6019
6020 2019-03-29  Keith Seitz  <keiths@redhat.com>
6021
6022         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6023         %s/pulongest for TYPE_LENGTH instead of %d in format
6024         strings.
6025         * ada-typerint.c (ada_print_type): Likewise.
6026         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6027         * compile/compile-c-support.c (generate_register_struct): Likewise.
6028         * gdbtypes.c (recursive_dump_type): Likewise.
6029         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6030         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6031         instead of %d in format strings.
6032         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6033         to std::min to ULONGEST.
6034         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6035         instead of %d in format strings.
6036         * tracepoint.c (info_scope_command): Likewise.
6037         * typeprint.c (print_offset_data::update)
6038         (print_offset_data::finish): Likewise.
6039         * xtensa-tdep.c (xtensa_store_return_value)
6040         (xtensa_push_dummy_call): Likewise.
6041
6042 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6043
6044         * windows-nat.c (display_selector): Fixed format specifications
6045         for 64-bit Cygwin.
6046
6047 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6048
6049         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6050
6051 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6052
6053         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6054         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6055         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6056         (nios2_linux_init_abi): Install it.
6057
6058 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6059
6060         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6061
6062 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6063
6064         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6065
6066 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6067             Tom Tromey  <tromey@adacore.com>
6068
6069         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6070
6071 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6072
6073         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6074         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6075         method to compute the bounds of range types. Also print "[evaluated]"
6076         if the bounds' values come from a dynamic evaluation.
6077
6078 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6079
6080         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6081         whitespace when pretty printing is on.
6082
6083 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6084
6085         * ppc-linux-nat.c: Add include.
6086
6087 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6088
6089         * NEWS: Mention AArch64 Pointer Authentication.
6090
6091 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6092
6093         * arm-linux-nat.c: Add include.
6094
6095 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6096
6097         * source-cache.c (source_cache::get_source_lines): Re-read
6098         fullname after calling open_source_file.
6099
6100 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6101
6102         * NEWS: Mention TLS support for FreeBSD.
6103
6104 2019-03-25  Tom Tromey  <tromey@adacore.com>
6105
6106         * minsyms.c (BUNCH_SIZE): Update comment.
6107         (~minimal_symbol_reader): Remove old comment.
6108         (compact_minimal_symbols): Update comment.
6109         (minimal_symbol_reader::install): Remove old comment.  Update
6110         other comments.
6111
6112 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6113
6114         * s390-linux-nat.c: Add include.
6115
6116 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6117
6118         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6119         Call linux_get_hwcap.
6120         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6121         Likewise.
6122         (aarch64_linux_get_hwcap): Remove function.
6123         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6124         declaration.
6125         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6126         linux_get_hwcap.
6127         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6128         * linux-tdep.c (linux_get_hwcap): Add function.
6129         (linux_get_hwcap2): Likewise.
6130         * linux-tdep.h (linux_get_hwcap): Add declaration.
6131         (linux_get_hwcap2): Likewise.
6132         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6133         (ppc_linux_get_hwcap2): Likewise.
6134         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6135         linux_get_hwcap.
6136         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6137         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6138         (ppc_linux_nat_target::read_description): Likewise.
6139         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6140         * s390-linux-nat.c: Likewise.
6141         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6142
6143 2019-03-24  Tom Tromey  <tom@tromey.com>
6144
6145         * ada-lang.c (standard_lookup): Simplify initialization.
6146         (ada_lookup_symbol_nonlocal): Simplify return.
6147         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6148         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6149         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6150         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6151         initialization.
6152         * solib.c (solib_global_lookup): Simplify.
6153         * symtab.c (null_block_symbol): Remove.
6154         (symbol_cache_lookup): Simplify returns.
6155         (lookup_language_this): Simplify returns.
6156         (lookup_symbol_aux): Simplify return.
6157         (lookup_local_symbol): Simplify returns.
6158         (lookup_global_symbol_from_objfile): Simplify return.
6159         (lookup_symbol_in_objfile_symtabs)
6160         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6161         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6162         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6163         * cp-namespace.c (cp_lookup_bare_symbol)
6164         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6165         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6166         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6167         (cp_lookup_symbol_via_imports): Simplify initialization.
6168         (find_symbol_in_baseclass): Likewise.
6169         * symtab.h (null_block_symbol): Remove.
6170         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6171         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6172         (d_lookup_symbol_module): Likewise.
6173         (find_symbol_in_baseclass): Simplify initialization.
6174
6175 2019-03-24  Tom Tromey  <tom@tromey.com>
6176
6177         * expression.h: Don't include symtab.h.
6178         (struct block): Forward declare.
6179
6180 2019-03-24  Tom Tromey  <tom@tromey.com>
6181
6182         * c-exp.y (typebase): Remove casts.
6183         * gdbtypes.c (lookup_unsigned_typename, )
6184         (lookup_signed_typename): Remove cast.
6185         * eval.c (parse_to_comma_and_eval): Remove cast.
6186         * parse.c (write_dollar_variable): Remove cast.
6187         * block.h (struct block) <superblock>: Now const.
6188         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6189         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6190         (map_block): Make "block" const.
6191         * symfile.h (struct quick_symbol_functions)
6192         <map_matching_symbols>: Constify block argument to "callback".
6193         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6194         const.
6195         (find_pc_sect_compunit_symtab): Make "b" const.
6196         (find_symbol_at_address): Likewise.
6197         (search_symbols): Likewise.
6198         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6199         (dw2_debug_names_lookup_symbol): Likewise.
6200         (dw2_map_matching_symbols): Update.
6201         * p-valprint.c (pascal_val_print): Remove "block".
6202         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6203         (aux_add_nonlocal_symbols): Make "block" const.
6204         (resolve_subexp): Remove cast.
6205         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6206         const.
6207         (iterate_over_file_blocks): Likewise.
6208         * f-exp.y (%union) <bval>: Remove.
6209         * coffread.c (patch_opaque_types): Make "b" const.
6210         * spu-tdep.c (spu_catch_start): Make "block" const.
6211         * c-valprint.c (print_unpacked_pointer): Remove "block".
6212         * symmisc.c (dump_symtab_1): Make "b" const.
6213         (block_depth): Make "block" const.
6214         * d-exp.y (%union) <bval>: Remove.
6215         * cp-support.h (cp_lookup_rtti_type): Update.
6216         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6217         * psymtab.c (psym_lookup_symbol): Make "block" const.
6218         (maintenance_check_psymtabs): Make "b" const.
6219         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6220         (enumerate_locals, enumerate_args): Update.
6221         * python/py-symtab.c (stpy_global_block): Make "block" const.
6222         (stpy_static_block): Likewise.
6223         * inline-frame.c (block_starting_point_at): Make "new_block"
6224         const.
6225         * block.c (find_block_in_blockvector): Make return type const.
6226         (blockvector_for_pc_sect): Make "b" const.
6227         (find_block_in_blockvector): Make "b" const.
6228
6229 2019-03-23  Tom Tromey  <tom@tromey.com>
6230
6231         * varobj.c (varobj_create): Update.
6232         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6233         * printcmd.c (display_command, do_one_display): Don't reset
6234         innermost_block.
6235         * parser-defs.h (enum innermost_block_tracker_type): Move to
6236         expression.h.
6237         (innermost_block): Update comment.
6238         * parse.c (parse_exp_1): Add tracker_types parameter.
6239         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6240         tracker_types parameter.  Reset innermost_block.
6241         (parse_exp_in_context): Remove.
6242         (parse_expression_for_completion): Update.
6243         * objfiles.c (~objfile): Don't reset expression_context_block or
6244         innermost_block.
6245         * expression.h (enum innermost_block_tracker_type): Move from
6246         parser-defs.h.
6247         (parse_exp_1): Add tracker_types parameter.
6248         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6249         reset innermost_block.
6250
6251 2019-03-23  Tom Tromey  <tom@tromey.com>
6252
6253         * objfiles.h: Include bcache.h.
6254
6255 2019-03-23  Tom Tromey  <tom@tromey.com>
6256
6257         * linespec.c (get_current_search_block): Use
6258         scoped_restore_current_language.
6259         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6260
6261 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6262             Jiong Wang  <jiong.wang@arm.com>
6263
6264         * aarch64-linux-tdep.c
6265         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6266         section.
6267         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6268
6269 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6270             Jiong Wang  <jiong.wang@arm.com>
6271
6272         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6273         instructions.
6274         (aarch64_analyze_prologue_test): Add PACIASP test.
6275         (aarch64_prologue_prev_register): Unmask PC value.
6276
6277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6278             Jiong Wang  <jiong.wang@arm.com>
6279
6280         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6281         (aarch64_dwarf2_prev_register): Unmask PC value.
6282         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6283         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6284         DW_CFA_AARCH64_negate_ra_state.
6285         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6286
6287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6288             Jiong Wang  <jiong.wang@arm.com>
6289
6290         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6291         registers.
6292         (aarch64_pseudo_register_name): Likewise.
6293         (aarch64_pseudo_register_type): Likewise.
6294         (aarch64_pseudo_register_reggroup_p): Likewise.
6295         (aarch64_gdbarch_init): Add pauth registers.
6296         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6297         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6298         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6299         (struct gdbarch_tdep): Add regnum for ra_state.
6300
6301 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6302             Jiong Wang  <jiong.wang@arm.com>
6303
6304         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6305
6306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6307             Jiong Wang  <jiong.wang@arm.com>
6308
6309         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6310         function.
6311         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6312         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6313         (aarch64_gdbarch_init): Add puth registers.
6314         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6315         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6316         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6317
6318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6319             Jiong Wang  <jiong.wang@arm.com>
6320
6321         * aarch64-linux-nat.c
6322         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6323         * aarch64-linux-tdep.c
6324         (aarch64_linux_core_read_description): Likewise.
6325         (aarch64_linux_get_hwcap): New function.
6326         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6327         (aarch64_linux_get_hwcap): New declaration.
6328
6329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6330             Jiong Wang  <jiong.wang@arm.com>
6331
6332         * aarch64-linux-nat.c
6333         (aarch64_linux_nat_target::read_description): Add pauth param.
6334         * aarch64-linux-tdep.c
6335         (aarch64_linux_core_read_description): Likewise.
6336         * aarch64-tdep.c (struct target_desc): Add in pauth.
6337         (aarch64_read_description): Add pauth param.
6338         (aarch64_gdbarch_init): Likewise.
6339         * aarch64-tdep.h (aarch64_read_description): Likewise.
6340         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6341         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6342         * features/Makefile: Add new files.
6343         * features/aarch64-pauth.c: New file.
6344         * features/aarch64-pauth.xml: New file.
6345
6346 2019-03-20  Tom Tromey  <tromey@adacore.com>
6347
6348         * infrun.c (handle_inferior_event): Rename from
6349         handle_inferior_event_1.  Create a scoped_value_mark.
6350         (handle_inferior_event): Remove.
6351
6352 2019-03-19  Tom Tromey  <tromey@adacore.com>
6353
6354         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6355         * infrun.h (print_stop_event): Add "displays" parameter.
6356         * infrun.c (print_stop_event): Add "displays" parameter.
6357
6358 2019-03-19  Pedro Alves  <palves@redhat.com>
6359
6360         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6361         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6362         to -1.  Fix TABs vs spaces.
6363         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6364         * tui/tui-out.h (tui_ui_out) Add intro comments.
6365         <m_line, m_start_of_line>: In-class initialize, and add describing
6366         comment.
6367
6368 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6369
6370         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6371         variable names.
6372         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6373
6374 2019-03-18  Pedro Alves  <palves@redhat.com>
6375             Eli Zaretskii <eliz@gnu.org>
6376
6377         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6378         m_line and m_start_of_line.
6379
6380 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6381
6382         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6383         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6384         it returns a newline.  This fixes a regression in TU mode, whereby
6385         the next line is output on the same screen line as the user input.
6386
6387 2019-03-18  Tom Tromey  <tromey@adacore.com>
6388
6389         * minsyms.c (minimal_symbol_reader::install): Remove call to
6390         obstack_blank.
6391
6392 2019-03-18  Pedro Alves  <palves@redhat.com>
6393
6394         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6395         New globals.
6396         (apply_style): New, factored out from ...
6397         (apply_ansi_escape): ... this.  Handle reverse video mode.
6398         (tui_set_reverse_mode): New function.
6399         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6400         * tui/tui-winsource.c (tui_show_source_line): Use
6401         tui_set_reverse_mode instead of setting A_STANDOUT.
6402         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6403         New setter methods.
6404
6405 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6406
6407         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6408         Handle tabs.
6409
6410 2019-03-18  Tom Tromey  <tromey@adacore.com>
6411
6412         * ada-lang.c (empty_array): Add "high" parameter.
6413         (ada_evaluate_subexp): Update.
6414
6415 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6416
6417         * unittests/string_view-selftests.c: Define
6418         _initialize_string_view_selftests unconditionally.
6419
6420 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6421
6422         PR gdb/24350
6423         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6424
6425 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6426
6427         PR gdb/24351
6428         * windows-nat.c (display_selector): Fix format specifiers.
6429
6430 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6431
6432         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6433         tui_refill_source_window instead of tui_refresh_win, to update the
6434         current execution line.  This fixes redisplay of the current line
6435         when stepping through the code with "next" or "step".
6436
6437 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6438
6439         * source-cache.c (source_cache::get_source_lines): Call
6440         find_source_lines to initialize s->nlines.  This fixes vertical
6441         scrolling of TUI source window when the DOWN arrow is pressed.
6442
6443 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6444
6445         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6446         linux-thread-db.c (_initialize_thread_db): Likewise.
6447
6448 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6449
6450         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6451         wclrtoeol in tui_show_source_line".  This reverts changes made in
6452         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6453
6454 2019-03-15  Tom Tromey  <tom@tromey.com>
6455
6456         * symtab.h (struct minimal_symbol): Derive from
6457         general_symbol_info.
6458         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6459         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6460         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6461         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6462         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6463         (MSYMBOL_SEARCH_NAME): Update.
6464         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6465         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6466         * minsyms.c (minimal_symbol_reader::record_full): Update.
6467
6468 2019-03-15  Tom Tromey  <tom@tromey.com>
6469
6470         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6471
6472 2019-03-15  Tom Tromey  <tom@tromey.com>
6473
6474         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6475         unique_xmalloc_ptr.
6476         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6477         Update.
6478         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6479         (build_minimal_symbol_hash_tables)
6480         (minimal_symbol_reader::install): Update.
6481
6482 2019-03-15  Tom Tromey  <tom@tromey.com>
6483
6484         * symtab.c (create_demangled_names_hash): Update.
6485         (symbol_set_names): Update.
6486         * objfiles.h (struct objfile_per_bfd_storage)
6487         <demangled_names_hash>: Now an htab_up.
6488         * objfiles.c (objfile_per_bfd_storage): Simplify.
6489
6490 2019-03-15  Tom Tromey  <tom@tromey.com>
6491
6492         * objfiles.h (struct objfile_per_bfd_storage): Declare
6493         destructor.
6494         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6495         New.
6496         (get_objfile_bfd_data): Use new.  Don't initialize
6497         language_of_main.
6498         (free_objfile_per_bfd_storage): Remove.
6499         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6500
6501 2019-03-15  Tom Tromey  <tom@tromey.com>
6502
6503         * symfile.c (reread_symbols): Update.
6504         * objfiles.c (objfile::objfile): Update.
6505         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6506         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6507         comment.
6508         (minimal_symbol_reader::install): Update.
6509         (terminate_minimal_symbol_table): Remove.
6510         * jit.c (jit_object_close_impl): Update.
6511
6512 2019-03-15  Tom Tromey  <tom@tromey.com>
6513
6514         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6515         initializations.
6516
6517 2019-03-15  Tom Tromey  <tom@tromey.com>
6518
6519         * objfiles.h (struct objfile_per_bfd_storage)
6520         <demangled_hash_languages>: Now a bitset.
6521         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6522         (lookup_minimal_symbol): Update.
6523
6524 2019-03-15  Tom Tromey  <tom@tromey.com>
6525
6526         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6527         Don't return the symbol.
6528         * coffread.c (record_minimal_symbol): Use record_full.
6529
6530 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6531
6532         The MS-Windows port of ncurses fails to switch to a color pair if
6533         one or both of the colors are the implicit default colors.  This
6534         change records the default colors when TUI is initialized, and
6535         then specifies them explicitly when a color pair uses the default
6536         colors.  This allows color styling in TUI mode on MS-Windows.
6537
6538         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6539         ncurses_norm_attr.
6540         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6541         colors in ncurses_norm_attr.
6542         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6543         "none", replace it with the default color recorded in
6544         ncurses_norm_attr.
6545
6546 2019-03-14  Tom Tromey  <tromey@adacore.com>
6547
6548         * source-cache.h (class source_cache) <get_source_lines>: Return
6549         std::string.
6550         * source-cache.c (source_cache::extract_lines): Handle case where
6551         first_pos==npos.  Return std::string.
6552         (source_cache::get_source_lines): Update.
6553
6554 2019-03-14  Tom Tromey  <tromey@adacore.com>
6555
6556         * NEWS: Add item for "style sources" commands.
6557         * source-cache.c (source_cache::get_source_lines): Check
6558         source_styling.
6559         * cli/cli-style.c (source_styling): New global.
6560         (_initialize_cli_style): Add "style sources" commands.
6561         (show_style_sources): New function.
6562         * cli/cli-style.h (source_styling): Declare.
6563
6564 2019-03-14  Pedro Alves  <palves@redhat.com>
6565             Tom Tromey  <tromey@adacore.com>
6566
6567         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6568         * tui/tui-winsource.c (tui_refill_source_window): New function,
6569         from...
6570         (tui_horizontal_source_scroll): ... here.  Move some logic.
6571         * cli/cli-style.c (set_style_enabled): Notify new observable.
6572         * tui/tui-hooks.c (tui_redisplay_source): New function.
6573         (tui_attach_detach_observers): Attach or detach
6574         tui_redisplay_source.
6575         * observable.h (source_styling_changed): New observable.
6576         * observable.c: Define source_styling_changed observable.
6577
6578 2019-03-13  Tom Tromey  <tromey@adacore.com>
6579
6580         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6581         (i386_gnu_nat_target::store_registers): Update.
6582         * target-debug.h (target_debug_print_std_string): New macro.
6583         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6584         * windows-tdep.c (display_one_tib): Update.
6585         * tui/tui-stack.c (tui_make_status_line): Update.
6586         * top.c (print_inferior_quit_action): Update.
6587         * thread.c (thr_try_catch_cmd): Update.
6588         (add_thread_with_info): Update.
6589         (thread_target_id_str): Update.
6590         (thr_try_catch_cmd): Update.
6591         (thread_command): Update.
6592         (thread_find_command): Update.
6593         * record-btrace.c (record_btrace_target::info_record)
6594         (record_btrace_resume_thread, record_btrace_target::resume)
6595         (record_btrace_cancel_resume, record_btrace_step_thread)
6596         (record_btrace_target::wait, record_btrace_target::wait)
6597         (record_btrace_target::wait, record_btrace_target::stop): Update.
6598         * progspace.c (print_program_space): Update.
6599         * process-stratum-target.c
6600         (process_stratum_target::thread_address_space): Update.
6601         * linux-fork.c (linux_fork_mourn_inferior)
6602         (detach_checkpoint_command, info_checkpoints_command)
6603         (linux_fork_context): Update.
6604         (linux_fork_detach): Update.
6605         (class scoped_switch_fork_info): Update.
6606         (delete_checkpoint_command): Update.
6607         * infrun.c (follow_fork_inferior): Update.
6608         (follow_fork_inferior): Update.
6609         (proceed_after_vfork_done): Update.
6610         (handle_vfork_child_exec_or_exit): Update.
6611         (follow_exec): Update.
6612         (displaced_step_prepare_throw): Update.
6613         (displaced_step_restore): Update.
6614         (start_step_over): Update.
6615         (resume_1): Update.
6616         (clear_proceed_status_thread): Update.
6617         (proceed): Update.
6618         (print_target_wait_results): Update.
6619         (do_target_wait): Update.
6620         (context_switch): Update.
6621         (stop_all_threads): Update.
6622         (restart_threads): Update.
6623         (finish_step_over): Update.
6624         (handle_signal_stop): Update.
6625         (switch_back_to_stepped_thread): Update.
6626         (keep_going_pass_signal): Update.
6627         (print_exited_reason): Update.
6628         (normal_stop): Update.
6629         * inferior.c (inferior_pid_to_str): Change return type.
6630         (print_selected_inferior): Update.
6631         (add_inferior): Update.
6632         (detach_inferior): Update.
6633         * dummy-frame.c (fprint_dummy_frames): Update.
6634         * dcache.c (dcache_info_1): Update.
6635         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6636         (btrace_fetch, btrace_clear): Update.
6637         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6638         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6639         type.
6640         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6641         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6642         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6643         * gdbarch.c, gdbarch.h: Rebuild.
6644         * gdbarch.sh (core_pid_to_str): Change return type.
6645         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6646         return type.
6647         (windows_nat_target::pid_to_str): Change return type.
6648         (windows_delete_thread): Update.
6649         (windows_nat_target::attach): Update.
6650         (windows_nat_target::files_info): Update.
6651         * target-delegates.c: Rebuild.
6652         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6653         return type.
6654         (sol_thread_target::pid_to_str): Change return type.
6655         * remote.c (class remote_target) <pid_to_str>: Change return
6656         type.
6657         (remote_target::pid_to_str): Change return type.
6658         (extended_remote_target::attach, remote_target::remote_stop_ns)
6659         (remote_target::remote_notif_remove_queued_reply)
6660         (remote_target::push_stop_reply, remote_target::disable_btrace):
6661         Update.
6662         (extended_remote_target::attach): Update.
6663         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6664         type.
6665         (gdbsim_target::pid_to_str): Change return type.
6666         * ravenscar-thread.c (struct ravenscar_thread_target)
6667         <pid_to_str>: Change return type.
6668         (ravenscar_thread_target::pid_to_str): Change return type.
6669         * procfs.c (class procfs_target) <pid_to_str>: Change return
6670         type.
6671         (procfs_target::pid_to_str): Change return type.
6672         (procfs_target::attach): Update.
6673         (procfs_target::detach): Update.
6674         (procfs_target::fetch_registers): Update.
6675         (procfs_target::store_registers): Update.
6676         (procfs_target::wait): Update.
6677         (procfs_target::files_info): Update.
6678         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6679         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6680         return type.
6681         (nto_procfs_target::pid_to_str): Change return type.
6682         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6683         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6684         return type.
6685         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6686         (exit_lwp): Update.
6687         (attach_proc_task_lwp_callback, get_detach_signal)
6688         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6689         (linux_nat_target::resume, wait_lwp, stop_callback)
6690         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6691         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6692         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6693         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6694         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6695         type.
6696         (inf_ptrace_target::attach): Update.
6697         (inf_ptrace_target::files_info): Update.
6698         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6699         type.
6700         (go32_nat_target::pid_to_str): Change return type.
6701         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6702         (gnu_nat_target::wait): Update.
6703         (gnu_nat_target::wait): Update.
6704         (gnu_nat_target::resume): Update.
6705         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6706         (fbsd_nat_target::wait): Update.
6707         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6708         type.
6709         (darwin_nat_target::attach): Update.
6710         * corelow.c (class core_target) <pid_to_str>: Change return type.
6711         (core_target::pid_to_str): Change return type.
6712         * target.c (normal_pid_to_str): Change return type.
6713         (default_pid_to_str): Likewise.
6714         (target_pid_to_str): Change return type.
6715         (target_translate_tls_address): Update.
6716         (target_announce_detach): Update.
6717         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6718         return type.
6719         (bsd_uthread_target::pid_to_str): Change return type.
6720         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6721         type.
6722         (bsd_kvm_target::pid_to_str): Change return type.
6723         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6724         return type.
6725         (aix_thread_target::pid_to_str): Change return type.
6726         * target.h (struct target_ops) <pid_to_str>: Change return type.
6727         (target_pid_to_str, normal_pid_to_str): Likewise.
6728         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6729         type.
6730         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6731         type.
6732         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6733         return type.
6734         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6735         type.
6736         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6737         type.
6738         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6739         return type.
6740
6741 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6742
6743         * NEWS: Mention that the new default MI version is 3.  Mention
6744         changes to the output of commands and events that deal with
6745         multi-location breakpoints.
6746         * breakpoint.c: Include "mi/mi-out.h".
6747         (print_one_breakpoint): Change output syntax if using MI version
6748         >= 3.
6749         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6750         New.
6751         (mi_multi_location_breakpoint_output_fixed): New.
6752         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6753         (mi_cmd_fix_multi_location_breakpoint_output): New.
6754         (mi_multi_location_breakpoint_output_fixed): New.
6755         * mi/mi-cmds.c (mi_cmds): Register command
6756         -fix-multi-location-breakpoint-output.
6757         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6758         interpreter "mi".
6759
6760 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6761
6762         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6763         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6764         instantiate mi_ui_out based on interpreter name.
6765         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6766         * mi/mi-main.c (mi_load_progress): Likewise.
6767
6768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6769
6770         * NEWS: Combine separate "New targets" sections for 8.3.
6771
6772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6773
6774         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6775         (ppcfbsd_init_abi): Install gdbarch
6776         "fetch_tls_load_module_address" and "get_thread_local_address"
6777         methods.
6778
6779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6780
6781         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6782         (riscv_fbsd_init_abi): Install gdbarch
6783         "fetch_tls_load_module_address" and "get_thread_local_address"
6784         methods.
6785
6786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6787
6788         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6789         (i386fbsd_init_abi): Install gdbarch
6790         "fetch_tls_load_module_address" and "get_thread_local_address"
6791         methods.
6792
6793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6794
6795         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6796         (amd64fbsd_init_abi): Install gdbarch
6797         "fetch_tls_load_module_address" and "get_thread_local_address"
6798         methods.
6799
6800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6801
6802         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6803         (struct fbsd_pspace_data): New type.
6804         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6805         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6806         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6807         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6808         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6809
6810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6811
6812         * gdbtypes.c (lookup_struct_elt): New function.
6813         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6814         * gdbtypes.h (struct struct_elt): New type.
6815         (lookup_struct_elt): New prototype.
6816
6817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6818
6819         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6820         remove disabled code block.
6821
6822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6823
6824         * gdbarch.sh (get_thread_local_address): New method.
6825         * gdbarch.h, gdbarch.c: Regenerate.
6826         * target.c (target_translate_tls_address): Use
6827         gdbarch_get_thread_local_address if present instead of
6828         target::get_thread_local_address.
6829
6830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6831
6832         * target.h (target::get_thread_local_address): Update comment.
6833
6834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6835
6836         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6837         objfile->separate_debug_objfile_backlink if not NULL.
6838
6839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6840
6841         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6842         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6843         (amd64bsd_store_inferior_registers): Likewise.
6844         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6845         Enable segment base registers.
6846         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6847         PT_GETFSBASE and PT_GETGSBASE.
6848         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6849         PT_SETGSBASE.
6850         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6851         segment base registers.
6852         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6853
6854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6855
6856         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6857         Update calls to i386_target_description to add 'segments'
6858         parameter.
6859         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6860         add segment base registers.
6861         * arch/i386.c (i386_create_target_description): Add 'segments'
6862         parameter to enable segment base registers.
6863         * arch/i386.h (i386_create_target_description): Likewise.
6864         * features/i386/32bit-segments.xml: New file.
6865         * features/i386/32bit-segments.c: Generate.
6866         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6867         call to i386_target_description to add 'segments' parameter.
6868         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6869         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6870         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6871         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6872         if feature is present.
6873         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6874         Add 'segments' parameter to call to i386_target_description.
6875         (i386_target_description): Add 'segments' parameter to enable
6876         segment base registers.
6877         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6878         to call to i386_target_description.
6879         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6880         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6881         Define I386_NUM_REGS.
6882         (i386_target_description): Add 'segments' parameter to enable
6883         segment base registers.
6884
6885 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6886
6887         PR/24325
6888         * source-cache.c: #undef open and close, to avoid unresolved
6889         externals during linking.
6890
6891 2019-03-12  Tom Tromey  <tromey@adacore.com>
6892
6893         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6894         const.  Add initializers.
6895         (_initialize_remote): Don't initialize ptid globals.
6896
6897 2019-03-12  Pedro Alves  <palves@redhat.com>
6898
6899         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6900
6901 2019-03-12  Pedro Alves  <palves@redhat.com>
6902
6903         * cp-name-parser.y (main): Remove unused 'len' variable.
6904
6905 2019-03-12  Tom Tromey  <tromey@adacore.com>
6906
6907         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6908         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6909
6910 2019-03-12  Tom Tromey  <tromey@adacore.com>
6911
6912         * linux-nat.c (iterate_over_lwps): Update.
6913         (stop_callback): Remove parameter.
6914         (stop_wait_callback, detach_callback, resume_set_callback)
6915         (select_singlestep_lwp_callback, set_ignore_sigint)
6916         (status_callback, resumed_callback, resume_clear_callback)
6917         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6918         data parameter.
6919         (linux_nat_target::detach, linux_nat_target::resume)
6920         (linux_stop_and_wait_all_lwps, select_event_lwp)
6921         (linux_nat_filter_event, linux_nat_wait_1)
6922         (linux_nat_target::kill, linux_nat_target::stop)
6923         (linux_nat_target::stop): Update.
6924         (linux_nat_resume_callback): Change type.
6925         (resume_stopped_resumed_lwps, count_events_callback)
6926         (select_event_lwp_callback): Likewise.
6927         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6928         * arm-linux-nat.c (struct update_registers_data): Remove.
6929         (update_registers_callback): Change type.
6930         (arm_linux_insert_hw_breakpoint1): Update.
6931         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6932         parameter.
6933         (x86_linux_dr_set_addr): Update.
6934         (x86_linux_dr_set_control): Update.
6935         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6936         (iterate_over_lwps): Use gdb::function_view.
6937         * nat/aarch64-linux-hw-point.c (struct
6938         aarch64_dr_update_callback_param): Remove.
6939         (debug_reg_change_callback): Change type.
6940         (aarch64_notify_debug_reg_change): Update.
6941         * s390-linux-nat.c (s390_refresh_per_info): Update.
6942
6943 2019-03-11  Tom Tromey  <tromey@adacore.com>
6944
6945         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6946         redundant assignment to "this_cu".
6947
6948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6949
6950         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6951
6952 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6953
6954         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6955         from...
6956         (rank_one_type): ... this.
6957
6958 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6959
6960         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6961         from...
6962         (rank_one_type): ... this.
6963
6964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6965
6966         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6967         from...
6968         (rank_one_type): ... this.
6969
6970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6971
6972         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6973         from...
6974         (rank_one_type): ... this.
6975
6976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6977
6978         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6979         from...
6980         (rank_one_type): ... this.
6981
6982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6983
6984         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6985         from...
6986         (rank_one_type): ... this.
6987
6988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6989
6990         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6991         from...
6992         (rank_one_type): ... this.
6993
6994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6995
6996         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6997         from...
6998         (rank_one_type): ... this.
6999
7000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7001
7002         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7003         from...
7004         (rank_one_type): ... this.
7005
7006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7007
7008         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7009         from...
7010         (rank_one_type): ... this.
7011
7012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7013
7014         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7015         from...
7016         (rank_one_type): ... this.
7017
7018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7019
7020         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7021         from...
7022         (rank_one_type): ... this.
7023
7024 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7025
7026         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7027         inferior-events' shows the example events.
7028
7029 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7030
7031         Support styling on native MS-Windows console
7032
7033         PR/24315
7034         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7035         on MS-Windows if $TERM is not defined.
7036
7037         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7038
7039         * posix-hdep.c (gdb_console_fputs):
7040         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7041         functions.
7042         * ui-file.h (gdb_console_fputs): Add prototype.
7043
7044         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7045         back to fputs only if the former returns zero.
7046
7047 2019-03-07  Tom Tromey  <tom@tromey.com>
7048
7049         * symmisc.c (print_symbol_bcache_statistics): Update.
7050         (print_objfile_statistics): Update.
7051         * symfile.c (allocate_symtab): Update.
7052         * stabsread.c: Don't include bcache.h.
7053         * psymtab.h (struct psymbol_bcache): Don't declare.
7054         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7055         (psymbol_bcache_init, psymbol_bcache_free)
7056         (psymbol_bcache_get_bcache): Don't declare.
7057         * psymtab.c (struct psymbol_bcache): Remove.
7058         (psymtab_storage::psymtab_storage): Update.
7059         (psymtab_storage::~psymtab_storage): Update.
7060         (psymbol_bcache_init, psymbol_bcache_free)
7061         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7062         (add_psymbol_to_bcache): Update.
7063         (allocate_psymtab): Update.
7064         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7065         macro_cache>: No longer pointers.
7066         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7067         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7068         * macrotab.c (macro_bcache): Update.
7069         * macroexp.c: Don't include bcache.h.
7070         * gdbtypes.c (check_types_worklist): Update.
7071         (types_deeply_equal): Remove TRY/CATCH.  Update.
7072         * elfread.c (elf_symtab_read): Update.
7073         * dwarf2read.c: Don't include bcache.h.
7074         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7075         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7076         (print_bcache_statistics, bcache_memory_used): Don't declare.
7077         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7078         methods.  Rename all data members.
7079         * bcache.c (struct bcache): Move to bcache.h.
7080         (bcache::expand_hash_table): Rename from expand_hash_table.
7081         (bcache): Remove.
7082         (bcache::insert): Rename from bcache_full.
7083         (bcache::compare): Rename from bcache_compare.
7084         (bcache_xmalloc): Remove.
7085         (bcache::~bcache): Rename from bcache_xfree.
7086         (bcache::print_statistics): Rename from print_bcache_statistics.
7087         (bcache::memory_used): Rename from bcache_memory_used.
7088
7089 2019-03-07  Pedro Alves  <palves@redhat.com>
7090
7091         * infrun.c (normal_stop): Also check for
7092         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7093
7094 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7095
7096         * f-lang.c (value_from_host_double): Moved to...
7097         * value.c (value_from_host_double): ...here.
7098         * value.h (value_from_host_double): Declare.
7099         * guile/scm-math.c (vlscm_convert_typed_number): Use
7100         value_from_host_double.
7101         (vlscm_convert_number): Likewise.
7102         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7103         * python/py-value.c (convert_value_from_python): Likewise.
7104
7105 2019-03-06  Tom Tromey  <tom@tromey.com>
7106
7107         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7108
7109 2019-03-06  Tom Tromey  <tom@tromey.com>
7110
7111         * utils.h (free_current_contents): Don't declare.
7112         * utils.c (free_current_contents): Remove.
7113
7114 2019-03-06  Tom Tromey  <tom@tromey.com>
7115
7116         * top.c (quit_force): Update.
7117         * main.c (captured_command_loop): Update.
7118         * common/new-op.c (operator new): Update.
7119         * common/common-exceptions.c (struct catcher)
7120         <save_cleanup_chain>: Remove member.
7121         (exceptions_state_mc_init): Update.
7122         (exception_try_scope_entry): Return nullptr.
7123         (exception_try_scope_exit, exception_rethrow)
7124         (throw_exception_sjlj, throw_exception_cxx): Update.
7125         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7126         (all_cleanups, do_cleanups, discard_cleanups)
7127         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7128         (restore_cleanups, restore_final_cleanups): Don't declare.
7129         (do_final_cleanups): Remove parameter.
7130         * common/cleanups.c (cleanup_chain, make_cleanup)
7131         (make_cleanup_dtor, all_cleanups, do_cleanups)
7132         (discard_my_cleanups, discard_cleanups)
7133         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7134         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7135         (null_cleanup): Remove.
7136         (do_final_cleanups): Remove parameter.
7137
7138 2019-03-06  Tom Tromey  <tom@tromey.com>
7139
7140         * remote.c (remote_target::remote_parse_stop_reply): Use
7141         unique_xmalloc_ptr.
7142
7143 2019-03-06  Tom Tromey  <tom@tromey.com>
7144
7145         * stabsread.c (struct stabs_field_info): Rename from field_info.
7146         <list, fnlist>: Add initializers.
7147         <obstack>: New member.
7148         (read_member_functions, read_struct_fields, read_baseclasses):
7149         Allocate on obstack.  Don't use cleanups.
7150         (read_one_struct_field, read_member_functions, read_struct_fields)
7151         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7152         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7153         (read_struct_type): Update.
7154
7155 2019-03-06  Tom Tromey  <tom@tromey.com>
7156
7157         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7158         * common/filestuff.h (make_cleanup_close): Don't declare.
7159         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7160         Remove.
7161
7162 2019-03-06  Tom Tromey  <tom@tromey.com>
7163
7164         * solib-aix.c: Use make_scope_exit.
7165
7166 2019-03-06  Tom Tromey  <tom@tromey.com>
7167
7168         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7169         Use make_scope_exit.
7170
7171 2019-03-06  Tom Tromey  <tom@tromey.com>
7172
7173         * solib-svr4.c (disable_probes_interface): Remove parameter.
7174         (svr4_handle_solib_event): Use make_scope_exit.
7175
7176 2019-03-06  Tom Tromey  <tom@tromey.com>
7177
7178         * remote.c (struct stop_reply_deleter): Remove.
7179         (stop_reply_up): Update.
7180         (struct stop_reply): Derive from notif_event.  Don't typedef.
7181         <regcache>: Now a std::vector.
7182         (stop_reply_xfree): Remove.
7183         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7184         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7185         (remote_target::discard_pending_stop_replies): Use delete.
7186         (remote_target::remote_parse_stop_reply): Update.
7187         (remote_target::process_stop_reply): Update.
7188         * remote-notif.h (struct notif_event): Add virtual destructor.
7189         Remove "dtr" member.
7190         (struct notif_client) <alloc_event>: Return a unique_ptr.
7191         (notif_event_xfree): Don't declare.
7192         (notif_event_up): New typedef.
7193         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7194         (notif_event_xfree, do_notif_event_xfree): Remove.
7195         (remote_notif_state_xfree): Update.
7196
7197 2019-03-06  Tom Tromey  <tom@tromey.com>
7198
7199         * infrun.c (displaced_step_clear_cleanup): Now a
7200         forward_scope_exit type.
7201         (displaced_step_prepare_throw): Update.
7202         (displaced_step_fixup): Update.
7203
7204 2019-03-06  Tom Tromey  <tom@tromey.com>
7205
7206         * inferior.h (class inferior): Update comment.
7207         * gdbthread.h (class thread_info): Update comment.
7208
7209 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7210             Tom Tromey  <tom@tromey.com>
7211
7212         * stabsread.h (struct stab_section_list): Remove.
7213         (coffstab_build_psymtabs): Update.
7214         * dbxread.c (symbuf_sections): Now a std::vector.
7215         (sect_idx): New global.
7216         (fill_symbuf): Update.
7217         (coffstab_build_psymtabs): Change type of stabsects parameter.
7218         Update.
7219         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7220         std::vector.
7221         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7222         (coff_locate_sections): Update.
7223         (coff_symfile_read): Remove cleanups.  Update.
7224         (init_stringtab): Add storage parameter.
7225         (free_stringtab, free_stringtab_cleanup): Remove.
7226         (init_lineno): Add storage parameter.
7227         (free_linetab, free_linetab_cleanup): Remove.
7228
7229 2019-03-06  Pedro Alves  <palves@redhat.com>
7230
7231         * linux-fork.c (fork_info::clobber_regs): Delete.
7232         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7233         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7234         comment.  Adjust.
7235         (scoped_switch_fork_info::scoped_switch_fork_info)
7236         (checkpoint_command, linux_fork_context): Adjust
7237         fork_save_infrun_state calls.
7238
7239 2019-03-06  Pedro Alves  <palves@redhat.com>
7240
7241         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7242         (inf_has_multiple_threads): Return 'bool' and rewrite using
7243         inferior_info::threads().
7244
7245 2019-03-06  Pedro Alves  <palves@redhat.com>
7246
7247         * linux-fork.c: Include <list>.
7248         (fork_list): Now a std::list instance.
7249         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7250         (forks_exist_p, find_last_fork): Adjust.
7251         (new_fork): Delete.
7252         (one_fork_p): New.
7253         (add_fork): Adjust.
7254         (free_fork): Delete, folded into fork_info::~fork_info().
7255         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7256         Adjust.
7257         (init_fork_list): Delete.
7258         (linux_fork_killall, linux_fork_mourn_inferior)
7259         (linux_fork_detach, info_checkpoints_command): Adjust.
7260         (_initialize_linux_fork): No longer call init_fork_list.
7261
7262 2019-03-06  Pedro Alves  <palves@redhat.com>
7263
7264         * linux-fork.c (new_fork): New, split out of ...
7265         (add_fork): ... this.  Return void.  Move "first fork" special
7266         case from here, to ...
7267         (checkpoint_command): ... here.
7268         * linux-linux.h (add_fork): Return void.
7269
7270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7273
7274 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7275             Chris January  <chris.january@arm.com>
7276             David Lecomber  <david.lecomber@arm.com>
7277
7278         * f-exp.y: New token, UNOP_INTRINSIC.
7279         (exp): New pattern using UNOP_INTRINSIC token.
7280         (f77_keywords): Add 'abs' keyword.
7281         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7282         (value_from_host_double): New function.
7283         (evaluate_subexp_f): Support UNOP_ABS.
7284
7285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7286
7287         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7288         types.
7289
7290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7291
7292         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7293         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7294         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7295
7296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7297
7298         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7299
7300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7301             Chris January  <chris.january@arm.com>
7302
7303         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7304         * f-exp.y: Define 'KIND' token.
7305         (exp): New pattern for KIND expressions.
7306         (ptype): Handle types with a kind extension.
7307         (direct_abs_decl): Extend to spot kind extensions.
7308         (f77_keywords): Add 'kind' to the list.
7309         (push_kind_type): New function.
7310         (convert_to_kind_type): New function.
7311         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7312         * parse.c (operator_length_standard): Likewise.
7313         * parser-defs.h (enum type_pieces): Add tp_kind.
7314         * std-operator.def: Add UNOP_KIND.
7315
7316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         * f-exp.y (f_parse): Set yydebug.
7319
7320 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * f-lang.c (evaluate_subexp_f): New function.
7323         (exp_descriptor_f): New global.
7324         (f_language_defn): Use exp_descriptor_f instead of
7325         exp_descriptor_standard.
7326
7327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7328
7329         * f-exp.y (struct token): Add comments.
7330         (dot_ops): Remove uppercase versions and the end marker.
7331         (f77_keywords): Likewise.
7332         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7333         entries in the dot_ops array are case insensitive, and use
7334         strncasecmp to compare strings.  Also some whitespace cleanup in
7335         this area.  Similar for the f77_keywords array, except entries in
7336         this list might be case sensitive.
7337
7338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * f-exp.y (struct f77_boolean_val): Add comments.
7341         (boolean_values): Remove uppercase versions, and end marker.
7342         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7343         and use strncasecmp to achieve case insensitivity.  Additionally,
7344         perform whitespace cleanup around this code.
7345
7346 2019-03-06  Tom Tromey  <tromey@adacore.com>
7347
7348         * remote-sim.c (gdbsim_target_open): Use result of
7349         gdb_argv::release.
7350
7351 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7352         Dirk Schubert  <dirk.schubert@arm.com>
7353         Chris January  <chris.january@arm.com>
7354
7355         * eval.c (evaluate_subexp_standard): Call Fortran argument
7356         wrapping logic.
7357         * f-lang.c (struct value): A value which can be passed into a
7358         Fortran function call.
7359         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7360         where appropriate.
7361         (struct type): Value ready for a Fortran function call.
7362         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7363         is needed.
7364         * f-lang.h (fortran_argument_convert): Declaration.
7365         (fortran_preserve_arg_pointer): Declaration.
7366         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7367
7368 2019-03-05  Tom Tromey  <tromey@adacore.com>
7369
7370         * python/py-prettyprint.c (print_string_repr): Remove #if.
7371         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7372
7373 2019-03-05  Tom Tromey  <tromey@adacore.com>
7374
7375         * target.c (the_dummy_target): Move later.  Change type to
7376         "dummy_target".
7377         (initialize_targets): Don't initialize the_dummy_target.
7378
7379 2019-03-05  Tom Tromey  <tromey@adacore.com>
7380
7381         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7382         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7383
7384 2019-03-05  Tom Tromey  <tromey@adacore.com>
7385
7386         * windows-nat.c (windows_nat_target::attach)
7387         (windows_nat_target::detach): Don't call gdb_flush.
7388         * valprint.c (generic_val_print, val_print, val_print_string):
7389         Don't call gdb_flush.
7390         * utils.c (defaulted_query): Don't call gdb_flush.
7391         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7392         * target.c (target_announce_detach): Don't call gdb_flush.
7393         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7394         * remote.c (extended_remote_target::attach): Don't call
7395         gdb_flush.
7396         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7397         * printcmd.c (do_examine): Don't call gdb_flush.
7398         (info_display_command): Don't call gdb_flush.
7399         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7400         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7401         * memattr.c (info_mem_command): Don't call gdb_flush.
7402         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7403         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7404         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7405         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7406         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7407         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7408         (gnu_nat_target::detach): Don't call gdb_flush.
7409         * f-valprint.c (f_val_print): Don't call gdb_flush.
7410         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7411         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7412         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7413         gdb_flush.
7414         * c-valprint.c (c_val_print): Don't call gdb_flush.
7415         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7416
7417 2019-03-05  Tom Tromey  <tromey@adacore.com>
7418
7419         * varobj.c (update_dynamic_varobj_children): Update.
7420         (install_default_visualizer): Use reset, not release.
7421         * value.c (set_internalvar): Update.
7422         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7423         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7424         ATTRIBUTE_UNUSED_RESULT.
7425
7426 2019-03-05  Tom Tromey  <tromey@adacore.com>
7427
7428         * remote.c (class scoped_remote_fd) <release>: Add
7429         ATTRIBUTE_UNUSED_RESULT.
7430
7431 2019-03-05  Tom Tromey  <tromey@adacore.com>
7432
7433         * macroexp.c (struct macro_buffer) <release>: Add
7434         ATTRIBUTE_UNUSED_RESULT.
7435
7436 2019-03-05  Tom Tromey  <tromey@adacore.com>
7437
7438         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7439         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7440         ATTRIBUTE_UNUSED_RESULT.
7441
7442 2019-03-05  Tom Tromey  <tromey@adacore.com>
7443
7444         * common/scoped_fd.h (class scoped_fd) <release>: Add
7445         ATTRIBUTE_UNUSED_RESULT.
7446
7447 2019-03-05  Tom Tromey  <tromey@adacore.com>
7448
7449         * parser-defs.h (struct parser_state) <release>: Add
7450         ATTRIBUTE_UNUSED_RESULT.
7451
7452 2019-03-05  Tom Tromey  <tromey@adacore.com>
7453
7454         * utils.h (class gdb_argv) <release>: Add
7455         ATTRIBUTE_UNUSED_RESULT.
7456         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7457
7458 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7459
7460         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7461         for-loop range, to avoid compiler warnings.
7462
7463         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7464         avoid compiler warnings about unused variables.
7465
7466         * NEWS: Mention end of support for native debugging on MS-Windows
7467         before XP.
7468
7469         PR gdb/24292
7470         * common/netstuff.c:
7471         * gdbserver/gdbreplay.c
7472         * gdbserver/remote-utils.c:
7473         * ser-tcp.c:
7474         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7475         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7476         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7477         'getaddrinfo' and 'freeaddrinfo' were not available before
7478         Windows XP, and mingw.org's MinGW headers by default define
7479         _WIN32_WINNT to 0x500.
7480
7481 2019-03-01  Gary Benson <gbenson@redhat.com>
7482
7483         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7484
7485 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7486             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7487
7488         PR gdb/8527
7489         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7490         set_sigint_trap, clear_sigint_trap.
7491
7492 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7493
7494         * target.c (target_detach): Clear the regcache and the
7495         frame cache.
7496
7497 2019-02-27  Pedro Alves  <palves@redhat.com>
7498
7499         * utils.c (set_screen_size): When we cap the height/width sizes,
7500         tweak the corresponding command variable to show "unlimited":
7501
7502 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7503             Pedro Alves  <palves@redhat.com>
7504
7505         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7506         before calling rl_set_screen_size.
7507
7508 2019-02-27  Tom Tromey  <tromey@adacore.com>
7509
7510         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7511         define.
7512         * python/py-value.c: Remove Python 2.4 workaround.
7513         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7514         workaround.
7515         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7516         Python 2.4 workaround.
7517         * python/python-internal.h: Remove Python 2.4 comment.
7518         (Py_ssize_t): Don't define.
7519         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7520         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7521         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7522         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7523         * python/python.c (do_start_initialization): Remove Python 2.4
7524         workaround.
7525         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7526         (print_children): Remove Python 2.4 workaround.
7527         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7528         workaround.
7529         (CHARBUFFERPROC_NAME): Remove.
7530         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7531         Python 2.4 workaround.
7532
7533 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7534
7535         * NEWS: Note minimum Python version.
7536
7537 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7538
7539         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7540         code from these functions.  Remove corresponding ifdefs.  Use
7541         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7542         Remove gotos and target of gotos.
7543         (infpy_search_memory): Likewise.
7544
7545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7548         (hppa_gdbarch_init): Don't register deleted functions with
7549         gdbarch.
7550
7551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7552
7553         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7554         (h8300_unwind_sp): Delete.
7555         (h8300_dummy_id): Delete.
7556         (h8300_gdbarch_init): Don't register deleted functions with
7557         gdbarch.
7558
7559 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7560
7561         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7562         (ft32_unwind_pc): Delete.
7563         (ft32_unwind_sp): Delete.
7564         (ft32_gdbarch_init): Don't register deleted functions with
7565         gdbarch.
7566
7567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7568
7569         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7570         (frv_unwind_pc): Delete.
7571         (frv_unwind_sp): Delete.
7572         (frv_gdbarch_init): Don't register deleted functions with
7573         gdbarch.
7574
7575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7576
7577         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7578         (riscv_unwind_pc): Delete.
7579         (riscv_unwind_sp): Delete.
7580         (riscv_gdbarch_init): Don't register deleted functions with
7581         gdbarch.
7582
7583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7584
7585         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7586         (csky_unwind_pc): Delete.
7587         (csky_unwind_sp): Delete.
7588         (csky_gdbarch_init): Don't register deleted functions with
7589         gdbarch.
7590
7591 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7592
7593         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7594         (cris_unwind_pc): Delete.
7595         (cris_unwind_sp): Delete.
7596         (cris_gdbarch_init): Don't register deleted functions with
7597         gdbarch.
7598
7599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7600
7601         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7602         (bfin_unwind_pc): Delete.
7603         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7604
7605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7606
7607         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7608         (arm_unwind_pc): Delete.
7609         (arm_unwind_sp): Delete.
7610         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7611
7612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7613
7614         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7615         (arc_unwind_pc): Delete.
7616         (arc_unwind_sp): Delete.
7617         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7618
7619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7620
7621         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7622         (alpha_unwind_pc): Delete.
7623         (alpha_gdbarch_init): Don't register deleted functions with
7624         gdbarch.
7625
7626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7627
7628         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7629         (aarch64_unwind_pc): Delete.
7630         (aarch64_unwind_sp): Delete.
7631         (aarch64_gdbarch_init): Don't register deleted functions with
7632         gdbarch.
7633
7634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7635
7636         * gdbtypes.c (type_align): Don't consider static members when
7637         computing structure alignment.
7638
7639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7640
7641         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7642         return 0 for other types.
7643         * arch-utils.c (default_type_align): Always return 0.
7644         * gdbarch.h: Regenerate.
7645         * gdbarch.sh (type_align): Extend comment.
7646         * gdbtypes.c (type_align): Add additional comments, always call
7647         gdbarch_type_align before applying the default rules.
7648         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7649         generic code will then apply a suitable default.
7650         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7651         types, return 0 for other types.
7652
7653 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7654
7655         * NEWS: Create a new section for the next release branch.
7656         Rename the section of the current branch, now that it has
7657         been cut.
7658
7659 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7660
7661         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7662         * version.in: Bump version to 8.3.50.DATE-git.
7663
7664 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7665
7666         * aix-thread.c (ptid_cmp): Remove unused variable.
7667         (get_signaled_thread): Likewise.
7668         (store_regs_user_thread): Likewise.
7669         (store_regs_kernel_thread): Likewise.
7670         (fetch_regs_kernel_thread): Remove shadowed variable.
7671
7672 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7673
7674         * features/riscv/32bit-cpu.xml: Add register numbers.
7675         * features/riscv/32bit-fpu.c: Regenerate.
7676         * features/riscv/32bit-fpu.xml: Add register numbers.
7677         * features/riscv/64bit-cpu.xml: Add register numbers.
7678         * features/riscv/64bit-fpu.c: Regenerate.
7679         * features/riscv/64bit-fpu.xml: Add register numbers.
7680
7681 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7682
7683         * NEWS: Mention two argument form of gdb.Value constructor.
7684         * python/py-value.c (convert_buffer_and_type_to_value): New
7685         function.
7686         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7687         Add support for handling an optional second argument.  Call
7688         convert_buffer_and_type_to_value as appropriate.
7689         * python/python-internal.h (Py_buffer_deleter): New struct.
7690         (Py_buffer_up): New typedef.
7691
7692 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7693
7694         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7695         instead of releasing ownership.
7696
7697 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7698
7699         * dwarf2read.c (open_and_init_dwp_file): Call
7700         elf_numsections instead of bfd_count_sections to initialize
7701         dwp_file->num_sections.
7702
7703 2019-02-25  Tom Tromey  <tromey@adacore.com>
7704
7705         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7706
7707 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7708
7709         * gcore.in: Add '--readnever' option when invoking GDB.
7710
7711 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7712
7713         * MAINTAINERS: Update my email address.
7714
7715 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7716
7717         * build-id.c (build_id_to_debug_bfd_1): New function.
7718         (build_id_to_debug_bfd): Look for separate debug file in
7719         sysroot.
7720
7721 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * gdbarch.sh: Update the copyright year range that is placed into
7724         generated files.
7725
7726 2019-02-22  Keith Seitz  <keiths@redhat.com>
7727
7728         PR symtab/23853
7729         * linespec.c (create_sals_line_offset): Search for the default
7730         symtab's filename instead of its fullname.
7731
7732 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7733
7734         * NEWS: Update style defaults.
7735
7736 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7737
7738         * main.c (captured_main_1): Disable styling in batch mode.
7739
7740 2019-02-20  Tom Tromey  <tom@tromey.com>
7741
7742         * symtab.c (symtab_symbol_info): Fix typos.
7743
7744 2019-02-20  Tom Tromey  <tromey@adacore.com>
7745
7746         * findcmd.c (_initialize_mem_search): Use upper case for
7747         metasyntactic variables.
7748
7749 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7750
7751         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7752         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7753
7754 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7755
7756         * top.h (source_file_name): Change to std::string.
7757         * top.c (source_file_name): Likewise.
7758         (command_line_input): Adjust.
7759         * cli/cli-script.c (script_from_file): Adjust.
7760
7761 2019-02-19  Tom Tromey  <tromey@adacore.com>
7762
7763         * ravenscar-thread.c
7764         (ravenscar_thread_target::update_thread_list): Don't call
7765         ada_build_task_list.
7766         * ada-lang.h (ada_build_task_list): Don't declare.
7767         * ada-tasks.c (struct ada_tasks_inferior_data)
7768         <task_list_valid_p>: Now bool.
7769         (read_known_tasks, ada_task_list_changed)
7770         (ada_tasks_invalidate_inferior_data): Update.
7771         (read_known_tasks_array): Return bool.
7772         (read_known_tasks_list): Likewise.
7773         (read_known_tasks): Return void.
7774         (ada_build_task_list): Now static.
7775
7776 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7777
7778         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7779         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7780
7781 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7782
7783         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7784         variant for ada_tasks_pspace_data_handle and
7785         ada_tasks_inferior_data_handle.
7786         (ada_tasks_pspace_data_cleanup): New function.
7787         (ada_tasks_inferior_data_cleanup): New function.
7788
7789 2019-02-17  Tom Tromey  <tom@tromey.com>
7790
7791         * macrotab.h (macro_source_fullname): Return a std::string.
7792         * macrotab.c (macro_include, check_for_redefinition)
7793         (macro_undef, macro_lookup_definition, foreach_macro)
7794         (foreach_macro_in_scope): Update.
7795         (macro_source_fullname): Return a std::string.
7796         * macrocmd.c (show_pp_source_pos): Update.
7797
7798 2019-02-17  Tom Tromey  <tom@tromey.com>
7799
7800         * macrocmd.c (show_pp_source_pos): Style the file names.
7801
7802 2019-02-17  Tom Tromey  <tom@tromey.com>
7803
7804         PR tui/24197:
7805         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7806
7807 2019-02-17  Tom Tromey  <tom@tromey.com>
7808
7809         * ada-lang.c (user_select_syms): Use filtered printing.
7810         * utils.c (wrap_style): New global.
7811         (desired_style): Remove.
7812         (emit_style_escape): Add stream parameter.
7813         (set_output_style, reset_terminal_style, prompt_for_continue):
7814         Update.
7815         (flush_wrap_buffer): Only flush gdb_stdout.
7816         (wrap_here): Set wrap_style.
7817         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7818         treat escape sequences as a character.  Change when wrap buffer is
7819         flushed.
7820         (fputs_styled): Do not set the output style when the default is
7821         requested.
7822         * ui-style.h (struct ui_file_style) <is_default>: New method.
7823         * source.c (print_source_lines_base): Emit escape sequences in one
7824         piece.
7825
7826 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7827
7828         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7829         integers and enumeration types.
7830
7831 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7832
7833         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7834         instead of lookup_symbol_in_language
7835         (do_exact_match): New function.
7836         (ada_get_symbol_name_matcher): Return do_exact_match when
7837         doing a verbatim match.
7838
7839 2019-02-15  Tom Tromey  <tromey@adacore.com>
7840
7841         * ravenscar-thread.c (ravenscar_thread_target::resume)
7842         (ravenscar_thread_target::wait): Special case wildcard requests.
7843
7844 2019-02-15  Tom Tromey  <tromey@adacore.com>
7845
7846         * ravenscar-thread.c (base_ptid): Remove.
7847         (struct ravenscar_thread_target) <close>: New method.
7848         <m_base_ptid>: New member.
7849         <update_inferior_ptid, active_task, task_is_currently_active,
7850         runtime_initialized>: Declare methods.
7851         <ravenscar_thread_target>: Add constructor.
7852         (ravenscar_thread_target::task_is_currently_active)
7853         (ravenscar_thread_target::update_inferior_ptid)
7854         (ravenscar_runtime_initialized): Rename.  Now methods.
7855         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7856         (ravenscar_thread_target::update_thread_list): Update.
7857         (ravenscar_thread_target::active_task): Now method.
7858         (ravenscar_thread_target::store_registers)
7859         (ravenscar_thread_target::prepare_to_store)
7860         (ravenscar_thread_target::prepare_to_store)
7861         (ravenscar_thread_target::mourn_inferior): Update.
7862         (ravenscar_inferior_created): Use "new" to create target.
7863         (ravenscar_thread_target::get_ada_task_ptid): Update.
7864         (_initialize_ravenscar): Don't initialize base_ptid.
7865         (ravenscar_ops): Remove global.
7866
7867 2019-02-15  Tom Tromey  <tromey@adacore.com>
7868
7869         * target.h (push_target): Declare new overload.
7870         * target.c (push_target): New overload, taking an rvalue reference.
7871         * remote.c (remote_target::open_1): Use push_target overload.
7872         * corelow.c (core_target_open): Use push_target overload.
7873
7874 2019-02-15  Tom Tromey  <tromey@adacore.com>
7875
7876         * ravenscar-thread.c (is_ravenscar_task)
7877         (ravenscar_task_is_currently_active): Return bool.
7878         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7879         (_initialize_ravenscar): Remove "(void)".
7880         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7881         Return bool.
7882
7883 2019-02-15  Tom Tromey  <tromey@adacore.com>
7884
7885         * ravenscar-thread.c (ravenscar_runtime_initializer)
7886         (has_ravenscar_runtime, get_running_thread_id)
7887         (ravenscar_thread_target::resume): Fix indentation.
7888
7889 2019-02-15  Tom Tromey  <tromey@adacore.com>
7890
7891         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7892         from ravenscar_arch_ops.
7893         (sparc_ravenscar_ops::fetch_registers)
7894         (sparc_ravenscar_ops::store_registers): Now methods.
7895         (sparc_ravenscar_prepare_to_store): Remove.
7896         (sparc_ravenscar_ops): Redefine.
7897         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7898         methods and destructor.  Remove members.
7899         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7900         (ravenscar_thread_target::store_registers)
7901         (ravenscar_thread_target::prepare_to_store): Update.
7902         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7903         Remove.
7904         (struct ppc_ravenscar_powerpc_ops): Derive from
7905         ravenscar_arch_ops.
7906         (ppc_ravenscar_powerpc_ops::fetch_registers)
7907         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7908         (ppc_ravenscar_powerpc_ops): Redefine.
7909         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7910         (ppc_ravenscar_e500_ops::fetch_registers)
7911         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7912         (ppc_ravenscar_e500_ops): Redefine.
7913         * aarch64-ravenscar-thread.c
7914         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7915         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7916         (aarch64_ravenscar_fetch_registers)
7917         (aarch64_ravenscar_store_registers): Now methods.
7918         (aarch64_ravenscar_ops): Redefine.
7919
7920 2019-02-15  Tom Tromey  <tromey@adacore.com>
7921
7922         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7923         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7924         (ravenscar_thread_target::stopped_by_watchpoint)
7925         (ravenscar_thread_target::stopped_data_address)
7926         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7927
7928 2019-02-15  Tom Tromey  <tromey@adacore.com>
7929
7930         * ravenscar-thread.c: Fix some typos.
7931
7932 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7933             Tom Tromey  <tromey@adacore.com>
7934
7935         * ada-lang.c (ada_exception_sal): Change addr_string to a
7936         std::string.
7937         (create_ada_exception_catchpoint): Update.
7938
7939 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7940             Tom Tromey  <tromey@adacore.com>
7941
7942         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7943         (bp_location_ops): Remove.
7944         (base_breakpoint_allocate_location): Update.
7945         (free_bp_location): Update.
7946         * ada-lang.c (class ada_catchpoint_location)
7947         <ada_catchpoint_location>: Remove ops parameter.
7948         (ada_catchpoint_location_dtor): Remove.
7949         (ada_catchpoint_location_ops): Remove.
7950         (allocate_location_exception): Update.
7951         * breakpoint.h (struct bp_location_ops): Remove.
7952         (class bp_location) <bp_location>: Remove bp_location_ops
7953         parameter.
7954         <~bp_location>: Add destructor.
7955         <ops>: Remove.
7956
7957 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7958             Pedro Alves  <palves@redhat.com>
7959
7960         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7961         'PATH_MAX'.
7962
7963 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7964             Samuel Thibault  <samuel.thibault@gnu.org>
7965             Thomas Schwinge  <thomas@codesourcery.com>
7966
7967         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7968         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7969
7970 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7971
7972         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7973         (check_empty): Use "const char *".
7974
7975         * gnu-nat.c (gnu_nat_target::detach): Instead of
7976         'detach_inferior (pid)' call
7977         'detach_inferior (find_inferior_pid (pid))'.
7978
7979         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7980         'nat/fork-inferior.o'.
7981         * gnu-nat.c: #include "nat/fork-inferior.h".
7982
7983         * gnu-nat.c (gnu_nat_target::detach): Instead of
7984         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7985         * gnu-nat.h: #include "inf-child.h".
7986         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7987         'i386_gnu_nat_target::fetch_registers'.
7988         (gnu_store_registers): Rename/move to
7989         'i386_gnu_nat_target::store_registers'.
7990
7991         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7992         * gnu-nat.h (mach_thread_info): New function.
7993         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7994
7995         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7996
7997 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7998
7999         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8000
8001 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8002
8003         * windows-nat.c (windows_add_thread): Add new parameter
8004         "main_thread_p" with default value set to false.  Update
8005         function documentation as well as all callers.
8006         (windows_delete_thread): Likewise.
8007         (fake_create_process): Update call to windows_add_thread.
8008         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8009         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8010         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8011         call to windows_delete_thread.
8012
8013 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8014
8015         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8016
8017 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8018
8019         * symfile.c (find_separate_debug_file): Use canonical path of
8020         sysroot with child_path instead of gdb_sysroot if it is valid.
8021
8022 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8023
8024         * symfile.c (find_separate_debug_file): Use child_path to
8025         determine if an object file is under a sysroot.
8026
8027 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8028
8029         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8030         unittests/child-path-selftests.c.
8031         * common/pathstuff.c (child_path): New function.
8032         * common/pathstuff.h (child_path): New prototype.
8033         * unittests/child-path-selftests.c: New file.
8034
8035 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8036
8037         * symfile.c (find_separate_debug_file): Look for separate debug
8038         files in debug directories under the sysroot.
8039
8040 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8041
8042         * symtab.h (struct minimal_symbol data_p): New const method.
8043         (struct minimal_symbol text_p): Likewise.
8044         * symtab.c (output_source_filename): Use file name style
8045         to print file name.
8046         (print_symbol_info): Likewise.
8047         (print_msymbol_info): Use address style to print addresses.
8048         Use function name style to print executable text symbols.
8049         (expand_symtab_containing_pc): Use data_p.
8050         (find_pc_sect_compunit_symtab): Likewise.
8051
8052 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8053
8054         * breakpoint.c (describe_other_breakpoints): Use address style
8055         to print addresses.
8056         (say_where): Likewise.
8057
8058 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8059
8060         * ada-typeprint.c (print_func_type): Print function name
8061         style to print function name.
8062         * c-typeprint.c (c_print_type_1): Likewise.
8063
8064 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8065
8066         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8067         for execve.
8068
8069 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8070
8071         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8072         type_stack.
8073
8074 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8075
8076         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8077         TYPE_CODE_REF types.
8078
8079 2019-02-08  Jim Wilson  <jimw@sifive.com>
8080
8081         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8082         (riscv_linux_fregset): New.
8083         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8084
8085 2019-02-07  Tom Tromey  <tom@tromey.com>
8086
8087         * thread.c (thread_cancel_execution_command): Update.
8088         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8089         methods.
8090         (struct thread_fsm_ops): Remove.
8091         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8092         (thread_fsm_should_stop, thread_fsm_return_value)
8093         (thread_fsm_set_finished, thread_fsm_finished_p)
8094         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8095         Don't declare.
8096         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8097         * infrun.c (clear_proceed_status_thread)
8098         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8099         (print_stop_event): Update.
8100         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8101         Add constructor.
8102         (step_command_fsm_ops): Remove.
8103         (new_step_command_fsm): Remove.
8104         (step_1): Update.
8105         (step_command_fsm::should_stop): Rename from
8106         step_command_fsm_should_stop.
8107         (step_command_fsm::clean_up): Rename from
8108         step_command_fsm_clean_up.
8109         (step_command_fsm::do_async_reply_reason): Rename from
8110         step_command_fsm_async_reply_reason.
8111         (struct until_next_fsm): Inherit from thread_fsm.  Add
8112         constructor.
8113         (until_next_fsm_ops): Remove.
8114         (new_until_next_fsm): Remove.
8115         (until_next_fsm::should_stop): Rename from
8116         until_next_fsm_should_stop.
8117         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8118         (until_next_fsm::do_async_reply_reason): Rename from
8119         until_next_fsm_async_reply_reason.
8120         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8121         constructor.  Change type of breakpoint.
8122         (finish_command_fsm_ops): Remove.
8123         (new_finish_command_fsm): Remove.
8124         (finish_command_fsm::should_stop): Rename from
8125         finish_command_fsm_should_stop.
8126         (finish_command_fsm::clean_up): Rename from
8127         finish_command_fsm_clean_up.
8128         (finish_command_fsm::return_value): Rename from
8129         finish_command_fsm_return_value.
8130         (finish_command_fsm::do_async_reply_reason): Rename from
8131         finish_command_fsm_async_reply_reason.
8132         (finish_command): Update.
8133         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8134         Add constructor.
8135         (call_thread_fsm_ops): Remove.
8136         (call_thread_fsm::call_thread_fsm): Rename from
8137         new_call_thread_fsm.
8138         (call_thread_fsm::should_stop): Rename from
8139         call_thread_fsm_should_stop.
8140         (call_thread_fsm::should_notify_stop): Rename from
8141         call_thread_fsm_should_notify_stop.
8142         (run_inferior_call, call_function_by_hand_dummy): Update.
8143         * cli/cli-interp.c (should_print_stop_to_console): Update.
8144         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8145         Add constructor.  Change type of location_breakpoint,
8146         caller_breakpoint.
8147         (until_break_fsm_ops): Remove.
8148         (new_until_break_fsm): Remove.
8149         (until_break_fsm::should_stop): Rename from
8150         until_break_fsm_should_stop.
8151         (until_break_fsm::clean_up): Rename from
8152         until_break_fsm_clean_up.
8153         (until_break_fsm::do_async_reply_reason): Rename from
8154         until_break_fsm_async_reply_reason.
8155         (until_break_command): Update.
8156         * thread-fsm.c: Remove.
8157         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8158
8159 2019-02-07  Tom Tromey  <tom@tromey.com>
8160
8161         * yy-remap.h: Add include guard.
8162         * xtensa-tdep.h: Add include guard.
8163         * xcoffread.h: Rename include guard.
8164         * varobj-iter.h: Add include guard.
8165         * tui/tui.h: Rename include guard.
8166         * tui/tui-winsource.h: Rename include guard.
8167         * tui/tui-wingeneral.h: Rename include guard.
8168         * tui/tui-windata.h: Rename include guard.
8169         * tui/tui-win.h: Rename include guard.
8170         * tui/tui-stack.h: Rename include guard.
8171         * tui/tui-source.h: Rename include guard.
8172         * tui/tui-regs.h: Rename include guard.
8173         * tui/tui-out.h: Rename include guard.
8174         * tui/tui-layout.h: Rename include guard.
8175         * tui/tui-io.h: Rename include guard.
8176         * tui/tui-hooks.h: Rename include guard.
8177         * tui/tui-file.h: Rename include guard.
8178         * tui/tui-disasm.h: Rename include guard.
8179         * tui/tui-data.h: Rename include guard.
8180         * tui/tui-command.h: Rename include guard.
8181         * tic6x-tdep.h: Add include guard.
8182         * target/waitstatus.h: Rename include guard.
8183         * target/wait.h: Rename include guard.
8184         * target/target.h: Rename include guard.
8185         * target/resume.h: Rename include guard.
8186         * target-float.h: Rename include guard.
8187         * stabsread.h: Add include guard.
8188         * rs6000-tdep.h: Add include guard.
8189         * riscv-fbsd-tdep.h: Add include guard.
8190         * regformats/regdef.h: Rename include guard.
8191         * record.h: Rename include guard.
8192         * python/python.h: Rename include guard.
8193         * python/python-internal.h: Rename include guard.
8194         * python/py-stopevent.h: Rename include guard.
8195         * python/py-ref.h: Rename include guard.
8196         * python/py-record.h: Rename include guard.
8197         * python/py-record-full.h: Rename include guard.
8198         * python/py-record-btrace.h: Rename include guard.
8199         * python/py-instruction.h: Rename include guard.
8200         * python/py-events.h: Rename include guard.
8201         * python/py-event.h: Rename include guard.
8202         * procfs.h: Add include guard.
8203         * proc-utils.h: Add include guard.
8204         * p-lang.h: Add include guard.
8205         * or1k-tdep.h: Rename include guard.
8206         * observable.h: Rename include guard.
8207         * nto-tdep.h: Rename include guard.
8208         * nat/x86-linux.h: Rename include guard.
8209         * nat/x86-linux-dregs.h: Rename include guard.
8210         * nat/x86-gcc-cpuid.h: Add include guard.
8211         * nat/x86-dregs.h: Rename include guard.
8212         * nat/x86-cpuid.h: Rename include guard.
8213         * nat/ppc-linux.h: Rename include guard.
8214         * nat/mips-linux-watch.h: Rename include guard.
8215         * nat/linux-waitpid.h: Rename include guard.
8216         * nat/linux-ptrace.h: Rename include guard.
8217         * nat/linux-procfs.h: Rename include guard.
8218         * nat/linux-osdata.h: Rename include guard.
8219         * nat/linux-nat.h: Rename include guard.
8220         * nat/linux-namespaces.h: Rename include guard.
8221         * nat/linux-btrace.h: Rename include guard.
8222         * nat/glibc_thread_db.h: Rename include guard.
8223         * nat/gdb_thread_db.h: Rename include guard.
8224         * nat/gdb_ptrace.h: Rename include guard.
8225         * nat/fork-inferior.h: Rename include guard.
8226         * nat/amd64-linux-siginfo.h: Rename include guard.
8227         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8228         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8229         * nat/aarch64-linux.h: Rename include guard.
8230         * nat/aarch64-linux-hw-point.h: Rename include guard.
8231         * mn10300-tdep.h: Add include guard.
8232         * mips-linux-tdep.h: Add include guard.
8233         * mi/mi-parse.h: Rename include guard.
8234         * mi/mi-out.h: Rename include guard.
8235         * mi/mi-main.h: Rename include guard.
8236         * mi/mi-interp.h: Rename include guard.
8237         * mi/mi-getopt.h: Rename include guard.
8238         * mi/mi-console.h: Rename include guard.
8239         * mi/mi-common.h: Rename include guard.
8240         * mi/mi-cmds.h: Rename include guard.
8241         * mi/mi-cmd-break.h: Rename include guard.
8242         * m2-lang.h: Add include guard.
8243         * location.h: Rename include guard.
8244         * linux-record.h: Rename include guard.
8245         * linux-nat.h: Add include guard.
8246         * linux-fork.h: Add include guard.
8247         * i386-darwin-tdep.h: Rename include guard.
8248         * hppa-linux-offsets.h: Add include guard.
8249         * guile/guile.h: Rename include guard.
8250         * guile/guile-internal.h: Rename include guard.
8251         * gnu-nat.h: Rename include guard.
8252         * gdb-stabs.h: Rename include guard.
8253         * frv-tdep.h: Add include guard.
8254         * f-lang.h: Add include guard.
8255         * event-loop.h: Add include guard.
8256         * darwin-nat.h: Rename include guard.
8257         * cp-abi.h: Rename include guard.
8258         * config/sparc/nm-sol2.h: Rename include guard.
8259         * config/nm-nto.h: Rename include guard.
8260         * config/nm-linux.h: Add include guard.
8261         * config/i386/nm-i386gnu.h: Rename include guard.
8262         * config/djgpp/nl_types.h: Rename include guard.
8263         * config/djgpp/langinfo.h: Rename include guard.
8264         * compile/gcc-cp-plugin.h: Add include guard.
8265         * compile/gcc-c-plugin.h: Add include guard.
8266         * compile/compile.h: Rename include guard.
8267         * compile/compile-object-run.h: Rename include guard.
8268         * compile/compile-object-load.h: Rename include guard.
8269         * compile/compile-internal.h: Rename include guard.
8270         * compile/compile-cplus.h: Rename include guard.
8271         * compile/compile-c.h: Rename include guard.
8272         * common/xml-utils.h: Rename include guard.
8273         * common/x86-xstate.h: Rename include guard.
8274         * common/version.h: Rename include guard.
8275         * common/vec.h: Rename include guard.
8276         * common/tdesc.h: Rename include guard.
8277         * common/selftest.h: Rename include guard.
8278         * common/scoped_restore.h: Rename include guard.
8279         * common/scoped_mmap.h: Rename include guard.
8280         * common/scoped_fd.h: Rename include guard.
8281         * common/safe-iterator.h: Rename include guard.
8282         * common/run-time-clock.h: Rename include guard.
8283         * common/refcounted-object.h: Rename include guard.
8284         * common/queue.h: Rename include guard.
8285         * common/ptid.h: Rename include guard.
8286         * common/print-utils.h: Rename include guard.
8287         * common/preprocessor.h: Rename include guard.
8288         * common/pathstuff.h: Rename include guard.
8289         * common/observable.h: Rename include guard.
8290         * common/netstuff.h: Rename include guard.
8291         * common/job-control.h: Rename include guard.
8292         * common/host-defs.h: Rename include guard.
8293         * common/gdb_wait.h: Rename include guard.
8294         * common/gdb_vecs.h: Rename include guard.
8295         * common/gdb_unlinker.h: Rename include guard.
8296         * common/gdb_unique_ptr.h: Rename include guard.
8297         * common/gdb_tilde_expand.h: Rename include guard.
8298         * common/gdb_sys_time.h: Rename include guard.
8299         * common/gdb_string_view.h: Rename include guard.
8300         * common/gdb_splay_tree.h: Rename include guard.
8301         * common/gdb_setjmp.h: Rename include guard.
8302         * common/gdb_ref_ptr.h: Rename include guard.
8303         * common/gdb_optional.h: Rename include guard.
8304         * common/gdb_locale.h: Rename include guard.
8305         * common/gdb_assert.h: Rename include guard.
8306         * common/filtered-iterator.h: Rename include guard.
8307         * common/filestuff.h: Rename include guard.
8308         * common/fileio.h: Rename include guard.
8309         * common/environ.h: Rename include guard.
8310         * common/common-utils.h: Rename include guard.
8311         * common/common-types.h: Rename include guard.
8312         * common/common-regcache.h: Rename include guard.
8313         * common/common-inferior.h: Rename include guard.
8314         * common/common-gdbthread.h: Rename include guard.
8315         * common/common-exceptions.h: Rename include guard.
8316         * common/common-defs.h: Rename include guard.
8317         * common/common-debug.h: Rename include guard.
8318         * common/cleanups.h: Rename include guard.
8319         * common/buffer.h: Rename include guard.
8320         * common/btrace-common.h: Rename include guard.
8321         * common/break-common.h: Rename include guard.
8322         * cli/cli-utils.h: Rename include guard.
8323         * cli/cli-style.h: Rename include guard.
8324         * cli/cli-setshow.h: Rename include guard.
8325         * cli/cli-script.h: Rename include guard.
8326         * cli/cli-interp.h: Rename include guard.
8327         * cli/cli-decode.h: Rename include guard.
8328         * cli/cli-cmds.h: Rename include guard.
8329         * charset-list.h: Add include guard.
8330         * buildsym-legacy.h: Rename include guard.
8331         * bfin-tdep.h: Add include guard.
8332         * ax.h: Rename include guard.
8333         * arm-linux-tdep.h: Add include guard.
8334         * arm-fbsd-tdep.h: Add include guard.
8335         * arch/xtensa.h: Rename include guard.
8336         * arch/tic6x.h: Add include guard.
8337         * arch/i386.h: Add include guard.
8338         * arch/arm.h: Rename include guard.
8339         * arch/arm-linux.h: Rename include guard.
8340         * arch/arm-get-next-pcs.h: Rename include guard.
8341         * arch/amd64.h: Add include guard.
8342         * arch/aarch64-insn.h: Rename include guard.
8343         * arch-utils.h: Rename include guard.
8344         * annotate.h: Add include guard.
8345         * amd64-darwin-tdep.h: Rename include guard.
8346         * aarch64-linux-tdep.h: Add include guard.
8347         * aarch64-fbsd-tdep.h: Add include guard.
8348         * aarch32-linux-nat.h: Add include guard.
8349
8350 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8351
8352         * macrotab.c (macro_define_internal): New function that
8353         factorizes macro_define_object_internal and macro_define_function
8354         code.
8355         (macro_define_object_internal): Use macro_define_internal.
8356         (macro_define_function): Likewise.
8357
8358 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8359
8360         * macrocmd.c (extract_identifier): Return
8361         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8362         callers.
8363
8364 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8365
8366         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8367
8368 2019-02-05  Tom Tromey  <tom@tromey.com>
8369
8370         * target.c (target_stack::unpush): Move assertion earlier.
8371
8372 2019-01-30  Tom Tromey  <tom@tromey.com>
8373
8374         PR python/23615:
8375         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8376         (gdbpy_parse_and_eval): Likewise.
8377         * python/python-internal.h (gdbpy_allow_threads): New class.
8378
8379 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8380
8381         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8382         (aarch64_fbsd_fpregmap): Move earlier.
8383         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8384         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8385         instead of individual calls to trad_frame_set_reg_addr.
8386         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8387         earlier.
8388         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8389         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8390         instead of individual calls to trad_frame_set_reg_addr.
8391
8392 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8393
8394         * CONTRIBUTE: Replace contribution list with wiki link.
8395
8396 2019-01-25  Tom Tromey  <tom@tromey.com>
8397
8398         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8399
8400 2019-01-25  Tom Tromey  <tom@tromey.com>
8401
8402         * xtensa-linux-nat.c: Fix common/ includes.
8403         * xml-support.h: Fix common/ includes.
8404         * xml-support.c: Fix common/ includes.
8405         * x86-linux-nat.c: Fix common/ includes.
8406         * windows-nat.c: Fix common/ includes.
8407         * varobj.h: Fix common/ includes.
8408         * varobj.c: Fix common/ includes.
8409         * value.c: Fix common/ includes.
8410         * valops.c: Fix common/ includes.
8411         * utils.c: Fix common/ includes.
8412         * unittests/xml-utils-selftests.c: Fix common/ includes.
8413         * unittests/utils-selftests.c: Fix common/ includes.
8414         * unittests/unpack-selftests.c: Fix common/ includes.
8415         * unittests/tracepoint-selftests.c: Fix common/ includes.
8416         * unittests/style-selftests.c: Fix common/ includes.
8417         * unittests/string_view-selftests.c: Fix common/ includes.
8418         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8419         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8420         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8421         * unittests/rsp-low-selftests.c: Fix common/ includes.
8422         * unittests/parse-connection-spec-selftests.c: Fix common/
8423         includes.
8424         * unittests/optional-selftests.c: Fix common/ includes.
8425         * unittests/offset-type-selftests.c: Fix common/ includes.
8426         * unittests/observable-selftests.c: Fix common/ includes.
8427         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8428         * unittests/memrange-selftests.c: Fix common/ includes.
8429         * unittests/memory-map-selftests.c: Fix common/ includes.
8430         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8431         * unittests/function-view-selftests.c: Fix common/ includes.
8432         * unittests/environ-selftests.c: Fix common/ includes.
8433         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8434         * unittests/common-utils-selftests.c: Fix common/ includes.
8435         * unittests/cli-utils-selftests.c: Fix common/ includes.
8436         * unittests/array-view-selftests.c: Fix common/ includes.
8437         * ui-file.c: Fix common/ includes.
8438         * tui/tui-io.c: Fix common/ includes.
8439         * tracepoint.h: Fix common/ includes.
8440         * tracepoint.c: Fix common/ includes.
8441         * tracefile-tfile.c: Fix common/ includes.
8442         * top.h: Fix common/ includes.
8443         * top.c: Fix common/ includes.
8444         * thread.c: Fix common/ includes.
8445         * target/waitstatus.h: Fix common/ includes.
8446         * target/waitstatus.c: Fix common/ includes.
8447         * target.h: Fix common/ includes.
8448         * target.c: Fix common/ includes.
8449         * target-memory.c: Fix common/ includes.
8450         * target-descriptions.c: Fix common/ includes.
8451         * symtab.h: Fix common/ includes.
8452         * symfile.c: Fix common/ includes.
8453         * stap-probe.c: Fix common/ includes.
8454         * spu-linux-nat.c: Fix common/ includes.
8455         * sparc-nat.c: Fix common/ includes.
8456         * source.c: Fix common/ includes.
8457         * solib.c: Fix common/ includes.
8458         * solib-target.c: Fix common/ includes.
8459         * ser-unix.c: Fix common/ includes.
8460         * ser-tcp.c: Fix common/ includes.
8461         * ser-pipe.c: Fix common/ includes.
8462         * ser-base.c: Fix common/ includes.
8463         * selftest-arch.c: Fix common/ includes.
8464         * s12z-tdep.c: Fix common/ includes.
8465         * rust-exp.y: Fix common/ includes.
8466         * rs6000-aix-tdep.c: Fix common/ includes.
8467         * riscv-tdep.c: Fix common/ includes.
8468         * remote.c: Fix common/ includes.
8469         * remote-notif.h: Fix common/ includes.
8470         * remote-fileio.h: Fix common/ includes.
8471         * remote-fileio.c: Fix common/ includes.
8472         * regcache.h: Fix common/ includes.
8473         * regcache.c: Fix common/ includes.
8474         * record-btrace.c: Fix common/ includes.
8475         * python/python.c: Fix common/ includes.
8476         * python/py-type.c: Fix common/ includes.
8477         * python/py-inferior.c: Fix common/ includes.
8478         * progspace.h: Fix common/ includes.
8479         * producer.c: Fix common/ includes.
8480         * procfs.c: Fix common/ includes.
8481         * proc-api.c: Fix common/ includes.
8482         * printcmd.c: Fix common/ includes.
8483         * ppc-linux-nat.c: Fix common/ includes.
8484         * parser-defs.h: Fix common/ includes.
8485         * osdata.c: Fix common/ includes.
8486         * obsd-nat.c: Fix common/ includes.
8487         * nat/x86-linux.c: Fix common/ includes.
8488         * nat/x86-linux-dregs.c: Fix common/ includes.
8489         * nat/x86-dregs.h: Fix common/ includes.
8490         * nat/x86-dregs.c: Fix common/ includes.
8491         * nat/ppc-linux.c: Fix common/ includes.
8492         * nat/mips-linux-watch.h: Fix common/ includes.
8493         * nat/mips-linux-watch.c: Fix common/ includes.
8494         * nat/linux-waitpid.c: Fix common/ includes.
8495         * nat/linux-ptrace.h: Fix common/ includes.
8496         * nat/linux-ptrace.c: Fix common/ includes.
8497         * nat/linux-procfs.c: Fix common/ includes.
8498         * nat/linux-personality.c: Fix common/ includes.
8499         * nat/linux-osdata.c: Fix common/ includes.
8500         * nat/linux-namespaces.c: Fix common/ includes.
8501         * nat/linux-btrace.h: Fix common/ includes.
8502         * nat/linux-btrace.c: Fix common/ includes.
8503         * nat/fork-inferior.c: Fix common/ includes.
8504         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8505         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8506         * nat/aarch64-linux.c: Fix common/ includes.
8507         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8508         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8509         * namespace.h: Fix common/ includes.
8510         * mips-linux-tdep.c: Fix common/ includes.
8511         * minsyms.c: Fix common/ includes.
8512         * mi/mi-parse.h: Fix common/ includes.
8513         * mi/mi-main.c: Fix common/ includes.
8514         * mi/mi-cmd-env.c: Fix common/ includes.
8515         * memrange.h: Fix common/ includes.
8516         * memattr.c: Fix common/ includes.
8517         * maint.h: Fix common/ includes.
8518         * maint.c: Fix common/ includes.
8519         * main.c: Fix common/ includes.
8520         * machoread.c: Fix common/ includes.
8521         * location.c: Fix common/ includes.
8522         * linux-thread-db.c: Fix common/ includes.
8523         * linux-nat.c: Fix common/ includes.
8524         * linux-fork.c: Fix common/ includes.
8525         * inline-frame.c: Fix common/ includes.
8526         * infrun.c: Fix common/ includes.
8527         * inflow.c: Fix common/ includes.
8528         * inferior.h: Fix common/ includes.
8529         * inferior.c: Fix common/ includes.
8530         * infcmd.c: Fix common/ includes.
8531         * inf-ptrace.c: Fix common/ includes.
8532         * inf-child.c: Fix common/ includes.
8533         * ia64-linux-nat.c: Fix common/ includes.
8534         * i387-tdep.c: Fix common/ includes.
8535         * i386-tdep.c: Fix common/ includes.
8536         * i386-linux-tdep.c: Fix common/ includes.
8537         * i386-linux-nat.c: Fix common/ includes.
8538         * i386-go32-tdep.c: Fix common/ includes.
8539         * i386-fbsd-tdep.c: Fix common/ includes.
8540         * i386-fbsd-nat.c: Fix common/ includes.
8541         * guile/scm-type.c: Fix common/ includes.
8542         * guile/guile.c: Fix common/ includes.
8543         * go32-nat.c: Fix common/ includes.
8544         * gnu-nat.c: Fix common/ includes.
8545         * gdbthread.h: Fix common/ includes.
8546         * gdbarch-selftests.c: Fix common/ includes.
8547         * gdb_usleep.c: Fix common/ includes.
8548         * gdb_select.h: Fix common/ includes.
8549         * gdb_bfd.c: Fix common/ includes.
8550         * gcore.c: Fix common/ includes.
8551         * fork-child.c: Fix common/ includes.
8552         * findvar.c: Fix common/ includes.
8553         * fbsd-nat.c: Fix common/ includes.
8554         * event-top.c: Fix common/ includes.
8555         * event-loop.c: Fix common/ includes.
8556         * dwarf2read.c: Fix common/ includes.
8557         * dwarf2loc.c: Fix common/ includes.
8558         * dwarf2-frame.c: Fix common/ includes.
8559         * dwarf-index-cache.c: Fix common/ includes.
8560         * dtrace-probe.c: Fix common/ includes.
8561         * disasm-selftests.c: Fix common/ includes.
8562         * defs.h: Fix common/ includes.
8563         * csky-tdep.c: Fix common/ includes.
8564         * cp-valprint.c: Fix common/ includes.
8565         * cp-support.h: Fix common/ includes.
8566         * cp-support.c: Fix common/ includes.
8567         * corelow.c: Fix common/ includes.
8568         * completer.h: Fix common/ includes.
8569         * completer.c: Fix common/ includes.
8570         * compile/compile.c: Fix common/ includes.
8571         * compile/compile-loc2c.c: Fix common/ includes.
8572         * compile/compile-cplus-types.c: Fix common/ includes.
8573         * compile/compile-cplus-symbols.c: Fix common/ includes.
8574         * command.h: Fix common/ includes.
8575         * cli/cli-dump.c: Fix common/ includes.
8576         * cli/cli-cmds.c: Fix common/ includes.
8577         * charset.c: Fix common/ includes.
8578         * build-id.c: Fix common/ includes.
8579         * btrace.h: Fix common/ includes.
8580         * btrace.c: Fix common/ includes.
8581         * breakpoint.h: Fix common/ includes.
8582         * breakpoint.c: Fix common/ includes.
8583         * ax.h:
8584         (enum agent_op): Fix common/ includes.
8585         * ax-general.c (struct aop_map): Fix common/ includes.
8586         * ax-gdb.c: Fix common/ includes.
8587         * auxv.c: Fix common/ includes.
8588         * auto-load.c: Fix common/ includes.
8589         * arm-tdep.c: Fix common/ includes.
8590         * arch/riscv.c: Fix common/ includes.
8591         * arch/ppc-linux-common.c: Fix common/ includes.
8592         * arch/i386.c: Fix common/ includes.
8593         * arch/arm.c: Fix common/ includes.
8594         * arch/arm-linux.c: Fix common/ includes.
8595         * arch/arm-get-next-pcs.c: Fix common/ includes.
8596         * arch/amd64.c: Fix common/ includes.
8597         * arch/aarch64.c: Fix common/ includes.
8598         * arch/aarch64-insn.c: Fix common/ includes.
8599         * arch-utils.c: Fix common/ includes.
8600         * amd64-windows-tdep.c: Fix common/ includes.
8601         * amd64-tdep.c: Fix common/ includes.
8602         * amd64-sol2-tdep.c: Fix common/ includes.
8603         * amd64-obsd-tdep.c: Fix common/ includes.
8604         * amd64-nbsd-tdep.c: Fix common/ includes.
8605         * amd64-linux-tdep.c: Fix common/ includes.
8606         * amd64-linux-nat.c: Fix common/ includes.
8607         * amd64-fbsd-tdep.c: Fix common/ includes.
8608         * amd64-fbsd-nat.c: Fix common/ includes.
8609         * amd64-dicos-tdep.c: Fix common/ includes.
8610         * amd64-darwin-tdep.c: Fix common/ includes.
8611         * agent.c: Fix common/ includes.
8612         * ada-lang.h: Fix common/ includes.
8613         * ada-lang.c: Fix common/ includes.
8614         * aarch64-tdep.c: Fix common/ includes.
8615
8616 2019-01-25  Tom Tromey  <tom@tromey.com>
8617
8618         * common/create-version.sh: Use common/version.h.
8619
8620 2019-01-24  Pedro Alves  <palves@redhat.com>
8621
8622         * infrun.c (signal_stop, signal_print, signal_program)
8623         (signal_catch, signal_pass): Now arrays instead of pointers.
8624         (update_signals_program_target, do_target_resume)
8625         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8626         * linux-nat.c (linux_nat_target::pass_signals)
8627         (linux_nat_target::create_inferior, linux_nat_target::attach):
8628         Adjust.
8629         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8630         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8631         * procfs.c (procfs_target::pass_signals): Adjust.
8632         * record-full.c (record_full_target::resume): Adjust.
8633         * remote.c (remote_target::pass_signals)
8634         (remote_target::program_signals): Adjust.
8635         * target-debug.h (target_debug_print_signals): Now takes a
8636         gdb::array_view as parameter.  Adjust.
8637         * target.h (target_ops) <pass_signals, program_signals>: Replace
8638         pointer and length parameters with gdb::array_view.
8639         (target_pass_signals, target_program_signals): Likewise.
8640         * target-delegates.c: Regenerate.
8641
8642 2019-01-24  Pedro Alves  <palves@redhat.com>
8643
8644         * common/forward-scope-exit.h
8645         (forward_scope_exit::forward_scope_exit): Pass arguments to
8646         m_bind_function directly, instead of creating a std::bind and
8647         copying that.
8648
8649 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8650
8651         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8652         for static members.
8653         (pass_in_v_vfp_candidate): Likewise.
8654
8655 2019-01-23  Tom Tromey  <tom@tromey.com>
8656             Pedro Alves  <palves@redhat.com>
8657
8658         * regcache.c (class regcache_invalidator): Remove.
8659         (regcache::raw_write): Use make_scope_exit.
8660
8661 2019-01-23  Tom Tromey  <tom@tromey.com>
8662
8663         * ui-out.h (class ui_out_emit_type): Update comment.
8664
8665 2019-01-23  Tom Tromey  <tom@tromey.com>
8666
8667         * infrun.c (fetch_inferior_event): Update comment.
8668
8669 2019-01-23  Tom Tromey  <tom@tromey.com>
8670             Pedro Alves  <palves@redhat.com>
8671
8672         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8673         parameter.
8674         (fetch_inferior_event): Use SCOPE_EXIT.
8675
8676
8677 2019-01-23  Tom Tromey  <tom@tromey.com>
8678             Pedro Alves  <palves@redhat.com>
8679
8680         * infrun.c (disable_thread_events): Delete.
8681         (stop_all_threads): Use SCOPE_EXIT.
8682
8683 2019-01-23  Tom Tromey  <tom@tromey.com>
8684             Pedro Alves  <palves@redhat.com>
8685
8686         * symfile.c: Include forward-scope-exit.h.
8687         (clear_symtab_users_cleanup): Replace forward declaration with
8688         a FORWARD_SCOPE_EXIT.
8689         (syms_from_objfile_1): Use the forward_scope_exit and
8690         gdb::optional instead of cleanup_function.
8691         (reread_symbols): Use the forward_scope_exit instead of
8692         cleanup_function.
8693         (clear_symtab_users_cleanup): Remove function.
8694
8695 2019-01-23  Tom Tromey  <tom@tromey.com>
8696             Pedro Alves  <palves@redhat.com>
8697
8698         * linux-nat.c: Include scope-exit.h.
8699         (cleanup_target_stop): Remove.
8700         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8701         SCOPE_EXIT.
8702
8703 2019-01-23  Tom Tromey  <tom@tromey.com>
8704             Pedro Alves  <palves@redhat.com>
8705
8706         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8707         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8708
8709 2019-01-23  Tom Tromey  <tom@tromey.com>
8710             Andrew Burgess  <andrew.burgess@embecosm.com>
8711             Pedro Alves  <palves@redhat.com>
8712
8713         * infrun.c (fetch_inferior_event): Use scope_exit.
8714         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8715         * top.c (execute_command): Use scope_exit.
8716         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8717         * utils.c (do_bpstat_clear_actions_cleanup)
8718         (make_bpstat_clear_actions_cleanup): Remove.
8719
8720 2019-01-23  Tom Tromey  <tom@tromey.com>
8721             Pedro Alves  <palves@redhat.com>
8722
8723         * infrun.c: Include "common/scope-exit.h"
8724         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8725         (wait_for_inferior): Use SCOPE_EXIT.
8726         (fetch_inferior_event): Use scope_exit.
8727
8728 2019-01-23  Tom Tromey  <tom@tromey.com>
8729             Pedro Alves  <palves@redhat.com>
8730
8731         * breakpoint.c (create_breakpoint): Remove cleanup.
8732
8733 2019-01-23  Tom Tromey  <tom@tromey.com>
8734             Andrew Burgess  <andrew.burgess@embecosm.com>
8735             Pedro Alves  <palves@redhat.com>
8736
8737 2019-01-23  Pedro Alves  <palves@redhat.com>
8738
8739         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8740
8741 2019-01-23  Pedro Alves  <palves@redhat.com>
8742             Andrew Burgess  <andrew.burgess@embecosm.com>
8743
8744         * gdbthread.h: Include "common/forward-scope-exit.h".
8745         (scoped_finish_thread_state): Redefine custom class in terms of
8746         forward_scope_exit.
8747
8748 2019-01-23  Pedro Alves  <palves@redhat.com>
8749             Andrew Burgess  <andrew.burgess@embecosm.com>
8750
8751         * common/forward-scope-exit.h: New file.
8752
8753 2019-01-23  Pedro Alves  <palves@redhat.com>
8754             Andrew Burgess  <andrew.burgess@embecosm.com>
8755             Tom Tromey  <tom@tromey.com>
8756
8757         * common/scope-exit.h: New file.
8758
8759 2019-01-23  Pedro Alves  <palves@redhat.com>
8760
8761         * common/preprocessor.h (ESC): Rename to ...
8762         (ESC_PARENS): ... this.
8763         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8764         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8765
8766 2019-01-23  Tom Tromey  <tom@tromey.com>
8767
8768         * language.h (class scoped_switch_to_sym_language_if_auto):
8769         Initialize m_lang in both cases.
8770
8771 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8772
8773         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8774         with XCNEW.
8775
8776 2019-01-22  Tom Tromey  <tom@tromey.com>
8777
8778         * corelow.c: Do not include sys/file.h.
8779
8780 2019-01-22  Tom Tromey  <tom@tromey.com>
8781
8782         * tui/tui-wingeneral.h: Include gdb_curses.h.
8783
8784 2019-01-22  Tom Tromey  <tom@tromey.com>
8785
8786         * source-cache.h (class source_cache) <get_source_lines,
8787         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8788
8789 2019-01-22  Tom Tromey  <tom@tromey.com>
8790
8791         * remote-fileio.h (struct remote_target): Declare.
8792
8793 2019-01-22  Tom Tromey  <tom@tromey.com>
8794
8795         * python/py-arch.c: Do not include py-ref.h.
8796         * python/py-bpevent.c: Do not include py-ref.h.
8797         * python/py-cmd.c: Do not include py-ref.h.
8798         * python/py-continueevent.c: Do not include py-ref.h.
8799         * python/py-event.h: Do not include py-ref.h.
8800         * python/py-evtregistry.c: Do not include py-ref.h.
8801         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8802         * python/py-frame.c: Do not include py-ref.h.
8803         * python/py-framefilter.c: Do not include py-ref.h.
8804         * python/py-function.c: Do not include py-ref.h.
8805         * python/py-infevents.c: Do not include py-ref.h.
8806         * python/py-linetable.c: Do not include py-ref.h.
8807         * python/py-objfile.c: Do not include py-ref.h.
8808         * python/py-param.c: Do not include py-ref.h.
8809         * python/py-prettyprint.c: Do not include py-ref.h.
8810         * python/py-progspace.c: Do not include py-ref.h.
8811         * python/py-symbol.c: Do not include py-ref.h.
8812         * python/py-symtab.c: Do not include py-ref.h.
8813         * python/py-type.c: Do not include py-ref.h.
8814         * python/py-unwind.c: Do not include py-ref.h.
8815         * python/py-utils.c: Do not include py-ref.h.
8816         * python/py-value.c: Do not include py-ref.h.
8817         * python/py-varobj.c: Do not include py-ref.h.
8818         * python/py-xmethods.c: Do not include py-ref.h.
8819         * python/python.c: Do not include py-ref.h.
8820         * varobj.c: Do not include py-ref.h.
8821
8822 2019-01-22  Tom Tromey  <tom@tromey.com>
8823
8824         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8825         keyword for bcache.
8826
8827 2019-01-22  Tom Tromey  <tom@tromey.com>
8828
8829         * compile/compile-cplus-types.c: Remove a comment by #include.
8830
8831 2019-01-22  Tom Tromey  <tom@tromey.com>
8832
8833         * compile/gcc-c-plugin.h: Include compile-internal.h.
8834
8835 2019-01-22  Tom Tromey  <tom@tromey.com>
8836
8837         * stabsread.c (EXTERN): Do not define.
8838         (symnum, next_symbol_text_func, processing_gcc_compilation)
8839         (within_function, global_sym_chain, global_stabs)
8840         (previous_stab_code, this_object_header_files)
8841         (n_this_object_header_files)
8842         (n_allocated_this_object_header_files): Define.
8843         * stabsread.h (EXTERN): Never define.  Use "extern".
8844
8845 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8846
8847         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8848         history_value.
8849
8850 2019-01-21  Tom Tromey  <tom@tromey.com>
8851
8852         * ui-out.c: Fix includes.
8853         * tui/tui-source.c: Fix includes.
8854         * target.c: Fix includes.
8855         * remote.c: Fix includes.
8856         * regcache.c: Fix includes.
8857         * python/py-block.c: Fix includes.
8858         * printcmd.c: Fix includes.
8859         * or1k-tdep.c: Fix includes.
8860         * mi/mi-main.c: Fix includes.
8861         * m32r-tdep.c: Fix includes.
8862         * csky-tdep.c: Fix includes.
8863         * compile/compile-cplus-types.c: Fix includes.
8864         * cli/cli-interp.c: Fix includes.
8865
8866 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8867
8868         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8869         for padding.
8870
8871 2019-01-16  Tom Tromey  <tom@tromey.com>
8872
8873         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8874         earlier.
8875         (struct objfile) <msymbols_range>: Move from top level.
8876         <msymbols>: New method.
8877         (class objfile_msymbols): Remove.
8878         * symtab.c (default_collect_symbol_completion_matches_break_on):
8879         Update.
8880         * symmisc.c (dump_msymbols): Update.
8881         * stabsread.c (scan_file_globals): Update.
8882         * objc-lang.c (info_selectors_command, info_classes_command)
8883         (find_methods): Update.
8884         * minsyms.c (find_solib_trampoline_target): Update.
8885         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8886         * coffread.c (coff_symfile_read): Update.
8887         * ada-lang.c (ada_lookup_simple_minsym)
8888         (ada_collect_symbol_completion_matches): Update.
8889
8890 2019-01-16  Tom Tromey  <tom@tromey.com>
8891
8892         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8893         type.  Remove no-argument constructor.
8894         <iterator::operator++>: Simplify.
8895         <begin>: Update.
8896         <end>: Use minimal_symbol_count.
8897
8898 2019-01-16  Tom Tromey  <tom@tromey.com>
8899
8900         * objfiles.h (struct objfile) <psymtabs>: New method.
8901         (class objfile_psymtabs): Remove.
8902         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8903         typedef.
8904         <range>: New method.
8905         (require_partial_symbols): Change return type.
8906         * psymtab.c (require_partial_symbols)
8907         (psym_expand_symtabs_matching): Update.
8908         * mdebugread.c (parse_partial_symbols): Update.
8909         * dbxread.c (dbx_end_psymtab): Update.
8910
8911 2019-01-15  Tom Tromey  <tom@tromey.com>
8912
8913         * symtab.c (lookup_objfile_from_block)
8914         (lookup_symbol_in_objfile_symtabs)
8915         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8916         (find_line_symtab, info_sources_command)
8917         (default_collect_symbol_completion_matches_break_on)
8918         (make_source_files_completion_list): Update.
8919         * symmisc.c (print_objfile_statistics, dump_objfile)
8920         (maintenance_print_symbols, maintenance_info_symtabs)
8921         (maintenance_check_symtabs, maintenance_info_line_tables):
8922         Update.
8923         * source.c (select_source_symtab)
8924         (forget_cached_source_info_for_objfile): Update.
8925         * objfiles.h (class objfile_compunits): Remove.
8926         (struct objfile) <compunits_range>: New typedef.
8927         (compunits): New method.
8928         * objfiles.c (objfile_relocate1): Update.
8929         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8930         * maint.c (count_symtabs_and_blocks): Update.
8931         * linespec.c (iterate_over_all_matching_symtabs): Update.
8932         * cp-support.c (add_symbol_overload_list_qualified): Update.
8933         * coffread.c (coff_symtab_read): Update.
8934         * ada-lang.c (add_nonlocal_symbols)
8935         (ada_collect_symbol_completion_matches)
8936         (ada_add_global_exceptions): Update.
8937
8938 2019-01-15  Tom Tromey  <tom@tromey.com>
8939
8940         * progspace.h (program_space) <objfiles_safe_range>: New
8941         typedef.
8942         <objfiles_safe>: New method.
8943         * objfiles.h (class all_objfiles_safe): Remove.
8944         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8945         * jit.c (jit_inferior_exit_hook): Update.
8946
8947 2019-01-17  Tom Tromey  <tom@tromey.com>
8948
8949         * progspace.h (program_space) <objfiles_range>: New typedef.
8950         <objfiles>: New method.
8951         <objfiles_head>: Rename from objfiles.
8952         (object_files): Update.
8953         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8954         * guile/scm-pretty-print.c
8955         (ppscm_find_pretty_printer_from_objfiles): Update.
8956         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8957         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8958         Update.
8959         * python/py-progspace.c (pspy_get_objfiles): Update.
8960         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8961         Update.
8962         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8963         (objfpy_lookup_objfile_by_build_id): Update.
8964         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8965         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8966         Update.
8967         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8968         (expand_symtab_containing_pc, lookup_objfile_from_block)
8969         (lookup_static_symbol, basic_lookup_transparent_type)
8970         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8971         (find_line_symtab, info_sources_command)
8972         (default_collect_symbol_completion_matches_break_on)
8973         (make_source_files_completion_list, find_main_name): Update.
8974         * symmisc.c (print_symbol_bcache_statistics)
8975         (print_objfile_statistics, maintenance_print_symbols)
8976         (maintenance_print_msymbols, maintenance_print_objfiles)
8977         (maintenance_info_symtabs, maintenance_check_symtabs)
8978         (maintenance_expand_symtabs, maintenance_info_line_tables):
8979         Update.
8980         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8981         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8982         (map_overlay_command, unmap_overlay_command)
8983         (simple_overlay_update, expand_symtabs_matching)
8984         (map_symbol_filenames): Update.
8985         * symfile-debug.c (set_debug_symfile): Update.
8986         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8987         Update.
8988         * source.c (select_source_symtab, forget_cached_source_info):
8989         Update.
8990         * solib.c (solib_read_symbols): Update.
8991         * solib-spu.c (append_ocl_sos): Update.
8992         * psymtab.c (maintenance_print_psymbols)
8993         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8994         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8995         * printcmd.c (info_symbol_command): Update.
8996         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8997         Update.
8998         * objfiles.h (class all_objfiles): Remove.
8999         * objfiles.c (have_partial_symbols, have_full_symbols)
9000         (have_minimal_symbols, qsort_cmp, update_section_map)
9001         (shared_objfile_contains_address_p)
9002         (default_iterate_over_objfiles_in_search_order): Update.
9003         * objc-lang.c (info_selectors_command, info_classes_command)
9004         (find_methods): Update.
9005         * minsyms.c (find_solib_trampoline_target): Update.
9006         * maint.c (maintenance_info_sections)
9007         (maintenance_translate_address, count_symtabs_and_blocks):
9008         Update.
9009         * main.c (captured_main_1): Update.
9010         * linux-thread-db.c (try_thread_db_load_from_pdir)
9011         (has_libpthread): Update.
9012         * linespec.c (iterate_over_all_matching_symtabs)
9013         (search_minsyms_for_name): Update.
9014         * jit.c (jit_find_objf_with_entry_addr): Update.
9015         * hppa-tdep.c (find_unwind_entry)
9016         (hppa_lookup_stub_minimal_symbol): Update.
9017         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9018         Update.
9019         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9020         (elf_gnu_ifunc_resolve_by_got): Update.
9021         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9022         * dwarf-index-write.c (save_gdb_index_command): Update.
9023         * cp-support.c (add_symbol_overload_list_qualified): Update.
9024         * breakpoint.c (create_overlay_event_breakpoint)
9025         (create_longjmp_master_breakpoint)
9026         (create_std_terminate_master_breakpoint)
9027         (create_exception_master_breakpoint): Update.
9028         * blockframe.c (find_pc_partial_function): Update.
9029         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9030         (ada_collect_symbol_completion_matches)
9031         (ada_add_global_exceptions): Update.
9032
9033 2019-01-17  Tom Tromey  <tom@tromey.com>
9034
9035         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9036         declare VEC.
9037         (solib_target_parse_libraries): Change return type.
9038         (library_list_start_segment, library_list_start_section)
9039         (library_list_end_library, library_list_start_library); Update.
9040         (solib_target_free_library_list): Remove.
9041         (solib_target_parse_libraries): Remove cleanup.  Change return
9042         type.
9043         (solib_target_current_sos): Update.
9044
9045 2019-01-17  Tom Tromey  <tromey@bapiya>
9046
9047         * valprint.c: Replace "the the" with "the".
9048         * symtab.c: Replace "the the" with "the".
9049         * solib.c: Replace "the the" with "the".
9050         * solib-dsbt.c: Replace "the the" with "the".
9051         * linespec.c: Replace "the the" with "the".
9052         * dwarf2loc.h: Replace "the the" with "the".
9053         * amd64-windows-tdep.c: Replace "the the" with "the".
9054         * aarch64-tdep.c: Replace "the the" with "the".
9055
9056 2019-01-16  Keith Seitz  <keiths@redhat.com>
9057
9058         PR gdb/23773
9059         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9060         <builder>: Rename to ..
9061         <m_builder>: ... this and make private.
9062         (dwarf2_cu::get_builder): New method.  Change all users of
9063         `builder' to use this method.
9064         (dwarf2_start_symtab): Move to ...
9065         (dwarf2_cu::start_symtab): ... here.  Update all callers
9066         (setup_type_unit_groups): Move to ...
9067         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9068         callers.
9069         (dwarf2_cu::reset_builder): New method.
9070         (process_full_compunit, process_full_type_unit): Use
9071         dwarf2_cu::reset_builder.
9072         (follow_die_offset): Record the ancestor CU if it is different
9073         from the followed DIE's CU.
9074         (follow_die_sig_1): Likewise.
9075
9076 2019-01-15  Tom Tromey  <tom@tromey.com>
9077
9078         * remote.c (class remote_state) <buf>: Now a char_vector.
9079         <buf_size>: Remove.
9080         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9081         parameter.
9082         (remote_target::getpkt_or_notif_sane_1)
9083         (remote_target::getpkt_sane)
9084         (remote_target::getpkt_or_notif_sane): Likewise.
9085         (class remote_target) <putpkt>: New overload.
9086         (remote_target::read_frame): Change type of "buf_p".  Remove
9087         sizeof_p parameter.
9088         (packet_ok): New overload.
9089         (packet_check_result): New overload.
9090         Update all uses.
9091
9092 2019-01-14  Tom Tromey  <tom@tromey.com>
9093
9094         * remote-notif.c (handle_notification, remote_notif_ack)
9095         (remote_notif_parse): Make "buf" const.
9096         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9097         const.
9098         (remote_notif_parse, remote_notif_ack, handle_notification):
9099         Likewise.
9100         * remote.c (remote_notif_stop_parse): Make "buf" const.
9101         (remote_target::remote_parse_stop_reply): Make "buf" const.
9102         (remote_notif_stop_ack): Make "buf" const.
9103
9104 2019-01-14  Tom Tromey  <tom@tromey.com>
9105
9106         * remote.c (remote_console_output): Make parameter const.
9107
9108 2019-01-14  Tom Tromey  <tom@tromey.com>
9109
9110         * target-debug.h (target_debug_print_signals): Constify.
9111         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9112         * procfs.c (procfs_target::pass_signals): Update.
9113         * linux-nat.c (linux_nat_target::pass_signals): Update.
9114         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9115         * target-delegates.c: Rebuild.
9116         * remote.c (remote_target::program_signals): Update.
9117         (remote_target::pass_signals): Update.
9118         * target.c (target_pass_signals): Constify argument.
9119         (target_program_signals): Likewise.
9120         * target.h (struct target_ops) <pass_signals, program_signals>:
9121         Constify argument.
9122         (target_pass_signals, target_program_signals): Constify argument.
9123
9124 2019-01-14  Tom Tromey  <tom@tromey.com>
9125
9126         PR tui/28819:
9127         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9128
9129 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9130
9131         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9132         field.
9133         * rs6000-tdep.c: Include reggroups.h.
9134         (IS_V_ALIAS_PSEUDOREG): Define.
9135         (rs6000_register_name): Return names for the "vX" aliases.
9136         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9137         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9138         aliases.  Call default_register_reggroup_p for all other
9139         pseudo-registers.
9140         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9141         New functions.
9142         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9143         Handle "vX" aliases.
9144         (v_alias_pseudo_register_collect): New function.
9145         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9146         (rs6000_gdbarch_init): Initialize "vX" aliases as
9147         pseudo-registers.  Restore registration of
9148         rs6000_pseudo_register_reggroup_p with
9149         set_tdesc_pseudo_register_reggroup_p.
9150
9151 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9152
9153         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9154         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9155         set_gdbarch_num_pseudo_regs.
9156
9157 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9158
9159         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9160         Remove arg prefixname, add do_set and do_show.
9161         Add member functions set_list and show_list.
9162         * cli/cli-style.c (class cli_style_option): Update accordingly.
9163         (style_set_list): Move to file scope.
9164         (style_show_list): Likewise.
9165         (set_style): Call help_list.
9166         (show_style): Call cmd_show_list.
9167         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9168         Update to use the new macro.
9169
9170 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9171
9172         * ada-lang.c (_initialize_ada_language): Expand the help text
9173         for the "catch exception" command.
9174
9175 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9176
9177         * symtab.c (matching_obj_sections): Initialize obj,
9178         declare it closer to its usage.
9179
9180 2019-01-10  Tom Tromey  <tom@tromey.com>
9181
9182         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9183         (basic_inf_threads_range): Remove.
9184         (inf_threads_range, inf_non_exited_threads_range)
9185         (safe_inf_threads_range): Use next_adapter.
9186
9187 2019-01-10  Keith Seitz  <keiths@redhat.com>
9188
9189         PR gdb/23712
9190         PR symtab/23010
9191         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9192         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9193
9194 2019-01-10  Keith Seitz  <keiths@redhat.com>
9195
9196         PR gdb/23712
9197         PR symtab/23010
9198         * dictionary.c (pending_to_vector): Remove.
9199         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9200         Remove _1 suffix, replacing functions of the same name.  Update
9201         all callers.
9202         (dict_create_hashed, dict_create_hashed_expandable)
9203         (dict_create_linear, dict_create_linear_expandable, dict_free)
9204         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9205         Make functions static.
9206
9207 2019-01-10  Keith Seitz  <keiths@redhat.com>
9208
9209         PR gdb/23712
9210         PR symtab/23010
9211         * dictionary.h (struct dictionary): Replace declaration with
9212         multidictionary.
9213         (dict_create_hashed, dict_create_hashed_expandable)
9214         (dict_create_linear, dict_create_linear_expandable)
9215         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9216         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9217         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9218         taking multidictionary argument.
9219         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9220         * block.h (struct block) <dict>: Change to multidictionary
9221         and rename `multidict'.
9222         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9223         symmisc.c: Update all dictionary references to multidictionary.
9224
9225 2019-01-10  Keith Seitz  <keiths@redhat.com>
9226
9227         PR gdb/23712
9228         PR symtab/23010
9229         * dictionary.c: Include unordered_map.
9230         (pending_to_vector): New function.
9231         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9232         Rewrite the non-"_1" functions to take vector instead
9233         of linked list.
9234         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9235         "new" _1 versions of the same name.
9236         (multidictionary): Define.
9237         (std::hash<enum language): New definition.
9238         (collate_pending_symbols_by_language, mdict_create_hashed)
9239         (mdict_create_hashed_expandable, mdict_create_linear)
9240         (mdict_create_linear_expandable, mdict_free)
9241         (find_language_dictionary, create_new_language_dictionary)
9242         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9243         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9244         (mdict_size, mdict_empty): New functions.
9245         * dictionary.h (mdict_iterator): Define.
9246
9247 2019-01-10  Pedro Alves  <palves@redhat.com>
9248
9249         * breakpoint.c (read_uploaded_action)
9250         (create_tracepoint_from_upload): Adjust to use
9251         gdb::unique_xmalloc_ptr.
9252         * ctf.c (ctf_write_uploaded_tp):
9253         (SET_ARRAY_FIELD): Use emplace_back.
9254         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9255         * tracefile-tfile.c (tfile_write_uploaded_tp):
9256         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9257         gdb::unique_xmalloc_ptr.
9258         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9259         at_string, cond_string, cmd_strings>: Replace char pointers
9260         with gdb::unique_xmalloc_ptr.
9261
9262 2019-01-10  Pedro Alves  <palves@redhat.com>
9263
9264         * solib-target.c (library_list_start_library): Don't xstrdup name.
9265
9266 2019-01-10  Pedro Alves  <palves@redhat.com>
9267
9268         * mdebugread.c (parse_partial_symbols): Use
9269         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9270
9271 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * linux-fork.c (scoped_switch_fork_info)
9274         <~scoped_switch_fork_info>: Fix incorrect variable name.
9275
9276 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9277
9278         * linux-fork.c (scoped_switch_fork_info)
9279         <scoped_switch_fork_info>: Make explicit.
9280         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9281
9282 2019-01-10  Tom Tromey  <tom@tromey.com>
9283
9284         * objfiles.h (objfile::reset_psymtabs): Update.
9285         * objfiles.c (objfile::objfile): Update.
9286         * psymtab.h (psymtab_storage::obstack): Update.
9287         (psymtab_storage::m_obstack): Use gdb::optional.
9288         (class psymtab_storage): Update comment.  Remove objfile
9289         parameter.
9290         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9291
9292 2019-01-10  Tom Tromey  <tom@tromey.com>
9293
9294         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9295         <free_psymtabs>: Now private.
9296         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9297         (allocate_psymtab): Use new method.
9298
9299 2019-01-10  Tom Tromey  <tom@tromey.com>
9300
9301         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9302         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9303         * mdebugread.c (parse_partial_symbols): Use
9304         allocate_dependencies.
9305         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9306         allocate_dependencies.
9307         (process_psymtab_comp_unit_reader)
9308         (build_type_psymtab_dependencies): Likewise.
9309         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9310
9311 2019-01-10  Tom Tromey  <tom@tromey.com>
9312
9313         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9314         PSYMBOL_SET_LANGUAGE.
9315         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9316
9317 2019-01-10  Tom Tromey  <tom@tromey.com>
9318
9319         * psymtab.h (psymtab_storage::obstack): New method.
9320         <m_obstack>: Rename from obstack; now private.
9321         * psymtab.c (psymtab_storage): Update.
9322         * dwarf2read.c (create_addrmap_from_index)
9323         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9324         Update.
9325
9326 2019-01-10  Tom Tromey  <tom@tromey.com>
9327
9328         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9329         * objfiles.h (objfile::reset_psymtabs): New method.
9330
9331 2019-01-10  Tom Tromey  <tom@tromey.com>
9332
9333         * symmisc.c (print_symbol_bcache_statistics): Update.
9334         (print_objfile_statistics): Update.
9335         * symfile.c (reread_symbols): Update.
9336         * psymtab.h (class psymtab_storage): New.
9337         * psymtab.c (psymtab_storage): New constructor.
9338         (~psymtab_storage): New destructor.
9339         (require_partial_symbols): Update.
9340         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9341         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9342         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9343         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9344         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9345         (start_psymtab_common, end_psymtab_common)
9346         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9347         (allocate_psymtab): Update.
9348         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9349         Update.
9350         (dump_psymtab_addrmap, maintenance_print_psymbols)
9351         (maintenance_check_psymtabs): Update.
9352         (class objfile_psymtabs): Move to objfiles.h.
9353         * psympriv.h (discard_psymtab): Now inline.
9354         (psymtab_discarder::psymtab_discarder): Update.
9355         (psymtab_discarder::~psymtab_discarder): Update.
9356         (ALL_OBJFILE_PSYMTABS): Rewrite.
9357         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9358         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9359         Remove fields.
9360         <partial_symtabs>: New field.
9361         (class objfile_psymtabs): Move from psymtab.h.  Update.
9362         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9363         psymbol_cache.
9364         (objfile::~objfile): Don't destroy psymbol_cache.
9365         * mdebugread.c (parse_partial_symbols): Update.
9366         * dwarf2read.c (create_addrmap_from_index)
9367         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9368         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9369         (add_partial_subprogram, dwarf2_ranges_read): Update.
9370         * dwarf-index-write.c (write_address_map)
9371         (write_one_signatured_type, recursively_write_psymbols)
9372         (class debug_names, class debug_names, write_psymtabs_to_index):
9373         Update.
9374
9375 2019-01-10  Tom Tromey  <tom@tromey.com>
9376
9377         * symtab.h (SYMBOL_SET_NAMES): Update.
9378         (symbol_set_names): Update.
9379         (MSYMBOL_SET_NAMES): Update.
9380         * symtab.c (symbol_set_names): Change argument to be an
9381         objfile_per_bfd_storage.
9382         * psymtab.c (add_psymbol_to_bcache): Update.
9383         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9384
9385 2019-01-10  Tom Tromey  <tom@tromey.com>
9386
9387         * symtab.c (create_demangled_names_hash): Change argument to be an
9388         objfile_per_bfd_storage.
9389         (symbol_set_names): Update.
9390
9391 2019-01-10  Tom Tromey  <tom@tromey.com>
9392
9393         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9394         init_psymbol_list.
9395         * psymtab.c (init_psymbol_list): Do nothing if already called.
9396         * psympriv.h (init_psymbol_list): Add comment.
9397         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9398         init_psymbol_list.
9399         * dbxread.c (dbx_symfile_read): Unconditionally call
9400         init_psymbol_list.
9401
9402 2019-01-10  Tom Tromey  <tom@tromey.com>
9403
9404         * xcoffread.c (scan_xcoff_symtab): Update.
9405         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9406         "where".
9407         * mdebugread.c (parse_partial_symbols)
9408         (handle_psymbol_enumerators): Update.
9409         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9410         * dbxread.c (read_dbx_symtab): Update.
9411         * psympriv.h (psymbol_placement): New enum.
9412         (add_psymbol_to_list): Update.
9413
9414 2019-01-10  Tom Tromey  <tom@tromey.com>
9415
9416         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9417         static_psymbols parameters.
9418         (scan_xcoff_symtab): Update.
9419         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9420         static_psymbols parameters.
9421         * psympriv.h (start_psymtab_common): Update.
9422         * mdebugread.c (parse_partial_symbols): Update.
9423         * dwarf2read.c (create_partial_symtab): Update.
9424         * dbxread.c (read_dbx_symtab): Update.
9425         (start_psymtab): Remove global_psymbols and static_psymbols
9426         parameters.
9427
9428 2019-01-10  Tom Tromey  <tom@tromey.com>
9429
9430         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9431         * psymtab.c (allocate_psymtab): Add comment.
9432         * psympriv.h (allocate_psymtab): Add comment.
9433         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9434         initializations.
9435         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9436
9437 2019-01-10  Tom Tromey  <tom@tromey.com>
9438
9439         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9440         Don't declare.
9441         * mipsread.c: Include mdebugread.h.
9442         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9443         Declare.
9444         * elfread.c: Include mdebugread.h.
9445
9446 2019-01-09  Tom Tromey  <tom@tromey.com>
9447
9448         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9449         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9450         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9451         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9452         (psym_lookup_symbol, psym_find_last_source_symtab)
9453         (psym_forget_cached_source_info, psym_print_stats)
9454         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9455         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9456         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9457         (psym_find_compunit_symtab_by_address)
9458         (maintenance_print_psymbols, maintenance_info_psymtabs)
9459         (maintenance_check_psymtabs): Use ranged for.
9460         * psymtab.h (class objfile_psymtabs): New.
9461         (require_partial_symbols): Return objfile_psymtabs.
9462         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9463
9464 2019-01-09  Tom Tromey  <tom@tromey.com>
9465
9466         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9467         (find_pc_mapped_section, list_overlays_command)
9468         (map_overlay_command, unmap_overlay_command)
9469         (simple_overlay_update): Use all_objfiles.
9470         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9471         * printcmd.c (info_symbol_command): Use all_objfiles.
9472         * objfiles.h (ALL_OBJSECTIONS): Remove.
9473         * maint.c (maintenance_translate_address): Use all_objfiles.
9474         * gcore.c (gcore_create_callback): Use all_objfiles.
9475         (objfile_find_memory_regions): Likewise.
9476
9477 2019-01-09  Tom Tromey  <tom@tromey.com>
9478
9479         * symtab.c (find_line_symtab, info_sources_command)
9480         (make_source_files_completion_list): Use objfile_compunits.
9481         * source.c (select_source_symtab): Use objfile_compunits.
9482         * objfiles.h (struct objfile): Update comment.
9483         (ALL_OBJFILES): Remove.
9484         (ALL_FILETABS): Remove.
9485         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9486         objfile_compunits.
9487
9488 2019-01-09  Tom Tromey  <tom@tromey.com>
9489
9490         * symmisc.c (print_objfile_statistics, dump_objfile)
9491         (maintenance_print_symbols): Use compunit_filetabs.
9492         * source.c (forget_cached_source_info_for_objfile): Use
9493         compunit_filetabs.
9494         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9495         (ALL_FILETABS): Use compunit_filetabs.
9496         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9497         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9498
9499 2019-01-09  Tom Tromey  <tom@tromey.com>
9500
9501         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9502         (compunit_filetabs): New.
9503         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9504         compunit_filetabs.
9505         (info_sources_command, make_source_files_completion_list): Remove
9506         declaration.
9507         * symmisc.c (print_objfile_statistics, dump_objfile)
9508         (maintenance_print_symbols): Remove declaration.
9509         (maintenance_info_symtabs): Use compunit_filetabs.
9510         (maintenance_info_line_tables): Likewise.
9511         * source.c (select_source_symtab): Change local variable name.
9512         (forget_cached_source_info_for_objfile): Remove declaration.
9513         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9514         * objfiles.c (objfile_relocate1): Remove declaration.
9515         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9516         declaration.
9517         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9518         * coffread.c (coff_symtab_read): Remove declaration.
9519         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9520         compunit_filetabs.
9521
9522 2019-01-09  Tom Tromey  <tom@tromey.com>
9523
9524         * symtab.c (lookup_objfile_from_block)
9525         (find_pc_sect_compunit_symtab, search_symbols)
9526         (default_collect_symbol_completion_matches_break_on): Use
9527         objfile_compunits.
9528         * objfiles.h (ALL_COMPUNITS): Remove.
9529         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9530         * cp-support.c (add_symbol_overload_list_qualified): Use
9531         objfile_compunits.
9532         * ada-lang.c (ada_collect_symbol_completion_matches)
9533         (ada_add_global_exceptions): Use objfile_compunits.
9534
9535 2019-01-09  Tom Tromey  <tom@tromey.com>
9536
9537         * source.c (select_source_symtab)
9538         (forget_cached_source_info_for_objfile): Remove declaration.
9539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9540         declaration.
9541         * maint.c (count_symtabs_and_blocks): Remove declaration.
9542         * cp-support.c (add_symbol_overload_list_qualified): Remove
9543         declaration.
9544         * coffread.c (coff_symtab_read): Remove declaration.
9545         * symtab.c (lookup_symbol_in_objfile_symtabs)
9546         (basic_lookup_transparent_type_1): Use objfile_compunits.
9547         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9548         (info_sources_command, search_symbols)
9549         (default_collect_symbol_completion_matches_break_on)
9550         (make_source_files_completion_list): Remove declaration.
9551         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9552         (ada_collect_symbol_completion_matches)
9553         (ada_add_global_exceptions): Remove declaration.
9554         * linespec.c (iterate_over_all_matching_symtabs): Use
9555         objfile_compunits.
9556         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9557         (class objfile_compunits): New.
9558         (ALL_COMPUNITS): Use objfile_compunits.
9559         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9560         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9561         objfile_compunits.
9562         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9563
9564 2019-01-09  Tom Tromey  <tom@tromey.com>
9565
9566         * symtab.c (search_symbols)
9567         (default_collect_symbol_completion_matches_break_on): Use
9568         objfile_msymbols.
9569         * ada-lang.c (ada_lookup_simple_minsym)
9570         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9571         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9572         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9573         objfile_msymbols.
9574         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9575         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9576         * objc-lang.c (find_methods): Use objfile_msymbols.
9577         (info_selectors_command, info_classes_command): Likewise.
9578         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9579         * objfiles.h (class objfile_msymbols): New.
9580         (ALL_OBJFILE_MSYMBOLS): Remove.
9581         (ALL_MSYMBOLS): Remove.
9582
9583 2019-01-09  Tom Tromey  <tom@tromey.com>
9584
9585         * common/next-iterator.h (next_adapter): Add Iterator template
9586         parameter.
9587         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9588         (class all_objfiles_safe): New.
9589         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9590         * objfiles.c (put_objfile_before): Update comment.
9591         (add_separate_debug_objfile): Likewise.
9592         (free_all_objfiles): Use all_objfiles_safe.
9593         (objfile_purge_solibs): Likewise.
9594
9595 2019-01-09  Tom Tromey  <tom@tromey.com>
9596
9597         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9598         (expand_symtab_containing_pc, lookup_static_symbol)
9599         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9600         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9601         all_objfiles.
9602         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9603         * breakpoint.c (create_overlay_event_breakpoint)
9604         (create_longjmp_master_breakpoint)
9605         (create_std_terminate_master_breakpoint)
9606         (create_exception_master_breakpoint): Use all_objfiles.
9607         * linux-thread-db.c (try_thread_db_load_from_pdir)
9608         (has_libpthread): Use all_objfiles.
9609         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9610         * linespec.c (iterate_over_all_matching_symtabs)
9611         (search_minsyms_for_name): Use all_objfiles.
9612         * maint.c (maintenance_info_sections): Use all_objfiles.
9613         * main.c (captured_main_1): Use all_objfiles.
9614         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9615         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9616         * guile/scm-pretty-print.c
9617         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9618         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9619         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9620         (maintenance_print_msymbols): Use all_objfiles.
9621         * source.c (select_source_symtab): Use all_objfiles.
9622         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9623         * symfile.c (remove_symbol_file_command)
9624         (expand_symtabs_matching, map_symbol_filenames): Use
9625         all_objfiles.
9626         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9627         all_objfiles.
9628         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9629         * objc-lang.c (find_methods): Use all_objfiles.
9630         * objfiles.c (have_partial_symbols, have_full_symbols)
9631         (have_minimal_symbols, qsort_cmp)
9632         (default_iterate_over_objfiles_in_search_order): Use
9633         all_objfiles.
9634         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9635         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9636         (maintenance_check_psymtabs): Use all_objfiles.
9637         (ALL_PSYMTABS): Remove.
9638         * compile/compile-object-run.c (do_module_cleanup): Use
9639         all_objfiles.
9640         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9641         * cp-support.c (add_symbol_overload_list_qualified): Use
9642         all_objfiles.
9643         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9644         Use all_objfiles.
9645         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9646         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9647         all_objfiles.
9648         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9649         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9650         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9651         Uses all_objfiles.
9652         * solib.c (solib_read_symbols): Use all_objfiles
9653
9654 2019-01-09  Tom Tromey  <tom@tromey.com>
9655
9656         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9657         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9658         all_objfiles.
9659         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9660         * symmisc.c (print_symbol_bcache_statistics)
9661         (print_objfile_statistics, maintenance_print_objfiles)
9662         (maintenance_info_symtabs, maintenance_check_symtabs)
9663         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9664         all_objfiles.
9665         * source.c (forget_cached_source_info): Use all_objfiles.
9666         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9667         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9668         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9669         * objfiles.c (update_section_map): Use all_objfiles.
9670         (shared_objfile_contains_address_p): Likewise.
9671         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9672         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9673
9674 2019-01-09  Tom Tromey  <tom@tromey.com>
9675
9676         * common/next-iterator.h: New file.
9677         * objfiles.h (class all_objfiles): New.
9678         (struct objfile_iterator): New.
9679
9680 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9681
9682         * NEWS: Move the description of the changed "frame", "select-frame",
9683          and "info frame" commands to the Changed commands section.
9684
9685 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9686
9687         * gdbtypes.c (check_stub_method_group): Remove handling of old
9688         mangling schemes.
9689         * linespec.c (find_methods): Likewise.
9690         * stabsread.c (read_member_functions): Likewise.
9691         * valops.c (search_struct_method): Likewise.
9692         (value_struct_elt_for_reference): Likewise.
9693         * NEWS: Mention this change.
9694
9695 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9696
9697         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9698         print_source_lines.
9699         * source.c (print_source_lines_base): Update line number check.
9700         (print_source_lines): New function.
9701         (source_lines_range::source_lines_range): New function.
9702         * source.h (class source_lines_range): New class.
9703         (print_source_lines): New declaration.
9704
9705 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9706
9707         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9708
9709 2019-01-08  Tom Tromey  <tom@tromey.com>
9710             Simon Marchi  <simon.marchi@ericsson.com>
9711
9712         PR gdb/24060
9713         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9714         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9715         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9716         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9717         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9718         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9719
9720 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9721
9722         * source.c (select_source_symtab): Move header comment to
9723         declaration in source.h.
9724         (forget_cached_source_info_for_objfile): Likewise.
9725         (forget_cached_source_info): Likewise.
9726         (identify_source_line): Likewise.
9727         * source.h (identify_source_line): Move declaration from symtab.h
9728         and add comment from source.c
9729         (print_source_lines): Likewise.
9730         (forget_cached_source_info_for_objfile): Likewise.
9731         (forget_cached_source_info): Likewise.
9732         (select_source_symtab): Likewise.
9733         (enum print_source_lines_flag): Move definition from symtab.h.
9734         * symtab.h (identify_source_line): Move declaration to source.h.
9735         (print_source_lines): Likewise.
9736         (forget_cached_source_info_for_objfile): Likewise.
9737         (forget_cached_source_info): Likewise.
9738         (select_source_symtab): Likewise.
9739         (enum print_source_lines_flag): Move definition to source.h.
9740         * tui/tui-hooks.c: Add 'source.h' include.
9741
9742 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9743
9744         * source.c (print_source_lines_base): Handle requests to print
9745         reverse line number sequences, and guard against empty lines
9746         string.
9747
9748 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9749
9750         * source.c (print_source_lines_base): Fix skip of '\r' if next
9751         character is '\n'.
9752
9753 2019-01-06  Tom Tromey  <tom@tromey.com>
9754
9755         * c-exp.y (struct c_parse_state) <macro_original_text,
9756         expansion_obstack>: New member.
9757         (macro_original_text, expansion_obstack): Remove globals.
9758         (scan_macro_expansion, scanning_macro_expansion)
9759         (finished_macro_expansion): Update.
9760         (scan_macro_cleanup): Remove.
9761         (yylex, c_parse): Update.
9762
9763 2019-01-06  Tom Tromey  <tom@tromey.com>
9764
9765         * c-exp.y (struct c_parse_state) <strings>: New member.
9766         (operator_stoken): Update.
9767
9768 2019-01-06  Tom Tromey  <tom@tromey.com>
9769
9770         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9771         (union type_stack_elt) <typelist_val>: Now a pointer to
9772         std::vector.
9773         (type_stack_cleanup): Don't declare.
9774         (push_typelist): Update.
9775         * parse.c (pop_typelist): Return a std::vector.
9776         (push_typelist): Take a std::vector.
9777         (follow_types): Update.  Do not free args.
9778         (type_stack_cleanup): Remove.
9779         * c-exp.y (struct c_parse_state): New.
9780         (cpstate): New global.
9781         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9782         (nonempty_typelist): Update.
9783         (func_mod): Create a new vector.
9784         (c_parse): Create a c_parse_state.
9785         (check_parameter_typelist): Do not delete params.
9786         (function_method): Update.  Do not delete type_list.
9787
9788 2019-01-06  Tom Tromey  <tom@tromey.com>
9789
9790         PR gdb/28155:
9791         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9792         check_typedef.
9793         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9794         (print_return_value): Likewise.
9795
9796 2019-01-05  Tom Tromey  <tom@tromey.com>
9797
9798         * contrib/cleanup_check.py: Remove.
9799         * contrib/gcc-with-excheck: Remove.
9800         * contrib/exsummary.py: Remove.
9801         * contrib/excheck.py: Remove.
9802
9803 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9804
9805         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9806         NULL. Initialize tpprev to NULL instead of assigning it
9807         to NULL on the next statement.
9808         * windows-nat.c (windows_delete_thread): Remove check for
9809         main_thread_id before printing thread exit notifications.
9810         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9811         Remove thread ID check against main_thread_id.
9812         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9813         windows_delete_thread.
9814         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9815
9816 2019-01-04  Tom Tromey  <tom@tromey.com>
9817
9818         * compile/compile.c (_initialize_compile): Use upper case for
9819         metasyntactic variables.
9820         * symmisc.c (_initialize_symmisc): Use upper case for
9821         metasyntactic variables.
9822         * psymtab.c (_initialize_psymtab): Use upper case for
9823         metasyntactic variables.
9824         * demangle.c (demangle_command): Use upper case for metasyntactic
9825         variables.
9826         (_initialize_demangler): Likewise.
9827         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9828         variables.
9829
9830 2019-01-03  Tom Tromey  <tom@tromey.com>
9831
9832         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9833
9834 2019-01-03  Tom Tromey  <tom@tromey.com>
9835
9836         * python/py-symtab.c (salpy_str): Update.
9837         (struct salpy_sal_object) <symtab>: Now a PyObject.
9838         (salpy_dealloc): Update.
9839         (del_objfile_sal): Use gdbpy_ref.
9840
9841 2019-01-03  Tom Tromey  <tom@tromey.com>
9842
9843         * python/py-type.c (convert_field): Use new_reference.  Return
9844         gdbpy_ref.
9845         (make_fielditem): Return gdbpy_ref.
9846         (typy_fields): Update.
9847         (typy_getitem): Update.
9848         (field_name): Return gdbpy_ref.  Use new_reference.
9849         (typy_iterator_iternext): Update.
9850
9851 2019-01-03  Tom Tromey  <tom@tromey.com>
9852
9853         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9854
9855 2019-01-03  Tom Tromey  <tom@tromey.com>
9856
9857         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9858         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9859         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9860         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9861         (pspy_set_type_printers): Likewise.
9862         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9863         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9864         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9865         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9866         (objfpy_set_type_printers): Likewise.
9867
9868 2019-01-03  Tom Tromey  <tom@tromey.com>
9869
9870         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9871         (gdbpy_print_stack): Use gdbpy_err_fetch.
9872         * python/python-internal.h (class gdbpy_err_fetch): New class.
9873         (class gdbpy_enter) <m_error_type, m_error_value,
9874         m_error_traceback>: Remove.
9875         <m_error>: New member.
9876         (gdbpy_exception_to_string): Don't declare.
9877         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9878         * python/py-value.c (convert_value_from_python): Use
9879         gdbpy_err_fetch.
9880         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9881         gdbpy_exception_to_string.
9882         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9883         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9884         gdbpy_err_fetch.
9885
9886 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9887
9888         * linux-nat.c (delete_lwp_cleanup): Delete.
9889         (struct lwp_deleter): New struct.
9890         (lwp_info_up): New typedef.
9891         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9892         lwp_info_up.
9893
9894 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9895
9896         * linux-fork.c (class scoped_switch_fork_info): New class.
9897         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9898
9899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9900
9901         * valops.c (find_overload_match): Remove use of null_cleanup, and
9902         calls to do_cleanups.
9903
9904 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9905
9906         * compile/compile-cplus-types.c
9907         (compile_cplus_instance::decl_name): Handle changes to
9908         cp_func_name.
9909         * cp-support.c (cp_func_name): Update header comment, update
9910         return type.
9911         * cp-support.h (cp_func_name): Update return type in declaration.
9912         * valops.c (find_overload_match): Move temp_func local to top
9913         level of function and change its type.  Use temp_func to hold and
9914         delete temporary string obtained from cp_func_name.
9915
9916 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9917
9918         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9919         gdb::char_vector, remove cleanup, and update uses of `msg`.
9920
9921 2019-01-03  Jim Wilson  <jimw@sifive.com>
9922
9923         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9924
9925 2019-01-02  Tom Tromey  <tom@tromey.com>
9926
9927         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9928         (tdesc_parse_xml): Remove cleanups.
9929         * target-descriptions.h (make_cleanup_free_target_description):
9930         Don't declare.
9931         (target_desc_deleter): New struct.
9932         (target_desc_up): New typedef.
9933         * target-descriptions.c (target_desc_deleter::operator()): Rename
9934         from free_target_description.
9935         (make_cleanup_free_target_description): Remove.
9936
9937 2019-01-02  Tom Tromey  <tom@tromey.com>
9938
9939         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9940         constructor, destructor.
9941         (linespec_parser): Remove typedef.
9942         (~linespec_parser): Rename from linespec_parser_delete.
9943         (linespec_lex_to_end, linespec_complete_label)
9944         (linespec_complete): Update.
9945         (decode_line_full): Remove cleanups.
9946         (decode_line_1): Update.
9947
9948 2019-01-02  Tom Tromey  <tom@tromey.com>
9949
9950         * python/python-internal.h (inferior_to_inferior_object): Change
9951         return type.
9952         * python/py-exitedevent.c (create_exited_event_object): Update.
9953         * python/py-inferior.c (inferior_to_inferior_object): Return
9954         gdbpy_ref.
9955         (python_new_inferior, python_inferior_deleted)
9956         (thread_to_thread_object, delete_thread_object)
9957         (build_inferior_list, gdbpy_selected_inferior): Update.
9958         * python/py-infthread.c (create_thread_object): Update.  Also fail
9959         if inferior_to_inferior_object fails.
9960
9961 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9962
9963         * inferior.h (class inferior) <displaced_step_state>: New field.
9964         * infrun.h (struct displaced_step_state): Move here from
9965         infrun.c.  Initialize fields, add constructor.
9966         <inf>: Remove field.
9967         <reset>: New method.
9968         * infrun.c (struct displaced_step_inferior_state): Move to
9969         infrun.h.
9970         (displaced_step_inferior_states): Remove.
9971         (get_displaced_stepping_state): Adust.
9972         (displaced_step_in_progress_any_inferior): Adjust.
9973         (displaced_step_in_progress_thread): Adjust.
9974         (displaced_step_in_progress): Adjust.
9975         (add_displaced_stepping_state): Remove.
9976         (get_displaced_step_closure_by_addr): Adjust.
9977         (remove_displaced_stepping_state): Remove.
9978         (infrun_inferior_exit): Call displaced_step_state.reset.
9979         (use_displaced_stepping): Don't check for NULL.
9980         (displaced_step_prepare_throw): Call
9981         get_displaced_stepping_state.
9982         (displaced_step_fixup): Don't check for NULL.
9983         (prepare_for_detach): Don't check for NULL.
9984
9985 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9986
9987         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9988          in case of call that did not complete.
9989
9990 2019-01-02  Andrey Utkin  <autkin@undo.io>
9991
9992         * symfile.c (find_separate_debug_file): Fix search of debug files for
9993         remote debuggee.
9994
9995 2019-01-02  Tom Tromey  <tom@tromey.com>
9996
9997         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9998         indentation.
9999         * python/py-frame.c (frapy_older): Remove cast.
10000         (frapy_newer): Likewise.
10001         * python/py-breakpoint.c (local_setattro): Remove cast.
10002         * python/py-arch.c (archpy_name): Remove local variable.
10003         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10004
10005 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10006
10007         * unittests/basic_string_view/element_access/char/empty.cc:
10008         Fix year range in copyright header.
10009
10010 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10011
10012         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10013         Delete.
10014         <operator==>: Update with for removed field.
10015         <hash>: Likewise.
10016         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10017         <isa_features>: ...this.
10018         <abi_features>: New field.
10019         (riscv_isa_flen): Update comment.
10020         (riscv_abi_xlen): New declaration.
10021         (riscv_abi_flen): New declaration.
10022         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10023         isa_features.
10024         (riscv_abi_xlen): New function.
10025         (riscv_isa_flen): Update to get answer from isa_features.
10026         (riscv_abi_flen): New function.
10027         (riscv_has_fp_abi): Update to get answer from abi_features.
10028         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10029         xlen and flen.
10030         (riscv_call_info) <xlen, flen>: Update comment.
10031         (riscv_call_arg_struct): Remove invalid assertions
10032         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10033         is removed.
10034         (riscv_gdbarch_init): Gather isa features and abi features
10035         separately, ensure both match on the gdbarch when reusing an old
10036         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10037         a target with 64-bit float hardware.
10038
10039 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10040
10041         * source.c (search_command_helper): Stop reverse search
10042         when line 1 has been searched.
10043
10044 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10045
10046         * record-full.c (record_full_base_target::close): Rewrite
10047         record_full_core_buf_list free logic.
10048
10049 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10050
10051         * break-catch-syscall.c (print_one_catch_syscall): xfree
10052         the last text.
10053
10054 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10055
10056         * top.c (print_gdb_version): Update Copyright year in version
10057         message.
10058
10059 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10060
10061         Update copyright year range in all GDB files.
10062
10063 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10064
10065         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10066
10067 For older changes see ChangeLog-2018.
10068 \f
10069 Local Variables:
10070 mode: change-log
10071 left-margin: 8
10072 fill-column: 74
10073 version-control: never
10074 coding: utf-8
10075 End:
10076