gdb/ChangeLog

   1 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
   4
   5 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   6             Tom Tromey  <tromey@adacore.com>
   7
   8         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
   9
  10 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  11
  12         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  13         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  14         method to compute the bounds of range types. Also print "[evaluated]"
  15         if the bounds' values come from a dynamic evaluation.
  16
  17 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  20         whitespace when pretty printing is on.
  21
  22 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * ppc-linux-nat.c: Add include.
  25
  26 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * NEWS: Mention AArch64 Pointer Authentication.
  29
  30 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  31
  32         * arm-linux-nat.c: Add include.
  33
  34 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  35
  36         * source-cache.c (source_cache::get_source_lines): Re-read
  37         fullname after calling open_source_file.
  38
  39 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  40
  41         * NEWS: Mention TLS support for FreeBSD.
  42
  43 2019-03-25  Tom Tromey  <tromey@adacore.com>
  44
  45         * minsyms.c (BUNCH_SIZE): Update comment.
  46         (~minimal_symbol_reader): Remove old comment.
  47         (compact_minimal_symbols): Update comment.
  48         (minimal_symbol_reader::install): Remove old comment.  Update
  49         other comments.
  50
  51 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  52
  53         * s390-linux-nat.c: Add include.
  54
  55 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  56
  57         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  58         Call linux_get_hwcap.
  59         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  60         Likewise.
  61         (aarch64_linux_get_hwcap): Remove function.
  62         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  63         declaration.
  64         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  65         linux_get_hwcap.
  66         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  67         * linux-tdep.c (linux_get_hwcap): Add function.
  68         (linux_get_hwcap2): Likewise.
  69         * linux-tdep.h (linux_get_hwcap): Add declaration.
  70         (linux_get_hwcap2): Likewise.
  71         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  72         (ppc_linux_get_hwcap2): Likewise.
  73         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  74         linux_get_hwcap.
  75         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  76         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  77         (ppc_linux_nat_target::read_description): Likewise.
  78         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  79         * s390-linux-nat.c: Likewise.
  80         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  81
  82 2019-03-24  Tom Tromey  <tom@tromey.com>
  83
  84         * ada-lang.c (standard_lookup): Simplify initialization.
  85         (ada_lookup_symbol_nonlocal): Simplify return.
  86         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  87         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  88         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  89         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  90         initialization.
  91         * solib.c (solib_global_lookup): Simplify.
  92         * symtab.c (null_block_symbol): Remove.
  93         (symbol_cache_lookup): Simplify returns.
  94         (lookup_language_this): Simplify returns.
  95         (lookup_symbol_aux): Simplify return.
  96         (lookup_local_symbol): Simplify returns.
  97         (lookup_global_symbol_from_objfile): Simplify return.
  98         (lookup_symbol_in_objfile_symtabs)
  99         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 100         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 101         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 102         * cp-namespace.c (cp_lookup_bare_symbol)
 103         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 104         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 105         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 106         (cp_lookup_symbol_via_imports): Simplify initialization.
 107         (find_symbol_in_baseclass): Likewise.
 108         * symtab.h (null_block_symbol): Remove.
 109         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 110         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 111         (d_lookup_symbol_module): Likewise.
 112         (find_symbol_in_baseclass): Simplify initialization.
 113
 114 2019-03-24  Tom Tromey  <tom@tromey.com>
 115
 116         * expression.h: Don't include symtab.h.
 117         (struct block): Forward declare.
 118
 119 2019-03-24  Tom Tromey  <tom@tromey.com>
 120
 121         * c-exp.y (typebase): Remove casts.
 122         * gdbtypes.c (lookup_unsigned_typename, )
 123         (lookup_signed_typename): Remove cast.
 124         * eval.c (parse_to_comma_and_eval): Remove cast.
 125         * parse.c (write_dollar_variable): Remove cast.
 126         * block.h (struct block) <superblock>: Now const.
 127         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 128         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 129         (map_block): Make "block" const.
 130         * symfile.h (struct quick_symbol_functions)
 131         <map_matching_symbols>: Constify block argument to "callback".
 132         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 133         const.
 134         (find_pc_sect_compunit_symtab): Make "b" const.
 135         (find_symbol_at_address): Likewise.
 136         (search_symbols): Likewise.
 137         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 138         (dw2_debug_names_lookup_symbol): Likewise.
 139         (dw2_map_matching_symbols): Update.
 140         * p-valprint.c (pascal_val_print): Remove "block".
 141         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 142         (aux_add_nonlocal_symbols): Make "block" const.
 143         (resolve_subexp): Remove cast.
 144         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 145         const.
 146         (iterate_over_file_blocks): Likewise.
 147         * f-exp.y (%union) <bval>: Remove.
 148         * coffread.c (patch_opaque_types): Make "b" const.
 149         * spu-tdep.c (spu_catch_start): Make "block" const.
 150         * c-valprint.c (print_unpacked_pointer): Remove "block".
 151         * symmisc.c (dump_symtab_1): Make "b" const.
 152         (block_depth): Make "block" const.
 153         * d-exp.y (%union) <bval>: Remove.
 154         * cp-support.h (cp_lookup_rtti_type): Update.
 155         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 156         * psymtab.c (psym_lookup_symbol): Make "block" const.
 157         (maintenance_check_psymtabs): Make "b" const.
 158         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 159         (enumerate_locals, enumerate_args): Update.
 160         * python/py-symtab.c (stpy_global_block): Make "block" const.
 161         (stpy_static_block): Likewise.
 162         * inline-frame.c (block_starting_point_at): Make "new_block"
 163         const.
 164         * block.c (find_block_in_blockvector): Make return type const.
 165         (blockvector_for_pc_sect): Make "b" const.
 166         (find_block_in_blockvector): Make "b" const.
 167
 168 2019-03-23  Tom Tromey  <tom@tromey.com>
 169
 170         * varobj.c (varobj_create): Update.
 171         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 172         * printcmd.c (display_command, do_one_display): Don't reset
 173         innermost_block.
 174         * parser-defs.h (enum innermost_block_tracker_type): Move to
 175         expression.h.
 176         (innermost_block): Update comment.
 177         * parse.c (parse_exp_1): Add tracker_types parameter.
 178         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 179         tracker_types parameter.  Reset innermost_block.
 180         (parse_exp_in_context): Remove.
 181         (parse_expression_for_completion): Update.
 182         * objfiles.c (~objfile): Don't reset expression_context_block or
 183         innermost_block.
 184         * expression.h (enum innermost_block_tracker_type): Move from
 185         parser-defs.h.
 186         (parse_exp_1): Add tracker_types parameter.
 187         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 188         reset innermost_block.
 189
 190 2019-03-23  Tom Tromey  <tom@tromey.com>
 191
 192         * objfiles.h: Include bcache.h.
 193
 194 2019-03-23  Tom Tromey  <tom@tromey.com>
 195
 196         * linespec.c (get_current_search_block): Use
 197         scoped_restore_current_language.
 198         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 199
 200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 201             Jiong Wang  <jiong.wang@arm.com>
 202
 203         * aarch64-linux-tdep.c
 204         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 205         section.
 206         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 207
 208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 209             Jiong Wang  <jiong.wang@arm.com>
 210
 211         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 212         instructions.
 213         (aarch64_analyze_prologue_test): Add PACIASP test.
 214         (aarch64_prologue_prev_register): Unmask PC value.
 215
 216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 217             Jiong Wang  <jiong.wang@arm.com>
 218
 219         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 220         (aarch64_dwarf2_prev_register): Unmask PC value.
 221         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 222         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 223         DW_CFA_AARCH64_negate_ra_state.
 224         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 225
 226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 227             Jiong Wang  <jiong.wang@arm.com>
 228
 229         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 230         registers.
 231         (aarch64_pseudo_register_name): Likewise.
 232         (aarch64_pseudo_register_type): Likewise.
 233         (aarch64_pseudo_register_reggroup_p): Likewise.
 234         (aarch64_gdbarch_init): Add pauth registers.
 235         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 236         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 237         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 238         (struct gdbarch_tdep): Add regnum for ra_state.
 239
 240 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 241             Jiong Wang  <jiong.wang@arm.com>
 242
 243         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 244
 245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 246             Jiong Wang  <jiong.wang@arm.com>
 247
 248         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 249         function.
 250         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 251         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 252         (aarch64_gdbarch_init): Add puth registers.
 253         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 254         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 255         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 256
 257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 258             Jiong Wang  <jiong.wang@arm.com>
 259
 260         * aarch64-linux-nat.c
 261         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 262         * aarch64-linux-tdep.c
 263         (aarch64_linux_core_read_description): Likewise.
 264         (aarch64_linux_get_hwcap): New function.
 265         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 266         (aarch64_linux_get_hwcap): New declaration.
 267
 268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 269             Jiong Wang  <jiong.wang@arm.com>
 270
 271         * aarch64-linux-nat.c
 272         (aarch64_linux_nat_target::read_description): Add pauth param.
 273         * aarch64-linux-tdep.c
 274         (aarch64_linux_core_read_description): Likewise.
 275         * aarch64-tdep.c (struct target_desc): Add in pauth.
 276         (aarch64_read_description): Add pauth param.
 277         (aarch64_gdbarch_init): Likewise.
 278         * aarch64-tdep.h (aarch64_read_description): Likewise.
 279         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 280         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 281         * features/Makefile: Add new files.
 282         * features/aarch64-pauth.c: New file.
 283         * features/aarch64-pauth.xml: New file.
 284
 285 2019-03-20  Tom Tromey  <tromey@adacore.com>
 286
 287         * infrun.c (handle_inferior_event): Rename from
 288         handle_inferior_event_1.  Create a scoped_value_mark.
 289         (handle_inferior_event): Remove.
 290
 291 2019-03-19  Tom Tromey  <tromey@adacore.com>
 292
 293         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 294         * infrun.h (print_stop_event): Add "displays" parameter.
 295         * infrun.c (print_stop_event): Add "displays" parameter.
 296
 297 2019-03-19  Pedro Alves  <palves@redhat.com>
 298
 299         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 300         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 301         to -1.  Fix TABs vs spaces.
 302         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 303         * tui/tui-out.h (tui_ui_out) Add intro comments.
 304         <m_line, m_start_of_line>: In-class initialize, and add describing
 305         comment.
 306
 307 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 308
 309         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 310         variable names.
 311         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 312
 313 2019-03-18  Pedro Alves  <palves@redhat.com>
 314             Eli Zaretskii <eliz@gnu.org>
 315
 316         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 317         m_line and m_start_of_line.
 318
 319 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 320
 321         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 322         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 323         it returns a newline.  This fixes a regression in TU mode, whereby
 324         the next line is output on the same screen line as the user input.
 325
 326 2019-03-18  Tom Tromey  <tromey@adacore.com>
 327
 328         * minsyms.c (minimal_symbol_reader::install): Remove call to
 329         obstack_blank.
 330
 331 2019-03-18  Pedro Alves  <palves@redhat.com>
 332
 333         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 334         New globals.
 335         (apply_style): New, factored out from ...
 336         (apply_ansi_escape): ... this.  Handle reverse video mode.
 337         (tui_set_reverse_mode): New function.
 338         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 339         * tui/tui-winsource.c (tui_show_source_line): Use
 340         tui_set_reverse_mode instead of setting A_STANDOUT.
 341         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 342         New setter methods.
 343
 344 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 345
 346         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 347         Handle tabs.
 348
 349 2019-03-18  Tom Tromey  <tromey@adacore.com>
 350
 351         * ada-lang.c (empty_array): Add "high" parameter.
 352         (ada_evaluate_subexp): Update.
 353
 354 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 355
 356         * unittests/string_view-selftests.c: Define
 357         _initialize_string_view_selftests unconditionally.
 358
 359 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 360
 361         PR gdb/24350
 362         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 363
 364 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 365
 366         PR gdb/24351
 367         * windows-nat.c (display_selector): Fix format specifiers.
 368
 369 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 370
 371         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 372         tui_refill_source_window instead of tui_refresh_win, to update the
 373         current execution line.  This fixes redisplay of the current line
 374         when stepping through the code with "next" or "step".
 375
 376 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 377
 378         * source-cache.c (source_cache::get_source_lines): Call
 379         find_source_lines to initialize s->nlines.  This fixes vertical
 380         scrolling of TUI source window when the DOWN arrow is pressed.
 381
 382 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 383
 384         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 385         linux-thread-db.c (_initialize_thread_db): Likewise.
 386
 387 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 388
 389         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 390         wclrtoeol in tui_show_source_line".  This reverts changes made in
 391         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 392
 393 2019-03-15  Tom Tromey  <tom@tromey.com>
 394
 395         * symtab.h (struct minimal_symbol): Derive from
 396         general_symbol_info.
 397         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 398         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 399         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 400         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 401         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 402         (MSYMBOL_SEARCH_NAME): Update.
 403         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 404         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 405         * minsyms.c (minimal_symbol_reader::record_full): Update.
 406
 407 2019-03-15  Tom Tromey  <tom@tromey.com>
 408
 409         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 410
 411 2019-03-15  Tom Tromey  <tom@tromey.com>
 412
 413         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 414         unique_xmalloc_ptr.
 415         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 416         Update.
 417         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 418         (build_minimal_symbol_hash_tables)
 419         (minimal_symbol_reader::install): Update.
 420
 421 2019-03-15  Tom Tromey  <tom@tromey.com>
 422
 423         * symtab.c (create_demangled_names_hash): Update.
 424         (symbol_set_names): Update.
 425         * objfiles.h (struct objfile_per_bfd_storage)
 426         <demangled_names_hash>: Now an htab_up.
 427         * objfiles.c (objfile_per_bfd_storage): Simplify.
 428
 429 2019-03-15  Tom Tromey  <tom@tromey.com>
 430
 431         * objfiles.h (struct objfile_per_bfd_storage): Declare
 432         destructor.
 433         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 434         New.
 435         (get_objfile_bfd_data): Use new.  Don't initialize
 436         language_of_main.
 437         (free_objfile_per_bfd_storage): Remove.
 438         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 439
 440 2019-03-15  Tom Tromey  <tom@tromey.com>
 441
 442         * symfile.c (reread_symbols): Update.
 443         * objfiles.c (objfile::objfile): Update.
 444         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 445         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 446         comment.
 447         (minimal_symbol_reader::install): Update.
 448         (terminate_minimal_symbol_table): Remove.
 449         * jit.c (jit_object_close_impl): Update.
 450
 451 2019-03-15  Tom Tromey  <tom@tromey.com>
 452
 453         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 454         initializations.
 455
 456 2019-03-15  Tom Tromey  <tom@tromey.com>
 457
 458         * objfiles.h (struct objfile_per_bfd_storage)
 459         <demangled_hash_languages>: Now a bitset.
 460         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 461         (lookup_minimal_symbol): Update.
 462
 463 2019-03-15  Tom Tromey  <tom@tromey.com>
 464
 465         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 466         Don't return the symbol.
 467         * coffread.c (record_minimal_symbol): Use record_full.
 468
 469 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 470
 471         The MS-Windows port of ncurses fails to switch to a color pair if
 472         one or both of the colors are the implicit default colors.  This
 473         change records the default colors when TUI is initialized, and
 474         then specifies them explicitly when a color pair uses the default
 475         colors.  This allows color styling in TUI mode on MS-Windows.
 476
 477         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 478         ncurses_norm_attr.
 479         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 480         colors in ncurses_norm_attr.
 481         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 482         "none", replace it with the default color recorded in
 483         ncurses_norm_attr.
 484
 485 2019-03-14  Tom Tromey  <tromey@adacore.com>
 486
 487         * source-cache.h (class source_cache) <get_source_lines>: Return
 488         std::string.
 489         * source-cache.c (source_cache::extract_lines): Handle case where
 490         first_pos==npos.  Return std::string.
 491         (source_cache::get_source_lines): Update.
 492
 493 2019-03-14  Tom Tromey  <tromey@adacore.com>
 494
 495         * NEWS: Add item for "style sources" commands.
 496         * source-cache.c (source_cache::get_source_lines): Check
 497         source_styling.
 498         * cli/cli-style.c (source_styling): New global.
 499         (_initialize_cli_style): Add "style sources" commands.
 500         (show_style_sources): New function.
 501         * cli/cli-style.h (source_styling): Declare.
 502
 503 2019-03-14  Pedro Alves  <palves@redhat.com>
 504             Tom Tromey  <tromey@adacore.com>
 505
 506         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 507         * tui/tui-winsource.c (tui_refill_source_window): New function,
 508         from...
 509         (tui_horizontal_source_scroll): ... here.  Move some logic.
 510         * cli/cli-style.c (set_style_enabled): Notify new observable.
 511         * tui/tui-hooks.c (tui_redisplay_source): New function.
 512         (tui_attach_detach_observers): Attach or detach
 513         tui_redisplay_source.
 514         * observable.h (source_styling_changed): New observable.
 515         * observable.c: Define source_styling_changed observable.
 516
 517 2019-03-13  Tom Tromey  <tromey@adacore.com>
 518
 519         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 520         (i386_gnu_nat_target::store_registers): Update.
 521         * target-debug.h (target_debug_print_std_string): New macro.
 522         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 523         * windows-tdep.c (display_one_tib): Update.
 524         * tui/tui-stack.c (tui_make_status_line): Update.
 525         * top.c (print_inferior_quit_action): Update.
 526         * thread.c (thr_try_catch_cmd): Update.
 527         (add_thread_with_info): Update.
 528         (thread_target_id_str): Update.
 529         (thr_try_catch_cmd): Update.
 530         (thread_command): Update.
 531         (thread_find_command): Update.
 532         * record-btrace.c (record_btrace_target::info_record)
 533         (record_btrace_resume_thread, record_btrace_target::resume)
 534         (record_btrace_cancel_resume, record_btrace_step_thread)
 535         (record_btrace_target::wait, record_btrace_target::wait)
 536         (record_btrace_target::wait, record_btrace_target::stop): Update.
 537         * progspace.c (print_program_space): Update.
 538         * process-stratum-target.c
 539         (process_stratum_target::thread_address_space): Update.
 540         * linux-fork.c (linux_fork_mourn_inferior)
 541         (detach_checkpoint_command, info_checkpoints_command)
 542         (linux_fork_context): Update.
 543         (linux_fork_detach): Update.
 544         (class scoped_switch_fork_info): Update.
 545         (delete_checkpoint_command): Update.
 546         * infrun.c (follow_fork_inferior): Update.
 547         (follow_fork_inferior): Update.
 548         (proceed_after_vfork_done): Update.
 549         (handle_vfork_child_exec_or_exit): Update.
 550         (follow_exec): Update.
 551         (displaced_step_prepare_throw): Update.
 552         (displaced_step_restore): Update.
 553         (start_step_over): Update.
 554         (resume_1): Update.
 555         (clear_proceed_status_thread): Update.
 556         (proceed): Update.
 557         (print_target_wait_results): Update.
 558         (do_target_wait): Update.
 559         (context_switch): Update.
 560         (stop_all_threads): Update.
 561         (restart_threads): Update.
 562         (finish_step_over): Update.
 563         (handle_signal_stop): Update.
 564         (switch_back_to_stepped_thread): Update.
 565         (keep_going_pass_signal): Update.
 566         (print_exited_reason): Update.
 567         (normal_stop): Update.
 568         * inferior.c (inferior_pid_to_str): Change return type.
 569         (print_selected_inferior): Update.
 570         (add_inferior): Update.
 571         (detach_inferior): Update.
 572         * dummy-frame.c (fprint_dummy_frames): Update.
 573         * dcache.c (dcache_info_1): Update.
 574         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 575         (btrace_fetch, btrace_clear): Update.
 576         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 577         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 578         type.
 579         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 580         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 581         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 582         * gdbarch.c, gdbarch.h: Rebuild.
 583         * gdbarch.sh (core_pid_to_str): Change return type.
 584         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 585         return type.
 586         (windows_nat_target::pid_to_str): Change return type.
 587         (windows_delete_thread): Update.
 588         (windows_nat_target::attach): Update.
 589         (windows_nat_target::files_info): Update.
 590         * target-delegates.c: Rebuild.
 591         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 592         return type.
 593         (sol_thread_target::pid_to_str): Change return type.
 594         * remote.c (class remote_target) <pid_to_str>: Change return
 595         type.
 596         (remote_target::pid_to_str): Change return type.
 597         (extended_remote_target::attach, remote_target::remote_stop_ns)
 598         (remote_target::remote_notif_remove_queued_reply)
 599         (remote_target::push_stop_reply, remote_target::disable_btrace):
 600         Update.
 601         (extended_remote_target::attach): Update.
 602         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 603         type.
 604         (gdbsim_target::pid_to_str): Change return type.
 605         * ravenscar-thread.c (struct ravenscar_thread_target)
 606         <pid_to_str>: Change return type.
 607         (ravenscar_thread_target::pid_to_str): Change return type.
 608         * procfs.c (class procfs_target) <pid_to_str>: Change return
 609         type.
 610         (procfs_target::pid_to_str): Change return type.
 611         (procfs_target::attach): Update.
 612         (procfs_target::detach): Update.
 613         (procfs_target::fetch_registers): Update.
 614         (procfs_target::store_registers): Update.
 615         (procfs_target::wait): Update.
 616         (procfs_target::files_info): Update.
 617         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 618         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 619         return type.
 620         (nto_procfs_target::pid_to_str): Change return type.
 621         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 622         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 623         return type.
 624         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 625         (exit_lwp): Update.
 626         (attach_proc_task_lwp_callback, get_detach_signal)
 627         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 628         (linux_nat_target::resume, wait_lwp, stop_callback)
 629         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 630         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 631         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 632         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 633         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 634         type.
 635         (inf_ptrace_target::attach): Update.
 636         (inf_ptrace_target::files_info): Update.
 637         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 638         type.
 639         (go32_nat_target::pid_to_str): Change return type.
 640         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 641         (gnu_nat_target::wait): Update.
 642         (gnu_nat_target::wait): Update.
 643         (gnu_nat_target::resume): Update.
 644         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 645         (fbsd_nat_target::wait): Update.
 646         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 647         type.
 648         (darwin_nat_target::attach): Update.
 649         * corelow.c (class core_target) <pid_to_str>: Change return type.
 650         (core_target::pid_to_str): Change return type.
 651         * target.c (normal_pid_to_str): Change return type.
 652         (default_pid_to_str): Likewise.
 653         (target_pid_to_str): Change return type.
 654         (target_translate_tls_address): Update.
 655         (target_announce_detach): Update.
 656         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 657         return type.
 658         (bsd_uthread_target::pid_to_str): Change return type.
 659         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 660         type.
 661         (bsd_kvm_target::pid_to_str): Change return type.
 662         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 663         return type.
 664         (aix_thread_target::pid_to_str): Change return type.
 665         * target.h (struct target_ops) <pid_to_str>: Change return type.
 666         (target_pid_to_str, normal_pid_to_str): Likewise.
 667         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 668         type.
 669         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 670         type.
 671         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 672         return type.
 673         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 674         type.
 675         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 676         type.
 677         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 678         return type.
 679
 680 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 681
 682         * NEWS: Mention that the new default MI version is 3.  Mention
 683         changes to the output of commands and events that deal with
 684         multi-location breakpoints.
 685         * breakpoint.c: Include "mi/mi-out.h".
 686         (print_one_breakpoint): Change output syntax if using MI version
 687         >= 3.
 688         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 689         New.
 690         (mi_multi_location_breakpoint_output_fixed): New.
 691         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 692         (mi_cmd_fix_multi_location_breakpoint_output): New.
 693         (mi_multi_location_breakpoint_output_fixed): New.
 694         * mi/mi-cmds.c (mi_cmds): Register command
 695         -fix-multi-location-breakpoint-output.
 696         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 697         interpreter "mi".
 698
 699 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 700
 701         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 702         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 703         instantiate mi_ui_out based on interpreter name.
 704         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 705         * mi/mi-main.c (mi_load_progress): Likewise.
 706
 707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 708
 709         * NEWS: Combine separate "New targets" sections for 8.3.
 710
 711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 712
 713         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 714         (ppcfbsd_init_abi): Install gdbarch
 715         "fetch_tls_load_module_address" and "get_thread_local_address"
 716         methods.
 717
 718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 719
 720         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 721         (riscv_fbsd_init_abi): Install gdbarch
 722         "fetch_tls_load_module_address" and "get_thread_local_address"
 723         methods.
 724
 725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 726
 727         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 728         (i386fbsd_init_abi): Install gdbarch
 729         "fetch_tls_load_module_address" and "get_thread_local_address"
 730         methods.
 731
 732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 733
 734         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 735         (amd64fbsd_init_abi): Install gdbarch
 736         "fetch_tls_load_module_address" and "get_thread_local_address"
 737         methods.
 738
 739 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 740
 741         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 742         (struct fbsd_pspace_data): New type.
 743         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 744         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 745         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 746         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 747         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 748
 749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 750
 751         * gdbtypes.c (lookup_struct_elt): New function.
 752         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 753         * gdbtypes.h (struct struct_elt): New type.
 754         (lookup_struct_elt): New prototype.
 755
 756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 757
 758         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 759         remove disabled code block.
 760
 761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 762
 763         * gdbarch.sh (get_thread_local_address): New method.
 764         * gdbarch.h, gdbarch.c: Regenerate.
 765         * target.c (target_translate_tls_address): Use
 766         gdbarch_get_thread_local_address if present instead of
 767         target::get_thread_local_address.
 768
 769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 770
 771         * target.h (target::get_thread_local_address): Update comment.
 772
 773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 774
 775         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 776         objfile->separate_debug_objfile_backlink if not NULL.
 777
 778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 779
 780         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 781         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 782         (amd64bsd_store_inferior_registers): Likewise.
 783         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 784         Enable segment base registers.
 785         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 786         PT_GETFSBASE and PT_GETGSBASE.
 787         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 788         PT_SETGSBASE.
 789         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 790         segment base registers.
 791         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 792
 793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 794
 795         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 796         Update calls to i386_target_description to add 'segments'
 797         parameter.
 798         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 799         add segment base registers.
 800         * arch/i386.c (i386_create_target_description): Add 'segments'
 801         parameter to enable segment base registers.
 802         * arch/i386.h (i386_create_target_description): Likewise.
 803         * features/i386/32bit-segments.xml: New file.
 804         * features/i386/32bit-segments.c: Generate.
 805         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 806         call to i386_target_description to add 'segments' parameter.
 807         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 808         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 809         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 810         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 811         if feature is present.
 812         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 813         Add 'segments' parameter to call to i386_target_description.
 814         (i386_target_description): Add 'segments' parameter to enable
 815         segment base registers.
 816         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 817         to call to i386_target_description.
 818         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 819         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 820         Define I386_NUM_REGS.
 821         (i386_target_description): Add 'segments' parameter to enable
 822         segment base registers.
 823
 824 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 825
 826         PR/24325
 827         * source-cache.c: #undef open and close, to avoid unresolved
 828         externals during linking.
 829
 830 2019-03-12  Tom Tromey  <tromey@adacore.com>
 831
 832         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 833         const.  Add initializers.
 834         (_initialize_remote): Don't initialize ptid globals.
 835
 836 2019-03-12  Pedro Alves  <palves@redhat.com>
 837
 838         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 839
 840 2019-03-12  Pedro Alves  <palves@redhat.com>
 841
 842         * cp-name-parser.y (main): Remove unused 'len' variable.
 843
 844 2019-03-12  Tom Tromey  <tromey@adacore.com>
 845
 846         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 847         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 848
 849 2019-03-12  Tom Tromey  <tromey@adacore.com>
 850
 851         * linux-nat.c (iterate_over_lwps): Update.
 852         (stop_callback): Remove parameter.
 853         (stop_wait_callback, detach_callback, resume_set_callback)
 854         (select_singlestep_lwp_callback, set_ignore_sigint)
 855         (status_callback, resumed_callback, resume_clear_callback)
 856         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 857         data parameter.
 858         (linux_nat_target::detach, linux_nat_target::resume)
 859         (linux_stop_and_wait_all_lwps, select_event_lwp)
 860         (linux_nat_filter_event, linux_nat_wait_1)
 861         (linux_nat_target::kill, linux_nat_target::stop)
 862         (linux_nat_target::stop): Update.
 863         (linux_nat_resume_callback): Change type.
 864         (resume_stopped_resumed_lwps, count_events_callback)
 865         (select_event_lwp_callback): Likewise.
 866         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 867         * arm-linux-nat.c (struct update_registers_data): Remove.
 868         (update_registers_callback): Change type.
 869         (arm_linux_insert_hw_breakpoint1): Update.
 870         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 871         parameter.
 872         (x86_linux_dr_set_addr): Update.
 873         (x86_linux_dr_set_control): Update.
 874         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 875         (iterate_over_lwps): Use gdb::function_view.
 876         * nat/aarch64-linux-hw-point.c (struct
 877         aarch64_dr_update_callback_param): Remove.
 878         (debug_reg_change_callback): Change type.
 879         (aarch64_notify_debug_reg_change): Update.
 880         * s390-linux-nat.c (s390_refresh_per_info): Update.
 881
 882 2019-03-11  Tom Tromey  <tromey@adacore.com>
 883
 884         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 885         redundant assignment to "this_cu".
 886
 887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 888
 889         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 890
 891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 892
 893         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 894         from...
 895         (rank_one_type): ... this.
 896
 897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 898
 899         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 900         from...
 901         (rank_one_type): ... this.
 902
 903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 904
 905         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 906         from...
 907         (rank_one_type): ... this.
 908
 909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 910
 911         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 912         from...
 913         (rank_one_type): ... this.
 914
 915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 916
 917         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 918         from...
 919         (rank_one_type): ... this.
 920
 921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 922
 923         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 924         from...
 925         (rank_one_type): ... this.
 926
 927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 928
 929         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 930         from...
 931         (rank_one_type): ... this.
 932
 933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 934
 935         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 936         from...
 937         (rank_one_type): ... this.
 938
 939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 940
 941         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 942         from...
 943         (rank_one_type): ... this.
 944
 945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 946
 947         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 948         from...
 949         (rank_one_type): ... this.
 950
 951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 952
 953         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 954         from...
 955         (rank_one_type): ... this.
 956
 957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 958
 959         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 960         from...
 961         (rank_one_type): ... this.
 962
 963 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 964
 965         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 966         inferior-events' shows the example events.
 967
 968 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 969
 970         Support styling on native MS-Windows console
 971
 972         PR/24315
 973         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 974         on MS-Windows if $TERM is not defined.
 975
 976         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 977
 978         * posix-hdep.c (gdb_console_fputs):
 979         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 980         functions.
 981         * ui-file.h (gdb_console_fputs): Add prototype.
 982
 983         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 984         back to fputs only if the former returns zero.
 985
 986 2019-03-07  Tom Tromey  <tom@tromey.com>
 987
 988         * symmisc.c (print_symbol_bcache_statistics): Update.
 989         (print_objfile_statistics): Update.
 990         * symfile.c (allocate_symtab): Update.
 991         * stabsread.c: Don't include bcache.h.
 992         * psymtab.h (struct psymbol_bcache): Don't declare.
 993         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 994         (psymbol_bcache_init, psymbol_bcache_free)
 995         (psymbol_bcache_get_bcache): Don't declare.
 996         * psymtab.c (struct psymbol_bcache): Remove.
 997         (psymtab_storage::psymtab_storage): Update.
 998         (psymtab_storage::~psymtab_storage): Update.
 999         (psymbol_bcache_init, psymbol_bcache_free)
1000         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1001         (add_psymbol_to_bcache): Update.
1002         (allocate_psymtab): Update.
1003         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1004         macro_cache>: No longer pointers.
1005         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1006         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1007         * macrotab.c (macro_bcache): Update.
1008         * macroexp.c: Don't include bcache.h.
1009         * gdbtypes.c (check_types_worklist): Update.
1010         (types_deeply_equal): Remove TRY/CATCH.  Update.
1011         * elfread.c (elf_symtab_read): Update.
1012         * dwarf2read.c: Don't include bcache.h.
1013         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1014         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1015         (print_bcache_statistics, bcache_memory_used): Don't declare.
1016         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1017         methods.  Rename all data members.
1018         * bcache.c (struct bcache): Move to bcache.h.
1019         (bcache::expand_hash_table): Rename from expand_hash_table.
1020         (bcache): Remove.
1021         (bcache::insert): Rename from bcache_full.
1022         (bcache::compare): Rename from bcache_compare.
1023         (bcache_xmalloc): Remove.
1024         (bcache::~bcache): Rename from bcache_xfree.
1025         (bcache::print_statistics): Rename from print_bcache_statistics.
1026         (bcache::memory_used): Rename from bcache_memory_used.
1027
1028 2019-03-07  Pedro Alves  <palves@redhat.com>
1029
1030         * infrun.c (normal_stop): Also check for
1031         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1032
1033 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * f-lang.c (value_from_host_double): Moved to...
1036         * value.c (value_from_host_double): ...here.
1037         * value.h (value_from_host_double): Declare.
1038         * guile/scm-math.c (vlscm_convert_typed_number): Use
1039         value_from_host_double.
1040         (vlscm_convert_number): Likewise.
1041         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1042         * python/py-value.c (convert_value_from_python): Likewise.
1043
1044 2019-03-06  Tom Tromey  <tom@tromey.com>
1045
1046         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1047
1048 2019-03-06  Tom Tromey  <tom@tromey.com>
1049
1050         * utils.h (free_current_contents): Don't declare.
1051         * utils.c (free_current_contents): Remove.
1052
1053 2019-03-06  Tom Tromey  <tom@tromey.com>
1054
1055         * top.c (quit_force): Update.
1056         * main.c (captured_command_loop): Update.
1057         * common/new-op.c (operator new): Update.
1058         * common/common-exceptions.c (struct catcher)
1059         <save_cleanup_chain>: Remove member.
1060         (exceptions_state_mc_init): Update.
1061         (exception_try_scope_entry): Return nullptr.
1062         (exception_try_scope_exit, exception_rethrow)
1063         (throw_exception_sjlj, throw_exception_cxx): Update.
1064         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1065         (all_cleanups, do_cleanups, discard_cleanups)
1066         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1067         (restore_cleanups, restore_final_cleanups): Don't declare.
1068         (do_final_cleanups): Remove parameter.
1069         * common/cleanups.c (cleanup_chain, make_cleanup)
1070         (make_cleanup_dtor, all_cleanups, do_cleanups)
1071         (discard_my_cleanups, discard_cleanups)
1072         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1073         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1074         (null_cleanup): Remove.
1075         (do_final_cleanups): Remove parameter.
1076
1077 2019-03-06  Tom Tromey  <tom@tromey.com>
1078
1079         * remote.c (remote_target::remote_parse_stop_reply): Use
1080         unique_xmalloc_ptr.
1081
1082 2019-03-06  Tom Tromey  <tom@tromey.com>
1083
1084         * stabsread.c (struct stabs_field_info): Rename from field_info.
1085         <list, fnlist>: Add initializers.
1086         <obstack>: New member.
1087         (read_member_functions, read_struct_fields, read_baseclasses):
1088         Allocate on obstack.  Don't use cleanups.
1089         (read_one_struct_field, read_member_functions, read_struct_fields)
1090         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1091         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1092         (read_struct_type): Update.
1093
1094 2019-03-06  Tom Tromey  <tom@tromey.com>
1095
1096         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1097         * common/filestuff.h (make_cleanup_close): Don't declare.
1098         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1099         Remove.
1100
1101 2019-03-06  Tom Tromey  <tom@tromey.com>
1102
1103         * solib-aix.c: Use make_scope_exit.
1104
1105 2019-03-06  Tom Tromey  <tom@tromey.com>
1106
1107         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1108         Use make_scope_exit.
1109
1110 2019-03-06  Tom Tromey  <tom@tromey.com>
1111
1112         * solib-svr4.c (disable_probes_interface): Remove parameter.
1113         (svr4_handle_solib_event): Use make_scope_exit.
1114
1115 2019-03-06  Tom Tromey  <tom@tromey.com>
1116
1117         * remote.c (struct stop_reply_deleter): Remove.
1118         (stop_reply_up): Update.
1119         (struct stop_reply): Derive from notif_event.  Don't typedef.
1120         <regcache>: Now a std::vector.
1121         (stop_reply_xfree): Remove.
1122         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1123         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1124         (remote_target::discard_pending_stop_replies): Use delete.
1125         (remote_target::remote_parse_stop_reply): Update.
1126         (remote_target::process_stop_reply): Update.
1127         * remote-notif.h (struct notif_event): Add virtual destructor.
1128         Remove "dtr" member.
1129         (struct notif_client) <alloc_event>: Return a unique_ptr.
1130         (notif_event_xfree): Don't declare.
1131         (notif_event_up): New typedef.
1132         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1133         (notif_event_xfree, do_notif_event_xfree): Remove.
1134         (remote_notif_state_xfree): Update.
1135
1136 2019-03-06  Tom Tromey  <tom@tromey.com>
1137
1138         * infrun.c (displaced_step_clear_cleanup): Now a
1139         forward_scope_exit type.
1140         (displaced_step_prepare_throw): Update.
1141         (displaced_step_fixup): Update.
1142
1143 2019-03-06  Tom Tromey  <tom@tromey.com>
1144
1145         * inferior.h (class inferior): Update comment.
1146         * gdbthread.h (class thread_info): Update comment.
1147
1148 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1149             Tom Tromey  <tom@tromey.com>
1150
1151         * stabsread.h (struct stab_section_list): Remove.
1152         (coffstab_build_psymtabs): Update.
1153         * dbxread.c (symbuf_sections): Now a std::vector.
1154         (sect_idx): New global.
1155         (fill_symbuf): Update.
1156         (coffstab_build_psymtabs): Change type of stabsects parameter.
1157         Update.
1158         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1159         std::vector.
1160         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1161         (coff_locate_sections): Update.
1162         (coff_symfile_read): Remove cleanups.  Update.
1163         (init_stringtab): Add storage parameter.
1164         (free_stringtab, free_stringtab_cleanup): Remove.
1165         (init_lineno): Add storage parameter.
1166         (free_linetab, free_linetab_cleanup): Remove.
1167
1168 2019-03-06  Pedro Alves  <palves@redhat.com>
1169
1170         * linux-fork.c (fork_info::clobber_regs): Delete.
1171         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1172         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1173         comment.  Adjust.
1174         (scoped_switch_fork_info::scoped_switch_fork_info)
1175         (checkpoint_command, linux_fork_context): Adjust
1176         fork_save_infrun_state calls.
1177
1178 2019-03-06  Pedro Alves  <palves@redhat.com>
1179
1180         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1181         (inf_has_multiple_threads): Return 'bool' and rewrite using
1182         inferior_info::threads().
1183
1184 2019-03-06  Pedro Alves  <palves@redhat.com>
1185
1186         * linux-fork.c: Include <list>.
1187         (fork_list): Now a std::list instance.
1188         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1189         (forks_exist_p, find_last_fork): Adjust.
1190         (new_fork): Delete.
1191         (one_fork_p): New.
1192         (add_fork): Adjust.
1193         (free_fork): Delete, folded into fork_info::~fork_info().
1194         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1195         Adjust.
1196         (init_fork_list): Delete.
1197         (linux_fork_killall, linux_fork_mourn_inferior)
1198         (linux_fork_detach, info_checkpoints_command): Adjust.
1199         (_initialize_linux_fork): No longer call init_fork_list.
1200
1201 2019-03-06  Pedro Alves  <palves@redhat.com>
1202
1203         * linux-fork.c (new_fork): New, split out of ...
1204         (add_fork): ... this.  Return void.  Move "first fork" special
1205         case from here, to ...
1206         (checkpoint_command): ... here.
1207         * linux-linux.h (add_fork): Return void.
1208
1209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1210
1211         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1212
1213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1214             Chris January  <chris.january@arm.com>
1215             David Lecomber  <david.lecomber@arm.com>
1216
1217         * f-exp.y: New token, UNOP_INTRINSIC.
1218         (exp): New pattern using UNOP_INTRINSIC token.
1219         (f77_keywords): Add 'abs' keyword.
1220         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1221         (value_from_host_double): New function.
1222         (evaluate_subexp_f): Support UNOP_ABS.
1223
1224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1227         types.
1228
1229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1232         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1233         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1234
1235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1238
1239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1240             Chris January  <chris.january@arm.com>
1241
1242         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1243         * f-exp.y: Define 'KIND' token.
1244         (exp): New pattern for KIND expressions.
1245         (ptype): Handle types with a kind extension.
1246         (direct_abs_decl): Extend to spot kind extensions.
1247         (f77_keywords): Add 'kind' to the list.
1248         (push_kind_type): New function.
1249         (convert_to_kind_type): New function.
1250         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1251         * parse.c (operator_length_standard): Likewise.
1252         * parser-defs.h (enum type_pieces): Add tp_kind.
1253         * std-operator.def: Add UNOP_KIND.
1254
1255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * f-exp.y (f_parse): Set yydebug.
1258
1259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1260
1261         * f-lang.c (evaluate_subexp_f): New function.
1262         (exp_descriptor_f): New global.
1263         (f_language_defn): Use exp_descriptor_f instead of
1264         exp_descriptor_standard.
1265
1266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * f-exp.y (struct token): Add comments.
1269         (dot_ops): Remove uppercase versions and the end marker.
1270         (f77_keywords): Likewise.
1271         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1272         entries in the dot_ops array are case insensitive, and use
1273         strncasecmp to compare strings.  Also some whitespace cleanup in
1274         this area.  Similar for the f77_keywords array, except entries in
1275         this list might be case sensitive.
1276
1277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * f-exp.y (struct f77_boolean_val): Add comments.
1280         (boolean_values): Remove uppercase versions, and end marker.
1281         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1282         and use strncasecmp to achieve case insensitivity.  Additionally,
1283         perform whitespace cleanup around this code.
1284
1285 2019-03-06  Tom Tromey  <tromey@adacore.com>
1286
1287         * remote-sim.c (gdbsim_target_open): Use result of
1288         gdb_argv::release.
1289
1290 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1291         Dirk Schubert  <dirk.schubert@arm.com>
1292         Chris January  <chris.january@arm.com>
1293
1294         * eval.c (evaluate_subexp_standard): Call Fortran argument
1295         wrapping logic.
1296         * f-lang.c (struct value): A value which can be passed into a
1297         Fortran function call.
1298         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1299         where appropriate.
1300         (struct type): Value ready for a Fortran function call.
1301         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1302         is needed.
1303         * f-lang.h (fortran_argument_convert): Declaration.
1304         (fortran_preserve_arg_pointer): Declaration.
1305         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1306
1307 2019-03-05  Tom Tromey  <tromey@adacore.com>
1308
1309         * python/py-prettyprint.c (print_string_repr): Remove #if.
1310         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1311
1312 2019-03-05  Tom Tromey  <tromey@adacore.com>
1313
1314         * target.c (the_dummy_target): Move later.  Change type to
1315         "dummy_target".
1316         (initialize_targets): Don't initialize the_dummy_target.
1317
1318 2019-03-05  Tom Tromey  <tromey@adacore.com>
1319
1320         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1321         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1322
1323 2019-03-05  Tom Tromey  <tromey@adacore.com>
1324
1325         * windows-nat.c (windows_nat_target::attach)
1326         (windows_nat_target::detach): Don't call gdb_flush.
1327         * valprint.c (generic_val_print, val_print, val_print_string):
1328         Don't call gdb_flush.
1329         * utils.c (defaulted_query): Don't call gdb_flush.
1330         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1331         * target.c (target_announce_detach): Don't call gdb_flush.
1332         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1333         * remote.c (extended_remote_target::attach): Don't call
1334         gdb_flush.
1335         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1336         * printcmd.c (do_examine): Don't call gdb_flush.
1337         (info_display_command): Don't call gdb_flush.
1338         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1339         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1340         * memattr.c (info_mem_command): Don't call gdb_flush.
1341         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1342         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1343         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1344         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1345         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1346         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1347         (gnu_nat_target::detach): Don't call gdb_flush.
1348         * f-valprint.c (f_val_print): Don't call gdb_flush.
1349         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1350         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1351         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1352         gdb_flush.
1353         * c-valprint.c (c_val_print): Don't call gdb_flush.
1354         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1355
1356 2019-03-05  Tom Tromey  <tromey@adacore.com>
1357
1358         * varobj.c (update_dynamic_varobj_children): Update.
1359         (install_default_visualizer): Use reset, not release.
1360         * value.c (set_internalvar): Update.
1361         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1362         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1363         ATTRIBUTE_UNUSED_RESULT.
1364
1365 2019-03-05  Tom Tromey  <tromey@adacore.com>
1366
1367         * remote.c (class scoped_remote_fd) <release>: Add
1368         ATTRIBUTE_UNUSED_RESULT.
1369
1370 2019-03-05  Tom Tromey  <tromey@adacore.com>
1371
1372         * macroexp.c (struct macro_buffer) <release>: Add
1373         ATTRIBUTE_UNUSED_RESULT.
1374
1375 2019-03-05  Tom Tromey  <tromey@adacore.com>
1376
1377         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1378         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1379         ATTRIBUTE_UNUSED_RESULT.
1380
1381 2019-03-05  Tom Tromey  <tromey@adacore.com>
1382
1383         * common/scoped_fd.h (class scoped_fd) <release>: Add
1384         ATTRIBUTE_UNUSED_RESULT.
1385
1386 2019-03-05  Tom Tromey  <tromey@adacore.com>
1387
1388         * parser-defs.h (struct parser_state) <release>: Add
1389         ATTRIBUTE_UNUSED_RESULT.
1390
1391 2019-03-05  Tom Tromey  <tromey@adacore.com>
1392
1393         * utils.h (class gdb_argv) <release>: Add
1394         ATTRIBUTE_UNUSED_RESULT.
1395         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1396
1397 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1398
1399         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1400         for-loop range, to avoid compiler warnings.
1401
1402         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1403         avoid compiler warnings about unused variables.
1404
1405         * NEWS: Mention end of support for native debugging on MS-Windows
1406         before XP.
1407
1408         PR gdb/24292
1409         * common/netstuff.c:
1410         * gdbserver/gdbreplay.c
1411         * gdbserver/remote-utils.c:
1412         * ser-tcp.c:
1413         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1414         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1415         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1416         'getaddrinfo' and 'freeaddrinfo' were not available before
1417         Windows XP, and mingw.org's MinGW headers by default define
1418         _WIN32_WINNT to 0x500.
1419
1420 2019-03-01  Gary Benson <gbenson@redhat.com>
1421
1422         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1423
1424 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1425             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1426
1427         PR gdb/8527
1428         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1429         set_sigint_trap, clear_sigint_trap.
1430
1431 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1432
1433         * target.c (target_detach): Clear the regcache and the
1434         frame cache.
1435
1436 2019-02-27  Pedro Alves  <palves@redhat.com>
1437
1438         * utils.c (set_screen_size): When we cap the height/width sizes,
1439         tweak the corresponding command variable to show "unlimited":
1440
1441 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1442             Pedro Alves  <palves@redhat.com>
1443
1444         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1445         before calling rl_set_screen_size.
1446
1447 2019-02-27  Tom Tromey  <tromey@adacore.com>
1448
1449         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1450         define.
1451         * python/py-value.c: Remove Python 2.4 workaround.
1452         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1453         workaround.
1454         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1455         Python 2.4 workaround.
1456         * python/python-internal.h: Remove Python 2.4 comment.
1457         (Py_ssize_t): Don't define.
1458         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1459         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1460         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1461         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1462         * python/python.c (do_start_initialization): Remove Python 2.4
1463         workaround.
1464         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1465         (print_children): Remove Python 2.4 workaround.
1466         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1467         workaround.
1468         (CHARBUFFERPROC_NAME): Remove.
1469         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1470         Python 2.4 workaround.
1471
1472 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1473
1474         * NEWS: Note minimum Python version.
1475
1476 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1477
1478         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1479         code from these functions.  Remove corresponding ifdefs.  Use
1480         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1481         Remove gotos and target of gotos.
1482         (infpy_search_memory): Likewise.
1483
1484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1485
1486         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1487         (hppa_gdbarch_init): Don't register deleted functions with
1488         gdbarch.
1489
1490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1491
1492         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1493         (h8300_unwind_sp): Delete.
1494         (h8300_dummy_id): Delete.
1495         (h8300_gdbarch_init): Don't register deleted functions with
1496         gdbarch.
1497
1498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1499
1500         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1501         (ft32_unwind_pc): Delete.
1502         (ft32_unwind_sp): Delete.
1503         (ft32_gdbarch_init): Don't register deleted functions with
1504         gdbarch.
1505
1506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1509         (frv_unwind_pc): Delete.
1510         (frv_unwind_sp): Delete.
1511         (frv_gdbarch_init): Don't register deleted functions with
1512         gdbarch.
1513
1514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1517         (riscv_unwind_pc): Delete.
1518         (riscv_unwind_sp): Delete.
1519         (riscv_gdbarch_init): Don't register deleted functions with
1520         gdbarch.
1521
1522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1525         (csky_unwind_pc): Delete.
1526         (csky_unwind_sp): Delete.
1527         (csky_gdbarch_init): Don't register deleted functions with
1528         gdbarch.
1529
1530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1533         (cris_unwind_pc): Delete.
1534         (cris_unwind_sp): Delete.
1535         (cris_gdbarch_init): Don't register deleted functions with
1536         gdbarch.
1537
1538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1541         (bfin_unwind_pc): Delete.
1542         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1543
1544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1547         (arm_unwind_pc): Delete.
1548         (arm_unwind_sp): Delete.
1549         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1550
1551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1554         (arc_unwind_pc): Delete.
1555         (arc_unwind_sp): Delete.
1556         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1557
1558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1559
1560         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1561         (alpha_unwind_pc): Delete.
1562         (alpha_gdbarch_init): Don't register deleted functions with
1563         gdbarch.
1564
1565 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1566
1567         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1568         (aarch64_unwind_pc): Delete.
1569         (aarch64_unwind_sp): Delete.
1570         (aarch64_gdbarch_init): Don't register deleted functions with
1571         gdbarch.
1572
1573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1574
1575         * gdbtypes.c (type_align): Don't consider static members when
1576         computing structure alignment.
1577
1578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1581         return 0 for other types.
1582         * arch-utils.c (default_type_align): Always return 0.
1583         * gdbarch.h: Regenerate.
1584         * gdbarch.sh (type_align): Extend comment.
1585         * gdbtypes.c (type_align): Add additional comments, always call
1586         gdbarch_type_align before applying the default rules.
1587         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1588         generic code will then apply a suitable default.
1589         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1590         types, return 0 for other types.
1591
1592 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1593
1594         * NEWS: Create a new section for the next release branch.
1595         Rename the section of the current branch, now that it has
1596         been cut.
1597
1598 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1599
1600         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1601         * version.in: Bump version to 8.3.50.DATE-git.
1602
1603 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1604
1605         * aix-thread.c (ptid_cmp): Remove unused variable.
1606         (get_signaled_thread): Likewise.
1607         (store_regs_user_thread): Likewise.
1608         (store_regs_kernel_thread): Likewise.
1609         (fetch_regs_kernel_thread): Remove shadowed variable.
1610
1611 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * features/riscv/32bit-cpu.xml: Add register numbers.
1614         * features/riscv/32bit-fpu.c: Regenerate.
1615         * features/riscv/32bit-fpu.xml: Add register numbers.
1616         * features/riscv/64bit-cpu.xml: Add register numbers.
1617         * features/riscv/64bit-fpu.c: Regenerate.
1618         * features/riscv/64bit-fpu.xml: Add register numbers.
1619
1620 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1621
1622         * NEWS: Mention two argument form of gdb.Value constructor.
1623         * python/py-value.c (convert_buffer_and_type_to_value): New
1624         function.
1625         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1626         Add support for handling an optional second argument.  Call
1627         convert_buffer_and_type_to_value as appropriate.
1628         * python/python-internal.h (Py_buffer_deleter): New struct.
1629         (Py_buffer_up): New typedef.
1630
1631 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1632
1633         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1634         instead of releasing ownership.
1635
1636 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1637
1638         * dwarf2read.c (open_and_init_dwp_file): Call
1639         elf_numsections instead of bfd_count_sections to initialize
1640         dwp_file->num_sections.
1641
1642 2019-02-25  Tom Tromey  <tromey@adacore.com>
1643
1644         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1645
1646 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1647
1648         * gcore.in: Add '--readnever' option when invoking GDB.
1649
1650 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1651
1652         * MAINTAINERS: Update my email address.
1653
1654 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1655
1656         * build-id.c (build_id_to_debug_bfd_1): New function.
1657         (build_id_to_debug_bfd): Look for separate debug file in
1658         sysroot.
1659
1660 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * gdbarch.sh: Update the copyright year range that is placed into
1663         generated files.
1664
1665 2019-02-22  Keith Seitz  <keiths@redhat.com>
1666
1667         PR symtab/23853
1668         * linespec.c (create_sals_line_offset): Search for the default
1669         symtab's filename instead of its fullname.
1670
1671 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * NEWS: Update style defaults.
1674
1675 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1676
1677         * main.c (captured_main_1): Disable styling in batch mode.
1678
1679 2019-02-20  Tom Tromey  <tom@tromey.com>
1680
1681         * symtab.c (symtab_symbol_info): Fix typos.
1682
1683 2019-02-20  Tom Tromey  <tromey@adacore.com>
1684
1685         * findcmd.c (_initialize_mem_search): Use upper case for
1686         metasyntactic variables.
1687
1688 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1689
1690         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1691         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1692
1693 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1694
1695         * top.h (source_file_name): Change to std::string.
1696         * top.c (source_file_name): Likewise.
1697         (command_line_input): Adjust.
1698         * cli/cli-script.c (script_from_file): Adjust.
1699
1700 2019-02-19  Tom Tromey  <tromey@adacore.com>
1701
1702         * ravenscar-thread.c
1703         (ravenscar_thread_target::update_thread_list): Don't call
1704         ada_build_task_list.
1705         * ada-lang.h (ada_build_task_list): Don't declare.
1706         * ada-tasks.c (struct ada_tasks_inferior_data)
1707         <task_list_valid_p>: Now bool.
1708         (read_known_tasks, ada_task_list_changed)
1709         (ada_tasks_invalidate_inferior_data): Update.
1710         (read_known_tasks_array): Return bool.
1711         (read_known_tasks_list): Likewise.
1712         (read_known_tasks): Return void.
1713         (ada_build_task_list): Now static.
1714
1715 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1716
1717         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1718         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1719
1720 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1721
1722         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1723         variant for ada_tasks_pspace_data_handle and
1724         ada_tasks_inferior_data_handle.
1725         (ada_tasks_pspace_data_cleanup): New function.
1726         (ada_tasks_inferior_data_cleanup): New function.
1727
1728 2019-02-17  Tom Tromey  <tom@tromey.com>
1729
1730         * macrotab.h (macro_source_fullname): Return a std::string.
1731         * macrotab.c (macro_include, check_for_redefinition)
1732         (macro_undef, macro_lookup_definition, foreach_macro)
1733         (foreach_macro_in_scope): Update.
1734         (macro_source_fullname): Return a std::string.
1735         * macrocmd.c (show_pp_source_pos): Update.
1736
1737 2019-02-17  Tom Tromey  <tom@tromey.com>
1738
1739         * macrocmd.c (show_pp_source_pos): Style the file names.
1740
1741 2019-02-17  Tom Tromey  <tom@tromey.com>
1742
1743         PR tui/24197:
1744         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1745
1746 2019-02-17  Tom Tromey  <tom@tromey.com>
1747
1748         * ada-lang.c (user_select_syms): Use filtered printing.
1749         * utils.c (wrap_style): New global.
1750         (desired_style): Remove.
1751         (emit_style_escape): Add stream parameter.
1752         (set_output_style, reset_terminal_style, prompt_for_continue):
1753         Update.
1754         (flush_wrap_buffer): Only flush gdb_stdout.
1755         (wrap_here): Set wrap_style.
1756         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1757         treat escape sequences as a character.  Change when wrap buffer is
1758         flushed.
1759         (fputs_styled): Do not set the output style when the default is
1760         requested.
1761         * ui-style.h (struct ui_file_style) <is_default>: New method.
1762         * source.c (print_source_lines_base): Emit escape sequences in one
1763         piece.
1764
1765 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1766
1767         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1768         integers and enumeration types.
1769
1770 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1771
1772         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1773         instead of lookup_symbol_in_language
1774         (do_exact_match): New function.
1775         (ada_get_symbol_name_matcher): Return do_exact_match when
1776         doing a verbatim match.
1777
1778 2019-02-15  Tom Tromey  <tromey@adacore.com>
1779
1780         * ravenscar-thread.c (ravenscar_thread_target::resume)
1781         (ravenscar_thread_target::wait): Special case wildcard requests.
1782
1783 2019-02-15  Tom Tromey  <tromey@adacore.com>
1784
1785         * ravenscar-thread.c (base_ptid): Remove.
1786         (struct ravenscar_thread_target) <close>: New method.
1787         <m_base_ptid>: New member.
1788         <update_inferior_ptid, active_task, task_is_currently_active,
1789         runtime_initialized>: Declare methods.
1790         <ravenscar_thread_target>: Add constructor.
1791         (ravenscar_thread_target::task_is_currently_active)
1792         (ravenscar_thread_target::update_inferior_ptid)
1793         (ravenscar_runtime_initialized): Rename.  Now methods.
1794         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1795         (ravenscar_thread_target::update_thread_list): Update.
1796         (ravenscar_thread_target::active_task): Now method.
1797         (ravenscar_thread_target::store_registers)
1798         (ravenscar_thread_target::prepare_to_store)
1799         (ravenscar_thread_target::prepare_to_store)
1800         (ravenscar_thread_target::mourn_inferior): Update.
1801         (ravenscar_inferior_created): Use "new" to create target.
1802         (ravenscar_thread_target::get_ada_task_ptid): Update.
1803         (_initialize_ravenscar): Don't initialize base_ptid.
1804         (ravenscar_ops): Remove global.
1805
1806 2019-02-15  Tom Tromey  <tromey@adacore.com>
1807
1808         * target.h (push_target): Declare new overload.
1809         * target.c (push_target): New overload, taking an rvalue reference.
1810         * remote.c (remote_target::open_1): Use push_target overload.
1811         * corelow.c (core_target_open): Use push_target overload.
1812
1813 2019-02-15  Tom Tromey  <tromey@adacore.com>
1814
1815         * ravenscar-thread.c (is_ravenscar_task)
1816         (ravenscar_task_is_currently_active): Return bool.
1817         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1818         (_initialize_ravenscar): Remove "(void)".
1819         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1820         Return bool.
1821
1822 2019-02-15  Tom Tromey  <tromey@adacore.com>
1823
1824         * ravenscar-thread.c (ravenscar_runtime_initializer)
1825         (has_ravenscar_runtime, get_running_thread_id)
1826         (ravenscar_thread_target::resume): Fix indentation.
1827
1828 2019-02-15  Tom Tromey  <tromey@adacore.com>
1829
1830         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1831         from ravenscar_arch_ops.
1832         (sparc_ravenscar_ops::fetch_registers)
1833         (sparc_ravenscar_ops::store_registers): Now methods.
1834         (sparc_ravenscar_prepare_to_store): Remove.
1835         (sparc_ravenscar_ops): Redefine.
1836         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1837         methods and destructor.  Remove members.
1838         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1839         (ravenscar_thread_target::store_registers)
1840         (ravenscar_thread_target::prepare_to_store): Update.
1841         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1842         Remove.
1843         (struct ppc_ravenscar_powerpc_ops): Derive from
1844         ravenscar_arch_ops.
1845         (ppc_ravenscar_powerpc_ops::fetch_registers)
1846         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1847         (ppc_ravenscar_powerpc_ops): Redefine.
1848         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1849         (ppc_ravenscar_e500_ops::fetch_registers)
1850         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1851         (ppc_ravenscar_e500_ops): Redefine.
1852         * aarch64-ravenscar-thread.c
1853         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1854         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1855         (aarch64_ravenscar_fetch_registers)
1856         (aarch64_ravenscar_store_registers): Now methods.
1857         (aarch64_ravenscar_ops): Redefine.
1858
1859 2019-02-15  Tom Tromey  <tromey@adacore.com>
1860
1861         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1862         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1863         (ravenscar_thread_target::stopped_by_watchpoint)
1864         (ravenscar_thread_target::stopped_data_address)
1865         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1866
1867 2019-02-15  Tom Tromey  <tromey@adacore.com>
1868
1869         * ravenscar-thread.c: Fix some typos.
1870
1871 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1872             Tom Tromey  <tromey@adacore.com>
1873
1874         * ada-lang.c (ada_exception_sal): Change addr_string to a
1875         std::string.
1876         (create_ada_exception_catchpoint): Update.
1877
1878 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1879             Tom Tromey  <tromey@adacore.com>
1880
1881         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1882         (bp_location_ops): Remove.
1883         (base_breakpoint_allocate_location): Update.
1884         (free_bp_location): Update.
1885         * ada-lang.c (class ada_catchpoint_location)
1886         <ada_catchpoint_location>: Remove ops parameter.
1887         (ada_catchpoint_location_dtor): Remove.
1888         (ada_catchpoint_location_ops): Remove.
1889         (allocate_location_exception): Update.
1890         * breakpoint.h (struct bp_location_ops): Remove.
1891         (class bp_location) <bp_location>: Remove bp_location_ops
1892         parameter.
1893         <~bp_location>: Add destructor.
1894         <ops>: Remove.
1895
1896 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1897             Pedro Alves  <palves@redhat.com>
1898
1899         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1900         'PATH_MAX'.
1901
1902 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1903             Samuel Thibault  <samuel.thibault@gnu.org>
1904             Thomas Schwinge  <thomas@codesourcery.com>
1905
1906         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1907         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1908
1909 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1910
1911         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1912         (check_empty): Use "const char *".
1913
1914         * gnu-nat.c (gnu_nat_target::detach): Instead of
1915         'detach_inferior (pid)' call
1916         'detach_inferior (find_inferior_pid (pid))'.
1917
1918         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1919         'nat/fork-inferior.o'.
1920         * gnu-nat.c: #include "nat/fork-inferior.h".
1921
1922         * gnu-nat.c (gnu_nat_target::detach): Instead of
1923         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1924         * gnu-nat.h: #include "inf-child.h".
1925         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1926         'i386_gnu_nat_target::fetch_registers'.
1927         (gnu_store_registers): Rename/move to
1928         'i386_gnu_nat_target::store_registers'.
1929
1930         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1931         * gnu-nat.h (mach_thread_info): New function.
1932         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1933
1934         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1935
1936 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1937
1938         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1939
1940 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1941
1942         * windows-nat.c (windows_add_thread): Add new parameter
1943         "main_thread_p" with default value set to false.  Update
1944         function documentation as well as all callers.
1945         (windows_delete_thread): Likewise.
1946         (fake_create_process): Update call to windows_add_thread.
1947         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1948         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1949         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1950         call to windows_delete_thread.
1951
1952 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1953
1954         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1955
1956 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1957
1958         * symfile.c (find_separate_debug_file): Use canonical path of
1959         sysroot with child_path instead of gdb_sysroot if it is valid.
1960
1961 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1962
1963         * symfile.c (find_separate_debug_file): Use child_path to
1964         determine if an object file is under a sysroot.
1965
1966 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1967
1968         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1969         unittests/child-path-selftests.c.
1970         * common/pathstuff.c (child_path): New function.
1971         * common/pathstuff.h (child_path): New prototype.
1972         * unittests/child-path-selftests.c: New file.
1973
1974 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1975
1976         * symfile.c (find_separate_debug_file): Look for separate debug
1977         files in debug directories under the sysroot.
1978
1979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1980
1981         * symtab.h (struct minimal_symbol data_p): New const method.
1982         (struct minimal_symbol text_p): Likewise.
1983         * symtab.c (output_source_filename): Use file name style
1984         to print file name.
1985         (print_symbol_info): Likewise.
1986         (print_msymbol_info): Use address style to print addresses.
1987         Use function name style to print executable text symbols.
1988         (expand_symtab_containing_pc): Use data_p.
1989         (find_pc_sect_compunit_symtab): Likewise.
1990
1991 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1992
1993         * breakpoint.c (describe_other_breakpoints): Use address style
1994         to print addresses.
1995         (say_where): Likewise.
1996
1997 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1998
1999         * ada-typeprint.c (print_func_type): Print function name
2000         style to print function name.
2001         * c-typeprint.c (c_print_type_1): Likewise.
2002
2003 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2004
2005         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2006         for execve.
2007
2008 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2009
2010         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2011         type_stack.
2012
2013 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2014
2015         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2016         TYPE_CODE_REF types.
2017
2018 2019-02-08  Jim Wilson  <jimw@sifive.com>
2019
2020         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2021         (riscv_linux_fregset): New.
2022         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2023
2024 2019-02-07  Tom Tromey  <tom@tromey.com>
2025
2026         * thread.c (thread_cancel_execution_command): Update.
2027         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2028         methods.
2029         (struct thread_fsm_ops): Remove.
2030         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2031         (thread_fsm_should_stop, thread_fsm_return_value)
2032         (thread_fsm_set_finished, thread_fsm_finished_p)
2033         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2034         Don't declare.
2035         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2036         * infrun.c (clear_proceed_status_thread)
2037         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2038         (print_stop_event): Update.
2039         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2040         Add constructor.
2041         (step_command_fsm_ops): Remove.
2042         (new_step_command_fsm): Remove.
2043         (step_1): Update.
2044         (step_command_fsm::should_stop): Rename from
2045         step_command_fsm_should_stop.
2046         (step_command_fsm::clean_up): Rename from
2047         step_command_fsm_clean_up.
2048         (step_command_fsm::do_async_reply_reason): Rename from
2049         step_command_fsm_async_reply_reason.
2050         (struct until_next_fsm): Inherit from thread_fsm.  Add
2051         constructor.
2052         (until_next_fsm_ops): Remove.
2053         (new_until_next_fsm): Remove.
2054         (until_next_fsm::should_stop): Rename from
2055         until_next_fsm_should_stop.
2056         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2057         (until_next_fsm::do_async_reply_reason): Rename from
2058         until_next_fsm_async_reply_reason.
2059         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2060         constructor.  Change type of breakpoint.
2061         (finish_command_fsm_ops): Remove.
2062         (new_finish_command_fsm): Remove.
2063         (finish_command_fsm::should_stop): Rename from
2064         finish_command_fsm_should_stop.
2065         (finish_command_fsm::clean_up): Rename from
2066         finish_command_fsm_clean_up.
2067         (finish_command_fsm::return_value): Rename from
2068         finish_command_fsm_return_value.
2069         (finish_command_fsm::do_async_reply_reason): Rename from
2070         finish_command_fsm_async_reply_reason.
2071         (finish_command): Update.
2072         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2073         Add constructor.
2074         (call_thread_fsm_ops): Remove.
2075         (call_thread_fsm::call_thread_fsm): Rename from
2076         new_call_thread_fsm.
2077         (call_thread_fsm::should_stop): Rename from
2078         call_thread_fsm_should_stop.
2079         (call_thread_fsm::should_notify_stop): Rename from
2080         call_thread_fsm_should_notify_stop.
2081         (run_inferior_call, call_function_by_hand_dummy): Update.
2082         * cli/cli-interp.c (should_print_stop_to_console): Update.
2083         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2084         Add constructor.  Change type of location_breakpoint,
2085         caller_breakpoint.
2086         (until_break_fsm_ops): Remove.
2087         (new_until_break_fsm): Remove.
2088         (until_break_fsm::should_stop): Rename from
2089         until_break_fsm_should_stop.
2090         (until_break_fsm::clean_up): Rename from
2091         until_break_fsm_clean_up.
2092         (until_break_fsm::do_async_reply_reason): Rename from
2093         until_break_fsm_async_reply_reason.
2094         (until_break_command): Update.
2095         * thread-fsm.c: Remove.
2096         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2097
2098 2019-02-07  Tom Tromey  <tom@tromey.com>
2099
2100         * yy-remap.h: Add include guard.
2101         * xtensa-tdep.h: Add include guard.
2102         * xcoffread.h: Rename include guard.
2103         * varobj-iter.h: Add include guard.
2104         * tui/tui.h: Rename include guard.
2105         * tui/tui-winsource.h: Rename include guard.
2106         * tui/tui-wingeneral.h: Rename include guard.
2107         * tui/tui-windata.h: Rename include guard.
2108         * tui/tui-win.h: Rename include guard.
2109         * tui/tui-stack.h: Rename include guard.
2110         * tui/tui-source.h: Rename include guard.
2111         * tui/tui-regs.h: Rename include guard.
2112         * tui/tui-out.h: Rename include guard.
2113         * tui/tui-layout.h: Rename include guard.
2114         * tui/tui-io.h: Rename include guard.
2115         * tui/tui-hooks.h: Rename include guard.
2116         * tui/tui-file.h: Rename include guard.
2117         * tui/tui-disasm.h: Rename include guard.
2118         * tui/tui-data.h: Rename include guard.
2119         * tui/tui-command.h: Rename include guard.
2120         * tic6x-tdep.h: Add include guard.
2121         * target/waitstatus.h: Rename include guard.
2122         * target/wait.h: Rename include guard.
2123         * target/target.h: Rename include guard.
2124         * target/resume.h: Rename include guard.
2125         * target-float.h: Rename include guard.
2126         * stabsread.h: Add include guard.
2127         * rs6000-tdep.h: Add include guard.
2128         * riscv-fbsd-tdep.h: Add include guard.
2129         * regformats/regdef.h: Rename include guard.
2130         * record.h: Rename include guard.
2131         * python/python.h: Rename include guard.
2132         * python/python-internal.h: Rename include guard.
2133         * python/py-stopevent.h: Rename include guard.
2134         * python/py-ref.h: Rename include guard.
2135         * python/py-record.h: Rename include guard.
2136         * python/py-record-full.h: Rename include guard.
2137         * python/py-record-btrace.h: Rename include guard.
2138         * python/py-instruction.h: Rename include guard.
2139         * python/py-events.h: Rename include guard.
2140         * python/py-event.h: Rename include guard.
2141         * procfs.h: Add include guard.
2142         * proc-utils.h: Add include guard.
2143         * p-lang.h: Add include guard.
2144         * or1k-tdep.h: Rename include guard.
2145         * observable.h: Rename include guard.
2146         * nto-tdep.h: Rename include guard.
2147         * nat/x86-linux.h: Rename include guard.
2148         * nat/x86-linux-dregs.h: Rename include guard.
2149         * nat/x86-gcc-cpuid.h: Add include guard.
2150         * nat/x86-dregs.h: Rename include guard.
2151         * nat/x86-cpuid.h: Rename include guard.
2152         * nat/ppc-linux.h: Rename include guard.
2153         * nat/mips-linux-watch.h: Rename include guard.
2154         * nat/linux-waitpid.h: Rename include guard.
2155         * nat/linux-ptrace.h: Rename include guard.
2156         * nat/linux-procfs.h: Rename include guard.
2157         * nat/linux-osdata.h: Rename include guard.
2158         * nat/linux-nat.h: Rename include guard.
2159         * nat/linux-namespaces.h: Rename include guard.
2160         * nat/linux-btrace.h: Rename include guard.
2161         * nat/glibc_thread_db.h: Rename include guard.
2162         * nat/gdb_thread_db.h: Rename include guard.
2163         * nat/gdb_ptrace.h: Rename include guard.
2164         * nat/fork-inferior.h: Rename include guard.
2165         * nat/amd64-linux-siginfo.h: Rename include guard.
2166         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2167         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2168         * nat/aarch64-linux.h: Rename include guard.
2169         * nat/aarch64-linux-hw-point.h: Rename include guard.
2170         * mn10300-tdep.h: Add include guard.
2171         * mips-linux-tdep.h: Add include guard.
2172         * mi/mi-parse.h: Rename include guard.
2173         * mi/mi-out.h: Rename include guard.
2174         * mi/mi-main.h: Rename include guard.
2175         * mi/mi-interp.h: Rename include guard.
2176         * mi/mi-getopt.h: Rename include guard.
2177         * mi/mi-console.h: Rename include guard.
2178         * mi/mi-common.h: Rename include guard.
2179         * mi/mi-cmds.h: Rename include guard.
2180         * mi/mi-cmd-break.h: Rename include guard.
2181         * m2-lang.h: Add include guard.
2182         * location.h: Rename include guard.
2183         * linux-record.h: Rename include guard.
2184         * linux-nat.h: Add include guard.
2185         * linux-fork.h: Add include guard.
2186         * i386-darwin-tdep.h: Rename include guard.
2187         * hppa-linux-offsets.h: Add include guard.
2188         * guile/guile.h: Rename include guard.
2189         * guile/guile-internal.h: Rename include guard.
2190         * gnu-nat.h: Rename include guard.
2191         * gdb-stabs.h: Rename include guard.
2192         * frv-tdep.h: Add include guard.
2193         * f-lang.h: Add include guard.
2194         * event-loop.h: Add include guard.
2195         * darwin-nat.h: Rename include guard.
2196         * cp-abi.h: Rename include guard.
2197         * config/sparc/nm-sol2.h: Rename include guard.
2198         * config/nm-nto.h: Rename include guard.
2199         * config/nm-linux.h: Add include guard.
2200         * config/i386/nm-i386gnu.h: Rename include guard.
2201         * config/djgpp/nl_types.h: Rename include guard.
2202         * config/djgpp/langinfo.h: Rename include guard.
2203         * compile/gcc-cp-plugin.h: Add include guard.
2204         * compile/gcc-c-plugin.h: Add include guard.
2205         * compile/compile.h: Rename include guard.
2206         * compile/compile-object-run.h: Rename include guard.
2207         * compile/compile-object-load.h: Rename include guard.
2208         * compile/compile-internal.h: Rename include guard.
2209         * compile/compile-cplus.h: Rename include guard.
2210         * compile/compile-c.h: Rename include guard.
2211         * common/xml-utils.h: Rename include guard.
2212         * common/x86-xstate.h: Rename include guard.
2213         * common/version.h: Rename include guard.
2214         * common/vec.h: Rename include guard.
2215         * common/tdesc.h: Rename include guard.
2216         * common/selftest.h: Rename include guard.
2217         * common/scoped_restore.h: Rename include guard.
2218         * common/scoped_mmap.h: Rename include guard.
2219         * common/scoped_fd.h: Rename include guard.
2220         * common/safe-iterator.h: Rename include guard.
2221         * common/run-time-clock.h: Rename include guard.
2222         * common/refcounted-object.h: Rename include guard.
2223         * common/queue.h: Rename include guard.
2224         * common/ptid.h: Rename include guard.
2225         * common/print-utils.h: Rename include guard.
2226         * common/preprocessor.h: Rename include guard.
2227         * common/pathstuff.h: Rename include guard.
2228         * common/observable.h: Rename include guard.
2229         * common/netstuff.h: Rename include guard.
2230         * common/job-control.h: Rename include guard.
2231         * common/host-defs.h: Rename include guard.
2232         * common/gdb_wait.h: Rename include guard.
2233         * common/gdb_vecs.h: Rename include guard.
2234         * common/gdb_unlinker.h: Rename include guard.
2235         * common/gdb_unique_ptr.h: Rename include guard.
2236         * common/gdb_tilde_expand.h: Rename include guard.
2237         * common/gdb_sys_time.h: Rename include guard.
2238         * common/gdb_string_view.h: Rename include guard.
2239         * common/gdb_splay_tree.h: Rename include guard.
2240         * common/gdb_setjmp.h: Rename include guard.
2241         * common/gdb_ref_ptr.h: Rename include guard.
2242         * common/gdb_optional.h: Rename include guard.
2243         * common/gdb_locale.h: Rename include guard.
2244         * common/gdb_assert.h: Rename include guard.
2245         * common/filtered-iterator.h: Rename include guard.
2246         * common/filestuff.h: Rename include guard.
2247         * common/fileio.h: Rename include guard.
2248         * common/environ.h: Rename include guard.
2249         * common/common-utils.h: Rename include guard.
2250         * common/common-types.h: Rename include guard.
2251         * common/common-regcache.h: Rename include guard.
2252         * common/common-inferior.h: Rename include guard.
2253         * common/common-gdbthread.h: Rename include guard.
2254         * common/common-exceptions.h: Rename include guard.
2255         * common/common-defs.h: Rename include guard.
2256         * common/common-debug.h: Rename include guard.
2257         * common/cleanups.h: Rename include guard.
2258         * common/buffer.h: Rename include guard.
2259         * common/btrace-common.h: Rename include guard.
2260         * common/break-common.h: Rename include guard.
2261         * cli/cli-utils.h: Rename include guard.
2262         * cli/cli-style.h: Rename include guard.
2263         * cli/cli-setshow.h: Rename include guard.
2264         * cli/cli-script.h: Rename include guard.
2265         * cli/cli-interp.h: Rename include guard.
2266         * cli/cli-decode.h: Rename include guard.
2267         * cli/cli-cmds.h: Rename include guard.
2268         * charset-list.h: Add include guard.
2269         * buildsym-legacy.h: Rename include guard.
2270         * bfin-tdep.h: Add include guard.
2271         * ax.h: Rename include guard.
2272         * arm-linux-tdep.h: Add include guard.
2273         * arm-fbsd-tdep.h: Add include guard.
2274         * arch/xtensa.h: Rename include guard.
2275         * arch/tic6x.h: Add include guard.
2276         * arch/i386.h: Add include guard.
2277         * arch/arm.h: Rename include guard.
2278         * arch/arm-linux.h: Rename include guard.
2279         * arch/arm-get-next-pcs.h: Rename include guard.
2280         * arch/amd64.h: Add include guard.
2281         * arch/aarch64-insn.h: Rename include guard.
2282         * arch-utils.h: Rename include guard.
2283         * annotate.h: Add include guard.
2284         * amd64-darwin-tdep.h: Rename include guard.
2285         * aarch64-linux-tdep.h: Add include guard.
2286         * aarch64-fbsd-tdep.h: Add include guard.
2287         * aarch32-linux-nat.h: Add include guard.
2288
2289 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2290
2291         * macrotab.c (macro_define_internal): New function that
2292         factorizes macro_define_object_internal and macro_define_function
2293         code.
2294         (macro_define_object_internal): Use macro_define_internal.
2295         (macro_define_function): Likewise.
2296
2297 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2298
2299         * macrocmd.c (extract_identifier): Return
2300         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2301         callers.
2302
2303 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2304
2305         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2306
2307 2019-02-05  Tom Tromey  <tom@tromey.com>
2308
2309         * target.c (target_stack::unpush): Move assertion earlier.
2310
2311 2019-01-30  Tom Tromey  <tom@tromey.com>
2312
2313         PR python/23615:
2314         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2315         (gdbpy_parse_and_eval): Likewise.
2316         * python/python-internal.h (gdbpy_allow_threads): New class.
2317
2318 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2319
2320         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2321         (aarch64_fbsd_fpregmap): Move earlier.
2322         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2323         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2324         instead of individual calls to trad_frame_set_reg_addr.
2325         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2326         earlier.
2327         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2328         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2329         instead of individual calls to trad_frame_set_reg_addr.
2330
2331 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2332
2333         * CONTRIBUTE: Replace contribution list with wiki link.
2334
2335 2019-01-25  Tom Tromey  <tom@tromey.com>
2336
2337         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2338
2339 2019-01-25  Tom Tromey  <tom@tromey.com>
2340
2341         * xtensa-linux-nat.c: Fix common/ includes.
2342         * xml-support.h: Fix common/ includes.
2343         * xml-support.c: Fix common/ includes.
2344         * x86-linux-nat.c: Fix common/ includes.
2345         * windows-nat.c: Fix common/ includes.
2346         * varobj.h: Fix common/ includes.
2347         * varobj.c: Fix common/ includes.
2348         * value.c: Fix common/ includes.
2349         * valops.c: Fix common/ includes.
2350         * utils.c: Fix common/ includes.
2351         * unittests/xml-utils-selftests.c: Fix common/ includes.
2352         * unittests/utils-selftests.c: Fix common/ includes.
2353         * unittests/unpack-selftests.c: Fix common/ includes.
2354         * unittests/tracepoint-selftests.c: Fix common/ includes.
2355         * unittests/style-selftests.c: Fix common/ includes.
2356         * unittests/string_view-selftests.c: Fix common/ includes.
2357         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2358         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2359         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2360         * unittests/rsp-low-selftests.c: Fix common/ includes.
2361         * unittests/parse-connection-spec-selftests.c: Fix common/
2362         includes.
2363         * unittests/optional-selftests.c: Fix common/ includes.
2364         * unittests/offset-type-selftests.c: Fix common/ includes.
2365         * unittests/observable-selftests.c: Fix common/ includes.
2366         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2367         * unittests/memrange-selftests.c: Fix common/ includes.
2368         * unittests/memory-map-selftests.c: Fix common/ includes.
2369         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2370         * unittests/function-view-selftests.c: Fix common/ includes.
2371         * unittests/environ-selftests.c: Fix common/ includes.
2372         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2373         * unittests/common-utils-selftests.c: Fix common/ includes.
2374         * unittests/cli-utils-selftests.c: Fix common/ includes.
2375         * unittests/array-view-selftests.c: Fix common/ includes.
2376         * ui-file.c: Fix common/ includes.
2377         * tui/tui-io.c: Fix common/ includes.
2378         * tracepoint.h: Fix common/ includes.
2379         * tracepoint.c: Fix common/ includes.
2380         * tracefile-tfile.c: Fix common/ includes.
2381         * top.h: Fix common/ includes.
2382         * top.c: Fix common/ includes.
2383         * thread.c: Fix common/ includes.
2384         * target/waitstatus.h: Fix common/ includes.
2385         * target/waitstatus.c: Fix common/ includes.
2386         * target.h: Fix common/ includes.
2387         * target.c: Fix common/ includes.
2388         * target-memory.c: Fix common/ includes.
2389         * target-descriptions.c: Fix common/ includes.
2390         * symtab.h: Fix common/ includes.
2391         * symfile.c: Fix common/ includes.
2392         * stap-probe.c: Fix common/ includes.
2393         * spu-linux-nat.c: Fix common/ includes.
2394         * sparc-nat.c: Fix common/ includes.
2395         * source.c: Fix common/ includes.
2396         * solib.c: Fix common/ includes.
2397         * solib-target.c: Fix common/ includes.
2398         * ser-unix.c: Fix common/ includes.
2399         * ser-tcp.c: Fix common/ includes.
2400         * ser-pipe.c: Fix common/ includes.
2401         * ser-base.c: Fix common/ includes.
2402         * selftest-arch.c: Fix common/ includes.
2403         * s12z-tdep.c: Fix common/ includes.
2404         * rust-exp.y: Fix common/ includes.
2405         * rs6000-aix-tdep.c: Fix common/ includes.
2406         * riscv-tdep.c: Fix common/ includes.
2407         * remote.c: Fix common/ includes.
2408         * remote-notif.h: Fix common/ includes.
2409         * remote-fileio.h: Fix common/ includes.
2410         * remote-fileio.c: Fix common/ includes.
2411         * regcache.h: Fix common/ includes.
2412         * regcache.c: Fix common/ includes.
2413         * record-btrace.c: Fix common/ includes.
2414         * python/python.c: Fix common/ includes.
2415         * python/py-type.c: Fix common/ includes.
2416         * python/py-inferior.c: Fix common/ includes.
2417         * progspace.h: Fix common/ includes.
2418         * producer.c: Fix common/ includes.
2419         * procfs.c: Fix common/ includes.
2420         * proc-api.c: Fix common/ includes.
2421         * printcmd.c: Fix common/ includes.
2422         * ppc-linux-nat.c: Fix common/ includes.
2423         * parser-defs.h: Fix common/ includes.
2424         * osdata.c: Fix common/ includes.
2425         * obsd-nat.c: Fix common/ includes.
2426         * nat/x86-linux.c: Fix common/ includes.
2427         * nat/x86-linux-dregs.c: Fix common/ includes.
2428         * nat/x86-dregs.h: Fix common/ includes.
2429         * nat/x86-dregs.c: Fix common/ includes.
2430         * nat/ppc-linux.c: Fix common/ includes.
2431         * nat/mips-linux-watch.h: Fix common/ includes.
2432         * nat/mips-linux-watch.c: Fix common/ includes.
2433         * nat/linux-waitpid.c: Fix common/ includes.
2434         * nat/linux-ptrace.h: Fix common/ includes.
2435         * nat/linux-ptrace.c: Fix common/ includes.
2436         * nat/linux-procfs.c: Fix common/ includes.
2437         * nat/linux-personality.c: Fix common/ includes.
2438         * nat/linux-osdata.c: Fix common/ includes.
2439         * nat/linux-namespaces.c: Fix common/ includes.
2440         * nat/linux-btrace.h: Fix common/ includes.
2441         * nat/linux-btrace.c: Fix common/ includes.
2442         * nat/fork-inferior.c: Fix common/ includes.
2443         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2444         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2445         * nat/aarch64-linux.c: Fix common/ includes.
2446         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2447         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2448         * namespace.h: Fix common/ includes.
2449         * mips-linux-tdep.c: Fix common/ includes.
2450         * minsyms.c: Fix common/ includes.
2451         * mi/mi-parse.h: Fix common/ includes.
2452         * mi/mi-main.c: Fix common/ includes.
2453         * mi/mi-cmd-env.c: Fix common/ includes.
2454         * memrange.h: Fix common/ includes.
2455         * memattr.c: Fix common/ includes.
2456         * maint.h: Fix common/ includes.
2457         * maint.c: Fix common/ includes.
2458         * main.c: Fix common/ includes.
2459         * machoread.c: Fix common/ includes.
2460         * location.c: Fix common/ includes.
2461         * linux-thread-db.c: Fix common/ includes.
2462         * linux-nat.c: Fix common/ includes.
2463         * linux-fork.c: Fix common/ includes.
2464         * inline-frame.c: Fix common/ includes.
2465         * infrun.c: Fix common/ includes.
2466         * inflow.c: Fix common/ includes.
2467         * inferior.h: Fix common/ includes.
2468         * inferior.c: Fix common/ includes.
2469         * infcmd.c: Fix common/ includes.
2470         * inf-ptrace.c: Fix common/ includes.
2471         * inf-child.c: Fix common/ includes.
2472         * ia64-linux-nat.c: Fix common/ includes.
2473         * i387-tdep.c: Fix common/ includes.
2474         * i386-tdep.c: Fix common/ includes.
2475         * i386-linux-tdep.c: Fix common/ includes.
2476         * i386-linux-nat.c: Fix common/ includes.
2477         * i386-go32-tdep.c: Fix common/ includes.
2478         * i386-fbsd-tdep.c: Fix common/ includes.
2479         * i386-fbsd-nat.c: Fix common/ includes.
2480         * guile/scm-type.c: Fix common/ includes.
2481         * guile/guile.c: Fix common/ includes.
2482         * go32-nat.c: Fix common/ includes.
2483         * gnu-nat.c: Fix common/ includes.
2484         * gdbthread.h: Fix common/ includes.
2485         * gdbarch-selftests.c: Fix common/ includes.
2486         * gdb_usleep.c: Fix common/ includes.
2487         * gdb_select.h: Fix common/ includes.
2488         * gdb_bfd.c: Fix common/ includes.
2489         * gcore.c: Fix common/ includes.
2490         * fork-child.c: Fix common/ includes.
2491         * findvar.c: Fix common/ includes.
2492         * fbsd-nat.c: Fix common/ includes.
2493         * event-top.c: Fix common/ includes.
2494         * event-loop.c: Fix common/ includes.
2495         * dwarf2read.c: Fix common/ includes.
2496         * dwarf2loc.c: Fix common/ includes.
2497         * dwarf2-frame.c: Fix common/ includes.
2498         * dwarf-index-cache.c: Fix common/ includes.
2499         * dtrace-probe.c: Fix common/ includes.
2500         * disasm-selftests.c: Fix common/ includes.
2501         * defs.h: Fix common/ includes.
2502         * csky-tdep.c: Fix common/ includes.
2503         * cp-valprint.c: Fix common/ includes.
2504         * cp-support.h: Fix common/ includes.
2505         * cp-support.c: Fix common/ includes.
2506         * corelow.c: Fix common/ includes.
2507         * completer.h: Fix common/ includes.
2508         * completer.c: Fix common/ includes.
2509         * compile/compile.c: Fix common/ includes.
2510         * compile/compile-loc2c.c: Fix common/ includes.
2511         * compile/compile-cplus-types.c: Fix common/ includes.
2512         * compile/compile-cplus-symbols.c: Fix common/ includes.
2513         * command.h: Fix common/ includes.
2514         * cli/cli-dump.c: Fix common/ includes.
2515         * cli/cli-cmds.c: Fix common/ includes.
2516         * charset.c: Fix common/ includes.
2517         * build-id.c: Fix common/ includes.
2518         * btrace.h: Fix common/ includes.
2519         * btrace.c: Fix common/ includes.
2520         * breakpoint.h: Fix common/ includes.
2521         * breakpoint.c: Fix common/ includes.
2522         * ax.h:
2523         (enum agent_op): Fix common/ includes.
2524         * ax-general.c (struct aop_map): Fix common/ includes.
2525         * ax-gdb.c: Fix common/ includes.
2526         * auxv.c: Fix common/ includes.
2527         * auto-load.c: Fix common/ includes.
2528         * arm-tdep.c: Fix common/ includes.
2529         * arch/riscv.c: Fix common/ includes.
2530         * arch/ppc-linux-common.c: Fix common/ includes.
2531         * arch/i386.c: Fix common/ includes.
2532         * arch/arm.c: Fix common/ includes.
2533         * arch/arm-linux.c: Fix common/ includes.
2534         * arch/arm-get-next-pcs.c: Fix common/ includes.
2535         * arch/amd64.c: Fix common/ includes.
2536         * arch/aarch64.c: Fix common/ includes.
2537         * arch/aarch64-insn.c: Fix common/ includes.
2538         * arch-utils.c: Fix common/ includes.
2539         * amd64-windows-tdep.c: Fix common/ includes.
2540         * amd64-tdep.c: Fix common/ includes.
2541         * amd64-sol2-tdep.c: Fix common/ includes.
2542         * amd64-obsd-tdep.c: Fix common/ includes.
2543         * amd64-nbsd-tdep.c: Fix common/ includes.
2544         * amd64-linux-tdep.c: Fix common/ includes.
2545         * amd64-linux-nat.c: Fix common/ includes.
2546         * amd64-fbsd-tdep.c: Fix common/ includes.
2547         * amd64-fbsd-nat.c: Fix common/ includes.
2548         * amd64-dicos-tdep.c: Fix common/ includes.
2549         * amd64-darwin-tdep.c: Fix common/ includes.
2550         * agent.c: Fix common/ includes.
2551         * ada-lang.h: Fix common/ includes.
2552         * ada-lang.c: Fix common/ includes.
2553         * aarch64-tdep.c: Fix common/ includes.
2554
2555 2019-01-25  Tom Tromey  <tom@tromey.com>
2556
2557         * common/create-version.sh: Use common/version.h.
2558
2559 2019-01-24  Pedro Alves  <palves@redhat.com>
2560
2561         * infrun.c (signal_stop, signal_print, signal_program)
2562         (signal_catch, signal_pass): Now arrays instead of pointers.
2563         (update_signals_program_target, do_target_resume)
2564         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2565         * linux-nat.c (linux_nat_target::pass_signals)
2566         (linux_nat_target::create_inferior, linux_nat_target::attach):
2567         Adjust.
2568         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2569         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2570         * procfs.c (procfs_target::pass_signals): Adjust.
2571         * record-full.c (record_full_target::resume): Adjust.
2572         * remote.c (remote_target::pass_signals)
2573         (remote_target::program_signals): Adjust.
2574         * target-debug.h (target_debug_print_signals): Now takes a
2575         gdb::array_view as parameter.  Adjust.
2576         * target.h (target_ops) <pass_signals, program_signals>: Replace
2577         pointer and length parameters with gdb::array_view.
2578         (target_pass_signals, target_program_signals): Likewise.
2579         * target-delegates.c: Regenerate.
2580
2581 2019-01-24  Pedro Alves  <palves@redhat.com>
2582
2583         * common/forward-scope-exit.h
2584         (forward_scope_exit::forward_scope_exit): Pass arguments to
2585         m_bind_function directly, instead of creating a std::bind and
2586         copying that.
2587
2588 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2589
2590         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2591         for static members.
2592         (pass_in_v_vfp_candidate): Likewise.
2593
2594 2019-01-23  Tom Tromey  <tom@tromey.com>
2595             Pedro Alves  <palves@redhat.com>
2596
2597         * regcache.c (class regcache_invalidator): Remove.
2598         (regcache::raw_write): Use make_scope_exit.
2599
2600 2019-01-23  Tom Tromey  <tom@tromey.com>
2601
2602         * ui-out.h (class ui_out_emit_type): Update comment.
2603
2604 2019-01-23  Tom Tromey  <tom@tromey.com>
2605
2606         * infrun.c (fetch_inferior_event): Update comment.
2607
2608 2019-01-23  Tom Tromey  <tom@tromey.com>
2609             Pedro Alves  <palves@redhat.com>
2610
2611         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2612         parameter.
2613         (fetch_inferior_event): Use SCOPE_EXIT.
2614
2615
2616 2019-01-23  Tom Tromey  <tom@tromey.com>
2617             Pedro Alves  <palves@redhat.com>
2618
2619         * infrun.c (disable_thread_events): Delete.
2620         (stop_all_threads): Use SCOPE_EXIT.
2621
2622 2019-01-23  Tom Tromey  <tom@tromey.com>
2623             Pedro Alves  <palves@redhat.com>
2624
2625         * symfile.c: Include forward-scope-exit.h.
2626         (clear_symtab_users_cleanup): Replace forward declaration with
2627         a FORWARD_SCOPE_EXIT.
2628         (syms_from_objfile_1): Use the forward_scope_exit and
2629         gdb::optional instead of cleanup_function.
2630         (reread_symbols): Use the forward_scope_exit instead of
2631         cleanup_function.
2632         (clear_symtab_users_cleanup): Remove function.
2633
2634 2019-01-23  Tom Tromey  <tom@tromey.com>
2635             Pedro Alves  <palves@redhat.com>
2636
2637         * linux-nat.c: Include scope-exit.h.
2638         (cleanup_target_stop): Remove.
2639         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2640         SCOPE_EXIT.
2641
2642 2019-01-23  Tom Tromey  <tom@tromey.com>
2643             Pedro Alves  <palves@redhat.com>
2644
2645         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2646         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2647
2648 2019-01-23  Tom Tromey  <tom@tromey.com>
2649             Andrew Burgess  <andrew.burgess@embecosm.com>
2650             Pedro Alves  <palves@redhat.com>
2651
2652         * infrun.c (fetch_inferior_event): Use scope_exit.
2653         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2654         * top.c (execute_command): Use scope_exit.
2655         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2656         * utils.c (do_bpstat_clear_actions_cleanup)
2657         (make_bpstat_clear_actions_cleanup): Remove.
2658
2659 2019-01-23  Tom Tromey  <tom@tromey.com>
2660             Pedro Alves  <palves@redhat.com>
2661
2662         * infrun.c: Include "common/scope-exit.h"
2663         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2664         (wait_for_inferior): Use SCOPE_EXIT.
2665         (fetch_inferior_event): Use scope_exit.
2666
2667 2019-01-23  Tom Tromey  <tom@tromey.com>
2668             Pedro Alves  <palves@redhat.com>
2669
2670         * breakpoint.c (create_breakpoint): Remove cleanup.
2671
2672 2019-01-23  Tom Tromey  <tom@tromey.com>
2673             Andrew Burgess  <andrew.burgess@embecosm.com>
2674             Pedro Alves  <palves@redhat.com>
2675
2676 2019-01-23  Pedro Alves  <palves@redhat.com>
2677
2678         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2679
2680 2019-01-23  Pedro Alves  <palves@redhat.com>
2681             Andrew Burgess  <andrew.burgess@embecosm.com>
2682
2683         * gdbthread.h: Include "common/forward-scope-exit.h".
2684         (scoped_finish_thread_state): Redefine custom class in terms of
2685         forward_scope_exit.
2686
2687 2019-01-23  Pedro Alves  <palves@redhat.com>
2688             Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * common/forward-scope-exit.h: New file.
2691
2692 2019-01-23  Pedro Alves  <palves@redhat.com>
2693             Andrew Burgess  <andrew.burgess@embecosm.com>
2694             Tom Tromey  <tom@tromey.com>
2695
2696         * common/scope-exit.h: New file.
2697
2698 2019-01-23  Pedro Alves  <palves@redhat.com>
2699
2700         * common/preprocessor.h (ESC): Rename to ...
2701         (ESC_PARENS): ... this.
2702         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2703         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2704
2705 2019-01-23  Tom Tromey  <tom@tromey.com>
2706
2707         * language.h (class scoped_switch_to_sym_language_if_auto):
2708         Initialize m_lang in both cases.
2709
2710 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2711
2712         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2713         with XCNEW.
2714
2715 2019-01-22  Tom Tromey  <tom@tromey.com>
2716
2717         * corelow.c: Do not include sys/file.h.
2718
2719 2019-01-22  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-wingeneral.h: Include gdb_curses.h.
2722
2723 2019-01-22  Tom Tromey  <tom@tromey.com>
2724
2725         * source-cache.h (class source_cache) <get_source_lines,
2726         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2727
2728 2019-01-22  Tom Tromey  <tom@tromey.com>
2729
2730         * remote-fileio.h (struct remote_target): Declare.
2731
2732 2019-01-22  Tom Tromey  <tom@tromey.com>
2733
2734         * python/py-arch.c: Do not include py-ref.h.
2735         * python/py-bpevent.c: Do not include py-ref.h.
2736         * python/py-cmd.c: Do not include py-ref.h.
2737         * python/py-continueevent.c: Do not include py-ref.h.
2738         * python/py-event.h: Do not include py-ref.h.
2739         * python/py-evtregistry.c: Do not include py-ref.h.
2740         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2741         * python/py-frame.c: Do not include py-ref.h.
2742         * python/py-framefilter.c: Do not include py-ref.h.
2743         * python/py-function.c: Do not include py-ref.h.
2744         * python/py-infevents.c: Do not include py-ref.h.
2745         * python/py-linetable.c: Do not include py-ref.h.
2746         * python/py-objfile.c: Do not include py-ref.h.
2747         * python/py-param.c: Do not include py-ref.h.
2748         * python/py-prettyprint.c: Do not include py-ref.h.
2749         * python/py-progspace.c: Do not include py-ref.h.
2750         * python/py-symbol.c: Do not include py-ref.h.
2751         * python/py-symtab.c: Do not include py-ref.h.
2752         * python/py-type.c: Do not include py-ref.h.
2753         * python/py-unwind.c: Do not include py-ref.h.
2754         * python/py-utils.c: Do not include py-ref.h.
2755         * python/py-value.c: Do not include py-ref.h.
2756         * python/py-varobj.c: Do not include py-ref.h.
2757         * python/py-xmethods.c: Do not include py-ref.h.
2758         * python/python.c: Do not include py-ref.h.
2759         * varobj.c: Do not include py-ref.h.
2760
2761 2019-01-22  Tom Tromey  <tom@tromey.com>
2762
2763         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2764         keyword for bcache.
2765
2766 2019-01-22  Tom Tromey  <tom@tromey.com>
2767
2768         * compile/compile-cplus-types.c: Remove a comment by #include.
2769
2770 2019-01-22  Tom Tromey  <tom@tromey.com>
2771
2772         * compile/gcc-c-plugin.h: Include compile-internal.h.
2773
2774 2019-01-22  Tom Tromey  <tom@tromey.com>
2775
2776         * stabsread.c (EXTERN): Do not define.
2777         (symnum, next_symbol_text_func, processing_gcc_compilation)
2778         (within_function, global_sym_chain, global_stabs)
2779         (previous_stab_code, this_object_header_files)
2780         (n_this_object_header_files)
2781         (n_allocated_this_object_header_files): Define.
2782         * stabsread.h (EXTERN): Never define.  Use "extern".
2783
2784 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2785
2786         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2787         history_value.
2788
2789 2019-01-21  Tom Tromey  <tom@tromey.com>
2790
2791         * ui-out.c: Fix includes.
2792         * tui/tui-source.c: Fix includes.
2793         * target.c: Fix includes.
2794         * remote.c: Fix includes.
2795         * regcache.c: Fix includes.
2796         * python/py-block.c: Fix includes.
2797         * printcmd.c: Fix includes.
2798         * or1k-tdep.c: Fix includes.
2799         * mi/mi-main.c: Fix includes.
2800         * m32r-tdep.c: Fix includes.
2801         * csky-tdep.c: Fix includes.
2802         * compile/compile-cplus-types.c: Fix includes.
2803         * cli/cli-interp.c: Fix includes.
2804
2805 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2806
2807         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2808         for padding.
2809
2810 2019-01-16  Tom Tromey  <tom@tromey.com>
2811
2812         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2813         earlier.
2814         (struct objfile) <msymbols_range>: Move from top level.
2815         <msymbols>: New method.
2816         (class objfile_msymbols): Remove.
2817         * symtab.c (default_collect_symbol_completion_matches_break_on):
2818         Update.
2819         * symmisc.c (dump_msymbols): Update.
2820         * stabsread.c (scan_file_globals): Update.
2821         * objc-lang.c (info_selectors_command, info_classes_command)
2822         (find_methods): Update.
2823         * minsyms.c (find_solib_trampoline_target): Update.
2824         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2825         * coffread.c (coff_symfile_read): Update.
2826         * ada-lang.c (ada_lookup_simple_minsym)
2827         (ada_collect_symbol_completion_matches): Update.
2828
2829 2019-01-16  Tom Tromey  <tom@tromey.com>
2830
2831         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2832         type.  Remove no-argument constructor.
2833         <iterator::operator++>: Simplify.
2834         <begin>: Update.
2835         <end>: Use minimal_symbol_count.
2836
2837 2019-01-16  Tom Tromey  <tom@tromey.com>
2838
2839         * objfiles.h (struct objfile) <psymtabs>: New method.
2840         (class objfile_psymtabs): Remove.
2841         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2842         typedef.
2843         <range>: New method.
2844         (require_partial_symbols): Change return type.
2845         * psymtab.c (require_partial_symbols)
2846         (psym_expand_symtabs_matching): Update.
2847         * mdebugread.c (parse_partial_symbols): Update.
2848         * dbxread.c (dbx_end_psymtab): Update.
2849
2850 2019-01-15  Tom Tromey  <tom@tromey.com>
2851
2852         * symtab.c (lookup_objfile_from_block)
2853         (lookup_symbol_in_objfile_symtabs)
2854         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2855         (find_line_symtab, info_sources_command)
2856         (default_collect_symbol_completion_matches_break_on)
2857         (make_source_files_completion_list): Update.
2858         * symmisc.c (print_objfile_statistics, dump_objfile)
2859         (maintenance_print_symbols, maintenance_info_symtabs)
2860         (maintenance_check_symtabs, maintenance_info_line_tables):
2861         Update.
2862         * source.c (select_source_symtab)
2863         (forget_cached_source_info_for_objfile): Update.
2864         * objfiles.h (class objfile_compunits): Remove.
2865         (struct objfile) <compunits_range>: New typedef.
2866         (compunits): New method.
2867         * objfiles.c (objfile_relocate1): Update.
2868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2869         * maint.c (count_symtabs_and_blocks): Update.
2870         * linespec.c (iterate_over_all_matching_symtabs): Update.
2871         * cp-support.c (add_symbol_overload_list_qualified): Update.
2872         * coffread.c (coff_symtab_read): Update.
2873         * ada-lang.c (add_nonlocal_symbols)
2874         (ada_collect_symbol_completion_matches)
2875         (ada_add_global_exceptions): Update.
2876
2877 2019-01-15  Tom Tromey  <tom@tromey.com>
2878
2879         * progspace.h (program_space) <objfiles_safe_range>: New
2880         typedef.
2881         <objfiles_safe>: New method.
2882         * objfiles.h (class all_objfiles_safe): Remove.
2883         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2884         * jit.c (jit_inferior_exit_hook): Update.
2885
2886 2019-01-17  Tom Tromey  <tom@tromey.com>
2887
2888         * progspace.h (program_space) <objfiles_range>: New typedef.
2889         <objfiles>: New method.
2890         <objfiles_head>: Rename from objfiles.
2891         (object_files): Update.
2892         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2893         * guile/scm-pretty-print.c
2894         (ppscm_find_pretty_printer_from_objfiles): Update.
2895         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2896         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2897         Update.
2898         * python/py-progspace.c (pspy_get_objfiles): Update.
2899         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2900         Update.
2901         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2902         (objfpy_lookup_objfile_by_build_id): Update.
2903         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2904         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2905         Update.
2906         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2907         (expand_symtab_containing_pc, lookup_objfile_from_block)
2908         (lookup_static_symbol, basic_lookup_transparent_type)
2909         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2910         (find_line_symtab, info_sources_command)
2911         (default_collect_symbol_completion_matches_break_on)
2912         (make_source_files_completion_list, find_main_name): Update.
2913         * symmisc.c (print_symbol_bcache_statistics)
2914         (print_objfile_statistics, maintenance_print_symbols)
2915         (maintenance_print_msymbols, maintenance_print_objfiles)
2916         (maintenance_info_symtabs, maintenance_check_symtabs)
2917         (maintenance_expand_symtabs, maintenance_info_line_tables):
2918         Update.
2919         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2920         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2921         (map_overlay_command, unmap_overlay_command)
2922         (simple_overlay_update, expand_symtabs_matching)
2923         (map_symbol_filenames): Update.
2924         * symfile-debug.c (set_debug_symfile): Update.
2925         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2926         Update.
2927         * source.c (select_source_symtab, forget_cached_source_info):
2928         Update.
2929         * solib.c (solib_read_symbols): Update.
2930         * solib-spu.c (append_ocl_sos): Update.
2931         * psymtab.c (maintenance_print_psymbols)
2932         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2933         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2934         * printcmd.c (info_symbol_command): Update.
2935         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2936         Update.
2937         * objfiles.h (class all_objfiles): Remove.
2938         * objfiles.c (have_partial_symbols, have_full_symbols)
2939         (have_minimal_symbols, qsort_cmp, update_section_map)
2940         (shared_objfile_contains_address_p)
2941         (default_iterate_over_objfiles_in_search_order): Update.
2942         * objc-lang.c (info_selectors_command, info_classes_command)
2943         (find_methods): Update.
2944         * minsyms.c (find_solib_trampoline_target): Update.
2945         * maint.c (maintenance_info_sections)
2946         (maintenance_translate_address, count_symtabs_and_blocks):
2947         Update.
2948         * main.c (captured_main_1): Update.
2949         * linux-thread-db.c (try_thread_db_load_from_pdir)
2950         (has_libpthread): Update.
2951         * linespec.c (iterate_over_all_matching_symtabs)
2952         (search_minsyms_for_name): Update.
2953         * jit.c (jit_find_objf_with_entry_addr): Update.
2954         * hppa-tdep.c (find_unwind_entry)
2955         (hppa_lookup_stub_minimal_symbol): Update.
2956         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2957         Update.
2958         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2959         (elf_gnu_ifunc_resolve_by_got): Update.
2960         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2961         * dwarf-index-write.c (save_gdb_index_command): Update.
2962         * cp-support.c (add_symbol_overload_list_qualified): Update.
2963         * breakpoint.c (create_overlay_event_breakpoint)
2964         (create_longjmp_master_breakpoint)
2965         (create_std_terminate_master_breakpoint)
2966         (create_exception_master_breakpoint): Update.
2967         * blockframe.c (find_pc_partial_function): Update.
2968         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2969         (ada_collect_symbol_completion_matches)
2970         (ada_add_global_exceptions): Update.
2971
2972 2019-01-17  Tom Tromey  <tom@tromey.com>
2973
2974         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2975         declare VEC.
2976         (solib_target_parse_libraries): Change return type.
2977         (library_list_start_segment, library_list_start_section)
2978         (library_list_end_library, library_list_start_library); Update.
2979         (solib_target_free_library_list): Remove.
2980         (solib_target_parse_libraries): Remove cleanup.  Change return
2981         type.
2982         (solib_target_current_sos): Update.
2983
2984 2019-01-17  Tom Tromey  <tromey@bapiya>
2985
2986         * valprint.c: Replace "the the" with "the".
2987         * symtab.c: Replace "the the" with "the".
2988         * solib.c: Replace "the the" with "the".
2989         * solib-dsbt.c: Replace "the the" with "the".
2990         * linespec.c: Replace "the the" with "the".
2991         * dwarf2loc.h: Replace "the the" with "the".
2992         * amd64-windows-tdep.c: Replace "the the" with "the".
2993         * aarch64-tdep.c: Replace "the the" with "the".
2994
2995 2019-01-16  Keith Seitz  <keiths@redhat.com>
2996
2997         PR gdb/23773
2998         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2999         <builder>: Rename to ..
3000         <m_builder>: ... this and make private.
3001         (dwarf2_cu::get_builder): New method.  Change all users of
3002         `builder' to use this method.
3003         (dwarf2_start_symtab): Move to ...
3004         (dwarf2_cu::start_symtab): ... here.  Update all callers
3005         (setup_type_unit_groups): Move to ...
3006         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3007         callers.
3008         (dwarf2_cu::reset_builder): New method.
3009         (process_full_compunit, process_full_type_unit): Use
3010         dwarf2_cu::reset_builder.
3011         (follow_die_offset): Record the ancestor CU if it is different
3012         from the followed DIE's CU.
3013         (follow_die_sig_1): Likewise.
3014
3015 2019-01-15  Tom Tromey  <tom@tromey.com>
3016
3017         * remote.c (class remote_state) <buf>: Now a char_vector.
3018         <buf_size>: Remove.
3019         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3020         parameter.
3021         (remote_target::getpkt_or_notif_sane_1)
3022         (remote_target::getpkt_sane)
3023         (remote_target::getpkt_or_notif_sane): Likewise.
3024         (class remote_target) <putpkt>: New overload.
3025         (remote_target::read_frame): Change type of "buf_p".  Remove
3026         sizeof_p parameter.
3027         (packet_ok): New overload.
3028         (packet_check_result): New overload.
3029         Update all uses.
3030
3031 2019-01-14  Tom Tromey  <tom@tromey.com>
3032
3033         * remote-notif.c (handle_notification, remote_notif_ack)
3034         (remote_notif_parse): Make "buf" const.
3035         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3036         const.
3037         (remote_notif_parse, remote_notif_ack, handle_notification):
3038         Likewise.
3039         * remote.c (remote_notif_stop_parse): Make "buf" const.
3040         (remote_target::remote_parse_stop_reply): Make "buf" const.
3041         (remote_notif_stop_ack): Make "buf" const.
3042
3043 2019-01-14  Tom Tromey  <tom@tromey.com>
3044
3045         * remote.c (remote_console_output): Make parameter const.
3046
3047 2019-01-14  Tom Tromey  <tom@tromey.com>
3048
3049         * target-debug.h (target_debug_print_signals): Constify.
3050         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3051         * procfs.c (procfs_target::pass_signals): Update.
3052         * linux-nat.c (linux_nat_target::pass_signals): Update.
3053         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3054         * target-delegates.c: Rebuild.
3055         * remote.c (remote_target::program_signals): Update.
3056         (remote_target::pass_signals): Update.
3057         * target.c (target_pass_signals): Constify argument.
3058         (target_program_signals): Likewise.
3059         * target.h (struct target_ops) <pass_signals, program_signals>:
3060         Constify argument.
3061         (target_pass_signals, target_program_signals): Constify argument.
3062
3063 2019-01-14  Tom Tromey  <tom@tromey.com>
3064
3065         PR tui/28819:
3066         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3067
3068 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3069
3070         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3071         field.
3072         * rs6000-tdep.c: Include reggroups.h.
3073         (IS_V_ALIAS_PSEUDOREG): Define.
3074         (rs6000_register_name): Return names for the "vX" aliases.
3075         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3076         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3077         aliases.  Call default_register_reggroup_p for all other
3078         pseudo-registers.
3079         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3080         New functions.
3081         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3082         Handle "vX" aliases.
3083         (v_alias_pseudo_register_collect): New function.
3084         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3085         (rs6000_gdbarch_init): Initialize "vX" aliases as
3086         pseudo-registers.  Restore registration of
3087         rs6000_pseudo_register_reggroup_p with
3088         set_tdesc_pseudo_register_reggroup_p.
3089
3090 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3091
3092         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3093         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3094         set_gdbarch_num_pseudo_regs.
3095
3096 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3097
3098         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3099         Remove arg prefixname, add do_set and do_show.
3100         Add member functions set_list and show_list.
3101         * cli/cli-style.c (class cli_style_option): Update accordingly.
3102         (style_set_list): Move to file scope.
3103         (style_show_list): Likewise.
3104         (set_style): Call help_list.
3105         (show_style): Call cmd_show_list.
3106         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3107         Update to use the new macro.
3108
3109 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3110
3111         * ada-lang.c (_initialize_ada_language): Expand the help text
3112         for the "catch exception" command.
3113
3114 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3115
3116         * symtab.c (matching_obj_sections): Initialize obj,
3117         declare it closer to its usage.
3118
3119 2019-01-10  Tom Tromey  <tom@tromey.com>
3120
3121         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3122         (basic_inf_threads_range): Remove.
3123         (inf_threads_range, inf_non_exited_threads_range)
3124         (safe_inf_threads_range): Use next_adapter.
3125
3126 2019-01-10  Keith Seitz  <keiths@redhat.com>
3127
3128         PR gdb/23712
3129         PR symtab/23010
3130         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3131         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3132
3133 2019-01-10  Keith Seitz  <keiths@redhat.com>
3134
3135         PR gdb/23712
3136         PR symtab/23010
3137         * dictionary.c (pending_to_vector): Remove.
3138         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3139         Remove _1 suffix, replacing functions of the same name.  Update
3140         all callers.
3141         (dict_create_hashed, dict_create_hashed_expandable)
3142         (dict_create_linear, dict_create_linear_expandable, dict_free)
3143         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3144         Make functions static.
3145
3146 2019-01-10  Keith Seitz  <keiths@redhat.com>
3147
3148         PR gdb/23712
3149         PR symtab/23010
3150         * dictionary.h (struct dictionary): Replace declaration with
3151         multidictionary.
3152         (dict_create_hashed, dict_create_hashed_expandable)
3153         (dict_create_linear, dict_create_linear_expandable)
3154         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3155         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3156         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3157         taking multidictionary argument.
3158         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3159         * block.h (struct block) <dict>: Change to multidictionary
3160         and rename `multidict'.
3161         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3162         symmisc.c: Update all dictionary references to multidictionary.
3163
3164 2019-01-10  Keith Seitz  <keiths@redhat.com>
3165
3166         PR gdb/23712
3167         PR symtab/23010
3168         * dictionary.c: Include unordered_map.
3169         (pending_to_vector): New function.
3170         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3171         Rewrite the non-"_1" functions to take vector instead
3172         of linked list.
3173         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3174         "new" _1 versions of the same name.
3175         (multidictionary): Define.
3176         (std::hash<enum language): New definition.
3177         (collate_pending_symbols_by_language, mdict_create_hashed)
3178         (mdict_create_hashed_expandable, mdict_create_linear)
3179         (mdict_create_linear_expandable, mdict_free)
3180         (find_language_dictionary, create_new_language_dictionary)
3181         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3182         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3183         (mdict_size, mdict_empty): New functions.
3184         * dictionary.h (mdict_iterator): Define.
3185
3186 2019-01-10  Pedro Alves  <palves@redhat.com>
3187
3188         * breakpoint.c (read_uploaded_action)
3189         (create_tracepoint_from_upload): Adjust to use
3190         gdb::unique_xmalloc_ptr.
3191         * ctf.c (ctf_write_uploaded_tp):
3192         (SET_ARRAY_FIELD): Use emplace_back.
3193         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3194         * tracefile-tfile.c (tfile_write_uploaded_tp):
3195         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3196         gdb::unique_xmalloc_ptr.
3197         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3198         at_string, cond_string, cmd_strings>: Replace char pointers
3199         with gdb::unique_xmalloc_ptr.
3200
3201 2019-01-10  Pedro Alves  <palves@redhat.com>
3202
3203         * solib-target.c (library_list_start_library): Don't xstrdup name.
3204
3205 2019-01-10  Pedro Alves  <palves@redhat.com>
3206
3207         * mdebugread.c (parse_partial_symbols): Use
3208         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3209
3210 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * linux-fork.c (scoped_switch_fork_info)
3213         <~scoped_switch_fork_info>: Fix incorrect variable name.
3214
3215 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3216
3217         * linux-fork.c (scoped_switch_fork_info)
3218         <scoped_switch_fork_info>: Make explicit.
3219         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3220
3221 2019-01-10  Tom Tromey  <tom@tromey.com>
3222
3223         * objfiles.h (objfile::reset_psymtabs): Update.
3224         * objfiles.c (objfile::objfile): Update.
3225         * psymtab.h (psymtab_storage::obstack): Update.
3226         (psymtab_storage::m_obstack): Use gdb::optional.
3227         (class psymtab_storage): Update comment.  Remove objfile
3228         parameter.
3229         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3230
3231 2019-01-10  Tom Tromey  <tom@tromey.com>
3232
3233         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3234         <free_psymtabs>: Now private.
3235         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3236         (allocate_psymtab): Use new method.
3237
3238 2019-01-10  Tom Tromey  <tom@tromey.com>
3239
3240         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3241         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3242         * mdebugread.c (parse_partial_symbols): Use
3243         allocate_dependencies.
3244         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3245         allocate_dependencies.
3246         (process_psymtab_comp_unit_reader)
3247         (build_type_psymtab_dependencies): Likewise.
3248         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3249
3250 2019-01-10  Tom Tromey  <tom@tromey.com>
3251
3252         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3253         PSYMBOL_SET_LANGUAGE.
3254         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3255
3256 2019-01-10  Tom Tromey  <tom@tromey.com>
3257
3258         * psymtab.h (psymtab_storage::obstack): New method.
3259         <m_obstack>: Rename from obstack; now private.
3260         * psymtab.c (psymtab_storage): Update.
3261         * dwarf2read.c (create_addrmap_from_index)
3262         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3263         Update.
3264
3265 2019-01-10  Tom Tromey  <tom@tromey.com>
3266
3267         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3268         * objfiles.h (objfile::reset_psymtabs): New method.
3269
3270 2019-01-10  Tom Tromey  <tom@tromey.com>
3271
3272         * symmisc.c (print_symbol_bcache_statistics): Update.
3273         (print_objfile_statistics): Update.
3274         * symfile.c (reread_symbols): Update.
3275         * psymtab.h (class psymtab_storage): New.
3276         * psymtab.c (psymtab_storage): New constructor.
3277         (~psymtab_storage): New destructor.
3278         (require_partial_symbols): Update.
3279         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3280         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3281         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3282         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3283         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3284         (start_psymtab_common, end_psymtab_common)
3285         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3286         (allocate_psymtab): Update.
3287         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3288         Update.
3289         (dump_psymtab_addrmap, maintenance_print_psymbols)
3290         (maintenance_check_psymtabs): Update.
3291         (class objfile_psymtabs): Move to objfiles.h.
3292         * psympriv.h (discard_psymtab): Now inline.
3293         (psymtab_discarder::psymtab_discarder): Update.
3294         (psymtab_discarder::~psymtab_discarder): Update.
3295         (ALL_OBJFILE_PSYMTABS): Rewrite.
3296         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3297         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3298         Remove fields.
3299         <partial_symtabs>: New field.
3300         (class objfile_psymtabs): Move from psymtab.h.  Update.
3301         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3302         psymbol_cache.
3303         (objfile::~objfile): Don't destroy psymbol_cache.
3304         * mdebugread.c (parse_partial_symbols): Update.
3305         * dwarf2read.c (create_addrmap_from_index)
3306         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3307         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3308         (add_partial_subprogram, dwarf2_ranges_read): Update.
3309         * dwarf-index-write.c (write_address_map)
3310         (write_one_signatured_type, recursively_write_psymbols)
3311         (class debug_names, class debug_names, write_psymtabs_to_index):
3312         Update.
3313
3314 2019-01-10  Tom Tromey  <tom@tromey.com>
3315
3316         * symtab.h (SYMBOL_SET_NAMES): Update.
3317         (symbol_set_names): Update.
3318         (MSYMBOL_SET_NAMES): Update.
3319         * symtab.c (symbol_set_names): Change argument to be an
3320         objfile_per_bfd_storage.
3321         * psymtab.c (add_psymbol_to_bcache): Update.
3322         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3323
3324 2019-01-10  Tom Tromey  <tom@tromey.com>
3325
3326         * symtab.c (create_demangled_names_hash): Change argument to be an
3327         objfile_per_bfd_storage.
3328         (symbol_set_names): Update.
3329
3330 2019-01-10  Tom Tromey  <tom@tromey.com>
3331
3332         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3333         init_psymbol_list.
3334         * psymtab.c (init_psymbol_list): Do nothing if already called.
3335         * psympriv.h (init_psymbol_list): Add comment.
3336         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3337         init_psymbol_list.
3338         * dbxread.c (dbx_symfile_read): Unconditionally call
3339         init_psymbol_list.
3340
3341 2019-01-10  Tom Tromey  <tom@tromey.com>
3342
3343         * xcoffread.c (scan_xcoff_symtab): Update.
3344         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3345         "where".
3346         * mdebugread.c (parse_partial_symbols)
3347         (handle_psymbol_enumerators): Update.
3348         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3349         * dbxread.c (read_dbx_symtab): Update.
3350         * psympriv.h (psymbol_placement): New enum.
3351         (add_psymbol_to_list): Update.
3352
3353 2019-01-10  Tom Tromey  <tom@tromey.com>
3354
3355         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3356         static_psymbols parameters.
3357         (scan_xcoff_symtab): Update.
3358         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3359         static_psymbols parameters.
3360         * psympriv.h (start_psymtab_common): Update.
3361         * mdebugread.c (parse_partial_symbols): Update.
3362         * dwarf2read.c (create_partial_symtab): Update.
3363         * dbxread.c (read_dbx_symtab): Update.
3364         (start_psymtab): Remove global_psymbols and static_psymbols
3365         parameters.
3366
3367 2019-01-10  Tom Tromey  <tom@tromey.com>
3368
3369         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3370         * psymtab.c (allocate_psymtab): Add comment.
3371         * psympriv.h (allocate_psymtab): Add comment.
3372         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3373         initializations.
3374         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3375
3376 2019-01-10  Tom Tromey  <tom@tromey.com>
3377
3378         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3379         Don't declare.
3380         * mipsread.c: Include mdebugread.h.
3381         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3382         Declare.
3383         * elfread.c: Include mdebugread.h.
3384
3385 2019-01-09  Tom Tromey  <tom@tromey.com>
3386
3387         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3388         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3389         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3390         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3391         (psym_lookup_symbol, psym_find_last_source_symtab)
3392         (psym_forget_cached_source_info, psym_print_stats)
3393         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3394         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3395         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3396         (psym_find_compunit_symtab_by_address)
3397         (maintenance_print_psymbols, maintenance_info_psymtabs)
3398         (maintenance_check_psymtabs): Use ranged for.
3399         * psymtab.h (class objfile_psymtabs): New.
3400         (require_partial_symbols): Return objfile_psymtabs.
3401         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3402
3403 2019-01-09  Tom Tromey  <tom@tromey.com>
3404
3405         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3406         (find_pc_mapped_section, list_overlays_command)
3407         (map_overlay_command, unmap_overlay_command)
3408         (simple_overlay_update): Use all_objfiles.
3409         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3410         * printcmd.c (info_symbol_command): Use all_objfiles.
3411         * objfiles.h (ALL_OBJSECTIONS): Remove.
3412         * maint.c (maintenance_translate_address): Use all_objfiles.
3413         * gcore.c (gcore_create_callback): Use all_objfiles.
3414         (objfile_find_memory_regions): Likewise.
3415
3416 2019-01-09  Tom Tromey  <tom@tromey.com>
3417
3418         * symtab.c (find_line_symtab, info_sources_command)
3419         (make_source_files_completion_list): Use objfile_compunits.
3420         * source.c (select_source_symtab): Use objfile_compunits.
3421         * objfiles.h (struct objfile): Update comment.
3422         (ALL_OBJFILES): Remove.
3423         (ALL_FILETABS): Remove.
3424         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3425         objfile_compunits.
3426
3427 2019-01-09  Tom Tromey  <tom@tromey.com>
3428
3429         * symmisc.c (print_objfile_statistics, dump_objfile)
3430         (maintenance_print_symbols): Use compunit_filetabs.
3431         * source.c (forget_cached_source_info_for_objfile): Use
3432         compunit_filetabs.
3433         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3434         (ALL_FILETABS): Use compunit_filetabs.
3435         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3436         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3437
3438 2019-01-09  Tom Tromey  <tom@tromey.com>
3439
3440         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3441         (compunit_filetabs): New.
3442         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3443         compunit_filetabs.
3444         (info_sources_command, make_source_files_completion_list): Remove
3445         declaration.
3446         * symmisc.c (print_objfile_statistics, dump_objfile)
3447         (maintenance_print_symbols): Remove declaration.
3448         (maintenance_info_symtabs): Use compunit_filetabs.
3449         (maintenance_info_line_tables): Likewise.
3450         * source.c (select_source_symtab): Change local variable name.
3451         (forget_cached_source_info_for_objfile): Remove declaration.
3452         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3453         * objfiles.c (objfile_relocate1): Remove declaration.
3454         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3455         declaration.
3456         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3457         * coffread.c (coff_symtab_read): Remove declaration.
3458         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3459         compunit_filetabs.
3460
3461 2019-01-09  Tom Tromey  <tom@tromey.com>
3462
3463         * symtab.c (lookup_objfile_from_block)
3464         (find_pc_sect_compunit_symtab, search_symbols)
3465         (default_collect_symbol_completion_matches_break_on): Use
3466         objfile_compunits.
3467         * objfiles.h (ALL_COMPUNITS): Remove.
3468         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3469         * cp-support.c (add_symbol_overload_list_qualified): Use
3470         objfile_compunits.
3471         * ada-lang.c (ada_collect_symbol_completion_matches)
3472         (ada_add_global_exceptions): Use objfile_compunits.
3473
3474 2019-01-09  Tom Tromey  <tom@tromey.com>
3475
3476         * source.c (select_source_symtab)
3477         (forget_cached_source_info_for_objfile): Remove declaration.
3478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3479         declaration.
3480         * maint.c (count_symtabs_and_blocks): Remove declaration.
3481         * cp-support.c (add_symbol_overload_list_qualified): Remove
3482         declaration.
3483         * coffread.c (coff_symtab_read): Remove declaration.
3484         * symtab.c (lookup_symbol_in_objfile_symtabs)
3485         (basic_lookup_transparent_type_1): Use objfile_compunits.
3486         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3487         (info_sources_command, search_symbols)
3488         (default_collect_symbol_completion_matches_break_on)
3489         (make_source_files_completion_list): Remove declaration.
3490         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3491         (ada_collect_symbol_completion_matches)
3492         (ada_add_global_exceptions): Remove declaration.
3493         * linespec.c (iterate_over_all_matching_symtabs): Use
3494         objfile_compunits.
3495         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3496         (class objfile_compunits): New.
3497         (ALL_COMPUNITS): Use objfile_compunits.
3498         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3499         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3500         objfile_compunits.
3501         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3502
3503 2019-01-09  Tom Tromey  <tom@tromey.com>
3504
3505         * symtab.c (search_symbols)
3506         (default_collect_symbol_completion_matches_break_on): Use
3507         objfile_msymbols.
3508         * ada-lang.c (ada_lookup_simple_minsym)
3509         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3510         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3511         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3512         objfile_msymbols.
3513         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3514         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3515         * objc-lang.c (find_methods): Use objfile_msymbols.
3516         (info_selectors_command, info_classes_command): Likewise.
3517         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3518         * objfiles.h (class objfile_msymbols): New.
3519         (ALL_OBJFILE_MSYMBOLS): Remove.
3520         (ALL_MSYMBOLS): Remove.
3521
3522 2019-01-09  Tom Tromey  <tom@tromey.com>
3523
3524         * common/next-iterator.h (next_adapter): Add Iterator template
3525         parameter.
3526         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3527         (class all_objfiles_safe): New.
3528         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3529         * objfiles.c (put_objfile_before): Update comment.
3530         (add_separate_debug_objfile): Likewise.
3531         (free_all_objfiles): Use all_objfiles_safe.
3532         (objfile_purge_solibs): Likewise.
3533
3534 2019-01-09  Tom Tromey  <tom@tromey.com>
3535
3536         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3537         (expand_symtab_containing_pc, lookup_static_symbol)
3538         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3539         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3540         all_objfiles.
3541         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3542         * breakpoint.c (create_overlay_event_breakpoint)
3543         (create_longjmp_master_breakpoint)
3544         (create_std_terminate_master_breakpoint)
3545         (create_exception_master_breakpoint): Use all_objfiles.
3546         * linux-thread-db.c (try_thread_db_load_from_pdir)
3547         (has_libpthread): Use all_objfiles.
3548         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3549         * linespec.c (iterate_over_all_matching_symtabs)
3550         (search_minsyms_for_name): Use all_objfiles.
3551         * maint.c (maintenance_info_sections): Use all_objfiles.
3552         * main.c (captured_main_1): Use all_objfiles.
3553         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3554         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3555         * guile/scm-pretty-print.c
3556         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3557         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3558         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3559         (maintenance_print_msymbols): Use all_objfiles.
3560         * source.c (select_source_symtab): Use all_objfiles.
3561         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3562         * symfile.c (remove_symbol_file_command)
3563         (expand_symtabs_matching, map_symbol_filenames): Use
3564         all_objfiles.
3565         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3566         all_objfiles.
3567         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3568         * objc-lang.c (find_methods): Use all_objfiles.
3569         * objfiles.c (have_partial_symbols, have_full_symbols)
3570         (have_minimal_symbols, qsort_cmp)
3571         (default_iterate_over_objfiles_in_search_order): Use
3572         all_objfiles.
3573         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3574         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3575         (maintenance_check_psymtabs): Use all_objfiles.
3576         (ALL_PSYMTABS): Remove.
3577         * compile/compile-object-run.c (do_module_cleanup): Use
3578         all_objfiles.
3579         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3580         * cp-support.c (add_symbol_overload_list_qualified): Use
3581         all_objfiles.
3582         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3583         Use all_objfiles.
3584         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3585         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3586         all_objfiles.
3587         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3588         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3589         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3590         Uses all_objfiles.
3591         * solib.c (solib_read_symbols): Use all_objfiles
3592
3593 2019-01-09  Tom Tromey  <tom@tromey.com>
3594
3595         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3596         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3597         all_objfiles.
3598         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3599         * symmisc.c (print_symbol_bcache_statistics)
3600         (print_objfile_statistics, maintenance_print_objfiles)
3601         (maintenance_info_symtabs, maintenance_check_symtabs)
3602         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3603         all_objfiles.
3604         * source.c (forget_cached_source_info): Use all_objfiles.
3605         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3606         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3607         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3608         * objfiles.c (update_section_map): Use all_objfiles.
3609         (shared_objfile_contains_address_p): Likewise.
3610         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3611         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3612
3613 2019-01-09  Tom Tromey  <tom@tromey.com>
3614
3615         * common/next-iterator.h: New file.
3616         * objfiles.h (class all_objfiles): New.
3617         (struct objfile_iterator): New.
3618
3619 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3620
3621         * NEWS: Move the description of the changed "frame", "select-frame",
3622          and "info frame" commands to the Changed commands section.
3623
3624 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3625
3626         * gdbtypes.c (check_stub_method_group): Remove handling of old
3627         mangling schemes.
3628         * linespec.c (find_methods): Likewise.
3629         * stabsread.c (read_member_functions): Likewise.
3630         * valops.c (search_struct_method): Likewise.
3631         (value_struct_elt_for_reference): Likewise.
3632         * NEWS: Mention this change.
3633
3634 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3637         print_source_lines.
3638         * source.c (print_source_lines_base): Update line number check.
3639         (print_source_lines): New function.
3640         (source_lines_range::source_lines_range): New function.
3641         * source.h (class source_lines_range): New class.
3642         (print_source_lines): New declaration.
3643
3644 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3645
3646         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3647
3648 2019-01-08  Tom Tromey  <tom@tromey.com>
3649             Simon Marchi  <simon.marchi@ericsson.com>
3650
3651         PR gdb/24060
3652         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3653         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3654         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3655         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3656         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3657         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3658
3659 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3660
3661         * source.c (select_source_symtab): Move header comment to
3662         declaration in source.h.
3663         (forget_cached_source_info_for_objfile): Likewise.
3664         (forget_cached_source_info): Likewise.
3665         (identify_source_line): Likewise.
3666         * source.h (identify_source_line): Move declaration from symtab.h
3667         and add comment from source.c
3668         (print_source_lines): Likewise.
3669         (forget_cached_source_info_for_objfile): Likewise.
3670         (forget_cached_source_info): Likewise.
3671         (select_source_symtab): Likewise.
3672         (enum print_source_lines_flag): Move definition from symtab.h.
3673         * symtab.h (identify_source_line): Move declaration to source.h.
3674         (print_source_lines): Likewise.
3675         (forget_cached_source_info_for_objfile): Likewise.
3676         (forget_cached_source_info): Likewise.
3677         (select_source_symtab): Likewise.
3678         (enum print_source_lines_flag): Move definition to source.h.
3679         * tui/tui-hooks.c: Add 'source.h' include.
3680
3681 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * source.c (print_source_lines_base): Handle requests to print
3684         reverse line number sequences, and guard against empty lines
3685         string.
3686
3687 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3688
3689         * source.c (print_source_lines_base): Fix skip of '\r' if next
3690         character is '\n'.
3691
3692 2019-01-06  Tom Tromey  <tom@tromey.com>
3693
3694         * c-exp.y (struct c_parse_state) <macro_original_text,
3695         expansion_obstack>: New member.
3696         (macro_original_text, expansion_obstack): Remove globals.
3697         (scan_macro_expansion, scanning_macro_expansion)
3698         (finished_macro_expansion): Update.
3699         (scan_macro_cleanup): Remove.
3700         (yylex, c_parse): Update.
3701
3702 2019-01-06  Tom Tromey  <tom@tromey.com>
3703
3704         * c-exp.y (struct c_parse_state) <strings>: New member.
3705         (operator_stoken): Update.
3706
3707 2019-01-06  Tom Tromey  <tom@tromey.com>
3708
3709         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3710         (union type_stack_elt) <typelist_val>: Now a pointer to
3711         std::vector.
3712         (type_stack_cleanup): Don't declare.
3713         (push_typelist): Update.
3714         * parse.c (pop_typelist): Return a std::vector.
3715         (push_typelist): Take a std::vector.
3716         (follow_types): Update.  Do not free args.
3717         (type_stack_cleanup): Remove.
3718         * c-exp.y (struct c_parse_state): New.
3719         (cpstate): New global.
3720         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3721         (nonempty_typelist): Update.
3722         (func_mod): Create a new vector.
3723         (c_parse): Create a c_parse_state.
3724         (check_parameter_typelist): Do not delete params.
3725         (function_method): Update.  Do not delete type_list.
3726
3727 2019-01-06  Tom Tromey  <tom@tromey.com>
3728
3729         PR gdb/28155:
3730         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3731         check_typedef.
3732         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3733         (print_return_value): Likewise.
3734
3735 2019-01-05  Tom Tromey  <tom@tromey.com>
3736
3737         * contrib/cleanup_check.py: Remove.
3738         * contrib/gcc-with-excheck: Remove.
3739         * contrib/exsummary.py: Remove.
3740         * contrib/excheck.py: Remove.
3741
3742 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3743
3744         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3745         NULL. Initialize tpprev to NULL instead of assigning it
3746         to NULL on the next statement.
3747         * windows-nat.c (windows_delete_thread): Remove check for
3748         main_thread_id before printing thread exit notifications.
3749         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3750         Remove thread ID check against main_thread_id.
3751         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3752         windows_delete_thread.
3753         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3754
3755 2019-01-04  Tom Tromey  <tom@tromey.com>
3756
3757         * compile/compile.c (_initialize_compile): Use upper case for
3758         metasyntactic variables.
3759         * symmisc.c (_initialize_symmisc): Use upper case for
3760         metasyntactic variables.
3761         * psymtab.c (_initialize_psymtab): Use upper case for
3762         metasyntactic variables.
3763         * demangle.c (demangle_command): Use upper case for metasyntactic
3764         variables.
3765         (_initialize_demangler): Likewise.
3766         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3767         variables.
3768
3769 2019-01-03  Tom Tromey  <tom@tromey.com>
3770
3771         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3772
3773 2019-01-03  Tom Tromey  <tom@tromey.com>
3774
3775         * python/py-symtab.c (salpy_str): Update.
3776         (struct salpy_sal_object) <symtab>: Now a PyObject.
3777         (salpy_dealloc): Update.
3778         (del_objfile_sal): Use gdbpy_ref.
3779
3780 2019-01-03  Tom Tromey  <tom@tromey.com>
3781
3782         * python/py-type.c (convert_field): Use new_reference.  Return
3783         gdbpy_ref.
3784         (make_fielditem): Return gdbpy_ref.
3785         (typy_fields): Update.
3786         (typy_getitem): Update.
3787         (field_name): Return gdbpy_ref.  Use new_reference.
3788         (typy_iterator_iternext): Update.
3789
3790 2019-01-03  Tom Tromey  <tom@tromey.com>
3791
3792         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3793
3794 2019-01-03  Tom Tromey  <tom@tromey.com>
3795
3796         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3797         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3798         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3799         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3800         (pspy_set_type_printers): Likewise.
3801         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3802         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3803         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3804         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3805         (objfpy_set_type_printers): Likewise.
3806
3807 2019-01-03  Tom Tromey  <tom@tromey.com>
3808
3809         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3810         (gdbpy_print_stack): Use gdbpy_err_fetch.
3811         * python/python-internal.h (class gdbpy_err_fetch): New class.
3812         (class gdbpy_enter) <m_error_type, m_error_value,
3813         m_error_traceback>: Remove.
3814         <m_error>: New member.
3815         (gdbpy_exception_to_string): Don't declare.
3816         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3817         * python/py-value.c (convert_value_from_python): Use
3818         gdbpy_err_fetch.
3819         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3820         gdbpy_exception_to_string.
3821         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3822         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3823         gdbpy_err_fetch.
3824
3825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * linux-nat.c (delete_lwp_cleanup): Delete.
3828         (struct lwp_deleter): New struct.
3829         (lwp_info_up): New typedef.
3830         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3831         lwp_info_up.
3832
3833 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3834
3835         * linux-fork.c (class scoped_switch_fork_info): New class.
3836         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3837
3838 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * valops.c (find_overload_match): Remove use of null_cleanup, and
3841         calls to do_cleanups.
3842
3843 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * compile/compile-cplus-types.c
3846         (compile_cplus_instance::decl_name): Handle changes to
3847         cp_func_name.
3848         * cp-support.c (cp_func_name): Update header comment, update
3849         return type.
3850         * cp-support.h (cp_func_name): Update return type in declaration.
3851         * valops.c (find_overload_match): Move temp_func local to top
3852         level of function and change its type.  Use temp_func to hold and
3853         delete temporary string obtained from cp_func_name.
3854
3855 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3858         gdb::char_vector, remove cleanup, and update uses of `msg`.
3859
3860 2019-01-03  Jim Wilson  <jimw@sifive.com>
3861
3862         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3863
3864 2019-01-02  Tom Tromey  <tom@tromey.com>
3865
3866         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3867         (tdesc_parse_xml): Remove cleanups.
3868         * target-descriptions.h (make_cleanup_free_target_description):
3869         Don't declare.
3870         (target_desc_deleter): New struct.
3871         (target_desc_up): New typedef.
3872         * target-descriptions.c (target_desc_deleter::operator()): Rename
3873         from free_target_description.
3874         (make_cleanup_free_target_description): Remove.
3875
3876 2019-01-02  Tom Tromey  <tom@tromey.com>
3877
3878         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3879         constructor, destructor.
3880         (linespec_parser): Remove typedef.
3881         (~linespec_parser): Rename from linespec_parser_delete.
3882         (linespec_lex_to_end, linespec_complete_label)
3883         (linespec_complete): Update.
3884         (decode_line_full): Remove cleanups.
3885         (decode_line_1): Update.
3886
3887 2019-01-02  Tom Tromey  <tom@tromey.com>
3888
3889         * python/python-internal.h (inferior_to_inferior_object): Change
3890         return type.
3891         * python/py-exitedevent.c (create_exited_event_object): Update.
3892         * python/py-inferior.c (inferior_to_inferior_object): Return
3893         gdbpy_ref.
3894         (python_new_inferior, python_inferior_deleted)
3895         (thread_to_thread_object, delete_thread_object)
3896         (build_inferior_list, gdbpy_selected_inferior): Update.
3897         * python/py-infthread.c (create_thread_object): Update.  Also fail
3898         if inferior_to_inferior_object fails.
3899
3900 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3901
3902         * inferior.h (class inferior) <displaced_step_state>: New field.
3903         * infrun.h (struct displaced_step_state): Move here from
3904         infrun.c.  Initialize fields, add constructor.
3905         <inf>: Remove field.
3906         <reset>: New method.
3907         * infrun.c (struct displaced_step_inferior_state): Move to
3908         infrun.h.
3909         (displaced_step_inferior_states): Remove.
3910         (get_displaced_stepping_state): Adust.
3911         (displaced_step_in_progress_any_inferior): Adjust.
3912         (displaced_step_in_progress_thread): Adjust.
3913         (displaced_step_in_progress): Adjust.
3914         (add_displaced_stepping_state): Remove.
3915         (get_displaced_step_closure_by_addr): Adjust.
3916         (remove_displaced_stepping_state): Remove.
3917         (infrun_inferior_exit): Call displaced_step_state.reset.
3918         (use_displaced_stepping): Don't check for NULL.
3919         (displaced_step_prepare_throw): Call
3920         get_displaced_stepping_state.
3921         (displaced_step_fixup): Don't check for NULL.
3922         (prepare_for_detach): Don't check for NULL.
3923
3924 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3925
3926         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3927          in case of call that did not complete.
3928
3929 2019-01-02  Andrey Utkin  <autkin@undo.io>
3930
3931         * symfile.c (find_separate_debug_file): Fix search of debug files for
3932         remote debuggee.
3933
3934 2019-01-02  Tom Tromey  <tom@tromey.com>
3935
3936         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3937         indentation.
3938         * python/py-frame.c (frapy_older): Remove cast.
3939         (frapy_newer): Likewise.
3940         * python/py-breakpoint.c (local_setattro): Remove cast.
3941         * python/py-arch.c (archpy_name): Remove local variable.
3942         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3943
3944 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3945
3946         * unittests/basic_string_view/element_access/char/empty.cc:
3947         Fix year range in copyright header.
3948
3949 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3950
3951         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3952         Delete.
3953         <operator==>: Update with for removed field.
3954         <hash>: Likewise.
3955         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3956         <isa_features>: ...this.
3957         <abi_features>: New field.
3958         (riscv_isa_flen): Update comment.
3959         (riscv_abi_xlen): New declaration.
3960         (riscv_abi_flen): New declaration.
3961         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3962         isa_features.
3963         (riscv_abi_xlen): New function.
3964         (riscv_isa_flen): Update to get answer from isa_features.
3965         (riscv_abi_flen): New function.
3966         (riscv_has_fp_abi): Update to get answer from abi_features.
3967         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3968         xlen and flen.
3969         (riscv_call_info) <xlen, flen>: Update comment.
3970         (riscv_call_arg_struct): Remove invalid assertions
3971         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3972         is removed.
3973         (riscv_gdbarch_init): Gather isa features and abi features
3974         separately, ensure both match on the gdbarch when reusing an old
3975         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3976         a target with 64-bit float hardware.
3977
3978 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3979
3980         * source.c (search_command_helper): Stop reverse search
3981         when line 1 has been searched.
3982
3983 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3984
3985         * record-full.c (record_full_base_target::close): Rewrite
3986         record_full_core_buf_list free logic.
3987
3988 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3989
3990         * break-catch-syscall.c (print_one_catch_syscall): xfree
3991         the last text.
3992
3993 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3994
3995         * top.c (print_gdb_version): Update Copyright year in version
3996         message.
3997
3998 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3999
4000         Update copyright year range in all GDB files.
4001
4002 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4003
4004         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4005
4006 For older changes see ChangeLog-2018.
4007 \f
4008 Local Variables:
4009 mode: change-log
4010 left-margin: 8
4011 fill-column: 74
4012 version-control: never
4013 coding: utf-8
4014 End:
4015