gdb/ChangeLog

   1 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
   4         gdb_bfd_ref_ptr.
   5         <~dwo_file>: Remove call to gdb_bfd_unref.
   6         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
   7         gdb_bfd_ref_ptr::get.
   8
   9 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  10
  11         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  12         type to htab_up.
  13         * dwarf2read.c (struct dwo_file): Initialize fields.
  14         <~dwo_file>: New.
  15         (free_dwo_file): Remove, move content to ~dwo_file.
  16         (struct dwo_file_deleter): Remove.
  17         (dwo_file_up>: Remove custom deleter.
  18         (free_dwo_files): Remove.
  19         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  20         dwo_files.
  21         (process_skeletonless_type_units): Call unique_ptr::get.
  22         (allocate_dwo_file_hash_table): Add deleter to created hash
  23         table.  Change return type to htab_up.
  24         (lookup_dwo_file_slot): Don't memset dwo_file, call
  25         unique_ptr::get.
  26         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  27         (create_dwo_unit_in_dwp_v2): Likewise.
  28         (open_and_init_dwo_file): Likewise.
  29         (free_dwo_file_from_slot): Remove.
  30
  31 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  32
  33         * dwarf2read.h (struct dwarf2_section_info) <readin,
  34         is_virtual>: Change type to bool.
  35         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  36         true instead of 1.
  37
  38 2019-06-19  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-data.h (tui_init_content_element): Don't declare.
  41
  42 2019-06-19  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-data.h (tui_init_win_info): Don't declare.
  45
  46 2019-06-19  Tom de Vries  <tdevries@suse.de>
  47
  48         * dwarf2read.h (abstract_to_concrete): Change type to
  49         std::unordered_map<sect_offset, std::vector<sect_offset>,
  50         gdb::hash_enum<sect_offset>>.
  51
  52 2019-06-19  Tom Tromey  <tromey@adacore.com>
  53
  54         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  55         EVAL_AVOID_SIDE_EFFECTS specially.
  56
  57 2019-06-19  Tom Tromey  <tromey@adacore.com>
  58
  59         * source-cache.c (highlighter): New global.
  60         (source_cache::get_source_lines): Create a highlighter on demand.
  61
  62 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  63
  64         * defs.h (deprecated_interactive_hook): Delete declaration.
  65         * interps.c (clear_interpreter_hooks): Remove use of
  66         deprecated_interactive_hook.
  67         * top.c (deprecated_interactive_hook): Delete definition.
  68         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  69
  70 2019-06-18  Tom de Vries  <tdevries@suse.de>
  71
  72         PR gdb/24515
  73         * dwarf2read.h (abstract_to_concrete): Change type from
  74         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  75         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  76         * dwarf2read.c (read_variable): Update.
  77         (dwarf2_fetch_die_loc_sect_off): Update.
  78
  79 2019-06-17  Tom de Vries  <tdevries@suse.de>
  80
  81         PR gdb/24617
  82         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  83         accessing parent[parent_len - 1].
  84
  85 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  86
  87         PR gdb/24364
  88         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  89         call dtrace_process_dof with NULL dof.
  90
  91 2019-06-16  Tom de Vries  <tdevries@suse.de>
  92
  93         PR gdb/24445
  94         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  95
  96 2019-06-16  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  99         (make_all_visible): Use address of member.
 100
 101 2019-06-16  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 104         (tui_free_window, free_content, free_content_elements): Remove
 105         unnecessary cast.
 106         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 107         cast.
 108         * tui/tui-regs.c (tui_show_register_group)
 109         (tui_display_registers_from, tui_display_reg_element_at_line):
 110         Remove unnecessary cast.
 111
 112 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 113
 114         * linux-nat.c (normal_mask): Delete.
 115         (_initialize_linux_nat): Don't initialise normal_mask.
 116
 117 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 118
 119         PR gdb/24445
 120         * dwarf-index-write.h (write_psymtabs_to_index): Add
 121         dwz_basename parameter.
 122         * dwarf-index-write.c (write_gdbindex): Move file writing to
 123         write_gdbindex_1.  Change return type void.
 124         (assert_file_size): Move up, remove filename parameter.
 125         (write_gdbindex_1): New function.
 126         (write_debug_names): Change return type to void, call
 127         assert_file_size.
 128         (struct index_wip_file): New struct.
 129         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 130         file logic to index_wip_file.  Write index for dwz file if
 131         needed.
 132         (save_gdb_index_command): Pass basename of dwz file, if present.
 133         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 134         build-id of dwz file, if present.
 135         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 136         (dwarf2_get_dwz_file): Likewise.
 137         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 138         (dwarf2_get_dwz_file): Likewise.
 139
 140 2019-06-16  Tom Tromey  <tom@tromey.com>
 141
 142         * coffread.c (process_coff_symbol): Use xstrdup.
 143         * value.c (create_internalvar): Use xstrdup.
 144
 145 2019-06-16  Tom Tromey  <tom@tromey.com>
 146
 147         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 148         * breakpoint.c (stopin_command, stopat_command)
 149         (until_break_command, decode_location_default): Remove unnecessary
 150         cast.
 151         * utils.c (subset_compare): Remove unnecessary cast.
 152         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 153         cast.
 154         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 155         cast.
 156         * infcmd.c (path_command): Remove unnecessary cast.
 157         * coffread.c (decode_type): Remove unnecessary cast.
 158         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 159         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 160         * tui/tui-stack.c (tui_show_locator_content)
 161         (tui_show_frame_info): Remove unnecessary cast.
 162         * tui/tui-win.c (tui_scroll_forward_command)
 163         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 164         (parse_scrolling_args): Remove unnecessary cast.
 165         * tui/tui-data.c (init_win_info, tui_del_window)
 166         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 167         (free_content_elements): Remove unnecessary cast.
 168         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 169         unnecessary cast.
 170         * tui/tui-source.c (tui_set_source_content)
 171         (tui_vertical_source_scroll): Remove unnecessary cast.
 172         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 173         cast.
 174         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 175         * tui/tui-regs.c (tui_display_registers_from)
 176         (tui_display_register): Remove unnecessary cast.
 177         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 178         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 179         (make_visible): Remove unnecessary cast.
 180         * tui/tui-winsource.c (tui_erase_source_content)
 181         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 182         unnecessary cast.
 183         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 184         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 185         * stabsread.c (read_type, read_array_type, read_range_type):
 186         Remove unnecessary cast.
 187         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 188         (parse_symbol, parse_type, upgrade_type, parse_external)
 189         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 190         unnecessary cast.
 191         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 192
 193 2019-06-16  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-data.c (tui_alloc_generic_win_info)
 196         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 197         checks.
 198
 199 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 200             Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * f-typeprint.c (f_print_type): Don't return early for not
 203         associated or not allocated types.
 204         (f_type_print_varspec_suffix): Add print_rank parameter and print
 205         ranks of array types in case they dangling.
 206         (f_type_print_base): Add print_rank parameter.
 207
 208 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 209
 210         * NEWS: Mention new MI commands.
 211         * break-catch-throw.c (enum exception_event_kind): Move to
 212         breakpoint.h.
 213         (print_mention_exception_catchpoint): Output text as a single
 214         message.
 215         (catch_exception_command_1): Rename to...
 216         (catch_exception_event): ...this, make non-static, update header
 217         command, and change some parameter types.
 218         (catch_catch_command): Update for changes to
 219         catch_exception_command_1.
 220         (catch_throw_command): Likewise.
 221         (catch_rethrow_command): Likewise.
 222         * breakpoint.c (enum exception_event_kind): Delete.
 223         * breakpoint.h (enum exception_event_kind): Moved here from
 224         break-catch-throw.c.
 225         (catch_exception_event): Declare.
 226         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 227         (mi_cmd_catch_throw): New function.
 228         (mi_cmd_catch_rethrow): New function.
 229         (mi_cmd_catch_catch): New function.
 230         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 231         'catch-catch' entries.
 232         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 233         (mi_cmd_catch_rethrow): Declare.
 234         (mi_cmd_catch_catch): Declare.
 235
 236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * annotate.c (annotate_source_line): Change return type to void,
 239         update implementation to match.
 240         * annotate.h (annotate_source_line): Change return type to void,
 241         update header comment.
 242         * stack.c (print_frame_info): Don't change what frame information
 243         is printed based on whether annotations are on or not.
 244
 245 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 246
 247         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 248         (annotate_source): Make static.
 249         (annotate_source_line): Moved from source.c and renamed from
 250         identify_source_line.  Update the return type.
 251         * annotate.h (annotate_source): Delete declaration.
 252         (annotate_source_line): Declaration moved from source.h, and
 253         renamed from identify_source_line.  Return type updated.
 254         * source.c (identify_source_line): Moved to annotate.c and renamed
 255         to annotate_source_line.
 256         (info_line_command): Remove check of annotation_level.
 257         * source.h (identify_source_line): Move declaration to annotate.h
 258         and rename to annotate_source_line.
 259         * stack.c: Add 'annotate.h' include.
 260         (print_frame_info): Remove check of annotation_level before
 261         calling annotate_source_line.
 262
 263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * source-cache.c (source_cache::get_plain_source_lines): Use
 266         open_source_file_with_line_charpos instead of just
 267         open_source_file, remove call to find_source_lines.
 268         (source_cache::get_source_lines): Likewise.
 269         * source.c (find_source_lines): Make static.
 270         (get_filename_and_charpos): Renamed into...
 271         (open_source_file_with_line_charpos): ..this along with changes to
 272         return a scoped_fd, and some other minor clean ups.
 273         (identify_source_line): Use open_source_file_with_line_charpos.
 274         (search_command_helper): Use open_source_file_with_line_charpos
 275         instead of just open_source_file, remove call to
 276         find_source_lines.
 277         * source.h (open_source_file_with_line_charpos): Declare new
 278         function.
 279         (find_source_lines): Delete declaration.
 280
 281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * source.c (get_filename_and_charpos): Remove fullname
 284         parameter.
 285         (identify_source_line): Update call to get_filename_and_charpos.
 286
 287 2019-06-14  Tom Tromey  <tromey@adacore.com>
 288
 289         PR gdb/24502:
 290         * ui-style.h (skip_ansi_escape): Update comment.
 291         * ui-file.h (class no_terminal_escape_file): New class.
 292         * ui-file.c (no_terminal_escape_file::write)
 293         (no_terminal_escape_file::puts): New methods.
 294         * cli/cli-logging.c (handle_redirections): Use
 295         no_terminal_escape_file.
 296
 297 2019-06-14  Tom Tromey  <tromey@adacore.com>
 298
 299         * NEWS: Move convenience variable news above Python news.
 300
 301 2019-06-14  Tom Tromey  <tom@tromey.com>
 302
 303         * gnulib: Move directory to top-level.
 304         * configure.ac: Don't configure gnulib.
 305         * configure: Rebuild.
 306         * common/common-defs.h: Use new path to gnulib.
 307         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 308         (GNULIB_H): Remove.
 309         (INCGNU): Look in new gnulib location.
 310         (HFILES_NO_SRCDIR): Remove gnulib files.
 311         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 312         (generated_files): Remove GNULIB_H.
 313         ($(LIBGNU), all-lib): Remove targets.
 314         (distclean): Don't mention GNULIB_BUILDDIR.
 315         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 316
 317 2019-06-14  Tom Tromey  <tromey@adacore.com>
 318
 319         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 320         Warn if symbol file does not provide any symbols.
 321
 322 2019-06-14  Tom Tromey  <tromey@adacore.com>
 323
 324         * source.c (find_and_open_source): Respect basenames_may_differ.
 325
 326 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * annotate.c (annotate_breakpoints_invalid): Make use of
 329         scoped_restore_terminal_state.
 330         (annotate_frames_invalid): Likewise.
 331
 332 2019-06-14  Tom Tromey  <tromey@adacore.com>
 333
 334         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 335         allow assignment to an internalvar.
 336
 337 2019-06-14  Tom Tromey  <tromey@adacore.com>
 338
 339         * ada-lex.l: Allow "_" in attribute names.
 340
 341 2019-06-14  Tom Tromey  <tromey@adacore.com>
 342
 343         PR gdb/24653:
 344         * regcache.c (registers_changed): Don't call alloca.
 345         * top.c (execute_command): Don't call alloca.
 346
 347 2019-06-13  Pedro Alves  <palves@redhat.com>
 348
 349         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 350         'expression'.  When parsing an expression, error out if there's
 351         junk after "unlimited".
 352         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 353         (do_set_command): Adjust calls to is_unlimited_literal.
 354
 355 2019-06-13  Pedro Alves  <palves@redhat.com>
 356
 357         * compile/compile.c (make_compile_options_def_group): Add braces
 358         around array_view initializer.
 359         * thread.c (make_thread_apply_all_options_def_group)
 360         (make_thread_apply_all_options_def_group): Likewise.
 361
 362 2019-06-13  Pedro Alves  <palves@redhat.com>
 363
 364         * NEWS (New commands): Mention "maint test-options
 365         require-delimiter", "maint test-options unknown-is-error", "maint
 366         test-options unknown-is-operand" and "maint show
 367         test-options-completion-result".
 368         (New command options, command completion): New section.
 369         (Completion improvements): New section.
 370         Mention that you can abbreviate "unlimited".
 371
 372 2019-06-13  Pedro Alves  <palves@redhat.com>
 373
 374         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 375         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 376         * unittests/cli-utils-selftests.c (test_parse_flags)
 377         (test_parse_flags_qcs): Delete.
 378         (test_cli_utils): Don't call deleted functions.
 379
 380 2019-06-13  Pedro Alves  <palves@redhat.com>
 381
 382         * thread.c: Include "cli/cli-option.h".
 383         (tp_array_compar_ascending): Global.
 384         (tp_array_compar): Delete function.
 385         (tp_array_compar_ascending, tp_array_compar_descending): New
 386         functions.
 387         (ascending_option_def, qcs_flag_option_def)
 388         (thr_qcs_flags_option_defs)
 389         (make_thread_apply_all_options_def_group)
 390         (make_thread_apply_options_def_group): New.
 391         (thread_apply_all_command): Use gdb::option::process_options.
 392         (thread_apply_command_completer)
 393         (thread_apply_all_command_completer): New.
 394         (thread_apply_command): Use gdb::option::process_options.
 395         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 396         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 397         to generate help text of "thread apply".  Adjust "taas"'s help.
 398         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 399         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 400
 401 2019-06-13  Pedro Alves  <palves@redhat.com>
 402
 403         * thread.c (thread_apply_command): Check for invalid TID with
 404         isdigit instead of !isalpha.
 405
 406 2019-06-13  Pedro Alves  <palves@redhat.com>
 407
 408         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 409         (validate_flags_qcs): New.
 410         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 411         (validate_flags_qcs): Declare.
 412         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 413         (make_frame_apply_options_def_group): New.
 414         (frame_apply_command_count): Process options with
 415         gdb::option::process_options.
 416         (frame_apply_completer): New.
 417         (frame_apply_level_completer, frame_apply_all_completer)
 418         (frame_apply_completer): New.
 419         (_initialize_stack): Update help of "frame apply", "frame apply
 420         level", "frame apply all" and "faas" to mention supported options
 421         and install command completers.
 422         * stack.h (frame_apply_all_completer): Declare.
 423         * thread.c: Include "stack.h".
 424         (tfaas_command): Add "--".
 425         (_initialize_thread): Update help "tfaas" to mention supported
 426         options and install command completer.
 427
 428 2019-06-13  Pedro Alves  <palves@redhat.com>
 429
 430         * completer.c (complete_nested_command_line): New.
 431         (gdb_completion_word_break_characters_throw): Add assertion.
 432         * completer.h (complete_nested_command_line): Declare.
 433
 434 2019-06-13  Pedro Alves  <palves@redhat.com>
 435
 436         * stack.c (parse_backtrace_qualifiers): New.
 437         (backtrace_command): Use it.
 438         (backtrace_command_completer): Complete on qualifiers.
 439
 440 2019-06-13  Pedro Alves  <palves@redhat.com>
 441
 442         * frame.c: Include "cli/cli-option.h.
 443         (user_set_backtrace_options): New.
 444         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 445         Delete.
 446         (get_prev_frame): Adjust.
 447         (boolean_option_def, uinteger_option_def)
 448         (set_backtrace_option_defs): New.
 449         (_initialize_frame): Adjust and use
 450         gdb::option::add_setshow_cmds_for_options to install "set
 451         backtrace past-main" and "set backtrace past-entry".
 452         * frame.h: Include "cli/cli-option.h".
 453         (struct frame_print_options): Forward declare.
 454         (print_frame_arguments_all, print_frame_arguments_scalars)
 455         (print_frame_arguments_none): Declare.
 456         (print_entry_values): Delete declaration.
 457         (struct frame_print_options, user_frame_print_options): New.
 458         (struct set_backtrace_options): New.
 459         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 460         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 461         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 462         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 463         (list_args_or_locals): Add frame_print_options parameter.
 464         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 465         * python/py-framefilter.c (enumerate_args): Pass down
 466         USER_FRAME_PRINT_OPTIONS.
 467         * stack.c: Include "cli/cli-option.h".
 468         (print_frame_arguments_all, print_frame_arguments_scalars)
 469         (print_frame_arguments_none): Declare.
 470         (print_raw_frame_arguments, print_entry_values): Delete.
 471         (user_frame_print_options): New.
 472         (boolean_option_def, enum_option_def, frame_print_option_defs):
 473         New.
 474         (struct backtrace_cmd_options): New.
 475         (bt_flag_option_def): New.
 476         (backtrace_command_option_defs): New.
 477         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 478         (print_frame_arg, read_frame_arg, print_frame_args)
 479         (print_frame_info, print_frame): Add frame_print_options parameter
 480         and use it.
 481         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 482         (backtrace_command_1): Add frame_print_options and
 483         backtrace_cmd_options parameters and use them.
 484         (make_backtrace_options_def_group): New.
 485         (backtrace_command): Process command options with
 486         gdb::option::process_options.
 487         (backtrace_command_completer): New.
 488         (_initialize_stack): Extend "backtrace"'s help to mention
 489         supported options.  Install completer for "backtrace".
 490         Install some settings commands with add_setshow_cmds_for_options.
 491
 492 2019-06-13  Pedro Alves  <palves@redhat.com>
 493
 494         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 495         and that "set/show print raw frame-arguments" are now deprecated.
 496
 497         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 498         command.
 499         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 500         * stack.c (_initialize_stack): Install "set/show print
 501         raw-frame-arguments", and deprecate "set/show print raw
 502         frame-arguments".
 503         * valprint.c (_initialize_valprint): Deprecate "set/show print
 504         raw".
 505
 506 2019-06-13  Pedro Alves  <palves@redhat.com>
 507
 508         * compile/compile.c (struct compile_options): New.
 509         (compile_flag_option_def, compile_command_option_defs)
 510         (make_compile_options_def_group): New.
 511         (compile_file_command): Handle options with
 512         gdb::option::process_options.
 513         (compile_file_command_completer): New function.
 514         (compile_code_command): Handle options with
 515         gdb::option::process_options.
 516         (compile_code_command_completer): New function.
 517         (_initialize_compiler): Install completers for "compile code" and
 518         "compile file".  Mention available options in "compile code" and
 519         "compile code"'s help.
 520         * completer.c (advance_to_completion_word): New, factored out from
 521         ...
 522         (advance_to_expression_complete_word_point): ... this.
 523         (advance_to_filename_complete_word_point): New.
 524         * completer.h (advance_to_filename_complete_word_point): New
 525         declaration.
 526
 527 2019-06-13  Pedro Alves  <palves@redhat.com>
 528
 529         * compile/compile.c: Include "cli/cli-option.h".
 530         (compile_print_value): Scope data pointer is now a
 531         value_print_options pointer; adjust.
 532         (compile_print_command): Process options.  Scope data pointer is
 533         now a value_print_options pointer; adjust.
 534         (_initialize_compile): Update "compile print"'s help to include
 535         supported options.  Install a completer for "compile print".
 536         * cp-valprint.c (show_vtblprint, show_objectprint)
 537         (show_static_field_print): Delete.
 538         (_initialize_cp_valprint): Don't install "set print
 539         static-members", "set print vtbl", "set print object" here.
 540         * printcmd.c: Include "cli/cli-option.h" and
 541         "common/gdb_optional.h".
 542         (print_command_parse_format): Rework to fill in a
 543         value_print_options instead of a format_data.
 544         (print_value): Change parameter type from format_data pointer to
 545         value_print_options reference.  Adjust.
 546         (print_command_1): Process options.  Adjust to pass down a
 547         value_print_options.
 548         (print_command_completer): New.
 549         (_initialize_printcmd): Install print_command_completer as
 550         handle_brkchars completer for the "print" command.  Update
 551         "print"'s help to include supported options.
 552         * valprint.c: Include "cli/cli-option.h".
 553         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 554         here from cp-valprint.c.
 555         (boolean_option_def, uinteger_option_def)
 556         (value_print_option_defs, make_value_print_options_def_group):
 557         New.  Use gdb::option::add_setshow_cmds_for_options to install
 558         "set print elements", "set print null-stop", "set print repeats",
 559         "set print pretty", "set print union", "set print array", "set
 560         print address", "set print symbol", "set print array-indexes".
 561         * valprint.h: Include <string> and "cli/cli-option.h".
 562         (make_value_print_options_def_group): Declare.
 563         (print_value): Change parameter type from format_data pointer to
 564         value_print_options reference.
 565         (print_command_completer): Declare.
 566
 567 2019-06-13  Pedro Alves  <palves@redhat.com>
 568
 569         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 570         (COMMON_SFILES): Add maint-test-settings.c.
 571         * cli/cli-decode.c (boolean_enums): New global, factored out from
 572         ...
 573         (add_setshow_boolean_cmd): ... here.
 574         * cli/cli-decode.h (boolean_enums): Declare.
 575         * cli/cli-option.c: New file.
 576         * cli/cli-option.h: New file.
 577         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 578         factored out from ...
 579         (parse_cli_boolean_value(const char *)): ... this.
 580         (is_unlimited_literal): Change parameter type to pointer to
 581         pointer.  Adjust and advance ARG pointer.
 582         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 583         (parse_cli_var_enum): New, factored out from ...
 584         (do_set_command): ... this.  Adjust.
 585         * cli/cli-setshow.h (parse_cli_boolean_value)
 586         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 587         (parse_cli_var_enum): Declare.
 588         * cli/cli-utils.c: Include "cli/cli-option.h".
 589         (get_ulongest): New.
 590         * cli/cli-utils.h (get_ulongest): Declare.
 591         (check_for_argument): New overloads.
 592         * maint-test-options.c: New file.
 593
 594 2019-06-13  Pedro Alves  <palves@redhat.com>
 595
 596         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 597         parse a range if "-" is at the end of the string.
 598
 599 2019-06-13  Pedro Alves  <palves@redhat.com>
 600
 601         * cli/cli-setshow.c (parse_auto_binary_operation)
 602         (parse_cli_boolean_value): Don't allow "o".
 603
 604 2019-06-13  Pedro Alves  <palves@redhat.com>
 605
 606         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 607         * NEWS: Mention maint test-settings KIND.
 608         * maint-test-settings.c: New file.
 609
 610 2019-06-13  Pedro Alves  <palves@redhat.com>
 611
 612         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 613         completer.
 614         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 615         "set" completers.
 616
 617 2019-06-13  Pedro Alves  <palves@redhat.com>
 618
 619         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 620         after item.
 621
 622 2019-06-13  Pedro Alves  <palves@redhat.com>
 623
 624         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 625
 626 2019-06-13  Pedro Alves <palves@redhat.com>
 627
 628         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 629         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 630         call.
 631         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 632         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 633         calls.
 634         (check_for_argument): Skip spaces after argument.
 635
 636 2019-06-13  Pedro Alves  <palves@redhat.com>
 637
 638         * thread.c (thread_apply_command): Adjust TID parsing.
 639         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 640         detected before end of string.
 641         (tid_is_in_list): Error out if LIST is invalid.
 642
 643 2019-06-13  Pedro Alves  <palves@redhat.com>
 644
 645         * completer.c (complete_line_internal_1): Rewind completion word
 646         point.
 647         (completion_tracker::advance_custom_word_point_by): Change
 648         parameter type to int.
 649         * completer.h (completion_tracker::advance_custom_word_point_by):
 650         Likewise.
 651
 652 2019-06-13  Pedro Alves  <palves@redhat.com>
 653
 654         * completer.c (advance_to_completion_word): Handle delimiters.
 655
 656 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 657
 658         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 659
 660 2019-06-11  Tom Tromey  <tom@tromey.com>
 661
 662         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 663         (xmalloc_failed): Move to alloc.c.
 664         * alloc.c: New file.
 665         * Makefile.in (COMMON_SFILES): Add alloc.c.
 666
 667 2019-06-11  Tom Tromey  <tom@tromey.com>
 668
 669         * nat/linux-waitpid.c: Don't include server.h.
 670         (linux_debug): Remove.
 671         (my_waitpid): Update.
 672
 673 2019-06-11  Tom Tromey  <tromey@adacore.com>
 674
 675         * infcall.c (_initialize_infcall): Remove trailing newline from
 676         help.
 677         * user-regs.c (_initialize_user_regs): Remove trailing newline
 678         from help.
 679         * typeprint.c (_initialize_typeprint): Remove trailing newline
 680         from help.
 681         * reverse.c (_initialize_reverse): Remove trailing newlines from
 682         help.
 683         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 684         from help.
 685         * language.c (add_set_language_command): Remove trailing newline
 686         from help.
 687         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 688         help.
 689         * disasm.c (_initialize_disasm): Remove trailing newline from
 690         help.
 691         * top.c (init_main): Remove trailing newline from help.
 692         * interps.c (_initialize_interpreter): Remove trailing newline
 693         from help.
 694         * btrace.c (_initialize_btrace): Remove trailing newlines from
 695         help.
 696         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 697         from help.
 698         * python/python.c (_initialize_python): Remove trailing newline
 699         from help.
 700         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 701         help.
 702         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 703         from help.  Reformat some text.
 704         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 705         from help.
 706         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 707         newline from help.
 708
 709 2019-06-11  Tom Tromey  <tromey@adacore.com>
 710
 711         * darwin-nat.c (darwin_decode_exception_message)
 712         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 713
 714 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * valops.c (value_slice): Check for not allocated or not
 717         associated values.
 718
 719 2019-06-10  Tom de Vries  <tdevries@suse.de>
 720
 721         PR gdb/24618
 722         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 723         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 724         invalid.
 725
 726 2019-06-10  Tom de Vries  <tdevries@suse.de>
 727
 728         PR gdb/24611
 729         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 730         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 731
 732 2019-06-10  Tom de Vries  <tdevries@suse.de>
 733
 734         PR symtab/24545
 735         * symtab.c (struct demangled_name_entry): Add language field.
 736         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 737         static minimal symbol".  Set and use language field.
 738
 739 2019-06-10  Tom Tromey  <tromey@adacore.com>
 740
 741         * ada-lang.c (_initialize_ada_language): Update help text.
 742
 743 2019-06-10  Tom Tromey  <tromey@adacore.com>
 744
 745         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 746         with a newline.
 747         * guile/guile.c (handle_boot_error): Don't end warning with a
 748         newline.
 749         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 750         warning with a newline.
 751         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 752         newline.
 753         (s12z_frame_cache): Likewise.
 754         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 755         a newline.
 756         * solib-svr4.c (disable_probes_interface): Don't end warning with
 757         a newline.
 758         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 759         newline.
 760         * python/python.c (do_finish_initialization): Don't end warning
 761         with a newline.
 762
 763 2019-06-10  Tom Tromey  <tom@tromey.com>
 764
 765         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 766         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 767         gdbpy_enter.
 768
 769 2019-06-10  Tom Tromey  <tromey@adacore.com>
 770
 771         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 772         data.
 773         (elf_new_init): Don't call stabsread_new_init.
 774         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 775         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 776         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 777
 778 2019-06-10  Tom de Vries  <tdevries@suse.de>
 779
 780         PR symtab/16264
 781         PR symtab/24517
 782         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 783
 784 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 785
 786         * source.c (find_and_open_source): Also rewrite relative file
 787         names.
 788
 789 2019-04-26  Amos Bird  <amosbird@gmail.com>
 790
 791         * annotate.c (annotate_thread_exited): Add "thread-exited"
 792         annotation.
 793
 794 2019-06-06  Tom Tromey  <tromey@adacore.com>
 795
 796         * maint.h (class scoped_command_stats): Use
 797         DISABLE_COPY_AND_ASSIGN.
 798         <print_time>: New method.
 799         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 800         print_time.
 801         (scoped_command_stats::print_time): New method.
 802
 803 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 806         instructions of lengths 6 or 8 bytes.
 807
 808 2019-06-04  Pedro Alves  <palves@redhat.com>
 809
 810         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 811
 812         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 813         * breakpoint.c (condition_completer): Likewise.
 814         * cli/cli-dump.c (scan_expression): Likewise.
 815         * common/filestuff.c (mkdir_recursive): Likewise.
 816         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 817         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 818         (gdb_abspath): Likewise.
 819         * compile/compile-cplus-types.c
 820         (compile_cplus_instance::decl_name): Likewise.
 821         * completer.c (complete_explicit_location):
 822         (signal_completer, reg_or_group_completer_1): Likewise.
 823         * cp-support.c (cp_remove_params_if_any): Likewise.
 824         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 825         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 826         * infcmd.c (strip_bg_char): Likewise.
 827         * linespec.c (copy_token_string): Likewise.
 828         * mi/mi-main.c (output_cores): Likewise.
 829         * psymtab.c (psymtab_search_name):
 830         * symfile.c (test_set_ext_lang_command): Likewise.
 831         * target.c (target_fileio_read_stralloc): Likewise.
 832         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 833         * value.c (complete_internalvar): Likewise.
 834
 835 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 836
 837         Add objfile property to gdb.Type.
 838         * NEWS: Mention Python API addition.
 839         * python/py-type.c (typy_get_objfile): New method.
 840
 841 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 842
 843         * NEWS: Mention the new set|show style [title|highlight].
 844         Mention changes to "show style", "help" and "apropos".
 845
 846 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 847
 848         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 849         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 850         instead of print_help_for_command.
 851         (print_doc_of_command): New function.
 852         (help_list): Add 'apropos -v word' suggestion.
 853         (print_help_for_command): Style the command name using title style.
 854         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 855         (_initialize_cli_cmds): Describe -v in apropos_command help.
 856
 857 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 858
 859         * cli/cli-style.h (cli_style_option): Add name in constructor,
 860         add m_name class member, add constructor with intensity,
 861         add name class function.
 862         (cli_style_option::add_setshow_commands): Remove name argument.
 863         (highlight_style, title_style): New styles.
 864         * cli/cli-style.c (do_show): New function that shows a style
 865         characteristic styling the style name with itself.
 866         (set_style_name): New function.
 867         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 868         Update all callers according to the changes in cli/cli-style.h.
 869         * utils.h (fputs_highlighted): New function.
 870         * utils.c (fputs_highlighted): Likewise.
 871
 872 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 873
 874         * NEWS: Mention new pipe command and new convenience variables.
 875
 876 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 877
 878         * cli/cli-cmds.c (pipe_command): New function.
 879         (_initialize_cli_cmds): Call add_com for pipe_command.
 880         Define | as an alias for pipe.
 881         (exit_status_set_internal_vars): New function.
 882         (shell_escape): Call exit_status_set_internal_vars.
 883         cli/cli-decode.c (find_command_name_length): Recognize | as
 884         a single character command.
 885
 886 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 887
 888         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 889         top.c (execute_command_to_ui_file): New function, mostly a copy
 890         of execute_command_to_string.
 891         (execute_command_to_string): Implement by calling
 892         execute_command_to_ui_file.
 893
 894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 895
 896         * top.h (saved_command_line): Remove declaration.
 897         * top.c (previous_saved_command_line, previous_repeat_arguments):
 898         New variables.
 899         (saved_command_line): Make static, define together with other
 900         'repeat variables'.
 901         (dont_repeat): Clear repeat_arguments.
 902         (repeat_previous, get_saved_command_line, save_command_line):
 903         New functions.
 904         (gdb_init): Initialize saved_command_line
 905         and previous_saved_command_line.
 906         * main.c (captured_main_1): Remove saved_command_line initialization.
 907         * event-top.c (handle_line_of_input): Update to use
 908         the new 'repeat' related functions instead of direct access to
 909         saved_command_line.
 910         * command.h (repeat_previous, get_saved_command_line,
 911         save_command_line): New declarations.
 912         (dont_repeat): Add comment.
 913
 914 2019-05-30  Tom Tromey  <tromey@adacore.com>
 915
 916         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 917         Fix comment.
 918         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 919
 920 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 921
 922         PR cli/24587
 923         * completer.c (complete): Initialize variable word.
 924
 925 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 926
 927         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 928         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 929         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 930         'body' is NULL to the outter 'if', protecting the '!is_define'
 931         situation as well.
 932
 933 2019-05-29  Tom Tromey  <tromey@adacore.com>
 934
 935         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 936         (dwarf_unknown): New function.
 937         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 938         (dwarf_type_encoding_name): Use dwarf_unknown.
 939
 940 2019-05-29  Tom Tromey  <tromey@adacore.com>
 941
 942         PR c++/20020:
 943         * cp-valprint.c (cp_print_value_fields): Call
 944         cp_print_static_field inside "try".
 945
 946 2019-05-29  Tom Tromey  <tromey@adacore.com>
 947
 948         * inflow.c (struct terminal_info): Add default operator=.
 949         * configure: Rebuild.
 950         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 951         -Wdeprecated-copy-dtor, -Wredundant-move.
 952
 953 2019-05-29  Tom Tromey  <tromey@adacore.com>
 954
 955         * NEWS: Add entry.
 956         * infcmd.c (print_return_value_1): Handle finish_print
 957         option.
 958         (show_print_finish): New function.
 959         (_initialize_infcmd): Add "set/show print finish" commands.
 960         * valprint.c (user_print_options): Initialize new member.
 961         * valprint.h (struct value_print_options) <finish_print>: New
 962         member.
 963
 964 2019-05-28  Tom Tromey  <tromey@adacore.com>
 965
 966         * ada-lang.c (ada_remove_Xbn_suffix)
 967         (find_old_style_renaming_symbol)
 968         (parse_old_style_renaming): Remove.
 969         (ada_find_renaming_symbol): Don't call
 970         find_old_style_renaming_symbol.
 971         (ada_is_renaming_symbol): Rename from
 972         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 973         bool.  Now static.
 974         (ada_read_var_value): Update and simplify.
 975         * ada-exp.y (write_var_or_type): Remove old code.
 976
 977 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 978
 979         * event-top.c: Remove include comment.
 980         * inflow.c (class scoped_ignore_sigttou): Move from here...
 981         * inflow.h (class scoped_ignore_sigttou): ...to here.
 982         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 983         * top.c:  Remove include comment.
 984
 985 2019-05-27  Tom Tromey  <tom@tromey.com>
 986
 987         * NEWS: Fix typo.
 988
 989 2019-05-22  Tom Tromey  <tromey@adacore.com>
 990
 991         * target.c (target_follow_exec): Constify parameter.
 992         * target-delegates.c: Rebuild.
 993         * remote.c (remote_target::follow_exec): Constify parameter.
 994         * infrun.c (follow_exec): Constify parameter.
 995         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 996         (target_follow_exec): Likewise.
 997
 998 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 999
1000         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1001         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1002
1003 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1004
1005         * NEWS: Add debugredirect and testsuite sections.
1006
1007 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1008
1009         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1010         target descriptions using exclusively floating point register name
1011         aliases.
1012
1013 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1014
1015         PR gdb/18644:
1016         * f-lang.c (build_fortran_types): Handle the case where
1017         gdbarch_floatformat_for_type returns a nullptr.
1018
1019 2019-05-21  Tom de Vries  <tdevries@suse.de>
1020
1021         PR cli/24587
1022         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1023
1024 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         PR gdb/18644:
1027         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1028         16-byte floats.
1029         * i386-tdep.c (i386_floatformat_for_type): Use
1030         floatformats_ia64_quad for the 16-byte floating point component
1031         within a fortran 32-byte complex number.
1032
1033 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1036         delete default constructor.
1037         (find_partial_die): Update to return const struct.
1038         (partial_die_parent_scope): Move variable declaration into scope
1039         of its use and change its type to auto.
1040         (guess_partial_die_structure_name): Likewise.
1041         (partial_die_info::fixup): Likewise.
1042
1043 2019-05-17  Tom Tromey  <tromey@adacore.com>
1044
1045         * source.c (find_and_open_source): Remove cast.
1046
1047 2019-05-17  Tom Tromey  <tromey@adacore.com>
1048
1049         * annotate.c (annotate_source): Make "filename" const.
1050         * annotate.h (annotate_source): Use const.
1051
1052 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1053
1054         * disasm.c (set_disassembler_options): Send errors to stderr.
1055
1056 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1057
1058         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1059         (cli_interp_base::set_logging): Check debug_redirect.
1060         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1061         * cli/cli-logging.c (debug_redirect): Add static variable.
1062         (pop_output_files): Add default param.
1063         (handle_redirections): Print debug setting.
1064         (show_logging_command): Likewise.
1065         (_initialize_cli_logging): Add debugredirect command.
1066         * interps.c (current_interp_set_logging): Add debug_redirect
1067         parameter.
1068         * interps.h (set_logging): Add debug_redirect parameter.
1069         (current_interp_set_logging): Likewise.
1070         * mi/mi-common.h: Likewise.
1071         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1072
1073 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1074             Tom Tromey  <tromey@adacore.com>
1075
1076         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1077         directly.
1078         * cli/cli-interp.h (make_logging_output): Remove declaration.
1079         * cli/cli-logging.c (make_logging_output): Remove function.
1080         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1081         directly.
1082         * ui-file.c (tee_file::tee_file): Remove bools.
1083         (tee_file::~tee_file): Remove deletes.
1084         * ui-file.h (tee_file): Remove bools.
1085
1086 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1087
1088         * mi/mi-cmds.h (mi_cmd_complete): New function.
1089         * mi/mi-main.c (mi_cmd_complete): Likewise.
1090         * mi/mi-cmds.c: Define new MI command -complete.
1091         * NEWS: Mention new -complete command.
1092
1093 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1094
1095         * completer.h (complete): New function.
1096         * completer.c (complete): Likewise.
1097         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1098         function defined in completer.h.
1099
1100 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1101
1102         * MAINTAINERS (Write After Approval): Add myself.
1103
1104 2019-05-17  Tom de Vries  <tdevries@suse.de>
1105
1106         PR gdb/24094
1107         * dwarf2read.c (struct cu_partial_die_info): New struct.
1108         (find_partial_die): Return cu_partial_die_info.
1109         (partial_die_parent_scope, guess_partial_die_structure_name)
1110         (partial_die_info::fixup): Handle new return type of find_partial_die.
1111
1112 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1113
1114         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1115         "std::string", simplifying the algorithm.
1116
1117 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1118
1119         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1120         (stap_static_probe_ops::get_probes): Likewise.
1121
1122 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1123
1124         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1125         '-')" and "else if".
1126         (stap_parse_single_operand): Join checks for
1127         "gdbarch_stap_parse_special_token_p" and
1128         "gdbarch_stap_parse_special_token" in the same "if" statement.
1129         Invert check when verifying for operation on register
1130         displacement.
1131
1132 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1133
1134         * stap-probe.c (stap_get_opcode): Update comment.
1135         (stap_get_expected_argument_type): Likewise.
1136         (handle_stap_probe): Likewise.
1137
1138 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1139
1140         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1141         return type to 'bool'.  Adjust comment.  Use 'bool' when
1142         appropriate.
1143         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1144         * stap-probe.c (stap_parse_argument_1): Likewise.
1145         (stap_is_operator): Likewise.
1146         (stap_is_generic_prefix): Likewise.
1147         (stap_is_register_prefix): Likewise.
1148         (stap_is_register_indirection_prefix): Likewise.
1149         (stap_is_integer_prefix): Likewise.
1150         (stap_generic_check_suffix): Likewise.
1151         (stap_check_integer_suffix): Likewise.
1152         (stap_check_register_suffix): Likewise.
1153         (stap_check_register_indirection_suffix): Likewise.
1154         (stap_parse_register_operand): Likewise.
1155         (stap_parse_single_operand): Likewise.
1156         (stap_parse_argument_1): Likewise.
1157         (stap_probe::get_argument_count): Likewise.
1158         (stap_is_operator): Likewise.
1159
1160 2019-05-16  Tom Tromey  <tromey@adacore.com>
1161
1162         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1163         keyword to foreach.
1164
1165 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1166
1167         * linux-thread-db.c (try_thread_db_load_1): Change return type
1168         to bool.
1169         (try_thread_db_load): Likewise.
1170         (try_thread_db_load_from_pdir_1): Likewise.
1171         (try_thread_db_load_from_pdir): Likewise.
1172         (try_thread_db_load_from_sdir): Likewise.
1173         (try_thread_db_load_from_dir): Likewise.
1174         (thread_db_load_search): Likewise.
1175         (has_libpthread): Likewise.
1176         (thread_db_load): Likewise.
1177
1178 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1179
1180         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1181         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1182         NULL, and complain/return if that's the case.
1183
1184 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1185
1186         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1187         (advance, posn, abstract_read_memory): New functions.
1188         [struct mem_read_abstraction]: New struct.
1189         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1190
1191 2019-05-14  Tom Tromey  <tromey@adacore.com>
1192
1193         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1194         value is not lval_memory.
1195
1196 2019-05-14  Tom Tromey  <tromey@adacore.com>
1197
1198         * solib.c (info_sharedlibrary_command): Style the file name.
1199
1200 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1201
1202         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1203         (aarch64_vnv_type): Likewise.
1204         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1205         * common/tdesc.c: Likewise.
1206         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1207         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1208         * features/aarch64-fpu.xml: Add ieee half view.
1209         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1210         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1211         * gdbtypes.h (struct builtin_type): Likewise.
1212         (struct objfile_type): Likewise.
1213
1214 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1215
1216         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1217         typo.
1218         * location.h (string_to_event_location): Likewise.
1219
1220 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1221
1222         GDB 8.3 released.
1223
1224 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1225
1226         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1227         New variable declaration.
1228         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1229         New variable.
1230         (print_one_breakpoint): Use ui_out::test_flags and new global
1231         variable to compute use_fixed_output.
1232         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1233         Remove.
1234         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1235         (mi_multi_location_breakpoint_output_fixed): Remove.
1236         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1237         new variable.
1238         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1239         fix_multi_location_breakpoint_output flag if version >= 3.
1240         * ui-out.h (enum ui_out_flag)
1241         <fix_multi_location_breakpoint_output>: New enumerator.
1242
1243 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1244
1245         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1246
1247 2019-05-10  Tom Tromey  <tromey@adacore.com>
1248
1249         * ada-lang.c (catch_ada_completer): New function.
1250         (_initialize_ada_language): Use it.
1251
1252 2019-05-10  Tom Tromey  <tromey@adacore.com>
1253
1254         * thread.c (print_thread_info): Make "requested_threads" const.
1255         * gdbthread.h (print_thread_info): Make "requested_threads"
1256         const.
1257         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1258         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1259
1260 2019-05-08  Tom Tromey  <tom@tromey.com>
1261
1262         * gdbtypes.c (objfile_type_data): Change type.
1263         (objfile_type, _initialize_gdbtypes): Update.
1264
1265 2019-05-08  Tom Tromey  <tom@tromey.com>
1266
1267         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1268         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1269         (_initialize_dwarf2_frame): Update.
1270
1271 2019-05-08  Tom Tromey  <tom@tromey.com>
1272
1273         * objc-lang.c (objc_objfile_data): Change type.
1274         (find_methods): Update.
1275         (_initialize_objc_lang): Remove.
1276
1277 2019-05-08  Tom Tromey  <tom@tromey.com>
1278
1279         * stabsread.c (rs6000_builtin_type_data): Change type.
1280         (rs6000_builtin_type, _initialize_stabsread): Update.
1281
1282 2019-05-08  Tom Tromey  <tom@tromey.com>
1283
1284         * mips-tdep.c (mips_pdr_data): Remove.
1285         (_initialize_mips_tdep): Update.
1286
1287 2019-05-08  Tom Tromey  <tom@tromey.com>
1288
1289         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1290         (hppa_init_objfile_priv_data, read_unwind_info)
1291         (find_unwind_entry, _initialize_hppa_tdep): Update.
1292
1293 2019-05-08  Tom Tromey  <tom@tromey.com>
1294
1295         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1296         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1297         on obstack.
1298         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1299
1300 2019-05-08  Tom Tromey  <tom@tromey.com>
1301
1302         * mdebugread.c (basic_type_data): Change type.
1303         (basic_type, _initialize_mdebugread): Update.
1304
1305 2019-05-08  Tom Tromey  <tom@tromey.com>
1306
1307         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1308
1309 2019-05-08  Tom Tromey  <tom@tromey.com>
1310
1311         * nto-tdep.c (nto_inferior_data_reg): Change type.
1312         (nto_inferior_data): Update.
1313         (nto_inferior_data_cleanup, nto_new_inferior_data)
1314         (_initialize_nto_tdep): Remove.
1315         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1316
1317 2019-05-08  Tom Tromey  <tom@tromey.com>
1318
1319         * ada-lang.c (struct ada_inferior_data): Add initializers.
1320         (ada_inferior_data): Change type.
1321         (ada_inferior_data_cleanup): Remove.
1322         (get_ada_inferior_data, ada_inferior_exit)
1323         (struct ada_pspace_data): Add initializers, destructor.
1324         (ada_pspace_data_handle): Change type.
1325         (get_ada_pspace_data): Update.
1326         (ada_pspace_data_cleanup): Remove.
1327
1328 2019-05-08  Tom Tromey  <tom@tromey.com>
1329
1330         * coffread.c (struct coff_symfile_info): Add initializers.
1331         (coff_objfile_data_key): Move lower.  Change type.
1332         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1333         Update.
1334         (coff_free_info): Remove.
1335
1336 2019-05-08  Tom Tromey  <tom@tromey.com>
1337
1338         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1339         (fbsd_pspace_data_handle): Move lower.  Change type.
1340         (get_fbsd_pspace_data): Update.
1341         (fbsd_pspace_data_cleanup): Remove.
1342         (_initialize_fbsd_tdep): Update.
1343
1344 2019-05-08  Tom Tromey  <tom@tromey.com>
1345
1346         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1347         (get_ada_tasks_pspace_data): Update.
1348         (ada_tasks_pspace_data_cleanup): Remove.
1349         (_initialize_tasks): Update.
1350         (ada_tasks_inferior_data_handle): Change type.
1351         (get_ada_tasks_inferior_data): Update.
1352         (ada_tasks_inferior_data_cleanup): Remove.
1353         (struct ada_tasks_pspace_data): Add initializers.
1354
1355 2019-05-08  Tom Tromey  <tom@tromey.com>
1356
1357         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1358         * symfile-debug.c (debug_sym_get_probes): Change type.
1359         * stap-probe.c (handle_stap_probe):
1360         (stap_static_probe_ops::get_probes): Change type.
1361         * probe.h (class static_probe_ops) <get_probes>: Change type.
1362         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1363         (parse_probes_in_pspace): Update.
1364         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1365         Update.
1366         (any_static_probe_ops::get_probes): Change type.
1367         * elfread.c (elfread_data): New typedef.
1368         (probe_key): Change type.
1369         (elf_get_probes): Likewise.  Update.
1370         (probe_key_free): Remove.
1371         (_initialize_elfread): Update.
1372         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1373         Change type.
1374         (dtrace_process_dof_probe, dtrace_process_dof)
1375         (dtrace_static_probe_ops::get_probe): Change type.
1376
1377 2019-05-08  Tom Tromey  <tom@tromey.com>
1378
1379         * xcoffread.c (struct xcoff_symfile_info): Rename from
1380         coff_symfile_info.  Add initializers.
1381         (xcoff_objfile_data_key): Move lower.  Change type.
1382         (XCOFF_DATA): Rewrite.
1383         (xcoff_free_info): Remove.
1384         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1385         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1386         (xcoff_initial_scan): Update.
1387
1388 2019-05-08  Tom Tromey  <tom@tromey.com>
1389
1390         * solib-svr4.c (struct svr4_info): Add initializers and
1391         destructor.
1392         <probes_table>: Now an htab_up.
1393         (solib_svr4_pspace_data): Change type.
1394         (free_probes_table): Simplify.
1395         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1396         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1397         (probes_table_remove_objfile_probes, register_solib_event_probe)
1398         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1399         (_initialize_svr4_solib): Update.
1400
1401 2019-05-08  Tom Tromey  <tom@tromey.com>
1402
1403         * remote.c (remote_pspace_data): Change type.
1404         (remote_pspace_data_cleanup): Remove.
1405         (get_remote_exec_file, set_pspace_remote_exec_file)
1406         (_initialize_remote): Update.
1407
1408 2019-05-08  Tom Tromey  <tom@tromey.com>
1409
1410         * breakpoint.c (breakpoint_objfile_key): Change type.
1411         (get_breakpoint_objfile_data): Update.
1412         (free_breakpoint_objfile_data): Remove.
1413         (_initialize_breakpoint): Update.
1414
1415 2019-05-08  Tom Tromey  <tom@tromey.com>
1416
1417         * linux-tdep.c (struct linux_info): Add initializers.
1418         (linux_inferior_data): Move.  Change type.
1419         (invalidate_linux_cache_inf): Update.
1420         (linux_inferior_data_cleanup): Remove.
1421         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1422
1423 2019-05-08  Tom Tromey  <tom@tromey.com>
1424
1425         * auxv.c (auxv_inferior_data): Move.  Change type.
1426         (auxv_inferior_data_cleanup): Remove.
1427         (invalidate_auxv_cache_inf): Rewrite.
1428         (get_auxv_inferior_data, _initialize_auxv): Update.
1429
1430 2019-05-08  Tom Tromey  <tom@tromey.com>
1431
1432         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1433         (symfile_debug_objfile_data_key): Change type.
1434         (symfile_debug_installed, debug_qf_has_symbols)
1435         (debug_qf_find_last_source_symtab)
1436         (debug_qf_forget_cached_source_info)
1437         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1438         (debug_qf_print_stats, debug_qf_dump)
1439         (debug_qf_expand_symtabs_for_function)
1440         (debug_qf_expand_all_symtabs)
1441         (debug_qf_expand_symtabs_with_fullname)
1442         (debug_qf_map_matching_symbols)
1443         (debug_qf_expand_symtabs_matching)
1444         (debug_qf_find_pc_sect_compunit_symtab)
1445         (debug_qf_map_symbol_filenames)
1446         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1447         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1448         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1449         (debug_sym_read_linetable, debug_sym_relocate): Update.
1450         (symfile_debug_free_objfile): Remove.
1451         (install_symfile_debug_logging, _initialize_symfile_debug):
1452         Update.
1453
1454 2019-05-08  Tom Tromey  <tom@tromey.com>
1455
1456         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1457         allocate_on_obstack.
1458         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1459         (get_dwarf2_per_objfile): Update.
1460         (set_dwarf2_per_objfile): Remove.
1461         (dwarf2_has_info, dwarf2_get_section_info): Update.
1462         (dwarf2_free_objfile): Remove.
1463         (_initialize_dwarf2_read): Update.
1464
1465 2019-05-08  Tom Tromey  <tom@tromey.com>
1466
1467         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1468         initializers.
1469         <unsupported_script_warning_printed,
1470         script_not_found_warning_printed>: Now bool.
1471         (auto_load_pspace_data): Change type.
1472         (~auto_load_pspace_info): Rename from
1473         auto_load_pspace_data_cleanup.
1474         (get_auto_load_pspace_data, init_loaded_scripts_info)
1475         (clear_section_scripts, maybe_print_unsupported_script_warning)
1476         (maybe_print_script_not_found_warning, _initialize_auto_load):
1477         Update.
1478
1479 2019-05-08  Tom Tromey  <tom@tromey.com>
1480
1481         * objfiles.c (objfile_pspace_info): Add destructor and
1482         initializers.
1483         (objfiles_pspace_data): Change type.
1484         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1485         (get_objfile_pspace_data): Update.
1486         (objfiles_bfd_data): Change type.
1487         (get_objfile_bfd_data): Update.
1488         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1489
1490 2019-05-08  Tom Tromey  <tom@tromey.com>
1491
1492         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1493         Change type.
1494         (get_catch_syscall_inferior_data): Update.
1495         (catch_syscall_inferior_data_cleanup): Remove.
1496         (_initialize_break_catch_syscall): Update.
1497
1498 2019-05-08  Tom Tromey  <tom@tromey.com>
1499
1500         * inflow.c (struct terminal_info): Add destructor and
1501         initializers.
1502         (inflow_inferior_data): Change type.
1503         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1504         (get_inflow_inferior_data, inflow_inferior_exit)
1505         (swap_terminal_info, _initialize_inflow): Update.
1506
1507 2019-05-08  Tom Tromey  <tom@tromey.com>
1508
1509         * target-dcache.c (target_dcache_cleanup): Remove.
1510         (target_dcache_aspace_key): Change type.
1511         (target_dcache_init_p, target_dcache_invalidate)
1512         (target_dcache_get, target_dcache_get_or_init)
1513         (_initialize_target_dcache): Update.
1514         * dcache.h (struct dcache_deleter): New.
1515
1516 2019-05-08  Tom Tromey  <tom@tromey.com>
1517
1518         * symtab.c (struct symbol_cache): Add destructor and
1519         initializers.
1520         (symbol_cache_key): Move.  Change type.
1521         (make_symbol_cache, free_symbol_cache): Remove.
1522         (get_symbol_cache): Update.
1523         (symbol_cache_cleanup): Remove.
1524         (ALL_PSPACES, symbol_cache_flush)
1525         (maintenance_print_symbol_cache)
1526         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1527         Update.
1528
1529 2019-05-08  Tom Tromey  <tom@tromey.com>
1530
1531         * symtab.c (struct main_info): Add destructor and initializers.
1532         (main_progspace_key): Move.  Change type.
1533         (get_main_info): Update.
1534         (main_info_cleanup): Remove.
1535         (_initialize_symtab): Update.
1536
1537 2019-05-08  Tom Tromey  <tom@tromey.com>
1538
1539         * registry.h (DECLARE_REGISTRY): Define the _key class.
1540
1541 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * NEWS: Merge two 'New commands' sections.
1544
1545 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1546
1547         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1548         parameter and use Ada language definition instead.
1549         (ada_val_print_ptr): Remove unused language parameter.
1550         (ada_val_print_num): Remove language parameter and use Ada language
1551         definition instead.
1552         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1553         parameter.
1554         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1555         parameter and use Ada language definition instead.
1556         (ada_val_print_1): Update all ada_val_print_xxx calls.
1557         Remove language parameter.
1558         (ada_val_print): Update ada_val_print_1 call.
1559
1560 2019-05-08  Tom Tromey  <tromey@adacore.com>
1561
1562         * remote.c (remote_hw_watchpoint_limit)
1563         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1564         Now static.
1565
1566 2019-05-08  Tom Tromey  <tromey@adacore.com>
1567
1568         * maint.c (_initialize_maint_cmds): Move initialization code to
1569         remote.c.
1570         (watchdog, show_watchdog): Move to remote.c.
1571         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1572         "watchdog" static.
1573         (_initialize_remote): Move initialization code from maint.c.
1574         * defs.h (watchdog): Don't declare.
1575
1576 2019-05-08  Tom Tromey  <tromey@adacore.com>
1577
1578         * tui/tui-interp.c: Include main.h.
1579         * interps.c: Include main.h.
1580         * main.h (interpreter_p): Declare.
1581         * defs.h (interpreter_p): Don't declare.
1582
1583 2019-05-08  Tom Tromey  <tromey@adacore.com>
1584
1585         * dwarf2loc.c: Include dwarf2read.h.
1586         * defs.h (read_unsigned_leb128): Don't declare.
1587         * dwarf2read.h (read_unsigned_leb128): Declare.
1588
1589 2019-05-08  Tom Tromey  <tromey@adacore.com>
1590
1591         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1592         method.
1593
1594 2019-05-08  Tom Tromey  <tromey@adacore.com>
1595
1596         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1597         when no wrap column is set.
1598
1599 2019-05-08  Tom Tromey  <tromey@adacore.com>
1600
1601         * c-lang.c (c_get_string): Handle non-C-style arrays.
1602
1603 2019-05-08  Tom Tromey  <tromey@adacore.com>
1604
1605         * typeprint.c (print_offset_data::update): Print the bit offset,
1606         not the number of bits remaining.
1607
1608 2019-05-08  Tom Tromey  <tromey@adacore.com>
1609
1610         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1611         padding at end of comment.
1612
1613 2019-05-08  Tom Tromey  <tromey@adacore.com>
1614
1615         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1616         Compare main types.
1617
1618 2019-05-06  Tom Tromey  <tom@tromey.com>
1619
1620         * common/scoped_mmap.c: Include common-defs.h.
1621         * common/scoped_mmap.h: Don't include config.h.
1622
1623 2019-05-04  Tom Tromey  <tom@tromey.com>
1624
1625         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1626         (struct aarch64_call_info): Add initializers.
1627         <si>: Now a std::vector.
1628         (pass_on_stack, aarch64_push_dummy_call): Update.
1629
1630 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1631             Tom Tromey  <tom@tromey.com>
1632
1633         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1634         (ppc_threads): Now a std::vector.  Now static.
1635         (hwdebug_find_thread_points_by_tid)
1636         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1637         Update.
1638
1639 2019-05-04  Tom Tromey  <tom@tromey.com>
1640
1641         * arc-tdep.c (arc_tdesc_init): Return bool.
1642
1643 2019-05-04  Tom Tromey  <tom@tromey.com>
1644
1645         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1646         Use gdb_assert_not_reached.
1647
1648 2019-05-04  Tom Tromey  <tom@tromey.com>
1649
1650         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1651         "false".
1652
1653 2019-05-04  Tom Tromey  <tom@tromey.com>
1654
1655         * arc-tdep.c (arc_tdesc_init): Use bool.
1656
1657 2019-05-04  Tom Tromey  <tom@tromey.com>
1658
1659         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1660
1661 2019-05-04  Tom Tromey  <tom@tromey.com>
1662
1663         * cli/cli-cmds.c (valid_command_p): Return bool.
1664
1665 2019-05-04  Tom Tromey  <tom@tromey.com>
1666
1667         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1668         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1669
1670 2019-05-04  Raul Tambre  <raul@tambre.ee>
1671
1672         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1673         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1674         operator for comparison.
1675
1676 2019-05-04  Tom Tromey  <tom@tromey.com>
1677
1678         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1679         (lookup_partial_symbol, print_partial_symbols)
1680         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1681         (psymbol_compare): Update.
1682         (add_psymbol_to_bcache): Clear the entire psymbol.
1683         (maintenance_check_psymtabs): Update.
1684         * psympriv.h (struct partial_symbol): Don't derive from
1685         general_symbol_info.
1686         <obj_section, unrelocated_address, address,
1687         set_unrelocated_address>: Update.
1688         <ginfo>: New member.
1689         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1690         (debug_names::write_psymbols): Update.
1691
1692 2019-05-04  Tom de Vries  <tdevries@suse.de>
1693
1694         * contrib/cc-with-tweaks.sh: Support -n arg.
1695
1696 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1697
1698         * corelow.c (core_target::detach): Ensure frame cache and
1699         register caches are cleared.
1700         inferior.c (exit_inferior_1): Likewise.
1701
1702 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1703             Tom Tromey  <tom@tromey.com>
1704
1705         * dictionary.c (collate_pending_symbols_by_language): Remove
1706         "struct" from foreach.
1707         * symtab.c (lookup_global_symbol_from_objfile)
1708         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1709         foreach.
1710         * ser-tcp.c (net_open): Remove "struct" from foreach.
1711         * objfiles.c (objfile_relocate, objfile_rebase)
1712         (objfile_has_symbols): Remove "struct" from foreach.
1713         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1714         from foreach.
1715         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1716         foreach.
1717         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1718         "struct" from foreach.
1719         * ada-lang.c (create_excep_cond_exprs)
1720         (ada_exception_catchpoint_cond_string): Remove "struct" from
1721         foreach.
1722
1723 2019-05-03  Tom Tromey  <tromey@adacore.com>
1724
1725         * ada-exp.y (convert_char_literal): Check suffix of each
1726         enumerator.
1727
1728 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1729
1730         PR ada/21406:
1731         * ada-exp.y (yywrap): Don't define.
1732         * ada-lex.l (%option): Add noyywrap
1733         (yywrap): Remove.
1734
1735 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1736
1737         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1738         _WIN32_WINNT to the XP level, unless already defined to a higher
1739         level.
1740
1741         * unittests/parse-connection-spec-selftests.c:
1742         * ser-tcp.c:
1743         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1744         override.
1745
1746         * symfile.c (find_separate_debug_file): Remove colon from the
1747         drive spec of DOS/Windows file names of the target, so that the
1748         file name produced from DEBUGDIR and the target's directory will
1749         be valid on DOS/Windows systems.
1750
1751 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1752
1753         * rust-lang.c (val_print_struct): Handle printing structures
1754         containing strings.
1755
1756 2019-05-02  Tom Tromey  <tromey@adacore.com>
1757
1758         * valarith.c (_initialize_valarith): Remove.
1759
1760 2019-05-01  Tom Tromey  <tromey@adacore.com>
1761
1762         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1763         bitfields.
1764
1765 2019-05-01  Tom Tromey  <tromey@adacore.com>
1766
1767         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1768         for big-endian copies.
1769
1770 2019-04-30  Ali Tamur  <tamur@google.com>
1771         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1772         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1773         (read_3_bytes): New function.
1774
1775 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1776
1777         * windows-nat.c (main_thread_id): Delete.
1778         (handle_output_debug_string): Replace main_thread_id by
1779         current_event.dwThreadId.
1780         (fake_create_process): Likewise.
1781         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1782         Do not set main_thread_id.
1783         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1784         current_event.dwThreadId.
1785         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1786
1787 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1788
1789         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1790         Use current_event.dwThreadId instead of main_thread_id.
1791
1792 2019-04-30  Tom Tromey  <tromey@adacore.com>
1793
1794         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1795         (create_excep_cond_exprs): Iterate over program spaces.
1796         (ada_exception_catchpoint_cond_string): Examine all minimal
1797         symbols for exception types.
1798
1799 2019-04-30  Tom Tromey  <tromey@adacore.com>
1800
1801         PR c++/24470:
1802         * dwarf2read.c (process_structure_scope): Handle case where type
1803         has template parameters but no symbol was created.
1804
1805 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1806             Chris January  <chris.january@arm.com>
1807
1808         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1809         qualifier.
1810         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1811
1812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         * f-typeprint.c (f_print_type): Update rules for printing
1815         whitespace.
1816         (f_type_print_varspec_suffix): Likewise.
1817
1818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1819             Chris January  <chris.january@arm.com>
1820
1821         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1822         function arguments.
1823
1824 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * f-lang.c (build_fortran_types): Change name of void type to
1827         lower case.
1828         * f-typeprint.c (f_type_print_base): Print the name of the void
1829         type, rather than a fixed string.
1830         * f-valprint.c (f_decorations): Use lower case void string.
1831
1832 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1833             Chris January  <chris.january@arm.com>
1834
1835         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1836         types for Fortran.
1837
1838 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1839             Chris January  <chris.january@arm.com>
1840             David Lecomber  <david.lecomber@arm.com>
1841
1842         * f-exp.y (BINOP_INTRINSIC): New token.
1843         (exp): New parser rule handling BINOP_INTRINSIC.
1844         (f77_keywords): Add new builtin procedures.
1845         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1846         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1847         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1848         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1849         (print_unop_subexp_f): New function.
1850         (print_binop_subexp_f): New function.
1851         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1852         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1853         (dump_subexp_body_f): Likewise.
1854         (operator_check_f): Likewise.
1855         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1856         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1857
1858 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1859
1860         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1861         UNOP_KIND.
1862         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1863         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1864         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1865         (operator_length_f): New fuction.
1866         (print_subexp_f): New function.
1867         (op_name_f): New function.
1868         (dump_subexp_body_f): New function.
1869         (operator_check_f): New function.
1870         (exp_descriptor_f): Replace standard expression handling functions
1871         with new functions.
1872         * gdb/fortran-operator.def: New file.
1873         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1874         * gdb/std-operator.def: Remove UNOP_KIND.
1875
1876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * std-operator.def: Remove unbalanced, stray double quote
1879         character.
1880
1881 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1882             Chris January  <chris.january@arm.com>
1883             Daniel Everett  <daniel.everett@arm.com>
1884             Nick Forrington  <nick.forrington@arm.com>
1885             Richard Bunt  <richard.bunt@arm.com>
1886
1887         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1888         of depth when printing anonymous structs or unions.
1889         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1890         Don't print either the top-level value, or the children if the
1891         max-depth is exceeded.
1892         (ppscm_print_children): When printing the key of a map, allow one
1893         extra level of depth.
1894         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1895         print either the top-level value, or the children if the max-depth
1896         is exceeded.
1897         (print_children): When printing the key of a map, allow one extra
1898         level of depth.
1899         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1900         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1901         (user_print_options): Initialise max_depth field.
1902         (val_print_scalar_or_string_type_p): New function.
1903         (val_print): Check to see if the max depth has been reached.
1904         (val_print_check_max_depth): Define new function.
1905         (show_print_max_depth): New function.
1906         (_initialize_valprint): Add 'print max-depth' option.
1907         * valprint.h (struct value_print_options) <max_depth>: New field.
1908         (val_print_check_max_depth): Declare new function.
1909         * NEWS: Document new feature.
1910
1911 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1912
1913         * ada-lang.c (ada_language_defn): Initialise new field.
1914         * c-lang.c (c_is_string_type_p): New function.
1915         (c_language_defn): Initialise new field.
1916         (cplus_language_defn): Initialise new field.
1917         (asm_language_defn): Initialise new field.
1918         (minimal_language_defn): Initialise new field.
1919         * c-lang.h (c_is_string_type_p): Declare new function.
1920         * d-lang.c (d_language_defn): Initialise new field.
1921         * f-lang.c (f_is_string_type_p): New function.
1922         (f_language_defn): Initialise new field.
1923         * go-lang.c (go_is_string_type_p): New function.
1924         (go_language_defn): Initialise new field.
1925         * language.c (default_is_string_type_p): New function.
1926         (unknown_language_defn): Initialise new field.
1927         (auto_language_defn): Initialise new field.
1928         * language.h (struct language_defn) <la_is_string_type_p>: New
1929         member variable.
1930         (default_is_string_type_p): Declare new function.
1931         * m2-lang.c (m2_language_defn): Initialise new field.
1932         * objc-lang.c (objc_language_defn): Initialise new field.
1933         * opencl-lang.c (opencl_language_defn): Initialise new field.
1934         * p-lang.c (pascal_is_string_type_p): New function.
1935         (pascal_language_defn): Initialise new field.
1936         * rust-lang.c (rust_is_string_type_p): New function.
1937         (rust_language_defn): Initialise new field.
1938
1939 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1942         New field.
1943         * ada-lang.c (ada_language_defn): Initialise new field.
1944         * c-lang.c (c_language_defn): Likewise.
1945         (cplus_language_defn): Likewise.
1946         (asm_language_defn): Likewise.
1947         (minimal_language_defn): Likewise.
1948         * d-lang.c (d_language_defn): Likewise.
1949         * f-lang.c (f_language_defn): Likewise.
1950         * go-lang.c (go_language_defn): Likewise.
1951         * language.c (unknown_language_defn): Likewise.
1952         (auto_language_defn): Likewise.
1953         * m2-lang.c (m2_language_defn): Likewise.
1954         * objc-lang.c (objc_language_defn): Likewise.
1955         * opencl-lang.c (opencl_language_defn): Likewise.
1956         * p-lang.c (pascal_language_defn): Likewise.
1957         * rust-lang.c (rust_language_defn): Likewise.
1958
1959 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * ada-lang.c (ada_is_character_type): Change return type to bool.
1962         (ada_is_string_type): Likewise.
1963         * ada-lang.h (ada_is_character_type): Update declaration
1964         (ada_is_string_type): Likewise.
1965
1966 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1967
1968         Support style in 'frame|thread apply'
1969
1970         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1971         * record.c (record_start, record_stop): Update callers of
1972         execute_command_to_string with false.
1973         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1974         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1975         methods.
1976         (class string_file): New constructor with term_out parameter.
1977         Override methods term_out and can_emit_style_escape.  New member
1978         term_out.
1979         (class stdio_file): Override can_emit_style_escape.
1980         (class tee_file): Override term_out and can_emit_style_escape.
1981         * utils.h (can_emit_style_escape): Remove.
1982         * utils.c (can_emit_style_escape): Likewise.
1983         Update all callers of can_emit_style_escape (SOMESTREAM) to
1984         SOMESTREAM->can_emit_style_escape.
1985         * source-cache.c (source_cache::get_source_lines): Likewise.
1986         * stack.c (frame_apply_command_count): Call execute_command_to_string
1987         passing the term_out characteristic of the current gdb_stdout.
1988         * thread.c (thr_try_catch_cmd): Likewise.
1989         * top.c (execute_command_to_string): pass term_out parameter
1990         to construct the string_file for the command output.
1991         * ui-file.c (term_cli_styling): New function (most code moved
1992         from utils.c can_emit_style_escape).
1993         (string_file::string_file, string_file::can_emit_style_escape,
1994         stdio_file::can_emit_style_escape, tee_file::term_out,
1995         tee_file::can_emit_style_escape): New functions.
1996
1997 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1998
1999         * NEWS: Mention the new set|show may-call-functions.
2000         * infcall.c (may_call_functions_p): New variable.
2001         (show_may_call_functions_p): New function.
2002         (call_function_by_hand_dummy): Throws an error if not
2003         may-call-functions.
2004         (_initialize_infcall): Call add_setshow_boolean_cmd for
2005         may-call-functions.
2006
2007 2019-04-25  Keith Seitz  <keiths@redhat.com>
2008
2009         PR c++/24367
2010         * cp-support.c (inspect_type): Don't attempt substitutions
2011         of symbol with the same name.
2012
2013 2019-04-25  Tom Tromey  <tromey@adacore.com>
2014
2015         PR gdb/24475:
2016         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2017         static.
2018
2019 2019-04-25  Tom Tromey  <tromey@adacore.com>
2020
2021         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2022         rvalue reference.
2023         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2024         (gdb_xml_parser::parse): Use std::move.
2025         * python/python-internal.h (gdbpy_convert_exception): Take a const
2026         reference.
2027         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2028         std::move.
2029         * python/py-utils.c (gdbpy_convert_exception): Take a const
2030         reference.
2031         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2032         Use std::move.
2033         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2034         Use std::move.
2035         * mi/mi-main.c (mi_print_exception): Take a const reference.
2036         * main.c (handle_command_errors): Take a const reference.
2037         * linespec.c (parse_linespec): Use std::move.
2038         * infcall.c (run_inferior_call): Use std::move.
2039         (call_function_by_hand_dummy): Use std::move.
2040         * exec.c (try_open_exec_file): Use std::move.
2041         * exceptions.h (exception_print, exception_fprintf)
2042         (exception_print_same): Update.
2043         * exceptions.c (print_exception, exception_print)
2044         (exception_fprintf, exception_print_same): Change parameters to
2045         const reference.
2046         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2047         * common/new-op.c: Use std::move.
2048         * common/common-exceptions.h (struct gdb_exception): Add move
2049         constructor.
2050         (struct gdb_exception_error, struct gdb_exception_quit, struct
2051         gdb_quit_bad_alloc): Change constructor to move constructor.
2052         (throw_exception): Change parameter to rvalue reference.
2053         * common/common-exceptions.c (throw_exception): Take rvalue
2054         reference.
2055         * cli/cli-interp.c (safe_execute_command): Use std::move.
2056         * breakpoint.c (insert_bp_location, location_to_sals): Use
2057         std::move.
2058
2059 2019-04-25  Tom Tromey  <tromey@adacore.com>
2060
2061         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2062         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2063         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2064         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2065         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2066         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2067         guile/scm-value.c: Use unpack.
2068         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2069         gdbscm_gdb_exception.
2070         (gdbscm_throw_gdb_exception): Likewise.
2071         (struct gdbscm_gdb_exception): New.
2072         (unpack): New function.
2073         (gdbscm_wrap): Use unpack.
2074
2075 2019-04-25  Tom Tromey  <tromey@adacore.com>
2076
2077         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2078         (gdb_rl_callback_handler): Use std::move.
2079         * common/common-exceptions.h (struct gdb_exception): Add move
2080         assignment operator.
2081         (throw_exception_sjlj): Change "exception" to const reference.
2082         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2083         (throw_exception_sjlj): Change "exception" to const reference.
2084
2085 2019-04-25  Tom Tromey  <tromey@adacore.com>
2086
2087         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2088         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2089         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2090         Update.
2091         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2092         Update.
2093         * mi/mi-interp.c (mi_interp::exec): Update.
2094         * linespec.c (parse_linespec): Update.
2095         * infcall.c (run_inferior_call): Update.
2096         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2097         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2098         (gdbscm_lookup_global_symbol): Update.
2099         * guile/scm-param.c (gdbscm_parameter_value): Update.
2100         * guile/scm-frame.c (gdbscm_frame_read_register)
2101         (gdbscm_frame_read_var): Update.
2102         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2103         * exec.c (try_open_exec_file): Update.
2104         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2105         (gdb_rl_callback_handler): Update.
2106         * common/common-exceptions.h (exception_none): Don't declare.
2107         * common/common-exceptions.c (exception_none): Don't define.
2108         (struct catcher) <exception>: Update.
2109         * cli/cli-interp.c (safe_execute_command): Update.
2110         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2111
2112 2019-04-25  Ali Tamur  <tamur@google.com>
2113
2114         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2115         (read_attribute_value): Likewise.
2116         (dwarf2_read_addr_index): Update comment.
2117         (read_str_index): Add DW_FORM_strx.
2118         (dwarf2_string_attr): Likewise.
2119         (dwarf2_const_value_attr): Likewise.
2120         (dump_die_shallow): Likewise.
2121         (dwarf2_fetch_constant_bytes): Likewise.
2122         (skip_form_bytes): Likewise.
2123         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2124
2125 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2126
2127         PR corefiles/11608
2128         PR corefiles/18187
2129         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2130         OFFSET.  Verify if current mapping contains an ELF header.
2131         (linux_find_memory_regions_full): Adjust call to
2132         dump_mapping_p.
2133
2134 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2135             Kang Li <kanglictf@gmail.com>
2136
2137         PR gdb/21600
2138
2139         * dwarf2-frame.c (read_initial_length): Be consistent about using
2140         unsigned representation of length.
2141         (decode_frame_entry_1): Likewise.  Check for wraparound of
2142         end pointer as well as buffer overflow.
2143
2144 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2145
2146         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2147         "vq".
2148
2149 2019-04-24  Tom Tromey  <tromey@adacore.com>
2150
2151         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2152
2153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2154
2155         * s12z-tdep.c (s12z_unwind_pc): Delete.
2156         (s12z_unwind_sp): Delete.
2157         (s12z_gdbarch_init): Don't register deleted functions with
2158         gdbarch.
2159
2160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * rl78-tdep.c (rl78_unwind_sp): Delete.
2163         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2164
2165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2166
2167         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2168         (xstormy16_unwind_pc): Delete.
2169         (xstormy16_dummy_id): Delete.
2170         (xstormy16_gdbarch_init): Don't register deleted functions with
2171         gdbarch.
2172
2173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * vax-tdep.c (vax_unwind_pc): Delete.
2176         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2177
2178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * v850-tdep.c (v850_unwind_sp): Delete.
2181         (v850_unwind_pc): Delete.
2182         (v850_dummy_id): Delete.
2183         (v850_gdbarch_init): Don't register deleted functions with
2184         gdbarch.
2185
2186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2189         (tilegx_unwind_pc): Delete.
2190         (tilegx_unwind_dummy_id): Delete.
2191         (tilegx_gdbarch_init): Don't register deleted functions with
2192         gdbarch.
2193
2194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2197         (tic6x_dummy_id): Delete.
2198         (tic6x_gdbarch_init): Don't register deleted functions with
2199         gdbarch.
2200
2201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * sparc-tdep.c (sparc_unwind_pc): Delete.
2204         (sparc32_gdbarch_init): Don't register deleted function with
2205         gdbarch.
2206
2207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * sh-tdep.c (sh_unwind_sp): Delete.
2210         (sh_unwind_pc): Delete.
2211         (sh_dummy_id): Delete.
2212         (sh_gdbarch_init): Don't register deleted functions with
2213         gdbarch.
2214
2215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * score-tdep.c (score_unwind_sp): Delete.
2218         (score_unwind_pc): Delete.
2219         (score_dummy_id): Delete.
2220         (score_gdbarch_init): Don't register deleted functions with
2221         gdbarch.
2222
2223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * rx-tdep.c (rx_unwind_pc): Delete.
2226         (rx_unwind_sp): Delete.
2227         (rx_dummy_id): Delete.
2228         (rx_gdbarch_init): Don't register deleted functions with
2229         gdbarch.  Update comment.
2230
2231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2234         (rs6000_dummy_id): Delete.
2235         (rs6000_gdbarch_init): Don't register deleted functions with
2236         gdbarch.
2237
2238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * or1k-tdep.c (or1k_dummy_id): Delete.
2241         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2242
2243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * nios2-tdep.c (nios2_dummy_id): Delete.
2246         (nios2_unwind_sp): Delete.
2247         (nios2_gdbarch_init): Don't register deleted functions with
2248         gdbarch.
2249
2250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2251
2252         * nds32-tdep.c (nds32_dummy_id): Delete.
2253         (nds32_unwind_pc): Delete.
2254         (nds32_unwind_sp): Delete.
2255         (nds32_gdbarch_init): Don't register deleted functions with
2256         gdbarch.
2257
2258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * msp430-tdep.c (msp430_unwind_pc): Delete.
2261         (msp430_unwind_sp): Delete.
2262         (msp430_dummy_id): Delete.
2263         (msp430_gdbarch_init): Don't register deleted functions with
2264         gdbarch.
2265
2266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * moxie-tdep.c (moxie_unwind_sp): Delete.
2269         (moxie_unwind_pc): Delete.
2270         (moxie_dummy_id): Delete.
2271         (moxie_gdbarch_init): Don't register deleted functions with
2272         gdbarch.
2273
2274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2275
2276         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2277         (mn10300_unwind_pc): Delete.
2278         (mn10300_unwind_sp): Delete.
2279         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2280         mn10300_unwind_sp.
2281         (mn10300_frame_unwind_init): Don't register deleted functions with
2282         gdbarch.
2283
2284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * mep-tdep.c (mep_unwind_pc): Delete.
2287         (mep_unwind_sp): Delete.
2288         (mep_dummy_id): Delete.
2289         (mep_gdbarch_init): Don't register deleted functions with
2290         gdbarch.
2291
2292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2295         (m68hc11_unwind_sp): Delete.
2296         (m68hc11_gdbarch_init): Don't register deleted functions with
2297         gdbarch.
2298
2299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * m32r-tdep.c (m32r_unwind_sp): Delete.
2302         (m32r_unwind_pc): Delete.
2303         (m32r_dummy_id): Delete.
2304         (m32r_gdbarch_init): Don't register deleted functions with
2305         gdbarch.
2306
2307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2308
2309         * m32c-tdep.c (m32c_unwind_pc): Delete.
2310         (m32c_unwind_sp): Delete.
2311         (m32c_dummy_id): Delete.
2312         (m32c_gdbarch_init): Don't register deleted functions with
2313         gdbarch.
2314
2315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2318         (lm32_unwind_pc): Delete.
2319         (lm32_dummy_id): Delete.
2320         (lm32_gdbarch_init): Don't register deleted functions with
2321         gdbarch.
2322
2323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2326         (iq2000_unwind_pc): Delete.
2327         (iq2000_dummy_id): Delete.
2328         (iq2000_gdbarch_init): Don't register deleted functions with
2329         gdbarch.
2330
2331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * nds32-tdep.c (nds32_type_align): Delete.
2334         (nds32_push_dummy_call): Use type_align instead.
2335
2336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2337
2338         * arm-tdep.c (arm_type_align): Only handle vector override case.
2339         (arm_push_dummy_call): Use type_align.
2340         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2341
2342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2343
2344         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2345         case.
2346         (pass_on_stack): Use type_align.
2347         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2348         function.
2349
2350 2019-04-23  Tom Tromey  <tromey@adacore.com>
2351
2352         * dwarf2read.c (line_header::file_name_at): Remove unused
2353         overload.
2354
2355 2019-04-23  Tom de Vries  <tdevries@suse.de>
2356
2357         PR gdb/24438
2358         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2359         invocation.
2360
2361
2362 2019-03-27  Ali Tamur  <tamur@google.com>
2363
2364         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2365         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2366         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2367         (dwarf_expr_context::get_addr_index): Likewise
2368         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2369         (symbol_needs_eval_context::get_addr_index): Likewise
2370         (disassemble_dwarf_expression): Add DW_OP_addrx
2371         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2372         (read_cutu_die_from_dwo): Update comment
2373         (skip_one_die): Add DW_FORM_addrx
2374         (read_attribute_value): Likewise
2375         (var_decode_location): Add DW_OP_addrx
2376         (dwarf2_const_value_attr): Add DW_FORM_addrx
2377         (dump_die_shallow): Likewise
2378         (dwarf2_fetch_constant_bytes): Likewise
2379         (decode_locdesc): Add DW_OP_addrx
2380         (skip_form_bytes): Add DW_FORM_addrx
2381
2382 2019-04-22  Ali Tamur  <tamur@google.com>
2383
2384         * MAINTAINERS (Write After Approval): Add self.
2385
2386 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2387
2388         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2389         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2390         (open_symbol_file_object): Likewise.
2391         (svr4_default_sos): Add info parameter.
2392         (svr4_read_so_list): Likewise.
2393         (svr4_current_sos_direct): Adjust functions calls to pass down
2394         info.
2395         (svr4_current_sos_1): Add info parameter.
2396         (svr4_current_sos): Call get_svr4_info, pass info down to
2397         svr4_current_sos_1.
2398         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2399         get_svr4_info.
2400         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2401         get_svr4_info.
2402         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2403         to get_svr4_info.
2404         (probes_table_remove_objfile_probes): Likewise.
2405         (register_solib_event_probe): Add info parameter.
2406         (solist_update_incremental): Pass info parameter down to
2407         svr4_read_so_list.
2408         (disable_probes_interface): Add info parameter.
2409         (svr4_handle_solib_event): Pass current_program_space to
2410         get_svr4_info.  Adjust disable_probes_interface cleanup.
2411         (svr4_create_probe_breakpoints): Add info parameter, pass it
2412         down to register_solib_event_probe.
2413         (svr4_create_solib_event_breakpoints): Add info parameter,
2414         pass it down to svr4_create_probe_breakpoints.
2415         (enable_break): Pass info down to
2416         svr4_create_solib_event_breakpoints.
2417         (svr4_solib_create_inferior_hook): Pass current_program_space to
2418         get_svr4_info.
2419         (svr4_clear_solib): Likewise.
2420
2421 2019-04-22  Pedro Alves  <palves@redhat.com>
2422
2423         * solib-svr4.c (svr4_free_objfile_observer): New.
2424         (probe_and_action::objfile): New field.
2425         (probes_table_htab_remove_objfile_probes)
2426         (probes_table_remove_objfile_probes): New functions.
2427         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2428         in the new probe_and_action.  Don't store the probe in 'lookup'.
2429         (svr4_create_probe_breakpoints): Pass objfile to
2430         register_solib_event_probe.
2431         (_initialize_svr4_solib): Register a free_objfile observer.
2432
2433 2019-04-19  Tom Tromey  <tom@tromey.com>
2434
2435         * common/queue.h: Remove.
2436
2437 2019-04-19  Tom Tromey  <tom@tromey.com>
2438
2439         * event-loop.c: Don't include "common/queue.h".
2440
2441 2019-04-19  Tom Tromey  <tom@tromey.com>
2442
2443         * remote.c (remote_target): Use delete.
2444         * remote-notif.h: Include <list>, not "common/queue.h".
2445         (notif_client_p): Remove typedef.
2446         (remote_notif_state): Add constructor, destructor, initializer.
2447         <notif_queue>: Now a std::list.
2448         (remote_notif_state_xfree): Don't declare.
2449         * remote-notif.c (remote_notif_process, handle_notification)
2450         (remote_notif_state_allocate): Update.
2451         (~remote_notif_state): Rename from remote_notif_state_xfree.
2452
2453 2019-04-19  Tom Tromey  <tom@tromey.com>
2454
2455         * symfile.c (reread_symbols): Update.
2456         * objfiles.c (objfile_register_static_link)
2457         (objfile_lookup_static_link): Update
2458         (~objfile) Don't delete static_links.
2459         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2460
2461 2019-04-19  Tom Tromey  <tom@tromey.com>
2462
2463         * type-stack.h (struct type_stack) <insert>: Constify string.
2464         * type-stack.c (type_stack::insert): Constify string.
2465         * gdbtypes.h (lookup_template_type): Update.
2466         (address_space_name_to_int): Update.
2467         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2468         const.
2469         (lookup_template_type): Make name const.
2470         * c-exp.y: Update rules.
2471         (lex_one_token, classify_name, classify_inner_name)
2472         (c_print_token): Update.
2473         * p-exp.y: Update rules.
2474         (yylex): Update.
2475         * f-exp.y: Update rules.
2476         (yylex): Update.
2477         * d-exp.y: Update rules.
2478         (lex_one_token, classify_name, classify_inner_name): Update.
2479         * parse.c (write_dollar_variable, copy_name): Return std::string.
2480         * parser-defs.h (copy_name): Change return type.
2481         * m2-exp.y: Update rules.
2482         (yylex): Update.
2483         * go-exp.y (lex_one_token): Update.
2484         Update rules.
2485         (classify_unsafe_function, classify_packaged_name)
2486         (classify_name, yylex): Update.
2487
2488 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2489
2490         * configure.ac: add --enable-source-highlight switch.
2491         * configure: Regenerate.
2492         * top.c (print_gdb_version): plumb --enable-source-highlight
2493         status to "show configuration".
2494
2495 2019-04-19  Tom Tromey  <tromey@adacore.com>
2496
2497         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2498         Check ADA_TYPE_P.
2499         (empty_record, ada_template_to_fixed_record_type_1)
2500         (template_to_static_fixed_type)
2501         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2502         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2503         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2504         macros.
2505
2506 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2507
2508         PR symtab/24423:
2509         * source.c (print_source_lines_base): Advance "iter" when a
2510         control character is seen.
2511
2512 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2513
2514         * inferior.h (struct infcall_suspend_state_deleter):
2515         Catch exception in destructor to avoid crash.
2516
2517 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2518
2519         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2520         close to the add_com "shell".
2521
2522 2019-04-18  Tom Tromey  <tromey@adacore.com>
2523
2524         * process-stratum-target.h (class process_stratum_target)
2525         <stratum>: Add "final".
2526
2527 2019-04-17  Tom Tromey  <tromey@adacore.com>
2528
2529         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2530         against nullptr before use.
2531
2532 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2533
2534         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2535
2536 2019-04-17  Jim Wilson  <jimw@sifive.com>
2537             Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2540         code read might fail, assume 4-byte breakpoint in that case.
2541
2542 2019-04-15  Leszek Swirski  <leszeks@google.com>
2543
2544         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2545         rather than a hand-rolled POD check when checking for forced MEMORY
2546         classification.
2547
2548 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2549
2550         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2551         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2552         function.
2553         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2554         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2555         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2556         declaration.
2557
2558 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2559
2560         * aarch64-linux-nat.c
2561         (aarch64_linux_nat_target::thread_architecture): Add override.
2562         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2563         each VQ.
2564
2565 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2566
2567         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2568
2569 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2572         target types of size 96-bits, add some additional comments, and
2573         check that the builtin type we found was the correct size.
2574
2575 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2576
2577         * utils.c (prompt_for_continue): Don't restore the styling at the
2578         end, as applied_style has the wrong value.  This fixes styling in
2579         long lists of file names that are interrupted by the "Continue?"
2580         prompt.
2581
2582 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2583
2584         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2585         * c-lang.c (c_language_defn): Likewise.
2586         (cplus_language_defn): Likewise.
2587         (asm_language_defn): Likewise.
2588         (minimal_language_defn): Likewise.
2589         * d-lang.c (d_language_defn): Likewise.
2590         * f-lang.c (f_language_defn): Likewise.
2591         * go-lang.c (go_language_defn): Likewise.
2592         * language.c (unknown_language_defn): Likewise.
2593         (auto_language_defn): Likewise.
2594         * language.h (struct language_defn): Remove la_magic field.
2595         (LANG_MAGIC): Delete.
2596         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2597         * objc-lang.c (objc_language_defn): Likewise.
2598         * opencl-lang.c (opencl_language_defn): Likewise.
2599         * p-lang.c (pascal_language_defn): Likewise.
2600         * rust-lang.c (rust_language_defn): Likewise.
2601
2602 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2603
2604         * riscv-tdep.c (riscv_type_align): New function.
2605         (riscv_type_alignment): Delete.
2606         (riscv_arg_location): Use 'type_align'.
2607         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2608
2609 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * gdbtypes.c (type_align): A struct with no non-static fields also
2612         has alignment of 1.
2613
2614 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2617         component to 0.
2618         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2619         member.
2620         (riscv_struct_info::analyse): New implementation using new
2621         analyse_inner member function.
2622         (riscv_struct_info::field_offset): New member function.
2623         (riscv_struct_info::m_offsets): New member variable.
2624         (riscv_struct_info::analyse_inner): New private member function,
2625         takes the old implementation of riscv_struct_info::analyse but
2626         extended to track field offsets.
2627         (riscv_call_arg_struct): Update the struct folding special cases
2628         to handle cases where empty C++ structs, which are non-zero
2629         length, are found.
2630         (riscv_arg_location): Initialise the length of each location, a
2631         non-zero length now indicates the location is in use.
2632         (riscv_push_dummy_call): Allow for the first location having a
2633         non-zero offset when setting up arguments.
2634         (riscv_return_value): Likewise, but for return values.
2635
2636 2019-04-11  Tom Tromey  <tromey@adacore.com>
2637
2638         * utils.c (internal_vproblem): Make "msg" const.
2639
2640 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2643         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2644         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2645         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2646
2647 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2648
2649         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2650         function.
2651         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2652         of amd64_collect_native_gregset.
2653         (amd64_linux_nat_target::store_registers): Likewise.
2654
2655 2019-04-10  Tom Tromey  <tom@tromey.com>
2656
2657         * symtab.c (lookup_global_symbol_from_objfile)
2658         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2659         * objfiles.h (class separate_debug_iterator): New.
2660         (class separate_debug_range): New.
2661         (struct objfile) <separate_debug_objfiles>: New method.
2662         (objfile_separate_debug_iterate): Don't declare.
2663         * objfiles.c (separate_debug_iterator::operator++): Rename from
2664         objfile_separate_debug_iterate.
2665         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2666         iterator.
2667         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2668         iterator.
2669
2670 2019-04-10  Tom Tromey  <tom@tromey.com>
2671
2672         * symfile.c (reread_symbols): Remove old comment.
2673         * objfiles.c (free_all_objfiles): Fix a typo.
2674
2675 2019-04-10  Tom Tromey  <tom@tromey.com>
2676
2677         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2678         * minsyms.c (lookup_minimal_symbol): Use foreach.
2679         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2680         (lookup_minimal_symbol_solib_trampoline): Likewise.
2681         * symfile.c (reread_symbols): Use foreach.
2682
2683 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2684             Tom Tromey  <tromey@adacore.com>
2685
2686         PR rust/24414:
2687         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2688         (rust_lex_int_test): Change "value" to be LONGEST.
2689         (rust_lex_tests): Add test for long integer literal.
2690
2691 2019-04-09  Tom Tromey  <tromey@adacore.com>
2692
2693         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2694         to bool.
2695         (extended_remote_target::attach): Update.
2696         (remote_target::remote_notice_new_inferior): Update.
2697         (remote_target::add_current_inferior_and_thread): Update.
2698         * inferior.c (exit_inferior_1): Use "false".
2699         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2700
2701 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2702
2703         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2704         the "start" command.
2705
2706 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2707
2708         * python/py-inferior.c (infpy_thread_from_thread_handle):
2709         Adjust comments to reflect renaming of thread_from_thread_handle
2710         to thread_from_handle.  Adjust keywords.  Fix type error message.
2711         (inferior_object_methods): Add thread_from_handle.  Retain
2712         thread_from_thread_handle, but mark it as deprecated.
2713
2714 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2715
2716         * gdbthread.h (find_thread_by_handle): Revise declaration.
2717         * thread.c (find_thread_by_handle): Likewise.  Adjust
2718         implementation too.
2719         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2720         support for buffer objects as handles.
2721
2722 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2723
2724         * python/py-infthread.c (thpy_thread_handle): New function.
2725         (thread_object_methods): Register thpy_thread_handle.
2726
2727 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2728
2729         * gdbthread.h (thread_to_thread_handle): Declare.
2730         * thread.c (gdbtypes.h): Include.
2731         (thread_to_thread_handle): New function.
2732
2733         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2734         (target_thread_info_to_thread_handle): Declare.
2735         * target.c (target_thread_info_to_thread_handle): New function.
2736         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2737         * target-delegates.c: Regenerate.
2738
2739         * linux-thread-db.c (class thread_db_target): Add method
2740         thread_info_to_thread_handle.
2741         (thread_db_target::thread_info_to_thread_handle): Define.
2742         * remote.c (class remote_target): Add new method
2743         thread_info_to_thread_handle.
2744         (remote_target::thread_info_to_thread_handle): Define.
2745
2746 2019-04-08  Pedro Alves  <palves@redhat.com>
2747
2748         * common/common-exceptions.c (throw_exception): Don't create
2749         named object to throw; throw directly.
2750         (throw_it): Likewise.  Don't initialize gdb_exception::message
2751         here, with new; pass FMT and AP to the ctor instead.
2752         * common/common-exceptions.h: Include <string>.
2753         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2754         const char *, va_list)): New ctor.  Use std::make_shared.
2755         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2756         errors)): Delete.
2757         (gdb_exception_error::gdb_exception_error(enum errors, const char
2758         *, va_list)): New.
2759         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2760         Add assertion.
2761         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2762         errors)): Delete.
2763         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2764         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2765         Add assertion.
2766
2767 2019-04-08  Tom Tromey  <tom@tromey.com>
2768
2769         * valops.c (value_rtti_indirect_type): Replace throw_exception
2770         with throw.
2771         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2772         with throw.
2773         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2774         throw.
2775         * target.c (target_translate_tls_address): Replace throw_exception
2776         with throw.
2777         * stack.c (frame_apply_command_count): Replace throw_exception
2778         with throw.
2779         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2780         throw.
2781         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2782         with throw.
2783         * rs6000-tdep.c (rs6000_frame_cache)
2784         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2785         * remote.c: Replace throw_exception with throw.
2786         * record-full.c (record_full_message, record_full_wait_1)
2787         (record_full_restore): Replace throw_exception with throw.
2788         * record-btrace.c:
2789         (get_thread_current_frame_id, record_btrace_start_replaying)
2790         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2791         (cmd_record_btrace_start): Replace throw_exception with throw.
2792         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2793         throw.
2794         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2795         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2796         * linespec.c:
2797         (find_linespec_symbols): Replace throw_exception with throw.
2798         * infrun.c (displaced_step_prepare, resume): Replace
2799         throw_exception with throw.
2800         * infcmd.c (post_create_inferior): Replace throw_exception with
2801         throw.
2802         * inf-loop.c (inferior_event_handler): Replace throw_exception
2803         with throw.
2804         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2805         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2806         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2807         (get_prev_frame_always, get_frame_pc_if_available)
2808         (get_frame_address_in_block_if_available, get_frame_language):
2809         Replace throw_exception with throw.
2810         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2811         throw_exception with throw.
2812         * eval.c (fetch_subexp_value, evaluate_var_value)
2813         (evaluate_funcall, evaluate_subexp_standard): Replace
2814         throw_exception with throw.
2815         * dwarf2loc.c (call_site_find_chain)
2816         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2817         Replace throw_exception with throw.
2818         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2819         with throw.
2820         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2821         throw.
2822         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2823         * completer.c (complete_line_internal): Replace throw_exception
2824         with throw.
2825         * compile/compile-object-run.c (compile_object_run): Replace
2826         throw_exception with throw.
2827         * cli/cli-script.c (process_next_line): Replace throw_exception
2828         with throw.
2829         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2830         (btrace_enable, btrace_maint_update_pt_packets): Replace
2831         throw_exception with throw.
2832         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2833         throw_exception with throw.
2834         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2835         throw_exception with throw.
2836         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2837         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2838         * aarch64-tdep.c (aarch64_make_prologue_cache)
2839         (aarch64_make_stub_cache): Replace throw_exception with throw.
2840
2841 2019-04-08  Tom Tromey  <tom@tromey.com>
2842
2843         * common/common-exceptions.c (throw_exception): Rename from
2844         throw_exception_cxx.  Remove old copy.  Make argument const.
2845         (throw_it): Create and throw exception objects directly.
2846         * common/common-exceptions.h (throw_exception): Make argument
2847         const.
2848         (struct gdb_exception_error): Add constructor.
2849         (struct gdb_exception_quit): Add constructor.
2850
2851 2019-04-08  Tom Tromey  <tom@tromey.com>
2852
2853         * common/common-exceptions.h (exception_rethrow): Don't declare.
2854         (TRY_SJLJ): Update comment.
2855         (TRY, CATCH, END_CATCH): Remove.
2856         * common/common-exceptions.c (exception_rethrow): Remove.
2857
2858 2019-04-08  Tom Tromey  <tom@tromey.com>
2859
2860         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2861         Remove.
2862         (gdb_exception_error): Rename from
2863         gdb_exception_RETURN_MASK_ERROR.
2864         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2865         (gdb_quit_bad_alloc): Update.
2866         * aarch64-tdep.c: Update.
2867         * ada-lang.c: Update.
2868         * ada-typeprint.c: Update.
2869         * ada-valprint.c: Update.
2870         * amd64-tdep.c: Update.
2871         * arch-utils.c: Update.
2872         * break-catch-throw.c: Update.
2873         * breakpoint.c: Update.
2874         * btrace.c: Update.
2875         * c-varobj.c: Update.
2876         * cli/cli-cmds.c: Update.
2877         * cli/cli-interp.c: Update.
2878         * cli/cli-script.c: Update.
2879         * common/common-exceptions.c: Update.
2880         * common/new-op.c: Update.
2881         * common/selftest.c: Update.
2882         * compile/compile-c-symbols.c: Update.
2883         * compile/compile-cplus-symbols.c: Update.
2884         * compile/compile-object-load.c: Update.
2885         * compile/compile-object-run.c: Update.
2886         * completer.c: Update.
2887         * corelow.c: Update.
2888         * cp-abi.c: Update.
2889         * cp-support.c: Update.
2890         * cp-valprint.c: Update.
2891         * darwin-nat.c: Update.
2892         * disasm-selftests.c: Update.
2893         * dtrace-probe.c: Update.
2894         * dwarf-index-cache.c: Update.
2895         * dwarf-index-write.c: Update.
2896         * dwarf2-frame-tailcall.c: Update.
2897         * dwarf2-frame.c: Update.
2898         * dwarf2loc.c: Update.
2899         * dwarf2read.c: Update.
2900         * eval.c: Update.
2901         * event-loop.c: Update.
2902         * event-top.c: Update.
2903         * exec.c: Update.
2904         * f-valprint.c: Update.
2905         * fbsd-tdep.c: Update.
2906         * frame-unwind.c: Update.
2907         * frame.c: Update.
2908         * gdbtypes.c: Update.
2909         * gnu-v3-abi.c: Update.
2910         * guile/guile-internal.h: Update.
2911         * guile/scm-block.c: Update.
2912         * guile/scm-breakpoint.c: Update.
2913         * guile/scm-cmd.c: Update.
2914         * guile/scm-disasm.c: Update.
2915         * guile/scm-frame.c: Update.
2916         * guile/scm-lazy-string.c: Update.
2917         * guile/scm-math.c: Update.
2918         * guile/scm-param.c: Update.
2919         * guile/scm-ports.c: Update.
2920         * guile/scm-pretty-print.c: Update.
2921         * guile/scm-symbol.c: Update.
2922         * guile/scm-symtab.c: Update.
2923         * guile/scm-type.c: Update.
2924         * guile/scm-value.c: Update.
2925         * i386-linux-tdep.c: Update.
2926         * i386-tdep.c: Update.
2927         * inf-loop.c: Update.
2928         * infcall.c: Update.
2929         * infcmd.c: Update.
2930         * infrun.c: Update.
2931         * jit.c: Update.
2932         * language.c: Update.
2933         * linespec.c: Update.
2934         * linux-fork.c: Update.
2935         * linux-nat.c: Update.
2936         * linux-tdep.c: Update.
2937         * linux-thread-db.c: Update.
2938         * main.c: Update.
2939         * mi/mi-cmd-break.c: Update.
2940         * mi/mi-cmd-stack.c: Update.
2941         * mi/mi-interp.c: Update.
2942         * mi/mi-main.c: Update.
2943         * objc-lang.c: Update.
2944         * p-valprint.c: Update.
2945         * parse.c: Update.
2946         * ppc-linux-tdep.c: Update.
2947         * printcmd.c: Update.
2948         * python/py-arch.c: Update.
2949         * python/py-breakpoint.c: Update.
2950         * python/py-cmd.c: Update.
2951         * python/py-finishbreakpoint.c: Update.
2952         * python/py-frame.c: Update.
2953         * python/py-framefilter.c: Update.
2954         * python/py-gdb-readline.c: Update.
2955         * python/py-inferior.c: Update.
2956         * python/py-infthread.c: Update.
2957         * python/py-lazy-string.c: Update.
2958         * python/py-linetable.c: Update.
2959         * python/py-objfile.c: Update.
2960         * python/py-param.c: Update.
2961         * python/py-prettyprint.c: Update.
2962         * python/py-progspace.c: Update.
2963         * python/py-record-btrace.c: Update.
2964         * python/py-record.c: Update.
2965         * python/py-symbol.c: Update.
2966         * python/py-type.c: Update.
2967         * python/py-unwind.c: Update.
2968         * python/py-utils.c: Update.
2969         * python/py-value.c: Update.
2970         * python/python.c: Update.
2971         * record-btrace.c: Update.
2972         * record-full.c: Update.
2973         * remote-fileio.c: Update.
2974         * remote.c: Update.
2975         * riscv-tdep.c: Update.
2976         * rs6000-aix-tdep.c: Update.
2977         * rs6000-tdep.c: Update.
2978         * rust-exp.y: Update.
2979         * rust-lang.c: Update.
2980         * s390-tdep.c: Update.
2981         * selftest-arch.c: Update.
2982         * solib-dsbt.c: Update.
2983         * solib-frv.c: Update.
2984         * solib-spu.c: Update.
2985         * solib-svr4.c: Update.
2986         * solib.c: Update.
2987         * sparc64-linux-tdep.c: Update.
2988         * stack.c: Update.
2989         * symfile-mem.c: Update.
2990         * symmisc.c: Update.
2991         * target.c: Update.
2992         * thread.c: Update.
2993         * top.c: Update.
2994         * tracefile-tfile.c: Update.
2995         * tui/tui.c: Update.
2996         * typeprint.c: Update.
2997         * unittests/cli-utils-selftests.c: Update.
2998         * unittests/parse-connection-spec-selftests.c: Update.
2999         * valops.c: Update.
3000         * valprint.c: Update.
3001         * value.c: Update.
3002         * varobj.c: Update.
3003         * windows-nat.c: Update.
3004         * x86-linux-nat.c: Update.
3005         * xml-support.c: Update.
3006
3007 2019-04-08  Tom Tromey  <tom@tromey.com>
3008
3009         * xml-support.c: Use C++ exception handling.
3010         * x86-linux-nat.c: Use C++ exception handling.
3011         * windows-nat.c: Use C++ exception handling.
3012         * varobj.c: Use C++ exception handling.
3013         * value.c: Use C++ exception handling.
3014         * valprint.c: Use C++ exception handling.
3015         * valops.c: Use C++ exception handling.
3016         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3017         handling.
3018         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3019         * typeprint.c: Use C++ exception handling.
3020         * tui/tui.c: Use C++ exception handling.
3021         * tracefile-tfile.c: Use C++ exception handling.
3022         * top.c: Use C++ exception handling.
3023         * thread.c: Use C++ exception handling.
3024         * target.c: Use C++ exception handling.
3025         * symmisc.c: Use C++ exception handling.
3026         * symfile-mem.c: Use C++ exception handling.
3027         * stack.c: Use C++ exception handling.
3028         * sparc64-linux-tdep.c: Use C++ exception handling.
3029         * solib.c: Use C++ exception handling.
3030         * solib-svr4.c: Use C++ exception handling.
3031         * solib-spu.c: Use C++ exception handling.
3032         * solib-frv.c: Use C++ exception handling.
3033         * solib-dsbt.c: Use C++ exception handling.
3034         * selftest-arch.c: Use C++ exception handling.
3035         * s390-tdep.c: Use C++ exception handling.
3036         * rust-lang.c: Use C++ exception handling.
3037         * rust-exp.y: Use C++ exception handling.
3038         * rs6000-tdep.c: Use C++ exception handling.
3039         * rs6000-aix-tdep.c: Use C++ exception handling.
3040         * riscv-tdep.c: Use C++ exception handling.
3041         * remote.c: Use C++ exception handling.
3042         * remote-fileio.c: Use C++ exception handling.
3043         * record-full.c: Use C++ exception handling.
3044         * record-btrace.c: Use C++ exception handling.
3045         * python/python.c: Use C++ exception handling.
3046         * python/py-value.c: Use C++ exception handling.
3047         * python/py-utils.c: Use C++ exception handling.
3048         * python/py-unwind.c: Use C++ exception handling.
3049         * python/py-type.c: Use C++ exception handling.
3050         * python/py-symbol.c: Use C++ exception handling.
3051         * python/py-record.c: Use C++ exception handling.
3052         * python/py-record-btrace.c: Use C++ exception handling.
3053         * python/py-progspace.c: Use C++ exception handling.
3054         * python/py-prettyprint.c: Use C++ exception handling.
3055         * python/py-param.c: Use C++ exception handling.
3056         * python/py-objfile.c: Use C++ exception handling.
3057         * python/py-linetable.c: Use C++ exception handling.
3058         * python/py-lazy-string.c: Use C++ exception handling.
3059         * python/py-infthread.c: Use C++ exception handling.
3060         * python/py-inferior.c: Use C++ exception handling.
3061         * python/py-gdb-readline.c: Use C++ exception handling.
3062         * python/py-framefilter.c: Use C++ exception handling.
3063         * python/py-frame.c: Use C++ exception handling.
3064         * python/py-finishbreakpoint.c: Use C++ exception handling.
3065         * python/py-cmd.c: Use C++ exception handling.
3066         * python/py-breakpoint.c: Use C++ exception handling.
3067         * python/py-arch.c: Use C++ exception handling.
3068         * printcmd.c: Use C++ exception handling.
3069         * ppc-linux-tdep.c: Use C++ exception handling.
3070         * parse.c: Use C++ exception handling.
3071         * p-valprint.c: Use C++ exception handling.
3072         * objc-lang.c: Use C++ exception handling.
3073         * mi/mi-main.c: Use C++ exception handling.
3074         * mi/mi-interp.c: Use C++ exception handling.
3075         * mi/mi-cmd-stack.c: Use C++ exception handling.
3076         * mi/mi-cmd-break.c: Use C++ exception handling.
3077         * main.c: Use C++ exception handling.
3078         * linux-thread-db.c: Use C++ exception handling.
3079         * linux-tdep.c: Use C++ exception handling.
3080         * linux-nat.c: Use C++ exception handling.
3081         * linux-fork.c: Use C++ exception handling.
3082         * linespec.c: Use C++ exception handling.
3083         * language.c: Use C++ exception handling.
3084         * jit.c: Use C++ exception handling.
3085         * infrun.c: Use C++ exception handling.
3086         * infcmd.c: Use C++ exception handling.
3087         * infcall.c: Use C++ exception handling.
3088         * inf-loop.c: Use C++ exception handling.
3089         * i386-tdep.c: Use C++ exception handling.
3090         * i386-linux-tdep.c: Use C++ exception handling.
3091         * guile/scm-value.c: Use C++ exception handling.
3092         * guile/scm-type.c: Use C++ exception handling.
3093         * guile/scm-symtab.c: Use C++ exception handling.
3094         * guile/scm-symbol.c: Use C++ exception handling.
3095         * guile/scm-pretty-print.c: Use C++ exception handling.
3096         * guile/scm-ports.c: Use C++ exception handling.
3097         * guile/scm-param.c: Use C++ exception handling.
3098         * guile/scm-math.c: Use C++ exception handling.
3099         * guile/scm-lazy-string.c: Use C++ exception handling.
3100         * guile/scm-frame.c: Use C++ exception handling.
3101         * guile/scm-disasm.c: Use C++ exception handling.
3102         * guile/scm-cmd.c: Use C++ exception handling.
3103         * guile/scm-breakpoint.c: Use C++ exception handling.
3104         * guile/scm-block.c: Use C++ exception handling.
3105         * guile/guile-internal.h: Use C++ exception handling.
3106         * gnu-v3-abi.c: Use C++ exception handling.
3107         * gdbtypes.c: Use C++ exception handling.
3108         * frame.c: Use C++ exception handling.
3109         * frame-unwind.c: Use C++ exception handling.
3110         * fbsd-tdep.c: Use C++ exception handling.
3111         * f-valprint.c: Use C++ exception handling.
3112         * exec.c: Use C++ exception handling.
3113         * event-top.c: Use C++ exception handling.
3114         * event-loop.c: Use C++ exception handling.
3115         * eval.c: Use C++ exception handling.
3116         * dwarf2read.c: Use C++ exception handling.
3117         * dwarf2loc.c: Use C++ exception handling.
3118         * dwarf2-frame.c: Use C++ exception handling.
3119         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3120         * dwarf-index-write.c: Use C++ exception handling.
3121         * dwarf-index-cache.c: Use C++ exception handling.
3122         * dtrace-probe.c: Use C++ exception handling.
3123         * disasm-selftests.c: Use C++ exception handling.
3124         * darwin-nat.c: Use C++ exception handling.
3125         * cp-valprint.c: Use C++ exception handling.
3126         * cp-support.c: Use C++ exception handling.
3127         * cp-abi.c: Use C++ exception handling.
3128         * corelow.c: Use C++ exception handling.
3129         * completer.c: Use C++ exception handling.
3130         * compile/compile-object-run.c: Use C++ exception handling.
3131         * compile/compile-object-load.c: Use C++ exception handling.
3132         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3133         * compile/compile-c-symbols.c: Use C++ exception handling.
3134         * common/selftest.c: Use C++ exception handling.
3135         * common/new-op.c: Use C++ exception handling.
3136         * cli/cli-script.c: Use C++ exception handling.
3137         * cli/cli-interp.c: Use C++ exception handling.
3138         * cli/cli-cmds.c: Use C++ exception handling.
3139         * c-varobj.c: Use C++ exception handling.
3140         * btrace.c: Use C++ exception handling.
3141         * breakpoint.c: Use C++ exception handling.
3142         * break-catch-throw.c: Use C++ exception handling.
3143         * arch-utils.c: Use C++ exception handling.
3144         * amd64-tdep.c: Use C++ exception handling.
3145         * ada-valprint.c: Use C++ exception handling.
3146         * ada-typeprint.c: Use C++ exception handling.
3147         * ada-lang.c: Use C++ exception handling.
3148         * aarch64-tdep.c: Use C++ exception handling.
3149
3150 2019-04-08  Tom Tromey  <tom@tromey.com>
3151
3152         * xml-support.c (gdb_xml_parser::parse): Update.
3153         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3154         * value.c (show_convenience): Update.
3155         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3156         (test_parse_flags_qcs): Update.
3157         * thread.c (thr_try_catch_cmd): Update.
3158         * target.c (target_translate_tls_address): Update.
3159         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3160         (info_frame_command_core, frame_apply_command_count): Update.
3161         * rust-exp.y (rust_lex_exception_test): Update.
3162         * riscv-tdep.c (riscv_print_one_register_info): Update.
3163         * remote.c (remote_target::enable_btrace): Update.
3164         * record-btrace.c (record_btrace_enable_warn): Update.
3165         * python/py-utils.c (gdbpy_convert_exception): Update.
3166         * printcmd.c (do_one_display, print_variable_and_value): Update.
3167         * mi/mi-main.c (mi_print_exception): Update.
3168         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3169         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3170         * linux-nat.c (linux_nat_target::attach): Update.
3171         * linux-fork.c (class scoped_switch_fork_info): Update.
3172         * infrun.c (displaced_step_prepare): Update.
3173         * infcall.c (call_function_by_hand_dummy): Update.
3174         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3175         * gnu-v3-abi.c (print_one_vtable): Update.
3176         * frame.c (get_prev_frame_always): Update.
3177         * f-valprint.c (info_common_command_for_block): Update.
3178         * exec.c (try_open_exec_file): Update.
3179         * exceptions.c (print_exception, exception_print)
3180         (exception_fprintf, exception_print_same): Update.
3181         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3182         * dwarf-index-cache.c (index_cache::store)
3183         (index_cache::lookup_gdb_index): Update.
3184         * darwin-nat.c (maybe_cache_shell): Update.
3185         * cp-valprint.c (cp_print_value_fields): Update.
3186         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3187         (gcc_cplus_symbol_address): Update.
3188         * compile/compile-c-symbols.c (gcc_convert_symbol)
3189         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3190         * common/selftest.c: Update.
3191         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3192         a std::string.
3193         (exception_try_scope_entry, exception_try_scope_exit): Don't
3194         declare.
3195         (struct exception_try_scope): Remove.
3196         (TRY): Don't use exception_try_scope.
3197         (struct gdb_exception): Add constructor, operator=.
3198         <what>: New method.
3199         (struct gdb_exception_RETURN_MASK_ALL)
3200         (struct gdb_exception_RETURN_MASK_ERROR)
3201         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3202         (struct gdb_quit_bad_alloc): Update.
3203         * common/common-exceptions.c (exception_none): Change
3204         initializer.
3205         (struct catcher) <state, exception>: Initialize inline.
3206         <prev>: Remove member.
3207         (current_catcher): Remove.
3208         (catchers): New global.
3209         (exceptions_state_mc_init): Simplify.
3210         (catcher_pop): Remove.
3211         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3212         (try_scope_depth, exception_try_scope_entry)
3213         (exception_try_scope_exit): Remove.
3214         (throw_exception_sjlj): Update.
3215         (exception_messages, exception_messages_size): Remove.
3216         (throw_it): Simplify.
3217         (gdb_exception_sliced_copy): Remove.
3218         (throw_exception_cxx): Update.
3219         * cli/cli-script.c (script_from_file): Update.
3220         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3221         Update.
3222         * ada-valprint.c (ada_val_print): Update.
3223         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3224         (create_excep_cond_exprs): Update.
3225
3226 2019-04-08  Tom Tromey  <tom@tromey.com>
3227
3228         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3229         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3230         (TRY, CATCH, END_CATCH): Remove some definitions.
3231         * common/common-exceptions.c: Don't use GDB_XCPT.
3232         (catcher_list_size): Remove.
3233         (throw_exception, throw_it): Simplify.
3234
3235 2019-04-05  Tom Tromey  <tom@tromey.com>
3236
3237         Revert the header-sorting patch.
3238         * ft32-tdep.c: Revert.
3239         * frv-tdep.c: Revert.
3240         * frv-linux-tdep.c: Revert.
3241         * frame.c: Revert.
3242         * frame-unwind.c: Revert.
3243         * frame-base.c: Revert.
3244         * fork-child.c: Revert.
3245         * findvar.c: Revert.
3246         * findcmd.c: Revert.
3247         * filesystem.c: Revert.
3248         * filename-seen-cache.h: Revert.
3249         * filename-seen-cache.c: Revert.
3250         * fbsd-tdep.c: Revert.
3251         * fbsd-nat.h: Revert.
3252         * fbsd-nat.c: Revert.
3253         * f-valprint.c: Revert.
3254         * f-typeprint.c: Revert.
3255         * f-lang.c: Revert.
3256         * extension.h: Revert.
3257         * extension.c: Revert.
3258         * extension-priv.h: Revert.
3259         * expprint.c: Revert.
3260         * exec.h: Revert.
3261         * exec.c: Revert.
3262         * exceptions.c: Revert.
3263         * event-top.c: Revert.
3264         * event-loop.c: Revert.
3265         * eval.c: Revert.
3266         * elfread.c: Revert.
3267         * dwarf2read.h: Revert.
3268         * dwarf2read.c: Revert.
3269         * dwarf2loc.c: Revert.
3270         * dwarf2expr.h: Revert.
3271         * dwarf2expr.c: Revert.
3272         * dwarf2-frame.c: Revert.
3273         * dwarf2-frame-tailcall.c: Revert.
3274         * dwarf-index-write.h: Revert.
3275         * dwarf-index-write.c: Revert.
3276         * dwarf-index-common.c: Revert.
3277         * dwarf-index-cache.h: Revert.
3278         * dwarf-index-cache.c: Revert.
3279         * dummy-frame.c: Revert.
3280         * dtrace-probe.c: Revert.
3281         * disasm.h: Revert.
3282         * disasm.c: Revert.
3283         * disasm-selftests.c: Revert.
3284         * dictionary.c: Revert.
3285         * dicos-tdep.c: Revert.
3286         * demangle.c: Revert.
3287         * dcache.h: Revert.
3288         * dcache.c: Revert.
3289         * darwin-nat.h: Revert.
3290         * darwin-nat.c: Revert.
3291         * darwin-nat-info.c: Revert.
3292         * d-valprint.c: Revert.
3293         * d-namespace.c: Revert.
3294         * d-lang.c: Revert.
3295         * ctf.c: Revert.
3296         * csky-tdep.c: Revert.
3297         * csky-linux-tdep.c: Revert.
3298         * cris-tdep.c: Revert.
3299         * cris-linux-tdep.c: Revert.
3300         * cp-valprint.c: Revert.
3301         * cp-support.c: Revert.
3302         * cp-namespace.c: Revert.
3303         * cp-abi.c: Revert.
3304         * corelow.c: Revert.
3305         * corefile.c: Revert.
3306         * continuations.c: Revert.
3307         * completer.h: Revert.
3308         * completer.c: Revert.
3309         * complaints.c: Revert.
3310         * coffread.c: Revert.
3311         * coff-pe-read.c: Revert.
3312         * cli-out.h: Revert.
3313         * cli-out.c: Revert.
3314         * charset.c: Revert.
3315         * c-varobj.c: Revert.
3316         * c-valprint.c: Revert.
3317         * c-typeprint.c: Revert.
3318         * c-lang.c: Revert.
3319         * buildsym.c: Revert.
3320         * buildsym-legacy.c: Revert.
3321         * build-id.h: Revert.
3322         * build-id.c: Revert.
3323         * btrace.c: Revert.
3324         * bsd-uthread.c: Revert.
3325         * breakpoint.h: Revert.
3326         * breakpoint.c: Revert.
3327         * break-catch-throw.c: Revert.
3328         * break-catch-syscall.c: Revert.
3329         * break-catch-sig.c: Revert.
3330         * blockframe.c: Revert.
3331         * block.c: Revert.
3332         * bfin-tdep.c: Revert.
3333         * bfin-linux-tdep.c: Revert.
3334         * bfd-target.c: Revert.
3335         * bcache.c: Revert.
3336         * ax-general.c: Revert.
3337         * ax-gdb.h: Revert.
3338         * ax-gdb.c: Revert.
3339         * avr-tdep.c: Revert.
3340         * auxv.c: Revert.
3341         * auto-load.c: Revert.
3342         * arm-wince-tdep.c: Revert.
3343         * arm-tdep.c: Revert.
3344         * arm-symbian-tdep.c: Revert.
3345         * arm-pikeos-tdep.c: Revert.
3346         * arm-obsd-tdep.c: Revert.
3347         * arm-nbsd-tdep.c: Revert.
3348         * arm-nbsd-nat.c: Revert.
3349         * arm-linux-tdep.c: Revert.
3350         * arm-linux-nat.c: Revert.
3351         * arm-fbsd-tdep.c: Revert.
3352         * arm-fbsd-nat.c: Revert.
3353         * arm-bsd-tdep.c: Revert.
3354         * arch-utils.c: Revert.
3355         * arc-tdep.c: Revert.
3356         * arc-newlib-tdep.c: Revert.
3357         * annotate.h: Revert.
3358         * annotate.c: Revert.
3359         * amd64-windows-tdep.c: Revert.
3360         * amd64-windows-nat.c: Revert.
3361         * amd64-tdep.c: Revert.
3362         * amd64-sol2-tdep.c: Revert.
3363         * amd64-obsd-tdep.c: Revert.
3364         * amd64-obsd-nat.c: Revert.
3365         * amd64-nbsd-tdep.c: Revert.
3366         * amd64-nbsd-nat.c: Revert.
3367         * amd64-nat.c: Revert.
3368         * amd64-linux-tdep.c: Revert.
3369         * amd64-linux-nat.c: Revert.
3370         * amd64-fbsd-tdep.c: Revert.
3371         * amd64-fbsd-nat.c: Revert.
3372         * amd64-dicos-tdep.c: Revert.
3373         * amd64-darwin-tdep.c: Revert.
3374         * amd64-bsd-nat.c: Revert.
3375         * alpha-tdep.c: Revert.
3376         * alpha-obsd-tdep.c: Revert.
3377         * alpha-nbsd-tdep.c: Revert.
3378         * alpha-mdebug-tdep.c: Revert.
3379         * alpha-linux-tdep.c: Revert.
3380         * alpha-linux-nat.c: Revert.
3381         * alpha-bsd-tdep.c: Revert.
3382         * alpha-bsd-nat.c: Revert.
3383         * aix-thread.c: Revert.
3384         * agent.c: Revert.
3385         * addrmap.c: Revert.
3386         * ada-varobj.c: Revert.
3387         * ada-valprint.c: Revert.
3388         * ada-typeprint.c: Revert.
3389         * ada-tasks.c: Revert.
3390         * ada-lang.c: Revert.
3391         * aarch64-tdep.c: Revert.
3392         * aarch64-ravenscar-thread.c: Revert.
3393         * aarch64-newlib-tdep.c: Revert.
3394         * aarch64-linux-tdep.c: Revert.
3395         * aarch64-linux-nat.c: Revert.
3396         * aarch64-fbsd-tdep.c: Revert.
3397         * aarch64-fbsd-nat.c: Revert.
3398         * aarch32-linux-nat.c: Revert.
3399
3400 2019-04-05  Tom Tromey  <tom@tromey.com>
3401
3402         * ft32-tdep.c: Sort headers.
3403         * frv-tdep.c: Sort headers.
3404         * frv-linux-tdep.c: Sort headers.
3405         * frame.c: Sort headers.
3406         * frame-unwind.c: Sort headers.
3407         * frame-base.c: Sort headers.
3408         * fork-child.c: Sort headers.
3409         * findvar.c: Sort headers.
3410         * findcmd.c: Sort headers.
3411         * filesystem.c: Sort headers.
3412         * filename-seen-cache.h: Sort headers.
3413         * filename-seen-cache.c: Sort headers.
3414         * fbsd-tdep.c: Sort headers.
3415         * fbsd-nat.h: Sort headers.
3416         * fbsd-nat.c: Sort headers.
3417         * f-valprint.c: Sort headers.
3418         * f-typeprint.c: Sort headers.
3419         * f-lang.c: Sort headers.
3420         * extension.h: Sort headers.
3421         * extension.c: Sort headers.
3422         * extension-priv.h: Sort headers.
3423         * expprint.c: Sort headers.
3424         * exec.h: Sort headers.
3425         * exec.c: Sort headers.
3426         * exceptions.c: Sort headers.
3427         * event-top.c: Sort headers.
3428         * event-loop.c: Sort headers.
3429         * eval.c: Sort headers.
3430         * elfread.c: Sort headers.
3431         * dwarf2read.h: Sort headers.
3432         * dwarf2read.c: Sort headers.
3433         * dwarf2loc.c: Sort headers.
3434         * dwarf2expr.h: Sort headers.
3435         * dwarf2expr.c: Sort headers.
3436         * dwarf2-frame.c: Sort headers.
3437         * dwarf2-frame-tailcall.c: Sort headers.
3438         * dwarf-index-write.h: Sort headers.
3439         * dwarf-index-write.c: Sort headers.
3440         * dwarf-index-common.c: Sort headers.
3441         * dwarf-index-cache.h: Sort headers.
3442         * dwarf-index-cache.c: Sort headers.
3443         * dummy-frame.c: Sort headers.
3444         * dtrace-probe.c: Sort headers.
3445         * disasm.h: Sort headers.
3446         * disasm.c: Sort headers.
3447         * disasm-selftests.c: Sort headers.
3448         * dictionary.c: Sort headers.
3449         * dicos-tdep.c: Sort headers.
3450         * demangle.c: Sort headers.
3451         * dcache.h: Sort headers.
3452         * dcache.c: Sort headers.
3453         * darwin-nat.h: Sort headers.
3454         * darwin-nat.c: Sort headers.
3455         * darwin-nat-info.c: Sort headers.
3456         * d-valprint.c: Sort headers.
3457         * d-namespace.c: Sort headers.
3458         * d-lang.c: Sort headers.
3459         * ctf.c: Sort headers.
3460         * csky-tdep.c: Sort headers.
3461         * csky-linux-tdep.c: Sort headers.
3462         * cris-tdep.c: Sort headers.
3463         * cris-linux-tdep.c: Sort headers.
3464         * cp-valprint.c: Sort headers.
3465         * cp-support.c: Sort headers.
3466         * cp-namespace.c: Sort headers.
3467         * cp-abi.c: Sort headers.
3468         * corelow.c: Sort headers.
3469         * corefile.c: Sort headers.
3470         * continuations.c: Sort headers.
3471         * completer.h: Sort headers.
3472         * completer.c: Sort headers.
3473         * complaints.c: Sort headers.
3474         * coffread.c: Sort headers.
3475         * coff-pe-read.c: Sort headers.
3476         * cli-out.h: Sort headers.
3477         * cli-out.c: Sort headers.
3478         * charset.c: Sort headers.
3479         * c-varobj.c: Sort headers.
3480         * c-valprint.c: Sort headers.
3481         * c-typeprint.c: Sort headers.
3482         * c-lang.c: Sort headers.
3483         * buildsym.c: Sort headers.
3484         * buildsym-legacy.c: Sort headers.
3485         * build-id.h: Sort headers.
3486         * build-id.c: Sort headers.
3487         * btrace.c: Sort headers.
3488         * bsd-uthread.c: Sort headers.
3489         * breakpoint.h: Sort headers.
3490         * breakpoint.c: Sort headers.
3491         * break-catch-throw.c: Sort headers.
3492         * break-catch-syscall.c: Sort headers.
3493         * break-catch-sig.c: Sort headers.
3494         * blockframe.c: Sort headers.
3495         * block.c: Sort headers.
3496         * bfin-tdep.c: Sort headers.
3497         * bfin-linux-tdep.c: Sort headers.
3498         * bfd-target.c: Sort headers.
3499         * bcache.c: Sort headers.
3500         * ax-general.c: Sort headers.
3501         * ax-gdb.h: Sort headers.
3502         * ax-gdb.c: Sort headers.
3503         * avr-tdep.c: Sort headers.
3504         * auxv.c: Sort headers.
3505         * auto-load.c: Sort headers.
3506         * arm-wince-tdep.c: Sort headers.
3507         * arm-tdep.c: Sort headers.
3508         * arm-symbian-tdep.c: Sort headers.
3509         * arm-pikeos-tdep.c: Sort headers.
3510         * arm-obsd-tdep.c: Sort headers.
3511         * arm-nbsd-tdep.c: Sort headers.
3512         * arm-nbsd-nat.c: Sort headers.
3513         * arm-linux-tdep.c: Sort headers.
3514         * arm-linux-nat.c: Sort headers.
3515         * arm-fbsd-tdep.c: Sort headers.
3516         * arm-fbsd-nat.c: Sort headers.
3517         * arm-bsd-tdep.c: Sort headers.
3518         * arch-utils.c: Sort headers.
3519         * arc-tdep.c: Sort headers.
3520         * arc-newlib-tdep.c: Sort headers.
3521         * annotate.h: Sort headers.
3522         * annotate.c: Sort headers.
3523         * amd64-windows-tdep.c: Sort headers.
3524         * amd64-windows-nat.c: Sort headers.
3525         * amd64-tdep.c: Sort headers.
3526         * amd64-sol2-tdep.c: Sort headers.
3527         * amd64-obsd-tdep.c: Sort headers.
3528         * amd64-obsd-nat.c: Sort headers.
3529         * amd64-nbsd-tdep.c: Sort headers.
3530         * amd64-nbsd-nat.c: Sort headers.
3531         * amd64-nat.c: Sort headers.
3532         * amd64-linux-tdep.c: Sort headers.
3533         * amd64-linux-nat.c: Sort headers.
3534         * amd64-fbsd-tdep.c: Sort headers.
3535         * amd64-fbsd-nat.c: Sort headers.
3536         * amd64-dicos-tdep.c: Sort headers.
3537         * amd64-darwin-tdep.c: Sort headers.
3538         * amd64-bsd-nat.c: Sort headers.
3539         * alpha-tdep.c: Sort headers.
3540         * alpha-obsd-tdep.c: Sort headers.
3541         * alpha-nbsd-tdep.c: Sort headers.
3542         * alpha-mdebug-tdep.c: Sort headers.
3543         * alpha-linux-tdep.c: Sort headers.
3544         * alpha-linux-nat.c: Sort headers.
3545         * alpha-bsd-tdep.c: Sort headers.
3546         * alpha-bsd-nat.c: Sort headers.
3547         * aix-thread.c: Sort headers.
3548         * agent.c: Sort headers.
3549         * addrmap.c: Sort headers.
3550         * ada-varobj.c: Sort headers.
3551         * ada-valprint.c: Sort headers.
3552         * ada-typeprint.c: Sort headers.
3553         * ada-tasks.c: Sort headers.
3554         * ada-lang.c: Sort headers.
3555         * aarch64-tdep.c: Sort headers.
3556         * aarch64-ravenscar-thread.c: Sort headers.
3557         * aarch64-newlib-tdep.c: Sort headers.
3558         * aarch64-linux-tdep.c: Sort headers.
3559         * aarch64-linux-nat.c: Sort headers.
3560         * aarch64-fbsd-tdep.c: Sort headers.
3561         * aarch64-fbsd-nat.c: Sort headers.
3562         * aarch32-linux-nat.c: Sort headers.
3563
3564 2019-04-04  Tom Tromey  <tom@tromey.com>
3565
3566         * varobj.c (varobj_create): Update.
3567         * rust-exp.y (struct rust_parser) <update_innermost_block,
3568         lookup_symbol>: New methods.
3569         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3570         Rename.
3571         (rust_parser::rust_lookup_type)
3572         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3573         * printcmd.c (display_command, do_one_display): Update.
3574         * parser-defs.h (struct parser_state) <parser_state>: Add
3575         "tracker" parameter.
3576         (block_tracker): New member.
3577         (class innermost_block_tracker) <innermost_block_tracker>: Add
3578         "types" parameter.
3579         <reset>: Remove method.
3580         (innermost_block): Don't declare.
3581         (null_post_parser): Update.
3582         * parse.c (innermost_block): Remove global.
3583         (write_dollar_variable): Update.
3584         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3585         Remove "tracker_types" parameter.
3586         (parse_expression): Add "tracker" parameter.
3587         (parse_expression_for_completion): Update.
3588         (null_post_parser): Add "tracker" parameter.
3589         * p-exp.y: Update rules.
3590         * m2-exp.y: Update rules.
3591         * language.h (struct language_defn) <la_post_parser>: Add
3592         "tracker" parameter.
3593         * go-exp.y: Update rules.
3594         * f-exp.y: Update rules.
3595         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3596         parameter.
3597         * d-exp.y: Update rules.
3598         * c-exp.y: Update rules.
3599         * breakpoint.c (set_breakpoint_condition): Create an
3600         innermost_block_tracker.
3601         (watch_command_1): Likewise.
3602         * ada-lang.c (resolve): Add "tracker" parameter.
3603         (resolve_subexp): Likewise.
3604         * ada-exp.y (write_var_from_sym): Update.
3605
3606 2019-04-04  Tom Tromey  <tom@tromey.com>
3607
3608         * type-stack.h: New file.
3609         * type-stack.c: New file.
3610         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3611         type-stack.h.
3612         (insert_into_type_stack, insert_type, push_type, push_type_int)
3613         (insert_type_address_space, pop_type, pop_type_int)
3614         (pop_typelist, pop_type_stack, append_type_stack)
3615         (push_type_stack, get_type_stack, push_typelist)
3616         (follow_type_instance_flags, follow_types): Don't declare.
3617         * parse.c (type_stack): Remove global.
3618         (parse_exp_in_context): Update.
3619         (insert_into_type_stack, insert_type, push_type, push_type_int)
3620         (insert_type_address_space, pop_type, pop_type_int)
3621         (pop_typelist, pop_type_stack, append_type_stack)
3622         (push_type_stack, get_type_stack, push_typelist)
3623         (follow_type_instance_flags, follow_types): Remove (moved to
3624         type-stack.c).
3625         * f-exp.y (type_stack): New global.
3626         Update rules.
3627         (push_kind_type, f_parse): Update.
3628         * d-exp.y (type_stack): New global.
3629         Update rules.
3630         (d_parse): Update.
3631         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3632         Update rules.
3633         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3634         (HFILES_NO_SRCDIR): Add type-stack.h.
3635
3636 2019-04-04  Tom Tromey  <tom@tromey.com>
3637
3638         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3639         (rust_parser::convert_ast_to_expression, rust_parse)
3640         (rust_lex_test_completion, rust_lex_tests): Update.
3641         * parser-defs.h (struct expr_completion_state): New.
3642         (struct parser_state) <parser_state>: Add completion parameter.
3643         <mark_struct_expression, mark_completion_tag>: New methods.
3644         <parse_completion, m_completion_state>: New members.
3645         (prefixify_expression, null_post_parser): Update.
3646         (mark_struct_expression, mark_completion_tag): Don't declare.
3647         * parse.c (parse_completion, expout_last_struct)
3648         (expout_tag_completion_type, expout_completion_name): Remove
3649         globals.
3650         (parser_state::mark_struct_expression)
3651         (parser_state::mark_completion_tag): Now methods.
3652         (prefixify_expression): Add last_struct parameter.
3653         (prefixify_subexp): Likewise.
3654         (parse_exp_1): Update.
3655         (parse_exp_in_context): Add cstate parameter.  Update.
3656         (parse_expression_for_completion): Create an
3657         expr_completion_state.
3658         (null_post_parser): Add "completion" parameter.
3659         * p-exp.y: Update rules.
3660         (yylex): Update.
3661         * language.h (struct language_defn) <la_post_parser>: Add
3662         "completing" parameter.
3663         * go-exp.y: Update rules.
3664         (lex_one_token): Update.
3665         * expression.h (parse_completion): Don't declare.
3666         * d-exp.y: Update rules.
3667         (lex_one_token): Update rules.
3668         * c-exp.y: Update rules.
3669         (lex_one_token): Update.
3670         * ada-lang.c (resolve): Add "parse_completion" parameter.
3671         (resolve_subexp): Likewise.
3672         (ada_resolve_function): Likewise.
3673
3674 2019-04-04  Tom Tromey  <tom@tromey.com>
3675
3676         * parser-defs.h (struct parser_state) <start_arglist,
3677         end_arglist>: New methods.
3678         <arglist_len, m_funcall_chain>: New members.
3679         (arglist_len, start_arglist, end_arglist): Don't declare.
3680         * parse.c (arglist_len, funcall_chain): Remove global.
3681         (start_arglist, end_arglist): Remove functions.
3682         (parse_exp_in_context): Update.
3683         * p-exp.y: Update rules.
3684         * m2-exp.y: Update rules.
3685         * go-exp.y: Update rules.
3686         * f-exp.y: Update rules.
3687         * d-exp.y: Update rules.
3688         * c-exp.y: Update rules.
3689
3690 2019-04-04  Tom Tromey  <tom@tromey.com>
3691
3692         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3693         lex_operator, push_back>: New methods.
3694         Update all rules.
3695         (rust_parser::lex_hex, lex_escape): Rename and update.
3696         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3697         (rust_parser::lex_operator): Rename and update.
3698         (rust_parser::lex_number, rustyylex, rustyyerror)
3699         (rust_lex_test_init, rust_lex_test_sequence)
3700         (rust_lex_test_push_back, rust_lex_tests): Update.
3701         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3702         parameter.
3703         <lexptr, prev_lexptr>: New members.
3704         (lexptr, prev_lexptr): Don't declare.
3705         * parse.c (lexptr, prev_lexptr): Remove globals.
3706         (parse_exp_in_context): Update.
3707         * p-exp.y (yylex, yyerror): Update.
3708         * m2-exp.y (parse_number, yylex, yyerror): Update.
3709         * go-exp.y (lex_one_token, yyerror): Update.
3710         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3711         * d-exp.y (lex_one_token, yyerror): Update.
3712         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3713         (lex_one_token, yyerror): Update.
3714         * ada-lex.l (YY_INPUT): Update.
3715         (rewind_to_char): Update.
3716         * ada-exp.y (yyerror): Update.
3717
3718 2019-04-04  Tom Tromey  <tom@tromey.com>
3719
3720         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3721         * parser-defs.h (struct parser_state) <parser_state>: Add new
3722         parameter.
3723         <comma_terminates>: New member.
3724         (comma_terminates): Don't declare global.
3725         * parse.c (comma_terminates): Remove global.
3726         (parse_exp_in_context): Update.
3727         * p-exp.y (yylex): Update.
3728         * m2-exp.y (yylex): Update.
3729         * go-exp.y (lex_one_token): Update.
3730         * f-exp.y (yylex): Update.
3731         * d-exp.y (lex_one_token): Update.
3732         * c-exp.y (lex_one_token): Update.
3733         * ada-lex.l: Update.
3734
3735 2019-04-04  Tom Tromey  <tom@tromey.com>
3736
3737         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3738         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3739         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3740         * parser-defs.h (paren_depth): Don't declare.
3741         * parse.c (paren_depth): Remove global.
3742         (parse_exp_in_context): Update.
3743         * p-exp.y (paren_depth): New global.
3744         (pascal_parse): Initialize it.
3745         * m2-exp.y (paren_depth): New global.
3746         (m2_parse): Initialize it.
3747         * go-exp.y (paren_depth): New global.
3748         (go_parse): Initialize it.
3749         * f-exp.y (paren_depth): New global.
3750         (f_parse): Initialize it.
3751         * d-exp.y (paren_depth): New global.
3752         (d_parse): Initialize it.
3753         * c-exp.y (paren_depth): New global.
3754         (c_parse): Initialize it.
3755         * ada-lex.l (paren_depth): New global.
3756         (lexer_init): Initialize it.
3757
3758 2019-04-04  Tom Tromey  <tom@tromey.com>
3759
3760         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3761         (rust_parser::convert_ast_to_type)
3762         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3763         * parser-defs.h (struct parser_state) <parser_state>: Add
3764         parameters.  Initialize new members.
3765         <expression_context_block, expression_context_pc>: New members.
3766         * parse.c (expression_context_block, expression_context_pc):
3767         Remove globals.
3768         (parse_exp_in_context): Update.
3769         * p-exp.y: Update all rules.
3770         (yylex): Update.
3771         * m2-exp.y: Update all rules.
3772         (yylex): Update.
3773         * go-exp.y (yylex): Update.
3774         * f-exp.y (yylex): Update.
3775         * d-exp.y: Update all rules.
3776         (yylex): Update.
3777         * c-exp.y: Update all rules.
3778         (lex_one_token, classify_name, yylex, c_parse): Update.
3779         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3780
3781 2019-04-04  Tom Tromey  <tom@tromey.com>
3782
3783         * gdbarch.h, gdbarch.c: Rebuild.
3784         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3785         * stap-probe.h:
3786         (struct stap_parse_info): Replace "parser_state" with
3787         "expr_builder".
3788         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3789         (parser_state): New class.
3790         * parse.c (expr_builder): Rename.
3791         (expr_builder::release): Rename.
3792         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3793         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3794         (write_exp_elt_longcst, write_exp_elt_floatcst)
3795         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3796         (write_exp_string_vector, write_exp_bitstring)
3797         (write_exp_msymbol, mark_struct_expression)
3798         (write_dollar_variable)
3799         (insert_type_address_space, increase_expout_size): Replace
3800         "parser_state" with "expr_builder".
3801         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3802         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3803         "parser_state" with "expr_builder".
3804
3805 2019-04-04  Tom Tromey  <tom@tromey.com>
3806
3807         * rust-exp.y: Replace "parse_language" with method call.
3808         * p-exp.y:
3809         (yylex): Replace "parse_language" with method call.
3810         * m2-exp.y:
3811         (yylex): Replace "parse_language" with method call.
3812         * go-exp.y (classify_name): Replace "parse_language" with method
3813         call.
3814         * f-exp.y (yylex): Replace "parse_language" with method call.
3815         * d-exp.y (lex_one_token): Replace "parse_language" with method
3816         call.
3817         * c-exp.y:
3818         (lex_one_token, classify_name, yylex): Replace "parse_language"
3819         with method call.
3820         * ada-exp.y (find_primitive_type, type_char)
3821         (type_system_address): Replace "parse_language" with method call.
3822
3823 2019-04-04  Tom Tromey  <tom@tromey.com>
3824
3825         * rust-exp.y: Replace "parse_gdbarch" with method call.
3826         * parse.c (write_dollar_variable, insert_type_address_space):
3827         Replace "parse_gdbarch" with method call.
3828         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3829         call.
3830         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3831         call.
3832         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3833         "parse_gdbarch" with method call.
3834         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3835         with method call.
3836         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3837         "parse_gdbarch" with method call.
3838         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3839         "parse_gdbarch" with method call.
3840         * c-exp.y (parse_type, parse_number, classify_name): Replace
3841         "parse_gdbarch" with method call.
3842         * ada-lex.l: Replace "parse_gdbarch" with method call.
3843         * ada-exp.y (parse_type, find_primitive_type, type_char)
3844         (type_system_address): Replace "parse_gdbarch" with method call.
3845
3846 2019-04-04  Tom Tromey  <tom@tromey.com>
3847
3848         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3849         * stap-probe.c (stap_parse_argument): Update.
3850         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3851         initial_size parameter.
3852         * rust-exp.y (rust_lex_tests): Update.
3853         * parse.c (parser_state): Update.
3854         (parse_exp_in_context): Update.
3855         * parser-defs.h (struct parser_state) <parser_state>: Remove
3856         "initial_size" parameter.
3857
3858 2019-04-04  Tom Tromey  <tom@tromey.com>
3859
3860         * parser-defs.h (increase_expout_size): Don't declare.
3861         * parse.c (increase_expout_size): Now static.
3862
3863 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3864
3865         * gnu-nat.c (gnu_nat_target::wait): Fix
3866         target_waitstatus_to_string call.
3867
3868 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * eval.c (evaluate_subexp_standard): Handle internal functions
3871         during Fortran function call handling.
3872
3873 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * NEWS: Mention new internal functions.
3876         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3877         (read_base_type): Use dwarf2_init_complex_target_type.
3878         * value.c (creal_internal_fn): New function.
3879         (cimag_internal_fn): New function.
3880         (_initialize_values): Register new internal functions.
3881
3882 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3883
3884         * infrun.c (stop_all_threads): If debug_infrun, always
3885         trace the wait status after wait_one, using
3886         target_waitstatus_to_string and target_pid_to_str.
3887         (handle_inferior_event): Replace various trace of
3888         wait status kind by a single trace.
3889         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3890         wait status kind image by target_waitstatus_to_string.
3891         * target/waitstatus.c (target_waitstatus_to_string): Fix
3892         obsolete comment.
3893
3894 2019-04-01  Tom Tromey  <tromey@adacore.com>
3895
3896         PR symtab/23331:
3897         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3898
3899 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3900             Pedro Alves  <palves@redhat.com>
3901
3902         * top.c (quit_force): Call 'finalize_values'.
3903         * value.c (finalize_values): New function.
3904         * value.h (finalize_values): Declare.
3905
3906 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3907
3908         * NEWS: Announce $_gdb_major and $_gdb_minor.
3909
3910         * top.c (init_gdb_version_vars): New function.
3911         (gdb_init): Call init_gdb_version_vars.
3912
3913 2019-03-29  Tom Tromey  <tromey@adacore.com>
3914
3915         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3916         help text.  Remove dead code.
3917
3918 2019-03-29  Keith Seitz  <keiths@redhat.com>
3919
3920         From Siddhesh Poyarekar:
3921         * f-lang.h (f77_get_upperbound): Return LONGEST.
3922         (f77_get_lowerbound): Likewise.
3923         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3924         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3925         print them.
3926         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3927         plongest to format print it.
3928         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3929         (f77_get_upperbound): Likewise.
3930         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3931         LOWER_BOUND to LONGEST.
3932         (f77_create_arrayprint_offset_tbl): Likewise.
3933
3934 2019-03-29  Keith Seitz  <keiths@redhat.com>
3935
3936         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3937         %s/pulongest for TYPE_LENGTH instead of %d in format
3938         strings.
3939         * ada-typerint.c (ada_print_type): Likewise.
3940         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3941         * compile/compile-c-support.c (generate_register_struct): Likewise.
3942         * gdbtypes.c (recursive_dump_type): Likewise.
3943         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3944         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3945         instead of %d in format strings.
3946         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3947         to std::min to ULONGEST.
3948         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3949         instead of %d in format strings.
3950         * tracepoint.c (info_scope_command): Likewise.
3951         * typeprint.c (print_offset_data::update)
3952         (print_offset_data::finish): Likewise.
3953         * xtensa-tdep.c (xtensa_store_return_value)
3954         (xtensa_push_dummy_call): Likewise.
3955
3956 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3957
3958         * windows-nat.c (display_selector): Fixed format specifications
3959         for 64-bit Cygwin.
3960
3961 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3962
3963         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3964
3965 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3966
3967         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3968         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3969         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3970         (nios2_linux_init_abi): Install it.
3971
3972 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3973
3974         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3975
3976 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3977
3978         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3979
3980 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3981             Tom Tromey  <tromey@adacore.com>
3982
3983         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3984
3985 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3986
3987         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3988         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3989         method to compute the bounds of range types. Also print "[evaluated]"
3990         if the bounds' values come from a dynamic evaluation.
3991
3992 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3993
3994         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3995         whitespace when pretty printing is on.
3996
3997 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3998
3999         * ppc-linux-nat.c: Add include.
4000
4001 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4002
4003         * NEWS: Mention AArch64 Pointer Authentication.
4004
4005 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4006
4007         * arm-linux-nat.c: Add include.
4008
4009 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4010
4011         * source-cache.c (source_cache::get_source_lines): Re-read
4012         fullname after calling open_source_file.
4013
4014 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4015
4016         * NEWS: Mention TLS support for FreeBSD.
4017
4018 2019-03-25  Tom Tromey  <tromey@adacore.com>
4019
4020         * minsyms.c (BUNCH_SIZE): Update comment.
4021         (~minimal_symbol_reader): Remove old comment.
4022         (compact_minimal_symbols): Update comment.
4023         (minimal_symbol_reader::install): Remove old comment.  Update
4024         other comments.
4025
4026 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4027
4028         * s390-linux-nat.c: Add include.
4029
4030 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4031
4032         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4033         Call linux_get_hwcap.
4034         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4035         Likewise.
4036         (aarch64_linux_get_hwcap): Remove function.
4037         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4038         declaration.
4039         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4040         linux_get_hwcap.
4041         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4042         * linux-tdep.c (linux_get_hwcap): Add function.
4043         (linux_get_hwcap2): Likewise.
4044         * linux-tdep.h (linux_get_hwcap): Add declaration.
4045         (linux_get_hwcap2): Likewise.
4046         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4047         (ppc_linux_get_hwcap2): Likewise.
4048         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4049         linux_get_hwcap.
4050         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4051         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4052         (ppc_linux_nat_target::read_description): Likewise.
4053         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4054         * s390-linux-nat.c: Likewise.
4055         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4056
4057 2019-03-24  Tom Tromey  <tom@tromey.com>
4058
4059         * ada-lang.c (standard_lookup): Simplify initialization.
4060         (ada_lookup_symbol_nonlocal): Simplify return.
4061         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4062         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4063         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4064         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4065         initialization.
4066         * solib.c (solib_global_lookup): Simplify.
4067         * symtab.c (null_block_symbol): Remove.
4068         (symbol_cache_lookup): Simplify returns.
4069         (lookup_language_this): Simplify returns.
4070         (lookup_symbol_aux): Simplify return.
4071         (lookup_local_symbol): Simplify returns.
4072         (lookup_global_symbol_from_objfile): Simplify return.
4073         (lookup_symbol_in_objfile_symtabs)
4074         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4075         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4076         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4077         * cp-namespace.c (cp_lookup_bare_symbol)
4078         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4079         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4080         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4081         (cp_lookup_symbol_via_imports): Simplify initialization.
4082         (find_symbol_in_baseclass): Likewise.
4083         * symtab.h (null_block_symbol): Remove.
4084         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4085         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4086         (d_lookup_symbol_module): Likewise.
4087         (find_symbol_in_baseclass): Simplify initialization.
4088
4089 2019-03-24  Tom Tromey  <tom@tromey.com>
4090
4091         * expression.h: Don't include symtab.h.
4092         (struct block): Forward declare.
4093
4094 2019-03-24  Tom Tromey  <tom@tromey.com>
4095
4096         * c-exp.y (typebase): Remove casts.
4097         * gdbtypes.c (lookup_unsigned_typename, )
4098         (lookup_signed_typename): Remove cast.
4099         * eval.c (parse_to_comma_and_eval): Remove cast.
4100         * parse.c (write_dollar_variable): Remove cast.
4101         * block.h (struct block) <superblock>: Now const.
4102         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4103         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4104         (map_block): Make "block" const.
4105         * symfile.h (struct quick_symbol_functions)
4106         <map_matching_symbols>: Constify block argument to "callback".
4107         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4108         const.
4109         (find_pc_sect_compunit_symtab): Make "b" const.
4110         (find_symbol_at_address): Likewise.
4111         (search_symbols): Likewise.
4112         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4113         (dw2_debug_names_lookup_symbol): Likewise.
4114         (dw2_map_matching_symbols): Update.
4115         * p-valprint.c (pascal_val_print): Remove "block".
4116         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4117         (aux_add_nonlocal_symbols): Make "block" const.
4118         (resolve_subexp): Remove cast.
4119         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4120         const.
4121         (iterate_over_file_blocks): Likewise.
4122         * f-exp.y (%union) <bval>: Remove.
4123         * coffread.c (patch_opaque_types): Make "b" const.
4124         * spu-tdep.c (spu_catch_start): Make "block" const.
4125         * c-valprint.c (print_unpacked_pointer): Remove "block".
4126         * symmisc.c (dump_symtab_1): Make "b" const.
4127         (block_depth): Make "block" const.
4128         * d-exp.y (%union) <bval>: Remove.
4129         * cp-support.h (cp_lookup_rtti_type): Update.
4130         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4131         * psymtab.c (psym_lookup_symbol): Make "block" const.
4132         (maintenance_check_psymtabs): Make "b" const.
4133         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4134         (enumerate_locals, enumerate_args): Update.
4135         * python/py-symtab.c (stpy_global_block): Make "block" const.
4136         (stpy_static_block): Likewise.
4137         * inline-frame.c (block_starting_point_at): Make "new_block"
4138         const.
4139         * block.c (find_block_in_blockvector): Make return type const.
4140         (blockvector_for_pc_sect): Make "b" const.
4141         (find_block_in_blockvector): Make "b" const.
4142
4143 2019-03-23  Tom Tromey  <tom@tromey.com>
4144
4145         * varobj.c (varobj_create): Update.
4146         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4147         * printcmd.c (display_command, do_one_display): Don't reset
4148         innermost_block.
4149         * parser-defs.h (enum innermost_block_tracker_type): Move to
4150         expression.h.
4151         (innermost_block): Update comment.
4152         * parse.c (parse_exp_1): Add tracker_types parameter.
4153         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4154         tracker_types parameter.  Reset innermost_block.
4155         (parse_exp_in_context): Remove.
4156         (parse_expression_for_completion): Update.
4157         * objfiles.c (~objfile): Don't reset expression_context_block or
4158         innermost_block.
4159         * expression.h (enum innermost_block_tracker_type): Move from
4160         parser-defs.h.
4161         (parse_exp_1): Add tracker_types parameter.
4162         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4163         reset innermost_block.
4164
4165 2019-03-23  Tom Tromey  <tom@tromey.com>
4166
4167         * objfiles.h: Include bcache.h.
4168
4169 2019-03-23  Tom Tromey  <tom@tromey.com>
4170
4171         * linespec.c (get_current_search_block): Use
4172         scoped_restore_current_language.
4173         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4174
4175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4176             Jiong Wang  <jiong.wang@arm.com>
4177
4178         * aarch64-linux-tdep.c
4179         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4180         section.
4181         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4182
4183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4184             Jiong Wang  <jiong.wang@arm.com>
4185
4186         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4187         instructions.
4188         (aarch64_analyze_prologue_test): Add PACIASP test.
4189         (aarch64_prologue_prev_register): Unmask PC value.
4190
4191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4192             Jiong Wang  <jiong.wang@arm.com>
4193
4194         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4195         (aarch64_dwarf2_prev_register): Unmask PC value.
4196         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4197         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4198         DW_CFA_AARCH64_negate_ra_state.
4199         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4200
4201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4202             Jiong Wang  <jiong.wang@arm.com>
4203
4204         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4205         registers.
4206         (aarch64_pseudo_register_name): Likewise.
4207         (aarch64_pseudo_register_type): Likewise.
4208         (aarch64_pseudo_register_reggroup_p): Likewise.
4209         (aarch64_gdbarch_init): Add pauth registers.
4210         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4211         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4212         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4213         (struct gdbarch_tdep): Add regnum for ra_state.
4214
4215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4216             Jiong Wang  <jiong.wang@arm.com>
4217
4218         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4219
4220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4221             Jiong Wang  <jiong.wang@arm.com>
4222
4223         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4224         function.
4225         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4226         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4227         (aarch64_gdbarch_init): Add puth registers.
4228         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4229         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4230         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4231
4232 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4233             Jiong Wang  <jiong.wang@arm.com>
4234
4235         * aarch64-linux-nat.c
4236         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4237         * aarch64-linux-tdep.c
4238         (aarch64_linux_core_read_description): Likewise.
4239         (aarch64_linux_get_hwcap): New function.
4240         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4241         (aarch64_linux_get_hwcap): New declaration.
4242
4243 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4244             Jiong Wang  <jiong.wang@arm.com>
4245
4246         * aarch64-linux-nat.c
4247         (aarch64_linux_nat_target::read_description): Add pauth param.
4248         * aarch64-linux-tdep.c
4249         (aarch64_linux_core_read_description): Likewise.
4250         * aarch64-tdep.c (struct target_desc): Add in pauth.
4251         (aarch64_read_description): Add pauth param.
4252         (aarch64_gdbarch_init): Likewise.
4253         * aarch64-tdep.h (aarch64_read_description): Likewise.
4254         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4255         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4256         * features/Makefile: Add new files.
4257         * features/aarch64-pauth.c: New file.
4258         * features/aarch64-pauth.xml: New file.
4259
4260 2019-03-20  Tom Tromey  <tromey@adacore.com>
4261
4262         * infrun.c (handle_inferior_event): Rename from
4263         handle_inferior_event_1.  Create a scoped_value_mark.
4264         (handle_inferior_event): Remove.
4265
4266 2019-03-19  Tom Tromey  <tromey@adacore.com>
4267
4268         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4269         * infrun.h (print_stop_event): Add "displays" parameter.
4270         * infrun.c (print_stop_event): Add "displays" parameter.
4271
4272 2019-03-19  Pedro Alves  <palves@redhat.com>
4273
4274         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4275         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4276         to -1.  Fix TABs vs spaces.
4277         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4278         * tui/tui-out.h (tui_ui_out) Add intro comments.
4279         <m_line, m_start_of_line>: In-class initialize, and add describing
4280         comment.
4281
4282 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4283
4284         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4285         variable names.
4286         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4287
4288 2019-03-18  Pedro Alves  <palves@redhat.com>
4289             Eli Zaretskii <eliz@gnu.org>
4290
4291         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4292         m_line and m_start_of_line.
4293
4294 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4295
4296         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4297         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4298         it returns a newline.  This fixes a regression in TU mode, whereby
4299         the next line is output on the same screen line as the user input.
4300
4301 2019-03-18  Tom Tromey  <tromey@adacore.com>
4302
4303         * minsyms.c (minimal_symbol_reader::install): Remove call to
4304         obstack_blank.
4305
4306 2019-03-18  Pedro Alves  <palves@redhat.com>
4307
4308         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4309         New globals.
4310         (apply_style): New, factored out from ...
4311         (apply_ansi_escape): ... this.  Handle reverse video mode.
4312         (tui_set_reverse_mode): New function.
4313         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4314         * tui/tui-winsource.c (tui_show_source_line): Use
4315         tui_set_reverse_mode instead of setting A_STANDOUT.
4316         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4317         New setter methods.
4318
4319 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4320
4321         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4322         Handle tabs.
4323
4324 2019-03-18  Tom Tromey  <tromey@adacore.com>
4325
4326         * ada-lang.c (empty_array): Add "high" parameter.
4327         (ada_evaluate_subexp): Update.
4328
4329 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4330
4331         * unittests/string_view-selftests.c: Define
4332         _initialize_string_view_selftests unconditionally.
4333
4334 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4335
4336         PR gdb/24350
4337         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4338
4339 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4340
4341         PR gdb/24351
4342         * windows-nat.c (display_selector): Fix format specifiers.
4343
4344 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4345
4346         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4347         tui_refill_source_window instead of tui_refresh_win, to update the
4348         current execution line.  This fixes redisplay of the current line
4349         when stepping through the code with "next" or "step".
4350
4351 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4352
4353         * source-cache.c (source_cache::get_source_lines): Call
4354         find_source_lines to initialize s->nlines.  This fixes vertical
4355         scrolling of TUI source window when the DOWN arrow is pressed.
4356
4357 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4358
4359         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4360         linux-thread-db.c (_initialize_thread_db): Likewise.
4361
4362 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4363
4364         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4365         wclrtoeol in tui_show_source_line".  This reverts changes made in
4366         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4367
4368 2019-03-15  Tom Tromey  <tom@tromey.com>
4369
4370         * symtab.h (struct minimal_symbol): Derive from
4371         general_symbol_info.
4372         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4373         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4374         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4375         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4376         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4377         (MSYMBOL_SEARCH_NAME): Update.
4378         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4379         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4380         * minsyms.c (minimal_symbol_reader::record_full): Update.
4381
4382 2019-03-15  Tom Tromey  <tom@tromey.com>
4383
4384         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4385
4386 2019-03-15  Tom Tromey  <tom@tromey.com>
4387
4388         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4389         unique_xmalloc_ptr.
4390         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4391         Update.
4392         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4393         (build_minimal_symbol_hash_tables)
4394         (minimal_symbol_reader::install): Update.
4395
4396 2019-03-15  Tom Tromey  <tom@tromey.com>
4397
4398         * symtab.c (create_demangled_names_hash): Update.
4399         (symbol_set_names): Update.
4400         * objfiles.h (struct objfile_per_bfd_storage)
4401         <demangled_names_hash>: Now an htab_up.
4402         * objfiles.c (objfile_per_bfd_storage): Simplify.
4403
4404 2019-03-15  Tom Tromey  <tom@tromey.com>
4405
4406         * objfiles.h (struct objfile_per_bfd_storage): Declare
4407         destructor.
4408         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4409         New.
4410         (get_objfile_bfd_data): Use new.  Don't initialize
4411         language_of_main.
4412         (free_objfile_per_bfd_storage): Remove.
4413         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4414
4415 2019-03-15  Tom Tromey  <tom@tromey.com>
4416
4417         * symfile.c (reread_symbols): Update.
4418         * objfiles.c (objfile::objfile): Update.
4419         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4420         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4421         comment.
4422         (minimal_symbol_reader::install): Update.
4423         (terminate_minimal_symbol_table): Remove.
4424         * jit.c (jit_object_close_impl): Update.
4425
4426 2019-03-15  Tom Tromey  <tom@tromey.com>
4427
4428         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4429         initializations.
4430
4431 2019-03-15  Tom Tromey  <tom@tromey.com>
4432
4433         * objfiles.h (struct objfile_per_bfd_storage)
4434         <demangled_hash_languages>: Now a bitset.
4435         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4436         (lookup_minimal_symbol): Update.
4437
4438 2019-03-15  Tom Tromey  <tom@tromey.com>
4439
4440         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4441         Don't return the symbol.
4442         * coffread.c (record_minimal_symbol): Use record_full.
4443
4444 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4445
4446         The MS-Windows port of ncurses fails to switch to a color pair if
4447         one or both of the colors are the implicit default colors.  This
4448         change records the default colors when TUI is initialized, and
4449         then specifies them explicitly when a color pair uses the default
4450         colors.  This allows color styling in TUI mode on MS-Windows.
4451
4452         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4453         ncurses_norm_attr.
4454         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4455         colors in ncurses_norm_attr.
4456         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4457         "none", replace it with the default color recorded in
4458         ncurses_norm_attr.
4459
4460 2019-03-14  Tom Tromey  <tromey@adacore.com>
4461
4462         * source-cache.h (class source_cache) <get_source_lines>: Return
4463         std::string.
4464         * source-cache.c (source_cache::extract_lines): Handle case where
4465         first_pos==npos.  Return std::string.
4466         (source_cache::get_source_lines): Update.
4467
4468 2019-03-14  Tom Tromey  <tromey@adacore.com>
4469
4470         * NEWS: Add item for "style sources" commands.
4471         * source-cache.c (source_cache::get_source_lines): Check
4472         source_styling.
4473         * cli/cli-style.c (source_styling): New global.
4474         (_initialize_cli_style): Add "style sources" commands.
4475         (show_style_sources): New function.
4476         * cli/cli-style.h (source_styling): Declare.
4477
4478 2019-03-14  Pedro Alves  <palves@redhat.com>
4479             Tom Tromey  <tromey@adacore.com>
4480
4481         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4482         * tui/tui-winsource.c (tui_refill_source_window): New function,
4483         from...
4484         (tui_horizontal_source_scroll): ... here.  Move some logic.
4485         * cli/cli-style.c (set_style_enabled): Notify new observable.
4486         * tui/tui-hooks.c (tui_redisplay_source): New function.
4487         (tui_attach_detach_observers): Attach or detach
4488         tui_redisplay_source.
4489         * observable.h (source_styling_changed): New observable.
4490         * observable.c: Define source_styling_changed observable.
4491
4492 2019-03-13  Tom Tromey  <tromey@adacore.com>
4493
4494         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4495         (i386_gnu_nat_target::store_registers): Update.
4496         * target-debug.h (target_debug_print_std_string): New macro.
4497         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4498         * windows-tdep.c (display_one_tib): Update.
4499         * tui/tui-stack.c (tui_make_status_line): Update.
4500         * top.c (print_inferior_quit_action): Update.
4501         * thread.c (thr_try_catch_cmd): Update.
4502         (add_thread_with_info): Update.
4503         (thread_target_id_str): Update.
4504         (thr_try_catch_cmd): Update.
4505         (thread_command): Update.
4506         (thread_find_command): Update.
4507         * record-btrace.c (record_btrace_target::info_record)
4508         (record_btrace_resume_thread, record_btrace_target::resume)
4509         (record_btrace_cancel_resume, record_btrace_step_thread)
4510         (record_btrace_target::wait, record_btrace_target::wait)
4511         (record_btrace_target::wait, record_btrace_target::stop): Update.
4512         * progspace.c (print_program_space): Update.
4513         * process-stratum-target.c
4514         (process_stratum_target::thread_address_space): Update.
4515         * linux-fork.c (linux_fork_mourn_inferior)
4516         (detach_checkpoint_command, info_checkpoints_command)
4517         (linux_fork_context): Update.
4518         (linux_fork_detach): Update.
4519         (class scoped_switch_fork_info): Update.
4520         (delete_checkpoint_command): Update.
4521         * infrun.c (follow_fork_inferior): Update.
4522         (follow_fork_inferior): Update.
4523         (proceed_after_vfork_done): Update.
4524         (handle_vfork_child_exec_or_exit): Update.
4525         (follow_exec): Update.
4526         (displaced_step_prepare_throw): Update.
4527         (displaced_step_restore): Update.
4528         (start_step_over): Update.
4529         (resume_1): Update.
4530         (clear_proceed_status_thread): Update.
4531         (proceed): Update.
4532         (print_target_wait_results): Update.
4533         (do_target_wait): Update.
4534         (context_switch): Update.
4535         (stop_all_threads): Update.
4536         (restart_threads): Update.
4537         (finish_step_over): Update.
4538         (handle_signal_stop): Update.
4539         (switch_back_to_stepped_thread): Update.
4540         (keep_going_pass_signal): Update.
4541         (print_exited_reason): Update.
4542         (normal_stop): Update.
4543         * inferior.c (inferior_pid_to_str): Change return type.
4544         (print_selected_inferior): Update.
4545         (add_inferior): Update.
4546         (detach_inferior): Update.
4547         * dummy-frame.c (fprint_dummy_frames): Update.
4548         * dcache.c (dcache_info_1): Update.
4549         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4550         (btrace_fetch, btrace_clear): Update.
4551         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4552         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4553         type.
4554         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4555         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4556         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4557         * gdbarch.c, gdbarch.h: Rebuild.
4558         * gdbarch.sh (core_pid_to_str): Change return type.
4559         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4560         return type.
4561         (windows_nat_target::pid_to_str): Change return type.
4562         (windows_delete_thread): Update.
4563         (windows_nat_target::attach): Update.
4564         (windows_nat_target::files_info): Update.
4565         * target-delegates.c: Rebuild.
4566         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4567         return type.
4568         (sol_thread_target::pid_to_str): Change return type.
4569         * remote.c (class remote_target) <pid_to_str>: Change return
4570         type.
4571         (remote_target::pid_to_str): Change return type.
4572         (extended_remote_target::attach, remote_target::remote_stop_ns)
4573         (remote_target::remote_notif_remove_queued_reply)
4574         (remote_target::push_stop_reply, remote_target::disable_btrace):
4575         Update.
4576         (extended_remote_target::attach): Update.
4577         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4578         type.
4579         (gdbsim_target::pid_to_str): Change return type.
4580         * ravenscar-thread.c (struct ravenscar_thread_target)
4581         <pid_to_str>: Change return type.
4582         (ravenscar_thread_target::pid_to_str): Change return type.
4583         * procfs.c (class procfs_target) <pid_to_str>: Change return
4584         type.
4585         (procfs_target::pid_to_str): Change return type.
4586         (procfs_target::attach): Update.
4587         (procfs_target::detach): Update.
4588         (procfs_target::fetch_registers): Update.
4589         (procfs_target::store_registers): Update.
4590         (procfs_target::wait): Update.
4591         (procfs_target::files_info): Update.
4592         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4593         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4594         return type.
4595         (nto_procfs_target::pid_to_str): Change return type.
4596         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4597         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4598         return type.
4599         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4600         (exit_lwp): Update.
4601         (attach_proc_task_lwp_callback, get_detach_signal)
4602         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4603         (linux_nat_target::resume, wait_lwp, stop_callback)
4604         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4605         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4606         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4607         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4608         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4609         type.
4610         (inf_ptrace_target::attach): Update.
4611         (inf_ptrace_target::files_info): Update.
4612         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4613         type.
4614         (go32_nat_target::pid_to_str): Change return type.
4615         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4616         (gnu_nat_target::wait): Update.
4617         (gnu_nat_target::wait): Update.
4618         (gnu_nat_target::resume): Update.
4619         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4620         (fbsd_nat_target::wait): Update.
4621         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4622         type.
4623         (darwin_nat_target::attach): Update.
4624         * corelow.c (class core_target) <pid_to_str>: Change return type.
4625         (core_target::pid_to_str): Change return type.
4626         * target.c (normal_pid_to_str): Change return type.
4627         (default_pid_to_str): Likewise.
4628         (target_pid_to_str): Change return type.
4629         (target_translate_tls_address): Update.
4630         (target_announce_detach): Update.
4631         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4632         return type.
4633         (bsd_uthread_target::pid_to_str): Change return type.
4634         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4635         type.
4636         (bsd_kvm_target::pid_to_str): Change return type.
4637         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4638         return type.
4639         (aix_thread_target::pid_to_str): Change return type.
4640         * target.h (struct target_ops) <pid_to_str>: Change return type.
4641         (target_pid_to_str, normal_pid_to_str): Likewise.
4642         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4643         type.
4644         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4645         type.
4646         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4647         return type.
4648         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4649         type.
4650         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4651         type.
4652         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4653         return type.
4654
4655 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4656
4657         * NEWS: Mention that the new default MI version is 3.  Mention
4658         changes to the output of commands and events that deal with
4659         multi-location breakpoints.
4660         * breakpoint.c: Include "mi/mi-out.h".
4661         (print_one_breakpoint): Change output syntax if using MI version
4662         >= 3.
4663         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4664         New.
4665         (mi_multi_location_breakpoint_output_fixed): New.
4666         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4667         (mi_cmd_fix_multi_location_breakpoint_output): New.
4668         (mi_multi_location_breakpoint_output_fixed): New.
4669         * mi/mi-cmds.c (mi_cmds): Register command
4670         -fix-multi-location-breakpoint-output.
4671         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4672         interpreter "mi".
4673
4674 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4675
4676         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4677         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4678         instantiate mi_ui_out based on interpreter name.
4679         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4680         * mi/mi-main.c (mi_load_progress): Likewise.
4681
4682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4683
4684         * NEWS: Combine separate "New targets" sections for 8.3.
4685
4686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4687
4688         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4689         (ppcfbsd_init_abi): Install gdbarch
4690         "fetch_tls_load_module_address" and "get_thread_local_address"
4691         methods.
4692
4693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4694
4695         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4696         (riscv_fbsd_init_abi): Install gdbarch
4697         "fetch_tls_load_module_address" and "get_thread_local_address"
4698         methods.
4699
4700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4701
4702         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4703         (i386fbsd_init_abi): Install gdbarch
4704         "fetch_tls_load_module_address" and "get_thread_local_address"
4705         methods.
4706
4707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4708
4709         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4710         (amd64fbsd_init_abi): Install gdbarch
4711         "fetch_tls_load_module_address" and "get_thread_local_address"
4712         methods.
4713
4714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4715
4716         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4717         (struct fbsd_pspace_data): New type.
4718         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4719         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4720         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4721         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4722         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4723
4724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4725
4726         * gdbtypes.c (lookup_struct_elt): New function.
4727         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4728         * gdbtypes.h (struct struct_elt): New type.
4729         (lookup_struct_elt): New prototype.
4730
4731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4732
4733         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4734         remove disabled code block.
4735
4736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4737
4738         * gdbarch.sh (get_thread_local_address): New method.
4739         * gdbarch.h, gdbarch.c: Regenerate.
4740         * target.c (target_translate_tls_address): Use
4741         gdbarch_get_thread_local_address if present instead of
4742         target::get_thread_local_address.
4743
4744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4745
4746         * target.h (target::get_thread_local_address): Update comment.
4747
4748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4749
4750         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4751         objfile->separate_debug_objfile_backlink if not NULL.
4752
4753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4754
4755         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4756         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4757         (amd64bsd_store_inferior_registers): Likewise.
4758         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4759         Enable segment base registers.
4760         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4761         PT_GETFSBASE and PT_GETGSBASE.
4762         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4763         PT_SETGSBASE.
4764         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4765         segment base registers.
4766         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4767
4768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4769
4770         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4771         Update calls to i386_target_description to add 'segments'
4772         parameter.
4773         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4774         add segment base registers.
4775         * arch/i386.c (i386_create_target_description): Add 'segments'
4776         parameter to enable segment base registers.
4777         * arch/i386.h (i386_create_target_description): Likewise.
4778         * features/i386/32bit-segments.xml: New file.
4779         * features/i386/32bit-segments.c: Generate.
4780         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4781         call to i386_target_description to add 'segments' parameter.
4782         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4783         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4784         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4785         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4786         if feature is present.
4787         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4788         Add 'segments' parameter to call to i386_target_description.
4789         (i386_target_description): Add 'segments' parameter to enable
4790         segment base registers.
4791         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4792         to call to i386_target_description.
4793         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4794         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4795         Define I386_NUM_REGS.
4796         (i386_target_description): Add 'segments' parameter to enable
4797         segment base registers.
4798
4799 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4800
4801         PR/24325
4802         * source-cache.c: #undef open and close, to avoid unresolved
4803         externals during linking.
4804
4805 2019-03-12  Tom Tromey  <tromey@adacore.com>
4806
4807         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4808         const.  Add initializers.
4809         (_initialize_remote): Don't initialize ptid globals.
4810
4811 2019-03-12  Pedro Alves  <palves@redhat.com>
4812
4813         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4814
4815 2019-03-12  Pedro Alves  <palves@redhat.com>
4816
4817         * cp-name-parser.y (main): Remove unused 'len' variable.
4818
4819 2019-03-12  Tom Tromey  <tromey@adacore.com>
4820
4821         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4822         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4823
4824 2019-03-12  Tom Tromey  <tromey@adacore.com>
4825
4826         * linux-nat.c (iterate_over_lwps): Update.
4827         (stop_callback): Remove parameter.
4828         (stop_wait_callback, detach_callback, resume_set_callback)
4829         (select_singlestep_lwp_callback, set_ignore_sigint)
4830         (status_callback, resumed_callback, resume_clear_callback)
4831         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4832         data parameter.
4833         (linux_nat_target::detach, linux_nat_target::resume)
4834         (linux_stop_and_wait_all_lwps, select_event_lwp)
4835         (linux_nat_filter_event, linux_nat_wait_1)
4836         (linux_nat_target::kill, linux_nat_target::stop)
4837         (linux_nat_target::stop): Update.
4838         (linux_nat_resume_callback): Change type.
4839         (resume_stopped_resumed_lwps, count_events_callback)
4840         (select_event_lwp_callback): Likewise.
4841         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4842         * arm-linux-nat.c (struct update_registers_data): Remove.
4843         (update_registers_callback): Change type.
4844         (arm_linux_insert_hw_breakpoint1): Update.
4845         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4846         parameter.
4847         (x86_linux_dr_set_addr): Update.
4848         (x86_linux_dr_set_control): Update.
4849         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4850         (iterate_over_lwps): Use gdb::function_view.
4851         * nat/aarch64-linux-hw-point.c (struct
4852         aarch64_dr_update_callback_param): Remove.
4853         (debug_reg_change_callback): Change type.
4854         (aarch64_notify_debug_reg_change): Update.
4855         * s390-linux-nat.c (s390_refresh_per_info): Update.
4856
4857 2019-03-11  Tom Tromey  <tromey@adacore.com>
4858
4859         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4860         redundant assignment to "this_cu".
4861
4862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4863
4864         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4865
4866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4867
4868         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4869         from...
4870         (rank_one_type): ... this.
4871
4872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4873
4874         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4875         from...
4876         (rank_one_type): ... this.
4877
4878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4879
4880         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4881         from...
4882         (rank_one_type): ... this.
4883
4884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4885
4886         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4887         from...
4888         (rank_one_type): ... this.
4889
4890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4891
4892         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4893         from...
4894         (rank_one_type): ... this.
4895
4896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4897
4898         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4899         from...
4900         (rank_one_type): ... this.
4901
4902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4903
4904         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4905         from...
4906         (rank_one_type): ... this.
4907
4908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4909
4910         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4911         from...
4912         (rank_one_type): ... this.
4913
4914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4915
4916         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4917         from...
4918         (rank_one_type): ... this.
4919
4920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4921
4922         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4923         from...
4924         (rank_one_type): ... this.
4925
4926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4929         from...
4930         (rank_one_type): ... this.
4931
4932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4933
4934         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4935         from...
4936         (rank_one_type): ... this.
4937
4938 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4939
4940         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4941         inferior-events' shows the example events.
4942
4943 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4944
4945         Support styling on native MS-Windows console
4946
4947         PR/24315
4948         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4949         on MS-Windows if $TERM is not defined.
4950
4951         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4952
4953         * posix-hdep.c (gdb_console_fputs):
4954         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4955         functions.
4956         * ui-file.h (gdb_console_fputs): Add prototype.
4957
4958         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4959         back to fputs only if the former returns zero.
4960
4961 2019-03-07  Tom Tromey  <tom@tromey.com>
4962
4963         * symmisc.c (print_symbol_bcache_statistics): Update.
4964         (print_objfile_statistics): Update.
4965         * symfile.c (allocate_symtab): Update.
4966         * stabsread.c: Don't include bcache.h.
4967         * psymtab.h (struct psymbol_bcache): Don't declare.
4968         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4969         (psymbol_bcache_init, psymbol_bcache_free)
4970         (psymbol_bcache_get_bcache): Don't declare.
4971         * psymtab.c (struct psymbol_bcache): Remove.
4972         (psymtab_storage::psymtab_storage): Update.
4973         (psymtab_storage::~psymtab_storage): Update.
4974         (psymbol_bcache_init, psymbol_bcache_free)
4975         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4976         (add_psymbol_to_bcache): Update.
4977         (allocate_psymtab): Update.
4978         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4979         macro_cache>: No longer pointers.
4980         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4981         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4982         * macrotab.c (macro_bcache): Update.
4983         * macroexp.c: Don't include bcache.h.
4984         * gdbtypes.c (check_types_worklist): Update.
4985         (types_deeply_equal): Remove TRY/CATCH.  Update.
4986         * elfread.c (elf_symtab_read): Update.
4987         * dwarf2read.c: Don't include bcache.h.
4988         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4989         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4990         (print_bcache_statistics, bcache_memory_used): Don't declare.
4991         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4992         methods.  Rename all data members.
4993         * bcache.c (struct bcache): Move to bcache.h.
4994         (bcache::expand_hash_table): Rename from expand_hash_table.
4995         (bcache): Remove.
4996         (bcache::insert): Rename from bcache_full.
4997         (bcache::compare): Rename from bcache_compare.
4998         (bcache_xmalloc): Remove.
4999         (bcache::~bcache): Rename from bcache_xfree.
5000         (bcache::print_statistics): Rename from print_bcache_statistics.
5001         (bcache::memory_used): Rename from bcache_memory_used.
5002
5003 2019-03-07  Pedro Alves  <palves@redhat.com>
5004
5005         * infrun.c (normal_stop): Also check for
5006         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5007
5008 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * f-lang.c (value_from_host_double): Moved to...
5011         * value.c (value_from_host_double): ...here.
5012         * value.h (value_from_host_double): Declare.
5013         * guile/scm-math.c (vlscm_convert_typed_number): Use
5014         value_from_host_double.
5015         (vlscm_convert_number): Likewise.
5016         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5017         * python/py-value.c (convert_value_from_python): Likewise.
5018
5019 2019-03-06  Tom Tromey  <tom@tromey.com>
5020
5021         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5022
5023 2019-03-06  Tom Tromey  <tom@tromey.com>
5024
5025         * utils.h (free_current_contents): Don't declare.
5026         * utils.c (free_current_contents): Remove.
5027
5028 2019-03-06  Tom Tromey  <tom@tromey.com>
5029
5030         * top.c (quit_force): Update.
5031         * main.c (captured_command_loop): Update.
5032         * common/new-op.c (operator new): Update.
5033         * common/common-exceptions.c (struct catcher)
5034         <save_cleanup_chain>: Remove member.
5035         (exceptions_state_mc_init): Update.
5036         (exception_try_scope_entry): Return nullptr.
5037         (exception_try_scope_exit, exception_rethrow)
5038         (throw_exception_sjlj, throw_exception_cxx): Update.
5039         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5040         (all_cleanups, do_cleanups, discard_cleanups)
5041         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5042         (restore_cleanups, restore_final_cleanups): Don't declare.
5043         (do_final_cleanups): Remove parameter.
5044         * common/cleanups.c (cleanup_chain, make_cleanup)
5045         (make_cleanup_dtor, all_cleanups, do_cleanups)
5046         (discard_my_cleanups, discard_cleanups)
5047         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5048         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5049         (null_cleanup): Remove.
5050         (do_final_cleanups): Remove parameter.
5051
5052 2019-03-06  Tom Tromey  <tom@tromey.com>
5053
5054         * remote.c (remote_target::remote_parse_stop_reply): Use
5055         unique_xmalloc_ptr.
5056
5057 2019-03-06  Tom Tromey  <tom@tromey.com>
5058
5059         * stabsread.c (struct stabs_field_info): Rename from field_info.
5060         <list, fnlist>: Add initializers.
5061         <obstack>: New member.
5062         (read_member_functions, read_struct_fields, read_baseclasses):
5063         Allocate on obstack.  Don't use cleanups.
5064         (read_one_struct_field, read_member_functions, read_struct_fields)
5065         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5066         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5067         (read_struct_type): Update.
5068
5069 2019-03-06  Tom Tromey  <tom@tromey.com>
5070
5071         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5072         * common/filestuff.h (make_cleanup_close): Don't declare.
5073         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5074         Remove.
5075
5076 2019-03-06  Tom Tromey  <tom@tromey.com>
5077
5078         * solib-aix.c: Use make_scope_exit.
5079
5080 2019-03-06  Tom Tromey  <tom@tromey.com>
5081
5082         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5083         Use make_scope_exit.
5084
5085 2019-03-06  Tom Tromey  <tom@tromey.com>
5086
5087         * solib-svr4.c (disable_probes_interface): Remove parameter.
5088         (svr4_handle_solib_event): Use make_scope_exit.
5089
5090 2019-03-06  Tom Tromey  <tom@tromey.com>
5091
5092         * remote.c (struct stop_reply_deleter): Remove.
5093         (stop_reply_up): Update.
5094         (struct stop_reply): Derive from notif_event.  Don't typedef.
5095         <regcache>: Now a std::vector.
5096         (stop_reply_xfree): Remove.
5097         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5098         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5099         (remote_target::discard_pending_stop_replies): Use delete.
5100         (remote_target::remote_parse_stop_reply): Update.
5101         (remote_target::process_stop_reply): Update.
5102         * remote-notif.h (struct notif_event): Add virtual destructor.
5103         Remove "dtr" member.
5104         (struct notif_client) <alloc_event>: Return a unique_ptr.
5105         (notif_event_xfree): Don't declare.
5106         (notif_event_up): New typedef.
5107         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5108         (notif_event_xfree, do_notif_event_xfree): Remove.
5109         (remote_notif_state_xfree): Update.
5110
5111 2019-03-06  Tom Tromey  <tom@tromey.com>
5112
5113         * infrun.c (displaced_step_clear_cleanup): Now a
5114         forward_scope_exit type.
5115         (displaced_step_prepare_throw): Update.
5116         (displaced_step_fixup): Update.
5117
5118 2019-03-06  Tom Tromey  <tom@tromey.com>
5119
5120         * inferior.h (class inferior): Update comment.
5121         * gdbthread.h (class thread_info): Update comment.
5122
5123 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5124             Tom Tromey  <tom@tromey.com>
5125
5126         * stabsread.h (struct stab_section_list): Remove.
5127         (coffstab_build_psymtabs): Update.
5128         * dbxread.c (symbuf_sections): Now a std::vector.
5129         (sect_idx): New global.
5130         (fill_symbuf): Update.
5131         (coffstab_build_psymtabs): Change type of stabsects parameter.
5132         Update.
5133         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5134         std::vector.
5135         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5136         (coff_locate_sections): Update.
5137         (coff_symfile_read): Remove cleanups.  Update.
5138         (init_stringtab): Add storage parameter.
5139         (free_stringtab, free_stringtab_cleanup): Remove.
5140         (init_lineno): Add storage parameter.
5141         (free_linetab, free_linetab_cleanup): Remove.
5142
5143 2019-03-06  Pedro Alves  <palves@redhat.com>
5144
5145         * linux-fork.c (fork_info::clobber_regs): Delete.
5146         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5147         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5148         comment.  Adjust.
5149         (scoped_switch_fork_info::scoped_switch_fork_info)
5150         (checkpoint_command, linux_fork_context): Adjust
5151         fork_save_infrun_state calls.
5152
5153 2019-03-06  Pedro Alves  <palves@redhat.com>
5154
5155         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5156         (inf_has_multiple_threads): Return 'bool' and rewrite using
5157         inferior_info::threads().
5158
5159 2019-03-06  Pedro Alves  <palves@redhat.com>
5160
5161         * linux-fork.c: Include <list>.
5162         (fork_list): Now a std::list instance.
5163         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5164         (forks_exist_p, find_last_fork): Adjust.
5165         (new_fork): Delete.
5166         (one_fork_p): New.
5167         (add_fork): Adjust.
5168         (free_fork): Delete, folded into fork_info::~fork_info().
5169         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5170         Adjust.
5171         (init_fork_list): Delete.
5172         (linux_fork_killall, linux_fork_mourn_inferior)
5173         (linux_fork_detach, info_checkpoints_command): Adjust.
5174         (_initialize_linux_fork): No longer call init_fork_list.
5175
5176 2019-03-06  Pedro Alves  <palves@redhat.com>
5177
5178         * linux-fork.c (new_fork): New, split out of ...
5179         (add_fork): ... this.  Return void.  Move "first fork" special
5180         case from here, to ...
5181         (checkpoint_command): ... here.
5182         * linux-linux.h (add_fork): Return void.
5183
5184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5185
5186         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5187
5188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5189             Chris January  <chris.january@arm.com>
5190             David Lecomber  <david.lecomber@arm.com>
5191
5192         * f-exp.y: New token, UNOP_INTRINSIC.
5193         (exp): New pattern using UNOP_INTRINSIC token.
5194         (f77_keywords): Add 'abs' keyword.
5195         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5196         (value_from_host_double): New function.
5197         (evaluate_subexp_f): Support UNOP_ABS.
5198
5199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5200
5201         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5202         types.
5203
5204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5205
5206         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5207         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5208         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5209
5210 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5211
5212         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5213
5214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5215             Chris January  <chris.january@arm.com>
5216
5217         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5218         * f-exp.y: Define 'KIND' token.
5219         (exp): New pattern for KIND expressions.
5220         (ptype): Handle types with a kind extension.
5221         (direct_abs_decl): Extend to spot kind extensions.
5222         (f77_keywords): Add 'kind' to the list.
5223         (push_kind_type): New function.
5224         (convert_to_kind_type): New function.
5225         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5226         * parse.c (operator_length_standard): Likewise.
5227         * parser-defs.h (enum type_pieces): Add tp_kind.
5228         * std-operator.def: Add UNOP_KIND.
5229
5230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * f-exp.y (f_parse): Set yydebug.
5233
5234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * f-lang.c (evaluate_subexp_f): New function.
5237         (exp_descriptor_f): New global.
5238         (f_language_defn): Use exp_descriptor_f instead of
5239         exp_descriptor_standard.
5240
5241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5242
5243         * f-exp.y (struct token): Add comments.
5244         (dot_ops): Remove uppercase versions and the end marker.
5245         (f77_keywords): Likewise.
5246         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5247         entries in the dot_ops array are case insensitive, and use
5248         strncasecmp to compare strings.  Also some whitespace cleanup in
5249         this area.  Similar for the f77_keywords array, except entries in
5250         this list might be case sensitive.
5251
5252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * f-exp.y (struct f77_boolean_val): Add comments.
5255         (boolean_values): Remove uppercase versions, and end marker.
5256         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5257         and use strncasecmp to achieve case insensitivity.  Additionally,
5258         perform whitespace cleanup around this code.
5259
5260 2019-03-06  Tom Tromey  <tromey@adacore.com>
5261
5262         * remote-sim.c (gdbsim_target_open): Use result of
5263         gdb_argv::release.
5264
5265 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5266         Dirk Schubert  <dirk.schubert@arm.com>
5267         Chris January  <chris.january@arm.com>
5268
5269         * eval.c (evaluate_subexp_standard): Call Fortran argument
5270         wrapping logic.
5271         * f-lang.c (struct value): A value which can be passed into a
5272         Fortran function call.
5273         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5274         where appropriate.
5275         (struct type): Value ready for a Fortran function call.
5276         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5277         is needed.
5278         * f-lang.h (fortran_argument_convert): Declaration.
5279         (fortran_preserve_arg_pointer): Declaration.
5280         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5281
5282 2019-03-05  Tom Tromey  <tromey@adacore.com>
5283
5284         * python/py-prettyprint.c (print_string_repr): Remove #if.
5285         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5286
5287 2019-03-05  Tom Tromey  <tromey@adacore.com>
5288
5289         * target.c (the_dummy_target): Move later.  Change type to
5290         "dummy_target".
5291         (initialize_targets): Don't initialize the_dummy_target.
5292
5293 2019-03-05  Tom Tromey  <tromey@adacore.com>
5294
5295         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5296         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5297
5298 2019-03-05  Tom Tromey  <tromey@adacore.com>
5299
5300         * windows-nat.c (windows_nat_target::attach)
5301         (windows_nat_target::detach): Don't call gdb_flush.
5302         * valprint.c (generic_val_print, val_print, val_print_string):
5303         Don't call gdb_flush.
5304         * utils.c (defaulted_query): Don't call gdb_flush.
5305         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5306         * target.c (target_announce_detach): Don't call gdb_flush.
5307         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5308         * remote.c (extended_remote_target::attach): Don't call
5309         gdb_flush.
5310         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5311         * printcmd.c (do_examine): Don't call gdb_flush.
5312         (info_display_command): Don't call gdb_flush.
5313         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5314         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5315         * memattr.c (info_mem_command): Don't call gdb_flush.
5316         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5317         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5318         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5319         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5320         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5321         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5322         (gnu_nat_target::detach): Don't call gdb_flush.
5323         * f-valprint.c (f_val_print): Don't call gdb_flush.
5324         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5325         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5326         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5327         gdb_flush.
5328         * c-valprint.c (c_val_print): Don't call gdb_flush.
5329         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5330
5331 2019-03-05  Tom Tromey  <tromey@adacore.com>
5332
5333         * varobj.c (update_dynamic_varobj_children): Update.
5334         (install_default_visualizer): Use reset, not release.
5335         * value.c (set_internalvar): Update.
5336         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5337         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5338         ATTRIBUTE_UNUSED_RESULT.
5339
5340 2019-03-05  Tom Tromey  <tromey@adacore.com>
5341
5342         * remote.c (class scoped_remote_fd) <release>: Add
5343         ATTRIBUTE_UNUSED_RESULT.
5344
5345 2019-03-05  Tom Tromey  <tromey@adacore.com>
5346
5347         * macroexp.c (struct macro_buffer) <release>: Add
5348         ATTRIBUTE_UNUSED_RESULT.
5349
5350 2019-03-05  Tom Tromey  <tromey@adacore.com>
5351
5352         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5353         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5354         ATTRIBUTE_UNUSED_RESULT.
5355
5356 2019-03-05  Tom Tromey  <tromey@adacore.com>
5357
5358         * common/scoped_fd.h (class scoped_fd) <release>: Add
5359         ATTRIBUTE_UNUSED_RESULT.
5360
5361 2019-03-05  Tom Tromey  <tromey@adacore.com>
5362
5363         * parser-defs.h (struct parser_state) <release>: Add
5364         ATTRIBUTE_UNUSED_RESULT.
5365
5366 2019-03-05  Tom Tromey  <tromey@adacore.com>
5367
5368         * utils.h (class gdb_argv) <release>: Add
5369         ATTRIBUTE_UNUSED_RESULT.
5370         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5371
5372 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5373
5374         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5375         for-loop range, to avoid compiler warnings.
5376
5377         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5378         avoid compiler warnings about unused variables.
5379
5380         * NEWS: Mention end of support for native debugging on MS-Windows
5381         before XP.
5382
5383         PR gdb/24292
5384         * common/netstuff.c:
5385         * gdbserver/gdbreplay.c
5386         * gdbserver/remote-utils.c:
5387         * ser-tcp.c:
5388         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5389         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5390         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5391         'getaddrinfo' and 'freeaddrinfo' were not available before
5392         Windows XP, and mingw.org's MinGW headers by default define
5393         _WIN32_WINNT to 0x500.
5394
5395 2019-03-01  Gary Benson <gbenson@redhat.com>
5396
5397         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5398
5399 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5400             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5401
5402         PR gdb/8527
5403         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5404         set_sigint_trap, clear_sigint_trap.
5405
5406 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5407
5408         * target.c (target_detach): Clear the regcache and the
5409         frame cache.
5410
5411 2019-02-27  Pedro Alves  <palves@redhat.com>
5412
5413         * utils.c (set_screen_size): When we cap the height/width sizes,
5414         tweak the corresponding command variable to show "unlimited":
5415
5416 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5417             Pedro Alves  <palves@redhat.com>
5418
5419         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5420         before calling rl_set_screen_size.
5421
5422 2019-02-27  Tom Tromey  <tromey@adacore.com>
5423
5424         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5425         define.
5426         * python/py-value.c: Remove Python 2.4 workaround.
5427         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5428         workaround.
5429         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5430         Python 2.4 workaround.
5431         * python/python-internal.h: Remove Python 2.4 comment.
5432         (Py_ssize_t): Don't define.
5433         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5434         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5435         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5436         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5437         * python/python.c (do_start_initialization): Remove Python 2.4
5438         workaround.
5439         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5440         (print_children): Remove Python 2.4 workaround.
5441         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5442         workaround.
5443         (CHARBUFFERPROC_NAME): Remove.
5444         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5445         Python 2.4 workaround.
5446
5447 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5448
5449         * NEWS: Note minimum Python version.
5450
5451 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5452
5453         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5454         code from these functions.  Remove corresponding ifdefs.  Use
5455         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5456         Remove gotos and target of gotos.
5457         (infpy_search_memory): Likewise.
5458
5459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5462         (hppa_gdbarch_init): Don't register deleted functions with
5463         gdbarch.
5464
5465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5468         (h8300_unwind_sp): Delete.
5469         (h8300_dummy_id): Delete.
5470         (h8300_gdbarch_init): Don't register deleted functions with
5471         gdbarch.
5472
5473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5474
5475         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5476         (ft32_unwind_pc): Delete.
5477         (ft32_unwind_sp): Delete.
5478         (ft32_gdbarch_init): Don't register deleted functions with
5479         gdbarch.
5480
5481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5482
5483         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5484         (frv_unwind_pc): Delete.
5485         (frv_unwind_sp): Delete.
5486         (frv_gdbarch_init): Don't register deleted functions with
5487         gdbarch.
5488
5489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5492         (riscv_unwind_pc): Delete.
5493         (riscv_unwind_sp): Delete.
5494         (riscv_gdbarch_init): Don't register deleted functions with
5495         gdbarch.
5496
5497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5500         (csky_unwind_pc): Delete.
5501         (csky_unwind_sp): Delete.
5502         (csky_gdbarch_init): Don't register deleted functions with
5503         gdbarch.
5504
5505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5508         (cris_unwind_pc): Delete.
5509         (cris_unwind_sp): Delete.
5510         (cris_gdbarch_init): Don't register deleted functions with
5511         gdbarch.
5512
5513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5514
5515         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5516         (bfin_unwind_pc): Delete.
5517         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5518
5519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5522         (arm_unwind_pc): Delete.
5523         (arm_unwind_sp): Delete.
5524         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5525
5526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5527
5528         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5529         (arc_unwind_pc): Delete.
5530         (arc_unwind_sp): Delete.
5531         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5532
5533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5534
5535         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5536         (alpha_unwind_pc): Delete.
5537         (alpha_gdbarch_init): Don't register deleted functions with
5538         gdbarch.
5539
5540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5543         (aarch64_unwind_pc): Delete.
5544         (aarch64_unwind_sp): Delete.
5545         (aarch64_gdbarch_init): Don't register deleted functions with
5546         gdbarch.
5547
5548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * gdbtypes.c (type_align): Don't consider static members when
5551         computing structure alignment.
5552
5553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5554
5555         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5556         return 0 for other types.
5557         * arch-utils.c (default_type_align): Always return 0.
5558         * gdbarch.h: Regenerate.
5559         * gdbarch.sh (type_align): Extend comment.
5560         * gdbtypes.c (type_align): Add additional comments, always call
5561         gdbarch_type_align before applying the default rules.
5562         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5563         generic code will then apply a suitable default.
5564         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5565         types, return 0 for other types.
5566
5567 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5568
5569         * NEWS: Create a new section for the next release branch.
5570         Rename the section of the current branch, now that it has
5571         been cut.
5572
5573 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5574
5575         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5576         * version.in: Bump version to 8.3.50.DATE-git.
5577
5578 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5579
5580         * aix-thread.c (ptid_cmp): Remove unused variable.
5581         (get_signaled_thread): Likewise.
5582         (store_regs_user_thread): Likewise.
5583         (store_regs_kernel_thread): Likewise.
5584         (fetch_regs_kernel_thread): Remove shadowed variable.
5585
5586 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * features/riscv/32bit-cpu.xml: Add register numbers.
5589         * features/riscv/32bit-fpu.c: Regenerate.
5590         * features/riscv/32bit-fpu.xml: Add register numbers.
5591         * features/riscv/64bit-cpu.xml: Add register numbers.
5592         * features/riscv/64bit-fpu.c: Regenerate.
5593         * features/riscv/64bit-fpu.xml: Add register numbers.
5594
5595 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5596
5597         * NEWS: Mention two argument form of gdb.Value constructor.
5598         * python/py-value.c (convert_buffer_and_type_to_value): New
5599         function.
5600         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5601         Add support for handling an optional second argument.  Call
5602         convert_buffer_and_type_to_value as appropriate.
5603         * python/python-internal.h (Py_buffer_deleter): New struct.
5604         (Py_buffer_up): New typedef.
5605
5606 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5607
5608         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5609         instead of releasing ownership.
5610
5611 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5612
5613         * dwarf2read.c (open_and_init_dwp_file): Call
5614         elf_numsections instead of bfd_count_sections to initialize
5615         dwp_file->num_sections.
5616
5617 2019-02-25  Tom Tromey  <tromey@adacore.com>
5618
5619         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5620
5621 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5622
5623         * gcore.in: Add '--readnever' option when invoking GDB.
5624
5625 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5626
5627         * MAINTAINERS: Update my email address.
5628
5629 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5630
5631         * build-id.c (build_id_to_debug_bfd_1): New function.
5632         (build_id_to_debug_bfd): Look for separate debug file in
5633         sysroot.
5634
5635 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5636
5637         * gdbarch.sh: Update the copyright year range that is placed into
5638         generated files.
5639
5640 2019-02-22  Keith Seitz  <keiths@redhat.com>
5641
5642         PR symtab/23853
5643         * linespec.c (create_sals_line_offset): Search for the default
5644         symtab's filename instead of its fullname.
5645
5646 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5647
5648         * NEWS: Update style defaults.
5649
5650 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5651
5652         * main.c (captured_main_1): Disable styling in batch mode.
5653
5654 2019-02-20  Tom Tromey  <tom@tromey.com>
5655
5656         * symtab.c (symtab_symbol_info): Fix typos.
5657
5658 2019-02-20  Tom Tromey  <tromey@adacore.com>
5659
5660         * findcmd.c (_initialize_mem_search): Use upper case for
5661         metasyntactic variables.
5662
5663 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5664
5665         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5666         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5667
5668 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5669
5670         * top.h (source_file_name): Change to std::string.
5671         * top.c (source_file_name): Likewise.
5672         (command_line_input): Adjust.
5673         * cli/cli-script.c (script_from_file): Adjust.
5674
5675 2019-02-19  Tom Tromey  <tromey@adacore.com>
5676
5677         * ravenscar-thread.c
5678         (ravenscar_thread_target::update_thread_list): Don't call
5679         ada_build_task_list.
5680         * ada-lang.h (ada_build_task_list): Don't declare.
5681         * ada-tasks.c (struct ada_tasks_inferior_data)
5682         <task_list_valid_p>: Now bool.
5683         (read_known_tasks, ada_task_list_changed)
5684         (ada_tasks_invalidate_inferior_data): Update.
5685         (read_known_tasks_array): Return bool.
5686         (read_known_tasks_list): Likewise.
5687         (read_known_tasks): Return void.
5688         (ada_build_task_list): Now static.
5689
5690 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5691
5692         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5693         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5694
5695 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5696
5697         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5698         variant for ada_tasks_pspace_data_handle and
5699         ada_tasks_inferior_data_handle.
5700         (ada_tasks_pspace_data_cleanup): New function.
5701         (ada_tasks_inferior_data_cleanup): New function.
5702
5703 2019-02-17  Tom Tromey  <tom@tromey.com>
5704
5705         * macrotab.h (macro_source_fullname): Return a std::string.
5706         * macrotab.c (macro_include, check_for_redefinition)
5707         (macro_undef, macro_lookup_definition, foreach_macro)
5708         (foreach_macro_in_scope): Update.
5709         (macro_source_fullname): Return a std::string.
5710         * macrocmd.c (show_pp_source_pos): Update.
5711
5712 2019-02-17  Tom Tromey  <tom@tromey.com>
5713
5714         * macrocmd.c (show_pp_source_pos): Style the file names.
5715
5716 2019-02-17  Tom Tromey  <tom@tromey.com>
5717
5718         PR tui/24197:
5719         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5720
5721 2019-02-17  Tom Tromey  <tom@tromey.com>
5722
5723         * ada-lang.c (user_select_syms): Use filtered printing.
5724         * utils.c (wrap_style): New global.
5725         (desired_style): Remove.
5726         (emit_style_escape): Add stream parameter.
5727         (set_output_style, reset_terminal_style, prompt_for_continue):
5728         Update.
5729         (flush_wrap_buffer): Only flush gdb_stdout.
5730         (wrap_here): Set wrap_style.
5731         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5732         treat escape sequences as a character.  Change when wrap buffer is
5733         flushed.
5734         (fputs_styled): Do not set the output style when the default is
5735         requested.
5736         * ui-style.h (struct ui_file_style) <is_default>: New method.
5737         * source.c (print_source_lines_base): Emit escape sequences in one
5738         piece.
5739
5740 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5741
5742         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5743         integers and enumeration types.
5744
5745 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5746
5747         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5748         instead of lookup_symbol_in_language
5749         (do_exact_match): New function.
5750         (ada_get_symbol_name_matcher): Return do_exact_match when
5751         doing a verbatim match.
5752
5753 2019-02-15  Tom Tromey  <tromey@adacore.com>
5754
5755         * ravenscar-thread.c (ravenscar_thread_target::resume)
5756         (ravenscar_thread_target::wait): Special case wildcard requests.
5757
5758 2019-02-15  Tom Tromey  <tromey@adacore.com>
5759
5760         * ravenscar-thread.c (base_ptid): Remove.
5761         (struct ravenscar_thread_target) <close>: New method.
5762         <m_base_ptid>: New member.
5763         <update_inferior_ptid, active_task, task_is_currently_active,
5764         runtime_initialized>: Declare methods.
5765         <ravenscar_thread_target>: Add constructor.
5766         (ravenscar_thread_target::task_is_currently_active)
5767         (ravenscar_thread_target::update_inferior_ptid)
5768         (ravenscar_runtime_initialized): Rename.  Now methods.
5769         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5770         (ravenscar_thread_target::update_thread_list): Update.
5771         (ravenscar_thread_target::active_task): Now method.
5772         (ravenscar_thread_target::store_registers)
5773         (ravenscar_thread_target::prepare_to_store)
5774         (ravenscar_thread_target::prepare_to_store)
5775         (ravenscar_thread_target::mourn_inferior): Update.
5776         (ravenscar_inferior_created): Use "new" to create target.
5777         (ravenscar_thread_target::get_ada_task_ptid): Update.
5778         (_initialize_ravenscar): Don't initialize base_ptid.
5779         (ravenscar_ops): Remove global.
5780
5781 2019-02-15  Tom Tromey  <tromey@adacore.com>
5782
5783         * target.h (push_target): Declare new overload.
5784         * target.c (push_target): New overload, taking an rvalue reference.
5785         * remote.c (remote_target::open_1): Use push_target overload.
5786         * corelow.c (core_target_open): Use push_target overload.
5787
5788 2019-02-15  Tom Tromey  <tromey@adacore.com>
5789
5790         * ravenscar-thread.c (is_ravenscar_task)
5791         (ravenscar_task_is_currently_active): Return bool.
5792         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5793         (_initialize_ravenscar): Remove "(void)".
5794         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5795         Return bool.
5796
5797 2019-02-15  Tom Tromey  <tromey@adacore.com>
5798
5799         * ravenscar-thread.c (ravenscar_runtime_initializer)
5800         (has_ravenscar_runtime, get_running_thread_id)
5801         (ravenscar_thread_target::resume): Fix indentation.
5802
5803 2019-02-15  Tom Tromey  <tromey@adacore.com>
5804
5805         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5806         from ravenscar_arch_ops.
5807         (sparc_ravenscar_ops::fetch_registers)
5808         (sparc_ravenscar_ops::store_registers): Now methods.
5809         (sparc_ravenscar_prepare_to_store): Remove.
5810         (sparc_ravenscar_ops): Redefine.
5811         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5812         methods and destructor.  Remove members.
5813         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5814         (ravenscar_thread_target::store_registers)
5815         (ravenscar_thread_target::prepare_to_store): Update.
5816         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5817         Remove.
5818         (struct ppc_ravenscar_powerpc_ops): Derive from
5819         ravenscar_arch_ops.
5820         (ppc_ravenscar_powerpc_ops::fetch_registers)
5821         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5822         (ppc_ravenscar_powerpc_ops): Redefine.
5823         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5824         (ppc_ravenscar_e500_ops::fetch_registers)
5825         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5826         (ppc_ravenscar_e500_ops): Redefine.
5827         * aarch64-ravenscar-thread.c
5828         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5829         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5830         (aarch64_ravenscar_fetch_registers)
5831         (aarch64_ravenscar_store_registers): Now methods.
5832         (aarch64_ravenscar_ops): Redefine.
5833
5834 2019-02-15  Tom Tromey  <tromey@adacore.com>
5835
5836         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5837         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5838         (ravenscar_thread_target::stopped_by_watchpoint)
5839         (ravenscar_thread_target::stopped_data_address)
5840         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5841
5842 2019-02-15  Tom Tromey  <tromey@adacore.com>
5843
5844         * ravenscar-thread.c: Fix some typos.
5845
5846 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5847             Tom Tromey  <tromey@adacore.com>
5848
5849         * ada-lang.c (ada_exception_sal): Change addr_string to a
5850         std::string.
5851         (create_ada_exception_catchpoint): Update.
5852
5853 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5854             Tom Tromey  <tromey@adacore.com>
5855
5856         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5857         (bp_location_ops): Remove.
5858         (base_breakpoint_allocate_location): Update.
5859         (free_bp_location): Update.
5860         * ada-lang.c (class ada_catchpoint_location)
5861         <ada_catchpoint_location>: Remove ops parameter.
5862         (ada_catchpoint_location_dtor): Remove.
5863         (ada_catchpoint_location_ops): Remove.
5864         (allocate_location_exception): Update.
5865         * breakpoint.h (struct bp_location_ops): Remove.
5866         (class bp_location) <bp_location>: Remove bp_location_ops
5867         parameter.
5868         <~bp_location>: Add destructor.
5869         <ops>: Remove.
5870
5871 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5872             Pedro Alves  <palves@redhat.com>
5873
5874         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5875         'PATH_MAX'.
5876
5877 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5878             Samuel Thibault  <samuel.thibault@gnu.org>
5879             Thomas Schwinge  <thomas@codesourcery.com>
5880
5881         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5882         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5883
5884 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5885
5886         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5887         (check_empty): Use "const char *".
5888
5889         * gnu-nat.c (gnu_nat_target::detach): Instead of
5890         'detach_inferior (pid)' call
5891         'detach_inferior (find_inferior_pid (pid))'.
5892
5893         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5894         'nat/fork-inferior.o'.
5895         * gnu-nat.c: #include "nat/fork-inferior.h".
5896
5897         * gnu-nat.c (gnu_nat_target::detach): Instead of
5898         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5899         * gnu-nat.h: #include "inf-child.h".
5900         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5901         'i386_gnu_nat_target::fetch_registers'.
5902         (gnu_store_registers): Rename/move to
5903         'i386_gnu_nat_target::store_registers'.
5904
5905         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5906         * gnu-nat.h (mach_thread_info): New function.
5907         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5908
5909         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5910
5911 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5912
5913         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5914
5915 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5916
5917         * windows-nat.c (windows_add_thread): Add new parameter
5918         "main_thread_p" with default value set to false.  Update
5919         function documentation as well as all callers.
5920         (windows_delete_thread): Likewise.
5921         (fake_create_process): Update call to windows_add_thread.
5922         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5923         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5924         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5925         call to windows_delete_thread.
5926
5927 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5928
5929         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5930
5931 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5932
5933         * symfile.c (find_separate_debug_file): Use canonical path of
5934         sysroot with child_path instead of gdb_sysroot if it is valid.
5935
5936 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5937
5938         * symfile.c (find_separate_debug_file): Use child_path to
5939         determine if an object file is under a sysroot.
5940
5941 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5942
5943         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5944         unittests/child-path-selftests.c.
5945         * common/pathstuff.c (child_path): New function.
5946         * common/pathstuff.h (child_path): New prototype.
5947         * unittests/child-path-selftests.c: New file.
5948
5949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5950
5951         * symfile.c (find_separate_debug_file): Look for separate debug
5952         files in debug directories under the sysroot.
5953
5954 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5955
5956         * symtab.h (struct minimal_symbol data_p): New const method.
5957         (struct minimal_symbol text_p): Likewise.
5958         * symtab.c (output_source_filename): Use file name style
5959         to print file name.
5960         (print_symbol_info): Likewise.
5961         (print_msymbol_info): Use address style to print addresses.
5962         Use function name style to print executable text symbols.
5963         (expand_symtab_containing_pc): Use data_p.
5964         (find_pc_sect_compunit_symtab): Likewise.
5965
5966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5967
5968         * breakpoint.c (describe_other_breakpoints): Use address style
5969         to print addresses.
5970         (say_where): Likewise.
5971
5972 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5973
5974         * ada-typeprint.c (print_func_type): Print function name
5975         style to print function name.
5976         * c-typeprint.c (c_print_type_1): Likewise.
5977
5978 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5979
5980         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5981         for execve.
5982
5983 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5984
5985         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5986         type_stack.
5987
5988 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5989
5990         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5991         TYPE_CODE_REF types.
5992
5993 2019-02-08  Jim Wilson  <jimw@sifive.com>
5994
5995         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5996         (riscv_linux_fregset): New.
5997         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5998
5999 2019-02-07  Tom Tromey  <tom@tromey.com>
6000
6001         * thread.c (thread_cancel_execution_command): Update.
6002         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6003         methods.
6004         (struct thread_fsm_ops): Remove.
6005         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6006         (thread_fsm_should_stop, thread_fsm_return_value)
6007         (thread_fsm_set_finished, thread_fsm_finished_p)
6008         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6009         Don't declare.
6010         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6011         * infrun.c (clear_proceed_status_thread)
6012         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6013         (print_stop_event): Update.
6014         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6015         Add constructor.
6016         (step_command_fsm_ops): Remove.
6017         (new_step_command_fsm): Remove.
6018         (step_1): Update.
6019         (step_command_fsm::should_stop): Rename from
6020         step_command_fsm_should_stop.
6021         (step_command_fsm::clean_up): Rename from
6022         step_command_fsm_clean_up.
6023         (step_command_fsm::do_async_reply_reason): Rename from
6024         step_command_fsm_async_reply_reason.
6025         (struct until_next_fsm): Inherit from thread_fsm.  Add
6026         constructor.
6027         (until_next_fsm_ops): Remove.
6028         (new_until_next_fsm): Remove.
6029         (until_next_fsm::should_stop): Rename from
6030         until_next_fsm_should_stop.
6031         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6032         (until_next_fsm::do_async_reply_reason): Rename from
6033         until_next_fsm_async_reply_reason.
6034         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6035         constructor.  Change type of breakpoint.
6036         (finish_command_fsm_ops): Remove.
6037         (new_finish_command_fsm): Remove.
6038         (finish_command_fsm::should_stop): Rename from
6039         finish_command_fsm_should_stop.
6040         (finish_command_fsm::clean_up): Rename from
6041         finish_command_fsm_clean_up.
6042         (finish_command_fsm::return_value): Rename from
6043         finish_command_fsm_return_value.
6044         (finish_command_fsm::do_async_reply_reason): Rename from
6045         finish_command_fsm_async_reply_reason.
6046         (finish_command): Update.
6047         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6048         Add constructor.
6049         (call_thread_fsm_ops): Remove.
6050         (call_thread_fsm::call_thread_fsm): Rename from
6051         new_call_thread_fsm.
6052         (call_thread_fsm::should_stop): Rename from
6053         call_thread_fsm_should_stop.
6054         (call_thread_fsm::should_notify_stop): Rename from
6055         call_thread_fsm_should_notify_stop.
6056         (run_inferior_call, call_function_by_hand_dummy): Update.
6057         * cli/cli-interp.c (should_print_stop_to_console): Update.
6058         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6059         Add constructor.  Change type of location_breakpoint,
6060         caller_breakpoint.
6061         (until_break_fsm_ops): Remove.
6062         (new_until_break_fsm): Remove.
6063         (until_break_fsm::should_stop): Rename from
6064         until_break_fsm_should_stop.
6065         (until_break_fsm::clean_up): Rename from
6066         until_break_fsm_clean_up.
6067         (until_break_fsm::do_async_reply_reason): Rename from
6068         until_break_fsm_async_reply_reason.
6069         (until_break_command): Update.
6070         * thread-fsm.c: Remove.
6071         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6072
6073 2019-02-07  Tom Tromey  <tom@tromey.com>
6074
6075         * yy-remap.h: Add include guard.
6076         * xtensa-tdep.h: Add include guard.
6077         * xcoffread.h: Rename include guard.
6078         * varobj-iter.h: Add include guard.
6079         * tui/tui.h: Rename include guard.
6080         * tui/tui-winsource.h: Rename include guard.
6081         * tui/tui-wingeneral.h: Rename include guard.
6082         * tui/tui-windata.h: Rename include guard.
6083         * tui/tui-win.h: Rename include guard.
6084         * tui/tui-stack.h: Rename include guard.
6085         * tui/tui-source.h: Rename include guard.
6086         * tui/tui-regs.h: Rename include guard.
6087         * tui/tui-out.h: Rename include guard.
6088         * tui/tui-layout.h: Rename include guard.
6089         * tui/tui-io.h: Rename include guard.
6090         * tui/tui-hooks.h: Rename include guard.
6091         * tui/tui-file.h: Rename include guard.
6092         * tui/tui-disasm.h: Rename include guard.
6093         * tui/tui-data.h: Rename include guard.
6094         * tui/tui-command.h: Rename include guard.
6095         * tic6x-tdep.h: Add include guard.
6096         * target/waitstatus.h: Rename include guard.
6097         * target/wait.h: Rename include guard.
6098         * target/target.h: Rename include guard.
6099         * target/resume.h: Rename include guard.
6100         * target-float.h: Rename include guard.
6101         * stabsread.h: Add include guard.
6102         * rs6000-tdep.h: Add include guard.
6103         * riscv-fbsd-tdep.h: Add include guard.
6104         * regformats/regdef.h: Rename include guard.
6105         * record.h: Rename include guard.
6106         * python/python.h: Rename include guard.
6107         * python/python-internal.h: Rename include guard.
6108         * python/py-stopevent.h: Rename include guard.
6109         * python/py-ref.h: Rename include guard.
6110         * python/py-record.h: Rename include guard.
6111         * python/py-record-full.h: Rename include guard.
6112         * python/py-record-btrace.h: Rename include guard.
6113         * python/py-instruction.h: Rename include guard.
6114         * python/py-events.h: Rename include guard.
6115         * python/py-event.h: Rename include guard.
6116         * procfs.h: Add include guard.
6117         * proc-utils.h: Add include guard.
6118         * p-lang.h: Add include guard.
6119         * or1k-tdep.h: Rename include guard.
6120         * observable.h: Rename include guard.
6121         * nto-tdep.h: Rename include guard.
6122         * nat/x86-linux.h: Rename include guard.
6123         * nat/x86-linux-dregs.h: Rename include guard.
6124         * nat/x86-gcc-cpuid.h: Add include guard.
6125         * nat/x86-dregs.h: Rename include guard.
6126         * nat/x86-cpuid.h: Rename include guard.
6127         * nat/ppc-linux.h: Rename include guard.
6128         * nat/mips-linux-watch.h: Rename include guard.
6129         * nat/linux-waitpid.h: Rename include guard.
6130         * nat/linux-ptrace.h: Rename include guard.
6131         * nat/linux-procfs.h: Rename include guard.
6132         * nat/linux-osdata.h: Rename include guard.
6133         * nat/linux-nat.h: Rename include guard.
6134         * nat/linux-namespaces.h: Rename include guard.
6135         * nat/linux-btrace.h: Rename include guard.
6136         * nat/glibc_thread_db.h: Rename include guard.
6137         * nat/gdb_thread_db.h: Rename include guard.
6138         * nat/gdb_ptrace.h: Rename include guard.
6139         * nat/fork-inferior.h: Rename include guard.
6140         * nat/amd64-linux-siginfo.h: Rename include guard.
6141         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6142         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6143         * nat/aarch64-linux.h: Rename include guard.
6144         * nat/aarch64-linux-hw-point.h: Rename include guard.
6145         * mn10300-tdep.h: Add include guard.
6146         * mips-linux-tdep.h: Add include guard.
6147         * mi/mi-parse.h: Rename include guard.
6148         * mi/mi-out.h: Rename include guard.
6149         * mi/mi-main.h: Rename include guard.
6150         * mi/mi-interp.h: Rename include guard.
6151         * mi/mi-getopt.h: Rename include guard.
6152         * mi/mi-console.h: Rename include guard.
6153         * mi/mi-common.h: Rename include guard.
6154         * mi/mi-cmds.h: Rename include guard.
6155         * mi/mi-cmd-break.h: Rename include guard.
6156         * m2-lang.h: Add include guard.
6157         * location.h: Rename include guard.
6158         * linux-record.h: Rename include guard.
6159         * linux-nat.h: Add include guard.
6160         * linux-fork.h: Add include guard.
6161         * i386-darwin-tdep.h: Rename include guard.
6162         * hppa-linux-offsets.h: Add include guard.
6163         * guile/guile.h: Rename include guard.
6164         * guile/guile-internal.h: Rename include guard.
6165         * gnu-nat.h: Rename include guard.
6166         * gdb-stabs.h: Rename include guard.
6167         * frv-tdep.h: Add include guard.
6168         * f-lang.h: Add include guard.
6169         * event-loop.h: Add include guard.
6170         * darwin-nat.h: Rename include guard.
6171         * cp-abi.h: Rename include guard.
6172         * config/sparc/nm-sol2.h: Rename include guard.
6173         * config/nm-nto.h: Rename include guard.
6174         * config/nm-linux.h: Add include guard.
6175         * config/i386/nm-i386gnu.h: Rename include guard.
6176         * config/djgpp/nl_types.h: Rename include guard.
6177         * config/djgpp/langinfo.h: Rename include guard.
6178         * compile/gcc-cp-plugin.h: Add include guard.
6179         * compile/gcc-c-plugin.h: Add include guard.
6180         * compile/compile.h: Rename include guard.
6181         * compile/compile-object-run.h: Rename include guard.
6182         * compile/compile-object-load.h: Rename include guard.
6183         * compile/compile-internal.h: Rename include guard.
6184         * compile/compile-cplus.h: Rename include guard.
6185         * compile/compile-c.h: Rename include guard.
6186         * common/xml-utils.h: Rename include guard.
6187         * common/x86-xstate.h: Rename include guard.
6188         * common/version.h: Rename include guard.
6189         * common/vec.h: Rename include guard.
6190         * common/tdesc.h: Rename include guard.
6191         * common/selftest.h: Rename include guard.
6192         * common/scoped_restore.h: Rename include guard.
6193         * common/scoped_mmap.h: Rename include guard.
6194         * common/scoped_fd.h: Rename include guard.
6195         * common/safe-iterator.h: Rename include guard.
6196         * common/run-time-clock.h: Rename include guard.
6197         * common/refcounted-object.h: Rename include guard.
6198         * common/queue.h: Rename include guard.
6199         * common/ptid.h: Rename include guard.
6200         * common/print-utils.h: Rename include guard.
6201         * common/preprocessor.h: Rename include guard.
6202         * common/pathstuff.h: Rename include guard.
6203         * common/observable.h: Rename include guard.
6204         * common/netstuff.h: Rename include guard.
6205         * common/job-control.h: Rename include guard.
6206         * common/host-defs.h: Rename include guard.
6207         * common/gdb_wait.h: Rename include guard.
6208         * common/gdb_vecs.h: Rename include guard.
6209         * common/gdb_unlinker.h: Rename include guard.
6210         * common/gdb_unique_ptr.h: Rename include guard.
6211         * common/gdb_tilde_expand.h: Rename include guard.
6212         * common/gdb_sys_time.h: Rename include guard.
6213         * common/gdb_string_view.h: Rename include guard.
6214         * common/gdb_splay_tree.h: Rename include guard.
6215         * common/gdb_setjmp.h: Rename include guard.
6216         * common/gdb_ref_ptr.h: Rename include guard.
6217         * common/gdb_optional.h: Rename include guard.
6218         * common/gdb_locale.h: Rename include guard.
6219         * common/gdb_assert.h: Rename include guard.
6220         * common/filtered-iterator.h: Rename include guard.
6221         * common/filestuff.h: Rename include guard.
6222         * common/fileio.h: Rename include guard.
6223         * common/environ.h: Rename include guard.
6224         * common/common-utils.h: Rename include guard.
6225         * common/common-types.h: Rename include guard.
6226         * common/common-regcache.h: Rename include guard.
6227         * common/common-inferior.h: Rename include guard.
6228         * common/common-gdbthread.h: Rename include guard.
6229         * common/common-exceptions.h: Rename include guard.
6230         * common/common-defs.h: Rename include guard.
6231         * common/common-debug.h: Rename include guard.
6232         * common/cleanups.h: Rename include guard.
6233         * common/buffer.h: Rename include guard.
6234         * common/btrace-common.h: Rename include guard.
6235         * common/break-common.h: Rename include guard.
6236         * cli/cli-utils.h: Rename include guard.
6237         * cli/cli-style.h: Rename include guard.
6238         * cli/cli-setshow.h: Rename include guard.
6239         * cli/cli-script.h: Rename include guard.
6240         * cli/cli-interp.h: Rename include guard.
6241         * cli/cli-decode.h: Rename include guard.
6242         * cli/cli-cmds.h: Rename include guard.
6243         * charset-list.h: Add include guard.
6244         * buildsym-legacy.h: Rename include guard.
6245         * bfin-tdep.h: Add include guard.
6246         * ax.h: Rename include guard.
6247         * arm-linux-tdep.h: Add include guard.
6248         * arm-fbsd-tdep.h: Add include guard.
6249         * arch/xtensa.h: Rename include guard.
6250         * arch/tic6x.h: Add include guard.
6251         * arch/i386.h: Add include guard.
6252         * arch/arm.h: Rename include guard.
6253         * arch/arm-linux.h: Rename include guard.
6254         * arch/arm-get-next-pcs.h: Rename include guard.
6255         * arch/amd64.h: Add include guard.
6256         * arch/aarch64-insn.h: Rename include guard.
6257         * arch-utils.h: Rename include guard.
6258         * annotate.h: Add include guard.
6259         * amd64-darwin-tdep.h: Rename include guard.
6260         * aarch64-linux-tdep.h: Add include guard.
6261         * aarch64-fbsd-tdep.h: Add include guard.
6262         * aarch32-linux-nat.h: Add include guard.
6263
6264 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6265
6266         * macrotab.c (macro_define_internal): New function that
6267         factorizes macro_define_object_internal and macro_define_function
6268         code.
6269         (macro_define_object_internal): Use macro_define_internal.
6270         (macro_define_function): Likewise.
6271
6272 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6273
6274         * macrocmd.c (extract_identifier): Return
6275         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6276         callers.
6277
6278 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6279
6280         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6281
6282 2019-02-05  Tom Tromey  <tom@tromey.com>
6283
6284         * target.c (target_stack::unpush): Move assertion earlier.
6285
6286 2019-01-30  Tom Tromey  <tom@tromey.com>
6287
6288         PR python/23615:
6289         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6290         (gdbpy_parse_and_eval): Likewise.
6291         * python/python-internal.h (gdbpy_allow_threads): New class.
6292
6293 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6294
6295         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6296         (aarch64_fbsd_fpregmap): Move earlier.
6297         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6298         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6299         instead of individual calls to trad_frame_set_reg_addr.
6300         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6301         earlier.
6302         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6303         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6304         instead of individual calls to trad_frame_set_reg_addr.
6305
6306 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6307
6308         * CONTRIBUTE: Replace contribution list with wiki link.
6309
6310 2019-01-25  Tom Tromey  <tom@tromey.com>
6311
6312         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6313
6314 2019-01-25  Tom Tromey  <tom@tromey.com>
6315
6316         * xtensa-linux-nat.c: Fix common/ includes.
6317         * xml-support.h: Fix common/ includes.
6318         * xml-support.c: Fix common/ includes.
6319         * x86-linux-nat.c: Fix common/ includes.
6320         * windows-nat.c: Fix common/ includes.
6321         * varobj.h: Fix common/ includes.
6322         * varobj.c: Fix common/ includes.
6323         * value.c: Fix common/ includes.
6324         * valops.c: Fix common/ includes.
6325         * utils.c: Fix common/ includes.
6326         * unittests/xml-utils-selftests.c: Fix common/ includes.
6327         * unittests/utils-selftests.c: Fix common/ includes.
6328         * unittests/unpack-selftests.c: Fix common/ includes.
6329         * unittests/tracepoint-selftests.c: Fix common/ includes.
6330         * unittests/style-selftests.c: Fix common/ includes.
6331         * unittests/string_view-selftests.c: Fix common/ includes.
6332         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6333         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6334         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6335         * unittests/rsp-low-selftests.c: Fix common/ includes.
6336         * unittests/parse-connection-spec-selftests.c: Fix common/
6337         includes.
6338         * unittests/optional-selftests.c: Fix common/ includes.
6339         * unittests/offset-type-selftests.c: Fix common/ includes.
6340         * unittests/observable-selftests.c: Fix common/ includes.
6341         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6342         * unittests/memrange-selftests.c: Fix common/ includes.
6343         * unittests/memory-map-selftests.c: Fix common/ includes.
6344         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6345         * unittests/function-view-selftests.c: Fix common/ includes.
6346         * unittests/environ-selftests.c: Fix common/ includes.
6347         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6348         * unittests/common-utils-selftests.c: Fix common/ includes.
6349         * unittests/cli-utils-selftests.c: Fix common/ includes.
6350         * unittests/array-view-selftests.c: Fix common/ includes.
6351         * ui-file.c: Fix common/ includes.
6352         * tui/tui-io.c: Fix common/ includes.
6353         * tracepoint.h: Fix common/ includes.
6354         * tracepoint.c: Fix common/ includes.
6355         * tracefile-tfile.c: Fix common/ includes.
6356         * top.h: Fix common/ includes.
6357         * top.c: Fix common/ includes.
6358         * thread.c: Fix common/ includes.
6359         * target/waitstatus.h: Fix common/ includes.
6360         * target/waitstatus.c: Fix common/ includes.
6361         * target.h: Fix common/ includes.
6362         * target.c: Fix common/ includes.
6363         * target-memory.c: Fix common/ includes.
6364         * target-descriptions.c: Fix common/ includes.
6365         * symtab.h: Fix common/ includes.
6366         * symfile.c: Fix common/ includes.
6367         * stap-probe.c: Fix common/ includes.
6368         * spu-linux-nat.c: Fix common/ includes.
6369         * sparc-nat.c: Fix common/ includes.
6370         * source.c: Fix common/ includes.
6371         * solib.c: Fix common/ includes.
6372         * solib-target.c: Fix common/ includes.
6373         * ser-unix.c: Fix common/ includes.
6374         * ser-tcp.c: Fix common/ includes.
6375         * ser-pipe.c: Fix common/ includes.
6376         * ser-base.c: Fix common/ includes.
6377         * selftest-arch.c: Fix common/ includes.
6378         * s12z-tdep.c: Fix common/ includes.
6379         * rust-exp.y: Fix common/ includes.
6380         * rs6000-aix-tdep.c: Fix common/ includes.
6381         * riscv-tdep.c: Fix common/ includes.
6382         * remote.c: Fix common/ includes.
6383         * remote-notif.h: Fix common/ includes.
6384         * remote-fileio.h: Fix common/ includes.
6385         * remote-fileio.c: Fix common/ includes.
6386         * regcache.h: Fix common/ includes.
6387         * regcache.c: Fix common/ includes.
6388         * record-btrace.c: Fix common/ includes.
6389         * python/python.c: Fix common/ includes.
6390         * python/py-type.c: Fix common/ includes.
6391         * python/py-inferior.c: Fix common/ includes.
6392         * progspace.h: Fix common/ includes.
6393         * producer.c: Fix common/ includes.
6394         * procfs.c: Fix common/ includes.
6395         * proc-api.c: Fix common/ includes.
6396         * printcmd.c: Fix common/ includes.
6397         * ppc-linux-nat.c: Fix common/ includes.
6398         * parser-defs.h: Fix common/ includes.
6399         * osdata.c: Fix common/ includes.
6400         * obsd-nat.c: Fix common/ includes.
6401         * nat/x86-linux.c: Fix common/ includes.
6402         * nat/x86-linux-dregs.c: Fix common/ includes.
6403         * nat/x86-dregs.h: Fix common/ includes.
6404         * nat/x86-dregs.c: Fix common/ includes.
6405         * nat/ppc-linux.c: Fix common/ includes.
6406         * nat/mips-linux-watch.h: Fix common/ includes.
6407         * nat/mips-linux-watch.c: Fix common/ includes.
6408         * nat/linux-waitpid.c: Fix common/ includes.
6409         * nat/linux-ptrace.h: Fix common/ includes.
6410         * nat/linux-ptrace.c: Fix common/ includes.
6411         * nat/linux-procfs.c: Fix common/ includes.
6412         * nat/linux-personality.c: Fix common/ includes.
6413         * nat/linux-osdata.c: Fix common/ includes.
6414         * nat/linux-namespaces.c: Fix common/ includes.
6415         * nat/linux-btrace.h: Fix common/ includes.
6416         * nat/linux-btrace.c: Fix common/ includes.
6417         * nat/fork-inferior.c: Fix common/ includes.
6418         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6419         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6420         * nat/aarch64-linux.c: Fix common/ includes.
6421         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6422         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6423         * namespace.h: Fix common/ includes.
6424         * mips-linux-tdep.c: Fix common/ includes.
6425         * minsyms.c: Fix common/ includes.
6426         * mi/mi-parse.h: Fix common/ includes.
6427         * mi/mi-main.c: Fix common/ includes.
6428         * mi/mi-cmd-env.c: Fix common/ includes.
6429         * memrange.h: Fix common/ includes.
6430         * memattr.c: Fix common/ includes.
6431         * maint.h: Fix common/ includes.
6432         * maint.c: Fix common/ includes.
6433         * main.c: Fix common/ includes.
6434         * machoread.c: Fix common/ includes.
6435         * location.c: Fix common/ includes.
6436         * linux-thread-db.c: Fix common/ includes.
6437         * linux-nat.c: Fix common/ includes.
6438         * linux-fork.c: Fix common/ includes.
6439         * inline-frame.c: Fix common/ includes.
6440         * infrun.c: Fix common/ includes.
6441         * inflow.c: Fix common/ includes.
6442         * inferior.h: Fix common/ includes.
6443         * inferior.c: Fix common/ includes.
6444         * infcmd.c: Fix common/ includes.
6445         * inf-ptrace.c: Fix common/ includes.
6446         * inf-child.c: Fix common/ includes.
6447         * ia64-linux-nat.c: Fix common/ includes.
6448         * i387-tdep.c: Fix common/ includes.
6449         * i386-tdep.c: Fix common/ includes.
6450         * i386-linux-tdep.c: Fix common/ includes.
6451         * i386-linux-nat.c: Fix common/ includes.
6452         * i386-go32-tdep.c: Fix common/ includes.
6453         * i386-fbsd-tdep.c: Fix common/ includes.
6454         * i386-fbsd-nat.c: Fix common/ includes.
6455         * guile/scm-type.c: Fix common/ includes.
6456         * guile/guile.c: Fix common/ includes.
6457         * go32-nat.c: Fix common/ includes.
6458         * gnu-nat.c: Fix common/ includes.
6459         * gdbthread.h: Fix common/ includes.
6460         * gdbarch-selftests.c: Fix common/ includes.
6461         * gdb_usleep.c: Fix common/ includes.
6462         * gdb_select.h: Fix common/ includes.
6463         * gdb_bfd.c: Fix common/ includes.
6464         * gcore.c: Fix common/ includes.
6465         * fork-child.c: Fix common/ includes.
6466         * findvar.c: Fix common/ includes.
6467         * fbsd-nat.c: Fix common/ includes.
6468         * event-top.c: Fix common/ includes.
6469         * event-loop.c: Fix common/ includes.
6470         * dwarf2read.c: Fix common/ includes.
6471         * dwarf2loc.c: Fix common/ includes.
6472         * dwarf2-frame.c: Fix common/ includes.
6473         * dwarf-index-cache.c: Fix common/ includes.
6474         * dtrace-probe.c: Fix common/ includes.
6475         * disasm-selftests.c: Fix common/ includes.
6476         * defs.h: Fix common/ includes.
6477         * csky-tdep.c: Fix common/ includes.
6478         * cp-valprint.c: Fix common/ includes.
6479         * cp-support.h: Fix common/ includes.
6480         * cp-support.c: Fix common/ includes.
6481         * corelow.c: Fix common/ includes.
6482         * completer.h: Fix common/ includes.
6483         * completer.c: Fix common/ includes.
6484         * compile/compile.c: Fix common/ includes.
6485         * compile/compile-loc2c.c: Fix common/ includes.
6486         * compile/compile-cplus-types.c: Fix common/ includes.
6487         * compile/compile-cplus-symbols.c: Fix common/ includes.
6488         * command.h: Fix common/ includes.
6489         * cli/cli-dump.c: Fix common/ includes.
6490         * cli/cli-cmds.c: Fix common/ includes.
6491         * charset.c: Fix common/ includes.
6492         * build-id.c: Fix common/ includes.
6493         * btrace.h: Fix common/ includes.
6494         * btrace.c: Fix common/ includes.
6495         * breakpoint.h: Fix common/ includes.
6496         * breakpoint.c: Fix common/ includes.
6497         * ax.h:
6498         (enum agent_op): Fix common/ includes.
6499         * ax-general.c (struct aop_map): Fix common/ includes.
6500         * ax-gdb.c: Fix common/ includes.
6501         * auxv.c: Fix common/ includes.
6502         * auto-load.c: Fix common/ includes.
6503         * arm-tdep.c: Fix common/ includes.
6504         * arch/riscv.c: Fix common/ includes.
6505         * arch/ppc-linux-common.c: Fix common/ includes.
6506         * arch/i386.c: Fix common/ includes.
6507         * arch/arm.c: Fix common/ includes.
6508         * arch/arm-linux.c: Fix common/ includes.
6509         * arch/arm-get-next-pcs.c: Fix common/ includes.
6510         * arch/amd64.c: Fix common/ includes.
6511         * arch/aarch64.c: Fix common/ includes.
6512         * arch/aarch64-insn.c: Fix common/ includes.
6513         * arch-utils.c: Fix common/ includes.
6514         * amd64-windows-tdep.c: Fix common/ includes.
6515         * amd64-tdep.c: Fix common/ includes.
6516         * amd64-sol2-tdep.c: Fix common/ includes.
6517         * amd64-obsd-tdep.c: Fix common/ includes.
6518         * amd64-nbsd-tdep.c: Fix common/ includes.
6519         * amd64-linux-tdep.c: Fix common/ includes.
6520         * amd64-linux-nat.c: Fix common/ includes.
6521         * amd64-fbsd-tdep.c: Fix common/ includes.
6522         * amd64-fbsd-nat.c: Fix common/ includes.
6523         * amd64-dicos-tdep.c: Fix common/ includes.
6524         * amd64-darwin-tdep.c: Fix common/ includes.
6525         * agent.c: Fix common/ includes.
6526         * ada-lang.h: Fix common/ includes.
6527         * ada-lang.c: Fix common/ includes.
6528         * aarch64-tdep.c: Fix common/ includes.
6529
6530 2019-01-25  Tom Tromey  <tom@tromey.com>
6531
6532         * common/create-version.sh: Use common/version.h.
6533
6534 2019-01-24  Pedro Alves  <palves@redhat.com>
6535
6536         * infrun.c (signal_stop, signal_print, signal_program)
6537         (signal_catch, signal_pass): Now arrays instead of pointers.
6538         (update_signals_program_target, do_target_resume)
6539         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6540         * linux-nat.c (linux_nat_target::pass_signals)
6541         (linux_nat_target::create_inferior, linux_nat_target::attach):
6542         Adjust.
6543         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6544         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6545         * procfs.c (procfs_target::pass_signals): Adjust.
6546         * record-full.c (record_full_target::resume): Adjust.
6547         * remote.c (remote_target::pass_signals)
6548         (remote_target::program_signals): Adjust.
6549         * target-debug.h (target_debug_print_signals): Now takes a
6550         gdb::array_view as parameter.  Adjust.
6551         * target.h (target_ops) <pass_signals, program_signals>: Replace
6552         pointer and length parameters with gdb::array_view.
6553         (target_pass_signals, target_program_signals): Likewise.
6554         * target-delegates.c: Regenerate.
6555
6556 2019-01-24  Pedro Alves  <palves@redhat.com>
6557
6558         * common/forward-scope-exit.h
6559         (forward_scope_exit::forward_scope_exit): Pass arguments to
6560         m_bind_function directly, instead of creating a std::bind and
6561         copying that.
6562
6563 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6564
6565         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6566         for static members.
6567         (pass_in_v_vfp_candidate): Likewise.
6568
6569 2019-01-23  Tom Tromey  <tom@tromey.com>
6570             Pedro Alves  <palves@redhat.com>
6571
6572         * regcache.c (class regcache_invalidator): Remove.
6573         (regcache::raw_write): Use make_scope_exit.
6574
6575 2019-01-23  Tom Tromey  <tom@tromey.com>
6576
6577         * ui-out.h (class ui_out_emit_type): Update comment.
6578
6579 2019-01-23  Tom Tromey  <tom@tromey.com>
6580
6581         * infrun.c (fetch_inferior_event): Update comment.
6582
6583 2019-01-23  Tom Tromey  <tom@tromey.com>
6584             Pedro Alves  <palves@redhat.com>
6585
6586         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6587         parameter.
6588         (fetch_inferior_event): Use SCOPE_EXIT.
6589
6590
6591 2019-01-23  Tom Tromey  <tom@tromey.com>
6592             Pedro Alves  <palves@redhat.com>
6593
6594         * infrun.c (disable_thread_events): Delete.
6595         (stop_all_threads): Use SCOPE_EXIT.
6596
6597 2019-01-23  Tom Tromey  <tom@tromey.com>
6598             Pedro Alves  <palves@redhat.com>
6599
6600         * symfile.c: Include forward-scope-exit.h.
6601         (clear_symtab_users_cleanup): Replace forward declaration with
6602         a FORWARD_SCOPE_EXIT.
6603         (syms_from_objfile_1): Use the forward_scope_exit and
6604         gdb::optional instead of cleanup_function.
6605         (reread_symbols): Use the forward_scope_exit instead of
6606         cleanup_function.
6607         (clear_symtab_users_cleanup): Remove function.
6608
6609 2019-01-23  Tom Tromey  <tom@tromey.com>
6610             Pedro Alves  <palves@redhat.com>
6611
6612         * linux-nat.c: Include scope-exit.h.
6613         (cleanup_target_stop): Remove.
6614         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6615         SCOPE_EXIT.
6616
6617 2019-01-23  Tom Tromey  <tom@tromey.com>
6618             Pedro Alves  <palves@redhat.com>
6619
6620         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6621         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6622
6623 2019-01-23  Tom Tromey  <tom@tromey.com>
6624             Andrew Burgess  <andrew.burgess@embecosm.com>
6625             Pedro Alves  <palves@redhat.com>
6626
6627         * infrun.c (fetch_inferior_event): Use scope_exit.
6628         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6629         * top.c (execute_command): Use scope_exit.
6630         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6631         * utils.c (do_bpstat_clear_actions_cleanup)
6632         (make_bpstat_clear_actions_cleanup): Remove.
6633
6634 2019-01-23  Tom Tromey  <tom@tromey.com>
6635             Pedro Alves  <palves@redhat.com>
6636
6637         * infrun.c: Include "common/scope-exit.h"
6638         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6639         (wait_for_inferior): Use SCOPE_EXIT.
6640         (fetch_inferior_event): Use scope_exit.
6641
6642 2019-01-23  Tom Tromey  <tom@tromey.com>
6643             Pedro Alves  <palves@redhat.com>
6644
6645         * breakpoint.c (create_breakpoint): Remove cleanup.
6646
6647 2019-01-23  Tom Tromey  <tom@tromey.com>
6648             Andrew Burgess  <andrew.burgess@embecosm.com>
6649             Pedro Alves  <palves@redhat.com>
6650
6651 2019-01-23  Pedro Alves  <palves@redhat.com>
6652
6653         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6654
6655 2019-01-23  Pedro Alves  <palves@redhat.com>
6656             Andrew Burgess  <andrew.burgess@embecosm.com>
6657
6658         * gdbthread.h: Include "common/forward-scope-exit.h".
6659         (scoped_finish_thread_state): Redefine custom class in terms of
6660         forward_scope_exit.
6661
6662 2019-01-23  Pedro Alves  <palves@redhat.com>
6663             Andrew Burgess  <andrew.burgess@embecosm.com>
6664
6665         * common/forward-scope-exit.h: New file.
6666
6667 2019-01-23  Pedro Alves  <palves@redhat.com>
6668             Andrew Burgess  <andrew.burgess@embecosm.com>
6669             Tom Tromey  <tom@tromey.com>
6670
6671         * common/scope-exit.h: New file.
6672
6673 2019-01-23  Pedro Alves  <palves@redhat.com>
6674
6675         * common/preprocessor.h (ESC): Rename to ...
6676         (ESC_PARENS): ... this.
6677         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6678         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6679
6680 2019-01-23  Tom Tromey  <tom@tromey.com>
6681
6682         * language.h (class scoped_switch_to_sym_language_if_auto):
6683         Initialize m_lang in both cases.
6684
6685 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6686
6687         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6688         with XCNEW.
6689
6690 2019-01-22  Tom Tromey  <tom@tromey.com>
6691
6692         * corelow.c: Do not include sys/file.h.
6693
6694 2019-01-22  Tom Tromey  <tom@tromey.com>
6695
6696         * tui/tui-wingeneral.h: Include gdb_curses.h.
6697
6698 2019-01-22  Tom Tromey  <tom@tromey.com>
6699
6700         * source-cache.h (class source_cache) <get_source_lines,
6701         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6702
6703 2019-01-22  Tom Tromey  <tom@tromey.com>
6704
6705         * remote-fileio.h (struct remote_target): Declare.
6706
6707 2019-01-22  Tom Tromey  <tom@tromey.com>
6708
6709         * python/py-arch.c: Do not include py-ref.h.
6710         * python/py-bpevent.c: Do not include py-ref.h.
6711         * python/py-cmd.c: Do not include py-ref.h.
6712         * python/py-continueevent.c: Do not include py-ref.h.
6713         * python/py-event.h: Do not include py-ref.h.
6714         * python/py-evtregistry.c: Do not include py-ref.h.
6715         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6716         * python/py-frame.c: Do not include py-ref.h.
6717         * python/py-framefilter.c: Do not include py-ref.h.
6718         * python/py-function.c: Do not include py-ref.h.
6719         * python/py-infevents.c: Do not include py-ref.h.
6720         * python/py-linetable.c: Do not include py-ref.h.
6721         * python/py-objfile.c: Do not include py-ref.h.
6722         * python/py-param.c: Do not include py-ref.h.
6723         * python/py-prettyprint.c: Do not include py-ref.h.
6724         * python/py-progspace.c: Do not include py-ref.h.
6725         * python/py-symbol.c: Do not include py-ref.h.
6726         * python/py-symtab.c: Do not include py-ref.h.
6727         * python/py-type.c: Do not include py-ref.h.
6728         * python/py-unwind.c: Do not include py-ref.h.
6729         * python/py-utils.c: Do not include py-ref.h.
6730         * python/py-value.c: Do not include py-ref.h.
6731         * python/py-varobj.c: Do not include py-ref.h.
6732         * python/py-xmethods.c: Do not include py-ref.h.
6733         * python/python.c: Do not include py-ref.h.
6734         * varobj.c: Do not include py-ref.h.
6735
6736 2019-01-22  Tom Tromey  <tom@tromey.com>
6737
6738         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6739         keyword for bcache.
6740
6741 2019-01-22  Tom Tromey  <tom@tromey.com>
6742
6743         * compile/compile-cplus-types.c: Remove a comment by #include.
6744
6745 2019-01-22  Tom Tromey  <tom@tromey.com>
6746
6747         * compile/gcc-c-plugin.h: Include compile-internal.h.
6748
6749 2019-01-22  Tom Tromey  <tom@tromey.com>
6750
6751         * stabsread.c (EXTERN): Do not define.
6752         (symnum, next_symbol_text_func, processing_gcc_compilation)
6753         (within_function, global_sym_chain, global_stabs)
6754         (previous_stab_code, this_object_header_files)
6755         (n_this_object_header_files)
6756         (n_allocated_this_object_header_files): Define.
6757         * stabsread.h (EXTERN): Never define.  Use "extern".
6758
6759 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6760
6761         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6762         history_value.
6763
6764 2019-01-21  Tom Tromey  <tom@tromey.com>
6765
6766         * ui-out.c: Fix includes.
6767         * tui/tui-source.c: Fix includes.
6768         * target.c: Fix includes.
6769         * remote.c: Fix includes.
6770         * regcache.c: Fix includes.
6771         * python/py-block.c: Fix includes.
6772         * printcmd.c: Fix includes.
6773         * or1k-tdep.c: Fix includes.
6774         * mi/mi-main.c: Fix includes.
6775         * m32r-tdep.c: Fix includes.
6776         * csky-tdep.c: Fix includes.
6777         * compile/compile-cplus-types.c: Fix includes.
6778         * cli/cli-interp.c: Fix includes.
6779
6780 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6781
6782         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6783         for padding.
6784
6785 2019-01-16  Tom Tromey  <tom@tromey.com>
6786
6787         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6788         earlier.
6789         (struct objfile) <msymbols_range>: Move from top level.
6790         <msymbols>: New method.
6791         (class objfile_msymbols): Remove.
6792         * symtab.c (default_collect_symbol_completion_matches_break_on):
6793         Update.
6794         * symmisc.c (dump_msymbols): Update.
6795         * stabsread.c (scan_file_globals): Update.
6796         * objc-lang.c (info_selectors_command, info_classes_command)
6797         (find_methods): Update.
6798         * minsyms.c (find_solib_trampoline_target): Update.
6799         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6800         * coffread.c (coff_symfile_read): Update.
6801         * ada-lang.c (ada_lookup_simple_minsym)
6802         (ada_collect_symbol_completion_matches): Update.
6803
6804 2019-01-16  Tom Tromey  <tom@tromey.com>
6805
6806         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6807         type.  Remove no-argument constructor.
6808         <iterator::operator++>: Simplify.
6809         <begin>: Update.
6810         <end>: Use minimal_symbol_count.
6811
6812 2019-01-16  Tom Tromey  <tom@tromey.com>
6813
6814         * objfiles.h (struct objfile) <psymtabs>: New method.
6815         (class objfile_psymtabs): Remove.
6816         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6817         typedef.
6818         <range>: New method.
6819         (require_partial_symbols): Change return type.
6820         * psymtab.c (require_partial_symbols)
6821         (psym_expand_symtabs_matching): Update.
6822         * mdebugread.c (parse_partial_symbols): Update.
6823         * dbxread.c (dbx_end_psymtab): Update.
6824
6825 2019-01-15  Tom Tromey  <tom@tromey.com>
6826
6827         * symtab.c (lookup_objfile_from_block)
6828         (lookup_symbol_in_objfile_symtabs)
6829         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6830         (find_line_symtab, info_sources_command)
6831         (default_collect_symbol_completion_matches_break_on)
6832         (make_source_files_completion_list): Update.
6833         * symmisc.c (print_objfile_statistics, dump_objfile)
6834         (maintenance_print_symbols, maintenance_info_symtabs)
6835         (maintenance_check_symtabs, maintenance_info_line_tables):
6836         Update.
6837         * source.c (select_source_symtab)
6838         (forget_cached_source_info_for_objfile): Update.
6839         * objfiles.h (class objfile_compunits): Remove.
6840         (struct objfile) <compunits_range>: New typedef.
6841         (compunits): New method.
6842         * objfiles.c (objfile_relocate1): Update.
6843         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6844         * maint.c (count_symtabs_and_blocks): Update.
6845         * linespec.c (iterate_over_all_matching_symtabs): Update.
6846         * cp-support.c (add_symbol_overload_list_qualified): Update.
6847         * coffread.c (coff_symtab_read): Update.
6848         * ada-lang.c (add_nonlocal_symbols)
6849         (ada_collect_symbol_completion_matches)
6850         (ada_add_global_exceptions): Update.
6851
6852 2019-01-15  Tom Tromey  <tom@tromey.com>
6853
6854         * progspace.h (program_space) <objfiles_safe_range>: New
6855         typedef.
6856         <objfiles_safe>: New method.
6857         * objfiles.h (class all_objfiles_safe): Remove.
6858         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6859         * jit.c (jit_inferior_exit_hook): Update.
6860
6861 2019-01-17  Tom Tromey  <tom@tromey.com>
6862
6863         * progspace.h (program_space) <objfiles_range>: New typedef.
6864         <objfiles>: New method.
6865         <objfiles_head>: Rename from objfiles.
6866         (object_files): Update.
6867         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6868         * guile/scm-pretty-print.c
6869         (ppscm_find_pretty_printer_from_objfiles): Update.
6870         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6871         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6872         Update.
6873         * python/py-progspace.c (pspy_get_objfiles): Update.
6874         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6875         Update.
6876         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6877         (objfpy_lookup_objfile_by_build_id): Update.
6878         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6879         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6880         Update.
6881         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6882         (expand_symtab_containing_pc, lookup_objfile_from_block)
6883         (lookup_static_symbol, basic_lookup_transparent_type)
6884         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6885         (find_line_symtab, info_sources_command)
6886         (default_collect_symbol_completion_matches_break_on)
6887         (make_source_files_completion_list, find_main_name): Update.
6888         * symmisc.c (print_symbol_bcache_statistics)
6889         (print_objfile_statistics, maintenance_print_symbols)
6890         (maintenance_print_msymbols, maintenance_print_objfiles)
6891         (maintenance_info_symtabs, maintenance_check_symtabs)
6892         (maintenance_expand_symtabs, maintenance_info_line_tables):
6893         Update.
6894         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6895         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6896         (map_overlay_command, unmap_overlay_command)
6897         (simple_overlay_update, expand_symtabs_matching)
6898         (map_symbol_filenames): Update.
6899         * symfile-debug.c (set_debug_symfile): Update.
6900         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6901         Update.
6902         * source.c (select_source_symtab, forget_cached_source_info):
6903         Update.
6904         * solib.c (solib_read_symbols): Update.
6905         * solib-spu.c (append_ocl_sos): Update.
6906         * psymtab.c (maintenance_print_psymbols)
6907         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6908         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6909         * printcmd.c (info_symbol_command): Update.
6910         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6911         Update.
6912         * objfiles.h (class all_objfiles): Remove.
6913         * objfiles.c (have_partial_symbols, have_full_symbols)
6914         (have_minimal_symbols, qsort_cmp, update_section_map)
6915         (shared_objfile_contains_address_p)
6916         (default_iterate_over_objfiles_in_search_order): Update.
6917         * objc-lang.c (info_selectors_command, info_classes_command)
6918         (find_methods): Update.
6919         * minsyms.c (find_solib_trampoline_target): Update.
6920         * maint.c (maintenance_info_sections)
6921         (maintenance_translate_address, count_symtabs_and_blocks):
6922         Update.
6923         * main.c (captured_main_1): Update.
6924         * linux-thread-db.c (try_thread_db_load_from_pdir)
6925         (has_libpthread): Update.
6926         * linespec.c (iterate_over_all_matching_symtabs)
6927         (search_minsyms_for_name): Update.
6928         * jit.c (jit_find_objf_with_entry_addr): Update.
6929         * hppa-tdep.c (find_unwind_entry)
6930         (hppa_lookup_stub_minimal_symbol): Update.
6931         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6932         Update.
6933         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6934         (elf_gnu_ifunc_resolve_by_got): Update.
6935         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6936         * dwarf-index-write.c (save_gdb_index_command): Update.
6937         * cp-support.c (add_symbol_overload_list_qualified): Update.
6938         * breakpoint.c (create_overlay_event_breakpoint)
6939         (create_longjmp_master_breakpoint)
6940         (create_std_terminate_master_breakpoint)
6941         (create_exception_master_breakpoint): Update.
6942         * blockframe.c (find_pc_partial_function): Update.
6943         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6944         (ada_collect_symbol_completion_matches)
6945         (ada_add_global_exceptions): Update.
6946
6947 2019-01-17  Tom Tromey  <tom@tromey.com>
6948
6949         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6950         declare VEC.
6951         (solib_target_parse_libraries): Change return type.
6952         (library_list_start_segment, library_list_start_section)
6953         (library_list_end_library, library_list_start_library); Update.
6954         (solib_target_free_library_list): Remove.
6955         (solib_target_parse_libraries): Remove cleanup.  Change return
6956         type.
6957         (solib_target_current_sos): Update.
6958
6959 2019-01-17  Tom Tromey  <tromey@bapiya>
6960
6961         * valprint.c: Replace "the the" with "the".
6962         * symtab.c: Replace "the the" with "the".
6963         * solib.c: Replace "the the" with "the".
6964         * solib-dsbt.c: Replace "the the" with "the".
6965         * linespec.c: Replace "the the" with "the".
6966         * dwarf2loc.h: Replace "the the" with "the".
6967         * amd64-windows-tdep.c: Replace "the the" with "the".
6968         * aarch64-tdep.c: Replace "the the" with "the".
6969
6970 2019-01-16  Keith Seitz  <keiths@redhat.com>
6971
6972         PR gdb/23773
6973         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6974         <builder>: Rename to ..
6975         <m_builder>: ... this and make private.
6976         (dwarf2_cu::get_builder): New method.  Change all users of
6977         `builder' to use this method.
6978         (dwarf2_start_symtab): Move to ...
6979         (dwarf2_cu::start_symtab): ... here.  Update all callers
6980         (setup_type_unit_groups): Move to ...
6981         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6982         callers.
6983         (dwarf2_cu::reset_builder): New method.
6984         (process_full_compunit, process_full_type_unit): Use
6985         dwarf2_cu::reset_builder.
6986         (follow_die_offset): Record the ancestor CU if it is different
6987         from the followed DIE's CU.
6988         (follow_die_sig_1): Likewise.
6989
6990 2019-01-15  Tom Tromey  <tom@tromey.com>
6991
6992         * remote.c (class remote_state) <buf>: Now a char_vector.
6993         <buf_size>: Remove.
6994         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6995         parameter.
6996         (remote_target::getpkt_or_notif_sane_1)
6997         (remote_target::getpkt_sane)
6998         (remote_target::getpkt_or_notif_sane): Likewise.
6999         (class remote_target) <putpkt>: New overload.
7000         (remote_target::read_frame): Change type of "buf_p".  Remove
7001         sizeof_p parameter.
7002         (packet_ok): New overload.
7003         (packet_check_result): New overload.
7004         Update all uses.
7005
7006 2019-01-14  Tom Tromey  <tom@tromey.com>
7007
7008         * remote-notif.c (handle_notification, remote_notif_ack)
7009         (remote_notif_parse): Make "buf" const.
7010         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7011         const.
7012         (remote_notif_parse, remote_notif_ack, handle_notification):
7013         Likewise.
7014         * remote.c (remote_notif_stop_parse): Make "buf" const.
7015         (remote_target::remote_parse_stop_reply): Make "buf" const.
7016         (remote_notif_stop_ack): Make "buf" const.
7017
7018 2019-01-14  Tom Tromey  <tom@tromey.com>
7019
7020         * remote.c (remote_console_output): Make parameter const.
7021
7022 2019-01-14  Tom Tromey  <tom@tromey.com>
7023
7024         * target-debug.h (target_debug_print_signals): Constify.
7025         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7026         * procfs.c (procfs_target::pass_signals): Update.
7027         * linux-nat.c (linux_nat_target::pass_signals): Update.
7028         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7029         * target-delegates.c: Rebuild.
7030         * remote.c (remote_target::program_signals): Update.
7031         (remote_target::pass_signals): Update.
7032         * target.c (target_pass_signals): Constify argument.
7033         (target_program_signals): Likewise.
7034         * target.h (struct target_ops) <pass_signals, program_signals>:
7035         Constify argument.
7036         (target_pass_signals, target_program_signals): Constify argument.
7037
7038 2019-01-14  Tom Tromey  <tom@tromey.com>
7039
7040         PR tui/28819:
7041         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7042
7043 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7044
7045         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7046         field.
7047         * rs6000-tdep.c: Include reggroups.h.
7048         (IS_V_ALIAS_PSEUDOREG): Define.
7049         (rs6000_register_name): Return names for the "vX" aliases.
7050         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7051         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7052         aliases.  Call default_register_reggroup_p for all other
7053         pseudo-registers.
7054         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7055         New functions.
7056         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7057         Handle "vX" aliases.
7058         (v_alias_pseudo_register_collect): New function.
7059         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7060         (rs6000_gdbarch_init): Initialize "vX" aliases as
7061         pseudo-registers.  Restore registration of
7062         rs6000_pseudo_register_reggroup_p with
7063         set_tdesc_pseudo_register_reggroup_p.
7064
7065 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7066
7067         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7068         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7069         set_gdbarch_num_pseudo_regs.
7070
7071 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7072
7073         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7074         Remove arg prefixname, add do_set and do_show.
7075         Add member functions set_list and show_list.
7076         * cli/cli-style.c (class cli_style_option): Update accordingly.
7077         (style_set_list): Move to file scope.
7078         (style_show_list): Likewise.
7079         (set_style): Call help_list.
7080         (show_style): Call cmd_show_list.
7081         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7082         Update to use the new macro.
7083
7084 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7085
7086         * ada-lang.c (_initialize_ada_language): Expand the help text
7087         for the "catch exception" command.
7088
7089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7090
7091         * symtab.c (matching_obj_sections): Initialize obj,
7092         declare it closer to its usage.
7093
7094 2019-01-10  Tom Tromey  <tom@tromey.com>
7095
7096         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7097         (basic_inf_threads_range): Remove.
7098         (inf_threads_range, inf_non_exited_threads_range)
7099         (safe_inf_threads_range): Use next_adapter.
7100
7101 2019-01-10  Keith Seitz  <keiths@redhat.com>
7102
7103         PR gdb/23712
7104         PR symtab/23010
7105         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7106         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7107
7108 2019-01-10  Keith Seitz  <keiths@redhat.com>
7109
7110         PR gdb/23712
7111         PR symtab/23010
7112         * dictionary.c (pending_to_vector): Remove.
7113         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7114         Remove _1 suffix, replacing functions of the same name.  Update
7115         all callers.
7116         (dict_create_hashed, dict_create_hashed_expandable)
7117         (dict_create_linear, dict_create_linear_expandable, dict_free)
7118         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7119         Make functions static.
7120
7121 2019-01-10  Keith Seitz  <keiths@redhat.com>
7122
7123         PR gdb/23712
7124         PR symtab/23010
7125         * dictionary.h (struct dictionary): Replace declaration with
7126         multidictionary.
7127         (dict_create_hashed, dict_create_hashed_expandable)
7128         (dict_create_linear, dict_create_linear_expandable)
7129         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7130         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7131         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7132         taking multidictionary argument.
7133         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7134         * block.h (struct block) <dict>: Change to multidictionary
7135         and rename `multidict'.
7136         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7137         symmisc.c: Update all dictionary references to multidictionary.
7138
7139 2019-01-10  Keith Seitz  <keiths@redhat.com>
7140
7141         PR gdb/23712
7142         PR symtab/23010
7143         * dictionary.c: Include unordered_map.
7144         (pending_to_vector): New function.
7145         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7146         Rewrite the non-"_1" functions to take vector instead
7147         of linked list.
7148         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7149         "new" _1 versions of the same name.
7150         (multidictionary): Define.
7151         (std::hash<enum language): New definition.
7152         (collate_pending_symbols_by_language, mdict_create_hashed)
7153         (mdict_create_hashed_expandable, mdict_create_linear)
7154         (mdict_create_linear_expandable, mdict_free)
7155         (find_language_dictionary, create_new_language_dictionary)
7156         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7157         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7158         (mdict_size, mdict_empty): New functions.
7159         * dictionary.h (mdict_iterator): Define.
7160
7161 2019-01-10  Pedro Alves  <palves@redhat.com>
7162
7163         * breakpoint.c (read_uploaded_action)
7164         (create_tracepoint_from_upload): Adjust to use
7165         gdb::unique_xmalloc_ptr.
7166         * ctf.c (ctf_write_uploaded_tp):
7167         (SET_ARRAY_FIELD): Use emplace_back.
7168         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7169         * tracefile-tfile.c (tfile_write_uploaded_tp):
7170         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7171         gdb::unique_xmalloc_ptr.
7172         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7173         at_string, cond_string, cmd_strings>: Replace char pointers
7174         with gdb::unique_xmalloc_ptr.
7175
7176 2019-01-10  Pedro Alves  <palves@redhat.com>
7177
7178         * solib-target.c (library_list_start_library): Don't xstrdup name.
7179
7180 2019-01-10  Pedro Alves  <palves@redhat.com>
7181
7182         * mdebugread.c (parse_partial_symbols): Use
7183         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7184
7185 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * linux-fork.c (scoped_switch_fork_info)
7188         <~scoped_switch_fork_info>: Fix incorrect variable name.
7189
7190 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7191
7192         * linux-fork.c (scoped_switch_fork_info)
7193         <scoped_switch_fork_info>: Make explicit.
7194         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7195
7196 2019-01-10  Tom Tromey  <tom@tromey.com>
7197
7198         * objfiles.h (objfile::reset_psymtabs): Update.
7199         * objfiles.c (objfile::objfile): Update.
7200         * psymtab.h (psymtab_storage::obstack): Update.
7201         (psymtab_storage::m_obstack): Use gdb::optional.
7202         (class psymtab_storage): Update comment.  Remove objfile
7203         parameter.
7204         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7205
7206 2019-01-10  Tom Tromey  <tom@tromey.com>
7207
7208         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7209         <free_psymtabs>: Now private.
7210         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7211         (allocate_psymtab): Use new method.
7212
7213 2019-01-10  Tom Tromey  <tom@tromey.com>
7214
7215         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7216         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7217         * mdebugread.c (parse_partial_symbols): Use
7218         allocate_dependencies.
7219         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7220         allocate_dependencies.
7221         (process_psymtab_comp_unit_reader)
7222         (build_type_psymtab_dependencies): Likewise.
7223         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7224
7225 2019-01-10  Tom Tromey  <tom@tromey.com>
7226
7227         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7228         PSYMBOL_SET_LANGUAGE.
7229         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7230
7231 2019-01-10  Tom Tromey  <tom@tromey.com>
7232
7233         * psymtab.h (psymtab_storage::obstack): New method.
7234         <m_obstack>: Rename from obstack; now private.
7235         * psymtab.c (psymtab_storage): Update.
7236         * dwarf2read.c (create_addrmap_from_index)
7237         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7238         Update.
7239
7240 2019-01-10  Tom Tromey  <tom@tromey.com>
7241
7242         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7243         * objfiles.h (objfile::reset_psymtabs): New method.
7244
7245 2019-01-10  Tom Tromey  <tom@tromey.com>
7246
7247         * symmisc.c (print_symbol_bcache_statistics): Update.
7248         (print_objfile_statistics): Update.
7249         * symfile.c (reread_symbols): Update.
7250         * psymtab.h (class psymtab_storage): New.
7251         * psymtab.c (psymtab_storage): New constructor.
7252         (~psymtab_storage): New destructor.
7253         (require_partial_symbols): Update.
7254         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7255         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7256         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7257         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7258         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7259         (start_psymtab_common, end_psymtab_common)
7260         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7261         (allocate_psymtab): Update.
7262         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7263         Update.
7264         (dump_psymtab_addrmap, maintenance_print_psymbols)
7265         (maintenance_check_psymtabs): Update.
7266         (class objfile_psymtabs): Move to objfiles.h.
7267         * psympriv.h (discard_psymtab): Now inline.
7268         (psymtab_discarder::psymtab_discarder): Update.
7269         (psymtab_discarder::~psymtab_discarder): Update.
7270         (ALL_OBJFILE_PSYMTABS): Rewrite.
7271         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7272         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7273         Remove fields.
7274         <partial_symtabs>: New field.
7275         (class objfile_psymtabs): Move from psymtab.h.  Update.
7276         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7277         psymbol_cache.
7278         (objfile::~objfile): Don't destroy psymbol_cache.
7279         * mdebugread.c (parse_partial_symbols): Update.
7280         * dwarf2read.c (create_addrmap_from_index)
7281         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7282         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7283         (add_partial_subprogram, dwarf2_ranges_read): Update.
7284         * dwarf-index-write.c (write_address_map)
7285         (write_one_signatured_type, recursively_write_psymbols)
7286         (class debug_names, class debug_names, write_psymtabs_to_index):
7287         Update.
7288
7289 2019-01-10  Tom Tromey  <tom@tromey.com>
7290
7291         * symtab.h (SYMBOL_SET_NAMES): Update.
7292         (symbol_set_names): Update.
7293         (MSYMBOL_SET_NAMES): Update.
7294         * symtab.c (symbol_set_names): Change argument to be an
7295         objfile_per_bfd_storage.
7296         * psymtab.c (add_psymbol_to_bcache): Update.
7297         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7298
7299 2019-01-10  Tom Tromey  <tom@tromey.com>
7300
7301         * symtab.c (create_demangled_names_hash): Change argument to be an
7302         objfile_per_bfd_storage.
7303         (symbol_set_names): Update.
7304
7305 2019-01-10  Tom Tromey  <tom@tromey.com>
7306
7307         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7308         init_psymbol_list.
7309         * psymtab.c (init_psymbol_list): Do nothing if already called.
7310         * psympriv.h (init_psymbol_list): Add comment.
7311         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7312         init_psymbol_list.
7313         * dbxread.c (dbx_symfile_read): Unconditionally call
7314         init_psymbol_list.
7315
7316 2019-01-10  Tom Tromey  <tom@tromey.com>
7317
7318         * xcoffread.c (scan_xcoff_symtab): Update.
7319         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7320         "where".
7321         * mdebugread.c (parse_partial_symbols)
7322         (handle_psymbol_enumerators): Update.
7323         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7324         * dbxread.c (read_dbx_symtab): Update.
7325         * psympriv.h (psymbol_placement): New enum.
7326         (add_psymbol_to_list): Update.
7327
7328 2019-01-10  Tom Tromey  <tom@tromey.com>
7329
7330         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7331         static_psymbols parameters.
7332         (scan_xcoff_symtab): Update.
7333         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7334         static_psymbols parameters.
7335         * psympriv.h (start_psymtab_common): Update.
7336         * mdebugread.c (parse_partial_symbols): Update.
7337         * dwarf2read.c (create_partial_symtab): Update.
7338         * dbxread.c (read_dbx_symtab): Update.
7339         (start_psymtab): Remove global_psymbols and static_psymbols
7340         parameters.
7341
7342 2019-01-10  Tom Tromey  <tom@tromey.com>
7343
7344         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7345         * psymtab.c (allocate_psymtab): Add comment.
7346         * psympriv.h (allocate_psymtab): Add comment.
7347         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7348         initializations.
7349         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7350
7351 2019-01-10  Tom Tromey  <tom@tromey.com>
7352
7353         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7354         Don't declare.
7355         * mipsread.c: Include mdebugread.h.
7356         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7357         Declare.
7358         * elfread.c: Include mdebugread.h.
7359
7360 2019-01-09  Tom Tromey  <tom@tromey.com>
7361
7362         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7363         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7364         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7365         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7366         (psym_lookup_symbol, psym_find_last_source_symtab)
7367         (psym_forget_cached_source_info, psym_print_stats)
7368         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7369         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7370         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7371         (psym_find_compunit_symtab_by_address)
7372         (maintenance_print_psymbols, maintenance_info_psymtabs)
7373         (maintenance_check_psymtabs): Use ranged for.
7374         * psymtab.h (class objfile_psymtabs): New.
7375         (require_partial_symbols): Return objfile_psymtabs.
7376         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7377
7378 2019-01-09  Tom Tromey  <tom@tromey.com>
7379
7380         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7381         (find_pc_mapped_section, list_overlays_command)
7382         (map_overlay_command, unmap_overlay_command)
7383         (simple_overlay_update): Use all_objfiles.
7384         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7385         * printcmd.c (info_symbol_command): Use all_objfiles.
7386         * objfiles.h (ALL_OBJSECTIONS): Remove.
7387         * maint.c (maintenance_translate_address): Use all_objfiles.
7388         * gcore.c (gcore_create_callback): Use all_objfiles.
7389         (objfile_find_memory_regions): Likewise.
7390
7391 2019-01-09  Tom Tromey  <tom@tromey.com>
7392
7393         * symtab.c (find_line_symtab, info_sources_command)
7394         (make_source_files_completion_list): Use objfile_compunits.
7395         * source.c (select_source_symtab): Use objfile_compunits.
7396         * objfiles.h (struct objfile): Update comment.
7397         (ALL_OBJFILES): Remove.
7398         (ALL_FILETABS): Remove.
7399         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7400         objfile_compunits.
7401
7402 2019-01-09  Tom Tromey  <tom@tromey.com>
7403
7404         * symmisc.c (print_objfile_statistics, dump_objfile)
7405         (maintenance_print_symbols): Use compunit_filetabs.
7406         * source.c (forget_cached_source_info_for_objfile): Use
7407         compunit_filetabs.
7408         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7409         (ALL_FILETABS): Use compunit_filetabs.
7410         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7411         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7412
7413 2019-01-09  Tom Tromey  <tom@tromey.com>
7414
7415         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7416         (compunit_filetabs): New.
7417         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7418         compunit_filetabs.
7419         (info_sources_command, make_source_files_completion_list): Remove
7420         declaration.
7421         * symmisc.c (print_objfile_statistics, dump_objfile)
7422         (maintenance_print_symbols): Remove declaration.
7423         (maintenance_info_symtabs): Use compunit_filetabs.
7424         (maintenance_info_line_tables): Likewise.
7425         * source.c (select_source_symtab): Change local variable name.
7426         (forget_cached_source_info_for_objfile): Remove declaration.
7427         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7428         * objfiles.c (objfile_relocate1): Remove declaration.
7429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7430         declaration.
7431         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7432         * coffread.c (coff_symtab_read): Remove declaration.
7433         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7434         compunit_filetabs.
7435
7436 2019-01-09  Tom Tromey  <tom@tromey.com>
7437
7438         * symtab.c (lookup_objfile_from_block)
7439         (find_pc_sect_compunit_symtab, search_symbols)
7440         (default_collect_symbol_completion_matches_break_on): Use
7441         objfile_compunits.
7442         * objfiles.h (ALL_COMPUNITS): Remove.
7443         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7444         * cp-support.c (add_symbol_overload_list_qualified): Use
7445         objfile_compunits.
7446         * ada-lang.c (ada_collect_symbol_completion_matches)
7447         (ada_add_global_exceptions): Use objfile_compunits.
7448
7449 2019-01-09  Tom Tromey  <tom@tromey.com>
7450
7451         * source.c (select_source_symtab)
7452         (forget_cached_source_info_for_objfile): Remove declaration.
7453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7454         declaration.
7455         * maint.c (count_symtabs_and_blocks): Remove declaration.
7456         * cp-support.c (add_symbol_overload_list_qualified): Remove
7457         declaration.
7458         * coffread.c (coff_symtab_read): Remove declaration.
7459         * symtab.c (lookup_symbol_in_objfile_symtabs)
7460         (basic_lookup_transparent_type_1): Use objfile_compunits.
7461         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7462         (info_sources_command, search_symbols)
7463         (default_collect_symbol_completion_matches_break_on)
7464         (make_source_files_completion_list): Remove declaration.
7465         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7466         (ada_collect_symbol_completion_matches)
7467         (ada_add_global_exceptions): Remove declaration.
7468         * linespec.c (iterate_over_all_matching_symtabs): Use
7469         objfile_compunits.
7470         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7471         (class objfile_compunits): New.
7472         (ALL_COMPUNITS): Use objfile_compunits.
7473         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7474         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7475         objfile_compunits.
7476         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7477
7478 2019-01-09  Tom Tromey  <tom@tromey.com>
7479
7480         * symtab.c (search_symbols)
7481         (default_collect_symbol_completion_matches_break_on): Use
7482         objfile_msymbols.
7483         * ada-lang.c (ada_lookup_simple_minsym)
7484         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7485         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7486         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7487         objfile_msymbols.
7488         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7489         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7490         * objc-lang.c (find_methods): Use objfile_msymbols.
7491         (info_selectors_command, info_classes_command): Likewise.
7492         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7493         * objfiles.h (class objfile_msymbols): New.
7494         (ALL_OBJFILE_MSYMBOLS): Remove.
7495         (ALL_MSYMBOLS): Remove.
7496
7497 2019-01-09  Tom Tromey  <tom@tromey.com>
7498
7499         * common/next-iterator.h (next_adapter): Add Iterator template
7500         parameter.
7501         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7502         (class all_objfiles_safe): New.
7503         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7504         * objfiles.c (put_objfile_before): Update comment.
7505         (add_separate_debug_objfile): Likewise.
7506         (free_all_objfiles): Use all_objfiles_safe.
7507         (objfile_purge_solibs): Likewise.
7508
7509 2019-01-09  Tom Tromey  <tom@tromey.com>
7510
7511         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7512         (expand_symtab_containing_pc, lookup_static_symbol)
7513         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7514         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7515         all_objfiles.
7516         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7517         * breakpoint.c (create_overlay_event_breakpoint)
7518         (create_longjmp_master_breakpoint)
7519         (create_std_terminate_master_breakpoint)
7520         (create_exception_master_breakpoint): Use all_objfiles.
7521         * linux-thread-db.c (try_thread_db_load_from_pdir)
7522         (has_libpthread): Use all_objfiles.
7523         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7524         * linespec.c (iterate_over_all_matching_symtabs)
7525         (search_minsyms_for_name): Use all_objfiles.
7526         * maint.c (maintenance_info_sections): Use all_objfiles.
7527         * main.c (captured_main_1): Use all_objfiles.
7528         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7529         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7530         * guile/scm-pretty-print.c
7531         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7532         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7533         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7534         (maintenance_print_msymbols): Use all_objfiles.
7535         * source.c (select_source_symtab): Use all_objfiles.
7536         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7537         * symfile.c (remove_symbol_file_command)
7538         (expand_symtabs_matching, map_symbol_filenames): Use
7539         all_objfiles.
7540         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7541         all_objfiles.
7542         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7543         * objc-lang.c (find_methods): Use all_objfiles.
7544         * objfiles.c (have_partial_symbols, have_full_symbols)
7545         (have_minimal_symbols, qsort_cmp)
7546         (default_iterate_over_objfiles_in_search_order): Use
7547         all_objfiles.
7548         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7549         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7550         (maintenance_check_psymtabs): Use all_objfiles.
7551         (ALL_PSYMTABS): Remove.
7552         * compile/compile-object-run.c (do_module_cleanup): Use
7553         all_objfiles.
7554         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7555         * cp-support.c (add_symbol_overload_list_qualified): Use
7556         all_objfiles.
7557         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7558         Use all_objfiles.
7559         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7560         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7561         all_objfiles.
7562         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7563         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7564         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7565         Uses all_objfiles.
7566         * solib.c (solib_read_symbols): Use all_objfiles
7567
7568 2019-01-09  Tom Tromey  <tom@tromey.com>
7569
7570         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7571         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7572         all_objfiles.
7573         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7574         * symmisc.c (print_symbol_bcache_statistics)
7575         (print_objfile_statistics, maintenance_print_objfiles)
7576         (maintenance_info_symtabs, maintenance_check_symtabs)
7577         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7578         all_objfiles.
7579         * source.c (forget_cached_source_info): Use all_objfiles.
7580         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7581         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7582         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7583         * objfiles.c (update_section_map): Use all_objfiles.
7584         (shared_objfile_contains_address_p): Likewise.
7585         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7586         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7587
7588 2019-01-09  Tom Tromey  <tom@tromey.com>
7589
7590         * common/next-iterator.h: New file.
7591         * objfiles.h (class all_objfiles): New.
7592         (struct objfile_iterator): New.
7593
7594 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7595
7596         * NEWS: Move the description of the changed "frame", "select-frame",
7597          and "info frame" commands to the Changed commands section.
7598
7599 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7600
7601         * gdbtypes.c (check_stub_method_group): Remove handling of old
7602         mangling schemes.
7603         * linespec.c (find_methods): Likewise.
7604         * stabsread.c (read_member_functions): Likewise.
7605         * valops.c (search_struct_method): Likewise.
7606         (value_struct_elt_for_reference): Likewise.
7607         * NEWS: Mention this change.
7608
7609 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7612         print_source_lines.
7613         * source.c (print_source_lines_base): Update line number check.
7614         (print_source_lines): New function.
7615         (source_lines_range::source_lines_range): New function.
7616         * source.h (class source_lines_range): New class.
7617         (print_source_lines): New declaration.
7618
7619 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7620
7621         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7622
7623 2019-01-08  Tom Tromey  <tom@tromey.com>
7624             Simon Marchi  <simon.marchi@ericsson.com>
7625
7626         PR gdb/24060
7627         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7628         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7629         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7630         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7631         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7632         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7633
7634 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7635
7636         * source.c (select_source_symtab): Move header comment to
7637         declaration in source.h.
7638         (forget_cached_source_info_for_objfile): Likewise.
7639         (forget_cached_source_info): Likewise.
7640         (identify_source_line): Likewise.
7641         * source.h (identify_source_line): Move declaration from symtab.h
7642         and add comment from source.c
7643         (print_source_lines): Likewise.
7644         (forget_cached_source_info_for_objfile): Likewise.
7645         (forget_cached_source_info): Likewise.
7646         (select_source_symtab): Likewise.
7647         (enum print_source_lines_flag): Move definition from symtab.h.
7648         * symtab.h (identify_source_line): Move declaration to source.h.
7649         (print_source_lines): Likewise.
7650         (forget_cached_source_info_for_objfile): Likewise.
7651         (forget_cached_source_info): Likewise.
7652         (select_source_symtab): Likewise.
7653         (enum print_source_lines_flag): Move definition to source.h.
7654         * tui/tui-hooks.c: Add 'source.h' include.
7655
7656 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7657
7658         * source.c (print_source_lines_base): Handle requests to print
7659         reverse line number sequences, and guard against empty lines
7660         string.
7661
7662 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7663
7664         * source.c (print_source_lines_base): Fix skip of '\r' if next
7665         character is '\n'.
7666
7667 2019-01-06  Tom Tromey  <tom@tromey.com>
7668
7669         * c-exp.y (struct c_parse_state) <macro_original_text,
7670         expansion_obstack>: New member.
7671         (macro_original_text, expansion_obstack): Remove globals.
7672         (scan_macro_expansion, scanning_macro_expansion)
7673         (finished_macro_expansion): Update.
7674         (scan_macro_cleanup): Remove.
7675         (yylex, c_parse): Update.
7676
7677 2019-01-06  Tom Tromey  <tom@tromey.com>
7678
7679         * c-exp.y (struct c_parse_state) <strings>: New member.
7680         (operator_stoken): Update.
7681
7682 2019-01-06  Tom Tromey  <tom@tromey.com>
7683
7684         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7685         (union type_stack_elt) <typelist_val>: Now a pointer to
7686         std::vector.
7687         (type_stack_cleanup): Don't declare.
7688         (push_typelist): Update.
7689         * parse.c (pop_typelist): Return a std::vector.
7690         (push_typelist): Take a std::vector.
7691         (follow_types): Update.  Do not free args.
7692         (type_stack_cleanup): Remove.
7693         * c-exp.y (struct c_parse_state): New.
7694         (cpstate): New global.
7695         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7696         (nonempty_typelist): Update.
7697         (func_mod): Create a new vector.
7698         (c_parse): Create a c_parse_state.
7699         (check_parameter_typelist): Do not delete params.
7700         (function_method): Update.  Do not delete type_list.
7701
7702 2019-01-06  Tom Tromey  <tom@tromey.com>
7703
7704         PR gdb/28155:
7705         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7706         check_typedef.
7707         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7708         (print_return_value): Likewise.
7709
7710 2019-01-05  Tom Tromey  <tom@tromey.com>
7711
7712         * contrib/cleanup_check.py: Remove.
7713         * contrib/gcc-with-excheck: Remove.
7714         * contrib/exsummary.py: Remove.
7715         * contrib/excheck.py: Remove.
7716
7717 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7718
7719         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7720         NULL. Initialize tpprev to NULL instead of assigning it
7721         to NULL on the next statement.
7722         * windows-nat.c (windows_delete_thread): Remove check for
7723         main_thread_id before printing thread exit notifications.
7724         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7725         Remove thread ID check against main_thread_id.
7726         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7727         windows_delete_thread.
7728         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7729
7730 2019-01-04  Tom Tromey  <tom@tromey.com>
7731
7732         * compile/compile.c (_initialize_compile): Use upper case for
7733         metasyntactic variables.
7734         * symmisc.c (_initialize_symmisc): Use upper case for
7735         metasyntactic variables.
7736         * psymtab.c (_initialize_psymtab): Use upper case for
7737         metasyntactic variables.
7738         * demangle.c (demangle_command): Use upper case for metasyntactic
7739         variables.
7740         (_initialize_demangler): Likewise.
7741         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7742         variables.
7743
7744 2019-01-03  Tom Tromey  <tom@tromey.com>
7745
7746         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7747
7748 2019-01-03  Tom Tromey  <tom@tromey.com>
7749
7750         * python/py-symtab.c (salpy_str): Update.
7751         (struct salpy_sal_object) <symtab>: Now a PyObject.
7752         (salpy_dealloc): Update.
7753         (del_objfile_sal): Use gdbpy_ref.
7754
7755 2019-01-03  Tom Tromey  <tom@tromey.com>
7756
7757         * python/py-type.c (convert_field): Use new_reference.  Return
7758         gdbpy_ref.
7759         (make_fielditem): Return gdbpy_ref.
7760         (typy_fields): Update.
7761         (typy_getitem): Update.
7762         (field_name): Return gdbpy_ref.  Use new_reference.
7763         (typy_iterator_iternext): Update.
7764
7765 2019-01-03  Tom Tromey  <tom@tromey.com>
7766
7767         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7768
7769 2019-01-03  Tom Tromey  <tom@tromey.com>
7770
7771         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7772         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7773         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7774         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7775         (pspy_set_type_printers): Likewise.
7776         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7777         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7778         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7779         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7780         (objfpy_set_type_printers): Likewise.
7781
7782 2019-01-03  Tom Tromey  <tom@tromey.com>
7783
7784         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7785         (gdbpy_print_stack): Use gdbpy_err_fetch.
7786         * python/python-internal.h (class gdbpy_err_fetch): New class.
7787         (class gdbpy_enter) <m_error_type, m_error_value,
7788         m_error_traceback>: Remove.
7789         <m_error>: New member.
7790         (gdbpy_exception_to_string): Don't declare.
7791         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7792         * python/py-value.c (convert_value_from_python): Use
7793         gdbpy_err_fetch.
7794         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7795         gdbpy_exception_to_string.
7796         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7797         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7798         gdbpy_err_fetch.
7799
7800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * linux-nat.c (delete_lwp_cleanup): Delete.
7803         (struct lwp_deleter): New struct.
7804         (lwp_info_up): New typedef.
7805         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7806         lwp_info_up.
7807
7808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7809
7810         * linux-fork.c (class scoped_switch_fork_info): New class.
7811         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7812
7813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7814
7815         * valops.c (find_overload_match): Remove use of null_cleanup, and
7816         calls to do_cleanups.
7817
7818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7819
7820         * compile/compile-cplus-types.c
7821         (compile_cplus_instance::decl_name): Handle changes to
7822         cp_func_name.
7823         * cp-support.c (cp_func_name): Update header comment, update
7824         return type.
7825         * cp-support.h (cp_func_name): Update return type in declaration.
7826         * valops.c (find_overload_match): Move temp_func local to top
7827         level of function and change its type.  Use temp_func to hold and
7828         delete temporary string obtained from cp_func_name.
7829
7830 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7833         gdb::char_vector, remove cleanup, and update uses of `msg`.
7834
7835 2019-01-03  Jim Wilson  <jimw@sifive.com>
7836
7837         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7838
7839 2019-01-02  Tom Tromey  <tom@tromey.com>
7840
7841         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7842         (tdesc_parse_xml): Remove cleanups.
7843         * target-descriptions.h (make_cleanup_free_target_description):
7844         Don't declare.
7845         (target_desc_deleter): New struct.
7846         (target_desc_up): New typedef.
7847         * target-descriptions.c (target_desc_deleter::operator()): Rename
7848         from free_target_description.
7849         (make_cleanup_free_target_description): Remove.
7850
7851 2019-01-02  Tom Tromey  <tom@tromey.com>
7852
7853         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7854         constructor, destructor.
7855         (linespec_parser): Remove typedef.
7856         (~linespec_parser): Rename from linespec_parser_delete.
7857         (linespec_lex_to_end, linespec_complete_label)
7858         (linespec_complete): Update.
7859         (decode_line_full): Remove cleanups.
7860         (decode_line_1): Update.
7861
7862 2019-01-02  Tom Tromey  <tom@tromey.com>
7863
7864         * python/python-internal.h (inferior_to_inferior_object): Change
7865         return type.
7866         * python/py-exitedevent.c (create_exited_event_object): Update.
7867         * python/py-inferior.c (inferior_to_inferior_object): Return
7868         gdbpy_ref.
7869         (python_new_inferior, python_inferior_deleted)
7870         (thread_to_thread_object, delete_thread_object)
7871         (build_inferior_list, gdbpy_selected_inferior): Update.
7872         * python/py-infthread.c (create_thread_object): Update.  Also fail
7873         if inferior_to_inferior_object fails.
7874
7875 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7876
7877         * inferior.h (class inferior) <displaced_step_state>: New field.
7878         * infrun.h (struct displaced_step_state): Move here from
7879         infrun.c.  Initialize fields, add constructor.
7880         <inf>: Remove field.
7881         <reset>: New method.
7882         * infrun.c (struct displaced_step_inferior_state): Move to
7883         infrun.h.
7884         (displaced_step_inferior_states): Remove.
7885         (get_displaced_stepping_state): Adust.
7886         (displaced_step_in_progress_any_inferior): Adjust.
7887         (displaced_step_in_progress_thread): Adjust.
7888         (displaced_step_in_progress): Adjust.
7889         (add_displaced_stepping_state): Remove.
7890         (get_displaced_step_closure_by_addr): Adjust.
7891         (remove_displaced_stepping_state): Remove.
7892         (infrun_inferior_exit): Call displaced_step_state.reset.
7893         (use_displaced_stepping): Don't check for NULL.
7894         (displaced_step_prepare_throw): Call
7895         get_displaced_stepping_state.
7896         (displaced_step_fixup): Don't check for NULL.
7897         (prepare_for_detach): Don't check for NULL.
7898
7899 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7900
7901         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7902          in case of call that did not complete.
7903
7904 2019-01-02  Andrey Utkin  <autkin@undo.io>
7905
7906         * symfile.c (find_separate_debug_file): Fix search of debug files for
7907         remote debuggee.
7908
7909 2019-01-02  Tom Tromey  <tom@tromey.com>
7910
7911         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7912         indentation.
7913         * python/py-frame.c (frapy_older): Remove cast.
7914         (frapy_newer): Likewise.
7915         * python/py-breakpoint.c (local_setattro): Remove cast.
7916         * python/py-arch.c (archpy_name): Remove local variable.
7917         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7918
7919 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7920
7921         * unittests/basic_string_view/element_access/char/empty.cc:
7922         Fix year range in copyright header.
7923
7924 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7925
7926         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7927         Delete.
7928         <operator==>: Update with for removed field.
7929         <hash>: Likewise.
7930         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7931         <isa_features>: ...this.
7932         <abi_features>: New field.
7933         (riscv_isa_flen): Update comment.
7934         (riscv_abi_xlen): New declaration.
7935         (riscv_abi_flen): New declaration.
7936         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7937         isa_features.
7938         (riscv_abi_xlen): New function.
7939         (riscv_isa_flen): Update to get answer from isa_features.
7940         (riscv_abi_flen): New function.
7941         (riscv_has_fp_abi): Update to get answer from abi_features.
7942         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7943         xlen and flen.
7944         (riscv_call_info) <xlen, flen>: Update comment.
7945         (riscv_call_arg_struct): Remove invalid assertions
7946         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7947         is removed.
7948         (riscv_gdbarch_init): Gather isa features and abi features
7949         separately, ensure both match on the gdbarch when reusing an old
7950         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7951         a target with 64-bit float hardware.
7952
7953 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7954
7955         * source.c (search_command_helper): Stop reverse search
7956         when line 1 has been searched.
7957
7958 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7959
7960         * record-full.c (record_full_base_target::close): Rewrite
7961         record_full_core_buf_list free logic.
7962
7963 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964
7965         * break-catch-syscall.c (print_one_catch_syscall): xfree
7966         the last text.
7967
7968 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7969
7970         * top.c (print_gdb_version): Update Copyright year in version
7971         message.
7972
7973 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7974
7975         Update copyright year range in all GDB files.
7976
7977 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7978
7979         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7980
7981 For older changes see ChangeLog-2018.
7982 \f
7983 Local Variables:
7984 mode: change-log
7985 left-margin: 8
7986 fill-column: 74
7987 version-control: never
7988 coding: utf-8
7989 End:
7990